[Libreoffice-commits] core.git: onlineupdate/source
onlineupdate/source/update/updater/bspatch.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 337f8922edbdae7cb3e6659ea6bf3bde9ba8adb0 Author: Stephan BergmannDate: Tue Jan 16 08:51:10 2018 +0100 Missing include Change-Id: Id5c7ff8b9d342b557bc87b1ac6f3e2fbc8437d69 diff --git a/onlineupdate/source/update/updater/bspatch.cxx b/onlineupdate/source/update/updater/bspatch.cxx index 10ec56200511..b77d3ea1097b 100644 --- a/onlineupdate/source/update/updater/bspatch.cxx +++ b/onlineupdate/source/update/updater/bspatch.cxx @@ -32,6 +32,7 @@ #include "bspatch.h" #include "errors.h" +#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - include/svtools include/vcl
include/svtools/imapobj.hxx |1 - include/vcl/gdimtf.hxx |1 - 2 files changed, 2 deletions(-) New commits: commit 420059de8576693b23661c64e55792ae992780ef Author: Stephan BergmannDate: Mon Jan 15 21:35:32 2018 +0100 Remove unused GDI_METAFILE_LABEL_NOTFOUND ...unused since 22bd00fa7f6b90964e5eca03c314cdfa7ac2be12 "remove unused #defines METAFILE_END and METAFILE_LABEL_NOTFOUND" Change-Id: Ia9bcd4100f03c12c8e97b57cbfabfbf634248014 Reviewed-on: https://gerrit.libreoffice.org/47918 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/vcl/gdimtf.hxx b/include/vcl/gdimtf.hxx index 6785a7b9e3c3..2a0baaded027 100644 --- a/include/vcl/gdimtf.hxx +++ b/include/vcl/gdimtf.hxx @@ -41,7 +41,6 @@ class Gradient; #define GDI_METAFILE_END(size_t(0x)) -#define GDI_METAFILE_LABEL_NOTFOUND ((size_t)0x) enum class MtfConversion { commit 6c5a1601d2ef47723a130e73953dd569f2cc856f Author: Stephan Bergmann Date: Mon Jan 15 21:19:39 2018 +0100 Remove unused IMAP_OBJ_NONE ...no other traces of it apart from its definition in 2351b6d4ba452ed9a261541cd8581ad43788d4db "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to svtools/inc/svtools and correspondent necessary changes" Change-Id: I8a919b35f90acde5a72616b311a3e66c591c1e36 Reviewed-on: https://gerrit.libreoffice.org/47917 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/svtools/imapobj.hxx b/include/svtools/imapobj.hxx index 04da290dda0d..9e396842ccf8 100644 --- a/include/svtools/imapobj.hxx +++ b/include/svtools/imapobj.hxx @@ -28,7 +28,6 @@ class Point; namespace tools { class Rectangle; } class SvStream; -#define IMAP_OBJ_NONE ((sal_uInt16)0x) #define IMAP_OBJ_RECTANGLE (sal_uInt16(0x0001)) #define IMAP_OBJ_CIRCLE (sal_uInt16(0x0002)) #define IMAP_OBJ_POLYGON(sal_uInt16(0x0003)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115030] Writer import docx math fomula "dot" is translated as "acute"
https://bugs.documentfoundation.org/show_bug.cgi?id=115030 Mike Kaganskichanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- Confirmed with Version: 6.0.0.2 (x64) Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: The attachment 139118 contains element with having value of UTF-8 character CC87, which is Unicode Character 'COMBINING DOT ABOVE' (U+0307) - see http://www.fileformat.info/info/unicode/char/0307. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115013] Merge fields aren't substituted after saving/reopening DOC(X) with added mail merge fields, and running mail merge
https://bugs.documentfoundation.org/show_bug.cgi?id=115013 Mike Kaganskichanged: What|Removed |Added Status|UNCONFIRMED |NEW Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #4 from Mike Kaganski --- https://gerrit.libreoffice.org/47895 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/cuicharmap.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f1ec1b1f6e24fce5e496fd7c97c93884068dfba2 Author: Pranav KantDate: Tue Jan 16 12:27:56 2018 +0530 svx: chain up correctly for SvxCharacterMap::Execute() Change-Id: I2ff70f7b2ade8e2aad96cff31bd313822779094c diff --git a/cui/source/dialogs/cuicharmap.cxx b/cui/source/dialogs/cuicharmap.cxx index ef849a56f8d6..77df333aa0c4 100644 --- a/cui/source/dialogs/cuicharmap.cxx +++ b/cui/source/dialogs/cuicharmap.cxx @@ -172,7 +172,7 @@ short SvxCharacterMap::Execute() m_pOKBtn->Enable(); } -return ModalDialog::Execute(); +return SfxModalDialog::Execute(); } void SvxCharacterMap::dispose() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115030] Writer import docx math fomula "dot" is translated as "acute"
https://bugs.documentfoundation.org/show_bug.cgi?id=115030 Pierre Cchanged: What|Removed |Added Summary|Writer import docx math |Writer import docx math |fomula "dot" is translate |fomula "dot" is translated |as "acute" |as "acute" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77149] #6 envelope will not print (HP printer)
https://bugs.documentfoundation.org/show_bug.cgi?id=77149 --- Comment #7 from Darrell--- The problem as described occurs for me in 5.4.4.2, Build ID: 1:5.4.4~rc2-0ubuntu0.16.04.1~lo1 with an HP LaserJet Pro 200 Color. On Windows 10, Version 6.0.0.2 (x64), choosing a #6 3/4 envelope results in a User format 6.5" x 6.06" envelope "page"; changing that to # 6 3/4 envelope in the Page style dialog produces a page with the right dimensions, but the sender and addressee are placed incorrectly. In the Print dialog, after selecting the HP LaserJet Pro 200 Color as the printer, the preview shows a #8 envelope. There appears to be no way to specify that the printer actually contains a # 6 3/4 envelope. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112071] [META] Linked external data issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112071 Bug 112071 depends on bug 114998, which changed state. Bug 114998 Summary: Externally Linked Data should update when pressing F9 https://bugs.documentfoundation.org/show_bug.cgi?id=114998 What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114998] Externally Linked Data should update when pressing F9
https://bugs.documentfoundation.org/show_bug.cgi?id=114998 Dan Dascalescuchanged: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- Summary|Externally Linked Data does |Externally Linked Data |not update when pressing F9 |should update when pressing ||F9 Ever confirmed|0 |1 --- Comment #2 from Dan Dascalescu --- Whether we as developers think external links are formulas or not, from a user's perspective, external links *are* much like formulas. A user could be linking to a sheet of currency prices that are updated externally by a server, just like =WEBSERVICE would fetch that URL. Let's adopt a user-centric mindset and consider adding link update via F9 as a feature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105197] Video thumbnails pasted from web covered up by blank frame
https://bugs.documentfoundation.org/show_bug.cgi?id=105197 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101285] Manage Conditional Formatting dialog doesn' t remember position, column sizes, and range selection
https://bugs.documentfoundation.org/show_bug.cgi?id=101285 --- Comment #2 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91400] LibreOffice doesn’t use system font in =?UTF-8?Q?OS=20X=2010=2E10=2B=20?=(Helvetica Neue in Yosemite 10.10, San Francisco in El Capitan 10.11 and Sierra 10.12)
https://bugs.documentfoundation.org/show_bug.cgi?id=91400 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100188] Lost of CONDITIONAL FORMATTING with formula on refresh by macro with cell link with an another file
https://bugs.documentfoundation.org/show_bug.cgi?id=100188 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92418] On Mac OS X, Cmd-H should Hide LibreOffice even when a dialog window has focus, not open LibreOffice Help (repro steps comment #4)
https://bugs.documentfoundation.org/show_bug.cgi?id=92418 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103793] FORMATTING: Conditional formatting doesn' t respect category of number-format.
https://bugs.documentfoundation.org/show_bug.cgi?id=103793 --- Comment #2 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84670] Conditional formatting changes row height
https://bugs.documentfoundation.org/show_bug.cgi?id=84670 --- Comment #16 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99808] Conditional FORMATTING of connected cells: Background fills only first cell
https://bugs.documentfoundation.org/show_bug.cgi?id=99808 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115033] New: Fatal Error after update to 5.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=115033 Bug ID: 115033 Summary: Fatal Error after update to 5.4.3.2 Product: LibreOffice Version: 5.4.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: campbellma...@xtra.co.nz Description: After update to 5.4.3.2. when "update" of a documents index is requested the following error message appears and file crashes. "Fatal Error" invalid vector subscript Using Libre writer in Windows 10 Actual Results: "Fatal Error" invalid vector subscript Expected Results: update of index Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115017] SVG images are clipped incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=115017 Regina Henschelchanged: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- Created attachment 139119 --> https://bugs.documentfoundation.org/attachment.cgi?id=139119=edit reduced file, which still shows the error It has nothing to do with the position of the clipPath definition. I have moved it to the begin and removed all elements, so that it is on same level as the referencing element and known before used. I think it is similar to bug 97657: The clip-path attribute is not supported. It makes no difference, whether you use a path or rect for the clipPath. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112120] Gallery showing nothing when Chemical laboratory extension installed
https://bugs.documentfoundation.org/show_bug.cgi?id=112120 Volgachanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Volga --- OK, I update to 2.1 and Gallery works for me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114995] Link to External Data doesn't support Text Import from CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=114995 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG --- Comment #1 from m.a.riosv --- Link to external data it's not for import csv files, they are raw text. You can use Menu/Sheet/Insert sheet from file, keeping the link if you like. Then it can be updated through Menu/Edit/Link Even they can be treated as a spreadsheet, referencing it directly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112071] [META] Linked external data issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112071 Bug 112071 depends on bug 114995, which changed state. Bug 114995 Summary: Link to External Data doesn't support Text Import from CSV https://bugs.documentfoundation.org/show_bug.cgi?id=114995 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: download.lst external/harfbuzz
download.lst |4 external/harfbuzz/UnpackedTarball_harfbuzz.mk |2 external/harfbuzz/revert-make-inert.patch | 200 -- 3 files changed, 2 insertions(+), 204 deletions(-) New commits: commit 3b773d5b41628c1ccf52bdd0d7962183d54c4138 Author: Khaled HosnyDate: Mon Jan 15 15:22:13 2018 +0200 Upload HarfBuzz 1.7.4 Change-Id: I7dd1f87dc95d0fb190755a8742d28ef8679d7b1e Reviewed-on: https://gerrit.libreoffice.org/47897 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/download.lst b/download.lst index f574617147c9..ae825299d6cf 100644 --- a/download.lst +++ b/download.lst @@ -94,8 +94,8 @@ export GPGME_SHA256SUM := 1b29fedb8bfad775e70eafac5b0590621683b2d9869db994568e64 export GPGME_TARBALL := gpgme-1.9.0.tar.bz2 export GRAPHITE_SHA256SUM := aa5e58356cd084000609ebbd93fef456a1bc0ab9e46fea20e81552fb286232a9 export GRAPHITE_TARBALL := graphite2-minimal-1.3.10.tgz -export HARFBUZZ_SHA256SUM := 042742d6ec67bc6719b69cf38a3fba24fbd120e207e3fdc18530dc730fb6a029 -export HARFBUZZ_TARBALL := harfbuzz-1.7.0.tar.bz2 +export HARFBUZZ_SHA256SUM := b5d6ac8415f97f3540d73f3f91c41c5c10f8a4d76350f11a7184062aae88ac0b +export HARFBUZZ_TARBALL := harfbuzz-1.7.4.tar.bz2 export HSQLDB_SHA256SUM := d30b13f4ba2e3b6a2d4f020c0dee0a9fb9fc6fbcc2d561f36b78da4bf3802370 export HSQLDB_TARBALL := 17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip export HUNSPELL_SHA256SUM := 3cd9ceb062fe5814f668e4f22b2fa6e3ba0b339b921739541ce180cac4d6f4c4 diff --git a/external/harfbuzz/UnpackedTarball_harfbuzz.mk b/external/harfbuzz/UnpackedTarball_harfbuzz.mk index 537862531bfd..8ec1c8d3ab23 100644 --- a/external/harfbuzz/UnpackedTarball_harfbuzz.mk +++ b/external/harfbuzz/UnpackedTarball_harfbuzz.mk @@ -17,8 +17,6 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,harfbuzz,0)) $(eval $(call gb_UnpackedTarball_add_patches,harfbuzz, \ external/harfbuzz/clang-cl.patch \ -external/harfbuzz/ubsan.patch \ - external/harfbuzz/revert-make-inert.patch \ )) ifneq ($(ENABLE_RUNTIME_OPTIMIZATIONS),TRUE) diff --git a/external/harfbuzz/revert-make-inert.patch b/external/harfbuzz/revert-make-inert.patch deleted file mode 100644 index 366750d87fb9.. --- a/external/harfbuzz/revert-make-inert.patch +++ /dev/null @@ -1,200 +0,0 @@ -From 93f7c1652a05e806c2e3ac7edf498d2f4a508a3a Mon Sep 17 00:00:00 2001 -From: Behdad Esfahbod -Date: Tue, 14 Nov 2017 10:59:54 -0800 -Subject: [PATCH] Revert "[glib/ucdn/icu/ft/ot] Make returned funcs inert" - -This reverts commit 5daf3bd4494cce6b4fb074533be9e99c4d9e0edd. - -If other atexit callbacks try to destruct the objects we destruct -in atexit callbacks, bad things will happen. - -I'll come up with some other way to catch premature destruction -of HB-owned objects. - -Fixes https://github.com/behdad/harfbuzz/issues/618 - src/hb-ft.cc | 3 --- - src/hb-glib.cc | 3 --- - src/hb-icu.cc| 3 --- - src/hb-object-private.hh | 37 ++--- - src/hb-ot-font.cc| 3 --- - src/hb-ucdn.cc | 3 --- - 6 files changed, 6 insertions(+), 46 deletions(-) - -diff --git src/hb-ft.cc src/hb-ft.cc -index 68c774547..0f15f8c3d 100644 src/hb-ft.cc -+++ src/hb-ft.cc -@@ -423,7 +423,6 @@ static hb_font_funcs_t *static_ft_funcs = nullptr; - static - void free_static_ft_funcs (void) - { -- hb_object_undo_inert (static_ft_funcs); - hb_font_funcs_destroy (static_ft_funcs); - } - #endif -@@ -454,10 +453,8 @@ _hb_ft_font_set_funcs (hb_font_t *font, FT_Face ft_face, bool unref) - hb_font_funcs_set_glyph_from_name_func (funcs, hb_ft_get_glyph_from_name, nullptr, nullptr); - - hb_font_funcs_make_immutable (funcs); --hb_object_make_inert (funcs); - - if (!hb_atomic_ptr_cmpexch (_ft_funcs, nullptr, funcs)) { -- hb_object_undo_inert (funcs); - hb_font_funcs_destroy (funcs); - goto retry; - } -diff --git src/hb-glib.cc src/hb-glib.cc -index 31de68e86..50c30e9c7 100644 src/hb-glib.cc -+++ src/hb-glib.cc -@@ -370,7 +370,6 @@ static hb_unicode_funcs_t *static_glib_funcs = nullptr; - static - void free_static_glib_funcs (void) - { -- hb_object_undo_inert (static_glib_funcs); - hb_unicode_funcs_destroy (static_glib_funcs); - } - #endif -@@ -391,10 +390,8 @@ hb_glib_get_unicode_funcs (void) - #undef HB_UNICODE_FUNC_IMPLEMENT - - hb_unicode_funcs_make_immutable (funcs); --hb_object_make_inert (funcs); - - if (!hb_atomic_ptr_cmpexch (_glib_funcs, nullptr, funcs)) { -- hb_object_undo_inert (funcs); - hb_unicode_funcs_destroy (funcs); - goto retry; - } -diff --git src/hb-icu.cc src/hb-icu.cc -index 44a198937..552eaeca5 100644 src/hb-icu.cc -+++ src/hb-icu.cc -@@ -351,7 +351,6 @@ static hb_unicode_funcs_t *static_icu_funcs = nullptr; - static - void free_static_icu_funcs
[Libreoffice-bugs] [Bug 114994] Sheet -> Link to External Data doesn' t have button to load the URL
https://bugs.documentfoundation.org/show_bug.cgi?id=114994 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Link to external data it's not for import csv files, they are raw text. You can use Menu/Sheet/Insert sheet from file, keeping the link if you like. Then it can be updated through Menu/Edit/Link -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114998] Externally Linked Data does not update when pressing F9
https://bugs.documentfoundation.org/show_bug.cgi?id=114998 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG --- Comment #1 from m.a.riosv --- External links can be updated through Menu/Edit/Links, they are not a formula. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112071] [META] Linked external data issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112071 Bug 112071 depends on bug 114998, which changed state. Bug 114998 Summary: Externally Linked Data does not update when pressing F9 https://bugs.documentfoundation.org/show_bug.cgi?id=114998 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 --- Comment #2 from teamprob...@sbcglobal.net --- My graphics (Intel UHD Graphics 620) control panel indicates that it's running OpenGL version 4.4. I followed the link you provided and (after some trial and error--I'm only at novice-level with regedit and took a few tries to figure out how to enter the keys and strings) it works, thank you. This is outside my level of tech savvy. I was able to install LO on another new pc last week (same Win10 version) with no issues. What's going on? Is it a bug? An Intel issue? Something else? Thank you very much for your help. I was very frustrated with this--you know, new pc, you expect stuff to go smoothly, right? :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on||96544 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96544 [Bug 96544] Text inserts in wrong place when cell contains a URL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96544] Text inserts in wrong place when cell contains a URL
https://bugs.documentfoundation.org/show_bug.cgi?id=96544 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com Blocks||108252 --- Comment #6 from Thomas Lendo --- I can reproduce the bug with Version 6.1.0.0.alpha0+ Build ID: acb43c0b8efbfb841e7b40603d75a8432eb21f21 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-01-09_01:20:44 Locale: de-DE (de_DE.UTF-8); Calc: group threaded and with Version: 6.0.0.1 Build-ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a CPU-Threads: 4; BS: Linux 4.10; UI-Render: Standard; VCL: gtk2; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115022] subtotal in .xlxs
https://bugs.documentfoundation.org/show_bug.cgi?id=115022 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- I can't reproduce: Version: 5.4.4.2 (x64) Build ID: 2524958677847fb3bb44820e40380acbe820f960 CPU threads: 4; OS: Windows 6.19; UI render: default; Locale: es-ES (es_ES); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105183] EDITING: The text cursor isn' t appear on the next line pressing shift-enter when the text is rotated ( 90 degrees)
https://bugs.documentfoundation.org/show_bug.cgi?id=105183 Thomas Lendochanged: What|Removed |Added Blocks||106045 OS|Windows (All) |All Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Vertical text direction issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 Thomas Lendochanged: What|Removed |Added Depends on||105183 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105183 [Bug 105183] EDITING: The text cursor isn't appear on the next line pressing shift-enter when the text is rotated (90 degrees) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 teamprob...@sbcglobal.net changed: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115032] AutoCaption preference in options dialog should show Above as default position of table captions
https://bugs.documentfoundation.org/show_bug.cgi?id=115032 Thomas Lendochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=40 ||457 Blocks||114426, 113944 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113944 [Bug 113944] [META] Options dialog's Writer settings bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=114426 [Bug 114426] [META] Caption bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113944] [META] Options dialog's Writer settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113944 Thomas Lendochanged: What|Removed |Added Depends on||115032 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115032 [Bug 115032] AutoCaption preference in options dialog should show Above as default position of table captions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114426] [META] Caption bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114426 Thomas Lendochanged: What|Removed |Added Depends on||115032 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115032 [Bug 115032] AutoCaption preference in options dialog should show Above as default position of table captions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114426] [META] Caption bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114426 Thomas Lendochanged: What|Removed |Added Depends on||40457 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=40457 [Bug 40457] Place captions above tables by default -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Is OpenGL enabled? If so, could you please try to disable it as explained here https://wiki.documentfoundation.org/OpenGL and retest? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Infra call on Tue, Jan 16 at 17:30 UTC
On Tue, 09 Jan 2018 at 18:47:41 +0100, Guilhem Moulin wrote: > The next infra call will take place at `date -d 'Tue Jan 16 17:30:00 UTC > 2018'` > (18:30:00 Berlin time). > > See https://pad.documentfoundation.org/p/infra for details; agenda TBA. Reminder: that's tomorrow! -- Guilhem. signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 115032] New: AutoCaption preference in options dialog should show Above as default position of table captions
https://bugs.documentfoundation.org/show_bug.cgi?id=115032 Bug ID: 115032 Summary: AutoCaption preference in options dialog should show Above as default position of table captions Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thomas.le...@gmail.com This is a follow-up bug of Bug 40457 "Place captions above tables by default". Also the default preference in Tools > Options > Writer > AutoCaption should show "Above" as position of table captions instead of "Below". (I don't mean that table captions should be enabled by default.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] New: Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 Bug ID: 115031 Summary: Installs but Will Only Run in Safe-Mode New PC Windows 10 Product: LibreOffice Version: 5.4.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: teamprob...@sbcglobal.net Brand new PC, Windows 10 ver. 1709 (OS Build 12699.192) No other version of LibreOffice or Open Office Trial version of MS Office installed (but not used) Trial version of Norton Security I have downloaded the .msi file 3 times, installed without errors. There is no existing user profile, extensions, etc. However, when trying to open LO or LO Writer, the activity icon (little circle) runs for a few seconds but nothing happens. Before the last try, I uninstalled LO, then deleted all appearance of LO in the Win10 Registry, same problem. I can open LO in safe-mode but that's it. Help? (Yes, I know this is for bug reporting and not user support but... :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/bansan/chardraw' - cui/source cui/uiconfig
cui/source/dialogs/cuicharmap.cxx| 93 +++ cui/source/inc/cuicharmap.hxx| 24 - cui/uiconfig/ui/specialcharacters.ui |6 -- 3 files changed, 118 insertions(+), 5 deletions(-) New commits: commit 7fd8902e6b423f76aae473f78b210d175e539433 Author: Vincent Le GarrecDate: Mon Jan 15 23:28:40 2018 +0100 Allow draw symbol with mouse Use left click to draw black symbol. Use right click to rub the symbol. Change-Id: I3cb2155f105452f8b0f92a7fe2873ce98168cf2d diff --git a/cui/source/dialogs/cuicharmap.cxx b/cui/source/dialogs/cuicharmap.cxx index 4c6a2b3a3d82..7ca01ffba5b1 100644 --- a/cui/source/dialogs/cuicharmap.cxx +++ b/cui/source/dialogs/cuicharmap.cxx @@ -1281,4 +1281,97 @@ void SvxShowText::SetText( const OUString& rText ) } +VCL_BUILDER_FACTORY(DrawingAreaOcr) + +void DrawingAreaOcr::MouseButtonDown (const MouseEvent ) +{ +if (rMEvt.IsLeft()) +{ +state = State::DRAW; +} +else if (rMEvt.IsRight()) +{ +state = State::DELETE; +} + +if (state != State::NONE) +{ +const Point & mouse_pos = rMEvt.GetPosPixel(); + +data.emplace_back(mouse_pos.X(), mouse_pos.Y(), state); +} +} + +void DrawingAreaOcr::MouseMove( const MouseEvent ) +{ +const Point & mouse_pos = rMEvt.GetPosPixel(); + +if (state != State::NONE) +{ +data.emplace_back(mouse_pos.X(), mouse_pos.Y(), state); +} + +Invalidate(); +Update(); +std::cout << static_cast(state) << std::endl; +} + +void DrawingAreaOcr::MouseButtonUp (const MouseEvent ) +{ +const Point & mouse_pos = rMEvt.GetPosPixel(); +state = State::NONE; +data.emplace_back(mouse_pos.X(), mouse_pos.Y(), state); +} + +void DrawingAreaOcr::Paint(vcl::RenderContext& rRenderContext, const ::tools::Rectangle&) +{ +Color aTextCol = rRenderContext.GetLineColor(); + +rRenderContext.SetLineColor(Color( COL_WHITE )); +rRenderContext.DrawRect(tools::Rectangle(Point(0, 0), Size(GetOutputSizePixel().Width(), GetOutputSizePixel().Height(; + +const auto * i_1 = (); +basegfx::B2DPolygon aB2DPolyLine; +for (const auto & i : data) +{ +if (i_1->state == i.state) +{ +aB2DPolyLine.append(basegfx::B2DPoint(i.x, i.y)); +} +else +{ +if (i_1->state == State::DRAW) +{ +rRenderContext.SetLineColor(Color( COL_BLACK )); +rRenderContext.DrawPolyLine(aB2DPolyLine, 10.0); +} +else if (i_1->state == State::DELETE) +{ +rRenderContext.SetLineColor(Color( COL_WHITE )); +rRenderContext.DrawPolyLine(aB2DPolyLine, 10.0); +} +aB2DPolyLine.clear(); +} +i_1 = +} + +size_t size = data.size(); +if (size >= 2) +{ +if (data[size-2].state == State::DRAW) +{ +rRenderContext.SetLineColor(Color( COL_BLACK )); +rRenderContext.DrawPolyLine(aB2DPolyLine, 10.0); +} +else if (data[size-2].state == State::DELETE) +{ +rRenderContext.SetLineColor(Color( COL_WHITE )); +rRenderContext.DrawPolyLine(aB2DPolyLine, 10.0); +} +aB2DPolyLine.clear(); +} + +rRenderContext.SetTextLineColor(aTextCol); +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx index 7e2619efc10b..752678e1ad91 100644 --- a/cui/source/inc/cuicharmap.hxx +++ b/cui/source/inc/cuicharmap.hxx @@ -39,6 +39,28 @@ namespace svx struct SvxShowCharSetItem; } +class DrawingAreaOcr : public Control +{ +public: +DrawingAreaOcr(vcl::Window* pParent) : Control(pParent, WB_BORDER), state(State::NONE) {} +void MouseButtonDown (const MouseEvent ) override; +void MouseMove( const MouseEvent ) override; +void MouseButtonUp (const MouseEvent ) override; +void Paint( vcl::RenderContext& rRenderContext, const ::tools::Rectangle& ) override; + +private: +enum class State {DRAW, DELETE, NONE}; +State state; +struct DrawPoint +{ +int x; +int y; +State state; +DrawPoint(int x_, int y_, State state_) : x(x_), y(y_), state(state_) {}; +}; +std::vector data; +}; + class SvxShowText : public Control { public: @@ -79,7 +101,7 @@ private: VclPtrm_pSubsetLB; VclPtrm_pShowChar; VclPtr m_pDrawChk; -VclPtrm_pDrawingArea; +VclPtr m_pDrawingArea; VclPtr m_pSearchText; VclPtr m_pHexCodeText; VclPtr m_pDecimalCodeText; diff --git a/cui/uiconfig/ui/specialcharacters.ui b/cui/uiconfig/ui/specialcharacters.ui index ca21156de36c..9067d6fbb163 100644 --- a/cui/uiconfig/ui/specialcharacters.ui +++ b/cui/uiconfig/ui/specialcharacters.ui @@ -202,17 +202,15 @@
[Libreoffice-ux-advise] [Bug 112852] Should unapplying Bold remove the attribute or force text to Regular?
https://bugs.documentfoundation.org/show_bug.cgi?id=112852 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #12 from Thomas Lendo --- (In reply to Heiko Tietze from comment #7) > The only solution is to implement the first option and "forget" all previous > direct formattings after a style is applied. This is what I would expect. But I'm one of the rare users that use styles instead of DF as far as possible. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 112852] Should unapplying Bold remove the attribute or force text to Regular?
https://bugs.documentfoundation.org/show_bug.cgi?id=112852 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #12 from Thomas Lendo --- (In reply to Heiko Tietze from comment #7) > The only solution is to implement the first option and "forget" all previous > direct formattings after a style is applied. This is what I would expect. But I'm one of the rare users that use styles instead of DF as far as possible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/bansan/chardraw' - 2 commits - cui/source cui/uiconfig
cui/source/dialogs/cuicharmap.cxx| 19 ++ cui/source/inc/cuicharmap.hxx|3 ++ cui/uiconfig/ui/specialcharacters.ui | 47 +-- 3 files changed, 62 insertions(+), 7 deletions(-) New commits: commit 98a44dbadab9fee22ddebebb0b3e08691b818021 Author: Vincent Le GarrecDate: Mon Jan 15 23:20:29 2018 +0100 Add event to draw checkbox When box is checked, the drawingarea is visible instead of the showchar. Change-Id: I1f1219eb0087a8aff4d70c856c4b2823249b0ceb diff --git a/cui/source/dialogs/cuicharmap.cxx b/cui/source/dialogs/cuicharmap.cxx index ef849a56f8d6..4c6a2b3a3d82 100644 --- a/cui/source/dialogs/cuicharmap.cxx +++ b/cui/source/dialogs/cuicharmap.cxx @@ -64,6 +64,8 @@ SvxCharacterMap::SvxCharacterMap( vcl::Window* pParent, const SfxItemSet* pSet, get(m_pShowSet, "showcharset"); get(m_pSearchSet, "searchcharset"); get(m_pShowChar, "showchar"); +get(m_pDrawChk, "drawcheckbutton"); +get(m_pDrawingArea, "drawingarea"); m_pShowChar->SetCentered(true); if (m_bHasInsert) get(m_pOKBtn, "insert"); else get(m_pOKBtn, "ok"); @@ -188,6 +190,8 @@ void SvxCharacterMap::dispose() m_pSubsetText.clear(); m_pSubsetLB.clear(); m_pShowChar.clear(); +m_pDrawChk.clear(); +m_pDrawingArea.clear(); m_pHexCodeText.clear(); m_pDecimalCodeText.clear(); m_pCharName.clear(); @@ -486,6 +490,8 @@ void SvxCharacterMap::init() m_pShowSet->SetPreSelectHdl( LINK( this, SvxCharacterMap, CharPreSelectHdl ) ); m_pShowSet->SetFavClickHdl( LINK( this, SvxCharacterMap, FavClickHdl ) ); +m_pDrawChk->SetClickHdl( LINK( this, SvxCharacterMap, DrawToggleHdl ) ); + m_pSearchSet->SetDoubleClickHdl( LINK( this, SvxCharacterMap, SearchCharDoubleClickHdl ) ); m_pSearchSet->SetSelectHdl( LINK( this, SvxCharacterMap, SearchCharSelectHdl ) ); m_pSearchSet->SetHighlightHdl( LINK( this, SvxCharacterMap, SearchCharHighlightHdl ) ); @@ -939,6 +945,19 @@ IMPL_LINK_NOARG(SvxCharacterMap, InsertClickHdl, Button*, void) EndDialog(RET_OK); } +IMPL_LINK_NOARG(SvxCharacterMap, DrawToggleHdl, Button*, void) +{ +if (m_pDrawChk->IsChecked()) +{ +m_pDrawingArea->Show(); +m_pShowChar->Hide(); +} +else +{ +m_pDrawingArea->Hide(); +m_pShowChar->Show(); +} +} IMPL_STATIC_LINK(SvxCharacterMap, LoseFocusHdl, Control&, pItem, void) { diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx index b1a06b4540e3..7e2619efc10b 100644 --- a/cui/source/inc/cuicharmap.hxx +++ b/cui/source/inc/cuicharmap.hxx @@ -78,6 +78,8 @@ private: VclPtr m_pSubsetText; VclPtrm_pSubsetLB; VclPtrm_pShowChar; +VclPtr m_pDrawChk; +VclPtrm_pDrawingArea; VclPtr m_pSearchText; VclPtr m_pHexCodeText; VclPtr m_pDecimalCodeText; @@ -105,6 +107,7 @@ private: DECL_LINK(SubsetSelectHdl, ListBox&, void); DECL_LINK(CharDoubleClickHdl, SvxShowCharSet*,void); DECL_LINK(CharSelectHdl, SvxShowCharSet*, void); +DECL_LINK(DrawToggleHdl, Button*, void); DECL_LINK(CharHighlightHdl, SvxShowCharSet*, void); DECL_LINK(CharPreSelectHdl, SvxShowCharSet*, void); DECL_LINK(FavClickHdl, SvxShowCharSet*,void); commit c61d6a88c0f991b70c4bf19466eb671523f84aae Author: Vincent Le Garrec Date: Mon Jan 15 23:16:41 2018 +0100 Add draw functions to specialchar ui Change-Id: I6b732127cdd48b5e0acf8c409d586426d9b13c8e diff --git a/cui/uiconfig/ui/specialcharacters.ui b/cui/uiconfig/ui/specialcharacters.ui index 09a18b37b90a..ca21156de36c 100644 --- a/cui/uiconfig/ui/specialcharacters.ui +++ b/cui/uiconfig/ui/specialcharacters.ui @@ -202,6 +202,22 @@ + +80 +150 +False +True +True +True + + +False +True +0 +1 + + + True False @@ -212,7 +228,7 @@ 0 -1 +2 @@ -224,6 +240,23 @@ 6 True + +Draw +True +True +False +True +start +0 +True + + +0 +
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/dialog.hxx|4 - vcl/inc/svdata.hxx|2 vcl/source/app/svmain.cxx |2 vcl/source/uitest/uitest.cxx |4 - vcl/source/window/dialog.cxx | 95 -- vcl/source/window/winproc.cxx |6 +- 6 files changed, 46 insertions(+), 67 deletions(-) New commits: commit 1a156644e27a380daed217707a9cff9319f70a49 Author: Jan HolesovskyDate: Mon Jan 15 19:56:52 2018 +0100 vcl: No need for a double-linked list of dialogs in Execute(). Instead use a simple vector. Change-Id: I50652468cf06ba681d5caccb74a52b32c6c507a0 Reviewed-on: https://gerrit.libreoffice.org/47910 Tested-by: Jenkins Reviewed-by: Michael Meeks diff --git a/include/vcl/dialog.hxx b/include/vcl/dialog.hxx index 6dea53f47058..7fe00ba1c8c3 100644 --- a/include/vcl/dialog.hxx +++ b/include/vcl/dialog.hxx @@ -45,9 +45,7 @@ public: }; private: -VclPtr mpPrevExecuteDlg; -VclPtr mpNextExecuteDlg; -std::unique_ptr mpDialogImpl; +std::unique_ptr mpDialogImpl; longmnMousePositioned; boolmbInExecute; boolmbInClose; diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx index c88f8a4ce356..7949de3c0861 100644 --- a/vcl/inc/svdata.hxx +++ b/vcl/inc/svdata.hxx @@ -204,7 +204,7 @@ struct ImplSVWinData VclPtr mpCaptureWin; // window, that has the mouse capture VclPtr mpLastDeacWin; // Window, that need a deactivate (FloatingWindow-Handling) VclPtr mpFirstFloat; // First FloatingWindow in PopupMode -VclPtr mpLastExecuteDlg; // First Dialog that is in Execute +std::vector mpExecuteDialogs; ///< Stack of dialogs that are Execute()'d - the last one is the top most one. VclPtr mpExtTextInputWin; // Window, which is in ExtTextInput VclPtr mpTrackWin; // window, that is in tracking mode AutoTimer* mpTrackTimer = nullptr; // tracking timer diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx index 10d65ad2802c..500eb3060c19 100644 --- a/vcl/source/app/svmain.cxx +++ b/vcl/source/app/svmain.cxx @@ -606,7 +606,7 @@ void DeInitVCL() pSVData->maWinData.mpCaptureWin = nullptr; pSVData->maWinData.mpLastDeacWin = nullptr; pSVData->maWinData.mpFirstFloat = nullptr; -pSVData->maWinData.mpLastExecuteDlg = nullptr; +pSVData->maWinData.mpExecuteDialogs.clear(); pSVData->maWinData.mpExtTextInputWin = nullptr; pSVData->maWinData.mpTrackWin = nullptr; pSVData->maWinData.mpAutoScrollWin = nullptr; diff --git a/vcl/source/uitest/uitest.cxx b/vcl/source/uitest/uitest.cxx index 3234108ca7ed..658b8cf75a82 100644 --- a/vcl/source/uitest/uitest.cxx +++ b/vcl/source/uitest/uitest.cxx @@ -38,9 +38,9 @@ std::unique_ptr UITest::getFocusTopWindow() ImplSVData* pSVData = ImplGetSVData(); ImplSVWinData& rWinData = pSVData->maWinData; -if (rWinData.mpLastExecuteDlg) +if (!rWinData.mpExecuteDialogs.empty()) { -return rWinData.mpLastExecuteDlg->GetUITestFactory()(rWinData.mpLastExecuteDlg); +return rWinData.mpExecuteDialogs.back()->GetUITestFactory()(rWinData.mpExecuteDialogs.back()); } return rWinData.mpFirstFrame->GetUITestFactory()(rWinData.mpFirstFrame); diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx index b2f97bdcd081..972b6671f0ed 100644 --- a/vcl/source/window/dialog.cxx +++ b/vcl/source/window/dialog.cxx @@ -350,8 +350,6 @@ struct DialogImpl void Dialog::ImplInitDialogData() { mpWindowImpl->mbDialog = true; -mpPrevExecuteDlg= nullptr; -mpNextExecuteDlg= nullptr; mbInExecute = false; mbInClose = false; mbModalMode = false; @@ -373,19 +371,17 @@ vcl::Window* Dialog::GetDefaultParent(WinBits nStyle) if (pParent && (!pParent->IsInputEnabled() || pParent->IsInModalMode())) { ImplSVData* pSVData = ImplGetSVData(); -Dialog* pExeDlg = pSVData->maWinData.mpLastExecuteDlg; -while (pExeDlg) +auto& rExecuteDialogs = pSVData->maWinData.mpExecuteDialogs; +for (auto it = rExecuteDialogs.rbegin(); it != rExecuteDialogs.rend(); ++it) { // only if visible and enabled -if (pParent->ImplGetFirstOverlapWindow()->IsWindowOrChild(pExeDlg, true) && -pExeDlg->IsReallyVisible() && -pExeDlg->IsEnabled() && pExeDlg->IsInputEnabled() && !pExeDlg->IsInModalMode()) +if (pParent->ImplGetFirstOverlapWindow()->IsWindowOrChild(*it, true) && +(*it)->IsReallyVisible() && +(*it)->IsEnabled() && (*it)->IsInputEnabled() && !(*it)->IsInModalMode()) { -
[Libreoffice-bugs] [Bug 115000] Style inherit is not properly saved when created ( but it does at second save)
https://bugs.documentfoundation.org/show_bug.cgi?id=115000 --- Comment #2 from Laurent BP--- The bug appears if you create inheritance with a style which did not exist when file was opened. 1. Create new drawing 2. Create new style 3. Save doc (but no reload) 4. Create inherited style from new style Inheritance will be lost. If on step 3, file is reloaded, inheritance will be kept. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Thomas Lendochanged: What|Removed |Added Depends on||68268 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=68268 [Bug 68268] EDITING: Sentences are inserted without spaces at the end or at the beginning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68268] EDITING: Sentences are inserted without spaces at the end or at the beginning
https://bugs.documentfoundation.org/show_bug.cgi?id=68268 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com Blocks||102593 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114905] CRASH: LibreOffice crashes opening the new file dialog from the notebookbar
https://bugs.documentfoundation.org/show_bug.cgi?id=114905 Xisco Faulíchanged: What|Removed |Added CC||caol...@redhat.com --- Comment #4 from Xisco Faulí --- Caolán, one for you ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 68271] EDITING: Paragraphs are inserted without paragraph end character
https://bugs.documentfoundation.org/show_bug.cgi?id=68271 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #13 from Thomas Lendo --- I agree with Cor Nouws in comment 11. But I would support the idea if the user can choose the behavior (with or without end character) in the options dialog. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 68271] EDITING: Paragraphs are inserted without paragraph end character
https://bugs.documentfoundation.org/show_bug.cgi?id=68271 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com --- Comment #13 from Thomas Lendo --- I agree with Cor Nouws in comment 11. But I would support the idea if the user can choose the behavior (with or without end character) in the options dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115000] Style inherit is not properly saved when created ( but it does at second save)
https://bugs.documentfoundation.org/show_bug.cgi?id=115000 Laurent BPchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||jumbo4...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Laurent BP --- Confirmed with: - Version: 5.4.4.2 Build ID: 2524958677847fb3bb44820e40380acbe820f960 Threads CPU : 8; OS : Linux 4.10; UI Render : par défaut; VCL : gtk2; Locale : fr-FR (fr_FR.UTF-8); Calc: group - Version: 6.0.0.2 Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd Threads CPU : 8; OS : Linux 4.10; UI Render : par défaut; VCL: gtk2; Locale : fr-FR (fr_FR.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - include/sfx2 include/sot
include/sfx2/thumbnailview.hxx |1 - include/sot/exchange.hxx |5 - 2 files changed, 6 deletions(-) New commits: commit f2e3d8d34b3d3993d46e38c660a60cdfc7950090 Author: Stephan BergmannDate: Mon Jan 15 20:42:54 2018 +0100 Remove unused EXCHG_OUT_ACTION_* ..._INSERT_BOOKMARK and ..._MOVE_FILE unused since ef80b69819cbf9618041350b46ce4db892e42a80 "remve all the old/not used destination defines", and no other traces of ..._INSERT_OBJ, ..._MOVE_FILELIST, ..._UPDATE_RANGE use apart from their definitions in f108f9423b744fb97557539530f901962efbd8d0 "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to sot/inc/sot and correspondent necessary changes" Change-Id: Ia352add990d120b8b7562c62f2f2ca8afda92f47 Reviewed-on: https://gerrit.libreoffice.org/47914 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/sot/exchange.hxx b/include/sot/exchange.hxx index aed90f28a82f..3ea611799506 100644 --- a/include/sot/exchange.hxx +++ b/include/sot/exchange.hxx @@ -54,17 +54,12 @@ SOT_DLLPUBLIC bool IsFormatSupported( const DataFlavorExVector& rDataFlavorExVec #define EXCHG_IN_ACTION_MOVE (sal_uInt8(css::datatransfer::dnd::DNDConstants::ACTION_MOVE)) #define EXCHG_IN_ACTION_COPY (sal_uInt8(css::datatransfer::dnd::DNDConstants::ACTION_COPY)) #define EXCHG_IN_ACTION_LINK (sal_uInt8(css::datatransfer::dnd::DNDConstants::ACTION_LINK)) -#define EXCHG_OUT_ACTION_INSERT_OBJ ((sal_uInt8)17) -#define EXCHG_OUT_ACTION_INSERT_BOOKMARK((sal_uInt8)18) #define EXCHG_OUT_ACTION_INSERT_FILE(sal_uInt8(20)) #define EXCHG_OUT_ACTION_INSERT_IMAGEMAP(sal_uInt8(22)) #define EXCHG_OUT_ACTION_INSERT_OLE (sal_uInt8(23)) #define EXCHG_OUT_ACTION_INSERT_INTERACTIVE (sal_uInt8(24)) #define EXCHG_OUT_ACTION_REPLACE_IMAGEMAP (sal_uInt8(29)) #define EXCHG_OUT_ACTION_GET_ATTRIBUTES (sal_uInt8(30)) -#define EXCHG_OUT_ACTION_MOVE_FILE ((sal_uInt8)32) -#define EXCHG_OUT_ACTION_MOVE_FILELIST ((sal_uInt8)33) -#define EXCHG_OUT_ACTION_UPDATE_RANGE ((sal_uInt8)34) #define EXCHG_OUT_ACTION_INSERT_PRIVATE (sal_uInt8(35)) #define EXCHG_OUT_ACTION_INSERT_HTML(sal_uInt8(36)) #define EXCHG_OUT_ACTION_MOVE_PRIVATE (sal_uInt8(37)) commit 84184cc396ce11389e0e93f649c9320b14710bb4 Author: Stephan Bergmann Date: Mon Jan 15 20:18:55 2018 +0100 Remove unused THUMBNAILVIEW_APPEND ...unused since 6affa4be69aa31e27af9d50e9ab6bd740319c379 "callcatcher: update list, stop hiding uncalled tests :-)" Change-Id: I0a5a7ed3be508703887f00750e11b811162e6fc3 Reviewed-on: https://gerrit.libreoffice.org/47912 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx index 7b1face96c87..e3cbca77ec0a 100644 --- a/include/sfx2/thumbnailview.hxx +++ b/include/sfx2/thumbnailview.hxx @@ -156,7 +156,6 @@ namespace drawinglayer { /* ThumbnailView types */ -#define THUMBNAILVIEW_APPEND ((sal_uInt16)-1) #define THUMBNAILVIEW_ITEM_NOTFOUND (sal_uInt16(-1)) // Display all the available items in the thumbnail. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115017] SVG images are clipped incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=115017 Telestochanged: What|Removed |Added Status|UNCONFIRMED |NEW Version|5.4.4.2 release |3.5.7.2 release Blocks||88278 Ever confirmed|0 |1 --- Comment #4 from Telesto --- Confirming with Version: 6.1.0.0.alpha0+ Build ID: 80fb8d406ced47e6a2089f0c8ba5c103d2fec91f CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-01-15_05:18:42 Locale: nl-NL (nl_NL); Calc: CL and with LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88278 [Bug 88278] [META] insert SVG image filter (all modules) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88278] [META] insert SVG image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Telestochanged: What|Removed |Added Depends on||115017 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115017 [Bug 115017] SVG images are clipped incorrectly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114960] Higher resolution of background images in templates
https://bugs.documentfoundation.org/show_bug.cgi?id=114960 --- Comment #4 from Thomas Lendo--- (In reply to Laurent BP from comment #2) > Please describe precisely which templates need to be improved. The Impress templates I mean are - Beehive - Blue Curve - Blueprint Plans - DNA - Forestbird - Nature Illustration - Pencil - Vintage -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/source
android/source/res/values/strings.xml |2 + android/source/res/xml/libreoffice_preferences.xml|5 ++ android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java | 17 +- 3 files changed, 23 insertions(+), 1 deletion(-) New commits: commit 2733ca6c0aed6468c26fd7a80b0b50e32fd608c4 Author: Mert TümerDate: Mon Jan 8 13:15:21 2018 +0300 tdf#103083 option to show/hide hidden files/folders on Android The patch was sent for the ULAKBIM/PARDUS project. Signed-off-by: Mert Tümer Change-Id: Iadbb688a1a976279b23d246001818ac1c21b3d47 Reviewed-on: https://gerrit.libreoffice.org/47637 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/android/source/res/values/strings.xml b/android/source/res/values/strings.xml index 1fb23a528c06..9b6ff7abff9c 100644 --- a/android/source/res/values/strings.xml +++ b/android/source/res/values/strings.xml @@ -49,6 +49,8 @@ General Experimental Mode Enable the experimental editing mode. Use at your own risk. +Hidden Files/Folders +Enable to show hidden files/folders About Parts diff --git a/android/source/res/xml/libreoffice_preferences.xml b/android/source/res/xml/libreoffice_preferences.xml index 347709b7d017..17236434daa2 100644 --- a/android/source/res/xml/libreoffice_preferences.xml +++ b/android/source/res/xml/libreoffice_preferences.xml @@ -20,6 +20,11 @@ android:title="File explorer layout" android:key="EXPLORER_VIEW_TYPE" android:summary="View files as a grid or in a list." /> + paths = currentDirectory.listFiles(FileUtilities .getFileFilter(filterMode)); +filePaths = new ArrayList(); +for(IFile file: paths) { +if(showHiddenFiles){ +filePaths.add(file); +} else { +if(!file.getName().startsWith(".")){ +filePaths.add(file); +} +} +} } catch (final RuntimeException e) { final Activity activity = LibreOfficeUIActivity.this; @@ -813,6 +825,7 @@ public class LibreOfficeUIActivity extends AppCompatActivity implements Settings SharedPreferences defaultPrefs = PreferenceManager.getDefaultSharedPreferences(getBaseContext()); viewMode = Integer.valueOf(defaultPrefs.getString(EXPLORER_VIEW_TYPE_KEY, ""+ GRID_VIEW)); filterMode = Integer.valueOf(defaultPrefs.getString(FILTER_MODE_KEY , "-1")); +showHiddenFiles = Boolean.valueOf(defaultPrefs.getBoolean(ENABLE_SHOW_HIDDEN_FILES_KEY, false)); Intent i = this.getIntent(); if (i.hasExtra(CURRENT_DIRECTORY_KEY)) { @@ -850,6 +863,7 @@ public class LibreOfficeUIActivity extends AppCompatActivity implements Settings outState.putInt(FILTER_MODE_KEY, filterMode); outState.putInt(EXPLORER_VIEW_TYPE_KEY , viewMode); outState.putInt(DOC_PROVIDER_KEY, documentProvider.getId()); +outState.putBoolean(ENABLE_SHOW_HIDDEN_FILES_KEY , showHiddenFiles); Log.d(LOGTAG, currentDirectory.toString() + Integer.toString(filterMode) + Integer.toString(viewMode)); //prefs.edit().putInt(EXPLORER_VIEW_TYPE, viewType).commit(); @@ -876,6 +890,7 @@ public class LibreOfficeUIActivity extends AppCompatActivity implements Settings } filterMode = savedInstanceState.getInt(FILTER_MODE_KEY, FileUtilities.ALL); viewMode = savedInstanceState.getInt(EXPLORER_VIEW_TYPE_KEY, GRID_VIEW); +showHiddenFiles = savedInstanceState.getBoolean(ENABLE_SHOW_HIDDEN_FILES_KEY, false); //openDirectory(currentDirectory); Log.d(LOGTAG, "onRestoreInstanceState"); Log.d(LOGTAG, currentDirectory.toString() + Integer.toString(filterMode) + Integer.toString(viewMode)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 36308] [UI]Change behaviour for "tree view" on Writer's Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=36308 --- Comment #16 from Commit Notification--- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=77acf66a3414c46edecfbc04b65e4a507eb857cb change Not to Dont in tdf#36308 fix It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/source
android/source/res/layout/activity_document_browser.xml |9 + android/source/res/values/strings.xml |1 + android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |5 - 3 files changed, 14 insertions(+), 1 deletion(-) New commits: commit 55ecc98376dbeffc366820e718fd906b8935a17b Author: Mert TümerDate: Mon Jan 8 12:52:01 2018 +0300 tdf#89639 added path text for the document browser The patch was sent for the ULAKBIM/PARDUS project. Signed-off-by: Mert Tümer Change-Id: I14ce3bb7c11f4cc2fe9194a99b433764209b1528 Reviewed-on: https://gerrit.libreoffice.org/47635 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/android/source/res/layout/activity_document_browser.xml b/android/source/res/layout/activity_document_browser.xml index fab1b095035e..9f62f5f22a3e 100644 --- a/android/source/res/layout/activity_document_browser.xml +++ b/android/source/res/layout/activity_document_browser.xml @@ -86,6 +86,15 @@ android:padding="16dp" android:textStyle="bold" /> + + Go Choose Directory Invalid directory path +Current Directory: Save the document before closing? diff --git a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java index 786b949bb504..530644667aa9 100644 --- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java +++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java @@ -464,12 +464,15 @@ public class LibreOfficeUIActivity extends AppCompatActivity implements Settings findViewById(R.id.header_browser).setVisibility((View.VISIBLE)); findViewById(R.id.header_recents).setVisibility((View.VISIBLE)); actionBar.setTitle(R.string.app_name); +findViewById(R.id.text_directory_path).setVisibility(View.GONE); } else { recentRecyclerView.setVisibility(View.GONE); findViewById(R.id.header_browser).setVisibility((View.GONE)); findViewById(R.id.header_recents).setVisibility((View.GONE)); actionBar.setTitle(dir.getName()); - +findViewById(R.id.text_directory_path).setVisibility(View.VISIBLE); + ((TextView)findViewById(R.id.text_directory_path)).setText(getString(R.string.current_dir) + +" " + dir.getUri().getPath()); } new AsyncTask () { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svtools svtools/source sw/source
include/svtools/treelistbox.hxx |2 +- svtools/source/contnr/treelistbox.cxx |2 +- sw/source/uibase/utlui/content.cxx|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 77acf66a3414c46edecfbc04b65e4a507eb857cb Author: Jim RaykowskiDate: Sun Jan 14 11:24:10 2018 -0900 change Not to Dont in tdf#36308 fix Change-Id: I05806eea3363b7363d7a377277c63785aadc5386 Reviewed-on: https://gerrit.libreoffice.org/47870 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/include/svtools/treelistbox.hxx b/include/svtools/treelistbox.hxx index 12bfa4a11439..adf8a079a2a2 100644 --- a/include/svtools/treelistbox.hxx +++ b/include/svtools/treelistbox.hxx @@ -649,7 +649,7 @@ public: voidSetSublistOpenWithReturn(); // open/close sublist with return/enter voidSetSublistOpenWithLeftRight(); // open/close sublist with cursor left/right -voidSetSublistNotOpenWithDoubleClick(); // do not open/close sublist with mouse double click on entry +voidSetSublistDontOpenWithDoubleClick(); // do not open/close sublist with mouse double click on entry voidEnableInplaceEditing( bool bEnable ); // Edits the Entry's first StringItem, 0 == Cursor diff --git a/svtools/source/contnr/treelistbox.cxx b/svtools/source/contnr/treelistbox.cxx index 5f1c37606785..1a8c07d521a6 100644 --- a/svtools/source/contnr/treelistbox.cxx +++ b/svtools/source/contnr/treelistbox.cxx @@ -1434,7 +1434,7 @@ void SvTreeListBox::SetSublistOpenWithLeftRight() pImpl->bSubLstOpLR = true; } -void SvTreeListBox::SetSublistNotOpenWithDoubleClick() +void SvTreeListBox::SetSublistDontOpenWithDoubleClick() { pImpl->bSubLstOpDblClick = false; } diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index f58c15a6e358..df7f1bbb29c1 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -858,7 +858,7 @@ SwContentTree::SwContentTree(vcl::Window* pParent, SwNavigationPI* pDialog) , m_bViewHasChanged(false) , m_bIsKeySpace(false) { -SetSublistNotOpenWithDoubleClick(); +SetSublistDontOpenWithDoubleClick(); SetHelpId(HID_NAVIGATOR_TREELIST); SetNodeDefaultImages(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt |binary sw/qa/extras/uiwriter/uiwriter.cxx | 51 +- sw/source/filter/xml/xmlimp.cxx| 240 +++--- sw/source/filter/xml/xmlimp.hxx|1 4 files changed, 228 insertions(+), 64 deletions(-) New commits: commit 1b04fae2b10d258d71e9e29ea659495b6d949367 Author: Serge KrotDate: Fri Jan 12 13:55:59 2018 +0100 tdf#113877 Insert document: merge two lists into one When inserting a new document into current position we need to concat to lists into one only when they have the same list properties. (cherry picked from commit 311ea730cb225bca167af2e4111445608a14a263) Change-Id: I2766d5856418338fd5920968ac136899eeac7d74 Reviewed-on: https://gerrit.libreoffice.org/47913 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt new file mode 100755 index ..47fe7e0760fe Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 39190dffc906..90c13315ad77 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -208,6 +208,7 @@ public: void testTdf112025(); void testTdf114306(); void testTdf113877(); +void testTdf113877NoMerge(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -315,6 +316,7 @@ public: CPPUNIT_TEST(testTdf112025); CPPUNIT_TEST(testTdf114306); CPPUNIT_TEST(testTdf113877); +CPPUNIT_TEST(testTdf113877NoMerge); CPPUNIT_TEST_SUITE_END(); private: @@ -3814,6 +3816,8 @@ void SwUiWriterTest::testTdf114306() xmlXPathFreeObject(pXmlObj); } +// During insert of the document with list inside into the main document inside the list +// we should merge both lists into one, when they have the same list properties void SwUiWriterTest::testTdf113877() { load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt"); @@ -3831,13 +3835,52 @@ void SwUiWriterTest::testTdf113877() lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues); } +const OUString listId1 = getProperty(getParagraph(1), "ListId"); +const OUString listId4 = getProperty(getParagraph(4), "ListId"); +const OUString listId5 = getProperty(getParagraph(5), "ListId"); +const OUString listId6 = getProperty(getParagraph(6), "ListId"); +const OUString listId7 = getProperty(getParagraph(7), "ListId"); + +// the initial list with 4 list items +CPPUNIT_ASSERT_EQUAL(listId1, listId4); + +// the last of the first list, and the first of the inserted list +CPPUNIT_ASSERT_EQUAL(listId4, listId5); +CPPUNIT_ASSERT_EQUAL(listId5, listId6); +CPPUNIT_ASSERT_EQUAL(listId6, listId7); +} + +// The same test as testTdf113877() but merging of two list should not be performed. +void SwUiWriterTest::testTdf113877NoMerge() +{ +load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt"); + +// set a page cursor into the end of the document +uno::Reference xModel(mxComponent, uno::UNO_QUERY); +uno::Reference xTextViewCursorSupplier(xModel->getCurrentController(), uno::UNO_QUERY); +uno::Reference xCursor(xTextViewCursorSupplier->getViewCursor(), uno::UNO_QUERY); +xCursor->jumpToEndOfPage(); + +// insert the same document at current cursor position +{ +const OUString insertFileid = m_directories.getURLFromSrc(DATA_DIRECTORY) + "tdf113877_insert_numbered_list_abcd.odt"; +uno::Sequence aPropertyValues(comphelper::InitPropertySequence({ { "Name", uno::makeAny(insertFileid) } })); +lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues); +} + +const OUString listId1 = getProperty(getParagraph(1), "ListId"); +const OUString listId4 = getProperty(getParagraph(4), "ListId"); +const OUString listId5 = getProperty(getParagraph(5), "ListId"); +const OUString listId6 = getProperty(getParagraph(6), "ListId"); +const OUString listId7 = getProperty(getParagraph(7), "ListId"); + // the initial list with 4 list items -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(1), "ListId"), getProperty(getParagraph(4), "ListId")); +CPPUNIT_ASSERT_EQUAL(listId1, listId4); // the last of the first list, and the first of the inserted list -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(4), "ListId"), getProperty(getParagraph(5), "ListId")); -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(5), "ListId"), getProperty(getParagraph(6), "ListId")); -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(6),
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt |binary sw/qa/extras/uiwriter/uiwriter.cxx | 51 +- sw/source/filter/xml/xmlimp.cxx| 239 +++--- sw/source/filter/xml/xmlimp.hxx|1 4 files changed, 227 insertions(+), 64 deletions(-) New commits: commit 311ea730cb225bca167af2e4111445608a14a263 Author: Serge KrotDate: Fri Jan 12 13:55:59 2018 +0100 tdf#113877 Insert document: merge two lists into one When inserting a new document into current position we need to concat to lists into one only when they have the same list properties. Added unit test. Change-Id: I66a8090fdeacd3a630700113d6a26a1cad75dc41 Reviewed-on: https://gerrit.libreoffice.org/47814 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt new file mode 100755 index ..47fe7e0760fe Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf113877_insert_numbered_list_abcd.odt differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 7d39895f39bd..1bfb252c4899 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -264,6 +264,7 @@ public: void testTdf58604(); void testTdf112025(); void testTdf113877(); +void testTdf113877NoMerge(); void testMsWordCompTrailingBlanks(); void testCreateDocxAnnotation(); void testTdf107976(); @@ -437,6 +438,7 @@ public: CPPUNIT_TEST(testTdf58604); CPPUNIT_TEST(testTdf112025); CPPUNIT_TEST(testTdf113877); +CPPUNIT_TEST(testTdf113877NoMerge); CPPUNIT_TEST(testMsWordCompTrailingBlanks); CPPUNIT_TEST(testCreateDocxAnnotation); CPPUNIT_TEST(testTdf107976); @@ -5281,6 +5283,8 @@ void SwUiWriterTest::testTdf114306() assertXPath(pXmlDoc, "/root/page[2]/body/tab[1]/row[1]/cell[1]/txt", 1); } +// During insert of the document with list inside into the main document inside the list +// we should merge both lists into one, when they have the same list properties void SwUiWriterTest::testTdf113877() { load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt"); @@ -5298,13 +5302,52 @@ void SwUiWriterTest::testTdf113877() lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues); } +const OUString listId1 = getProperty(getParagraph(1), "ListId"); +const OUString listId4 = getProperty(getParagraph(4), "ListId"); +const OUString listId5 = getProperty(getParagraph(5), "ListId"); +const OUString listId6 = getProperty(getParagraph(6), "ListId"); +const OUString listId7 = getProperty(getParagraph(7), "ListId"); + +// the initial list with 4 list items +CPPUNIT_ASSERT_EQUAL(listId1, listId4); + +// the last of the first list, and the first of the inserted list +CPPUNIT_ASSERT_EQUAL(listId4, listId5); +CPPUNIT_ASSERT_EQUAL(listId5, listId6); +CPPUNIT_ASSERT_EQUAL(listId6, listId7); +} + +// The same test as testTdf113877() but merging of two list should not be performed. +void SwUiWriterTest::testTdf113877NoMerge() +{ +load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt"); + +// set a page cursor into the end of the document +uno::Reference xModel(mxComponent, uno::UNO_QUERY); +uno::Reference xTextViewCursorSupplier(xModel->getCurrentController(), uno::UNO_QUERY); +uno::Reference xCursor(xTextViewCursorSupplier->getViewCursor(), uno::UNO_QUERY); +xCursor->jumpToEndOfPage(); + +// insert the same document at current cursor position +{ +const OUString insertFileid = m_directories.getURLFromSrc(DATA_DIRECTORY) + "tdf113877_insert_numbered_list_abcd.odt"; +uno::Sequence aPropertyValues(comphelper::InitPropertySequence({ { "Name", uno::makeAny(insertFileid) } })); +lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues); +} + +const OUString listId1 = getProperty(getParagraph(1), "ListId"); +const OUString listId4 = getProperty(getParagraph(4), "ListId"); +const OUString listId5 = getProperty(getParagraph(5), "ListId"); +const OUString listId6 = getProperty(getParagraph(6), "ListId"); +const OUString listId7 = getProperty(getParagraph(7), "ListId"); + // the initial list with 4 list items -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(1), "ListId"), getProperty(getParagraph(4), "ListId")); +CPPUNIT_ASSERT_EQUAL(listId1, listId4); // the last of the first list, and the first of the inserted list -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(4), "ListId"), getProperty(getParagraph(5), "ListId")); -CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(5), "ListId"),
[Libreoffice-commits] core.git: include/editeng
include/editeng/lrspitem.hxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 8f28db9515e049fa7e0aa26fe32513e3486dcfaf Author: Stephan BergmannDate: Mon Jan 15 20:10:21 2018 +0100 Remove unused LRSPACE_{16,AUTOFIRST}_VERSION ...unused since 1e4b1e4a1aca3b333820b0a865997e6f62e80064 "Removing unused SfxItemPool serialisation from editeng" Change-Id: Iecc91d21a3c02985259e985c4092652efe877b50 Reviewed-on: https://gerrit.libreoffice.org/47911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx index 4a2d9bd3992d..6a1a16d61144 100644 --- a/include/editeng/lrspitem.hxx +++ b/include/editeng/lrspitem.hxx @@ -43,9 +43,7 @@ 700 -500 200 700 -500 */ -#define LRSPACE_16_VERSION ((sal_uInt16)0x0001) #define LRSPACE_TXTLEFT_VERSION (sal_uInt16(0x0002)) -#define LRSPACE_AUTOFIRST_VERSION ((sal_uInt16)0x0003) #define LRSPACE_NEGATIVE_VERSION (sal_uInt16(0x0004)) class EDITENG_DLLPUBLIC SvxLRSpaceItem : public SfxPoolItem ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 50699] Template Changer: Allow ability to change a document' s associated template
https://bugs.documentfoundation.org/show_bug.cgi?id=50699 --- Comment #49 from Thomas Lendo--- (In reply to Heiko Tietze from comment #43) > * Feature: Do we really want this workflow? Should document and template be > linked so that changes to the template become effective later? As Pierre C said in comment 45 and Patrick Smits in comment 47, the current workflow with the extension is sufficient and need not to be changed. Please test the extension and you will see. For a developer, the extension can be the reference. > * Scope: How about textboxes, containing the company address for instance? > We can start with a basic set of course. As far as I know, textboxes and other objects are not in the scope of the extension. I wouldn't extend the scope of the feature by now. It worked very well till now. > * Workflow: How do we edit the template? We could ask the user whether a > template should be opened and edited as it or applied to the current > document. Alternatively an extra command "Apply template" could be better. > The integration into the template manager is unclear. As Patrick Smits said in comment 47, nothing has to be changed in the template manager or in the workflow with linked files. You can edit a template with the template manager. Editing the template always opens the current template available in the template manager. The only new that has to be implemented is the place where the link to a template can be applied or changed or deleted (as I said in the last point in my comment 42). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 50699] Template Changer: Allow ability to change a document' s associated template
https://bugs.documentfoundation.org/show_bug.cgi?id=50699 --- Comment #49 from Thomas Lendo--- (In reply to Heiko Tietze from comment #43) > * Feature: Do we really want this workflow? Should document and template be > linked so that changes to the template become effective later? As Pierre C said in comment 45 and Patrick Smits in comment 47, the current workflow with the extension is sufficient and need not to be changed. Please test the extension and you will see. For a developer, the extension can be the reference. > * Scope: How about textboxes, containing the company address for instance? > We can start with a basic set of course. As far as I know, textboxes and other objects are not in the scope of the extension. I wouldn't extend the scope of the feature by now. It worked very well till now. > * Workflow: How do we edit the template? We could ask the user whether a > template should be opened and edited as it or applied to the current > document. Alternatively an extra command "Apply template" could be better. > The integration into the template manager is unclear. As Patrick Smits said in comment 47, nothing has to be changed in the template manager or in the workflow with linked files. You can edit a template with the template manager. Editing the template always opens the current template available in the template manager. The only new that has to be implemented is the place where the link to a template can be applied or changed or deleted (as I said in the last point in my comment 42). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115030] New: Writer import docx math fomula "dot" is translate as " acute"
https://bugs.documentfoundation.org/show_bug.cgi?id=115030 Bug ID: 115030 Summary: Writer import docx math fomula "dot" is translate as "acute" Product: LibreOffice Version: 5.0 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Formula Editor Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pierre.choffar...@free.fr Created attachment 139118 --> https://bugs.documentfoundation.org/attachment.cgi?id=139118=edit dot example - Open attachment, with writer. this is a simple letter with a dot symbol - when writer translate the formula, it is not the same as in DOCX The formula should use "dot" instead of "acute" math command -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115000] Style inherit is not properly saved when created ( but it does at second save)
https://bugs.documentfoundation.org/show_bug.cgi?id=115000 Pierre Cchanged: What|Removed |Added Summary|Style inherit is not|Style inherit is not |properly saved when created |properly saved when created |(but it does at second |(but it does at second |saved) |save) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Help needed !!! SolarMutex
Hi I need help. I am debugging the iOS version of LibreOfficeKit init() to find a missing SolarMutex release (Xcode 9 debugger). Can someone please tell me how to "see" (in the debugger) if the SolarMutex is locked, and if so to which task. rgds jan I. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 115029] New: The drawing of the blue selection frame is flickery/ lagging behind while scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=115029 Bug ID: 115029 Summary: The drawing of the blue selection frame is flickery/lagging behind while scrolling Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: The drawing of the blue selection frame is flickery/lagging behind while scrolling Steps to Reproduce: 1. Open attachment 136849 2. Set it to multi page view (at least to pages) and scroll 3. Select all 4. Scroll up down/ scroll wheel or dragging scroll-bar 5. The blue selection color is always lagging behind. The text is rendered stable but the selection frame is unstable/flickery (depending on scrolling speed and method (dragging the scroll-bar or normal scrolling) Similar behavior in Calc 1. Open a spreadsheet 2. Select all 3. Scroll down/up Actual Results: The selection flickering while scrolling. It's a bit restless Expected Results: A more stable section frame layout Reproducible: Always User Profile Reset: No Additional Info: Found Version: 6.1.0.0.alpha0+ Build ID: 80fb8d406ced47e6a2089f0c8ba5c103d2fec91f CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-01-15_05:18:42 Locale: nl-NL (nl_NL); Calc: CL and in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 With or without OpenGL. Also seen on MacOS (with a single page). User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115020] Cutting a large dataset is very slow since 6.1.0.0.alpha0+
https://bugs.documentfoundation.org/show_bug.cgi?id=115020 --- Comment #8 from Xavier Van Wijmeersch--- no repro with Version: 6.0.1.0.0+ Build ID: 1f497913901972fd51c222a5824c21f6bda5c0db CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115020] Cutting a large dataset is very slow since 6.1.0.0.alpha0+
https://bugs.documentfoundation.org/show_bug.cgi?id=115020 Telestochanged: What|Removed |Added Keywords||bibisectRequest, perf, ||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/main/ChartController.cxx | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) New commits: commit 5836d2be26af9ba4c38e8677e4c9f6f640f273be Author: Vasily MelenchukDate: Mon Jan 15 20:02:53 2018 +0300 Code simplification: both if branches are doing same. Change-Id: I92a51fc62a051390a5e1b3790906cbd2135a53a7 Reviewed-on: https://gerrit.libreoffice.org/47909 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx index b2b8dbdc9720..1348c7aedb1b 100644 --- a/chart2/source/controller/main/ChartController.cxx +++ b/chart2/source/controller/main/ChartController.cxx @@ -717,15 +717,7 @@ sal_Bool SAL_CALL ChartController::suspend( sal_Bool bSuspend ) } //change suspend mode -if(bSuspend) -{ -m_bSuspended = bSuspend; -return true; -} -else -{ -m_bSuspended = bSuspend; -} +m_bSuspended = bSuspend; return true; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115020] Cutting a large dataset is very slow since 6.1.0.0.alpha0+
https://bugs.documentfoundation.org/show_bug.cgi?id=115020 --- Comment #7 from Xavier Van Wijmeersch--- it takes 5.5 seconds with Version: 5.4.4.2 Build ID: 2524958677847fb3bb44820e40380acbe820f960 CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 Telestochanged: What|Removed |Added CC||cpkel...@cox.net --- Comment #112 from Telesto --- *** Bug 115028 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115028] Page orientation problem on attempting to print with Epson XP820
https://bugs.documentfoundation.org/show_bug.cgi?id=115028 Telestochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Telesto --- Please update to LibreOffice 5.4.4 *** This bug has been marked as a duplicate of bug 92190 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loolkitconfig.xcu
loolkitconfig.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0150762d141f24fb048a069209c2b0de1f77e969 Author: Pranav KantDate: Fri Jan 12 18:39:34 2018 +0530 loolkitconfig.xcu: /home is only available in debug builds, not release ... so the problem as mentioned in 831c79c0acbca6a7053080061b14381640c4abb7 was only fixed for debug builds. Change-Id: I549a4765af558a7969e5a96717b36612bd89f22b (cherry picked from commit 57387bf2b42caca704b3df30045d33e295f202ea) Reviewed-on: https://gerrit.libreoffice.org/47809 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loolkitconfig.xcu b/loolkitconfig.xcu index ae2cd1ed..a80508aa 100644 --- a/loolkitconfig.xcu +++ b/loolkitconfig.xcu @@ -11,6 +11,6 @@ false -file:///home +file:///tmp ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loleaflet/dist
loleaflet/dist/loleaflet.css |5 + 1 file changed, 5 insertions(+) New commits: commit f3cb71180b5814eb36f0e0bfaac77f7f8b758841 Author: Pranav KantDate: Fri Jan 12 18:19:50 2018 +0530 loleaflet: Don't allow selecting the dialog canvas Change-Id: I8c88183f0fbb29b5cd815240105153b71c5eb2ce Reviewed-on: https://gerrit.libreoffice.org/47808 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css index 79e04619..57185f0e 100644 --- a/loleaflet/dist/loleaflet.css +++ b/loleaflet/dist/loleaflet.css @@ -352,4 +352,9 @@ body { cursor: default; display: block; /* required to remove all borders around canvas element */ caret-color: transparent; /* firefox shows a caret otherwise on top-left of the canvas */ +user-select: none; +-moz-user-select: none; +-khtml-user-select: none; +-webkit-user-select: none; +-o-user-select: none; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115027] Missing blue page break line when adding a new page ( afters only after scrolling)
https://bugs.documentfoundation.org/show_bug.cgi?id=115027 --- Comment #1 from Telesto--- Has some similarity with bug 107305 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loleaflet/dist
loleaflet/dist/loleaflet.css |1 + 1 file changed, 1 insertion(+) New commits: commit 57621181fd3f1ca774129fb31a939114333f97f1 Author: Pranav KantDate: Fri Jan 12 18:14:16 2018 +0530 loleaflet: hide the caret on dialog canvas Otherwise, on firefox, when the dialog canvas has the focus, a caret different from the one overlayed by LOK, is shown. Change-Id: Ie38aae59f01a3811becca0bcf50c9d7d240bfa9b Reviewed-on: https://gerrit.libreoffice.org/47807 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css index 38d9383e..79e04619 100644 --- a/loleaflet/dist/loleaflet.css +++ b/loleaflet/dist/loleaflet.css @@ -351,4 +351,5 @@ body { .lokdialog_canvas { cursor: default; display: block; /* required to remove all borders around canvas element */ +caret-color: transparent; /* firefox shows a caret otherwise on top-left of the canvas */ } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - wsd/DocumentBroker.cpp
wsd/DocumentBroker.cpp |7 +++ 1 file changed, 7 insertions(+) New commits: commit 0da449bbd9968fb580b90fbeb0672437b7f5f832 Author: Michael MeeksDate: Fri Jan 12 16:16:56 2018 + Warn if we exit with a modified document around. Change-Id: Ie38ab49c66358f674e14820a6ffa993c25aa9e92 Reviewed-on: https://gerrit.libreoffice.org/47822 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index f149f36c..6c6da1f5 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -297,6 +297,13 @@ void DocumentBroker::pollThread() _poll->continuePolling() << ", ShutdownRequestFlag: " << ShutdownRequestFlag << ", TerminationFlag: " << TerminationFlag << "."); +if (_isModified) +{ +std::stringstream state; +dumpState(state); +LOG_ERR("DocumentBroker stopping although modified " << state.str()); +} + // Flush socket data first. const int flushTimeoutMs = POLL_TIMEOUT_MS * 2; // ~1000ms const auto flushStartTime = std::chrono::steady_clock::now(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses
https://bugs.documentfoundation.org/show_bug.cgi?id=108636 Bug 108636 depends on bug 108584, which changed state. Bug 108584 Summary: user\config\autotbl.fmt is read more than a 1000 times every time when cutting some text in Writer (see comment 4) https://bugs.documentfoundation.org/show_bug.cgi?id=108584 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108584] user\config\autotbl.fmt is read more than a 1000 times every time when cutting some text in Writer (see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=108584 Telestochanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Telesto --- No repro with Version: 6.1.0.0.alpha0+ Build ID: 80fb8d406ced47e6a2089f0c8ba5c103d2fec91f CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-01-15_05:18:42 Locale: nl-NL (nl_NL); Calc: CL Based on comment 4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loleaflet/src
loleaflet/src/control/Control.Menubar.js |2 ++ 1 file changed, 2 insertions(+) New commits: commit 9f44565598e6da9d8e2d9efb63c0a47cfb4f1611 Author: Andras TimarDate: Tue Jan 9 10:45:53 2018 +0100 Put checkmark if spell checking language 'None' is selected Change-Id: Iccbcbce2590b70c115199fcdb57bd5174d9c3a80 Reviewed-on: https://gerrit.libreoffice.org/47639 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 68d6fb9c..1a458b1b 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -538,6 +538,8 @@ L.Control.Menubar = L.Control.extend({ var data = decodeURIComponent($(aItem).data('uno')); if (data.indexOf(lang) !== -1) { $(aItem).addClass('lo-menu-item-checked'); + } else if (data.indexOf('LANGUAGE_NONE') !== -1 && lang === '[None]') { + $(aItem).addClass('lo-menu-item-checked'); } else { $(aItem).removeClass('lo-menu-item-checked'); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loleaflet/src loleaflet/unocommands.js
loleaflet/src/control/Control.Menubar.js | 42 ++- loleaflet/unocommands.js |1 2 files changed, 5 insertions(+), 38 deletions(-) New commits: commit d61ce94ebf0d1ed78f1f71423f6ba7d33290b983 Author: Andras TimarDate: Tue Jan 9 10:17:02 2018 +0100 Format - Page... dialog instead of custom Page menus Change-Id: I7b91505a7f875fa67d4e5214bd697451c4b3c5e2 Reviewed-on: https://gerrit.libreoffice.org/47634 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 353672fd..68d6fb9c 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -157,18 +157,10 @@ L.Control.Menubar = L.Control.extend({ {uno: '.uno:FontDialog'}, {uno: '.uno:ParagraphDialog'}, {uno: '.uno:OutlineBullet'}, + {uno: '.uno:PageDialog'}, {type: 'separator'}, - {uno: '.uno:ResetAttributes'}, - {name: _('Page'), type: 'menu', menu: [ - {name: 'A4, ' + _('Portrait'), type: 'action', id: 'a4portrait'}, - {name: 'A4, ' + _('Landscape'), type: 'action', id: 'a4landscape'}, - {name: 'A5, ' + _('Portrait'), type: 'action', id: 'a5portrait'}, - {name: 'A5, ' + _('Landscape'), type: 'action', id: 'a5landscape'}, - {name: 'Letter, ' + _('Portrait'), type: 'action', id: 'letterportrait'}, - {name: 'Letter, ' + _('Landscape'), type: 'action', id: 'letterlandscape'}, - {name: 'Legal, ' + _('Portrait'), type: 'action', id: 'legalportrait'}, - {name: 'Legal, ' + _('Landscape'), type: 'action', id: 'legallandscape'}]}] - }, + {uno: '.uno:ResetAttributes'} + ]}, {name: _UNO('.uno:TableMenu', 'text'), type: 'menu', menu: [ {name: _UNO('.uno:TableInsertMenu', 'text'), type: 'menu', menu: [ {uno: '.uno:InsertRowsBefore'}, @@ -658,35 +650,9 @@ L.Control.Menubar = L.Control.extend({ map.fire('postMessage', {msgId: 'close', args: {EverModified: map._everModified, Deprecated: true}}); map.fire('postMessage', {msgId: 'UI_Close', args: {EverModified: map._everModified}}); map.remove(); - } - else if (id === 'repair') { + } else if (id === 'repair') { map._socket.sendMessage('commandvalues command=.uno:DocumentRepair'); - } else if (id === 'a4portrait') { - map.sendUnoCommand('.uno:AttributePageSize {"AttributePageSize.Width":{"type":"long", "value": "21000"},"AttributePageSize.Height":{"type":"long", "value": "29700"}}'); - map.sendUnoCommand('.uno:AttributePage {"AttributePage.Landscape":{"type":"boolean", "value": "false"}}'); - } else if (id === 'a4landscape') { - map.sendUnoCommand('.uno:AttributePageSize {"AttributePageSize.Height":{"type":"long", "value": "21000"},"AttributePageSize.Width":{"type":"long", "value": "29700"}}'); - map.sendUnoCommand('.uno:AttributePage {"AttributePage.Landscape":{"type":"boolean", "value": "true"}}'); - } else if (id === 'a5portrait') { - map.sendUnoCommand('.uno:AttributePageSize {"AttributePageSize.Width":{"type":"long", "value": "14800"},"AttributePageSize.Height":{"type":"long", "value": "21000"}}'); - map.sendUnoCommand('.uno:AttributePage {"AttributePage.Landscape":{"type":"boolean", "value": "false"}}'); - } else if (id === 'a5landscape') { - map.sendUnoCommand('.uno:AttributePageSize {"AttributePageSize.Height":{"type":"long", "value": "14800"},"AttributePageSize.Width":{"type":"long", "value": "21000"}}'); - map.sendUnoCommand('.uno:AttributePage {"AttributePage.Landscape":{"type":"boolean", "value": "true"}}'); - } else if (id === 'letterportrait') { - map.sendUnoCommand('.uno:AttributePageSize {"AttributePageSize.Width":{"type":"long", "value": "21950"},"AttributePageSize.Height":{"type":"long", "value": "27940"}}'); - map.sendUnoCommand('.uno:AttributePage
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - loleaflet/src
loleaflet/src/control/Control.Menubar.js |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4decf25294f636f0b61546f49a99f7066ed0ae6f Author: Andras TimarDate: Tue Jan 9 09:36:35 2018 +0100 Only show checkmarks in Language -> For selection menu Change-Id: I420b7f9fd1559fdeeedf8836c09021bee36dcbb6 Reviewed-on: https://gerrit.libreoffice.org/47631 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 89bbc507..353672fd 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -541,7 +541,7 @@ L.Control.Menubar = L.Control.extend({ } else { $(aItem).removeClass('disabled'); } - if (unoCommand.indexOf('.uno:LanguageStatus') !== -1) { + if (unoCommand.indexOf('.uno:LanguageStatus?Language:string=Current_') !== -1) { var lang = map['stateChangeHandler'].getItemValue('.uno:LanguageStatus'); var data = decodeURIComponent($(aItem).data('uno')); if (data.indexOf(lang) !== -1) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115028] New: Page orientation problem on attempting to print with Epson XP820
https://bugs.documentfoundation.org/show_bug.cgi?id=115028 Bug ID: 115028 Summary: Page orientation problem on attempting to print with Epson XP820 Product: LibreOffice Version: 5.3.7.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cpkel...@cox.net Description: The document I created using the word processing unit displayed in portrait format, but when I attempted to print it, the printout was in landscape. What was unusual was that the print display that popped up had no orientation option, so there was no way to change from the landscape orientation. I'm operating with an iMac with the High Sierra OS (OSX 10.13.2) and an Intel Core i5. Steps to Reproduce: 1.Create a word document in portrait format 2.Hit the printer icon or the command-P keys 3.Print the document Actual Results: Document prints out in landscape format Expected Results: Document should print out in portrait format Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85299] FORMATTING: bullets list style not retained after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=85299 --- Comment #17 from n.lederba...@tsn.at --- Created attachment 139117 --> https://bugs.documentfoundation.org/attachment.cgi?id=139117=edit a test for list points I made myself a template with all the necessary points: font, font size, border and a list hierarchy Infortunately i am not able to find the same order of list points as i find in the document before. So I tried to fix the order of list-points. Impossible. With the list written I can't change the order witout an unexpectet behaviour of the points. The main fault is, that I don't want to use the list-point-formatting that LO-Writer proposes. So when you change the intendation, all is completely in disorder and there is no way to find an issue. When in the list-point dialogue I mark the case "relative", I get minus-number back. Why can't I save all my changes I once have made to find an equal formatting and behaviour for all my documents? I'm using LO Version: 5.4.3.2 on Windows 7 (the same version on Linux Kubuntu 14/04 LTS) Norbert L -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115027] New: Missing blue page break line when adding a new page ( afters only after scrolling)
https://bugs.documentfoundation.org/show_bug.cgi?id=115027 Bug ID: 115027 Summary: Missing blue page break line when adding a new page (afters only after scrolling) Product: LibreOffice Version: 6.0.0.2 rc Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Missing blue page break line when adding a new page (afters only after scrolling) Steps to Reproduce: 1. Open Writer 2. Press CTRL+ENTER Actual Results: No page break line Expected Results: A page break line Reproducible: Always User Profile Reset: No Additional Info: Found in Versie: 6.0.0.2 Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: standaard; Locale: nl-NL (nl_NL); Calc: CL but not in Version: 6.0.0.1.0+ Build ID: d4469196a2072d2d3fa2e433d02552facaa269f2 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 24b339c8a7aa01c51aa36cd81da0e66dbeecb8b8 Author: Christian LohmaierDate: Mon Jan 15 19:42:56 2018 +0100 Updated core Project: translations e871217990589c0b78633ce5d460e70075a32015 update translations after first de-fuzzying round Change-Id: Ie6b488bf4cb510522eb8d92b479b4ab42226698d (cherry picked from commit 030ab61d2b016aaebac10ecaea1774a69b240ce8) diff --git a/translations b/translations index 321ffe14cfa9..e87121799058 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 321ffe14cfa93dce92d2bc4c32f0ca41dda39c47 +Subproject commit e871217990589c0b78633ce5d460e70075a32015 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 33aa58d66e97c48009bcbae6cf2cab349382fb4d Author: Christian LohmaierDate: Mon Jan 15 19:42:56 2018 +0100 Updated core Project: translations 030ab61d2b016aaebac10ecaea1774a69b240ce8 update translations after first de-fuzzying round Change-Id: Ie6b488bf4cb510522eb8d92b479b4ab42226698d diff --git a/translations b/translations index 37dce4e45765..030ab61d2b01 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 37dce4e45765761dcf3ade415b7197a1d7026cdc +Subproject commit 030ab61d2b016aaebac10ecaea1774a69b240ce8 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107636] [META] User profile (user data/settings) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107636 Bug 107636 depends on bug 113783, which changed state. Bug 113783 Summary: Change user profile folder for 6.0 https://bugs.documentfoundation.org/show_bug.cgi?id=113783 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113783] Change user profile folder for 6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=113783 Yousuf Philips (jay)changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #11 from Yousuf Philips (jay) --- ESC decided to reject this suggestion as there we dont provide a means to migrate user data. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115020] Cutting a large dataset is very slow since 6.1.0.0.alpha0+
https://bugs.documentfoundation.org/show_bug.cgi?id=115020 Telestochanged: What|Removed |Added Summary|Cutting a large dataset is |Cutting a large dataset is |very slow compared to |very slow since |6.0.0.0.alpha1+ |6.1.0.0.alpha0+ --- Comment #6 from Telesto --- No repro with Versie: 6.0.0.2 Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85299] FORMATTING: bullets list style not retained after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=85299 --- Comment #16 from n.lederba...@tsn.at --- Created attachment 139116 --> https://bugs.documentfoundation.org/attachment.cgi?id=139116=edit 1. a finished document This is a document that I made 2013. There are no changes by reopening it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)
https://bugs.documentfoundation.org/show_bug.cgi?id=115026 Telestochanged: What|Removed |Added CC||philip...@hotmail.com --- Comment #2 from Telesto --- @Jay, Thought you might be interested in this one -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115026] EDITING: LibreOffice ignores page break when adding a table to the second page ( & deletes a page in a certain case)
https://bugs.documentfoundation.org/show_bug.cgi?id=115026 --- Comment #1 from Telesto--- Created attachment 139115 --> https://bugs.documentfoundation.org/attachment.cgi?id=139115=edit Bibisect log Bisected to: author Jim Raykowski 2017-10-31 15:48:07 -0800 committer Yousuf Philips 2017-12-27 15:27:50 +0100 commit 203b913155812706e9be14c5fe2b8f543cc4fdc7 (patch) treee2233e80cbc67d0bf834d4eb716ff935cebe6d08 parent 023949fac0043408ac1b86dc67732666d041875e (diff) tdf#107555 Apply 'Default Style' table style to newly inserted tables -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - lotuswordpro/inc lotuswordpro/source
lotuswordpro/inc/lwpfrib.hxx|4 lotuswordpro/source/filter/lwpchangemgr.cxx |2 ++ lotuswordpro/source/filter/lwpfrib.cxx | 18 +- 3 files changed, 23 insertions(+), 1 deletion(-) New commits: commit a4bae5beeb71edb8b3ac51f9775e16a889560524 Author: Caolán McNamaraDate: Fri Jan 12 09:43:41 2018 + ofz#5254 Bad-cast Change-Id: I318d441d841dd4c783f87ac2f3f699852e8b1039 Reviewed-on: https://gerrit.libreoffice.org/47804 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/lotuswordpro/inc/lwpfrib.hxx b/lotuswordpro/inc/lwpfrib.hxx index 4e824c0002f4..6ff3cad39a98 100644 --- a/lotuswordpro/inc/lwpfrib.hxx +++ b/lotuswordpro/inc/lwpfrib.hxx @@ -97,6 +97,7 @@ public: OUString GetEditor(); XFColor GetHighlightColor(); protected: +std::map * m_pFribMap; LwpPara* m_pPara; LwpFrib* m_pNext; sal_uInt8 m_nFribType; @@ -119,6 +120,9 @@ public: REV_INSERT =0, REV_DELETE = 1, }; + +void Register(std::map * pFribMap); +void Deregister(); private: static void ReadModifiers(LwpObjectStream* pObjStrm,ModifierInfo* pModInfo); protected: diff --git a/lotuswordpro/source/filter/lwpchangemgr.cxx b/lotuswordpro/source/filter/lwpchangemgr.cxx index e08ee979869d..c04241aaccb4 100644 --- a/lotuswordpro/source/filter/lwpchangemgr.cxx +++ b/lotuswordpro/source/filter/lwpchangemgr.cxx @@ -89,6 +89,7 @@ LwpChangeMgr::LwpChangeMgr() m_pFribMap = _DocFribMap; m_ChangeList.clear(); } + LwpChangeMgr::~LwpChangeMgr() { m_pFribMap=nullptr; @@ -102,6 +103,7 @@ void LwpChangeMgr::AddChangeFrib(LwpFrib* pFrib) m_nCounter++; OUString sID = "ct"+ OUString::number(m_nCounter); m_pFribMap->insert(std::pair (pFrib,sID)); +pFrib->Register(m_pFribMap); } OUString LwpChangeMgr::GetChangeID(LwpFrib* pFrib) diff --git a/lotuswordpro/source/filter/lwpfrib.cxx b/lotuswordpro/source/filter/lwpfrib.cxx index f9b3ad759d3c..919b257be043 100644 --- a/lotuswordpro/source/filter/lwpfrib.cxx +++ b/lotuswordpro/source/filter/lwpfrib.cxx @@ -87,7 +87,8 @@ LwpFrib::LwpFrib(LwpPara* pPara) -: m_pPara(pPara) +: m_pFribMap(nullptr) +, m_pPara(pPara) , m_pNext(nullptr) , m_nFribType(0) , m_pModifiers(nullptr) @@ -100,6 +101,7 @@ LwpFrib::LwpFrib(LwpPara* pPara) LwpFrib::~LwpFrib() { +Deregister(); } LwpFrib* LwpFrib::CreateFrib(LwpPara* pPara, LwpObjectStream* pObjStrm, sal_uInt8 fribtag,sal_uInt8 editID) @@ -447,4 +449,18 @@ XFColor LwpFrib::GetHighlightColor() return pGlobal->GetHighlightColor(m_nEditor); } +void LwpFrib::Register(std::map * pFribMap) +{ +m_pFribMap = pFribMap; +} + +void LwpFrib::Deregister() +{ +if (m_pFribMap) +{ +m_pFribMap->erase(this); +m_pFribMap = nullptr; +} +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - lotuswordpro/source
lotuswordpro/source/filter/lwpchangemgr.cxx |2 ++ lotuswordpro/source/filter/lwpfrib.cxx | 18 +- lotuswordpro/source/filter/lwpfrib.hxx |4 3 files changed, 23 insertions(+), 1 deletion(-) New commits: commit f8a1dd7ae35ea0307a9282378a9300897df6fb42 Author: Caolán McNamaraDate: Fri Jan 12 09:43:41 2018 + ofz#5254 Bad-cast Change-Id: I318d441d841dd4c783f87ac2f3f699852e8b1039 Reviewed-on: https://gerrit.libreoffice.org/47805 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/lotuswordpro/source/filter/lwpchangemgr.cxx b/lotuswordpro/source/filter/lwpchangemgr.cxx index 30b272e35ccc..cbd9b58aa805 100644 --- a/lotuswordpro/source/filter/lwpchangemgr.cxx +++ b/lotuswordpro/source/filter/lwpchangemgr.cxx @@ -89,6 +89,7 @@ LwpChangeMgr::LwpChangeMgr() m_pFribMap = _DocFribMap; m_ChangeList.clear(); } + LwpChangeMgr::~LwpChangeMgr() { m_pFribMap=nullptr; @@ -102,6 +103,7 @@ void LwpChangeMgr::AddChangeFrib(LwpFrib* pFrib) m_nCounter++; OUString sID = "ct"+ OUString::number(m_nCounter); m_pFribMap->insert(std::pair (pFrib,sID)); +pFrib->Register(m_pFribMap); } OUString LwpChangeMgr::GetChangeID(LwpFrib* pFrib) diff --git a/lotuswordpro/source/filter/lwpfrib.cxx b/lotuswordpro/source/filter/lwpfrib.cxx index bd951118d48d..baebf753ed03 100644 --- a/lotuswordpro/source/filter/lwpfrib.cxx +++ b/lotuswordpro/source/filter/lwpfrib.cxx @@ -87,7 +87,8 @@ LwpFrib::LwpFrib(LwpPara* pPara) -: m_pPara(pPara) +: m_pFribMap(nullptr) +, m_pPara(pPara) , m_pNext(nullptr) , m_nFribType(0) , m_pModifiers(nullptr) @@ -100,6 +101,7 @@ LwpFrib::LwpFrib(LwpPara* pPara) LwpFrib::~LwpFrib() { +Deregister(); } LwpFrib* LwpFrib::CreateFrib(LwpPara* pPara, LwpObjectStream* pObjStrm, sal_uInt8 fribtag,sal_uInt8 editID) @@ -447,4 +449,18 @@ XFColor LwpFrib::GetHighlightColor() return pGlobal->GetHighlightColor(m_nEditor); } +void LwpFrib::Register(std::map * pFribMap) +{ +m_pFribMap = pFribMap; +} + +void LwpFrib::Deregister() +{ +if (m_pFribMap) +{ +m_pFribMap->erase(this); +m_pFribMap = nullptr; +} +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/lotuswordpro/source/filter/lwpfrib.hxx b/lotuswordpro/source/filter/lwpfrib.hxx index 910f85dee08f..6fde006a649e 100644 --- a/lotuswordpro/source/filter/lwpfrib.hxx +++ b/lotuswordpro/source/filter/lwpfrib.hxx @@ -97,6 +97,7 @@ public: OUString GetEditor(); XFColor GetHighlightColor(); protected: +std::map * m_pFribMap; LwpPara* m_pPara; LwpFrib* m_pNext; sal_uInt8 m_nFribType; @@ -119,6 +120,9 @@ public: REV_INSERT =0, REV_DELETE = 1, }; + +void Register(std::map * pFribMap); +void Deregister(); private: static void ReadModifiers(LwpObjectStream* pObjStrm,ModifierInfo* pModInfo); protected: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 84579] COLOR PICKER: Text label of currently selected color should appear in widget
https://bugs.documentfoundation.org/show_bug.cgi?id=84579 --- Comment #28 from V Stuart Foote--- Created attachment 139114 --> https://bugs.documentfoundation.org/attachment.cgi?id=139114=edit RGB Hex appended to color picker's label -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs