date:20180125

[Libreoffice-commits] core.git: sw/qa sw/source

2018-01-25 Thread Andrea Gelmini

 sw/qa/extras/tiledrendering/tiledrendering.cxx |2 +-
 sw/source/uibase/uiview/viewling.cxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6e36e0ce006a85fb286b787def737bff6c8e9d8f
Author: Andrea Gelmini 
Date:   Fri Jan 26 08:44:07 2018 +0100

Fix typos

Change-Id: Iffdbe1ce151f31b65e353cf87aaa1e0102d4430d
Reviewed-on: https://gerrit.libreoffice.org/48653
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index c89b9cf844ef..3bf2d07a595f 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -2046,7 +2046,7 @@ void SwTiledRenderingTest::testTdf115088()
 Scheduler::ProcessEventsToIdle();
 comphelper::dispatchCommand(".uno:Copy", 
uno::Sequence());
 
-// Move cursor to the begining of the first line and paste
+// Move cursor to the beginning of the first line and paste
 pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_HOME | 
KEY_MOD1);
 pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_HOME | KEY_MOD1);
 Scheduler::ProcessEventsToIdle();
diff --git a/sw/source/uibase/uiview/viewling.cxx 
b/sw/source/uibase/uiview/viewling.cxx
index cb7f8b11c546..2057a113ad0c 100644
--- a/sw/source/uibase/uiview/viewling.cxx
+++ b/sw/source/uibase/uiview/viewling.cxx
@@ -572,7 +572,7 @@ void SwView::StartThesaurus()
 
 if (pDlg)
 {
-guard.dismiss(); // ignore, we'll call SetIdle() explictly after 
the dialog ends
+guard.dismiss(); // ignore, we'll call SetIdle() explicitly after 
the dialog ends
 
 pDlg->StartExecuteAsync([=](sal_Int32 nResult){
 if (nResult == RET_OK )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114028] LibreOffice Vanilla doesn' t include help and displayed help message is incorrect / unhelpful

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114028

Alex Thurgood  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88205] Adapt uses of css::uno::Sequence to use initializer_list ctor

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88205

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.4.0   |target:5.3.0 target:5.4.0
   ||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114028] LibreOffice Vanilla doesn' t include help and displayed help message is incorrect / unhelpful

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114028

Alex Thurgood  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Alex Thurgood  ---
Confirming fixed in 

Version: 5.4.4.5
Build ID: 2524958677847fb3bb44820e40380acbe820f960
Threads CPU : 4; OS : Mac OS X 10.13.3; UI Render : par défaut; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group


Thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

2018-01-25 Thread ekuiitr

 desktop/source/migration/services/jvmfwk.cxx|3 +--
 desktop/source/migration/services/oo3extensionmigration.cxx |2 +-
 desktop/source/migration/services/wordbookmigration.cxx |2 +-
 desktop/source/offacc/acceptor.cxx  |3 +--
 4 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 155dd4ebec9c38c0c478f648b09045e037818aea
Author: ekuiitr 
Date:   Fri Jan 26 00:07:43 2018 +0530

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

Change-Id: Idc14e71c732ce031b9bec556401dc84fd0757b6b
Reviewed-on: https://gerrit.libreoffice.org/48636
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/desktop/source/migration/services/jvmfwk.cxx 
b/desktop/source/migration/services/jvmfwk.cxx
index fc858ec3a039..24e0d50930c0 100644
--- a/desktop/source/migration/services/jvmfwk.cxx
+++ b/desktop/source/migration/services/jvmfwk.cxx
@@ -152,8 +152,7 @@ OUString jvmfwk_getImplementationName()
 
 css::uno::Sequence< OUString > jvmfwk_getSupportedServiceNames()
 {
-OUString str_name = SERVICE_NAME;
-return css::uno::Sequence< OUString >( _name, 1 );
+return { SERVICE_NAME };
 }
 
 // XServiceInfo
diff --git a/desktop/source/migration/services/oo3extensionmigration.cxx 
b/desktop/source/migration/services/oo3extensionmigration.cxx
index 4510c93d2831..b98b90bf559f 100644
--- a/desktop/source/migration/services/oo3extensionmigration.cxx
+++ b/desktop/source/migration/services/oo3extensionmigration.cxx
@@ -63,7 +63,7 @@ OUString OO3ExtensionMigration_getImplementationName()
 
 Sequence< OUString > OO3ExtensionMigration_getSupportedServiceNames()
 {
-return Sequence< OUString > { "com.sun.star.migration.Extensions" };
+return { "com.sun.star.migration.Extensions" };
 }
 
 
diff --git a/desktop/source/migration/services/wordbookmigration.cxx 
b/desktop/source/migration/services/wordbookmigration.cxx
index ab2264e4d683..8730a8707b29 100644
--- a/desktop/source/migration/services/wordbookmigration.cxx
+++ b/desktop/source/migration/services/wordbookmigration.cxx
@@ -40,7 +40,7 @@ namespace migration
 
 Sequence< OUString > WordbookMigration_getSupportedServiceNames()
 {
-return Sequence< OUString > { "com.sun.star.migration.Wordbooks" };
+return { "com.sun.star.migration.Wordbooks" };
 }
 
 
diff --git a/desktop/source/offacc/acceptor.cxx 
b/desktop/source/offacc/acceptor.cxx
index 6244b79e2c4e..40287169ae97 100644
--- a/desktop/source/offacc/acceptor.cxx
+++ b/desktop/source/offacc/acceptor.cxx
@@ -188,8 +188,7 @@ OUString Acceptor::getImplementationName()
 }
 Sequence Acceptor::impl_getSupportedServiceNames()
 {
-Sequence aSequence { "com.sun.star.office.Acceptor" };
-return aSequence;
+return { "com.sun.star.office.Acceptor" };
 }
 Sequence Acceptor::getSupportedServiceNames()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107642] [META] Paragraph dialog bugs and enhancements

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107642
Bug 107642 depends on bug 107567, which changed state.

Bug 107567 Summary: Text previews in Paragraph dialog not showing correctly for 
RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=107567

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88205] Adapt uses of css::uno::Sequence to use initializer_list ctor

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88205

--- Comment #37 from Commit Notification 
 ---
ekuiitr committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=155dd4ebec9c38c0c478f648b09045e037818aea

tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114027] [META] Libreoffice Vanilla (Mac Appstore version) bugs and enhancements

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114027
Bug 114027 depends on bug 114028, which changed state.

Bug 114028 Summary: LibreOffice Vanilla doesn't include help and displayed help 
message is incorrect / unhelpful
https://bugs.documentfoundation.org/show_bug.cgi?id=114028

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||s.mehrbr...@gmail.com
 Resolution|--- |FIXED

--- Comment #15 from Samuel Mehrbrodt (CIB)  ---
Can someone please verify the fix? Then we can backport this to 6.0 too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
Bug 43808 depends on bug 107567, which changed state.

Bug 107567 Summary: Text previews in Paragraph dialog not showing correctly for 
RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=107567

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

2018-01-25 Thread Noel Grandin

 ucb/source/sorter/sortresult.cxx |   11 ---
 ucb/source/sorter/sortresult.hxx |5 +++--
 2 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit 47ae2add3a818dff6c85c5a4376772b542258484
Author: Noel Grandin 
Date:   Tue Jan 23 08:56:19 2018 +0200

loplugin:useuniqueptr in SortedResultSet

Change-Id: Ib57cf4b30afda6f5e0d024a0c72417f6b1786e9a
Reviewed-on: https://gerrit.libreoffice.org/48588
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx
index 4041fdcb806e..e18360794bf4 100644
--- a/ucb/source/sorter/sortresult.cxx
+++ b/ucb/source/sorter/sortresult.cxx
@@ -141,9 +141,6 @@ SortedResultSet::~SortedResultSet()
 mpSortInfo = nullptr;
 
 mpPropSetInfo.clear();
-
-delete mpPropChangeListeners;
-delete mpVetoChangeListeners;
 }
 
 
@@ -823,8 +820,8 @@ void SAL_CALL SortedResultSet::addPropertyChangeListener(
 osl::Guard< osl::Mutex > aGuard( maMutex );
 
 if ( !mpPropChangeListeners )
-mpPropChangeListeners =
-new PropertyChangeListeners_Impl();
+mpPropChangeListeners.reset(
+new PropertyChangeListeners_Impl() );
 
 mpPropChangeListeners->addInterface( PropertyName, Listener );
 }
@@ -848,8 +845,8 @@ void SAL_CALL SortedResultSet::addVetoableChangeListener(
 osl::Guard< osl::Mutex > aGuard( maMutex );
 
 if ( !mpVetoChangeListeners )
-mpVetoChangeListeners =
-new PropertyChangeListeners_Impl();
+mpVetoChangeListeners.reset(
+new PropertyChangeListeners_Impl() );
 
 mpVetoChangeListeners->addInterface( PropertyName, Listener );
 }
diff --git a/ucb/source/sorter/sortresult.hxx b/ucb/source/sorter/sortresult.hxx
index 649a5c957e5d..f97f9050c6bc 100644
--- a/ucb/source/sorter/sortresult.hxx
+++ b/ucb/source/sorter/sortresult.hxx
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace comphelper {
 class OInterfaceContainerHelper2;
@@ -99,8 +100,8 @@ class SortedResultSet: public cppu::WeakImplHelper <
 css::beans::XPropertySet >
 {
 comphelper::OInterfaceContainerHelper2 *mpDisposeEventListeners;
-PropertyChangeListeners_Impl*mpPropChangeListeners;
-PropertyChangeListeners_Impl*mpVetoChangeListeners;
+std::unique_ptrmpPropChangeListeners;
+std::unique_ptrmpVetoChangeListeners;
 
 css::uno::Reference < css::sdbc::XResultSet >mxOriginal;
 css::uno::Reference < css::sdbc::XResultSet >mxOther;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: ucb/source

2018-01-25 Thread Noel Grandin

 ucb/source/sorter/sortdynres.cxx |6 +++---
 ucb/source/sorter/sortdynres.hxx |3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit b4155c305daf5c64b964bb2b8ea8d6bd672fd46b
Author: Noel Grandin 
Date:   Mon Jan 22 14:24:02 2018 +0200

loplugin:useuniqueptr in SortedDynamicResultSet

Change-Id: Ife4849926f26631bbe65bd22158165fac306cd43
Reviewed-on: https://gerrit.libreoffice.org/48586
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/sorter/sortdynres.cxx b/ucb/source/sorter/sortdynres.cxx
index 7d8fef03c82c..114d29c5f2e6 100644
--- a/ucb/source/sorter/sortdynres.cxx
+++ b/ucb/source/sorter/sortdynres.cxx
@@ -73,7 +73,7 @@ SortedDynamicResultSet::~SortedDynamicResultSet()
 mxOwnListener->impl_OwnerDies();
 mxOwnListener.clear();
 
-delete mpDisposeEventListeners;
+mpDisposeEventListeners.reset();
 
 mxOne.clear();
 mxTwo.clear();
@@ -123,8 +123,8 @@ void SAL_CALL SortedDynamicResultSet::addEventListener(
 osl::Guard< osl::Mutex > aGuard( maMutex );
 
 if ( !mpDisposeEventListeners )
-mpDisposeEventListeners =
-new OInterfaceContainerHelper2( getContainerMutex() );
+mpDisposeEventListeners.reset(
+new OInterfaceContainerHelper2( getContainerMutex() ) );
 
 mpDisposeEventListeners->addInterface( Listener );
 }
diff --git a/ucb/source/sorter/sortdynres.hxx b/ucb/source/sorter/sortdynres.hxx
index 9e100df1f143..d121ba52683c 100644
--- a/ucb/source/sorter/sortdynres.hxx
+++ b/ucb/source/sorter/sortdynres.hxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "sortresult.hxx"
 
 
@@ -44,7 +45,7 @@ class SortedDynamicResultSet: public cppu::WeakImplHelper <
 css::lang::XServiceInfo,
 css::ucb::XDynamicResultSet >
 {
-comphelper::OInterfaceContainerHelper2 *mpDisposeEventListeners;
+std::unique_ptr  
mpDisposeEventListeners;
 
 css::uno::Reference < css::ucb::XDynamicResultSetListener > mxListener;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #14 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=122da2eea23faf6916c3f3b9e1895f5c404b26c7

tdf#107567 et al. Paragraph dialog preview windows fixes

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

2018-01-25 Thread Noel Grandin

 ucb/source/core/ucbstore.cxx |   29 ++---
 1 file changed, 10 insertions(+), 19 deletions(-)

New commits:
commit 3cf85c9ff1975ed086eb9a390ea870d39313fed1
Author: Noel Grandin 
Date:   Mon Jan 22 14:26:02 2018 +0200

loplugin:useuniqueptr in PersistentPropertySet_Impl

Change-Id: I78259770767fd3bbe3217f20a513703e7347288f
Reviewed-on: https://gerrit.libreoffice.org/48587
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/core/ucbstore.cxx b/ucb/source/core/ucbstore.cxx
index 5e3fdfa90d53..62909dd6c692 100644
--- a/ucb/source/core/ucbstore.cxx
+++ b/ucb/source/core/ucbstore.cxx
@@ -1059,24 +1059,15 @@ struct PersistentPropertySet_Impl
 OUStringm_aKey;
 OUStringm_aFullKey;
 osl::Mutex  m_aMutex;
-OInterfaceContainerHelper2*  m_pDisposeEventListeners;
-OInterfaceContainerHelper2*  m_pPropSetChangeListeners;
-PropertyListeners_Impl* m_pPropertyChangeListeners;
+std::unique_ptr  m_pDisposeEventListeners;
+std::unique_ptr  m_pPropSetChangeListeners;
+std::unique_ptr  m_pPropertyChangeListeners;
 
 PersistentPropertySet_Impl( PropertySetRegistry& rCreator,
 const OUString& rKey )
-: m_pCreator(  ), m_pInfo( nullptr ), m_aKey( rKey ),
-  m_pDisposeEventListeners( nullptr ), m_pPropSetChangeListeners( nullptr 
),
-  m_pPropertyChangeListeners( nullptr )
+: m_pCreator(  ), m_pInfo( nullptr ), m_aKey( rKey )
 {
 }
-
-~PersistentPropertySet_Impl()
-{
-delete m_pDisposeEventListeners;
-delete m_pPropSetChangeListeners;
-delete m_pPropertyChangeListeners;
-}
 };
 
 
@@ -1155,8 +1146,8 @@ void SAL_CALL PersistentPropertySet::addEventListener(
 const Reference< XEventListener >& Listener )
 {
 if ( !m_pImpl->m_pDisposeEventListeners )
-m_pImpl->m_pDisposeEventListeners =
-new OInterfaceContainerHelper2( m_pImpl->m_aMutex );
+m_pImpl->m_pDisposeEventListeners.reset(
+new OInterfaceContainerHelper2( m_pImpl->m_aMutex ) );
 
 m_pImpl->m_pDisposeEventListeners->addInterface( Listener );
 }
@@ -1329,8 +1320,8 @@ void SAL_CALL 
PersistentPropertySet::addPropertyChangeListener(
 //  load();
 
 if ( !m_pImpl->m_pPropertyChangeListeners )
-m_pImpl->m_pPropertyChangeListeners =
-new PropertyListeners_Impl( m_pImpl->m_aMutex );
+m_pImpl->m_pPropertyChangeListeners.reset(
+new PropertyListeners_Impl( m_pImpl->m_aMutex ) );
 
 m_pImpl->m_pPropertyChangeListeners->addInterface(
 aPropertyName, xListener );
@@ -1724,8 +1715,8 @@ void SAL_CALL 
PersistentPropertySet::addPropertySetInfoChangeListener(
 const Reference< XPropertySetInfoChangeListener >& Listener )
 {
 if ( !m_pImpl->m_pPropSetChangeListeners )
-m_pImpl->m_pPropSetChangeListeners =
-new OInterfaceContainerHelper2( m_pImpl->m_aMutex );
+m_pImpl->m_pPropSetChangeListeners.reset(
+new OInterfaceContainerHelper2( m_pImpl->m_aMutex ) );
 
 m_pImpl->m_pPropSetChangeListeners->addInterface( Listener );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - cui/source include/xmloff xmloff/source

2018-01-25 Thread Jim Raykowski

 cui/source/inc/paragrph.hxx  |4 
 cui/source/tabpages/paragrph.cxx |  184 +++
 include/xmloff/txtparae.hxx  |   12 +-
 xmloff/source/text/txtparae.cxx  |   20 ++--
 4 files changed, 129 insertions(+), 91 deletions(-)

New commits:
commit 122da2eea23faf6916c3f3b9e1895f5c404b26c7
Author: Jim Raykowski 
Date:   Sat Nov 18 22:21:24 2017 -0900

tdf#107567 et al. Paragraph dialog preview windows fixes

tdf#107567 tdf#98211 tdf#98212 tdf#113275

Change-Id: I6d11cb809283eee4fa79acae9aa32baaab558833
Reviewed-on: https://gerrit.libreoffice.org/45273
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index 2060cd224064..bc79add8c31c 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -46,6 +46,7 @@ class SvxLineSpacingItem;
 class SvxStdParagraphTabPage: public SfxTabPage
 {
 friend class VclPtr;
+using TabPage::ActivatePage;
 using TabPage::DeactivatePage;
 static const sal_uInt16 pStdRanges[];
 
@@ -94,6 +95,7 @@ private:
 DECL_LINK( AutoHdl_Impl, Button*, void );
 
 protected:
+virtual voidActivatePage( const SfxItemSet& rSet ) override;
 virtual DeactivateRCDeactivatePage( SfxItemSet* pSet ) override;
 
 
@@ -124,6 +126,7 @@ public:
 class SvxParaAlignTabPage : public SfxTabPage
 {
 friend class VclPtr;
+using TabPage::ActivatePage;
 using TabPage::DeactivatePage;
 static const sal_uInt16 pAlignRanges[];
 
@@ -159,6 +162,7 @@ class SvxParaAlignTabPage : public SfxTabPage
 SvxParaAlignTabPage( vcl::Window* pParent, const 
SfxItemSet& rSet );
 
 protected:
+virtual voidActivatePage( const SfxItemSet& rSet ) override;
 virtual DeactivateRCDeactivatePage( SfxItemSet* pSet ) override;
 
 public:
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 5ea77cf288e1..61cdb6603321 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -617,6 +617,43 @@ void SvxStdParagraphTabPage::EnableRelativeMode()
 bRelativeMode = true;
 }
 
+void SvxStdParagraphTabPage::ActivatePage( const SfxItemSet& rSet )
+{
+sal_uInt16 _nWhich = GetWhich( SID_ATTR_PARA_ADJUST );
+SfxItemState eItemState = rSet.GetItemState( _nWhich );
+
+if ( eItemState >= SfxItemState::DEFAULT )
+{
+const SvxAdjustItem& rAdj = static_cast( 
rSet.Get( _nWhich ) );
+SvxAdjust eAdjust = rAdj.GetAdjust();
+if ( eAdjust == SvxAdjust::Center || eAdjust == SvxAdjust::Block )
+{
+_nWhich = GetWhich( SID_ATTR_FRAMEDIRECTION );
+eItemState = rSet.GetItemState( _nWhich );
+
+if ( eItemState >= SfxItemState::DEFAULT )
+{
+const SvxFrameDirectionItem& rFrameDirItem = static_cast( rSet.Get( _nWhich ) );
+SvxFrameDirection eFrameDirection = rFrameDirItem.GetValue();
+
+m_pExampleWin->EnableRTL( SvxFrameDirection::Horizontal_RL_TB 
== eFrameDirection );
+
+if ( eAdjust == SvxAdjust::Block )
+m_pExampleWin->SetLastLine( rAdj.GetLastBlock() );
+}
+}
+else
+{
+m_pExampleWin->EnableRTL( eAdjust == SvxAdjust::Right );
+eAdjust = SvxAdjust::Left; //required for correct preview display
+m_pExampleWin->SetLastLine( eAdjust );
+}
+m_pExampleWin->SetAdjust( eAdjust );
+
+UpdateExample_Impl();
+}
+}
+
 DeactivateRC SvxStdParagraphTabPage::DeactivatePage( SfxItemSet* _pSet )
 {
 ELRLoseFocusHdl( *m_pFLineIndent );
@@ -1002,6 +1039,8 @@ SvxParaAlignTabPage::SvxParaAlignTabPage( vcl::Window* 
pParent, const SfxItemSet
 get(m_pPropertiesFL,"framePROPERTIES");
 get(m_pTextDirectionLB,"comboLB_TEXTDIRECTION");
 
+SetExchangeSupport();
+
 SvtLanguageOptions aLangOptions;
 sal_uInt16 nLastLinePos = LASTLINEPOS_DEFAULT;
 
@@ -1083,69 +1122,35 @@ bool SvxParaAlignTabPage::FillItemSet( SfxItemSet* 
rOutSet )
 {
 bool bModified = false;
 
-bool bAdj = false, bChecked = false;
 SvxAdjust eAdjust = SvxAdjust::Left;
 
 if ( m_pLeft->IsChecked() )
-{
 eAdjust = SvxAdjust::Left;
-bAdj = !m_pLeft->GetSavedValue();
-bChecked = true;
-}
 else if ( m_pRight->IsChecked() )
-{
 eAdjust = SvxAdjust::Right;
-bAdj = !m_pRight->GetSavedValue();
-bChecked = true;
-}
 else if ( m_pCenter->IsChecked() )
-{
 eAdjust = SvxAdjust::Center;
-bAdj = !m_pCenter->GetSavedValue();
-bChecked = true;
-}
 else if ( m_pJustify->IsChecked() )
-{
 eAdjust = SvxAdjust::Block;
-bAdj = !m_pJustify->GetSavedValue() ||
-m_pExpandCB->IsValueChangedFromSaved() ||
-

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang include/svx sd/inc sd/source svx/inc svx/source

2018-01-25 Thread Noel Grandin

 compilerplugins/clang/datamembershadow.cxx|2 -
 include/svx/sdr/contact/objectcontactofobjlistpainter.hxx |2 -
 include/svx/sdr/table/tablecontroller.hxx |2 -
 include/svx/svdedxv.hxx   |3 +
 include/svx/svdobj.hxx|2 -
 include/svx/svdoutl.hxx   |2 -
 include/svx/svdpage.hxx   |2 -
 sd/inc/Outliner.hxx   |2 -
 sd/inc/OutlinerIterator.hxx   |4 +-
 sd/inc/undo/undoobjects.hxx   |   24 +++---
 sd/source/core/stlfamily.cxx  |2 -
 sd/source/ui/func/smarttag.cxx|4 +-
 sd/source/ui/inc/OutlinerIteratorImpl.hxx |4 +-
 sd/source/ui/inc/futext.hxx   |3 +
 sd/source/ui/inc/smarttag.hxx |4 +-
 sd/source/ui/view/OutlinerIterator.cxx|6 +--
 sd/source/ui/view/sdview.cxx  |2 -
 sd/source/ui/view/viewoverlaymanager.cxx  |8 ++--
 svx/inc/sdr/primitive2d/sdrolecontentprimitive2d.hxx  |2 -
 svx/source/sdr/contact/objectcontactofobjlistpainter.cxx  |2 -
 svx/source/svdraw/svdpage.cxx |   10 ++---
 svx/source/table/tableundo.cxx|2 -
 svx/source/table/tableundo.hxx|6 +--
 svx/source/unodraw/gluepts.cxx|2 -
 24 files changed, 49 insertions(+), 53 deletions(-)

New commits:
commit 398bbde8231e77bd4106c09c34839f0f16f2f7ee
Author: Noel Grandin 
Date:   Thu Jan 25 11:50:14 2018 +0200

expand out SdrObjectWeakRef and SdrPageWeakRef typedefs

Change-Id: Icacc7354df4a927533e6fec072cdd527e4c57b96
Reviewed-on: https://gerrit.libreoffice.org/48566
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx 
b/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx
index 380e927ca568..7390f30b08a7 100644
--- a/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx
+++ b/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx
@@ -90,7 +90,7 @@ protected:
 ObjectContact&  mrOriginalObjectContact;
 
 // Set StartPoint for next run, also given in constructor
-SdrPageWeakRef  mxStartPage;
+tools::WeakReference   mxStartPage;
 
 // Hierarchy access methods
 virtual sal_uInt32 GetPaintObjectCount() const override;
diff --git a/include/svx/sdr/table/tablecontroller.hxx 
b/include/svx/sdr/table/tablecontroller.hxx
index 79730758b419..d621d87d2fd0 100644
--- a/include/svx/sdr/table/tablecontroller.hxx
+++ b/include/svx/sdr/table/tablecontroller.hxx
@@ -176,7 +176,7 @@ private:
 sdr::overlay::OverlayObjectList*  mpSelectionOverlay;
 
 SdrView* mpView;
-SdrObjectWeakRef mxTableObj;
+tools::WeakReference mxTableObj;
 SdrModel* mpModel;
 
 css::uno::Reference< css::util::XModifyListener > mxModifyListener;
diff --git a/include/svx/svdedxv.hxx b/include/svx/svdedxv.hxx
index b55385e77d17..20f61dff15af 100644
--- a/include/svx/svdedxv.hxx
+++ b/include/svx/svdedxv.hxx
@@ -74,7 +74,8 @@ class SVX_DLLPUBLIC SdrObjEditView: public SdrGlueEditView, 
public EditViewCallb
 
 protected:
 // TextEdit
-SdrObjectWeakRefmxTextEditObj; // current object in 
TextEdit
+tools::WeakReference
+mxTextEditObj; // current object in 
TextEdit
 SdrPageView*pTextEditPV;
 SdrOutliner*pTextEditOutliner; // outliner for the 
TextEdit
 OutlinerView*   pTextEditOutlinerView; // current view of the 
outliners
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 265ec9b96c72..25ab2c824e14 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -1003,8 +1003,6 @@ private:
 SdrObjFactory() = delete;
 };
 
-typedef tools::WeakReference< SdrObject > SdrObjectWeakRef;
-
 template< typename T > T* SdrObject::CloneHelper() const
 {
 OSL_ASSERT( typeid( T ) == typeid( *this ));
diff --git a/include/svx/svdoutl.hxx b/include/svx/svdoutl.hxx
index 5d1f9e842593..b13cd4b0ab6f 100644
--- a/include/svx/svdoutl.hxx
+++ b/include/svx/svdoutl.hxx
@@ -30,7 +30,7 @@ class SdrPage;
 class SVX_DLLPUBLIC SdrOutliner : public Outliner
 {
 protected:
-SdrObjectWeakRef mpTextObj;
+tools::WeakReference mpTextObj;
 const SdrPage* mpVisualizedPage;
 
 public:
diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx
index 0952a9335ac3..7f9917bacb29 100644
--- a/include/svx/svdpage.hxx
+++

[Libreoffice-bugs] [Bug 113993] LibreOffice - Writer distorts text when I type " Tashdid " character in Persian Language

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113993

--- Comment #7 from Hadi SetSH  ---
(In reply to Xisco Faulí from comment #5)
> Setting to NEEDINFO as per comment 4

Sorry , I didn't replied , Just added a comment
I have already added an Screenshot , Just see attachments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113993] LibreOffice - Writer distorts text when I type " Tashdid " character in Persian Language

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113993

--- Comment #6 from Hadi SetSH  ---
@Xisco Faulí

I have already added an Screenshot , See Attachments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2018-01-25 Thread Stephan Bergmann

 sw/source/filter/xml/xmlimpit.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1a0b01f2238e30a58a2bb4a4054b7726887fe15d
Author: Stephan Bergmann 
Date:   Thu Jan 25 16:50:51 2018 +0100

USHRT_MAX -> SAL_MAX_UINT16

The check against USHRT_MAX and the mismatching cast to sal_uInt16 in the
following SetWidth call were like that ever since the code first shows up in
57941a2dfdb461a2444a0ab84076db8423c46ca7 "#86004# removed
SfxPoolItem::importXML, exportXML, equalsXML".

Change-Id: Icd63d5b66765fc2391898a9d47a228407b9d5744
Reviewed-on: https://gerrit.libreoffice.org/48631
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/filter/xml/xmlimpit.cxx 
b/sw/source/filter/xml/xmlimpit.cxx
index d4e9344d6b8a..32a591e82b0b 100644
--- a/sw/source/filter/xml/xmlimpit.cxx
+++ b/sw/source/filter/xml/xmlimpit.cxx
@@ -902,8 +902,8 @@ bool SvXMLImportItemMapper::PutXMLValue(
 sal_Int32 nValue = rValue.toInt32();
 if( nValue < MINLAY )
 nValue = MINLAY;
-else if( nValue > USHRT_MAX )
-nValue = USHRT_MAX;
+else if( nValue > SAL_MAX_UINT16 )
+nValue = SAL_MAX_UINT16;
 
 rFrameSize.SetWidth( static_cast(nValue) );
 rFrameSize.SetHeightSizeType( ATT_VAR_SIZE );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #30 from Mike Kaganski  ---
(In reply to Jim Raykowski from comment #29)
> Maybe the best thing would be to abort the current patch and make separate
> commits under this bug report for each reported place that will use the new
> background tab? Using the new background tab for character highlighting is
> the only place that I feel is ready at this time.

Please do this! :) This would allow for incremental progress, and also for
parallelism in implementing that for different areas (if others would like,
they could coordinate their work here with you).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85811

Kevin Suo  changed:

   What|Removed |Added

 Depends on||115238


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115238
[Bug 115238] Menu items are shown to the top of the menu boundary (covers the
menu thus makes the menu invisible)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115238] Menu items are shown to the top of the menu boundary ( covers the menu thus makes the menu invisible)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115238

Kevin Suo  changed:

   What|Removed |Added

 Blocks||85811


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115238] Menu items are shown to the top of the menu boundary ( covers the menu thus makes the menu invisible)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115238

--- Comment #2 from Kevin Suo  ---
Created attachment 139370
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139370=edit
Firefox UI (good)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115238] Menu items are shown to the top of the menu boundary ( covers the menu thus makes the menu invisible)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115238

--- Comment #1 from Kevin Suo  ---
Created attachment 139369
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139369=edit
libreoffice UI (bad)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115238] New: Menu items are shown to the top of the menu boundary ( covers the menu thus makes the menu invisible)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115238

Bug ID: 115238
   Summary: Menu items are shown to the top of the menu boundary
(covers the menu thus makes the menu invisible)
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

When you move/hover/navigate around the menus, if the number of items within
this menu is big thus the menu items can not fit the screen, the menu items
displayed will flow up to the menu boundary. These makes the menus covered
(shielded) by the menu items shown.

Steps to Reproduce:
1. Put your mouse on the "File" menu.

Current Result:
The "File" menu and the other menus next to it are invisible. If you want to
move to another menu, you have to firstly move you mouse cursor to a blank
area.

Expected:
The menu items shown should never cover the menus.

Further information:
The behaviour in Firefox is good, menu items are shown below the menu. If there
are many menu items so they can not fit to the screen, an up or down triangle
button is shown.

Version: 6.1.0.0.alpha0+
Build ID：ff8826d438a9fd080e8e61f8e66b3d3b2c8d752b
CPU 线程：2; 操作系统：Linux 4.14; UI 渲染：默认; VCL: gtk3; 
区域语言：zh-CN (zh_CN.UTF-8); Calc: group threaded

版本：5.4.4.2
Build ID：5.4.4.2-1.fc27
CPU 线程：2; 操作系统：Linux 4.14; UI 渲染：默认; VCL: gtk3; 
区域语言：zh-CN (zh_CN.UTF-8); Calc: group

Fedora 27, Gnome Desktop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #29 from Jim Raykowski  ---
(In reply to Yousuf Philips (jay) from comment #28)
> (In reply to Jim Raykowski from comment #27)
> > Table background is only by cell. A workaround for the 'by cell, row or
> > table' drop down in the old background tab is to select rows, columns, or
> > entire table and then apply background.
> 
> If the row or table is selected, would it be setting the color at the row
> and table level? What is the intended fix for this temporary workaround? If
> there isnt an intended fix for this, then table background should be left
> out of the fix.

Hi Jay, 

It has been a while since I've looked at this.

Table background is work in progress. In addition to not being able to set
table background by row, or table there is the problem of after setting a
bitmap background the image is not selected in the bitmap list when the table
properties dialog is reopened. This can cause no image to be set if the OK
button is pressed without first clicking on a bitmap in the list. It has to do
with the new background tab needing loext:graphic-properties to reselect the
image. At this time it is beyond my knowledge of how to do this. 

Maybe the best thing would be to abort the current patch and make separate
commits under this bug report for each reported place that will use the new
background tab? Using the new background tab for character highlighting is the
only place that I feel is ready at this time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105003] Rotating a PNG image is quite slow

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105003

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95806] FILEOPEN: DOCX import: strange layout problem with table in footnote

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95806

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76232] Table: Merging Two Cells Leads to an Additional Line Break

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76232

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105510] Bullets and numbering contained in a table cell don' t get pasted using paste special formatted text

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105510

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

open source contribution

2018-01-25 Thread Aanjaneya Singh Dhoni

I m Computer Science student and network security enthusiast. I want to
part of your organisation's open source projects. How can i start. Please
guide me as a newbie.

-- 



 
  

 
 
 
 
 
 


--

This email and the information it contains are confidential and may be 
privileged. If you have received this email in error please notify me 
immediately. You should not copy it for any purpose, or disclose its 
contents to any other person. Internet communications are not secure and, 
therefore, Poornima University does not accept legal responsibility for the 
contents of this message as it has been transmitted over a public network. 
If you suspect the message may have been intercepted or amended please 
contact us.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

support ActiveX components in LibreOffice

2018-01-25 Thread Stančík Pavel

Hello
We use CRM system QAD CRM which comunicate with MS Office via ActiveX 
components.
We would like to move to LibreOffice.
That´s why we need to know how work and how you support ActiveX components in 
LibreOffice.
I found out some pieces of informations in forum and help 
(https://help.libreoffice.org) but they are not unit.
Does LibreOffice support ActiveX objects, methods and classes the same way like 
MS Office do?
If yes, for which release of LO?
Would you continue support ActiveX components in future?
 

Best regards 

   Pavel Stancik
   Consultant IS
 


 

Minerva Slovensko, a.s.
Sokolská 7
960 01 Zvolen
Slovakia
 
Tel.: +421 45 5400722
Fax: +421 45 5400720
 
 

pavel.stan...@minerva-is.sk 
http://www.minerva-is.eu___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115237] New: Crash in: MSWordExportBase::GetItem(unsigned short)

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115237

Bug ID: 115237
   Summary: Crash in: MSWordExportBase::GetItem(unsigned short)
   Product: LibreOffice
   Version: unspecified
  Hardware: PowerPC
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hwac...@gmail.com

This bug was filed from the crash reporting server and is
br-9bf502bf-a82c-4780-8b37-9e08ff86dfb3.
=

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115236] relative links & file:// URI scheme fail when exporting to HTML and SVG from LibreOffice Impress Versions : 5.1 & 5.3

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115236

UbunLibOffImp  changed:

   What|Removed |Added

Summary|file:// URI scheme fails|relative links & file://
   |when exporting to HTML and  |URI scheme fail when
   |SVG from LibreOffice|exporting to HTML and SVG
   |Impress Versions: 5.1 & 5.3 |from LibreOffice Impress
   ||Versions: 5.1 & 5.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115236] New: file:// URI scheme fails when exporting to HTML and SVG from LibreOffice Impress Versions : 5.1 & 5.3

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115236

Bug ID: 115236
   Summary: file:// URI scheme fails when exporting to HTML and
SVG from LibreOffice Impress Versions: 5.1 & 5.3
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: duder_t...@hotmail.com

Description:
Environment = Ubuntu 16.04 & Firefox 58 & LibreOffice Impress Version: 5.3.7.2
& 5.1.X.X

There are many interrelated problems pertaining to the way LibreOffice Impress
handles the export of URL(URI) links.

a] Impress will completely ignore/remove a relative link when a *.odp is
exported to type *.svg
(example [a] = Insert > Link type > Internet > Web > URL:
"./subdirectory/file.xyz")
(result  [a] = when the *.svg is opened in above listed web browser, no
hyperlink(s) will exist)

b] Impress should never convert the characters "file://" to "smb://" when a
*.odp is exported to type *.svg
(example [b] = Insert > Link type > INTERNET > Web > URL:
"file://./subdirectory/file.xyz")
(result  [b] = when the *.svg is opened in above listed web browser, hyperlink
becomes "smb://./subdirectory/file.svg" and is dead)

c] Impress should never strip out "." character when used as the first
character in a relative link in a *.odp that is exported to type *.svg
(example [c] = Insert > Link type > DOCUMENT > DOCUMENT PATH:
"file://./subdirectory/file.xyz")
(result  [c] = when the *.svg is opened in above listed web browser, hyperlink
becomes "file:///subdirectory/file.svg" and is dead since it is not resolved
correctly)

- The use of the file protocol (file://) was an attempt to workaround the fact
that Impress cannot correctly embed relative links when exporting a *.svg
- Usage of the file:// protocol was a futile effort to try to get a relative
URL within the *.svg to resolve correctly such that the *.svg can be used
without absolute links
- Piles of unnecessary JavaScript had to be added to every web link in order to
parse the location URL of the *.svg and then generate a URL for the hyperlink
resource
- Please carefully review the concept of baseURL as it pertains to a *.svg
created by Impress that has local filesystem links
- It is difficult to report more errors since the above listed items are so
fundamental that additional items can't be dealt with until basic functionality
is established.

Steps to Reproduce:
a] Impress will completely ignore/remove a relative link when a *.odp is
exported to type *.svg
(example [a] = Insert > Link type > Internet > Web > URL:
"./subdirectory/file.xyz")
(result  [a] = when the *.svg is opened in above listed web browser, no
hyperlink(s) will exist)

b] Impress should never convert the characters "file://" to "smb://" when a
*.odp is exported to type *.svg
(example [b] = Insert > Link type > INTERNET > Web > URL:
"file://./subdirectory/file.xyz")
(result  [b] = when the *.svg is opened in above listed web browser, hyperlink
becomes "smb://./subdirectory/file.svg" and is dead)

c] Impress should never strip out "." character when used as the first
character in a relative link in a *.odp that is exported to type *.svg
(example [c] = Insert > Link type > DOCUMENT > DOCUMENT PATH:
"file://./subdirectory/file.xyz")
(result  [c] = when the *.svg is opened in above listed web browser, hyperlink
becomes "file:///subdirectory/file.svg" and is dead since it is not resolved
correctly)

Actual Results:  
a] Impress will completely ignore/remove a relative link when a *.odp is
exported to type *.svg
(example [a] = Insert > Link type > Internet > Web > URL:
"./subdirectory/file.xyz")
(result  [a] = when the *.svg is opened in above listed web browser, no
hyperlink(s) will exist)

b] Impress should never convert the characters "file://" to "smb://" when a
*.odp is exported to type *.svg
(example [b] = Insert > Link type > INTERNET > Web > URL:
"file://./subdirectory/file.xyz")
(result  [b] = when the *.svg is opened in above listed web browser, hyperlink
becomes "smb://./subdirectory/file.svg" and is dead)

c] Impress should never strip out "." character when used as the first
character in a relative link in a *.odp that is exported to type *.svg
(example [c] = Insert > Link type > DOCUMENT > DOCUMENT PATH:
"file://./subdirectory/file.xyz")
(result  [c] = when the *.svg is opened in above listed web browser, hyperlink
becomes "file:///subdirectory/file.svg" and is dead since it is not resolved
correctly)

Expected Results:
When a user exports a LibreOffice Impress document to the file format SVG, the
user expects that hyperlinks associated with the text and imagery will actually
function when the SVG file is opened in a web browser such as FireFox.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

[Libreoffice-bugs] [Bug 114458] Can't finished the job. Application Just keep running

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114458

--- Comment #2 from Leon  ---
I'm very glad to receive your email. I really appreciate.
I post my brief main code. I use C# to call the LibreOffice.exe to  change my
file. But just keep running and I didn't see the any error message.
Here is my code below.

// Just use C# Process to execute the  LibreOffice.exe
startInfo.FileName =
ConfigurationManager.AppSettings["LibreOfficeExePath"];
startInfo.WorkingDirectory = outputDir;
startInfo.WindowStyle = ProcessWindowStyle.Hidden;
startInfo.Arguments = string.Format(" -headless -convert-to {1} 
  {0}", inputFilePath, extensionParameter);
startInfo.RedirectStandardError = true;
startInfo.RedirectStandardOutput = true;
startInfo.Verb = "runas";

 using (Process exeProcess = Process.Start(startInfo))
{
var errorMessage = exeProcess.StandardError.ReadToEnd();
var streamMessage = exeProcess.StandardOutput.ReadToEnd();
File.AppendAllText(@"E:\BackUp\BackUpLog.txt", 
$@"\r\n{errorMessage}\r\n{streamMessage}");
exeProcess.WaitForExit();
}

My program just keep waiting the LibreOffice.exe return some command. 
This code >  Process.Start(startInfo)  into the LibreOffice.exe to change
file then never reach this code >  exeProcess.WaitForExit();
 I think my program doesn't receive any response, so just keep waiting for
LibreOffice.exe return some information.

This my problem I posted in stackoverflow but no one can fix this problem.
Please check this link. Hope you can get more information.
https://stackoverflow.com/questions/47824861/use-c-sharp-process-to-shift-the-file-to-odflibreoffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

2018-01-25 Thread Jens Carl

 connectivity/source/drivers/calc/CTable.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 583a574d045ffc1eb4e2b05f60852df0db8ae2c2
Author: Jens Carl 
Date:   Thu Jan 25 23:39:06 2018 +

Update comment to reflect the right type

Follow up from commit 4cdb7fa375ba1894deb412853214f01f95bd3f05,
where it was missed.

Change-Id: Icfc123b0e238705f175fda6308ecc40569d3a31a
Reviewed-on: https://gerrit.libreoffice.org/48643
Reviewed-by: Jens Carl 
Tested-by: Jens Carl 

diff --git a/connectivity/source/drivers/calc/CTable.cxx 
b/connectivity/source/drivers/calc/CTable.cxx
index 37263aa5477f..bce84e2b05b3 100644
--- a/connectivity/source/drivers/calc/CTable.cxx
+++ b/connectivity/source/drivers/calc/CTable.cxx
@@ -146,7 +146,7 @@ static CellContentType lcl_GetContentOrResultType( const 
Reference& xCell
 Reference xProp( xCell, UNO_QUERY );
 try
 {
-xProp->getPropertyValue( "CellContentType" ) >>= eCellType;  
// type of formula result
+xProp->getPropertyValue( "CellContentType" ) >>= eCellType;  
// type of cell content
 }
 catch (UnknownPropertyException&)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115235] New: wrong folder when saving non-ODT files as ODT

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115235

Bug ID: 115235
   Summary: wrong folder when saving non-ODT files as ODT
   Product: LibreOffice
   Version: 6.0.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: uwesto...@web.de

- open a DOCX file
- save as into another folder

The file dialog is opened and you can select the desired folder (e.g.
D:\Tests).
LO warns you that the format is not ODT.

- click in the warning dialog to use ODT

result: the file dialog is opened again but not in the selected folder
(D:\Tests) but in the folder where the DOCX file is in.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115224] FILESAVE HTMLEXPORT shapes badly positioned after saved as HTML

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115224

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
In resulting HTML file the shapes are replaced with images, which are put
inside the cell. The table structure is disturbed. You can better see what
happens, if you enable cell borders.

If the shapes are anchored to page, then all shapes-images should go into a
div-element, which is outside the table. Here the export is surely wrong.

If you group the shapes, one picture is generated. That gives a better
placement in case the cells behind the group are empty. That might be a
workaround in case of the attached document, but not in general. If the cells
contain something, the shape-image is placed after the table.

As workaround I suggest to copy the relevant part of the table and insert it in
a Writer/Web document. Then group the shapes, insert the group in Draw and
generate a png-image from it. Insert this image in Write/Web before the table,
anchor it to page and drag it to the desired position.

Unfortunaltely the HTML-export is not maintained at all currently. So I suggest
a "wontfix".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115234] New: Suggest - Implement indent a text on the right - LibreOffice Calc

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115234

Bug ID: 115234
   Summary: Suggest - Implement indent a text on the right -
LibreOffice Calc
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leaba...@gmail.com

Description:
I want to suggest the implementation of indent a text when it's aligned on the
right on a column in LibreOffice Calc.

Steps to Reproduce:
It's only possible indent a text when you select Align left, but it's not
possible when you select Align right. This is very useful when you want to
center numbers but you want to keep them aligned vertically.

Actual Results:  
This is not a problem. I'm suggesting a new feature.

Expected Results:
This is not a problem. I'm suggesting a new feature.


Reproducible: Always


User Profile Reset: No



Additional Info:
Thank you. I really like the LibreOffice Suite. And I'm sorry I need to provide
more details.


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

2018-01-25 Thread brian houston morrow

 sw/uiconfig/swriter/ui/columnpage.ui |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d31ff9d4df7a87f67c5583c0eb78e0fbe1ba6641
Author: brian houston morrow 
Date:   Tue Jan 23 18:38:57 2018 -0600

tdf#113239 Increase tick amount for spacing spinner to 0.1

Change-Id: I8bb2f3863ed16b11c6a65c59b89d41dcdf2d8544
Reviewed-on: https://gerrit.libreoffice.org/48475
Tested-by: Jenkins 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/uiconfig/swriter/ui/columnpage.ui 
b/sw/uiconfig/swriter/ui/columnpage.ui
index 1ce5640810cf..577f6430f8f8 100644
--- a/sw/uiconfig/swriter/ui/columnpage.ui
+++ b/sw/uiconfig/swriter/ui/columnpage.ui
@@ -13,12 +13,12 @@
   
 0.01
 56
-0.10001
+0.1
 1
   
   
 56
-0.01
+0.1
 1
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115229] saveas file filter prevents .

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115229

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
If you use the file dialog of LibreOffice, then you can e.g. enter *.svg into
the file name field and press the enter key. Then the file list will show all
.svg files, independent of the chosen file type filter. The same is true for
the native file dialog of Windows.

It seems the native file dialog of your Linux version has a restriction.

I'm no regular Linux user and have only Ubuntu 16 in a virtual box. I get no
files listed if the file type is set to "All Formats" although the folder is
not empty. A Linux expert should say, whether this is the usual behavior or a
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - tools/map.cpp

2018-01-25 Thread Tor Lillqvist

 tools/map.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cb1bdf3a7325bc9be4cc4cb965a77aa1c40817d7
Author: Tor Lillqvist 
Date:   Thu Oct 26 12:02:28 2017 +0300

Avoid warning: ‘%s’ directive output may be truncated writing up to 255 
bytes

... into a region of size 58

Change-Id: I725c537ed21553e9dc34ba006a39917e1549b6a7
(cherry picked from commit a0b82c9fdb8bc4db967d1f589092a99d72f657e7)
Reviewed-on: https://gerrit.libreoffice.org/48628
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/tools/map.cpp b/tools/map.cpp
index 9ed47193..e5e16777 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -21,7 +21,7 @@
 #include 
 
 #define MAP_SIZE 20
-#define PATH_SIZE 64
+#define PATH_SIZE 1000 // No harm in having it much larger than strictly 
necessary. Avoids compiler warning.
 #define BUFFER_SIZE 9600
 
 static int read_buffer(char *buffer, unsigned size,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - common/SpookyV2.cpp

2018-01-25 Thread Tor Lillqvist

 common/SpookyV2.cpp |   18 ++
 1 file changed, 18 insertions(+)

New commits:
commit 497b872f3619987d4860407ce6250dce3052e6f6
Author: Tor Lillqvist 
Date:   Thu Oct 26 11:51:53 2017 +0300

More -Werror=implicit-fallthrough=

Change-Id: I62164eef3a4f95bfe505b3b1a866495bde6c19b1
(cherry picked from commit 73d77a9f6746e4a6418b6539dfbe35fcda29fcd5)
Reviewed-on: https://gerrit.libreoffice.org/48626
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/common/SpookyV2.cpp b/common/SpookyV2.cpp
index 9d6ea649..88d79696 100644
--- a/common/SpookyV2.cpp
+++ b/common/SpookyV2.cpp
@@ -16,6 +16,13 @@
 
 #define ALLOW_UNALIGNED_READS true
 
+#if defined __clang__
+#define FALLTHROUGH [[clang::fallthrough]]
+#elif defined __GNUC__ && __GNUC__ >= 7
+#define FALLTHROUGH [[fallthrough]]
+#else
+#define FALLTHROUGH
+#endif
 //
 // short hash ... it could be used on any message,
 // but it's used by Spooky just for short messages.
@@ -80,36 +87,47 @@ void SpookyHash::Short(
 {
 case 15:
 d += ((uint64)u.p8[14]) << 48;
+FALLTHROUGH;
 case 14:
 d += ((uint64)u.p8[13]) << 40;
+FALLTHROUGH;
 case 13:
 d += ((uint64)u.p8[12]) << 32;
+FALLTHROUGH;
 case 12:
 d += u.p32[2];
 c += u.p64[0];
 break;
 case 11:
 d += ((uint64)u.p8[10]) << 16;
+FALLTHROUGH;
 case 10:
 d += ((uint64)u.p8[9]) << 8;
+FALLTHROUGH;
 case 9:
 d += (uint64)u.p8[8];
+FALLTHROUGH;
 case 8:
 c += u.p64[0];
 break;
 case 7:
 c += ((uint64)u.p8[6]) << 48;
+FALLTHROUGH;
 case 6:
 c += ((uint64)u.p8[5]) << 40;
+FALLTHROUGH;
 case 5:
 c += ((uint64)u.p8[4]) << 32;
+FALLTHROUGH;
 case 4:
 c += u.p32[0];
 break;
 case 3:
 c += ((uint64)u.p8[2]) << 16;
+FALLTHROUGH;
 case 2:
 c += ((uint64)u.p8[1]) << 8;
+FALLTHROUGH;
 case 1:
 c += (uint64)u.p8[0];
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - kit/Kit.cpp

2018-01-25 Thread Tor Lillqvist

 kit/Kit.cpp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 84b7b48780e72e279aafc9150e1b7e7e60acb02d
Author: Tor Lillqvist 
Date:   Thu Oct 26 11:53:35 2017 +0300

Fix makedev warning

g++ says: In the GNU C Library, "makedev" is defined by
. For historical compatibility, it is currently
defined by  as well, but we plan to remove this soon. To
use "makedev", include  directly. If you did not
intend to use a system-defined macro "makedev", you should undefine it
after including .

Change-Id: If5cd1ec0ca34b00b1248e9b2650d4d13e6d3bf64
(cherry picked from commit a806655e59786b9de6d64dfcff30bfa4fde6af67)
Reviewed-on: https://gerrit.libreoffice.org/48627
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 304a62e5..bb10f534 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -19,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - net/WebSocketHandler.hpp

2018-01-25 Thread Tor Lillqvist

 net/WebSocketHandler.hpp |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 400b29fb800fd62f8976b470fe01adbc2cbacf89
Author: Tor Lillqvist 
Date:   Thu Oct 26 11:38:43 2017 +0300

Avoid warning "this statement may fall through" when intentional

Change-Id: I8d8bcb4747a1933e4ecefe1220a80a355e60317f
(cherry picked from commit 6b0faf9d97d9c479f3297ccfc0bf1b06d1de0e34)
Reviewed-on: https://gerrit.libreoffice.org/48624
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 4ff01c36..8ff0fff2 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -213,6 +213,11 @@ public:
 case WSOpCode::Ping:
 LOG_ERR("#" << socket->getFD() << ": Clients should not send 
pings, only servers");
 // drop through
+#if defined __clang__
+[[clang::fallthrough]];
+#elif defined __GNUC__ && __GNUC__ >= 7
+[[fallthrough]];
+#endif
 case WSOpCode::Close:
 if (!_shuttingDown)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115233] New: Replacing image resets the crop

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115233

Bug ID: 115233
   Summary: Replacing image resets the crop
   Product: LibreOffice
   Version: 5.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: matth...@dug.com

Description:
In 5.1 and previous replacing an image would persist the crop setting from the
original image.

This has been an issue for a while it seems, and at my company we are just
starting to migrate from 5.1 to 5.3 and this is an issue many of our users are
encountering.

Steps to Reproduce:
1.Insert an image into a slide, and crop it.
2.Select image, and "Replace" it.
3.The replacement image is inserted, and cropping is reset.

Actual Results:  
The uncropped image is displayed in the slide

Expected Results:
The image has the cropping from the original image.


Reproducible: Always


User Profile Reset: No



Additional Info:
bug #103031 is the original which was merged into a different bug, with this
one never being actually fixed. The problem persists even with the latest
LibeOffice 6.0 RC's and that ticket has been falsely marked as resolved
therefor I have created this one.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113458] [META] Packaging/installation/removal bugs and enhancements

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113458

Telesto  changed:

   What|Removed |Added

 Depends on||81916


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=81916
[Bug 81916] Other: Language Pack installer is not signed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81916] Other: Language Pack installer is not signed

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81916

Telesto  changed:

   What|Removed |Added

 Blocks||113458


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113458
[Bug 113458] [META] Packaging/installation/removal bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113458] [META] Packaging/installation/removal bugs and enhancements

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113458

Telesto  changed:

   What|Removed |Added

 Depends on||114679


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114679
[Bug 114679] MacOS: Copying the installation files is quite slow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114679] MacOS: Copying the installation files is quite slow

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114679

Telesto  changed:

   What|Removed |Added

 Blocks||113458


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113458
[Bug 113458] [META] Packaging/installation/removal bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114640] Install package on macOS misses background picture for 6.0 rc1

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114640

--- Comment #3 from Telesto  ---
No repro with RC3. Looks like WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2018-01-25 Thread Jens Carl

 sc/source/ui/unoobj/celllistsource.cxx   |6 +++---
 sc/source/ui/unoobj/cellvaluebinding.cxx |4 ++--
 sc/source/ui/vba/vbarange.cxx|6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 8a73799d12f0d2dc04890b96bd0adf0ffcf50d17
Author: Jens Carl 
Date:   Wed Jan 24 02:10:35 2018 +

Change property value to get CellContentType in sc/

Change the name of property value to get the CellContentType and
rename variables to reflect change of the meaning. Follow up from
commit cceaece18a42405190941865908636522e0ee4cb.

Change-Id: I35c58174cef8ab44bd37b37fd18876ef912e16be
Reviewed-on: https://gerrit.libreoffice.org/48476
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/source/ui/unoobj/celllistsource.cxx 
b/sc/source/ui/unoobj/celllistsource.cxx
index 6d3cdc49c5c9..5cbe67624f3a 100644
--- a/sc/source/ui/unoobj/celllistsource.cxx
+++ b/sc/source/ui/unoobj/celllistsource.cxx
@@ -200,9 +200,9 @@ namespace calc
 Reference< XPropertySet > xProp( xCell, UNO_QUERY);
 if (xProp.is())
 {
-CellContentType eResultType;
-if ((xProp->getPropertyValue("FormulaResultType") 
>>= eResultType) &&
-eResultType == CellContentType_VALUE)
+CellContentType eContentType;
+if ((xProp->getPropertyValue("CellContentType") 
>>= eContentType) &&
+eContentType == CellContentType_VALUE)
 *pAny <<= xCell->getValue();
 else
 *pAny <<= sText;
diff --git a/sc/source/ui/unoobj/cellvaluebinding.cxx 
b/sc/source/ui/unoobj/cellvaluebinding.cxx
index 29cb35a199a5..65aae5c2c4c4 100644
--- a/sc/source/ui/unoobj/cellvaluebinding.cxx
+++ b/sc/source/ui/unoobj/cellvaluebinding.cxx
@@ -203,8 +203,8 @@ namespace calc
 Reference xProp( m_xCell, UNO_QUERY );
 if ( xProp.is() )
 {
-CellContentType eResultType;
-if ( (xProp->getPropertyValue("FormulaResultType") 
>>= eResultType) && eResultType == CellContentType_VALUE )
+CellContentType eContentType;
+if ( (xProp->getPropertyValue("CellContentType") 
>>= eContentType) && eContentType == CellContentType_VALUE )
 bHasValue = true;
 }
 }
diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 21ac5d79635f..24de46dba614 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -825,11 +825,11 @@ void CellValueGetter::visitNode( sal_Int32 x, sal_Int32 
y, const uno::Reference<
 {
 uno::Reference< beans::XPropertySet > xProp( xCell, 
uno::UNO_QUERY_THROW );
 
-table::CellContentType eFormulaType = 
table::CellContentType_VALUE;
+table::CellContentType eContentType = 
table::CellContentType_VALUE;
 // some formulas give textual results
-xProp->getPropertyValue( "FormulaResultType" ) >>= 
eFormulaType;
+xProp->getPropertyValue( "CellContentType" ) >>= eContentType;
 
-if ( eFormulaType == table::CellContentType_TEXT )
+if ( eContentType == table::CellContentType_TEXT )
 {
 uno::Reference< text::XTextRange > xTextRange(xCell, 
::uno::UNO_QUERY_THROW);
 aValue <<= xTextRange->getString();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

2018-01-25 Thread Jens Carl

 connectivity/source/drivers/calc/CTable.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4cdb7fa375ba1894deb412853214f01f95bd3f05
Author: Jens Carl 
Date:   Tue Jan 23 21:44:58 2018 +

Change property value to get CellContentType in connectivity/

Follow up from commit cceaece18a42405190941865908636522e0ee4cb.

Change-Id: I29df5403204279b038095156c85638877d2dc9ff
Reviewed-on: https://gerrit.libreoffice.org/48465
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/connectivity/source/drivers/calc/CTable.cxx 
b/connectivity/source/drivers/calc/CTable.cxx
index 142e8a2bf6a6..37263aa5477f 100644
--- a/connectivity/source/drivers/calc/CTable.cxx
+++ b/connectivity/source/drivers/calc/CTable.cxx
@@ -146,11 +146,11 @@ static CellContentType lcl_GetContentOrResultType( const 
Reference& xCell
 Reference xProp( xCell, UNO_QUERY );
 try
 {
-xProp->getPropertyValue( "FormulaResultType" ) >>= eCellType;  
// type of formula result
+xProp->getPropertyValue( "CellContentType" ) >>= eCellType;  
// type of formula result
 }
 catch (UnknownPropertyException&)
 {
-eCellType = CellContentType_VALUE;  // if FormulaResultType 
property not available
+eCellType = CellContentType_VALUE;  // if CellContentType property 
not available
 }
 }
 return eCellType;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: avmedia/source include/sal jurt/source sal/osl sal/rtl tools/source

2018-01-25 Thread Stephan Bergmann

 avmedia/source/vlc/wrapper/Types.hxx|3 +++
 include/sal/config.h|2 --
 jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c |4 
 jurt/source/pipe/wrapper/wrapper.c  |1 +
 sal/osl/all/signalshared.cxx|2 ++
 sal/osl/unx/salinit.cxx |1 +
 sal/osl/w32/signal.cxx  |3 +++
 sal/rtl/hash.cxx|4 
 tools/source/reversemap/bestreversemap.cxx  |1 +
 9 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 0b14c0fbef7a6d3420e8da6ae44488b23de4c4fb
Author: Stephan Bergmann 
Date:   Thu Jan 18 15:34:41 2018 +0100

Remove stdlib.h from sal/config.h

This reverts 5da3337c007e0572028283d70bad43e9a29d45c1 "readded include 
stdlib.h,
because of missing NULL definition in many headers, #10, #101685", 
which is
no longer relevant.

Change-Id: I544ed9a7afbf7b611bc481b8d50acca3193d93de
Reviewed-on: https://gerrit.libreoffice.org/48131
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/avmedia/source/vlc/wrapper/Types.hxx 
b/avmedia/source/vlc/wrapper/Types.hxx
index 7411b03dc95a..eb5dd3a4f9d4 100644
--- a/avmedia/source/vlc/wrapper/Types.hxx
+++ b/avmedia/source/vlc/wrapper/Types.hxx
@@ -12,9 +12,12 @@
 #ifndef INCLUDED_AVMEDIA_SOURCE_VLC_WRAPPER_TYPES_HXX
 #define INCLUDED_AVMEDIA_SOURCE_VLC_WRAPPER_TYPES_HXX
 
+#include 
+
 #if defined(_WIN32)
 typedef __int64 libvlc_time_t;
 #else
+#include 
 typedef int64_t libvlc_time_t;
 #endif
 
diff --git a/include/sal/config.h b/include/sal/config.h
index 03a2f5b9fa21..bfe4d5e2d3e2 100644
--- a/include/sal/config.h
+++ b/include/sal/config.h
@@ -24,8 +24,6 @@
 #include 
 #endif
 
-#include 
-
 #ifdef _WIN32
 #define SAL_W32
 #define SAL_DLLEXTENSION ".dll"
diff --git 
a/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c 
b/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
index ba775da069d0..5259bbcd5474 100644
--- a/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
+++ b/jurt/source/pipe/com_sun_star_lib_connections_pipe_PipeConnection.c
@@ -17,6 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include 
 #include 
 #include 
diff --git a/jurt/source/pipe/wrapper/wrapper.c 
b/jurt/source/pipe/wrapper/wrapper.c
index aefaa3719183..28d16690b54e 100644
--- a/jurt/source/pipe/wrapper/wrapper.c
+++ b/jurt/source/pipe/wrapper/wrapper.c
@@ -20,6 +20,7 @@
 #include 
 
 #include 
+#include 
 
 #define WIN32_LEAN_AND_MEAN
 #include 
diff --git a/sal/osl/all/signalshared.cxx b/sal/osl/all/signalshared.cxx
index 9cf7fafc2de5..d6998eb006ca 100644
--- a/sal/osl/all/signalshared.cxx
+++ b/sal/osl/all/signalshared.cxx
@@ -19,6 +19,8 @@
 
 #include 
 
+#include 
+
 #include 
 
 #include 
diff --git a/sal/osl/unx/salinit.cxx b/sal/osl/unx/salinit.cxx
index 5e95c2bab532..bfec16a96677 100644
--- a/sal/osl/unx/salinit.cxx
+++ b/sal/osl/unx/salinit.cxx
@@ -37,6 +37,7 @@
 #include 
 
 #if HAVE_SYSLOG_H
+#include 
 #include 
 #include 
 #endif
diff --git a/sal/osl/w32/signal.cxx b/sal/osl/w32/signal.cxx
index 5f11b8a6bcf6..79d0bcbd4e03 100644
--- a/sal/osl/w32/signal.cxx
+++ b/sal/osl/w32/signal.cxx
@@ -18,6 +18,9 @@
  */
 
 #include 
+
+#include 
+
 #include 
 
 #include 
diff --git a/sal/rtl/hash.cxx b/sal/rtl/hash.cxx
index 0dc36a4c..1599343bde3a 100644
--- a/sal/rtl/hash.cxx
+++ b/sal/rtl/hash.cxx
@@ -17,6 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
+
 #include "hash.hxx"
 #include "strimp.hxx"
 #include 
diff --git a/tools/source/reversemap/bestreversemap.cxx 
b/tools/source/reversemap/bestreversemap.cxx
index 97691b3dd0eb..a03711abbdfc 100644
--- a/tools/source/reversemap/bestreversemap.cxx
+++ b/tools/source/reversemap/bestreversemap.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 struct Encoder
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #44 from Telesto  ---
(In reply to Tor Lillqvist from comment #42)
> I don't see any percentage scale in the System Preferences > Dock > Size
> slider. When you talk about 50% or 40%, is that just an eyeballed
> estimation? After touching it, how do I get it back to the default? (Not
> that it matters much to me how big it is, I practically never use the Dock
> for anything, and of course I have it to auto-hide.)

Sorry, that's my eyeball estimation :-). Everything is working fine as long as
the dock responds to the Dock Size slider. The issue starts when the Dock stops
growing, while the slider is suggestion room for a larger one. It's probably
set to the middle by default (and that's already to much for my 11" screen)

My experience with Macs is very limited. So it might not be reproducible on
no-retina Macs and/or Macs with a smaller screen dimension.

Btw, no clue how the set it back to the default setting. Except for a new user
profile, or guessing the middle of the slider.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115214] FILESAVE XLSX Function Syntax Error (#Name?), with a reference to an external xlsx file and Excel formula syntax

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115214

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #6 from m.a.riosv  ---
Looks like a duple of
https://bugs.documentfoundation.org/show_bug.cgi?id=76047

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115232] New: Impress text selection slightly off with larger line spacing

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115232

Bug ID: 115232
   Summary: Impress text selection slightly off with larger line
spacing
   Product: LibreOffice
   Version: 6.0.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mvanr...@inf.ed.ac.uk

Created attachment 139368
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139368=edit
screen shot of bug

Hi

In Impress, when I create and then select text, it gets a blue overlay. 

This works fine, but when I increase the line spacing to 1.5 or 2, the
selection coloring is off set vertically. (see screenshot).
The cursor is also slightly too low.

I don't see the bug in Writer (but text seems to work different there).

Version: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU threads: 4; OS: Linux 4.14; UI render: GL; VCL: gtk2; 
Locale: en-GB (en_GB.utf8); Calc: group

On Debian buster.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65231] EDITING: Enable to change the color for record changes without loosing the differentiation between authors

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65231

--- Comment #12 from Dan Carr  ---
Sorry for the comment: 
This item has been fixed: 
Go to Tools-Options-Writer-Changes  and you may select from the color palate
for each type of change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #43 from Martin Srebotnjak  ---
Probably he meant the zoom slider as shown in the status bar ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65231] EDITING: Enable to change the color for record changes without loosing the differentiation between authors

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65231

--- Comment #11 from Dan Carr  ---
I would like to add my endorsement for this change.  The colors selected for
tracking changes are hard to view.  To work around this issue, I was forced to
load a multi-page document into a table and use one column to identify changes
which were sometimes a single character used to correct a misspelling and a
third column to identify author.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

2018-01-25 Thread Milian Wolff

 vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx |   19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

New commits:
commit bea99d013a0dea0c010a94425aef08c6711a669c
Author: Milian Wolff 
Date:   Thu Jan 25 14:08:28 2018 +0100

lo_kde5filepicker: cleanup main and add version and help options

This way users can figure out what this tool is about. Most notably,
you can run it now with `-h, --help` as one would expect.

Change-Id: If8dd3142bdcc96d2962a2647b2187d75666b9394
Reviewed-on: https://gerrit.libreoffice.org/48592
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx 
b/vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx
index c17236d281a0..d25af0afee70 100644
--- a/vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx
@@ -21,14 +21,29 @@
 #include "kde5_filepicker_ipc.hxx"
 
 #include 
+#include 
+#include 
 
-#include 
+#include 
 
 int main(int argc, char** argv)
 {
+QApplication::setOrganizationName("LibreOffice");
+QApplication::setOrganizationDomain("libreoffice.org");
 QApplication::setApplicationName(QStringLiteral("lo_kde5filepicker"));
-QApplication app(argc, argv);
 QApplication::setQuitOnLastWindowClosed(false);
+QApplication::setApplicationVersion(LIBO_VERSION_DOTTED);
+
+QApplication app(argc, argv);
+
+QCommandLineParser parser;
+parser.setApplicationDescription(
+QObject::tr("Helper executable for LibreOffice KDE/Plasma 
integration.\n"
+"Do not run this executable directly. Rather, use it 
indirectly via "
+"the gtk3_kde5 VCL plugin 
(SAL_USE_VCLPLUGIN=gtk3_kde5)."));
+parser.addVersionOption();
+parser.addHelpOption();
+parser.process(app);
 
 KDE5FilePicker filePicker;
 FilePickerIpc ipc();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

2018-01-25 Thread Milian Wolff

 vcl/unx/gtk3_kde5/kde5_filepicker.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 91ab6b4feda09e2ded45f716d8f283ced06971ad
Author: Milian Wolff 
Date:   Thu Jan 25 14:05:37 2018 +0100

Properly restore size of KDE5 file picker dialog

The event filter we installed prevented the show event from reaching
the KDEPlatformFileDialogHelper::show method. This prevented the
dialog from being restored to the size chosen by the user previously.

Change-Id: I7af457f19f59d27bd104f8f70d9f4767da6641ee
Reviewed-on: https://gerrit.libreoffice.org/48591
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx 
b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
index 9b3f21db92e9..d774ebc2834e 100644
--- a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
@@ -235,7 +235,6 @@ bool KDE5FilePicker::eventFilter(QObject* o, QEvent* e)
 KWindowSystem::setMainWindow(w, _winId);
 if (auto* fileWidget = w->findChild({}, 
Qt::FindDirectChildrenOnly))
 fileWidget->setCustomWidget(_extraControls);
-return false;
 }
 }
 return QObject::eventFilter(o, e);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

2018-01-25 Thread Milian Wolff

 vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx |   51 --
 vcl/unx/gtk3_kde5/kde5_filepicker_ipc.hxx |2 -
 2 files changed, 29 insertions(+), 24 deletions(-)

New commits:
commit a8a52bf04c3e459189511dd2fefc0f2851a356e9
Author: Milian Wolff 
Date:   Thu Jan 25 13:53:25 2018 +0100

Properly quit the lo_kde5filepicker on Quit command

Quitting the event loop is not enough, we also have to get out
of the readCommands loop. Return false for this scenario. Also
exit the command when an unhandled command comes in, we cannot
really recover the stream from this anyways.

Change-Id: I7d58724ea0364565e476516d5645cb436ce1d461
Reviewed-on: https://gerrit.libreoffice.org/48590
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx 
b/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
index 082864066d16..26c19f6b4c9b 100644
--- a/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx
@@ -65,14 +65,17 @@ FilePickerIpc::~FilePickerIpc() = default;
 
 void FilePickerIpc::readCommands()
 {
-while (!std::cin.eof())
+while (readCommand())
 {
-readCommand();
+// read next command
 }
 }
 
-void FilePickerIpc::readCommand()
+bool FilePickerIpc::readCommand()
 {
+if (std::cin.eof())
+return false;
+
 uint64_t messageId = 0;
 Commands command;
 readIpcArgs(std::cin, messageId, command);
@@ -84,45 +87,45 @@ void FilePickerIpc::readCommand()
 QString title;
 readIpcArgs(std::cin, title);
 m_filePicker->setTitle(title);
-return;
+return true;
 }
 case Commands::SetWinId:
 {
 sal_uIntPtr winId = 0;
 readIpcArgs(std::cin, winId);
 m_filePicker->setWinId(winId);
-return;
+return true;
 }
 case Commands::Execute:
 {
 sendIpcArgs(std::cout, messageId, m_filePicker->execute());
-return;
+return true;
 }
 case Commands::SetMultiSelectionMode:
 {
 bool multiSelection = false;
 readIpcArgs(std::cin, multiSelection);
 m_filePicker->setMultiSelectionMode(multiSelection);
-return;
+return true;
 }
 case Commands::SetDefaultName:
 {
 QString name;
 readIpcArgs(std::cin, name);
 m_filePicker->setDefaultName(name);
-return;
+return true;
 }
 case Commands::SetDisplayDirectory:
 {
 QString dir;
 readIpcArgs(std::cin, dir);
 m_filePicker->setDisplayDirectory(dir);
-return;
+return true;
 }
 case Commands::GetDisplayDirectory:
 {
 sendIpcArgs(std::cout, messageId, 
m_filePicker->getDisplayDirectory());
-return;
+return true;
 }
 case Commands::GetSelectedFiles:
 {
@@ -145,26 +148,26 @@ void FilePickerIpc::readCommand()
 files << url.toString();
 }
 sendIpcArgs(std::cout, messageId, files);
-return;
+return true;
 }
 case Commands::AppendFilter:
 {
 QString title, filter;
 readIpcArgs(std::cin, title, filter);
 m_filePicker->appendFilter(title, filter);
-return;
+return true;
 }
 case Commands::SetCurrentFilter:
 {
 QString title;
 readIpcArgs(std::cin, title);
 m_filePicker->setCurrentFilter(title);
-return;
+return true;
 }
 case Commands::GetCurrentFilter:
 {
 sendIpcArgs(std::cout, messageId, 
m_filePicker->getCurrentFilter());
-return;
+return true;
 }
 case Commands::SetValue:
 {
@@ -173,7 +176,7 @@ void FilePickerIpc::readCommand()
 bool value = false;
 readIpcArgs(std::cin, controlId, nControlAction, value);
 m_filePicker->setValue(controlId, nControlAction, value);
-return;
+return true;
 }
 case Commands::GetValue:
 {
@@ -181,7 +184,7 @@ void FilePickerIpc::readCommand()
 sal_Int16 nControlAction = 0;
 readIpcArgs(std::cin, controlId, nControlAction);
 sendIpcArgs(std::cout, messageId, 
m_filePicker->getValue(controlId, nControlAction));
-return;
+return true;
 }
 case Commands::EnableControl:
 {
@@ -189,7 +192,7 @@ void FilePickerIpc::readCommand()
 bool enabled = false;
 readIpcArgs(std::cin, controlId, enabled);

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 4a/73f51f4c83e5c59d4ccf68164bd0544533576e

2018-01-25 Thread Caolán McNamara

 4a/73f51f4c83e5c59d4ccf68164bd0544533576e |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 8c238ee66e76a4b257e45d25d8b0c62749640675
Author: Caolán McNamara 
Date:   Thu Jan 25 21:05:14 2018 +

Notes added by 'git notes add'

diff --git a/4a/73f51f4c83e5c59d4ccf68164bd0544533576e 
b/4a/73f51f4c83e5c59d4ccf68164bd0544533576e
new file mode 100644
index ..ced43be5a3aa
--- /dev/null
+++ b/4a/73f51f4c83e5c59d4ccf68164bd0544533576e
@@ -0,0 +1 @@
+prefer: c5f88f0dce63c4fb2d208c493c1b06e25318aa61
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2f/e2f41d1f15a980fb169accda71a192dbba8d72

2018-01-25 Thread Caolán McNamara

 2f/e2f41d1f15a980fb169accda71a192dbba8d72 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 69193ed9f4a3de4b326e5ea9fdac973460e4ea7f
Author: Caolán McNamara 
Date:   Thu Jan 25 21:04:49 2018 +

Notes added by 'git notes add'

diff --git a/2f/e2f41d1f15a980fb169accda71a192dbba8d72 
b/2f/e2f41d1f15a980fb169accda71a192dbba8d72
new file mode 100644
index ..051a05d84d5c
--- /dev/null
+++ b/2f/e2f41d1f15a980fb169accda71a192dbba8d72
@@ -0,0 +1 @@
+prefer: 8a9f54bc1283b7137a90506e29dba7962dd73f83
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/oss-fuzz-build.sh vcl/workben

2018-01-25 Thread Caolán McNamara

 bin/oss-fuzz-build.sh   |   13 +++--
 vcl/workben/602fuzzer.options   |2 ++
 vcl/workben/bmpfuzzer.options   |2 ++
 vcl/workben/cgmfuzzer.options   |2 ++
 vcl/workben/diffuzzer.options   |2 ++
 vcl/workben/docxfuzzer.options  |2 ++
 vcl/workben/dxffuzzer.options   |2 ++
 vcl/workben/epsfuzzer.options   |2 ++
 vcl/workben/fodpfuzzer.options  |3 +++
 vcl/workben/fodsfuzzer.options  |3 +++
 vcl/workben/fodtfuzzer.options  |3 +++
 vcl/workben/giffuzzer.options   |3 +++
 vcl/workben/htmlfuzzer.options  |3 +++
 vcl/workben/hwpfuzzer.options   |2 ++
 vcl/workben/jpgfuzzer.options   |3 +++
 vcl/workben/lwpfuzzer.options   |2 ++
 vcl/workben/metfuzzer.options   |2 ++
 vcl/workben/mmlfuzzer.options   |3 +++
 vcl/workben/mtpfuzzer.options   |2 ++
 vcl/workben/olefuzzer.options   |2 ++
 vcl/workben/pcdfuzzer.options   |2 ++
 vcl/workben/pctfuzzer.options   |2 ++
 vcl/workben/pcxfuzzer.options   |2 ++
 vcl/workben/pngfuzzer.options   |3 +++
 vcl/workben/ppmfuzzer.options   |2 ++
 vcl/workben/pptfuzzer.options   |2 ++
 vcl/workben/pptxfuzzer.options  |2 ++
 vcl/workben/psdfuzzer.options   |2 ++
 vcl/workben/qpwfuzzer.options   |2 ++
 vcl/workben/rasfuzzer.options   |2 ++
 vcl/workben/rtffuzzer.options   |2 ++
 vcl/workben/scrtffuzzer.options |2 ++
 vcl/workben/slkfuzzer.options   |2 ++
 vcl/workben/svmfuzzer.options   |2 ++
 vcl/workben/tgafuzzer.options   |2 ++
 vcl/workben/tiffuzzer.options   |3 +++
 vcl/workben/wksfuzzer.options   |2 ++
 vcl/workben/wmffuzzer.options   |2 ++
 vcl/workben/ww2fuzzer.options   |2 ++
 vcl/workben/ww6fuzzer.options   |2 ++
 vcl/workben/ww8fuzzer.options   |2 ++
 vcl/workben/xbmfuzzer.options   |2 ++
 vcl/workben/xlsfuzzer.options   |2 ++
 vcl/workben/xlsxfuzzer.options  |2 ++
 vcl/workben/xpmfuzzer.options   |2 ++
 45 files changed, 100 insertions(+), 10 deletions(-)

New commits:
commit c23d1d3efd5ec716525704d91b53ae07cb4c5458
Author: Caolán McNamara 
Date:   Thu Jan 25 17:12:14 2018 +

put a ceiling on various fuzzer input sizes

Change-Id: I7a53859377e6228542be50fd26af6b0d6701384c

diff --git a/bin/oss-fuzz-build.sh b/bin/oss-fuzz-build.sh
index 10759eb31cd2..29c591ca3d7f 100755
--- a/bin/oss-fuzz-build.sh
+++ b/bin/oss-fuzz-build.sh
@@ -34,13 +34,6 @@ popd
 #starting corpuses
 cp $SRC/*_seed_corpus.zip $OUT
 #fuzzing dictionaries
-cp $SRC/gif.dict $OUT/giffuzzer.dict
-cp $SRC/jpeg.dict $OUT/jpgfuzzer.dict
-cp $SRC/png.dict $OUT/pngfuzzer.dict
-cp $SRC/tiff.dict $OUT/tiffuzzer.dict
-cp $SRC/xml.dict $OUT/fodtfuzzer.dict
-cp $SRC/xml.dict $OUT/fodsfuzzer.dict
-cp $SRC/xml.dict $OUT/fodpfuzzer.dict
-cp $SRC/xml.dict $OUT/fodgfuzzer.dict
-cp $SRC/xml.dict $OUT/mmlfuzzer.dict
-cp $SRC/html_tags.dict $OUT/htmlfuzzer.dict
+cp $SRC/*.dict $OUT
+#options files
+cp $SRC/libreoffice/vcl/workben/*.options $OUT
diff --git a/vcl/workben/602fuzzer.options b/vcl/workben/602fuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/602fuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/bmpfuzzer.options b/vcl/workben/bmpfuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/bmpfuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/cgmfuzzer.options b/vcl/workben/cgmfuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/cgmfuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/diffuzzer.options b/vcl/workben/diffuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/diffuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/docxfuzzer.options b/vcl/workben/docxfuzzer.options
new file mode 100644
index ..e8c2b812b01d
--- /dev/null
+++ b/vcl/workben/docxfuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 98304
diff --git a/vcl/workben/dxffuzzer.options b/vcl/workben/dxffuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/dxffuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/epsfuzzer.options b/vcl/workben/epsfuzzer.options
new file mode 100644
index ..678d526b1ea9
--- /dev/null
+++ b/vcl/workben/epsfuzzer.options
@@ -0,0 +1,2 @@
+[libfuzzer]
+max_len = 65536
diff --git a/vcl/workben/fodpfuzzer.options b/vcl/workben/fodpfuzzer.options
new file mode 100644
index ..76d308c39d0c
--- /dev/null
+++ b/vcl/workben/fodpfuzzer.options
@@ -0,0 +1,3 @@
+[libfuzzer]
+max_len = 65536
+dict = xml.dict
diff --git a/vcl/workben/fodsfuzzer.options b/vcl/workben/fodsfuzzer.options
new file mode 100644
index ..76d308c39d0c
--- /dev/null
+++

[Libreoffice-bugs] [Bug 113541] EDITING - Link to external documents is not created correctly - incorrect URL formation when path contains upper case , spaces and '!', '#' or '$' characters

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113541

--- Comment #11 from bunkem  ---
Trying the nightly version:
Version: 6.0.1.0.0+
Build ID: d76fc1a87a31bf513f844be933996334ea85446c
CPU threads: 8; OS: Mac OS X 10.11.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:libreoffice-6-0, Time:
2018-01-25_13:52:46
Locale: en-US (en.UTF-8); Calc: group

This one does the linking correctly. 

What's up with this 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113541] EDITING - Link to external documents is not created correctly - incorrect URL formation when path contains upper case , spaces and '!', '#' or '$' characters

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113541

bunkem  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #10 from bunkem  ---
I've been testing the 6.0RC2 and this issue has cropped up again.

Calc is changing all the links to lowercase and as the Mac file system is cap
sensitive, the links are throwing ERR:507 again.

Version: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU threads: 8; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-CA (en.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81234
Bug 81234 depends on bug 105910, which changed state.

Bug 105910 Summary: Allow defaults to be used as parameters for RTF control 
words without explicit parameters
https://bugs.documentfoundation.org/show_bug.cgi?id=105910

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2018-01-25 Thread Caolán McNamara

 vcl/source/filter/igif/gifread.cxx |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

New commits:
commit 2839be08281b4c6b23b9ecdbb4da2032788b6223
Author: Caolán McNamara 
Date:   Thu Jan 25 16:41:25 2018 +

ofz: cache animation size to avoid timeout

Change-Id: Iede591487782a941a9915123b83537ddadd1b4c5
Reviewed-on: https://gerrit.libreoffice.org/48629
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/filter/igif/gifread.cxx 
b/vcl/source/filter/igif/gifread.cxx
index 2afaa92d16d2..78ed3036e67f 100644
--- a/vcl/source/filter/igif/gifread.cxx
+++ b/vcl/source/filter/igif/gifread.cxx
@@ -50,6 +50,8 @@ class SvStream;
 class GIFReader : public GraphicReader
 {
 Animation   aAnimation;
+sal_uInt64  nAnimationByteSize;
+sal_uInt64  nAnimationMinFileData;
 Bitmap  aBmp8;
 Bitmap  aBmp1;
 BitmapPalette   aGPalette;
@@ -109,7 +111,9 @@ public:
 };
 
 GIFReader::GIFReader( SvStream& rStm )
-: aGPalette ( 256 )
+: nAnimationByteSize(0)
+, nAnimationMinFileData(0)
+, aGPalette ( 256 )
 , aLPalette ( 256 )
 , rIStm ( rStm )
 , nYAcc ( 0 )
@@ -167,13 +171,8 @@ void GIFReader::CreateBitmaps( long nWidth, long nHeight, 
BitmapPalette* pPal,
 // 1:1472.88 [184.11 x 8] is more realistic)
 
 sal_uInt64 nMinFileData = nWidth * nHeight / 2560;
-for (size_t i = 0; i < aAnimation.Count(); ++i)
-{
-const AnimationBitmap& rBitmap = aAnimation.Get(i);
-const Size& rSize = rBitmap.aSizePix;
-nMinFileData += rSize.Width() * rSize.Height() / 2560;
-nCombinedPixSize += rBitmap.aBmpEx.GetSizeBytes();
-}
+nMinFileData += nAnimationMinFileData;
+nCombinedPixSize += nAnimationByteSize;
 
 if (nMaxStreamData < nMinFileData)
 {
@@ -662,6 +661,8 @@ void GIFReader::CreateNewBitmaps()
 else
 aAnimBmp.eDisposal = Disposal::Not;
 
+nAnimationByteSize += aAnimBmp.aBmpEx.GetSizeBytes();
+nAnimationMinFileData += nImageWidth * nImageHeight / 2560;
 aAnimation.Insert( aAnimBmp );
 
 if( aAnimation.Count() == 1 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: hwpfilter/source

2018-01-25 Thread Caolán McNamara

 hwpfilter/source/hwpread.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 09af5c6ce286333d6c41dbd1432c2007c5691f8e
Author: Caolán McNamara 
Date:   Thu Jan 25 13:52:51 2018 +

ofz#5379 Timeout

Change-Id: I876ed253c61a13faae2b31c43fa595b3612cd082
Reviewed-on: https://gerrit.libreoffice.org/48610
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index 25d1d5188fc4..bb8df6defe4a 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -448,7 +448,7 @@ bool Picture::Read(HWPFile & hwpf)
 {
size_t nOldSize = follow.size();
size_t nBlock = std::min(SAL_N_ELEMENTS(hwpf.scratch), 
follow_block_size - nOldSize);
-   size_t nReadBlock = hwpf.Read1b(hwpf.scratch, nBlock);
+   size_t nReadBlock = hwpf.ReadBlock(hwpf.scratch, nBlock);
if (nReadBlock)
{
follow.insert(follow.end(), hwpf.scratch, hwpf.scratch + 
nReadBlock);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers

 i18npool/source/localedata/data/la_VA.xml  |   20 ++--
 i18npool/source/localedata/data/lld_IT.xml |   20 ++--
 i18npool/source/localedata/data/vec_IT.xml |   20 ++--
 3 files changed, 30 insertions(+), 30 deletions(-)

New commits:
commit 80ac1dc53ba2aac97bce067495f7f60c6acabadd
Author: Winfried Donkers 
Date:   Thu Jan 25 16:52:30 2018 +0100

Change TimeSeparator for locale la_VA, lld_IT and vec_IT.

Change-Id: I0afc3a08a31216efdbddc389dc23f0b04bc92b37
Reviewed-on: https://gerrit.libreoffice.org/48619
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/i18npool/source/localedata/data/la_VA.xml 
b/i18npool/source/localedata/data/la_VA.xml
index e951225f1933..ee71bf2666e3 100644
--- a/i18npool/source/localedata/data/la_VA.xml
+++ b/i18npool/source/localedata/data/la_VA.xml
@@ -33,7 +33,7 @@
   /
   .
   ,
-  .
+  :
   ,
   ;

@@ -169,31 +169,31 @@
   WW
 
 
-  HH.MM
+  HH:MM
 
 
-  HH.MM.SS
+  HH:MM:SS
 
 
-  HH.MM AM/PM
+  HH:MM AM/PM
 
 
-  HH.MM.SS AM/PM
+  HH:MM:SS AM/PM
 
 
-  [HH].MM.SS
+  [HH]:MM:SS
 
 
-  MM.SS,00
+  MM:SS,00
 
 
-  [HH].MM.SS,00
+  [HH]:MM:SS,00
 
 
-  DD/MM/YY HH.MM
+  DD/MM/YY HH:MM
 
 
-  DD/MM/ HH.MM.SS
+  DD/MM/ HH:MM:SS
 
   
   
diff --git a/i18npool/source/localedata/data/lld_IT.xml 
b/i18npool/source/localedata/data/lld_IT.xml
index 8f99a86ae1df..5fa8c1120ddd 100644
--- a/i18npool/source/localedata/data/lld_IT.xml
+++ b/i18npool/source/localedata/data/lld_IT.xml
@@ -33,7 +33,7 @@
   /
   .
   ,
-  .
+  :
   ,
   ;
   , 
@@ -170,31 +170,31 @@
   WW
 
 
-  HH.MM
+  HH:MM
 
 
-  HH.MM.SS
+  HH:MM:SS
 
 
-  HH.MM AM/PM
+  HH:MM AM/PM
 
 
-  HH.MM.SS AM/PM
+  HH:MM:SS AM/PM
 
 
-  [HH].MM.SS
+  [HH]:MM:SS
 
 
-  MM.SS,00
+  MM:SS,00
 
 
-  [HH].MM.SS,00
+  [HH]:MM:SS,00
 
 
-  DD/MM/YY HH.MM
+  DD/MM/YY HH:MM
 
 
-  DD/MM/ HH.MM.SS AM/PM
+  DD/MM/ HH:MM:SS AM/PM
 
   
   
diff --git a/i18npool/source/localedata/data/vec_IT.xml 
b/i18npool/source/localedata/data/vec_IT.xml
index aa79dd8b519e..086d59857db5 100644
--- a/i18npool/source/localedata/data/vec_IT.xml
+++ b/i18npool/source/localedata/data/vec_IT.xml
@@ -33,7 +33,7 @@
   /
   .
   ,
-  .
+  :
   ,
   ;

@@ -169,31 +169,31 @@
   WW
 
 
-  HH.MM
+  HH:MM
 
 
-  HH.MM.SS
+  HH:MM:SS
 
 
-  HH.MM AM/PM
+  HH:MM AM/PM
 
 
-  HH.MM.SS AM/PM
+  HH:MM:SS AM/PM
 
 
-  [HH].MM.SS
+  [HH]:MM:SS
 
 
-  MM.SS,00
+  MM:SS,00
 
 
-  [HH].MM.SS,00
+  [HH]:MM:SS,00
 
 
-  DD/MM/YY HH.MM
+  DD/MM/YY HH:MM
 
 
-  DD/MM/ HH.MM.SS
+  DD/MM/ HH:MM:SS
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

2018-01-25 Thread Caolán McNamara

 filter/source/msfilter/svdfppt.cxx |   10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit cf4e7f122ac80399d8ead31e4f5d5732c864be97
Author: Caolán McNamara 
Date:   Thu Jan 25 14:33:22 2018 +

clamp normal page sizes as well as notepages

max multiplication is about 4.4 based on
SvxMSDffManager::SetModel nMapMul/nMapDiv

Change-Id: I97bc6ad76bb43fb46aa521bf852decfdd17883e7
Reviewed-on: https://gerrit.libreoffice.org/48612
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 3779ea408e3f..bb44fae227dd 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -281,11 +281,13 @@ SvStream& ReadPptDocumentAtom(SvStream& rIn, 
PptDocumentAtom& rAtom)
.ReadSChar( nTitlePlaceHoldersOmitted )
.ReadSChar( nRightToLeft )
.ReadSChar( nShowComments );
-rAtom.aSlidesPageSize.Width() = nSlideX;
-rAtom.aSlidesPageSize.Height() = nSlideY;
 // clamp dodgy data to avoid overflow in later calculations
-rAtom.aNotesPageSize.Width() = std::min(nNoticeX, 65536);
-rAtom.aNotesPageSize.Height() = std::min(nNoticeY, 65536);
+const sal_Int32 nPageClamp = SAL_MAX_INT32/5;
+rAtom.aSlidesPageSize.Width() = basegfx::clamp(nSlideX, 
-nPageClamp, nPageClamp);
+rAtom.aSlidesPageSize.Height() = basegfx::clamp(nSlideY, 
-nPageClamp, nPageClamp);
+const sal_Int32 nNoteClamp = 65536;
+rAtom.aNotesPageSize.Width() = basegfx::clamp(nNoticeX, 
-nNoteClamp, nNoteClamp);
+rAtom.aNotesPageSize.Height() = basegfx::clamp(nNoticeY, 
-nNoteClamp, nNoteClamp);
 rAtom.eSlidesPageFormat = static_cast(nSlidePageFormat);
 rAtom.bEmbeddedTrueType = nEmbeddedTrueType;
 rAtom.bTitlePlaceholdersOmitted = nTitlePlaceHoldersOmitted;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2018-01-25 Thread Michael Stahl

 sw/source/filter/html/htmltab.cxx |   21 +
 sw/source/filter/xml/xmltbli.cxx  |   28 
 2 files changed, 49 insertions(+)

New commits:
commit 0628693eaf056fedf4d82be8f58f0b87ab7dc20b
Author: Michael Stahl 
Date:   Thu Jan 25 13:20:55 2018 +0100

sw: try to limit rowspan/colspan attributes a bit

Not sure what would be a reasonable maximum, but this should at least
limit fuzzing to 64k cells at a time.

Change-Id: I03c8f828be7ca2d5caeb1f318b55e25ab3f528ef
Reviewed-on: https://gerrit.libreoffice.org/48589
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/html/htmltab.cxx 
b/sw/source/filter/html/htmltab.cxx
index 178121062d1a..b80020e80e8a 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2857,9 +2858,19 @@ CellSaveStruct::CellSaveStruct( SwHTMLParser& rParser, 
HTMLTable const *pCurTabl
 break;
 case HtmlOptionId::COLSPAN:
 m_nColSpan = static_cast(rOption.GetNumber());
+if (m_nColSpan > 256)
+{
+SAL_INFO("sw.html", "ignoring huge COLSPAN " << 
m_nColSpan);
+m_nColSpan = 1;
+}
 break;
 case HtmlOptionId::ROWSPAN:
 m_nRowSpan = static_cast(rOption.GetNumber());
+if (m_nRowSpan > 8192 || (m_nRowSpan > 256 && 
utl::ConfigManager::IsFuzzing()))
+{
+SAL_INFO("sw.html", "ignoring huge ROWSPAN " << 
m_nRowSpan);
+m_nRowSpan = 1;
+}
 break;
 case HtmlOptionId::ALIGN:
 m_eAdjust = rOption.GetEnum( aHTMLPAlignTable, m_eAdjust );
@@ -4265,6 +4276,11 @@ void SwHTMLParser::BuildTableColGroup( HTMLTable 
*pCurTable,
 break;
 case HtmlOptionId::SPAN:
 pSaveStruct->nColGrpSpan = 
static_cast(rOption.GetNumber());
+if (pSaveStruct->nColGrpSpan > 256)
+{
+SAL_INFO("sw.html", "ignoring huge SPAN " << 
pSaveStruct->nColGrpSpan);
+pSaveStruct->nColGrpSpan = 1;
+}
 break;
 case HtmlOptionId::WIDTH:
 pSaveStruct->nColGrpWidth = 
static_cast(rOption.GetNumber());
@@ -4347,6 +4363,11 @@ void SwHTMLParser::BuildTableColGroup( HTMLTable 
*pCurTable,
 break;
 case HtmlOptionId::SPAN:
 nColSpan = 
static_cast(rOption.GetNumber());
+if (nColSpan > 256)
+{
+SAL_INFO("sw.html", "ignoring huge SPAN " << 
nColSpan);
+nColSpan = 1;
+}
 break;
 case HtmlOptionId::WIDTH:
 nColWidth = 
static_cast(rOption.GetNumber());
diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx
index 1ec745d907ce..bb4e532b8e37 100644
--- a/sw/source/filter/xml/xmltbli.cxx
+++ b/sw/source/filter/xml/xmltbli.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -471,12 +472,27 @@ SwXMLTableCellContext_Impl::SwXMLTableCellContext_Impl(
 break;
 case XML_TOK_TABLE_NUM_COLS_SPANNED:
 nColSpan = static_cast(std::max(1, 
rValue.toInt32()));
+if (nColSpan > 256)
+{
+SAL_INFO("sw.xml", "ignoring huge table:number-columns-spanned 
" << nColSpan);
+nColSpan = 1;
+}
 break;
 case XML_TOK_TABLE_NUM_ROWS_SPANNED:
 nRowSpan = static_cast(std::max(1, 
rValue.toInt32()));
+if (nRowSpan > 8192 || (nRowSpan > 256 && 
utl::ConfigManager::IsFuzzing()))
+{
+SAL_INFO("sw.xml", "ignoring huge table:number-rows-spanned " 
<< nRowSpan);
+nRowSpan = 1;
+}
 break;
 case XML_TOK_TABLE_NUM_COLS_REPEATED:
 nColRepeat = static_cast(std::max(1, 
rValue.toInt32()));
+if (nColRepeat > 256)
+{
+SAL_INFO("sw.xml", "ignoring huge 
table:number-columns-repeated " << nColRepeat);
+nColRepeat = 1;
+}
 break;
 case XML_TOK_TABLE_FORMULA:
 {
@@ -751,7 +767,14 @@ SwXMLTableColContext_Impl::SwXMLTableColContext_Impl(
 if( IsXMLToken( aLocalName, XML_STYLE_NAME ) )
 aStyleName = rValue;

[Libreoffice-bugs] [Bug 112990] LO60master on macOS: crashing at start with OpenGL enabled

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112990

--- Comment #37 from Frank Fuchs  ---
I can reliably reproduce the crash / no crash behaviour as follows:
* enable OpenGL and LO crashes during opening of a document and then goes into
an endless crash / restart / restore loop
* resetting the profile and then NOT enabling OpenGL reliably opens the same
documents w/o problems.

Clearly a regression since I could run LO with OpenGL enabled on all prior LO
versions (which supported OpenGL) on my very same machine.

SW:
LO 6.0.0.3 (LO 6.0.0 RC3)
macOS 10.13.3
Java 8u162

HW:
MacBook Pro Retina early 2013, 16GB RAM, Intel HD 4000 and NVIDIA GeForce GT
650M

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers

 i18npool/source/localedata/data/it_IT.xml |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit c97d67631724c29fa665c5f0aaad0a0fd9a061ee
Author: Winfried Donkers 
Date:   Thu Jan 25 16:22:24 2018 +0100

tdf#105226 follow up: change time separator for locale it_IT.

Change-Id: If994f615b4a9b976086546a80357b75e93952528
Reviewed-on: https://gerrit.libreoffice.org/48615
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/i18npool/source/localedata/data/it_IT.xml 
b/i18npool/source/localedata/data/it_IT.xml
index 94ebb32f8f61..8a047c4aa882 100644
--- a/i18npool/source/localedata/data/it_IT.xml
+++ b/i18npool/source/localedata/data/it_IT.xml
@@ -33,7 +33,7 @@
   /
   .
   ,
-  .
+  :
   ,
   ;

@@ -169,31 +169,31 @@
   WW
 
 
-  HH.MM
+  HH:MM
 
 
-  HH.MM.SS
+  HH:MM:SS
 
 
-  HH.MM AM/PM
+  HH:MM AM/PM
 
 
-  HH.MM.SS AM/PM
+  HH:MM:SS AM/PM
 
 
-  [HH].MM.SS
+  [HH]:MM:SS
 
 
-  MM.SS,00
+  MM:SS,00
 
 
-  [HH].MM.SS,00
+  [HH]:MM:SS,00
 
 
-  GG/MM/AA HH.MM
+  GG/MM/AA HH:MM
 
 
-  GG/MM/ HH.MM.SS
+  GG/MM/ HH:MM:SS
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - i18npool/source

2018-01-25 Thread Stephan Bergmann

 i18npool/source/indexentry/indexentrysupplier_default.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 48653e1edbc72c2a45e8861a837e6233cad1fbba
Author: Stephan Bergmann 
Date:   Thu Jan 25 11:31:45 2018 +0100

Fix Index::getIndexWeight for empty input

...which triggers the assertion `index >= 0 && 
static_cast(index) <
static_cast(getLength())' in rtl::OUString::operator[] at
include/rtl/ustring.hxx:669 (see below for a reproducer).

I am not sure whether the case of `startPos == rIndexEntry.getLength()` 
should
really go into the following for loop inspecting `tables`, with a somewhat
random `code` of U+ (or some other value even?), or should rather be 
handled
explicitly in some other way.

Reproducer in an empty Writer document: "Insert - Table of Contents and 
Index -
Bibliography Entry...": "Insert Bibliography Entry" dialog: "ARJ00", 
"Insert",
"AVV00", "Insert", "Close"; "Insert - Table of Contents and Index - Table of
Contents, Index or Bibliography...": "Table of Contents, Index or 
Bibliography"
dialog: "Type - Type and Title - Type: Bibliography", "Entries - Sort by -
Content", "Entries - Sort Keys - 1: Address", "OK": assert fires

Change-Id: I2c9fad2c37bfa7a3509c197e678311fb45cb991a
Reviewed-on: https://gerrit.libreoffice.org/48564
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit ad9d70e73394b1d0d2c1e1e4584c8bc6f3a5d8b3)
Reviewed-on: https://gerrit.libreoffice.org/48635

diff --git a/i18npool/source/indexentry/indexentrysupplier_default.cxx 
b/i18npool/source/indexentry/indexentrysupplier_default.cxx
index bcd7b2ab6d7c..af86b94c1ad9 100644
--- a/i18npool/source/indexentry/indexentrysupplier_default.cxx
+++ b/i18npool/source/indexentry/indexentrysupplier_default.cxx
@@ -138,7 +138,7 @@ sal_Int16 Index::getIndexWeight(const OUString& rIndexEntry)
 return mkeys[i];
 }
 }
-sal_Unicode code = rIndexEntry[startPos];
+sal_Unicode code = startPos < rIndexEntry.getLength() ? 
rIndexEntry[startPos] : 0;
 for (sal_Int16 i = 0; i < table_count; i++) {
 if (tables[i].start <= code && code <= tables[i].end)
 return tables[i].table[code-tables[i].start];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers

 i18npool/source/localedata/data/it_CH.xml  |4 ++--
 i18npool/source/localedata/data/vec_IT.xml |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 8ff3d8821ef68069c1bdcf1a123b0c929d745566
Author: Winfried Donkers 
Date:   Thu Jan 25 16:26:46 2018 +0100

Fix incorrect AM/PM symbols in locale it_CH and vec_IT.

Follow up of tdf#105226.

Change-Id: I31816a36e427338034a30492f2a7ac7f2d0fddd2
Reviewed-on: https://gerrit.libreoffice.org/48616
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/i18npool/source/localedata/data/it_CH.xml 
b/i18npool/source/localedata/data/it_CH.xml
index 1514c671a367..aa19b9e2339d 100644
--- a/i18npool/source/localedata/data/it_CH.xml
+++ b/i18npool/source/localedata/data/it_CH.xml
@@ -47,8 +47,8 @@
   “
   ”
 
-m.
-p.
+a.m.
+p.m.
 metric
   
   
diff --git a/i18npool/source/localedata/data/vec_IT.xml 
b/i18npool/source/localedata/data/vec_IT.xml
index 705e1aafca4e..aa79dd8b519e 100644
--- a/i18npool/source/localedata/data/vec_IT.xml
+++ b/i18npool/source/localedata/data/vec_IT.xml
@@ -47,8 +47,8 @@
   “
   ”
 
-m.
-p.
+a.m.
+p.m.
 metric
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #42 from Tor Lillqvist  ---
I don't see any percentage scale in the System Preferences > Dock > Size
slider. When you talk about 50% or 40%, is that just an eyeballed estimation?
After touching it, how do I get it back to the default? (Not that it matters
much to me how big it is, I practically never use the Dock for anything, and of
course I have it to auto-hide.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108473] Inserting into a Form Table Control Date/Time (Time) field gets stuck

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108473

--- Comment #7 from Howard Johnson  ---
@Julian, No worries.  It's hard not to be human.  

FTI, I also just tested this on 6.1.0.0.alpha0+ (from a build I did last night)
and it also gets stuck there too.  (I had intended this to be in my last
comment, but my human part got in the way again.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

2018-01-25 Thread Jim Raykowski

 sc/source/ui/view/formatsh.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4c6fc246c9d9388b7a512cb4371bc6bb09e8581b
Author: Jim Raykowski 
Date:   Mon Dec 18 15:03:02 2017 -0900

tdf#114519 Update cell content on sidebar number format change

In Calc, when the cursor is flashing in a cell (input mode) and the
sidebar Number Format panel 'Select a category of contents' drop down
selection is changed the cell contents does not update on selection
change.

This patch ends cell input mode on 'Select a category of contents' drop
down change allowing cell to be updated to the selected number format.

Change-Id: Ia1f46499ada2cfbcc82bd5babb6cf56ae0d6259c
Reviewed-on: https://gerrit.libreoffice.org/46883
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit 7416c2ea6c25ec1ff60ce1055b79b216cd501140)
Reviewed-on: https://gerrit.libreoffice.org/48632
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index 82f5ba3fbc97..b6522696ad34 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -1004,6 +1004,7 @@ void ScFormatShell::ExecuteNumFormat( SfxRequest& rReq )
 {
 switch ( nSlot )
 {
+case SID_NUMBER_TYPE_FORMAT:
 case SID_NUMBER_TWODEC:
 case SID_NUMBER_SCIENTIFIC:
 case SID_NUMBER_DATE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2018-01-25 Thread Eike Rathke

 sc/source/filter/oox/condformatbuffer.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit fef24d9f999ee54d7936900485d97ff26656f517
Author: Eike Rathke 
Date:   Thu Jan 25 20:59:39 2018 +0100

CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressions

Change-Id: I31ede1a23223a798141a0891deeabd8cf88fff58

diff --git a/sc/source/filter/oox/condformatbuffer.cxx 
b/sc/source/filter/oox/condformatbuffer.cxx
index 515e0422accc..3a46a3b28fa6 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -868,11 +868,13 @@ void CondFormatRule::finalizeImport()
 {
 pTokenArray2.reset(new ScTokenArray());
 ScTokenConversion::ConvertToTokenArray( rDoc, *pTokenArray2.get(), 
maModel.maFormulas[ 1 ] );
+rDoc.CheckLinkFormulaNeedingCheck( *pTokenArray2.get());
 }
 
 ScTokenArray aTokenArray;
 OUString aStyleName = getStyles().createDxfStyle( maModel.mnDxfId );
 ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, 
maModel.maFormulas[ 0 ] );
+rDoc.CheckLinkFormulaNeedingCheck( aTokenArray);
 ScCondFormatEntry* pNewEntry = new ScCondFormatEntry(eOperator,
 , pTokenArray2.get(), 
, aPos, aStyleName);
 mpFormat->AddEntry(pNewEntry);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108473] Inserting into a Form Table Control Date/Time (Time) field gets stuck

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108473

--- Comment #6 from Julien Nabet  ---
(In reply to Howard Johnson from comment #5)
> ...
> did you mean the Date/Time (Date) column, or the Date/Time (Time) column?
> ...
I'm very sorry, you're right, I was on the wrong column (dumb me!).
I got each time the error message you attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerfilter/source

2018-01-25 Thread ekuiitr

 writerfilter/source/rtftok/rtfcontrolwords.cxx | 3652 -
 writerfilter/source/rtftok/rtfcontrolwords.hxx |2 
 writerfilter/source/rtftok/rtftokenizer.cxx|   12 
 3 files changed, 1833 insertions(+), 1833 deletions(-)

New commits:
commit 061145e2172886f0bd8b33f16ede7c21dba6f3f6
Author: ekuiitr 
Date:   Tue Jan 23 12:07:03 2018 +0530

tdf#105910 Allow defaults to be used as parameters for RTF control words.

[MS-RTF] specifies in "Conventions of an RTF Reader" section
("Change Formatting Property" action), that if a control word
requires a parameter, and it isn't specified, then a control-word-
specific default value is used. This patch implements the said
rule.
[MS-RTF]: https://www.microsoft.com/download/details.aspx?id=10725

Change-Id: Ic0b76bf16b01c65e1b89c243698fd46fd6426d90
Reviewed-on: https://gerrit.libreoffice.org/48375
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/writerfilter/source/rtftok/rtfcontrolwords.cxx 
b/writerfilter/source/rtftok/rtfcontrolwords.cxx
index 1894055baf63..f1c39391fc6e 100644
--- a/writerfilter/source/rtftok/rtfcontrolwords.cxx
+++ b/writerfilter/source/rtftok/rtfcontrolwords.cxx
@@ -17,1831 +17,1831 @@ namespace rtftok
 {
 RTFSymbol aRTFControlWords[] = {
 // sKeyword nControlType nIndex
-{ "'", CONTROL_SYMBOL, RTF_HEXCHAR },
-{ "-", CONTROL_SYMBOL, RTF_OPTHYPH },
-{ "*", CONTROL_SYMBOL, RTF_IGNORE },
-{ ":", CONTROL_SYMBOL, RTF_SUBENTRY },
-{ "\\", CONTROL_SYMBOL, RTF_BACKSLASH },
-{ "\n", CONTROL_SYMBOL, RTF_PAR },
-{ "\r", CONTROL_SYMBOL, RTF_PAR },
-{ "\r\n", CONTROL_SYMBOL, RTF_PAR },
-{ "_", CONTROL_SYMBOL, RTF_NOBRKHYPH },
-{ "{", CONTROL_SYMBOL, RTF_LBRACE },
-{ "|", CONTROL_SYMBOL, RTF_FORMULA },
-{ "}", CONTROL_SYMBOL, RTF_RBRACE },
-{ "~", CONTROL_SYMBOL, RTF_NOBREAK },
-{ "ab", CONTROL_TOGGLE, RTF_AB },
-{ "absh", CONTROL_VALUE, RTF_ABSH },
-{ "abslock", CONTROL_FLAG, RTF_ABSLOCK },
-{ "absnoovrlp", CONTROL_TOGGLE, RTF_ABSNOOVRLP },
-{ "absw", CONTROL_VALUE, RTF_ABSW },
-{ "acaps", CONTROL_TOGGLE, RTF_ACAPS },
-{ "acccircle", CONTROL_TOGGLE, RTF_ACCCIRCLE },
-{ "acccomma", CONTROL_TOGGLE, RTF_ACCCOMMA },
-{ "accdot", CONTROL_TOGGLE, RTF_ACCDOT },
-{ "accnone", CONTROL_TOGGLE, RTF_ACCNONE },
-{ "accunderdot", CONTROL_TOGGLE, RTF_ACCUNDERDOT },
-{ "acf", CONTROL_VALUE, RTF_ACF },
-{ "adeff", CONTROL_VALUE, RTF_ADEFF },
-{ "additive", CONTROL_FLAG, RTF_ADDITIVE },
-{ "adeflang", CONTROL_VALUE, RTF_ADEFLANG },
-{ "adjustright", CONTROL_FLAG, RTF_ADJUSTRIGHT },
-{ "adn", CONTROL_VALUE, RTF_ADN },
-{ "aenddoc", CONTROL_FLAG, RTF_AENDDOC },
-{ "aendnotes", CONTROL_FLAG, RTF_AENDNOTES },
-{ "aexpnd", CONTROL_VALUE, RTF_AEXPND },
-{ "af", CONTROL_VALUE, RTF_AF },
-{ "afelev", CONTROL_FLAG, RTF_AFELEV },
-{ "afs", CONTROL_VALUE, RTF_AFS },
-{ "aftnbj", CONTROL_FLAG, RTF_AFTNBJ },
-{ "aftncn", CONTROL_DESTINATION, RTF_AFTNCN },
-{ "aftnnalc", CONTROL_FLAG, RTF_AFTNNALC },
-{ "aftnnar", CONTROL_FLAG, RTF_AFTNNAR },
-{ "aftnnauc", CONTROL_FLAG, RTF_AFTNNAUC },
-{ "aftnnchi", CONTROL_FLAG, RTF_AFTNNCHI },
-{ "aftnnchosung", CONTROL_FLAG, RTF_AFTNNCHOSUNG },
-{ "aftnncnum", CONTROL_FLAG, RTF_AFTNNCNUM },
-{ "aftnndbar", CONTROL_FLAG, RTF_AFTNNDBAR },
-{ "aftnndbnum", CONTROL_FLAG, RTF_AFTNNDBNUM },
-{ "aftnndbnumd", CONTROL_FLAG, RTF_AFTNNDBNUMD },
-{ "aftnndbnumk", CONTROL_FLAG, RTF_AFTNNDBNUMK },
-{ "aftnndbnumt", CONTROL_FLAG, RTF_AFTNNDBNUMT },
-{ "aftnnganada", CONTROL_FLAG, RTF_AFTNNGANADA },
-{ "aftnngbnum", CONTROL_FLAG, RTF_AFTNNGBNUM },
-{ "aftnngbnumd", CONTROL_FLAG, RTF_AFTNNGBNUMD },
-{ "aftnngbnumk", CONTROL_FLAG, RTF_AFTNNGBNUMK },
-{ "aftnngbnuml", CONTROL_FLAG, RTF_AFTNNGBNUML },
-{ "aftnnrlc", CONTROL_FLAG, RTF_AFTNNRLC },
-{ "aftnnruc", CONTROL_FLAG, RTF_AFTNNRUC },
-{ "aftnnzodiac", CONTROL_FLAG, RTF_AFTNNZODIAC },
-{ "aftnnzodiacd", CONTROL_FLAG, RTF_AFTNNZODIACD },
-{ "aftnnzodiacl", CONTROL_FLAG, RTF_AFTNNZODIACL },
-{ "aftnrestart", CONTROL_FLAG, RTF_AFTNRESTART },
-{ "aftnrstcont", CONTROL_FLAG, RTF_AFTNRSTCONT },
-{ "aftnsep", CONTROL_DESTINATION, RTF_AFTNSEP },
-{ "aftnsepc", CONTROL_DESTINATION, RTF_AFTNSEPC },
-{ "aftnstart", CONTROL_VALUE, RTF_AFTNSTART },
-{ "aftntj", CONTROL_FLAG, RTF_AFTNTJ },
-{ "ai", CONTROL_TOGGLE, RTF_AI },
-{ "alang", CONTROL_VALUE, RTF_ALANG },
-{ "allowfieldendsel", CONTROL_FLAG, RTF_ALLOWFIELDENDSEL },
-{ "allprot", CONTROL_FLAG, RTF_ALLPROT },
-{ "alntblind", CONTROL_FLAG, RTF_ALNTBLIND },
-{ "alt", CONTROL_FLAG, RTF_ALT },
-{ "animtext", CONTROL_VALUE, RTF_ANIMTEXT },
-{ "annotation", CONTROL_DESTINATION, RTF_ANNOTATION },
-{ "annotprot",

[Libreoffice-commits] core.git: sw/uiconfig

2018-01-25 Thread Olivier Hallot

 sw/uiconfig/swriter/ui/watermarkdialog.ui |   19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

New commits:
commit 24075745b3865edc1254ce0c445f4b7152092545
Author: Olivier Hallot 
Date:   Thu Jan 25 13:46:42 2018 -0200

tdf#112356 Add help button in watermark dialog

Part of documenting the watermark feature of writer

Change-Id: I6376a583f02367c0e87fbd62e3bd449633a4dc5d
Reviewed-on: https://gerrit.libreoffice.org/48618
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/sw/uiconfig/swriter/ui/watermarkdialog.ui 
b/sw/uiconfig/swriter/ui/watermarkdialog.ui
index 1dcc43bffae4..9c823c881e92 100644
--- a/sw/uiconfig/swriter/ui/watermarkdialog.ui
+++ b/sw/uiconfig/swriter/ui/watermarkdialog.ui
@@ -28,6 +28,21 @@
 False
 end
 
+  
+gtk-help
+True
+True
+True
+True
+  
+  
+False
+True
+0
+True
+  
+
+
   
 gtk-ok
 True
@@ -40,7 +55,7 @@
   
 False
 True
-0
+1
   
 
 
@@ -54,7 +69,7 @@
   
 False
 True
-1
+2
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/source

2018-01-25 Thread Bjoern Michaelsen

 sw/inc/ftninfo.hxx|1 -
 sw/source/core/doc/docnew.cxx |8 
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 80fc1fe32aff770164e257ab63f715be9cd2d5ab
Author: Bjoern Michaelsen 
Date:   Thu Jan 25 01:55:43 2018 +0100

Remove SwEndNoteInfo::ReleaseCollection

- obsoleted by SwClient::EndListeningAll()

Change-Id: Id086a42e778b7630c44af4a6ddf2a23d77538c2b
Reviewed-on: https://gerrit.libreoffice.org/48549
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/ftninfo.hxx b/sw/inc/ftninfo.hxx
index eeeb39e1129d..9a6982a81893 100644
--- a/sw/inc/ftninfo.hxx
+++ b/sw/inc/ftninfo.hxx
@@ -71,7 +71,6 @@ public:
 
 void SetPrefix(const OUString& rSet) { sPrefix = rSet; }
 void SetSuffix(const OUString& rSet) { sSuffix = rSet; }
-void ReleaseCollection() { if ( GetRegisteredInNonConst() ) 
GetRegisteredInNonConst()->Remove( this ); }
 };
 
 enum SwFootnotePos
diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index e71260ac584e..5c55de44eb9a 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -498,8 +498,8 @@ SwDoc::~SwDoc()
 
 // Delete for Collections
 // So that we get rid of the dependencies
-mpFootnoteInfo->ReleaseCollection();
-mpEndNoteInfo->ReleaseCollection();
+mpFootnoteInfo->EndListeningAll();
+mpEndNoteInfo->EndListeningAll();
 
 assert(mpDfltTextFormatColl == (*mpTextFormatCollTable)[0]
 && "Default-Text-Collection must always be at the start");
@@ -711,8 +711,8 @@ void SwDoc::ClearDoc()
 
 // Delete for Collections
 // So that we get rid of the dependencies
-mpFootnoteInfo->ReleaseCollection();
-mpEndNoteInfo->ReleaseCollection();
+mpFootnoteInfo->EndListeningAll();
+mpEndNoteInfo->EndListeningAll();
 
 // Optimization: Based on the fact that Standard is always 2nd in the
 // array, we should delete it as the last. With this we avoid
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2018-01-25 Thread Bjoern Michaelsen

 sw/source/core/doc/lineinfo.cxx |4 ++--
 sw/source/core/doc/number.cxx   |   12 ++--
 sw/source/core/docnode/node.cxx |2 +-
 sw/source/core/layout/atrfrm.cxx|8 
 sw/source/core/para/paratr.cxx  |3 +--
 sw/source/core/txtnode/SwGrammarContact.cxx |4 ++--
 sw/source/core/txtnode/txtatr2.cxx  |8 
 7 files changed, 20 insertions(+), 21 deletions(-)

New commits:
commit 93cabd565d412ea65ffd0c3fc01025a52d47ca4e
Author: Bjoern Michaelsen 
Date:   Thu Jan 25 02:21:24 2018 +0100

more GetRegisteredIn obsoleted by StopListeningAll()

Change-Id: I7d69a5112e03cec1b8ebdc389940557b4dbd1117
Reviewed-on: https://gerrit.libreoffice.org/48550
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/source/core/doc/lineinfo.cxx b/sw/source/core/doc/lineinfo.cxx
index d8cf7439a38e..f8599bd94f1d 100644
--- a/sw/source/core/doc/lineinfo.cxx
+++ b/sw/source/core/doc/lineinfo.cxx
@@ -84,8 +84,8 @@ SwLineNumberInfo& SwLineNumberInfo::operator=(const 
SwLineNumberInfo )
 {
 if ( rCpy.GetRegisteredIn() )
 const_cast(rCpy.GetRegisteredIn())->Add( this );
-else if ( GetRegisteredIn() )
-GetRegisteredInNonConst()->Remove( this );
+else
+EndListeningAll();
 
 aType = rCpy.GetNumType();
 aDivider = rCpy.GetDivider();
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index b60a20168802..8912e30363b7 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -217,8 +217,8 @@ SwNumFormat::SwNumFormat(const SvxNumberFormat& rNumFormat, 
SwDoc* pDoc)
 }
 pCFormat->Add( this );
 }
-else if( GetRegisteredIn() )
-GetRegisteredInNonConst()->Remove( this );
+else
+EndListeningAll();
 }
 
 SwNumFormat::~SwNumFormat()
@@ -259,8 +259,8 @@ SwNumFormat& SwNumFormat::operator=( const SwNumFormat& 
rNumFormat)
 SvxNumberFormat::operator=(rNumFormat);
 if( rNumFormat.GetRegisteredIn() )
 rNumFormat.GetRegisteredInNonConst()->Add( this );
-else if( GetRegisteredIn() )
-GetRegisteredInNonConst()->Remove( this );
+else
+EndListeningAll();
 //For i120928,record the cp info of graphic within bullet
 m_cGrfBulletCP = rNumFormat.m_cGrfBulletCP;
 return *this;
@@ -277,8 +277,8 @@ void SwNumFormat::SetCharFormat( SwCharFormat* pChFormat)
 {
 if( pChFormat )
 pChFormat->Add( this );
-else if( GetRegisteredIn() )
-GetRegisteredInNonConst()->Remove( this );
+else
+EndListeningAll();
 }
 
 void SwNumFormat::Modify( const SfxPoolItem* pOld, const SfxPoolItem* pNew )
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 03e262ee2eb7..8e0636759083 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -1042,7 +1042,7 @@ void SwContentNode::Modify( const SfxPoolItem* pOldValue, 
const SfxPoolItem* pNe
 else
 {
 // Else register anyways when dying
-GetRegisteredIn()->Remove( this );
+EndListeningAll();
 if ( GetpSwAttrSet() )
 AttrSetHandleHelper::SetParent( mpAttrSet, *this, 
nullptr, nullptr );
 }
diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index e8b8c79091cc..7ca5544be310 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -2055,16 +2055,16 @@ void SwFormatChain::SetPrev( SwFlyFrameFormat *pFormat )
 {
 if ( pFormat )
 pFormat->Add(  );
-else if ( aPrev.GetRegisteredIn() )
-aPrev.GetRegisteredIn()->Remove(  );
+else
+aPrev.EndListeningAll();
 }
 
 void SwFormatChain::SetNext( SwFlyFrameFormat *pFormat )
 {
 if ( pFormat )
 pFormat->Add(  );
-else if ( aNext.GetRegisteredIn() )
-aNext.GetRegisteredIn()->Remove(  );
+else
+aNext.EndListeningAll();
 }
 
 bool SwFormatChain::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) const
diff --git a/sw/source/core/para/paratr.cxx b/sw/source/core/para/paratr.cxx
index 68dc9bd1c5df..f66b388ffabe 100644
--- a/sw/source/core/para/paratr.cxx
+++ b/sw/source/core/para/paratr.cxx
@@ -66,8 +66,7 @@ void SwFormatDrop::SetCharFormat( SwCharFormat *pNew )
 {
 assert(!pNew || !pNew->IsDefault()); // expose cases that lead to 
use-after-free
 // Rewire
-if ( GetRegisteredIn() )
-GetRegisteredInNonConst()->Remove( this );
+EndListeningAll();
 if(pNew)
 pNew->Add( this );
 }
diff --git a/sw/source/core/txtnode/SwGrammarContact.cxx 
b/sw/source/core/txtnode/SwGrammarContact.cxx
index 78ea24427659..d1ae37a7571d 100644
--- a/sw/source/core/txtnode/SwGrammarContact.cxx
+++

[Libreoffice-commits] core.git: sw/inc sw/source

2018-01-25 Thread Bjoern Michaelsen

 sw/inc/calbck.hxx|1 +
 sw/inc/swevent.hxx   |2 +-
 sw/inc/tox.hxx   |1 -
 sw/source/core/access/accframebase.cxx   |9 +++--
 sw/source/core/access/accnotextframe.cxx |5 +
 sw/source/core/access/accpara.cxx|3 +--
 sw/source/core/access/acctable.cxx   |7 ++-
 sw/source/core/attr/calbck.cxx   |8 +++-
 sw/source/core/attr/format.cxx   |5 ++---
 sw/source/core/crsr/crsrsh.cxx   |3 +--
 sw/source/core/doc/acmplwrd.cxx  |6 +++---
 sw/source/core/doc/docfly.cxx|2 +-
 sw/source/core/doc/docftn.cxx|   16 
 sw/source/core/inc/UndoCore.hxx  |1 -
 sw/source/core/txtnode/fmtatr2.cxx   |4 ++--
 sw/source/core/undo/rolbck.cxx   |2 +-
 sw/source/core/undo/undobj1.cxx  |5 -
 sw/source/core/unocore/unobkm.cxx|2 +-
 sw/source/core/unocore/unochart.cxx  |2 +-
 sw/source/core/unocore/unodraw.cxx   |3 +--
 sw/source/core/unocore/unofield.cxx  |2 +-
 sw/source/core/unocore/unoflatpara.cxx   |3 +--
 sw/source/core/unocore/unoframe.cxx  |3 +--
 sw/source/core/unocore/unoftn.cxx|5 +
 sw/source/core/unocore/unoidx.cxx|8 ++--
 sw/source/core/unocore/unoobj2.cxx   |   14 ++
 sw/source/core/unocore/unoport.cxx   |6 +-
 sw/source/core/unocore/unorefmk.cxx  |7 ++-
 sw/source/core/unocore/unostyle.cxx  |3 +--
 sw/source/core/unocore/unotbl.cxx|8 +++-
 sw/source/core/unocore/unotextmarkup.cxx |5 +
 sw/source/filter/html/htmltab.cxx|   10 +++---
 sw/source/filter/html/swhtml.cxx |2 +-
 sw/source/uibase/wrtsh/wrtsh2.cxx|7 ++-
 34 files changed, 63 insertions(+), 107 deletions(-)

New commits:
commit 360f2d1b46174fcb33323dcac978bfe8796bad19
Author: Bjoern Michaelsen 
Date:   Wed Jan 24 00:56:50 2018 +0100

introduce SwClient::EndListeningAll()

- this is to reduce the use of GetRegisterdIn(), which should be an
  implementation detail
- remove SwTOXMark::DeRegister() which did the same for a part of the
  class tree
- remove SwUndoSetFlyFormat::DeRegisterFromFormat(), same
- remove doubletracking FrameDeleteWatch::m_bDeleted, just check
  GetRegisteredIn()

Change-Id: Id9364076759446ee5ff1898683c3ca700c1014c9
Reviewed-on: https://gerrit.libreoffice.org/48548
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index 38d2e94b4261..06b6266bd32d 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -132,6 +132,7 @@ public:
 
 const SwModify* GetRegisteredIn() const { return m_pRegisteredIn; }
 SwModify* GetRegisteredIn() { return m_pRegisteredIn; }
+void EndListeningAll();
 
 
 // get information about attribute
diff --git a/sw/inc/swevent.hxx b/sw/inc/swevent.hxx
index b108d8de9168..9b6b4b3b84f1 100644
--- a/sw/inc/swevent.hxx
+++ b/sw/inc/swevent.hxx
@@ -111,7 +111,7 @@ struct SwCallMouseEvent
 // note: pFormat is not necessarily the same as
 // GetRegisteredIn() here; see ~SwFormat()
 assert(PTR.pFormat);
-GetRegisteredInNonConst()->Remove(this);
+EndListeningAll();
 }
 eType = EVENT_OBJECT_NONE; PTR.pFormat = nullptr; 
PTR.IMAP.pIMapObj = nullptr;
 }
diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx
index b32b3c8f96ba..2ca0604d3926 100644
--- a/sw/inc/tox.hxx
+++ b/sw/inc/tox.hxx
@@ -142,7 +142,6 @@ public:
 { return m_wXDocumentIndexMark; }
 SAL_DLLPRIVATE void 
SetXTOXMark(css::uno::Reference const& xMark)
 { m_wXDocumentIndexMark = xMark; }
-void DeRegister() { GetRegisteredInNonConst()->Remove( this ); }
 void RegisterToTOXType( SwTOXType& rMark );
 static void InsertTOXMarks( SwTOXMarks& aMarks, const SwTOXType& rType );
 };
diff --git a/sw/source/core/access/accframebase.cxx 
b/sw/source/core/access/accframebase.cxx
index 221304bc3857..88ae7c5aa087 100644
--- a/sw/source/core/access/accframebase.cxx
+++ b/sw/source/core/access/accframebase.cxx
@@ -244,14 +244,14 @@ void SwAccessibleFrameBase::Modify( const SfxPoolItem* 
pOld, const SfxPoolItem *
 case RES_OBJECTDYING:
 // mba: it seems that this class intentionally does not call code in 
base class SwClient
 if( pOld && ( GetRegisteredIn() == static_cast< SwModify *>( 
static_cast< const SwPtrMsgPoolItem * >( pOld )->pObject ) ) )
-GetRegisteredInNonConst()->Remove( this );
+EndListeningAll();
 break;
 
 case RES_FMT_CHG:
 if( pOld &&
 static_cast< const SwFormatChg * >(pNew)->pChangedFormat ==

[Libreoffice-bugs] [Bug 108473] Inserting into a Form Table Control Date/Time (Time) field gets stuck

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108473

--- Comment #5 from Howard Johnson  ---
(In reply to Julien Nabet from comment #4)
> With LO Debian package 5.4.4.2 or with master sources updated yesterday, I
> don't reproduce this.
> 
> I opened the form, put "4:00" on fourth line of the first table on Date
> column, then could move the cursor with keys.
> I noticed that "4:00" was automatically replaced by "04:00" and the ID
> automatically filled.
> Buovjaga: do you still reproduce this with a recent LO version?

@Julien, 

When you say, 

  "... the first table on Date column,..." 

did you mean the Date/Time (Date) column, or the Date/Time (Time) column?

This bug report was for the Date/Time (Time) column.  But if 4:00 is put into
the Date/Time (Date) column it doesn't make sense, and I actually would expect
an error, but I'm not seeing one.  (I guess I might also have to add that as a
separate bug. :-)

Just a few minutes ago I tested this on the following versions:

  5.4.3.2 - can't move up or down without error.
  5.4.4.2   - can't move up or down without error.
  6.0.0.0.beta2 - can't move up or down without error.
  6.0.0.2   - can't move up or down without error.

So, unfortunately I don't see any progress yet.

Thanks
___

OS: Debian 9.3 (x86-64); 
Cinnamon: 3.2.7; 
Linux Kernel: 4.9.0-5-amd64; 
Processor: Intel Core 2 Duo P8800; 
Graphics Card: AMD/ATI RV710/M92 Mobility Radeon HD 4530/4570/545v

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115231] FILESAVE: ODT: Signature is not displayed after RT

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115231

--- Comment #3 from Samuel Mehrbrodt (CIB)  ---
The import is not yet implemented ;)
Bug 83877 is still in progress...

But note that this only affects current master, not any released version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #8 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #7)

Of course. And the clear() (in the second time!) actually deletes the
document... should it do that at all? and when it does, shouldn't it have
removed itself from some listeners list beforehand, to not receive events
initiated bu that document's destruction?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - sw/inc sw/source

2018-01-25 Thread Michael Stahl

 sw/inc/doc.hxx  |7 ---
 sw/source/core/doc/docnew.cxx   |   17 +
 sw/source/core/doc/doctxm.cxx   |   14 +-
 sw/source/uibase/dbui/dbmgr.cxx |   12 ++--
 4 files changed, 24 insertions(+), 26 deletions(-)

New commits:
commit 26d34f319ba48216785f7fdbf9e6bfdaf2dc6ad2
Author: Michael Stahl 
Date:   Thu Jan 25 15:49:34 2018 +0100

sw: fix some bug in SwTOXBaseSection::UpdatePageNum()

Looking at UpdatePageNum_ it's fairly obvious that the 2 vectors aNums
and aDescs have to be in sync, but aNums is cleared after each iteration
while aDescs is not.

Change-Id: I41d8a8df5c4c3ae51aa5ea89c21b01651af5651c

diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index 3202362cbbf2..aa2bee2db1ad 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -1548,8 +1548,6 @@ void SwTOXBaseSection::UpdatePageNum()
 for( SwTOXSortTabBases::size_type nCnt = 0; nCnt < aSortArr.size(); ++nCnt 
)
 {
 // Loop over all SourceNodes
-std::vector aNums; // the PageNumber
-std::vector aDescs;// The PageDescriptors 
matching the PageNumbers
 
 // process run in lines
 SwTOXSortTabBases::size_type nRange = 0;
@@ -1572,6 +1570,8 @@ void SwTOXBaseSection::UpdatePageNum()
 
 for(SwTOXSortTabBases::size_type nRunInEntry = nCnt; nRunInEntry < 
nCnt + nRange; ++nRunInEntry)
 {
+std::vector aNums; // the PageNumber
+std::vector aDescs; // The PageDescriptors matching 
the PageNumbers
 std::vector aMainNums; // contains page numbers of 
main entries
 SwTOXSortTabBase* pSortBase = aSortArr[nRunInEntry];
 size_t nSize = pSortBase->aTOXSources.size();
@@ -1630,7 +1630,6 @@ void SwTOXBaseSection::UpdatePageNum()
 UpdatePageNum_( const_cast(pTextNd), aNums, 
aDescs, ,
 aIntl );
 }
-aNums.clear();
 }
 }
 // Delete the mapping array after setting the right PageNumber
commit 38af1bb52d3833da7919e61e650fb9ec1bdaf4f7
Author: Michael Stahl 
Date:   Thu Jan 25 15:44:34 2018 +0100

sw: de-pointerise local variable in SwTOXBaseSection::UpdatePageNum()

Change-Id: I24fcde19ae94cc5a278da6d88e72ce6a57a64951

diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index e19316445785..3202362cbbf2 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -1550,7 +1550,6 @@ void SwTOXBaseSection::UpdatePageNum()
 // Loop over all SourceNodes
 std::vector aNums; // the PageNumber
 std::vector aDescs;// The PageDescriptors 
matching the PageNumbers
-std::vector *pMainNums = nullptr; // contains page numbers 
of main entries
 
 // process run in lines
 SwTOXSortTabBases::size_type nRange = 0;
@@ -1573,6 +1572,7 @@ void SwTOXBaseSection::UpdatePageNum()
 
 for(SwTOXSortTabBases::size_type nRunInEntry = nCnt; nRunInEntry < 
nCnt + nRange; ++nRunInEntry)
 {
+std::vector aMainNums; // contains page numbers of 
main entries
 SwTOXSortTabBase* pSortBase = aSortArr[nRunInEntry];
 size_t nSize = pSortBase->aTOXSources.size();
 for (size_t j = 0; j < nSize; ++j)
@@ -1616,9 +1616,7 @@ void SwTOXBaseSection::UpdatePageNum()
 if(TOX_SORT_INDEX == pSortBase->GetType() &&
 rTOXSource.bMainEntry)
 {
-if(!pMainNums)
-pMainNums = new std::vector;
-pMainNums->push_back(nPage);
+aMainNums.push_back(nPage);
 }
 }
 }
@@ -1629,10 +1627,9 @@ void SwTOXBaseSection::UpdatePageNum()
 const SwTextNode* pTextNd = pBase->pTOXNd->GetTextNode();
 OSL_ENSURE( pTextNd, "no TextNode, wrong TOC" );
 
-UpdatePageNum_( const_cast(pTextNd), aNums, 
aDescs, pMainNums,
+UpdatePageNum_( const_cast(pTextNd), aNums, 
aDescs, ,
 aIntl );
 }
-DELETEZ(pMainNums);
 aNums.clear();
 }
 }
commit 7dbe76266cb4250701aaee043933ccb21e5f6564
Author: Michael Stahl 
Date:   Thu Jan 25 15:43:19 2018 +0100

sw: convert SwDoc::mpDBManager to unique_ptr

Very odd things are happening in dbmgr.cxx to override this member,
so add a 2nd member that points to the DBManager that is actually used.

Change-Id: If5d4ea1e4951a0406fddcb71302c53ee7b37a34e

diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 726471e1dea6..aa7ee77406cf 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -283,7 +283,8 @@ class

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - dbaccess/source

2018-01-25 Thread Caolán McNamara

 dbaccess/source/ui/inc/browserids.hxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 2b4ad9183d7fc0da40dc1fdd523bdc613612024c
Author: Caolán McNamara 
Date:   Tue Jan 23 20:48:51 2018 +

tdf#115080 menu id collision

21 collides with the pattern field menu id

Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56
Reviewed-on: https://gerrit.libreoffice.org/48487
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/dbaccess/source/ui/inc/browserids.hxx 
b/dbaccess/source/ui/inc/browserids.hxx
index 5ce766602db5..7603c8c39140 100644
--- a/dbaccess/source/ui/inc/browserids.hxx
+++ b/dbaccess/source/ui/inc/browserids.hxx
@@ -47,11 +47,11 @@
 #define ID_BROWSER_REMOVEFILTER SID_FM_REMOVE_FILTER_SORT
 #define ID_BROWSER_FILTERED SID_FM_FORM_FILTERED
 #define ID_BROWSER_REFRESH  SID_FM_REFRESH
-#define ID_BROWSER_COLATTRSET   20  // Spaltenformatierung
-#define ID_BROWSER_COLWIDTH 21  // Spaltenbreite
-#define ID_BROWSER_TABLEATTR22  // table format attributes
-#define ID_BROWSER_ROWHEIGHT23  // Zeilenhoehe
-#define ID_BROWSER_COLUMNINFO   24  // copies the column 
description to insert it into the table design
+#define ID_BROWSER_COLATTRSET   10020  // column formatting
+#define ID_BROWSER_COLWIDTH 10021  // column width
+#define ID_BROWSER_TABLEATTR10022  // table format attributes
+#define ID_BROWSER_ROWHEIGHT10023  // row height
+#define ID_BROWSER_COLUMNINFO   10024  // copies the column 
description to insert it into the table design
 #define ID_BROWSER_ADDTABLE SID_FM_ADDTABLE
 #define ID_BROWSER_EXPLORER SID_DSBROWSER_EXPLORER
 #define ID_BROWSER_DOCUMENT_DATASOURCE  SID_DOCUMENT_DATA_SOURCE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96011] Document is not focused on opening LO / opening existing documents

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96011

John Marchi  changed:

   What|Removed |Added

  Component|Writer  |Calc

--- Comment #18 from John Marchi  ---
Upgraded to 5.4.4 today. Opened a .xls document with Calc. Calc opened the
"Import Options" window behind other windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - svl/source

2018-01-25 Thread Eike Rathke

 svl/source/numbers/zforscan.cxx |8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 28265db967d90680c1fd754bb746751b849373b3
Author: Eike Rathke 
Date:   Tue Oct 17 12:34:35 2017 +0200

Add to nPos once instead of in each iteration

(cherry picked from commit d728492f4aa195fd4aec3ddb116879de76a95c6d)

Change-Id: I9ab9d5be1edead3a83375d87910bc9128c894b85
Reviewed-on: https://gerrit.libreoffice.org/48302
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/svl/source/numbers/zforscan.cxx b/svl/source/numbers/zforscan.cxx
index cd09a444c81f..74a765238518 100644
--- a/svl/source/numbers/zforscan.cxx
+++ b/svl/source/numbers/zforscan.cxx
@@ -2412,19 +2412,18 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )
 bDecSep = true;
 nTypeArray[i] = NF_SYMBOLTYPE_DIGIT;
 OUString& rStr = sStrArray[i];
-nPos = nPos + sStrArray[i].getLength();
 nCounter++;
 i++;
 while (i < nAnzStrings &&
sStrArray[i][0] == '0')
 {
 rStr += sStrArray[i];
-nPos = nPos + sStrArray[i].getLength();
 nTypeArray[i] = NF_SYMBOLTYPE_EMPTY;
 nAnzResStrings--;
 nCounter++;
 i++;
 }
+nPos += rStr.getLength();
 }
 else
 {
@@ -2562,19 +2561,18 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )
 bDecSep = true;
 nTypeArray[i] = NF_SYMBOLTYPE_DIGIT;
 OUString& rStr = sStrArray[i];
-nPos = nPos + sStrArray[i].getLength();
-i++;
 nCounter++;
+i++;
 while (i < nAnzStrings &&
sStrArray[i][0] == '0')
 {
 rStr += sStrArray[i];
-nPos = nPos + sStrArray[i].getLength();
 nTypeArray[i] = NF_SYMBOLTYPE_EMPTY;
 nAnzResStrings--;
 nCounter++;
 i++;
 }
+nPos += rStr.getLength();
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/osx

2018-01-25 Thread Caolán McNamara

 vcl/osx/salframeview.mm |   21 -
 1 file changed, 12 insertions(+), 9 deletions(-)

New commits:
commit 378d7d68d9e842039bcf797a8b95c2e85768e1e7
Author: Caolán McNamara 
Date:   Sat Jan 20 20:01:13 2018 +

tdf#109062 restore osx scrollwheel logic

to pre

commit f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c
Date:   Tue May 16 10:12:09 2017 +0100

Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling

state.

Change-Id: If5a494441731e73136158b4905c2744ba8bc8875
Reviewed-on: https://gerrit.libreoffice.org/48306
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/vcl/osx/salframeview.mm b/vcl/osx/salframeview.mm
index 50cd5bc4e722..c7bf9c965d87 100644
--- a/vcl/osx/salframeview.mm
+++ b/vcl/osx/salframeview.mm
@@ -807,9 +807,10 @@ private:
 if( aEvent.mnDelta == 0 )
 aEvent.mnDelta = aEvent.mnNotchDelta;
 aEvent.mbHorz = FALSE;
-aEvent.mnScrollLines = nDeltaZ;
-if( aEvent.mnScrollLines == 0 )
-aEvent.mnScrollLines = 1;
+sal_uInt32 nScrollLines = nDeltaZ;
+if (nScrollLines == 0)
+nScrollLines = 1;
+aEvent.mnScrollLines = nScrollLines;
 mpFrame->CallCallback( SalEvent::WheelMouse,  );
 }
 }
@@ -929,9 +930,10 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 if( aEvent.mnDelta == 0 )
 aEvent.mnDelta = aEvent.mnNotchDelta;
 aEvent.mbHorz = TRUE;
-aEvent.mnScrollLines = fabs(dX) / WHEEL_EVENT_FACTOR;
-if( aEvent.mnScrollLines == 0 )
-aEvent.mnScrollLines = 1;
+sal_uInt32 nScrollLines = fabs(dX) / WHEEL_EVENT_FACTOR;
+if (nScrollLines == 0)
+nScrollLines = 1;
+aEvent.mnScrollLines = nScrollLines;
 
 mpFrame->CallCallback( SalEvent::WheelMouse,  );
 }
@@ -942,9 +944,10 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 if( aEvent.mnDelta == 0 )
 aEvent.mnDelta = aEvent.mnNotchDelta;
 aEvent.mbHorz = FALSE;
-aEvent.mnScrollLines = fabs(dY) / WHEEL_EVENT_FACTOR;
-if( aEvent.mnScrollLines == 0 )
-aEvent.mnScrollLines = 1;
+sal_uInt32 nScrollLines = fabs(dY) / WHEEL_EVENT_FACTOR;
+if (nScrollLines == 0)
+nScrollLines = 1;
+aEvent.mnScrollLines = nScrollLines;
 
 mpFrame->CallCallback( SalEvent::WheelMouse,  );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

2018-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #7 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #6)
> (In reply to Julien Nabet from comment #5)
> 
> The destroying viewshell gets used in the update sequence, and so its
> partially destroyed data is being accessed. The problem here IMO is how to
> ensure that it doesn't get involved in the update sequence (deregister it
> somewhere prior to the clearing the mxDoc?).

Seeing the bt:
frame 15:
328 mxDoc.clear();
frame 2:
   2549 SwView* pView =  GetDoc()->GetDocShell() ?
GetDoc()->GetDocShell()->GetView() : nullptr;

It seems indeed the call to clear() which triggers the pb.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - editeng/qa

2018-01-25 Thread Szymon Kłos

 editeng/qa/unit/core-test.cxx |   94 ++
 1 file changed, 94 insertions(+)

New commits:
commit 70cae0860a144de898bed5a990759dec400d978c
Author: Szymon Kłos 
Date:   Wed Jan 3 11:25:23 2018 +0100

tdf#114628 unit test for line spacing

* two cases 60% and 150% line spacing

Change-Id: I2ce66cd19f459b738243052b5c12da0bbb883ebe
Reviewed-on: https://gerrit.libreoffice.org/47303
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/47582
Reviewed-by: Eike Rathke 

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index d2b8affea7a1..7736db426c0a 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -20,6 +20,9 @@
 #include "editeng/eeitem.hxx"
 #include "editeng/editids.hrc"
 #include "editeng/editdoc.hxx"
+#include "editeng/fontitem.hxx"
+#include "editeng/fhgtitem.hxx"
+#include "editeng/lspcitem.hxx"
 #include "editeng/svxacorr.hxx"
 #include "editeng/unofield.hxx"
 #include "editeng/wghtitem.hxx"
@@ -46,6 +49,9 @@ public:
 virtual void setUp() override;
 virtual void tearDown() override;
 
+/// Test text portions position when percentage line spacing is set
+void testLineSpacing();
+
 void testConstruction();
 
 /// Test UNO service class that implements text field items.
@@ -75,6 +81,7 @@ public:
 void testSectionAttributes();
 
 CPPUNIT_TEST_SUITE(Test);
+CPPUNIT_TEST(testLineSpacing);
 CPPUNIT_TEST(testConstruction);
 CPPUNIT_TEST(testUnoTextFields);
 CPPUNIT_TEST(testAutocorrect);
@@ -108,6 +115,93 @@ void Test::tearDown()
 test::BootstrapFixture::tearDown();
 }
 
+void Test::testLineSpacing()
+{
+// Create EditEngine's instance
+EditEngine aEditEngine(mpItemPool);
+
+if(aEditEngine.GetRefDevice()->GetDPIY() != 96
+|| 
!basegfx::fTools::equal(aEditEngine.GetRefDevice()->GetDPIScaleFactor(), 1.0))
+return;
+
+// Get EditDoc for current EditEngine's instance
+EditDoc  = aEditEngine.GetEditDoc();
+
+// Initially no text should be there
+CPPUNIT_ASSERT_EQUAL(sal_uLong(0), rDoc.GetTextLen());
+CPPUNIT_ASSERT_EQUAL(OUString(), rDoc.GetParaAsString(sal_Int32(0)));
+
+// Set initial text
+OUString aText = "This is multi-line paragraph";
+
+sal_Int32 aTextLen = aText.getLength();
+aEditEngine.SetText(aText);
+
+// Assert changes - text insertion
+CPPUNIT_ASSERT_EQUAL(sal_uLong(aTextLen), rDoc.GetTextLen());
+CPPUNIT_ASSERT_EQUAL(aText, rDoc.GetParaAsString(sal_Int32(0)));
+
+// Get ItemSet for line spacing - 60%
+std::unique_ptr pSet(new 
SfxItemSet(aEditEngine.GetEmptyItemSet()));
+SvxLineSpacingItem aLineSpacing(LINE_SPACE_DEFAULT_HEIGHT, EE_PARA_SBL);
+aLineSpacing.SetPropLineSpace(60);
+pSet->Put(aLineSpacing);
+
+// Set font
+SvxFontItem aFont(EE_CHAR_FONTINFO);
+aFont.SetFamilyName("Liberation Sans");
+pSet->Put(aFont);
+SvxFontHeightItem aFontSize(240, 100, EE_CHAR_FONTHEIGHT);
+pSet->Put(aFontSize);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(3), pSet->Count());
+
+// Select all paragraphs and set spacing
+ESelection aSelection(0, 0, 0, aTextLen);
+aEditEngine.QuickSetAttribs(*pSet, aSelection);
+
+// Force multiple lines
+aEditEngine.SetPaperSize(Size(1000, 6000));
+CPPUNIT_ASSERT_EQUAL((sal_Int32)4, aEditEngine.GetLineCount(0));
+
+// Assert changes
+ParaPortion* pParaPortion = aEditEngine.GetParaPortions()[0];
+ContentNode* const pNode = pParaPortion->GetNode();
+const SfxPoolItem& rLSItem = 
pNode->GetContentAttribs().GetItem(EE_PARA_SBL);
+const SvxLineSpacingItem* pLSItem = static_cast();
+CPPUNIT_ASSERT_EQUAL(SvxInterLineSpaceRule::Prop, 
pLSItem->GetInterLineSpaceRule());
+CPPUNIT_ASSERT_EQUAL((sal_uInt16)60, pLSItem->GetPropLineSpace());
+
+// Check the first line
+ParagraphInfos aInfo = aEditEngine.GetParagraphInfos(0);
+CPPUNIT_ASSERT_EQUAL((sal_uInt16)122, aInfo.nFirstLineMaxAscent);
+CPPUNIT_ASSERT_EQUAL((sal_uInt16)153, 
(sal_uInt16)aEditEngine.GetLineHeight(0));
+
+// Prepare second case - 150%
+std::unique_ptr pSet2(new 
SfxItemSet(aEditEngine.GetEmptyItemSet()));
+SvxLineSpacingItem aLineSpacing2(LINE_SPACE_DEFAULT_HEIGHT, EE_PARA_SBL);
+aLineSpacing2.SetPropLineSpace(150);
+pSet2->Put(aLineSpacing2);
+pSet2->Put(aFont);
+pSet2->Put(aFontSize);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(3), pSet2->Count());
+
+// Select all paragraphs and set spacing
+aEditEngine.QuickSetAttribs(*pSet2, aSelection);
+
+// Assert changes
+const SfxPoolItem& rLSItem2 = 
pNode->GetContentAttribs().GetItem(EE_PARA_SBL);
+const SvxLineSpacingItem* pLSItem2 = static_cast();
+CPPUNIT_ASSERT_EQUAL(SvxInterLineSpaceRule::Prop, 
pLSItem2->GetInterLineSpaceRule());
+

1 2 3 4 >

1 - 100 of 344 matches

Mail list logo