[Libreoffice-bugs] [Bug 115424] menu font missing
https://bugs.documentfoundation.org/show_bug.cgi?id=115424 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Alex Thurgood --- @awaschb : please tell us whether or not you have changed the system font. What you are seeing is a failed fallback representation of the font, which might indicate that the system font isn't supported. Do you have any particular LO language packs installed ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 --- Comment #13 from Chandanathil P. Geevan--- Seems like a minor issue with the files packaged with different distributions. Yesterday, I downloaded a new copy and tried a repair. That did not resolve the problem. Or, is it possible that some of the new styles are there in the distribution, but there is some way they remain inactive? The problem is real. Many have reported although they have not bothered to file a bug report. It isn't a critical issue. But does affect the credibility. The new table format styles were highlighted in the promotions for the new release but are missing in the installation for many. It is very disappointing. This doesn't seem a 'difficult' issue to resolve since it is working for many and not for only a few. Will be great if this issue could be quickly resolved. Hoping for the best. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 --- Comment #13 from Chandanathil P. Geevan--- Seems like a minor issue with the files packaged with different distributions. Yesterday, I downloaded a new copy and tried a repair. That did not resolve the problem. Or, is it possible that some of the new styles are there in the distribution, but there is some way they remain inactive? The problem is real. Many have reported although they have not bothered to file a bug report. It isn't a critical issue. But does affect the credibility. The new table format styles were highlighted in the promotions for the new release but are missing in the installation for many. It is very disappointing. This doesn't seem a 'difficult' issue to resolve since it is working for many and not for only a few. Will be great if this issue could be quickly resolved. Hoping for the best. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: 2 commits - canvas/source cui/source drawinglayer/source emfio/source filter/source forms/source include/comphelper include/svx sd/source svtools/source svx/source vcl/
canvas/source/vcl/canvasbitmaphelper.cxx | 11 - canvas/source/vcl/canvashelper.cxx |4 canvas/source/vcl/impltools.cxx | 16 + cui/source/dialogs/colorpicker.cxx | 18 + drawinglayer/source/primitive2d/sceneprimitive2d.cxx | 12 - emfio/source/reader/wmfreader.cxx|3 filter/source/graphicfilter/icgm/bitmap.cxx | 11 - filter/source/graphicfilter/ieps/ieps.cxx|5 filter/source/graphicfilter/ipcx/ipcx.cxx| 19 +- filter/source/graphicfilter/ipict/ipict.cxx |4 filter/source/graphicfilter/ipsd/ipsd.cxx|3 filter/source/graphicfilter/itga/itga.cxx| 11 - forms/source/component/Columns.hxx |4 forms/source/component/Hidden.hxx|4 include/comphelper/accessibletexthelper.hxx |4 include/svx/svdview.hxx |4 sd/source/ui/inc/fuhhconv.hxx|4 svtools/source/graphic/grfmgr2.cxx | 31 ++- svtools/source/graphic/transformer.cxx |3 svx/source/inc/sdbdatacolumn.hxx |4 svx/source/svdraw/svdfmtf.cxx|6 svx/source/svdraw/svdoashp.cxx |3 svx/source/xoutdev/_xoutbmp.cxx |5 vcl/source/bitmap/BitmapProcessor.cxx| 18 + vcl/source/bitmap/BitmapScaleConvolution.cxx |3 vcl/source/bitmap/bitmapscalesuper.cxx | 30 ++- vcl/source/gdi/alpha.cxx |8 vcl/source/gdi/bitmap.cxx| 180 +-- vcl/source/gdi/bitmap3.cxx | 96 ++ vcl/source/gdi/bitmap4.cxx | 46 +++- vcl/source/gdi/bitmapex.cxx | 48 ++--- vcl/source/gdi/bmpacc.cxx|5 vcl/source/gdi/bmpacc3.cxx |3 vcl/source/gdi/dibtools.cxx |6 vcl/source/helper/canvastools.cxx| 22 +- vcl/source/outdev/bitmap.cxx | 30 +-- vcl/source/outdev/transparent.cxx|6 vcl/workben/vcldemo.cxx |6 38 files changed, 444 insertions(+), 252 deletions(-) New commits: commit 3e0efdb50cd9bcf1749993607330ea1567eb33a2 Author: Noel GrandinDate: Tue Jan 30 20:40:19 2018 +0200 convert SetPixel->SetPixelOnData by extracting out the Y scanline computation from the innermost loop. Inspired by commit 078d01c1b6cb9bbd80aeadc49a71cc817413164c. Change-Id: Ic3c1827c01ed3aec629975749a551c7a68ae4a5e Reviewed-on: https://gerrit.libreoffice.org/48926 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/canvas/source/vcl/canvasbitmaphelper.cxx b/canvas/source/vcl/canvasbitmaphelper.cxx index f3f3995a889b..bdb016fd 100644 --- a/canvas/source/vcl/canvasbitmaphelper.cxx +++ b/canvas/source/vcl/canvasbitmaphelper.cxx @@ -308,17 +308,20 @@ namespace vclcanvas default: { +Scanline pScan = pWriteAccess->GetScanline( y ); +Scanline pAScan = pAlphaWriteAccess->GetScanline( y ); + for( long x=rect.X1; x SetPixel( y, x, BitmapColor( data[ nCurrPos ], +pWriteAccess->SetPixelOnData( pScan, x, BitmapColor( data[ nCurrPos ], data[ nCurrPos+1 ], data[ nCurrPos+2 ] ) ); nCurrPos += 3; // cast to unsigned byte, for correct subtraction result -pAlphaWriteAccess->SetPixel( y, x, +pAlphaWriteAccess->SetPixelOnData( pAScan, x, BitmapColor( static_cast(255 - static_cast(data[ nCurrPos++ ])) ) ); @@ -387,11 +390,13 @@ namespace vclcanvas default: { +Scanline pScan = pWriteAccess->GetScanline( y ); + for( long x=rect.X1; x
[Libreoffice-bugs] [Bug 115481] New: Letter paper size is not what it should be.
https://bugs.documentfoundation.org/show_bug.cgi?id=115481 Bug ID: 115481 Summary: Letter paper size is not what it should be. Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shamoakrasie...@gmail.com Created attachment 139620 --> https://bugs.documentfoundation.org/attachment.cgi?id=139620=edit Screenshots of the issue. The letter paper size in the Page Properties menu shows a width of 8.5 " and a hight of 11.00 " which is the standard letter size. However, when printing (whether a file, or a printer) the letter paper size is fixed to the government letter size which is 8.00 " by 10.00 ". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Mailbox Service Warning
Dear libreoffice, Your email account will Expire on 8 Feb 2018, If you want to continue using your email address: libreoffice@lists.freedesktop.org You will need to verify immediately to prevent your account from terminating All messages and files will be lost if you do not immediately verify Verify Now This service is free of charge. lists.freedesktop.org provider! © 2018 All rights reserved ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 50699] Template Changer: Allow ability to change a document' s associated template
https://bugs.documentfoundation.org/show_bug.cgi?id=50699 --- Comment #52 from Jon Grossart--- Most of the functionality to implement this enhancement are already present. 1. if a template is updated, LibreOffice already asks if you want to update the styles when you open a document based on it 2. there is already code to manually load/update styles. What would be needed in the GUI to allow someone to change the associated template and the code to call the exist code to update the styles (which could probably even be a force close/reopen since that code path already does that in some way). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 50699] Template Changer: Allow ability to change a document' s associated template
https://bugs.documentfoundation.org/show_bug.cgi?id=50699 --- Comment #52 from Jon Grossart--- Most of the functionality to implement this enhancement are already present. 1. if a template is updated, LibreOffice already asks if you want to update the styles when you open a document based on it 2. there is already code to manually load/update styles. What would be needed in the GUI to allow someone to change the associated template and the code to call the exist code to update the styles (which could probably even be a force close/reopen since that code path already does that in some way). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 Dieter Praaschanged: What|Removed |Added Keywords||needsUXEval Status|NEEDINFO|NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||107553 --- Comment #12 from Dieter Praas --- (In reply to Leif Lodahl from comment #10) > I can confirm in 6.0.0.3 Linux x86_64. => I set the bug report to NEW Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107553 [Bug 107553] [META] Writer table styles bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107553] [META] Writer table styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107553 Dieter Praaschanged: What|Removed |Added Depends on||115448 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115448 [Bug 115448] Missing new table formats in Writer/LO6.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 Dieter Praaschanged: What|Removed |Added Keywords||needsUXEval Status|NEEDINFO|NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||107553 --- Comment #12 from Dieter Praas --- (In reply to Leif Lodahl from comment #10) > I can confirm in 6.0.0.3 Linux x86_64. => I set the bug report to NEW Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107553 [Bug 107553] [META] Writer table styles bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - icon-themes/sifr icon-themes/sifr_dark
icon-themes/sifr/cmd/32/backcolor.png |binary icon-themes/sifr/cmd/32/bold.png |binary icon-themes/sifr/cmd/lc_bold.png |binary icon-themes/sifr/cmd/sc_backcolor.png |binary icon-themes/sifr/cmd/sc_bold.png |binary icon-themes/sifr_dark/cmd/32/backcolor.png |binary icon-themes/sifr_dark/cmd/32/bold.png |binary icon-themes/sifr_dark/cmd/lc_backcolor.png |binary icon-themes/sifr_dark/cmd/lc_bold.png |binary icon-themes/sifr_dark/cmd/sc_backcolor.png |binary icon-themes/sifr_dark/cmd/sc_bold.png |binary 11 files changed New commits: commit f0cfb480adb9a4ef39ee09af622041c55812a2c3 Author: Matthias FreundDate: Sun Feb 4 21:51:29 2018 +0100 tdf#75256 Sifr update 32px for bold and backcolor Change-Id: Ibd6dc50925ad6188292e38c87f5ffbbf10792993 Reviewed-on: https://gerrit.libreoffice.org/49255 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/sifr/cmd/32/backcolor.png b/icon-themes/sifr/cmd/32/backcolor.png new file mode 100644 index ..1ab5a920775d Binary files /dev/null and b/icon-themes/sifr/cmd/32/backcolor.png differ diff --git a/icon-themes/sifr/cmd/32/bold.png b/icon-themes/sifr/cmd/32/bold.png new file mode 100644 index ..a1d742570fff Binary files /dev/null and b/icon-themes/sifr/cmd/32/bold.png differ diff --git a/icon-themes/sifr/cmd/lc_bold.png b/icon-themes/sifr/cmd/lc_bold.png index 9ed70b4c4be6..f2e1706d03d9 100644 Binary files a/icon-themes/sifr/cmd/lc_bold.png and b/icon-themes/sifr/cmd/lc_bold.png differ diff --git a/icon-themes/sifr/cmd/sc_backcolor.png b/icon-themes/sifr/cmd/sc_backcolor.png index 9f000129e1a1..f12aee1b8d17 100644 Binary files a/icon-themes/sifr/cmd/sc_backcolor.png and b/icon-themes/sifr/cmd/sc_backcolor.png differ diff --git a/icon-themes/sifr/cmd/sc_bold.png b/icon-themes/sifr/cmd/sc_bold.png index ce7bc4eecadb..368a8cdd5692 100644 Binary files a/icon-themes/sifr/cmd/sc_bold.png and b/icon-themes/sifr/cmd/sc_bold.png differ diff --git a/icon-themes/sifr_dark/cmd/32/backcolor.png b/icon-themes/sifr_dark/cmd/32/backcolor.png new file mode 100644 index ..a470fc676cf8 Binary files /dev/null and b/icon-themes/sifr_dark/cmd/32/backcolor.png differ diff --git a/icon-themes/sifr_dark/cmd/32/bold.png b/icon-themes/sifr_dark/cmd/32/bold.png new file mode 100644 index ..20c364464ffa Binary files /dev/null and b/icon-themes/sifr_dark/cmd/32/bold.png differ diff --git a/icon-themes/sifr_dark/cmd/lc_backcolor.png b/icon-themes/sifr_dark/cmd/lc_backcolor.png index 5c7e2095afb5..a5badadc6fb1 100644 Binary files a/icon-themes/sifr_dark/cmd/lc_backcolor.png and b/icon-themes/sifr_dark/cmd/lc_backcolor.png differ diff --git a/icon-themes/sifr_dark/cmd/lc_bold.png b/icon-themes/sifr_dark/cmd/lc_bold.png index 98e43c23c147..50db6cf345d1 100644 Binary files a/icon-themes/sifr_dark/cmd/lc_bold.png and b/icon-themes/sifr_dark/cmd/lc_bold.png differ diff --git a/icon-themes/sifr_dark/cmd/sc_backcolor.png b/icon-themes/sifr_dark/cmd/sc_backcolor.png index 737e08c4de53..08ecc326c8c3 100644 Binary files a/icon-themes/sifr_dark/cmd/sc_backcolor.png and b/icon-themes/sifr_dark/cmd/sc_backcolor.png differ diff --git a/icon-themes/sifr_dark/cmd/sc_bold.png b/icon-themes/sifr_dark/cmd/sc_bold.png index 148f88b4f609..6dab8dcd6fe5 100644 Binary files a/icon-themes/sifr_dark/cmd/sc_bold.png and b/icon-themes/sifr_dark/cmd/sc_bold.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 84657] FORMATTING: Pressing Enter in sidebar (Writer) while typing the value creates new line in document (does not
https://bugs.documentfoundation.org/show_bug.cgi?id=84657 Adolfo Jaymechanged: What|Removed |Added Whiteboard|BSA |target:6.1.0 --- Comment #8 from Adolfo Jayme --- Related patch by Jim: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bcfc348663b04834fe8e6d6315f647be1595469a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98505] Pressing ENTER in SIDEBAR combobox/ spinbox cause it to press ENTER in the document
https://bugs.documentfoundation.org/show_bug.cgi?id=98505 Adolfo Jaymechanged: What|Removed |Added Whiteboard||target:6.1.0 --- Comment #9 from Adolfo Jayme --- Related patch by Jim: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bcfc348663b04834fe8e6d6315f647be1595469a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102012] FILEOPEN DOCX Frame with table inside it positioned wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=102012 --- Comment #16 from Robert Markowitz--- Problem is still very much there. Considering its age, would appreciate it if you can raise the priority. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112197] Pc don't shutdown when "quick start" is enable
https://bugs.documentfoundation.org/show_bug.cgi?id=112197 --- Comment #2 from 張修銘--- Seems that Quickstarter is not removed in LibreOffice 6.0. It can be enabled from Tools > Options > LibreOffice > General. And in https://wiki.documentfoundation.org/ReleaseNotes/6.0#Feature_removal_.2F_deprecation, the feature removal is deleted. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65323] Objects anchored as characters aren't treated as characters
https://bugs.documentfoundation.org/show_bug.cgi?id=65323 --- Comment #12 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105694] Misspelled Hebrew word causes writer to hang/crash
https://bugs.documentfoundation.org/show_bug.cgi?id=105694 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105276] New line issue in long equations (no wrap option)
https://bugs.documentfoundation.org/show_bug.cgi?id=105276 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65944] punctuation after inline formula may go to the next line
https://bugs.documentfoundation.org/show_bug.cgi?id=65944 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115480] SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=115480 --- Comment #3 from daviding--- Created attachment 139619 --> https://bugs.documentfoundation.org/attachment.cgi?id=139619=edit Sample file exported from LO Draw 5.4.2.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115480] SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=115480 --- Comment #2 from daviding--- Created attachment 139618 --> https://bugs.documentfoundation.org/attachment.cgi?id=139618=edit Sample file exported from LO Draw 5.3.1.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115480] SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=115480 --- Comment #1 from daviding--- Created attachment 139617 --> https://bugs.documentfoundation.org/attachment.cgi?id=139617=edit Sample Draw file for export to SVG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/orcusinterface.hxx |6 ++- sc/source/filter/orcus/interface.cxx| 58 2 files changed, 42 insertions(+), 22 deletions(-) New commits: commit 8a0b61172a14b8b766a2e85f27762db3558d3af7 Author: Kohei YoshidaDate: Mon Feb 5 20:59:34 2018 -0500 Import distributed text alignment settings correctly from orcus. Change-Id: Id04e2bd19475d6d7b98560835bc5aaad4bb8addf Reviewed-on: https://gerrit.libreoffice.org/49265 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/sc/source/filter/inc/orcusinterface.hxx b/sc/source/filter/inc/orcusinterface.hxx index 5d6cc1f55135..d1b4cfb5e6b1 100644 --- a/sc/source/filter/inc/orcusinterface.hxx +++ b/sc/source/filter/inc/orcusinterface.hxx @@ -387,8 +387,10 @@ private: size_t mnStyleXf; bool mbAlignment; -SvxCellHorJustify meHor_alignment; -SvxCellVerJustify meVer_alignment; +SvxCellHorJustify meHorAlignment; +SvxCellVerJustify meVerAlignment; +SvxCellJustifyMethod meHorAlignMethod; +SvxCellJustifyMethod meVerAlignMethod; xf(); }; diff --git a/sc/source/filter/orcus/interface.cxx b/sc/source/filter/orcus/interface.cxx index 40140ae93b5e..b7bc5970f58c 100644 --- a/sc/source/filter/orcus/interface.cxx +++ b/sc/source/filter/orcus/interface.cxx @@ -1263,8 +1263,10 @@ ScOrcusStyles::xf::xf(): mnNumberFormatId(0), mnStyleXf(0), mbAlignment(false), -meHor_alignment(SvxCellHorJustify::Right), -meVer_alignment(SvxCellVerJustify::Bottom) +meHorAlignment(SvxCellHorJustify::Standard), +meVerAlignment(SvxCellVerJustify::Standard), +meHorAlignMethod(SvxCellJustifyMethod::Auto), +meVerAlignMethod(SvxCellJustifyMethod::Auto) { } @@ -1330,8 +1332,10 @@ void ScOrcusStyles::applyXfToItemSet(SfxItemSet& rSet, const xf& rXf) if(rXf.mbAlignment) { -rSet.Put(SvxHorJustifyItem(rXf.meHor_alignment, ATTR_HOR_JUSTIFY)); -rSet.Put(SvxVerJustifyItem(rXf.meVer_alignment, ATTR_VER_JUSTIFY)); +rSet.Put(SvxHorJustifyItem(rXf.meHorAlignment, ATTR_HOR_JUSTIFY)); +rSet.Put(SvxVerJustifyItem(rXf.meVerAlignment, ATTR_VER_JUSTIFY)); +rSet.Put(SvxJustifyMethodItem(rXf.meHorAlignMethod, ATTR_HOR_JUSTIFY_METHOD)); +rSet.Put(SvxJustifyMethodItem(rXf.meVerAlignMethod, ATTR_VER_JUSTIFY_METHOD)); } } @@ -1813,17 +1817,24 @@ void ScOrcusStyles::set_xf_horizontal_alignment(orcus::spreadsheet::hor_alignmen switch (align) { case os::hor_alignment_t::left: -maCurrentXF.meHor_alignment = SvxCellHorJustify::Left; -break; +maCurrentXF.meHorAlignment = SvxCellHorJustify::Left; +break; case os::hor_alignment_t::right: -maCurrentXF.meHor_alignment = SvxCellHorJustify::Right; -break; +maCurrentXF.meHorAlignment = SvxCellHorJustify::Right; +break; case os::hor_alignment_t::center: -maCurrentXF.meHor_alignment = SvxCellHorJustify::Center; -break; +maCurrentXF.meHorAlignment = SvxCellHorJustify::Center; +break; case os::hor_alignment_t::justified: -maCurrentXF.meHor_alignment = SvxCellHorJustify::Standard; -break; +maCurrentXF.meHorAlignment = SvxCellHorJustify::Block; +break; +case os::hor_alignment_t::distributed: +maCurrentXF.meHorAlignment = SvxCellHorJustify::Block; +maCurrentXF.meHorAlignMethod = SvxCellJustifyMethod::Distribute; +break; +case os::hor_alignment_t::unknown: +maCurrentXF.meHorAlignment = SvxCellHorJustify::Standard; +break; default: ; } @@ -1835,17 +1846,24 @@ void ScOrcusStyles::set_xf_vertical_alignment(orcus::spreadsheet::ver_alignment_ switch (align) { case os::ver_alignment_t::top: -maCurrentXF.meVer_alignment = SvxCellVerJustify::Top; -break; +maCurrentXF.meVerAlignment = SvxCellVerJustify::Top; +break; case os::ver_alignment_t::bottom: -maCurrentXF.meVer_alignment = SvxCellVerJustify::Bottom; -break; +maCurrentXF.meVerAlignment = SvxCellVerJustify::Bottom; +break; case os::ver_alignment_t::middle: -maCurrentXF.meVer_alignment = SvxCellVerJustify::Center; -break; +maCurrentXF.meVerAlignment = SvxCellVerJustify::Center; +break; case os::ver_alignment_t::justified: -maCurrentXF.meVer_alignment = SvxCellVerJustify::Standard; -break; +maCurrentXF.meVerAlignment = SvxCellVerJustify::Block; +break; +case os::ver_alignment_t::distributed: +maCurrentXF.meVerAlignment = SvxCellVerJustify::Block; +
[Libreoffice-bugs] [Bug 115480] New: SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=115480 Bug ID: 115480 Summary: SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2 Product: LibreOffice Version: 5.4.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: divirt...@coevolving.com Description: I have a complicated biography done in Draw 5.3.1.2. When I export to SVG with Draw 5.3.1.2, it's great. When I export to SVG with Draw 5.4.4.2, the boxes and lines are distorted, making the output unusable. Steps to Reproduce: 1. Open file in LO Draw 5.3.1.2 (sample at http://coevolving.com/LODraw-bug/20180205a.odg ) 2. Export to SVG (sample result at http://coevolving.com/LODraw-bug/20180205a_LODraw_5.3.1.2.svg ) 3. Open file in LO Draw 5.4.2.2 (same sample at http://coevolving.com/LODraw-bug/20180205a.odg ) 4. Export to SVG (sample result at http://coevolving.com/LODraw-bug/20180205a_LODraw_5.4.2.2.svg ) 5. Show SVG files in Chrome Actual Results: SVG file exported by LO Draw 5.3.1.2 looks as in editor. (e.g. http://coevolving.com/LODraw-bug/20180205a_LODraw_5.3.1.2.svg ). SVG file exported by LO Draw 5.4.2.2 distorts rectangles and lines (e.g. http://coevolving.com/LODraw-bug/20180205a_LODraw_5.4.2.2.svg ). Expected Results: SVG export from LO Draw 5.4.2.2 should be the same as with 5.3.1.2 . Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: The version that doesn't work is: Version: 5.4.2.2 Build ID: 1:5.4.2-0ubuntu0.17.10.1 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: kde4; Locale: en-CA (en_CA.UTF-8); Calc: group glxinfo | grep OpenGL OpenGL vendor string: Intel Open Source Technology Center OpenGL renderer string: Mesa DRI Intel(R) Ivybridge Mobile OpenGL core profile version string: 4.2 (Core Profile) Mesa 17.2.4 OpenGL core profile shading language version string: 4.20 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 3.0 Mesa 17.2.4 OpenGL shading language version string: 1.30 OpenGL context flags: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.0 Mesa 17.2.4 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00 OpenGL ES profile extensions: The one that works is: Version 5.3.1.2 Build ID: 1.5.3.1-0ubuntu2 CPU Threads: 2; OS Version: linux 4.10; UI Render: default; VCL: kde4; Layout Engine: new; Locale: en-CA (en_CA.UTF-8); Calc: group OpenGL ES profile version string: OpenGL ES 2.0 Mesa 17.0.7 User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115479] New: Insert Row short cut keys do not function in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=115479 Bug ID: 115479 Summary: Insert Row short cut keys do not function in calc Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ca.rajendra.par...@gmail.com Description: In the manu - Sheet - Insert Rows - Below / Above does not function Actual Results: Sheet - Insert Rows - Rows Above / Rows Below Expected Results: Rows Above / Rows Below are disabled Reproducible: Always User Profile Reset: No Additional Info: Nothing - unable to insert rows in the calc sheet User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115451] Sidebar focus becomes hidden on deck change
https://bugs.documentfoundation.org/show_bug.cgi?id=115451 --- Comment #3 from Jim Raykowski--- (In reply to Telesto from comment #1) > Repro > Version: 6.1.0.0.alpha0+ > Build ID: ea89dabf8b6363972190a6b50c527c418d51c2c7 > CPU threads: 4; OS: Windows 6.3; UI render: default; > TinderBox: Win-x86@42, Branch:master, Time: 2018-01-27_22:55:15 > Locale: nl-NL (nl_NL); Calc: CL Thank you Telesto for confirming this :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115244] FILESAVE XLSX Cell Reference Error:507, with a reference external xlsx file cells
https://bugs.documentfoundation.org/show_bug.cgi?id=115244 Bartoszchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Bartosz --- Confirmed with Ubuntu 16.04 LibreOffice 5.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115471] PNG corrupted after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=115471 Aron Budeachanged: What|Removed |Added Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Version|6.1.0.0.alpha0+ Master |4.4.0.3 release Ever confirmed|0 |1 OS|Linux (All) |All --- Comment #3 from Aron Budea --- Confirmed with LO 6.0.0.3 & 4.4.0.3 / Windows 7. No repro with 4.3.0.4. => regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115474] Applying autoformat to a large number of cells takes too long ( with row-alternate shading)
https://bugs.documentfoundation.org/show_bug.cgi?id=115474 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest, regression | Version|6.0.0.3 release |Inherited From OOo Summary|Applying autoformat to a|Applying autoformat to a |large number of cells takes |large number of cells takes |to long |too long (with ||row-alternate shading) --- Comment #2 from Aron Budea --- Correction: it depends on if the style has row-alternate shading, eg. Box List Blue (6.0) or Currency Turqoise (< 6.0). When using the appropriate style, the bug occurs from 6.0.0.3 all the way back to 3.3.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 94309, which changed state. Bug 94309 Summary: SUMIFS function gives Err:504 for external references https://bugs.documentfoundation.org/show_bug.cgi?id=94309 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115474] Applying autoformat to a large number of cells takes to long
https://bugs.documentfoundation.org/show_bug.cgi?id=115474 Aron Budeachanged: What|Removed |Added Keywords||bibisectRequest, perf, ||regression Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Version|6.1.0.0.alpha0+ Master |6.0.0.3 release Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- Confirmed using LO 6.0.0.3 / Windows 7. Applying autoformat syles happens instantly in 5.4.0.3. => regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 94309, which changed state. Bug 94309 Summary: SUMIFS function gives Err:504 for external references https://bugs.documentfoundation.org/show_bug.cgi?id=94309 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113500] AutoFill with combined cell content incorrectly increments value when starting from the same content
https://bugs.documentfoundation.org/show_bug.cgi?id=113500 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |bibisected --- Comment #2 from Aron Budea --- Bibisected to the following range using repo bibisect-43all: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=1856186951a70a0bcac4e0c3632ca4afe68c05e3..d31997559adac6f03d932cb6c5819149c38c1398 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77517] Function of reference to external file Error 504
https://bugs.documentfoundation.org/show_bug.cgi?id=77517 Bartoszchanged: What|Removed |Added CC||gan...@poczta.onet.pl Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77517] Function of reference to external file Error 504
https://bugs.documentfoundation.org/show_bug.cgi?id=77517 Bartoszchanged: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94309] SUMIFS function gives Err:504 for external references
https://bugs.documentfoundation.org/show_bug.cgi?id=94309 Bartoszchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114820] FILEOPEN XLSX VLOOKUP/HLOOKUP gives Error:504, with a reference to an external xlsx file cells
https://bugs.documentfoundation.org/show_bug.cgi?id=114820 Bartoszchanged: What|Removed |Added Attachment #139563|0 |1 is obsolete|| --- Comment #9 from Bartosz --- Created attachment 139616 --> https://bugs.documentfoundation.org/attachment.cgi?id=139616=edit Screenshot of the LibreOFfice with the fix With big help of Eike, I managed to fix that issue. Review: https://gerrit.libreoffice.org/#/c/49263/ In attachment you could find the screenshot from LO after fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115451] Sidebar focus becomes hidden on deck change
https://bugs.documentfoundation.org/show_bug.cgi?id=115451 --- Comment #2 from Jim Raykowski--- Here is a patch that sets the keyboard focus to the deck button when clicked. I like this better than setting the focus to the deck title, which is another option, and I like it a whole lot better than leaving the focus on whatever it was on before the button was clicked. It might be something to consult with the UX team about? https://gerrit.libreoffice.org/#/c/49262/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114820] FILEOPEN XLSX VLOOKUP/HLOOKUP gives Error:504, with a reference to an external xlsx file cells
https://bugs.documentfoundation.org/show_bug.cgi?id=114820 Bartoszchanged: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108235] Pivot table update on undo lags a step behind
https://bugs.documentfoundation.org/show_bug.cgi?id=108235 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |bibisected Version|4.1 all versions|3.6.0.4 release --- Comment #4 from Aron Budea --- Bibisected using bibisect-43all, bug introduced in the following range, probably by one of Kohei's commits dealing with pivot tables: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=0a8596dd8ebbbc80e87d4bdfafe3cf53355b7d43..c0a99301f5d854cad8baeaca798549424937598d -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114820] FILEOPEN XLSX VLOOKUP/HLOOKUP gives Error:504, with a reference to an external xlsx file cells
https://bugs.documentfoundation.org/show_bug.cgi?id=114820 Bartoszchanged: What|Removed |Added Summary|FILESAVE XLSX |FILEOPEN XLSX |VLOOKUP/HLOOKUP gives |VLOOKUP/HLOOKUP gives |Error:504, with a reference |Error:504, with a reference |to an external xlsx file|to an external xlsx file |cells |cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells
https://bugs.documentfoundation.org/show_bug.cgi?id=115162 Bartoszchanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/parse.hxx|2 +- starmath/source/parse.cxx | 22 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) New commits: commit 715114595e0feec49c4d54cc5eb26f13dccb7968 Author: Takeshi AbeDate: Mon Feb 5 18:01:21 2018 +0900 starmath: Make DoAlign() return std::unique_ptr to take advantage of copy elision and simplify client code. Change-Id: I9e08bc2b9743563f483657c7348abca05dd34c85 Reviewed-on: https://gerrit.libreoffice.org/49222 Tested-by: Jenkins Reviewed-by: Takeshi Abe diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx index a2faa73a3b40..e3ec707d8bf4 100644 --- a/starmath/inc/parse.hxx +++ b/starmath/inc/parse.hxx @@ -93,7 +93,7 @@ class SmParser SmOperNode *DoOperator(); SmNode *DoOper(); SmStructureNode *DoUnOper(); -SmNode *DoAlign(bool bUseExtraSpaces = true); +std::unique_ptr DoAlign(bool bUseExtraSpaces = true); SmStructureNode *DoFontAttribut(); SmAttributNode *DoAttribut(); SmStructureNode *DoFont(); diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx index 7e026673a69a..e097e87e1b8e 100644 --- a/starmath/source/parse.cxx +++ b/starmath/source/parse.cxx @@ -969,7 +969,7 @@ std::unique_ptr SmParser::DoTable() return xSNode; } -SmNode *SmParser::DoAlign(bool bUseExtraSpaces) +std::unique_ptr SmParser::DoAlign(bool bUseExtraSpaces) // parse alignment info (if any), then go on with rest of expression { DepthProtect aDepthGuard(m_nParseDepth); @@ -986,7 +986,7 @@ SmNode *SmParser::DoAlign(bool bUseExtraSpaces) // allow for just one align statement in 5.0 if (TokenInGroup(TG::Align)) -return DoError(SmParseError::DoubleAlign); +return std::unique_ptr(DoError(SmParseError::DoubleAlign)); } auto pNode = DoExpression(bUseExtraSpaces); @@ -994,9 +994,9 @@ SmNode *SmParser::DoAlign(bool bUseExtraSpaces) if (xSNode) { xSNode->SetSubNode(0, pNode.release()); -return xSNode.release(); +return std::move(xSNode); // this explicit move can be omitted since C++14 } -return pNode.release(); +return pNode; } // Postcondition: m_aCurToken.eType == TEND || m_aCurToken.eType == TNEWLINE @@ -1012,7 +1012,7 @@ SmLineNode *SmParser::DoLine() // (and go on with expressions that must not have alignment // statements in 'while' loop below. See also 'Expression()'.) if (m_aCurToken.eType != TEND && m_aCurToken.eType != TNEWLINE) -ExpressionArray.emplace_back(std::unique_ptr(DoAlign())); +ExpressionArray.push_back(DoAlign()); while (m_aCurToken.eType != TEND && m_aCurToken.eType != TNEWLINE) ExpressionArray.push_back(DoExpression()); @@ -1336,7 +1336,7 @@ SmNode *SmParser::DoTerm(bool bGroupNumberIdent) return xSNode.release(); } -std::unique_ptr pNode(DoAlign(!bNoSpace)); +auto pNode = DoAlign(!bNoSpace); if (m_aCurToken.eType == TRGROUP) { NextToken(); return pNode.release(); @@ -2051,7 +2051,7 @@ SmBracebodyNode *SmParser::DoBracebody(bool bIsLeftRight) } else if (m_aCurToken.eType != TRIGHT) { -aNodes.emplace_back(std::unique_ptr(DoAlign())); +aNodes.push_back(DoAlign()); if (m_aCurToken.eType != TMLINE && m_aCurToken.eType != TRIGHT) aNodes.emplace_back(std::unique_ptr(DoError(SmParseError::RightExpected))); } @@ -2068,7 +2068,7 @@ SmBracebodyNode *SmParser::DoBracebody(bool bIsLeftRight) } else if (!TokenInGroup(TG::RBrace)) { -aNodes.emplace_back(std::unique_ptr(DoAlign())); +aNodes.push_back(DoAlign()); if (m_aCurToken.eType != TMLINE && !TokenInGroup(TG::RBrace)) aNodes.emplace_back(std::unique_ptr(DoError(SmParseError::RbraceExpected))); } @@ -2153,7 +2153,7 @@ SmStructureNode *SmParser::DoStack() do { NextToken(); -aExprArr.emplace_back(std::unique_ptr(DoAlign())); +aExprArr.push_back(DoAlign()); } while (m_aCurToken.eType == TPOUND); @@ -2181,7 +2181,7 @@ SmStructureNode *SmParser::DoMatrix() do { NextToken(); -aExprArr.emplace_back(std::unique_ptr(DoAlign())); +aExprArr.push_back(DoAlign()); } while (m_aCurToken.eType == TPOUND); @@ -2192,7 +2192,7 @@ SmStructureNode *SmParser::DoMatrix() NextToken(); for (size_t i = 0; i < nCol; i++) { -std::unique_ptr xNode(DoAlign()); +auto xNode = DoAlign(); if (i < (nCol - 1)) { if (m_aCurToken.eType == TPOUND) ___
[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 Bug 103238 depends on bug 112239, which changed state. Bug 112239 Summary: Icons missing for the not yet used commands in the new customize dialog https://bugs.documentfoundation.org/show_bug.cgi?id=112239 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/customize/CommandCategoryListBox.cxx | 29 cui/source/customize/SvxMenuConfigPage.cxx |4 +-- cui/source/customize/SvxToolbarConfigPage.cxx |4 +-- cui/source/inc/CommandCategoryListBox.hxx |7 +++-- 4 files changed, 28 insertions(+), 16 deletions(-) New commits: commit d6630ddc992f65975f4ad4fc4677a799e634fca1 Author: Jim RaykowskiDate: Wed Jan 24 23:05:16 2018 -0900 tdf#112239: Add icons to customize dialog function tree Change-Id: I68e908664d24c52657b3a073aae1c8cc41c3ce3e Reviewed-on: https://gerrit.libreoffice.org/48556 Tested-by: Jenkins Reviewed-by: Muhammet Kara diff --git a/cui/source/customize/CommandCategoryListBox.cxx b/cui/source/customize/CommandCategoryListBox.cxx index bc0d3d6c80b4..4d83f1147215 100644 --- a/cui/source/customize/CommandCategoryListBox.cxx +++ b/cui/source/customize/CommandCategoryListBox.cxx @@ -43,6 +43,8 @@ #include #include +#include //for SaveInData + CommandCategoryListBox::CommandCategoryListBox(vcl::Window* pParent) : ListBox( pParent, WB_BORDER | WB_DROPDOWN) , pStylesInfo( nullptr ) @@ -198,7 +200,8 @@ void CommandCategoryListBox::Init( void CommandCategoryListBox::FillFunctionsList( const css::uno::Sequence& xCommands, const VclPtr& pFunctionListBox, -const OUString& filterTerm ) +const OUString& filterTerm, +SaveInData *pCurrentSaveInData ) { // Setup search filter parameters m_searchOptions.searchString = filterTerm; @@ -217,7 +220,11 @@ void CommandCategoryListBox::FillFunctionsList( continue; } -SvTreeListEntry* pFuncEntry = pFunctionListBox->InsertEntry(sUIName ); +Image aImage; +if (pCurrentSaveInData) +aImage = pCurrentSaveInData->GetImage(rInfo.Command); + +SvTreeListEntry* pFuncEntry = pFunctionListBox->InsertEntry(sUIName, aImage, aImage ); m_aGroupInfo.push_back( o3tl::make_unique( SfxCfgKind::FUNCTION_SLOT, 0 ) ); SfxGroupInfo_Impl* pGrpInfo = m_aGroupInfo.back().get(); @@ -255,7 +262,7 @@ OUString CommandCategoryListBox::MapCommand2UIName(const OUString& sCommand) } void CommandCategoryListBox::categorySelected( const VclPtr& pFunctionListBox, -const OUString& filterTerm ) +const OUString& filterTerm , SaveInData *pCurrentSaveInData) { SfxGroupInfo_Impl *pInfo = static_cast (GetSelectedEntryData()); pFunctionListBox->SetUpdateMode(false); @@ -281,7 +288,7 @@ void CommandCategoryListBox::categorySelected( const VclPtrgetConfigurableDispatchInformation( pCurrentInfo->nUniqueID ); -FillFunctionsList( lCommands, pFunctionListBox, filterTerm ); +FillFunctionsList( lCommands, pFunctionListBox, filterTerm, pCurrentSaveInData ); } catch( css::container::NoSuchElementException& ) { @@ -298,7 +305,7 @@ void CommandCategoryListBox::categorySelected( const VclPtr lCommands = xProvider->getConfigurableDispatchInformation(nGroup); -FillFunctionsList( lCommands, pFunctionListBox, filterTerm ); +FillFunctionsList( lCommands, pFunctionListBox, filterTerm, pCurrentSaveInData ); break; } case SfxCfgKind::GROUP_SCRIPTCONTAINER: //Macros @@ -363,7 +370,7 @@ void CommandCategoryListBox::categorySelected( const VclPtrEnableChildrenOnDemand(); //Add the children and the grand children -addChildren( pMacroGroup, childGroup, pFunctionListBox, filterTerm ); +addChildren( pMacroGroup, childGroup, pFunctionListBox, filterTerm, pCurrentSaveInData ); // Remove the main group if empty if (!pMacroGroup->HasChildren()) @@ -464,7 +471,7 @@ void CommandCategoryListBox::SetStylesInfo(SfxStylesInfo_Impl* pStyles) void CommandCategoryListBox::addChildren( SvTreeListEntry* parentEntry, const css::uno::Reference< css::script::browse::XBrowseNode > , -const VclPtr& pFunctionListBox, const OUString& filterTerm ) +const VclPtr& pFunctionListBox, const OUString& filterTerm , SaveInData *pCurrentSaveInData) { // Setup search filter parameters m_searchOptions.searchString = filterTerm; @@ -486,7 +493,7 @@ void CommandCategoryListBox::addChildren( pNewEntry->SetUserData( m_aGroupInfo.back().get() ); pNewEntry->EnableChildrenOnDemand(); -addChildren(pNewEntry, child, pFunctionListBox, filterTerm); +addChildren(pNewEntry, child, pFunctionListBox, filterTerm, pCurrentSaveInData); // Remove the group if empty
[Libreoffice-bugs] [Bug 71828] Distorted eps-exports with LO Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=71828 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |notBibisectable Hardware|x86-64 (AMD64) |All Blocks||11 --- Comment #8 from Aron Budea --- Bug already there in oldest state of bibisect-43all => notbibisectable. Bug is still there in 6.0.0.3 / Ubuntu 17.10. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=11 [Bug 11] [META] EPS (Encapsulated PostScript) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113333] [META] EPS (Encapsulated PostScript) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=11 Aron Budeachanged: What|Removed |Added Depends on||71828 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71828 [Bug 71828] Distorted eps-exports with LO Draw -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97269] Linux portable edition
https://bugs.documentfoundation.org/show_bug.cgi?id=97269 --- Comment #26 from Hans Deragon--- But how does the casual, normal user, get to this page (http://www.libreoffice.org/download/appimage) from the home page (http://www.libreoffice.org)? If you did not posted this link in this bug report, I would never have found out its existence. https://www.libreoffice.org/download/download/ does not provide a link to the appimage version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111319] defining a picture as background makes extremely difficult to select a table , text or object and to change its properties
https://bugs.documentfoundation.org/show_bug.cgi?id=111319 Cristiano Duartechanged: What|Removed |Added Version|5.1.3.2 release |5.3.7.2 release --- Comment #3 from Cristiano Duarte --- I can confirm that with LO 5.3.7.2.0+ (5.3.7.2-6.fc26) we can left-click or select texts (easily), but the problem still persists, as in the sample file attached to this bug report: a) when trying to select empty paragraphs or extend the selection to empty paragraphs; b) when trying to select an image (if the watermark image is selected, then it is possible to easily select the math image) - the math image in the attached sample file; c) when right-clicking on empty paragraphs or tables, always selects the watermark image and open the watermark image popup menu; d) still not possible to make cell or table background to render -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Crash test update
Hi Caolán, On Monday, 2018-02-05 10:35:39 +, Caolán McNamara wrote: > On Thu, 2018-02-01 at 21:26 +, Crashtest VM wrote: > > New crashtest update available at http://dev-builds.libreoffice.org/c > > rashtest/4696d3728f0aba1087001bc543fc0867dd0ebdda/ > > The threaded xml import stuff is now gone, all that remains is the more > recent assert from... > > commit faa0305ba3d0dc698fce4915d4f3a1fb52422380 Shredded with commit 951dd781743c975a7d29cc30e88e1b4a56c0b176 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/documen8.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 951dd781743c975a7d29cc30e88e1b4a56c0b176 Author: Eike RathkeDate: Mon Feb 5 23:13:08 2018 +0100 Turn assert into SAL_WARN In the wild there are named expressions without expression and formula error cells without formula. Change-Id: I11546b09173de65cebe776529edee74c549d73c8 diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx index eb58eb080213..48b9c443990f 100644 --- a/sc/source/core/data/documen8.cxx +++ b/sc/source/core/data/documen8.cxx @@ -1195,7 +1195,10 @@ void ScDocument::CheckLinkFormulaNeedingCheck( const ScTokenArray& rCode ) } else { -assert(!"called with empty ScTokenArray"); +// Possible with named expression without expression like Excel +// internal print ranges, obscure user define names, ... formula error +// cells without formula ... +SAL_WARN("sc.core","ScDocument::CheckLinkFormulaNeedingCheck - called with empty ScTokenArray"); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114699] FileOpen Icons corrupted on HiDPI Display
https://bugs.documentfoundation.org/show_bug.cgi?id=114699 --- Comment #17 from dan...@favoredform.com --- Created attachment 139615 --> https://bugs.documentfoundation.org/attachment.cgi?id=139615=edit Sample of 5.4.4 windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100784] Keyboard shortcuts don't work in Mac Full Screen mode [ FORMATTING] (see comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=100784 --- Comment #17 from Telesto--- Created attachment 139614 --> https://bugs.documentfoundation.org/attachment.cgi?id=139614=edit Bibisect Bisected to: author Yousuf Philips 2015-05-31 21:19:50 +0400 committer Yousuf Philips 2015-05-31 22:20:44 + commit 6c189a1eb90012789692344aa7dc418c7ec7f032 (patch) tree9c0a5d2a7cf059fc6dd494174a1fa9a4d3e97a3e parent 778d5508f5be8d9e31e1634110137f8afdf0065e (diff) tdf#91781 Reorganize writer's menu bar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114699] FileOpen Icons corrupted on HiDPI Display
https://bugs.documentfoundation.org/show_bug.cgi?id=114699 --- Comment #16 from dan...@favoredform.com --- The command "openssl dgst -sha256 LibreOffice_5.4.4_Win_x64.msi" produces the following: SHA256(LibreOffice_5.4.4_Win_x64.msi)= 0738dd24b5ba9a9dab079df34db7543d9d8b9a7a2989c0a4934debbaea8a5c8f That is the installer that I used; yes, when I initially became active on this bug, I was using an earlier version that also had the problem, but at least now you know exactly what I have installed. LibreOffice was one of the first things I installed ( I literally reinstalled Windows once in an attempt to fix this). By the way, as long as this gets fixed in 6+, I personally could care less about 5.4. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115478] New: Some text styles run over to a 2nd page on Ver 6, not on Ver 5.4
https://bugs.documentfoundation.org/show_bug.cgi?id=115478 Bug ID: 115478 Summary: Some text styles run over to a 2nd page on Ver 6, not on Ver 5.4 Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: steveb...@yahoo.com Description: My small print Conditions of Sale in Arial 10 now runs over by 2 lines to a second page on ver 6. I have switched back to ver 5.4 for this reason. Not really a bug I guess, but needs to be said. Thanks. Actual Results: ... Expected Results: ... Reproducible: Always User Profile Reset: No Additional Info: ... User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100784] Keyboard shortcuts don't work in Mac Full Screen mode [ FORMATTING] (see comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=100784 --- Comment #16 from Telesto--- Repro. However depending on the order Version: 6.1.0.0.alpha0+ Build ID: d1bc14b318c9a412a761d243085da0895a1aed4a CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; Locale: nl-NL (nl_US.UTF-8); Calc: group threaded No issue in scenario A 1. Type TEST to a document 2. View Menu → Full Screen 3. Select text (CTRL+A) and CTRL+B However broken in: Scenario B 1. Type test to a document 2. Press CTRL CMD F 3. Select text (CTRL+A) 4. CTRL+B Scenario C 1. Type test to a document 2. Select text (CTRL+A) 3. View Menu → Full Screen 4. CTRL+B It's permanent in all cases. So it keeps working if you follow the steps of scenario A. It will break when following B or C (and LibO needs a restart to undo the effect). So, pressing a key combo before entering Full screen mode seems to break things -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/util
officecfg/util/template.gen | 51 1 file changed, 51 deletions(-) New commits: commit 578fa77e8922ee9bf97e8b17ba4fb2b9bfae6e61 Author: Stephan BergmannDate: Mon Feb 5 16:37:42 2018 +0100 Remove unused officecfg/util/template.gen ...that appears to be unused (and effectively unchanged) at least ever since ee27dd72550ce8815e06e337d3682d5b8d9d7b11 "initial import" Change-Id: Ie10fa6c28c375cc467aad104cbc224aef91b0d31 Reviewed-on: https://gerrit.libreoffice.org/49249 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/officecfg/util/template.gen b/officecfg/util/template.gen deleted file mode 100755 index a19395767118.. --- a/officecfg/util/template.gen +++ /dev/null @@ -1,51 +0,0 @@ -: # -*- perl -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the "License"); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# -eval 'exec perl -wS $0 ${1+"$@"}' - if 0; - -open(OUTFILE, ">$ARGV[1]"); - -print OUTFILE "\n"; -print OUTFILE "\n"; - - -chdir($ARGV[0]) or die "can't chdir() to $ARGV[0]"; - -opendir(DIR, "."); - -@files=readdir(DIR); - -foreach $file (@files) { - if ( $file =~ /\w*\.tpl/ ) { - open(INFILE, "<$file") or die "can't open file $file"; - while() { - if ( /xml version=/ ) { - next; - } - print OUTFILE; - } - close(INFILE); - } -} - -print OUTFILE "\n"; - -closedir(DIR); - -close(OUTFILE); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Setup.xcs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ffd8369b909c86653ef30593fddf67c9f5308583 Author: Stephan BergmannDate: Mon Feb 5 17:17:17 2018 +0100 rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props 8f44fb5ee0bd21d192820ffd359504f6d1c68a52 "Mark Base window titles for localisation" localized some uses of ooSetupFactoryUIName in officecfg/registry/data/org/openoffice/Setup.xcu, but failed to mark the prop as oor:localized="true" in officecfg/registry/schema/org/openoffice/Setup.xcs. (So some arbitrary localized version of the prop would win at runtime, potentially displaying certain window titles in wrong languages.) Other uses of ooSetupFactoryUIName in Setup.xcu (for "Calc", "Impress", "Writer", etc.) have never been localized, and are probably not meant to be localized. AFAICS, irrespective of oor:localized="true" in Setup.xcs, their values not being marked with xml:lang="en-US" in Setup.xcu will mean that they will not appear in translations/source/*/officecfg/registry/data/org/openoffice.po and will not accidentally start to be translated after this commit. (Theoretically, inconsistencies between oor:localized in xcs and uses of xml:lang in xcu could statically be caught at build time, e.g., with officecfg/util/sanity.xsl. However, those checks work on each XML file individually, so don't have the schema information available when looking at the data in the xcu file. And those checks are written in XSLT, which makes writing new checks rather, erm, unpleasant.) Change-Id: I9c61e8ebf75d3d54f7e5b6688eac47a6ed8dc5c3 Reviewed-on: https://gerrit.libreoffice.org/49252 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/officecfg/registry/schema/org/openoffice/Setup.xcs b/officecfg/registry/schema/org/openoffice/Setup.xcs index f55e3698f58f..31db1eca9af4 100644 --- a/officecfg/registry/schema/org/openoffice/Setup.xcs +++ b/officecfg/registry/schema/org/openoffice/Setup.xcs @@ -149,7 +149,7 @@ Specifies the short name of the factory. - + Specifies the UI name of the factory. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: officecfg/util
officecfg/util/resource.xsl | 70 1 file changed, 70 deletions(-) New commits: commit 8d9f4eb63816737b44e496ed7add70bc18368cb3 Author: Stephan BergmannDate: Mon Feb 5 16:38:57 2018 +0100 Remove unused officecfg/util/resource.xsl ...that was presumably used from officecfg/registry/schema/makefile.mk when it got introduced with 0fdb9a2b4abb0d05bbe89692515e5dc8f03768ad "#100282# create java property files for SOMC", but appears to be unused today (and has effectively been left unchanged since its introduction) Change-Id: I0b6ffbf1dff6950d24fa13c55f5b9cba23cd737f Reviewed-on: https://gerrit.libreoffice.org/49250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/officecfg/util/resource.xsl b/officecfg/util/resource.xsl deleted file mode 100644 index a0119b146cf7.. --- a/officecfg/util/resource.xsl +++ /dev/null @@ -1,70 +0,0 @@ - - - -http://www.w3.org/1999/XSL/Transform; -xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; -xmlns:xs="http://www.w3.org/2001/XMLSchema; -xmlns:oor="http://openoffice.org/2001/registry; -version="1.0"> - - - - - -en-US - - - - - - - - - - - - - - - - - - - -[] -[] - -. - - - - -= - - - - - - - - - - - - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: officecfg/util
officecfg/util/component-conf.gen | 79 -- officecfg/util/component-ldif.gen | 76 - officecfg/util/component-map.gen | 87 -- 3 files changed, 242 deletions(-) New commits: commit 0f7825e7f32b5e62ab70d0b4856fe0aa16594fed Author: Stephan BergmannDate: Mon Feb 5 16:29:52 2018 +0100 Remove unused officecfg/util/component-*.gen files ...that appear to never have been used for anything that would still be relevant for LO today at least, and have effectively never been modified since their introduction with 0ff65e7aa039b442e61080aae50e4ef629f8ff4c "#97750# property mapping for LDAP DS" (and seem to be about some other LDAP integration than what is provided by officecfg/registry/schema/oo-*.xcd.sample) Change-Id: I36f92dbb187ff6966e0b89152f3dd3eeb128662e Reviewed-on: https://gerrit.libreoffice.org/49248 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/officecfg/util/component-conf.gen b/officecfg/util/component-conf.gen deleted file mode 100755 index 846e765521a6.. --- a/officecfg/util/component-conf.gen +++ /dev/null @@ -1,79 +0,0 @@ -: # -*- perl -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the "License"); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -# generates of the component schema list an ldap schema in slapd format - -eval 'exec perl -wS $0 ${1+"$@"}' - if 0; - -#creating the output file -open(OUTFILE, ">$ARGV[0]") or die "can't open >$ARGV[0]"; - -#open the makefile -open(INFILE, "makefile.mk") or die "can't open makefile.mk"; - -$inxcs=0; - -#search all schemas in the makefile except userprofile and format them as e.g org.openoffice.Inet -while() { - tr/\r\n//d; - - if (/^\s*XCSFILES/) { - $inxcs++; - } - next unless $inxcs; - - if ($inxcs) { - - $inxcs=0 unless /\\$/; - - next if (/^\s*XCSFILES/); - next if (/UserProfile/); - - s/^\s+//; - s/\s*\\$//; - s/\.xcs.*$//; - s#\$/#.#g; - - push(@comp_names, $_); - } -} -close(INFILE); - -# generate the schema in slapd format - -foreach (@comp_names) { - - s#org.openoffice.#oo-#g; - s#\.#-#g; - - $myLdapName=lc $_; - - print OUTFILE "attribute $myLdapName-attr $myLdapName-attr-oid cis single\n"; - print OUTFILE "objectclass $myLdapName-class\n"; - print OUTFILE "\toid\n"; - print OUTFILE "\t\t$myLdapName-class-oid\n"; - print OUTFILE "\tsuperior top\n"; - print OUTFILE "\tallows\n"; - print OUTFILE "\t$myLdapName-attr\n"; -} - -close(OUTFILE); - -exit 0; diff --git a/officecfg/util/component-ldif.gen b/officecfg/util/component-ldif.gen deleted file mode 100755 index db26e31a35ee.. --- a/officecfg/util/component-ldif.gen +++ /dev/null @@ -1,76 +0,0 @@ -: # -*- perl -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the "License"); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -# generates of the component schema list an ldap schema in ldif format - -eval 'exec perl -wS $0 ${1+"$@"}' - if 0; - -#creating the output file -open(OUTFILE, ">$ARGV[0]") or die "can't open >$ARGV[0]"; - -#open the makefile -open(INFILE, "makefile.mk") or die "can't open makefile.mk"; - -$inxcs=0; - -#search all schemas in the makefile except userprofile and format them as e.g
[Libreoffice-bugs] [Bug 115287] Editing: after many, many, many years, Writer is still not capable of inserting an image properly
https://bugs.documentfoundation.org/show_bug.cgi?id=115287 --- Comment #15 from Telesto--- (In reply to Dirk Munk from comment #14) > I tried some other formats as well, like TIFF and PSD. The same result, the > picture is inserted with the wrong format. > > So far, PNG is the only image type that is inserted properly. > > I would call this a major problem, not being able to properly insert an > image. > > Can some one please confirm the problem, and elevate it to a major problem > since it seems to concern many image formats? Only for the record: PNG import is fine, export is broken too. See bug 109323. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b4/027b74a699d7a8070d0669e780b7fbe4d03807
b4/027b74a699d7a8070d0669e780b7fbe4d03807 |1 + 1 file changed, 1 insertion(+) New commits: commit ba529fd197fd2e99d3f549868d70c64565e447d8 Author: Caolán McNamaraDate: Mon Feb 5 21:00:39 2018 + Notes added by 'git notes add' diff --git a/b4/027b74a699d7a8070d0669e780b7fbe4d03807 b/b4/027b74a699d7a8070d0669e780b7fbe4d03807 new file mode 100644 index ..75dcc599ca90 --- /dev/null +++ b/b4/027b74a699d7a8070d0669e780b7fbe4d03807 @@ -0,0 +1 @@ +prefer: 6d3b26829b5f30ea934249ef88eb10b2507969f1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwpfribtable.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit d525fe37700afd39ab1ced7c28476229bc5751dd Author: Caolán McNamaraDate: Mon Feb 5 20:56:29 2018 + ofz#6024 Direct-leak Change-Id: I43959dea19860bc0d34c4623fc86ccb3ce069189 diff --git a/lotuswordpro/source/filter/lwpfribtable.cxx b/lotuswordpro/source/filter/lwpfribtable.cxx index 67135fff4603..f675fd77e5d1 100644 --- a/lotuswordpro/source/filter/lwpfribtable.cxx +++ b/lotuswordpro/source/filter/lwpfribtable.cxx @@ -144,9 +144,9 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) sChangeID = pChangeMgr->GetChangeID(this); if (!sChangeID.isEmpty() && pXFContentContainer) { -XFChangeStart* pChangeStart = new XFChangeStart; -pChangeStart->SetChangeID(sChangeID); -pXFContentContainer->Add(pChangeStart); +rtl::Reference xChangeStart(new XFChangeStart); +xChangeStart->SetChangeID(sChangeID); +pXFContentContainer->Add(xChangeStart.get()); } } @@ -157,19 +157,19 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) { if (!sChangeID.isEmpty() && pXFContentContainer) { -XFChangeEnd* pChangeEnd = new XFChangeEnd; -pChangeEnd->SetChangeID(sChangeID); -pXFContentContainer->Add(pChangeEnd); +rtl::Reference xChangeEnd(new XFChangeEnd); +xChangeEnd->SetChangeID(sChangeID); +pXFContentContainer->Add(xChangeEnd.get()); } } if(LwpLayoutRelativityGuts::LAY_INLINE_NEWLINE == nType && HasNextFrib()) { -XFParagraph* pXFPara = new XFParagraph(); -pXFPara->SetStyleName(m_StyleName); -m_pPara->AddXFContent(pXFPara); -m_pPara->GetFribs().SetXFPara(pXFPara); +rtl::Reference xXFPara(new XFParagraph); +xXFPara->SetStyleName(m_StyleName); +m_pPara->AddXFContent(xXFPara.get()); +m_pPara->GetFribs().SetXFPara(xXFPara.get()); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 115477] Restore edit buffer to extend the Special Character dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115477 V Stuart Footechanged: What|Removed |Added CC||akshaydeepi...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||s.mehrbr...@gmail.com, ||vstuart.fo...@utsa.edu Blocks||109232 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109232 [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109232 V Stuart Footechanged: What|Removed |Added Depends on||115477 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115477 [Bug 115477] Restore edit buffer to extend the Special Character dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115477] Restore edit buffer to extend the Special Character dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115477 V Stuart Footechanged: What|Removed |Added CC||akshaydeepi...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||s.mehrbr...@gmail.com, ||vstuart.fo...@utsa.edu Blocks||109232 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109232 [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - cui/source
cui/source/inc/backgrnd.hxx |1 + cui/source/tabpages/backgrnd.cxx | 12 ++-- 2 files changed, 7 insertions(+), 6 deletions(-) New commits: commit f9a0f6bad57949c508024a7fcbca1f783788ec03 Author: Eike RathkeDate: Tue Jun 20 23:56:44 2017 +0200 Resolves: tdf#105740 select without selecting.. tdf#101588 b0rk The initial color, if determined, must result in being selected. Differentiate between pre-selected and user-selected. Regression of commit 429be969b39867d6d9f36978c9ac15b601e78ba6 Date: Mon Dec 12 21:24:20 2016 +0100 Change-Id: I928af131d03c61a8e474e5cd356aea8b766112fa Reviewed-on: https://gerrit.libreoffice.org/49256 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/cui/source/inc/backgrnd.hxx b/cui/source/inc/backgrnd.hxx index e2b8d84e5ca1..06497440b7c7 100644 --- a/cui/source/inc/backgrnd.hxx +++ b/cui/source/inc/backgrnd.hxx @@ -108,6 +108,7 @@ private: boolbIsGraphicValid : 1; boolbLinkOnly : 1; boolbHighlighting : 1; +boolm_bColorSelected: 1; Graphic aBgdGraphic; OUStringaBgdGraphicPath; OUStringaBgdGraphicFilter; diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx index 1f34633e6fcd..59df9a96c345 100644 --- a/cui/source/tabpages/backgrnd.cxx +++ b/cui/source/tabpages/backgrnd.cxx @@ -330,6 +330,7 @@ SvxBackgroundTabPage::SvxBackgroundTabPage(vcl::Window* pParent, const SfxItemSe , bIsGraphicValid(false) , bLinkOnly(false) , bHighlighting(false) +, m_bColorSelected(false) , pPageImpl(new SvxBackgroundPage_Impl) , pImportDlg(nullptr) , pTableBck_Impl(nullptr) @@ -447,6 +448,8 @@ void SvxBackgroundTabPage::Reset( const SfxItemSet* rSet ) return; } +m_bColorSelected = false; + // condition of the preview button is persistent due to UserData OUString aUserData = GetUserData(); m_pBtnPreview->Check( !aUserData.isEmpty() && '1' == aUserData[0] ); @@ -681,7 +684,7 @@ bool SvxBackgroundTabPage::FillItemSet( SfxItemSet* rCoreSet ) { // Brush-treatment: if ( rOldItem.GetColor() != aBgdColor || - (SfxItemState::DEFAULT >= eOldItemState && !m_pBackgroundColorSet->IsNoSelection())) + (SfxItemState::DEFAULT >= eOldItemState && m_bColorSelected)) { bModified = true; rCoreSet->Put( SvxBrushItem( aBgdColor, nWhich ) ); @@ -1135,6 +1138,7 @@ IMPL_LINK_NOARG_TYPED(SvxBackgroundTabPage, BackgroundColorHdl_Impl, ValueSet*, sal_uInt16 nItemId = m_pBackgroundColorSet->GetSelectItemId(); Color aColor = nItemId ? ( m_pBackgroundColorSet->GetItemColor( nItemId ) ) : Color( COL_TRANSPARENT ); aBgdColor = aColor; +m_bColorSelected = true; m_pPreviewWin1->NotifyChange( aBgdColor ); } @@ -1421,13 +1425,9 @@ void SvxBackgroundTabPage::FillControls_Impl( const SvxBrushItem& rBgdAttr, } else { -bool bNoSelection = m_pBackgroundColorSet->IsNoSelection(); m_pBackgroundColorSet->SelectItem( nCol ); -m_pBackgroundColorSet->SaveValue(); -// The actual selection is user set, not what we preset. -if (bNoSelection) -m_pBackgroundColorSet->SetNoSelection(); } +m_pBackgroundColorSet->SaveValue(); m_pPreviewWin1->NotifyChange( aBgdColor ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115477] New: Restore edit buffer to extend the Special Character dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=115477 Bug ID: 115477 Summary: Restore edit buffer to extend the Special Character dialog Product: LibreOffice Version: 6.0.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vstuart.fo...@utsa.edu With GSOC 2017 refactoring of Special Character dialog we've removed the "Characters:" string buffer. Characters are now directly picked & placed into document one by one with support for Recently used and Favorite glyphs. Removed from the refactored GUI was its edit buffer, where in the past we could assemble picked unicode glyphs and combining diacritics into text strings to be pasted into the document. While not of immediate use to our Benjamin users, it is a basic requirement for any polyglot user, or the Eve user who occasionally has to prepare paragraph text with alternate scripts. It is very useful IME for alternate language script input without having to change paragraph languag or keyboard mappings. Providing an edit buffer field, or dialog frame, to use the CharMap selected font to assemble picked glyphs into strings, or full sentences, would be great. Additional bells and whistles might include spellcheck and application of style to the buffer string. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Minutes of the design meeting 2018-Jan-31
Hi, Le 31/01/2018 à 21:48, Heiko Tietze a écrit : [...] GSoC * Full list of ideas https://pad.documentfoundation.org/p/UX-GSoC_Ideas * Public list https://wiki.documentfoundation.org/Development/GSoC/Ideas#User_Interface Here are some suggestions based on my recent experience in teaching LibreOffice and writing a python macro : Impress : work on "papercut" bugs -- 1 - Animations sets for a text box with several paragraphs don't affect new paragraphs (not inherited) https://bugs.documentfoundation.org/show_bug.cgi?id=57581 This is the most annoying problem that new users face : - they create a slide with few lines of text, - they add an animation on the text, to make it appear line by line - they test : it works correctly - they add one line of text (inside or at the end) - they test and boom... the animation is "broken" - they make a pause, then... close impress and open powerpoint... 2 - Editing: Text spacing changes when click in textbox https://bugs.documentfoundation.org/show_bug.cgi?id=89060 It is a subtle but very annoying visual effect. Python macros I had to create a macro embedded in a file. As I had not written basic for a long time, I tried to write it in python. The fist problem is that on Ubuntu, it is necessary to install a specific package 'libreoffice-script-provider-python' The second problem is that, by default, there is no tool to integrate a python macro in a document. I found the APSO extension [1] that allows that and is very useful. I found some difficult points in writing python macro with that extension : - after modifying a python script, you have to close and re-open the odf file - some inline documentation is missing : about API, and some sample code - the context (available via XSCRIPTCONTEXT) is missing some API, compared to basic So here are my suggestions for GSoC : - allow an easy activation of python support : a simple button would download and install all necessary packages - integrate the functionality of APSO (to allow embedding/managing python script in odf file) - remove the need to re-open the odf file before using a new version of python script Other points can be done directly in the current extension : - add some inline documentation about API [2] - add inline documentation on both ways to use python script : - an external script that connects to LibreOffice - an internal script that get called by menu/button - allow to create scripts empty or with comments (that provide minimum documentation and good practice) - add a library of sample code (a list of "how-to ?"), that can be easily copied in script files Adding API to the context (available via XSCRIPTCONTEXT) can be done by working on LibreOffice code : /usr/lib/libreoffice/program/pythonscript/py Cheers, Michel [1] https://extensions.libreoffice.org/extensions/apso-alternative-script-organizer-for-python [2] based on very useful page https://wiki.openoffice.org/wiki/Python/Transfer_from_Basic_to_Python ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 115429] Error message when opening a *.odg file
https://bugs.documentfoundation.org/show_bug.cgi?id=115429 --- Comment #5 from MM--- Notice that when saving to otg, you'll get the same error as when saving to odg. And when saving to fodg, you'll get a "General Error. General input/output error.". All formats still worked when saving with v5.3.7.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115040] Conditional formatting "between" - incorrect tab order
https://bugs.documentfoundation.org/show_bug.cgi?id=115040 Regina Henschelchanged: What|Removed |Added Keywords||accessibility Severity|minor |normal --- Comment #3 from Regina Henschel --- Change Importance to "normal", because it is an accessibility problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/docufld.hxx| 33 +++ sw/source/core/fields/docufld.cxx | 168 +++--- 2 files changed, 101 insertions(+), 100 deletions(-) New commits: commit 3e6b60b27fe2eb4c8d38aa4ccafaf166ebbfd76d Author: Miklos VajnaDate: Mon Feb 5 10:09:01 2018 +0100 sw: prefix members of SwHiddenParaField, SwHiddenTextField and SwJumpEditField Change-Id: I23a5ea2d85f5f22f48a2c069d84929b4d70f62a0 Reviewed-on: https://gerrit.libreoffice.org/49225 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/inc/docufld.hxx b/sw/inc/docufld.hxx index bcd44403e1ef..3f1f6b7c494c 100644 --- a/sw/inc/docufld.hxx +++ b/sw/inc/docufld.hxx @@ -277,28 +277,28 @@ public: class SwHiddenTextFieldType : public SwFieldType { -bool bHidden; +bool m_bHidden; public: SwHiddenTextFieldType(bool bSetHidden = true); virtual SwFieldType*Copy() const override; voidSetHiddenFlag( bool bSetHidden ); -bool GetHiddenFlag() const { return bHidden; } +bool GetHiddenFlag() const { return m_bHidden; } }; class SW_DLLPUBLIC SwHiddenTextField : public SwField { -OUString aTRUEText; ///< Text if condition true. -OUString aFALSEText;///< If condition false. -OUString aContent; ///< Evaluated DB-text. +OUString m_aTRUEText; ///< Text if condition true. +OUString m_aFALSEText; ///< If condition false. +OUString m_aContent; ///< Evaluated DB-text. -OUString aCond;///< Condition. -sal_uInt16 nSubType; +OUString m_aCond; ///< Condition. +sal_uInt16 m_nSubType; -boolbCanToggle : 1; ///< Can field be toggled alone? -boolbIsHidden : 1; ///< Is it not visible? -boolbValid : 1; ///< Is DB-field evaluated? +bool m_bCanToggle : 1; ///< Can field be toggled alone? +bool m_bIsHidden : 1; ///< Is it not visible? +bool m_bValid : 1; ///< Is DB-field evaluated? virtual OUStringExpand() const override; virtual SwField*Copy() const override; @@ -321,7 +321,7 @@ public: voidEvaluate(SwDoc*); -void SetValue(bool bHidden) { bIsHidden = bHidden; } +void SetValue(bool bHidden) { m_bIsHidden = bHidden; } static OUString GetColumnName(const OUString& rName); static OUString GetDBName(const OUString& rName, SwDoc *pDoc); @@ -355,8 +355,8 @@ public: class SwHiddenParaField : public SwField { -OUString aCond; -boolbIsHidden:1; +OUString m_aCond; +bool m_bIsHidden; public: /// Direct input, delete old value. SwHiddenParaField(SwHiddenParaFieldType*, const OUString& rCond); @@ -364,8 +364,8 @@ public: virtual OUStringExpand() const override; virtual SwField*Copy() const override; -voidSetHidden(bool bHidden) { bIsHidden = bHidden; } -boolIsHidden() const{ return bIsHidden;} +voidSetHidden(bool bHidden) { m_bIsHidden = bHidden; } +boolIsHidden() const{ return m_bIsHidden;} /// Query, set condition. virtual OUStringGetPar1() const override; @@ -643,7 +643,8 @@ public: class SwJumpEditField : public SwField { -OUString sText, sHelp; +OUString m_sText; +OUString m_sHelp; public: SwJumpEditField( SwJumpEditFieldType*, sal_uInt32 nFormat, const OUString& sText, const OUString& sHelp ); diff --git a/sw/source/core/fields/docufld.cxx b/sw/source/core/fields/docufld.cxx index fa0e3edc807a..174eb02afaab 100644 --- a/sw/source/core/fields/docufld.cxx +++ b/sw/source/core/fields/docufld.cxx @@ -1252,20 +1252,20 @@ bool SwDocInfoField::PutValue( const uno::Any& rAny, sal_uInt16 nWhichId ) } SwHiddenTextFieldType::SwHiddenTextFieldType( bool bSetHidden ) -: SwFieldType( SwFieldIds::HiddenText ), bHidden( bSetHidden ) +: SwFieldType( SwFieldIds::HiddenText ), m_bHidden( bSetHidden ) { } SwFieldType* SwHiddenTextFieldType::Copy() const { -return new SwHiddenTextFieldType( bHidden ); +return new SwHiddenTextFieldType( m_bHidden ); } void SwHiddenTextFieldType::SetHiddenFlag( bool bSetHidden ) { -if( bHidden != bSetHidden ) +if( m_bHidden != bSetHidden ) { -bHidden = bSetHidden; +m_bHidden = bSetHidden; UpdateFields(); // notify all HiddenTexts } } @@ -1276,26 +1276,26 @@ SwHiddenTextField::SwHiddenTextField( SwHiddenTextFieldType* pFieldType, const OUString& rStr, boolbHidden, sal_uInt16 nSub) : -SwField( pFieldType ), aCond(rCond), nSubType(nSub), -bCanToggle(bConditional),
[Libreoffice-bugs] [Bug 115460] BurnInStyleSheetAttributes not working correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=115460 --- Comment #1 from Regina Henschel--- The insert button has the items "Draw 8" and "Drawing Format". The item "Drawing Format" does a burn in of the styles and works as expected for me, using Version: 6.1.0.0.alpha0+ (x64) Build ID: facfc2951ea9f4745edd4a6fb1cf97697f33f40a CPU threads: 8; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2018-01-14_00:42:04 Locale: de-DE (de_DE); Calc: CL The behavior of item "Draw 8" depends on module. In Writer and Calc it will insert an OLE object. This has the needed styles included and therefore the appearance of the shapes is correct. In Impress and Draw it inserts the objects themselves, having still the reference to the styles. Because the new documents do not have defined the styles, the default style is used as fall back. Workaround: Insert the slide/page, which contains the shapes, via "Insert Page from File" or "Insert Slide from File" respectively, or via copy via slide sorter or slides pane. After you have copied the styles this way, pasting via "Draw 8" will apply the styles correctly. The option to copy styles using the template manager has been removed and no ersatz exists. The "Load Style" dialog is not available in Draw/Impress. I do not know other workarounds to copy styles separately. Copying shapes together with their styles between Draw and Impress does not work. This problem has been reported earlier in bug 41436. The additional problem mentioned there, that copying slides loose the styles, is solved in the mean time. Heiko, please read that bug and decide which one to close. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91130] Smaller default font name list
https://bugs.documentfoundation.org/show_bug.cgi?id=91130 --- Comment #14 from Yousuf Philips (jay)--- (In reply to Ole Tange from comment #10) > The text field is for entering substrings, that will dynamically filter the > list. The substrings can be positive (must contain) or negative (cannot > contain). Nice concept but way to complicated for the regular LO user, so would have very limited benefit. Have to agree with Heiko that a multi-column approach isnt useful. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91130] Smaller default font name list
https://bugs.documentfoundation.org/show_bug.cgi?id=91130 --- Comment #14 from Yousuf Philips (jay)--- (In reply to Ole Tange from comment #10) > The text field is for entering substrings, that will dynamically filter the > list. The substrings can be positive (must contain) or negative (cannot > contain). Nice concept but way to complicated for the regular LO user, so would have very limited benefit. Have to agree with Heiko that a multi-column approach isnt useful. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115348] FILEOPEN: Left justified .rtf saved in LO is stuck fully justified when opened in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=115348 Jo-Jochanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Jo-Jo --- This bug is specific to .rtf files, and I have already attached an example .rtf. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115476] LibreOffice Crash after login
https://bugs.documentfoundation.org/show_bug.cgi?id=115476 Kevin W. Gagelchanged: What|Removed |Added URL|crashreport.libreoffice.org | |/stats/crash_details/2be62e | |1f-5a50-4098-93f7-8cd389961 | |802 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115476] LibreOffice Crash after login
https://bugs.documentfoundation.org/show_bug.cgi?id=115476 Kevin W. Gagelchanged: What|Removed |Added Crash report or||crashreport.libreoffice.org crash signature||/stats/crash_details/2be62e ||1f-5a50-4098-93f7-8cd389961 ||802 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115476] LibreOffice Crash after login
https://bugs.documentfoundation.org/show_bug.cgi?id=115476 Kevin W. Gagelchanged: What|Removed |Added URL||crashreport.libreoffice.org ||/stats/crash_details/2be62e ||1f-5a50-4098-93f7-8cd389961 ||802 CC||kwga...@shaw.ca -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115476] New: LibreOffice Crash after login
https://bugs.documentfoundation.org/show_bug.cgi?id=115476 Bug ID: 115476 Summary: LibreOffice Crash after login Product: LibreOffice Version: 6.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kwga...@shaw.ca Description: I turned on my computer and logged into it. Then a crash report came up. I have LibreOffice quickstarter set to startup on login. Steps to Reproduce: 1.Turn computer on 2.Login 3.Submitted crash report... Actual Results: Everything seems to be working Expected Results: Everything seems to be working. Reproducible: Didn't try User Profile Reset: No Additional Info: crashreport.libreoffice.org/stats/crash_details/2be62e1f-5a50-4098-93f7-8cd389961802. ---Paste from About--- Version: 6.0.0.3 (x64) Build ID: 64a0f66915f38c6217de274f0aa8e15618924765 CPU threads: 12; OS: Windows 10.0; UI render: GL; Locale: en-US (en_US); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100784] Keyboard shortcuts don't work in Mac Full Screen mode [ FORMATTING] (see comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=100784 Yousuf Philips (jay)changed: What|Removed |Added CC||tele...@surfxs.nl, ||t...@iki.fi, ||xiscofa...@libreoffice.org --- Comment #15 from Yousuf Philips (jay) --- Telesto, Xisco, Tor: are any of you guys able to repo this on a Mac, as Steve repos it and Alex doesnt. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/svdograf.hxx |4 svx/source/svdraw/svdograf.cxx | 181 +++-- 2 files changed, 88 insertions(+), 97 deletions(-) New commits: commit 94411b5765427344d106e5cca12c032ca5a1ea6a Author: Tomaž VajngerlDate: Mon Feb 5 10:02:03 2018 +0900 use unique_ptr to store GraphicObject for SdrGrafObj Change-Id: I578156cd96e1e1400e93e96ace8a38759e3d1b2c Reviewed-on: https://gerrit.libreoffice.org/49221 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx index b4fd3baba256..f31ed858e575 100644 --- a/include/svx/svdograf.hxx +++ b/include/svx/svdograf.hxx @@ -94,8 +94,8 @@ private: OUString aFileName; // If it's a Link, the filename can be found in here OUString aReferer; OUString aFilterName; -GraphicObject* pGraphic; // In order to speed up output of bitmaps, especially rotated ones -GraphicObject* mpReplacementGraphic; +std::unique_ptr mpGraphicObject; // In order to speed up output of bitmaps, especially rotated ones +std::unique_ptr mpReplacementGraphicObject; SdrGraphicLink* pGraphicLink; // And here a pointer for linked graphics bool bMirrored:1; // True: the graphic is horizontal, which means it's mirrored along the y-axis diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx index 7297beb2c914..29dffa90fd3b 100644 --- a/svx/source/svdraw/svdograf.cxx +++ b/svx/source/svdraw/svdograf.cxx @@ -282,10 +282,10 @@ sdr::contact::ViewContact* SdrGrafObj::CreateObjectSpecificViewContact() void SdrGrafObj::onGraphicChanged() { -if (!pGraphic || pGraphic->IsSwappedOut()) // don't force swap-in for this +if (!mpGraphicObject || mpGraphicObject->IsSwappedOut()) // don't force swap-in for this return; -const VectorGraphicDataPtr& rVectorGraphicDataPtr = pGraphic->GetGraphic().getVectorGraphicData(); +const VectorGraphicDataPtr& rVectorGraphicDataPtr = mpGraphicObject->GetGraphic().getVectorGraphicData(); if (!rVectorGraphicDataPtr.get()) return; @@ -328,15 +328,14 @@ void SdrGrafObj::onGraphicChanged() SdrGrafObj::SdrGrafObj() : SdrRectObj() -, pGraphicLink(nullptr) -, bMirrored(false) -, mbIsSignatureLine(false) -, mbIsSignatureLineShowSignDate(true) -, mbIsSignatureLineCanAddComment(false) -{ -pGraphic = new GraphicObject; -mpReplacementGraphic = nullptr; -pGraphic->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); +, mpGraphicObject(new GraphicObject) +, pGraphicLink(nullptr) +, bMirrored(false) +, mbIsSignatureLine(false) +, mbIsSignatureLineShowSignDate(true) +, mbIsSignatureLineCanAddComment(false) +{ +mpGraphicObject->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); onGraphicChanged(); // #i118485# Shear allowed and possible now @@ -353,17 +352,16 @@ SdrGrafObj::SdrGrafObj() mbSupportTextIndentingOnLineWidthChange = false; } -SdrGrafObj::SdrGrafObj(const Graphic& rGrf, const tools::Rectangle& rRect) +SdrGrafObj::SdrGrafObj(const Graphic& rGraphic, const tools::Rectangle& rRect) : SdrRectObj(rRect) +, mpGraphicObject(new GraphicObject(rGraphic)) , pGraphicLink(nullptr) , bMirrored(false) , mbIsSignatureLine(false) , mbIsSignatureLineShowSignDate(true) , mbIsSignatureLineCanAddComment(false) { -pGraphic = new GraphicObject( rGrf ); -mpReplacementGraphic = nullptr; -pGraphic->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); +mpGraphicObject->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); onGraphicChanged(); // #i118485# Shear allowed and possible now @@ -380,17 +378,16 @@ SdrGrafObj::SdrGrafObj(const Graphic& rGrf, const tools::Rectangle& rRect) mbSupportTextIndentingOnLineWidthChange = false; } -SdrGrafObj::SdrGrafObj( const Graphic& rGrf ) +SdrGrafObj::SdrGrafObj(const Graphic& rGraphic) : SdrRectObj() +, mpGraphicObject(new GraphicObject(rGraphic)) , pGraphicLink(nullptr) , bMirrored(false) , mbIsSignatureLine(false) , mbIsSignatureLineShowSignDate(true) , mbIsSignatureLineCanAddComment(false) { -pGraphic = new GraphicObject( rGrf ); -mpReplacementGraphic = nullptr; -pGraphic->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); +mpGraphicObject->SetSwapStreamHdl( LINK(this, SdrGrafObj, ImpSwapHdl) ); onGraphicChanged(); // #i118485# Shear allowed and possible now @@ -409,18 +406,15 @@ SdrGrafObj::SdrGrafObj( const Graphic& rGrf ) SdrGrafObj::~SdrGrafObj() { -delete pGraphic; -delete mpReplacementGraphic; ImpDeregisterLink(); } -void SdrGrafObj::SetGraphicObject( const GraphicObject& rGrfObj ) +void SdrGrafObj::SetGraphicObject(const GraphicObject& rGraphicObject) { -*pGraphic = rGrfObj; -delete
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - toolkit/inc toolkit/source
toolkit/inc/layout/layout.hxx|2 toolkit/source/layout/vcl/wbutton.cxx| 72 toolkit/source/layout/vcl/wcontainer.cxx |8 - toolkit/source/layout/vcl/wfield.cxx | 87 +-- toolkit/source/layout/vcl/wrapper.cxx| 136 ++- toolkit/source/layout/vcl/wrapper.hxx|6 - 6 files changed, 150 insertions(+), 161 deletions(-) New commits: commit 837bd0e46c8cb64362614bb6c548addee73f80fa Author: Don LewisDate: Mon Feb 5 18:20:47 2018 + A number of methods in main/toolkit/source/layout/vcl/* use either "!this" or "this" in a boolean context in order to detect being called with a null object and exit early. In a valid C++ program "this" will never be null, so a compiler could legally optimize out this comparision, which could potentially result in the method dereferencing a null pointer later in the code. This situation could only happen if the caller is using a null object pointer to call the method or is using a object ref to call the method that was generated by dereferencing a null pointer, neither of which is valid. Resolve this by moving the checks out of the method and into the caller. Make this easier by changing the getImpl() method to return the private *Impl pointer directly instead of deferencing the pointer and returning a ref. The latter is invalid if the pointer is null. This allows GetImpl() to be called in a boolean contect to peform the check. It also allows a number of instances of "()" calls in a boolean context to be fixed by changing them to "getImpl()". The address of a ref will never be zero in a valid C++ program, so the compiler could potentially optimize out those checks. There does not appear to be any need for Control and ComboBox to use customized versions of GetImpl() since these appear to behave identically to the versions generated by the canned macro, so switch them back to the macro version. This commit should result in no functional changes. It seems like all of these checks for a null implementation should not be necessary, but that requires further investigation. diff --git a/toolkit/inc/layout/layout.hxx b/toolkit/inc/layout/layout.hxx index 01dbd2228610..69e38af00d55 100644 --- a/toolkit/inc/layout/layout.hxx +++ b/toolkit/inc/layout/layout.hxx @@ -102,7 +102,7 @@ public: t( Window *parent, WinBits nStyle = defaultWinBit ); \ t (Window *parent, ResId const ) #define DECL_GET_IMPL(t) \ -inline t##Impl () const +inline t##Impl *getImpl() const #define DECL_GET_WINDOW( cls ) ::cls* Get##cls() const #define IMPL_GET_WINDOW( cls ) ::cls* cls::Get##cls() const { return dynamic_cast< ::cls*>( GetWindow() ); } diff --git a/toolkit/source/layout/vcl/wbutton.cxx b/toolkit/source/layout/vcl/wbutton.cxx index c769bdca736e..afdeca8a957b 100644 --- a/toolkit/source/layout/vcl/wbutton.cxx +++ b/toolkit/source/layout/vcl/wbutton.cxx @@ -140,35 +140,36 @@ String Button::GetStandardText (sal_uInt16 button_type) void Button::SetText( OUString const& rStr ) { -if ( !getImpl().mxButton.is() ) +if ( !getImpl()->mxButton.is() ) return; -getImpl().mxButton->setLabel( rStr ); +getImpl()->mxButton->setLabel( rStr ); } void Button::SetClickHdl( const Link& link ) { -if ( () && getImpl().mxButton.is ()) -getImpl().SetClickHdl( link ); +if (getImpl() && getImpl()->mxButton.is ()) +getImpl()->SetClickHdl( link ); } Link& Button::GetClickHdl () { -return getImpl().GetClickHdl (); +return getImpl()->GetClickHdl (); } bool Button::SetModeImage (Image const& image) { -return getImpl().SetModeImage (image.getImpl().mxGraphic); +return getImpl() || getImpl()->SetModeImage (image.getImpl().mxGraphic); } bool Button::SetModeImage (::Image const& image, BmpColorMode mode) { -return GetButton ()->SetModeImage (image, mode); +return !GetButton () || GetButton ()->SetModeImage (image, mode); } void Button::SetImageAlign( ImageAlign eAlign ) { -getImpl().setProperty( "ImageAlign", uno::Any( (sal_Int16) eAlign ) ); +if ( getImpl() ) +getImpl()->setProperty( "ImageAlign", uno::Any( (sal_Int16) eAlign ) ); } void Button::Click() @@ -229,14 +230,15 @@ PushButton::~PushButton () void PushButton::Check( bool bCheck ) { -getImpl().setProperty( "State", uno::Any( (sal_Int16) !!bCheck ) ); +if ( getImpl() ) +getImpl()->setProperty( "State", uno::Any( (sal_Int16) !!bCheck ) ); // XButton doesn't have explicit toggle event -getImpl().fireToggle(); +getImpl()->fireToggle(); } bool PushButton::IsChecked() const { -return !!( getImpl().getProperty( "State" ).get< sal_Int16 >() ); +return !!( getImpl() && getImpl()->getProperty( "State" ).get< sal_Int16 >() ); }
[Libreoffice-bugs] [Bug 115470] Name of the "Cycle Case" is too long
https://bugs.documentfoundation.org/show_bug.cgi?id=115470 --- Comment #3 from Yousuf Philips (jay)--- (In reply to V Stuart Foote from comment #2) > Looking at the entry for ".uno:ChangeCaseRotateCase" in GenericCommands.xcu > shouldn't the Context Label have the "(Title Case, UPPERCASE, lowercase)" > annotation, but the label omit it? This label is suitable for the tooltip, so 'Label' should likely be changed to 'TooltipLabel' and 'ContextLabel' changed to 'Label'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)
https://bugs.documentfoundation.org/show_bug.cgi?id=109323 Thomas Lendochanged: What|Removed |Added Depends on||115464 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115464 [Bug 115464] UI of export to PNG and JPG misleading for resolution -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105815] [META] Draw image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105815 Thomas Lendochanged: What|Removed |Added Depends on||115464 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115464 [Bug 115464] UI of export to PNG and JPG misleading for resolution -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115464] UI of export to PNG and JPG misleading for resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=115464 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com Blocks||105815, 109323 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105815 [Bug 105815] [META] Draw image bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=109323 [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115464] UI of export to PNG and JPG misleading for resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=115464 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com Blocks||105815, 109323 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105815 [Bug 105815] [META] Draw image bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=109323 [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 --- Comment #9 from Aron Budea--- The XLSX part could probably be worth a bug report, though. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ios/CustomTarget_iOS_setup.mk
ios/CustomTarget_iOS_setup.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 2db0c3e04348d3096dff72c568c461be3cb1a0c6 Author: jan IversenDate: Mon Feb 5 19:37:43 2018 +0100 iOS, add tango theme to avoid vcl problem. Change-Id: I73bee8ce04ec6234187224d03f0e081f09037e72 diff --git a/ios/CustomTarget_iOS_setup.mk b/ios/CustomTarget_iOS_setup.mk index 8fea759249e9..eb102f669bf3 100644 --- a/ios/CustomTarget_iOS_setup.mk +++ b/ios/CustomTarget_iOS_setup.mk @@ -66,6 +66,7 @@ $(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk \ cp $(INSTDIR)/share/filter/oox-drawingml-cs-presets $(IOSRES)/share/filter cp $(INSTDIR)/share/filter/vml-shape-types $(IOSRES)/share/filter cp -R $(INSTDIR)/share/registry $(IOSRES)/share + cp $(INSTDIR)/share/config/*zip $(IOSRES)/share/config # Set up rc (the "inifile", fundamentalrc, unorc, bootstraprc and versionrc. (echo '[Bootstrap]' \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Yousuf Philips (jay)changed: What|Removed |Added Depends on|115349 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115349 [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88174] [META] Binary XLS format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=88174 Yousuf Philips (jay)changed: What|Removed |Added Depends on||115349 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115349 [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113782] [META] XLSX (OOXML) conditional formatting bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113782 Yousuf Philips (jay)changed: What|Removed |Added Depends on|115349 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115349 [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 Yousuf Philips (jay)changed: What|Removed |Added Blocks|109072, 113782 |88174 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88174 [Bug 88174] [META] Binary XLS format limitations https://bugs.documentfoundation.org/show_bug.cgi?id=109072 [Bug 109072] [META] XLS (binary) format bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=113782 [Bug 113782] [META] XLSX (OOXML) conditional formatting bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 Leif Lodahlchanged: What|Removed |Added CC||leiflod...@gmail.com --- Comment #11 from Leif Lodahl --- Created attachment 139612 --> https://bugs.documentfoundation.org/attachment.cgi?id=139612=edit new table styles missing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115448] Missing new table formats in Writer/LO6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115448 --- Comment #10 from Leif Lodahl--- I can confirm in 6.0.0.3 Linux x86_64. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115457] Footer background image doesn't get saved or reloaded
https://bugs.documentfoundation.org/show_bug.cgi?id=115457 --- Comment #1 from Xavier Van Wijmeersch--- image is gone and a color is in place of the image confirm with Version: 6.1.0.0.alpha0+ Build ID: 949d7b670cda798c54de072ba9d8f0aabe8afd8c CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115475] New: hidden columns do not fill
https://bugs.documentfoundation.org/show_bug.cgi?id=115475 Bug ID: 115475 Summary: hidden columns do not fill Product: LibreOffice Version: 5.2.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: damontrip...@gmail.com Description: Hidden columns do not fill when using the fill selection box across hidden columns, only the visible columns are filled. Expectation: the hidden columns would also be filled Actual Results: Hidden columns do not fill when using the fill selection box across hidden columns, only the visible columns are filled. Expected Results: Expectation: the hidden columns would also be filled Reproducible: Always User Profile Reset: No Additional Info: Version: 5.2.7.2 (x64) Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Locale: en-US (en_US); Calc: group User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115445] UI: Small special characters box now hard to find
https://bugs.documentfoundation.org/show_bug.cgi?id=115445 Yousuf Philips (jay)changed: What|Removed |Added Blocks||109232 --- Comment #6 from Yousuf Philips (jay) --- Here are the 4 reasons i gave in the gerrit patch of why 1. space (it takes up 1.5 times the size of the non-group button version) 2. importance (we use group buttons in the toolbar for highly important features, which symbol isnt) 3. we dont use this group button version in other modules 4. it was placed in the toolbar for testing purposes during GSoC The new group button is available in the standard toolbar, but it is hidden by default, so it will be easy for users who want it to use it to enable it by right-clicking on the toolbar and selecting 'Customize Toolbar' from the context menu. (In reply to V Stuart Foote from comment #1) > And, likely additional work will see the two button actions merged into a > split button. Not aware of any additional work which would suggest this and doubt it would be useful in any of the toolbar layouts. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109232 [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise