[Libreoffice-bugs] [Bug 116443] New: SLIDESHOW: Fade transition flickers, then flashes the previous slide.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116443

Bug ID: 116443
   Summary: SLIDESHOW: Fade transition flickers, then flashes the
previous slide.
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hutch...@msn.com

Description:
The fade transition is erratic and renders the program unusable in a
professional situation.

Steps to Reproduce:
The file Flicker_Demo.odp demonstrates the problem with a show of 3 slides.

Actual Results:  
Each slide has a fade transition (through black, 2 sec. duration). Each slide
flickers at the start and end of each fade. Also(although difficult to see),
Slide 1 flashes for a fraction of a second while slide 2 is fading in.
Similarly, Slide 2 flashes while Slide 3 is fading in.

Expected Results:
Each slide should fade out smoothly to black and then fade in to the following
slide.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I'm running Windows 7, 64-bit OS with an Intel i3-4170 CPU @3.70 GHz and 8 GB
RAM. The graphics are run with the onboard Intel HD chipset. Under
Tools>Options>LibreOffice>View, I have tried various permutations of the
"Graphics Output" options (hardware acceleration,anti-aliasing, Open GL). There
may be subtle variations (difficult to see) but none are satisfactory. The
flash of the previous slide is very brief; it's close to the display's refresh
rate and does not always occur.

When the same file runs on an old (2009) MacBook Pro (OS X 10.11.6 with a 3.06
GHz Intel Core 2 Duo, 8 GB RAM, NVIDIA 9400M integrated graphics), the fade
transitions are flawless; with or without Open GL.  


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101
Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Dieter Praas  changed:

   What|Removed |Added

 Depends on||116436


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116436
[Bug 116436] background color of a table row disappears after saving as docx
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116436] background color of a table row disappears after saving as docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116436

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
Version|6.0.1.1 release |5.4.6.2 release
 Blocks||10
 Ever confirmed|0   |1
 OS|Mac OS X (All)  |All

--- Comment #1 from Dieter Praas  ---
I confirm it with

Version: 6.1.0.0.alpha0+ (x64)
Build ID: d64ce643275e0b2b0dea9e532fc261391dc8793c
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-01_03:24:30
Locale: de-DE (de_DE); Calc: CL

additional information:
the same problem occurs if you choose background => table
the backround persists, if you choose background => cell


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104770] Scanned PDF shows hidden text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104770

V Stuart Foote  changed:

   What|Removed |Added

 CC||caius.cha...@gmail.com

--- Comment #8 from V Stuart Foote  ---
*** Bug 116442 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116442] Imported PDF with OCR texts forcefully.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116442

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 104770 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116409] Word-Documents from Confluence not readable from Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116409

Urmas  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---
 Ever confirmed|0   |1

--- Comment #6 from Urmas  ---
If Word 2003 and higher can open it seamlessly, the LO should be able too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115845] CPU usage increases randomly while writer is minimized after it has been open for several hours

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115845

--- Comment #9 from Alexandre Bibeau  ---
Created attachment 140667
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140667=edit
verysleepy profile during high CPU usage

While soffice.bin was using about 65% of a core while minimized, here is what
verysleepy recorded.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116437] default table font differs from the default font for the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116437

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #2 from V Stuart Foote  ---
Please reset user profile and retest...

Default Style defaults use Liberation Serif 12pt font.

Text Body defaults uses Liberation Serif 12pt font.

Table Contents defaults also uses Liberation Serif 12pt font.

Put another way, if you modify the Default style for use, you will also need to
modify the Text Body and the Table Contents (and any other styles) to match. If
you want to keep those style modification for reuse--save them as a template
document and open new documents against that template.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116433] No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #5 from V Stuart Foote  ---
You'll need to add the below stanzas with a text editor to your profile
configuration--registrymodifications.xcu in the %APPDATA%\LibreOffice\4\user
folder.

They won't be there with a new default profile, because on Windows builds
OpenGL is enabled (unless it was black-listed); once the stanzas are added they
can be edited true or false as needed.

false
false

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116442] New: Imported PDF with OCR texts forcefully.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116442

Bug ID: 116442
   Summary: Imported PDF with OCR texts forcefully.
   Product: LibreOffice
   Version: 6.0.2.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: caius.cha...@gmail.com

Description of problem:
- Draw imports PDFs with OCR texts forcefully, but no function for removal at
once or export back to PDF wiwhout that.

Version-Release number of selected component (if applicable):
- 6.0.2.1 release.

How reproducible:
- Always.

Steps to Reproduce:
1. Scan a document into a PDF file with OCR included.
2. Open such PDF file.
3. Export that to PDF format.
4. Open file with PDF viewer, such as Adobe Reader.
5. Observe the results.

Actual results:
- The PDF have OCR texts overlayed above the base document.

Expected results:
- OCR texts are invisible by default on the viewer software, or there are
functions that can remove or export without that via Draw.

Additional info:
- Nil.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115573] EDITING: Table loses formatting when inserting a new row in a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115573

--- Comment #60 from Volga  ---
(In reply to Jim Raykowski from comment #57)
> Here is a link to a revert patch:
> https://gerrit.libreoffice.org/#/c/51253/
Can you back port it into 6.0 branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58132] : Button “Reset” in Option Dialogs does not Work as expected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58132

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88473] EDITING: Selection in Mode ‘Extended Selection’ Can’t be Corrected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88473

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88852] SIDEBAR: Mouse Pointer Displayed During Resizing a Sidebar Panel is at the Wrong Position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88852

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105552] Print preview empty with only background color changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105552

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88454] EDITING: Erroneous Behaviour of Selection Modes “Extended” and “Block” in Documents with tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88454

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102184] Navigator: Document doesn't move to the selected page, if cursor is in a comment

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102184

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Pranav Kant]

 sd/source/ui/func/fuinsert.cxx |   21 ++---
 sd/source/ui/inc/View.hxx  |2 +-
 sd/source/ui/inc/Window.hxx|1 +
 sd/source/ui/view/sdview2.cxx  |   13 ++---
 sd/source/ui/view/sdwindow.cxx |   20 
 5 files changed, 26 insertions(+), 31 deletions(-)

New commits:
commit 1990fc47bb561fcb9f98cbdcb7f986b93a54b876
Author: Pranav Kant 
Date:   Thu Mar 8 21:07:40 2018 +0100

sd lok: Enable mapmode in case of lok to calculate center

This reverts the solution in 9fee132c18b658c9ea9fb1114c1fefa56b57532a.

Also, calculate center using the new function for chart, image, and text
shape insertion.

Change-Id: Ie893050b7c875760db0194e7a3f0c2cd3068963b
Reviewed-on: https://gerrit.libreoffice.org/51343
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/sd/source/ui/func/fuinsert.cxx b/sd/source/ui/func/fuinsert.cxx
index 7d18f8e6ab4c..397580a029e1 100644
--- a/sd/source/ui/func/fuinsert.cxx
+++ b/sd/source/ui/func/fuinsert.cxx
@@ -69,7 +69,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -170,20 +169,7 @@ void FuInsertGraphic::DoExecute( SfxRequest& rReq )
 bSelectionReplaced = true;
 }
 
-Point aPos;
-// For LOK, set position to center of the page
-if (comphelper::LibreOfficeKit::isActive())
-aPos = ::tools::Rectangle(aPos, 
mpView->GetSdrPageView()->GetPage()->GetSize()).Center();
-else
-{
-::tools::Rectangle aRect(aPos, mpWindow->GetOutputSizePixel() 
);
-aPos = aRect.Center();
-bool bMapModeWasEnabled(mpWindow->IsMapModeEnabled());
-mpWindow->EnableMapMode(/*true*/);
-aPos = mpWindow->PixelToLogic(aPos);
-mpWindow->EnableMapMode(bMapModeWasEnabled);
-}
-
+Point aPos = mpWindow->GetVisibleCenter();
 SdrGrafObj* pGrafObj = mpView->InsertGraphic(aGraphic, nAction, 
aPos, pPickObj, nullptr);
 
 if(pGrafObj && bAsLink )
@@ -380,10 +366,7 @@ void FuInsertOLE::DoExecute( SfxRequest& rReq )
 aSize = OutputDevice::LogicToLogic(aSize, MapMode(aUnit), 
MapMode(MapUnit::Map100thMM));
 }
 
-Point aPos;
-::tools::Rectangle aWinRect(aPos, 
mpWindow->GetOutputSizePixel() );
-aPos = aWinRect.Center();
-aPos = mpWindow->PixelToLogic(aPos);
+Point aPos = mpWindow->GetVisibleCenter();
 aPos.AdjustX( -(aSize.Width() / 2) );
 aPos.AdjustY( -(aSize.Height() / 2) );
 aRect = ::tools::Rectangle(aPos, aSize);
diff --git a/sd/source/ui/inc/View.hxx b/sd/source/ui/inc/View.hxx
index 271a8850f707..962b6d43f56e 100644
--- a/sd/source/ui/inc/View.hxx
+++ b/sd/source/ui/inc/View.hxx
@@ -91,7 +91,7 @@ public:
 voidSelectAll();
 voidDoCut();
 voidDoCopy();
-voidDoPaste(vcl::Window const * pWindow=nullptr);
+voidDoPaste(::sd::Window* pWindow=nullptr);
 virtual voidDoConnect(SdrOle2Obj* pOleObj) override;
 virtual boolSetStyleSheet(SfxStyleSheet* pStyleSheet, bool 
bDontRemoveHardAttr = false);
 voidStartDrag( const Point& rStartPos, vcl::Window* 
pWindow );
diff --git a/sd/source/ui/inc/Window.hxx b/sd/source/ui/inc/Window.hxx
index d1aa74a91602..d03890f6f491 100644
--- a/sd/source/ui/inc/Window.hxx
+++ b/sd/source/ui/inc/Window.hxx
@@ -131,6 +131,7 @@ public:
 voidSetVisibleXY(double fX, double fY);
 double  GetVisibleWidth();
 double  GetVisibleHeight();
+Point   GetVisibleCenter();
 double  GetScrlLineWidth();
 double  GetScrlLineHeight();
 double  GetScrlPageWidth();
diff --git a/sd/source/ui/view/sdview2.cxx b/sd/source/ui/view/sdview2.cxx
index 81aff44869e2..57db0d9bef2d 100644
--- a/sd/source/ui/view/sdview2.cxx
+++ b/sd/source/ui/view/sdview2.cxx
@@ -264,7 +264,7 @@ void View::DoCopy()
 }
 }
 
-void View::DoPaste (vcl::Window const * pWindow)
+void View::DoPaste (::sd::Window* pWindow)
 {
 TransferableDataHelper aDataHelper( 
TransferableDataHelper::CreateFromSystemClipboard( mpViewSh->GetActiveWindow() 
) );
 if( !aDataHelper.GetTransferable().is() )
@@ -315,17 +315,8 @@ void View::DoPaste (vcl::Window const * pWindow)
 }
 else
 {
-Point   aPos;
 sal_Int8nDnDAction = DND_ACTION_COPY;
-
-if( pWindow )
-{
-if (comphelper::LibreOfficeKit::isActive())
-aPos = ::tools::Rectangle(aPos, 
GetSdrPageView()->GetPage()->GetSize()).Center();
-else
-aPos = pWindow->PixelToLogic( ::tools::Rectangle( aPos, 

[Libreoffice-commits] core.git: sd/qa sd/source

[Pranav Kant]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |   20 
 sd/source/ui/inc/ViewShell.hxx   |2 ++
 sd/source/ui/unoidl/unomodel.cxx |   14 --
 sd/source/ui/view/viewshe2.cxx   |   12 
 4 files changed, 46 insertions(+), 2 deletions(-)

New commits:
commit 21f56ccbd22ffa347edf931b7ed93c99988fbb8a
Author: Pranav Kant 
Date:   Thu Mar 15 20:09:26 2018 +0530

sd lok: Set the view size to full page size + fix unit tests

... such that during insertion of objects when sd calculates the center
of the view to place the object, it is the center of the whole slide,
not the center of the default rectangle of 800x600.

It's also important to hide rulers, scrollbars so that correct center is
calculated; we don't need them anyways in LOK.

Change-Id: I2d1577bc963d324959b272ed3174571ab197d014
Reviewed-on: https://gerrit.libreoffice.org/51416
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index b0ea2340574a..94f5e1b52e0d 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -339,6 +339,7 @@ xmlDocPtr SdTiledRenderingTest::parseXmlDump()
 
 void SdTiledRenderingTest::testRegisterCallback()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 
pViewShell->GetViewShellBase().registerLibreOfficeKitViewCallback(::callback,
 this);
@@ -354,6 +355,7 @@ void SdTiledRenderingTest::testRegisterCallback()
 CPPUNIT_ASSERT(!m_aInvalidation.IsEmpty());
 ::tools::Rectangle aTopLeft(0, 0, 256*15, 256*15); // 1 px = 15 twips, 
assuming 96 DPI.
 CPPUNIT_ASSERT(m_aInvalidation.IsOver(aTopLeft));
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testPostKeyEvent()
@@ -423,6 +425,7 @@ void SdTiledRenderingTest::testPostMouseEvent()
 
 void SdTiledRenderingTest::testSetTextSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 
xDrawPage(pXImpressDocument->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
 uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
@@ -447,10 +450,12 @@ void SdTiledRenderingTest::testSetTextSelection()
 pXImpressDocument->setTextSelection(LOK_SETTEXTSELECTION_END, aEnd.getX(), 
aEnd.getY());
 // The new selection must include the ending dot, too -- but not the first 
word.
 CPPUNIT_ASSERT_EQUAL(OUString("bbb."), rEditView.GetSelected());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testGetTextSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 
xDrawPage(pXImpressDocument->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
 uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
@@ -471,10 +476,12 @@ void SdTiledRenderingTest::testGetTextSelection()
 
 // Make sure returned RTF is not empty.
 CPPUNIT_ASSERT(!pXImpressDocument->getTextSelection("text/rtf", 
aUsedFormat).isEmpty());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testSetGraphicSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("shape.odp");
 sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 SdPage* pPage = pViewShell->GetActualPage();
@@ -504,10 +511,13 @@ void SdTiledRenderingTest::testSetGraphicSelection()
 // Check that a resize happened, but aspect ratio is not kept.
 CPPUNIT_ASSERT_EQUAL(aShapeBefore.getWidth(), aShapeAfter.getWidth());
 CPPUNIT_ASSERT(aShapeBefore.getHeight() < aShapeAfter.getHeight());
+
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testUndoShells()
 {
+comphelper::LibreOfficeKit::setActive();
 // Load a document and set the page size.
 SdXImpressDocument* pXImpressDocument = createDoc("shape.odp");
 uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence(
@@ -525,10 +535,12 @@ void SdTiledRenderingTest::testUndoShells()
 sal_Int32 nView1 = SfxLokHelper::getView();
 // This was -1, SdUndoGroup did not track what view shell created it.
 CPPUNIT_ASSERT_EQUAL(ViewShellId(nView1), 
pUndoManager->GetUndoAction()->GetViewShellId());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testResetSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 

[Libreoffice-bugs] [Bug 116440] write dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116440

--- Comment #1 from m.a.riosv  ---
*** Bug 116441 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116441] write dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116441

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #1 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 116440 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116440] New: write dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116440

Bug ID: 116440
   Summary: write dictionary
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ephoen...@gmail.com

Description:
The dictionary seems to lack a lot of words. I think that it should be updated
like the rest of the software

Actual Results:  
I correct word spelling appears to be incorrect

Expected Results:
the word isn't recognized for incorrect spelling


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116441] New: write dictionary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116441

Bug ID: 116441
   Summary: write dictionary
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ephoen...@gmail.com

Description:
The dictionary seems to lack a lot of words. I think that it should be updated
like the rest of the software

Actual Results:  
I correct word spelling appears to be incorrect

Expected Results:
the word isn't recognized for incorrect spelling


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113925] Paragraph dialog: Doubleclick on ruler should open "tabs" instead of "Indents & Spacing"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113925

Nickson Thanda  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nicksonthand...@msn.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Henry Castro]

 sc/source/ui/inc/anyrefdg.hxx  |   40 +++---
 sc/source/ui/miscdlgs/anyrefdg.cxx |  218 ++---
 2 files changed, 129 insertions(+), 129 deletions(-)

New commits:
commit ef5aea051495b314c043ce4f1ff7b0fafb9c4bb8
Author: Henry Castro 
Date:   Fri Mar 16 17:24:28 2018 -0400

sc: prefix members of ScFormulaReferenceHelper

Change-Id: I412c7336802032da93c3cc4df1d7f6d8baf36a7b
Reviewed-on: https://gerrit.libreoffice.org/51442
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sc/source/ui/inc/anyrefdg.hxx b/sc/source/ui/inc/anyrefdg.hxx
index 1abdb8b1a2e3..254c0539c9a6 100644
--- a/sc/source/ui/inc/anyrefdg.hxx
+++ b/sc/source/ui/inc/anyrefdg.hxx
@@ -44,30 +44,30 @@ class ScRangeList;
 class ScFormulaReferenceHelper
 {
 IAnyRefDialog*  m_pDlg;
-::std::unique_ptr pRefComp;
-VclPtrpRefEdit;   // active input field
-VclPtr  pRefBtn;// associated button
+::std::unique_ptr m_pRefComp;
+VclPtrm_pRefEdit;   // active input field
+VclPtr  m_pRefBtn;// associated button
 VclPtr m_pWindow;
 SfxBindings*m_pBindings;
 ::std::unique_ptr
-pAccel; // for Enter/Escape
+m_pAccel; // for Enter/Escape
 ::std::vector m_aHiddenWidgets;// vector of 
hidden Controls
 sal_Int32   m_nOldBorderWidth;  // border width for expanded 
dialog
-SCTAB   nRefTab;// used for ShowReference
-
-OUStringsOldDialogText; // Original title of the 
dialog window
-SizeaOldDialogSize; // Original size of the dialog 
window
-Point   aOldEditPos;// Original position of the 
input field
-SizeaOldEditSize;   // Original size of the input 
field
-longmnOldEditWidthReq;
-Point   aOldButtonPos;  // Original position of the 
button
-VclPtr mpOldEditParent;// Original parent of the edit 
field and the button
-boolmbOldDlgLayoutEnabled;  // Original layout state of 
parent dialog
-boolmbOldEditParentLayoutEnabled;  // Original layout 
state of edit widget parent
-
-boolbEnableColorRef;
-boolbHighlightRef;
-boolbAccInserted;
+SCTAB   m_nRefTab;// used for ShowReference
+
+OUStringm_sOldDialogText; // Original title of the 
dialog window
+Sizem_aOldDialogSize; // Original size of the 
dialog window
+Point   m_aOldEditPos;// Original position of the 
input field
+Sizem_aOldEditSize;   // Original size of the 
input field
+longm_nOldEditWidthReq;
+Point   m_aOldButtonPos;  // Original position of the 
button
+VclPtr m_pOldEditParent;// Original parent of the 
edit field and the button
+boolm_bOldDlgLayoutEnabled;  // Original layout state of 
parent dialog
+boolm_bOldEditParentLayoutEnabled;  // Original layout 
state of edit widget parent
+
+boolm_bEnableColorRef;
+boolm_bHighlightRef;
+boolm_bAccInserted;
 
 DECL_LINK( AccelSelectHdl, Accelerator&, void );
 
@@ -98,7 +98,7 @@ public:
 
 public:
 static bool CanInputStart( const formula::RefEdit *pEdit ){ return 
!!pEdit; }
-boolCanInputDone( bool bForced ){   return pRefEdit && 
(bForced || !pRefBtn);   }
+boolCanInputDone( bool bForced ){   return m_pRefEdit && 
(bForced || !m_pRefBtn);   }
 };
 
 class SC_DLLPUBLIC ScRefHandler :
diff --git a/sc/source/ui/miscdlgs/anyrefdg.cxx 
b/sc/source/ui/miscdlgs/anyrefdg.cxx
index 196d09728716..e2e2bd45e81b 100644
--- a/sc/source/ui/miscdlgs/anyrefdg.cxx
+++ b/sc/source/ui/miscdlgs/anyrefdg.cxx
@@ -46,21 +46,21 @@
 
 ScFormulaReferenceHelper::ScFormulaReferenceHelper(IAnyRefDialog* 
_pDlg,SfxBindings* _pBindings)
  : m_pDlg(_pDlg)
- , pRefEdit (nullptr)
- , pRefBtn (nullptr)
+ , m_pRefEdit (nullptr)
+ , m_pRefBtn (nullptr)
  , m_pWindow(nullptr)
  , m_pBindings(_pBindings)
  , m_nOldBorderWidth (0)
- , nRefTab(0)
- , mnOldEditWidthReq( -1 )
- , mpOldEditParent( nullptr )
- , mbOldDlgLayoutEnabled( false )
- , mbOldEditParentLayoutEnabled( false )
- , bHighlightRef( false )
- , bAccInserted( false )
+ , m_nRefTab(0)
+ , m_nOldEditWidthReq(-1)
+ , m_pOldEditParent(nullptr)
+ , m_bOldDlgLayoutEnabled(false)
+ , m_bOldEditParentLayoutEnabled(false)
+ , m_bHighlightRef(false)
+ , m_bAccInserted(false)
 {
 ScInputOptions 

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[andreas kainz]

 icon-themes/colibre/sd/res/layout_empty.png  |binary
 icon-themes/colibre/sd/res/layout_head01.png |binary
 icon-themes/colibre/sd/res/layout_head02.png |binary
 icon-themes/colibre/sd/res/layout_head02a.png|binary
 icon-themes/colibre/sd/res/layout_head02b.png|binary
 icon-themes/colibre/sd/res/layout_head03.png |binary
 icon-themes/colibre/sd/res/layout_head03a.png|binary
 icon-themes/colibre/sd/res/layout_head03b.png|binary
 icon-themes/colibre/sd/res/layout_head03c.png|binary
 icon-themes/colibre/sd/res/layout_head04.png |binary
 icon-themes/colibre/sd/res/layout_head06.png |binary
 icon-themes/colibre/sd/res/layout_textonly.png   |binary
 icon-themes/colibre/sd/res/layout_vertical01.png |binary
 icon-themes/colibre/sd/res/layout_vertical02.png |binary
 icon-themes/colibre_svg/sd/res/layout_empty.svg  |1 +
 icon-themes/colibre_svg/sd/res/layout_head01.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_head02.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_head02a.svg|1 +
 icon-themes/colibre_svg/sd/res/layout_head02b.svg|1 +
 icon-themes/colibre_svg/sd/res/layout_head03.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_head03a.svg|1 +
 icon-themes/colibre_svg/sd/res/layout_head03b.svg|1 +
 icon-themes/colibre_svg/sd/res/layout_head03c.svg|1 +
 icon-themes/colibre_svg/sd/res/layout_head04.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_head06.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_textonly.svg   |1 +
 icon-themes/colibre_svg/sd/res/layout_vertical01.svg |1 +
 icon-themes/colibre_svg/sd/res/layout_vertical02.svg |1 +
 28 files changed, 14 insertions(+)

New commits:
commit 48d9c34204fcc0862c6627a6d587c7df5e5f84b2
Author: andreas kainz 
Date:   Sat Mar 17 02:13:27 2018 +0100

Colibre icons: add layout icons for impress

Change-Id: I0b05de738cdcb77ca92e95ee93a682bc417e27f9
Reviewed-on: https://gerrit.libreoffice.org/51449
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/sd/res/layout_empty.png 
b/icon-themes/colibre/sd/res/layout_empty.png
new file mode 100644
index ..5c61e9b8315b
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_empty.png differ
diff --git a/icon-themes/colibre/sd/res/layout_head01.png 
b/icon-themes/colibre/sd/res/layout_head01.png
new file mode 100644
index ..e218da4860c6
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head01.png differ
diff --git a/icon-themes/colibre/sd/res/layout_head02.png 
b/icon-themes/colibre/sd/res/layout_head02.png
new file mode 100644
index ..b166ef0a0ea7
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head02.png differ
diff --git a/icon-themes/colibre/sd/res/layout_head02a.png 
b/icon-themes/colibre/sd/res/layout_head02a.png
new file mode 100644
index ..a5f24b1a19e8
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head02a.png 
differ
diff --git a/icon-themes/colibre/sd/res/layout_head02b.png 
b/icon-themes/colibre/sd/res/layout_head02b.png
new file mode 100644
index ..0492f185923e
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head02b.png 
differ
diff --git a/icon-themes/colibre/sd/res/layout_head03.png 
b/icon-themes/colibre/sd/res/layout_head03.png
new file mode 100644
index ..7bb6d653dfdf
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head03.png differ
diff --git a/icon-themes/colibre/sd/res/layout_head03a.png 
b/icon-themes/colibre/sd/res/layout_head03a.png
new file mode 100644
index ..e232af691219
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head03a.png 
differ
diff --git a/icon-themes/colibre/sd/res/layout_head03b.png 
b/icon-themes/colibre/sd/res/layout_head03b.png
new file mode 100644
index ..bb5171575435
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head03b.png 
differ
diff --git a/icon-themes/colibre/sd/res/layout_head03c.png 
b/icon-themes/colibre/sd/res/layout_head03c.png
new file mode 100644
index ..fe67864a34a7
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head03c.png 
differ
diff --git a/icon-themes/colibre/sd/res/layout_head04.png 
b/icon-themes/colibre/sd/res/layout_head04.png
new file mode 100644
index ..251d387c6398
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head04.png differ
diff --git a/icon-themes/colibre/sd/res/layout_head06.png 
b/icon-themes/colibre/sd/res/layout_head06.png
new file mode 100644
index ..05a3dfde4175
Binary files /dev/null and b/icon-themes/colibre/sd/res/layout_head06.png differ
diff --git a/icon-themes/colibre/sd/res/layout_textonly.png 
b/icon-themes/colibre/sd/res/layout_textonly.png
new file mode 100644

[Libreoffice-commits] core.git: officecfg/registry

[Reshma]

 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu|2 +-
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ea5f9dd6d5bc10e17a9745a0d2b8ae7a342833a8
Author: Reshma 
Date:   Fri Mar 9 21:39:50 2018 +0530

tdf#106375: change tool tip to "Align Center"

change "Center Horizontally" to "Align Center" in Formatting toolbar

Change-Id: Ib5fbe70eb2a5490f7dd234ca8e5db118e68c8a73
Reviewed-on: https://gerrit.libreoffice.org/51045
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 3d2e0783a081..2b868169fa8d 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -1763,7 +1763,7 @@
   
   
 
-  Center Horizontally
+  Align Center
 
 
   1
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 22f09405bf64..8314128cdc33 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -1730,7 +1730,7 @@
   Center
 
 
-  Center Horizontally
+  Align Center
 
 
   11
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[andreas kainz]

 icon-themes/colibre/cmd/lc_marks.png  |binary
 icon-themes/colibre/cmd/lc_mediamute.png  |binary
 icon-themes/colibre/cmd/lc_shear.png  |binary
 icon-themes/colibre/cmd/lc_toggletabbarvisibility.png |binary
 icon-themes/colibre/cmd/lc_transformdialog.png|binary
 icon-themes/colibre/cmd/lc_verticalcaption.png|binary
 icon-themes/colibre/cmd/sc_hide.png   |binary
 icon-themes/colibre/cmd/sc_insertfixedtext.png|binary
 icon-themes/colibre/cmd/sc_marks.png  |binary
 icon-themes/colibre/cmd/sc_mediamute.png  |binary
 icon-themes/colibre/cmd/sc_position.png   |binary
 icon-themes/colibre/cmd/sc_shear.png  |binary
 icon-themes/colibre/cmd/sc_size.png   |binary
 icon-themes/colibre/cmd/sc_toggletabbarvisibility.png |binary
 icon-themes/colibre/cmd/sc_transformdialog.png|binary
 icon-themes/colibre/cmd/sc_verticalcaption.png|binary
 icon-themes/colibre_svg/cmd/lc_marks.svg  |1 +
 icon-themes/colibre_svg/cmd/lc_mediamute.svg  |1 +
 icon-themes/colibre_svg/cmd/lc_shear.svg  |1 +
 icon-themes/colibre_svg/cmd/lc_toggletabbarvisibility.svg |1 +
 icon-themes/colibre_svg/cmd/lc_transformdialog.svg|1 +
 icon-themes/colibre_svg/cmd/lc_verticalcaption.svg|1 +
 icon-themes/colibre_svg/cmd/sc_hide.svg   |4 
 icon-themes/colibre_svg/cmd/sc_insertfixedtext.svg|4 
 icon-themes/colibre_svg/cmd/sc_marks.svg  |5 +
 icon-themes/colibre_svg/cmd/sc_mediamute.svg  |1 +
 icon-themes/colibre_svg/cmd/sc_position.svg   |1 +
 icon-themes/colibre_svg/cmd/sc_shear.svg  |4 
 icon-themes/colibre_svg/cmd/sc_size.svg   |1 +
 icon-themes/colibre_svg/cmd/sc_toggletabbarvisibility.svg |4 
 icon-themes/colibre_svg/cmd/sc_transformdialog.svg|4 
 icon-themes/colibre_svg/cmd/sc_verticalcaption.svg|4 
 32 files changed, 38 insertions(+)

New commits:
commit 2282ca86a56b890bf7196fc89b3ea096b5ea734b
Author: andreas kainz 
Date:   Sat Mar 17 01:41:48 2018 +0100

Colibre icons: finish cmd files

Change-Id: I7cc165fc2c0931aad519a8b2a872dda89ce153d5
Reviewed-on: https://gerrit.libreoffice.org/51448
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/lc_marks.png 
b/icon-themes/colibre/cmd/lc_marks.png
new file mode 100644
index ..cb73ddf1fa5f
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_marks.png differ
diff --git a/icon-themes/colibre/cmd/lc_mediamute.png 
b/icon-themes/colibre/cmd/lc_mediamute.png
new file mode 100644
index ..8ad7f3dcf3fa
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_mediamute.png differ
diff --git a/icon-themes/colibre/cmd/lc_shear.png 
b/icon-themes/colibre/cmd/lc_shear.png
new file mode 100644
index ..eee6fc5c4128
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_shear.png differ
diff --git a/icon-themes/colibre/cmd/lc_toggletabbarvisibility.png 
b/icon-themes/colibre/cmd/lc_toggletabbarvisibility.png
new file mode 100644
index ..71ef75df6cad
Binary files /dev/null and 
b/icon-themes/colibre/cmd/lc_toggletabbarvisibility.png differ
diff --git a/icon-themes/colibre/cmd/lc_transformdialog.png 
b/icon-themes/colibre/cmd/lc_transformdialog.png
new file mode 100644
index ..6996f17fc617
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_transformdialog.png 
differ
diff --git a/icon-themes/colibre/cmd/lc_verticalcaption.png 
b/icon-themes/colibre/cmd/lc_verticalcaption.png
new file mode 100644
index ..04460ffb6c21
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_verticalcaption.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_hide.png 
b/icon-themes/colibre/cmd/sc_hide.png
new file mode 100644
index ..f49653f8e30b
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_hide.png differ
diff --git a/icon-themes/colibre/cmd/sc_insertfixedtext.png 
b/icon-themes/colibre/cmd/sc_insertfixedtext.png
new file mode 100644
index ..f1bb1fc6d796
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_insertfixedtext.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_marks.png 
b/icon-themes/colibre/cmd/sc_marks.png
new file mode 100644
index ..ec4cca1d6904
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_marks.png differ
diff --git a/icon-themes/colibre/cmd/sc_mediamute.png 
b/icon-themes/colibre/cmd/sc_mediamute.png
new file mode 100644
index ..213fdba32b01
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_mediamute.png differ
diff --git 

[Libreoffice-bugs] [Bug 106323] Tab layout in dialogs is too cramped

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106323

--- Comment #17 from andreas_k  ---
Created attachment 140666
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140666=edit
tabl style on windows 10

as you can see the style for tabs is nearly the same the only difference is
that MS Office add space left and right to the tab label which improve not only
the style it helps also usability cause small tabs like Page, Area, ... can
grab easier by mouse when the tab is a bit more wide

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/LibreOfficeKit sfx2/source

[Ashod Nakashian]

 include/LibreOfficeKit/LibreOfficeKitEnums.h |   11 +++
 sfx2/source/view/viewsh.cxx  |   16 +++-
 2 files changed, 22 insertions(+), 5 deletions(-)

New commits:
commit de774e261a59625336fe4d744d8c8e2966b570d2
Author: Ashod Nakashian 
Date:   Sun Feb 25 14:14:40 2018 -0500

lok: notify clients of clipboard changes

Change-Id: I93d8eacc0defb1176ec5d767f49356812cf90ff6
Reviewed-on: https://gerrit.libreoffice.org/50327
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index b90aa6279c41..020bbff90f20 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -568,6 +568,17 @@ typedef enum
  * - "close" - window is closed
  */
 LOK_CALLBACK_WINDOW = 36,
+
+/**
+ * Notification that the clipboard contents have changed.
+ * Typically fired in response to copying to clipboard.
+ *
+ * The payload currently is empty and it's up to the
+ * client to get the contents, if necessary. However,
+ * in the future the contents might be included for
+ * convenience.
+ */
+LOK_CALLBACK_CLIPBOARD_CHANGED = 37,
 }
 LibreOfficeKitCallbackType;
 
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 41ac335237ad..3b742b0a56d6 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -156,12 +156,18 @@ SfxClipboardChangeListener::SfxClipboardChangeListener( 
SfxViewShell* pView, con
 void SfxClipboardChangeListener::ChangedContents()
 {
 const SolarMutexGuard aGuard;
-if( m_pViewShell )
+if (m_pViewShell)
 {
 SfxBindings& rBind = m_pViewShell->GetViewFrame()->GetBindings();
-rBind.Invalidate( SID_PASTE );
-rBind.Invalidate( SID_PASTE_SPECIAL );
-rBind.Invalidate( SID_CLIPBOARD_FORMAT_ITEMS );
+rBind.Invalidate(SID_PASTE);
+rBind.Invalidate(SID_PASTE_SPECIAL);
+rBind.Invalidate(SID_CLIPBOARD_FORMAT_ITEMS);
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+// In the future we might send the payload as well.
+SfxLokHelper::notifyAllViews(LOK_CALLBACK_CLIPBOARD_CHANGED, "");
+}
 }
 }
 
@@ -823,7 +829,7 @@ SfxInPlaceClient* SfxViewShell::GetUIActiveClient() const
 if ( !pClients )
 return nullptr;
 
-bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive();
+const bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive();
 
 for (SfxInPlaceClient* pIPClient : *pClients)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116431] Make the string "LibreOffice (Safe Mode)" translatable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116431

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|6.0.1.1 release |5.3 all versions
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
Thanks for your bug report. → NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116425] FILEOPEN XLSX Excel spreadsheet takes forever and a lot of CPU time to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116425

--- Comment #4 from m.a.riosv  ---
To clear a direct format use Ctrl+M on the selected cells.

As I comment the file is protectod so it's no possible e.g. to see if there are
conditional formats slowing the file.

LibreOffice is more oriented to the use of the styles, with all those cells
having  defined styles is quicker.

Reopen the bug, it's your choice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116438] Calc, Draw, Impress should also ask whether to apply orientation when an image is inserted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116438

--- Comment #2 from himajin100...@gmail.com ---
self-solved logerrit issue.

submission done.
https://gerrit.libreoffice.org/#/c/51447/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[andreas kainz]

 icon-themes/colibre/sc/res/sidebar/CellBorder.png |binary
 icon-themes/colibre_svg/sc/res/sidebar/CellBorder.svg |   84 ++
 2 files changed, 84 insertions(+)

New commits:
commit df4253787e9f6ba4951ee2f416ec65937b2c8ddf
Author: andreas kainz 
Date:   Fri Mar 16 23:38:07 2018 +0100

Colibre icons: add cellborder icon

Change-Id: Ifd74d3cfbc6b4b1c2c4a7a1b5529e137a7b041eb
Reviewed-on: https://gerrit.libreoffice.org/51446
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/sc/res/sidebar/CellBorder.png 
b/icon-themes/colibre/sc/res/sidebar/CellBorder.png
new file mode 100644
index ..bf3ca5b1ffeb
Binary files /dev/null and b/icon-themes/colibre/sc/res/sidebar/CellBorder.png 
differ
diff --git a/icon-themes/colibre_svg/sc/res/sidebar/CellBorder.svg 
b/icon-themes/colibre_svg/sc/res/sidebar/CellBorder.svg
new file mode 100644
index ..6fd1c4f67891
--- /dev/null
+++ b/icon-themes/colibre_svg/sc/res/sidebar/CellBorder.svg
@@ -0,0 +1,84 @@
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   viewBox="0 0 43 43"
+   id="svg2"
+   version="1.1"
+   inkscape:version="0.91 r13725"
+   sodipodi:docname="CellBorder.svg">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+  
+
+  
+  
+  
+
+  
+  
+  
+  
+  
+  
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/tango icon-themes/tango_svg

[andreas kainz]

 icon-themes/tango_svg/CREDITS |8 
 1 file changed, 8 insertions(+)

New commits:
commit 5e6f2ca6f86f810a41c9948c6552526424661a65
Author: andreas kainz 
Date:   Thu Mar 15 22:38:45 2018 +0100

Tango icons: move svg and xcf source files to tango_svg

Change-Id: I94a2c7a1048a3e29776a0b5b6f78a7d043b751ca
Reviewed-on: https://gerrit.libreoffice.org/51376
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/tango_svg/CREDITS b/icon-themes/tango_svg/CREDITS
new file mode 100644
index ..1717d840c12f
--- /dev/null
+++ b/icon-themes/tango_svg/CREDITS
@@ -0,0 +1,8 @@
+All artwork is licensed under under the Creative Commons Attribution-Share 
Alike 3.0
+United States License. To view a copy of this licence, visit
+http://creativecommons.org/licenses/by-sa/3.0/ or send a letter to Creative
+Commons, 171 Second Street, Suite 300, San Francisco, California 94105, USA.
+
+Credit for icons imported from git://git.gnome.org/gnome-icon-theme or 
derivatives of these goes to the GNOME project (http://www.gnome.org)
+Derivatives and new icons were created by Alexander Wilms 
 and Miroslav Mazel 
+/cmd/lc_crop.png is derived from image_crop.svg. Copyright 2014 by Daniel Foré 
. Available under the terms of the GPL (Source: 
elementaryicons).
diff --git a/icon-themes/tango/cmd/32/insertgraphic.xcf.bz2 
b/icon-themes/tango_svg/cmd/32/insertgraphic.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/32/insertgraphic.xcf.bz2
rename to icon-themes/tango_svg/cmd/32/insertgraphic.xcf.bz2
diff --git a/icon-themes/tango/cmd/32/saveas.xcf.bz2 
b/icon-themes/tango_svg/cmd/32/saveas.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/32/saveas.xcf.bz2
rename to icon-themes/tango_svg/cmd/32/saveas.xcf.bz2
diff --git a/icon-themes/tango/cmd/32/spelldialog.xcf.bz2 
b/icon-themes/tango_svg/cmd/32/spelldialog.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/32/spelldialog.xcf.bz2
rename to icon-themes/tango_svg/cmd/32/spelldialog.xcf.bz2
diff --git a/icon-themes/tango/cmd/lc_absoluterecord.xcf.bz2 
b/icon-themes/tango_svg/cmd/lc_absoluterecord.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/lc_absoluterecord.xcf.bz2
rename to icon-themes/tango_svg/cmd/lc_absoluterecord.xcf.bz2
diff --git a/icon-themes/tango/cmd/lc_adddatefield.xcf.bz2 
b/icon-themes/tango_svg/cmd/lc_adddatefield.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/lc_adddatefield.xcf.bz2
rename to icon-themes/tango_svg/cmd/lc_adddatefield.xcf.bz2
diff --git a/icon-themes/tango/cmd/lc_addfield.xcf.bz2 
b/icon-themes/tango_svg/cmd/lc_addfield.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/lc_addfield.xcf.bz2
rename to icon-themes/tango_svg/cmd/lc_addfield.xcf.bz2
diff --git a/icon-themes/tango/cmd/lc_addtable.xcf.bz2 
b/icon-themes/tango_svg/cmd/lc_addtable.xcf.bz2
similarity index 100%
rename from icon-themes/tango/cmd/lc_addtable.xcf.bz2
rename to icon-themes/tango_svg/cmd/lc_addtable.xcf.bz2
diff --git a/icon-themes/tango/cmd/lc_autosum.svg 
b/icon-themes/tango_svg/cmd/lc_autosum.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_autosum.svg
rename to icon-themes/tango_svg/cmd/lc_autosum.svg
diff --git a/icon-themes/tango/cmd/lc_backcolor.svg 
b/icon-themes/tango_svg/cmd/lc_backcolor.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_backcolor.svg
rename to icon-themes/tango_svg/cmd/lc_backcolor.svg
diff --git a/icon-themes/tango/cmd/lc_backgroundcolor.svg 
b/icon-themes/tango_svg/cmd/lc_backgroundcolor.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_backgroundcolor.svg
rename to icon-themes/tango_svg/cmd/lc_backgroundcolor.svg
diff --git a/icon-themes/tango/cmd/lc_bezierappend.svg 
b/icon-themes/tango_svg/cmd/lc_bezierappend.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_bezierappend.svg
rename to icon-themes/tango_svg/cmd/lc_bezierappend.svg
diff --git a/icon-themes/tango/cmd/lc_bezierdelete.svg 
b/icon-themes/tango_svg/cmd/lc_bezierdelete.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_bezierdelete.svg
rename to icon-themes/tango_svg/cmd/lc_bezierdelete.svg
diff --git a/icon-themes/tango/cmd/lc_bezieredge.svg 
b/icon-themes/tango_svg/cmd/lc_bezieredge.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_bezieredge.svg
rename to icon-themes/tango_svg/cmd/lc_bezieredge.svg
diff --git a/icon-themes/tango/cmd/lc_beziersmooth.svg 
b/icon-themes/tango_svg/cmd/lc_beziersmooth.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_beziersmooth.svg
rename to icon-themes/tango_svg/cmd/lc_beziersmooth.svg
diff --git a/icon-themes/tango/cmd/lc_beziersymmetric.svg 
b/icon-themes/tango_svg/cmd/lc_beziersymmetric.svg
similarity index 100%
rename from icon-themes/tango/cmd/lc_beziersymmetric.svg
rename to 

[Libreoffice-ux-advise] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #2 from Thomas Lendo  ---
For me, the whole section "New Table Defaults" is obsolete since we've table
styles in Writer.

Before we invest time to repair it (how should it interfere with styles?) we
should drop it completely. Users should change the default table style if they
want no borders, etc.

But this also means that the bugs in the current table style implementation
should be fixed so that users can modify them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #2 from Thomas Lendo  ---
For me, the whole section "New Table Defaults" is obsolete since we've table
styles in Writer.

Before we invest time to repair it (how should it interfere with styles?) we
should drop it completely. Users should change the default table style if they
want no borders, etc.

But this also means that the bugs in the current table style implementation
should be fixed so that users can modify them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45671] Turn color etc. toolbar buttons into split buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45671

Thomas Lendo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Thomas Lendo  ---
I set this bug to RESOLVED FIXED because
a) the bugs on which it depends are all fixed,
b) there's meta bug 103429 for all kind of Split-Group-Buttons,
c) several commits from 2012 are referenced in comments,
d) there's no activity for a long time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/source

[Caolán McNamara]

 sw/source/uibase/shells/textsh1.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit acccdba69bd47c4a85830a149fe57d28b0b1b8ea
Author: Caolán McNamara 
Date:   Thu Jan 18 15:50:23 2018 +

coverity#1427648 Dereference after null check

Change-Id: Ib4be7b819a5ba68d78d98d8ae05d755898f3cad1
Reviewed-on: https://gerrit.libreoffice.org/48136
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 432f4369cdb62fd05abbde50804ff4e1d5011f39)
Reviewed-on: https://gerrit.libreoffice.org/51444
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/sw/source/uibase/shells/textsh1.cxx 
b/sw/source/uibase/shells/textsh1.cxx
index 0edd376acddb..63a5cb5dbd54 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -204,9 +204,12 @@ void sw_CharDialog(SwWrtShell , bool bUseDialog, 
sal_uInt16 nSlot, const
 
 if (bUseDialog)
 {
-std::shared_ptr pRequest(new SfxRequest(*pReq));
-pReq->Ignore(); // the 'old' request is not relevant any more
-
+std::shared_ptr pRequest;
+if (pReq)
+{
+pRequest.reset(new SfxRequest(*pReq));
+pReq->Ignore(); // the 'old' request is not relevant any more
+}
 pDlg->StartExecuteAsync([pDlg, , pCoreSet, bSel, bSelectionPut, 
pRequest](sal_Int32 nResult){
 if (nResult == RET_OK)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
Bug 103429 depends on bug 45671, which changed state.

Bug 45671 Summary: Turn color etc. toolbar buttons into split buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=45671

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77866] Filesave: Unused bitmap fill image files are kept in the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77866

--- Comment #6 from Patrick Jacquot  ---
It happened to me, that after deleting a background image and inserting a new
one, the old one was kept in the saved file and appeared when reloading the
saved file instead of the new one.
Version: 5.4.5.1
Build ID: 1:5.4.5-0ubuntu0.17.10.5
CPU threads: 2; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115632] LibreCalc crashes when selecting New> Labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115632

Claude Chmielewski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #17 from Claude Chmielewski  ---
I'm about to dynamite the box. I need Libreoffice fully functional and it is
not. Writer no longer works. This version is 6.0.1.2 and it says 3rd party. I
had to perform miracles to remove it. I cannot install Apache Openoffice or
LibreOpenOffice. I have to copy all my work to a Windows computer that I hardly
use which is running Apache Openoffice. Incidentally Scribus doesn't work right
on Ubuntu 16.04 LTS. I have Scribus installed on the Windows computer also. I
wish some one had an answer to this nightmare.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116439] OS/2 multi-image bitmap does not display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116439

--- Comment #2 from Chris Sherlock  ---
(FWIW, I don't think most other programs handle BA records properly either...
as an example, I'm fairly certain that Chrome isn't opening it correctly... but
I could be wrong. It does a better job than what we are doing though!)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116438] Calc, Draw, Impress should also ask whether to apply orientation when an image is inserted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116438

--- Comment #1 from himajin100...@gmail.com ---
Wait for a while. logerrit is complaining.

! [remote rejected]   HEAD -> refs/drafts/master (you are not allowed
to upload merges)
error: failed to push some refs to 'ssh://logerrit/core'

I have been doing some cleanups of my cygwin environment, like the ones I
carelessly configure-d on home directory rather than build directory, and that
might be one of the cause.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116439] OS/2 multi-image bitmap does not display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116439

--- Comment #1 from Chris Sherlock  ---
Created attachment 140665
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140665=edit
OS/2 BitmapArray based bitmap

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116439] OS/2 multi-image bitmap does not display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116439

Chris Sherlock  changed:

   What|Removed |Added

Version|3.3.0 release   |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115964] Document password prompt not centered to window with GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115964

--- Comment #10 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2f95590f478a68a4de6ef05018785523e46506b

Related: tdf#115964 convert the problematic dialog to a native gtk3 one

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115964] Document password prompt not centered to window with GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115964

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116439] New: OS/2 multi-image bitmap does not display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116439

Bug ID: 116439
   Summary: OS/2 multi-image bitmap does not display correctly
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chris.sherloc...@gmail.com

Description:
An OS/2 bitmap that uses a BitmapArray (multiple bitmaps) does not display
correctly.

Steps to Reproduce:
1. Open Draw
2. Click on Insert -> Image
3. Choose "marbles.bmp"

Actual Results:  
marbles.bmp does not display correctly. 

Expected Results:
marbles.bmp should show the best image, but instead it looks like a "cropped
image", I suspect because it has picked the wrong image. 


Reproducible: Always


User Profile Reset: No



Additional Info:
marbles.bmp is the standard test image used for BA type OS/2 bitmaps. Currently
we detect that the magic number of the bitmap is "BA" (0x4142), but then we
don't seem to actually go through each bitmap image to find the correct one.

Further info on OS/2 bitmap formats can be found here:

http://www.fileformat.info/format/os2bmp/egff.htm

The spot where we read in and handle the BA magic number is here:

https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/dibtools.cxx#1061


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx

[Caolán McNamara]

 vcl/inc/unx/gtk/gtkframe.hxx  |1 +
 vcl/source/app/svmain.cxx |3 ++-
 vcl/unx/gtk3/gtk3gtkframe.cxx |   32 +++-
 3 files changed, 34 insertions(+), 2 deletions(-)

New commits:
commit 2937661f0e9381f84067a025f76e5554b8a1a457
Author: Caolán McNamara 
Date:   Fri Mar 16 16:50:42 2018 +

rhbz#1392145 ensure titlebar close button matches 'outside' direction

Change-Id: I20e925c58adb56acd4d1a63720d330c8b6613441
Reviewed-on: https://gerrit.libreoffice.org/51433
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 6f4e0db8dc7f..160a4408d44f 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -173,6 +173,7 @@ class GtkSalFrame : public SalFrame
 SalX11Screenm_nXScreen;
 GtkWidget*  m_pWindow;
 #if GTK_CHECK_VERSION(3,0,0)
+GtkHeaderBar*   m_pHeaderBar;
 GtkGrid*m_pTopLevelGrid;
 #endif
 GtkEventBox*m_pEventBox;
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 1e84db1dd9cf..f337bc9657ce 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -31,7 +31,7 @@
 
 #include 
 #include 
-
+#include 
 #include 
 #include 
 #include 
@@ -335,6 +335,7 @@ bool InitVCL()
 OUString 
aLocaleString(SvtSysLocaleOptions().GetRealUILanguageTag().getGlibcLocaleString(".UTF-8"));
 if (!aLocaleString.isEmpty())
 {
+MsLangId::getSystemUILanguage(); //call this now to pin what the 
system UI really was
 OUString envVar("LANGUAGE");
 osl_setEnvironment(envVar.pData, aLocaleString.pData);
 }
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 0171bdfcf696..f9208e0a895b 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -75,6 +75,8 @@
 #  include 
 #endif
 
+#include 
+
 #include 
 #include 
 
@@ -488,6 +490,7 @@ bool GtkSalFrame::doKeyCallback( guint state,
 
 GtkSalFrame::GtkSalFrame( SalFrame* pParent, SalFrameStyleFlags nStyle )
 : m_nXScreen( getDisplay()->GetDefaultXScreen() )
+, m_pHeaderBar(nullptr)
 , m_pGraphics(nullptr)
 , m_bGraphics(false)
 {
@@ -500,6 +503,7 @@ GtkSalFrame::GtkSalFrame( SalFrame* pParent, 
SalFrameStyleFlags nStyle )
 
 GtkSalFrame::GtkSalFrame( SystemParentData* pSysData )
 : m_nXScreen( getDisplay()->GetDefaultXScreen() )
+, m_pHeaderBar(nullptr)
 , m_pGraphics(nullptr)
 , m_bGraphics(false)
 {
@@ -1249,6 +1253,27 @@ void GtkSalFrame::Init( SalFrame* pParent, 
SalFrameStyleFlags nStyle )
 gtk_window_set_type_hint( GTK_WINDOW(m_pWindow), eType );
 gtk_window_set_gravity( GTK_WINDOW(m_pWindow), GDK_GRAVITY_STATIC );
 gtk_window_set_resizable( GTK_WINDOW(m_pWindow), bool(nStyle & 
SalFrameStyleFlags::SIZEABLE) );
+
+#if defined(GDK_WINDOWING_WAYLAND)
+//rhbz#1392145 under wayland/csd if we've overridden the default 
widget direction in order to set LibreOffice's
+//UI to the configured ui language but the system ui locale is a 
different text direction, then the toplevel
+//built-in close button of the titlebar follows the overridden 
direction rather than continue in the same
+//direction as every other titlebar on the user's desktop. So if they 
don't match set an explicit
+//header bar with the desired 'outside' direction
+if ((eType == GDK_WINDOW_TYPE_HINT_NORMAL || eType == 
GDK_WINDOW_TYPE_HINT_DIALOG) && 
GDK_IS_WAYLAND_DISPLAY(GtkSalFrame::getGdkDisplay()))
+{
+const bool bDesktopIsRTL = 
MsLangId::isRightToLeft(MsLangId::getSystemUILanguage());
+const bool bAppIsRTL = gtk_widget_get_default_direction() == 
GTK_TEXT_DIR_RTL;
+if (bDesktopIsRTL != bAppIsRTL)
+{
+m_pHeaderBar = GTK_HEADER_BAR(gtk_header_bar_new());
+gtk_widget_set_direction(GTK_WIDGET(m_pHeaderBar), 
bDesktopIsRTL ? GTK_TEXT_DIR_RTL : GTK_TEXT_DIR_LTR);
+gtk_header_bar_set_show_close_button(m_pHeaderBar, true);
+gtk_window_set_titlebar(GTK_WINDOW(m_pWindow), 
GTK_WIDGET(m_pHeaderBar));
+gtk_widget_show(GTK_WIDGET(m_pHeaderBar));
+}
+}
+#endif
 }
 else if( nStyle & SalFrameStyleFlags::FLOAT )
 gtk_window_set_type_hint( GTK_WINDOW(m_pWindow), 
GDK_WINDOW_TYPE_HINT_POPUP_MENU );
@@ -1340,7 +1365,12 @@ void GtkSalFrame::SetTitle( const OUString& rTitle )
 {
 m_aTitle = rTitle;
 if( m_pWindow && ! isChild() )
-gtk_window_set_title( GTK_WINDOW(m_pWindow), OUStringToOString( 
rTitle, RTL_TEXTENCODING_UTF8 ).getStr() );
+{
+OString sTitle(OUStringToOString(rTitle, RTL_TEXTENCODING_UTF8));
+

[Libreoffice-commits] core.git: filter/source include/comphelper include/sfx2 offapi/com offapi/UnoApi_offapi.mk officecfg/registry sfx2/Library_sfx.mk sfx2/source uui/inc uui/source

[Michael Meeks]

 filter/source/config/cache/constant.hxx|1 
 filter/source/config/cache/filtercache.cxx |6 +
 filter/source/config/fragments/filters/AbiWord.xcu |2 
 filter/source/config/fragments/filters/MWAW_Bitmap.xcu |2 
 filter/source/config/fragments/filters/MWAW_Database.xcu   |2 
 filter/source/config/fragments/filters/MWAW_Drawing.xcu|2 
 filter/source/config/fragments/filters/MWAW_Presentation.xcu   |2 
 filter/source/config/fragments/filters/MWAW_Spreadsheet.xcu|2 
 filter/source/config/fragments/filters/MWAW_Text_Document.xcu  |2 
 filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu   |2 
 filter/source/config/fragments/filters/StarOffice_XML__Writer_.xcu |2 
 filter/source/config/fragments/filters/T602Document.xcu|2 
 filter/source/config/fragments/filters/XPM.xcu |2 
 filter/source/config/fragments/filters/writer_MIZI_Hwp_97.xcu  |2 
 include/comphelper/documentconstants.hxx   |4 
 include/sfx2/docfilt.hxx   |3 
 include/sfx2/objsh.hxx |3 
 offapi/UnoApi_offapi.mk|1 
 offapi/com/sun/star/document/ExoticFileLoadException.idl   |   34 

 officecfg/registry/schema/org/openoffice/Office/Common.xcs |   23 +
 sfx2/Library_sfx.mk|1 
 sfx2/source/doc/exoticfileloadexception.cxx|   42 
++
 sfx2/source/doc/exoticfileloadexception.hxx|   42 
++
 sfx2/source/doc/objstor.cxx|   37 

 uui/inc/ids.hrc|2 
 uui/inc/ids.hxx|1 
 uui/source/iahndl.cxx  |   25 +
 27 files changed, 235 insertions(+), 14 deletions(-)

New commits:
commit 25e4b59b2e9805ebd3c38c40e5591125a05ed5b0
Author: Michael Meeks 
Date:   Wed Feb 25 15:07:19 2015 +

First cut at annotating 'exotic' filters.

The idea being that we can improve security by warning for these.

Change-Id: I7d993417bfb6a8fe868bc3e07ccbcfe71bf285ff
Reviewed-on: https://gerrit.libreoffice.org/50387
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/filter/source/config/cache/constant.hxx 
b/filter/source/config/cache/constant.hxx
index c8a45889ee0e..2a5da1529de3 100644
--- a/filter/source/config/cache/constant.hxx
+++ b/filter/source/config/cache/constant.hxx
@@ -121,6 +121,7 @@
 #define  FLAGNAME_TEMPLATEPATH  "TEMPLATEPATH"
 #define  FLAGNAME_COMBINED  "COMBINED"
 #define FLAGNAME_SUPPORTSSIGNING "SUPPORTSSIGNING"
+#define FLAGNAME_EXOTIC "EXOTIC"
 
 /** @short  some uno service names.
  */
diff --git a/filter/source/config/cache/filtercache.cxx 
b/filter/source/config/cache/filtercache.cxx
index f6d80f97540c..bb3bfdc7b9d1 100644
--- a/filter/source/config/cache/filtercache.cxx
+++ b/filter/source/config/cache/filtercache.cxx
@@ -1843,6 +1843,7 @@ css::uno::Sequence< OUString > 
FilterCache::impl_convertFlagField2FlagNames(SfxF
 if (nFlags & SfxFilterFlags::COMBINED ) 
lFlagNames.emplace_back(FLAGNAME_COMBINED );
 if (nFlags & SfxFilterFlags::SUPPORTSSIGNING) 
lFlagNames.emplace_back(FLAGNAME_SUPPORTSSIGNING);
 if (nFlags & SfxFilterFlags::GPGENCRYPTION) 
lFlagNames.emplace_back(FLAGNAME_GPGENCRYPTION);
+if (nFlags & SfxFilterFlags::EXOTIC) 
lFlagNames.emplace_back(FLAGNAME_EXOTIC);
 
 return comphelper::containerToSequence(lFlagNames);
 }
@@ -1883,6 +1884,11 @@ SfxFilterFlags 
FilterCache::impl_convertFlagNames2FlagField(const css::uno::Sequ
 nField |= SfxFilterFlags::ENCRYPTION;
 continue;
 }
+if (pNames[i] == FLAGNAME_EXOTIC)
+{
+nField |= SfxFilterFlags::EXOTIC;
+continue;
+}
 if (pNames[i] == FLAGNAME_EXPORT)
 {
 nField |= SfxFilterFlags::EXPORT;
diff --git a/filter/source/config/fragments/filters/AbiWord.xcu 
b/filter/source/config/fragments/filters/AbiWord.xcu
index 115febd8aafe..a309ac87d379 100644
--- a/filter/source/config/fragments/filters/AbiWord.xcu
+++ b/filter/source/config/fragments/filters/AbiWord.xcu
@@ -16,7 +16,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 
-IMPORT ALIEN 
3RDPARTYFILTER
+IMPORT ALIEN 3RDPARTYFILTER 
EXOTIC
 
 com.sun.star.comp.Writer.AbiWordImportFilter
 ABW
diff --git a/filter/source/config/fragments/filters/MWAW_Bitmap.xcu 

[Libreoffice-commits] core.git: uui/inc

[Caolán McNamara]

 uui/inc/strings.hrc |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 975a8164e05a437ec8b51a506989b0bd617854b8
Author: Caolán McNamara 
Date:   Fri Mar 16 13:47:00 2018 +

Related tdf#116264 trailing newlines used for msgbox padding now harmful

Change-Id: Ibe53f71514ffa7d5ca5728b742964f1ab4827692
Reviewed-on: https://gerrit.libreoffice.org/51427
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/uui/inc/strings.hrc b/uui/inc/strings.hrc
index a47412520bca..22deb50f2837 100644
--- a/uui/inc/strings.hrc
+++ b/uui/inc/strings.hrc
@@ -31,10 +31,10 @@
 #define STR_PASSWORD_MISMATCH   NC_("STR_PASSWORD_MISMATCH", 
"The confirmation password did not match the password. Set the password again 
by entering the same password in both boxes.")
 
 #define STR_ALREADYOPEN_TITLE   NC_("STR_ALREADYOPEN_TITLE", 
"Document in Use")
-#define STR_ALREADYOPEN_MSG NC_("STR_ALREADYOPEN_MSG", 
"Document file '$(ARG1)' is locked for editing by yourself on a different 
system since $(ARG2)\n\nOpen document read-only, or ignore own file locking and 
open the document for editing.\n\n")
+#define STR_ALREADYOPEN_MSG NC_("STR_ALREADYOPEN_MSG", 
"Document file '$(ARG1)' is locked for editing by yourself on a different 
system since $(ARG2)\n\nOpen document read-only, or ignore own file locking and 
open the document for editing.")
 #define STR_ALREADYOPEN_READONLY_BTN
NC_("STR_ALREADYOPEN_READONLY_BTN", "Open ~Read-Only")
 #define STR_ALREADYOPEN_OPEN_BTN
NC_("STR_ALREADYOPEN_OPEN_BTN", "~Open")
-#define STR_ALREADYOPEN_SAVE_MSG
NC_("STR_ALREADYOPEN_SAVE_MSG", "Document file '$(ARG1)' is locked for editing 
by yourself on a different system since $(ARG2)\n\nClose document on other 
system and retry saving or ignore own file locking and save current 
document.\n\n")
+#define STR_ALREADYOPEN_SAVE_MSG
NC_("STR_ALREADYOPEN_SAVE_MSG", "Document file '$(ARG1)' is locked for editing 
by yourself on a different system since $(ARG2)\n\nClose document on other 
system and retry saving or ignore own file locking and save current document.")
 #define STR_ALREADYOPEN_RETRY_SAVE_BTN  
NC_("STR_ALREADYOPEN_RETRY_SAVE_BTN", "~Retry Saving")
 #define STR_ALREADYOPEN_SAVE_BTN
NC_("STR_ALREADYOPEN_SAVE_BTN", "~Save")
 
@@ -48,18 +48,18 @@
 
 #define STR_OPENLOCKED_TITLENC_("STR_OPENLOCKED_TITLE", 
"Document in Use")
 #define STR_OPENLOCKED_MSG  NC_("STR_OPENLOCKED_MSG", 
"Document file '$(ARG1)' is locked for editing by:\n\n$(ARG2)\n\nOpen document 
read-only or open a copy of the document for editing.\n\n$(ARG3)")
-#define STR_OPENLOCKED_ALLOWIGNORE_MSG  
NC_("STR_OPENLOCKED_ALLOWIGNORE_MSG", "You may also ignore the file locking and 
open the document for editing.\n\n")
+#define STR_OPENLOCKED_ALLOWIGNORE_MSG  
NC_("STR_OPENLOCKED_ALLOWIGNORE_MSG", "You may also ignore the file locking and 
open the document for editing.")
 #define STR_OPENLOCKED_OPENREADONLY_BTN 
NC_("STR_OPENLOCKED_OPENREADONLY_BTN", "Open ~Read-Only")
 #define STR_OPENLOCKED_OPENCOPY_BTN 
NC_("STR_OPENLOCKED_OPENCOPY_BTN", "Open ~Copy")
 #define STR_UNKNOWNUSER NC_("STR_UNKNOWNUSER", 
"Unknown User")
 
 #define STR_FILECHANGED_TITLE   NC_("STR_FILECHANGED_TITLE", 
"Document Has Been Changed by Others")
-#define STR_FILECHANGED_MSG NC_("STR_FILECHANGED_MSG", 
"The file has been changed since it was opened for editing in %PRODUCTNAME. 
Saving your version of the document will overwrite changes made by 
others.\n\nDo you want to save anyway?\n\n")
+#define STR_FILECHANGED_MSG NC_("STR_FILECHANGED_MSG", 
"The file has been changed since it was opened for editing in %PRODUCTNAME. 
Saving your version of the document will overwrite changes made by 
others.\n\nDo you want to save anyway?")
 #define STR_FILECHANGED_SAVEANYWAY_BTN  
NC_("STR_FILECHANGED_SAVEANYWAY_BTN", "~Save Anyway")
 
 #define STR_TRYLATER_TITLE  NC_("STR_TRYLATER_TITLE", 
"Document in Use")
-#define STR_TRYLATER_MSGNC_("STR_TRYLATER_MSG", 
"Document file '$(ARG1)' is locked for editing by:\n\n$(ARG2)\n\nTry again 
later to save document or save a copy of that document.\n\n")
-#define STR_OVERWRITE_IGNORELOCK_MSG
NC_("STR_OVERWRITE_IGNORELOCK_MSG", "Document file '$(ARG1)' is locked for 
editing by:\n\n$(ARG2)\n\nYou may try to ignore the file locking and overwrite 
the existing document.\n\n")
+#define STR_TRYLATER_MSGNC_("STR_TRYLATER_MSG", 
"Document file '$(ARG1)' is locked for editing by:\n\n$(ARG2)\n\nTry again 
later to save 

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=975a8164e05a437ec8b51a506989b0bd617854b8

Related tdf#116264 trailing newlines used for msgbox padding now harmful

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: uui/source uui/uiconfig

[Caolán McNamara]

 uui/source/iahndl-authentication.cxx |   12 ++---
 uui/source/passworddlg.cxx   |   74 +--
 uui/source/passworddlg.hxx   |   27 
 uui/uiconfig/ui/password.ui  |   15 +--
 4 files changed, 56 insertions(+), 72 deletions(-)

New commits:
commit d2f95590f478a68a4de6ef05018785523e46506b
Author: Caolán McNamara 
Date:   Fri Mar 16 16:07:22 2018 +

Related: tdf#115964 convert the problematic dialog to a native gtk3 one

Change-Id: I84e10f1c45dfbe267f9b350d74271ac149bdaf43
Reviewed-on: https://gerrit.libreoffice.org/51432
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/uui/source/iahndl-authentication.cxx 
b/uui/source/iahndl-authentication.cxx
index 12ed4ed7aff9..2d4d5362f169 100644
--- a/uui/source/iahndl-authentication.cxx
+++ b/uui/source/iahndl-authentication.cxx
@@ -518,11 +518,11 @@ executePasswordDialog(
 {
 if (bIsSimplePasswordRequest)
 {
-ScopedVclPtrInstance xDialog(pParent, nMode, 
aResLocale, aDocName,
-bIsPasswordToModify, bIsSimplePasswordRequest);
+std::unique_ptr xDialog(new 
PasswordDialog(pParent ? pParent->GetFrameWeld() : nullptr, nMode,
+aResLocale, aDocName, bIsPasswordToModify, 
bIsSimplePasswordRequest));
 xDialog->SetMinLen(0);
 
-rInfo.SetResult(xDialog->Execute() == RET_OK ? 
DialogMask::ButtonsOk : DialogMask::ButtonsCancel);
+rInfo.SetResult(xDialog->run() == RET_OK ? 
DialogMask::ButtonsOk : DialogMask::ButtonsCancel);
 rInfo.SetPassword(xDialog->GetPassword());
 }
 else
@@ -541,11 +541,11 @@ executePasswordDialog(
 }
 else // enter password or reenter password
 {
-ScopedVclPtrInstance xDialog(pParent, nMode, 
aResLocale, aDocName,
-bIsPasswordToModify, bIsSimplePasswordRequest);
+std::unique_ptr xDialog(new PasswordDialog(pParent 
? pParent->GetFrameWeld() : nullptr, nMode,
+aResLocale, aDocName, bIsPasswordToModify, 
bIsSimplePasswordRequest));
 xDialog->SetMinLen(0);
 
-rInfo.SetResult(xDialog->Execute() == RET_OK ? 
DialogMask::ButtonsOk : DialogMask::ButtonsCancel);
+rInfo.SetResult(xDialog->run() == RET_OK ? DialogMask::ButtonsOk : 
DialogMask::ButtonsCancel);
 rInfo.SetPassword(bIsPasswordToModify ? OUString() : 
xDialog->GetPassword());
 rInfo.SetPasswordToModify(bIsPasswordToModify ? 
xDialog->GetPassword() : OUString());
 }
diff --git a/uui/source/passworddlg.cxx b/uui/source/passworddlg.cxx
index eec9540de9a8..14cb63446eae 100644
--- a/uui/source/passworddlg.cxx
+++ b/uui/source/passworddlg.cxx
@@ -27,100 +27,84 @@
 
 using namespace ::com::sun::star;
 
-PasswordDialog::PasswordDialog(vcl::Window* _pParent,
+PasswordDialog::PasswordDialog(weld::Window* pParent,
 task::PasswordRequestMode nDlgMode, const std::locale& rLocale,
 const OUString& aDocURL, bool bOpenToModify, bool bIsSimplePasswordRequest)
-: ModalDialog(_pParent, "PasswordDialog", "uui/ui/password.ui")
+: GenericDialogController(pParent, "uui/ui/password.ui", "PasswordDialog")
+, m_xFTPassword(m_xBuilder->weld_label("newpassFT"))
+, m_xEDPassword(m_xBuilder->weld_entry("newpassEntry"))
+, m_xFTConfirmPassword(m_xBuilder->weld_label("confirmpassFT"))
+, m_xEDConfirmPassword(m_xBuilder->weld_entry("confirmpassEntry"))
+, m_xOKBtn(m_xBuilder->weld_button("ok"))
 , nMinLen(1)
 , aPasswdMismatch(Translate::get(STR_PASSWORD_MISMATCH, rLocale))
 , nDialogMode(nDlgMode)
 , rResLocale(rLocale)
 {
-get(m_pFTPassword, "newpassFT");
-get(m_pEDPassword, "newpassEntry");
-get(m_pFTConfirmPassword, "confirmpassFT");
-get(m_pEDConfirmPassword, "confirmpassEntry");
-get(m_pOKBtn, "ok");
-
 if( nDialogMode == task::PasswordRequestMode_PASSWORD_REENTER )
 {
 const char* pOpenToModifyErrStrId = bOpenToModify ? 
STR_ERROR_PASSWORD_TO_MODIFY_WRONG : STR_ERROR_PASSWORD_TO_OPEN_WRONG;
 const char* pErrStrId = bIsSimplePasswordRequest ? 
STR_ERROR_SIMPLE_PASSWORD_WRONG : pOpenToModifyErrStrId;
 OUString aErrorMsg(Translate::get(pErrStrId, rResLocale));
-std::unique_ptr 
xBox(Application::CreateMessageDialog(_pParent ? _pParent->GetFrameWeld() : 
nullptr,
+std::unique_ptr 
xBox(Application::CreateMessageDialog(pParent,
   VclMessageType::Warning, 
VclButtonsType::Ok, aErrorMsg));
 xBox->run();
 }
 
 // default settings for enter password or reenter passwd...
 OUString aTitle(Translate::get(STR_TITLE_ENTER_PASSWORD, rResLocale));
-m_pFTConfirmPassword->Hide();
-

[Libreoffice-commits] core.git: sw/uiconfig

[Caolán McNamara]

 sw/uiconfig/swriter/ui/signatureline.ui |  360 ++--
 1 file changed, 206 insertions(+), 154 deletions(-)

New commits:
commit d0b35b2ec2639d438930c5136e960ed4140a69f3
Author: Caolán McNamara 
Date:   Fri Mar 16 13:21:00 2018 +

use real frames, etc

Change-Id: Ie21a7058c51c3c456de473bf0a88f46cb76a44a4
Reviewed-on: https://gerrit.libreoffice.org/51424
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/uiconfig/swriter/ui/signatureline.ui 
b/sw/uiconfig/swriter/ui/signatureline.ui
index edf50bf5e884..95293de73979 100644
--- a/sw/uiconfig/swriter/ui/signatureline.ui
+++ b/sw/uiconfig/swriter/ui/signatureline.ui
@@ -4,6 +4,7 @@
   
   
 False
+6
 Signature Line
 True
 0
@@ -63,181 +64,232 @@
 6
 6
 6
+True
+True
 6
 6
 
-  
-True
-True
-True
-True
-John Doe
-  
-  
-1
-1
-  
-
-
-  
-True
-True
-True
-True
-Director
-  
-  
-1
-2
-  
-
-
-  
-True
-True
-True
-True
-john@example.org
-  
-  
-1
-3
-  
-
-
-  
-True
-False
-start
-Name:
-  
-  
-0
-1
-  
-
-
-  
-True
-False
-start
-Title:
-  
-  
-0
-2
-  
-
-
-  
+  
 True
 False
-start
-6
-Suggested Signer
-
-  
-
+True
+0
+none
+
+  
+True
+False
+6
+12
+
+  
+True
+False
+6
+12
+
+  
+True
+True
+True
+True
+John Doe
+  
+  
+1
+0
+  
+
+
+  
+True
+True
+True
+True
+Director
+  
+  
+1
+1
+  
+
+
+  
+True
+True
+True
+True
+john@example.org
+  
+  
+1
+2
+  
+
+
+  
+True
+False
+start
+Name:
+True
+edit_name
+  
+  
+0
+0
+  
+
+
+  
+True
+False
+start
+Title:
+True
+edit_title
+  
+  
+0
+1
+  
+
+
+  
+True
+

[Libreoffice-commits] core.git: sw/inc sw/source

[Caolán McNamara]

 sw/inc/swabstdlg.hxx|2 +-
 sw/source/ui/dialog/swdlgfact.cxx   |4 ++--
 sw/source/ui/dialog/swdlgfact.hxx   |2 +-
 sw/source/ui/table/convert.cxx  |2 +-
 sw/source/uibase/dialog/SignatureLineDialog.cxx |5 +++--
 sw/source/uibase/inc/SignatureLineDialog.hxx|2 +-
 sw/source/uibase/uiview/viewdlg2.cxx|2 +-
 7 files changed, 10 insertions(+), 9 deletions(-)

New commits:
commit 28d73ca4b1297345cefed1a092d983bb59a6c445
Author: Caolán McNamara 
Date:   Fri Mar 16 13:30:47 2018 +

can get the window from the SwView

Change-Id: Ifa3033b928db817ccdc4337f8995179bc488fcb6
Reviewed-on: https://gerrit.libreoffice.org/51425
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 7c7861797d03..d11d882052b5 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -400,7 +400,7 @@ public:
 SwCharDlgMode nDialogMode, const OUString* pFormatStr = nullptr) = 0;
 virtual VclPtr CreateSwConvertTableDlg(SwView& 
rView, bool bToTable) = 0;
 virtual VclPtr CreateSwCaptionDialog ( vcl::Window 
*pParent, SwView ) = 0;
-virtual VclPtr CreateSignatureLineDialog(weld::Window* 
pParent, SwView& rView) = 0;
+virtual VclPtr CreateSignatureLineDialog(SwView& rView) 
= 0;
 
 virtual VclPtr 
CreateSwInsertDBColAutoPilot(SwView& rView,
 css::uno::Reference< css::sdbc::XDataSource> rxSource,
diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index b0724dcf18e7..9000ad0380e1 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -728,9 +728,9 @@ VclPtr 
SwAbstractDialogFactory_Impl::CreateSwCaptionDialog (
 return VclPtr::Create( pDlg );
 }
 
-VclPtr 
SwAbstractDialogFactory_Impl::CreateSignatureLineDialog(weld::Window* pParent, 
SwView& rV)
+VclPtr 
SwAbstractDialogFactory_Impl::CreateSignatureLineDialog(SwView& rV)
 {
-return VclPtr::Create(new 
SignatureLineDialog(pParent, rV));
+return VclPtr::Create(new 
SignatureLineDialog(rV));
 }
 
 VclPtr 
SwAbstractDialogFactory_Impl::CreateSwInsertDBColAutoPilot( SwView& rView,
diff --git a/sw/source/ui/dialog/swdlgfact.hxx 
b/sw/source/ui/dialog/swdlgfact.hxx
index 33db10f8cb49..caf3059c86ac 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -451,7 +451,7 @@ public:
 SwCharDlgMode nDialogMode, const OUString* pFormatStr = nullptr) 
override;
 virtual VclPtr CreateSwConvertTableDlg(SwView& 
rView, bool bToTable) override;
 virtual VclPtr CreateSwCaptionDialog ( vcl::Window 
*pParent, SwView ) override;
-virtual VclPtr CreateSignatureLineDialog(weld::Window* 
pParent, SwView& rView) override;
+virtual VclPtr CreateSignatureLineDialog(SwView& rView) 
override;
 
 virtual VclPtr 
CreateSwInsertDBColAutoPilot(SwView& rView,
 css::uno::Reference< css::sdbc::XDataSource> rxSource,
diff --git a/sw/source/ui/table/convert.cxx b/sw/source/ui/table/convert.cxx
index f33d262bba41..dd7007cf0a13 100644
--- a/sw/source/ui/table/convert.cxx
+++ b/sw/source/ui/table/convert.cxx
@@ -94,7 +94,7 @@ void SwConvertTableDlg::GetValues(  sal_Unicode& rDelim,
 }
 
 SwConvertTableDlg::SwConvertTableDlg(SwView& rView, bool bToTable)
-: GenericDialogController(rView.GetViewFrame()->GetWindow().GetFrameWeld(),
+: GenericDialogController(rView.GetFrameWeld(),
 "modules/swriter/ui/converttexttable.ui", "ConvertTextTableDialog")
 , m_xTabBtn(m_xBuilder->weld_radio_button("tabs"))
 , m_xSemiBtn(m_xBuilder->weld_radio_button("semicolons"))
diff --git a/sw/source/uibase/dialog/SignatureLineDialog.cxx 
b/sw/source/uibase/dialog/SignatureLineDialog.cxx
index 2b0f48a42703..8d3df885beff 100644
--- a/sw/source/uibase/dialog/SignatureLineDialog.cxx
+++ b/sw/source/uibase/dialog/SignatureLineDialog.cxx
@@ -37,8 +37,9 @@ using namespace css::view;
 using namespace css::drawing;
 using namespace css::graphic;
 
-SignatureLineDialog::SignatureLineDialog(weld::Window* pParent, SwView& rView)
-: GenericDialogController(pParent, "modules/swriter/ui/signatureline.ui", 
"SignatureLineDialog")
+SignatureLineDialog::SignatureLineDialog(SwView& rView)
+: GenericDialogController(rView.GetFrameWeld(), 
"modules/swriter/ui/signatureline.ui",
+  "SignatureLineDialog")
 , m_xEditName(m_xBuilder->weld_entry("edit_name"))
 , m_xEditTitle(m_xBuilder->weld_entry("edit_title"))
 , m_xEditEmail(m_xBuilder->weld_entry("edit_email"))
diff --git a/sw/source/uibase/inc/SignatureLineDialog.hxx 
b/sw/source/uibase/inc/SignatureLineDialog.hxx
index f3da0ba0bad2..80d7cf87289d 100644
--- a/sw/source/uibase/inc/SignatureLineDialog.hxx
+++ b/sw/source/uibase/inc/SignatureLineDialog.hxx
@@ -21,7 

[Libreoffice-commits] core.git: cui/source include/vcl sfx2/source sw/source vcl/source vcl/unx

[Caolán McNamara]

 cui/source/dialogs/colorpicker.cxx  |6 +++---
 include/vcl/outdev.hxx  |1 +
 include/vcl/weld.hxx|2 +-
 sfx2/source/doc/new.cxx |2 +-
 sfx2/source/doc/saveastemplatedlg.cxx   |2 +-
 sw/source/ui/table/instable.cxx |2 +-
 sw/source/ui/table/tautofmt.cxx |2 +-
 sw/source/uibase/dialog/SignatureLineDialog.cxx |2 +-
 vcl/source/app/salvtables.cxx   |4 ++--
 vcl/source/outdev/text.cxx  |8 
 vcl/source/window/builder.cxx   |2 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx|5 ++---
 12 files changed, 23 insertions(+), 15 deletions(-)

New commits:
commit ca1ed645036cab9ba5e94a9d2e22ef8110e852e0
Author: Caolán McNamara 
Date:   Fri Mar 16 12:03:58 2018 +

use digit width instead of char width

its the same across backends

Change-Id: I37c83cbf1139babcd014c7cfdee06a13bea845c7
Reviewed-on: https://gerrit.libreoffice.org/51423
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/dialogs/colorpicker.cxx 
b/cui/source/dialogs/colorpicker.cxx
index 70a059a29014..87605abe22d5 100644
--- a/cui/source/dialogs/colorpicker.cxx
+++ b/cui/source/dialogs/colorpicker.cxx
@@ -166,7 +166,7 @@ public:
 {
 m_xDrawingArea->connect_size_allocate(LINK(this, ColorPreviewControl, 
DoResize));
 m_xDrawingArea->connect_draw(LINK(this, ColorPreviewControl, DoPaint));
-
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_char_width() * 
10,
+
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_digit_width() 
* 10,
  m_xDrawingArea->get_text_height() * 
2);
 
 }
@@ -212,7 +212,7 @@ public:
 , mdX( -1.0 )
 , mdY( -1.0 )
 {
-
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_char_width() * 
40,
+
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_digit_width() 
* 40,
  m_xDrawingArea->get_text_height() * 
10);
 m_xDrawingArea->connect_size_allocate(LINK(this, ColorFieldControl, 
DoResize));
 m_xDrawingArea->connect_draw(LINK(this, ColorFieldControl, DoPaint));
@@ -559,7 +559,7 @@ ColorSliderControl::ColorSliderControl(weld::DrawingArea* 
pDrawingArea)
 , mnLevel( 0 )
 , mdValue( -1.0 )
 {
-
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_char_width() * 
3, -1);
+
m_xDrawingArea->set_size_request(m_xDrawingArea->get_approximate_digit_width() 
* 3, -1);
 m_xDrawingArea->connect_size_allocate(LINK(this, ColorSliderControl, 
DoResize));
 m_xDrawingArea->connect_draw(LINK(this, ColorSliderControl, DoPaint));
 m_xDrawingArea->connect_mouse_press(LINK(this, ColorSliderControl, 
DoButtonDown));
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index e2cec1c195dd..4b766ccd797a 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1138,6 +1138,7 @@ public:
 */
 longGetTextHeight() const;
 float   approximate_char_width() const;
+float   approximate_digit_width() const;
 
 voidDrawTextArray( const Point& rStartPt, const 
OUString& rStr,
const long* pDXAry,
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 98c53f882e2f..eb1f8501cf04 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -42,7 +42,7 @@ public:
 }
 virtual void set_size_request(int nWidth, int nHeight) = 0;
 virtual Size get_preferred_size() const = 0;
-virtual float get_approximate_char_width() const = 0;
+virtual float get_approximate_digit_width() const = 0;
 virtual int get_text_height() const = 0;
 virtual Size get_pixel_size(const OUString& rText) const = 0;
 virtual OString get_buildable_name() const = 0;
diff --git a/sfx2/source/doc/new.cxx b/sfx2/source/doc/new.cxx
index be99751c9a05..ef6fbf939a93 100644
--- a/sfx2/source/doc/new.cxx
+++ b/sfx2/source/doc/new.cxx
@@ -253,7 +253,7 @@ SfxNewFileDialog::SfxNewFileDialog(weld::Window *pParent, 
SfxNewFileDialogMode n
 , m_sLoadTemplate(m_xAltTitleFt->get_label())
 , m_nFlags(nFlags)
 {
-const int nWidth = m_xRegionLb->get_approximate_char_width() * 32;
+const int nWidth = m_xRegionLb->get_approximate_digit_width() * 32;
 const int nHeight = m_xRegionLb->get_height_rows(8);
 m_xRegionLb->set_size_request(nWidth, nHeight);
 m_xTemplateLb->set_size_request(nWidth, nHeight);
diff --git a/sfx2/source/doc/saveastemplatedlg.cxx 
b/sfx2/source/doc/saveastemplatedlg.cxx
index e1f8101fa78d..76a647e94fa6 100644
--- 

[Libreoffice-commits] core.git: sw/inc sw/source sw/uiconfig

[Caolán McNamara]

 sw/inc/swabstdlg.hxx|2 
 sw/source/ui/dialog/swdlgfact.cxx   |9 ++-
 sw/source/ui/dialog/swdlgfact.hxx   |   16 +-
 sw/source/ui/dialog/swuiexp.cxx |1 
 sw/source/uibase/dialog/SignatureLineDialog.cxx |   58 +++-
 sw/source/uibase/inc/SignatureLineDialog.hxx|   29 +---
 sw/source/uibase/uiview/viewdlg2.cxx|8 +--
 sw/uiconfig/swriter/ui/signatureline.ui |   54 ++
 8 files changed, 101 insertions(+), 76 deletions(-)

New commits:
commit d416fa9a212e0421a7c925507ddee07132f3cab3
Author: Caolán McNamara 
Date:   Fri Mar 16 12:02:17 2018 +

weld SignatureLineDialog

Change-Id: I14cbc7e1aa70696abdeb21eae31176566f17e066
Reviewed-on: https://gerrit.libreoffice.org/51422
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 0c9a77babacd..7c7861797d03 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -400,7 +400,7 @@ public:
 SwCharDlgMode nDialogMode, const OUString* pFormatStr = nullptr) = 0;
 virtual VclPtr CreateSwConvertTableDlg(SwView& 
rView, bool bToTable) = 0;
 virtual VclPtr CreateSwCaptionDialog ( vcl::Window 
*pParent, SwView ) = 0;
-virtual VclPtr CreateSignatureLineDialog(vcl::Window* 
pParent, SwView& rView) = 0;
+virtual VclPtr CreateSignatureLineDialog(weld::Window* 
pParent, SwView& rView) = 0;
 
 virtual VclPtr 
CreateSwInsertDBColAutoPilot(SwView& rView,
 css::uno::Reference< css::sdbc::XDataSource> rxSource,
diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index 4ddbae92c8b3..b0724dcf18e7 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -104,6 +104,10 @@ short AbstractSwSortDlg_Impl::Execute()
 {
 return m_xDlg->execute();
 }
+short AbstractSignatureLineDialog_Impl::Execute()
+{
+return m_xDlg->execute();
+}
 IMPL_ABSTDLG_BASE(AbstractTabDialog_Impl);
 short AbstractSwConvertTableDlg_Impl::Execute()
 {
@@ -724,10 +728,9 @@ VclPtr 
SwAbstractDialogFactory_Impl::CreateSwCaptionDialog (
 return VclPtr::Create( pDlg );
 }
 
-VclPtr 
SwAbstractDialogFactory_Impl::CreateSignatureLineDialog(vcl::Window* pParent, 
SwView& rV)
+VclPtr 
SwAbstractDialogFactory_Impl::CreateSignatureLineDialog(weld::Window* pParent, 
SwView& rV)
 {
-VclPtr pDlg = VclPtr::Create(pParent, rV);
-return VclPtr::Create(pDlg);
+return VclPtr::Create(new 
SignatureLineDialog(pParent, rV));
 }
 
 VclPtr 
SwAbstractDialogFactory_Impl::CreateSwInsertDBColAutoPilot( SwView& rView,
diff --git a/sw/source/ui/dialog/swdlgfact.hxx 
b/sw/source/ui/dialog/swdlgfact.hxx
index b24f08177d0d..33db10f8cb49 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -26,6 +26,7 @@ class SwAsciiFilterDlg;
 class Dialog;
 class SwBreakDlg;
 class SwSortDlg;
+class SignatureLineDialog;
 class SfxTabDialog;
 class SwConvertTableDlg;
 class SwInsertDBColAutoPilot;
@@ -114,6 +115,18 @@ public:
 virtual short Execute() override;
 };
 
+class AbstractSignatureLineDialog_Impl : public VclAbstractDialog
+{
+protected:
+std::unique_ptr m_xDlg;
+public:
+explicit AbstractSignatureLineDialog_Impl(SignatureLineDialog* p)
+: m_xDlg(p)
+{
+}
+virtual short Execute() override;
+};
+
 class AbstractSwBreakDlg_Impl : public AbstractSwBreakDlg
 {
 protected:
@@ -438,8 +451,7 @@ public:
 SwCharDlgMode nDialogMode, const OUString* pFormatStr = nullptr) 
override;
 virtual VclPtr CreateSwConvertTableDlg(SwView& 
rView, bool bToTable) override;
 virtual VclPtr CreateSwCaptionDialog ( vcl::Window 
*pParent, SwView ) override;
-virtual VclPtr CreateSignatureLineDialog(vcl::Window* 
pParent,
-SwView& rView) 
override;
+virtual VclPtr CreateSignatureLineDialog(weld::Window* 
pParent, SwView& rView) override;
 
 virtual VclPtr 
CreateSwInsertDBColAutoPilot(SwView& rView,
 css::uno::Reference< css::sdbc::XDataSource> rxSource,
diff --git a/sw/source/ui/dialog/swuiexp.cxx b/sw/source/ui/dialog/swuiexp.cxx
index b6f412435c33..f938df0b3ff0 100644
--- a/sw/source/ui/dialog/swuiexp.cxx
+++ b/sw/source/ui/dialog/swuiexp.cxx
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/sw/source/uibase/dialog/SignatureLineDialog.cxx 
b/sw/source/uibase/dialog/SignatureLineDialog.cxx
index c7832e4078e9..815636d86ab9 100644
--- a/sw/source/uibase/dialog/SignatureLineDialog.cxx
+++ b/sw/source/uibase/dialog/SignatureLineDialog.cxx
@@ -37,16 +37,18 @@ using namespace css::view;
 using namespace css::drawing;
 using namespace css::graphic;
 

[Libreoffice-bugs] [Bug 116437] default table font differs from the default font for the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116437

--- Comment #1 from haim kilov  ---
Create a new file with default font Arial size 10. 
Type something. 
Insert a new table. 
The default font for this table is Liberation Serif size 12.

This is not the expected behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116438] New: Calc, Draw, Impress should also ask whether to apply orientation when an image is inserted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116438

Bug ID: 116438
   Summary: Calc,Draw,Impress should also ask whether to apply
orientation when an image is inserted
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: himajin100...@gmail.com

Description:
see steps to reproduce


Steps to Reproduce:
1. Download f-orientation-3.jpg(or f-orientation-6.jpg or f-orientation-8.jpg)
and f-orientation-1.jpg(just for reference) from
https://github.com/minodisk/go-fix-orientation/tree/master/processor/fixtures

2. OK Case:

2-a. Run Writer
2-b. Insert -> Image from the main menu.
2-c. Specify f-orientation-3.jpg and click Open
2-d. A dialog "Rotate int standard orientation?" appears.
2-e. Click Yes
2-f. the inserted image looks like f-orientation-1.jpg
if you have chosen No in 2-e, the image will look as 180 degrees rotated
version.

3. Now, NG case:

3-a. Run Calc
3-b. Insert -> Image from the main menu.
3-c. Specify f-orientation-3.jpg and click Open
3-d. No dialog appears.
3-e. there is nothing to do.
3-f. the image will look as 180 degrees rotated version.

Actual Results:  
as written in 3-d and 3-e

Expected Results:
work as written in 2-d and 2-e in Calc,Draw and Impress


Reproducible: Always


User Profile Reset: No



Additional Info:
I will submit a patch. 

Note: the patch would not cover "drag-dropping an image" into Calc, Draw and
Impress. I haven't gone that far.

Note: This patch will not change writer's dialog into "weld" version
/core/sw/source/uibase/uiview/view2.cxx?r=5c151537#224

Note: I'm still not sure what to pass as the first argument for
Application::CreateMessageDialog

Version: 6.1.0.0.alpha0+ (x64)
Build ID: e5bc7fa4e83b33fc3eee343e560a4f8cb91eacd6
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-15_00:49:26
Locale: en-US (ja_JP); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101
Firefox/61.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116437] New: default table font differs from the default font for the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116437

Bug ID: 116437
   Summary: default table font differs from the default font for
the document
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ha...@aol.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116436] New: background color of a table row disappears after saving as docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116436

Bug ID: 116436
   Summary: background color of a table row disappears after
saving as docx
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ha...@aol.com

Background color of a table row disappears after saving as docx.

Steps to reproduce:
1. Create the following file:
A line
[a two-row and two-column table with any contents]
Another line

2. Highlight the top row; Table->properties->background->row --> use any
background color (I used red)
3. Save as docx
4. Reopen the same file

Result: The background color disappears
Expected result: the background color is preserved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

[Henry Castro]

 sc/qa/unit/tiledrendering/tiledrendering.cxx |   43 +++
 sc/source/ui/app/scmod.cxx   |   32 +++-
 sc/source/ui/formdlg/formula.cxx |6 +--
 sc/source/ui/inc/anyrefdg.hxx|4 +-
 sc/source/ui/miscdlgs/anyrefdg.cxx   |   32 
 5 files changed, 73 insertions(+), 44 deletions(-)

New commits:
commit 009d2756b1678477ec23d5647bd5004c4bff3a62
Author: Henry Castro 
Date:   Thu Mar 15 14:23:48 2018 -0400

lokdialog: do not lock events when opened ScFilter Dialog

When exists 2 or more views and one of the views open the ScFilter dialog,
the other views are locked and no event process.

In tiled rendering case, collaborative editing is not functional with 2 or
more views are locked, so the patch prevents locking the other views

Change-Id: I0133d38ac5ecef4d3ebc22f3e922602704dcd0b3
Reviewed-on: https://gerrit.libreoffice.org/51370
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 2eba19977076..cdd9af6df92f 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -30,10 +30,12 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -91,6 +93,7 @@ public:
 void testLanguageStatus();
 void testMultiViewCopyPaste();
 void testIMESupport();
+void testFilterDlg();
 
 CPPUNIT_TEST_SUITE(ScTiledRenderingTest);
 CPPUNIT_TEST(testRowColumnSelections);
@@ -122,6 +125,7 @@ public:
 CPPUNIT_TEST(testLanguageStatus);
 CPPUNIT_TEST(testMultiViewCopyPaste);
 CPPUNIT_TEST(testIMESupport);
+CPPUNIT_TEST(testFilterDlg);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -1608,6 +1612,45 @@ void ScTiledRenderingTest::testIMESupport()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void ScTiledRenderingTest::testFilterDlg()
+{
+comphelper::LibreOfficeKit::setActive();
+
+createDoc("empty.ods");
+
+// view #1
+SfxViewShell* pView1 = SfxViewShell::Current();
+int nView1 = SfxLokHelper::getView();
+
+// view #2
+SfxLokHelper::createView();
+SfxViewShell* pView2 = SfxViewShell::Current();
+CPPUNIT_ASSERT(pView1 != pView2);
+{
+pView2->GetViewFrame()->GetDispatcher()->Execute(SID_FILTER,
+SfxCallMode::SLOT|SfxCallMode::RECORD);
+}
+
+Scheduler::ProcessEventsToIdle();
+SfxChildWindow* pRefWindow = 
pView2->GetViewFrame()->GetChildWindow(SID_FILTER);
+CPPUNIT_ASSERT(pRefWindow);
+
+// switch to view 1
+SfxLokHelper::setView(nView1);
+CPPUNIT_ASSERT_EQUAL(true, 
pView2->GetViewFrame()->GetDispatcher()->IsLocked());
+CPPUNIT_ASSERT_EQUAL(false, 
pView1->GetViewFrame()->GetDispatcher()->IsLocked());
+
+KeyEvent aEvent(27, KEY_ESCAPE, 0);
+Application::PostKeyEvent(VclEventId::WindowKeyInput, 
pRefWindow->GetWindow(), );
+Application::PostKeyEvent(VclEventId::WindowKeyUp, 
pRefWindow->GetWindow(), );
+
+Scheduler::ProcessEventsToIdle();
+CPPUNIT_ASSERT_EQUAL(false, 
pView2->GetViewFrame()->GetDispatcher()->IsLocked());
+CPPUNIT_ASSERT_EQUAL(false, 
pView1->GetViewFrame()->GetDispatcher()->IsLocked());
+
+comphelper::LibreOfficeKit::setActive(false);
+}
+
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScTiledRenderingTest);
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 8cd2725c67d5..29c2c33d81df 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1554,20 +1554,25 @@ void ScModule::SetRefDialog( sal_uInt16 nId, bool bVis, 
SfxViewFrame* pViewFrm )
 }
 }
 
-static SfxChildWindow* lcl_GetChildWinFromAnyView( sal_uInt16 nId )
+static inline SfxChildWindow* lcl_GetChildWinFromCurrentView( sal_uInt16 nId )
 {
-// First, try the current view
 SfxViewFrame* pViewFrm = SfxViewFrame::Current();
 
 // #i46999# current view frame can be null (for example, when closing help)
-SfxChildWindow* pChildWnd = pViewFrm ? pViewFrm->GetChildWindow( nId ) : 
nullptr;
+return pViewFrm ? pViewFrm->GetChildWindow( nId ) : nullptr;
+}
+
+static SfxChildWindow* lcl_GetChildWinFromAnyView( sal_uInt16 nId )
+{
+// First, try the current view
+SfxChildWindow* pChildWnd = lcl_GetChildWinFromCurrentView( nId );
 if ( pChildWnd )
 return pChildWnd;   // found in the current view
 
 //  if not found there, get the child window from any open view
 //  it can be open only in one view because nCurRefDlgId is global
 
-pViewFrm = SfxViewFrame::GetFirst();
+SfxViewFrame* pViewFrm = SfxViewFrame::GetFirst();
 while ( pViewFrm )
 {
 pChildWnd = pViewFrm->GetChildWindow( nId );
@@ -1588,7 +1593,7 @@ bool ScModule::IsModalMode(SfxObjectShell* pDocSh)

[Libreoffice-bugs] [Bug 82481] SUM() copies cell formats

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82481

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||109352


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109352
[Bug 109352] [META] Sum function bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109352] [META] Sum function bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109352

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||82481


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82481
[Bug 82481] SUM() copies cell formats
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105948

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116429


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116429
[Bug 116429] Undoing after adding a shape only undoes "Change object name of
Shape to 'Shape 1'"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116429] Undoing after adding a shape only undoes " Change object name of Shape to 'Shape 1'"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116429

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||105948


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116422] Index lexical

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116422

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||89606


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89606
[Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116433] No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

kec  changed:

   What|Removed |Added

Version|unspecified |6.0.2.1 release

--- Comment #4 from kec  ---
I'm not sure how to navigate the menus and settings without texts. Please
advise.


Content of opengl_device.log:

DriverVersion: 23.20.15017.3010
DriverDate: 1-31-2018
DeviceID: PCI\VEN_1002_130A_383017AA_00
AdapterVendorID: 0x1002
AdapterDeviceID: 0x130a
AdapterSubsysID: 0x383017aa
DeviceKey:
System\CurrentControlSet\Control\Video\{84853A88-2395-11E8-9F6C-5C93A2B7425E}\
DeviceString: AMD Radeon(TM) R6 Graphics

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89606

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116422


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116422
[Bug 116422] Index lexical
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112228] [META] Desktop environment bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112228

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||113397


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113397
[Bug 113397] Global  menu does not work with KDE Plasma 5.9 +
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113397] Global menu does not work with KDE Plasma 5.9 +

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113397

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||112228


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112228
[Bug 112228] [META] Desktop environment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bridges/source

[jan Iversen]

 bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx|6 ++
 bridges/source/cpp_uno/gcc3_ios/ios64_helper.s |9 +++--
 2 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 8a8663a49b6d2ba297587c730860cc8ca9d139da
Author: jan Iversen 
Date:   Fri Mar 16 20:29:02 2018 +0100

iOS, solved call stack problem.

Stack was not corrupted, but the call stack was not intact when
passing the assembler code.

Change-Id: If07909dce2b4a73634a130e5f50e84312115b845

diff --git a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
index 748d276ac21b..9ad3954e4504 100644
--- a/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_ios/cpp2uno.cxx
@@ -418,8 +418,8 @@ namespace
  * (called by asm snippets)
  */
 
-extern "C" sal_Int64 cpp_vtable_call( sal_Int32 func, sal_Int32 offset,
-  void **pCallStack )
+extern "C" void cpp_vtable_call( sal_Int32 func, sal_Int32 offset,
+ void **pCallStack )
 {
 sal_Int64 nRegReturn;
 typelib_TypeClass aType = cpp_mediate( func, offset, pCallStack, 
 );
@@ -444,8 +444,6 @@ extern "C" sal_Int64 cpp_vtable_call( sal_Int32 func, 
sal_Int32 offset,
 default:
 break;
 }
-
-return nRegReturn;
 }
 
 namespace
diff --git a/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s 
b/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
index 67620c38e426..4c09f2b1b2f9 100644
--- a/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
+++ b/bridges/source/cpp_uno/gcc3_ios/ios64_helper.s
@@ -199,6 +199,8 @@ _privateSnippetExecutor:
 .cfi_offset w29, -16
 
 // _privateSnippetExecutor is jumped to from codeSnippet_*
+stpx29, x30, [sp, #-0x10]!
+movx29, sp
 
 // push all GP, FP/SIMD registers to the stack
 stp x6, x7, [sp, #-16]!
@@ -220,9 +222,12 @@ _privateSnippetExecutor:
 mov x2, sp
 
 bl  _cpp_vtable_call
-ldp x8, lr, [sp, #0]
+//ldp x8, lr, [sp, #0]
+//add sp, sp, #144
+//ret lr
 add sp, sp, #144
-ret lr
+ldpx29, x30, [sp], #0x10
+ret
 .cfi_endproc
 
 // vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103304] [META] Page dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103304

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||71843


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71843
[Bug 71843] Missing "Surround header" and "Surround footer" Page Border options
in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71843] Missing "Surround header" and "Surround footer" Page Border options in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71843

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103304


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103304
[Bug 103304] [META] Page dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82009] PIVOTTABLE: Black color on fields of Pivot Table Layout window (Mac OS X only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82009

eisa01  changed:

   What|Removed |Added

   Priority|highest |high
 CC||eis...@gmail.com
   Severity|normal  |major

--- Comment #29 from eisa01  ---
This is still present

Makes using the pivot table functionality a bit cumbersome, and this is a
regression, so I'm revising the importance according to the bug prioritizing
chart

Version: 6.1.0.0.alpha0+
Build ID: 8e8dd8f320a3ff59ff8a16c1a7a867888ce80700
CPU threads: 2; OS: Mac OS X 10.12.6; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-03-13_23:59:29
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97889] SIDEBAR: Connector content panel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97889

Gerry  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||649

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99649] [META] Improve Connector handling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99649

Gerry  changed:

   What|Removed |Added

 CC||gerry.trep...@googlemail.co
   ||m
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||889

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102187

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116407


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116407
[Bug 116407] option "Border" for new table redundant
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||102187, 103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102187
[Bug 102187] [META] Options dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116407


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116407
[Bug 116407] option "Border" for new table redundant
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||102187, 103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102187
[Bug 102187] [META] Options dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116435] New: XML Form Document: Impossible to rename default-value " instanceData"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116435

Bug ID: 116435
   Summary: XML Form Document: Impossible to rename default-value
"instanceData"
   Product: LibreOffice
   Version: 3.6.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Open LO.
File > New > XML Form Document
On the right you could see the Data Navigator. If not switch to the bottom of
the window, 4th button from the left.
Data Navigator shows "Instance 1" and there "instanceData".
Mark "instanceData" and edit the element (right mousclick > Edit Element)
Change the name, for example, to "Data".
Close the dialog.
No changing has been made.
Add a element with default "newElement".
Change the name, for example, to "New".
Close the dialog.
Element has been renamed.

Renaming works here on all elements, except the root-element "instanceData".

There is one way rename the root-element out of the box:
create a xml-file with the following content
-



-
Go to Instances (right down on the Data Navigator) > Edit. Browse to the file,
click "OK", save the form and reopen it. "instanceData" has been removed by
"Main".

All these tested with LO 6.0.2.1 and also the oldest here installed version LO
3.6.7., OpenSUSE 42.3 64bit rpm. Renaming doesn't work in any LO-version, also
tested with AOO - the same. Has been working at the beginning of XML Form
Documents with OOo. There are descriptions available for OOo 2.0 which will
show forms with many different named root-elements.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103303] [META] Desktop integration bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103303

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||116408


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116408
[Bug 116408] LibreOffice not associated with pdf docs in "open with" contextual
menu in MacOS
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116408] LibreOffice not associated with pdf docs in "open with" contextual menu in MacOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116408

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103303


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103303
[Bug 103303] [META] Desktop integration bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/OperationSmiley' - svx/source

[Armin Le Grand]

 svx/source/customshapes/EnhancedCustomShape2d.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 75a376b9b1bd784ed16bba5b3a0842097dfae6e8
Author: Armin Le Grand 
Date:   Fri Mar 16 18:17:54 2018 +0100

OperationSmiley: Corrected shadowing of local variables

Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa

diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 17fe098ff3fe..5ed79db32897 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -746,7 +746,7 @@ 
EnhancedCustomShape2d::EnhancedCustomShape2d(SdrObjCustomShape& rSdrObjCustomSha
 if ( pAny )
 *pAny >>= bFlipV;
 
-nRotateAngle = static_cast(static_cast< SdrObjCustomShape& 
>(mrSdrObjCustomShape).GetObjectRotation() * 100.0);
+nRotateAngle = 
static_cast(mrSdrObjCustomShape.GetObjectRotation() * 100.0);
 
 /*const sal_Int32* pDefData =*/ ApplyShapeAttributes( rGeometryItem );
 SetPathSize();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116433] No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Buovjaga  ---
Looks like bug 112305.

Do you have OpenGL enabled? Tools - Options - LibreOffice - View - Use OpenGL
for all rendering
If yes, try turning it off and copy & paste to a comment the contents of your
C:\Users\User\AppData\Roaming\LibreOffice\4\cache\opengl_device.log

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116434] Libreoffice startup exceedingly slow in 6.0.2.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116434

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
  Component|Base|LibreOffice
   Hardware|IA64 (Itanium)  |x86-64 (AMD64)

--- Comment #2 from Buovjaga  ---
Have not noticed this on macOS 10.12.6.

You could test Help - Restart in safe mode and then Continue in safe mode and
then opening some document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82481] SUM() copies cell formats

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82481

eisa01  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All

--- Comment #8 from eisa01  ---
Setting version to all, this is not mac specific

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116420] Error when I try to open an Document in a Sharepoint WebDAV directory ( # is not allowed in a filename)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116420

--- Comment #2 from Gabor Kelemen  ---
Will take a look next week.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116433] No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

--- Comment #2 from kec  ---
No that does not help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: canvas/source include/vcl vcl/source

[Noel Grandin]

 canvas/source/cairo/cairo_canvashelper.cxx |  288 
 include/vcl/BitmapTools.hxx|6 
 vcl/source/bitmap/BitmapTools.cxx  |  291 +
 3 files changed, 303 insertions(+), 282 deletions(-)

New commits:
commit 5b75a1697250d8b2b6003c37067f39270a5ad828
Author: Noel Grandin 
Date:   Fri Mar 16 14:58:59 2018 +0200

move cairo extract bitmap code from canvas to vcl

part of making GetMask/GetAlpha an internal detail of vcl

Change-Id: I45c2e9fdae08d7f444a64e8e04a6f65bb525cbd1
Reviewed-on: https://gerrit.libreoffice.org/51417
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index bba59a15c475..2ed3d0472c04 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -48,6 +48,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -328,71 +329,6 @@ namespace cairocanvas
 return ::BitmapEx();
 }
 
-static sal_uInt8 lcl_GetColor(BitmapColor const& rColor)
-{
-sal_uInt8 nTemp(0);
-if (rColor.IsIndex())
-{
-nTemp = rColor.GetIndex();
-}
-else
-{
-nTemp = rColor.GetBlue();
-// greyscale expected here, or what would non-grey colors mean?
-assert(rColor.GetRed() == nTemp && rColor.GetGreen() == nTemp);
-}
-return nTemp;
-}
-
-static bool readAlpha( BitmapReadAccess const * pAlphaReadAcc, long nY, 
const long nWidth, unsigned char* data, long nOff )
-{
-bool bIsAlpha = false;
-long nX;
-int nAlpha;
-Scanline pReadScan;
-
-nOff += 3;
-
-switch( pAlphaReadAcc->GetScanlineFormat() )
-{
-case ScanlineFormat::N8BitTcMask:
-pReadScan = pAlphaReadAcc->GetScanline( nY );
-for( nX = 0; nX < nWidth; nX++ )
-{
-nAlpha = data[ nOff ] = 255 - ( *pReadScan++ );
-if( nAlpha != 255 )
-bIsAlpha = true;
-nOff += 4;
-}
-break;
-case ScanlineFormat::N8BitPal:
-pReadScan = pAlphaReadAcc->GetScanline( nY );
-for( nX = 0; nX < nWidth; nX++ )
-{
-BitmapColor const& rColor(
-pAlphaReadAcc->GetPaletteColor(*pReadScan));
-pReadScan++;
-nAlpha = data[ nOff ] = 255 - lcl_GetColor(rColor);
-if( nAlpha != 255 )
-bIsAlpha = true;
-nOff += 4;
-}
-break;
-default:
-SAL_INFO( "canvas.cairo", "fallback to GetColor for alpha - 
slow, format: " << static_cast(pAlphaReadAcc->GetScanlineFormat()) );
-for( nX = 0; nX < nWidth; nX++ )
-{
-nAlpha = data[ nOff ] = 255 - pAlphaReadAcc->GetColor( nY, 
nX ).GetIndex();
-if( nAlpha != 255 )
-bIsAlpha = true;
-nOff += 4;
-}
-}
-
-return bIsAlpha;
-}
-
-
 /** surfaceFromXBitmap Create a surface from XBitmap
  * @param xBitmap bitmap image that will be used for the surface
  * @param rDevice reference to the device into which we want to draw
@@ -427,232 +363,20 @@ namespace cairocanvas
 
 if( !pSurface )
 {
-AlphaMask aAlpha = aBmpEx.GetAlpha();
-
-::BitmapReadAccess* pBitmapReadAcc = 
aBitmap.AcquireReadAccess();
-::BitmapReadAccess* pAlphaReadAcc = nullptr;
-const long  nWidth = pBitmapReadAcc->Width();
-const long  nHeight = pBitmapReadAcc->Height();
-long nX, nY;
-bool bIsAlpha = false;
-
-if( aBmpEx.IsTransparent() || aBmpEx.IsAlpha() )
-pAlphaReadAcc = aAlpha.AcquireReadAccess();
-
-data = static_cast(malloc( nWidth*nHeight*4 ));
-
-long nOff = 0;
-::Color aColor;
-unsigned int nAlpha = 255;
-
-for( nY = 0; nY < nHeight; nY++ )
-{
-::Scanline pReadScan;
-
-switch( pBitmapReadAcc->GetScanlineFormat() )
-{
-case ScanlineFormat::N8BitPal:
-pReadScan = pBitmapReadAcc->GetScanline( nY );
-if( pAlphaReadAcc )
-if( readAlpha( pAlphaReadAcc, nY, nWidth, data, 
nOff ) )
-bIsAlpha = true;
-
-for( nX 

[Libreoffice-commits] core.git: filter/source include/vcl vcl/source

[Noel Grandin]

 filter/source/msfilter/msdffimp.cxx |9 +++--
 include/vcl/bitmapex.hxx|1 +
 vcl/source/gdi/bitmapex.cxx |8 
 3 files changed, 12 insertions(+), 6 deletions(-)

New commits:
commit 8015e0a15d1b8c454c26c645c7e8ebee9c4e1ee1
Author: Noel Grandin 
Date:   Fri Mar 16 13:43:08 2018 +0200

move some mask code from SvxMSDffManager::ImportGraphic inside BitmapEx

part of moving GetMask/GetAlpha touching code inside vcl

Change-Id: I46e908ed6216dd521143ca94d2dcbd7e95d8b9ce
Reviewed-on: https://gerrit.libreoffice.org/51408
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 960fa7f1ed2d..7c77dff78824 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -3822,12 +3822,9 @@ SdrObject* SvxMSDffManager::ImportGraphic( SvStream& 
rSt, SfxItemSet& rSet, cons
 
 if ( aGraf.GetType() == GraphicType::Bitmap )
 {
-BitmapExaBitmapEx( aGraf.GetBitmapEx() );
-Bitmap  aBitmap( aBitmapEx.GetBitmap() );
-Bitmap  aMask( aBitmap.CreateMask( MSO_CLR_ToColor( 
nTransColor, DFF_Prop_pictureTransparent ), 9 ) );
-if ( aBitmapEx.IsTransparent() )
-aMask.CombineSimple( aBitmapEx.GetMask(), 
BmpCombine::Or );
-aGraf = BitmapEx( aBitmap, aMask );
+BitmapEx aBitmapEx( aGraf.GetBitmapEx() );
+aBitmapEx.CombineMaskOr( MSO_CLR_ToColor( nTransColor, 
DFF_Prop_pictureTransparent ), 9 );
+aGraf = aBitmapEx;
 }
 }
 
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index 4876180e10c4..d78f273b21ad 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -448,6 +448,7 @@ public:
 
 voidAdjustTransparency( sal_uInt8 cTrans );
 
+voidCombineMaskOr(Color maskColor, sal_uInt8 nTol);
 public:
 
 SAL_DLLPRIVATE std::shared_ptr const & ImplGetBitmapImpBitmap() 
const { return maBitmap.ImplGetImpBitmap(); }
diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index 1dcc72befeaf..14b3fa17efd6 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -1441,4 +1441,12 @@ void BitmapEx::GetSplitData( std::vector& 
rvColorData, std::vectorhttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Noel Grandin]

 sd/source/ui/unoidl/unowcntr.cxx |   24 +---
 sd/source/ui/unoidl/unowcntr.hxx |2 +-
 2 files changed, 10 insertions(+), 16 deletions(-)

New commits:
commit 92dc87cbac74c1be260534b5e38088c44515a47b
Author: Noel Grandin 
Date:   Fri Mar 16 14:38:30 2018 +0200

loplugin:useuniqueptr in SvUnoWeakContainer

just use a std::vector here, these are small objects, no need to
allocate them separately

Change-Id: Ie9f8df88eb7c291e2c99177d0f5e4bfc1c7ab542
Reviewed-on: https://gerrit.libreoffice.org/51415
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sd/source/ui/unoidl/unowcntr.cxx b/sd/source/ui/unoidl/unowcntr.cxx
index bb1687b07362..7583b1f569d4 100644
--- a/sd/source/ui/unoidl/unowcntr.cxx
+++ b/sd/source/ui/unoidl/unowcntr.cxx
@@ -29,9 +29,6 @@ SvUnoWeakContainer::SvUnoWeakContainer() throw()
 
 SvUnoWeakContainer::~SvUnoWeakContainer() throw()
 {
-for (auto const& elem : maVector)
-delete elem;
-maVector.clear();
 }
 
 /** inserts the given ref into this container */
@@ -39,21 +36,20 @@ void SvUnoWeakContainer::insert( const uno::WeakReference< 
uno::XInterface >& xR
 {
 for ( auto it = maVector.begin(); it != maVector.end(); )
 {
-uno::WeakReference< uno::XInterface >* pRef = *it;
-uno::Reference< uno::XInterface > xTestRef( *pRef );
+uno::WeakReference< uno::XInterface > & rWeakRef = *it;
+uno::Reference< uno::XInterface > xTestRef( rWeakRef );
 if ( !xTestRef.is() )
 {
-delete pRef;
 it = maVector.erase( it );
 }
 else
 {
-if ( *pRef == xRef )
+if ( rWeakRef == xRef )
 return;
 ++it;
 }
 }
-maVector.push_back( new uno::WeakReference< uno::XInterface >( xRef ) );
+maVector.emplace_back( uno::WeakReference< uno::XInterface >( xRef ) );
 }
 
 /** searches the container for a ref that returns true on the given
@@ -67,18 +63,17 @@ bool SvUnoWeakContainer::findRef(
 {
 for ( auto it = maVector.begin(); it != maVector.end(); )
 {
-uno::WeakReference< uno::XInterface >* pRef = *it;
-uno::Reference< uno::XInterface > xTestRef( *pRef );
+uno::WeakReference< uno::XInterface > & itRef = *it;
+uno::Reference< uno::XInterface > xTestRef( itRef );
 if ( !xTestRef.is() )
 {
-delete pRef;
 it = maVector.erase( it );
 }
 else
 {
-if( (*pSearchFunc)( *pRef, pSearchData ) )
+if( (*pSearchFunc)( itRef, pSearchData ) )
 {
-rRef = *pRef;
+rRef = itRef;
 return true;
 }
 ++it;
@@ -91,8 +86,7 @@ void SvUnoWeakContainer::dispose()
 {
 for (auto const& elem : maVector)
 {
-uno::WeakReference< uno::XInterface >* pRef = elem;
-uno::Reference< uno::XInterface > xTestRef( *pRef );
+uno::Reference< uno::XInterface > xTestRef( elem );
 if ( xTestRef.is() )
 {
 uno::Reference< lang::XComponent > xComp( xTestRef, uno::UNO_QUERY 
);
diff --git a/sd/source/ui/unoidl/unowcntr.hxx b/sd/source/ui/unoidl/unowcntr.hxx
index 787c81d3c3b3..8d1a5e441912 100644
--- a/sd/source/ui/unoidl/unowcntr.hxx
+++ b/sd/source/ui/unoidl/unowcntr.hxx
@@ -28,7 +28,7 @@ typedef bool (*weakref_searchfunc)( const 
css::uno::WeakReference< css::uno::XIn
 class SvUnoWeakContainer
 {
 private:
-std::vector< css::uno::WeakReference< css::uno::XInterface >* > maVector;
+std::vector< css::uno::WeakReference< css::uno::XInterface > > maVector;
 
 public:
 SvUnoWeakContainer() throw();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116433] No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

--- Comment #1 from Xavier Van Wijmeersch  ---
I did have the same problem, so i closed LibreOffice and did shutdown my pc.
When I restarted the pc and LibreOffice the problem was gone. Just give it a
try.
Hope it helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116141] Help installed but not recognised

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116141

--- Comment #9 from rich...@mellish.eu ---
Well, I have de-installed and re-installed both LibreOffice and the Help pack,
and still got the same message "The LibreOffice built-in help is not installed
on your computer."

In desperation I have de-installed again and this time installed version 6 by
running LibreOffice_6.0.2_Win_x64.msi and
LibreOffice_6.0.2_Win_x64_helppack_en-GB.msi

STILL the same. I'm not doing anything special, just running the installers as
downloaded from www.libreoffice.org.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/OperationSmiley' - svx/source

[Armin Le Grand]

 svx/source/customshapes/EnhancedCustomShapeEngine.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e739d02af4d8cf299753c0884255a63ad5037cf9
Author: Armin Le Grand 
Date:   Fri Mar 16 18:17:54 2018 +0100

OperationSmiley: Corrected shadowing of local variables

Change-Id: I7826c7d80ca822cd8211cbf9444f21c3bcfaf6aa

diff --git a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx 
b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
index 899ea6e03c26..133c008ebc4e 100644
--- a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
@@ -205,10 +205,10 @@ SdrObject* 
EnhancedCustomShapeEngine::ImplForceGroupWithText(
 
 if(bIsSdrObjCustomShape)
 {
-SdrObjCustomShape& rSdrObjCustomShape(
+SdrObjCustomShape& rSdrObjCustomShape2(
 static_cast< SdrObjCustomShape& >(
 *GetSdrObjectFromXShape(mxShape)));
-EnhancedCustomShape2d aCustomShape2d(rSdrObjCustomShape);
+EnhancedCustomShape2d aCustomShape2d(rSdrObjCustomShape2);
 aTextBounds = aCustomShape2d.GetTextRect();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116434] Libreoffice startup exceedingly slow in 6.0.2.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116434

Jon R Kibler  changed:

   What|Removed |Added

Summary|After upgrading from|Libreoffice startup
   |Libreoffice 5.4.6.2 to  |exceedingly slow in 6.0.2.1
   |6.0.2.1, the amount of time |
   |it takes from clicking on   |
   |the Libreoffice icon in |
   |Dock to Start Center being  |
   |displayed has increased |
   |from 10-15 seconds to now   |
   |be 30-90 seconds.   |

--- Comment #1 from Jon R Kibler  ---
(Side note: When I was typing in the Summary description, suddenly the bug was
submitted in the middle of my typing! That is why the original comments were
brief and uninformative.)

Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: GL; 
Locale: en-US (en_US.UTF-8);

After upgrading from Libreoffice 5.4.6.2 to 6.0.2.1, the amount of time it
takes from clicking on the Libreoffice icon in Dock to Start Center being
displayed has increased from 10-15 seconds to now be 30-90 seconds.

I have cleared all recent documents and reset libreoffice, and it makes no
difference in how slow libreoffice now is at startup.

I have also noticed a similar slowdown when opening a single document from
Finder. However, that delay is highly variable, depending upon the document
size. I have had one large document take over 3 minutes to open.

What changed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116434] New: After upgrading from Libreoffice 5.4.6.2 to 6.0.2.1, the amount of time it takes from clicking on the Libreoffice icon in Dock to Start Center being displayed has

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116434

Bug ID: 116434
   Summary: After upgrading from Libreoffice 5.4.6.2 to 6.0.2.1,
the amount of time it takes from clicking on the
Libreoffice icon in Dock to Start Center being
displayed has increased from 10-15 seconds to now be
30-90 seconds.
   Product: LibreOffice
   Version: 6.0.2.1 release
  Hardware: IA64 (Itanium)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jrk1231...@nym.hush.com

Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 8; OS: Mac OS X 10.12.6; UI render: default; 
Locale: en-US (en_US.UTF-8);

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116433] New: No texts, lables or menues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116433

Bug ID: 116433
   Summary: No texts, lables or menues
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: klaus_ed...@hotmail.com

Created attachment 140664
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140664=edit
screenshot

I have installed Libre Office 6.0.2.1 on Widnows 10.
It is installed on a Lenovo laptop Z50.

There are no texts, labels or menus. Opening a ods file show only red underline
for spelling mistakes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs