[Libreoffice-commits] core.git: sc/CppunitTest_sc_cellcursorobj.mk
sc/CppunitTest_sc_cellcursorobj.mk | 43 ++--- 1 file changed, 7 insertions(+), 36 deletions(-) New commits: commit 30d5569dcf46ddd84a85eb9bd38e18e59cfd2c9d Author: Jens Carl Date: Thu Jun 21 04:59:18 2018 + Remove obsolete (cargo-cult copied) dependencies Change-Id: Ifd550df955cc95498949a0907e43ba41f68ba585 Reviewed-on: https://gerrit.libreoffice.org/56216 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/sc/CppunitTest_sc_cellcursorobj.mk b/sc/CppunitTest_sc_cellcursorobj.mk index 7882a8926bc8..4ebca949c3c4 100644 --- a/sc/CppunitTest_sc_cellcursorobj.mk +++ b/sc/CppunitTest_sc_cellcursorobj.mk @@ -11,50 +11,21 @@ $(eval $(call gb_CppunitTest_CppunitTest,sc_cellcursorobj)) +$(eval $(call gb_CppunitTest_use_external,sc_cellcursorobj,boost_headers)) + $(eval $(call gb_CppunitTest_add_exception_objects,sc_cellcursorobj, \ -sc/qa/extras/sccellcursorobj \ + sc/qa/extras/sccellcursorobj \ )) -$(eval $(call gb_CppunitTest_use_external,sc_cellcursorobj,boost_headers)) - $(eval $(call gb_CppunitTest_use_libraries,sc_cellcursorobj, \ -basegfx \ -comphelper \ -cppu \ -cppuhelper \ -drawinglayer \ -editeng \ -for \ -forui \ -i18nlangtag \ -msfilter \ -oox \ -sal \ -salhelper \ -sax \ -sb \ -sc \ -sfx \ -sot \ -subsequenttest \ -svl \ -svt \ -svx \ -svxcore \ + cppu \ + sal \ + subsequenttest \ test \ -tk \ -tl \ -ucbhelper \ unotest \ -utl \ -vbahelper \ -vcl \ -xo \ )) $(eval $(call gb_CppunitTest_set_include,sc_cellcursorobj,\ --I$(SRCDIR)/sc/source/ui/inc \ --I$(SRCDIR)/sc/inc \ $$(INCLUDE) \ )) @@ -64,7 +35,7 @@ $(eval $(call gb_CppunitTest_use_ure,sc_cellcursorobj)) $(eval $(call gb_CppunitTest_use_vcl,sc_cellcursorobj)) $(eval $(call gb_CppunitTest_use_components,sc_cellcursorobj,\ -$(sc_unoapi_common_components) \ + $(sc_unoapi_common_components) \ )) $(eval $(call gb_CppunitTest_use_configuration,sc_cellcursorobj)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 77517, which changed state. Bug 77517 Summary: Function of reference to external file Error 504 https://bugs.documentfoundation.org/show_bug.cgi?id=77517 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118285] Ability to assign keyboard shortcut to special characters is provided only by a non-existent extension
https://bugs.documentfoundation.org/show_bug.cgi?id=118285 V Stuart Foote changed: What|Removed |Added Resolution|--- |INVALID CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- No, this is already done with macro assignments: 1. via an AutoText +F3 "macro" assignment, and "macro"+F3 replacement 2. or via Tools -> AutoCorrect -> AutoCorrect Options: Replace table entries (our method for emoji entry). 3. or via +X toggle of unicode glyph, e.g. U+00b6 -> +X => ¶ Also a bit GUI'ish, but the LibreOffice Special Character dialog is fully keyboard navigable and now includes reuse of Recent Characters (+r & ) and Favorite Characters (+v & ) Demise of OpenOffice.org Compose Special Characters extension is NOT OUR BUG => INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5e7b686b28a306f3a4c1782ef83ec7335281ffd9 Author: Tor Lillqvist Date: Thu Jun 21 08:10:24 2018 +0300 Updated core Project: dictionaries 846e5da4b28bb40158cfb992f3a371614e25a349 tdf#104332 (and others): Fix two thinkos in my recent commit Change-Id: I6908826572153daeee1211ea3796a6e4a0e007b2 Reviewed-on: https://gerrit.libreoffice.org/56217 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist diff --git a/dictionaries b/dictionaries index 2d8dd0af877d..846e5da4b28b 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 2d8dd0af877de8494ca9c2c027eba4a42bbc09eb +Subproject commit 846e5da4b28bb40158cfb992f3a371614e25a349 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: pt_BR/Lightproof.py pt_BR/pythonpath
pt_BR/Lightproof.py |2 +-
pt_BR/pythonpath/lightproof_impl_pt_BR.py |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 846e5da4b28bb40158cfb992f3a371614e25a349
Author: Tor Lillqvist
Date: Thu Jun 21 08:10:24 2018 +0300
tdf#104332 (and others): Fix two thinkos in my recent commit
Change-Id: I6908826572153daeee1211ea3796a6e4a0e007b2
Reviewed-on: https://gerrit.libreoffice.org/56217
Reviewed-by: Tor Lillqvist
Tested-by: Tor Lillqvist
diff --git a/pt_BR/Lightproof.py b/pt_BR/Lightproof.py
index cf0247d..0868693 100644
--- a/pt_BR/Lightproof.py
+++ b/pt_BR/Lightproof.py
@@ -67,7 +67,7 @@ class Lightproof( unohelper.Base, XProofreader, XServiceInfo,
XServiceName, XSer
if lightproof_impl_pt_BR.SMGR == None:
lightproof_impl_pt_BR.SMGR = currentContext.ServiceManager
lightproof_impl_pt_BR.spellchecker = \
-
lightproof_impl_en.SMGR.createInstanceWithContext("com.sun.star.linguistic2.SpellChecker",
currentContext)
+
lightproof_impl_pt_BR.SMGR.createInstanceWithContext("com.sun.star.linguistic2.SpellChecker",
currentContext)
lightproof_handler_pt_BR.load(currentContext)
aRes = uno.createUnoStruct(
"com.sun.star.linguistic2.ProofreadingResult" )
aRes.aDocumentIdentifier = nDocId
diff --git a/pt_BR/pythonpath/lightproof_impl_pt_BR.py
b/pt_BR/pythonpath/lightproof_impl_pt_BR.py
index 8611ee5..d3a72a1 100644
--- a/pt_BR/pythonpath/lightproof_impl_pt_BR.py
+++ b/pt_BR/pythonpath/lightproof_impl_pt_BR.py
@@ -29,6 +29,7 @@ suggestions = {}
# assign Calc functions
calcfunc = None
+SMGR = None
# check settings
def option(lang, opt):
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/uitest/goalSeek/tdf43693.py |2 +-
sc/source/core/tool/formularesult.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 708dbf3a170cfd0564f1d872f33c27806b83cafe
Author: Andrea Gelmini
Date: Wed Jun 20 23:41:46 2018 +0200
Fix typos
Change-Id: I6a42d683e2d4d2d8887822dc17ab2fd7f51982a5
Reviewed-on: https://gerrit.libreoffice.org/56210
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/sc/qa/uitest/goalSeek/tdf43693.py
b/sc/qa/uitest/goalSeek/tdf43693.py
index 991c91bbe46a..ade370e2b8fa 100644
--- a/sc/qa/uitest/goalSeek/tdf43693.py
+++ b/sc/qa/uitest/goalSeek/tdf43693.py
@@ -16,7 +16,7 @@ import pathlib
def get_url_for_data_file(file_name):
return
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
-#Bug 43693 - Goal Seek: reproducable crash using "target value search"
+#Bug 43693 - Goal Seek: reproducible crash using "target value search"
class tdf43693(UITestCase):
def test_tdf43693_goalSeek(self):
diff --git a/sc/source/core/tool/formularesult.cxx
b/sc/source/core/tool/formularesult.cxx
index ad10f51a36ba..2431713cffdf 100644
--- a/sc/source/core/tool/formularesult.cxx
+++ b/sc/source/core/tool/formularesult.cxx
@@ -275,7 +275,7 @@ inline bool isValue( formula::StackVar sv )
{
return sv == formula::svDouble || sv == formula::svError
|| sv == formula::svEmptyCell
-// The initial unitialized result value is double 0.0, even if the type
+// The initial uninitialized result value is double 0.0, even if the
type
// is unknown, so the interpreter asking for it gets that double
// instead of having to convert a string which may result in #VALUE!
// (otherwise the unknown would be neither error nor double nor string)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #32 from Tor Lillqvist --- https://gerrit.libreoffice.org/#/c/56217/ should fix it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332
--- Comment #31 from Tor Lillqvist ---
Ah! Yes, I forgot that thing. I guess in lightproof_impl_pt_BR.py , there needs
to be:
> calcfunc = None
>
> +SMGR = None
>
> # check settings
That's what I did when I first experimented with the smaller lightproof for en,
but I forgot with pt_BR.
I also now see that in pt_BR/Lightproof.py I accidentally use
lightproof_impl_en.SMGR.createInstanceWithContext("com.sun.star.linguistic2.SpellChecker",
currentContext) ...
Will fix.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107115] Not installed font 'Calibri Light' rendered different (and wrong) on Ubuntu compared to Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=107115 Jean-Baptiste Faure changed: What|Removed |Added Ever confirmed|0 |1 CC||jbfa...@libreoffice.org Status|UNCONFIRMED |NEW --- Comment #13 from Jean-Baptiste Faure --- Reproducible for me with LibreOffice 6.1.0.0.beta2+ under Ubuntu 16.04 x86-64: 1/ C fonts from Microsoft are not installed on my system 2/ alternative fonts Caladea and Carlito are installed 3/ opening the docx file with fonts embedded LO claims that Calibri is available (expected) but that Calibri Light is not, which is not expected if this font is really embedded in the docx. So it's clear that there is a problem with how LO recognize Calibri Light font and substitute it if needed. Set status to NEW. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93653] Strange behavior when pasting a cell in the formula bar
https://bugs.documentfoundation.org/show_bug.cgi?id=93653 --- Comment #7 from Nikos Platis --- (In reply to Nikos Platis from comment #6) > Still holds exactly as reported in Comment 4 Sorry, forgot to mention version: now on version 6.0.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93653] Strange behavior when pasting a cell in the formula bar
https://bugs.documentfoundation.org/show_bug.cgi?id=93653 --- Comment #6 from Nikos Platis --- Still holds exactly as reported in Comment 4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues
https://bugs.documentfoundation.org/show_bug.cgi?id=60251 Volga changed: What|Removed |Added Depends on||118287 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118287 [Bug 118287] LibreOffice should using native dialog box interface on Windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118287] LibreOffice should using native dialog box interface on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=118287 Volga changed: What|Removed |Added Blocks||60251 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=60251 [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118230] Replace... command does not remember order of alignment of elements after picture is placed
https://bugs.documentfoundation.org/show_bug.cgi?id=118230 --- Comment #4 from mwtjunkm...@gmail.com --- (In reply to Xisco Faulí from comment #3) > Regression introduced by: > > authorSamuel Mehrbrodt 2016-07-05 > 12:05:28 + > committer Samuel Mehrbrodt 2016-07-05 > 19:58:48 > + > commitfd6655080e181de4b78e31f13fe8ba35de8edfe5 (patch) > tree b132314cd39e107b818f057cda33c07e6e9f2e47 > parent28a03248b1d1649e157b788e43dfe8326f165379 (diff) > tdf#73742 Don't replace existing image when inserting one > If we want to replace an image, we have an entry in the context menu for > that. > > Bisected with: bibisect-linux-64-5.3 > > Adding Cc: to Samuel Mehrbrodt I'm not entirely sure, but I suspect you're missing the point. It's not the act of replacing the image that's the problem. It's where the replacement image lands in terms of the top-down order of items on the document. Currently, once the image is replaced, it always occupies the top-most position in the hierarchy rather than honoring the placement of the position of the picture which it replaced. That is the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118287] New: LibreOffice should using native dialog box interface on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=118287 Bug ID: 118287 Summary: LibreOffice should using native dialog box interface on Windows Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shanshandehongx...@outlook.com Description: Althrough LibreOffice is available Windows, the dialog window doesn't use native look as this: https://msdn.microsoft.com/dynimg/IC534161.png Since LibreOffice is using native GTK3 dialog interfaces on Linux, I think it's possible to make the same implementation on Windows. MSDN has documentations related to this: https://msdn.microsoft.com/en-us/library/windows/desktop/ff468823(v=vs.85).aspx Steps to Reproduce: - Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101796] Table as Autotext does not contain the table template informations
https://bugs.documentfoundation.org/show_bug.cgi?id=101796 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44390] UI: Input Line height not adapted for View Zoom
https://bugs.documentfoundation.org/show_bug.cgi?id=44390 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47953] "Error loading BASIC of document" error messages
https://bugs.documentfoundation.org/show_bug.cgi?id=47953 --- Comment #17 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108642] FILEOPEN: document with a complex table structure takes double the time to open when the sidebar is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=108642 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83739] EDITING: AutoText changes font
https://bugs.documentfoundation.org/show_bug.cgi?id=83739 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93653] Strange behavior when pasting a cell in the formula bar
https://bugs.documentfoundation.org/show_bug.cgi?id=93653 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94220] UI: Formula bar and cell edit show line break after hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=94220 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92136] 'Styles and Formatting'/Sidebar is empty with Formula bar
https://bugs.documentfoundation.org/show_bug.cgi?id=92136 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #51 from Xisco Faulí --- A polite ping, still working on this bug? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 66089] FORMATTING: Wrong currency (and number) format from file created with Excel (see comment #17 for instructions to reproduce!)
https://bugs.documentfoundation.org/show_bug.cgi?id=66089 Aron Budea changed: What|Removed |Added Hardware|Other |All Resolution|--- |FIXED CC||ba...@caesar.elte.hu Status|NEW |RESOLVED Assignee|libreoffice-b...@lists.free |ba...@caesar.elte.hu |desktop.org | --- Comment #23 from Aron Budea --- With the above commit the spreadsheet looks fine to me after the instructions in comment 17. Backport to 6.1 is in gerrit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/ui/view/output2.cxx | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) New commits: commit 5f3c08cf061ae9c6c4cad74e6671c41394f00630 Author: Marco Cecchetti Date: Thu Jun 14 12:32:48 2018 +0200 tdf#105720: lok: sc: currency symbol is displayed in the preceding cell Change-Id: I6175cfeab3d8bc3a757c8522aa9c7a7e49c4bf2b Reviewed-on: https://gerrit.libreoffice.org/55790 Reviewed-by: Marco Cecchetti Tested-by: Marco Cecchetti (cherry picked from commit 37210da00a9190f7765fa9c1e4a08629d2f4c2c4) Reviewed-on: https://gerrit.libreoffice.org/56214 Tested-by: Jenkins Reviewed-by: Aron Budea diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx index 60fa18819e16..9327f6cb856f 100644 --- a/sc/source/ui/view/output2.cxx +++ b/sc/source/ui/view/output2.cxx @@ -75,6 +75,7 @@ #include #include +#include #include #include @@ -566,13 +567,21 @@ void ScDrawStringsVars::RepeatToFill( long nColWidth ) if ( nRepeatPos == -1 || nRepeatPos > aString.getLength() ) return; +const bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive(); + long nCharWidth = pOutput->pFmtDevice->GetTextWidth(OUString(nRepeatChar)); -if ( nCharWidth < 1) return; + +if ( nCharWidth < 1 || (bIsTiledRendering && nCharWidth < TWIPS_PER_PIXEL)) return; + if (bPixelToLogic) nColWidth = pOutput->mpRefDevice->PixelToLogic(Size(nColWidth,0)).Width(); + // Are there restrictions on the cell type we should filter out here ? -long nSpaceToFill = ( nColWidth - aTextSize.Width() ); +long nTextWidth = aTextSize.Width(); +if ( bIsTiledRendering ) +nTextWidth = pOutput->mpRefDevice->PixelToLogic(Size(nTextWidth,0)).Width(); +long nSpaceToFill = ( nColWidth - nTextWidth ); if ( nSpaceToFill <= nCharWidth ) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112483] Impress Remote: Slide preview is blank
https://bugs.documentfoundation.org/show_bug.cgi?id=112483 --- Comment #13 from ver...@spid.com --- Confirmed with libreoffice 6.0.3.2 and Android 8.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118198] FORMATTING : can't validate or cancel a character to customize a bullet list
https://bugs.documentfoundation.org/show_bug.cgi?id=118198 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 CC||ba...@caesar.elte.hu Status|UNCONFIRMED |NEW --- Comment #1 from Aron Budea --- Thanks for the bug report. Confirmed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118195] FORMATTING : languages list not translated in the format cell dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=118195 Aron Budea changed: What|Removed |Added Component|Calc|LibreOffice Ever confirmed|0 |1 CC||ba...@caesar.elte.hu Status|UNCONFIRMED |NEW --- Comment #1 from Aron Budea --- Thanks for the bug report. Confirmed. Same in Writer's Format -> Character dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118197] FORMATTING : can't select Gradient, Pattern or Hatch in Format > Paragraph > Area
https://bugs.documentfoundation.org/show_bug.cgi?id=118197 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Component|Writer |LibreOffice Status|UNCONFIRMED |NEW --- Comment #1 from Aron Budea --- Thanks for the bug report. Confirmed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118196] FORMATTING : problem to select a color in the font colors list
https://bugs.documentfoundation.org/show_bug.cgi?id=118196 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Aron Budea --- Thanks for the bug report. Confirmed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118194] Missing translations in dialog boxes and menus in chart module
https://bugs.documentfoundation.org/show_bug.cgi?id=118194 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Component|LibreOffice |Calc Resolution|--- |WORKSFORME --- Comment #3 from Aron Budea --- Thanks for the bug report. Yes, this was an issue, but should be fixed with the next update. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105720] Left-aligned currency symbols in currency fields are displayed in the middle of the preceding cell (in some builds)
https://bugs.documentfoundation.org/show_bug.cgi?id=105720 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||089 Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |mrcek...@gmail.com |desktop.org | --- Comment #11 from Aron Budea --- It was interesting to see how this and bug 66089 had the same roots. Thanks for figuring out the original fix, Marco! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66089] FORMATTING: Wrong currency (and number) format from file created with Excel (see comment #17 for instructions to reproduce!)
https://bugs.documentfoundation.org/show_bug.cgi?id=66089 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5720 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 marcin_mail2...@yahoo.pl changed: What|Removed |Added Attachment #142986|Chart after ammendment |Chart after data add & description||X-axis range expand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 marcin_mail2...@yahoo.pl changed: What|Removed |Added Attachment #142985|Chart before data add & |Chart before data add & description|X-axis expand |X-axis range expand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 marcin_mail2...@yahoo.pl changed: What|Removed |Added Attachment #142985|Chart before ammendment |Chart before data add & description||X-axis expand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 --- Comment #4 from marcin_mail2...@yahoo.pl --- Created attachment 142987 --> https://bugs.documentfoundation.org/attachment.cgi?id=142987=edit Chart manually ammended after data expand This is how chart should look like. All I've done was manual movement of "PSR S970 release" flag to correct data (which shrinked on X-axis scale as soon as range has been expanded). Clue is to "anchor" such object (by context menu -> stick object to X-axis, for example), so each data manipulation should recalculate positioning of that object to according X-axis data. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 --- Comment #3 from marcin_mail2...@yahoo.pl --- Created attachment 142986 --> https://bugs.documentfoundation.org/attachment.cgi?id=142986=edit Chart after ammendment I have added more data (so data range has been expanded). See "PSR S970 release" flag - it points to some specific data, which now is bad - compare to previous (Before.png) chart and see positioning of this flag to PSR S950 first data point. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117661] Objects don't move at chart, when new data are added
https://bugs.documentfoundation.org/show_bug.cgi?id=117661 --- Comment #2 from marcin_mail2...@yahoo.pl --- Created attachment 142985 --> https://bugs.documentfoundation.org/attachment.cgi?id=142985=edit Chart before ammendment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118274] TABLE: Table styles should include table alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=118274 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Regina Henschel --- Currently the "table styles" in the Styles dialog are not styles in a technical sense, but they are table-templates. Such table-template is a set of cell formatting information, each of them for a special group of cells, e.g. the first row. Such cell formatting information contains a reference to a table cell style and a reference to a paragraph style. But the table template cannot have a reference to a table style. And the alignment information belongs to the element , not to the element . LibreOffice has only a rudimentary implementation of table-styles. It always writes the information as automatic-style, that is the way to write hard formatting. And if a file uses "true" table styles, LibreOffice does not understand it. The file format allows table styles as "true" styles, including inheritance and the possibility to use the same style for different tables. But LibreOffice has not implemented to use it. The UI will be tricky, because tables refer to two sources for their formatting, an element of family "table" and an element . So it is a valid request, to implement the use of true table styles. There exist bug 34391 about "table styles". But in fact the entire comments in it are about table templates. Therefore I think, it is better to keep this bug report for "true" table styles. A "true" table style is an element of family table as child element of element , in contrast to the current implementation as child of element . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118274] TABLE: Table styles should include table alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=118274 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Regina Henschel --- Currently the "table styles" in the Styles dialog are not styles in a technical sense, but they are table-templates. Such table-template is a set of cell formatting information, each of them for a special group of cells, e.g. the first row. Such cell formatting information contains a reference to a table cell style and a reference to a paragraph style. But the table template cannot have a reference to a table style. And the alignment information belongs to the element , not to the element . LibreOffice has only a rudimentary implementation of table-styles. It always writes the information as automatic-style, that is the way to write hard formatting. And if a file uses "true" table styles, LibreOffice does not understand it. The file format allows table styles as "true" styles, including inheritance and the possibility to use the same style for different tables. But LibreOffice has not implemented to use it. The UI will be tricky, because tables refer to two sources for their formatting, an element of family "table" and an element . So it is a valid request, to implement the use of true table styles. There exist bug 34391 about "table styles". But in fact the entire comments in it are about table templates. Therefore I think, it is better to keep this bug report for "true" table styles. A "true" table style is an element of family table as child element of element , in contrast to the current implementation as child of element . -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Bug 104442 depends on bug 64389, which changed state. Bug 64389 Summary: FILEOPEN Imported docx has arrows (drawing objects) with wrong position and orientation https://bugs.documentfoundation.org/show_bug.cgi?id=64389 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64389] FILEOPEN Imported docx has arrows (drawing objects) with wrong position and orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=64389 mmtsuchi changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #15 from mmtsuchi --- Hi, I have found a workaround: Create arrows with Microsoft Word. save .docx Open with LibreOffice writer. Use exclusively these arrows (copy-paste, move change colors) See attachment before. Regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64389] FILEOPEN Imported docx has arrows (drawing objects) with wrong position and orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=64389 mmtsuchi changed: What|Removed |Added CC||mm.tsu...@gmail.com --- Comment #14 from mmtsuchi --- Created attachment 142984 --> https://bugs.documentfoundation.org/attachment.cgi?id=142984=edit arrows by MSO and LibO The first blue arrows are created by Word 2016. Conserve positions . OK The second by LibreOffice 5.4.7.2. Arrows Positions go away each time you save .docx. The third are copy and paste from the first. Conserve positions . OK -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118286] New: The caret borders on the invisible and is unchangeable
https://bugs.documentfoundation.org/show_bug.cgi?id=118286 Bug ID: 118286 Summary: The caret borders on the invisible and is unchangeable Product: LibreOffice Version: 6.0.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: naj...@posteo.net On my system - Linux Mint Cinnamon, hiDPI - the caret in Writer is thin and consequently (at least given its colour) hard to see. My eyes could be better but I suspect many people will have the same problem. There is a GTK hack that affects the caret system-wide, but I do not wish to resort to that because I find the caret to be fine in all the other applications I use. My cate in SublimeText: https://imgur.com/a/HRPCEO9 My caret in my terminaL: https://imgur.com/a/iQDSKNK My - anemic! - caret in Writer: https://imgur.com/a/BI5rbkM Cf. bug #105415. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118283] Crash reports lack information since 6.1 beta1
https://bugs.documentfoundation.org/show_bug.cgi?id=118283 --- Comment #1 from Aron Budea --- Analyzing a 6.1 beta2 dump file with WinDbg produced correct backtrace with symbols, so the dump file should be fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118285] New: Ability to assign keyboard shortcut to special characters is provided only by a non-existent extension
https://bugs.documentfoundation.org/show_bug.cgi?id=118285 Bug ID: 118285 Summary: Ability to assign keyboard shortcut to special characters is provided only by a non-existent extension Product: LibreOffice Version: 6.0.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: naj...@posteo.net Microsoft Word allows me, helpfully, to assign, say, the paragraph mark to a keyboard shortcut. Writer - and the rest of LibreOffice, I think - do not. Apparently an extension provides the functionality. (See https://ask.libreoffice.org/en/question/7663/lo-writer-insert-special-characters-by-shortcut-keys/) It seems to me a poor show that one should have to rely upon an extension. Also - though perhaps a badly performing search mechanism is to blame - the extension appears no longer to exist. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118284] New: Disabling the obstructive table tool-tips is excessively hard
https://bugs.documentfoundation.org/show_bug.cgi?id=118284 Bug ID: 118284 Summary: Disabling the obstructive table tool-tips is excessively hard Product: LibreOffice Version: 6.0.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: naj...@posteo.net As some posts on the Internet testify, it is hard to disable tooltips and particularly the ones that get in one's way - for: do they not? - when working with tables in Writer. It turns out there is a solution - if one counts disabling all (or almost all?) LibreOffice tooltips as a solution. That solution involves finding the 'expert configuration' window, searching for 'tip', locating (visually) the 'office / common' section (or something like that), finding the 'help' boolean, and toggling to false. Surely, there ought to be an easier way to disable all tooltips and indeed, perhaps, to disable tooltips selectively. Addenda. The dark theme I am using made it hard to read some of the text in the about:config-ish window. Also: when working with a table earlier, LibreOffice had crashed and then, before I could go online - I was offline, on a train, at the time - it removed the window about submitting a bug report and replaced it with another. Still, all of these things are distinct from the issue that I report above. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118283] New: Crash reports lack information since 6.1 beta1
https://bugs.documentfoundation.org/show_bug.cgi?id=118283 Bug ID: 118283 Summary: Crash reports lack information since 6.1 beta1 Product: LibreOffice Version: 6.1.0.0.beta1+ Hardware: All OS: All Status: UNCONFIRMED Keywords: notBibisectable, regression Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 113285 The following crash reports were submitted using steps from bug 87, 64-bit build, OS is Windows 7: 6.1 beta1: http://crashreport.libreoffice.org/stats/crash_details/c9e01a6b-fdf1-4428-8fa6-40d7c79b6ad7 6.1 beta2: http://crashreport.libreoffice.org/stats/crash_details/75088ce5-2260-45d1-afd1-c7e8f5d0b283 Neither reports contain proper backtrace, additionally the beta2 crash report lacks symbol identification. Here's a proper crash report created with LO 6.0.4.2: http://crashreport.libreoffice.org/stats/crash_details/f0965b0f-2a3f-4641-a457-9b763b8ec0b1 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113285 [Bug 113285] [META] Crash report system bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113285] [META] Crash report system bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113285 Aron Budea changed: What|Removed |Added Depends on||118283 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118283 [Bug 118283] Crash reports lack information since 6.1 beta1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/filter/orcus/xmlcontext.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 2acaf22274068fbc4181120084aa372254e11686
Author: Markus Mohrhard
Date: Wed Jun 20 00:04:55 2018 +0200
push the data from the temporary storage to the document for XML source
Change-Id: I93d489ef9b3fa105db2d364ad9133a26d5366361
Reviewed-on: https://gerrit.libreoffice.org/56126
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
(cherry picked from commit ca49ed9c4342917ba616170e95d7614224a13a4b)
Reviewed-on: https://gerrit.libreoffice.org/56135
Reviewed-by: Eike Rathke
diff --git a/sc/source/filter/orcus/xmlcontext.cxx
b/sc/source/filter/orcus/xmlcontext.cxx
index 1e343ff57a38..5e97db9f84e9 100644
--- a/sc/source/filter/orcus/xmlcontext.cxx
+++ b/sc/source/filter/orcus/xmlcontext.cxx
@@ -289,6 +289,7 @@ void ScOrcusXMLContextImpl::importXML(const
ScOrcusImportXMLParam& rParam)
}
filter.read_file(path);
+aFactory.finalize();
}
catch (const std::exception&)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - svl/source
svl/source/numbers/zformat.cxx |8 +---
svl/source/numbers/zforscan.cxx |6 +++---
2 files changed, 4 insertions(+), 10 deletions(-)
New commits:
commit 57eec349eeb0cf7d0acdeff09daed5867385db4d
Author: Laurent BP
Date: Fri Jun 15 20:41:18 2018 +0200
tdf#117575 treat thousand sep with ? in integer part
'?' was missing when treating thousand separator
However, format with '?' in integer part are not
saved in ODF.
Change-Id: I1d684a31f800f10bf9a04babb0b9fec34e28e72a
Reviewed-on: https://gerrit.libreoffice.org/55901
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 062e0999c2b7923e463f1611204a63f0bb7b6404)
Reviewed-on: https://gerrit.libreoffice.org/56147
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index e24ef037f7ba..a863b984891d 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -4434,13 +4434,7 @@ bool SvNumberformat::ImpNumberFillWithThousands(
OUStringBuffer& sBuff, // numb
; // nothing
break;
case '?':
-// erAck: 2008-04-03T16:24+0200
-// Actually this currently isn't executed
-// because the format scanner in the context of
-// "?," doesn't generate a group separator but
-// a literal ',' character instead that is
-// inserted unconditionally. Should be changed
-// on some occasion.
+// replace thousand separator with blank
sBuff.insert(k, ' ');
break;
default:
diff --git a/svl/source/numbers/zforscan.cxx b/svl/source/numbers/zforscan.cxx
index 40b522d074a9..ea9e24236b4c 100644
--- a/svl/source/numbers/zforscan.cxx
+++ b/svl/source/numbers/zforscan.cxx
@@ -2070,8 +2070,8 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString&
rString )
}
}
else if (i > 0 && i < nStringsCnt-1 &&
- (cPre == '#' || cPre == '0') &&
- ((cNext = NextChar(i)) == '#' || cNext ==
'0')) // #,#
+ (cPre == '#' || cPre == '0' || cPre == '?')
&&
+ ((cNext = NextChar(i)) == '#' || cNext == '0'
|| cNext == '?')) // #,#
{
nPos = nPos + sStrArray[i].getLength();
if (!bThousand) // only once
@@ -2083,7 +2083,7 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString&
rString )
nResultStringsCnt--;
i++;
}
-else if (i > 0 && (cPre == '#' || cPre == '0')
+else if (i > 0 && (cPre == '#' || cPre == '0' || cPre
== '?')
&& PreviousType(i) == NF_SYMBOLTYPE_DIGIT
&& nThousand < FLAG_STANDARD_IN_FORMAT )
{ // #
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #30 from László Németh --- (In reply to Tor Lillqvist from comment #29) > I must confess I have no idea how to check whether the pt-BR Lightproof > works any longer after my change... Anybody? The lightproof_impl_pt_BR.py > and lightproof_pt_BR.py files are rather hard to understand. > > (I did try an equivalent change to the en Lightproof.py and that didn't > break it. But it would be nice to be able to double-check for pt-BR.) It seems, a lower case sentence starting word, ie. "uno" will be underlined by the pt-BR grammar checker. I started to check, there is a problem with the patch yet. I will fix tomorrow, if it's ok: Python exception: : module 'lightproof_impl_pt_BR' has no attribute 'SMGR', traceback follows File "/home/laci/libreoffice/instdir/share/extensions/dict-pt-BR/Lightproof.py", line 67, in doProofreading if lightproof_impl_pt_BR.SMGR == None: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/circle.png|binary icon-themes/colibre/cmd/32/circle_unfilled.png |binary icon-themes/colibre/cmd/32/circlearc.png |binary icon-themes/colibre/cmd/32/circlecut.png |binary icon-themes/colibre/cmd/32/circlecut_unfilled.png|binary icon-themes/colibre/cmd/32/circlepie.png |binary icon-themes/colibre/cmd/32/circlepie_unfilled.png|binary icon-themes/colibre/cmd/32/config.png|binary icon-themes/colibre/cmd/32/controlproperties.png |binary icon-themes/colibre/cmd/32/dbchangedesignmode.png|binary icon-themes/colibre/cmd/32/dbnewquery.png|binary icon-themes/colibre/cmd/32/dbqueryedit.png |binary icon-themes/colibre/cmd/32/linestyle.png |binary icon-themes/colibre/cmd/32/viewdatasourcebrowser.png |binary icon-themes/colibre_svg/cmd/32/circle.svg|1 + icon-themes/colibre_svg/cmd/32/circle_unfilled.svg |1 + icon-themes/colibre_svg/cmd/32/circlearc.svg |1 + icon-themes/colibre_svg/cmd/32/circlecut.svg |1 + icon-themes/colibre_svg/cmd/32/circlecut_unfilled.svg|1 + icon-themes/colibre_svg/cmd/32/circlepie.svg |1 + icon-themes/colibre_svg/cmd/32/circlepie_unfilled.svg|1 + icon-themes/colibre_svg/cmd/32/config.svg|1 + icon-themes/colibre_svg/cmd/32/controlproperties.svg |1 + icon-themes/colibre_svg/cmd/32/dbchangedesignmode.svg|1 + icon-themes/colibre_svg/cmd/32/dbnewquery.svg|1 + icon-themes/colibre_svg/cmd/32/dbqueryedit.svg |1 + icon-themes/colibre_svg/cmd/32/linestyle.svg |1 + icon-themes/colibre_svg/cmd/32/viewdatasourcebrowser.svg |1 + 28 files changed, 14 insertions(+) New commits: commit 48a58bb72eb936eb983ef6423b5a137119865fa8 Author: andreas kainz Date: Wed Jun 20 15:01:03 2018 +0200 Colibre icons: 32px update Change-Id: I08f53b7c2e961c249e5109641288ad6dc84af7d9 Reviewed-on: https://gerrit.libreoffice.org/56159 Tested-by: Jenkins Reviewed-by: andreas_kainz (cherry picked from commit f53a5dfae6d07ea314c5c742c7ceeb94e2066ac1) Reviewed-on: https://gerrit.libreoffice.org/56175 diff --git a/icon-themes/colibre/cmd/32/circle.png b/icon-themes/colibre/cmd/32/circle.png new file mode 100644 index ..6c3cec93032a Binary files /dev/null and b/icon-themes/colibre/cmd/32/circle.png differ diff --git a/icon-themes/colibre/cmd/32/circle_unfilled.png b/icon-themes/colibre/cmd/32/circle_unfilled.png new file mode 100644 index ..3e2c789d5f3b Binary files /dev/null and b/icon-themes/colibre/cmd/32/circle_unfilled.png differ diff --git a/icon-themes/colibre/cmd/32/circlearc.png b/icon-themes/colibre/cmd/32/circlearc.png new file mode 100644 index ..55db7b574efb Binary files /dev/null and b/icon-themes/colibre/cmd/32/circlearc.png differ diff --git a/icon-themes/colibre/cmd/32/circlecut.png b/icon-themes/colibre/cmd/32/circlecut.png new file mode 100644 index ..77ddd4065691 Binary files /dev/null and b/icon-themes/colibre/cmd/32/circlecut.png differ diff --git a/icon-themes/colibre/cmd/32/circlecut_unfilled.png b/icon-themes/colibre/cmd/32/circlecut_unfilled.png new file mode 100644 index ..9c65167df5f0 Binary files /dev/null and b/icon-themes/colibre/cmd/32/circlecut_unfilled.png differ diff --git a/icon-themes/colibre/cmd/32/circlepie.png b/icon-themes/colibre/cmd/32/circlepie.png new file mode 100644 index ..92ab997954bb Binary files /dev/null and b/icon-themes/colibre/cmd/32/circlepie.png differ diff --git a/icon-themes/colibre/cmd/32/circlepie_unfilled.png b/icon-themes/colibre/cmd/32/circlepie_unfilled.png new file mode 100644 index ..65935751aecf Binary files /dev/null and b/icon-themes/colibre/cmd/32/circlepie_unfilled.png differ diff --git a/icon-themes/colibre/cmd/32/config.png b/icon-themes/colibre/cmd/32/config.png new file mode 100644 index ..532cd1b80742 Binary files /dev/null and b/icon-themes/colibre/cmd/32/config.png differ diff --git a/icon-themes/colibre/cmd/32/controlproperties.png b/icon-themes/colibre/cmd/32/controlproperties.png new file mode 100644 index ..532cd1b80742 Binary files /dev/null and b/icon-themes/colibre/cmd/32/controlproperties.png differ diff --git a/icon-themes/colibre/cmd/32/dbchangedesignmode.png b/icon-themes/colibre/cmd/32/dbchangedesignmode.png new file mode 100644 index ..652dc417f9af Binary files /dev/null and b/icon-themes/colibre/cmd/32/dbchangedesignmode.png differ diff --git a/icon-themes/colibre/cmd/32/dbnewquery.png b/icon-themes/colibre/cmd/32/dbnewquery.png new file mode 100644 index ..f8d3a04befa4 Binary files /dev/null and b/icon-themes/colibre/cmd/32/dbnewquery.png differ diff --git
[Libreoffice-bugs] [Bug 118282] Undo using CTRL+Z isn't working properly; have to press it multiple times for a single undo
https://bugs.documentfoundation.org/show_bug.cgi?id=118282 Telesto changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #2 from Telesto --- Hardware failure -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118282] Undo using CTRL+Z isn't working properly; have to press it multiple times for a single undo
https://bugs.documentfoundation.org/show_bug.cgi?id=118282 --- Comment #1 from Telesto --- If the steps don't work: 7. Do a 'full' Undo/redo a few times by holding (CTRL+Y/CTRL+Z) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/formulacell.cxx | 34 ++
1 file changed, 30 insertions(+), 4 deletions(-)
New commits:
commit eb678c01d35a485b9f79009c126e296d9e811d36
Author: Eike Rathke
Date: Wed Jun 20 20:00:23 2018 +0200
Prepare for Excel's dirty circular references iteration behaviour
In which either convergence is detected or N iterations are
executed and the result is displayed no matter what. Which would
"do N iteration steps" but never detect non-convergence.
Enable that only with an additional option where the user
specifies s/he doesn't want to be informed of non-convergence
errors.
Change-Id: I3caba0c200e16514e39ea46d7f899afc05a5a2cc
Reviewed-on: https://gerrit.libreoffice.org/56183
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sc/source/core/data/formulacell.cxx
b/sc/source/core/data/formulacell.cxx
index 661b0940eaf6..2fd26955891c 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1622,12 +1622,15 @@ void ScFormulaCell::Interpret()
}
// Start at 1, init things.
rRecursionHelper.StartIteration();
-// Mark all cells being in iteration.
+// Mark all cells being in iteration. Reset results to
+// original values, formula cells have been interpreted
+// already, discard that step.
for (ScFormulaRecursionList::const_iterator aIter(
rRecursionHelper.GetIterationStart()); aIter !=
rRecursionHelper.GetIterationEnd(); ++aIter)
{
ScFormulaCell* pIterCell = (*aIter).pCell;
+pIterCell->aResult = (*aIter).aPreviousResult;
pIterCell->bIsIterCell = true;
}
}
@@ -1636,7 +1639,8 @@ void ScFormulaCell::Interpret()
for ( ; rRecursionHelper.GetIteration() <= nIterMax && !rDone;
rRecursionHelper.IncIteration())
{
-rDone = true;
+rDone = false;
+bool bFirst = true;
for ( ScFormulaRecursionList::iterator aIter(
rRecursionHelper.GetIterationStart()); aIter !=
rRecursionHelper.GetIterationEnd() &&
@@ -1652,7 +1656,15 @@ void ScFormulaCell::Interpret()
pIterCell->InterpretTail(
pDocument->GetNonThreadedContext(), SCITP_FROM_ITERATION);
pDocument->DecInterpretLevel();
}
-rDone = rDone && !pIterCell->IsDirtyOrInTableOpDirty();
+if (bFirst)
+{
+rDone = !pIterCell->IsDirtyOrInTableOpDirty();
+bFirst = false;
+}
+else if (rDone)
+{
+rDone = !pIterCell->IsDirtyOrInTableOpDirty();
+}
}
if (rRecursionHelper.IsInReturn())
{
@@ -1687,12 +1699,26 @@ void ScFormulaCell::Interpret()
pIterCell->bIsIterCell = false;
pIterCell->nSeenInIteration = 0;
pIterCell->bRunning = (*aIter).bOldRunning;
+pIterCell->ResetDirty();
+// The difference to Excel is that Excel does not
+// produce an error for non-convergence thus a
+// delta of 0.001 still works to execute the
+// maximum number of iterations and display the
+// results no matter if the result anywhere reached
+// near delta, but also never indicates whether the
+// result actually makes sense in case of
+// non-counter context. Calc does check the delta
+// in every case. If we wanted to support what
+// Excel does then add another option "indicate
+// non-convergence error" (default on) and execute
+// the following block only if set.
+#if 1
// If one cell didn't converge, all cells of this
// circular dependency don't, no matter whether
// single cells did.
-pIterCell->ResetDirty();
pIterCell->aResult.SetResultError(
FormulaError::NoConvergence);
pIterCell->bChanged = true;
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/formulacell.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 00b3007976f60bdf65fbe69e3f4f1613b477a059
Author: Eike Rathke
Date: Wed Jun 20 19:31:36 2018 +0200
Avoid side effects of additional Interpret() during iteration
... which could alter results if this formula cell again depends
on other formula cells in the circular reference(s).
Change-Id: I2b56902a71c0f16f9777507402ea004ae609bfbc
Reviewed-on: https://gerrit.libreoffice.org/56182
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sc/source/core/data/formulacell.cxx
b/sc/source/core/data/formulacell.cxx
index 615dccfce416..661b0940eaf6 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -2598,6 +2598,11 @@ bool ScFormulaCell::IsMultilineResult()
bool ScFormulaCell::NeedsInterpret() const
{
+if (bIsIterCell)
+// Shortcut to force return of current value and not enter Interpret()
+// as we're looping over all iteration cells.
+return false;
+
if (!IsDirtyOrInTableOpDirty())
return false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118282] New: Undo using CTRL+Z isn't working properly; have to press it multiple times for a single undo
https://bugs.documentfoundation.org/show_bug.cgi?id=118282 Bug ID: 118282 Summary: Undo using CTRL+Z isn't working properly; have to press it multiple times for a single undo Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Undo using CTRL+Z isn't working properly; have to press it multiple times for a single undo Steps to Reproduce: 1. Launch calc 2. Enter some text into a1-a3 3. Click on column A (CTRL+C) 4. Click on column C & paste using CTRL+V) 5. Click on column E & paste using CTRL+V) 6. Undo everything using CTRL+Z & and count the key presses Fine using Edit -> Undo Actual Results: Way to may keypresses needed Expected Results: Every CTR+Z key-press 1 step back Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.0.0.alpha0+ Build ID: 66effc66abb1356af0aa54a79a83b1aae53520e4 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-06-19_05:01:54 Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118281] New: Form control information for Text Box use 'cm' for units, not units as selected in other dialogs.
https://bugs.documentfoundation.org/show_bug.cgi?id=118281 Bug ID: 118281 Summary: Form control information for Text Box use 'cm' for units, not units as selected in other dialogs. Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: michael.tier...@gmail.com Description: When I open the "Controls" "Properties: Text Box" for a text box, the measurements for Position X, Position Y, Width, and Height are measured in 'cm' when all other aspects of the document are set for Inches. Yes, I don't doubt in the slightest that I might have missed a setting but I don't believe this is the case. The "Properties" sidebar showing the position in inches not cm. I'm choosing the component of LibreOffice because I can't tell where the report belongs. I've searched and not found any other like this. If I missed it, I'm sorry. Steps to Reproduce: 1. Create drawing document. 2. Insert a text field. 3. Right click on text field and choose "Control" Actual Results: Measurements in Metric. Expected Results: Measurements are based on a central setting. Reproducible: Always User Profile Reset: No Additional Info: If this is a duplicate, my apologies. If someone's interested, I can try to record my screen showing the sequence to reproduce. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118280] New: 6.1 beta2 starts with crash on empty profile (Windows, 64-bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=118280 Bug ID: 118280 Summary: 6.1 beta2 starts with crash on empty profile (Windows, 64-bit) Product: LibreOffice Version: 6.1.0.0.beta2+ Hardware: All OS: Windows (All) Status: UNCONFIRMED Keywords: regression Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: xiscofa...@libreoffice.org Delete user profile, and start LO. => "LibreOfficeDev has stopped working" Second start succeeds, and it works fine afterwards. The crash dump is in the wrong place, and the dump ini file needs to be fixed (DumpFile needs to include the path to the dump file), then it can be submitted: http://crashreport.libreoffice.org/stats/crash_details/1473a6a3-8acf-419e-b26f-c196228405be (not very useful, there seems to be another issue with crash report evaluation) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117543] Copying/pasting a page doesn't include the master page content when pasting to a new document
https://bugs.documentfoundation.org/show_bug.cgi?id=117543 --- Comment #2 from Telesto --- Created attachment 142983 --> https://bugs.documentfoundation.org/attachment.cgi?id=142983=edit Example file (In reply to Buovjaga from comment #1) > Attachment amnesia :) I should stick with descriptions instead of an example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117543] Copying/pasting a page doesn't include the master page content when pasting to a new document
https://bugs.documentfoundation.org/show_bug.cgi?id=117543 Telesto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105761] libreoffice-gtk3 causing longer time to open documents from file explorer on Ubuntu systems
https://bugs.documentfoundation.org/show_bug.cgi?id=105761 Jean-Baptiste Faure changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #11 from Jean-Baptiste Faure --- Do you still encounter this issue with the current LO version provided by Ubuntu PPA ? In my case with Ubuntu 16.04 I get the version 6.0.4. Status set to NEEDINFO, please set it back to UNCONFIRMED once requested informations are provided. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34391] FORMATTING: Implementing Table Styles
https://bugs.documentfoundation.org/show_bug.cgi?id=34391 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #24 from Dieter Praas --- Table styles are now part of writer. Open bugs and enhancements are collected in meta bug 107553. So I just want to ask, why this bug is still open? (just because I can't see a reason, but I'm sure there is one) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118279] New: No logo in Help -> About
https://bugs.documentfoundation.org/show_bug.cgi?id=118279 Bug ID: 118279 Summary: No logo in Help -> About Product: LibreOffice Version: 6.1.0.0.beta2+ Hardware: All OS: Windows (All) Status: UNCONFIRMED Keywords: regression Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Created attachment 142982 --> https://bugs.documentfoundation.org/attachment.cgi?id=142982=edit Screenshot Installed LibreOfficeDev_6.1.0.0.beta2_Win_x64.msi. There's no logo in Help -> About LibreOfficeDev -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118274] TABLE: Table styles should include table alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=118274 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval Summary|TABLE: Table styles don't |TABLE: Table styles should |include table alignment |include table alignment CC||libreoffice-ux-advise@lists ||.freedesktop.org Severity|normal |enhancement --- Comment #6 from Dieter Praas --- Now it's clear to me. I can confirm the observed behaviour. I think this is more an enhancement than a bug. I'm also not sure, if it is possible to add table alingment to table styles. So I don't want to change status to NEW. Perhaps some more experienced user knows more about it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118274] TABLE: Table styles should include table alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=118274 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval Summary|TABLE: Table styles don't |TABLE: Table styles should |include table alignment |include table alignment CC||libreoffice-ux-advise@lists ||.freedesktop.org Severity|normal |enhancement --- Comment #6 from Dieter Praas --- Now it's clear to me. I can confirm the observed behaviour. I think this is more an enhancement than a bug. I'm also not sure, if it is possible to add table alingment to table styles. So I don't want to change status to NEW. Perhaps some more experienced user knows more about it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105602] Extended help does not work in GtkToolButton items if the property "action_name" is set
https://bugs.documentfoundation.org/show_bug.cgi?id=105602 --- Comment #3 from Gabor Kelemen --- (In reply to Xisco Faulí from comment #2) > Hi Gabor, > Could you please explain how to display that ToolButton? > > OTOH, Do you still reproduce it on master ? Hi 2, Yes I still see it. 1, I'm not sure I understand the question. You can read in the .ui files these objects with the shortened HID are GtkToolButton objects, this is the common pattern here: (at code pointer [3] in comment#1) Displaying the actual HID of the items? See here: https://wiki.documentfoundation.org/Documentation/Understanding,_Authoring_and_Editing_Openoffice.org_Help/4#Determining_A_Help_ID You need to export HELP_DEBUG=TRUE in ~/.bashrc and restart your environment to show them in the extended tip bubble. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115816] Sidebar Gallery preview list box context menu has two Insert menu items
https://bugs.documentfoundation.org/show_bug.cgi?id=115816 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #3 from Caolán McNamara --- looks like these were always there, but disabled so hidden in the past, then when I enabled them there's the apparently duplicated entries, the last one is supposed to be a paste into the gallery. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118274] TABLE: Table styles don't include table alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=118274 --- Comment #5 from Phil Krylov --- I think that by step "3. Align center" you are setting center alignment for _paragraphs_ inside table cells (Format - Align - Centered), but what I meant by setting center alignment for table is "Table - Table Properties - Table - Alignment - Center". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104332] Thesaurus in the Tools menu causes it to open slowly the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=104332 --- Comment #29 from Tor Lillqvist --- I must confess I have no idea how to check whether the pt-BR Lightproof works any longer after my change... Anybody? The lightproof_impl_pt_BR.py and lightproof_pt_BR.py files are rather hard to understand. (I did try an equivalent change to the en Lightproof.py and that didn't break it. But it would be nice to be able to double-check for pt-BR.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/core/tool/formularesult.cxx |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 011a9d000e32ec55e9ef46237fc1f5a578f78f9b
Author: Eike Rathke
Date: Wed Jun 20 18:07:54 2018 +0200
Related: tdf#117049 treat yet unknown result as initial 0.0
For the first =A1+B1 in B1 with iterations the result could had
been #VALUE! depending on string conversion calculation settings.
Change-Id: I8d7a745d67ba7a20f7a66e8aa143642d08ea5111
Reviewed-on: https://gerrit.libreoffice.org/56173
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 93dcfa7ee157dd865f5d266d1f877014462eac72)
Reviewed-on: https://gerrit.libreoffice.org/56179
diff --git a/sc/source/core/tool/formularesult.cxx
b/sc/source/core/tool/formularesult.cxx
index c1ed01516113..ad10f51a36ba 100644
--- a/sc/source/core/tool/formularesult.cxx
+++ b/sc/source/core/tool/formularesult.cxx
@@ -274,7 +274,12 @@ namespace {
inline bool isValue( formula::StackVar sv )
{
return sv == formula::svDouble || sv == formula::svError
-|| sv == formula::svEmptyCell;
+|| sv == formula::svEmptyCell
+// The initial unitialized result value is double 0.0, even if the type
+// is unknown, so the interpreter asking for it gets that double
+// instead of having to convert a string which may result in #VALUE!
+// (otherwise the unknown would be neither error nor double nor string)
+|| sv == formula::svUnknown;
}
inline bool isString( formula::StackVar sv )
@@ -457,6 +462,8 @@ double ScFormulaResult::GetDouble() const
; // nothing
}
}
+// Note that we reach here also for the default ctor and
+// formula::svUnknown from GetType().
return 0.0;
}
if (mbEmpty)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/core/data/formulacell.cxx | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
New commits:
commit 8cbd64985af140b2afac6ea2fd3b9b93300f6f7c
Author: Eike Rathke
Date: Wed Jun 20 17:22:14 2018 +0200
Resolves: tdf#117049 do not re-interpret a single circular self-reference
... to not execute the calculation twice, which added an implicit
iteration step.
Change-Id: I943f770d32ebe84a8359f2f94c1f0bf5731b6f88
Reviewed-on: https://gerrit.libreoffice.org/56170
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 678f8ab7eb90f5b0dd99328957b21d11e3be68b4)
Reviewed-on: https://gerrit.libreoffice.org/56178
diff --git a/sc/source/core/data/formulacell.cxx
b/sc/source/core/data/formulacell.cxx
index e996b8c2318f..d20ea590441d 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1610,11 +1610,16 @@ void ScFormulaCell::Interpret()
else
{
bResumeIteration = false;
-// Close circle once.
-pDocument->IncInterpretLevel();
-rRecursionHelper.GetList().back().pCell->InterpretTail(
pDocument->GetNonThreadedContext(),
-
SCITP_CLOSE_ITERATION_CIRCLE);
-pDocument->DecInterpretLevel();
+// Close circle once. If 'this' is self-referencing only
+// (e.g. counter or self-adder) then it is already
+// implicitly closed.
+if (rRecursionHelper.GetList().size() > 1)
+{
+pDocument->IncInterpretLevel();
+rRecursionHelper.GetList().back().pCell->InterpretTail(
+pDocument->GetNonThreadedContext(),
SCITP_CLOSE_ITERATION_CIRCLE);
+pDocument->DecInterpretLevel();
+}
// Start at 1, init things.
rRecursionHelper.StartIteration();
// Mark all cells being in iteration.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118227] XML 2003 Excel import export filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=118227 --- Comment #2 from DM --- Two additional bugs. In the code at the bottom of this comment, if you open it (extension .xml) in LibreOffice it reads correctly, but now hit Save, close and reopen it, and you'll see the formatting has gone! There are in fact two issues with the XML it so saved - firstly it hasn't written the styles so the number formatting is lost (two decimals seems to be ok but not 3), and secondly it has skipped writing the formatted blank cell by using an index on the following one to assert its position, and this means the blank cell opens without formatting, which is incorrect, as it is very common to want formatted blank cells - the correct way to write it would be as Excel does as a Cell without the inner Data tag, i.e. Cheers, David http://www.w3.org/TR/REC-html40;>-1 -1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114451] Writer works not well while inserting large SVG file
https://bugs.documentfoundation.org/show_bug.cgi?id=114451 Telesto changed: What|Removed |Added Attachment #142981|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114451] Writer works not well while inserting large SVG file
https://bugs.documentfoundation.org/show_bug.cgi?id=114451 Telesto changed: What|Removed |Added Attachment #142980|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 202add7f817b6360956b5a41427ee83fa87b7a01
Author: Caolán McNamara
Date: Wed Jun 20 15:31:50 2018 +0100
show down arrow in GtkMenuButtons
Change-Id: I6468474110adfc477927f6d89b44e92d29384484
Reviewed-on: https://gerrit.libreoffice.org/56165
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 05035bb756ad..cb5ab02cee52 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -4708,6 +4708,13 @@ private:
}
if (gtk_button_get_use_underline(pButton) &&
!gtk_button_get_use_stock(pButton))
m_aMnemonicButtons.push_back(pButton);
+
+if (GTK_IS_MENU_BUTTON(pWidget))
+{
+gtk_button_set_image(pButton, gtk_image_new_from_icon_name
("pan-down-symbolic", GTK_ICON_SIZE_BUTTON));
+gtk_button_set_image_position(pButton, GTK_POS_RIGHT);
+gtk_button_set_always_show_image(pButton, true);
+}
}
else if (GTK_IS_LABEL(pWidget))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source cui/source extensions/source include/svtools include/svx sd/source svtools/source svx/source
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx |4 +-
cui/source/tabpages/tpcolor.cxx | 10 +++---
extensions/source/propctrlr/formcomponenthandler.cxx |5 +--
include/svtools/colrdlg.hxx |4 +-
include/svx/PaletteManager.hxx |2 -
include/svx/bmpmask.hxx |4 +-
sd/source/filter/html/pubdlg.cxx | 12 +++
sd/source/ui/slideshow/slideshowimpl.cxx |4 +-
svtools/source/dialogs/colrdlg.cxx | 16 --
svx/source/dialog/_bmpmask.cxx | 17 +--
svx/source/engine3d/float3d.cxx |5 +--
svx/source/tbxctrls/PaletteManager.cxx |6 +--
svx/source/tbxctrls/tbcontrl.cxx |2 -
13 files changed, 44 insertions(+), 47 deletions(-)
New commits:
commit b15244d526c285cd109f7195855409f698d0cdc0
Author: Caolán McNamara
Date: Wed Jun 20 14:15:01 2018 +0100
move SvColorDialog to welded arguments
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a
Reviewed-on: https://gerrit.libreoffice.org/56162
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
index 4ee5f75f6284..489a60a9343d 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
@@ -390,9 +390,9 @@ IMPL_LINK( ThreeD_SceneIllumination_TabPage,
ColorDialogHdl, Button*, pButton, v
bool bIsAmbientLight = (pButton==m_pBtn_AmbientLight_Color);
SvxColorListBox* pListBox = bIsAmbientLight ? m_pLB_AmbientLight.get() :
m_pLB_LightSource.get();
-SvColorDialog aColorDlg( this );
+SvColorDialog aColorDlg;
aColorDlg.SetColor( pListBox->GetSelectEntryColor() );
-if( aColorDlg.Execute() == RET_OK )
+if( aColorDlg.Execute(GetFrameWeld()) == RET_OK )
{
Color aColor( aColorDlg.GetColor());
lcl_selectColor( *pListBox, aColor );
diff --git a/cui/source/tabpages/tpcolor.cxx b/cui/source/tabpages/tpcolor.cxx
index 113d1f9fb8a8..724a075b22d5 100644
--- a/cui/source/tabpages/tpcolor.cxx
+++ b/cui/source/tabpages/tpcolor.cxx
@@ -388,14 +388,14 @@ IMPL_LINK_NOARG(SvxColorTabPage, ClickAddHdl_Impl,
weld::Button&, void)
IMPL_LINK_NOARG(SvxColorTabPage, ClickWorkOnHdl_Impl, weld::Button&, void)
{
-std::unique_ptr pColorDlg(new SvColorDialog(
GetParentDialog() ));
+SvColorDialog aColorDlg;
-pColorDlg->SetColor (aCurrentColor);
-pColorDlg->SetMode( svtools::ColorPickerMode::Modify );
+aColorDlg.SetColor (aCurrentColor);
+aColorDlg.SetMode( svtools::ColorPickerMode::Modify );
-if( pColorDlg->Execute() == RET_OK )
+if (aColorDlg.Execute(GetFrameWeld()) == RET_OK)
{
-Color aPreviewColor = pColorDlg->GetColor();
+Color aPreviewColor = aColorDlg.GetColor();
aCurrentColor = aPreviewColor;
UpdateColorValues( false );
// fill ItemSet and pass it on to XOut
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx
b/extensions/source/propctrlr/formcomponenthandler.cxx
index 62257da1efbf..48965b871eac 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -2842,11 +2842,12 @@ namespace pcr
{
::Color aColor;
OSL_VERIFY( impl_getPropertyValue_throw(
impl_getPropertyNameFromId_nothrow( _nColorPropertyId ) ) >>= aColor );
-SvColorDialog aColorDlg( impl_getDefaultDialogParent_nothrow() );
+SvColorDialog aColorDlg;
aColorDlg.SetColor( aColor );
_rClearBeforeDialog.clear();
-if ( !aColorDlg.Execute() )
+vcl::Window* pParent = impl_getDefaultDialogParent_nothrow();
+if (!aColorDlg.Execute(pParent ? pParent->GetFrameWeld() : nullptr))
return false;
_out_rNewValue <<= aColorDlg.GetColor();
diff --git a/include/svtools/colrdlg.hxx b/include/svtools/colrdlg.hxx
index 69def8510b35..3688e348f4a5 100644
--- a/include/svtools/colrdlg.hxx
+++ b/include/svtools/colrdlg.hxx
@@ -36,7 +36,7 @@ namespace svtools
class SVT_DLLPUBLIC SvColorDialog final
{
public:
-SvColorDialog( vcl::Window* pParent );
+SvColorDialog();
~SvColorDialog();
voidSetColor( const Color& rColor );
@@ -44,7 +44,7 @@ public:
voidSetMode( svtools::ColorPickerMode eMode );
-short Execute();
+short Execute(weld::Window* pParent);
private:
VclPtr mpParent;
diff --git a/include/svx/PaletteManager.hxx b/include/svx/PaletteManager.hxx
index d4b6fd1a2298..ed8f639374f3 100644
---
[Libreoffice-commits] core.git: Branch 'private/Ashod/cd-5.3-3.2_import_unloaded' - 12 commits - basctl/inc basic/source canvas/source chart2/CppunitTest_chart2_export.mk chart2/CppunitTest_chart2_imp
Rebased ref, commits from common ancestor:
commit 1fb42f8e8ecb0696c41c5d80e2d6a4ca521fd24d
Author: Ashod Nakashian
Date: Wed Jun 20 15:55:07 2018 -0400
vcl: remove swapping logic from GraphicObject to support lazy-loading
Change-Id: I286a9b6ee75f07744232771263c26579ad9653e7
diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx
index 822f37abb72b..00df8ee00042 100644
--- a/include/vcl/GraphicObject.hxx
+++ b/include/vcl/GraphicObject.hxx
@@ -173,30 +173,8 @@ class VCL_DLLPUBLIC GraphicObject
private:
Graphic maGraphic;
GraphicAttr maAttr;
-SizemaPrefSize;
-MapMode maPrefMapMode;
-sal_uLong mnSizeBytes;
-GraphicType meType;
-OUStringmaLink;
-Link maSwapStreamHdl;
OUStringmaUserData;
-std::unique_ptr mxSwapOutTimer;
std::unique_ptr mxSimpleCache;
-sal_uInt32 mnAnimationLoopCount;
-
-// a unique increasing ID to be able to say which data change is older
-sal_uLong mnDataChangeTimeStamp;
-
-boolmbAutoSwapped : 1;
-boolmbTransparent : 1;
-boolmbAnimated : 1;
-boolmbEPS : 1;
-boolmbIsInSwapIn: 1;
-boolmbIsInSwapOut : 1;
-
-voidVCL_DLLPRIVATE ImplAssignGraphicData();
-static void VCL_DLLPRIVATE ImplEnsureGraphicManager();
-voidVCL_DLLPRIVATE ImplAutoSwapIn();
boolVCL_DLLPRIVATE ImplGetCropParams(
OutputDevice* pOut,
@@ -299,12 +277,6 @@ private:
boolbEnlarge
) const;
-DECL_LINK( ImplAutoSwapOutHdl, Timer*, void );
-protected:
-
-SvStream* GetSwapStream() const;
-voidSetSwapState();
-
public:
GraphicObject();
GraphicObject( const Graphic& rGraphic );
@@ -316,12 +288,6 @@ public:
booloperator==( const GraphicObject& rCacheObj ) const;
booloperator!=( const GraphicObject& rCacheObj ) const
{ return !( *this == rCacheObj ); }
-boolHasSwapStreamHdl() const { return
maSwapStreamHdl.IsSet(); }
-voidSetSwapStreamHdl(const Link& rHdl);
-
-voidFireSwapInRequest();
-voidFireSwapOutRequest();
-
const Graphic& GetGraphic() const;
voidSetGraphic( const Graphic& rGraphic, const
GraphicObject* pCopyObj = nullptr);
voidSetGraphic( const Graphic& rGraphic, const
OUString& rLink );
@@ -361,11 +327,6 @@ public:
voidSetAttr( const GraphicAttr& rAttr );
const GraphicAttr& GetAttr() const { return maAttr; }
-boolHasLink() const { return !maLink.isEmpty(); }
-voidSetLink();
-voidSetLink( const OUString& rLink );
-const OUString& GetLink() const { return maLink; }
-
boolHasUserData() const { return
!maUserData.isEmpty(); }
voidSetUserData();
voidSetUserData( const OUString& rUserData );
@@ -373,14 +334,6 @@ public:
OString GetUniqueID() const;
-boolSwapOut();
-boolSwapOut( SvStream* pOStm );
-boolSwapIn();
-
-boolIsInSwapIn() const { return mbIsInSwapIn; }
-boolIsInSwapOut() const { return mbIsInSwapOut; }
-boolIsSwappedOut() const { return( mbAutoSwapped ||
maGraphic.IsSwapOut() ); }
-
GraphicType GetType() const;
SizeGetPrefSize() const;
MapMode GetPrefMapMode() const;
@@ -462,9 +415,6 @@ public:
double fTopCrop,
double fRightCrop,
double fBottomCrop) const;
-
-// read access
-sal_uLong GetDataChangeTimeStamp() const { return mnDataChangeTimeStamp; }
};
namespace vcl
diff --git a/svx/source/sdr/contact/viewcontactofgraphic.cxx
b/svx/source/sdr/contact/viewcontactofgraphic.cxx
index 89b763deb3ef..9e49fae47d7f 100644
--- a/svx/source/sdr/contact/viewcontactofgraphic.cxx
+++ b/svx/source/sdr/contact/viewcontactofgraphic.cxx
@@ -418,10 +418,6 @@ namespace sdr
// draft when swapped out
const GraphicObject& rGraphicObject =
GetGrafObject().GetGraphicObject();
-static bool bAllowReplacements(true);
-
-if(rGraphicObject.IsSwappedOut() && bAllowReplacements)
-return
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 02e5afcea007365714b57e09b079ad0acca6e99d
Author: Caolán McNamara
Date: Wed Jun 20 15:31:50 2018 +0100
show down arrow in GtkMenuButtons
Change-Id: I6468474110adfc477927f6d89b44e92d29384484
Reviewed-on: https://gerrit.libreoffice.org/56164
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 05035bb756ad..cb5ab02cee52 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -4708,6 +4708,13 @@ private:
}
if (gtk_button_get_use_underline(pButton) &&
!gtk_button_get_use_stock(pButton))
m_aMnemonicButtons.push_back(pButton);
+
+if (GTK_IS_MENU_BUTTON(pWidget))
+{
+gtk_button_set_image(pButton, gtk_image_new_from_icon_name
("pan-down-symbolic", GTK_ICON_SIZE_BUTTON));
+gtk_button_set_image_position(pButton, GTK_POS_RIGHT);
+gtk_button_set_always_show_image(pButton, true);
+}
}
else if (GTK_IS_LABEL(pWidget))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - dbaccess/source
dbaccess/source/ui/inc/UITools.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f2d2e3dc7ddccd490b6829310340942b710057e7
Author: Caolán McNamara
Date: Wed Jun 20 15:58:49 2018 +0100
Resolves: tdf#118120 RET_ALL shares same value as RET_HELP
Change-Id: I766c379171ac25eb9c1d8036e052fb8f2b4e1459
Reviewed-on: https://gerrit.libreoffice.org/56168
Tested-by: Jenkins
Reviewed-by: Julien Nabet
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/dbaccess/source/ui/inc/UITools.hxx
b/dbaccess/source/ui/inc/UITools.hxx
index cd8e5a877b1b..0c4ae7a85e64 100644
--- a/dbaccess/source/ui/inc/UITools.hxx
+++ b/dbaccess/source/ui/inc/UITools.hxx
@@ -28,7 +28,7 @@
#include
-#define RET_ALL 10
+#define RET_ALL 100
// we only need forward decl here
namespace com { namespace sun { namespace star {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86206] Exporting to SVG breaks dashed lines
https://bugs.documentfoundation.org/show_bug.cgi?id=86206 --- Comment #14 from kompilainenn <79045_79...@mail.ru> --- still repro in 6.1 beta 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105720] Left-aligned currency symbols in currency fields are displayed in the middle of the preceding cell (in some builds)
https://bugs.documentfoundation.org/show_bug.cgi?id=105720 --- Comment #10 from Commit Notification --- Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=93e9a3e2b545c853f53ffe28d2795f55ad29f304 tdf#66089 tdf#105720: only rely on bPixelToLogic It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66089] FORMATTING: Wrong currency (and number) format from file created with Excel (see comment #17 for instructions to reproduce!)
https://bugs.documentfoundation.org/show_bug.cgi?id=66089 --- Comment #22 from Commit Notification --- Aron Budea committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=93e9a3e2b545c853f53ffe28d2795f55ad29f304 tdf#66089 tdf#105720: only rely on bPixelToLogic It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/output2.cxx | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
New commits:
commit 93e9a3e2b545c853f53ffe28d2795f55ad29f304
Author: Aron Budea
Date: Wed Jun 20 17:52:13 2018 +0200
tdf#66089 tdf#105720: only rely on bPixelToLogic
Left-aligned currency symbols were put in preceding cells
sometimes, because fill width was calculated incorrectly.
Commit 37210da00a9190f7765fa9c1e4a08629d2f4c2c4 fixed the issue
for LOK, but the bug was still reproducible in Calc if setting
"Use printer metrics for text formatting" was enabled.
Change-Id: I6cf90493cbf98c5020acd5faf1d0f3cf2def5c25
Reviewed-on: https://gerrit.libreoffice.org/56172
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index bf10567aa2eb..ab6f0065d71c 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -75,7 +75,6 @@
#include
#include
-#include
#include
#include
@@ -567,19 +566,18 @@ void ScDrawStringsVars::RepeatToFill( long nColWidth )
if ( nRepeatPos == -1 || nRepeatPos > aString.getLength() )
return;
-const bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive();
-
long nCharWidth = pOutput->pFmtDevice->GetTextWidth(OUString(nRepeatChar));
-if ( nCharWidth < 1 || (bIsTiledRendering && nCharWidth <
TWIPS_PER_PIXEL)) return;
-
-if (bPixelToLogic)
-nColWidth =
pOutput->mpRefDevice->PixelToLogic(Size(nColWidth,0)).Width();
+if ( nCharWidth < 1 || (bPixelToLogic && nCharWidth <
pOutput->mpRefDevice->PixelToLogic(Size(1,0)).Width()) )
+return;
// Are there restrictions on the cell type we should filter out here ?
long nTextWidth = aTextSize.Width();
-if ( bIsTiledRendering )
+if ( bPixelToLogic )
+{
+nColWidth =
pOutput->mpRefDevice->PixelToLogic(Size(nColWidth,0)).Width();
nTextWidth =
pOutput->mpRefDevice->PixelToLogic(Size(nTextWidth,0)).Width();
+}
long nSpaceToFill = ( nColWidth - nTextWidth );
if ( nSpaceToFill <= nCharWidth )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66089] FORMATTING: Wrong currency (and number) format from file created with Excel (see comment #17 for instructions to reproduce!)
https://bugs.documentfoundation.org/show_bug.cgi?id=66089 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80219] FILESAVE: SVG loss some color after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=80219 --- Comment #14 from kompilainenn <79045_79...@mail.ru> --- still repro in LO 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115464] UI of export to PNG and JPG misleading for resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=115464 --- Comment #21 from ed...@gmx.fr --- A symmetrical yet clear layout would be 3 groups (i.e. 3 lockers) of two numbers: 1) physical size (width, height) with a toggle to keep aspect ratio fixed 2) pixel size (width, height) with a toggle to keep aspect ratio fixed 3) dpi (width, height) with a toggle to keep their ratio fixed In this way the user can choose what to fix, and what to control, and see immediately the outcome of the changes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43693] Goal Seek: reproducable crash using "target value search"
https://bugs.documentfoundation.org/show_bug.cgi?id=43693 --- Comment #8 from Commit Notification --- Zdeněk Crhonek committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b4c09401053ff6df8de9e839299ac26efa28b37 uitest Calc/Goal seek; tdf#37341 ; tdf#43693 It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43693] Goal Seek: reproducable crash using "target value search"
https://bugs.documentfoundation.org/show_bug.cgi?id=43693 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/Module_sc.mk sc/qa sc/UITest_goalSeek.mk
sc/Module_sc.mk |1
sc/UITest_goalSeek.mk | 20
sc/qa/uitest/calc_tests/data/goalSeek.ods |binary
sc/qa/uitest/calc_tests/data/tdf37341.ods |binary
sc/qa/uitest/calc_tests/data/tdf43693.ods |binary
sc/qa/uitest/goalSeek/goalSeek.py | 49 ++
sc/qa/uitest/goalSeek/tdf37341.py | 46
sc/qa/uitest/goalSeek/tdf43693.py | 46
sc/qa/uitest/solver/solver.py |3 -
9 files changed, 163 insertions(+), 2 deletions(-)
New commits:
commit 1b4c09401053ff6df8de9e839299ac26efa28b37
Author: Zdeněk Crhonek
Date: Wed Jun 20 20:03:26 2018 +0200
uitest Calc/Goal seek; tdf#37341 ; tdf#43693
Change-Id: Ib6416eec6245f22f49687437a466b1e5c6d60efb
Reviewed-on: https://gerrit.libreoffice.org/56181
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index e8e1bb5b2bfb..2474f08553fa 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -190,6 +190,7 @@ $(eval $(call gb_Module_add_uicheck_targets,sc,\
UITest_calc_tests4 \
UITest_statistics \
UITest_solver \
+ UITest_goalSeek \
))
endif
diff --git a/sc/UITest_goalSeek.mk b/sc/UITest_goalSeek.mk
new file mode 100644
index ..0990482e7fd2
--- /dev/null
+++ b/sc/UITest_goalSeek.mk
@@ -0,0 +1,20 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_UITest_UITest,goalSeek))
+
+$(eval $(call gb_UITest_add_modules,goalSeek,$(SRCDIR)/sc/qa/uitest,\
+ goalSeek/ \
+))
+
+$(eval $(call gb_UITest_set_defs,goalSeek, \
+TDOC="$(SRCDIR)/sc/qa/uitest/calc_tests/data" \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sc/qa/uitest/calc_tests/data/goalSeek.ods
b/sc/qa/uitest/calc_tests/data/goalSeek.ods
new file mode 100644
index ..fd78ec0197e4
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/goalSeek.ods differ
diff --git a/sc/qa/uitest/calc_tests/data/tdf37341.ods
b/sc/qa/uitest/calc_tests/data/tdf37341.ods
new file mode 100644
index ..d0f5024fb1ac
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf37341.ods differ
diff --git a/sc/qa/uitest/calc_tests/data/tdf43693.ods
b/sc/qa/uitest/calc_tests/data/tdf43693.ods
new file mode 100644
index ..501a07765e71
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf43693.ods differ
diff --git a/sc/qa/uitest/goalSeek/goalSeek.py
b/sc/qa/uitest/goalSeek/goalSeek.py
new file mode 100644
index ..59d8b894009d
--- /dev/null
+++ b/sc/qa/uitest/goalSeek/goalSeek.py
@@ -0,0 +1,49 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.debug import sleep
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+
+class goalSeek(UITestCase):
+def test_goalSeek(self):
+calc_doc =
self.ui_test.load_file(get_url_for_data_file("goalSeek.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B4"}))
+
self.ui_test.execute_modeless_dialog_through_command(".uno:GoalSeekDialog")
+xDialog = self.xUITest.getTopFocusWindow()
+xformulaedit = xDialog.getChild("formulaedit")
+xtarget = xDialog.getChild("target")
+xvaredit = xDialog.getChild("varedit")
+xtarget.executeAction("TYPE", mkPropertyValues({"TEXT":"15000"}))
+xvaredit.executeAction("TYPE", mkPropertyValues({"TEXT":"B1"}))
+xOKBtn = xDialog.getChild("ok")
+
+def handle_OK_dlg(dialog):
+print(dialog.getChildren())
+xYesButn = dialog.getChild("yes")
+self.ui_test.close_dialog_through_button(xYesButn)
+
+self.ui_test.execute_blocking_action(xOKBtn.executeAction,
args=('CLICK', ()),
+dialog_handler=handle_OK_dlg)
+#verify
+
[Libreoffice-bugs] [Bug 56691] Saving embedded .SVG Graphics in a document results in a zero sized .SVG file
https://bugs.documentfoundation.org/show_bug.cgi?id=56691 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||todven...@suomi24.fi, ||xiscofa...@libreoffice.org --- Comment #4 from kompilainenn <79045_79...@mail.ru> --- this really fixed for ODT/ODG formats. i checked it in LO 6.1 beta 2 but if you save image from DOCX to SVG, then Inkscape shows error about zero size of SVG file this bug didn't have any CC. I added you, men What do you think about this bug now? may be create a new different bug about export image to SVG from DOCX? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - desktop/CppunitTest_desktop_lokinit.mk desktop/qa
desktop/CppunitTest_desktop_lokinit.mk |2
desktop/qa/unit/desktop-lok-init.cxx | 99 -
2 files changed, 98 insertions(+), 3 deletions(-)
New commits:
commit 740e204b481a3d742ef7c240e081a9ddc45a11a2
Author: Jan Holesovsky
Date: Tue Jun 19 01:18:08 2018 +0200
lok: Unit test for passing table borders via jsonToPropertyValuesVector.
Change-Id: Iadc0d76a1903d76fcd84f316d4796cc1dec13277
Reviewed-on: https://gerrit.libreoffice.org/56150
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky
(cherry picked from commit f6b9e4a8d95f2987386e55f244a7f6ea00995b74)
Reviewed-on: https://gerrit.libreoffice.org/56205
Tested-by: Jan Holesovsky
diff --git a/desktop/CppunitTest_desktop_lokinit.mk
b/desktop/CppunitTest_desktop_lokinit.mk
index fb9e71bccfe2..502f0807075b 100644
--- a/desktop/CppunitTest_desktop_lokinit.mk
+++ b/desktop/CppunitTest_desktop_lokinit.mk
@@ -19,6 +19,8 @@ $(eval $(call
gb_CppunitTest_use_external,desktop_lok_init,boost_headers))
$(eval $(call gb_CppunitTest_use_sdk_api,desktop_lok_init))
+$(eval $(call gb_CppunitTest_use_ure,desktop_lok_init))
+
$(eval $(call gb_CppunitTest_set_include,desktop_lok_init,\
-I$(SRCDIR)/desktop/source/inc \
-I$(SRCDIR)/desktop/inc \
diff --git a/desktop/qa/unit/desktop-lok-init.cxx
b/desktop/qa/unit/desktop-lok-init.cxx
index fa751bb64eaa..180b95c33a6a 100644
--- a/desktop/qa/unit/desktop-lok-init.cxx
+++ b/desktop/qa/unit/desktop-lok-init.cxx
@@ -18,12 +18,13 @@
#include
#include
-#include
-#include
-#include
+#include
#include
+#include
+#include
+
using namespace css;
/// Unit tests for desktop/source/lib/init.cxx internals.
@@ -33,9 +34,11 @@ public:
LOKInitTest() {}
void testJsonToPropertyValues();
+void testJsonToPropertyValuesBorder();
CPPUNIT_TEST_SUITE(LOKInitTest);
CPPUNIT_TEST(testJsonToPropertyValues);
+CPPUNIT_TEST(testJsonToPropertyValuesBorder);
CPPUNIT_TEST_SUITE_END();
};
@@ -71,6 +74,96 @@ void LOKInitTest::testJsonToPropertyValues()
aArgs,
comphelper::containerToSequence(desktop::jsonToPropertyValuesVector(arguments)));
}
+void LOKInitTest::testJsonToPropertyValuesBorder()
+{
+const char arguments[]
+= "{"
+ "\"OuterBorder\": {"
+ "\"type\" : \"[]any\","
+ "\"value\" : ["
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 }"
+ "]"
+ "},"
+ "\"InnerBorder\":{"
+ "\"type\" : \"[]any\","
+ "\"value\" : ["
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" :
Minutes from the design meeting 2018-Jul-20
Present: Stuart, Heiko * Terminology Calc "Tools > Protect Spreadsheet" + https://bugs.documentfoundation.org/show_bug.cgi?id=113236 + "Protect Sheet Tabs" (Cor) + pro: documentation/help update is not so crucial + "Protect the Worksheet" or "Protect the Workbook" is used in Excel + "Lock Sheets" (Heiko) + pro: the icon is a lock + or "Freeze"? (Stuart) => let's go with "Protect Sheet Tabs" * "View > Grid Lines for Sheet" should work on all sheets + https://bugs.documentfoundation.org/show_bug.cgi?id=105560 + WF, as Tools > Options is the default and the view options toggles this (Heiko) + possible issue with saving, see comment 20 + Excel works on sheet level, so view > gridlines off works for the current sheet only => WF, new ticket for saving => another issue is that tools > options = hide are not overrridden by view > gridlines (on) => "show on colored cells" doesnt work too - maybe a difference between windows/linux or related to restart + weird control anyway with show/hide as one option merged with another (on colored cells) => default color is "Grid color", which cannot reset when changed * When in autocomplete jump to end of the word per cursor right instead of next cell + https://bugs.documentfoundation.org/show_bug.cgi?id=99615 + works smoothly only when we always go right on cursor right and never jump to next cell (Heiko) + WF; use F2 to exit autocompletion (Eike) + MSO works like what Eike describes => WF following Eike * Comma delimited numbers + https://bugs.documentfoundation.org/show_bug.cgi?id=39829 + Enhance "Detect special numbers" (Heiko) + Excel provides an "Advanced..." (Text Import Settings) dialog where delimiter can be modified + Excel doesnt remember any settings + see also tdf#117955 - input delimiter is not necessarily saved as settings on text import dialog will control + supposed workflow in LibreOffice is to select the langauge dependent on the input, e.g. German for 1,2;1,3 => WFM; we should update the preview when language is changed and perhaps we show in what settings a particular language results * Introduce shortcuts for indentation + https://bugs.documentfoundation.org/show_bug.cgi?id=101736 + alt+cmd/ctrl+5/6 + WF/Customize it, because this function is not so frequently used and we should save rare shortcuts (Heiko) + tab in MSO changes the indentation, backspace removes it (to zero) - there is no shortcut in LibO we insert a tabulator character (which is done per ctrl+tab in MSO) => WFM, customize it (Increment Indent Value, Decrement Indent Value) signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - desktop/CppunitTest_desktop_lokinit.mk desktop/inc desktop/Module_desktop.mk desktop/qa desktop/source
desktop/CppunitTest_desktop_lokinit.mk | 47 +++
desktop/Module_desktop.mk |1
desktop/inc/lib/init.hxx |6 ++
desktop/qa/unit/desktop-lok-init.cxx | 78 +
desktop/source/lib/init.cxx|2
5 files changed, 133 insertions(+), 1 deletion(-)
New commits:
commit fc5e70050a6a9abf4eec1688eae7d53db6816483
Author: Jan Holesovsky
Date: Tue Jun 19 00:00:05 2018 +0200
lok: Unit test for jsonToPropertyValuesVector.
Change-Id: I3e0623cc68838c650edbd03cc89bf3fcb8098ff8
Reviewed-on: https://gerrit.libreoffice.org/56149
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky
(cherry picked from commit 666edd059b360b38add0acd959ea7e2ab5c7c5fd)
Reviewed-on: https://gerrit.libreoffice.org/56204
Tested-by: Jan Holesovsky
diff --git a/desktop/CppunitTest_desktop_lokinit.mk
b/desktop/CppunitTest_desktop_lokinit.mk
new file mode 100644
index ..fb9e71bccfe2
--- /dev/null
+++ b/desktop/CppunitTest_desktop_lokinit.mk
@@ -0,0 +1,47 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,desktop_lok_init))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,desktop_lok_init, \
+desktop/qa/unit/desktop-lok-init \
+))
+
+$(eval $(call gb_CppunitTest_use_external,desktop_lok_init,boost_headers))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,desktop_lok_init))
+
+$(eval $(call gb_CppunitTest_set_include,desktop_lok_init,\
+-I$(SRCDIR)/desktop/source/inc \
+-I$(SRCDIR)/desktop/inc \
+$$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,desktop_lok_init, \
+comphelper \
+cppu \
+sal \
+sofficeapp \
+vcl \
+$(gb_UWINAPI) \
+))
+
+ifeq ($(OS),LINUX)
+$(eval $(call gb_CppunitTest_add_libs,desktop_lok_init,\
+-lm \
+-ldl \
+-lpthread \
+))
+endif
+
+$(eval $(call gb_CppunitTest_use_configuration,desktop_lok_init))
+
+# vim: set noet sw=4 ts=4:
diff --git a/desktop/Module_desktop.mk b/desktop/Module_desktop.mk
index e18b23126dff..12c5e53e0a1e 100644
--- a/desktop/Module_desktop.mk
+++ b/desktop/Module_desktop.mk
@@ -137,6 +137,7 @@ $(eval $(call gb_Module_add_check_targets,desktop, \
ifeq ($(OS),LINUX)
$(eval $(call gb_Module_add_check_targets,desktop, \
CppunitTest_desktop_lib \
+CppunitTest_desktop_lokinit \
))
endif
diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index 78b3437f4ef4..cb8afa899b76 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -16,9 +16,11 @@
#include
#include
+#include
#include
#include
#include
+#include
#include
#include
@@ -98,6 +100,10 @@ namespace desktop {
/// comma, like: Name1=Value1,Name2=Value2,Name3=Value3.
/// @param rOptions When extracted, the Param=Value is removed from it.
DESKTOP_DLLPUBLIC OUString extractParameter(OUString& aOptions, const
OUString& rName);
+
+/// Helper function to convert JSON to a vector of PropertyValues.
+/// Public to be unit-test-able.
+DESKTOP_DLLPUBLIC std::vector
jsonToPropertyValuesVector(const char* pJSON);
}
#endif
diff --git a/desktop/qa/unit/desktop-lok-init.cxx
b/desktop/qa/unit/desktop-lok-init.cxx
new file mode 100644
index ..fa751bb64eaa
--- /dev/null
+++ b/desktop/qa/unit/desktop-lok-init.cxx
@@ -0,0 +1,78 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+
+#include
+
+using namespace css;
+
+/// Unit tests for desktop/source/lib/init.cxx internals.
+class LOKInitTest : public ::CppUnit::TestFixture
+{
+public:
+LOKInitTest() {}
+
+void testJsonToPropertyValues();
+
+CPPUNIT_TEST_SUITE(LOKInitTest);
+CPPUNIT_TEST(testJsonToPropertyValues);
+CPPUNIT_TEST_SUITE_END();
+};
+
+namespace
+{
+void assertSequencesEqual(const uno::Sequence& expected,
+ const uno::Sequence& actual)
+{
+CPPUNIT_ASSERT_EQUAL_MESSAGE("The sequences should have the same length",
expected.getLength(),
+ actual.getLength());
+for (int i = 0; i < expected.getLength(); ++i)
+{
+
[Libreoffice-qa] Minutes from the design meeting 2018-Jul-20
Present: Stuart, Heiko * Terminology Calc "Tools > Protect Spreadsheet" + https://bugs.documentfoundation.org/show_bug.cgi?id=113236 + "Protect Sheet Tabs" (Cor) + pro: documentation/help update is not so crucial + "Protect the Worksheet" or "Protect the Workbook" is used in Excel + "Lock Sheets" (Heiko) + pro: the icon is a lock + or "Freeze"? (Stuart) => let's go with "Protect Sheet Tabs" * "View > Grid Lines for Sheet" should work on all sheets + https://bugs.documentfoundation.org/show_bug.cgi?id=105560 + WF, as Tools > Options is the default and the view options toggles this (Heiko) + possible issue with saving, see comment 20 + Excel works on sheet level, so view > gridlines off works for the current sheet only => WF, new ticket for saving => another issue is that tools > options = hide are not overrridden by view > gridlines (on) => "show on colored cells" doesnt work too - maybe a difference between windows/linux or related to restart + weird control anyway with show/hide as one option merged with another (on colored cells) => default color is "Grid color", which cannot reset when changed * When in autocomplete jump to end of the word per cursor right instead of next cell + https://bugs.documentfoundation.org/show_bug.cgi?id=99615 + works smoothly only when we always go right on cursor right and never jump to next cell (Heiko) + WF; use F2 to exit autocompletion (Eike) + MSO works like what Eike describes => WF following Eike * Comma delimited numbers + https://bugs.documentfoundation.org/show_bug.cgi?id=39829 + Enhance "Detect special numbers" (Heiko) + Excel provides an "Advanced..." (Text Import Settings) dialog where delimiter can be modified + Excel doesnt remember any settings + see also tdf#117955 - input delimiter is not necessarily saved as settings on text import dialog will control + supposed workflow in LibreOffice is to select the langauge dependent on the input, e.g. German for 1,2;1,3 => WFM; we should update the preview when language is changed and perhaps we show in what settings a particular language results * Introduce shortcuts for indentation + https://bugs.documentfoundation.org/show_bug.cgi?id=101736 + alt+cmd/ctrl+5/6 + WF/Customize it, because this function is not so frequently used and we should save rare shortcuts (Heiko) + tab in MSO changes the indentation, backspace removes it (to zero) - there is no shortcut in LibO we insert a tabulator character (which is done per ctrl+tab in MSO) => WFM, customize it (Increment Indent Value, Decrement Indent Value) signature.asc Description: OpenPGP digital signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - desktop/source
desktop/source/lib/init.cxx | 81 ++--
1 file changed, 78 insertions(+), 3 deletions(-)
New commits:
commit 705b6b1129d3595251ffcc5cbc003e0799a4edf6
Author: Henry Castro
Date: Mon Jun 18 08:28:40 2018 -0400
lokit: add jsonToUnoAny
Change-Id: I79c2fe22fe7f3a8daa121ecaa529b6bca3216bf3
Reviewed-on: https://gerrit.libreoffice.org/56032
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
(cherry picked from commit 87674a28893520eb8bb528c7e774a7ed926976cb)
Reviewed-on: https://gerrit.libreoffice.org/56203
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 34bb568b8a8e..df318560aacd 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -48,6 +48,9 @@
#include
#include
#include
+#include
+#include
+#include
#include
#include
#include
@@ -232,19 +235,79 @@ static OUString getAbsoluteURL(const char* pURL)
return OUString();
}
+static uno::Any jsonToUnoAny(const boost::property_tree::ptree& aTree)
+{
+uno::Any aAny;
+uno::Any aValue;
+sal_Int32 nFields;
+uno::TypeClass aTypeClass;
+uno::Reference< reflection::XIdlField > aField;
+boost::property_tree::ptree aNodeNull, aNodeValue, aNodeField;
+const std::string& rType = aTree.get("type", "");
+const std::string& rValue = aTree.get("value", "");
+uno::Sequence< uno::Reference< reflection::XIdlField > > aFields;
+uno::Reference< reflection:: XIdlClass > xIdlClass =
+
css::reflection::theCoreReflection::get(comphelper::getProcessComponentContext())->forName(OUString::fromUtf8(rType.c_str()));
+if (xIdlClass.is())
+{
+aTypeClass = xIdlClass->getTypeClass();
+xIdlClass->createObject(aAny);
+aFields = xIdlClass->getFields();
+nFields = aFields.getLength();
+aNodeValue = aTree.get_child("value", aNodeNull);
+if (nFields > 0 && aNodeValue != aNodeNull)
+{
+for (sal_Int32 itField = 0; itField < nFields; ++itField)
+{
+aField = aFields[itField];
+aNodeField =
aNodeValue.get_child(aField->getName().toUtf8().getStr(), aNodeNull);
+if (aNodeField != aNodeNull)
+{
+aValue = jsonToUnoAny(aNodeField);
+aField->set(aAny, aValue);
+}
+}
+}
+else if (!rValue.empty())
+{
+if (aTypeClass == uno::TypeClass_VOID)
+aAny.clear();
+else if (aTypeClass == uno::TypeClass_BYTE)
+aAny <<=
static_cast(OString(rValue.c_str()).toInt32());
+else if (aTypeClass == uno::TypeClass_BOOLEAN)
+aAny <<= OString(rValue.c_str()).toBoolean();
+else if (aTypeClass == uno::TypeClass_SHORT)
+aAny <<=
static_cast(OString(rValue.c_str()).toInt32());
+else if (aTypeClass == uno::TypeClass_UNSIGNED_SHORT)
+aAny <<=
static_cast(OString(rValue.c_str()).toUInt32());
+else if (aTypeClass == uno::TypeClass_LONG)
+aAny <<= OString(rValue.c_str()).toInt32();
+else if (aTypeClass == uno::TypeClass_UNSIGNED_LONG)
+aAny <<=
static_cast(OString(rValue.c_str()).toInt32());
+else if (aTypeClass == uno::TypeClass_FLOAT)
+aAny <<= OString(rValue.c_str()).toFloat();
+else if (aTypeClass == uno::TypeClass_DOUBLE)
+aAny <<= OString(rValue.c_str()).toDouble();
+else if (aTypeClass == uno::TypeClass_STRING)
+aAny <<= OUString::fromUtf8(rValue.c_str());
+}
+}
+return aAny;
+}
+
static std::vector jsonToPropertyValuesVector(const
char* pJSON)
{
std::vector aArguments;
if (pJSON && pJSON[0] != '\0')
{
-boost::property_tree::ptree aTree;
+boost::property_tree::ptree aTree, aNodeNull, aNodeValue;
std::stringstream aStream(pJSON);
boost::property_tree::read_json(aStream, aTree);
for (const auto& rPair : aTree)
{
-const std::string& rType = rPair.second.get("type");
-const std::string& rValue = rPair.second.get("value");
+const std::string& rType = rPair.second.get("type",
"");
+const std::string& rValue = rPair.second.get("value",
"");
beans::PropertyValue aValue;
aValue.Name = OUString::fromUtf8(rPair.first.c_str());
@@ -258,6 +321,18 @@ static std::vector
jsonToPropertyValuesVector(const char*
aValue.Value <<= OString(rValue.c_str()).toInt32();
else if (rType == "unsigned short")
aValue.Value <<=
static_cast(OString(rValue.c_str()).toUInt32());
+else if (rType == "[]any")
+{
+aNodeValue = rPair.second.get_child("value", aNodeNull);
+if (aNodeValue !=
[Libreoffice-commits] core.git: desktop/CppunitTest_desktop_lokinit.mk desktop/qa
desktop/CppunitTest_desktop_lokinit.mk |2
desktop/qa/unit/desktop-lok-init.cxx | 99 -
2 files changed, 98 insertions(+), 3 deletions(-)
New commits:
commit f6b9e4a8d95f2987386e55f244a7f6ea00995b74
Author: Jan Holesovsky
Date: Tue Jun 19 01:18:08 2018 +0200
lok: Unit test for passing table borders via jsonToPropertyValuesVector.
Change-Id: Iadc0d76a1903d76fcd84f316d4796cc1dec13277
Reviewed-on: https://gerrit.libreoffice.org/56150
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky
diff --git a/desktop/CppunitTest_desktop_lokinit.mk
b/desktop/CppunitTest_desktop_lokinit.mk
index fb9e71bccfe2..502f0807075b 100644
--- a/desktop/CppunitTest_desktop_lokinit.mk
+++ b/desktop/CppunitTest_desktop_lokinit.mk
@@ -19,6 +19,8 @@ $(eval $(call
gb_CppunitTest_use_external,desktop_lok_init,boost_headers))
$(eval $(call gb_CppunitTest_use_sdk_api,desktop_lok_init))
+$(eval $(call gb_CppunitTest_use_ure,desktop_lok_init))
+
$(eval $(call gb_CppunitTest_set_include,desktop_lok_init,\
-I$(SRCDIR)/desktop/source/inc \
-I$(SRCDIR)/desktop/inc \
diff --git a/desktop/qa/unit/desktop-lok-init.cxx
b/desktop/qa/unit/desktop-lok-init.cxx
index fa751bb64eaa..180b95c33a6a 100644
--- a/desktop/qa/unit/desktop-lok-init.cxx
+++ b/desktop/qa/unit/desktop-lok-init.cxx
@@ -18,12 +18,13 @@
#include
#include
-#include
-#include
-#include
+#include
#include
+#include
+#include
+
using namespace css;
/// Unit tests for desktop/source/lib/init.cxx internals.
@@ -33,9 +34,11 @@ public:
LOKInitTest() {}
void testJsonToPropertyValues();
+void testJsonToPropertyValuesBorder();
CPPUNIT_TEST_SUITE(LOKInitTest);
CPPUNIT_TEST(testJsonToPropertyValues);
+CPPUNIT_TEST(testJsonToPropertyValuesBorder);
CPPUNIT_TEST_SUITE_END();
};
@@ -71,6 +74,96 @@ void LOKInitTest::testJsonToPropertyValues()
aArgs,
comphelper::containerToSequence(desktop::jsonToPropertyValuesVector(arguments)));
}
+void LOKInitTest::testJsonToPropertyValuesBorder()
+{
+const char arguments[]
+= "{"
+ "\"OuterBorder\": {"
+ "\"type\" : \"[]any\","
+ "\"value\" : ["
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" : { \"type\" :
\"short\", \"value\" : 1 "
+ "}, \"LineDistance\" : { \"type\" : \"short\", \"value\" : 0 },
\"LineStyle\" : { "
+ "\"type\" : \"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" :
\"unsigned long\", "
+ "\"value\" : 1 } } },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 },"
+ "{ \"type\" : \"long\", \"value\" : 0 }"
+ "]"
+ "},"
+ "\"InnerBorder\":{"
+ "\"type\" : \"[]any\","
+ "\"value\" : ["
+ "{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" : {
\"Color\" : { \"type\" : "
+ "\"com.sun.star.util.Color\", \"value\" : 0 }, \"InnerLineWidth\" :
{ \"type\" : "
+ "\"short\", \"value\" : 0 }, \"OuterLineWidth\" :
