[Libreoffice-bugs] [Bug 53027] EDITING: dBase-Import-Wizard fails when trying to append DECIMAL(NUMERIC) and BOOLEAN data types
https://bugs.documentfoundation.org/show_bug.cgi?id=53027 Korrawit Pruegsanusak changed: What|Removed |Added Attachment #65021|application/x-download |application/pdf mime type|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/source
extras/source/autocorr/lang/tr/DocumentList.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 37d5bf82eae7e6d611879d1132b1f6fdafdeb9ed Author: Muhammet Kara AuthorDate: Fri Sep 7 16:29:08 2018 +0300 Commit: Muhammet Kara CommitDate: Sat Sep 8 07:54:50 2018 +0200 [tr][autocorr] Fix erroneous entries Change-Id: Iaded68785c50833aa998706b6840f86d99ffc17d Reviewed-on: https://gerrit.libreoffice.org/60155 Tested-by: Jenkins Reviewed-by: Muhammet Kara diff --git a/extras/source/autocorr/lang/tr/DocumentList.xml b/extras/source/autocorr/lang/tr/DocumentList.xml index 28440cdce5e2..965e5060e416 100644 --- a/extras/source/autocorr/lang/tr/DocumentList.xml +++ b/extras/source/autocorr/lang/tr/DocumentList.xml @@ -24,7 +24,7 @@ - + @@ -104,7 +104,7 @@ - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Google Code-in tasks
Hi! On Fri, 7 Sep 2018 at 17:30, wrote: > > * Google Code In for pre university students from 13 to 17 (Thorsten) >+ https://codein.withgoogle.com/ >+ organizations can apply between Sep/06-17 >+ we need agreement from mentors > + official categorization: "Code, Documentation/Training, > Outreach/Research, >Quality Assurance, or Design" >+ we have to prepare a list of bite-sized tasks; needed with the > application > Looks like we already have a list of some tasks which was made in 2015 - https://wiki.documentfoundation.org/Mentoring_Programs/Task_ideas_for_Google_Code-in Other tasks which might be used for Code-in - Build LibreOffice from source code on your machine Remove copy-paste codes (tdf#39593) Convert manual tests to automated UI tests (tdf#107501) Write a blog post explaining any ten reasons why our clang plug-in might cause a build failure when we upload our code to Jenkins (e.g. unused variables, unnecessary parentheses, redundant cast, etc.) Convert tests to python (tdf#97361, tdf#97362) Include Gerrit link in bibisect log (tdf#84479) In fact, I feel many other bugs in Bugzilla with keyword topicCleanup can be used as tasks for GCI. Regards, Saurav > + > https://developers.google.com/open-source/gci/resources/example-tasks >+ mentoring mostly from UX, QA, translation ? (Thorsten) > + if you think it is useful & have cycles > + can look into the sign-up myself. > AI: + discuss in the staff meeting (Sophie, Heiko, Xisco) > + deadline is the 17th. > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 119755] New: Get error message: "maximum number of columns per sheet" - in 64bit Calc on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=119755 Bug ID: 119755 Summary: Get error message: "maximum number of columns per sheet" - in 64bit Calc on Windows Product: LibreOffice Version: 6.1.0.3 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sverr...@gmail.com Description: Yesterday I edited a .xlsx file using MS Excel 2010 but when I try to open the file in Librecalc 6.1, I get error message/warning: " maximum number of columns per sheet" - in 64bit Calc on Windows Please fix in a permanent way. Compatibility is the key to success and vice versa. Cheers File/document libreoffice 6.1 open file problem with compatibility, MS Office (.xlsx) https://www.dropbox.com/s/tncfecovr8y1cs8/Meningsm%C3%A5linger-2017.xlsx?dl=0 Screenshot https://www.dropbox.com/s/wdompgcr2gv4afw/Open%20file%20warning.png?dl=0 C:\data\apps\libreOffice_db\bugs\problem - maximum columns https://bugs.documentfoundation.org/show_bug.cgi?id=116274 Steps to Reproduce: 1. Download file from dropbox 2. Open the file 3. You see? Please fix asap Actual Results: Get error/warning. Fix! Expected Results: Get error/warning. Fix! Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34303] PDF export location should have option in settings to set path of the original file, last path used for save/export/.. or home directory
https://bugs.documentfoundation.org/show_bug.cgi?id=34303 --- Comment #44 from putt1ck --- I think this is wider than PDF export and a bug that entered around 6.05. I've added a bug report on it https://bugs.documentfoundation.org/show_bug.cgi?id=119754 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119754] New: Save as & PDF export no longer uses current doc location as starting point
https://bugs.documentfoundation.org/show_bug.cgi?id=119754 Bug ID: 119754 Summary: Save as & PDF export no longer uses current doc location as starting point Product: LibreOffice Version: 6.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cputt...@gmail.com Since v6.05 or close, document "save as" and PDF export fail to use current doc location as the starting point, reverting to user home directory as a starting point. I noticed this change ~2 months ago, but put it down to a blip as I use Tumbleweed. However it has persisted through several update cycles and is still present in LO 6.1.0.3. Cannot confirm which version the bug arrived in but see comment linked below referencing 6.0.5; this matches, give or take, the release history of LibreOffice in Tumbleweed i.e. I'd look there for the regression. https://ask.libreoffice.org/en/question/37405/make-libreoffice-remember-last-default-location/ Also seems related to recent comments on https://bugs.documentfoundation.org/show_bug.cgi?id=34303 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107495] An explicitly enabled contextual toolbar is always closing after exiting its contextual state
https://bugs.documentfoundation.org/show_bug.cgi?id=107495 V Stuart Foote changed: What|Removed |Added CC||perie_...@hotmail.com --- Comment #8 from V Stuart Foote --- *** Bug 119741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119741] Missing Text Formatting Toolbar even if I have locked it
https://bugs.documentfoundation.org/show_bug.cgi?id=119741 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3240 --- Comment #2 from V Stuart Foote --- The Text Formatting toolbar is "contextual" and contextsensitive, such that when the text in a Draw Text Box does not have focus--the toolbar will close. That is the correct UI behavior of a contextsensitive control. Valid enhancement to be able to selectively pin contextsensitive toolbar visible (that is the see also bug 103240) otherwise this is a duplicate of bug 107495 *** This bug has been marked as a duplicate of bug 107495 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103240] Modify toolbar state in Customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=103240 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9741 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118884] Unary/Binary Operators glyph rendering initially misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=118884 --- Comment #8 from Jan-Marek Glogowski --- And https://gerrit.libreoffice.org/#/c/60092/ is just cleanup patch to get rid of a now duplicated HFONT life-cycle management. The original version had a bug. I couldn't debug it, because of a memory corruption unrelated to my patch, with very "funny" failing assertions. That resulted in https://gerrit.libreoffice.org/#/c/60162/. I just found two occurrences directly related to my failing unit test, but some grep found more and reviewing more code around the first hits revealed a lot more. And this is just the result from a straight-forward grep over the code base. Who knows how many of these std:unique_ptr<...[]> array delete[] bugs are still there undetected. I'm just wondering why none of our static analysis tool-chains caught these earlier... build without online-updater? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118884] Unary/Binary Operators glyph rendering initially misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=118884 --- Comment #7 from Jan-Marek Glogowski --- The primary fix is https://gerrit.libreoffice.org/#/c/60091/. I'm not sure why the old code was working at all. The problem was the completely ignored nFallbackLevel of the glyphs. For the rendering of the symbols, we do 1. set fallback 0 font OpenSymbol 2. set current scale factor to font 0 3. we render the glyphs to the cache 1. sets fallback 1 some normal font, as we can't render normal text with the Symbol font 2. set current scale factor to font 1 now we ask for the glyph bounding boxes of our symbols The old code was wrong here, as it 1. used the wrong "current scale" 2. ignored the fallback level of the glyphs This is why the glyph were rendered correct, but overlapping, because the non-Symbol fonts characters with the same glyph id are overall not so width. Sometimes you were able to get the correct symbol rendered in the math window, but when you moved the cursor in the editor to the different parts of the formular, you could see the highlight frame was smaller then the glyph. Took me a while to figure all this out... This global "current scale factor" was always wrong. Probably before we were lucky and didn't get a fallback font. I don't know. So the patch moves the scaling factor to the font object, where it belongs - no more global var. And now, when we ask for the glyph bounding boxes, we check for the glyphs' fallback level, eventually change the font and use the correct scaling to get the correct bounding box. https://gerrit.libreoffice.org/#/c/60093/ might also be a fix. Font lookup depends on the SalGraphics in strange way and not just the HDC (look at ImplDoSetFont). At least this moves the real lookup into the LogicalFontInstance, where it belongs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119750] Failure to install
https://bugs.documentfoundation.org/show_bug.cgi?id=119750 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Version|unspecified |6.1.0.3 release Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Component|Base|Installation --- Comment #1 from V Stuart Foote --- We would need a verbose installation log. And, as LibreOffice installation on Widnows requires changes to the registry and installation of fonts to the Windows system folders--it *must* be "run as administrator" with UAC acknowledgement. To capture logging, run the installation from an Administrator CMD window or PowerShell window. The use the command line to do the install: "msiexec.exe /i LibreOffice_6.1.0.3_Win_x64.msi /L*v lo610installLog.txt" if you still have issues with permissions or with the install, ZIP up the log and post it. If you can not, please close this issue, as there is nothing actionable currently. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 --- Comment #21 from opensuse.lietuviu.ka...@gmail.com --- Created attachment 144749 --> https://bugs.documentfoundation.org/attachment.cgi?id=144749=edit Proproduced in 6.2.0.0.alpha0+ 9a9b81c7212fa6a6762246593acf3f1950677a22 2018-09-07_22:32:07 (In reply to Buovjaga from comment #19) > Can you repro on master (6.2)? Yes, I can reproduce in Version: 6.2.0.0.alpha0+ Build ID: 9a9b81c7212fa6a6762246593acf3f1950677a22 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: kde4; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-07_22:32:07 Locale: lt-LT (lt_LT.UTF-8); Calc: threaded with http://bugs.documentfoundation.org/attachment.cgi?id=144165 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119753] Highlighted text magically expands to new text without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=119753 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not confirm on Windows 10 Pro 64-bit en-US with Version: 6.1.0.3 (x64) Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 8; OS: Windows 10.0; UI render: GL; Locale: en-US (en_US); Calc: group threaded Selecting a word at end of paragraph and applying highlighting from Standard Toolbar. Typing a space receives the highlighting. Selecting some of the text run and from context menu Character dialog -> Highlighting apply none to remove the direct formatting, adding additional text to the highlighted run continues it and spaces *are* highlighted. Deleting the space back to the direct formatted highlighted run and adding a space back does not pick up the DF. Same in current master/6.2.0 build. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 --- Comment #20 from opensuse.lietuviu.ka...@gmail.com --- @Buovjaga Did you tried to open http://bugs.documentfoundation.org/attachment.cgi?id=144165 as uploaded in comment#17 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119752] Cox tech support
https://bugs.documentfoundation.org/show_bug.cgi?id=119752 V Stuart Foote changed: What|Removed |Added Resolution|--- |INVALID CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119731] Calc: Not Suitable Group and Ungroup Icon Representation
https://bugs.documentfoundation.org/show_bug.cgi?id=119731 --- Comment #3 from Rizal Muttaqin --- Created attachment 144748 --> https://bugs.documentfoundation.org/attachment.cgi?id=144748=edit These icons are my proposal for Calc's Group and Ungroup function -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/filter/eppt/pptx-animations.cxx | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
New commits:
commit 22f49d10c001f9d62e3783872bc7e53a902265a3
Author: Mark Hung
AuthorDate: Fri Sep 7 06:26:53 2018 +0800
Commit: Mark Hung
CommitDate: Sat Sep 8 06:04:51 2018 +0200
sd / pptx export: use extracted ooxml node type.
Prefer extracted node type over XAnimationNode->getType(),
as the later has been converted to former and unknown
condition filtered.
As the switch-case statements use ooxml node type now,
all kown node types are handled. Hence returning early
for unkown case isn't necessary and is removed.
That also fix unrestored mpConetxt in 9a9b81c7212f because
of returning early.
Change-Id: I614dcaa5b0ce32b19c396d0eab4499c1d67fa059
Reviewed-on: https://gerrit.libreoffice.org/60139
Tested-by: Jenkins
Reviewed-by: Mark Hung
diff --git a/sd/source/filter/eppt/pptx-animations.cxx
b/sd/source/filter/eppt/pptx-animations.cxx
index 42cec71e09e1..86fd90362af7 100644
--- a/sd/source/filter/eppt/pptx-animations.cxx
+++ b/sd/source/filter/eppt/pptx-animations.cxx
@@ -1147,35 +1147,32 @@ void PPTXAnimationExport::WriteAnimationNode(const
NodeContextPtr& pContext)
SAL_INFO("sd.eppt", "export node type: " << rXNode->getType());
sal_Int32 xmlNodeType = extractNodeType(rXNode);
-if (xmlNodeType == -1)
-return;
-
-switch (rXNode->getType())
+switch (xmlNodeType)
{
-case AnimationNodeType::ITERATE:
-case AnimationNodeType::PAR:
+case XML_par:
mpFS->startElementNS(XML_p, xmlNodeType, FSEND);
WriteAnimationNodeCommonPropsStart();
mpFS->endElementNS(XML_p, xmlNodeType);
break;
-case AnimationNodeType::SEQ:
+case XML_seq:
WriteAnimationNodeSeq();
break;
-case AnimationNodeType::ANIMATETRANSFORM:
-case AnimationNodeType::ANIMATE:
-case AnimationNodeType::ANIMATEMOTION:
-case AnimationNodeType::ANIMATECOLOR:
-case AnimationNodeType::SET:
+case XML_animScale:
+case XML_animRot:
+case XML_anim:
+case XML_animMotion:
+case XML_animClr:
+case XML_set:
WriteAnimationNodeAnimate(xmlNodeType);
break;
-case AnimationNodeType::TRANSITIONFILTER:
+case XML_animEffect:
WriteAnimationNodeEffect();
break;
-case AnimationNodeType::COMMAND:
+case XML_cmd:
WriteAnimationNodeCommand();
break;
default:
-SAL_WARN("sd.eppt", "unhandled animation node: " <<
rXNode->getType());
+SAL_WARN("sd.eppt", "export ooxml node type: " << xmlNodeType);
break;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 109791] Character name is not static
https://bugs.documentfoundation.org/show_bug.cgi?id=109791 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8304 CC||vstuart.fo...@utsa.edu Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from V Stuart Foote --- pretty sure this was also fixed for scaling the dialog by Caolán's "reselect current glyph on changing font" http://cgit.freedesktop.org/libreoffice/core/commit/?id=e8bf2cb72dbe55f4e9ac7ace48e644a934cfc503 for see also bug 118304 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109232 Bug 109232 depends on bug 109791, which changed state. Bug 109791 Summary: Character name is not static https://bugs.documentfoundation.org/show_bug.cgi?id=109791 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118304] Preview glyph and charmap of selected Unicodepoint does not behave when changing to a font without coverage of the codepoint
https://bugs.documentfoundation.org/show_bug.cgi?id=118304 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||9791 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112147] Smaller number of columns in special character group button
https://bugs.documentfoundation.org/show_bug.cgi?id=112147 V Stuart Foote changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from V Stuart Foote --- This is correct now, both the Favorites and the Recent characters are in the same 6 x 2 grid. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109232] [META] Special character dialog and toolbar group button bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109232 Bug 109232 depends on bug 112147, which changed state. Bug 112147 Summary: Smaller number of columns in special character group button https://bugs.documentfoundation.org/show_bug.cgi?id=112147 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119302] Wrong rendering of math formulas with scalable brackets in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119302 V Stuart Foote changed: What|Removed |Added CC||khaledho...@eglug.org, ||vstuart.fo...@utsa.edu --- Comment #12 from V Stuart Foote --- these two commits as in 9a9b81c7212fa6a6762246593acf3f1950677a22 seem to complete the fix, stamping of the glyph into the calculated nodes are now accurate. https://gerrit.libreoffice.org/#/c/60092/ https://gerrit.libreoffice.org/#/c/60093/ while for the prior days be5e7fed5f8dc4ba95b890d8b364a8be97fa2739 build with just https://gerrit.libreoffice.org/#/c/60091/ the scalable bracket glyphs were not correctly positioned into their sm node. =-testing-= Windows 10 Pro 64-bit en-US with Version: 6.2.0.0.alpha0+ (x64) Build ID: 9a9b81c7212fa6a6762246593acf3f1950677a22 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-07_23:40:38 Locale: en-US (en_US); Calc: threaded Version: 6.2.0.0.alpha0+ (x64) Build ID: be5e7fed5f8dc4ba95b890d8b364a8be97fa2739 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-07_03:18:06 Locale: en-US (en_US); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118884] Unary/Binary Operators glyph rendering initially misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=118884 V Stuart Foote changed: What|Removed |Added CC||glo...@fbihome.de, ||khaledho...@eglug.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9302 Blocks||117936 --- Comment #6 from V Stuart Foote --- A notable improvement on Windows build 2018-09-08 vs 2018-09-07 - the sm nodes are no longer chaotic when moving the Elements drop list up and down its panels. With the 9a9b81c7212fa6a6762246593acf3f1950677a22 build, all the nodes are now well proportioned and placed. The see also bug 119302 for the scalable brackets is also better with the 9a9b81c7212fa6a6762246593acf3f1950677a22 build Seems fixed... =-ref-= Testing Windows 10 Pro 64-bit en-US with Version: 6.2.0.0.alpha0+ (x64) Build ID: 9a9b81c7212fa6a6762246593acf3f1950677a22 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-07_23:40:38 Locale: en-US (en_US); Calc: threaded compared to same with Version: 6.2.0.0.alpha0+ (x64) Build ID: be5e7fed5f8dc4ba95b890d8b364a8be97fa2739 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-07_03:18:06 Locale: en-US (en_US); Calc: threaded these two commits are in 9a9b81c7212fa6a6762246593acf3f1950677a22 https://gerrit.libreoffice.org/#/c/60092/ https://gerrit.libreoffice.org/#/c/60093/ This earlier commit was in be5e7fed5f8dc4ba95b890d8b364a8be97fa2739, but the sm nodes there were not fully stable https://gerrit.libreoffice.org/#/c/60091/ Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117936 [Bug 117936] [META] Refactor CommonSalLayout font handling regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117936] [META] Refactor CommonSalLayout font handling regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=117936 V Stuart Foote changed: What|Removed |Added Depends on||118884 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118884 [Bug 118884] Unary/Binary Operators glyph rendering initially misplaced -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119302] Wrong rendering of math formulas with scalable brackets in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119302 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8884 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42768] FILESAVE: when I make changes to a text in .doc format (or when transforming .odt into a .doc) and I reopen the file, footnotes and italics are not respected (or go mad,
https://bugs.documentfoundation.org/show_bug.cgi?id=42768 --- Comment #19 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108358] search bar is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=108358 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112214] BASE, Form Editor: changing width or height of a control does not set save status to changed, thus no prompt for saving is triggered
https://bugs.documentfoundation.org/show_bug.cgi?id=112214 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109791] Character name is not static
https://bugs.documentfoundation.org/show_bug.cgi?id=109791 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109215] Keyboard access to recently used and favorite characters
https://bugs.documentfoundation.org/show_bug.cgi?id=109215 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107885] VBA AutoFilter can't compare strings
https://bugs.documentfoundation.org/show_bug.cgi?id=107885 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112147] Smaller number of columns in special character group button
https://bugs.documentfoundation.org/show_bug.cgi?id=112147 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112245] Copy paste XY chart with Points and Lines from Calc into Writer loses date format when hovering
https://bugs.documentfoundation.org/show_bug.cgi?id=112245 --- Comment #14 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45386] Column formatting not honored saving to .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=45386 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90406] Hanging punctuation after math objects or bibliography entries
https://bugs.documentfoundation.org/show_bug.cgi?id=90406 --- Comment #23 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84765] Impress Remote: add support for handling hidden slides
https://bugs.documentfoundation.org/show_bug.cgi?id=84765 --- Comment #14 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/src
loleaflet/src/map/Map.js |6 ++
1 file changed, 6 insertions(+)
New commits:
commit d65801299d801eb42549376d9713291226b3cc5c
Author: Jan Holesovsky
AuthorDate: Fri Sep 7 15:16:26 2018 +0200
Commit: Henry Castro
CommitDate: Sat Sep 8 02:36:54 2018 +0200
On desktop, focus immediately on startup to get the caret.
Change-Id: Ie33805341740e38bef657fbd7677ef7d0c14cee3
Reviewed-on: https://gerrit.libreoffice.org/60149
Reviewed-by: Henry Castro
Tested-by: Henry Castro
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index f93606bc2..79d70c5e5 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -831,6 +831,9 @@ L.Map = L.Evented.extend({
vex.dialogID = -1;
this._startInactiveTimer();
+ if (!L.Browser.mobile) {
+ this.focus();
+ }
return vex.close(id);
}
} else {
@@ -839,6 +842,9 @@ L.Map = L.Evented.extend({
}
this._startInactiveTimer();
+ if (!L.Browser.mobile) {
+ this.focus();
+ }
return false;
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119753] New: Highlighted text magically expands to new text without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=119753 Bug ID: 119753 Summary: Highlighted text magically expands to new text without warning Product: LibreOffice Version: 6.0.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myusualnickn...@gmail.com Description: At the end of a paragraph, I highlighted a word. I then hit space, and the highlighting did not apply to the space, I then wrote more... and the highlighting jumped from the previous word to the new word that I was writing... This might be OK if the space had been highlighted.. but it wasn't... there was a clear communication from libreoffice that I was no longer in highlighted text... and it's not ok that it highlighted what I wrote after because I would have done an action to turn it off... So the space needs to be properly highlighted to indicate what is going to happen. I expected it to not be highlighted and my next word to not be highlighted... but I'm also ok with it being highlighted and me doing something to turn off highlighting... Of note, I had the word selected when I made it be highlighted, which makes me expect it to not apply to the space coming after it... If I had clicked the button, then written the word, I would expect to click the button to end the highlight... Steps to Reproduce: 1.See above 2. 3. Actual Results: see above Expected Results: if I select text to apply formatting to, ONLY that text should have fomatting applied to it... the text typed after should not have the formatting applied... But really this is about the space that came after it... It's not special.. It should be treated like any other character.. It is so infuriating to have the computer tell me one behavior is occurring, then have it switch behavior afterwards.. that is the real bug. Reproducible: Always User Profile Reset: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no Version: 6.1.0.3 (x64) Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: en-US (en_US); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: layout.xml differs from parseDump(...)
Hi Patrick, Patrick Jaap wrote: > So, the first one is equal, but the other ones are shifted by 333. > > How can this be caused? Is this a bug? > Looks odd indeed. First thing that comes to mind: layouting continues asynchronously after the load - perhaps a Scheduler::ProcessEventsToIdle() helps. See uiwriter.cxx for a few examples where that is used. Other than that, all a bit speculative. Any code / patch yet to look at? Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 101193] Return object Name and Description dialog buttons to object context menus
https://bugs.documentfoundation.org/show_bug.cgi?id=101193 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #20 from andreas_k --- Hi I need feedback for Name and Description items in Context menu. Name Description in writer context menu - graphic not available - draw available - media available - oleobject available - form available >From my point of view Name and Descriptions should be available for all the objects or for none. Description - graphic, draw, media, oleobject, form for ALL apps available Name - graphic, draw, media, oleobject, form for Draw available - form for ALL apps available other area Name isn't needed cause it's only needed to separate stuff in the navigator. Did I miss something -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101193] Return object Name and Description dialog buttons to object context menus
https://bugs.documentfoundation.org/show_bug.cgi?id=101193 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #20 from andreas_k --- Hi I need feedback for Name and Description items in Context menu. Name Description in writer context menu - graphic not available - draw available - media available - oleobject available - form available From my point of view Name and Descriptions should be available for all the objects or for none. Description - graphic, draw, media, oleobject, form for ALL apps available Name - graphic, draw, media, oleobject, form for Draw available - form for ALL apps available other area Name isn't needed cause it's only needed to separate stuff in the navigator. Did I miss something -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 109287] LibreOffice does not start on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=109287 James Sanchez changed: What|Removed |Added Resolution|INSUFFICIENTDATA|--- Status|RESOLVED|REOPENED Version|5.3.4.2 release |6.1.0.3 release --- Comment #3 from James Sanchez --- Will not open just a white box with the spinning icon. This is a win10 latest release on an HP laptop. Fresh win10 install and fresh LO install. Same problem with LO 5.5 and LO has been uninstalled and reinstalled numerous times with same result. Opens correctly in safe mode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119506] Draw Contextmenu in Writer, Calc, Draw and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=119506 --- Comment #15 from andreas_k --- (In reply to Martin Srebotnjak from comment #12) > I suggest we get rid of “Rotate or Flip…” - it is simply not OK (for the > same reason we are not using “Copy, Cut or Paste…” or “Arrange or Align…” as > a command with submenu in context menus). > If no other better solution pops up, I suggest to rename this submenu title > with "Transform...". Transformations is still available in draw and impress. Where rotate is also available but not "simple" mirror. Rotate and Flip is already available in writer for graphic context menu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 119506] Draw Contextmenu in Writer, Calc, Draw and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=119506 --- Comment #15 from andreas_k --- (In reply to Martin Srebotnjak from comment #12) > I suggest we get rid of “Rotate or Flip…” - it is simply not OK (for the > same reason we are not using “Copy, Cut or Paste…” or “Arrange or Align…” as > a command with submenu in context menus). > If no other better solution pops up, I suggest to rename this submenu title > with "Transform...". Transformations is still available in draw and impress. Where rotate is also available but not "simple" mirror. Rotate and Flip is already available in writer for graphic context menu. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 119722] Losing Dots when importing a CSV with IPv4 addresses
https://bugs.documentfoundation.org/show_bug.cgi?id=119722 --- Comment #11 from V Stuart Foote --- (In reply to lightonflux from comment #10) > Is a help text in order? > > Some small text that tells the user that the columns below are interactive > elements. > But the "Fields" and "Column type" preview panel has *always* been interactive (inherited from OOo) the current help (master/6.2) for the dialog is available here: https://help.libreoffice.org/6.2/en-US/text/shared/00/0208.html?System=WIN=CALC#bm_id3155934 Don't see much need for a "tool-tip" that a mouse over and context menu provides. > I think this is especially important for people with Excel experience. AFAIK > in Excel it is only a preview. And it says so. No, Excel's Text Import Wizard also goes interactive, allowing to set General-Text-Date-or Skip, in its final steps. The OOo/LibreOffice UI is much more direct. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 5 commits - loleaflet/admin loleaflet/debug loleaflet/html loleaflet/js loleaflet/l10n loleaflet/src loolwsd.xml.in wsd/FileServer.cpp wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp
loleaflet/admin/admin.html|8
loleaflet/admin/adminAnalytics.html |8
loleaflet/admin/adminHistory.html |8
loleaflet/admin/adminSettings.html|8
loleaflet/debug/document/admin.html |2
loleaflet/debug/document/adminAnalytics.html |2
loleaflet/debug/document/adminSettings.html |2
loleaflet/html/loleaflet.html.m4 | 18 +
loleaflet/js/main.js |3
loleaflet/l10n/admin-localizations.json | 236 +-
loleaflet/src/core/Socket.js |2
loleaflet/src/layer/tile/TileLayer.js |2
loleaflet/src/map/handler/Map.FileInserter.js |2
loleaflet/src/map/handler/Map.SlideShow.js|2
loolwsd.xml.in|1
wsd/FileServer.cpp| 21 +-
wsd/LOOLWSD.cpp | 17 +
wsd/LOOLWSD.hpp |1
18 files changed, 184 insertions(+), 159 deletions(-)
New commits:
commit 5ae112d563a89a94b852edc03a21efdb19fc0cbd
Author: Jan Holesovsky
AuthorDate: Sat Sep 8 00:10:50 2018 +0200
Commit: Jan Holesovsky
CommitDate: Sat Sep 8 00:12:20 2018 +0200
ServiceRoot: Fix the admin console (the jwt token generation).
Change-Id: Ic1772692471d29c99d7d68834cddb6b304e721d2
diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index 517477b2e..e0b475595 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -252,7 +252,7 @@ bool FileServerRequestHandler::isAdminLoggedIn(const
HTTPRequest& request,
Poco::Net::HTTPCookie cookie("jwt", jwtToken);
// bundlify appears to add an extra /dist -> dist/dist/admin
-cookie.setPath("/loleaflet/dist/");
+cookie.setPath(LOOLWSD::ServiceRoot + "/loleaflet/dist/");
cookie.setSecure(LOOLWSD::isSSLEnabled() ||
LOOLWSD::isSSLTermination());
response.addCookie(cookie);
commit 7152a8a55c365c94a9756b1fa504ab2836b142d2
Author: Jan Holesovsky
AuthorDate: Fri Sep 7 23:34:09 2018 +0200
Commit: Jan Holesovsky
CommitDate: Sat Sep 8 00:12:20 2018 +0200
ServiceRoot: Fix the branding and update the admin console debug URL.
Change-Id: Id10d7a4d99ea993a398467e528e2018cc12d503b
diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index a508c4f15..517477b2e 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -619,11 +619,11 @@ void FileServerRequestHandler::preprocessFile(const
HTTPRequest& request, Poco::
Poco::replaceInPlace(preprocess, std::string("%VERSION%"),
std::string(LOOLWSD_VERSION_HASH));
Poco::replaceInPlace(preprocess, std::string("%SERVICE_ROOT%"),
LOOLWSD::ServiceRoot);
-static const std::string linkCSS("");
-static const std::string scriptJS("");
+static const std::string linkCSS("");
+static const std::string scriptJS("");
-std::string brandCSS(Poco::format(linkCSS, std::string(BRANDING)));
-std::string brandJS(Poco::format(scriptJS, std::string(BRANDING)));
+std::string brandCSS(Poco::format(linkCSS, LOOLWSD::ServiceRoot,
std::string(BRANDING)));
+std::string brandJS(Poco::format(scriptJS, LOOLWSD::ServiceRoot,
std::string(BRANDING)));
const auto& config = Application::instance().config();
#if ENABLE_SUPPORT_KEY
@@ -631,8 +631,8 @@ void FileServerRequestHandler::preprocessFile(const
HTTPRequest& request, Poco::
SupportKey key(keyString);
if (!key.verify() || key.validDaysRemaining() <= 0)
{
-brandCSS = Poco::format(linkCSS, std::string(BRANDING_UNSUPPORTED));
-brandJS = Poco::format(scriptJS, std::string(BRANDING_UNSUPPORTED));
+brandCSS = Poco::format(linkCSS, LOOLWSD::ServiceRoot,
std::string(BRANDING_UNSUPPORTED));
+brandJS = Poco::format(scriptJS, LOOLWSD::ServiceRoot,
std::string(BRANDING_UNSUPPORTED));
}
#endif
@@ -792,13 +792,13 @@ void FileServerRequestHandler::preprocessAdminFile(const
HTTPRequest& request,co
if (!FileServerRequestHandler::isAdminLoggedIn(request, response))
throw Poco::Net::NotAuthenticatedException("Invalid admin login");
-static const std::string scriptJS("");
+static const std::string scriptJS("");
static const std::string footerPage("Key: %s
Expiry Date: %s");
const std::string relPath = getRequestPathname(request);
LOG_DBG("Preprocessing file: " << relPath);
std::string adminFile = *getUncompressedFile(relPath);
-std::string brandJS(Poco::format(scriptJS, std::string(BRANDING)));
+std::string brandJS(Poco::format(scriptJS, LOOLWSD::ServiceRoot,
std::string(BRANDING)));
std::string brandFooter;
#if ENABLE_SUPPORT_KEY
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 7723adb5a..8248d28d8 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -568,6 +568,7 @@ inline std::string getAdminURI(const
Poco::Util::LayeredConfiguration )
std::ostringstream oss;
[Libreoffice-bugs] [Bug 119547] Media Contextmenu in Writer, Calc, Draw and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=119547 --- Comment #4 from andreas_k --- Created attachment 144747 --> https://bugs.documentfoundation.org/attachment.cgi?id=144747=edit Contextmenu Media for Writer, Calc, Draw and Impress V3 >> Missing Description and Name (both IMHO are better without ellipsis) Description for a11y is available in any other object context menu in writer excl. form. So have it all the time or none. >>I wonder what's under Convert (regarding it's media, ie. an audio/video file). good point removed. It didn't work anyway. >>No Align for Word/Calc is hard to explain when you keep it on the other >>modules. good point added, but didn't work maybe someone can fix that align is available for media context. >>Similar for Group- why do you remove it? wasn't removed it's not in a subgroup so it will be shown ONLY when you select more than one media file. >>We had a discussion about "Insert Caption..." though not about media but >>images. Add Caption in writer work really well and it's a 100% context related action So I add Insert Caption to ALL objects. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 119547] Media Contextmenu in Writer, Calc, Draw and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=119547 --- Comment #4 from andreas_k --- Created attachment 144747 --> https://bugs.documentfoundation.org/attachment.cgi?id=144747=edit Contextmenu Media for Writer, Calc, Draw and Impress V3 >> Missing Description and Name (both IMHO are better without ellipsis) Description for a11y is available in any other object context menu in writer excl. form. So have it all the time or none. >>I wonder what's under Convert (regarding it's media, ie. an audio/video file). good point removed. It didn't work anyway. >>No Align for Word/Calc is hard to explain when you keep it on the other >>modules. good point added, but didn't work maybe someone can fix that align is available for media context. >>Similar for Group- why do you remove it? wasn't removed it's not in a subgroup so it will be shown ONLY when you select more than one media file. >>We had a discussion about "Insert Caption..." though not about media but >>images. Add Caption in writer work really well and it's a 100% context related action So I add Insert Caption to ALL objects. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 99213] Presentation saved in PPTX format cannot be opened in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=99213 Mark Hung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104787] [META] Saved PPTX files that MS Powerpoint can't open
https://bugs.documentfoundation.org/show_bug.cgi?id=104787 Bug 104787 depends on bug 99213, which changed state. Bug 99213 Summary: Presentation saved in PPTX format cannot be opened in PowerPoint https://bugs.documentfoundation.org/show_bug.cgi?id=99213 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119752] Cox tech support
https://bugs.documentfoundation.org/show_bug.cgi?id=119752 Daveheller changed: What|Removed |Added URL||http://www.email-customer-c ||are.com/cox-support -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119752] New: Cox tech support
https://bugs.documentfoundation.org/show_bug.cgi?id=119752 Bug ID: 119752 Summary: Cox tech support Product: LibreOffice Version: 4.1.2.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: daveheller...@gmail.com Description: There are times when a Gmail account does not run according to user's expectations and thus it is battling common problems. If you're encountering a username or password incorrect issue in Cox account due to which you are unable to access the email account. Users can not understand enough technology to understand many states of technical features that solve the solution: video calling, online chatting, remote services and more. To get the difficulty in solving the right time, to join the technical support team, all the services mentioned above are very well supported above. It is most important to connect with the cox tech Support Team here. It's tech support team who is particularly capable of improving every type of technical difficulty that is usually faced by .for more details cox related issue you can contact toll-free number+1-800-892-1502 or click web-page http://www.email-customer-care.com/cox-support Actual Results: technical support Expected Results: customer service Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/filter/eppt/pptx-animations.cxx | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
New commits:
commit 9a9b81c7212fa6a6762246593acf3f1950677a22
Author: Mark Hung
AuthorDate: Thu Sep 6 05:56:46 2018 +0800
Commit: Mark Hung
CommitDate: Fri Sep 7 23:57:02 2018 +0200
sd/ pptx export: resolves unhandled node type causing crashes.
found in
http://dev-builds.libreoffice.org/crashtest/1103bddab3f695b61484960523c4c2c0de4f0f91/
https://bz.apache.org/ooo/attachment.cgi?id=49270
https://bz.apache.org/ooo/attachment.cgi?id=44458
https://bz.apache.org/ooo/attachment.cgi?id=54593
Change-Id: If9e19140f2fcffc0b261c1d91a40597684a51917
Reviewed-on: https://gerrit.libreoffice.org/60060
Tested-by: Jenkins
Reviewed-by: Mark Hung
diff --git a/sd/source/filter/eppt/pptx-animations.cxx
b/sd/source/filter/eppt/pptx-animations.cxx
index b02ccdcc4cb7..42cec71e09e1 100644
--- a/sd/source/filter/eppt/pptx-animations.cxx
+++ b/sd/source/filter/eppt/pptx-animations.cxx
@@ -425,9 +425,10 @@ bool isValidTarget(const Any& rTarget)
return false;
}
-/// convert animation node type to corresponding ooxml element.
-sal_Int32 convertNodeType(sal_Int16 nType)
+/// extract ooxml node type from a XAnimationNode.
+sal_Int32 extractNodeType(const Reference& rXNode)
{
+sal_Int16 nType = rXNode->getType();
sal_Int32 xmlNodeType = -1;
switch (nType)
{
@@ -445,9 +446,17 @@ sal_Int32 convertNodeType(sal_Int16 nType)
xmlNodeType = XML_animMotion;
break;
case AnimationNodeType::ANIMATETRANSFORM:
-// could be XML_animScale or XML_animRot based on
xTransform->getTransformType()
-xmlNodeType = -1;
+{
+Reference xTransform(rXNode, UNO_QUERY);
+if (xTransform.is())
+{
+if (xTransform->getTransformType() ==
AnimationTransformType::SCALE)
+xmlNodeType = XML_animScale;
+else if (xTransform->getTransformType() ==
AnimationTransformType::ROTATE)
+xmlNodeType = XML_animRot;
+}
break;
+}
case AnimationNodeType::ANIMATECOLOR:
xmlNodeType = XML_animClr;
break;
@@ -1136,7 +1145,10 @@ void PPTXAnimationExport::WriteAnimationNode(const
NodeContextPtr& pContext)
const Reference& rXNode = getCurrentNode();
SAL_INFO("sd.eppt", "export node type: " << rXNode->getType());
-sal_Int32 xmlNodeType = convertNodeType(rXNode->getType());
+sal_Int32 xmlNodeType = extractNodeType(rXNode);
+
+if (xmlNodeType == -1)
+return;
switch (rXNode->getType())
{
@@ -1150,22 +1162,6 @@ void PPTXAnimationExport::WriteAnimationNode(const
NodeContextPtr& pContext)
WriteAnimationNodeSeq();
break;
case AnimationNodeType::ANIMATETRANSFORM:
-{
-Reference xTransform(rXNode, UNO_QUERY);
-if (xTransform.is())
-{
-if (xTransform->getTransformType() ==
AnimationTransformType::SCALE)
-xmlNodeType = XML_animScale;
-else if (xTransform->getTransformType() ==
AnimationTransformType::ROTATE)
-xmlNodeType = XML_animRot;
-
-WriteAnimationNodeAnimate(xmlNodeType);
-}
-else
-SAL_WARN("sd.eppt",
- "XAnimateTransform not handled: " <<
xTransform->getTransformType());
-}
-break;
case AnimationNodeType::ANIMATE:
case AnimationNodeType::ANIMATEMOTION:
case AnimationNodeType::ANIMATECOLOR:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119743] Libreoffice 6.1 base: can't save special options
https://bugs.documentfoundation.org/show_bug.cgi?id=119743 --- Comment #4 from Julien Nabet --- Trying to understand all this, I noticed that there are: "PreferDosLikeLineEnds" and "UseDOSLineEnds" Shouldn't we have only 1 var? What's the diff between them? For "ParameterNameSubstitution", I don't see any alternative var. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119711] contextmenu Chart: sheettab.xml
https://bugs.documentfoundation.org/show_bug.cgi?id=119711 --- Comment #7 from andreas_k --- > In the last screenshot, View grid and Hide Sheet are in the left menu at > diferent positions and with separator. In the right position they are > together. This is not consistent. Thanks for the feedback. The issue is that view grid lines are an "visible" thing it change how the tab will look like it "hide" the grid. Hide sheet is also kind of "visible" option it hide the sheet. Do you have an better idea for grouping cause the main issue is, that I don't want to have groups with only one item. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 119711] contextmenu Chart: sheettab.xml
https://bugs.documentfoundation.org/show_bug.cgi?id=119711 --- Comment #7 from andreas_k --- > In the last screenshot, View grid and Hide Sheet are in the left menu at > diferent positions and with separator. In the right position they are > together. This is not consistent. Thanks for the feedback. The issue is that view grid lines are an "visible" thing it change how the tab will look like it "hide" the grid. Hide sheet is also kind of "visible" option it hide the sheet. Do you have an better idea for grouping cause the main issue is, that I don't want to have groups with only one item. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 119305] Calc consumes all system memory when creating a chart while all cells are selected, including empty cells
https://bugs.documentfoundation.org/show_bug.cgi?id=119305 Jason Wood changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119298] Table alignment changes from automatic to left (or from left) after moving the inner table border of an embedded table in Webview with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=119298 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #4 from Dieter Praas --- I also can't see tables in webview, but perhaps thats normal, because tables are part of the header and footer in normal view. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119305] Calc consumes all system memory when creating a chart while all cells are selected, including empty cells
https://bugs.documentfoundation.org/show_bug.cgi?id=119305 --- Comment #2 from Jason Wood --- Created attachment 144746 --> https://bugs.documentfoundation.org/attachment.cgi?id=144746=edit Table with issues I played around with this issue to see if I could figure out the cause of the problem. I believe that it is related to columns without data surrounded by columns with data (see the attached example). With this smaller, randomly generated dataset, I am unable to get Calc to consume all memory as I initially reported. However, if you select all cells (clicking the blank spot between row 1 and column A) and attempt to insert a figure, Calc does not produce the figure as expected. However, if the selection is limited to A1:Y1000 (the randomly generated data), the figure is produced as expected (see the figure in the tab with the same name). If I were to add more columns I might be able to get Calc to consume all memory, but I think this example will be enough to demonstrate the issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43107] Regular expression "\n" in replace field inputs "\n" instead of line(paragraph?) break
https://bugs.documentfoundation.org/show_bug.cgi?id=43107 --- Comment #22 from DN --- (In reply to Cor Nouws from comment #21) > There is more. Who says Ctrl+Enter creates a new line in a Calc text cell? It does. Did you test and see what happens? > Unzip a Calc file with a 'new line', and you see: > text on line oneAnd this on line too > > Unzip a Writer file with a 'new line', and you see: > This is line oneand this is > line two This isn't relevant to whether this is a bug. What's relevant is what the user actually sees/experiences. Which is a newline. Which is *also* what's in the docs: https://help.libreoffice.org/Common/Inserting_Line_Breaks_in_Cells > So, although the Calc cell UI does not know the paragraph concept, the xml > file does. Unless it's a fundamental limitation of ODS, this is also irrelevant in terms of this being a bug, and just means there is separate bug with saving to ODS. Even in the case of a fundamental limitation of the format, it doesn't negate this bug; it might make it CANTFIX at most. > Thus the question still stands: what are the bugs, and/or not yet > implemented features? (see below) > > > > Hence I do not have a file to test this exactly.. > > > > The steps I listed result in a doc to test this. > > They don't - hence my request ;) Your previous comments made no mention of my steps not working. Please tell me how the outcome when you tried differed from my description. > > > behavior was the same in version 3.3.0 and is in OpenOffice. > > > So, is this really a bug, or something that behaves different than > > > expected?? > > > > It's a bug. The content of "replace" should be interpreted as a regex (i.e. > > \n should be interpreted as a newline, not a literal string). It may well > > have always been a bug in Open/LibreOffice. > > No doubt that I agree, that one would expect that Find & Replace replaces > 'line breaks'. In any case, in there is no line break, a result 'not found' > would be more appropriate. Covered above. Ctrl-Enter = line break per docs. Displays as line break. User wants a line break. Document saving bugs are irrelevant, unless they're the *cause* of this bug. A "not found" would be adding another effective bug (in terms of intended/documented behaviour) to align with other buggy behaviour elsewhere. > > So bugs/problems are: > - a 'new line' in Calc text cells, produces a new paragraph; Separate bug re. ODS and maybe internal state. Additionally, the *find* part works fine. The *replace* part is this bug. > - it makes sense that, since Shift+Enter does the opposite of Enter, >Ctrl+Enter is used for the line break (new line/paragraph) It effectively does now (user experience/documentation). Again, nothing to do with this bug, which is about *replacement*. > - maybe it should really create a line break? Not directly relevant, might be a dependency for this bug - see above. > - Find & Replace should either report: no new lines found; or behave > different in Calc text, handling paragraphs as if it were line breaks; Or Ctrl-Enter should just actually insert a line break per the docs - possibly a separate bug. Again, this bug is about *replacement* being literal \n instead of an (effectively) line break. > - documentation is not clear/complete. Possibly, but tangential. > > adding @eike and @regina to cc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119743] Libreoffice 6.1 base: can't save special options
https://bugs.documentfoundation.org/show_bug.cgi?id=119743
--- Comment #3 from Julien Nabet ---
Forgot to tell that if I do:
diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index bc0f8b4813ee..50ff50d0c688 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -699,8 +699,7 @@ void
ODbDataSourceAdministrationHelper::fillDatasourceInfo(const SfxItemSet& _rS
{
const SfxPoolItem* pCurrent =
_rSource.GetItem(static_cast(detailId));
aTranslation = m_aIndirectPropTranslator.find(detailId);
-if ( pCurrent && (m_aIndirectPropTranslator.end() != aTranslation) &&
- aProperties.has(aTranslation->second) )
+if ( pCurrent && (m_aIndirectPropTranslator.end() != aTranslation) )
{
if ( aTranslation->second == INFO_CHARSET )
{
I could save the option (without changing any other file).
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119751] Microsoft 365 Support
https://bugs.documentfoundation.org/show_bug.cgi?id=119751 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119743] Libreoffice 6.1 base: can't save special options
https://bugs.documentfoundation.org/show_bug.cgi?id=119743 Julien Nabet changed: What|Removed |Added CC||lio...@mamane.lu --- Comment #2 from Julien Nabet --- Seems related to https://cgit.freedesktop.org/libreoffice/core/commit/?id=d6fce54c82868b82bd6fa190db6047d69bbb3ecf Lionel: reading comment of the commit, why don't we match 2) with 1) and so display only driver/datasource properties supported? In my case if "End text lines with CR+LF" doesn't stay enabled after having checked the option on my hsqldb embedded database, I suppose it's because hsqldb embedded database doesn't support it. So what's the interest to display the option? Reading https://cgit.freedesktop.org/libreoffice/core/commit/?id=a29d97e6ddab8ec002ba9827bd5fc874117712e0, I wonder if connectivity/registry/hsqldb/org/openoffice/Office/DataAccess/Drivers.xcu should be changed to replace "Features" by "Properties" Now about reporter's case and JDBC, I noticed that ParameterNameSubstitution was in Features part. What about putting it a ParameterNameSubstitution block in Properties part but with false value by default? More simply shouldn't we remove getFeatures and just keep getProperties? + some cleanup in Drivers.xcu files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119605] Document comparison is missing an option not to take into account (or show) style (or formatting) changes
https://bugs.documentfoundation.org/show_bug.cgi?id=119605 Cor Nouws changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #6 from Cor Nouws --- @lászló: looking at your great work in this area (thanks!) you might want to give some comment on this issue too? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119220] Long CPU spike when adding a new bullet (see comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=119220 Telesto changed: What|Removed |Added Summary|Long CPU spike when adding |Long CPU spike when adding |a new bullet|a new bullet (see comment ||5) Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #5 from Telesto --- Comment 1 isn't properly reproducible (see comment 3; didn't add it to the title, sorry). Again with some additions: 1. Open the attached file (automatic spell check enabled) 2. Press Enter after Peu (on the last page) to add a new bullet 3. Select All (CTRL+A) 4. Change the language from English to French (France) (bump) (wait until done) 5. Delete the new created bullet (press backspace until back to peu) 6. Press Enter again (again a long bump) Repro with Version: 6.2.0.0.alpha0+ Build ID: 5e8fd488f17fe0433cc9b31ace6527fb06ea3bb0 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-09-05_02:20:05 Locale: en-US (nl_NL); Calc: CL -> in safe-mode but not in Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119254] Pasting a slide with multiple shapes (~1000) takes longer with GTK3 backend
https://bugs.documentfoundation.org/show_bug.cgi?id=119254 --- Comment #8 from Gorka Navarrete --- Buovjaga, I tried starting from a terminal with libreoffice --safe-mode and times are still >1m. With a i7-4790 (8GB RAM), Ubuntu 18.04, LO 6.0.3.2: safe mode: ~1m40s normal mode: ~1m37s NO gtk3 (a11y disabled): ~2s -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43107] Regular expression "\n" in replace field inputs "\n" instead of line(paragraph?) break
https://bugs.documentfoundation.org/show_bug.cgi?id=43107 Cor Nouws changed: What|Removed |Added Summary|Regular expression "\n" in |Regular expression "\n" in |replace field inputs "\n" |replace field inputs "\n" |instead of paragraph break |instead of line(paragraph?) ||break CC||er...@redhat.com, ||rb.hensc...@t-online.de --- Comment #21 from Cor Nouws --- (In reply to DN from comment #20) > > Help reads: : "\n is for line end entered with Shft+Enter" > > (for anyone else reading - the help page by clicking Help on the > search/replace window and clicking "List of Regular Expressions") > > This is a documentation bug. This refers to Writer only, not Calc. There is more. Who says Ctrl+Enter creates a new line in a Calc text cell? Unzip a Calc file with a 'new line', and you see: text on line oneAnd this on line too Unzip a Writer file with a 'new line', and you see: This is line oneand this is line two So, although the Calc cell UI does not know the paragraph concept, the xml file does. Thus the question still stands: what are the bugs, and/or not yet implemented features? (see below) > > Hence I do not have a file to test this exactly.. > > The steps I listed result in a doc to test this. They don't - hence my request ;) > > behavior was the same in version 3.3.0 and is in OpenOffice. > > So, is this really a bug, or something that behaves different than > > expected?? > > It's a bug. The content of "replace" should be interpreted as a regex (i.e. > \n should be interpreted as a newline, not a literal string). It may well > have always been a bug in Open/LibreOffice. No doubt that I agree, that one would expect that Find & Replace replaces 'line breaks'. In any case, in there is no line break, a result 'not found' would be more appropriate. So bugs/problems are: - a 'new line' in Calc text cells, produces a new paragraph; - it makes sense that, since Shift+Enter does the opposite of Enter, Ctrl+Enter is used for the line break (new line/paragraph) - maybe it should really create a line break? - Find & Replace should either report: no new lines found; or behave different in Calc text, handling paragraphs as if it were line breaks; - documentation is not clear/complete. adding @eike and @regina to cc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/source
extras/source/autocorr/lang/tr/DocumentList.xml | 86 1 file changed, 43 insertions(+), 43 deletions(-) New commits: commit 0fa2a77881d81fd0692eed628b2785a57be60ab7 Author: Muhammet Kara AuthorDate: Fri Sep 7 16:23:33 2018 +0300 Commit: Muhammet Kara CommitDate: Fri Sep 7 22:48:22 2018 +0200 [tr][autocorr] Consistent capitalizations for Turkish Change-Id: Icfb6d82f094a4ab743d0ec4f51ddfdda606a731a Reviewed-on: https://gerrit.libreoffice.org/60152 Tested-by: Jenkins Reviewed-by: Muhammet Kara diff --git a/extras/source/autocorr/lang/tr/DocumentList.xml b/extras/source/autocorr/lang/tr/DocumentList.xml index eba1760f1f0d..28440cdce5e2 100644 --- a/extras/source/autocorr/lang/tr/DocumentList.xml +++ b/extras/source/autocorr/lang/tr/DocumentList.xml @@ -11,37 +11,37 @@ - + - - - + + + - + - - + + - + - + - + - + - + - + @@ -50,72 +50,72 @@ - - + + http://"/> - + - + - - + + - - - - + + + + - - - - - + + + + + - + - + - - + + - + - - + + - + - + - - - + + + - + - + - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dtrans/source onlineupdate/source vcl/opengl vcl/win
dtrans/source/win32/misc/ImplHelper.cxx|2 -
onlineupdate/source/update/updater/updater.cxx | 32 -
vcl/opengl/win/WinDeviceInfo.cxx |2 -
vcl/win/app/salinst.cxx|2 -
vcl/win/window/salframe.cxx|4 +--
5 files changed, 21 insertions(+), 21 deletions(-)
New commits:
commit b18747fcee1ba8744e5cd63791dc9f3eb6848a56
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 7 16:09:50 2018 +0200
Commit: Mike Kaganski
CommitDate: Fri Sep 7 22:04:50 2018 +0200
Fix some std::unique_ptr array allocs
Found by reviewing the output of and the code around
git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]"
The onlineupdater code needs a little bit more attention.
Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0
Reviewed-on: https://gerrit.libreoffice.org/60162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/dtrans/source/win32/misc/ImplHelper.cxx
b/dtrans/source/win32/misc/ImplHelper.cxx
index 4b98b4850006..f933701ce961 100644
--- a/dtrans/source/win32/misc/ImplHelper.cxx
+++ b/dtrans/source/win32/misc/ImplHelper.cxx
@@ -95,7 +95,7 @@ OUString getWinCPFromLocaleId( LCID lcid, LCTYPE lctype )
if ( nResult )
{
-std::unique_ptr buff( new wchar_t[nResult] );
+std::unique_ptr buff( new wchar_t[nResult] );
// Now get the actual data
nResult = GetLocaleInfoW( lcid, lctype, buff.get(), nResult );
diff --git a/onlineupdate/source/update/updater/updater.cxx
b/onlineupdate/source/update/updater/updater.cxx
index 1782804eff15..a05fd075bd3a 100644
--- a/onlineupdate/source/update/updater/updater.cxx
+++ b/onlineupdate/source/update/updater/updater.cxx
@@ -1119,8 +1119,8 @@ public:
void Finish(int status);
private:
-std::unique_ptr mFile;
-std::unique_ptr mRelPath;
+std::unique_ptr mFile;
+std::unique_ptr mRelPath;
int mSkip;
};
@@ -1247,8 +1247,8 @@ public:
virtual void Finish(int status);
private:
-std::unique_ptr mDir;
-std::unique_ptr mRelPath;
+std::unique_ptr mDir;
+std::unique_ptr mRelPath;
int mSkip;
};
@@ -1260,6 +1260,7 @@ RemoveDir::Parse(NS_tchar *line)
NS_tchar* validPath = get_valid_path(, true);
if (!validPath)
return PARSE_ERROR;
+
mRelPath.reset(new NS_tchar[MAXPATHLEN]);
NS_tstrcpy(mRelPath.get(), validPath);
@@ -1371,8 +1372,8 @@ public:
virtual void Finish(int status);
private:
-std::unique_ptr mFile;
-std::unique_ptr mRelPath;
+std::unique_ptr mFile;
+std::unique_ptr mRelPath;
bool mAdded;
ArchiveReader& mArchiveReader;
};
@@ -1387,7 +1388,6 @@ AddFile::Parse(NS_tchar *line)
return PARSE_ERROR;
mRelPath.reset(new NS_tchar[MAXPATHLEN]);
-
NS_tstrcpy(mRelPath.get(), validPath);
mFile.reset(get_full_path(validPath));
@@ -1799,7 +1799,7 @@ public:
virtual void Finish(int status);
protected:
-std::unique_ptr mTestFile;
+std::unique_ptr mTestFile;
};
AddIfFile::AddIfFile(ArchiveReader& archiveReader):
@@ -1866,7 +1866,7 @@ public:
virtual void Finish(int status);
protected:
-std::unique_ptr mTestFile;
+std::unique_ptr mTestFile;
};
AddIfNotFile::AddIfNotFile(ArchiveReader& archiveReader):
@@ -1933,7 +1933,7 @@ public:
virtual void Finish(int status);
private:
-std::unique_ptr mTestFile;
+std::unique_ptr mTestFile;
};
PatchIfFile::PatchIfFile(ArchiveReader& archiveReader):
@@ -2323,7 +2323,7 @@ CopyInstallDirToDestDir()
#endif
copy_recursive_skiplist skiplist;
-std::unique_ptr pUserProfile(new NS_tchar[MAXPATHLEN]);
+std::unique_ptr pUserProfile(new NS_tchar[MAXPATHLEN]);
NS_tstrcpy(pUserProfile.get(), gPatchDirPath);
NS_tchar *slash = (NS_tchar *) NS_tstrrchr(pUserProfile.get(), NS_T('/'));
if (slash)
@@ -4036,7 +4036,7 @@ int add_dir_entries(const NS_tchar *dirpath, ActionList
*list)
NS_tsnprintf(searchspec, sizeof(searchspec)/sizeof(searchspec[0]),
NS_T("%s*"), dirpath);
-std::unique_ptr pszSpec(get_full_path(searchspec));
+std::unique_ptr pszSpec(get_full_path(searchspec));
hFindFile = FindFirstFileW(pszSpec.get(), );
if (hFindFile != INVALID_HANDLE_VALUE)
@@ -4116,7 +4116,7 @@ int add_dir_entries(const NS_tchar *dirpath, ActionList
*list)
char chars[MAXNAMLEN];
} ent_buf;
struct dirent* ent;
-std::unique_ptr searchpath(get_full_path(dirpath));
+std::unique_ptr searchpath(get_full_path(dirpath));
DIR* dir = opendir(searchpath.get());
if (!dir)
@@ -4206,7 +4206,7 @@ int add_dir_entries(const NS_tchar *dirpath, ActionList
*list)
int rv = OK;
FTS *ftsdir;
FTSENT *ftsdirEntry;
-std::unique_ptr searchpath(get_full_path(dirpath));
+std::unique_ptr searchpath(get_full_path(dirpath));
// Remove the trailing slash so the paths don't
Re: [Libreoffice-qa] Issue Gallery Theme Export To Extension
Hello, I tested the creation of a new gallery theme with LibreOffice with version down to LibreOffice 5.1.x and the behavior seemed to be the same. It is impossible to create gallery extensions with LibreOffice in the way it was described in the TDF wiki and on a lot of other websites (and in my howto too). I tried to edit the *.sdg file that was created from the new gallery theme, but with no success. I tried to edit the URL at the end of the file, but that doesn't help. It is impossible to drag a graphic from the theme (installed via extension) into a document. Seemed to be that there has been inserted a regression. Kind regards, Andreas Am 05.09.2018 um 22:27 schrieb Andreas Mantke: > Hello, > > it was possible to easily create a new gallery theme with former > versions of LibreOffice and create an extension to deploy it to other > users. LibreOffice created three new files in the 'gallery' subdirectory > of the users configuration. You could copy (and rename) this files and > put them in a subdirectory of the gallery-extension. If a user installed > it on his/her computer, the new theme were added to his/her gallery and > could be inserted by drag and drop into a document. > > This way is not available anymore (since at least LibreOffice 6.0). > LibreOffice creates in addition to the three files a subdirectory with > the new graphics (the ones that are added to the new theme). But if you > copy the whole files in the 'gallery' subdirectory and also the > subdirectory with the graphics into the subdirectory of the extension > you could install the extension, see a new gallery theme, but could not > drag and drop the graphics into a document. You will get a dialog > instead, that shows in one field the (old) link to the graphic. This is > the absolute link to the graphic at that time when the gallery theme was > created. > > If you have a look into the *.sdg file of the new gallery theme, you'll > find the absolute path to the graphic(s) at the end of it. It should > have been a relative path to the graphic(s). > > This new behavior of LibreOffice makes it impossible to create and share > LibreOffice gallery extensions. The included graphics will never be found. > > I have to update my documentation about non-code extensions next days > and explain that it is only possible to create gallery extensions with > former (not actively supported) versions of LibreOffice yet. > > Kind regards, > Andreas > > ___ > List Name: Libreoffice-qa mailing list > Mail address: Libreoffice-qa@lists.freedesktop.org > Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa > Problems? > http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ > Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette > List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 119249] Point markers in icon themes should be semi-transparent
https://bugs.documentfoundation.org/show_bug.cgi?id=119249 --- Comment #8 from andreas_k --- Good point Would you make an suggestion or should I add you to the patch? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119694] HSQLDB driver not loading causes BASE error in embedded hsqldb database
https://bugs.documentfoundation.org/show_bug.cgi?id=119694 Julien Nabet changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.2 |target:6.2.0 target:6.1.1 |target:6.1.1| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119694] HSQLDB driver not loading causes BASE error in embedded hsqldb database
https://bugs.documentfoundation.org/show_bug.cgi?id=119694 --- Comment #34 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-1-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7d1612ca3e29dce226700551040ceac1de99299b=libreoffice-6-1-1 tdf#119694: read embedded hsqldb file generated before 6.1 It will be available in 6.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119694] HSQLDB driver not loading causes BASE error in embedded hsqldb database
https://bugs.documentfoundation.org/show_bug.cgi?id=119694 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.2 |target:6.2.0 target:6.1.2 ||target:6.1.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1-1' - dbaccess/source
dbaccess/source/filter/xml/xmlfilter.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 7d1612ca3e29dce226700551040ceac1de99299b
Author: Julien Nabet
AuthorDate: Thu Sep 6 22:02:56 2018 +0200
Commit: Caolán McNamara
CommitDate: Fri Sep 7 21:32:01 2018 +0200
tdf#119694: read embedded hsqldb file generated before 6.1
Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebb34571c19c5ac939fbf5aed2ab66ee18e298dc
Thank you Drew Jensen for the bibisect!
Change-Id: I9550f61709e8582a52554f578ef043c6551f09f0
Reviewed-on: https://gerrit.libreoffice.org/60117
Reviewed-by: Michael Stahl
Tested-by: Michael Stahl
(cherry picked from commit 4b5194bd1d0dd893720ec0b311ee215a3168219f)
Reviewed-on: https://gerrit.libreoffice.org/60131
Tested-by: Jenkins
(cherry picked from commit 6e0e3872f30c177559446b2c050b2a6582f257ec)
Reviewed-on: https://gerrit.libreoffice.org/60143
Reviewed-by: Christian Lohmaier
Reviewed-by: Tomaž Vajngerl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx
b/dbaccess/source/filter/xml/xmlfilter.cxx
index a77db0ecec0f..02fd2fda823e 100644
--- a/dbaccess/source/filter/xml/xmlfilter.cxx
+++ b/dbaccess/source/filter/xml/xmlfilter.cxx
@@ -655,6 +655,7 @@ const SvXMLTokenMap& ODBFilter::GetDocContentElemTokenMap()
const
{ XML_NAMESPACE_OOO,XML_AUTOMATIC_STYLES,
XML_TOK_CONTENT_AUTOSTYLES },
{ XML_NAMESPACE_OFFICE, XML_SCRIPTS,
XML_TOK_CONTENT_SCRIPTS },
{ XML_NAMESPACE_OFFICE, XML_BODY,
XML_TOK_CONTENT_BODY},
+{ XML_NAMESPACE_OOO,XML_BODY,
XML_TOK_CONTENT_BODY},
XML_TOKEN_MAP_END
};
m_pDocContentElemTokenMap.reset(new SvXMLTokenMap( aElemTokenMap ));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118639] Slow performance to the point of being unuseable
https://bugs.documentfoundation.org/show_bug.cgi?id=118639 --- Comment #13 from Stuart Edwards --- Interesting that the replication of this file does not occur in the LODev files and neither is there a mysterious flashing file. There is however 500 Mb in the temp file that is probably unnecessary? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119722] Losing Dots when importing a CSV with IPv4 addresses
https://bugs.documentfoundation.org/show_bug.cgi?id=119722 --- Comment #10 from lightonflux --- Is a help text in order? Some small text that tells the user that the columns below are interactive elements. I think this is especially important for people with Excel experience. AFAIK in Excel it is only a preview. And it says so. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99968] The format for an envelope does not get passed to the print function, Print is still set to 11.0" x 8.5"...
https://bugs.documentfoundation.org/show_bug.cgi?id=99968 --- Comment #11 from ecomer --- I have the same problem. #10 envelope opens as a "User" size instead of the #10 envelope. Screenshots are at: https://www.flickr.com/gp/celem/j3ee9N My system is: Linux asrock 4.18.5-1-MANJARO #1 SMP PREEMPT Fri Aug 24 16:36:58 UTC 2018 x86_64 GNU/Linux My LibreOffice version is: Version: 6.1.0.3, Build ID: 6.1.0-2 CPU threads: 2; OS: Linux 4.18; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); Calc: group threaded Driver info: $ lpinfo --make-and-model "HL-2140" -m foomatic:Brother-HL-2140-hl1250.ppd Brother HL-2140 Foomatic/hl1250 [NOTE] the hl1250 driver is recommended for the HL2140. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118639] Slow performance to the point of being unuseable
https://bugs.documentfoundation.org/show_bug.cgi?id=118639 --- Comment #12 from Stuart Edwards --- The saga continues. Noticing that LO was getting a little sluggish I went back to the user support files and sure enough, the backup directory was full of zero byte copies of my protected file (140,000). I deleted them and then was able to watch them being re-created in batches of 3. I also noticed a file name flash in the adjacent finder window - it appears every 30 seconds or so and is hard to read as it's only there for a split second. I started a screen record and managed to catch it and then took a screen shot (attached - iYNegh). The file name is always different but of the same style - 6 alpha-numeric characters. An incidental finding is that the user directory contained about 850 Mb of files - so I hunted down the source and found that is was in 'temp' files. 200 Mb in the user and in user-old/temp another 600 Mb. Should these files self-delete if they are 'temps'? Can I safely delete them? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118639] Slow performance to the point of being unuseable
https://bugs.documentfoundation.org/show_bug.cgi?id=118639 --- Comment #11 from Stuart Edwards --- Created attachment 144745 --> https://bugs.documentfoundation.org/attachment.cgi?id=144745=edit Screen shot from screen capture showing intermittent file appearance see comment discussing this graphic -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119254] Pasting a slide with multiple shapes (~1000) takes longer with GTK3 backend
https://bugs.documentfoundation.org/show_bug.cgi?id=119254 --- Comment #7 from Caolán McNamara --- it may not be gtk3 vs non-gtk3, it may be a11y enabled libreoffice vs a11y disabled one -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=115709 Bug 115709 depends on bug 119019, which changed state. Bug 119019 Summary: EDITING DOCX Track changes deletion and addition in paragraphs with tracked paragraph formatting change not displayed instantly https://bugs.documentfoundation.org/show_bug.cgi?id=119019 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/IDocumentRedlineAccess.hxx |2
sw/qa/extras/uiwriter/data2/tdf119019.docx |binary
sw/qa/extras/uiwriter/uiwriter2.cxx | 35
sw/source/core/doc/DocumentContentOperationsManager.cxx | 13 +
sw/source/core/doc/DocumentRedlineManager.cxx | 25 +++
sw/source/core/inc/DocumentRedlineManager.hxx |2
6 files changed, 77 insertions(+)
New commits:
commit 694a6389e84d5b416cde6dde2d5eaa589a0a6493
Author: László Németh
AuthorDate: Thu Sep 6 17:21:05 2018 +0200
Commit: László Németh
CommitDate: Fri Sep 7 20:55:03 2018 +0200
tdf#119019 DOCX track changes: fix invisible delete and insert
during editing in a paragraph with tracked paragraph formatting,
by accepting the old formatting change automatically in the
actual paragraph before text deletion/insertion.
Note: it's not possible to reject paragraph formatting
changes in LO, but showing them is a minimal requirement.
Now they are still visible in change tracking dialog and
by the vertical line before the related paragraphs until
there are no new text deletions and insertions in those
paragraphs.
Change-Id: I526daad8dd96212ac73a10627128553452e4d31c
Reviewed-on: https://gerrit.libreoffice.org/60101
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/inc/IDocumentRedlineAccess.hxx
b/sw/inc/IDocumentRedlineAccess.hxx
index a68af07fb707..f8b1ee6b1a81 100644
--- a/sw/inc/IDocumentRedlineAccess.hxx
+++ b/sw/inc/IDocumentRedlineAccess.hxx
@@ -205,6 +205,8 @@ public:
virtual bool AcceptRedline(/*[in]*/const SwPaM& rPam, /*[in]*/bool
bCallDelete) = 0;
+virtual void AcceptRedlineParagraphFormatting(/*[in]*/const SwPaM& rPam )
= 0;
+
virtual bool RejectRedline(/*[in]*/SwRedlineTable::size_type nPos,
/*[in]*/bool bCallDelete) = 0;
virtual bool RejectRedline(/*[in]*/const SwPaM& rPam, /*[in]*/bool
bCallDelete) = 0;
diff --git a/sw/qa/extras/uiwriter/data2/tdf119019.docx
b/sw/qa/extras/uiwriter/data2/tdf119019.docx
new file mode 100644
index ..d38c9e4ae146
Binary files /dev/null and b/sw/qa/extras/uiwriter/data2/tdf119019.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 77398885940c..c2545de641a7 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -25,11 +25,13 @@ public:
void testTdf101534();
void testTdf54819();
void testTdf119571();
+void testTdf119019();
CPPUNIT_TEST_SUITE(SwUiWriterTest2);
CPPUNIT_TEST(testTdf101534);
CPPUNIT_TEST(testTdf54819);
CPPUNIT_TEST(testTdf119571);
+CPPUNIT_TEST(testTdf119019);
CPPUNIT_TEST_SUITE_END();
};
@@ -130,6 +132,39 @@ void SwUiWriterTest2::testTdf119571()
getProperty(getParagraph(2),
"ParaStyleName"));
}
+void SwUiWriterTest2::testTdf119019()
+{
+load(DATA_DIRECTORY, "tdf119019.docx");
+
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+CPPUNIT_ASSERT_EQUAL(OUString("Nunc viverra imperdiet enim. Fusce est.
Vivamus a tellus."),
+ getParagraph(2)->getString());
+CPPUNIT_ASSERT_EQUAL(OUString(""), getRun(getParagraph(2),
1)->getString());
+// second paragraph has got a tracked paragraph formatting yet
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 1), "RedlineType"));
+
+// delete last word of the second paragraph to remove tracked paragraph
formatting
+// of this paragraph to track and show word deletion correctly.
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->EndPara(/*bSelect=*/false);
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/true, 7,
/*bBasicCall=*/false);
+rtl::Reference pTransfer = new SwTransferable(*pWrtShell);
+pTransfer->Cut();
+
+// check tracked text deletion
+CPPUNIT_ASSERT_EQUAL(OUString("tellus."), getRun(getParagraph(2),
3)->getString());
+CPPUNIT_ASSERT_EQUAL(OUString(""), getRun(getParagraph(2),
2)->getString());
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 2), "RedlineType"));
+
+// check removing of tracked paragraph formatting
+CPPUNIT_ASSERT(!hasProperty(getRun(getParagraph(2), 1), "RedlineType"));
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest2);
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 788cb61dd7df..52e67c6d0146 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2449,6 +2449,15 @@ bool DocumentContentOperationsManager::Overwrite(
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/BitmapAlphaClampFilter.hxx|2 +-
include/vcl/BitmapColorQuantizationFilter.hxx |2 +-
include/vcl/BitmapConvolutionMatrixFilter.hxx |2 +-
include/vcl/BitmapDuoToneFilter.hxx |2 +-
include/vcl/BitmapEmbossGreyFilter.hxx|2 +-
include/vcl/BitmapFilter.hxx |6 +++---
include/vcl/BitmapGaussianSeparableBlurFilter.hxx |4 ++--
include/vcl/BitmapMedianFilter.hxx|2 +-
include/vcl/BitmapMonochromeFilter.hxx|2 +-
include/vcl/BitmapMosaicFilter.hxx| 10 +++---
include/vcl/BitmapPopArtFilter.hxx|2 +-
include/vcl/BitmapSeparableUnsharpenFilter.hxx|2 +-
include/vcl/BitmapSepiaFilter.hxx |2 +-
include/vcl/BitmapSimpleColorQuantizationFilter.hxx |2 +-
include/vcl/BitmapSmoothenFilter.hxx |2 +-
include/vcl/BitmapSobelGreyFilter.hxx |2 +-
include/vcl/BitmapSolarizeFilter.hxx |2 +-
vcl/inc/BitmapColorizeFilter.hxx |2 +-
vcl/inc/BitmapDisabledImageFilter.hxx |2 +-
vcl/inc/BitmapFastScaleFilter.hxx |2 +-
vcl/inc/BitmapInterpolateScaleFilter.hxx |2 +-
vcl/inc/BitmapLightenFilter.hxx |2 +-
vcl/inc/BitmapScaleConvolutionFilter.hxx |2 +-
vcl/inc/BitmapScaleSuperFilter.hxx|2 +-
vcl/source/bitmap/BitmapAlphaClampFilter.cxx |2 +-
vcl/source/bitmap/BitmapColorQuantizationFilter.cxx |2 +-
vcl/source/bitmap/BitmapColorizeFilter.cxx|2 +-
vcl/source/bitmap/BitmapConvolutionMatrixFilter.cxx |2 +-
vcl/source/bitmap/BitmapDisabledImageFilter.cxx |2 +-
vcl/source/bitmap/BitmapDuoToneFilter.cxx |2 +-
vcl/source/bitmap/BitmapEmbossGreyFilter.cxx |2 +-
vcl/source/bitmap/BitmapFastScaleFilter.cxx |2 +-
vcl/source/bitmap/BitmapGaussianSeparableBlurFilter.cxx |4 ++--
vcl/source/bitmap/BitmapInterpolateScaleFilter.cxx|2 +-
vcl/source/bitmap/BitmapLightenFilter.cxx |2 +-
vcl/source/bitmap/BitmapMedianFilter.cxx |2 +-
vcl/source/bitmap/BitmapMonochromeFilter.cxx |2 +-
vcl/source/bitmap/BitmapMosaicFilter.cxx |8 +---
vcl/source/bitmap/BitmapPopArtFilter.cxx |2 +-
vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx|2 +-
vcl/source/bitmap/BitmapScaleSuperFilter.cxx |2 +-
vcl/source/bitmap/BitmapSeparableUnsharpenFilter.cxx |2 +-
vcl/source/bitmap/BitmapSepiaFilter.cxx |2 +-
vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx |2 +-
vcl/source/bitmap/BitmapSmoothenFilter.cxx|2 +-
vcl/source/bitmap/BitmapSobelGreyFilter.cxx |2 +-
vcl/source/bitmap/BitmapSolarizeFilter.cxx|2 +-
vcl/source/bitmap/bitmapfilter.cxx|4 ++--
48 files changed, 59 insertions(+), 61 deletions(-)
New commits:
commit 453fde35bb838febf73bfda0bd981ee270c9b12e
Author: Stephan Bergmann
AuthorDate: Fri Sep 7 17:39:58 2018 +0200
Commit: Stephan Bergmann
CommitDate: Fri Sep 7 20:42:59 2018 +0200
BitmapFilter::execute can be const
...after a little tweak to BitmapMosaicFilter
Change-Id: I76b8ffdbf719a9d7960e7f3dafeb3adeb2300ec5
Reviewed-on: https://gerrit.libreoffice.org/60165
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/vcl/BitmapAlphaClampFilter.hxx
b/include/vcl/BitmapAlphaClampFilter.hxx
index 0fc6274b6d4e..39c039cbd02c 100644
--- a/include/vcl/BitmapAlphaClampFilter.hxx
+++ b/include/vcl/BitmapAlphaClampFilter.hxx
@@ -25,7 +25,7 @@ public:
{
}
-virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) const override;
private:
sal_uInt8 mcThreshold;
diff --git a/include/vcl/BitmapColorQuantizationFilter.hxx
b/include/vcl/BitmapColorQuantizationFilter.hxx
index e695567a7bc0..170b0d88a471 100644
--- a/include/vcl/BitmapColorQuantizationFilter.hxx
+++ b/include/vcl/BitmapColorQuantizationFilter.hxx
@@ -28,7 +28,7 @@ public:
{
}
-virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) const override;
private:
sal_uInt16 mnNewColorCount;
diff --git a/include/vcl/BitmapConvolutionMatrixFilter.hxx
b/include/vcl/BitmapConvolutionMatrixFilter.hxx
index cae8c3d8a91c..928eaa9f0aa2 100644
--- a/include/vcl/BitmapConvolutionMatrixFilter.hxx
+++
[Libreoffice-bugs] [Bug 119246] Dimensions dialog has wrong values in fields "Line distance", "Left guide" and "Right guide"
https://bugs.documentfoundation.org/show_bug.cgi?id=119246 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|5.0.0.5 release |4.2.0.4 release Ever confirmed|0 |1 Summary|Dimensions dialog has wrong |Dimensions dialog has wrong |values in fields "Line |values in fields "Line |distance", "Left guide" and |distance", "Left guide" and |"Right guilde" |"Right guide" Keywords||notBibisectable, regression OS|Windows (All) |All CC||todven...@suomi24.fi --- Comment #2 from Buovjaga --- Repro. Tried to bibisect on Linux with 42max, but unfortunately it has many commits, where the dialog is shown in a huge size with only the OK, Cancel, Help buttons visible. When I did git bisect visualize, the remaining suspects included a repo commit with a large number of non-buildable commits. Arch Linux 64-bit Version: 6.2.0.0.alpha0+ Build ID: 033a68c49fe2b8aa397832d92d400eb0259ea809 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: threaded Built on September 5th 2018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/salgdi.h |3 ++-
vcl/inc/win/winlayout.hxx |8 +---
vcl/win/gdi/salfont.cxx | 11 ---
vcl/win/gdi/winlayout.cxx | 26 +-
4 files changed, 28 insertions(+), 20 deletions(-)
New commits:
commit 7cb3e475f2fb0162c7290414509de4fb8fe57e30
Author: Jan-Marek Glogowski
AuthorDate: Thu Sep 6 14:04:25 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Sep 7 20:27:01 2018 +0200
WIN add SalGraphics* to WinFontInstance
HFONT lookup in ImplDoSetFont depends on the mbVirDev of the
WinSalGraphics. Since we need too look up HFONTs for SalLayout
without changing the corresponding SalGraphics, add a pointer
to the WinFontInstance.
Change-Id: Idb6573ce7267f0019c2183be47621d0eaef8e57b
Reviewed-on: https://gerrit.libreoffice.org/60093
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 243d2cdc8fc5..9f30f57ecac8 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -170,9 +170,10 @@ private:
bool CacheGlyphs(const GenericSalLayout& rLayout);
bool DrawCachedGlyphs(const GenericSalLayout& rLayout);
-HFONT ImplDoSetFont(FontSelectPattern const & i_rFont, const
PhysicalFontFace * i_pFontFace, float& o_rFontScale, HFONT& o_rOldFont);
public:
+HFONT ImplDoSetFont(FontSelectPattern const & i_rFont, const
PhysicalFontFace * i_pFontFace, float& o_rFontScale, HFONT& o_rOldFont);
+
HDC getHDC() const { return mhLocalDC; }
void setHDC(HDC aNew) { mhLocalDC = aNew; }
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 066f7b587f6d..161b3666e06a 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -154,20 +154,22 @@ public:
GlyphCache& GetGlyphCache() { return maGlyphCache; }
bool hasHScale() const;
-void SetHFONT(const HFONT);
+void SetGraphics(WinSalGraphics*);
+WinSalGraphics* GetGraphics() const { return m_pGraphics; }
+
HFONT GetHFONT() const { return m_hFont; }
-void SetScale(float fScale) { m_fScale = fScale; }
float GetScale() const { return m_fScale; }
// Prevent deletion of the HFONT in the WinFontInstance destructor
// Used for the ScopedFont handling
-void UnsetHFONT() { m_hFont = nullptr; }
+void SetHFONT(HFONT hFont) { m_hFont = hFont; }
private:
explicit WinFontInstance(const PhysicalFontFace&, const
FontSelectPattern&);
virtual hb_font_t* ImplInitHbFont() override;
+WinSalGraphics *m_pGraphics;
HFONT m_hFont;
float m_fScale;
GlyphCache maGlyphCache;
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index e2734052c9c0..15a95ee98668 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -934,13 +934,10 @@ void WinSalGraphics::SetFont(LogicalFontInstance* pFont,
int nFallbackLevel)
HFONT hNewFont = pFontInstance->GetHFONT();
if (!hNewFont)
{
-float fFontScale = 1.0;
-hNewFont = ImplDoSetFont(pFont->GetFontSelectPattern(),
pFont->GetFontFace(), fFontScale, hOldFont);
-mpWinFontEntry[ nFallbackLevel ]->SetHFONT(hNewFont);
-mpWinFontEntry[ nFallbackLevel ]->SetScale(fFontScale);
+pFontInstance->SetGraphics(this);
+hNewFont = pFontInstance->GetHFONT();
}
-else
-hOldFont = ::SelectFont( getHDC(), hNewFont );
+hOldFont = ::SelectFont(getHDC(), hNewFont);
// keep default font
if( !mhDefFont )
@@ -1588,7 +1585,7 @@ ScopedFont::ScopedFont(WinSalGraphics & rData):
m_rData(rData), m_hOrigFont(null
if (m_rData.mpWinFontEntry[0])
{
m_hOrigFont = m_rData.mpWinFontEntry[0]->GetHFONT();
-m_rData.mpWinFontEntry[0]->UnsetHFONT();
+m_rData.mpWinFontEntry[0]->SetHFONT(nullptr);
}
}
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 3800fcd9adc3..a1d76c8026a4 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -307,13 +307,16 @@ std::unique_ptr
WinSalGraphics::GetTextLayout(ImplLayoutArgs& /*rArgs
assert(mpWinFontEntry[nFallbackLevel]->GetFontFace());
+mpWinFontEntry[nFallbackLevel]->SetGraphics(this);
GenericSalLayout *aLayout = new
GenericSalLayout(*mpWinFontEntry[nFallbackLevel]);
return std::unique_ptr(aLayout);
}
WinFontInstance::WinFontInstance(const PhysicalFontFace& rPFF, const
FontSelectPattern& rFSP)
: LogicalFontInstance(rPFF, rFSP)
+, m_pGraphics(nullptr)
, m_hFont(nullptr)
+, m_fScale(1.0f)
{
}
@@ -335,8 +338,12 @@ static hb_blob_t* getFontTable(hb_face_t* /*face*/,
hb_tag_t nTableTag, void* pU
{
sal_uLong nLength = 0;
unsigned char* pBuffer = nullptr;
-HFONT hFont = static_cast(pUserData);
-HDC hDC = GetDC(nullptr);
+WinFontInstance* pFont = static_cast(pUserData);
+HDC hDC = pFont->GetGraphics()->getHDC();
+HFONT hFont = pFont->GetHFONT();
+assert(hDC);
+
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/salgdi.h| 13 ---
vcl/win/gdi/salfont.cxx | 55 ++--
vcl/win/gdi/salgdi.cxx |6 -
3 files changed, 17 insertions(+), 57 deletions(-)
New commits:
commit 334df91c6e464fe6434500f63e2fb12438722845
Author: Jan-Marek Glogowski
AuthorDate: Thu Sep 6 14:00:29 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Fri Sep 7 20:26:18 2018 +0200
WIN drop mhFonts[MAX_FALLBACK]
Everything now uses the HFONT from WinFontInstance, so there
is no need for the additional fallback array.
Change-Id: I15a197b262633569cb95c37689561db5323e1115
Reviewed-on: https://gerrit.libreoffice.org/60092
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 32a104bef88e..243d2cdc8fc5 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -156,19 +156,6 @@ private:
boolmbScreen : 1; // is Screen compatible
HWNDmhWnd; // Window-Handle, when
Window-Graphics
-/** HFONT lifecycle
- *
- * The HFONT has to be shared between mhFonts and mpWinFontEntry.
- * As mpWinFontEntry is reference counted and just freed in SetFont, the
HFONT is
- * transferred from mhFonts to the mpWinFontEntry.
- *
- * We need the mhFonts list, as embedded fonts don't have a corresponding
WinFontInstance
- * so for these there is just the mhFonts entry.
- *
- * The HFONT object can just be assigned to mhFonts _or_ mpWinFontEntry!
- **/
-
-HFONT mhFonts[ MAX_FALLBACK ];// Font + Fallbacks
rtl::Reference
mpWinFontEntry[ MAX_FALLBACK ]; // pointer to the
most recent font instance
HRGNmhRegion; // vcl::Region Handle
diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index bed9c7a22376..e2734052c9c0 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -913,22 +913,17 @@ void WinSalGraphics::SetFont(LogicalFontInstance* pFont,
int nFallbackLevel)
// return early if there is no new font
if( !pFont )
{
-// deselect still active font
-if (mhDefFont)
-{
-::SelectFont(getHDC(), mhDefFont);
-mhDefFont = nullptr;
-}
+if (!mpWinFontEntry[nFallbackLevel].is())
+return;
+
+// select original DC font
+assert(mhDefFont);
+::SelectFont(getHDC(), mhDefFont);
+mhDefFont = nullptr;
+
// release no longer referenced font handles
for( int i = nFallbackLevel; i < MAX_FALLBACK; ++i )
-{
-if( mhFonts[i] )
-{
-::DeleteFont( mhFonts[i] );
-mhFonts[ i ] = nullptr;
-}
mpWinFontEntry[i] = nullptr;
-}
return;
}
@@ -953,16 +948,8 @@ void WinSalGraphics::SetFont(LogicalFontInstance* pFont,
int nFallbackLevel)
else
{
// release no longer referenced font handles
-for( int i = nFallbackLevel; i < MAX_FALLBACK; ++i )
-{
-if( mhFonts[i] )
-{
-::DeleteFont( mhFonts[i] );
-mhFonts[i] = nullptr;
-}
-if (i > nFallbackLevel)
-mpWinFontEntry[i] = nullptr;
-}
+for( int i = nFallbackLevel + 1; mpWinFontEntry[i].is() && i <
MAX_FALLBACK; ++i )
+mpWinFontEntry[i] = nullptr;
}
// now the font is live => update font face
@@ -973,8 +960,8 @@ void WinSalGraphics::SetFont(LogicalFontInstance* pFont,
int nFallbackLevel)
void WinSalGraphics::GetFontMetric( ImplFontMetricDataRef& rxFontMetric, int
nFallbackLevel )
{
// temporarily change the HDC to the font in the fallback level
-assert(!mhFonts[nFallbackLevel] && mpWinFontEntry[nFallbackLevel]);
-const HFONT hOldFont = SelectFont(getHDC(),
mpWinFontEntry[nFallbackLevel]->GetHFONT());
+rtl::Reference pFontInstance =
mpWinFontEntry[nFallbackLevel];
+const HFONT hOldFont = SelectFont(getHDC(), pFontInstance->GetHFONT());
wchar_t aFaceName[LF_FACESIZE+60];
if( GetTextFaceW( getHDC(), SAL_N_ELEMENTS(aFaceName), aFaceName ) )
@@ -985,7 +972,7 @@ void WinSalGraphics::GetFontMetric( ImplFontMetricDataRef&
rxFontMetric, int nFa
const RawFontData aHheaRawData(getHDC(), nHheaTag);
const RawFontData aOS2RawData(getHDC(), nOS2Tag);
-
rxFontMetric->SetMinKashida(mpWinFontEntry[nFallbackLevel]->GetKashidaWidth());
+rxFontMetric->SetMinKashida(pFontInstance->GetKashidaWidth());
// get the font metric
OUTLINETEXTMETRICW aOutlineMetric;
@@ -1006,7 +993,7 @@ void WinSalGraphics::GetFontMetric( ImplFontMetricDataRef&
rxFontMetric, int nFa
rxFontMetric->SetSlant( 0 );
// transformation dependent font metrics
-
[Libreoffice-bugs] [Bug 119156] Font anchors not working for combining characters inserted via menu insert -> special characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=119156 --- Comment #4 from Georgy --- I suppose you haven't installed included font. Included font have anchors to specify combining position. The problem is if we have text with normal character and combining character in span, then LO shows combination of two characters as if there were no anchors. If font doesn't have anchors in tested character combination you won't see the difference. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119743] Libreoffice 6.1 base: can't save special options
https://bugs.documentfoundation.org/show_bug.cgi?id=119743 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Priority|medium |high OS|Windows (All) |All Hardware|x86 (IA32) |All Status|UNCONFIRMED |NEW Severity|normal |major Keywords||regression Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this with a brand new odb file embedded hsqldb. I checked "End text lines with CR+LF", clicked "OK" button. Then when reopening, the corresponding checkbox was unchecked. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119751] Microsoft 365 Support
https://bugs.documentfoundation.org/show_bug.cgi?id=119751 Marcus Starc changed: What|Removed |Added URL||http://www.microsoftoutlook ||office365.com/outlook-365-s ||upport.html Keywords||accessibility -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119751] New: Microsoft 365 Support
https://bugs.documentfoundation.org/show_bug.cgi?id=119751 Bug ID: 119751 Summary: Microsoft 365 Support Product: LibreOffice Version: 3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: starcmar...@gmail.com Description: Not every person in the bunch to take a gander at a PC and make sense of it. They need the preparation that is important so as to utilize each program. On the off chance those projects are not working appropriately, Microsoft 365 Support could profit the workplace staff. Microsoft 365 is the service suite of application for Microsoft products, which provides reliable help and support for their product. Microsoft products are mostly used in the corporate business sectors. If you are genuine users of Microsoft 365 and getting some errors while using your Microsoft 365 and you do not understand what should you do? Then don’t worry just visit our website and dial our toll-free number and discuss your issues with our technician. Once you visit your website you also know about our other services. Our technicians were able to clear all your doubts regarding your Microsoft 365 as well as fix your issues as fast as possible. Read More: - http://www.microsoftoutlookoffice365.com/outlook-365-support.html Actual Results: Getting Tech Support Expected Results: Resolved Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/salhelper salhelper/source
include/salhelper/simplereferenceobject.hxx | 22 ++
salhelper/source/simplereferenceobject.cxx | 15 ---
2 files changed, 6 insertions(+), 31 deletions(-)
New commits:
commit c5483edae01e4145c80439c5070e0bf2fad51186
Author: Stephan Bergmann
AuthorDate: Fri Sep 7 10:48:41 2018 +0200
Commit: Stephan Bergmann
CommitDate: Fri Sep 7 20:07:45 2018 +0200
Drop workaround for old MSVC that no longer appears necessary with MSVC 2017
The comments talk about unspecific "compilation and/or linking errors" with
MSVC
2008 and 2013, but building with latest MSVC 2017 at least works fine now,
so
assume the workaround is no longer needed. (Theoretically, external code
being
compiled with older MSVC could run into problems now, but lets take that
risk of
becoming slightly build-time incompatible here.)
Change-Id: I9e20be355c765c3a881502773963a61305eb00f3
Reviewed-on: https://gerrit.libreoffice.org/60135
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/salhelper/simplereferenceobject.hxx
b/include/salhelper/simplereferenceobject.hxx
index d8f86f52d00a..2745f0d848fd 100644
--- a/include/salhelper/simplereferenceobject.hxx
+++ b/include/salhelper/simplereferenceobject.hxx
@@ -51,8 +51,8 @@ namespace salhelper {
The same problem as with operators new and delete would also be there with
operators new[] and delete[]. But since arrays of reference-counted
-objects are of no use, anyway, it seems best to simply declare and not
-define (private) operators new[] and delete[].
+objects are of no use, anyway, it seems best to simply
+define operators new[] and delete[] as deleted.
*/
class SALHELPER_DLLPUBLIC SimpleReferenceObject
{
@@ -102,23 +102,13 @@ private:
*/
void operator =(SimpleReferenceObject) SAL_DELETED_FUNCTION;
-/// @cond INTERNAL
-
-#ifdef _MSC_VER
-/* We can't now have these private with MSVC2008 at least, it leads to
- compilation errors in xmloff and other places.
-*/
-protected:
-#endif
-/** not implemented (see general class documentation)
+/** see general class documentation
*/
-static void * operator new[](std::size_t);
+static void * operator new[](std::size_t) SAL_DELETED_FUNCTION;
-/** not implemented (see general class documentation)
+/** see general class documentation
*/
-static void operator delete[](void * pPtr);
-
-/// @endcond
+static void operator delete[](void * pPtr) SAL_DELETED_FUNCTION;
};
}
diff --git a/salhelper/source/simplereferenceobject.cxx
b/salhelper/source/simplereferenceobject.cxx
index fcf130d9d192..c07c922528a6 100644
--- a/salhelper/source/simplereferenceobject.cxx
+++ b/salhelper/source/simplereferenceobject.cxx
@@ -59,19 +59,4 @@ void SimpleReferenceObject::operator delete(void * pPtr,
std::nothrow_t const &)
#endif // WNT
}
-#ifdef _MSC_VER
-
-/* This operator is supposed to be unimplemented, but that now leads
- * to compilation and/or linking errors with MSVC2008. Problem still
- * there with MSVC2013. As it can be left unimplemented just fine with
- * other compilers, presumably it is never called. So do implement it
- * then to avoid the compilation and/or linking errors, but make it
- * crash intentionally if called.
- */
-void SimpleReferenceObject::operator delete[](void * /* pPtr */)
-{
-abort();
-}
-#endif
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/bitmap/BitmapColorQuantizationFilter.cxx | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
New commits:
commit 91f2b2b88731bd083c6a5218ae4eb35126e4b872
Author: Stephan Bergmann
AuthorDate: Fri Sep 7 15:25:33 2018 +0200
Commit: Stephan Bergmann
CommitDate: Fri Sep 7 20:07:17 2018 +0200
Multiple calls of BitmapColorQuantizationFilter::execute
...should probably be independent of each other
Change-Id: I22fb860a5a197d5f3f0f8706782e25d07511a1d9
Reviewed-on: https://gerrit.libreoffice.org/60153
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/source/bitmap/BitmapColorQuantizationFilter.cxx
b/vcl/source/bitmap/BitmapColorQuantizationFilter.cxx
index 13e88341c0d9..643354515f06 100644
--- a/vcl/source/bitmap/BitmapColorQuantizationFilter.cxx
+++ b/vcl/source/bitmap/BitmapColorQuantizationFilter.cxx
@@ -8,6 +8,10 @@
*
*/
+#include
+
+#include
+
#include
#include
#include
@@ -32,10 +36,9 @@ BitmapEx BitmapColorQuantizationFilter::execute(BitmapEx
const& aBitmapEx)
Bitmap::ScopedReadAccess pRAcc(aBitmap);
sal_uInt16 nBitCount;
-if (mnNewColorCount > 256)
-mnNewColorCount = 256;
+auto const cappedNewColorCount = std::min(mnNewColorCount,
sal_uInt16(256));
-if (mnNewColorCount < 17)
+if (cappedNewColorCount < 17)
nBitCount = 4;
else
nBitCount = 8;
@@ -104,7 +107,7 @@ BitmapEx BitmapColorQuantizationFilter::execute(BitmapEx
const& aBitmapEx)
}
}
-BitmapPalette aNewPal(mnNewColorCount);
+BitmapPalette aNewPal(cappedNewColorCount);
std::qsort(pCountTable.get(), nTotalColors,
sizeof(PopularColorCount),
[](const void* p1, const void* p2) {
@@ -122,7 +125,7 @@ BitmapEx BitmapColorQuantizationFilter::execute(BitmapEx
const& aBitmapEx)
return nRet;
});
-for (sal_uInt16 n = 0; n < mnNewColorCount; n++)
+for (sal_uInt16 n = 0; n < cappedNewColorCount; n++)
{
const PopularColorCount& rPop = pCountTable[n];
aNewPal[n] = BitmapColor(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119750] New: Failure to install
https://bugs.documentfoundation.org/show_bug.cgi?id=119750 Bug ID: 119750 Summary: Failure to install Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: win...@swbell.net Description: The latest version asked for administrator permission in order install and removed my previous installed version when uninstalling. I am the administrator and sole user on this computer. No other program does the same so is there a bug in not correctly detecting administrator permission. I don't know why you would want that anyway, surely it is unnecessary, or it was there before and the W10 updates changed something. Please fix. I love this suite. Steps to Reproduce: 1.No 2. 3. Actual Results: No Expected Results: No Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119156] Font anchors not working for combining characters inserted via menu insert -> special characters.
https://bugs.documentfoundation.org/show_bug.cgi?id=119156 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #3 from Buovjaga --- For me, the diacritic in the bottom paragraph is above the character (perfectly in the middle). So not like in your screenshot, where it is inside it. I suppose I set to NEW, purely by observing the file. In 3.6.7, the bottom paragraph looks the same as the top. Arch Linux 64-bit Version: 6.2.0.0.alpha0+ Build ID: 033a68c49fe2b8aa397832d92d400eb0259ea809 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: threaded Built on September 5th 2018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119286] Sanitize documents using "Find & Replace" getting slower and slower
https://bugs.documentfoundation.org/show_bug.cgi?id=119286 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi, ||vmik...@collabora.co.uk Status|UNCONFIRMED |NEW Blocks||102847 Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #4 from Buovjaga --- Repro slowness 6.2 vs. 3.6. Adding Cc: to Miklos Vajna so he can comment on the blamed commit Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 Buovjaga changed: What|Removed |Added Depends on||119286 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119286 [Bug 119286] Sanitize documents using "Find & Replace" getting slower and slower -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119298] Table alignment changes from automatic to left (or from left) after moving the inner table border of an embedded table in Webview with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=119298 Buovjaga changed: What|Removed |Added Keywords||bibisected, bisected, ||regression CC||qui...@gmail.com, ||todven...@suomi24.fi --- Comment #3 from Buovjaga --- I don't see the tables in webview so I don't know how to repro. Maybe Tomaž will anyway. Adding Cc: to Tomaž Vajngerl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
