[Libreoffice-commits] core.git: sc/source

2018-11-28 Thread Libreoffice Gerrit user
 sc/source/ui/view/drawview.cxx |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 12877c3ec0bb503dcd0d6d9b9aa83e2a1e5e7ac4
Author: Armin Le Grand 
AuthorDate: Tue Nov 27 13:53:59 2018 +0100
Commit: Armin Le Grand 
CommitDate: Thu Nov 29 08:55:54 2018 +0100

No GridOffset support for PDF or Print

Change-Id: I40c1128ef2fb8860e883016344138bb84f68c2de
Reviewed-on: https://gerrit.libreoffice.org/64112
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 

diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx
index 28af22f58c34..a19d7ce48c84 100644
--- a/sc/source/ui/view/drawview.cxx
+++ b/sc/source/ui/view/drawview.cxx
@@ -1181,6 +1181,18 @@ namespace sdr
 
 bool ObjectContactOfScDrawView::supportsGridOffsets() const
 {
+// no GridOffset support for printer
+if(isOutputToPrinter())
+{
+return false;
+}
+
+// no GridOffset support for PDF export
+if(isOutputToPDFFile())
+{
+return false;
+}
+
 // yes - we support it
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

2018-11-28 Thread Libreoffice Gerrit user
 wsd/DocumentBroker.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit dc4712c3f9e3ad541f5d4348a47604665050596f
Author: Miklos Vajna 
AuthorDate: Thu Nov 29 08:52:57 2018 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 29 08:52:57 2018 +0100

wsd: limit_load_secs is not interesting for the mobile case, either

Change-Id: I92ad4bea80c261cc802ccdbebc1ce2990260853e

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 87eff69b6..c2dda9221 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -250,12 +250,12 @@ void DocumentBroker::pollThread()
 uint64_t adminSent = 0;
 uint64_t adminRecv = 0;
 auto lastBWUpdateTime = std::chrono::steady_clock::now();
+
+int limit_load_secs = 
LOOLWSD::getConfigValue("per_document.limit_load_secs", 100);
 auto loadDeadline = std::chrono::steady_clock::now() + 
std::chrono::seconds(limit_load_secs);
 #endif
 auto last30SecCheckTime = std::chrono::steady_clock::now();
 
-int limit_load_secs = 
LOOLWSD::getConfigValue("per_document.limit_load_secs", 100);
-
 // Main polling loop goodness.
 while (!_stop && _poll->continuePolling() && !TerminationFlag)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

2018-11-28 Thread Libreoffice Gerrit user
 wsd/DocumentBroker.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e312f90169b35a0ad7db48252a9d6d8c526140a
Author: Miklos Vajna 
AuthorDate: Thu Nov 29 08:51:26 2018 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 29 08:51:26 2018 +0100

Fix gtk build: -Werror=unused-but-set-variable

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 8235c073c..87eff69b6 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -250,11 +250,11 @@ void DocumentBroker::pollThread()
 uint64_t adminSent = 0;
 uint64_t adminRecv = 0;
 auto lastBWUpdateTime = std::chrono::steady_clock::now();
+auto loadDeadline = std::chrono::steady_clock::now() + 
std::chrono::seconds(limit_load_secs);
 #endif
 auto last30SecCheckTime = std::chrono::steady_clock::now();
 
 int limit_load_secs = 
LOOLWSD::getConfigValue("per_document.limit_load_secs", 100);
-auto loadDeadline = std::chrono::steady_clock::now() + 
std::chrono::seconds(limit_load_secs);
 
 // Main polling loop goodness.
 while (!_stop && _poll->continuePolling() && !TerminationFlag)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: external/xmlsec

2018-11-28 Thread Libreoffice Gerrit user
 external/xmlsec/README |   37 -
 1 file changed, 4 insertions(+), 33 deletions(-)

New commits:
commit 6ddc2fb9f476895706915bddbe7431400e773597
Author: Miklos Vajna 
AuthorDate: Wed Nov 28 21:28:54 2018 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 29 08:45:53 2018 +0100

libxmlsec: rewrite README now that we no longer patch the library

Change-Id: I8900e399df970056c8ac781c05e9eff6a43c31c7
Reviewed-on: https://gerrit.libreoffice.org/64195
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/external/xmlsec/README b/external/xmlsec/README
index 2484bf2300e4..9f2c5e5e7162 100644
--- a/external/xmlsec/README
+++ b/external/xmlsec/README
@@ -1,34 +1,5 @@
-XML signing, etc. From [http://www.aleksey.com/xmlsec/]. Heavily patched.
-
-The XML Security library has been modified, so that there is NO verification of
-the certificate during sign or verification operation. On Windows this was done
-in the function xmlSecMSCryptoX509StoreVerify (file src/mscrypto/x509vfy.c) and
-on UNIX in xmlSecNssX509StoreVerify (file src/nss/x509vfy.c).
-
-The implementation creates certificates from all of the X509Data children, such
-as X509IssuerSerial and X509Certificate and stores them in a certificate store
-(see xmlsec/src/mscrypto/x509.c:xmlSecMSCryptoX509DataNodeRead). It must then
-find the certificate containing the public key which is used for validation
-within that store. This is done in xmlSecMSCryptoX509StoreVerify. This function
-however only takes those certificates into account which can be validated. This
-was changed by the patch xmlsec1-noverify.patch, which prevents this 
certificate
-validation.
-
-xmlSecMSCryptoX509StoreVerify iterates over all certificates contained or
-referenced in the X509Data elements and selects one which is no issuer of any 
of
-the other certificates. This certificate is not necessarily the one which was
-used for signing but it must contain the proper validation key, which is
-sufficient to validate the signature. See 
-http://www.w3.org/TR/xmldsig-core/#sec-X509Data 
-for details.
-
-There is a flag XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS that can be set
-in a xmlSecKeyInfoCtx (see function xmlSecNssKeyDataX509XmlRead, in file
-src/nss/x509.c), which indicates that one can turn off the validation. However,
-setting it will cause that the validation key is not found. If the flag is set,
-then the key is not extracted from the certificate store which contains all the
-certificates of the X509Data elements. In other words, the certificates which
-are delivered within the XML signature are not used when looking for suitable
-validation key.
-
+XML signing, etc. From [http://www.aleksey.com/xmlsec/].
 
+The certificate vertification functionality of libxmlsec is not used, both the
+mscng and nss backends specify the
+XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS flag during verification.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/Storage.cpp wsd/Storage.hpp

2018-11-28 Thread Libreoffice Gerrit user
 wsd/DocumentBroker.cpp |   18 +-
 wsd/Storage.cpp|   12 ++--
 wsd/Storage.hpp|   17 -
 3 files changed, 27 insertions(+), 20 deletions(-)

New commits:
commit ae3fec55d41bde6c8e7e50986ae30a58d87a
Author: Miklos Vajna 
AuthorDate: Thu Nov 29 08:42:43 2018 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 29 08:43:02 2018 +0100

StorageBase::FileInfo: make members private

Which shows that the _size member was unused.

Change-Id: Ic6e74659050b86cd9057971ec21623fad75f0c39

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index fed34213e..8235c073c 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -526,7 +526,7 @@ bool DocumentBroker::load(const 
std::shared_ptr& session, const s
 if (wopifileinfo->getDisableExport())
 wopifileinfo->setHideExportOption(true);
 
-wopiInfo->set("BaseFileName", wopiStorage->getFileInfo()._filename);
+wopiInfo->set("BaseFileName", 
wopiStorage->getFileInfo().getFilename());
 wopiInfo->set("HidePrintOption", wopifileinfo->getHidePrintOption());
 wopiInfo->set("HideSaveOption", wopifileinfo->getHideSaveOption());
 wopiInfo->set("HideExportOption", wopifileinfo->getHideExportOption());
@@ -551,7 +551,7 @@ bool DocumentBroker::load(const 
std::shared_ptr& session, const s
 session->sendMessage("wopi: " + wopiInfoString);
 
 // Mark the session as 'Document owner' if WOPI hosts supports it
-if (userId == _storage->getFileInfo()._ownerId)
+if (userId == _storage->getFileInfo().getOwnerId())
 {
 LOG_DBG("Session [" << sessionId << "] is the document owner");
 session->setDocumentOwner(true);
@@ -604,21 +604,21 @@ bool DocumentBroker::load(const 
std::shared_ptr& session, const s
 
 if (firstInstance)
 {
-_documentLastModifiedTime = fileInfo._modifiedTime;
+_documentLastModifiedTime = fileInfo.getModifiedTime();
 LOG_DBG("Document timestamp: " << _documentLastModifiedTime);
 }
 else
 {
 // Check if document has been modified by some external action
-LOG_TRC("Document modified time: " << fileInfo._modifiedTime);
+LOG_TRC("Document modified time: " << fileInfo.getModifiedTime());
 static const Poco::Timestamp Zero(Poco::Timestamp::fromEpochTime(0));
 if (_documentLastModifiedTime != Zero &&
-fileInfo._modifiedTime != Zero &&
-_documentLastModifiedTime != fileInfo._modifiedTime)
+fileInfo.getModifiedTime() != Zero &&
+_documentLastModifiedTime != fileInfo.getModifiedTime())
 {
 LOG_DBG("Document " << _docKey << "] has been modified behind our 
back. " <<
 "Informing all clients. Expected: " << 
_documentLastModifiedTime <<
-", Actual: " << fileInfo._modifiedTime);
+", Actual: " << fileInfo.getModifiedTime());
 
 _documentChangedInStorage = true;
 std::string message = "close: documentconflict";
@@ -703,7 +703,7 @@ bool DocumentBroker::load(const 
std::shared_ptr& session, const s
 _uriJailed = Poco::URI(Poco::URI("file://"), 
localPathEncoded).toString();
 _uriJailedAnonym = Poco::URI(Poco::URI("file://"), 
LOOLWSD::anonymizeUrl(localPath)).toString();
 
-_filename = fileInfo._filename;
+_filename = fileInfo.getFilename();
 
 // Use the local temp file's timestamp.
 _lastFileModifiedTime = 
Poco::File(_storage->getRootFilePath()).getLastModified();
@@ -840,7 +840,7 @@ bool DocumentBroker::saveToStorageInternal(const 
std::string& sessionId,
 _lastSaveTime = std::chrono::steady_clock::now();
 
 // Save the storage timestamp.
-_documentLastModifiedTime = _storage->getFileInfo()._modifiedTime;
+_documentLastModifiedTime = 
_storage->getFileInfo().getModifiedTime();
 
 // After a successful save, we are sure that document in the 
storage is same as ours
 _documentChangedInStorage = false;
diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index 7ed86bc3c..b40bebfb3 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -350,8 +350,8 @@ StorageBase::SaveResult 
LocalStorage::saveLocalFileToStorage(const Authorization
 
 // update its fileinfo object. This is used later to check if someone 
else changed the
 // document while we are/were editing it
-getFileInfo()._modifiedTime = 
Poco::File(getUri().getPath()).getLastModified();
-LOG_TRC("New FileInfo modified time in storage " << 
getFileInfo()._modifiedTime);
+
getFileInfo().setModifiedTime(Poco::File(getUri().getPath()).getLastModified());
+LOG_TRC("New FileInfo modified time in storage " << 
getFileInfo().getModifiedTime());
 }
 catch (const Poco::Exception& exc)
 {
@@ -660,7 +660,7 @@ std::string WopiSt

Re: Tinberbox MacOSX-x86_64_49-TDF failure - ld: file not found

2018-11-28 Thread Stephan Bergmann

On 28/11/2018 19:50, Luke Benes wrote:

In this range: 
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=313a0efb1d703a36030a7e5e55bd308c7e4650f3..ae3309c908311248f1580a894f197732964bfac2

@49 started failing with:

https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1543237201.21995

   [build LOC] vcl
   [build SED] CustomTarget/wizards/share/dialog.xlc
   [build SED] CustomTarget/wizards/share/script.xlc
   [build PKG] wizards_properties
   [build LOC] wizards
   [build LOC] writerperfect
   [build LOC] xmlsecurity
   [build CUS] instsetoo_native/setup
   [build LOC] external
   [build CHK] external
   [build SLC] external
   [build UPK] boost_1_66_0.tar.bz2
   [build LNK] Library/libuno_sal.dylib.3
   [build UPK] icu4c-63_1-src.tgz
   [build UPK] nss-3.38-with-nspr-4.19.tar.gz
   NEXTld: file not found: 
/Users/cloph/tb/workdir/CObject/sal/osl/unx/backtrace.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/compat.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/debugbase.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/filepath.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/loadmodulerelative.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/log.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/signalshared.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/utility.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_arena.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_cache.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_fini.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_global.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/bootstrap.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/byteseq.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/cipher.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/cmdargs.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/crc.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/digest.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/hash.
7157  NEXTclang: error: linker command failed with exit code 1 (use -v to 
see invocation)
7158  NEXTmake[1]: *** 
[/Users/cloph/tb/instdir/LibreOfficeDev.app/Contents/Frameworks/libuno_sal.dylib.3]
 Error 1
7159  make[1]: *** Waiting for unfinished jobs
7160  NEXTmake: *** [build] Error 2


possibility caused by this commit?
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ab9d95e6073d

Use -filelist with macOS linker


Yes, and likely fixed with 
 
"gbuild: MacOSX: use tr instead of sed for newlines", I'd guess.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/source

2018-11-28 Thread Libreoffice Gerrit user
 sc/source/ui/unoobj/chart2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5908f1ea0a19482a999c2e00aeaae05eabc1e8e6
Author: Markus Mohrhard 
AuthorDate: Thu Nov 29 00:04:58 2018 +0100
Commit: Markus Mohrhard 
CommitDate: Thu Nov 29 07:40:06 2018 +0100

tdf#105236, only take number format from numeric cells

Change-Id: I55deaa1f0579582a45dc1e10bb578b680eb98647
Reviewed-on: https://gerrit.libreoffice.org/64200
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 
(cherry picked from commit fb04e7180cdf656dbbd3daa9c81615d9478229e0)
Reviewed-on: https://gerrit.libreoffice.org/64203

diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index 448652397cee..5fc78815f602 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -3145,7 +3145,7 @@ sal_uInt32 getDisplayNumberFormat(const ScDocument* pDoc, 
const ScAddress& rPos)
 for (const Item& rItem : m_aDataArray)
 {
 ScRefCellValue aCell(*m_pDocument, rItem.mAddress);
-if (!aCell.isEmpty())
+if (!aCell.isEmpty() && aCell.hasNumeric())
 {
 return 
static_cast(getDisplayNumberFormat(m_pDocument, rItem.mAddress));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: compilerplugins/clang include/svx svx/source

2018-11-28 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |2 --
 include/svx/svdedtv.hxx|3 +--
 svx/source/svdraw/svdedtv.cxx  |6 +-
 3 files changed, 2 insertions(+), 9 deletions(-)

New commits:
commit 07c607b8a20cfa3c0022204db201fe2739f7b8cc
Author: Noel Grandin 
AuthorDate: Mon Nov 26 10:59:57 2018 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 29 07:19:03 2018 +0100

remove unused SdrInsertFlags enum value

Change-Id: Ic68f2dc4e3752859c943d9885b52b70f33896aea
Reviewed-on: https://gerrit.libreoffice.org/64172
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index bbb57be316e4..a54619908b6d 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -492,8 +492,6 @@ include/svx/ruler.hxx:60
 enum SvxRulerDragFlags OBJECT_LEFT_INDENT_ONLY
 include/svx/sdtakitm.hxx:31
 enum SdrTextAniKind Blink
-include/svx/svdedtv.hxx:65
-enum SdrInsertFlags NOBROADCAST
 include/svx/svdhdl.hxx:108
 enum BitmapMarkerKind RectPlus_7x7
 include/svx/svdograf.hxx:52
diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 6fc2e1aab75f..af60deaac0f6 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -62,11 +62,10 @@ enum class SdrInsertFlags
 ADDMARK = 0x0002, /* object will be added an existing selection  */
 SETDEFATTR  = 0x0004, /* actual attributes (+StyleSheet) are assigned to 
the object */
 SETDEFLAYER = 0x0008, /* actual layer is assigned to the object */
-NOBROADCAST = 0x0010, /* insert with NbcInsertObject() for SolidDragging */
 };
 namespace o3tl
 {
-template<> struct typed_flags : 
is_typed_flags {};
+template<> struct typed_flags : 
is_typed_flags {};
 }
 
 class SVX_DLLPUBLIC SdrEditView : public SdrMarkView
diff --git a/svx/source/svdraw/svdedtv.cxx b/svx/source/svdraw/svdedtv.cxx
index 2197c3fbc42e..a3b20b853068 100644
--- a/svx/source/svdraw/svdedtv.cxx
+++ b/svx/source/svdraw/svdedtv.cxx
@@ -971,11 +971,7 @@ bool SdrEditView::InsertObjectAtView(SdrObject* pObj, 
SdrPageView& rPV, SdrInser
 pObj->SetMergedItemSet(maDefaultAttr);
 }
 if (!pObj->IsInserted()) {
-if (nOptions & SdrInsertFlags::NOBROADCAST) {
-rPV.GetObjList()->NbcInsertObject(pObj, SAL_MAX_SIZE);
-} else {
-rPV.GetObjList()->InsertObject(pObj, SAL_MAX_SIZE);
-}
+rPV.GetObjList()->InsertObject(pObj, SAL_MAX_SIZE);
 }
 if( IsUndoEnabled() )
 AddUndo(GetModel()->GetSdrUndoFactory().CreateUndoNewObject(*pObj));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basctl/source basic/source desktop/source fpicker/source framework/source helpcompiler/source l10ntools/source oox/source package/source scripting/source sc/source sd/s

2018-11-28 Thread Libreoffice Gerrit user
 basctl/source/basicide/bastype3.cxx   |   95 -
 basic/source/classes/sb.cxx   |   29 
 desktop/source/migration/services/oo3extensionmigration.cxx   |7 
 fpicker/source/office/OfficeFilePicker.cxx|6 
 framework/source/dispatch/interceptionhelper.cxx  |2 
 framework/source/layoutmanager/toolbarlayoutmanager.cxx   |7 
 helpcompiler/source/HelpLinker.cxx|4 
 l10ntools/source/po.cxx   |7 
 oox/source/helper/propertymap.cxx |   17 
 oox/source/ole/axbinaryreader.cxx |4 
 oox/source/ole/axbinarywriter.cxx |   24 
 package/source/xstor/xstorage.cxx |   17 
 sc/source/core/data/table5.cxx|   18 
 sc/source/core/tool/addincol.cxx  |   17 
 sc/source/core/tool/adiasync.cxx  |   25 
 sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx|   21 
 sc/source/ui/app/inputwin.cxx |   20 
 sc/source/ui/dbgui/sfiltdlg.cxx   |   19 
 sc/source/ui/docshell/docfunc.cxx |   11 
 sc/source/ui/navipi/content.cxx   |   20 
 sc/source/ui/unoobj/cellsuno.cxx  |   31 
 sc/source/ui/unoobj/listenercalls.cxx |   33 
 sc/source/ui/view/gridwin2.cxx|2 
 scripting/source/provider/BrowseNodeFactoryImpl.cxx   |   21 
 sd/source/ui/func/smarttag.cxx|7 
 sfx2/source/doc/saveastemplatedlg.cxx |7 
 sfx2/source/doc/templatedlg.cxx   |   14 
 slideshow/source/engine/slide/slideimpl.cxx   |   13 
 svx/source/form/fmvwimp.cxx   |7 
 svx/source/svdraw/svddrgmt.cxx|   33 
 svx/source/svdraw/svdmark.cxx |2 
 svx/source/svdraw/svdobj.cxx  |9 
 sw/source/core/access/accmap.cxx  |   14 
 sw/source/core/undo/undel.cxx |   17 
 sw/source/core/unocore/unoportenum.cxx|   35 
 sw/source/filter/html/swhtml.cxx  |   10 
 sw/source/filter/ww8/docxattributeoutput.cxx  |   32 
 sw/source/filter/ww8/wrtw8esh.cxx |   17 
 sw/source/filter/ww8/ww8graf.cxx  |   15 
 sw/source/ui/dialog/uiregionsw.cxx|   39 
 sw/source/ui/frmdlg/frmpage.cxx   |9 
 sw/source/uibase/app/docsh2.cxx   |   11 
 sw/source/uibase/docvw/PostItMgr.cxx  |   13 
 ucb/source/ucp/webdav-neon/NeonHeadRequest.cxx|7 
 unodevtools/source/skeletonmaker/cppcompskeleton.cxx  |   20 
 unotools/source/misc/fontdefs.cxx |2 
 vcl/opengl/gdiimpl.cxx|7 
 vcl/source/control/notebookbar.cxx|2 
 vcl/source/filter/ipdf/pdfdocument.cxx|9 
 vcl/unx/generic/fontmanager/fontmanager.cxx   |   13 
 vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx  |4 
 xmloff/source/draw/sdxmlexp.cxx   |  719 --
 xmloff/source/draw/shapeimport.cxx|   67 
 xmloff/source/table/XMLTableImport.cxx|   21 
 xmloff/source/text/txtparai.cxx   |2 
 xmlscript/source/xmldlg_imexp/xmldlg_expmodels.cxx|7 
 xmlsecurity/source/framework/saxeventkeeperimpl.cxx   |   10 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |6 
 58 files changed, 748 insertions(+), 909 deletions(-)

New commits:
commit 21de55596c0fdc2be736c6d0369bd9d3783020be
Author: Noel Grandin 
AuthorDate: Wed Nov 28 15:13:42 2018 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 29 07:17:37 2018 +0100

remove unnecessary "if (!empty()" checks before loops

found with
   git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'

Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/bastype3.cxx 
b/basctl/source/basicide/bastype3.cxx
index 90bbcbe44e83..c8f9506014ad 100644
--- a/basctl/source/basicide/bastype3.cxx
+++ b/basctl/source/basicide/bastype3.cxx
@@ -486,60 +486,57 @@ EntryDescriptor TreeListBox::GetEntryDescriptor(

[Libreoffice-commits] core.git: compilerplugins/clang

2018-11-28 Thread Libreoffice Gerrit user
 compilerplugins/clang/compat.hxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit da9fb5d6d9ebf9363981c370ce937d8848989fcb
Author: Noel Grandin 
AuthorDate: Wed Nov 28 12:36:29 2018 +0200
Commit: Noel Grandin 
CommitDate: Thu Nov 29 07:17:07 2018 +0100

comment out the EvaluateAsInt compat code for now

sberg: Note how that Clang change keeps getting reverted; latest one is

"Revert r347417 'Re-Reinstate 347294 with a fix for the failures.'"  But
lets wait a little while to see how things settle there.

Change-Id: I05b34ca1377792bcb4c557defd3e9b5d11ee2b14
Reviewed-on: https://gerrit.libreoffice.org/64168
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 97410fcbdc7a..7a518770a3b6 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -157,7 +157,8 @@ inline bool CPlusPlus17(clang::LangOptions const & opts) {
 }
 
 inline bool EvaluateAsInt(clang::Expr const * expr, llvm::APSInt& intRes, 
const clang::ASTContext& ctx) {
-#if CLANG_VERSION >= 8
+// this keeps getting landed and then reverted in clang
+#if 0 && CLANG_VERSION >= 8
 clang::Expr::EvalResult res;
 bool b = expr->EvaluateAsInt(res, ctx);
 if (b && res.Val.isInt())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-11-28 Thread Libreoffice Gerrit user
 sw/source/filter/ww8/ww8atr.cxx |   15 ++-
 1 file changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 1215b3cf095e5baa73bd422ef396eb6245b95303
Author: Justin Luth 
AuthorDate: Tue Nov 27 21:07:49 2018 +0300
Commit: Justin Luth 
CommitDate: Thu Nov 29 05:34:07 2018 +0100

doc sprmPShd documentation.

sprmPShd (0xC64D) is a SHDOperand value that specifies
the background shading for the paragraph. The SDHOperand
structure is an operand that is used by several Sprm structures
to specify the background shading to be applied.

ShdAuto is a special value for Shd that specifies that no shading
is applied and is defined as 0xFF00 / 0x

ShdNil is a special value for Shd. If ShdNil is used in a Table Style
definition, ShdNil is ignored and the shading of the cell is not affected.
If ShdNil is applied outside of a Table Style, ShdNil
specifies that no shading is applied. ShdNil is defined as 0x

Change-Id: I66ec3cbccae60eb658ee00cb01b22cfae36482d0
Reviewed-on: https://gerrit.libreoffice.org/64184
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index b911ef83b6a7..64e10f03ee74 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -4195,19 +4195,16 @@ void WW8AttributeOutput::FormatBackground( const 
SvxBrushItem& rBrush )
 if ( !m_rWW8Export.m_bOutPageDescs )
 {
 WW8_SHD aSHD;
-
 WW8Export::TransBrush( rBrush.GetColor(), aSHD );
-// sprmPShd
+
 m_rWW8Export.InsUInt16( NS_sprm::sprmPShd80 );
 m_rWW8Export.InsUInt16( aSHD.GetValue() );
 
-// Quite a few unknowns, some might be transparency or something
-// of that nature...
-m_rWW8Export.InsUInt16( 0xC64D );
-m_rWW8Export.pO->push_back( 10 );
-m_rWW8Export.InsUInt32( 0xFF00 );
-m_rWW8Export.InsUInt32( SuitableBGColor( rBrush.GetColor() ) );
-m_rWW8Export.InsUInt16( 0x );
+m_rWW8Export.InsUInt16( NS_sprm::sprmPShd );
+m_rWW8Export.pO->push_back( 10 ); //size of operand: MUST be 10
+m_rWW8Export.InsUInt32( 0xFF00 ); //cvFore: Foreground BGR = cvAuto
+m_rWW8Export.InsUInt32( SuitableBGColor( rBrush.GetColor() ) ); 
//cvBack
+m_rWW8Export.InsUInt16( 0x ); //iPat: specifies the pattern used 
for shading = clear/100% background
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/colibre icon-themes/colibre_svg officecfg/registry sc/uiconfig sd/uiconfig sw/uiconfig

2018-11-28 Thread Libreoffice Gerrit user
 icon-themes/colibre/cmd/32/toolsmacroedit.png|binary
 icon-themes/colibre/cmd/lc_scriptorganizer.png   |binary
 icon-themes/colibre/cmd/sc_scriptorganizer.png   |binary
 icon-themes/colibre/links.txt|   11 
+
 icon-themes/colibre/res/lx03252.png  |binary
 icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg|   21 
++
 icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg   |   14 
++
 icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg   |   14 
++
 icon-themes/colibre_svg/res/lx03252.svg  |2 
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |3 +
 sc/uiconfig/scalc/ui/notebookbar.ui  |4 -
 sd/uiconfig/sdraw/ui/notebookbar.ui  |4 -
 sd/uiconfig/simpress/ui/notebookbar.ui   |4 -
 sw/uiconfig/swriter/ui/notebookbar.ui|   11 
++---
 14 files changed, 75 insertions(+), 13 deletions(-)

New commits:
commit 19ed06f3e22a9f088a72633d6dc3b40116007f25
Author: andreas kainz 
AuthorDate: Wed Nov 28 13:16:23 2018 +0100
Commit: andreas_kainz 
CommitDate: Thu Nov 29 04:42:44 2018 +0100

tdf#121581 change organize dialoogs to organize macro

add missing colibre icons
improve layout for large icons

Change-Id: Id9d003b945654f958ec43d530083e2070d4b580e
Reviewed-on: https://gerrit.libreoffice.org/64159
Tested-by: Jenkins
Reviewed-by: andreas_kainz 
(cherry picked from commit 2c154667ff257a9aaec2baa386cec7b9e129132d)
Reviewed-on: https://gerrit.libreoffice.org/64193

diff --git a/icon-themes/colibre/cmd/32/toolsmacroedit.png 
b/icon-themes/colibre/cmd/32/toolsmacroedit.png
new file mode 100644
index ..3b3061988c22
Binary files /dev/null and b/icon-themes/colibre/cmd/32/toolsmacroedit.png 
differ
diff --git a/icon-themes/colibre/cmd/lc_scriptorganizer.png 
b/icon-themes/colibre/cmd/lc_scriptorganizer.png
new file mode 100644
index ..cd202cf2eed0
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_scriptorganizer.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_scriptorganizer.png 
b/icon-themes/colibre/cmd/sc_scriptorganizer.png
new file mode 100644
index ..734d8a401f6e
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_scriptorganizer.png 
differ
diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index 7c12157267c1..7d498f287ab0 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -1801,3 +1801,14 @@ cmd/lc_tableevents.png cmd/lc_animationeffects.png
 cmd/sc_sheetlefttoright.png cmd/sc_paralefttoright.png
 cmd/sc_sheetrighttoleft.png cmd/sc_pararighttoleft.png
 cmd/sc_tableevents.png cmd/sc_animationeffects.png
+
+
+# Macro
+cmd/32/macrosmenu.png cmd/32/choosemacro.png
+cmd/32/basicideappear.png cmd/32/toolsmacroedit.png
+
+cmd/lc_macrosmenu.png cmd/lc_choosemacro.png
+cmd/lc_basicideappear.png cmd/lc_toolsmacroedit.png
+
+cmd/sc_macrosmenu.png cmd/sc_choosemacro.png
+cmd/sc_basicideappear.png cmd/sc_toolsmacroedit.png
diff --git a/icon-themes/colibre/res/lx03252.png 
b/icon-themes/colibre/res/lx03252.png
index 007769c55c7d..edac6bc02f4a 100644
Binary files a/icon-themes/colibre/res/lx03252.png and 
b/icon-themes/colibre/res/lx03252.png differ
diff --git a/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg 
b/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg
new file mode 100644
index ..87054391316c
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg
@@ -0,0 +1,21 @@
+http://www.w3.org/2000/svg";>
+  
+  
+  
+
+
+  
+
diff --git a/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg 
b/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg
new file mode 100644
index ..4075bd463f20
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg
@@ -0,0 +1,14 @@
+http://www.w3.org/2000/svg";>
+
+
+  
+
diff --git a/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg 
b/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg
new file mode 100644
index ..13ac6d6dc4cd
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg
@@ -0,0 +1,14 @@
+http://www.w3.org/2000/svg";>
+  
+  
+
+
diff --git a/icon-themes/colibre_svg/res/lx03252.svg 
b/icon-themes/colibre_svg/res/lx03252.svg
index a2ca91cfcfc8..6fae78de924e 100644
--- a/icon-themes/colibre_svg/res/lx03252.svg
+++ b/icon-themes/colibre_svg/res/lx03252.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index b0387cfefee1..69856aa6362e 100644
--- a/officecfg/reg

[Libreoffice-commits] core.git: chart2/qa

2018-11-28 Thread Libreoffice Gerrit user
 chart2/qa/extras/chart2import.cxx   |   14 ++
 chart2/qa/extras/data/xls/source_number_format_axis.xls |binary
 2 files changed, 14 insertions(+)

New commits:
commit 92c25a6163dca79987fd8fe7c3efd5527edc29b5
Author: Markus Mohrhard 
AuthorDate: Thu Nov 29 01:53:12 2018 +0100
Commit: Markus Mohrhard 
CommitDate: Thu Nov 29 03:32:31 2018 +0100

add test for tdf#105236

Change-Id: I5464504ae9ee411221c2cb2ff6f27b7b7e131326
Reviewed-on: https://gerrit.libreoffice.org/64201
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index d0a5c344a1e6..64e343c6d639 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -118,6 +118,7 @@ public:
 void testDeletedDataLabel();
 void testDataPointInheritedColorDOCX();
 void testExternalStrRefsXLSX();
+void testSourceNumberFormatComplexCategoriesXLS();
 
 CPPUNIT_TEST_SUITE(Chart2ImportTest);
 CPPUNIT_TEST(Fdo60083);
@@ -190,6 +191,7 @@ public:
 CPPUNIT_TEST(testDeletedDataLabel);
 CPPUNIT_TEST(testDataPointInheritedColorDOCX);
 CPPUNIT_TEST(testExternalStrRefsXLSX);
+CPPUNIT_TEST(testSourceNumberFormatComplexCategoriesXLS);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -1700,6 +1702,18 @@ void Chart2ImportTest::testExternalStrRefsXLSX()
 CPPUNIT_ASSERT_EQUAL(OUString("test2"), aValues[1].get());
 }
 
+void Chart2ImportTest::testSourceNumberFormatComplexCategoriesXLS()
+{
+load("/chart2/qa/extras/data/xls/", "source_number_format_axis.xls");
+uno::Reference< chart2::XChartDocument > xChartDoc( getChartCompFromSheet( 
0, mxComponent ), UNO_QUERY_THROW );
+CPPUNIT_ASSERT(xChartDoc.is());
+
+Reference xAxis = getAxisFromDoc(xChartDoc, 0, 0, 0);
+chart2::ScaleData aScaleData = xAxis->getScaleData();
+sal_Int32 nNumberFormat =  
aScaleData.Categories->getValues()->getNumberFormatKeyByIndex(-1);
+CPPUNIT_ASSERT(nNumberFormat != 0);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ImportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/chart2/qa/extras/data/xls/source_number_format_axis.xls 
b/chart2/qa/extras/data/xls/source_number_format_axis.xls
new file mode 100644
index ..bc54593ac150
Binary files /dev/null and 
b/chart2/qa/extras/data/xls/source_number_format_axis.xls differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2018-11-28 Thread Libreoffice Gerrit user
 sc/source/ui/unoobj/chart2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fb04e7180cdf656dbbd3daa9c81615d9478229e0
Author: Markus Mohrhard 
AuthorDate: Thu Nov 29 00:04:58 2018 +0100
Commit: Markus Mohrhard 
CommitDate: Thu Nov 29 03:30:46 2018 +0100

tdf#105236, only take number format from numeric cells

Change-Id: I55deaa1f0579582a45dc1e10bb578b680eb98647
Reviewed-on: https://gerrit.libreoffice.org/64200
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/unoobj/chart2uno.cxx 
b/sc/source/ui/unoobj/chart2uno.cxx
index 448652397cee..5fc78815f602 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -3145,7 +3145,7 @@ sal_uInt32 getDisplayNumberFormat(const ScDocument* pDoc, 
const ScAddress& rPos)
 for (const Item& rItem : m_aDataArray)
 {
 ScRefCellValue aCell(*m_pDocument, rItem.mAddress);
-if (!aCell.isEmpty())
+if (!aCell.isEmpty() && aCell.hasNumeric())
 {
 return 
static_cast(getDisplayNumberFormat(m_pDocument, rItem.mAddress));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/qa sc/source

2018-11-28 Thread Libreoffice Gerrit user
 sc/qa/unit/data/ods/tdf121612.ods |binary
 sc/qa/unit/subsequent_export-test.cxx |   20 
 sc/source/filter/excel/xepivotxml.cxx |   11 +--
 3 files changed, 29 insertions(+), 2 deletions(-)

New commits:
commit 6481bda69ade61cb5420156272fcf17edd43d620
Author: Vasily Melenchuk 
AuthorDate: Thu Nov 22 11:30:29 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Thu Nov 29 00:57:59 2018 +0100

tdf#121612: update pivot caches during saving to XLSX

Cache was empty so pivot table was not exported completely
and pivot table filter were missing.

Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d
Reviewed-on: https://gerrit.libreoffice.org/63785
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/sc/qa/unit/data/ods/tdf121612.ods 
b/sc/qa/unit/data/ods/tdf121612.ods
new file mode 100644
index ..6afc4e0c931c
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf121612.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 1425ff330954..f084ad015f29 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -206,6 +207,7 @@ public:
 void testKeepSettingsOfBlankRows();
 
 void testTdf118990();
+void testTdf121612();
 
 CPPUNIT_TEST_SUITE(ScExportTest);
 CPPUNIT_TEST(test);
@@ -319,6 +321,7 @@ public:
 CPPUNIT_TEST(testKeepSettingsOfBlankRows);
 
 CPPUNIT_TEST(testTdf118990);
+CPPUNIT_TEST(testTdf121612);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -4169,6 +4172,23 @@ void ScExportTest::testTdf118990()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testTdf121612()
+{
+ScDocShellRef xDocSh = loadDoc("tdf121612.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+xDocSh = saveAndReload(xDocSh.get(), FORMAT_XLSX);
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// There should be a pivot table
+CPPUNIT_ASSERT(rDoc.HasPivotTable());
+
+// DP collection is not lost after export and has one entry
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
+CPPUNIT_ASSERT(pDPColl);
+CPPUNIT_ASSERT_EQUAL(size_t(1), pDPColl->GetCount());
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index b7e790eca6da..271b4cb8fdf4 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -418,15 +418,22 @@ XclExpXmlPivotTableManager::XclExpXmlPivotTableManager( 
const XclExpRoot& rRoot
 
 void XclExpXmlPivotTableManager::Initialize()
 {
-const ScDocument& rDoc = GetDoc();
+ScDocument& rDoc = GetDoc();
 if (!rDoc.HasPivotTable())
 // No pivot table to export.
 return;
 
-const ScDPCollection* pDPColl = rDoc.GetDPCollection();
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
 if (!pDPColl)
 return;
 
+// Update caches from DPObject
+for (size_t i = 0; i < pDPColl->GetCount(); ++i)
+{
+ScDPObject& rDPObj = (*pDPColl)[i];
+rDPObj.SyncAllDimensionMembers();
+}
+
 // Go through the caches first.
 
 std::vector aCaches;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basic/source

2018-11-28 Thread Libreoffice Gerrit user
 basic/source/basmgr/basmgr.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 00caf3994cab5a25fd4ff147e2860a439b69c731
Author: Andrea Gelmini 
AuthorDate: Wed Nov 28 17:47:58 2018 +0100
Commit: Jens Carl 
CommitDate: Thu Nov 29 00:08:52 2018 +0100

Fix typo

Change-Id: I8e340cc5bbf5131939446291177c3532911237ab
Reviewed-on: https://gerrit.libreoffice.org/64183
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index f1ad7192aabf..c079d4efa3db 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -1043,7 +1043,7 @@ StarBASIC* BasicManager::AddLib( SotStorage& rStorage, 
const OUString& rLibName,
 aNewLibName += "_";
 }
 BasicLibInfo* pLibInfo = CreateLibInfo();
-// Use original name otherwise ImpLoadLibrary failes...
+// Use original name otherwise ImpLoadLibrary fails...
 pLibInfo->SetLibName( rLibName );
 // but doesn't work this way if name exists twice
 sal_uInt16 nLibId = static_cast(mpImpl->aLibs.size()) - 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: 4 commits - common/MessageQueue.cpp ios/Mobile wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

2018-11-28 Thread Libreoffice Gerrit user
 common/MessageQueue.cpp  |   18 +-
 ios/Mobile/Document.mm   |4 +++-
 ios/Mobile/DocumentViewController.mm |6 +-
 wsd/DocumentBroker.cpp   |4 ++--
 wsd/DocumentBroker.hpp   |6 +++---
 5 files changed, 22 insertions(+), 16 deletions(-)

New commits:
commit b4e3110d7b60d6dc58e716d86fb18fe8fed23ba7
Author: Tor Lillqvist 
AuthorDate: Thu Nov 29 01:01:12 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Nov 29 01:07:03 2018 +0200

Truncate for logging at a bit higher limit

Change-Id: I352ef6476a9cde767b4076ad9a2ab8cf3c9bdf2b

diff --git a/ios/Mobile/Document.mm b/ios/Mobile/Document.mm
index 720aaab79..241e2cb3d 100644
--- a/ios/Mobile/Document.mm
+++ b/ios/Mobile/Document.mm
@@ -92,7 +92,7 @@
 js = @"window.TheFakeWebSocket.onmessage({'data': 
Base64ToArrayBuffer('";
 js = [js stringByAppendingString: [[NSData dataWithBytes:buffer 
length:length] base64EncodedStringWithOptions:0]];
 js = [js stringByAppendingString:@"')});"];
-NSString *subjs = [js substringToIndex:std::min(40ul, js.length)];
+NSString *subjs = [js substringToIndex:std::min(100ul, js.length)];
 if (subjs.length < js.length)
 subjs = [subjs stringByAppendingString:@"..."];
 
diff --git a/ios/Mobile/DocumentViewController.mm 
b/ios/Mobile/DocumentViewController.mm
index f858a0a5a..f60e31bbc 100644
--- a/ios/Mobile/DocumentViewController.mm
+++ b/ios/Mobile/DocumentViewController.mm
@@ -150,7 +150,7 @@
 } else if ([message.name isEqualToString:@"debug"]) {
 LOG_TRC_NOFILE("==> " << [message.body UTF8String]);
 } else if ([message.name isEqualToString:@"lool"]) {
-NSString *subBody = [message.body substringToIndex:std::min(40ul, 
((NSString*)message.body).length)];
+NSString *subBody = [message.body substringToIndex:std::min(100ul, 
((NSString*)message.body).length)];
 if (subBody.length < ((NSString*)message.body).length)
 subBody = [subBody stringByAppendingString:@"..."];
 
commit 235c9b8a6070c0ffefc0aa5a80534e6f5c9f5af5
Author: Tor Lillqvist 
AuthorDate: Thu Nov 29 00:57:34 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Nov 29 01:07:03 2018 +0200

Use getAbbreviatedMessage() for its intended purpose

Don't log a potentially very long message in its entirety.

Change-Id: I01fbf76465d99bbab117d1dcacc6c7239a1da518

diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp
index 0a473d0e4..44781d118 100644
--- a/common/MessageQueue.cpp
+++ b/common/MessageQueue.cpp
@@ -31,7 +31,7 @@ void TileQueue::put_impl(const Payload& value)
 
 if (firstToken == "canceltiles")
 {
-LOG_TRC("Processing [" << msg << "]. Before canceltiles have " << 
getQueue().size() << " in queue.");
+LOG_TRC("Processing [" << LOOLProtocol::getAbbreviatedMessage(msg) << 
"]. Before canceltiles have " << getQueue().size() << " in queue.");
 const std::string seqs = msg.substr(12);
 StringTokenizer tokens(seqs, ",", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 getQueue().erase(std::remove_if(getQueue().begin(), getQueue().end(),
@@ -119,7 +119,7 @@ void TileQueue::removeTileDuplicate(const std::string& 
tileMsg)
 if (it.size() > newMsgPos &&
 strncmp(tileMsg.data(), it.data(), newMsgPos) == 0)
 {
-LOG_TRC("Remove duplicate tile request: " << 
std::string(it.data(), it.size()) << " -> " << tileMsg);
+LOG_TRC("Remove duplicate tile request: " << 
std::string(it.data(), it.size()) << " -> " << 
LOOLProtocol::getAbbreviatedMessage(tileMsg));
 getQueue().erase(getQueue().begin() + i);
 break;
 }
@@ -334,7 +334,7 @@ std::string TileQueue::removeCallbackDuplicate(const 
std::string& callbackMsg)
 
 if (unoCommand == queuedUnoCommand)
 {
-LOG_TRC("Remove obsolete uno command: " << 
std::string(it.data(), it.size()) << " -> " << callbackMsg);
+LOG_TRC("Remove obsolete uno command: " << 
std::string(it.data(), it.size()) << " -> " << 
LOOLProtocol::getAbbreviatedMessage(callbackMsg));
 getQueue().erase(getQueue().begin() + i);
 break;
 }
@@ -371,7 +371,7 @@ std::string TileQueue::removeCallbackDuplicate(const 
std::string& callbackMsg)
 
 if (!isViewCallback && (queuedTokens[1] == tokens[1] && 
queuedTokens[2] == tokens[2]))
 {
-LOG_TRC("Remove obsolete callback: " << std::string(it.data(), 
it.size()) << " -> " << callbackMsg);
+LOG_TRC("Remove obsolete callback: " << std::string(it.data(), 
it.size()) << " -> " << LOOLProtocol::getAbbreviatedMessage(callbackMsg));
 getQueue().erase(getQueue().begin() + i);
 break;
 }
@@ -384,7 +384,7 @@ std::string TileQueue::removeCallbackDuplicate(const 
std

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.1.4.1'

2018-11-28 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.4.1' created by Christian Lohmaier 
 at 2018-11-28 22:02 +

Tag libreoffice-6.1.4.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJb/xCAAAoJEPQ0oe+v7q6j7j8QAIjULK+YbG8LJsqpSjgv4y9t
zRfJcPuUPtUzEB+ZajqszwefoHnfLs6ol6NTZdUkaMgZQY7ueVaF6yREhNGmu8b/
Govgkl8sHKhZ7HqfRlB83srSv+9ZI/SCs4qcTpQNxdGvnhDp0bcPxSWxoXaf9we1
ikP1RiPLXGEwCpH3IPg2x6pBJYUi7eZFaAuz4aZjM1wXmDHZHnek5w0neFXh42lj
QeFXWkhSsavqeIaxkjAlrKE/PxXjar/9vc+YuKDp/ZP4+BI1k96i6IzqRmcL7mgr
fMqce0jY8lYy6PJ++GL65ICovQnYEGLchqQPEEeCzmEFNznrreIiQn4huK2Qs1dh
l5C6T/Tw6wT/zBZDTxkHsSaRl0fCqinBx/SjpUedovDv7mcrOsMLMBEnL8x8lt7y
Z8Yc3u8mlxEMwPp5x9y/fq46mcfApcNpdoULVhs1gnvo9PiFIa8mwv33Wh+52GtT
TtkBdeHCyGIHUpO0Im5JuSHrET6UzvxdfeLJrovZ+alaa1SZ91VJDWuSLyH65Ova
CaVhLF85rqhMF4LMx48idAvcAeNbOsjy00IF5YsyYOikxCK5PgJkUfx+s63U7tyo
OvtwM8CVZK/XpF+UWklGf1DfUQQQOQoP91oDbvroVGm3C1sfFg/ub5RdNyHJzcVa
Eclt+kOGfV3bVy4p0Rbk
=SM/6
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-70:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.1.4.1'

2018-11-28 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.4.1' created by Christian Lohmaier 
 at 2018-11-28 22:02 +

Tag libreoffice-6.1.4.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJb/xCEAAoJEPQ0oe+v7q6jItcP/2z6vYk3QyPcmXePcLuunP0f
ggv42NRNmNSNdf7rIkg9W3snwrT69LWoMv+T04Jnh9lHAqZ+rGHqwDJekfuAuCP1
9MItCK8QA6oYsfC2ji5nMFA/DEa8DhkTv7eVsnducjvfGQUB/+DH1y7w7Cr9ZL7R
k2Ts3CK5+fhIfFpgllIo5iHq5cWzAf2I4V09Xi+R9y0K/uEe/8M4wHee9pK2l+pO
NsP0KowxBVRzWkGVtE3jervCNajqQte6kXyW2xOqvBJmkZmAPAvXc/pqE5FPP7cS
DkZNNkVvvTOIZ9tjzhegfeBPE40MfUduPGdfkqKM8hK9Koo3WiLlbCiQkyEfeMY9
UYNK/EEaD/9qxEmOmX9b3jGBsaMiKSKphgQ8o79gcCNdU81v9ym+GnFYjWKn9DsQ
cQOJ5Jp9lJwoEEcCvtPiOjpx/Zud2dNUsVgdMFnMVfjMWIX0rtrUlK5IxECXSMaQ
bvINf8W5wJ6oqfNL+qJqIQRBSsJW89N2SVpFA38skcO1JO37R0k4nO9kJO0r5uCP
QFzn2O762rwOFHettYI71bhOTpGN8Dl+jgpjWJoJL+0AwSzLZxCbL6OaUM7/z3jB
5MYMKcHO5yQ1nMtjZhyDhBw9APdJrgRH42xvlHSwP7HlAUqttASvpthXR1XH9jd2
afeOEvz/oW6FV40+6nGH
=QXOM
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-25:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1-4' - configure.ac

2018-11-28 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0b8986992c7c092ec4f85d60c22db3603a474571
Author: Christian Lohmaier 
AuthorDate: Wed Nov 28 23:03:27 2018 +0100
Commit: Christian Lohmaier 
CommitDate: Wed Nov 28 23:03:27 2018 +0100

bump product version to 6.1.4.1.0+

Change-Id: I2057b37cd228d17fc336e3137f39c4cfa0595a0d

diff --git a/configure.ac b/configure.ac
index f1c76828a4df..7fc25d971df9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.1.4.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.4.1.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.1.4.1'

2018-11-28 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.4.1' created by Christian Lohmaier 
 at 2018-11-28 22:02 +

Tag libreoffice-6.1.4.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJb/xBxAAoJEPQ0oe+v7q6jZ9wQALzsHeBQ9LY0u6ERQS/FZGWj
qi2tlNM5kF6Cs1gRVEiPRdth4Xov9GJ9M9XVDZujjm/wjVAlSLjcBrq/KoV3ZGsi
yUN5Xz7/jSNmIll/L0vMePRP8LpJFQmIiZc5p4g5dI0USzaEZ/6bHxLPCeLNhkXx
XOVw6MmKPochk1VH3sfznR2UjnJfhjmbq0FUotskWiw2DAY9WLbwwrxgGD4iTwr9
xEKfk2DSxJuXK7vsBUzcTXSmRuzohWh7axOR4Q2JW03bTmI8axS39szYgklzVAp8
TYkHsoiJy5459TU+2zWsLK7cl4Pw5NHAOxuG9jS3lWWfyqFuzUvkWMRcsMLSW7Sy
HHEsgTz526mT82UfCjd2KJ2pGm0jfv0AWTrlMHD/sb1pn4rmImMpuQv4Rj7ao5RA
wN6g0hcj13x+xB4F8LKTr9yfIarstXogV9XKlGWNcwBeUZ6trn26wRrFTANBZO4n
vfVAIQmU3E0jI6wtC0RIc9AEuHW6WMtmJ4T7wEqVtq0ak39RUBOIUN7OPTwWcr9t
e6eczcBNqm0wkUZs7urXs26TAqFmKU/3OC8Lb0paGTBXKntaPCAOo4ohYk7sdMjR
IhsS5dPGQ6+rWKi9VsdBmztS216vG5c68saWuYt6c+d3qtwaY94m/PuGcqOOkLaL
hvBUg6D3+bxG7A3vw/Pt
=4QFg
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-10:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.1.4.1'

2018-11-28 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.4.1' created by Christian Lohmaier 
 at 2018-11-28 22:02 +

Tag libreoffice-6.1.4.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJb/xCHAAoJEPQ0oe+v7q6jxrAP/3FFwnWHYP+BlWrDqUXKmCP9
r/sYPW5ST1M/wEAtpCiZRdr1dumfQcAharfklMw7c1J82e+5w2+5UBc4sB9LlQGS
hfeTbO0iSe9eXbSSkgmumaUqNtN6nH6A4FvUTEfQOgcEvo8uvuPZdxkgoKfDS5Tt
2/L7CslUViGfCVDhmIGZdHMuDFK2xTCXYrhRG3mJBWp05auM3XI/eR3+q+GP2OLC
fOp60g1ARQmMb8XtVvCq4+v4C+2xazlPfciskTSlWT7XMWspNqGo/XXlVA66r0Kg
4yGu1T+M0efX9fjZi5ZsJGAm4/WEph9kPy4teeLB5tyACDKkR7rN2WAwsncbwtGy
rpEEXR0HgvqwIRpJS5R5DrgkmFHdP+PTv8cTsABUIPM9x3/kwCKfimNSC/5sdT98
Z1lPtOpuDmUvW0bkGCFLvnalwxorfVQeUqfyVlCvrxvW+QigRhQhZJ8j/DyS9DvW
cOiRImJ0+fFRsMpMloSCG/Q7PBAq0gdwg9SEY9w9rUOxFagK/Odm8ZT38Tddvkug
vtqxb4DR9NGhacHmB7UTv0CfF3ZKB7LH/ALuUSy1zLxJERWxt7D9V+aebDEB/4d6
tqVIOmFrN9XNqs4iEwI1447UGPSpwtoVdABCMga/mXBaUncLrG5GsopUBQcZilwd
NUs2e2T68t0eGkpVmlLU
=uZG2
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-1314:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - configure.ac

2018-11-28 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b2a5d84d0e4ce1ce85459398a6eca63b49c93dd1
Author: Christian Lohmaier 
AuthorDate: Wed Nov 28 23:00:50 2018 +0100
Commit: Christian Lohmaier 
CommitDate: Wed Nov 28 23:00:50 2018 +0100

bump product version to 6.1.5.0.0+

Change-Id: Ic5e5b929c353a1a438268ba01b40b70fc85a9bd7

diff --git a/configure.ac b/configure.ac
index f1c76828a4df..4c213dc3fd47 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.1.4.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.5.0.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'libreoffice-6-1-4'

2018-11-28 Thread Libreoffice Gerrit user
New branch 'libreoffice-6-1-4' available with the following commits:
commit f2e4d3902c187b8907f29f947d16a47bd4a5d0ff
Author: Christian Lohmaier 
Date:   Wed Nov 28 22:58:12 2018 +0100

Branch libreoffice-6-1-4

This is 'libreoffice-6-1-4' - the stable branch for the 6.1.4 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Ic08d9aca1473a5abff4ce4833c5f755d43434b83

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-1-4'

2018-11-28 Thread Libreoffice Gerrit user
New branch 'libreoffice-6-1-4' available with the following commits:
commit 4027902fbe3cb82ed91554fca0ad9b19be9c2271
Author: Christian Lohmaier 
Date:   Wed Nov 28 22:56:48 2018 +0100

Branch libreoffice-6-1-4

This is 'libreoffice-6-1-4' - the stable branch for the 6.1.4 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I008f93a76d17d073b98485b31fc6221db11700af

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-1-4'

2018-11-28 Thread Libreoffice Gerrit user
New branch 'libreoffice-6-1-4' available with the following commits:
commit caf4a58dfec875a1b161d810a61b91cdee0debd4
Author: Christian Lohmaier 
Date:   Wed Nov 28 22:56:47 2018 +0100

Branch libreoffice-6-1-4

This is 'libreoffice-6-1-4' - the stable branch for the 6.1.4 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: If5bbce4f2e790a02277196606da38ff73e69795b

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Changes to 'libreoffice-6-1-4'

2018-11-28 Thread Libreoffice Gerrit user
New branch 'libreoffice-6-1-4' available with the following commits:
commit 625c711472cce9e6df2288d431e68b04a9b337bc
Author: Christian Lohmaier 
Date:   Wed Nov 28 22:56:48 2018 +0100

Branch libreoffice-6-1-4

This is 'libreoffice-6-1-4' - the stable branch for the 6.1.4 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I6858e5cc1462a4952624f8caec73319ea9f3a348

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - editeng/source

2018-11-28 Thread Libreoffice Gerrit user
 editeng/source/editeng/impedit3.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6a25245b37437e66f501338f17d6b54825a266d3
Author: AlicVB 
AuthorDate: Wed Oct 17 22:03:24 2018 +0200
Commit: Christian Lohmaier 
CommitDate: Wed Nov 28 22:47:59 2018 +0100

tdf#120525 fix linespacing <100% for impress

apply linespacing changes even for fonts with big descent values

Change-Id: If1763da1ea015822d90a5c7410ca90dcaa71d22f
Reviewed-on: https://gerrit.libreoffice.org/61894
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 87239dbf7d57d812cdecbf75f6e86afaa4864abb)
Reviewed-on: https://gerrit.libreoffice.org/64190
Reviewed-by: Christian Lohmaier 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 7cc6dfddb695..fc383b9555ad 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -1451,10 +1451,10 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 sal_uInt16 nNewAscent = pLine->GetTxtHeight() * 
nPropLineSpace / 100 * 4 / 5; // 80%
 if ( !nAscent || nAscent > nNewAscent )
 {
-sal_uInt16 nHeight = pLine->GetHeight() * 
nPropLineSpace / 100;
-pLine->SetHeight( nHeight, pLine->GetTxtHeight() );
 pLine->SetMaxAscent( nNewAscent );
 }
+sal_uInt16 nHeight = pLine->GetHeight() * nPropLineSpace / 
100;
+pLine->SetHeight( nHeight, pLine->GetTxtHeight() );
 }
 else if ( rLSItem.GetPropLineSpace() && ( 
rLSItem.GetPropLineSpace() != 100 ) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - 1977 commits - accessibility/inc accessibility/Library_acc.mk accessibility/source android/source avmedia/inc avmedia/source basctl/inc

2018-11-28 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor:
commit 9bb0ce088108e6326b5cd66ad4eae3191b6ba418
Author: Daniel 
AuthorDate: Tue Jul 31 09:49:07 2018 -0300
Commit: Daniel Silva 
CommitDate: Wed Nov 28 09:36:56 2018 -0200

Print dialog UI adjustments

Change-Id: Iecf66e31b66d65b9077da4870385ef8f9012f043
Reviewed-on: https://gerrit.libreoffice.org/58361
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/sd/uiconfig/simpress/ui/impressprinteroptions.ui 
b/sd/uiconfig/simpress/ui/impressprinteroptions.ui
index 70e48f940aa8..c40508ae3b3f 100644
--- a/sd/uiconfig/simpress/ui/impressprinteroptions.ui
+++ b/sd/uiconfig/simpress/ui/impressprinteroptions.ui
@@ -21,115 +21,83 @@
 False
 6
 12
+7
 
-  
+  
 True
 False
-vertical
-3
+5
+6
 
-  
+  
 True
 False
-6
-
-  
-True
-False
-Type:
-  
-  
-False
-True
-0
-  
-
-
-  
-True
-False
-  
-  
-False
-True
-1
-  
-
+start
+Type:
+True
+impressdocument
   
   
-False
-True
-0
+0
+0
   
 
 
-  
+  
 True
 False
-6
-
-  
-True
-False
-Slides per page:
-  
-  
-False
-True
-0
-  
-
-
-  
-True
-False
-  
-  
-False
-True
-1
-  
-
+start
+Slides per page:
+True
+slidesperpage
   
   
-False
-True
-1
+0
+1
   
 
 
-  
+  
 True
 False
-6
-
-  
-True
-False
-Order:
-  
-  
-False
-True
-0
-  
-
-
-  
-True
-False
-  
-  
-False
-True
-1
-  
-
+start
+Order:
+True
+slidesperpageorder
   
   
-False
-True
-2
+0
+2
+  
+
+
+  
+True
+False
+  
+  
+1
+0
+  
+
+
+  
+True
+False
+  
+  
+1
+1
+  
+
+
+  
+True
+False
+  
+  
+1
+2
   
 
   
diff --git a/sw/uiconfig/swriter/ui/printeroptions.ui 
b/sw/uiconfig/swriter/ui/printeroptions.ui
index d3efd6be93f1..36f9d87bff2e 100644
--- a/sw/uiconfig/swriter/ui/printeropti

[Libreoffice-commits] core.git: vcl/source

2018-11-28 Thread Libreoffice Gerrit user
 vcl/source/window/builder.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit dd929d99dd86a0ed8587adc5b8b6bff5b4dafbf3
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 17:44:14 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 22:14:34 2018 +0100

drop WB_SIMPLEMODE for TreeView

multi selections are weird with this set

Change-Id: I765c46294803d06911a6ac3fc37d68dd001aacdc
Reviewed-on: https://gerrit.libreoffice.org/64187
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index ce2204fee71b..44795670be9c 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -1904,7 +1904,7 @@ VclPtr VclBuilder::makeObject(vcl::Window 
*pParent, const OString &
 //   everything over to SvHeaderTabListBox/SvTabListBox
 //c) remove the users of makeSvTabListBox and makeSvTreeListBox
 extractModel(id, rMap);
-WinBits nWinStyle = 
WB_CLIPCHILDREN|WB_LEFT|WB_VCENTER|WB_3DLOOK|WB_SIMPLEMODE;
+WinBits nWinStyle = WB_CLIPCHILDREN|WB_LEFT|WB_VCENTER|WB_3DLOOK;
 if (m_bLegacy)
 {
 OUString sBorder = BuilderUtils::extractCustomProperty(rMap);
@@ -1917,7 +1917,7 @@ VclPtr VclBuilder::makeObject(vcl::Window 
*pParent, const OString &
 nWinStyle |= WB_BORDER;
 if (m_bLegacy)
 {
-xWindow = VclPtr::Create(pRealParent, nWinStyle);
+xWindow = VclPtr::Create(pRealParent, nWinStyle | 
WB_SIMPLEMODE);
 xWindowForPackingProps = xWindow;
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2018-11-28 Thread Libreoffice Gerrit user
 loleaflet/src/layer/AnnotationManager.js |   13 -
 1 file changed, 13 deletions(-)

New commits:
commit 0998cabbe758a9b2a43d34e1c45a506080c12406
Author: Tor Lillqvist 
AuthorDate: Wed Nov 28 23:13:54 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 28 23:13:54 2018 +0200

Fix mis-merge (?), remove duplicated function definition

Change-Id: I7652515241f156d1722d2f626ec627d166d7b4ca

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index a410598de..206f7ae71 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -472,19 +472,6 @@ L.AnnotationManager = L.Class.extend({
 
},
 
-   layout: function (zoom) {
-   if (zoom)
-   this.doLayout(zoom);
-   else if (!this._layoutTimer) {
-   var me = this;
-   me._layoutTimer = setTimeout(function() {
-   delete me._layoutTimer;
-   me.doLayout(zoom);
-   }, 250 /* ms */);
-   } // else - avoid excessive re-layout
-
-   },
-
add: function (comment) {
var annotation = 
L.annotation(this._map._docLayer._twipsToLatLng(comment.anchorPos.getTopRight()),
 comment,
comment.id === 'new' ? {noMenu: true} : 
{}).addTo(this._map);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-11-28 Thread Libreoffice Gerrit user
 sw/source/core/frmedt/feshview.cxx |   17 +
 1 file changed, 5 insertions(+), 12 deletions(-)

New commits:
commit 30a07561c19da050c7ca0a7a67868a6f6229a449
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 15:47:12 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 22:13:46 2018 +0100

Revert "Resolves: tdf#112696 survive missing SwDrawContact"

This reverts commit 2cb9c55e4da18fbfb2f578c46d094e6ca0d56fa1.

Change-Id: I2d276d0171103d45be2cd66990fb5cf8d2fb4161
Reviewed-on: https://gerrit.libreoffice.org/64178
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/frmedt/feshview.cxx 
b/sw/source/core/frmedt/feshview.cxx
index 4abc8f16aea1..b05698242f55 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -2241,11 +2241,6 @@ RndStdIds SwFEShell::GetAnchorId() const
 break;
 }
 SwDrawContact *pContact = 
static_cast(GetUserCall(pObj));
-if (!pContact)
-{
-nRet = RndStdIds::UNKNOWN;
-break;
-}
 RndStdIds nId = pContact->GetFormat()->GetAnchor().GetAnchorId();
 if ( nRet == RndStdIds(SHRT_MAX) )
 nRet = nId;
@@ -2350,13 +2345,11 @@ bool SwFEShell::IsGroupSelected()
 SdrObject *pObj = rMrkList.GetMark( i )->GetMarkedSdrObj();
 // consider 'virtual' drawing objects.
 // Thus, use corresponding method instead of checking type.
-if (!pObj->IsGroupObject())
-continue;
-// --> #i38505# No ungroup allowed for 3d objects
-if (pObj->Is3DObj())
-continue;
-SwDrawContact *pContact = 
static_cast(GetUserCall(pObj));
-if (!pContact || RndStdIds::FLY_AS_CHAR != 
pContact->GetFormat()->GetAnchor().GetAnchorId())
+if ( pObj->IsGroupObject() &&
+ // --> #i38505# No ungroup allowed for 3d objects
+ !pObj->Is3DObj() &&
+ RndStdIds::FLY_AS_CHAR != 
static_cast(GetUserCall(pObj))->
+  GetFormat()->GetAnchor().GetAnchorId() )
 {
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/js

2018-11-28 Thread Libreoffice Gerrit user
 loleaflet/js/toolbar.js |   14 --
 1 file changed, 14 deletions(-)

New commits:
commit 5eaaeb5bb2654af99aeca15e3303aed9226cd91a
Author: Thorsten Behrens 
AuthorDate: Wed Nov 28 17:28:36 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 28 21:20:33 2018 +0100

loleaflet: remove TextWrap menu from toolbar

Since it's available already from the context menu.

Change-Id: Ia79a5f21b2d757621a3cb8d7114b90617c6c2acf
Reviewed-on: https://gerrit.libreoffice.org/64181
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 2fac097ff..eb4be1346 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -173,11 +173,6 @@ function onClick(e, id, item, subItem) {
else if (id === 'lastrecord') {

$('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft()
 + 120);
}
-   else if (id.startsWith('menu-wrap:wrap-'))
-   {
-   var wrapType = id.substring('menu-wrap:wrap-'.length);
-   map.toggleCommandState(wrapType);
-   }
else if (id === 'insertgraphic' || item.id === 'localgraphic') {
L.DomUtil.get('insertgraphic').click();
}
@@ -622,15 +617,6 @@ var fontsizesSelectValue;
 
 function createToolbar() {
var toolItems = [
-   {type: 'menu', id: 'menu-wrap', caption: _('Textwrap'), mobile: 
false, items: [
-   { text: _('No wrap'), id: 'wrap-WrapOff' },
-   { text: _('Page wrap'), id: 'wrap-WrapOn' },
-   { text: _('Wrap anchor only'), id: 
'wrap-WrapAnchorOnly' },
-   { text: _('Ideal wrap'), id: 'wrap-WrapIdeal' },
-   { text: _('Left wrap'), id: 'wrap-WrapLeft' },
-   { text: _('Right wrap'), id: 'wrap-WrapRight' },
-   { text: _('Wrap through'), id: 'wrap-WrapThrough' }
-   ]},
{type: 'button',  id: 'save', img: 'save', hint: 
_UNO('.uno:Save')},
{type: 'break', id: 'savebreak'},
{type: 'button',  id: 'undo',  img: 'undo', hint: 
_UNO('.uno:Undo'), uno: 'Undo', disabled: true, mobile: false},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'libreoffice-6-2' - loleaflet/js

2018-11-28 Thread Libreoffice Gerrit user
 loleaflet/js/toolbar.js |   14 --
 1 file changed, 14 deletions(-)

New commits:
commit 5e5221bd92e2bb229d988be4a0ad86fa12b6
Author: Thorsten Behrens 
AuthorDate: Wed Nov 28 17:28:36 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 28 21:20:45 2018 +0100

loleaflet: remove TextWrap menu from toolbar

Since it's available already from the context menu.

Change-Id: Ia79a5f21b2d757621a3cb8d7114b90617c6c2acf
Reviewed-on: https://gerrit.libreoffice.org/64194
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 0b293580b..f4fc46c87 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -172,11 +172,6 @@ function onClick(e, id, item, subItem) {
else if (id === 'lastrecord') {

$('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft()
 + 120);
}
-   else if (id.startsWith('menu-wrap:wrap-'))
-   {
-   var wrapType = id.substring('menu-wrap:wrap-'.length);
-   map.toggleCommandState(wrapType);
-   }
else if (id === 'insertgraphic' || item.id === 'localgraphic') {
L.DomUtil.get('insertgraphic').click();
}
@@ -618,15 +613,6 @@ var fontsizesSelectValue;
 
 function createToolbar() {
var toolItems = [
-   {type: 'menu', id: 'menu-wrap', caption: _('Textwrap'), mobile: 
false, items: [
-   { text: _('No wrap'), id: 'wrap-WrapOff' },
-   { text: _('Page wrap'), id: 'wrap-WrapOn' },
-   { text: _('Wrap anchor only'), id: 
'wrap-WrapAnchorOnly' },
-   { text: _('Ideal wrap'), id: 'wrap-WrapIdeal' },
-   { text: _('Left wrap'), id: 'wrap-WrapLeft' },
-   { text: _('Right wrap'), id: 'wrap-WrapRight' },
-   { text: _('Wrap through'), id: 'wrap-WrapThrough' }
-   ]},
{type: 'button',  id: 'save', img: 'save', hint: 
_UNO('.uno:Save')},
{type: 'break', id: 'savebreak'},
{type: 'button',  id: 'undo',  img: 'undo', hint: 
_UNO('.uno:Undo'), uno: 'Undo', disabled: true, mobile: false},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-11-28 Thread Libreoffice Gerrit user
 sw/source/core/doc/docredln.cxx   |4 +-
 sw/source/uibase/uno/unotxdoc.cxx |   69 ++
 2 files changed, 44 insertions(+), 29 deletions(-)

New commits:
commit fc98dac9eeff15a0d04e643017cb1d49a69bca00
Author: Ashod Nakashian 
AuthorDate: Thu Nov 8 11:02:26 2018 -0500
Commit: Andras Timar 
CommitDate: Wed Nov 28 21:17:22 2018 +0100

LOK: don't emit redline comments

Change tracking can be quite numerous. Showing the
markers (and their comments" as comment-boxes is
sensible where there is limited change in a doc.

However with extensively modified doc, this becomes
overwhelming both in terms of browser load and
editing performance. As such, we disable them
as they don't add much value. The user can still
access them from the Track Changes > Manage menu.

Use a rather nasty env. var hack to propagate this
setting from WSD for now.

Change-Id: I3f964816b4a10f565012b273added8a8413cd309
Signed-off-by: Michael Meeks 
(cherry picked from commit d4f821b7a385953542e90b2749690b9f8f4cc782)
Reviewed-on: https://gerrit.libreoffice.org/64176
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index 02774b88002e..c1873fbaad74 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -351,7 +351,9 @@ void lcl_LOKInvalidateStartEndFrames(SwShellCursor& rCursor)
 /// Emits LOK notification about one addition / removal of a redline item.
 void SwRedlineTable::LOKRedlineNotification(RedlineNotification nType, 
SwRangeRedline* pRedline)
 {
-if (!comphelper::LibreOfficeKit::isActive())
+// Disable since usability is very low beyond some small number of changes.
+static bool bDisableRedlineComments = getenv("DISABLE_REDLINE") != nullptr;
+if (!comphelper::LibreOfficeKit::isActive() || bDisableRedlineComments)
 return;
 
 boost::property_tree::ptree aRedline;
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index e7ae142d9bf1..b4ecdc0649f7 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3275,40 +3275,53 @@ Pointer SwXTextDocument::getPointer()
 
 OUString SwXTextDocument::getTrackedChanges()
 {
-const SwRedlineTable& rRedlineTable = 
pDocShell->GetDoc()->getIDocumentRedlineAccess().GetRedlineTable();
 boost::property_tree::ptree aTrackedChanges;
-for (SwRedlineTable::size_type i = 0; i < rRedlineTable.size(); ++i)
-{
-boost::property_tree::ptree aTrackedChange;
-aTrackedChange.put("index", rRedlineTable[i]->GetId());
-aTrackedChange.put("author", 
rRedlineTable[i]->GetAuthorString(1).toUtf8().getStr());
-aTrackedChange.put("type", 
nsRedlineType_t::SwRedlineTypeToOUString(rRedlineTable[i]->GetRedlineData().GetType()).toUtf8().getStr());
-aTrackedChange.put("comment", 
rRedlineTable[i]->GetRedlineData().GetComment().toUtf8().getStr());
-aTrackedChange.put("description", 
rRedlineTable[i]->GetDescr().toUtf8().getStr());
-OUString sDateTime = 
utl::toISO8601(rRedlineTable[i]->GetRedlineData().GetTimeStamp().GetUNODateTime());
-aTrackedChange.put("dateTime", sDateTime.toUtf8().getStr());
-
-SwContentNode* pContentNd = rRedlineTable[i]->GetContentNode();
-SwView* pView = dynamic_cast(SfxViewShell::Current());
-if (pView && pContentNd)
+
+// Disable since usability is very low beyond some small number of changes.
+static bool bDisableRedlineComments = getenv("DISABLE_REDLINE") != nullptr;
+if (!bDisableRedlineComments)
+{
+const SwRedlineTable& rRedlineTable
+= 
pDocShell->GetDoc()->getIDocumentRedlineAccess().GetRedlineTable();
+for (SwRedlineTable::size_type i = 0; i < rRedlineTable.size(); ++i)
 {
-SwShellCursor aCursor(pView->GetWrtShell(), 
*(rRedlineTable[i]->Start()));
-aCursor.SetMark();
-aCursor.GetMark()->nNode = *pContentNd;
-aCursor.GetMark()->nContent.Assign(pContentNd, 
rRedlineTable[i]->End()->nContent.GetIndex());
+boost::property_tree::ptree aTrackedChange;
+aTrackedChange.put("index", rRedlineTable[i]->GetId());
+aTrackedChange.put("author", 
rRedlineTable[i]->GetAuthorString(1).toUtf8().getStr());
+aTrackedChange.put("type", 
nsRedlineType_t::SwRedlineTypeToOUString(
+   
rRedlineTable[i]->GetRedlineData().GetType())
+   .toUtf8()
+   .getStr());
+aTrackedChange.put("comment",
+   
rRedlineTable[i]->GetRedlineData().GetComment().toUtf8().getStr());
+aTrackedChange.put("description", 
rRedlineTable[i]->GetDescr().toUtf8().getStr());
+OUString sDateTime = utl:

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/uiconfig sw/uiconfig

2018-11-28 Thread Libreoffice Gerrit user
 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   59 ++
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |   47 
 2 files changed, 62 insertions(+), 44 deletions(-)

New commits:
commit 16c739eb500eec27c0e2d040a492456ee1c7cbbe
Author: andreas kainz 
AuthorDate: Wed Nov 28 13:22:18 2018 +0100
Commit: andreas_kainz 
CommitDate: Wed Nov 28 21:07:10 2018 +0100

NB tabbed compact: update toolbar

Change-Id: I5c2cd3339634cbb88f2c89226ff46d342eebc3a1
Reviewed-on: https://gerrit.libreoffice.org/64160
Tested-by: Jenkins
Reviewed-by: andreas_kainz 
(cherry picked from commit 22f2d93f1626765b16e390a18a267f9c46dab59c)
Reviewed-on: https://gerrit.libreoffice.org/64173

diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index 97ed18278bf8..e9eab32b947b 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -1150,6 +1150,13 @@
   
 
 
+  
+True
+False
+.uno:VerticalText
+  
+
+
   
 True
 False
@@ -2607,8 +2614,8 @@
 
   
 True
-True
-~File
+False
+File
 True
   
   
@@ -3843,8 +3850,8 @@
 
   
 True
-True
-~Home
+False
+Home
 True
 
   
@@ -4500,8 +4507,8 @@
 
   
 True
-True
-~Insert
+False
+Insert
 True
   
   
@@ -5032,8 +5039,8 @@
 
   
 True
-True
-~Layout
+False
+Layout
 True
   
   
@@ -5720,8 +5727,8 @@
 
   
 True
-True
-~Data
+False
+Data
 True
   
   
@@ -6128,8 +6135,8 @@
 
   
 True
-True
-~Review
+False
+Review
 True
   
   
@@ -6657,8 +6664,8 @@
 
   
 True
-True
-~View
+False
+View
 True
   
   
@@ -7352,8 +7359,8 @@
 
   
 True

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg officecfg/registry sc/uiconfig sd/uiconfig sw/uiconfig

 icon-themes/colibre/cmd/32/toolsmacroedit.png|binary
 icon-themes/colibre/cmd/lc_scriptorganizer.png   |binary
 icon-themes/colibre/cmd/sc_scriptorganizer.png   |binary
 icon-themes/colibre/links.txt|   11 
+
 icon-themes/colibre/res/lx03252.png  |binary
 icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg|   21 
++
 icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg   |   14 
++
 icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg   |   14 
++
 icon-themes/colibre_svg/res/lx03252.svg  |2 
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |3 +
 sc/uiconfig/scalc/ui/notebookbar.ui  |4 -
 sd/uiconfig/sdraw/ui/notebookbar.ui  |4 -
 sd/uiconfig/simpress/ui/notebookbar.ui   |4 -
 sw/uiconfig/swriter/ui/notebookbar.ui|   11 
++---
 14 files changed, 75 insertions(+), 13 deletions(-)

New commits:
commit 2c154667ff257a9aaec2baa386cec7b9e129132d
Author: andreas kainz 
AuthorDate: Wed Nov 28 13:16:23 2018 +0100
Commit: andreas_kainz 
CommitDate: Wed Nov 28 21:07:20 2018 +0100

tdf#121581 change organize dialoogs to organize macro

add missing colibre icons
improve layout for large icons

Change-Id: Id9d003b945654f958ec43d530083e2070d4b580e
Reviewed-on: https://gerrit.libreoffice.org/64159
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/32/toolsmacroedit.png 
b/icon-themes/colibre/cmd/32/toolsmacroedit.png
new file mode 100644
index ..3b3061988c22
Binary files /dev/null and b/icon-themes/colibre/cmd/32/toolsmacroedit.png 
differ
diff --git a/icon-themes/colibre/cmd/lc_scriptorganizer.png 
b/icon-themes/colibre/cmd/lc_scriptorganizer.png
new file mode 100644
index ..cd202cf2eed0
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_scriptorganizer.png 
differ
diff --git a/icon-themes/colibre/cmd/sc_scriptorganizer.png 
b/icon-themes/colibre/cmd/sc_scriptorganizer.png
new file mode 100644
index ..734d8a401f6e
Binary files /dev/null and b/icon-themes/colibre/cmd/sc_scriptorganizer.png 
differ
diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index 7c12157267c1..7d498f287ab0 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -1801,3 +1801,14 @@ cmd/lc_tableevents.png cmd/lc_animationeffects.png
 cmd/sc_sheetlefttoright.png cmd/sc_paralefttoright.png
 cmd/sc_sheetrighttoleft.png cmd/sc_pararighttoleft.png
 cmd/sc_tableevents.png cmd/sc_animationeffects.png
+
+
+# Macro
+cmd/32/macrosmenu.png cmd/32/choosemacro.png
+cmd/32/basicideappear.png cmd/32/toolsmacroedit.png
+
+cmd/lc_macrosmenu.png cmd/lc_choosemacro.png
+cmd/lc_basicideappear.png cmd/lc_toolsmacroedit.png
+
+cmd/sc_macrosmenu.png cmd/sc_choosemacro.png
+cmd/sc_basicideappear.png cmd/sc_toolsmacroedit.png
diff --git a/icon-themes/colibre/res/lx03252.png 
b/icon-themes/colibre/res/lx03252.png
index 007769c55c7d..edac6bc02f4a 100644
Binary files a/icon-themes/colibre/res/lx03252.png and 
b/icon-themes/colibre/res/lx03252.png differ
diff --git a/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg 
b/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg
new file mode 100644
index ..87054391316c
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/toolsmacroedit.svg
@@ -0,0 +1,21 @@
+http://www.w3.org/2000/svg";>
+  
+  
+  
+
+
+  
+
diff --git a/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg 
b/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg
new file mode 100644
index ..4075bd463f20
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/lc_scriptorganizer.svg
@@ -0,0 +1,14 @@
+http://www.w3.org/2000/svg";>
+
+
+  
+
diff --git a/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg 
b/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg
new file mode 100644
index ..13ac6d6dc4cd
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/sc_scriptorganizer.svg
@@ -0,0 +1,14 @@
+http://www.w3.org/2000/svg";>
+  
+  
+
+
diff --git a/icon-themes/colibre_svg/res/lx03252.svg 
b/icon-themes/colibre_svg/res/lx03252.svg
index a2ca91cfcfc8..6fae78de924e 100644
--- a/icon-themes/colibre_svg/res/lx03252.svg
+++ b/icon-themes/colibre_svg/res/lx03252.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 83b25c19508e..ecaf820b572b 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.

[Libreoffice-commits] core.git: sw/source

 sw/source/uibase/uno/unotxvw.cxx |   27 +++
 1 file changed, 27 insertions(+)

New commits:
commit e0ac72a1b714adc8f2ed8a721a8c0c1894d183e2
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 15:46:14 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 20:48:48 2018 +0100

tdf#112696 if we select every member of a group, select the group itself

Change-Id: I1b540772ff3a04c2cb32135c972f3a745c307eb9
Reviewed-on: https://gerrit.libreoffice.org/64179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/uno/unotxvw.cxx b/sw/source/uibase/uno/unotxvw.cxx
index 1a9b9b116a0e..204f8ed45447 100644
--- a/sw/source/uibase/uno/unotxvw.cxx
+++ b/sw/source/uibase/uno/unotxvw.cxx
@@ -312,6 +312,33 @@ sal_Bool SwXTextView::select(const uno::Any& aInterface)
 bRet = true;
 }
 }
+
+// tdf#112696 if we selected every individual element of a group, then
+// select that group instead
+const SdrMarkList &rMrkList = pDrawView->GetMarkedObjectList();
+size_t nMarkCount = rMrkList.GetMarkCount();
+if (nMarkCount > 1)
+{
+SdrObject* pObject = rMrkList.GetMark(0)->GetMarkedSdrObj();
+SdrObject* pGroupParent = 
pObject->getParentSdrObjectFromSdrObject();
+for (size_t i = 1; i < nMarkCount; ++i)
+{
+pObject = rMrkList.GetMark(i)->GetMarkedSdrObj();
+SdrObject* pParent = 
pObject->getParentSdrObjectFromSdrObject();
+if (pParent != pGroupParent)
+{
+pGroupParent = nullptr;
+break;
+}
+}
+
+if (pGroupParent && pGroupParent->IsGroupObject() &&
+pGroupParent->getChildrenOfSdrObject()->GetObjCount() == 
nMarkCount)
+{
+pDrawView->UnmarkAll();
+pDrawView->MarkObj(pGroupParent, pPV);
+}
+}
 }
 return bRet;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/source

 sw/source/uibase/uno/unotxvw.cxx |   27 +++
 1 file changed, 27 insertions(+)

New commits:
commit b39c91cf5a2c21924f8ac780dadab75a6a2a0713
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 15:46:14 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 20:48:34 2018 +0100

tdf#112696 if we select every member of a group, select the group itself

Change-Id: I1b540772ff3a04c2cb32135c972f3a745c307eb9
Reviewed-on: https://gerrit.libreoffice.org/64180
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/uno/unotxvw.cxx b/sw/source/uibase/uno/unotxvw.cxx
index 1a9b9b116a0e..204f8ed45447 100644
--- a/sw/source/uibase/uno/unotxvw.cxx
+++ b/sw/source/uibase/uno/unotxvw.cxx
@@ -312,6 +312,33 @@ sal_Bool SwXTextView::select(const uno::Any& aInterface)
 bRet = true;
 }
 }
+
+// tdf#112696 if we selected every individual element of a group, then
+// select that group instead
+const SdrMarkList &rMrkList = pDrawView->GetMarkedObjectList();
+size_t nMarkCount = rMrkList.GetMarkCount();
+if (nMarkCount > 1)
+{
+SdrObject* pObject = rMrkList.GetMark(0)->GetMarkedSdrObj();
+SdrObject* pGroupParent = 
pObject->getParentSdrObjectFromSdrObject();
+for (size_t i = 1; i < nMarkCount; ++i)
+{
+pObject = rMrkList.GetMark(i)->GetMarkedSdrObj();
+SdrObject* pParent = 
pObject->getParentSdrObjectFromSdrObject();
+if (pParent != pGroupParent)
+{
+pGroupParent = nullptr;
+break;
+}
+}
+
+if (pGroupParent && pGroupParent->IsGroupObject() &&
+pGroupParent->getChildrenOfSdrObject()->GetObjCount() == 
nMarkCount)
+{
+pDrawView->UnmarkAll();
+pDrawView->MarkObj(pGroupParent, pPV);
+}
+}
 }
 return bRet;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

 vcl/unx/gtk3/gtk3gtkinst.cxx |   50 ++-
 1 file changed, 49 insertions(+), 1 deletion(-)

New commits:
commit f761968bdd609267add6c968d62fffee1d9ee9e7
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 11:50:19 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 20:48:16 2018 +0100

Resolves: tdf#121752 let scroll wheel change active notebook tab

Change-Id: If8437346a58ea14266f11293b94082740303e5a9
Reviewed-on: https://gerrit.libreoffice.org/64170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 6eb623efe088..286206f7c4a5 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -3012,6 +3012,7 @@ private:
 GtkNotebook* m_pNotebook;
 gulong m_nSwitchPageSignalId;
 gulong m_nSizeAllocateSignalId;
+gulong m_nScrollSignalId;
 mutable std::vector> m_aPages;
 
 static void signalSwitchPage(GtkNotebook*, GtkWidget*, guint nNewPage, 
gpointer widget)
@@ -3033,6 +3034,50 @@ private:
 m_aEnterPageHdl.Call(sNewIdent);
 }
 
+static gboolean signalScroll(GtkWidget*, GdkEventScroll* event, gpointer 
widget)
+{
+GtkInstanceNotebook* pThis = static_cast(widget);
+return pThis->signal_scroll(event);
+}
+
+bool signal_scroll(GdkEventScroll* event)
+{
+bool bNext(false), bPrev(false);
+switch (event->direction)
+{
+case GDK_SCROLL_RIGHT:
+case GDK_SCROLL_DOWN:
+bNext = true;
+break;
+case GDK_SCROLL_LEFT:
+case GDK_SCROLL_UP:
+bPrev = true;
+break;
+case GDK_SCROLL_SMOOTH:
+{
+switch (gtk_notebook_get_tab_pos(m_pNotebook))
+{
+case GTK_POS_LEFT:
+case GTK_POS_RIGHT:
+bNext = event->delta_y > 0;
+bPrev = event->delta_y < 0;
+break;
+case GTK_POS_TOP:
+case GTK_POS_BOTTOM:
+bNext = event->delta_x > 0;
+bPrev = event->delta_x < 0;
+break;
+}
+break;
+}
+}
+if (bNext)
+gtk_notebook_next_page(m_pNotebook);
+else if (bPrev)
+gtk_notebook_prev_page(m_pNotebook);
+return true;
+}
+
 OString get_page_ident(guint nPage) const
 {
 const GtkWidget* pTabWidget = gtk_notebook_get_tab_label(m_pNotebook, 
gtk_notebook_get_nth_page(m_pNotebook, nPage));
@@ -3097,6 +3142,8 @@ public:
 , m_pNotebook(pNotebook)
 , m_nSwitchPageSignalId(g_signal_connect(pNotebook, "switch-page", 
G_CALLBACK(signalSwitchPage), this))
 {
+gtk_widget_add_events(GTK_WIDGET(pNotebook), GDK_SCROLL_MASK);
+m_nScrollSignalId = g_signal_connect(pNotebook, "scroll-event", 
G_CALLBACK(signalScroll), this);
 if (get_n_pages() > 6)
 m_nSizeAllocateSignalId = g_signal_connect(pNotebook, 
"size-allocate", G_CALLBACK(signalSizeAllocate), this);
 else
@@ -3188,9 +3235,10 @@ public:
 
 virtual ~GtkInstanceNotebook() override
 {
-g_signal_handler_disconnect(m_pNotebook, m_nSwitchPageSignalId);
 if (m_nSizeAllocateSignalId)
 g_signal_handler_disconnect(m_pNotebook, m_nSizeAllocateSignalId);
+g_signal_handler_disconnect(m_pNotebook, m_nScrollSignalId);
+g_signal_handler_disconnect(m_pNotebook, m_nSwitchPageSignalId);
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Minutes from the UX/design meeting 2018-Nov-28

Present: Heiko

Tickets 

* Context menu with "cut,copy,...,symbols" inaccessible, if word is 
autocorrectable
   + https://bugs.documentfoundation.org/show_bug.cgi?id=120901
   + minimum consistency is good, so yes (Heiko)
   + agree; we made a similar decision some time ago (Cor)
   => go for it

 * delete referenced cell - raise error
   + https://bugs.documentfoundation.org/show_bug.cgi?id=92419
   + WF acc. c9, 15, 17
   + there are more workflows where users could benefit from some help
 but s/he should learn the tools (Cor)
   => WF

 * Pasting from Writer to Impress Should be "Text only" by default
   + https://bugs.documentfoundation.org/show_bug.cgi?id=121574
   + agree (Heiko)
   + keep the current behaviour; users should learn to paste special (Cor)
   + better go with rich text format by default
   => following Regina treating this as a bug

 * New comment box should automatically re-position and re-size appropriately
   based on the shape of text pasted into it
   + https://bugs.documentfoundation.org/show_bug.cgi?id=104271
   + position (#1) WFM, size (#2) the proposal assumes line breakes but we 
could 
 always adjust the height automatically (and width if the text is smaller); 
 would also make sense to increase the default size a bit
   + support the idea (Cor)
   = go for size but not position

 * UI: tool bar: adding application/input line results in unusable button 
instead of input line like in formula bar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=99834
   + WF (but it would be nice to have the edit line in the function sidebar, 
bug 92416 & meta 103441)
   + agree with WF (Cor)
   => WF





signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: README.md

 README.md |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 58904bb5b0bcba2f0c6a598f5cd5f2891a66dc3c
Author: Stephan Bergmann 
AuthorDate: Wed Nov 28 16:30:03 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 19:56:33 2018 +0100

Xcode 9.3 reportedly requires at least macOS 10.13.2

...according to .  (See also the 
discussion
in the mail sub-thread starting at


"Re: Compiler baselines".)

Change-Id: Iab6fa737dfeb7cea93b18ec85c76d21da92e1d6d
Reviewed-on: https://gerrit.libreoffice.org/64177
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/README.md b/README.md
index 1285ed7e3f12..45abb593bf9d 100644
--- a/README.md
+++ b/README.md
@@ -37,7 +37,7 @@ run and compile LibreOffice, also used by the TDF builds:
 * Build: Cygwin + Visual Studio 2017
 * macOS:
 * Runtime: 10.10
-* Build: 10.12 + Xcode 9.3
+* Build: 10.13.2 + Xcode 9.3
 * Linux:
 * Runtime: RHEL 6 or CentOS 6
 * Build: GCC 4.8.1 or Clang
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Tinberbox MacOSX-x86_64_49-TDF failure - ld: file not found

In this range: 
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=313a0efb1d703a36030a7e5e55bd308c7e4650f3..ae3309c908311248f1580a894f197732964bfac2

@49 started failing with: 

https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&full-log=1543237201.21995

  [build LOC] vcl
  [build SED] CustomTarget/wizards/share/dialog.xlc
  [build SED] CustomTarget/wizards/share/script.xlc
  [build PKG] wizards_properties
  [build LOC] wizards
  [build LOC] writerperfect
  [build LOC] xmlsecurity
  [build CUS] instsetoo_native/setup
  [build LOC] external
  [build CHK] external
  [build SLC] external
  [build UPK] boost_1_66_0.tar.bz2
  [build LNK] Library/libuno_sal.dylib.3
  [build UPK] icu4c-63_1-src.tgz
  [build UPK] nss-3.38-with-nspr-4.19.tar.gz
  NEXTld: file not found: 
/Users/cloph/tb/workdir/CObject/sal/osl/unx/backtrace.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/compat.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/debugbase.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/filepath.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/loadmodulerelative.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/log.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/signalshared.o/Users/cloph/tb/workdir/CxxObject/sal/osl/all/utility.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_arena.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_cache.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_fini.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/alloc_global.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/bootstrap.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/byteseq.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/cipher.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/cmdargs.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/crc.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/digest.o/Users/cloph/tb/workdir/CxxObject/sal/rtl/hash.
7157  NEXTclang: error: linker command failed with exit code 1 (use -v to 
see invocation)
7158  NEXTmake[1]: *** 
[/Users/cloph/tb/instdir/LibreOfficeDev.app/Contents/Frameworks/libuno_sal.dylib.3]
 Error 1
7159  make[1]: *** Waiting for unfinished jobs
7160  NEXTmake: *** [build] Error 2


possibility caused by this commit?
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ab9d95e6073d

Use -filelist with macOS linker


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - .gitreview

 .gitreview |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8105dfe757f5b18a39387a0ae116d11a6b46f547
Author: Thorsten Behrens 
AuthorDate: Wed Nov 28 18:53:54 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Nov 28 18:53:54 2018 +0100

fix the .gitreview to point to the 6.1 distro/lhm/... branch

Change-Id: I0c66fe18c6fa74d6619179eb0425a7ac40a647eb

diff --git a/.gitreview b/.gitreview
index 040bbce83108..65b6d0d4116e 100644
--- a/.gitreview
+++ b/.gitreview
@@ -3,5 +3,5 @@ host=logerrit
 port=29418
 project=core
 defaultremote=logerrit
-defaultbranch=libreoffice-6-1
+defaultbranch=distro/lhm/libreoffice-6-1+backports
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

 sw/inc/poolfmt.hxx  |3 ++-
 sw/inc/strings.hrc  |1 +
 sw/qa/python/check_styles.py|2 +-
 sw/source/core/doc/DocumentStylePoolManager.cxx |7 +++
 sw/source/core/doc/SwStyleNameMapper.cxx|3 ++-
 sw/source/core/doc/poolfmt.cxx  |   11 ---
 6 files changed, 21 insertions(+), 6 deletions(-)

New commits:
commit a9022502e0b0e2b40aa55aeee375467fc0ab75e6
Author: heiko tietze 
AuthorDate: Wed Nov 28 10:51:04 2018 +0100
Commit: Heiko Tietze 
CommitDate: Wed Nov 28 18:49:48 2018 +0100

tdf#121369 - Header and Footer parent styles

New "Header and Footer" style introduced as parent to header/footer styles
Right alignment set for HeaderR and FooterR

Change-Id: Iff407da8907b761236ebc2aa8877b9d6b8294e10
Reviewed-on: https://gerrit.libreoffice.org/64152
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sw/inc/poolfmt.hxx b/sw/inc/poolfmt.hxx
index 67191db7f676..22b075978aff 100644
--- a/sw/inc/poolfmt.hxx
+++ b/sw/inc/poolfmt.hxx
@@ -327,7 +327,8 @@ RES_POOLCOLL_LISTS_END,
 RES_POOLCOLL_EXTRA_BEGIN = COLL_EXTRA_BITS,
 
 /// Subgroup header.
-RES_POOLCOLL_HEADER = RES_POOLCOLL_EXTRA_BEGIN, ///< Header Left&Right.
+RES_POOLCOLL_HEADERFOOTER = RES_POOLCOLL_EXTRA_BEGIN,   ///< Header and Footer.
+RES_POOLCOLL_HEADER,///< Header Left&Right.
 RES_POOLCOLL_HEADERL,   ///< Header Left.
 RES_POOLCOLL_HEADERR,   ///< Header Right.
 
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index ac8ad3c44826..a53b4546e8c2 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -122,6 +122,7 @@
 #define STR_POOLCOLL_BUL_LEVEL5 NC_("STR_POOLCOLL_BUL_LEVEL5", 
"List 5")
 #define STR_POOLCOLL_BUL_LEVEL5E
NC_("STR_POOLCOLL_BUL_LEVEL5E", "List 5 End")
 #define STR_POOLCOLL_BUL_NONUM5 NC_("STR_POOLCOLL_BUL_NONUM5", 
"List 5 Cont.")
+#define STR_POOLCOLL_HEADERFOOTER   NC_("STR_POOLCOLL_HEADER", 
"Header and Footer")
 #define STR_POOLCOLL_HEADER NC_("STR_POOLCOLL_HEADER", 
"Header")
 #define STR_POOLCOLL_HEADERLNC_("STR_POOLCOLL_HEADERL", 
"Header Left")
 #define STR_POOLCOLL_HEADERRNC_("STR_POOLCOLL_HEADERR", 
"Header Right")
diff --git a/sw/qa/python/check_styles.py b/sw/qa/python/check_styles.py
index a52d84cd1b44..8746c479fbbe 100644
--- a/sw/qa/python/check_styles.py
+++ b/sw/qa/python/check_styles.py
@@ -132,7 +132,7 @@ class CheckStyle(unittest.TestCase):
 def test_ParagraphFamily(self):
 xDoc = CheckStyle._uno.openEmptyWriterDoc()
 xParaStyles = xDoc.StyleFamilies["ParagraphStyles"]
-vEmptyDocStyles = ['Standard', 'Heading', 'Text body', 'List', 
'Caption', 'Index', 'First line indent', 'Hanging indent', 'Text body indent', 
'Salutation', 'Signature', 'List Indent', 'Marginalia', 'Heading 1', 'Heading 
2', 'Heading 3', 'Heading 4', 'Heading 5', 'Heading 6', 'Heading 7', 'Heading 
8', 'Heading 9', 'Heading 10', 'Title', 'Subtitle', 'Numbering 1 Start', 
'Numbering 1', 'Numbering 1 End', 'Numbering 1 Cont.', 'Numbering 2 Start', 
'Numbering 2', 'Numbering 2 End', 'Numbering 2 Cont.', 'Numbering 3 Start', 
'Numbering 3', 'Numbering 3 End', 'Numbering 3 Cont.', 'Numbering 4 Start', 
'Numbering 4', 'Numbering 4 End', 'Numbering 4 Cont.', 'Numbering 5 Start', 
'Numbering 5', 'Numbering 5 End', 'Numbering 5 Cont.', 'List 1 Start', 'List 
1', 'List 1 End', 'List 1 Cont.', 'List 2 Start', 'List 2', 'List 2 End', 'List 
2 Cont.', 'List 3 Start', 'List 3', 'List 3 End', 'List 3 Cont.', 'List 4 
Start', 'List 4', 'List 4 End', 'List 4 Cont.', 'List 5 Start', 'List 5', 'List 
5 E
 nd', 'List 5 Cont.', 'Index Heading', 'Index 1', 'Index 2', 'Index 3', 'Index 
Separator', 'Contents Heading', 'Contents 1', 'Contents 2', 'Contents 3', 
'Contents 4', 'Contents 5', 'User Index Heading', 'User Index 1', 'User Index 
2', 'User Index 3', 'User Index 4', 'User Index 5', 'Contents 6', 'Contents 7', 
'Contents 8', 'Contents 9', 'Contents 10', 'Figure Index Heading', 'Figure 
Index 1', 'Object index heading', 'Object index 1', 'Table index heading', 
'Table index 1', 'Bibliography Heading', 'Bibliography 1', 'User Index 6', 
'User Index 7', 'User Index 8', 'User Index 9', 'User Index 10', 'Header', 
'Header left', 'Header right', 'Footer', 'Footer left', 'Footer right', 'Table 
Contents', 'Table Heading', 'Illustration', 'Table', 'Text','Figure', 'Frame 
contents', 'Footnote', 'Addressee', 'Sender', 'Endnote', 'Drawing', 
'Quotations', 'Preformatted Text', 'Horizontal Line', 'List Contents', 'List 
Heading']
+vEmptyDocStyles = ['Standard', 'Heading', 'Text body', 'List', 
'Caption', 'Index', 'First line indent', 'Hanging indent', 'Text body indent', 
'Salutation', 'Signature', 'List Indent', 'Marginalia', 'Heading 

[Libreoffice-commits] core.git: Branch 'private/mst/sw_redlinehide_4a' - 8 commits - sw/qa sw/source

Rebased ref, commits from common ancestor:
commit 3e7b5525270a4849174f9df72741e298b1a8cd13
Author: Michael Stahl 
AuthorDate: Wed Nov 28 18:15:41 2018 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 28 18:15:41 2018 +0100

sw_redlinehide_4a: stop toggling ShowDelete in SwAutoFormat

Change-Id: Ib6495d4248faa679d5a55642ac51baf419708287

diff --git a/sw/source/core/edit/autofmt.cxx b/sw/source/core/edit/autofmt.cxx
index 01ec8dd6e46a..9b89732b60fe 100644
--- a/sw/source/core/edit/autofmt.cxx
+++ b/sw/source/core/edit/autofmt.cxx
@@ -19,6 +19,10 @@
 
 #include 
 
+#include 
+
+#include 
+
 #include 
 
 #include 
@@ -2235,14 +2239,21 @@ SwAutoFormat::SwAutoFormat( SwEditShell* pEdShell, 
SvxSwAutoFormatFlags const &
  m_nEndNdIdx = m_aEndNdIdx.GetIndex(),
  m_pDoc->GetDocShell() );
 
+uno::Reference const xContext(
+comphelper::getProcessComponentContext());
+bool const 
isExp(officecfg::Office::Common::Misc::ExperimentalMode::get(xContext));
 RedlineFlags eRedlMode = 
m_pDoc->getIDocumentRedlineAccess().GetRedlineFlags(), eOldMode = eRedlMode;
 if( m_aFlags.bWithRedlining )
 {
 m_pDoc->SetAutoFormatRedline( true );
-eRedlMode = RedlineFlags::On | RedlineFlags::ShowInsert;
+eRedlMode = (isExp)
+? RedlineFlags::On | (eOldMode & RedlineFlags::ShowMask)
+: RedlineFlags::On | RedlineFlags::ShowInsert;
 }
 else
-  eRedlMode = RedlineFlags::ShowInsert | RedlineFlags::Ignore;
+  eRedlMode = (isExp)
+  ? RedlineFlags::Ignore | (eOldMode & RedlineFlags::ShowMask)
+  : RedlineFlags::ShowInsert | RedlineFlags::Ignore;
 m_pDoc->getIDocumentRedlineAccess().SetRedlineFlags( eRedlMode );
 
 // save undo state (might be turned off)
commit 1e3cfbc7b4659d8db8cb488a03aabb15d1453912
Author: Michael Stahl 
AuthorDate: Wed Nov 28 18:15:18 2018 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 28 18:15:18 2018 +0100

currently we still have ShowDelete disableable

Change-Id: I2f7bdee1d527895b745c7cf010e195e721556bd7

diff --git a/sw/source/core/edit/autofmt.cxx b/sw/source/core/edit/autofmt.cxx
index f45ba31b846b..01ec8dd6e46a 100644
--- a/sw/source/core/edit/autofmt.cxx
+++ b/sw/source/core/edit/autofmt.cxx
@@ -1110,6 +1110,10 @@ bool GetRanges(std::vector> 
& rRanges,
 bool isNoRedline(true);
 SwRedlineTable::size_type tmp;
 IDocumentRedlineAccess const& rIDRA(rDoc.getIDocumentRedlineAccess());
+if (!(rIDRA.GetRedlineFlags() & RedlineFlags::ShowDelete))
+{
+return isNoRedline;
+}
 rIDRA.GetRedline(*rDelPam.Start(), &tmp);
 SwPosition const* pCurrent(rDelPam.Start());
 for ( ; tmp < rIDRA.GetRedlineTable().size(); ++tmp)
commit 030b03a16694f77282e5f2b998102167710e54f9
Author: Michael Stahl 
AuthorDate: Wed Nov 28 17:41:09 2018 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 28 18:14:59 2018 +0100

sw_redlinehide_4a: TextFrameIndex goes live

Change-Id: Ie59c09bdc57505e16022c43791d5e65cc233d5b9

diff --git a/sw/source/core/inc/TextFrameIndex.hxx 
b/sw/source/core/inc/TextFrameIndex.hxx
index d15fc7bf6691..3987bd5903fe 100644
--- a/sw/source/core/inc/TextFrameIndex.hxx
+++ b/sw/source/core/inc/TextFrameIndex.hxx
@@ -13,17 +13,13 @@
 #include 
 #include 
 
-#if 0
-typedef o3tl::strong_int TextFrameIndex;
-#else
 /**
  * Denotes a character index in a text frame at a layout level, after extent
  * mapping from a text node at a document model level.
  *
  * @see SwTextFrame::MapViewToModelPos().
  */
-typedef sal_Int32 TextFrameIndex;
-#endif
+typedef o3tl::strong_int TextFrameIndex;
 
 #endif // INCLUDED_SW_SOURCE_CORE_INC_TEXTFRAMEINDEX_HXX
 
commit 0d36421dfb1ce836e3cb84cc04ea5cae37d787f1
Author: Michael Stahl 
AuthorDate: Wed Nov 28 17:39:44 2018 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 28 17:39:44 2018 +0100

sw_redlinehide_4a: fix up some more TextFrameIndex in tests

Change-Id: I2232498b66f3d165deb6bf761879dd8ca16913c4

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index fb399694ed9d..fa698b44450d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -4178,7 +4178,7 @@ void SwUiWriterTest::testTdf87922()
 SwNodeIndex aNodeIndex(pDoc->GetNodes().GetEndOfContent(), -1);
 const OUString& rText = aNodeIndex.GetNode().GetTextNode()->GetText();
 sal_Int32 nLength = rText.getLength();
-SwDrawTextInfo aDrawTextInfo(pWrtShell, *pWrtShell->GetOut(), pScriptInfo, 
rText, 0, nLength);
+SwDrawTextInfo aDrawTextInfo(pWrtShell, *pWrtShell->GetOut(), pScriptInfo, 
rText, TextFrameIndex(0), TextFrameIndex(nLength));
 // Root -> page -> body -> text.
 SwTextFrame* pTextFrame = 
static_cast(pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower());
 aDrawTextInfo.SetFrame(pTextFrame);
@@ -4222,17 +4222,17 @@ class PortionHandler : public SwPor

[Libreoffice-commits] online.git: ios/Mobile

 ios/Mobile/Info.plist.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3ad5ca0167b75b45cd868f68cc3ce84a5c817f0a
Author: Tor Lillqvist 
AuthorDate: Wed Nov 28 19:07:00 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 28 19:07:04 2018 +0200

Bump CFBundleVersion

Change-Id: I0f7aada06d3161abb012292d54d326128411e233

diff --git a/ios/Mobile/Info.plist.in b/ios/Mobile/Info.plist.in
index a2b80f32d..4f14d7eb1 100644
--- a/ios/Mobile/Info.plist.in
+++ b/ios/Mobile/Info.plist.in
@@ -197,7 +197,7 @@
 CFBundleShortVersionString
 0.1
 CFBundleVersion
-9
+10
 LSRequiresIPhoneOS
 
 UIFileSharingEnabled
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] dev-tools.git: qa/bugzillaChecker.py

 qa/bugzillaChecker.py |   30 --
 1 file changed, 24 insertions(+), 6 deletions(-)

New commits:
commit 37823b54dd0b1adc95268952e2f815c46b3346bd
Author: Xisco Fauli 
AuthorDate: Wed Nov 28 17:56:37 2018 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 28 17:56:37 2018 +0100

QA: check inactive unconfirmed bugs which last comment is from the reporter

diff --git a/qa/bugzillaChecker.py b/qa/bugzillaChecker.py
index 55f2dfd..55e8d49 100755
--- a/qa/bugzillaChecker.py
+++ b/qa/bugzillaChecker.py
@@ -29,15 +29,23 @@ memberBugs = 50
 oldUserPeriodDays = 180
 oldUserBugs = 20
 
+# bugs which last comment is from the Commit Notification
 pingFixedBugPeriodDays = 30
 
+# Unconfirmed bugs which last comment is not written by the reporter
+# or not comments at all
 retestUnconfirmedPeriodDays = 30
 
+# Unconfirmed bugs which last comment is written by the reporter
+inactiveUnconfirmedPeriodDays = 180
+
+# Needinfo bugs which last comment is written by the reporter
 retestNeedinfoPeriodDays = 60
 
+# Assigned bugs without activity
 inactiveAssignedPeriodDays = 90
 
-#tuple of versions to check whether the version has been changed at 
confirmation time
+# tuple of versions to check whether the version has been changed at 
confirmation time
 versionsToCheck = ('5', '6')
 
 crashReportDomain = "https://crashreport.libreoffice.org/stats/signature/";
@@ -295,13 +303,18 @@ def analyze_bugzilla_checkers(statList, bugzillaData, 
cfg):
 if bSameAuthor and rowStatus == 'UNCONFIRMED' and \
 datetime.datetime.strptime(row['last_change_time'], 
"%Y-%m-%dT%H:%M:%SZ") < cfg['retestUnconfirmedPeriod']:
 value = [ rowId, row['last_change_time'], creatorMail ]
-util_add_to_result(lResults, 'unconfirmed_not_triaged', value)
+util_add_to_result(lResults, 'unconfirmed_without_comments', 
value)
 
 if len(comments) > 0:
-if rowStatus == 'UNCONFIRMED' and comments[-1]['creator'] != 
creatorMail and \
+if rowStatus == 'UNCONFIRMED':
+if comments[-1]['creator'] != creatorMail and \
 datetime.datetime.strptime(row['last_change_time'], 
"%Y-%m-%dT%H:%M:%SZ") < cfg['retestUnconfirmedPeriod']:
-value = [ rowId, row['last_change_time'], 
comments[-1]['creator'] ]
-util_add_to_result(lResults, 'untouched_unconfirmed', 
value)
+value = [ rowId, row['last_change_time'], 
comments[-1]['creator'] ]
+util_add_to_result(lResults, 
'unconfirmed_last_comment_not_from_reporter', value)
+elif comments[-1]['creator'] == creatorMail and \
+datetime.datetime.strptime(row['last_change_time'], 
"%Y-%m-%dT%H:%M:%SZ") < cfg['inactiveUnconfirmedPeriod']:
+value = [ rowId, row['last_change_time'], 
comments[-1]['creator'] ]
+util_add_to_result(lResults, 
'unconfirmed_last_comment_from_reporter', value)
 
 elif rowStatus == 'NEEDINFO' and comments[-1]['creator'] == 
creatorMail and \
 datetime.datetime.strptime(row['last_change_time'], 
"%Y-%m-%dT%H:%M:%SZ") >= cfg['retestNeedinfoPeriod']:
@@ -402,9 +415,12 @@ def analyze_bugzilla_checkers(statList, bugzillaData, cfg):
 if dKey == 'inactive_assignee':
 if dValue[idx][1] >= 
cfg['coloredInactiveAssignedPeriod']:
 background = Back.GREEN
-elif dKey == 'untouched_unconfirmed' or dKey == 
'unconfirmed_not_triaged':
+elif dKey == 'unconfirmed_last_comment_not_from_reporter' 
or dKey == 'unconfirmed_without_comments':
 if dValue[idx][1] >= 
cfg['coloredRetestUnconfirmedPeriod']:
 background = Back.GREEN
+elif dKey == 'unconfirmed_last_comment_from_reporter':
+if dValue[idx][1] >= 
cfg['coloredInactiveUnconfirmedPeriod']:
+background = Back.GREEN
 elif dKey == 'ping_bug_fixed':
 if dValue[idx][1] >= cfg['coloredFixBugPingPeriod']:
 background = Back.GREEN
@@ -460,6 +476,8 @@ def runCfg():
 cfg['pingFixedBugDiff'] = common.util_convert_days_to_datetime(cfg, 
pingFixedBugPeriodDays + reportPeriodDays)
 cfg['coloredFixBugPingPeriod'] = common.util_convert_days_to_datetime(cfg, 
coloredPeriodDays + pingFixedBugPeriodDays)
 cfg['retestUnconfirmedPeriod'] = common.util_convert_days_to_datetime(cfg, 
retestUnconfirmedPeriodDays)
+cfg['coloredInactiveUnconfirmedPeriod'] = 
common.util_convert_days_to_datetime(cfg, coloredPeriodDays + 
inactiveUnconfirmedPeriodDays)
+cfg['inactiveUnconfirmedPeriod'] = 
common.util_convert_days_to_datetime(cfg, inactiveUnconfirmedPeriodDays)
 cfg['coloredRe

[Libreoffice-commits] core.git: vcl/qa

 vcl/qa/cppunit/pdfexport/pdfexport.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3bb64c0b26962f3c62dc82353b8ca13479c409be
Author: Stephan Bergmann 
AuthorDate: Wed Nov 28 15:04:44 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 17:07:50 2018 +0100

Check against concrete expected values in PdfExportTest::testTdf115262

With d464d505fbf6e53a38afdd3661d320fac8c760d6 "Refactor calc non-linear
ViewToDevice transform", the problems with my macOS build that I described 
in
the commit message of (abandoned) 

"Omit 'Calc adjust to grid hack' when not rendering for the screen" are
apparently solved:  `make CppunitTest_vcl_pdfexport test` succeeds, and 
opening
vcl/qa/cppunit/pdfexport/data/tdf115262.ods and exporting it to PDF while 
the
on-screen Calc document is displayed at varying zoom levels leads to 
effectively
identical files now.

Assuming that 232 is the universally correct value for nFirstImageTop now
(nRowTop appears to have always evaluated to 199), it looks cleaner to me to
have the expected values spelled out explicitly in the test code.

Change-Id: Idb9f30f4ab9641b5b5325ddd90084e4112e1b572
Reviewed-on: https://gerrit.libreoffice.org/64171
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 001b3de2f480..5075fef47a54 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -1577,8 +1577,8 @@ void PdfExportTest::testTdf115262()
 }
 // Make sure that the top of the "400" is below the top of the image (in
 // bottom-right-corner-based PDF coordinates).
-// This was: expected less than 144, actual is 199.
-CPPUNIT_ASSERT_LESS(nFirstImageTop, nRowTop);
+CPPUNIT_ASSERT_EQUAL(232, nFirstImageTop);
+CPPUNIT_ASSERT_EQUAL(199, nRowTop);
 FPDFText_ClosePage(pTextPage);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/qa sw/source

 sw/qa/extras/ooxmlexport/ooxmlexport12.cxx |   21 +++--
 sw/qa/extras/ww8export/ww8export3.cxx  |   22 --
 sw/source/filter/ww8/ww8par3.cxx   |   16 +++-
 3 files changed, 26 insertions(+), 33 deletions(-)

New commits:
commit 3640db087386d699e49f9a5d426c91de6788d612
Author: Justin Luth 
AuthorDate: Sat Nov 24 14:39:50 2018 +0300
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 16:49:27 2018 +0100

partial revert tdf79435 doc: round-trip legacy input formfields

Apparently import isn't always properly reading some of these
strings, so it is just garbage being round-tripped in some cases.
Let's just avoid that until such time as import might be fixed.

I couldn't readily identify the import problem. It even happens with
version eWW8 files and also TestBeltAndBraces() didn't seem to
prevent the problem.

These crashes are due to reading garbage:
/srv/crashtestdata/files/doc/ooo78311-1.doc
-DISTRICT_COURSE_OUTLINE_TEMPLATE.doc
/srv/crashtestdata/files/doc/kde79024-2.doc
-Ü2_Blanko.doc
/srv/crashtestdata/files/doc/ooo24395-1.doc
-stateapp-emp.doc
/srv/crashtestdata/files/doc/abi9921-1.doc
/srv/crashtestdata/files/doc/ooo59101-1.doc
-Hovedblankett.DOC
/srv/crashtestdata/files/doc/fdo48097-1.doc
-BR1010.doc

Change-Id: Iceaa53760867f06c73ab900c57f197dbc0fb8e65
Reviewed-on: https://gerrit.libreoffice.org/63938
Tested-by: Jenkins
Reviewed-by: Justin Luth 
(cherry picked from commit d3144a09dc5e2c21ffa34e3527bb6c94cd9926e8)
Reviewed-on: https://gerrit.libreoffice.org/64014

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
index ac7909edcc9b..547afcd1a399 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
@@ -733,18 +733,19 @@ DECLARE_OOXMLEXPORT_TEST(testTdf79435_legacyInputFields, 
"tdf79435_legacyInputFi
 uno::Reference 
xParameters(xFormField->getParameters());
 
 OUString sTmp;
-xParameters->getByName("EntryMacro") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
-xParameters->getByName("Help") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("F1Help"), sTmp);
-xParameters->getByName("ExitMacro") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
+// Doc import problems, so disabling tests
+//xParameters->getByName("EntryMacro") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
+//xParameters->getByName("Help") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("F1Help"), sTmp);
+//xParameters->getByName("ExitMacro") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
 xParameters->getByName("Hint") >>= sTmp;
 CPPUNIT_ASSERT_EQUAL(OUString("StatusHelp"), sTmp);
-xParameters->getByName("Content") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("Camelcase"), sTmp);
-xParameters->getByName("Format") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("TITLE CASE"), sTmp);
+//xParameters->getByName("Content") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("Camelcase"), sTmp);
+//xParameters->getByName("Format") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("TITLE CASE"), sTmp);
 
 sal_uInt16 nMaxLength = 0;
 xParameters->getByName("MaxLength") >>= nMaxLength;
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx 
b/sw/qa/extras/ww8export/ww8export3.cxx
index 14293e2ba5df..e85ec0efa18f 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -75,18 +75,20 @@ DECLARE_WW8EXPORT_TEST(testTdf79435_legacyInputFields, 
"tdf79435_legacyInputFiel
 uno::Reference 
xParameters(xFormField->getParameters());
 
 OUString sTmp;
-xParameters->getByName("EntryMacro") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
-xParameters->getByName("Help") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("F1Help"), sTmp);
-xParameters->getByName("ExitMacro") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
+// Too often the string reader can fail during import - fix that first to 
prevent round-tripping garbage.
+// (for example BR-1010B.doc from tdf#48097)
+//xParameters->getByName("EntryMacro") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
+//xParameters->getByName("Help") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("F1Help"), sTmp);
+//xParameters->getByName("ExitMacro") >>= sTmp;
+//CPPUNIT_ASSERT_EQUAL(OUString("test"), sTmp);
 xParameters->getByName("Description") >>= sTmp;
 CPPUNIT_ASSERT_EQUAL(OUString("StatusHelp"), sTmp);
-xParameters->getByName("Content") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("Camelcase"), sTmp);
-xParameters->getByName("Format") >>= sTmp;
-CPPUNIT_ASSERT_EQUAL(OUString("TITLE CASE"), sTmp);
+//xParameters->getByName("Content") >>= sTmp;
+/

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/qa writerfilter/source

 sw/qa/extras/ooxmlimport/data/tdf120551.docx  |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx |8 +++
 writerfilter/source/dmapper/GraphicImport.cxx |   27 --
 3 files changed, 33 insertions(+), 2 deletions(-)

New commits:
commit ef5875be7d0aefcb95f878fee49d79a65cd063ea
Author: Miklos Vajna 
AuthorDate: Mon Nov 19 21:41:07 2018 +0100
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 16:49:03 2018 +0100

tdf#120551 DOCX import: fix position of group shape with absolute position

Regression from commit af313fc149f80adb0f1680ca20e19745ccb7fede
(tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat
option, 2017-01-06), the group shape which covers most of the single
page in the document had a negative left position, while it should have
a small positive one (checking the drawingML markup).

This was a pre-existing problem, but now it's visible since we no longer
force objects to be on the page in Word compat mode.

Seeing the ODT import never positions group shapes (it's just a
container for child shapes), probably the DOCX import shouldn't do that
either. Start moving into this direction, first only for
absolute-positioned toplevel group shapes only, which already fixes the
bug.

(cherry picked from commit d220e476df38e86e094066a690985c624316d37f)

Change-Id: I152ba06a81a2bd09195a4c724da4b8878b0457bb
Reviewed-on: https://gerrit.libreoffice.org/63710
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf120551.docx 
b/sw/qa/extras/ooxmlimport/data/tdf120551.docx
new file mode 100644
index ..0fc0057c4e03
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf120551.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 6b54a7991fb3..b7e75e9c28fe 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -93,6 +93,14 @@ DECLARE_OOXMLIMPORT_TEST(testGroupShapeFontName, 
"groupshape-fontname.docx")
 getProperty(getRun(getParagraphOfText(1, xText), 1), 
"CharFontNameAsian"));
 }
 
+DECLARE_OOXMLIMPORT_TEST(test120551, "tdf120551.docx")
+{
+auto nHoriOrientPosition = getProperty(getShape(1), 
"HoriOrientPosition");
+// Without the accompanying fix in place, this test would have failed with
+// 'Expected: 436, Actual  : -2542'.
+CPPUNIT_ASSERT_EQUAL(static_cast(436), nHoriOrientPosition);
+}
+
 DECLARE_OOXMLIMPORT_TEST(testTdf111550, "tdf111550.docx")
 {
 // The test document has following ill-formed structure:
diff --git a/writerfilter/source/dmapper/GraphicImport.cxx 
b/writerfilter/source/dmapper/GraphicImport.cxx
index 45621b9c1686..c9597a25d6b3 100644
--- a/writerfilter/source/dmapper/GraphicImport.cxx
+++ b/writerfilter/source/dmapper/GraphicImport.cxx
@@ -65,11 +65,27 @@
 #include "WrapPolygonHandler.hxx"
 #include "util.hxx"
 
+using namespace css;
+
+namespace
+{
+bool isTopGroupObj(const uno::Reference& xShape)
+{
+SdrObject* pObject = GetSdrObjectFromXShape(xShape);
+if (!pObject)
+return false;
+
+if (pObject->GetUpGroup())
+return false;
+
+return pObject->IsGroupObject();
+}
+}
+
 namespace writerfilter {
 
 namespace dmapper
 {
-using namespace css;
 
 class XInputStreamHelper : public cppu::WeakImplHelper
 {
@@ -818,8 +834,15 @@ void GraphicImport::lcl_attribute(Id nName, Value& rValue)
 xShapeProps->setPropertyValue("RotateAngle", 
uno::makeAny(sal_Int32(0)));
 
 // Position of the groupshape should be set after 
children have been added.
+// Long-term we should get rid of positioning group
+// shapes, though. Do it for top-level ones with
+// absolute page position as a start.
 // fdo#80555: also set position for graphic shapes 
here
-
m_xShape->setPosition(awt::Point(m_pImpl->nLeftPosition, 
m_pImpl->nTopPosition));
+if (!isTopGroupObj(m_xShape)
+|| m_pImpl->nHoriRelation != 
text::RelOrientation::PAGE_FRAME
+|| m_pImpl->nVertRelation != 
text::RelOrientation::PAGE_FRAME)
+m_xShape->setPosition(
+awt::Point(m_pImpl->nLeftPosition, 
m_pImpl->nTopPosition));
 
 if (nRotation)
 xShapeProps->setPropertyValue("RotateAngle", 
uno::makeAny(nRotation));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: 3 commits - loleaflet/html loleaflet/src

 loleaflet/html/framed.html|2 +-
 loleaflet/src/map/handler/Map.WOPI.js |6 --
 2 files changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 1dd186528696bf33257dd9dcb1434ac9206efab7
Author: Samuel Mehrbrodt 
AuthorDate: Wed Nov 28 16:44:33 2018 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 28 16:46:24 2018 +0100

framed.html: Use better defaults for URL

so that only the hash code needs to be changed (in normal setups)

Change-Id: Idde78ecc030573612128f0ee8d50ad95333fa72b

diff --git a/loleaflet/html/framed.html b/loleaflet/html/framed.html
index c3384b256..8b4f324c6 100644
--- a/loleaflet/html/framed.html
+++ b/loleaflet/html/framed.html
@@ -204,6 +204,6 @@
 the hex string needs to be changed of course, to the right one as
 shown by 'make run'. -->
 
-http://snorken.local:9980/loleaflet/3304e9093/loleaflet.html?file_path=file:///home/tml/lo/online/test/data/empty.ods&NotWOPIButIframe=true";
 height="1000" width="1000">
+http://localhost:9980/loleaflet/b766728b5/loleaflet.html?file_path=file:///libreoffice/online/test/data/hello-world.ods&NotWOPIButIframe=true";
 height="1000" width="1000">
   
 
commit 46f318c3584b810cc1b366c3510c8871b4eca886
Author: Samuel Mehrbrodt 
AuthorDate: Wed Nov 28 16:41:20 2018 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 28 16:46:24 2018 +0100

resizeToolbar is undefined

But it inserting buttons seems to work fine even without that call,
so just remove it.

Change-Id: I831b171c57feed82e1ca778ba5a16a382f1786ee

diff --git a/loleaflet/src/map/handler/Map.WOPI.js 
b/loleaflet/src/map/handler/Map.WOPI.js
index e5728c9e9..18e86c7c6 100644
--- a/loleaflet/src/map/handler/Map.WOPI.js
+++ b/loleaflet/src/map/handler/Map.WOPI.js
@@ -3,7 +3,7 @@
  * L.WOPI contains WOPI related logic
  */
 
-/* global $ w2ui toolbarUpMobileItems resizeToolbar _ */
+/* global $ w2ui toolbarUpMobileItems _ */
 L.Map.WOPI = L.Handler.extend({
// If the CheckFileInfo call fails on server side, we won't have any 
PostMessageOrigin.
// So use '*' because we still needs to send 'close' message to the 
parent frame which
@@ -175,7 +175,6 @@ L.Map.WOPI = L.Handler.extend({
var idx = 
toolbarUpMobileItems.indexOf('save');

toolbarUpMobileItems.splice(idx, 0, msg.Values.id);
}
-   resizeToolbar();
}
else if (this._map._permission === 
'readonly') {
// Just add a menu entry for it
commit a9008c844dcd13220a89e259af484f1ea1573583
Author: Samuel Mehrbrodt 
AuthorDate: Wed Nov 28 16:38:25 2018 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 28 16:46:24 2018 +0100

Display image url for buttons inserted with postMessage 'Insert_Button'

There was no 

[Libreoffice-commits] online.git: .clang-format

 .clang-format |   47 +++
 1 file changed, 47 insertions(+)

New commits:
commit c583195d6287d0214c56945b6bdb3253f3e0d884
Author: Samuel Mehrbrodt 
AuthorDate: Wed Nov 28 09:39:29 2018 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 28 16:46:11 2018 +0100

Add clang-format config from core repo

Not enforced at the moment

Change-Id: I5e2b0def768e7b887425b6b0adc2c790565e42ea
Reviewed-on: https://gerrit.libreoffice.org/64148
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/.clang-format b/.clang-format
new file mode 100644
index 0..9d0d3de3f
--- /dev/null
+++ b/.clang-format
@@ -0,0 +1,47 @@
+AccessModifierOffset: -4
+ConstructorInitializerIndentWidth: 4
+AlignEscapedNewlinesLeft: false
+AlignTrailingComments: false
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakTemplateDeclarations: false
+AlwaysBreakBeforeMultilineStrings: false
+BreakBeforeBinaryOperators: true
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializersBeforeComma: true
+BinPackParameters: true
+ColumnLimit: 100
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+DerivePointerBinding: false
+ExperimentalAutoDetectBinPacking: false
+IndentCaseLabels: true
+KeepEmptyLinesAtTheStartOfBlocks: false
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: None
+ObjCSpaceBeforeProtocolList: true
+PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakComment: 60
+PenaltyBreakString: 1000
+PenaltyBreakFirstLessLess: 120
+PenaltyExcessCharacter: 100
+PenaltyReturnTypeOnItsOwnLine: 60
+PointerBindsToType: true
+ReflowComments: false
+SpacesBeforeTrailingComments: 1
+Cpp11BracedListStyle: false
+Standard:Cpp11
+IndentWidth: 4
+TabWidth:8
+UseTab:  Never
+BreakBeforeBraces: Allman
+IndentFunctionDeclarationAfterType: false
+SpacesInParentheses: false
+SpacesInAngles:  false
+SpaceInEmptyParentheses: false
+SpacesInCStyleCastParentheses: false
+SpaceAfterControlStatementKeyword: true
+SpaceBeforeAssignmentOperators: true
+ContinuationIndentWidth: 4
+SortIncludes: false
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loolwsd.xml.in wsd/LOOLWSD.cpp

 loolwsd.xml.in  |1 +
 wsd/LOOLWSD.cpp |8 
 2 files changed, 9 insertions(+)

New commits:
commit ff31b2cd8115ff998a52b63fcc5bda22daba3e3d
Author: Michael Meeks 
AuthorDate: Thu Nov 8 21:02:57 2018 +
Commit: Andras Timar 
CommitDate: Wed Nov 28 16:44:27 2018 +0100

Nasty hack to disable red-lining via config setting and the environment.

Change-Id: I67303fa9593c53a4575b4b45e2b2c879ae8ee890
Reviewed-on: https://gerrit.libreoffice.org/63137
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
(cherry picked from commit 2ff64d81ed3188994b755c0533526cc776f5c8c4)

diff --git a/loolwsd.xml.in b/loolwsd.xml.in
index 48c053adb..7ba63f0a0 100644
--- a/loolwsd.xml.in
+++ b/loolwsd.xml.in
@@ -18,6 +18,7 @@
 
 4
 false
+   true
 3600
 
 30
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 438004b7f..c91791d15 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -789,6 +789,7 @@ void LOOLWSD::initialize(Application& self)
 { "per_document.limit_stack_mem_kb", "8000" },
 { "per_document.limit_virt_mem_mb", "0" },
 { "per_document.max_concurrency", "4" },
+{ "per_document.redlining_as_comments", "true" },
 { "per_view.idle_timeout_secs", "900" },
 { "per_view.out_of_focus_timeout_secs", "60" },
 { "security.capabilities", "true" },
@@ -1022,6 +1023,13 @@ void LOOLWSD::initialize(Application& self)
 LOG_INF("MAX_CONCURRENCY set to " << maxConcurrency << ".");
 #endif
 
+const auto redlining = getConfigValue(conf, 
"per_document.redlining_as_comments", true);
+if (!redlining)
+{
+setenv("DISABLE_REDLINE", "1", 1);
+LOG_INF("DISABLE_REDLINE set");
+}
+
 // Otherwise we profile the soft-device at jail creation time.
 setenv("SAL_DISABLE_OPENCL", "true", 1);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

 loleaflet/src/layer/AnnotationManager.js |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit c3f2cf88bb25f2743c147a6b844b9a4addd7e9eb
Author: Michael Meeks 
AuthorDate: Wed Nov 7 14:14:46 2018 +
Commit: Andras Timar 
CommitDate: Wed Nov 28 16:36:16 2018 +0100

Avoid synchronous re-layout of comments / red-lines on each modification.

Change-Id: I698c6d47a58cfab2096900e01d19c8f4d4693fc4
(cherry picked from commit c48054f18a1c34d5460a2b9ec74fe57c122ef0a6)

diff --git a/loleaflet/src/layer/AnnotationManager.js 
b/loleaflet/src/layer/AnnotationManager.js
index 206f7ae71..a410598de 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -472,6 +472,19 @@ L.AnnotationManager = L.Class.extend({
 
},
 
+   layout: function (zoom) {
+   if (zoom)
+   this.doLayout(zoom);
+   else if (!this._layoutTimer) {
+   var me = this;
+   me._layoutTimer = setTimeout(function() {
+   delete me._layoutTimer;
+   me.doLayout(zoom);
+   }, 250 /* ms */);
+   } // else - avoid excessive re-layout
+
+   },
+
add: function (comment) {
var annotation = 
L.annotation(this._map._docLayer._twipsToLatLng(comment.anchorPos.getTopRight()),
 comment,
comment.id === 'new' ? {noMenu: true} : 
{}).addTo(this._map);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Compiler baselines


On 28/11/2018 16:16, Miklos Vajna wrote:

On Wed, Nov 28, 2018 at 09:57:09AM +0100, Stephan Bergmann 
 wrote:

Neither is it clear to me, nor whether anything is actually broken (see
explanation above).


https://en.wikipedia.org/wiki/Xcode#9.x_series actually points out that
running Xcode 9.3 requires 10.13; so I guess that means that code should
and can't be fixed, but then README.md needs updating (or simply drop
the macOS version from the build line?).


good point,  "Xcode 9.3 
reportedly requires at least macOS 10.13.2"

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 344 commits - basegfx/Library_basegfx.mk basegfx/source basegfx/test basic/qa basic/source canvas/source chart2/inc char

Rebased ref, commits from common ancestor:
commit 4283337b509b471acb018c9daeb97b41dde67c8d
Author: Thorsten Behrens 
AuthorDate: Wed Nov 28 00:38:40 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Nov 28 16:24:02 2018 +0100

Disable the GL based 3D charts

KDE5 currently does not support GL windows properly, so lets disable
that - this is the gist of 026e2623f7f498432e6dc970fb06145dfc77dc45
but with minimal footprint for easier branch maintenance.

Change-Id: I88113596e460c6300a826f821d918a761632047e

diff --git a/chart2/inc/ChartModel.hxx b/chart2/inc/ChartModel.hxx
index 83dca2872772..44e873b02912 100644
--- a/chart2/inc/ChartModel.hxx
+++ b/chart2/inc/ChartModel.hxx
@@ -476,16 +476,9 @@ public:
 
 void removeDataProviders();
 
-#if HAVE_FEATURE_OPENGL
-OpenGLWindow* getOpenGLWindow() { return mpOpenGLWindow;}
-#endif
-
 private:
 sal_Int32 mnStart;
 sal_Int32 mnEnd;
-#if HAVE_FEATURE_OPENGL
-VclPtr mpOpenGLWindow;
-#endif
 };
 
 }  // namespace chart
diff --git a/chart2/source/controller/main/ChartWindow.cxx 
b/chart2/source/controller/main/ChartWindow.cxx
index a0f7c31de47d..a5080383d9c9 100644
--- a/chart2/source/controller/main/ChartWindow.cxx
+++ b/chart2/source/controller/main/ChartWindow.cxx
@@ -58,11 +58,7 @@ ChartWindow::ChartWindow( ChartController* pController, 
vcl::Window* pParent, Wi
 , m_pWindowController( pController )
 , m_bInPaint(false)
 , m_pViewShellWindow( nullptr )
-#if HAVE_FEATURE_OPENGL
-, m_pOpenGLWindow(VclPtr::Create(this, false))
-#else
 , m_pOpenGLWindow(nullptr)
-#endif
 {
 set_id("chart_window");
 SetHelpId( HID_SCH_WIN_DOCUMENT );
diff --git a/chart2/source/model/main/ChartModel.cxx 
b/chart2/source/model/main/ChartModel.cxx
index d0ceb73b88e7..c917f4d64a65 100644
--- a/chart2/source/model/main/ChartModel.cxx
+++ b/chart2/source/model/main/ChartModel.cxx
@@ -112,9 +112,6 @@ 
ChartModel::ChartModel(uno::Reference const & xContext)
 "com.sun.star.xml.NamespaceMap", 
"com.sun.star.comp.chart.XMLNameSpaceMap" ), uno::UNO_QUERY)
 , mnStart(0)
 , mnEnd(0)
-#if HAVE_FEATURE_OPENGL
-, mpOpenGLWindow(nullptr)
-#endif
 {
 osl_atomic_increment(&m_refCount);
 {
@@ -156,9 +153,6 @@ ChartModel::ChartModel( const ChartModel & rOther )
 , m_xInternalDataProvider( rOther.m_xInternalDataProvider )
 , mnStart(rOther.mnStart)
 , mnEnd(rOther.mnEnd)
-#if HAVE_FEATURE_OPENGL
-, mpOpenGLWindow(nullptr)
-#endif
 {
 osl_atomic_increment(&m_refCount);
 {
@@ -1309,12 +1303,7 @@ void ChartModel::setTimeBasedRange(sal_Int32 nStart, 
sal_Int32 nEnd)
 
 void ChartModel::setWindow( const sal_uInt64 nWindowPtr )
 {
-#if HAVE_FEATURE_OPENGL
-OpenGLWindow* pWindow = reinterpret_cast(nWindowPtr);
-mpOpenGLWindow = pWindow;
-#else
 (void)nWindowPtr;
-#endif
 }
 
 void ChartModel::update()
@@ -1325,9 +1314,6 @@ void ChartModel::update()
 }
 mxChartView->setViewDirty();
 mxChartView->update();
-#if HAVE_FEATURE_OPENGL
-mxChartView->updateOpenGLWindow();
-#endif
 }
 
 bool ChartModel::isDataFromSpreadsheet()
diff --git a/chart2/source/model/template/ChartTypeManager.cxx 
b/chart2/source/model/template/ChartTypeManager.cxx
index bb9656f76692..1b81327efd1b 100644
--- a/chart2/source/model/template/ChartTypeManager.cxx
+++ b/chart2/source/model/template/ChartTypeManager.cxx
@@ -32,9 +32,6 @@
 #include "NetChartTypeTemplate.hxx"
 #include "BubbleChartTypeTemplate.hxx"
 #include 
-#if HAVE_FEATURE_OPENGL
-#include "GL3DBarChartTypeTemplate.hxx"
-#endif
 #include 
 #include 
 #include 
@@ -529,16 +526,7 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartTypeManager::createInstance(
 case TEMPLATE_BUBBLE:
 xTemplate.set( new BubbleChartTypeTemplate( m_xContext, 
aServiceSpecifier ));
 break;
-#if HAVE_FEATURE_OPENGL
-case TEMPLATE_GL3DBAR:
-xTemplate.set(new GL3DBarChartTypeTemplate(m_xContext, 
aServiceSpecifier));
-break;
-case TEMPLATE_GL3DBAR_ROUNDED_RECTANGLE:
-xTemplate.set(new GL3DBarChartTypeTemplate(m_xContext, 
aServiceSpecifier));
-break;
-#else
 default: break;
-#endif
 //case TEMPLATE_SURFACE:
 //case TEMPLATE_ADDIN:
 //   break;
diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 22f268b19a4a..9b8e157afc28 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -50,9 +50,6 @@
 #include 
 #include 
 #include 
-#if HAVE_FEATURE_OPENGL
-#include 
-#endif
 #include 
 #include 
 #include 
@@ -70,9 +67,6 @@
 #include 
 #include 
 #include 
-#if HAVE_FEATURE_OPENGL
-#include 
-#endif
 #include 
 
 #include 
@@ -1066,35 +1060,19 @@ public:
 virtual void scroll(long nDelta) override;
 virtual void contextDestroyed() override;
 
-#if HAVE_FEATURE_O

Re: Proposed XHP extensions

Hi all concerned in writing Help pages!

I patched the LibreOffice Help submodule code with the following
extensions to XHP

Class Paragraph-like

 ... 

,  and 

Class Character-like

, , , , 

All these extensions above are documented in the XHP reference page in

https://wiki.documentfoundation.org/Documentation/Understanding,_Authoring_and_Editing_Openoffice.org_Help/3

Patch is

https://gerrit.libreoffice.org/#/c/63954/

IMPORTANT

In any case these extensions break the existing markup and contents.

Please do not change existing contents based on these extensions, it
will force a useless re-translation.

However, it is OK when updating contents,  and use the opportunity to
also apply the extended markup.

Kind regards

Olivier

Em 22/10/2018 07:55, Olivier Hallot escreveu:
> Hello everyone concerned on writing Help pages
>
> After significant amount of time spent writing and fixing Help pages
> (XHP), I came to conclusion that the Help XML (XHP) is a powerful markup
> but a bit too hard to master for newcomers and easy to have errors and
> mistakes slipped in files. Some of its complexity are not absolutely
> required so I wrote a wiki page suggesting the implementation of XHP
> extensions, aiming to make life simpler for adding and reading XHP
> contents textually (markup).
>
> Please note that in any case the current markup is affected, so it will
> preserve the legacy contents as well as the current translations.
>
> For example, the new markup for 'tip' paragraph should be
>
> 
>
> so it can replace
> 
>
> Yes, it is a trivial change but I hope it will make reading easier for all.
>
> Handling of the XHP extensions will be in the XSLT transformation and it
> will be patched accordingly, as well as the DTD, wiki documentation on
> XHP, and string extractors for Pootle.
>
> The wiki page is
>
> https://wiki.documentfoundation.org/Documentation/Proposed_Extensions_for_XHP
>
> And comments are welcome, do's dont's, thumbs up or thumbs down.
>
> regards

-- 
Olivier Hallot
LibreOffice Documentation Coordinator
Comunidade LibreOffice 
Rio de Janeiro - Brasil - Local Time: UTC-03:00
http://tdf.io/joinus 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Compiler baselines

Hi,

On Wed, Nov 28, 2018 at 09:57:09AM +0100, Stephan Bergmann 
 wrote:
> Neither is it clear to me, nor whether anything is actually broken (see
> explanation above).

https://en.wikipedia.org/wiki/Xcode#9.x_series actually points out that
running Xcode 9.3 requires 10.13; so I guess that means that code should
and can't be fixed, but then README.md needs updating (or simply drop
the macOS version from the build line?).

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: desktop/source

 desktop/source/deployment/gui/dp_gui_dialog2.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit d6938caa27d22cc9c1f363df695c3621cce8ac86
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 12:47:04 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 16:12:01 2018 +0100

make unopkg gui not ask to 'restart' on extension changes

Change-Id: I185527fcc4481ab2bd97ad81849ee38c6fa50919
Reviewed-on: https://gerrit.libreoffice.org/64167
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx 
b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index 62e2e301bfc4..28bfeee06b53 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -1080,7 +1080,9 @@ bool ExtMgrDialog::Close()
 if (!m_bClosed && m_pManager->isModified())
 {
 m_pManager->clearModified();
-Application::PostUserEvent(LINK(nullptr, ExtMgrDialog, Restart), 
m_xRestartParent);
+//only suggest restart if we're actually running, e.g. not from 
standalone unopkg gui
+if (dp_misc::office_is_running())
+Application::PostUserEvent(LINK(nullptr, ExtMgrDialog, Restart), 
m_xRestartParent);
 }
 m_bClosed = true;
 return bRet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

 vcl/unx/generic/printer/ppdparser.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 8f6af557890ae687592075099a02960155511bd5
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 12:23:38 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 16:10:38 2018 +0100

Resolves: tdf#112215 null deref on missing optional ppd value

Change-Id: Iba45437332df963e1aa213c587071ab293f36390
Reviewed-on: https://gerrit.libreoffice.org/64164
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/printer/ppdparser.cxx 
b/vcl/unx/generic/printer/ppdparser.cxx
index 105a350a27d6..7789459c200c 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -848,13 +848,22 @@ PPDParser::PPDParser( const OUString& rFile ) :
 }
 
 // fill in direct values
-if( (pKey = getKey( OUString( "ColorDevice" ) )) )
-m_bColorDevice = pKey->getValue( 0 
)->m_aValue.startsWithIgnoreAsciiCase( "true" );
+if ((pKey = getKey(OUString("ColorDevice"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_bColorDevice = 
pValue->m_aValue.startsWithIgnoreAsciiCase("true");
+}
 
-if( (pKey = getKey( OUString( "LanguageLevel" ) )) )
-m_nLanguageLevel = pKey->getValue( 0 )->m_aValue.toInt32();
-if( (pKey = getKey( OUString( "TTRasterizer" ) )) )
-m_bType42Capable = pKey->getValue( 0 
)->m_aValue.equalsIgnoreAsciiCase( "Type42" );
+if ((pKey = getKey(OUString("LanguageLevel"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_nLanguageLevel = pValue->m_aValue.toInt32();
+}
+if ((pKey = getKey(OUString("TTRasterizer"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_bType42Capable = pValue->m_aValue.equalsIgnoreAsciiCase( 
"Type42" );
+}
 }
 
 PPDParser::~PPDParser()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - bridges/source

 bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h |   57 ---
 1 file changed, 1 insertion(+), 56 deletions(-)

New commits:
commit 7eeb1f63778c4c1b7c80df2defccd4a9cb91f615
Author: Tor Lillqvist 
AuthorDate: Wed Nov 28 16:44:49 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 28 17:04:20 2018 +0200

Bin some unused declarations

They used std::unexpected_handler so did not compile as C++17 anyway.

Change-Id: I5f8bacb85cbd213dd6304d865a7b4cb7eb8f4b8f

diff --git a/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h 
b/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
index 55c922f72caf..9a700445c12a 100644
--- a/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
+++ b/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
@@ -109,52 +109,6 @@ struct __cxa_exception
   _Unwind_Exception unwindHeader;
 };
 
-struct __cxa_dependent_exception
-{
-#if __LP64__
-  void* primaryException;
-#endif
-
-  // Unused dummy data (should be set to null)
-  std::type_info *exceptionType;
-  void (*exceptionDestructor)(void *); 
-
-  // The C++ standard has entertaining rules wrt calling set_terminate
-  // and set_unexpected in the middle of the exception cleanup process.
-  std::unexpected_handler unexpectedHandler;
-  std::terminate_handler terminateHandler;
-
-  // The caught exception stack threads through here.
-  __cxa_exception *nextException;
-
-  // How many nested handlers have caught this exception.  A negated
-  // value is a signal that this object has been rethrown.
-  int handlerCount;
-
-#ifdef __ARM_EABI_UNWINDER__
-  // Stack of exceptions in cleanups.
-  __cxa_exception* nextPropagatingException;
-
-  // The number of active cleanup handlers for this exception.
-  int propagationCount;
-#else
-  // Cache parsed handler data from the personality routine Phase 1
-  // for Phase 2 and __cxa_call_unexpected.
-  int handlerSwitchValue;
-  const unsigned char *actionRecord;
-  const unsigned char *languageSpecificData;
-  _Unwind_Ptr catchTemp;
-  void *adjustedPtr;
-#endif
-
-#if !__LP64__
-  void* primaryException;
-#endif
-
- // The generic exception header.  Must be last.
-  _Unwind_Exception unwindHeader;
-};
-
 // Each thread in a C++ program has access to a __cxa_eh_globals object.
 struct __cxa_eh_globals
 {
@@ -221,15 +175,6 @@ extern "C" void __cxa_begin_cleanup (_Unwind_Exception*);
 extern "C" void __cxa_end_cleanup (void);
 #endif
 
-#pragma GCC visibility push(hidden)
-
-// Invokes given handler, dying appropriately if the user handler was
-// so inconsiderate as to return.
-extern void __terminate(std::terminate_handler) __attribute__((noreturn));
-extern void __unexpected(std::unexpected_handler) __attribute__((noreturn));
-
-#pragma GCC visibility pop
-
 // These are explicitly GNU C++ specific.
 
 // Acquire the C++ exception header from the C++ object.
commit f7251d06d8a3eb0f2876566ab115e4b093e1e496
Author: Tor Lillqvist 
AuthorDate: Wed Nov 28 16:37:34 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 28 17:04:20 2018 +0200

Do like effe6b3d84302afce3d5095e4f376e7e3bf669e0 for iOS, too

Change-Id: I9163e1722f163a04968df292ee8b29d472f9ac4f

diff --git a/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h 
b/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
index ee7066931bfc..55c922f72caf 100644
--- a/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
+++ b/bridges/source/cpp_uno/gcc3_ios/unwind-cxx.h
@@ -73,7 +73,7 @@ struct __cxa_exception
 
   // The C++ standard has entertaining rules wrt calling set_terminate
   // and set_unexpected in the middle of the exception cleanup process.
-  std::unexpected_handler unexpectedHandler;
+  void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17
   std::terminate_handler terminateHandler;
 
   // The caught exception stack threads through here.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/uiconfig sw/uiconfig

 sc/uiconfig/scalc/ui/notebookbar_compact.ui   |   59 ++
 sw/uiconfig/swriter/ui/notebookbar_compact.ui |   47 
 2 files changed, 62 insertions(+), 44 deletions(-)

New commits:
commit 22f2d93f1626765b16e390a18a267f9c46dab59c
Author: andreas kainz 
AuthorDate: Wed Nov 28 13:22:18 2018 +0100
Commit: andreas_kainz 
CommitDate: Wed Nov 28 15:58:04 2018 +0100

NB tabbed compact: update toolbar

Change-Id: I5c2cd3339634cbb88f2c89226ff46d342eebc3a1
Reviewed-on: https://gerrit.libreoffice.org/64160
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sc/uiconfig/scalc/ui/notebookbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
index 97ed18278bf8..e9eab32b947b 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_compact.ui
@@ -1150,6 +1150,13 @@
   
 
 
+  
+True
+False
+.uno:VerticalText
+  
+
+
   
 True
 False
@@ -2607,8 +2614,8 @@
 
   
 True
-True
-~File
+False
+File
 True
   
   
@@ -3843,8 +3850,8 @@
 
   
 True
-True
-~Home
+False
+Home
 True
 
   
@@ -4500,8 +4507,8 @@
 
   
 True
-True
-~Insert
+False
+Insert
 True
   
   
@@ -5032,8 +5039,8 @@
 
   
 True
-True
-~Layout
+False
+Layout
 True
   
   
@@ -5720,8 +5727,8 @@
 
   
 True
-True
-~Data
+False
+Data
 True
   
   
@@ -6128,8 +6135,8 @@
 
   
 True
-True
-~Review
+False
+Review
 True
   
   
@@ -6657,8 +6664,8 @@
 
   
 True
-True
-~View
+False
+View
 True
   
   
@@ -7352,8 +7359,8 @@
 
   
 True
-True
-

[Libreoffice-commits] core.git: xmlsecurity/source

 xmlsecurity/source/gpg/CertificateImpl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4e0b3012d48cb35dda1807ce1cf48b6c340069d0
Author: Andrea Gelmini 
AuthorDate: Mon Nov 19 00:20:03 2018 +0100
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 15:36:43 2018 +0100

Fix typos

Change-Id: I66f31ff16a5cd5d8fca7e920fdd6b77bb124dfbb
Reviewed-on: https://gerrit.libreoffice.org/63321
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/xmlsecurity/source/gpg/CertificateImpl.cxx 
b/xmlsecurity/source/gpg/CertificateImpl.cxx
index 72fed74b949e..64c7b4886e50 100644
--- a/xmlsecurity/source/gpg/CertificateImpl.cxx
+++ b/xmlsecurity/source/gpg/CertificateImpl.cxx
@@ -61,7 +61,7 @@ OUString SAL_CALL CertificateImpl::getIssuerName()
 
 OUString SAL_CALL CertificateImpl::getSubjectName()
 {
-// Samue as issuer name (user ID)
+// Same as issuer name (user ID)
 return getIssuerName();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: include/svx sc/sdi sc/source sd/sdi sd/source svx/sdi svx/source sw/sdi sw/source

 include/svx/svxids.hrc   |2 +-
 sc/sdi/drawsh.sdi|2 +-
 sc/source/ui/drawfunc/drawsh5.cxx|2 +-
 sd/sdi/_drvwsh.sdi   |2 +-
 sd/source/ui/view/drviews2.cxx   |2 +-
 svx/sdi/svx.sdi  |2 +-
 svx/source/toolbars/extrusionbar.cxx |   10 +-
 sw/sdi/drawsh.sdi|2 +-
 sw/source/uibase/shells/drawsh.cxx   |2 +-
 9 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit e051bb72d6a12e4a10d4a3548eb6a131b80d96fb
Author: Andrea Gelmini 
AuthorDate: Mon Sep 17 12:04:41 2018 +0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 15:36:02 2018 +0100

Fix SID_EXTRUSION_TOOGLE -> SID_EXTRUSION_TOGGLE

It passed "make check" on Linux.

If accepted, I have to update these files:
helpcontent2/helpers/help_hid.lst   : 
SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle
helpcontent2/helpers/longnames_commands.csv : 
SID_EXTRUSION_TOOGLE,.uno:ExtrusionToggle
helpcontent2/helpers/uno_hid.lst: 
SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle

Change-Id: Ie315ef92b6aa8c03c6fc180f4e82d95f28975c2e
Reviewed-on: https://gerrit.libreoffice.org/60631
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index acd2df632a1a..03c606182239 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -740,7 +740,7 @@ class SfxStringItem;
 #define SID_VERTICALTEXT_STATE  ( SID_SVX_START + 957 )
 #define SID_OPEN_XML_FILTERSETTINGS ( SID_SVX_START + 958 )
 #define SID_HANGUL_HANJA_CONVERSION ( SID_SVX_START + 959 )
-#define SID_EXTRUSION_TOOGLE( SID_SVX_START + 960 )
+#define SID_EXTRUSION_TOGGLE( SID_SVX_START + 960 )
 #define SID_EXTRUSION_TILT_DOWN ( SID_SVX_START + 961 )
 #define SID_EXTRUSION_TILT_UP   ( SID_SVX_START + 962 )
 #define SID_EXTRUSION_TILT_LEFT ( SID_SVX_START + 963 )
diff --git a/sc/sdi/drawsh.sdi b/sc/sdi/drawsh.sdi
index 2cd59627b427..53916eca91a2 100644
--- a/sc/sdi/drawsh.sdi
+++ b/sc/sdi/drawsh.sdi
@@ -193,7 +193,7 @@ interface TableDraw
 SID_FORMATPAINTBRUSH[ ExecMethod = ExecFormatPaintbrush; StateMethod = 
StateFormatPaintbrush; ]
 
 SID_OPEN_XML_FILTERSETTINGS [ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
-SID_EXTRUSION_TOOGLE[ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
+SID_EXTRUSION_TOGGLE[ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
 SID_EXTRUSION_TILT_DOWN [ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
 SID_EXTRUSION_TILT_UP   [ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
 SID_EXTRUSION_TILT_LEFT [ ExecMethod = ExecDrawFunc ; StateMethod 
= GetDrawFuncState ; ]
diff --git a/sc/source/ui/drawfunc/drawsh5.cxx 
b/sc/source/ui/drawfunc/drawsh5.cxx
index 81b9c310e3d6..4c08816a940e 100644
--- a/sc/source/ui/drawfunc/drawsh5.cxx
+++ b/sc/source/ui/drawfunc/drawsh5.cxx
@@ -576,7 +576,7 @@ void ScDrawShell::ExecDrawFunc( SfxRequest& rReq )
 break;
 }
 
-case SID_EXTRUSION_TOOGLE:
+case SID_EXTRUSION_TOGGLE:
 case SID_EXTRUSION_TILT_DOWN:
 case SID_EXTRUSION_TILT_UP:
 case SID_EXTRUSION_TILT_LEFT:
diff --git a/sd/sdi/_drvwsh.sdi b/sd/sdi/_drvwsh.sdi
index 5e24ed525be8..e0638004ec9f 100644
--- a/sd/sdi/_drvwsh.sdi
+++ b/sd/sdi/_drvwsh.sdi
@@ -2376,7 +2376,7 @@ interface DrawView
 ExecMethod = Execute ;
 StateMethod = GetMenuState ;
 ]
-SID_EXTRUSION_TOOGLE
+SID_EXTRUSION_TOGGLE
 [
 ExecMethod = FuTemporary ;
 StateMethod = GetMenuState ;
diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx
index a4863b8aca00..5d9a38aefd0e 100644
--- a/sd/source/ui/view/drviews2.cxx
+++ b/sd/source/ui/view/drviews2.cxx
@@ -3071,7 +3071,7 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq)
 }
 break;
 
-case SID_EXTRUSION_TOOGLE:
+case SID_EXTRUSION_TOGGLE:
 case SID_EXTRUSION_TILT_DOWN:
 case SID_EXTRUSION_TILT_UP:
 case SID_EXTRUSION_TILT_LEFT:
diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index d38f9d78a69e..b697c4064f9d 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -9505,7 +9505,7 @@ SfxVoidItem FontNameList SID_ATTR_CHAR_FONTLIST
 ]
 
 
-SfxBoolItem ExtrusionToggle SID_EXTRUSION_TOOGLE
+SfxBoolItem ExtrusionToggle SID_EXTRUSION_TOGGLE
 
 [
 AutoUpdate = TRUE,
diff --git a/svx/source/toolbars/extrusionbar.cxx 
b/svx/source/toolbars/extrusionbar.cxx
index cf14a4a55448..94bb8e326721 100644
--- a/svx/source/toolbars/extrusionbar.cxx
+++ b/svx/source/toolbars/extrusionbar.cxx
@@ -119,7

[Libreoffice-commits] core.git: framework/inc framework/source svtools/source vcl/source

 framework/inc/classes/framecontainer.hxx |2 +-
 framework/source/services/frame.cxx  |2 +-
 svtools/source/contnr/iconview.cxx   |4 ++--
 vcl/source/treelist/treelistbox.cxx  |4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit f0bf6a4178dfb3a75d01c4b8b48531a079b75b5b
Author: Andrea Gelmini 
AuthorDate: Fri Nov 9 07:49:16 2018 +0100
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 15:33:45 2018 +0100

Fix typo deactive

Change-Id: I68a87a9435784f949f1e7b730270641bd8e05b43
Reviewed-on: https://gerrit.libreoffice.org/63149
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/framework/inc/classes/framecontainer.hxx 
b/framework/inc/classes/framecontainer.hxx
index 5da67fcf49ba..5a82d3f9a315 100644
--- a/framework/inc/classes/framecontainer.hxx
+++ b/framework/inc/classes/framecontainer.hxx
@@ -45,7 +45,7 @@ typedef ::std::vector< css::uno::Reference< 
css::frame::XFrame > >  TFrameContai
 @descr  Every object of frame, task or desktop hold reference to 
his children. These container is used as helper
 to do this. Some helper-classes like OFrames or 
OTasksAccess use it to. They hold a pointer to an instance
 of this class, which is a member of a frame, task or 
desktop! You can append and remove frames.
-It's possible to set one of these frames as active or 
deactive. You could have full index-access to
+It's possible to set one of these frames as active or 
deactivate. You could have full index-access to
 container-items.
 
 @devstatus  ready to use
diff --git a/framework/source/services/frame.cxx 
b/framework/source/services/frame.cxx
index 66fe3032356a..8f3c36fefbcb 100644
--- a/framework/source/services/frame.cxx
+++ b/framework/source/services/frame.cxx
@@ -2111,7 +2111,7 @@ void SAL_CALL Frame::disposing()
 // If somewhere called dispose() whitout close() before - normally no 
dialogs
 // should exist. Otherwise it's the problem of the outside caller.
 // Note:
-//  (a) Do it after stopWindowListening(). May that force some 
active/deactive
+//  (a) Do it after stopWindowListening(). May that force some 
active/deactivate
 //  notifications which we don't need here really.
 //  (b) Don't forget to save the old value of IsDialogCancelEnabled() 
to
 //  restore it afterwards (to not kill headless mode).
diff --git a/svtools/source/contnr/iconview.cxx 
b/svtools/source/contnr/iconview.cxx
index 31f80325f40d..c323a693f045 100644
--- a/svtools/source/contnr/iconview.cxx
+++ b/svtools/source/contnr/iconview.cxx
@@ -141,8 +141,8 @@ void IconView::PaintEntry(SvTreeListEntry& rEntry, long nX, 
long nY,
 if (pViewDataEntry->IsHighlighted())
 {
 Color aNewWallColor = rSettings.GetHighlightColor();
-// if the face color is bright then the deactive color is also 
bright
-// -> so you can't see any deactive selection
+// if the face color is bright then the deactivate color is also 
bright
+// -> so you can't see any deactivate selection
 if (bHideSelection && !rSettings.GetFaceColor().IsBright()
&& aWallpaper.GetColor().IsBright() != 
rSettings.GetDeactiveColor().IsBright())
 {
diff --git a/vcl/source/treelist/treelistbox.cxx 
b/vcl/source/treelist/treelistbox.cxx
index 8962b8410664..fe09ca2494cb 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -2715,8 +2715,8 @@ void SvTreeListBox::PaintEntry1(SvTreeListEntry& rEntry, 
long nLine, vcl::Render
 if (pViewDataEntry->IsHighlighted() && bSelTab)
 {
 Color aNewWallColor = rSettings.GetHighlightColor();
-// if the face color is bright then the deactive color is also 
bright
-// -> so you can't see any deactive selection
+// if the face color is bright then the deactivate color is also 
bright
+// -> so you can't see any deactivate selection
 if (bHideSelection && !rSettings.GetFaceColor().IsBright()
&& aWallpaper.GetColor().IsBright() != 
rSettings.GetDeactiveColor().IsBright())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basctl/source cui/source dbaccess/source extensions/source formula/source fpicker/source framework/inc framework/source include/sfx2 include/svtools include/svx sc/sour

 basctl/source/basicide/brkdlg.cxx   |1 
 cui/source/dialogs/linkdlg.cxx  |1 
 cui/source/dialogs/thesdlg_impl.hxx |1 
 cui/source/inc/acccfg.hxx   |1 
 cui/source/inc/align.hxx|7 --
 cui/source/inc/cfg.hxx  |1 
 cui/source/inc/cuicharmap.hxx   |5 
 cui/source/inc/linkdlg.hxx  |1 
 cui/source/inc/macroass.hxx |4 ---
 cui/source/inc/macropg.hxx  |1 
 cui/source/inc/multipat.hxx |1 
 cui/source/inc/textanim.hxx |2 -
 cui/source/options/optjava.hxx  |1 
 cui/source/options/optopencl.hxx|1 
 dbaccess/source/ui/app/AppController.cxx|1 
 dbaccess/source/ui/app/AppControllerDnD.cxx |1 
 dbaccess/source/ui/app/AppSwapWindow.hxx|1 
 dbaccess/source/ui/dlg/TextConnectionHelper.hxx |1 
 dbaccess/source/ui/dlg/adminpages.cxx   |1 
 dbaccess/source/ui/dlg/advancedsettings.hxx |1 
 dbaccess/source/ui/dlg/detailpages.hxx  |1 
 dbaccess/source/ui/inc/adtabdlg.hxx |1 
 dbaccess/source/ui/inc/indexdialog.hxx  |1 
 dbaccess/source/ui/misc/WCopyTable.cxx  |1 
 extensions/source/bibliography/bibbeam.cxx  |1 
 extensions/source/bibliography/general.hxx  |1 
 extensions/source/propctrlr/browserlistbox.cxx  |3 +-
 extensions/source/propctrlr/browserlistbox.hxx  |1 
 extensions/source/propctrlr/taborder.hxx|1 
 formula/source/ui/dlg/formula.cxx   |1 
 formula/source/ui/dlg/parawin.hxx   |1 
 formula/source/ui/dlg/structpg.hxx  |1 
 fpicker/source/office/iodlgimp.cxx  |1 
 framework/inc/uielement/dropdownboxtoolbarcontroller.hxx|1 
 framework/source/uielement/dropdownboxtoolbarcontroller.cxx |1 
 include/sfx2/mgetempl.hxx   |5 
 include/svtools/foldertree.hxx  |1 
 include/svx/galctrl.hxx |1 
 sc/source/ui/pagedlg/hfedtdlg.cxx   |1 
 sd/source/filter/html/pubdlg.cxx|1 
 sd/source/ui/animations/CustomAnimationDialog.cxx   |1 
 sd/source/ui/animations/CustomAnimationPane.cxx |1 
 sd/source/ui/dlg/RemoteDialog.hxx   |4 ---
 sd/source/ui/dlg/headerfooterdlg.cxx|1 
 svtools/source/dialogs/ServerDetailsControls.cxx|1 
 svx/inc/galbrws2.hxx|1 
 svx/source/dialog/compressgraphicdialog.cxx |4 ---
 svx/source/dialog/imapdlg.cxx   |2 -
 svx/source/gallery2/gallery1.cxx|1 
 svx/source/gallery2/galtheme.cxx|1 
 svx/source/sidebar/line/LinePropertyPanel.cxx   |1 
 svx/source/sidebar/shadow/ShadowPropertyPanel.hxx   |1 
 svx/source/sidebar/text/TextCharacterSpacingControl.cxx |1 
 sw/source/ui/chrdlg/swuiccoll.cxx   |1 
 sw/source/ui/dbui/createaddresslistdialog.hxx   |1 
 sw/source/ui/dbui/customizeaddresslistdialog.hxx|6 +
 sw/source/ui/dbui/mmaddressblockpage.cxx|3 +-
 sw/source/ui/dbui/mmaddressblockpage.hxx|1 
 sw/source/ui/dbui/mmdocselectpage.hxx   |4 +--
 sw/source/ui/dbui/mmgreetingspage.hxx   |4 ---
 sw/source/ui/inc/mmresultdialogs.hxx|2 -
 sw/source/ui/misc/srtdlg.cxx|1 
 sw/source/uibase/dochdl/gloshdl.cxx |1 
 sw/source/uibase/inc/ascfldlg.hxx   |1 
 sw/source/uibase/inc/cnttab.hxx |1 
 sw/source/uibase/inc/glossary.hxx   |2 -
 sw/source/uibase/inc/mailconfigpage.hxx |1 
 sw/source/uibase/inc/numberingtypelistbox.hxx   |1 
 sw/source/uibase/inc/regionsw.hxx   |1 
 sw/source/uibase/inc/swuiidxmrk.hxx |   13 +---
 sw/source/uibase/sidebar/PageSizeControl.hxx|1 
 sw/source/uibase/sidebar/StylePresetsPanel.hx

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - desktop/source

 desktop/source/deployment/gui/dp_gui_dialog2.cxx |   84 ++-
 desktop/source/deployment/gui/dp_gui_dialog2.hxx |   23 +++---
 2 files changed, 78 insertions(+), 29 deletions(-)

New commits:
commit f2a39e1d9184b7cda32b713b699d19ac3d023849
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 11:12:55 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 15:09:55 2018 +0100

Resolves: tdf#121746 block toplevels from closing...

while the extension manager is querying via a dialog. Reuse
the isBusy for this.

Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280
Reviewed-on: https://gerrit.libreoffice.org/64161
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx 
b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index b36f18d8f5dc..62e2e301bfc4 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -336,16 +336,15 @@ void ExtBoxWithBtns_Impl::enableButtons( bool bEnable )
 
 // DialogHelper
 
-DialogHelper::DialogHelper( const uno::Reference< uno::XComponentContext > 
&xContext,
-Dialog *pWindow ) :
-m_pVCLWindow( pWindow ),
-m_nEventID(   nullptr ),
-m_bIsBusy(false )
+DialogHelper::DialogHelper(const uno::Reference< uno::XComponentContext > 
&xContext,
+   Dialog *pWindow)
+: m_xVCLWindow(pWindow)
+, m_nEventID(nullptr)
+, m_nBusy(0)
 {
 m_xContext = xContext;
 }
 
-
 DialogHelper::~DialogHelper()
 {
 if ( m_nEventID )
@@ -366,17 +365,21 @@ bool DialogHelper::continueOnSharedExtension( const 
uno::Reference< deployment::
 if ( !bHadWarning && IsSharedPkgMgr( xPackage ) )
 {
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xBox(Application::CreateMessageDialog(pParent,
   VclMessageType::Warning, 
VclButtonsType::OkCancel, DpResId(pResID)));
 bHadWarning = true;
 
-return RET_OK == xBox->run();
+bool bRet = RET_OK == xBox->run();
+xBox.reset();
+decBusy();
+return bRet;
 }
 else
 return true;
 }
 
-void DialogHelper::openWebBrowser( const OUString & sURL, const OUString 
&sTitle ) const
+void DialogHelper::openWebBrowser(const OUString& sURL, const OUString& sTitle)
 {
 if ( sURL.isEmpty() ) // Nothing to do, when the URL is empty
 return;
@@ -393,29 +396,35 @@ void DialogHelper::openWebBrowser( const OUString & sURL, 
const OUString &sTitle
 uno::Any exc( ::cppu::getCaughtException() );
 OUString msg( ::comphelper::anyToString( exc ) );
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xErrorBox(Application::CreateMessageDialog(getFrameWeld(),

VclMessageType::Warning, VclButtonsType::Ok, msg));
 xErrorBox->set_title(sTitle);
 xErrorBox->run();
+xErrorBox.reset();
+decBusy();
 }
 }
 
-
-bool DialogHelper::installExtensionWarn( const OUString &rExtensionName ) const
+bool DialogHelper::installExtensionWarn(const OUString &rExtensionName)
 {
 const SolarMutexGuard guard;
 
 // Check if extension installation is disabled in the expert configurations
 if 
(officecfg::Office::ExtensionManager::ExtensionSecurity::DisableExtensionInstallation::get())
 {
+incBusy();
 std::unique_ptr 
xWarnBox(Application::CreateMessageDialog(getFrameWeld(),
   VclMessageType::Warning, 
VclButtonsType::Ok,
   
DpResId(RID_STR_WARNING_INSTALL_EXTENSION_DISABLED)));
 xWarnBox->run();
+xWarnBox.reset();
+decBusy();
 
 return false;
 }
 
+incBusy();
 std::unique_ptr 
xInfoBox(Application::CreateMessageDialog(getFrameWeld(),
   VclMessageType::Warning, 
VclButtonsType::OkCancel,
   
DpResId(RID_STR_WARNING_INSTALL_EXTENSION)));
@@ -423,15 +432,21 @@ bool DialogHelper::installExtensionWarn( const OUString 
&rExtensionName ) const
 sText = sText.replaceAll("%NAME", rExtensionName);
 xInfoBox->set_primary_text(sText);
 
-return (RET_OK == xInfoBox->run());
+bool bRet = RET_OK == xInfoBox->run();
+xInfoBox.reset();
+decBusy();
+return bRet;
 }
 
-bool DialogHelper::installForAllUsers( bool &bInstallForAll ) const
+bool DialogHelper::installForAllUsers(bool &bInstallForAll)
 {
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xBuilder(Application::CreateBuilder(getFrameWeld(), 
"desktop/ui/installforalldialog.ui"));
 std::unique_ptr 
xQuery(xBuilder->weld_message_dialog("InstallForAllD

[Libreoffice-commits] core.git: vcl/unx

 vcl/unx/generic/printer/ppdparser.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 3288d88e0c0842a44aa959e41cc665b9cf3804b9
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 12:23:38 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 15:09:42 2018 +0100

Resolves: tdf#112215 null deref on missing optional ppd value

Change-Id: Iba45437332df963e1aa213c587071ab293f36390
Reviewed-on: https://gerrit.libreoffice.org/64163
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/printer/ppdparser.cxx 
b/vcl/unx/generic/printer/ppdparser.cxx
index 105a350a27d6..7789459c200c 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -848,13 +848,22 @@ PPDParser::PPDParser( const OUString& rFile ) :
 }
 
 // fill in direct values
-if( (pKey = getKey( OUString( "ColorDevice" ) )) )
-m_bColorDevice = pKey->getValue( 0 
)->m_aValue.startsWithIgnoreAsciiCase( "true" );
+if ((pKey = getKey(OUString("ColorDevice"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_bColorDevice = 
pValue->m_aValue.startsWithIgnoreAsciiCase("true");
+}
 
-if( (pKey = getKey( OUString( "LanguageLevel" ) )) )
-m_nLanguageLevel = pKey->getValue( 0 )->m_aValue.toInt32();
-if( (pKey = getKey( OUString( "TTRasterizer" ) )) )
-m_bType42Capable = pKey->getValue( 0 
)->m_aValue.equalsIgnoreAsciiCase( "Type42" );
+if ((pKey = getKey(OUString("LanguageLevel"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_nLanguageLevel = pValue->m_aValue.toInt32();
+}
+if ((pKey = getKey(OUString("TTRasterizer"
+{
+if (const PPDValue* pValue = pKey->getValue(0))
+m_bType42Capable = pValue->m_aValue.equalsIgnoreAsciiCase( 
"Type42" );
+}
 }
 
 PPDParser::~PPDParser()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

 vcl/unx/gtk3/gtk3gtkinst.cxx |   50 ++-
 1 file changed, 49 insertions(+), 1 deletion(-)

New commits:
commit f6e0212285f48beab3c47a00e5b2f9549654a066
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 11:50:19 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 14:35:37 2018 +0100

Resolves: tdf#121752 let scroll wheel change active notebook tab

Change-Id: If8437346a58ea14266f11293b94082740303e5a9
Reviewed-on: https://gerrit.libreoffice.org/64158
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 6eb623efe088..286206f7c4a5 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -3012,6 +3012,7 @@ private:
 GtkNotebook* m_pNotebook;
 gulong m_nSwitchPageSignalId;
 gulong m_nSizeAllocateSignalId;
+gulong m_nScrollSignalId;
 mutable std::vector> m_aPages;
 
 static void signalSwitchPage(GtkNotebook*, GtkWidget*, guint nNewPage, 
gpointer widget)
@@ -3033,6 +3034,50 @@ private:
 m_aEnterPageHdl.Call(sNewIdent);
 }
 
+static gboolean signalScroll(GtkWidget*, GdkEventScroll* event, gpointer 
widget)
+{
+GtkInstanceNotebook* pThis = static_cast(widget);
+return pThis->signal_scroll(event);
+}
+
+bool signal_scroll(GdkEventScroll* event)
+{
+bool bNext(false), bPrev(false);
+switch (event->direction)
+{
+case GDK_SCROLL_RIGHT:
+case GDK_SCROLL_DOWN:
+bNext = true;
+break;
+case GDK_SCROLL_LEFT:
+case GDK_SCROLL_UP:
+bPrev = true;
+break;
+case GDK_SCROLL_SMOOTH:
+{
+switch (gtk_notebook_get_tab_pos(m_pNotebook))
+{
+case GTK_POS_LEFT:
+case GTK_POS_RIGHT:
+bNext = event->delta_y > 0;
+bPrev = event->delta_y < 0;
+break;
+case GTK_POS_TOP:
+case GTK_POS_BOTTOM:
+bNext = event->delta_x > 0;
+bPrev = event->delta_x < 0;
+break;
+}
+break;
+}
+}
+if (bNext)
+gtk_notebook_next_page(m_pNotebook);
+else if (bPrev)
+gtk_notebook_prev_page(m_pNotebook);
+return true;
+}
+
 OString get_page_ident(guint nPage) const
 {
 const GtkWidget* pTabWidget = gtk_notebook_get_tab_label(m_pNotebook, 
gtk_notebook_get_nth_page(m_pNotebook, nPage));
@@ -3097,6 +3142,8 @@ public:
 , m_pNotebook(pNotebook)
 , m_nSwitchPageSignalId(g_signal_connect(pNotebook, "switch-page", 
G_CALLBACK(signalSwitchPage), this))
 {
+gtk_widget_add_events(GTK_WIDGET(pNotebook), GDK_SCROLL_MASK);
+m_nScrollSignalId = g_signal_connect(pNotebook, "scroll-event", 
G_CALLBACK(signalScroll), this);
 if (get_n_pages() > 6)
 m_nSizeAllocateSignalId = g_signal_connect(pNotebook, 
"size-allocate", G_CALLBACK(signalSizeAllocate), this);
 else
@@ -3188,9 +3235,10 @@ public:
 
 virtual ~GtkInstanceNotebook() override
 {
-g_signal_handler_disconnect(m_pNotebook, m_nSwitchPageSignalId);
 if (m_nSizeAllocateSignalId)
 g_signal_handler_disconnect(m_pNotebook, m_nSizeAllocateSignalId);
+g_signal_handler_disconnect(m_pNotebook, m_nScrollSignalId);
+g_signal_handler_disconnect(m_pNotebook, m_nSwitchPageSignalId);
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Makefile.in

 Makefile.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 46d434cd12f49fdaab93e8d60b7519f33a711666
Author: Stephan Bergmann 
AuthorDate: Wed Nov 28 13:07:03 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 14:31:29 2018 +0100

Let distclean remove all of generated config_build/ tree

Change-Id: I8d12454003c0bd23170007e30f96016b47820f5f
Reviewed-on: https://gerrit.libreoffice.org/64157
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/Makefile.in b/Makefile.in
index 393e94fda331..7cf5a9254233 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -214,7 +214,7 @@ distclean : clean compilerplugins-clean
 $(BUILDDIR)/config.status \
 $(BUILDDIR)/config_build.mk \
 $(BUILDDIR)/config_build_lang.mk \
-$(BUILDDIR)/config_build/*.h \
+$(BUILDDIR)/config_build \
 $(BUILDDIR)/config_host.mk \
 $(BUILDDIR)/config_host.mk.stamp \
 $(BUILDDIR)/config_host_lang.mk \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Compiler baselines


On 23/11/2018 08:57, Stephan Bergmann wrote:

On 21/11/2018 17:42, Stephan Bergmann wrote:
If nobody objects, we'd update the build baselines on master (towards 
LO 6.3) as follows (cf README.md):

* Windows: from Visual Studio 2017 to Visual Studio 2017 version 15.7


The relevant Windows Jenkins nodes (tb68-bytemark, tb72, tb73, tb77, and 
tb78, I assume) need to be upgraded to >= Visual Studio 2017 version 
15.7.  Who can do that?  Cloph?


Enforced now with 
 
"On Windows, check for at least Visual Studio 2017 version 15.7".

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - uui/source

 uui/source/iahndl-ssl.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit ea471b508cb90fbaa770f291a40864324d8d74ef
Author: Andras Timar 
AuthorDate: Sun Nov 25 17:41:20 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 28 13:55:18 2018 +0100

Do not validate SSL cert in LOK case

Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test 
environments.

Change-Id: I672ba9016b1555c6d9d8faba8d0a4b2a17adf453
Reviewed-on: https://gerrit.libreoffice.org/63993
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index 20688f7a3c9f..d27e273952b9 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -256,6 +257,12 @@ handleCertificateValidationRequest_(
 uno::Reference< task::XInteractionAbort > xAbort;
 getContinuations(rContinuations, &xApprove, &xAbort);
 
+if ( comphelper::LibreOfficeKit::isActive() && xApprove.is() )
+{
+xApprove->select();
+return;
+}
+
 sal_Int32 failures = rRequest.CertificateValidity;
 bool trustCert = true;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - uui/source

 uui/source/iahndl-ssl.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit a08552a8c36754930a3268e27aefee70d5cf21df
Author: Andras Timar 
AuthorDate: Sun Nov 25 18:15:24 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 28 13:54:56 2018 +0100

Do not validate SSL cert in LOK case

Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test 
environments.

Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878
Reviewed-on: https://gerrit.libreoffice.org/63994
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index 9f3aa12a725c..db0c3dc84322 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -250,6 +251,12 @@ handleCertificateValidationRequest_(
 uno::Reference< task::XInteractionAbort > xAbort;
 getContinuations(rContinuations, &xApprove, &xAbort);
 
+if ( comphelper::LibreOfficeKit::isActive() && xApprove.is() )
+{
+xApprove->select();
+return;
+}
+
 sal_Int32 failures = rRequest.CertificateValidity;
 bool trustCert = true;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: uui/source

 uui/source/iahndl-ssl.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 9c04c42425ae722e695fa4e340cabf0ca2846651
Author: Andras Timar 
AuthorDate: Sun Nov 25 18:15:24 2018 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 28 13:54:36 2018 +0100

Do not validate SSL cert in LOK case

Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test 
environments.

Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878
Reviewed-on: https://gerrit.libreoffice.org/64154
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index 096f81b21d4c..6db6695671d9 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -236,6 +237,12 @@ handleCertificateValidationRequest_(
 uno::Reference< task::XInteractionAbort > xAbort;
 getContinuations(rContinuations, &xApprove, &xAbort);
 
+if ( comphelper::LibreOfficeKit::isActive() && xApprove.is() )
+{
+xApprove->select();
+return;
+}
+
 sal_Int32 failures = rRequest.CertificateValidity;
 bool trustCert = true;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: configure.ac

 configure.ac |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 206b8c4ae320d7d8614f21800d8f77fa29f8f5ff
Author: Stephan Bergmann 
AuthorDate: Thu Aug 16 17:38:52 2018 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 13:51:04 2018 +0100

On Windows, check for at least Visual Studio 2017 version 15.7

...to further restrict the Windows MSVC baseline to not just VS 2017, but 
to the
latest update (as the various updates bring significant improvements for 
C++11/
14/17 support; see the mailing list thread starting at

"Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)").

Change-Id: If6a1b62da1691ae8ae19edb4ed7b35e4b6e46501
Reviewed-on: https://gerrit.libreoffice.org/59209
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index 4134f6460e16..426bbdf3cba0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3561,6 +3561,15 @@ if test "$_os" = "WINNT"; then
 AC_MSG_ERROR([Visual C++ not found after all, huh])
 fi
 
+AC_MSG_CHECKING([$CC is at least Visual Studio 2017 version 15.7])
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
+// See 
 for 
mapping
+// between Visual Studio versions and _MSC_VER:
+#if _MSC_VER < 1914
+#error
+#endif
+]])],[AC_MSG_RESULT([yes])],[AC_MSG_ERROR([no])])
+
 # Check for 64-bit (cross-)compiler to use to build the 64-bit
 # version of the Explorer extension (and maybe other small
 # bits, too) needed when installing a 32-bit LibreOffice on a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/src

 loleaflet/src/map/handler/Map.Keyboard.js |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 80e91e5e3935b46bb8a9c084b04a863ff90436e4
Author: Tor Lillqvist 
AuthorDate: Wed Oct 24 18:37:17 2018 +0300
Commit: Andras Timar 
CommitDate: Wed Nov 28 13:43:45 2018 +0100

tdf#120438: Don't handle a lone "alt" modifier in any special way

It is likely a Mac browser client simply accessing a "special
character" on their keyboard. (Or an iOS browser client using a
physical keyboard.) Like alt+8 to get '[' on a Swedish/Finnish Apple
keyboard, or alt+shift+2 to get '€' on a US English Apple keyboard.

Change-Id: I94b49d64db87324ff2a5cd5f50226d3c537b68e6
Reviewed-on: https://gerrit.libreoffice.org/62315
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 
(cherry picked from commit 1e97cfc2d2a8ee3e296ddfb7a331466bede4a575)
Reviewed-on: https://gerrit.libreoffice.org/64166
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/loleaflet/src/map/handler/Map.Keyboard.js 
b/loleaflet/src/map/handler/Map.Keyboard.js
index f5d3282da..4e489b075 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -301,6 +301,12 @@ L.Map.Keyboard = L.Handler.extend({
inputEle.value = '';
}
 
+   if (this.modifier == this.keyModifier.alt || this.modifier == 
this.keyModifier.shift + this.keyModifier.alt) {
+   // Presumably a Mac or iOS client accessing a "special 
character". Just ignore the alt modifier.
+   this.modifier -= alt;
+   alt = 0;
+   }
+
var unoKeyCode = this._toUNOKeyCode(keyCode);
 
if (this.modifier) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - include/sfx2 sfx2/source xmlsecurity/qa

 include/sfx2/signaturestate.hxx |4 +++-
 include/sfx2/strings.hrc|1 +
 sfx2/source/doc/objserv.cxx |8 +++-
 xmlsecurity/qa/unit/signing/signing.cxx |6 --
 4 files changed, 15 insertions(+), 4 deletions(-)

New commits:
commit 4e9258e033d17b9f05df36026ca573aa6b229823
Author: Miklos Vajna 
AuthorDate: Mon Nov 26 09:21:18 2018 +0100
Commit: Miklos Vajna 
CommitDate: Wed Nov 28 13:42:20 2018 +0100

sfx2: show partial signatures even if cert validation fails

(cherry picked from commit 4a59a8aba8c9d451edff790d9281d0095c1bd78e)

Change-Id: I6060b7130827346ac5d6955bf38ebe3b476819fd
Reviewed-on: https://gerrit.libreoffice.org/64151
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/sfx2/signaturestate.hxx b/include/sfx2/signaturestate.hxx
index a1fd09360906..8bdfdfac75d9 100644
--- a/include/sfx2/signaturestate.hxx
+++ b/include/sfx2/signaturestate.hxx
@@ -33,7 +33,9 @@ enum class SignatureState
 NOTVALIDATED  = 4,
 // signature and certificate are ok, but not all files are signed, as it 
was the case in
 // OOo 2.x - OOo 3.1.1. This state is only used together with document 
signatures.
-PARTIAL_OK= 5
+PARTIAL_OK= 5,
+/// Certificate could not be validated and the document is only partially 
signed.
+NOTVALIDATED_PARTIAL_OK = 6
 };
 
 #endif // INCLUDED_SFX2_SIGNATURESTATE_HXX
diff --git a/include/sfx2/strings.hrc b/include/sfx2/strings.hrc
index f02efc506078..ec2867206e54 100644
--- a/include/sfx2/strings.hrc
+++ b/include/sfx2/strings.hrc
@@ -261,6 +261,7 @@
 #define STR_SIGNATURE_INVALID   NC_("STR_SIGNATURE_INVALID", 
"The signature was valid, but the document has been modified")
 #define STR_SIGNATURE_NOTVALIDATED  
NC_("STR_SIGNATURE_NOTVALIDATED", "The signature is OK, but the certificate 
could not be validated.")
 #define STR_SIGNATURE_PARTIAL_OK
NC_("STR_SIGNATURE_PARTIAL_OK", "The signature is OK, but the document is only 
partially signed.")
+#define STR_SIGNATURE_NOTVALIDATED_PARTIAL_OK   
NC_("STR_SIGNATURE_NOTVALIDATED_PARTIAL_OK", "The certificate could not be 
validated and the document is only partially signed.")
 #define STR_SIGNATURE_OKNC_("STR_SIGNATURE_OK", "This 
document is digitally signed and the signature is valid.")
 #define STR_SIGNATURE_SHOW  NC_("STR_SIGNATURE_SHOW", 
"Show Signatures")
 
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index e7941cc01238..3b9737c5ae5e 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -1068,6 +1068,10 @@ void SfxObjectShell::GetState_Impl(SfxItemSet &rSet)
 sMessage = SfxResId(STR_SIGNATURE_OK);
 aInfoBarType = InfoBarType::Info;
 break;
+case SignatureState::NOTVALIDATED_PARTIAL_OK:
+sMessage = 
SfxResId(STR_SIGNATURE_NOTVALIDATED_PARTIAL_OK);
+aInfoBarType = InfoBarType::Warning;
+break;
 //FIXME SignatureState::Unknown, own message?
 default:
 break;
@@ -1285,7 +1289,9 @@ SignatureState 
SfxObjectShell::ImplCheckSignaturesInformation( const uno::Sequen
 }
 }
 
-if ( nResult == SignatureState::OK && !bCertValid )
+if (nResult == SignatureState::OK && !bCertValid && !bCompleteSignature)
+nResult = SignatureState::NOTVALIDATED_PARTIAL_OK;
+else if (nResult == SignatureState::OK && !bCertValid)
 nResult = SignatureState::NOTVALIDATED;
 else if ( nResult == SignatureState::OK && bCertValid && 
!bCompleteSignature)
 nResult = SignatureState::PARTIAL_OK;
diff --git a/xmlsecurity/qa/unit/signing/signing.cxx 
b/xmlsecurity/qa/unit/signing/signing.cxx
index 411cfceecf82..d9507982486b 100644
--- a/xmlsecurity/qa/unit/signing/signing.cxx
+++ b/xmlsecurity/qa/unit/signing/signing.cxx
@@ -639,12 +639,14 @@ void SigningTest::testOOXMLPartial()
 SfxObjectShell* pObjectShell = pBaseModel->GetObjectShell();
 CPPUNIT_ASSERT(pObjectShell);
 // This was SignatureState::BROKEN due to missing RelationshipTransform 
and SHA-256 support.
-// We expect NOTVALIDATED in case the root CA is not imported on the 
system, and PARTIAL_OK otherwise, so accept both.
+// We expect NOTVALIDATED_PARTIAL_OK in case the root CA is not imported 
on the system, and PARTIAL_OK otherwise, so accept both.
+// But reject NOTVALIDATED, hiding incompleteness is not OK.
 SignatureState nActual = pObjectShell->GetDocumentSignatureState();
 CPPUNIT_ASSERT_MESSAGE(
 
(OString::number(static_cast::type>(nActual))
  .getStr()),
-(nActual == SignatureState::NOTVALIDATED || nActual == 
SignatureState::PARTIAL_OK));
+(nActual == SignatureState::NOTVALIDATED_PARTIAL_OK
+ 

[Libreoffice-commits] core.git: desktop/source

 desktop/source/deployment/gui/dp_gui_dialog2.cxx |   84 ++-
 desktop/source/deployment/gui/dp_gui_dialog2.hxx |   23 +++---
 2 files changed, 78 insertions(+), 29 deletions(-)

New commits:
commit 01de2fbdedc693dc46c6d3fde276820a52b42a9c
Author: Caolán McNamara 
AuthorDate: Wed Nov 28 11:12:55 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 13:24:13 2018 +0100

Resolves: tdf#121746 block toplevels from closing...

while the extension manager is querying via a dialog. Reuse
the isBusy for this.

Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280
Reviewed-on: https://gerrit.libreoffice.org/64155
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx 
b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index b36f18d8f5dc..62e2e301bfc4 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -336,16 +336,15 @@ void ExtBoxWithBtns_Impl::enableButtons( bool bEnable )
 
 // DialogHelper
 
-DialogHelper::DialogHelper( const uno::Reference< uno::XComponentContext > 
&xContext,
-Dialog *pWindow ) :
-m_pVCLWindow( pWindow ),
-m_nEventID(   nullptr ),
-m_bIsBusy(false )
+DialogHelper::DialogHelper(const uno::Reference< uno::XComponentContext > 
&xContext,
+   Dialog *pWindow)
+: m_xVCLWindow(pWindow)
+, m_nEventID(nullptr)
+, m_nBusy(0)
 {
 m_xContext = xContext;
 }
 
-
 DialogHelper::~DialogHelper()
 {
 if ( m_nEventID )
@@ -366,17 +365,21 @@ bool DialogHelper::continueOnSharedExtension( const 
uno::Reference< deployment::
 if ( !bHadWarning && IsSharedPkgMgr( xPackage ) )
 {
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xBox(Application::CreateMessageDialog(pParent,
   VclMessageType::Warning, 
VclButtonsType::OkCancel, DpResId(pResID)));
 bHadWarning = true;
 
-return RET_OK == xBox->run();
+bool bRet = RET_OK == xBox->run();
+xBox.reset();
+decBusy();
+return bRet;
 }
 else
 return true;
 }
 
-void DialogHelper::openWebBrowser( const OUString & sURL, const OUString 
&sTitle ) const
+void DialogHelper::openWebBrowser(const OUString& sURL, const OUString& sTitle)
 {
 if ( sURL.isEmpty() ) // Nothing to do, when the URL is empty
 return;
@@ -393,29 +396,35 @@ void DialogHelper::openWebBrowser( const OUString & sURL, 
const OUString &sTitle
 uno::Any exc( ::cppu::getCaughtException() );
 OUString msg( ::comphelper::anyToString( exc ) );
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xErrorBox(Application::CreateMessageDialog(getFrameWeld(),

VclMessageType::Warning, VclButtonsType::Ok, msg));
 xErrorBox->set_title(sTitle);
 xErrorBox->run();
+xErrorBox.reset();
+decBusy();
 }
 }
 
-
-bool DialogHelper::installExtensionWarn( const OUString &rExtensionName ) const
+bool DialogHelper::installExtensionWarn(const OUString &rExtensionName)
 {
 const SolarMutexGuard guard;
 
 // Check if extension installation is disabled in the expert configurations
 if 
(officecfg::Office::ExtensionManager::ExtensionSecurity::DisableExtensionInstallation::get())
 {
+incBusy();
 std::unique_ptr 
xWarnBox(Application::CreateMessageDialog(getFrameWeld(),
   VclMessageType::Warning, 
VclButtonsType::Ok,
   
DpResId(RID_STR_WARNING_INSTALL_EXTENSION_DISABLED)));
 xWarnBox->run();
+xWarnBox.reset();
+decBusy();
 
 return false;
 }
 
+incBusy();
 std::unique_ptr 
xInfoBox(Application::CreateMessageDialog(getFrameWeld(),
   VclMessageType::Warning, 
VclButtonsType::OkCancel,
   
DpResId(RID_STR_WARNING_INSTALL_EXTENSION)));
@@ -423,15 +432,21 @@ bool DialogHelper::installExtensionWarn( const OUString 
&rExtensionName ) const
 sText = sText.replaceAll("%NAME", rExtensionName);
 xInfoBox->set_primary_text(sText);
 
-return (RET_OK == xInfoBox->run());
+bool bRet = RET_OK == xInfoBox->run();
+xInfoBox.reset();
+decBusy();
+return bRet;
 }
 
-bool DialogHelper::installForAllUsers( bool &bInstallForAll ) const
+bool DialogHelper::installForAllUsers(bool &bInstallForAll)
 {
 const SolarMutexGuard guard;
+incBusy();
 std::unique_ptr 
xBuilder(Application::CreateBuilder(getFrameWeld(), 
"desktop/ui/installforalldialog.ui"));
 std::unique_ptr 
xQuery(xBuilder->weld_message_dialog("InstallForAllD

[Libreoffice-commits] core.git: reportbuilder/java

 reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java |   
27 ++
 1 file changed, 27 insertions(+)

New commits:
commit 57bfb56972dc101200466054f0f9446301c214cb
Author: Caolán McNamara 
AuthorDate: Tue Nov 27 17:42:16 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 13:11:20 2018 +0100

Resolves: tdf#94446 if this is a SQLException in disguise, throw that 
instead

instead of the wrapper exception, so that dbaccess can apply its special
handling for SQLException::ErrorCode of 
dbtools::ParameterInteractionCancelled
in OLinkedDocumentsAccess::open if ParameterInteractionCancelled was the 
root
cause

Change-Id: I777893cf7355d8c4a9c48237284903176d81402d
Reviewed-on: https://gerrit.libreoffice.org/64123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git 
a/reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java 
b/reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
index 6c70a3425d90..4c799cd27326 100644
--- a/reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
+++ b/reportbuilder/java/org/libreoffice/report/pentaho/SOReportJobFactory.java
@@ -38,6 +38,9 @@ import com.sun.star.registry.InvalidRegistryException;
 import com.sun.star.registry.InvalidValueException;
 import com.sun.star.registry.XRegistryKey;
 import com.sun.star.registry.XSimpleRegistry;
+import com.sun.star.sdbc.SQLException;
+import org.jfree.report.ReportDataFactoryException;
+import org.libreoffice.report.DataSourceException;
 import org.libreoffice.report.DataSourceFactory;
 import org.libreoffice.report.JobProperties;
 import org.libreoffice.report.ReportEngineParameterNames;
@@ -194,6 +197,26 @@ public class SOReportJobFactory
 return currentLocale;
 }
 
+// tdf#94446 if this is a SQLException in disguise, throw that
+// original exception instead of the wrapper exception, so that
+// dbaccess can apply its special handling for
+// SQLException::ErrorCode of dbtools::ParameterInteractionCancelled
+// in OLinkedDocumentsAccess::open if ParameterInteractionCancelled
+// was the root cause
+public void rethrow_sql_exception(Throwable exception)
+throws com.sun.star.sdbc.SQLException
+{
+if (exception instanceof ReportDataFactoryException == false)
+return;
+exception = ((ReportDataFactoryException)exception).getParent();
+if (exception instanceof DataSourceException == false)
+return;
+exception = ((DataSourceException)exception).getCause();
+if (exception instanceof SQLException == false)
+return;
+throw (SQLException)exception;
+}
+
 public Object execute(final NamedValue[] namedValue)
 throws com.sun.star.lang.IllegalArgumentException, 
com.sun.star.uno.Exception
 {
@@ -223,6 +246,10 @@ public class SOReportJobFactory
 Writer result = new StringWriter();
 PrintWriter printWriter = new PrintWriter(result);
 e.printStackTrace(printWriter);
+
+// if this is a wrapped SQLException, rethrow that instead
+rethrow_sql_exception(e.getCause());
+
 throw new com.sun.star.lang.WrappedTargetException(e, 
e.toString() + '\n' + result.toString(), this, null);
 }
 catch (java.lang.IncompatibleClassChangeError e)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - cui/source

 cui/source/tabpages/transfrm.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 8b141eb612a89a112b9bb11baeff32155e4a0150
Author: Caolán McNamara 
AuthorDate: Tue Nov 27 21:21:45 2018 +
Commit: Xisco Faulí 
CommitDate: Wed Nov 28 12:43:35 2018 +0100

Resolves: tdf#121695 call save_value

so get_value_changed_from_saved detects no-op

Change-Id: I2b72bc7a6bc4093f9d942aa56f90542521e23cd9
Reviewed-on: https://gerrit.libreoffice.org/64132
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index bfc5017e3705..e9f067b38a77 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -1126,6 +1126,11 @@ void SvxPositionSizeTabPage::Reset( const SfxItemSet*  )
 OUString aStr = GetUserData();
 m_xCbxScale->set_active(aStr.toInt32() != 0);
 
+m_xMtrPosX->save_value();
+m_xMtrPosY->save_value();
+m_xMtrWidth->save_value();
+m_xMtrHeight->save_value();
+
 m_xTsbSizeProtect->save_state();
 m_xTsbAutoGrowWidth->save_state();
 m_xTsbAutoGrowHeight->save_state();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


RE: tdf#69569 ODFFv1.2 part 2 incorrect

Hi Eike,

Have you been able to form an opinion yet re the conclusions/suggestions below?

Winfried

> woensdag 14 november 2018 11:38
> 
> Hi Eike,
> 
> I have been studying ODFFv1.2 part 2 §4.11.7.7 with
> https://bugs.documentfoundation.org/show_bug.cgi?id=69569#c17 , lines 1..5.
> in mind.
> 
> My conclusions are that
> a) Line 8 should be
> " 8.Otherwise, if _(not A)_ and is-leap-year(year(date1)) then return
> 366 ";
> b) Lines 9 and 10 can be combined by appending inclusive to both dates, the
> current line 9 is ambiguous and line 10 does not fully solve that;
> c) The constraint date1 >= date2 is missing in §4.11.7.
> 
> I have made logical diagrams to cheack that all possible combinations of
> date1 and date2 are covered - on the presumption that date1 >= date2.
> If you agree with my conclusions, would it be possible that you submit a
> proposal for changing ODFF to reflect the above?
> I think that a proposal from you is more effective than one from me ;-)
> 
> And if you agree with my conclusions I intend to work on bug tdf69569 to
> implement the proposed changes (c is already implemented in
> /core/scaddins/source.analysis/analysishelper.cxx, getYearFrac(.)).
> 
> 
> Winfried
> 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Compiler baselines


On 23/11/2018 08:57, Stephan Bergmann wrote:

On 21/11/2018 17:42, Stephan Bergmann wrote:
If nobody objects, we'd update the build baselines on master (towards 
LO 6.3) as follows (cf README.md):

* flex: from 2.5.35 to 2.6.0


The relevant Linux Jenkins nodes (tb75-lilith, tb76-maggie, and 
tb79-pollux) and most of the relevant macOS Jenkins nodes (tb57, tb58, 
tb66, gb69, tb80, and tb81; tb59 and tb82 are permanently offline) have 
been updated (via admin_lode and 
 
"Install flex 2.6.4 if necessary").  The relevant Windows Jenkins nodes 
apparently still need updating (see above).


Enforced now with 
 
"Require at least flex 2.6.0, which no longer emits 'register'".



* gperf: from 3.0.0 to 3.1


The relevant Linux Jenkins nodes (tb75-lilith, tb76-maggie, and 
tb79-pollux) and most of the relevant macOS Jenkins nodes (tb57, tb58, 
tb66, gb69, tb80, and tb81; tb59 and tb82 are permanently offline) have 
been updated (via admin_ldoe and 
 
"On Linux, use latest gperf 3.1" resp. 
 
"Install gperf 3.1 if necessary").  The relevant Windows Jenkins nodes 
presumably still need updating (see above).


Enforced now with 
 
"Require at least gperf 3.1, which no longer emits 'register'".

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: configure.ac

 configure.ac |   24 +++-
 1 file changed, 7 insertions(+), 17 deletions(-)

New commits:
commit e8e3b00bafefffa1b8a35c5721988fb3bf1f817c
Author: Stephan Bergmann 
AuthorDate: Sat Nov 24 18:00:50 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 12:07:44 2018 +0100

Require at least gperf 3.1, which no longer emits "register"

...as discussed at


"minutes of ESC call ..."

Change-Id: I47b6d4a7b8370262ca942b4385e2c0e6f0adc613
Reviewed-on: https://gerrit.libreoffice.org/63953
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index 17672abcb8f4..4134f6460e16 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6155,11 +6155,14 @@ fi
 if test "$GNUMAKE_WIN_NATIVE" = "TRUE" ; then
 GPERF=`cygpath -m $GPERF`
 fi
-AC_MSG_CHECKING([gperf version])
-if test "`$GPERF --version | $EGREP ^GNU\ gperf | $AWK '{ print $3 }' | cut 
-d. -f1`" -ge "3"; then
-AC_MSG_RESULT([OK])
+AC_MSG_CHECKING([whether gperf is new enough])
+my_gperf_ver1=$($GPERF --version | head -n 1)
+my_gperf_ver2=${my_gperf_ver1#GNU gperf }
+my_gperf_ver3=$(printf %s "$my_gperf_ver2" | $AWK -F. '{ print 
$1*100+($2<100?$2:99) }')
+if test "$my_gperf_ver3" -ge 301; then
+AC_MSG_RESULT([yes ($my_gperf_ver2)])
 else
-AC_MSG_ERROR([too old, you need at least 3.0.0])
+AC_MSG_ERROR(["$my_gperf_ver1" is too old or unrecognized, must be at 
least gperf 3.1])
 fi
 AC_SUBST(GPERF)
 
@@ -6184,9 +6187,6 @@ CXXFLAGS_CXX11=
 if test "$COM" = MSC -a "$COM_IS_CLANG" != TRUE; then
 CXXFLAGS_CXX11=-std:c++17
 elif test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
-dnl But only use C++17 if the gperf that is being used knows not to emit
-dnl "register" in C++ output:
-printf 'foo\n' | $GPERF -L C++ > conftest.inc
 my_flags='-std=gnu++2a -std=c++2a -std=gnu++17 -std=gnu++1z -std=c++17 
-std=c++1z -std=gnu++14 -std=gnu++1y -std=c++14 -std=c++1y -std=gnu++11 
-std=gnu++0x -std=c++11 -std=c++0x'
 for flag in $my_flags; do
 if test "$COM" = MSC; then
@@ -6233,15 +6233,6 @@ elif test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
 #include 
 #include 
 
-#include 
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wpragmas"
-// make GCC not warn about next pragma
-#pragma GCC diagnostic ignored "-Wdeprecated-register"
-// make Clang with -std < C++17 not even warn about register
-#include "conftest.inc"
-#pragma GCC diagnostic pop
-
 #if defined SYSTEM_LIBCMIS
 // See ucb/source/ucp/cmis/auth_provider.hxx:
 #if __GNUC__ >= 7
@@ -6265,7 +6256,6 @@ elif test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
 break
 fi
 done
-rm conftest.inc
 fi
 if test -n "$CXXFLAGS_CXX11"; then
 AC_MSG_RESULT([yes ($CXXFLAGS_CXX11)])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: configure.ac

 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 09b8d1f480b22581f8ef31c2611f4bb7366b53c0
Author: Stephan Bergmann 
AuthorDate: Wed Nov 21 13:28:23 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 28 12:07:13 2018 +0100

Require at least flex 2.6.0, which no longer emits "register"

...according to .  Its use is no longer 
allowed in
C++17, so will start to cause build failures once we restrict builds to at 
least
C++17.  (The situation with gperf is similar, but instead of checking for a
minimal known-good version that no longer emits "register", we instead 
check for
it indirectly in configure.ac, by creating gperf-produced conftest.inc and
including that in the program used to test which -std= value to use.  We 
could
have done something similar for flex, but creating suitable flex output for
inclusion might be more work than it was for the simple gperf case.)

Change-Id: I662c6795ea5fde1420d9712c0ec910c0cadbc350
Reviewed-on: https://gerrit.libreoffice.org/63713
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index 13d4afa1240d..17672abcb8f4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9850,8 +9850,8 @@ if test -z "$FLEX"; then
 else
 AC_MSG_CHECKING([the flex version])
 _flex_version=$($FLEX --version | $SED -e 
's/^.*\([[[:digit:]]]\{1,\}\.[[[:digit:]]]\{1,\}\.[[[:digit:]]]\{1,\}\).*$/\1/')
-if test $(echo $_flex_version | $AWK -F. '{printf("%d%03d%03d", $1, $2, 
$3)}') -lt 2005035; then
-AC_MSG_ERROR([failed ($FLEX $_flex_version found, but need at least 
2.5.35)])
+if test $(echo $_flex_version | $AWK -F. '{printf("%d%03d%03d", $1, $2, 
$3)}') -lt 2006000; then
+AC_MSG_ERROR([failed ($FLEX $_flex_version found, but need at least 
2.6.0)])
 fi
 fi
 AC_SUBST([FLEX])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: wsd/Storage.cpp

 wsd/Storage.cpp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit b9694c305b07ff52b5659d5d4b7a0e6ecbea5487
Author: Tor Lillqvist 
AuthorDate: Wed Nov 28 12:40:52 2018 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 28 12:41:43 2018 +0200

Adapt after ed9c756c9ed9150f361340a2eb4dade9ec405935

Change-Id: Ide7ab1544039d11d478c30cc8fd9c09b1d1f6894

diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index a42534eaa..7ed86bc3c 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -328,10 +328,10 @@ std::string LocalStorage::loadStorageFileToLocal(const 
Authorization& /*auth*/)
 #else // MOBILEAPP
 
 // In the mobile app we use no jail
-_jailedFilePath = _uri.getPath();
-_isLoaded = true;
+setRootFilePath(getUri().getPath());
+setLoaded(true);
 
-return _jailedFilePath;
+return getRootFilePath();
 #endif
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

 sw/source/core/doc/swserv.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit 9c56e63c434be69d94a81078b7d5491a5775c8e0
Author: Noel Grandin 
AuthorDate: Wed Nov 28 12:34:27 2018 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 28 12:34:27 2018 +0200

-Werror=unused-but-set-variable

after
commit 19c56b3befae3a23f42f981de5057de380b4c5a0
loplugin:unusedfields in sw

Change-Id: I67314e86695a399fd211a64bdcf4cc3f18ca133d

diff --git a/sw/source/core/doc/swserv.cxx b/sw/source/core/doc/swserv.cxx
index f1c1338c9d3b..2428babd9019 100644
--- a/sw/source/core/doc/swserv.cxx
+++ b/sw/source/core/doc/swserv.cxx
@@ -183,8 +183,6 @@ void SwServerObject::SendDataChanged( const SwPaM& rRange )
 bool SwServerObject::IsLinkInServer( const SwBaseLink* pChkLnk ) const
 {
 sal_uLong nSttNd = 0, nEndNd = 0;
-sal_Int32 nStt = 0;
-sal_Int32 nEnd = 0;
 const SwNode* pNd = nullptr;
 const SwNodes* pNds = nullptr;
 
@@ -197,9 +195,7 @@ bool SwServerObject::IsLinkInServer( const SwBaseLink* 
pChkLnk ) const
 * pEnd = &CNTNT_TYPE.pBkmk->GetMarkEnd();
 
 nSttNd = pStt->nNode.GetIndex();
-nStt = pStt->nContent.GetIndex();
 nEndNd = pEnd->nNode.GetIndex();
-nEnd = pEnd->nContent.GetIndex();
 pNds = &pStt->nNode.GetNodes();
 }
 break;
@@ -215,8 +211,6 @@ bool SwServerObject::IsLinkInServer( const SwBaseLink* 
pChkLnk ) const
 {
 nSttNd = pNd->GetIndex();
 nEndNd = pNd->EndOfSectionIndex();
-nStt = 0;
-nEnd = -1;
 pNds = &pNd->GetNodes();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - officecfg/registry

 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ce7bb69f8205bcbe36cba4c53bd110e07ef3e05d
Author: Caolán McNamara 
AuthorDate: Tue Nov 27 14:02:12 2018 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 28 11:29:28 2018 +0100

tdf#90333 Dictionaries Path Cannot Be Changed

PathSettings::impl_storePath wants to be able to nil the Dictionaries
path in the old copy of properties

Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f
Reviewed-on: https://gerrit.libreoffice.org/64115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit f913bdf712b9e03506b1278e1142283af92125b1)
Reviewed-on: https://gerrit.libreoffice.org/64145

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 4ef848e68b0c..225567c53a06 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -1616,7 +1616,7 @@
   
   $(insturl)/@LIBO_SHARE_FOLDER@/config
 
-
+
   
 Contains the provided dictionaries.
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: officecfg/registry

 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu|2 -
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |   14 
+-
 2 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 9574dea6272b7f4cb0f61373b1c037a0f00f1eca
Author: Sabri Unal 
AuthorDate: Tue Nov 27 04:19:22 2018 +0200
Commit: Heiko Tietze 
CommitDate: Wed Nov 28 11:00:42 2018 +0100

Related: tdf#121629: Some menu items do not follow the Title Case rule

Change-Id: I6b071365ee1531c3ddba70a25e36d6bd98561ffc
Reviewed-on: https://gerrit.libreoffice.org/64135
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
index 22519d964527..8d3204d89af6 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
@@ -948,7 +948,7 @@
   
   
 
-  ~z-test...
+  ~Z-test...
 
 
   1
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index b0387cfefee1..83b25c19508e 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -6547,37 +6547,37 @@
   
   
 
-  Non-br~eaking hyphen
+  Non-br~eaking Hyphen
 
   
   
 
-  S~oft hyphen
+  S~oft Hyphen
 
   
   
 
-  ~Non-breaking space
+  ~Non-breaking Space
 
   
   
 
-  No-~width optional break
+  No-~width Optional Break
 
   
   
 
-  No-width no ~break
+  No-width No ~Break
 
   
   
 
-  ~Left-to-right mark
+  ~Left-to-right Mark
 
   
   
 
-  ~Right-to-left mark
+  ~Right-to-left Mark
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ab641e784774ba9b3f784d9334c0e33e2f77838d
Author: Olivier Hallot 
AuthorDate: Fri Nov 16 10:00:39 2018 -0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 28 10:53:51 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - tdf#121797 XHP extensions (Help part)

WIP. This is the Help part.

Extend the XML parser to include new incantations of the 
tag, namely
 to 
,  and 

Extension to the  tag:
, , ,  and 

* removed test files

Change-Id: I2a473ee8772606f5e84bb02e651bccc6749598f4
Reviewed-on: https://gerrit.libreoffice.org/63954
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 949606895b8d..49baef5df558 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 949606895b8d46fb97b0bfcda25cfb04f1f61e32
+Subproject commit 49baef5df55850a72b9385f7ec2b9eb98486e48a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: help3xsl/default.css help3xsl/online_transform.xsl helpers/xmlhelp.dtd

 help3xsl/default.css  |   17 +-
 help3xsl/online_transform.xsl |   59 ++
 helpers/xmlhelp.dtd   |   65 --
 3 files changed, 130 insertions(+), 11 deletions(-)

New commits:
commit 49baef5df55850a72b9385f7ec2b9eb98486e48a
Author: Olivier Hallot 
AuthorDate: Fri Nov 16 10:00:39 2018 -0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 10:53:51 2018 +0100

tdf#121797 XHP extensions (Help part)

WIP. This is the Help part.

Extend the XML parser to include new incantations of the 
tag, namely
 to 
,  and 

Extension to the  tag:
, , ,  and 

* removed test files

Change-Id: I2a473ee8772606f5e84bb02e651bccc6749598f4
Reviewed-on: https://gerrit.libreoffice.org/63954
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index e6a59ad8b..285d1e900 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -124,10 +124,23 @@ pre,
 border-top: 1px solid black;
 }
 .emph,
-.menuitem,
-.keycode {
+.menuitem {
 font-weight: bold;
 }
+.keycode {
+/*font-weight: bold;*/
+font-family: Menlo, Consolas, "DejaVu Sans Mono", "Nimbus Mono L", "Lucida 
Sans Typewriter", "Courier New", Courier, Monaco, monospace;
+}
+.widget{
+padding: 1px 10px;
+background: #f0f0f0;
+background: linear-gradient(to bottom,#f0f0f0,#fcfcfc);
+border-radius: 3px;
+color: #303030;
+border: 1px solid #a0a0a0;
+border-bottom-width: 2px;
+white-space: nowrap;
+}
 /* div's for warning, tip and note */
 .note,
 .tip,
diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl
index 95892bdd4..59eb5120a 100644
--- a/help3xsl/online_transform.xsl
+++ b/help3xsl/online_transform.xsl
@@ -800,6 +800,65 @@
 
 
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 
 
diff --git a/helpers/xmlhelp.dtd b/helpers/xmlhelp.dtd
index d6564f5f4..20dbe802d 100644
--- a/helpers/xmlhelp.dtd
+++ b/helpers/xmlhelp.dtd
@@ -21,6 +21,9 @@ Version 03-Feb-2006
 
 Version 06-Jun-2017
   Made xml-lang optional (#IMPLIED)
+
+Version Nov 2018
+  Added extensions: H1, .. H6, menuitem, keycode, literal input, widget, note, 
tip, warning
 -->
 
 
@@ -38,7 +41,7 @@ Version 06-Jun-2017
 
 
 
-
+
 
 
 
 
-
+
 
 
-
+
 
@@ -76,9 +79,9 @@ Version 06-Jun-2017
   date CDATA #REQUIRED
 >
 
-
+
 
-
+
 
 
 
 
+
+
+
+
+
+
+
+
+
+
 
 
 
 
 
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 
 
-
+
 
 
-
+
 
 
-
+
 
@@ -228,10 +265,20 @@ Version 06-Jun-2017
status (DRAFT | FINAL | PUBLISH | STALLED | DEPRECATED) #IMPLIED
 >
 
-
+
 
+
+
 
+
+
+
+
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: l10ntools/source

 l10ntools/source/xmlparse.cxx |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 10793855574782a1d57805883693b6f200cfac3d
Author: Olivier Hallot 
AuthorDate: Sat Nov 24 14:59:09 2018 -0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 10:53:20 2018 +0100

tdf#121697 XHP extensions

This is the core part of the bug, and is WIP

Extend the XML parser to include new incantations of the 
tag, namely
 to 
,  and 

Extension to the  tag:
, , ,  and 

Change-Id: Idaed321cc8756fa6bcf4fbc170982365ff33d4d7
Reviewed-on: https://gerrit.libreoffice.org/63955
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/l10ntools/source/xmlparse.cxx b/l10ntools/source/xmlparse.cxx
index d1380208d263..369d8e6e1562 100644
--- a/l10ntools/source/xmlparse.cxx
+++ b/l10ntools/source/xmlparse.cxx
@@ -314,6 +314,15 @@ XMLFile::XMLFile( const OString &rFileName ) // the file 
name, empty if created
 m_aNodes_localize.emplace( OString("bookmark") , true );
 m_aNodes_localize.emplace( OString("variable") , true );
 m_aNodes_localize.emplace( OString("paragraph") , true );
+m_aNodes_localize.emplace( OString("h1") , true );
+m_aNodes_localize.emplace( OString("h2") , true );
+m_aNodes_localize.emplace( OString("h3") , true );
+m_aNodes_localize.emplace( OString("h4") , true );
+m_aNodes_localize.emplace( OString("h5") , true );
+m_aNodes_localize.emplace( OString("h6") , true );
+m_aNodes_localize.emplace( OString("note") , true );
+m_aNodes_localize.emplace( OString("tip") , true );
+m_aNodes_localize.emplace( OString("warning") , true );
 m_aNodes_localize.emplace( OString("alt") , true );
 m_aNodes_localize.emplace( OString("caption") , true );
 m_aNodes_localize.emplace( OString("title") , true );
@@ -1055,12 +1064,14 @@ icu::UnicodeString lcl_QuotRange(
 
 bool lcl_isTag( const icu::UnicodeString& rString )
 {
-static const int nSize = 15;
+static const int nSize = 20;
 static const icu::UnicodeString vTags[nSize] = {
 "ahelp", "link", "item", "emph", "defaultinline",
 "switchinline", "caseinline", "variable",
 "bookmark_value", "image", "object",
-"embedvar", "alt", "sup", "sub" };
+"embedvar", "alt", "sup", "sub",
+"menuitem", "keycode", "input", "literal", "widget"
+};
 
 for( int nIndex = 0; nIndex < nSize; ++nIndex )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary source/text

 AllLangHelp_sbasic.mk  |3 
 source/auxiliary/sbasic.tree   |  637 -
 source/text/sbasic/python/main.xhp |   39 +
 source/text/sbasic/python/python_ide.xhp   |   32 +
 source/text/sbasic/python/python_locations.xhp |   29 +
 source/text/shared/00/0406.xhp |3 
 source/text/shared/01/0613.xhp |   16 
 7 files changed, 442 insertions(+), 317 deletions(-)

New commits:
commit 949606895b8d46fb97b0bfcda25cfb04f1f61e32
Author: Olivier Hallot 
AuthorDate: Tue Nov 27 22:10:50 2018 -0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 28 10:48:08 2018 +0100

tdf#121736 initial Help pages for Python scripts

Work in progress, initial addition of help pages for python
scripts in LO.

Change-Id: Iee95b1340c821fdb08524fdedeca3817b0de1459
Reviewed-on: https://gerrit.libreoffice.org/64137
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index 8515bb65a..4b3323aac 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -360,6 +360,9 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/main0601 \
 helpcontent2/source/text/sbasic/shared/special_vba_func \
 helpcontent2/source/text/sbasic/shared/vbasupport \
+helpcontent2/source/text/sbasic/python/main \
+helpcontent2/source/text/sbasic/python/python_ide \
+helpcontent2/source/text/sbasic/python/python_locations \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index fbae74d0d..03818d0e7 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -1,320 +1,327 @@
 
 
 
-   
-   
-%PRODUCTNAME Basic 
Help
-Programming with 
%PRODUCTNAME Basic 
-%PRODUCTNAME Basic 
Glossary
-Basics
-Syntax
-%PRODUCTNAME Basic 
IDE
-IDE Overview
-The Basic Editor
-Watch Window
-Macro Toolbar
-Macro
-Working with VBA 
Macros
-   
-   
-Using Procedures and 
Functions
-Libraries, Modules and 
Dialogs
-   
-Screen I/O Functions
-File I/O Functions
-Date and Time 
Functions
-Error-Handling 
Functions
-Logical Operators
-Mathematical 
Operators
-Numeric Functions
-Controlling Program 
Execution
-Variables
-Basic Constants
-Comparison Operators
-Strings
-Exclusive VBA 
functions
-Other Commands
-   
-   
-Abs Function
-AND Operator
-Array Function
-Asc Function
-AscW Function [VBA]
-Atn Function
-Beep Statement
-Blue Function
-CBool Function
-CByte Function
-CCur Function
-CDateFromUnoDateTime 
Function
-CDateToUnoDateTime 
Function
-CDateFromUnoTime 
Function
-CDateToUnoTime 
Function
-CDateFromUnoDate 
Function
-CDateToUnoDate 
Function
-CDateFromIso 
Function
-CDateToIso Function
-CDate Function
-CDbl Function
-CDec Function
-CInt Function
-CLng Function
-CSng Function
-CStr Function
-Call Statement
-ChDir Statement
-ChDrive Statement
-Choose Function
-Chr Function
-ChrW Function [VBA]
-Close Statement
-Comparison Operators
-Const Statement
-ConvertFromURL 
Function
-ConvertToURL 
Function
-Cos Function
-CreateObject 
Function
-CreateUnoDialog 
Function
-CreateUnoListener 
Function
-CreateUnoService 
Function
-CreateUnoStruct 
Function
-CreateUnoValue 
Function
-CurDir Function
-CVar Function
-CVErr Function
-DateAdd Function
-DateDiff Function
-DatePart Function
-DateSerial Function
-DateValue Function
-Date Statement
-Day Function
-DDB Function [VBA]
-Declare Statement
-DefBool Statement
-DefDate Statement
-DefDbl Statement
-DefInt Statement
-DefLng Statement
-DefObj Statement
-DefVar Statement
-DimArray Function
-Dim Statement
-Dir Function
-Do...Loop Statement
-Comparison Operators
-End Statement
-Environ Function
-Eof Function
-EqualUnoObjects 
Function
-Eqv Operator
-Erl Function
-Err Function
-Error Function
-Error-Handling 
Functions
-Exit Statement
-Exp Function
-FileAttr Function
-FileCopy Statement
-FileDateTime 
Function
-FileExists Function
-FileLen Function
-FindObject Function
-FindPropertyObject 
Function
-Fix Function
-For...Next Statement
-Format Function
-FormatDateTime Function 
[VBA]
-FormatNumber Function 
[VBA]
-FreeFile Function
-FreeLibrary Function
-Function Statement
-Further Statements
-FV Function [VBA]
-Generating Random 
Numbers
-GetAttr Function
-GetDefaultContext 
Function
-GetGUIType Function
-GetProcessServiceManager 
Function
-GetPathSeparator 
Function
-GetSolarVersion 
Function
-GetSystemTicks 
Function
-Get Statement
-GlobalScope
-GoSub...Return 
Statement
-GoTo Statement
-Green Function
-HasUnoInterfaces 
Function
-Hex Function
-Hour Function
-IIf Statement
-If...Then...Else 
Statement
-Imp-Operator
-InStr Function
-InStrRev Function 
[VBA]
-Input Function [VBA]
-InputBox Function
-Input# Statement
-Int Function
-IPmt Function [VBA]
-IRR Function [VBA]
-IsArray Function
-IsDate Function
-Is

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df22ca830ca1e60dc4fb212bb5c7a528d208430b
Author: Olivier Hallot 
AuthorDate: Tue Nov 27 22:10:50 2018 -0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 28 10:48:08 2018 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - tdf#121736 initial Help pages for Python scripts

Work in progress, initial addition of help pages for python
scripts in LO.

Change-Id: Iee95b1340c821fdb08524fdedeca3817b0de1459
Reviewed-on: https://gerrit.libreoffice.org/64137
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 6c2abb860183..949606895b8d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6c2abb8601836f6bea02b7dfabba486208f2c6be
+Subproject commit 949606895b8d46fb97b0bfcda25cfb04f1f61e32
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: slideshow/CppunitTest_slideshow.mk slideshow/Module_slideshow.mk slideshow/source slideshow/test

 slideshow/CppunitTest_slideshow.mk |   15 -
 slideshow/Module_slideshow.mk  |5 
 slideshow/source/engine/slide/layermanager.cxx |   13 +
 slideshow/source/engine/slide/layermanager.hxx |6 
 slideshow/test/demoshow.cxx|4 
 slideshow/test/slidetest.cxx   |  209 +
 slideshow/test/tests.hxx   |4 
 slideshow/test/testshape.cxx   |   53 +++---
 slideshow/test/testview.cxx|   96 ++-
 slideshow/test/views.cxx   |   22 +-
 10 files changed, 228 insertions(+), 199 deletions(-)

New commits:
commit 3588c6c5cc862b099e0c09dcf88c450ff93a69ed
Author: Thorsten Behrens 
AuthorDate: Tue Sep 4 09:02:04 2018 +0200
Commit: Thorsten Behrens 
CommitDate: Wed Nov 28 10:09:32 2018 +0100

slideshow: get unit tests to work again

Change-Id: I7b5c7a20677ac0f720b41daf8ca59c3cc94f1283
Reviewed-on: https://gerrit.libreoffice.org/59964
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/slideshow/CppunitTest_slideshow.mk 
b/slideshow/CppunitTest_slideshow.mk
index f30c474ccbad..d72a0409d63b 100644
--- a/slideshow/CppunitTest_slideshow.mk
+++ b/slideshow/CppunitTest_slideshow.mk
@@ -9,29 +9,17 @@
 
 $(eval $(call gb_CppunitTest_CppunitTest,slideshow))
 
-$(eval $(call gb_CppunitTest_use_package,slideshow,sd_qa_unit))
-
 $(eval $(call gb_CppunitTest_set_include,slideshow,\
 $$(INCLUDE) \
 -I$(SRCDIR)/slideshow/source/inc \
 ))
 
-$(eval $(call gb_CppunitTest_set_defs,slideshow,\
-$$(DEFS) \
-))
-
-ifneq ($(strip $(debug)$(DEBUG)),)
-$(eval $(call gb_CppunitTest_set_defs,slideshow,\
-$$(DEFS) \
--DBOOST_SP_ENABLE_DEBUG_HOOKS \
-))
-endif
-
 $(eval $(call gb_CppunitTest_use_sdk_api,slideshow))
 
 $(eval $(call gb_CppunitTest_use_library_objects,slideshow,slideshow))
 
 $(eval $(call gb_CppunitTest_use_libraries,slideshow,\
+   $(call gb_Helper_optional,AVMEDIA,avmedia) \
 basegfx \
 canvastools \
 comphelper \
@@ -39,6 +27,7 @@ $(eval $(call gb_CppunitTest_use_libraries,slideshow,\
 cppu \
 cppuhelper \
 sal \
+salhelper \
 svt \
 tl \
 utl \
diff --git a/slideshow/Module_slideshow.mk b/slideshow/Module_slideshow.mk
index 8d98a97a2e90..e29dac11a913 100644
--- a/slideshow/Module_slideshow.mk
+++ b/slideshow/Module_slideshow.mk
@@ -19,8 +19,9 @@ $(eval $(call gb_Module_add_targets,slideshow,\
  ))
 endif
 
-# not working
-# CppunitTest_slideshow \
+$(eval $(call gb_Module_add_check_targets,slideshow,\
+   CppunitTest_slideshow \
+))
 
 # not built normally (and unbuildable anyway ;)
 # Executable_demoshow \
diff --git a/slideshow/source/engine/slide/layermanager.cxx 
b/slideshow/source/engine/slide/layermanager.cxx
index 333412d90029..b5235840c0a8 100644
--- a/slideshow/source/engine/slide/layermanager.cxx
+++ b/slideshow/source/engine/slide/layermanager.cxx
@@ -254,6 +254,19 @@ namespace slideshow
 notifyShapeUpdate( rShape );
 }
 
+bool LayerManager::removeShape( const ShapeSharedPtr& rShape )
+{
+// remove shape from XShape hash map
+if( maXShapeHash.erase( rShape->getXShape() ) == 0 )
+return false; // shape not in map
+
+OSL_ASSERT( maAllShapes.find(rShape) != maAllShapes.end() );
+
+implRemoveShape( rShape );
+
+return true;
+}
+
 void LayerManager::implRemoveShape( const ShapeSharedPtr& rShape )
 {
 OSL_ASSERT( !maLayers.empty() ); // always at least background 
layer
diff --git a/slideshow/source/engine/slide/layermanager.hxx 
b/slideshow/source/engine/slide/layermanager.hxx
index 9005cd9e96a8..b6a029c2bb2d 100644
--- a/slideshow/source/engine/slide/layermanager.hxx
+++ b/slideshow/source/engine/slide/layermanager.hxx
@@ -111,6 +111,12 @@ namespace slideshow
  */
 void addShape( const ShapeSharedPtr& rShape );
 
+/** Remove shape from this object
+
+This method removes a shape from the shape.
+ */
+bool removeShape( const ShapeSharedPtr& rShape );
+
 /** Lookup a Shape from an XShape model object
 
 This method looks up the internal shape map for one
diff --git a/slideshow/test/demoshow.cxx b/slideshow/test/demoshow.cxx
index fe3d29363942..0f3087b82bde 100644
--- a/slideshow/test/demoshow.cxx
+++ b/slideshow/test/demoshow.cxx
@@ -37,8 +37,8 @@
 #include 
 #include 
 #include 
-#include "com/sun/star/animations/TransitionType.hpp"
-#include "com/sun/star/animations/TransitionSubType.hpp"
+#include 
+#include 
 
 #include 
 #include 
diff --git a/slideshow/test/slidetest.cxx b/slideshow/test/slidetest.cxx
index 2804e79a77e0..7b3691a96ec2 100644
--- a/slideshow/test/slidetest.cxx
+++ b/slideshow/test/slidetest.cxx
@@ -18,22 +18,22 @@
  */
 
 #include 
-#include "cppunit/TestAssert.h"

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - officecfg/registry

 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ee62ef6fbd4ca2d140f0fc4730bb63575c47e5ca
Author: Caolán McNamara 
AuthorDate: Tue Nov 27 14:02:12 2018 +
Commit: Andras Timar 
CommitDate: Wed Nov 28 10:09:04 2018 +0100

tdf#90333 Dictionaries Path Cannot Be Changed

PathSettings::impl_storePath wants to be able to nil the Dictionaries
path in the old copy of properties

Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f
Reviewed-on: https://gerrit.libreoffice.org/64115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit f913bdf712b9e03506b1278e1142283af92125b1)
Reviewed-on: https://gerrit.libreoffice.org/64150
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 51c4ff4274a5..cc1c458fe834 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -1602,7 +1602,7 @@
   
   $(insturl)/@LIBO_SHARE_FOLDER@/config
 
-
+
   
 Contains the provided dictionaries.
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - officecfg/registry

 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 43f1c7d73829e3ef0a623cfeff2f560d6c21cfb2
Author: Caolán McNamara 
AuthorDate: Tue Nov 27 14:02:12 2018 +
Commit: Andras Timar 
CommitDate: Wed Nov 28 10:06:49 2018 +0100

tdf#90333 Dictionaries Path Cannot Be Changed

PathSettings::impl_storePath wants to be able to nil the Dictionaries
path in the old copy of properties

Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f
Reviewed-on: https://gerrit.libreoffice.org/64115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit f913bdf712b9e03506b1278e1142283af92125b1)

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index b1bc6d4b2ac4..108ceb01ec16 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -1596,7 +1596,7 @@
   
   $(insturl)/@LIBO_SHARE_FOLDER@/config
 
-
+
   
 Contains the provided dictionaries.
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: dbaccess/source editeng/source include/editeng include/svtools sc/source sfx2/source svtools/source ucb/source vcl/source vcl/unx writerfilter/source

 dbaccess/source/ui/dlg/dlgsize.cxx   |8 
 dbaccess/source/ui/inc/dlgsize.hxx   |2 +-
 editeng/source/rtf/svxrtf.cxx|3 +--
 include/editeng/svxrtf.hxx   |2 +-
 include/svtools/editbrowsebox.hxx|4 ++--
 sc/source/filter/xml/xmlimprt.hxx|6 --
 sc/source/filter/xml/xmltransformationi.cxx  |1 +
 sc/source/filter/xml/xmltransformationi.hxx  |1 -
 sfx2/source/view/sfxbasecontroller.cxx   |6 --
 svtools/source/brwbox/editbrowsebox.cxx  |   11 ++-
 ucb/source/ucp/file/bc.cxx   |3 +--
 ucb/source/ucp/file/filinsreq.cxx|9 -
 ucb/source/ucp/file/filinsreq.hxx|1 -
 ucb/source/ucp/file/filtask.cxx  |   15 ---
 ucb/source/ucp/file/filtask.hxx  |   11 ++-
 vcl/source/bitmap/BitmapScaleSuperFilter.cxx |6 ++
 vcl/unx/generic/dtrans/bmp.cxx   |   18 +-
 vcl/unx/generic/dtrans/bmp.hxx   |6 +++---
 writerfilter/source/ooxml/Handler.cxx|3 +--
 writerfilter/source/ooxml/Handler.hxx|2 +-
 20 files changed, 35 insertions(+), 83 deletions(-)

New commits:
commit ae25d5d3a333f58723eb9449cd3694cc0b80b3a6
Author: Noel Grandin 
AuthorDate: Tue Nov 27 10:22:37 2018 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 28 10:00:01 2018 +0100

loplugin:unusedfields

Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453
Reviewed-on: https://gerrit.libreoffice.org/64144
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/dlg/dlgsize.cxx 
b/dbaccess/source/ui/dlg/dlgsize.cxx
index 9ed623fc8003..aca0710c5fc7 100644
--- a/dbaccess/source/ui/dlg/dlgsize.cxx
+++ b/dbaccess/source/ui/dlg/dlgsize.cxx
@@ -30,20 +30,20 @@ DlgSize::DlgSize(weld::Window* pParent, sal_Int32 nVal, 
bool bRow, sal_Int32 _nA
 : GenericDialogController(pParent, bRow ? 
OUString("dbaccess/ui/rowheightdialog.ui") : 
OUString("dbaccess/ui/colwidthdialog.ui"),
   bRow ? OString("RowHeightDialog") : 
OString("ColWidthDialog"))
 , m_nPrevValue(nVal)
-, m_nStandard(bRow ? DEF_ROW_HEIGHT : DEF_COL_WIDTH)
 , m_xMF_VALUE(m_xBuilder->weld_metric_spin_button("value", FieldUnit::CM))
 , m_xCB_STANDARD(m_xBuilder->weld_check_button("automatic"))
 {
+sal_Int32 nStandard(bRow ? DEF_ROW_HEIGHT : DEF_COL_WIDTH);
 if ( _nAlternativeStandard > 0 )
-m_nStandard = _nAlternativeStandard;
+nStandard = _nAlternativeStandard;
 m_xCB_STANDARD->connect_toggled(LINK(this,DlgSize,CbClickHdl));
 
 bool bDefault = -1 == nVal;
 m_xCB_STANDARD->set_active(bDefault);
 if (bDefault)
 {
-SetValue(m_nStandard);
-m_nPrevValue = m_nStandard;
+SetValue(nStandard);
+m_nPrevValue = nStandard;
 }
 CbClickHdl(*m_xCB_STANDARD);
 }
diff --git a/dbaccess/source/ui/inc/dlgsize.hxx 
b/dbaccess/source/ui/inc/dlgsize.hxx
index 6e72490945fb..d71f0ff1c649 100644
--- a/dbaccess/source/ui/inc/dlgsize.hxx
+++ b/dbaccess/source/ui/inc/dlgsize.hxx
@@ -27,7 +27,7 @@ namespace dbaui
 class DlgSize final : public weld::GenericDialogController
 {
 private:
-sal_Int32   m_nPrevValue, m_nStandard;
+sal_Int32   m_nPrevValue;
 voidSetValue( sal_Int32 nVal );
 
 DECL_LINK(CbClickHdl, weld::ToggleButton&, void);
diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx
index eed91b25158f..78d726b86d51 100644
--- a/editeng/source/rtf/svxrtf.cxx
+++ b/editeng/source/rtf/svxrtf.cxx
@@ -315,7 +315,7 @@ void SvxRTFParser::ReadStyleTable()
 break;
 
 case RTF_SBASEDON:  pStyle->nBasedOn = sal_uInt16(nTokenValue); break;
-case RTF_SNEXT: pStyle->nNext = sal_uInt16(nTokenValue);break;
+case RTF_SNEXT: break;
 case RTF_OUTLINELEVEL:
 case RTF_SOUTLVL:   pStyle->nOutlineNo = sal_uInt8(nTokenValue);
break;
 case RTF_S: nStyleNo = static_cast(nTokenValue);
@@ -925,7 +925,6 @@ SvxRTFStyleType::SvxRTFStyleType( SfxItemPool& rPool, const 
sal_uInt16* pWhichRa
 {
 nOutlineNo = sal_uInt8(-1); // not set
 nBasedOn = 0;
-nNext = 0;
 }
 
 
diff --git a/include/editeng/svxrtf.hxx b/include/editeng/svxrtf.hxx
index 73634f515e97..c9dd555d6ebe 100644
--- a/include/editeng/svxrtf.hxx
+++ b/include/editeng/svxrtf.hxx
@@ -95,7 +95,7 @@ struct SvxRTFStyleType
 {
 SfxItemSet aAttrSet;// the attributes of Style (+ derivate!)
 OUString sName;
-sal_uInt16 nBasedOn, nNext;
+sal_uInt16 nBasedOn;
 sal_uInt8 nOutlineNo;
 
 SvxRTFStyleType( SfxItemPool& rPool, const sal_uInt16* pWhichRange );
diff --git a/include/svtools/editbrowsebox.hxx 
b/include/svtools/editbrowsebox.hxx
index d61cda9dba39..9080c6a4f617 100644
--- a/include/svtools/editbrowsebox.hxx
+++ b/include/s

Re: Compiler baselines


On 28/11/2018 09:52, Miklos Vajna wrote:

On Tue, Nov 27, 2018 at 05:05:47PM +0100, Stephan Bergmann 
 wrote:

That commit is 
"-Werror,-Wdeprecated-declarations
(--with-macosx-version-min-required=10.14)", and I had naively assumed that
Jenkins would do a baseline macOS build and flag any parts that were not
supported by the baseline.

And I'm not even sure what the minimum SDK we want to support should be.
IIUC, Xcode may provide SDK 10.y versions newer than the macOS 10.x on which
the build is done, and configure.ac will (by default) pick up the newer
-with-macosx-sdk=10.y then.  So README.md's "Build: 10.12 + Xcode 9.3" might
not necessarily imply that we support building against SDK 10.12 (again,
IIUC).

Anyway, I don't really care either way, whether to fix the commit if
necessary or to update the build baseline in README.md to macOS 10.13
or to clarify the SDK baseline in README.md.

Do we know of any build done in an environment that should be covered by our
baseline but which got broken by the above commit?


Collabora's mac builder runs 10.13, so if README.md is just adapted to
reality (require 10.13 instead of 10.12), that's fine for us.

It was just not clear to me, what should be fixed here: code or
documentation.


Neither is it clear to me, nor whether anything is actually broken (see 
explanation above).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] online.git: wsd/FileServer.cpp

 wsd/FileServer.cpp |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 8f1abe48397d7da4629fb50324289ad39102cfc7
Author: Samuel Mehrbrodt 
AuthorDate: Wed Nov 28 09:36:24 2018 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Nov 28 09:53:35 2018 +0100

Only add the host to frame-ancestors

not the whole URL with all parameters

Change-Id: I42e3a6a4c05410284afea51bb13ac3f692b243ef
Reviewed-on: https://gerrit.libreoffice.org/64147
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index 651654364..87f90e556 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -694,6 +694,9 @@ void FileServerRequestHandler::preprocessFile(const 
HTTPRequest& request, Poco::
 {
 std::string wopiFrameAncestor;
 Poco::URI::decode(param.second, wopiFrameAncestor);
+Poco::URI uriWopiFrameAncestor(wopiFrameAncestor);
+// Remove parameters from URL
+wopiFrameAncestor = uriWopiFrameAncestor.getHost();
 if (wopiFrameAncestor != uriHost.getHost() && wopiFrameAncestor != 
configFrameAncestor)
 {
 frameAncestors += " " + wopiFrameAncestor;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   >