[Libreoffice-bugs] [Bug 114144] Doubleclicking on an item of an input list in an ott doesn't open the next input list dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=114144 k-j changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121800] Missing images, formatting from Microsoft Publisher 2013 imported document
https://bugs.documentfoundation.org/show_bug.cgi?id=121800 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 CC||79045_79...@mail.ru Status|UNCONFIRMED |NEW --- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> --- repro in Version: 6.1.2.1 Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 4; OS: Windows 6.1; UI render: default; Locale: ru-RU (ru_RU); Calc: group threaded and in Version: 6.3.0.0.alpha0+ Build ID: f21d2b48bd68424a96aa6cd5572e368208378291 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-11-27_00:26:54 Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114144] Doubleclicking on an item of an input list in an ott doesn't open the next input list dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=114144 --- Comment #4 from k-j --- Still exists until: Version: 6.2.0.0.beta1 (x64) Build-ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121800] Missing images, formatting from Microsoft Publisher 2013 imported document
https://bugs.documentfoundation.org/show_bug.cgi?id=121800 --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 147164 --> https://bugs.documentfoundation.org/attachment.cgi?id=147164=edit Original PUB file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121800] Missing images, formatting from Microsoft Publisher 2013 imported document
https://bugs.documentfoundation.org/show_bug.cgi?id=121800 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 147163 --> https://bugs.documentfoundation.org/attachment.cgi?id=147163=edit Original view (PDF) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121803] Added the function of "up and down split" and "left and right split" in the "Toolbar"
https://bugs.documentfoundation.org/show_bug.cgi?id=121803 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121803] Added the function of "up and down split" and "left and right split" in the "Toolbar"
https://bugs.documentfoundation.org/show_bug.cgi?id=121803 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120727] Excessive CPU usage under normal use (typing)
https://bugs.documentfoundation.org/show_bug.cgi?id=120727 --- Comment #7 from laur...@norbit.no --- (In reply to Alex Thurgood from comment #3) > @laurens : how many fonts are installed on your system ? > > The test document shows a style at the bottom in the status bar that is > called "First convert 1" - has this document been converted from a previous > other format? I also happens with "fresh" documents I have noticed this with multiple documents on multiple retina mac systems: If I change the object Anchor from "to paragraph" -> ""as character" the CPU usage whilst typing (with the object on the page) DROPS from 50% to 8-15%!! Scrolling through my documents is also much smoother when changing all frames from Anchor "to paragraph" -> "as character" I hope that this helps with sorting out this bug - I think that more people have this issue (https://www.reddit.com/r/libreoffice/comments/94n2e3/libreoffice_so_slow_its_almost_unusable_on_mac/) 1. Can someone understand why / fix? 2. Add default for insertion of new frames to be Anchor-> As character. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Keywords|needsUXEval | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Keywords|needsUXEval | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source filter/source fpicker/source include/vcl sc/source sfx2/source svtools/source svx/source sw/source vcl/source
cui/source/options/dbregister.cxx |4
cui/source/options/optcolor.cxx |2
cui/source/options/optfltr.cxx|2
cui/source/options/optpath.cxx|4
cui/source/options/webconninfo.cxx|4
cui/source/tabpages/autocdlg.cxx |4
filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |6 -
fpicker/source/office/PlacesListBox.cxx |2
include/vcl/headbar.hxx | 11 --
sc/source/ui/condformat/condformatmgr.cxx |2
sc/source/ui/miscdlgs/conflictsdlg.cxx|2
sc/source/ui/miscdlgs/sharedocdlg.cxx |2
sfx2/source/dialog/dinfdlg.cxx|2
svtools/source/brwbox/editbrowsebox.cxx |2
svtools/source/contnr/fileview.cxx|2
svx/source/fmcomp/gridctrl.cxx|2
svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx |2
sw/source/ui/dbui/mmaddressblockpage.cxx |2
sw/source/ui/dbui/mmoutputtypepage.cxx|4
sw/source/ui/dbui/selectdbtabledialog.cxx |2
vcl/source/treelist/headbar.cxx | 50
++
21 files changed, 40 insertions(+), 73 deletions(-)
New commits:
commit 799f159ac00ca155275aebd930f538a1924ca471
Author: Noel Grandin
AuthorDate: Thu Nov 29 21:09:27 2018 +0200
Commit: Noel Grandin
CommitDate: Fri Nov 30 08:40:08 2018 +0100
remove unused HeaderBarItemBits enum values
Change-Id: I84752cb9d683cb22c96d91cc54d7c4dc474603fc
Reviewed-on: https://gerrit.libreoffice.org/64269
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/cui/source/options/dbregister.cxx
b/cui/source/options/dbregister.cxx
index 18405c4a97ff..ebd641bb628d 100644
--- a/cui/source/options/dbregister.cxx
+++ b/cui/source/options/dbregister.cxx
@@ -132,11 +132,11 @@ DbRegistrationOptionsPage::DbRegistrationOptionsPage(
vcl::Window* pParent, cons
aSz.setWidth( TAB_WIDTH1 );
rBar.InsertItem( ITEMID_TYPE, CuiResId( RID_SVXSTR_TYPE ),
LogicToPixel( aSz, MapMode( MapUnit::MapAppFont )
).Width(),
-HeaderBarItemBits::LEFT |
HeaderBarItemBits::VCENTER | HeaderBarItemBits::CLICKABLE |
HeaderBarItemBits::UPARROW );
+HeaderBarItemBits::LEFT |
HeaderBarItemBits::CLICKABLE | HeaderBarItemBits::UPARROW );
aSz.setWidth( TAB_WIDTH2 );
rBar.InsertItem( ITEMID_PATH, CuiResId( RID_SVXSTR_PATH ),
LogicToPixel( aSz, MapMode( MapUnit::MapAppFont )
).Width(),
-HeaderBarItemBits::LEFT |
HeaderBarItemBits::VCENTER );
+HeaderBarItemBits::LEFT );
static long aTabs[] = {0, TAB_WIDTH1, TAB_WIDTH1 + TAB_WIDTH2 };
Size aHeadSize = rBar.GetSizePixel();
diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index 296d6c19e3b9..d2ad30ab52b8 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -840,7 +840,7 @@ void ColorConfigCtrl_Impl::InitHeaderBar(const OUString
, const OUString
const OUString )
{
// filling
-const HeaderBarItemBits nHeadBits = HeaderBarItemBits::VCENTER |
HeaderBarItemBits::FIXED | HeaderBarItemBits::FIXEDPOS;
+const HeaderBarItemBits nHeadBits = HeaderBarItemBits::FIXED |
HeaderBarItemBits::FIXEDPOS;
m_pHeaderHB->InsertItem(1, rOn, 0, nHeadBits | HeaderBarItemBits::CENTER);
m_pHeaderHB->InsertItem(2, rUIElems, 0, nHeadBits |
HeaderBarItemBits::LEFT);
m_pHeaderHB->InsertItem(3, rColorSetting, 0, nHeadBits |
HeaderBarItemBits::LEFT);
diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index 3d8b2fa04c52..611af717eae9 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -167,7 +167,7 @@ OfaMSFilterTabPage2::OfaMSFilterTabPage2( vcl::Window*
pParent, const SfxItemSet
OUString sHeader = sHeader1 + "\t" + sHeader2 + "\t";
m_pCheckLB->InsertHeaderEntry( sHeader, HEADERBAR_APPEND,
-HeaderBarItemBits::CENTER | HeaderBarItemBits::VCENTER |
HeaderBarItemBits::FIXEDPOS | HeaderBarItemBits::FIXED );
+HeaderBarItemBits::CENTER | HeaderBarItemBits::FIXEDPOS |
HeaderBarItemBits::FIXED );
m_pCheckLB->SetStyle( m_pCheckLB->GetStyle()|WB_HSCROLL| WB_VSCROLL );
}
diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx
index
[Libreoffice-bugs] [Bug 121810] Firebird: Migration: Crash in: libgobject-2.0.so.0.5600.3 when selecting more on error dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=121810 Julien Nabet changed: What|Removed |Added Summary|Firebrd: Migration: Crash |Firebird: Migration: Crash |in: |in: |libgobject-2.0.so.0.5600.3 |libgobject-2.0.so.0.5600.3 |when selecting more on |when selecting more on |error dialog|error dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: test/test.cpp
test/test.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 84d224d995c8a08d6ae9d5f8a712e2f353a8b388
Author: Miklos Vajna
AuthorDate: Fri Nov 30 08:37:50 2018 +0100
Commit: Miklos Vajna
CommitDate: Fri Nov 30 08:38:00 2018 +0100
test: no need to copy procEntry
Change-Id: Iac7bca9ebcf104975d01bcd1cdfe8e0f4d2a742e
diff --git a/test/test.cpp b/test/test.cpp
index 4a4ba9421..f09e1f855 100644
--- a/test/test.cpp
+++ b/test/test.cpp
@@ -154,7 +154,7 @@ std::vector getProcPids(const char* exec_filename,
bool ignoreZombies = fal
{
try
{
-Poco::Path procEntry = it.path();
+const Poco::Path& procEntry = it.path();
const std::string& fileName = procEntry.getFileName();
int pid;
std::size_t endPos = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/bin starmath/source starmath/util
solenv/bin/native-code.py|1 +
starmath/source/mathmlimport.cxx | 22 +-
starmath/source/register.cxx |9 +
starmath/source/register.hxx |7 ---
starmath/util/sm.component |3 ++-
5 files changed, 9 insertions(+), 33 deletions(-)
New commits:
commit f8325dd3ea14a4766cd2bb7c0249338b59c2ed28
Author: Miklos Vajna
AuthorDate: Thu Nov 29 21:34:51 2018 +0100
Commit: Miklos Vajna
CommitDate: Fri Nov 30 08:37:00 2018 +0100
starmath: create XMLOasisSettingsImporter instances with an uno constructor
Change-Id: I92c8991baf10fde574d06ab0870bbb26a7632e65
Reviewed-on: https://gerrit.libreoffice.org/64284
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 345ebb9a8e1f..c3cc2b1f0edb 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -281,6 +281,7 @@ edit_constructor_list = [
"Math_XMLOasisSettingsExporter_get_implementation",
"Math_XMLImporter_get_implementation",
"Math_XMLOasisMetaImporter_get_implementation",
+"Math_XMLOasisSettingsImporter_get_implementation",
# sw/util/sw.component
"com_sun_star_comp_Writer_XMLOasisContentExporter_get_implementation",
"com_sun_star_comp_Writer_XMLOasisMetaExporter_get_implementation",
diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index fcf3ebb21b48..4db3dfef7fdf 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -79,9 +79,6 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star;
using namespace ::xmloff::token;
-
-#define IMPORT_SVC_NAME "com.sun.star.xml.XMLImportFilter"
-
namespace {
SmNode* popOrZero(SmNodeStack& rStack)
@@ -450,21 +447,12 @@
Math_XMLOasisMetaImporter_get_implementation(uno::XComponentContext* pCtx,
SvXMLImportFlags::META));
}
-OUString SmXMLImportSettings_getImplementationName() throw()
-{
-return OUString( "com.sun.star.comp.Math.XMLOasisSettingsImporter" );
-}
-
-uno::Sequence< OUString > SmXMLImportSettings_getSupportedServiceNames()
-throw()
-{
-return uno::Sequence{ IMPORT_SVC_NAME };
-}
-
-uno::Reference< uno::XInterface > SmXMLImportSettings_createInstance(
-const uno::Reference< lang::XMultiServiceFactory > & rSMgr)
+extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
+Math_XMLOasisSettingsImporter_get_implementation(uno::XComponentContext* pCtx,
+ uno::Sequence
const& /*rSeq*/)
{
-return static_cast(new SmXMLImport(
comphelper::getComponentContext(rSMgr),
SmXMLImportSettings_getImplementationName(), SvXMLImportFlags::SETTINGS ));
+return cppu::acquire(new SmXMLImport(pCtx,
"com.sun.star.comp.Math.XMLOasisSettingsImporter",
+ SvXMLImportFlags::SETTINGS));
}
sal_Int64 SAL_CALL SmXMLImport::getSomething(
diff --git a/starmath/source/register.cxx b/starmath/source/register.cxx
index e3bfe9f79e5b..3e06241484c3 100644
--- a/starmath/source/register.cxx
+++ b/starmath/source/register.cxx
@@ -46,14 +46,7 @@ SAL_DLLPUBLIC_EXPORT void* sm_component_getFactory( const
sal_Char* pImplementat
Reference< XSingleServiceFactory > xFactory
;
Reference< XMultiServiceFactory >xServiceManager( static_cast<
XMultiServiceFactory* >( pServiceManager ) ) ;
-if
(SmXMLImportSettings_getImplementationName().equalsAscii(pImplementationName))
-{
-xFactory = ::cppu::createSingleFactory( xServiceManager,
-SmXMLImportSettings_getImplementationName(),
-SmXMLImportSettings_createInstance,
-SmXMLImportSettings_getSupportedServiceNames() );
-}
-else if( SmDocument_getImplementationName().equalsAscii(
pImplementationName ))
+if
(SmDocument_getImplementationName().equalsAscii(pImplementationName))
{
xFactory = ::sfx2::createSfxModelFactory( xServiceManager,
SmDocument_getImplementationName(),
diff --git a/starmath/source/register.hxx b/starmath/source/register.hxx
index cad881135d63..be875fbeccb0 100644
--- a/starmath/source/register.hxx
+++ b/starmath/source/register.hxx
@@ -32,13 +32,6 @@ OUString
css::uno::Reference< css::uno::XInterface >
SmDocument_createInstance(const css::uno::Reference<
css::lang::XMultiServiceFactory > & rSMgr, SfxModelFlags _nCreationFlags);
-css::uno::Sequence< OUString >
-SmXMLImportSettings_getSupportedServiceNames() throw();
-OUString SmXMLImportSettings_getImplementationName() throw();
-/// @throws css::uno::Exception
-css::uno::Reference< css::uno::XInterface >
-SmXMLImportSettings_createInstance(const css::uno::Reference<
css::lang::XMultiServiceFactory > & rSMgr);
-
#endif
/* vim:set
[Libreoffice-bugs] [Bug 121759] Doesn't active menu item Insert->Headers and Footers in Calc 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121759 Heiko Tietze changed: What|Removed |Added Keywords||needsUXEval CC|tietze.he...@gmail.com |libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #11 from Heiko Tietze --- (In reply to Samuel Mehrbrodt (CIB) from comment #10) > (In reply to Heiko Tietze from comment #7) > > We could move the menu entry to Edit, where it is actually better suited > > anyway. By doing so it's more clear that no header/footer has been enabled > > to be edited. > > How does the user know where he enables the header and footer? This needs to > be integrated into the header/footer dialog somehow before we disable them > by default. Added the UX list, and to summarize the issue is about a disabled menu entry in Calc after switching off Header/Footer by default at the page dialog. Actually I don't see this as a big issue. It was the same before with the little difference that the user switched H/F off manually. Okay, it's a big difference. But still, it's more or less the same in all other modules where you first have to enable H/F. By moving the disabled option to the Edit menu it becomes more clear that this dialog does not Insert. The alternative is somewhat like kompilainenn suggested in bug 121777 and I doubt it's easier to understand. Unfortunately the topic is urgent as the patch went into 6.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121759] Doesn't active menu item Insert->Headers and Footers in Calc 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121759 Heiko Tietze changed: What|Removed |Added Keywords||needsUXEval CC|tietze.he...@gmail.com |libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #11 from Heiko Tietze --- (In reply to Samuel Mehrbrodt (CIB) from comment #10) > (In reply to Heiko Tietze from comment #7) > > We could move the menu entry to Edit, where it is actually better suited > > anyway. By doing so it's more clear that no header/footer has been enabled > > to be edited. > > How does the user know where he enables the header and footer? This needs to > be integrated into the header/footer dialog somehow before we disable them > by default. Added the UX list, and to summarize the issue is about a disabled menu entry in Calc after switching off Header/Footer by default at the page dialog. Actually I don't see this as a big issue. It was the same before with the little difference that the user switched H/F off manually. Okay, it's a big difference. But still, it's more or less the same in all other modules where you first have to enable H/F. By moving the disabled option to the Edit menu it becomes more clear that this dialog does not Insert. The alternative is somewhat like kompilainenn suggested in bug 121777 and I doubt it's easier to understand. Unfortunately the topic is urgent as the patch went into 6.2. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/test/unusedenumconstants.cxx | 22
compilerplugins/clang/unusedenumconstants.cxx | 20
compilerplugins/clang/unusedenumconstants.py|5
compilerplugins/clang/unusedenumconstants.readonly.results | 640
compilerplugins/clang/unusedenumconstants.untouched.results | 188 -
compilerplugins/clang/unusedenumconstants.writeonly.results | 1544 +---
6 files changed, 897 insertions(+), 1522 deletions(-)
New commits:
commit 3b48c9452778cf822a8cd1defb614c1010d7b9f8
Author: Noel Grandin
AuthorDate: Thu Nov 29 16:00:51 2018 +0200
Commit: Noel Grandin
CommitDate: Fri Nov 30 08:33:15 2018 +0100
loplugin:unusedenumconstants ignore common pattern
Ignore a common pattern that does not introduce any new information,
merely removes information.
Change-Id: I37da352c9295ec12b9dac7aad4b4792a6d726b0d
Reviewed-on: https://gerrit.libreoffice.org/64255
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/test/unusedenumconstants.cxx
b/compilerplugins/clang/test/unusedenumconstants.cxx
index 76027b8e8481..31c2cb1dac55 100644
--- a/compilerplugins/clang/test/unusedenumconstants.cxx
+++ b/compilerplugins/clang/test/unusedenumconstants.cxx
@@ -81,6 +81,8 @@ struct Test4 : public Test4Base
};
};
+//---
+
// check that conditional operator walks up the tree
namespace test5
{
@@ -93,4 +95,24 @@ enum Enum
Enum foo(int x) { return x == 1 ? Enum::ONE : Enum::TWO; }
};
+//---
+// Ignore a common pattern that does not introduce any new information, merely
removes
+// information.
+enum class Enum6
+{
+Modules = 0x01, // expected-error {{write Modules
[loplugin:unusedenumconstants]}}
+Top = 0x02,
+};
+namespace o3tl
+{
+template <> struct typed_flags : is_typed_flags
+{
+};
+}
+void test6()
+{
+Enum6 foo = Enum6::Modules;
+foo &= ~Enum6::Top;
+};
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/unusedenumconstants.cxx
b/compilerplugins/clang/unusedenumconstants.cxx
index 80f40d69a1a1..d617f3f0d3a8 100644
--- a/compilerplugins/clang/unusedenumconstants.cxx
+++ b/compilerplugins/clang/unusedenumconstants.cxx
@@ -174,12 +174,24 @@ walk_up:
else if (const CXXOperatorCallExpr * operatorCall =
dyn_cast(parent))
{
auto oo = operatorCall->getOperator();
-// if assignment op
-if (oo == OO_Equal || oo == OO_StarEqual || oo == OO_SlashEqual || oo
== OO_PercentEqual
+if (oo == OO_AmpEqual)
+{
+// Ignore a common pattern that does not introduce any new
information, merely removes
+// information: foo &= ~Enum6::Top
+bool found = false;
+if (auto innerOperatorCall =
dyn_cast(operatorCall->getArg(1)))
+{
+found = innerOperatorCall->getOperator() == OO_Tilde;
+}
+if (!found)
+bWrite = true;
+}
+// if assignment op
+else if (oo == OO_Equal || oo == OO_StarEqual || oo == OO_SlashEqual
|| oo == OO_PercentEqual
|| oo == OO_PlusEqual || oo == OO_MinusEqual || oo ==
OO_LessLessEqual
- || oo == OO_AmpEqual || oo == OO_CaretEqual || oo == OO_PipeEqual)
+ || oo == OO_CaretEqual || oo == OO_PipeEqual)
bWrite = true;
-// else if comparison op
+// else if comparison op
else if (oo == OO_AmpAmp || oo == OO_PipePipe || oo == OO_Subscript
|| oo == OO_Less || oo == OO_Greater || oo == OO_LessEqual || oo
== OO_GreaterEqual || oo == OO_EqualEqual || oo == OO_ExclaimEqual)
bRead = true;
diff --git a/compilerplugins/clang/unusedenumconstants.py
b/compilerplugins/clang/unusedenumconstants.py
index 24cd0c6ded07..591c73f1cede 100755
--- a/compilerplugins/clang/unusedenumconstants.py
+++ b/compilerplugins/clang/unusedenumconstants.py
@@ -105,6 +105,11 @@ def is_ignore(srcLoc):
"sc/source/filter/inc/flttypes.hxx", # BiffTyp
"sc/inc/optutil.hxx", # ScOptionsUtil::KeyBindingType
"include/sfx2/chalign.hxx", # SfxChildAlignment
+ "drawinglayer/source/tools/emfpbrush.hxx",
+ "drawinglayer/source/tools/emfppen.cxx",
+ "include/oox/ppt/animationspersist.hxx",
+ "include/vcl/fontcapabilities.hxx",
+ "sw/inc/poolfmt.hxx",
# unit test code
"cppu/source/uno/check.cxx",
# general weird nonsense going on
diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results
b/compilerplugins/clang/unusedenumconstants.readonly.results
index a54619908b6d..3b2fb2b172ce 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - oox/source
oox/source/drawingml/chart/seriesconverter.cxx | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
New commits:
commit ef921ee138d563706bd2f3edeb13f737fabe03ec
Author: Markus Mohrhard
AuthorDate: Fri Nov 30 00:45:57 2018 +0100
Commit: Markus Mohrhard
CommitDate: Fri Nov 30 08:30:52 2018 +0100
tdf#121282, tdf#121279, set text properties also on complex data labels
Change-Id: I2304b6050b786b6e4a9a8a968d7a4846d9da8be8
Reviewed-on: https://gerrit.libreoffice.org/64306
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
(cherry picked from commit 6a04b9298ae993881d20fc4b5aa91516d4df6695)
Reviewed-on: https://gerrit.libreoffice.org/64308
diff --git a/oox/source/drawingml/chart/seriesconverter.cxx
b/oox/source/drawingml/chart/seriesconverter.cxx
index 241b8a4e506a..716a0b234bdd 100644
--- a/oox/source/drawingml/chart/seriesconverter.cxx
+++ b/oox/source/drawingml/chart/seriesconverter.cxx
@@ -124,6 +124,14 @@ Reference< XLabeledDataSequence >
lclCreateLabeledDataSequence(
return xLabeledSeq;
}
+void convertTextProperty(PropertySet& rPropSet, ObjectFormatter& rFormatter,
+DataLabelModelBase::TextBodyRef xTextProps)
+{
+rFormatter.convertTextFormatting( rPropSet, xTextProps,
OBJECTTYPE_DATALABEL );
+ObjectFormatter::convertTextRotation( rPropSet, xTextProps, false );
+ObjectFormatter::convertTextWrap( rPropSet, xTextProps );
+}
+
void lclConvertLabelFormatting( PropertySet& rPropSet, ObjectFormatter&
rFormatter,
const DataLabelModelBase& rDataLabel, const
TypeGroupConverter& rTypeGroup,
bool bDataSeriesLabel, bool bMSO2007Doc, const
PropertySet* pSeriesPropSet )
@@ -171,10 +179,7 @@ void lclConvertLabelFormatting( PropertySet& rPropSet,
ObjectFormatter& rFormatt
rFormatter.convertNumberFormat( rPropSet, rDataLabel.maNumberFormat,
false, bShowPercent );
// data label text formatting (frame formatting not supported by
Chart2)
-rFormatter.convertTextFormatting( rPropSet, rDataLabel.mxTextProp,
OBJECTTYPE_DATALABEL );
-ObjectFormatter::convertTextRotation( rPropSet, rDataLabel.mxTextProp,
false );
-ObjectFormatter::convertTextWrap( rPropSet, rDataLabel.mxTextProp );
-
+convertTextProperty(rPropSet, rFormatter, rDataLabel.mxTextProp);
// data label separator (do not overwrite series separator, if no
explicit point separator is present)
if( bDataSeriesLabel || rDataLabel.moaSeparator.has() )
@@ -338,6 +343,7 @@ void DataLabelConverter::convertFromModel( const Reference<
XDataSeries >& rxDat
}
aPropSet.setProperty( PROP_CustomLabelFields, makeAny( aSequence )
);
+convertTextProperty(aPropSet, getFormatter(),
mrModel.mxText->mxTextBody);
}
}
catch( Exception& )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/boost include/o3tl include/rtl include/vcl
external/boost/clang-cl.patch.0 |4 ++--
external/boost/msvc2017.patch.0 |8
include/o3tl/string_view.hxx| 11 +--
include/rtl/stringutils.hxx | 13 +
include/vcl/vclptr.hxx |6 --
5 files changed, 8 insertions(+), 34 deletions(-)
New commits:
commit 83102e4fa21e22ae18d2bbd19e29b1d37f50bab9
Author: Stephan Bergmann
AuthorDate: Thu Nov 29 13:45:27 2018 +0100
Commit: Stephan Bergmann
CommitDate: Fri Nov 30 08:25:13 2018 +0100
Remove obsolete _MSC_VER checks
...after 206b8c4ae320d7d8614f21800d8f77fa29f8f5ff "On Windows, check for at
least Visual Studio 2017 version 15.7"
Change-Id: I38ee86e1649bbdc828a7e328f2dbbac0dc163c8a
Reviewed-on: https://gerrit.libreoffice.org/64250
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/external/boost/clang-cl.patch.0 b/external/boost/clang-cl.patch.0
index 3990f27eb3f5..e563c637e2c3 100644
--- a/external/boost/clang-cl.patch.0
+++ b/external/boost/clang-cl.patch.0
@@ -5,7 +5,7 @@
// that an Output Iterator have output_iterator_tag in its iterator_category
if
// that iterator is not bidirectional_iterator or random_access_iterator.
-#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600)
-+#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600) || (defined __clang__ &&
BOOST_WORKAROUND(_MSC_VER, >= 1600))
++#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600) || defined __clang__
struct mutable_iterator_tag
: boost::random_access_traversal_tag, std::input_iterator_tag
{
@@ -14,7 +14,7 @@
// iterator support
//
-#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600)
-+#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600) || (defined __clang__ &&
BOOST_WORKAROUND(_MSC_VER, >= 1600))
++#if BOOST_WORKAROUND(BOOST_MSVC, >= 1600) || defined __clang__
// Deal with VC 2010 output_iterator_tag requirement
typedef array_iterator,reference,
mutable_iterator_tag> iterator;
diff --git a/external/boost/msvc2017.patch.0 b/external/boost/msvc2017.patch.0
index 525f3c95cbab..e888fd96aba4 100644
--- a/external/boost/msvc2017.patch.0
+++ b/external/boost/msvc2017.patch.0
@@ -4,7 +4,7 @@
// Helper types
//! Base iterator.
-+#if defined _MSC_VER && !defined __clang__ && _MSC_VER >= 1914
++#if defined _MSC_VER && !defined __clang__
+#pragma warning(push)
+#pragma warning(disable: 4996)
+#endif
@@ -14,7 +14,7 @@
typename Traits::difference_type,
typename Traits::pointer,
typename Traits::reference> base_iterator;
-+#if defined _MSC_VER && !defined __clang__ && _MSC_VER >= 1914
++#if defined _MSC_VER && !defined __clang__
+#pragma warning(pop)
+#endif
@@ -26,12 +26,12 @@
namespace boost
{
-+#if defined _MSC_VER && !defined __clang__ && _MSC_VER >= 1914
++#if defined _MSC_VER && !defined __clang__
+#pragma warning(push)
+#pragma warning(disable: 4996)
+#endif
using std::iterator;
-+#if defined _MSC_VER && !defined __clang__ && _MSC_VER >= 1914
++#if defined _MSC_VER && !defined __clang__
+#pragma warning(pop)
+#endif
diff --git a/include/o3tl/string_view.hxx b/include/o3tl/string_view.hxx
index bdc81e8d7261..4da7fcf0bf0f 100644
--- a/include/o3tl/string_view.hxx
+++ b/include/o3tl/string_view.hxx
@@ -177,16 +177,7 @@ public:
#if HAVE_CXX14_CONSTEXPR
constexpr
#endif
-basic_string_view & operator =(basic_string_view const & other) noexcept
-#if defined _MSC_VER && _MSC_VER <= 1900 && !defined __clang__
-{
-data_ = other.data_;
-size_ = other.size_;
-return *this;
-}
-#else
-= default;
-#endif
+basic_string_view & operator =(basic_string_view const & other) noexcept =
default;
// The various character types are handled below in the "LO specifics, to
// make up for traits::length not necessarily being constexpr yet for
diff --git a/include/rtl/stringutils.hxx b/include/rtl/stringutils.hxx
index f7cd0ad1a47d..7e9ff1cc86fd 100644
--- a/include/rtl/stringutils.hxx
+++ b/include/rtl/stringutils.hxx
@@ -65,12 +65,7 @@ namespace rtl
Instances of OUStringLiteral1 need to be const, as those literal-optimized
functions take the literal argument by non-const lvalue reference, for
-technical reasons. Except with MSVC, at least up to Visual Studio 2013:
-For one, it fails to take that const-ness into account when trying to match
-"OUStringLiteral1_ const" against T in a "T & literal" parameter of a
-function template. But for another, as a language extension, it allows to
-bind non-const temporary OUStringLiteral1_ instances to non-const lvalue
-references, but also with a warning that thus needs to be disabled.
+technical reasons.
@since LibreOffice 5.0
*/
@@ -78,13 +73,7 @@ struct SAL_WARN_UNUSED OUStringLiteral1_ {
constexpr OUStringLiteral1_(sal_Unicode theC): c(theC) {}
sal_Unicode const c;
};
-#if defined _MSC_VER && _MSC_VER <= 1900 && !defined __clang__
-// Visual Studio 2015
-using
[Libreoffice-bugs] [Bug 121811] Paste location program
https://bugs.documentfoundation.org/show_bug.cgi?id=121811 --- Comment #2 from 和尚蟹 --- Created attachment 147162 --> https://bugs.documentfoundation.org/attachment.cgi?id=147162=edit 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121811] Paste location program
https://bugs.documentfoundation.org/show_bug.cgi?id=121811 --- Comment #1 from 和尚蟹 --- Created attachment 147161 --> https://bugs.documentfoundation.org/attachment.cgi?id=147161=edit 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/workwin.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit f3ea5e21bea80004b04edbf0287d4a2e1aaef5d0
Author: Mike Kaganski
AuthorDate: Thu Nov 29 21:18:57 2018 +0100
Commit: Mike Kaganski
CommitDate: Fri Nov 30 08:10:57 2018 +0100
Revert "Revert "Notebookbar:Disabled appearence of context toolbars""
This reverts commit 9a6169529eb687190531225bfe9fef850325ee9e now
that proper fix for both tdf#121591 and tdf#119945 is pushed -
see commit 0a36be3fee1b4f1b47b55a64668b6aa99896ab24.
Change-Id: Ia44510d427e0626a5f566210247db8848653f8e2
Reviewed-on: https://gerrit.libreoffice.org/64279
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index 5320d832b13a..b7f6eddd9777 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -55,6 +55,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
@@ -1203,7 +1204,7 @@ void SfxWorkWindow::UpdateObjectBars_Impl2()
// Is a ToolBox required in this context ?
bool bModesMatching = (nUpdateMode != SfxVisibilityFlags::Invisible)
&& ((nTbxMode & nUpdateMode) == nUpdateMode);
-if ( bDestroy )
+if ( bDestroy || sfx2::SfxNotebookBar::IsActive())
{
OUString aTbxId = g_aTbxTypeName +
GetResourceURLFromToolbarId(eId);
xLayoutManager->destroyElement( aTbxId );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121759] Doesn't active menu item Insert->Headers and Footers in Calc 6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=121759 --- Comment #10 from Samuel Mehrbrodt (CIB) --- (In reply to Heiko Tietze from comment #7) > We could move the menu entry to Edit, where it is actually better suited > anyway. By doing so it's more clear that no header/footer has been enabled > to be edited. How does the user know where he enables the header and footer? This needs to be integrated into the header/footer dialog somehow before we disable them by default. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121811] New: Paste location program
https://bugs.documentfoundation.org/show_bug.cgi?id=121811 Bug ID: 121811 Summary: Paste location program Product: LibreOffice Version: 6.1.3.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pp887...@gmail.com Description: At present, the design of the position of the pattern is in the position of the original pattern, and this design has problems. E.g: Draw a square, then "Copy + Paste", you will find the copied square, in the same position. problem: Because sometimes, when the left mouse button is pressed 1 times, it will become 2 times, which is equivalent to copying 2 times, so copying 2 times in the same position, the user will not know. Paste the location program: ◎, "copy pattern horizontal position" + "horizontal distance" (0.5cm) = "posted horizontal position" ◎, "copy pattern vertical position" + "vertical distance" (0.5cm) = "posted vertical position" ◎, moving the "Paste on the pattern" will change the "horizontal distance" and "vertical distance". 1. “Paste the pattern”, move to the left to reduce the “horizontal distance”, and move to the right to increase the “horizontal distance”. 2, "Paste the pattern", move up to reduce the "vertical distance", move down to increase the "vertical distance". 3, this function, can be arranged with the same distance, very easy to use. Note: 1. Click the left mouse button to select the pattern and the “Place Location Program” will be enabled. 2, leaving the "Paste on the pattern", will close the "post position program". Actual operation: ◎, "Copying the horizontal position of the pattern" (2cm) ◎, "Copying the vertical position of the pattern" (1cm) ◎, "horizontal distance" (0.5cm) ◎, "vertical distance" (0.5cm) step 1 Click the left mouse button to select the pattern, it will open the "post position program". Then press the "Copy" button. Step 2 Press the "Paste" button for the first time. ※, "Copying pattern horizontal position" (2cm) + "horizontal distance" (0.5cm) = "posted horizontal position" (2.5cm) ※, "Copying the vertical position of the pattern" (1cm) + "Vertical distance" (0.5cm) = "Vertical position attached" (1.5cm) Step 3 Move the first "posted pattern" to the right by 3.5cm: ◎, "Copy the horizontal position of the pattern", it will become 6cm (2.5cm + 3.5cm = 6cm). ◎, "horizontal distance" will become 4cm (0.5 cm +3.5 cm = 4 cm). Press the "Paste" button for the second time. ※, "Copying pattern horizontal position" (6cm) + "horizontal distance" (4cm) = "posted horizontal position" (10cm) ※, "Copying the vertical position of the pattern" (1.5cm) + "Vertical distance" (0.5cm) = "Vertical position attached" (2cm) Step 4 Leaving the "Paste on" will close the "Paste Location Program". Writer, Calc, Impress, Draw, Math, Base, all use this design. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source
basic/source/classes/sbunoobj.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 597aeaf7a9c02153ca7006eb4c0263f1a15dad3d Author: Andrea Gelmini AuthorDate: Thu Nov 29 17:09:29 2018 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Fri Nov 30 07:51:17 2018 +0100 Fix typo Change-Id: I028e5462e9785bac77a98d09f0bf91b4da67e477 Reviewed-on: https://gerrit.libreoffice.org/64263 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx index 961c1a7f52e1..21e57c5d206b 100644 --- a/basic/source/classes/sbunoobj.cxx +++ b/basic/source/classes/sbunoobj.cxx @@ -3078,7 +3078,7 @@ void RTL_Impl_HasInterfaces( SbxArray& rPar ) } } -// Every thing works; then return TRUE +// Everything works; then return TRUE refVar->PutBool( true ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
https://bugs.documentfoundation.org/show_bug.cgi?id=82984 --- Comment #10 from Andreas Reichel --- This bug is still valid in LibreOffice Version: 6.1.3.2 (CPU threads: 16; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: threaded). I have created 2 files with the same content using Apache POI. One file is ZIP64 and can be read by Gnumeric, but not LibreOffice. The other file has been written without ZIP64 and can be read by LibreOffice 6.1.3.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
https://bugs.documentfoundation.org/show_bug.cgi?id=82984 --- Comment #9 from Andreas Reichel --- Created attachment 147160 --> https://bugs.documentfoundation.org/attachment.cgi?id=147160=edit XLSX with ZIP64 This file can be read in Gnumeric, but fails in LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82984] FILEOPEN: Error opening XLSX file in zip64 format
https://bugs.documentfoundation.org/show_bug.cgi?id=82984 --- Comment #8 from Andreas Reichel --- Created attachment 147159 --> https://bugs.documentfoundation.org/attachment.cgi?id=147159=edit XLSX without ZIP64 This file can be read in LibreOffice and Gnumeric. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121794] DOCX: Specific Document looses all tab stops
https://bugs.documentfoundation.org/show_bug.cgi?id=121794 --- Comment #6 from jvsingh...@gmail.com --- Created attachment 147158 --> https://bugs.documentfoundation.org/attachment.cgi?id=147158=edit The tab settings of the style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87838] India state names not in spelling dictionary
https://bugs.documentfoundation.org/show_bug.cgi?id=87838 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101948] Search fails to find specified indentation in imported Word document
https://bugs.documentfoundation.org/show_bug.cgi?id=101948 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114144] Doubleclicking on an item of an input list in an ott doesn't open the next input list dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=114144 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108825] Mail Merge Hangs (sometimes?) When Selecting CSV in Linux/Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=108825 --- Comment #19 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114113] No color highlighting of reference if it contains sheet name in single quotes (with spaces)
https://bugs.documentfoundation.org/show_bug.cgi?id=114113 --- Comment #2 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98723] Remote File SSH Type does not connect
https://bugs.documentfoundation.org/show_bug.cgi?id=98723 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120314] Landscaped document scan can rotate but cant adjust to full size page in portrait mode for reading.
https://bugs.documentfoundation.org/show_bug.cgi?id=120314 --- Comment #6 from yinlkw...@hotmail.com --- Yes, the bug is the subset of bug 115934. However, the problem that I describe here is a common task. i.e To have the image display in the correct orientation occupying the full page area. Perhaps a switch radio button can be added so that the height and width get swapped only for rotation of 90,270 degrees. This radio button is the equivalent of rotating the image outside libreoffice and import after rotation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121147] Initial screen comes up grey
https://bugs.documentfoundation.org/show_bug.cgi?id=121147 --- Comment #8 from Lee <92ma...@gmail.com> --- This is a re-post of my comment since I cannot see how to edit it Those who said the bug was not reproducible in 6.3 are reporting a Windows 10 environment, which is not the environment that fails. The environment which fails is a remote log-in to a multi-user Ubuntu (Linux) system. From the system console of such a system, it does work correctly but then, it isn't appropriate to perform office type tasks from the system console. I have tried, and again it failed using Version: 6.3.0.0.alpha0+ Build ID: da3432a0a8ab06c5bbd79a82703bf07e79c692f9 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded The last good version is Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121147] Initial screen comes up grey
https://bugs.documentfoundation.org/show_bug.cgi?id=121147 --- Comment #7 from Lee <92ma...@gmail.com> --- Those who said the bug was not reproducible in 6.3 are reporting a Windows 10 environment, using the environment in which it fails. The environment which files is a remote log-in (common on a multi-user Linux system. From the system console of such a system, it does work correctly but then, it isn't appropriate to perform office type tasks from the system console. I have tried, and again it failed using Version: 6.3.0.0.alpha0+ Build ID: da3432a0a8ab06c5bbd79a82703bf07e79c692f9 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded The last good version is Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 70977, which changed state. Bug 70977 Summary: Saving with Chart active is confusing and can lead to data loss in an unsaved spreadsheet, because flag Modified is set to false https://bugs.documentfoundation.org/show_bug.cgi?id=70977 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 100611, which changed state. Bug 100611 Summary: DATALOSS: Document with chart can be saved as chart, and can't be opened again without manual fix https://bugs.documentfoundation.org/show_bug.cgi?id=100611 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70977] Saving with Chart active is confusing and can lead to data loss in an unsaved spreadsheet, because flag Modified is set to false
https://bugs.documentfoundation.org/show_bug.cgi?id=70977 Markus Mohrhard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #18 from Markus Mohrhard --- Fixed by removal of the chart export feature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source include/sfx2 include/svx officecfg/registry sc/Library_sc.mk sc/sdi sc/source sc/uiconfig sfx2/source svx/sdi
filter/source/config/fragments/filters/chart8.xcu|2 include/sfx2/objsh.hxx |2 include/svx/svxids.hrc |1 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |8 - sc/Library_sc.mk |1 sc/sdi/tabvwsh.sdi |1 sc/source/filter/chart/chart_imp.cxx | 32 -- sc/source/ui/docshell/docsh.cxx | 39 --- sc/source/ui/drawfunc/fuins2.cxx | 37 --- sc/source/ui/inc/docsh.hxx |2 sc/source/ui/inc/fuinsert.hxx|7 - sc/source/ui/view/tabvwshb.cxx | 19 --- sc/uiconfig/scalc/menubar/menubar.xml|1 sfx2/source/doc/guisaveas.cxx| 21 sfx2/source/doc/objstor.cxx | 49 +- svx/sdi/svx.sdi | 19 --- 16 files changed, 10 insertions(+), 231 deletions(-) New commits: commit d543e8dfd3d8ae718e29304a155e1cf70d08325d Author: Markus Mohrhard AuthorDate: Thu Nov 29 20:34:56 2018 +0100 Commit: Markus Mohrhard CommitDate: Fri Nov 30 03:17:27 2018 +0100 tdf#93005, tdf#100611, remove the incomplete ODC export feature Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/filter/source/config/fragments/filters/chart8.xcu b/filter/source/config/fragments/filters/chart8.xcu index 3c33792476fe..6bcfbd88dc18 100644 --- a/filter/source/config/fragments/filters/chart8.xcu +++ b/filter/source/config/fragments/filters/chart8.xcu @@ -16,7 +16,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . --> -IMPORT EXPORT OWN DEFAULT PREFERRED ENCRYPTION +IMPORT EXPORT OWN DEFAULT NOTINFILEDIALOG NOTINCHOOSER PREFERRED ENCRYPTION com.sun.star.comp.chart2.XMLFilter XML diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx index 3a5233238149..4b59cc043cd6 100644 --- a/include/sfx2/objsh.hxx +++ b/include/sfx2/objsh.hxx @@ -602,7 +602,7 @@ public: */ voidSetupStorage( const css::uno::Reference< css::embed::XStorage >& xStorage, -sal_Int32 nVersion, bool bTemplate, bool bChart = false ) const; +sal_Int32 nVersion, bool bTemplate ) const; css::uno::Reference< css::embed::XStorage > const & GetStorage(); diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc index 03c606182239..9662124b339a 100644 --- a/include/svx/svxids.hrc +++ b/include/svx/svxids.hrc @@ -267,7 +267,6 @@ class SfxStringItem; #define SID_OBJECT_ALIGN_UP ( SID_SVX_START + 134 ) #define SID_OBJECT_ALIGN_MIDDLE ( SID_SVX_START + 135 ) #define SID_OBJECT_ALIGN_DOWN ( SID_SVX_START + 136 ) -#define SID_INSERT_DIAGRAM_FROM_FILE( SID_SVX_START + 139 ) #define SID_INSERT_DIAGRAM ( SID_SVX_START + 140 ) #define SID_INSERT_TABLE( SID_SVX_START + 141 ) #define SID_ATTRIBUTES_AREA ( SID_SVX_START + 142 ) diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu index ecaf820b572b..9dec9ccaf542 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu @@ -2549,14 +2549,6 @@ 1 - - - Chart from File... - - - 1 - - Bullets diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk index fe0e4368379b..82bd3ba17691 100644 --- a/sc/Library_sc.mk +++ b/sc/Library_sc.mk @@ -349,7 +349,6 @@ $(eval $(call gb_Library_add_exception_objects,sc,\ sc/source/filter/xml/xmltabi \ sc/source/filter/xml/xmltransformationi \ sc/source/filter/xml/xmlwrap \ -sc/source/filter/chart/chart_imp \ sc/source/filter/importfilterdata \ sc/source/ui/Accessibility/AccessibilityHints \ sc/source/ui/Accessibility/AccessibleCell \ diff --git a/sc/sdi/tabvwsh.sdi b/sc/sdi/tabvwsh.sdi index 7f33a247a394..4f9b451b05e2 100644 --- a/sc/sdi/tabvwsh.sdi +++ b/sc/sdi/tabvwsh.sdi @@ -125,7 +125,6 @@ interface BaseSelection SID_FM_CREATE_CONTROL [ ExecMethod = ExecDraw ; ] SID_LINKS
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 93005, which changed state. Bug 93005 Summary: Chart / Unable to save as .odc file https://bugs.documentfoundation.org/show_bug.cgi?id=93005 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/chart/seriesconverter.cxx | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
New commits:
commit 6a04b9298ae993881d20fc4b5aa91516d4df6695
Author: Markus Mohrhard
AuthorDate: Fri Nov 30 00:45:57 2018 +0100
Commit: Markus Mohrhard
CommitDate: Fri Nov 30 03:06:42 2018 +0100
tdf#121282, tdf#121279, set text properties also on complex data labels
Change-Id: I2304b6050b786b6e4a9a8a968d7a4846d9da8be8
Reviewed-on: https://gerrit.libreoffice.org/64306
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/oox/source/drawingml/chart/seriesconverter.cxx
b/oox/source/drawingml/chart/seriesconverter.cxx
index 241b8a4e506a..716a0b234bdd 100644
--- a/oox/source/drawingml/chart/seriesconverter.cxx
+++ b/oox/source/drawingml/chart/seriesconverter.cxx
@@ -124,6 +124,14 @@ Reference< XLabeledDataSequence >
lclCreateLabeledDataSequence(
return xLabeledSeq;
}
+void convertTextProperty(PropertySet& rPropSet, ObjectFormatter& rFormatter,
+DataLabelModelBase::TextBodyRef xTextProps)
+{
+rFormatter.convertTextFormatting( rPropSet, xTextProps,
OBJECTTYPE_DATALABEL );
+ObjectFormatter::convertTextRotation( rPropSet, xTextProps, false );
+ObjectFormatter::convertTextWrap( rPropSet, xTextProps );
+}
+
void lclConvertLabelFormatting( PropertySet& rPropSet, ObjectFormatter&
rFormatter,
const DataLabelModelBase& rDataLabel, const
TypeGroupConverter& rTypeGroup,
bool bDataSeriesLabel, bool bMSO2007Doc, const
PropertySet* pSeriesPropSet )
@@ -171,10 +179,7 @@ void lclConvertLabelFormatting( PropertySet& rPropSet,
ObjectFormatter& rFormatt
rFormatter.convertNumberFormat( rPropSet, rDataLabel.maNumberFormat,
false, bShowPercent );
// data label text formatting (frame formatting not supported by
Chart2)
-rFormatter.convertTextFormatting( rPropSet, rDataLabel.mxTextProp,
OBJECTTYPE_DATALABEL );
-ObjectFormatter::convertTextRotation( rPropSet, rDataLabel.mxTextProp,
false );
-ObjectFormatter::convertTextWrap( rPropSet, rDataLabel.mxTextProp );
-
+convertTextProperty(rPropSet, rFormatter, rDataLabel.mxTextProp);
// data label separator (do not overwrite series separator, if no
explicit point separator is present)
if( bDataSeriesLabel || rDataLabel.moaSeparator.has() )
@@ -338,6 +343,7 @@ void DataLabelConverter::convertFromModel( const Reference<
XDataSeries >& rxDat
}
aPropSet.setProperty( PROP_CustomLabelFields, makeAny( aSequence )
);
+convertTextProperty(aPropSet, getFormatter(),
mrModel.mxText->mxTextBody);
}
}
catch( Exception& )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121749] problem downloading beta file
https://bugs.documentfoundation.org/show_bug.cgi?id=121749 mois...@hushmail.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from mois...@hushmail.com --- problem repeated. I deleted the first installation file before downloading again. I'm downloading to a 64 bit Windows 7 Ultimate laptop. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94591] FILEOPEN: ODT - Custom shapes and ellipses not rendered correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94591 --- Comment #11 from Regina Henschel --- The file sample_doc_" has several problems: The smiley has a wrong path. It uses an angle of about 2.359e+7 degree. The other shapes have no svg:viewBox attribute and use draw:engine and draw:data attribute. The specification has no rule for a missing svg:viewBox. That is https://issues.oasis-open.org/browse/OFFICE-3824. In the meantime LibreOffice could use the svg:x, svg:y, svg:width and svg:height attributes to generate a viewBox on import. The only real bug is, that LibreOffice are confused by the draw:engine and draw:data attributes. Because LibreOffice does not support the specified data:engine, it should ignore these attributes and use the given path. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 --- Comment #8 from Jim Raykowski --- (In reply to Telesto from comment #4) > (In reply to Dieter Praas from comment #3) > > I confirm it with > > > > Version: 6.2.0.0.beta1 (x64) > > Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 > > CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; > > Locale: en-US (de_DE); UI-Language: en-GB > > Calc: threaded > > > > This happens because of different width of table borders > > table picker: Table border 0,05pt > > default style: Table border 0,5pt > > > > Table borders of table with table picker should also have 0,5pt > > @Jim > You're the table style expert ;-). So I thought you might be interested.. Thank you for the compliment but... really I'm no expert, just enjoy hacking on LO and being a part of this awesome community :-) Guessing the "table picker" is the insert table tool button. The button that inserts a table with no style. If so, it is plausible the cause of the shift is as Dieter has pointed out. Tables inserted with the insert table tool button have no style. Table Default Style is an auto format table style. When a table style is applied to a table any direct formatting is replaced by the table style when rows or columns are added/deleted. We tried using Default Style as the default for newly inserted tables. Probably shouldn't do that again. It may hold the record for the most bug reports :(, see bug 115573 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121279] FILEOPEN XLSX Chart legend created with Excel is not wrapped when the document is opened in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121279 Markus Mohrhard changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig include/svtools include/vcl sc/source vcl/source vcl/unx
cui/source/inc/autocdlg.hxx| 78 -
cui/source/tabpages/autocdlg.cxx | 297 +++--
cui/uiconfig/ui/acorreplacepage.ui | 59 ++-
include/svtools/inettbc.hxx|2
include/vcl/combobox.hxx |2
include/vcl/edit.hxx |4
include/vcl/weld.hxx | 23 ++
sc/source/ui/inc/linkarea.hxx |2
sc/source/ui/miscdlgs/linkarea.cxx | 10 -
vcl/source/app/salvtables.cxx | 74 ++---
vcl/source/control/combobox.cxx|2
vcl/source/control/edit.cxx|3
vcl/unx/gtk3/gtk3gtkinst.cxx | 75 ++---
13 files changed, 384 insertions(+), 247 deletions(-)
New commits:
commit d8d231f97d829350d965105e3a5be119d1a6494c
Author: Caolán McNamara
AuthorDate: Thu Nov 29 11:45:47 2018 +
Commit: Caolán McNamara
CommitDate: Fri Nov 30 00:48:49 2018 +0100
weld OfaAutocorrReplacePage
Change-Id: I143792cfe123942d44b2e39cb1910a5127b2f592
Reviewed-on: https://gerrit.libreoffice.org/64254
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index 55e1fed825ac..bc8739ac2fa0 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -233,49 +233,51 @@ typedef std::map
StringChangeTable;
class OfaAutocorrReplacePage : public SfxTabPage
{
-using TabPage::ActivatePage;
-using TabPage::DeactivatePage;
+using TabPage::ActivatePage;
+using TabPage::DeactivatePage;
private:
-StringChangeTable aChangesTable;
-
-VclPtr m_pTextOnlyCB;
-VclPtr m_pShortED;
-VclPtr m_pReplaceED;
-VclPtr m_pReplaceTLB;
-VclPtr m_pNewReplacePB;
-VclPtr m_pDeleteReplacePB;
-
-OUStringsModify;
-OUStringsNew;
-
-std::set aFormatText;
-std::map
-aDoubleStringTable;
-std::unique_ptr pCompareClass;
-std::unique_ptrpCharClass;
-LanguageTypeeLang;
-
-bool bHasSelectionText;
-bool bFirstSelect:1;
-bool bReplaceEditChanged:1;
-bool bSWriter:1;
-
-DECL_LINK(SelectHdl, SvTreeListBox*, void);
-DECL_LINK(NewDelButtonHdl, Button*, void);
-DECL_LINK(NewDelActionHdl, AutoCorrEdit&, bool);
-DECL_LINK(ModifyHdl, Edit&, void);
-bool NewDelHdl(void const *);
-
-void RefillReplaceBox( bool bFromReset,
-LanguageType eOldLanguage,
-LanguageType eNewLanguage);
+StringChangeTable aChangesTable;
+
+OUStringsModify;
+OUStringsNew;
+
+std::set aFormatText;
+std::map
+aDoubleStringTable;
+std::unique_ptr pCompareClass;
+std::unique_ptrpCharClass;
+LanguageTypeeLang;
+
+bool bHasSelectionText;
+bool bFirstSelect:1;
+bool bReplaceEditChanged:1;
+bool bSWriter:1;
+
+std::unique_ptr m_xTextOnlyCB;
+std::unique_ptr m_xShortED;
+std::unique_ptr m_xReplaceED;
+std::unique_ptr m_xReplaceTLB;
+std::unique_ptr m_xNewReplacePB;
+std::unique_ptr m_xReplacePB;
+std::unique_ptr m_xDeleteReplacePB;
+
+DECL_LINK(SelectHdl, weld::TreeView&, void);
+DECL_LINK(NewDelButtonHdl, weld::Button&, void);
+DECL_LINK(NewDelActionHdl, weld::Entry&, bool);
+DECL_LINK(EntrySizeAllocHdl, const Size&, void);
+DECL_LINK(ModifyHdl, weld::Entry&, void);
+bool NewDelHdl(const weld::Widget*);
+
+void RefillReplaceBox( bool bFromReset,
+LanguageType eOldLanguage,
+LanguageType eNewLanguage);
public:
-OfaAutocorrReplacePage( vcl::Window* pParent, const
SfxItemSet& rSet );
-virtual ~OfaAutocorrReplacePage() override;
-virtual voiddispose() override;
+OfaAutocorrReplacePage(TabPageParent pParent, const SfxItemSet& rSet);
+virtual ~OfaAutocorrReplacePage() override;
+virtual void dispose() override;
static VclPtr Create( TabPageParent pParent, const
SfxItemSet* rAttrSet);
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index c491d265253c..b143f2734857 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -857,24 +857,25 @@ voidOfaACorrCheckListBox::KeyInput( const KeyEvent&
rKEvt )
SvSimpleTable::KeyInput(rKEvt);
}
-OfaAutocorrReplacePage::OfaAutocorrReplacePage( vcl::Window* pParent,
-const SfxItemSet& rSet )
-: SfxTabPage(pParent, "AcorReplacePage", "cui/ui/acorreplacepage.ui",
)
+OfaAutocorrReplacePage::OfaAutocorrReplacePage(TabPageParent pParent,
+ const
[Libreoffice-bugs] [Bug 121282] FILEOPEN XLSX Chart area created with Excel shrinks when the document is opened in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121282 Markus Mohrhard changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/source include/vcl
cui/source/factory/dlgfact.cxx |6 --
cui/source/factory/dlgfact.hxx |6 --
include/vcl/abstdlg.hxx|8
3 files changed, 20 deletions(-)
New commits:
commit 9766892044fc69de18d0395ec2c4a0e652165c23
Author: Caolán McNamara
AuthorDate: Thu Nov 29 09:25:34 2018 +
Commit: Caolán McNamara
CommitDate: Fri Nov 30 00:47:45 2018 +0100
drop unused VclAbstractRefreshableDialog
Change-Id: I11ce3235ee95d7c6e8b1832579d097c7b044ae52
Reviewed-on: https://gerrit.libreoffice.org/64277
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 206d4a13cca9..759b90bc53c6 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -110,7 +110,6 @@ short CuiAbstractSingleTabController_Impl::Execute()
}
IMPL_ABSTDLG_BASE(CuiVclAbstractDialog_Impl)
-IMPL_ABSTDLG_BASE(VclAbstractRefreshableDialog_Impl);
IMPL_ABSTDLG_BASE(CuiAbstractTabDialog_Impl);
short AbstractSvxDistributeDialog_Impl::Execute()
@@ -554,11 +553,6 @@ sal_uInt32 AbstractGalleryIdDialog_Impl::GetId() const
return m_xDlg->GetId();
}
-void VclAbstractRefreshableDialog_Impl::Update()
-{
-pDlg->Update();
-}
-
OUString AbstractURLDlg_Impl::GetURL() const
{
return pDlg->GetURL();
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index 40f51fb6c681..1e103792893d 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -97,12 +97,6 @@ public:
virtual short Execute() override;
};
-class VclAbstractRefreshableDialog_Impl : public VclAbstractRefreshableDialog
-{
-DECL_ABSTDLG_BASE(VclAbstractRefreshableDialog_Impl,Dialog)
-virtual voidUpdate() override ;
-};
-
class CuiAbstractSfxDialog_Impl : public SfxAbstractDialog
{
DECL_ABSTDLG_BASE(CuiAbstractSfxDialog_Impl,SfxModalDialog)
diff --git a/include/vcl/abstdlg.hxx b/include/vcl/abstdlg.hxx
index 353a542439cf..f000d92c26e5 100644
--- a/include/vcl/abstdlg.hxx
+++ b/include/vcl/abstdlg.hxx
@@ -86,14 +86,6 @@ public:
virtual voidEndDialog(sal_Int32 nResult) = 0;
};
-class VCL_DLLPUBLIC VclAbstractRefreshableDialog : public VclAbstractDialog
-{
-protected:
-virtual ~VclAbstractRefreshableDialog() override = default;
-public:
-virtual voidUpdate() = 0;
-};
-
class VCL_DLLPUBLIC AbstractPasswordToOpenModifyDialog : public
VclAbstractDialog
{
protected:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 121787] Automatic spell checking is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=121787 --- Comment #1 from Durgapriyanka --- I can not reproduce the bug in Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121789] Automatic spell checking is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=121789 --- Comment #2 from Durgapriyanka --- I can not reproduce the bug in Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121791] Can't insert avi file into slide
https://bugs.documentfoundation.org/show_bug.cgi?id=121791 --- Comment #6 from Durgapriyanka --- I can not confirm this with Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization
https://bugs.documentfoundation.org/show_bug.cgi?id=97629 Bug 97629 depends on bug 115663, which changed state. Bug 115663 Summary: [NEWHELP] Implement BASIC color scheme for BASIC examples https://bugs.documentfoundation.org/show_bug.cgi?id=115663 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33173] Tabbed UI (Writer): Division/section-per-tab (similar to Lotus WordPro)
https://bugs.documentfoundation.org/show_bug.cgi?id=33173 --- Comment #27 from Stian --- Damn, people have been asking for this since 2003! :-O I find it very strange this wouldn't be implemented. Especially when the functionality is implemented in Calc. It seems logical to me that the source code in Calc for that functionality could be easily implemented into Writer. About the file format compliance. Since this hasn't been implemented or even made ready within the standard, I'd suggest making an extended ODT format (or not, it doesn't matter as long as it works in Libre Office). What matters is the feature implementation, really. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33173] Tabbed UI (Writer): Division/section-per-tab (similar to Lotus WordPro)
https://bugs.documentfoundation.org/show_bug.cgi?id=33173 V Stuart Foote changed: What|Removed |Added CC||stian.aarskaug@protonmail.c ||h --- Comment #26 from V Stuart Foote --- *** Bug 121809 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37134] Tabbed UI: Document-per-tab (similar to Firefox, Opera, gedit)
https://bugs.documentfoundation.org/show_bug.cgi?id=37134 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1809 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 --- Comment #3 from Stian --- V Stuart Foote: I'd argue a master document and subdocuments are cumbersome to use and don't suit the purpose very well. The sheet functionality in Calc fit the purpose perfectly when you need to go back and forth all the time to insert and view info. It's also contained within one file. I suspected it wouldn't comply with the file format. To that, I say it doesn't have to and could be saved to an ODF-extended format. I wouldn't mind if it were an opt-in functionality (intentionally enabled by user) and would only support viewing and editing in Libre Office. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 --- Comment #3 from Stian --- V Stuart Foote: I'd argue a master document and subdocuments are cumbersome to use and don't suit the purpose very well. The sheet functionality in Calc fit the purpose perfectly when you need to go back and forth all the time to insert and view info. It's also contained within one file. I suspected it wouldn't comply with the file format. To that, I say it doesn't have to and could be saved to an ODF-extended format. I wouldn't mind if it were an opt-in functionality (intentionally enabled by user) and would only support viewing and editing in Libre Office. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121800] Missing images, formatting from Microsoft Publisher 2013 imported document
https://bugs.documentfoundation.org/show_bug.cgi?id=121800 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. I can not reproduce the bug in Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=37 ||134 Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 33173 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=37 ||134 Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 33173 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/axes/DateHelper.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit b937c6deb2e5610c26dc7082fcdbb0f4835ecd99
Author: Markus Mohrhard
AuthorDate: Thu Nov 29 19:07:21 2018 +0100
Commit: Markus Mohrhard
CommitDate: Thu Nov 29 23:31:49 2018 +0100
related tdf#42915, pass NaN through date transformation
Many places in chart2 use NaN to mean no available value. Not propagating
NaN through the helper disables all this functionality.
Change-Id: I37f966007b5b7cc16778c5c6903710fbd144631b
Reviewed-on: https://gerrit.libreoffice.org/64266
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/chart2/source/view/axes/DateHelper.cxx
b/chart2/source/view/axes/DateHelper.cxx
index 2e1fa3a4b867..6006d3e48bed 100644
--- a/chart2/source/view/axes/DateHelper.cxx
+++ b/chart2/source/view/axes/DateHelper.cxx
@@ -68,6 +68,9 @@ bool DateHelper::IsLessThanOneYearAway( const Date& rD1,
const Date& rD2 )
double DateHelper::RasterizeDateValue( double fValue, const Date& rNullDate,
long TimeResolution )
{
+if (rtl::math::isNan(fValue))
+return fValue;
+
Date aDate(rNullDate); aDate.AddDays(::rtl::math::approxFloor(fValue));
switch(TimeResolution)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/AreaChart.cxx |5 +
chart2/source/view/charttypes/VSeriesPlotter.cxx |7 +++
2 files changed, 12 insertions(+)
New commits:
commit 33c0a64650646fc542a104f025abbf30d1b7628f
Author: Markus Mohrhard
AuthorDate: Thu Nov 29 19:11:58 2018 +0100
Commit: Markus Mohrhard
CommitDate: Thu Nov 29 23:31:36 2018 +0100
tdf#42915, NaN in a date axis can destroy the whole chart
The NaN value forces the scaling of the axis to be based on years
and introduces gaps in the rendering.
Change-Id: I78219be289d76edb53b5672209e1c031ab62def9
Reviewed-on: https://gerrit.libreoffice.org/64267
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/chart2/source/view/charttypes/AreaChart.cxx
b/chart2/source/view/charttypes/AreaChart.cxx
index f7f49af92f30..570dd0840f8b 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -718,7 +718,12 @@ void AreaChart::createShapes()
//collect data point information (logic coordinates, style
):
double fLogicX = pSeries->getXValue(nIndex);
if (bDateCategory)
+{
+if (rtl::math::isNan(fLogicX))
+continue;
+
fLogicX = DateHelper::RasterizeDateValue( fLogicX,
m_aNullDate, m_nTimeResolution );
+}
double fLogicY = pSeries->getYValue(nIndex);
if( m_nDimension==3 && m_bArea &&
rXSlot.m_aSeriesVector.size()!=1 )
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index f80f656cf478..ff09606cda5c 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -1451,10 +1451,17 @@ long VSeriesPlotter::calculateTimeResolutionOnXAxis()
if( !rDateCategories.empty() )
{
std::vector< double >::const_iterator aIt =
rDateCategories.begin(), aEnd = rDateCategories.end();
+while (rtl::math::isNan(*aIt) && aIt != aEnd)
+{
+++aIt;
+}
Date aPrevious(aNullDate);
aPrevious.AddDays(rtl::math::approxFloor(*aIt));
++aIt;
for(;aIt!=aEnd;++aIt)
{
+if (rtl::math::isNan(*aIt))
+continue;
+
Date aCurrent(aNullDate);
aCurrent.AddDays(rtl::math::approxFloor(*aIt));
if( nRet == css::chart::TimeUnit::YEAR )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sc/qa sc/source
sc/qa/unit/data/ods/tdf121612.ods |binary
sc/qa/unit/subsequent_export-test.cxx | 20
sc/source/filter/excel/xepivotxml.cxx | 11 +--
3 files changed, 29 insertions(+), 2 deletions(-)
New commits:
commit 78457f7462aa3bf92839667a550451f0d434f48b
Author: Vasily Melenchuk
AuthorDate: Thu Nov 22 11:30:29 2018 +0300
Commit: Thorsten Behrens
CommitDate: Thu Nov 29 23:10:15 2018 +0100
tdf#121612: update pivot caches during saving to XLSX
Cache was empty so pivot table was not exported completely
and pivot table filter were missing.
Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d
Reviewed-on: https://gerrit.libreoffice.org/63785
Tested-by: Jenkins
Reviewed-by: Katarina Behrens
Reviewed-by: Thorsten Behrens
Reviewed-on: https://gerrit.libreoffice.org/64265
Tested-by: Thorsten Behrens
diff --git a/sc/qa/unit/data/ods/tdf121612.ods
b/sc/qa/unit/data/ods/tdf121612.ods
new file mode 100644
index ..6afc4e0c931c
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf121612.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 36f62373e7e0..2fb53a18ac3c 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -43,6 +43,7 @@
#include
#include
#include
+#include
#include
#include
@@ -209,6 +210,7 @@ public:
void testKeepSettingsOfBlankRows();
void testTdf118990();
+void testTdf121612();
CPPUNIT_TEST_SUITE(ScExportTest);
CPPUNIT_TEST(test);
@@ -319,6 +321,7 @@ public:
CPPUNIT_TEST(testKeepSettingsOfBlankRows);
CPPUNIT_TEST(testTdf118990);
+CPPUNIT_TEST(testTdf121612);
CPPUNIT_TEST_SUITE_END();
@@ -4068,6 +4071,23 @@ void ScExportTest::testTdf118990()
xDocSh->DoClose();
}
+void ScExportTest::testTdf121612()
+{
+ScDocShellRef xDocSh = loadDoc("tdf121612.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+xDocSh = saveAndReload(xDocSh.get(), FORMAT_XLSX);
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// There should be a pivot table
+CPPUNIT_ASSERT(rDoc.HasPivotTable());
+
+// DP collection is not lost after export and has one entry
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
+CPPUNIT_ASSERT(pDPColl);
+CPPUNIT_ASSERT_EQUAL(size_t(1), pDPColl->GetCount());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 004f9938a72a..0f432793ec5a 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -419,15 +419,22 @@ XclExpXmlPivotTableManager::XclExpXmlPivotTableManager(
const XclExpRoot& rRoot
void XclExpXmlPivotTableManager::Initialize()
{
-const ScDocument& rDoc = GetDoc();
+ScDocument& rDoc = GetDoc();
if (!rDoc.HasPivotTable())
// No pivot table to export.
return;
-const ScDPCollection* pDPColl = rDoc.GetDPCollection();
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
if (!pDPColl)
return;
+// Update caches from DPObject
+for (size_t i = 0; i < pDPColl->GetCount(); ++i)
+{
+ScDPObject& rDPObj = (*pDPColl)[i];
+rDPObj.SyncAllDimensionMembers();
+}
+
// Go through the caches first.
std::vector aCaches;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- See little need to implement this non-ODF compliant Text document mode. Every thing the OP is asking for can be handled with master document / sub-document(s)--managed from Navigator. Somewhat lighter weight is to work with Sections in a single Writer document, again managed from Navigator. IMHO = WF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- See little need to implement this non-ODF compliant Text document mode. Every thing the OP is asking for can be handled with master document / sub-document(s)--managed from Navigator. Somewhat lighter weight is to work with Sections in a single Writer document, again managed from Navigator. IMHO = WF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 106145, which changed state. Bug 106145 Summary: Chart is not copied properly from Calc to Impress https://bugs.documentfoundation.org/show_bug.cgi?id=106145 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106145] Chart is not copied properly from Calc to Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=106145 Markus Mohrhard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #7 from Markus Mohrhard --- (In reply to Jan Lachnitt from comment #2) > I have noticed that if the chart is pasted as a Star Object Descriptor (the > default), wrong number format is used on the secondary Y axis. Should I file > another bug? Actually the same number format is used (General). However, Calc has some special code to get the necessary precision based on the cell number format. The same can obviously not be implemented for the internal data table. In Impress one needs to use a different number format if one wants to avoid the default 2 decimal places rounding. WHile the behavior might have changed here I think there is nothing we can do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval --- Comment #1 from Dieter Praas --- I think that's a question for the design team => needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval --- Comment #1 from Dieter Praas --- I think that's a question for the design team => needsUXEval -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 stian.aarsk...@protonmail.ch changed: What|Removed |Added URL||https://www.technorms.com/w ||p-content/uploads/2011/12/L ||ibre-Office-Calc.png -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 stian.aarsk...@protonmail.ch changed: What|Removed |Added URL||https://www.technorms.com/w ||p-content/uploads/2011/12/L ||ibre-Office-Calc.png -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: kit/ChildSession.cpp
kit/ChildSession.cpp |8
1 file changed, 8 insertions(+)
New commits:
commit 637324354d12c655259a0f54c81d676ac8bb24cf
Author: Tor Lillqvist
AuthorDate: Thu Nov 29 23:45:52 2018 +0200
Commit: Tor Lillqvist
CommitDate: Thu Nov 29 23:46:16 2018 +0200
Skip the signature uploading code for the mobile app case
Change-Id: If634c5b1ff77e6a56c9a195d9394c4d2906419cb
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 114a89a96..856940c96 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -25,11 +25,13 @@
#include
#include
#include
+#ifndef MOBILEAPP
#include
#include
#include
#include
#include
+#endif
#include
#include
@@ -365,10 +367,12 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
{
askSignatureStatus(buffer, length, tokens);
}
+#ifndef MOBILEAPP
else if (tokens[0] == "uploadsigneddocument")
{
return uploadSignedDocument(buffer, length, tokens);
}
+#endif
else
{
assert(false && "Unknown command token.");
@@ -378,6 +382,8 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
return true;
}
+#ifndef MOBILEAPP
+
// add to common / tools
size_t getFileSize(const std::string& filename)
{
@@ -509,6 +515,8 @@ bool ChildSession::uploadSignedDocument(const char* buffer,
int length, const st
return true;
}
+#endif
+
bool ChildSession::loadDocument(const char * /*buffer*/, int /*length*/, const
std::vector& tokens)
{
int part = -1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 37903] EDITING: Moving object using ALT - cursor keys also moves the object behind it
https://bugs.documentfoundation.org/show_bug.cgi?id=37903 --- Comment #15 from Gerry --- I can still confirm this bug in LibreOffice version 6.1.2.1 Version: 6.1.2.1 Build ID: 1:6.1.2-0ubuntu1.1 CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3; Locale: en-GB (de_DE.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 3 commits - kit/ChildSession.cpp loleaflet/css loleaflet/html loleaflet/images loleaflet/js loleaflet/src loolwsd.xml.in wsd/FileServer.cpp
kit/ChildSession.cpp |8 +---
loleaflet/css/toolbar.css |1 +
loleaflet/html/loleaflet.html.m4 |6 --
loleaflet/images/close_toolbar.svg |1 +
loleaflet/js/toolbar.js|3 ++-
loleaflet/src/control/Signing.js | 21 +++--
loolwsd.xml.in |4 ++--
wsd/FileServer.cpp |8 +++-
8 files changed, 37 insertions(+), 15 deletions(-)
New commits:
commit 7a8c5c072f4e70428deef923a2e78ab104b757b2
Author: Tomaž Vajngerl
AuthorDate: Thu Nov 29 22:34:14 2018 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Nov 29 22:46:14 2018 +0100
Add "close" function to the document signing info bar
Change-Id: I24e967de5c2a975ec2f1321c02712761c6d48de3
Reviewed-on: https://gerrit.libreoffice.org/64299
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/loleaflet/css/toolbar.css b/loleaflet/css/toolbar.css
index daef2d11c..c7c01fad3 100644
--- a/loleaflet/css/toolbar.css
+++ b/loleaflet/css/toolbar.css
@@ -584,6 +584,7 @@ button.leaflet-control-search-next
.w2ui-icon.users{ background: url('images/contacts-dark.svg') no-repeat center
!important; }
.w2ui-icon.fullscreen{ background: url('images/lc_fullscreen.svg') no-repeat
center !important; }
.w2ui-icon.closemobile{ background: url('images/lc_closedocmobile.svg')
no-repeat center !important; }
+.w2ui-icon.closetoolbar{ background: url('images/close_toolbar.svg') no-repeat
center !important; }
.inserttable-pop {
z-index: 1000;
diff --git a/loleaflet/images/close_toolbar.svg
b/loleaflet/images/close_toolbar.svg
new file mode 100644
index 0..68b09bb18
--- /dev/null
+++ b/loleaflet/images/close_toolbar.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 4e1b26591..9485d77cc 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -952,9 +952,10 @@ function initNormalToolbar(toolItems) {
{type: 'break' },
{type: 'menu', id: 'passport', caption:
_('Select passport'), items: []},
{type: 'html', id: 'current-passport', html:
'Passport: N/A'},
- {type: 'break' },
+ {type: 'spacer'},
{type: 'button', id: 'logout', caption:
'Logout', img: '', hint: _('Logout')},
{type: 'button', id: 'login', caption:
'Login', img: '', hint: _('Login')},
+ {type: 'button', id: 'close', img:
'closetoolbar', hint: _('Close')},
],
onClick: function (e) {
onClick(e, e.target);
diff --git a/loleaflet/src/control/Signing.js b/loleaflet/src/control/Signing.js
index 47c6dbfba..fcfcd970b 100644
--- a/loleaflet/src/control/Signing.js
+++ b/loleaflet/src/control/Signing.js
@@ -9,6 +9,8 @@ var library = null;
var identity = null;
var currentPassport = null;
+var oldtoolbarSize = null;
+
function isSuccess(result) {
return result.code == '200';
}
@@ -227,8 +229,15 @@ function vereignRestoreIdentity() {
L.Map.include({
showSignDocument: function() {
this.initializeLibrary();
+ oldtoolbarSize = $('#document-container').css('top');
- $('#document-container').css('top', '100px');
+ $('#document-container').css('top', '110px');
+ },
+ hideSignDocument: function() {
+ library = null;
+ identity = null;
+ currentPassport = null;
+ $('#document-container').css('top', oldtoolbarSize);
},
signingInitializeBar: function() {
adjustUIState();
@@ -377,7 +386,10 @@ L.Map.include({
}
},
handleSigningClickEvent: function(id, item) {
- if (id === 'login') {
+ if (id === 'close') {
+ this.hideSignDocument();
+ }
+ else if (id === 'login') {
this.signingLogin();
}
else if (id === 'logout') {
commit 2861299c7723a259701800b8c80c398898f92d54
Author: Tomaž Vajngerl
AuthorDate: Thu Nov 29 22:16:41 2018 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Nov 29 22:46:07 2018 +0100
make vereign server configurable, dynamically show sign. infobar
document_signing_url in loolwsd now accepts a vereign server URL
endpoint. If not provided, the signing functionallity won't be
available.
The document signing infobar is now shown dynamically so by
default it is not shown, but when the users clicks in menu the
"sign document", the infobar is shown (the document-content is
css "top" value is adjusted via JQuery).
Change-Id:
[Libreoffice-ux-advise] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 stian.aarsk...@protonmail.ch changed: What|Removed |Added Summary|Sheets for Writer (like in |FEATURE REQUEST: Sheets for |Calc) to separate document |Writer (like in Calc) to |contents into categories|separate document contents |etc.|into categories etc. Keywords|needsUXEval | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121809] FEATURE REQUEST: Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 stian.aarsk...@protonmail.ch changed: What|Removed |Added Summary|Sheets for Writer (like in |FEATURE REQUEST: Sheets for |Calc) to separate document |Writer (like in Calc) to |contents into categories|separate document contents |etc.|into categories etc. Keywords|needsUXEval | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121810] New: Firebrd: Migration: Crash in: libgobject-2.0.so.0.5600.3 when selecting more on error dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=121810 Bug ID: 121810 Summary: Firebrd: Migration: Crash in: libgobject-2.0.so.0.5600.3 when selecting more on error dialog Product: LibreOffice Version: 6.2.0.0.beta1+ Hardware: All OS: All Status: UNCONFIRMED Keywords: regression Severity: normal Priority: high Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: drewjensen.in...@gmail.com Created attachment 147157 --> https://bugs.documentfoundation.org/attachment.cgi?id=147157=edit test file for crash This bug was filed from the crash reporting server and is br-a88a20cc-0950-4902-8174-08de3b3b8d64. = The test system is Ubuntu 18.04. There is no crash with Version: 6.2.0.0.beta1 (From last Monday) Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 Does crash consistently with Version: 6.2.0.0.beta1+ (27 Nov) Build ID: 6ab7bfbca4148416233dbf8b9bfc79f3a1dfa821 To reproduce: 1 - download the attached odb file. 2 - Open in Base and start the mirgation assistant 3 - When the error box displays click on 'More' Crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121809] Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 121809] Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120068] Table Formatting is forgotten if I delete/add a column
https://bugs.documentfoundation.org/show_bug.cgi?id=120068 Telesto changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Blocks|108364 |107553 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107553 [Bug 107553] [META] Writer table styles bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108364 [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 Telesto changed: What|Removed |Added Depends on|120068 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120068 [Bug 120068] Table Formatting is forgotten if I delete/add a column -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107553] [META] Writer table styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107553 Telesto changed: What|Removed |Added Depends on||120068 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120068 [Bug 120068] Table Formatting is forgotten if I delete/add a column -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121809] Sheets for Writer (like in Calc) to separate document contents into categories etc.
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 stian.aarsk...@protonmail.ch changed: What|Removed |Added Summary|Sheets for Writer like in |Sheets for Writer (like in |Calc|Calc) to separate document ||contents into categories ||etc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 Dieter Praas changed: What|Removed |Added Version|6.2.0.0.alpha1+ |6.1.3.2 release --- Comment #7 from Dieter Praas --- Also repro in Version: 6.1.3.2 (x64) Build-ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121026] Horizontal table borders appear slightly fatter compared to vertical lines and compared to previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=121026 Telesto changed: What|Removed |Added CC||armin.le.gr...@me.com --- Comment #7 from Telesto --- Adding CC: to Armin Le Grand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121026] Horizontal table borders appear slightly fatter compared to vertical lines and compared to previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=121026 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1222 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121222] Bottom table border doesn't change color until scroll (or some other action)
https://bugs.documentfoundation.org/show_bug.cgi?id=121222 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1026 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121809] New: Sheets for Writer like in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121809 Bug ID: 121809 Summary: Sheets for Writer like in Calc Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stian.aarsk...@protonmail.ch Description: This is a feature request for sheets for Writer. This functionality can already be found in Calc (and Excel) but would be very useful in Writer! The sheet functionality would be perfect for this! I suppose the source code is easily adaptable from Calc to Writer. Picture of the functionality in Calc for illustration (sheets at the bottom left): https://www.technorms.com/wp-content/uploads/2011/12/Libre-Office-Calc.png Actual Results: This is a feature request. The feature does not exist. Expected Results: It should exist. :) Reproducible: Always User Profile Reset: No Additional Info: Why the need? To separate categories, topics etc. in documents. For instance, I have documents where I gather information on tuning parts, mods and reference information. Categories being suspension, brakes, wheels, electronics, weight reduction, you get the point. Other examples being system rebuild references (settings, fixes for problems, software, links and information). I'm aware of this Superuser thread of someone else asking for it, does not solve the problem for neither of us: https://superuser.com/questions/978787/sheets-in-libreoffice-writer-similar-to-that-in-calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 Telesto changed: What|Removed |Added Attachment #147155|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 --- Comment #6 from Telesto --- Sorry, wrong bug.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121026] Horizontal table borders appear slightly fatter compared to vertical lines and compared to previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=121026 --- Comment #6 from Telesto --- Created attachment 147156 --> https://bugs.documentfoundation.org/attachment.cgi?id=147156=edit Bibisect log Bisected to author Armin Le Grand 2018-10-25 10:06:05 +0200 committer Armin Le Grand 2018-10-25 12:43:55 +0200 commit 313392119522c21a6ecd14403d6f92c948149df7 (patch) treefbd1a112a41f83d34c6bb6ea79eeccf73dba3e7b parent 8dec85a3b3f4cbd46b03f707458347a25cc22c15 (diff) Reorganize FrameBorderPrimitive creation (II) Step5: Move the view-dependent decomposition from BorderLinePrimitive2D to SdrFrameBorderPrimitive2D. https://cgit.freedesktop.org/libreoffice/core/commit/?id=313392119522c21a6ecd14403d6f92c948149df7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 --- Comment #5 from Telesto --- Created attachment 147155 --> https://bugs.documentfoundation.org/attachment.cgi?id=147155=edit Bibisect log Bisected to author Armin Le Grand 2018-10-25 10:06:05 +0200 committer Armin Le Grand 2018-10-25 12:43:55 +0200 commit 313392119522c21a6ecd14403d6f92c948149df7 (patch) treefbd1a112a41f83d34c6bb6ea79eeccf73dba3e7b parent 8dec85a3b3f4cbd46b03f707458347a25cc22c15 (diff) Reorganize FrameBorderPrimitive creation (II) Step5: Move the view-dependent decomposition from BorderLinePrimitive2D to SdrFrameBorderPrimitive2D. https://cgit.freedesktop.org/libreoffice/core/commit/?id=313392119522c21a6ecd14403d6f92c948149df7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sc/qa sc/source
sc/qa/unit/data/ods/tdf121612.ods |binary
sc/qa/unit/subsequent_export-test.cxx | 19 +++
sc/source/filter/excel/xepivotxml.cxx | 11 +--
3 files changed, 28 insertions(+), 2 deletions(-)
New commits:
commit 41d514ecd43ae9ec673071bfa1d79e788b8f935b
Author: Vasily Melenchuk
AuthorDate: Thu Nov 22 11:30:29 2018 +0300
Commit: Thorsten Behrens
CommitDate: Thu Nov 29 22:26:44 2018 +0100
tdf#121612: update pivot caches during saving to XLSX
Cache was empty so pivot table was not exported completely
and pivot table filter were missing.
Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d
Reviewed-on: https://gerrit.libreoffice.org/63785
Tested-by: Jenkins
Reviewed-by: Katarina Behrens
Reviewed-by: Thorsten Behrens
Reviewed-on: https://gerrit.libreoffice.org/64264
Tested-by: Thorsten Behrens
diff --git a/sc/qa/unit/data/ods/tdf121612.ods
b/sc/qa/unit/data/ods/tdf121612.ods
new file mode 100644
index ..6afc4e0c931c
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf121612.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 4e90034a5f99..74b521a02c9a 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -176,6 +176,7 @@ public:
void testHeaderImage();
void testTdf88657();
+void testTdf121612();
CPPUNIT_TEST_SUITE(ScExportTest);
CPPUNIT_TEST(test);
@@ -258,6 +259,7 @@ public:
CPPUNIT_TEST(testHeaderImage);
CPPUNIT_TEST(testTdf88657);
+CPPUNIT_TEST(testTdf121612);
CPPUNIT_TEST_SUITE_END();
@@ -3708,6 +3710,23 @@ void ScExportTest::testConditionalFormatRangeListXLSX()
assertXPath(pDoc, "//x:conditionalFormatting", "sqref", "F4 F10");
}
+void ScExportTest::testTdf121612()
+{
+ScDocShellRef xDocSh = loadDoc("tdf121612.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+xDocSh = saveAndReload(xDocSh.get(), FORMAT_XLSX);
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// There should be a pivot table
+CPPUNIT_ASSERT(rDoc.HasPivotTable());
+
+// DP collection is not lost after export and has one entry
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
+CPPUNIT_ASSERT(pDPColl);
+CPPUNIT_ASSERT_EQUAL(size_t(1), pDPColl->GetCount());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 1b340812cc3f..28114c67c103 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -296,15 +296,22 @@ XclExpXmlPivotTableManager::XclExpXmlPivotTableManager(
const XclExpRoot& rRoot
void XclExpXmlPivotTableManager::Initialize()
{
-const ScDocument& rDoc = GetDoc();
+ScDocument& rDoc = GetDoc();
if (!rDoc.HasPivotTable())
// No pivot table to export.
return;
-const ScDPCollection* pDPColl = rDoc.GetDPCollection();
+ScDPCollection* pDPColl = rDoc.GetDPCollection();
if (!pDPColl)
return;
+// Update caches from DPObject
+for (size_t i = 0; i < pDPColl->GetCount(); ++i)
+{
+ScDPObject& rDPObj = (*pDPColl)[i];
+rDPObj.SyncAllDimensionMembers();
+}
+
// Go through the caches first.
std::vector aCaches;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88497] FILEOPEN: error bar in spreadsheet not shown
https://bugs.documentfoundation.org/show_bug.cgi?id=88497 Markus Mohrhard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #9 from Markus Mohrhard --- Actually this looks like it is correct how it is implemented by now. The file is storing a draw:stroke="none" which tells LibreOffice to draw an error bar without a line. I don't consider this a bug or a regression. It looks like we fixed a previous bug and unfortunately one needs to change the line format from none to continuous once. I checked that the format is correctly exported in master. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert
https://bugs.documentfoundation.org/show_bug.cgi?id=121029 Telesto changed: What|Removed |Added CC||rayk...@gmail.com --- Comment #4 from Telesto --- (In reply to Dieter Praas from comment #3) > I confirm it with > > Version: 6.2.0.0.beta1 (x64) > Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 > CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; > Locale: en-US (de_DE); UI-Language: en-GB > Calc: threaded > > This happens because of different width of table borders > table picker: Table border 0,05pt > default style: Table border 0,5pt > > Table borders of table with table picker should also have 0,5pt @Jim You're the table style expert ;-). So I thought you might be interested.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'refs/tags/3.4.2-1' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120653] Writer: Standard toolbar (single mode) on and off in Fullscreen view
https://bugs.documentfoundation.org/show_bug.cgi?id=120653 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de Ever confirmed|0 |1 --- Comment #2 from Dieter Praas --- Set to NEW because of comment 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
