[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=84837 --- Comment #126 from shandireza --- http://www.sourcedrivers.com/2017/02/epson-l220-free-driver-download.html http://www.sourcedrivers.com/2017/02/canon-mg7720-wireless-driver-download.html http://www.sourcedrivers.com/2016/10/brother-mfc-7860dw-driver-download.html https://www.sourcedrivers.com/2018/11/samsung-c467w-driver-download.html https://www.carshighlight.com/2018/12/chevrolet-silverado-3500hd-2019-review.html https://www.carshighlight.com/2018/12/2019-honda-civic-review-specs-price.html https://www.carshighlight.com/2017/08/honda-cr-v-2018-redesign-review-specs.html https://www.carshighlight.com/2018/11/2019-ford-f-150-review-specs-price.html https://www.softwareanddriver.com/2018/07/avg-2019-antivirus-free-download-and.html https://www.freedownloaden.com/2018/07/avg-2019-antivirus-free-download-and.html https://www.avastupdates.com/2018/07/avast-2019-free-full-download.html https://www.avastech.com/2018/07/avast-2019-free-full-download-and-review.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122111] Hex2DEC not converting right
https://bugs.documentfoundation.org/show_bug.cgi?id=122111 Xavier Van Wijmeersch changed: What|Removed |Added OS|Windows (All) |All CC||xv3...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122111] Hex2DEC not converting right
https://bugs.documentfoundation.org/show_bug.cgi?id=122111 Xavier Van Wijmeersch changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Xavier Van Wijmeersch --- After reading the explanation in comment 4 and have a look at the website given by MM i confirm the problem. And i think its inherent from ooo Version: 6.3.0.0.alpha0+ Build ID: b052974a6574e4074794ffa590fe60f7c1726768 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122119] New: UI checkbox is not fully displayed in Font features (Format cells dialog)
https://bugs.documentfoundation.org/show_bug.cgi?id=122119 Bug ID: 122119 Summary: UI checkbox is not fully displayed in Font features (Format cells dialog) Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: emo_asse...@yahoo.com Created attachment 147568 --> https://bugs.documentfoundation.org/attachment.cgi?id=147568=edit screenshot Open Calc Open Format cells dialog - Font - Features Issue - checkbox is hiddent (see screenshot) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113300] [META] Language detection bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113300 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||105091 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105091 [Bug 105091] Using unicode caracter 2042 (asterism) switches language to Hindi -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105091] Using unicode caracter 2042 (asterism) switches language to Hindi
https://bugs.documentfoundation.org/show_bug.cgi?id=105091 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||113300 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113300 [Bug 113300] [META] Language detection bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105091] Using unicode caracter 2042 (asterism) switches language to Hindi
https://bugs.documentfoundation.org/show_bug.cgi?id=105091 --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to MonsieurLune from comment #5) > I still have the issue on the master build: > 5.4.0.0.alpha0+ > Build ID: c6dd735afb2e1b3837c4f8c5659f52fafab4c56f > CPU Threads: 2 > OS Version: Linux 4.4 > UI Render: default > VCL: gtk2 > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: > 2017-01-30_03:01:16 > Locale: fr-FR (fr_FR.UTF-8) > Calc: group > > Simply open a new document, insert the U2042 char, et you're set to Hindi. I used shortcat Alt+X for inserting unicode symbol 2042 in Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded and I still have Russian language for my text in document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sal/osl
sal/osl/w32/file_url.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit dfe497c0c7628ed2d2abb5dbae2bf8756a371f29 Author: Mike Kaganski AuthorDate: Fri Dec 14 12:44:57 2018 +0100 Commit: Aron Budea CommitDate: Sat Dec 15 08:09:29 2018 +0100 tdf#98343: ensure PathRemoveFileSpec does not remove UNC's "\\" PathRemoveFileSpec is used exclusively in GetCaseCorrectPathName(Ex). The GetCaseCorrectPathName function is only called for absolute or relative paths, not some arbitrary that chunks. So initial double backslashes are only possible for UNC paths. This change fixes handling of UNC paths by the functions. Previously, the UNC path was recursively shortened until it only consisted of a single "\"; then, if bCheckExistence was requested, testing this path failed, which resulted in the whole recursion to return empty result; else when returning from the recursion, original path components were appended, but initial double backslashes were never restored. This led to transformation "\\SERVER\Path\file.ext" to "\SERVER\Path\file.ext". The GetCaseCorrectPathName itself is only used in two places: osl_getSystemPathFromFileURL_() and osl_getFileStatus(). osl_getSystemPathFromFileURL_ only calls GetCaseCorrectPathName for paths longer than 248 characters; bCheckExistence is false. In that case, the resulting wrong path (missing one initial backslash) was then processed in /* it should be an UNC path, use the according prefix */ branch, where two initial characters of it were stripped, one of which being the first character of SERVER name. So, all the following manipulations with resulting path were incorrect. This code path was the reason for the bug. osl_getFileStatus calls GetCaseCorrectPathName always; it requires to check existence. This led to 0 returned from GetCaseCorrectPathName, then osl_getFileStatus continued with copying the original string, thus ignoring the error. Change-Id: If7409afa2c0dd6dd001c79e719acbfd271a6ab72 Reviewed-on: https://gerrit.libreoffice.org/65158 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 12e878d3b5e8a59079811c36b7c89e588266dd0e) Reviewed-on: https://gerrit.libreoffice.org/65192 Reviewed-by: Aron Budea Tested-by: Aron Budea diff --git a/sal/osl/w32/file_url.cxx b/sal/osl/w32/file_url.cxx index d25fd9b56d71..6283b00893a2 100644 --- a/sal/osl/w32/file_url.cxx +++ b/sal/osl/w32/file_url.cxx @@ -305,11 +305,12 @@ DWORD IsValidFilePath(rtl_uString *path, DWORD dwFlags, rtl_uString **corrected) return bValid ? dwPathType : PATHTYPE_ERROR; } +// Expects a proper absolute or relative path static sal_Int32 PathRemoveFileSpec(LPWSTR lpPath, LPWSTR lpFileName, sal_Int32 nFileBufLen ) { sal_Int32 nRemoved = 0; -if ( nFileBufLen ) +if (nFileBufLen && wcscmp(lpPath, L"") != 0) // tdf#98343 do not remove leading UNC backslashes! { lpFileName[0] = 0; LPWSTR lpLastBkSlash = wcsrchr( lpPath, '\\' ); @@ -359,7 +360,7 @@ static LPWSTR PathAddBackslash(LPWSTR lpPath, sal_uInt32 nBufLen) return lpEndPath; } -// Same as GetLongPathName but also 95/NT4 +// Expects a proper absolute or relative path. NB: It is different from GetLongPathName WinAPI! static DWORD GetCaseCorrectPathNameEx( LPWSTR lpszPath, // path buffer to convert sal_uInt32 cchBuffer, // size of path buffer ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122118] New: Toolbar dropdown button icons are too large
https://bugs.documentfoundation.org/show_bug.cgi?id=122118 Bug ID: 122118 Summary: Toolbar dropdown button icons are too large Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: michael.me...@collabora.com Created attachment 147567 --> https://bugs.documentfoundation.org/attachment.cgi?id=147567=edit Screenshot The little triangles next to dropdown toolbar buttons are too large. See comparison screenshot. Observed using LO 6.3.0.0.alpha0+ (68aef0a3df1dd4c83dc3c26e4d3280649f4d3265) / Windows 7. Looks fine in 6.2 beta1. => regression Bibisected to the following commit using repo bibisect-win32-6.3. Adding Cc: to Michael Meeks, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=b62c43d1200e524369d9c7c2bd1dad3044efd672 author Michael Meeks 2018-11-23 02:14:00 + committer Michael Meeks 2018-11-26 18:54:08 +0100 Anti-alias toolbar button drop-downs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #187 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/2d6e0bdda331dc6343972f9ec786335aa8ddc674%5E%21 tdf#45904 Move XRefreshable Java tests to C++ It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/objdsc sc/CppunitTest_sc_headerfieldsobj.mk sc/Module_sc.mk sc/qa
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScHeaderFieldsObj.csv |3 sc/CppunitTest_sc_headerfieldsobj.mk | 43 sc/Module_sc.mk |1 sc/qa/extras/scheaderfieldsobj.cxx| 104 ++ 4 files changed, 148 insertions(+), 3 deletions(-) New commits: commit 2d6e0bdda331dc6343972f9ec786335aa8ddc674 Author: Jens Carl AuthorDate: Sat Dec 8 08:22:48 2018 + Commit: Jens Carl CommitDate: Sat Dec 15 06:47:46 2018 +0100 tdf#45904 Move XRefreshable Java tests to C++ Move XRefreshable Java tests to C++ for ScHeaderFieldsObj. Change-Id: Ia922b11e93f38bfc56795cc34c150b3429fd5447 Reviewed-on: https://gerrit.libreoffice.org/64798 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScHeaderFieldsObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScHeaderFieldsObj.csv index 86875218abdd..532a598aeea2 100644 --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScHeaderFieldsObj.csv +++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScHeaderFieldsObj.csv @@ -1,6 +1,3 @@ -"ScHeaderFieldsObj";"com::sun::star::util::XRefreshable";"refresh()" -"ScHeaderFieldsObj";"com::sun::star::util::XRefreshable";"addRefreshListener()" -"ScHeaderFieldsObj";"com::sun::star::util::XRefreshable";"removeRefreshListener()" "ScHeaderFieldsObj";"com::sun::star::container::XElementAccess";"getElementType()" "ScHeaderFieldsObj";"com::sun::star::container::XElementAccess";"hasElements()" "ScHeaderFieldsObj";"com::sun::star::container::XEnumerationAccess";"createEnumeration()" diff --git a/sc/CppunitTest_sc_headerfieldsobj.mk b/sc/CppunitTest_sc_headerfieldsobj.mk new file mode 100644 index ..c8257738ae11 --- /dev/null +++ b/sc/CppunitTest_sc_headerfieldsobj.mk @@ -0,0 +1,43 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +#* +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +#* + +$(eval $(call gb_CppunitTest_CppunitTest,sc_headerfieldsobj)) + +$(eval $(call gb_CppunitTest_use_external,sc_headerfieldsobj,boost_headers)) + +$(eval $(call gb_CppunitTest_add_exception_objects,sc_headerfieldsobj, \ +sc/qa/extras/scheaderfieldsobj \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,sc_headerfieldsobj, \ + cppu \ + sal \ + subsequenttest \ + test \ + unotest \ +)) + +$(eval $(call gb_CppunitTest_set_include,sc_headerfieldsobj,\ + $$(INCLUDE) \ +)) + +$(eval $(call gb_CppunitTest_use_sdk_api,sc_headerfieldsobj)) + +$(eval $(call gb_CppunitTest_use_ure,sc_headerfieldsobj)) +$(eval $(call gb_CppunitTest_use_vcl,sc_headerfieldsobj)) + +$(eval $(call gb_CppunitTest_use_components,sc_headerfieldsobj,\ +$(sc_unoapi_common_components) \ +)) + +$(eval $(call gb_CppunitTest_use_configuration,sc_headerfieldsobj)) + +# vim: set noet sw=4 ts=4: diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk index a4fa70eb4abd..95bfd089dd13 100644 --- a/sc/Module_sc.mk +++ b/sc/Module_sc.mk @@ -135,6 +135,7 @@ $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\ CppunitTest_sc_filterdescriptorbaseobj \ CppunitTest_sc_functiondescriptionobj \ CppunitTest_sc_functionlistobj \ + CppunitTest_sc_headerfieldsobj \ CppunitTest_sc_headerfootercontentobj \ CppunitTest_sc_indexenumeration_cellannotationsenumeration \ CppunitTest_sc_indexenumeration_cellarealinksenumeration \ diff --git a/sc/qa/extras/scheaderfieldsobj.cxx b/sc/qa/extras/scheaderfieldsobj.cxx new file mode 100644 index ..ea1379c37c50 --- /dev/null +++ b/sc/qa/extras/scheaderfieldsobj.cxx @@ -0,0 +1,104 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#include + +using namespace css; +using namespace css::uno; + +namespace sc_apitest +{ +class ScCellFieldsObj : public CalcUnoApiTest, public apitest::XRefreshable +{ +public: +ScCellFieldsObj(); + +virtual uno::Reference init() override; +virtual void setUp() override; +virtual void tearDown() override; + +CPPUNIT_TEST_SUITE(ScCellFieldsObj);
[Libreoffice-bugs] [Bug 102250] FILESAVE: slow save with dump (see Comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=102250 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79654] Save XLSX consumes 100% memory and hangs with "bad allocation" (scfiltlo.dll)
https://bugs.documentfoundation.org/show_bug.cgi?id=79654 --- Comment #14 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114002] Unicode Hentaigana does not rotate in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=114002 --- Comment #16 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77279] FORMATTING: Underline Text with Italics
https://bugs.documentfoundation.org/show_bug.cgi?id=77279 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108457] Android 4.4: crash when open odp file
https://bugs.documentfoundation.org/show_bug.cgi?id=108457 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114009] Underline become not consistent in vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=114009 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107897] EDITING: Some images are not loaded after HTML table paste
https://bugs.documentfoundation.org/show_bug.cgi?id=107897 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105091] Using unicode caracter 2042 (asterism) switches language to Hindi
https://bugs.documentfoundation.org/show_bug.cgi?id=105091 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101873] Cursor jumps to the begin of the document after searching for text not found
https://bugs.documentfoundation.org/show_bug.cgi?id=101873 --- Comment #17 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63142] Outlining, Promote, Demote does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=63142 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122117] New: No Toggle effect On/Off in Edit > Track Changes
https://bugs.documentfoundation.org/show_bug.cgi?id=122117 Bug ID: 122117 Summary: No Toggle effect On/Off in Edit > Track Changes Product: LibreOffice Version: 6.0.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: consciencia...@gmail.com Description: There is no signal to show the ON or OFF status of Edit > Track Changes > Record I believe that a change in icon was intended but is missing. -- Version: 6.0.6.2 Build ID: 1:6.0.6-0ubuntu0.18.04.1 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: x11; Locale: en-US (en); Calc: group Steps to Reproduce: 1.open a document 2.press in menu Edit > Track Changes > Record 3.delete some arbitrary text... it should turn tan 4.open in menu Edit > Track Changes > Record ... there is no change, though it is recording Actual Results: 1. 2. 3.deleted text should turn tan 4.there is no change, though it is recording Expected Results: change in icon or menu item AND a change of some icon or indicator in status bar Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54953] CALC: Enhance "Insert" label appearance and Insert/Overwrite tooltips (per Comment 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=54953 --- Comment #17 from Pedro --- (In reply to Xisco Faulí from comment #16) > An enhancement can't be a regression... It worked in previous versions and no longer works, it is a regression (see comment #7) The word INSERT is missing (but the tooltip is working). If you do click on an empty area (not expected from an UI) it will switch mode and Over will be displayed. In my opinion enhancement and enhance do not apply to something broken... See Timur's comment #15 for suggestions to fix this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 116290, which changed state. Bug 116290 Summary: UI: Window size limited by length of menu bar (gtk3 only?) https://bugs.documentfoundation.org/show_bug.cgi?id=116290 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtksalmenu.hxx |1 + vcl/unx/gtk/gtksalmenu.cxx | 15 ++- 2 files changed, 15 insertions(+), 1 deletion(-) New commits: commit da9e424c556e25cf42eddc9d6fa22011e80359aa Author: Caolán McNamara AuthorDate: Fri Dec 14 15:22:59 2018 + Commit: Caolán McNamara CommitDate: Sat Dec 15 01:57:38 2018 +0100 tdf#116290 allow menubar to shrink past its minimum size with a scrolledwindow with a horizontal external policy which doesn't show a scrollbar, but allows the scrolledwindow to shrink past its child size Change-Id: Ia73fc819a16bef49008e7e41bcc2d523c28268b0 Reviewed-on: https://gerrit.libreoffice.org/65172 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx index 2c287aa93354..9ab448857085 100644 --- a/vcl/inc/unx/gtk/gtksalmenu.hxx +++ b/vcl/inc/unx/gtk/gtksalmenu.hxx @@ -55,6 +55,7 @@ private: boolmbReturnFocusToDocument; boolmbAddedGrab; GtkWidget* mpMenuBarContainerWidget; +GtkWidget* mpMenuAllowShrinkWidget; GtkWidget* mpMenuBarWidget; GtkWidget* mpCloseButton; VclPtrmpVCLMenu; diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx index f9053ce23f6f..f6f45cf4acad 100644 --- a/vcl/unx/gtk/gtksalmenu.cxx +++ b/vcl/unx/gtk/gtksalmenu.cxx @@ -528,6 +528,7 @@ GtkSalMenu::GtkSalMenu( bool bMenuBar ) : mbReturnFocusToDocument( false ), mbAddedGrab( false ), mpMenuBarContainerWidget( nullptr ), +mpMenuAllowShrinkWidget( nullptr ), mpMenuBarWidget( nullptr ), mpCloseButton( nullptr ), mpVCLMenu( nullptr ), @@ -815,10 +816,21 @@ void GtkSalMenu::CreateMenuBarWidget() gtk_grid_insert_row(pGrid, 0); gtk_grid_attach(pGrid, mpMenuBarContainerWidget, 0, 0, 1, 1); +mpMenuAllowShrinkWidget = gtk_scrolled_window_new(nullptr, nullptr); + gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(mpMenuAllowShrinkWidget), GTK_SHADOW_NONE); +// tdf#116290 external policy on scrolledwindow will not show a scrollbar, +// but still allow scrolled window to not be sized to the child content. +// So the menubar can be shrunk past its nominal smallest width. +// Unlike a hack using GtkFixed/GtkLayout the correct placement of the menubar occurs under RTL + gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(mpMenuAllowShrinkWidget), GTK_POLICY_EXTERNAL, GTK_POLICY_NEVER); +gtk_grid_attach(GTK_GRID(mpMenuBarContainerWidget), mpMenuAllowShrinkWidget, 0, 0, 1, 1); + mpMenuBarWidget = gtk_menu_bar_new_from_model(mpMenuModel); gtk_widget_insert_action_group(mpMenuBarWidget, "win", mpActionGroup); gtk_widget_set_hexpand(GTK_WIDGET(mpMenuBarWidget), true); -gtk_grid_attach(GTK_GRID(mpMenuBarContainerWidget), mpMenuBarWidget, 0, 0, 1, 1); +gtk_widget_set_hexpand(mpMenuAllowShrinkWidget, true); +gtk_container_add(GTK_CONTAINER(mpMenuAllowShrinkWidget), mpMenuBarWidget); + g_signal_connect(G_OBJECT(mpMenuBarWidget), "deactivate", G_CALLBACK(MenuBarReturnFocus), this); g_signal_connect(G_OBJECT(mpMenuBarWidget), "key-press-event", G_CALLBACK(MenuBarSignalKey), this); @@ -826,6 +838,7 @@ void GtkSalMenu::CreateMenuBarWidget() ShowCloseButton( static_cast(mpVCLMenu.get())->HasCloseButton() ); #else +(void)mpMenuAllowShrinkWidget; (void)mpMenuBarContainerWidget; #endif } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtksalmenu.hxx |1 + vcl/unx/gtk/gtksalmenu.cxx | 15 ++- 2 files changed, 15 insertions(+), 1 deletion(-) New commits: commit 4f4f74642838d19278339fac9f8bc75ed8bfe1d5 Author: Caolán McNamara AuthorDate: Fri Dec 14 15:22:59 2018 + Commit: Caolán McNamara CommitDate: Sat Dec 15 01:57:59 2018 +0100 tdf#116290 allow menubar to shrink past its minimum size with a scrolledwindow with a horizontal external policy which doesn't show a scrollbar, but allows the scrolledwindow to shrink past its child size Change-Id: Ia73fc819a16bef49008e7e41bcc2d523c28268b0 Reviewed-on: https://gerrit.libreoffice.org/65171 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx index 2c287aa93354..9ab448857085 100644 --- a/vcl/inc/unx/gtk/gtksalmenu.hxx +++ b/vcl/inc/unx/gtk/gtksalmenu.hxx @@ -55,6 +55,7 @@ private: boolmbReturnFocusToDocument; boolmbAddedGrab; GtkWidget* mpMenuBarContainerWidget; +GtkWidget* mpMenuAllowShrinkWidget; GtkWidget* mpMenuBarWidget; GtkWidget* mpCloseButton; VclPtrmpVCLMenu; diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx index f9053ce23f6f..f6f45cf4acad 100644 --- a/vcl/unx/gtk/gtksalmenu.cxx +++ b/vcl/unx/gtk/gtksalmenu.cxx @@ -528,6 +528,7 @@ GtkSalMenu::GtkSalMenu( bool bMenuBar ) : mbReturnFocusToDocument( false ), mbAddedGrab( false ), mpMenuBarContainerWidget( nullptr ), +mpMenuAllowShrinkWidget( nullptr ), mpMenuBarWidget( nullptr ), mpCloseButton( nullptr ), mpVCLMenu( nullptr ), @@ -815,10 +816,21 @@ void GtkSalMenu::CreateMenuBarWidget() gtk_grid_insert_row(pGrid, 0); gtk_grid_attach(pGrid, mpMenuBarContainerWidget, 0, 0, 1, 1); +mpMenuAllowShrinkWidget = gtk_scrolled_window_new(nullptr, nullptr); + gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(mpMenuAllowShrinkWidget), GTK_SHADOW_NONE); +// tdf#116290 external policy on scrolledwindow will not show a scrollbar, +// but still allow scrolled window to not be sized to the child content. +// So the menubar can be shrunk past its nominal smallest width. +// Unlike a hack using GtkFixed/GtkLayout the correct placement of the menubar occurs under RTL + gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(mpMenuAllowShrinkWidget), GTK_POLICY_EXTERNAL, GTK_POLICY_NEVER); +gtk_grid_attach(GTK_GRID(mpMenuBarContainerWidget), mpMenuAllowShrinkWidget, 0, 0, 1, 1); + mpMenuBarWidget = gtk_menu_bar_new_from_model(mpMenuModel); gtk_widget_insert_action_group(mpMenuBarWidget, "win", mpActionGroup); gtk_widget_set_hexpand(GTK_WIDGET(mpMenuBarWidget), true); -gtk_grid_attach(GTK_GRID(mpMenuBarContainerWidget), mpMenuBarWidget, 0, 0, 1, 1); +gtk_widget_set_hexpand(mpMenuAllowShrinkWidget, true); +gtk_container_add(GTK_CONTAINER(mpMenuAllowShrinkWidget), mpMenuBarWidget); + g_signal_connect(G_OBJECT(mpMenuBarWidget), "deactivate", G_CALLBACK(MenuBarReturnFocus), this); g_signal_connect(G_OBJECT(mpMenuBarWidget), "key-press-event", G_CALLBACK(MenuBarSignalKey), this); @@ -826,6 +838,7 @@ void GtkSalMenu::CreateMenuBarWidget() ShowCloseButton( static_cast(mpVCLMenu.get())->HasCloseButton() ); #else +(void)mpMenuAllowShrinkWidget; (void)mpMenuBarContainerWidget; #endif } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122116] New: LibreOffice 6.1.* crashes by recovering file at start over and over on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=122116 Bug ID: 122116 Summary: LibreOffice 6.1.* crashes by recovering file at start over and over on Linux Product: LibreOffice Version: 6.1.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: andrasszerencs...@gmail.com Description: System: KDE neon 5.14 KDE Plasma Version: 5.14.4 KDE Frameworks Version: 5.53.0 QT Version: 5.11.2 Kernel Version: 4.15.0-42-generic OS Type: 64-bit // LibreOffice version in issue: Version: 6.1.3.2 Build ID: 1:6.1.3~rc2-0ubuntu0.18.04.2 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: CL // Used source: deb http://ppa.launchpad.net/libreoffice/libreoffice-prereleases/ubuntu bionic main / Current java versions appearing in libreoffice: 10.0.2 - location: /usr/lib/jvm/java-11-openjdk-amd64 1.8.0_191 - location: /usr/lib/jvm/java-8-openjdk-amd64/jre / My notes (First of all, there is an issue between AppArmor and LibreOffice on this system, a LOT. First I tried allowing everything step by step without success because a myriad profile appeared as denied awesomeness over and over so I just disabled all the basic usr.lib.libreoffice.program.* profile for LibreOffice in AppArmor at the end.) Obviously, first I tried to use the basic one implemented by given system above what is the very same version seemingly, at least as I noticed. important that this one what comes with the system by default behaves in the very same way. I hate to use PPAs, especially in neon what got a lot edgy sources in default already. KDE5 VCL is the very only reason I tried to install LibreOffice 6.2 because I thought it'll solve KDE issues such as the above crash, Global Application Menu, QT issues (right click menu appears on other monitor etc), etc. https://bugs.documentfoundation.org/show_bug.cgi?id=113397 Why I use the PPA? Prereleases Appimage won't work on this specific system and PC somehow, it closes right after the start, I tried several solution without success and there is not much or serious help for this particular Appimage. Flatpak stuck with 6.1 and as they said it'll stick with it for a wile and anyways KDE5 VCL will not be implemented even with Flatpak LO 6.2 version (what I don't really understand): https://github.com/flathub/org.libreoffice.LibreOffice/issues/63 . I '!don't like!' snap and it's also got 6.1 version. Despite the above PPA also contains only the 6.1 what I realized only later, somehow as it appears it works with Global Menu when I successfully got it open with the crash dialogue below and also it contains a promising package named libreoffice-kde5. / The most important part, the issue itself with PPA above On a clean start (~/.conf/libreoffice removed relogin) dialogue under LibreOffice Writer for example: --- "Due to an unexpected error, LibreOffice crashed. All the files you were working on will now be saved. The next time LibreOffice is launched, your files will be recovered automatically. The following files will be recovered:" --- (There is no file shown what will be recovered.) I found several sources what says it can be solved depending how you close it, with 'x' on main window or with 'ok' or 'x' or 'esc' on dialogue, well it doesn't matter. https://askubuntu.com/questions/244661/libreoffice-always-shows-recovery-process-at-startup-due-to-failing-recovery-ite --- After this I try to reopen LibreOffice and TWO dialogues appears right away. The first in background the typical recovery dialogue: --- "LibreOffice will attempt to recover the stat of the files you were working on before it crashed. Click 'Start' to begin the process, or click 'Discard' to cancel the recovery." --- The most interesting is that I don't even have time to click anything on the dialogue above, the below dialogue appears at the same time with it: --- "Due to an unexpected error, LibreOffice crashed. All the files you were working on will now be saved. The next time LibreOffice is launched, your files will be recovered automatically. The following files will be recovered: Untitled 1" --- It's the very same dialogue when LibreOffice crashes so it's just crashing right after it attempts to recovering given file and now an Untitled 1 file appears on the dialogue. Basically above quote simple a paradox, it's simple crashing by recovering the file and it says it will recover the file at the very same time. After this it's happening over and over when I try to
[Libreoffice-bugs] [Bug 113994] qt5 VCL plugin crashes on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=113994 --- Comment #12 from Bernhard Rosenkraenzer --- I'm running Plasma with X11, soffice.bin fails the same way as the wrapper. Note I'm still on 6.1 though, haven't built the 6.2 beta or git master yet (currently updating, should have news on that soon). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122115] New: While tracking changes "Sentence case" from menu does not appear as changed
https://bugs.documentfoundation.org/show_bug.cgi?id=122115 Bug ID: 122115 Summary: While tracking changes "Sentence case" from menu does not appear as changed Product: LibreOffice Version: 6.0.6.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: consciencia...@gmail.com While Edit > Track changes > Record, selected text changed through Format > Text > [lowercase, Uppercase, Sentence case] does not get marked as CHANGE -- Version: 6.0.6.2 Build ID: 1:6.0.6-0ubuntu0.18.04.1 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: x11; Locale: en-US (en); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/svg/svgexport.cxx | 65 ++-- filter/source/svg/svgfilter.cxx | 38 ++- filter/source/svg/svgfilter.hxx |8 3 files changed, 99 insertions(+), 12 deletions(-) New commits: commit d856ba77faa8db9300c99f7dcaa9101bdeca849b Author: Tamás Zolnai AuthorDate: Fri Dec 14 16:56:18 2018 +0100 Commit: Tamás Zolnai CommitDate: Sat Dec 15 01:34:48 2018 +0100 lok: Implement SVG export of selected Writer image A Writer image does not behave similar to other shapes, so we need to generate a shape to get the export code working. Change-Id: Icfb25ceb40f73f1018d379863b836d8303e539f3 Reviewed-on: https://gerrit.libreoffice.org/65176 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index 2dd294fba105..d74746f7cb38 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -31,6 +31,8 @@ #include #include #include +#include +#include #include #include @@ -51,6 +53,8 @@ #include #include #include +#include +#include #include @@ -531,7 +535,7 @@ bool SVGFilter::implExport( const Sequence< PropertyValue >& rDescriptor ) } } -if(mbWriterOrCalcFilter) +if(mbWriterFilter || mbCalcFilter) return implExportWriterOrCalc(xOStm); return implExportImpressOrDraw(xOStm); @@ -673,6 +677,45 @@ bool SVGFilter::implExportWriterOrCalc( const Reference< XOutputStream >& rxOStm return bRet; } +bool SVGFilter::implExportWriterTextGraphic( const Reference< view::XSelectionSupplier >& xSelectionSupplier ) +{ +Any selection = xSelectionSupplier->getSelection(); +uno::Reference xSelection; +selection >>= xSelection; +if (xSelection.is() && xSelection->supportsService("com.sun.star.text.TextGraphicObject")) +{ +uno::Reference xPropertySet(xSelection, uno::UNO_QUERY); +uno::Reference xGraphic; +xPropertySet->getPropertyValue("Graphic") >>= xGraphic; + +if (!xGraphic.is()) +return false; + +const Graphic aGraphic(xGraphic); + +// Calculate size from Graphic +Point aPos( OutputDevice::LogicToLogic(aGraphic.GetPrefMapMode().GetOrigin(), aGraphic.GetPrefMapMode(), MapMode(MapUnit::Map100thMM)) ); +Size aSize( OutputDevice::LogicToLogic(aGraphic.GetPrefSize(), aGraphic.GetPrefMapMode(), MapMode(MapUnit::Map100thMM)) ); + +assert(mSelectedPages.size() == 1); +SvxDrawPage* pSvxDrawPage(SvxDrawPage::getImplementation(mSelectedPages[0])); +if(pSvxDrawPage == nullptr || pSvxDrawPage->GetSdrPage() == nullptr) +return false; + +SdrGrafObj* pGraphicObj = new SdrGrafObj(pSvxDrawPage->GetSdrPage()->getSdrModelFromSdrPage(), aGraphic, tools::Rectangle( aPos, aSize )); +uno::Reference< drawing::XShape > xShape = GetXShapeForSdrObject(pGraphicObj); +uno::Reference< XPropertySet > xShapePropSet(xShape, uno::UNO_QUERY); +css::awt::Rectangle aBoundRect (aPos.X(), aPos.Y(), aSize.Width(), aSize.Height()); +xShapePropSet->setPropertyValue("BoundRect", uno::Any(aBoundRect)); +xShapePropSet->setPropertyValue("Graphic", uno::Any(xGraphic)); + +maShapeSelection = drawing::ShapeCollection::create(comphelper::getProcessComponentContext()); +maShapeSelection->add(xShape); +} + +return true; +} + Reference< XWriter > SVGFilter::implCreateExportDocumentHandler( const Reference< XOutputStream >& rxOStm ) { @@ -773,7 +816,7 @@ bool SVGFilter::implExportDocument() } } -if(mbWriterOrCalcFilter) +if(mbWriterFilter || mbCalcFilter) implExportDocumentHeaderWriterOrCalc(nDocX, nDocY, nDocWidth, nDocHeight); else implExportDocumentHeaderImpressOrDraw(nDocX, nDocY, nDocWidth, nDocHeight); @@ -2039,7 +2082,23 @@ bool SVGFilter::implCreateObjectsFromShape( const Reference< css::drawing::XDraw if( pObj ) { -const Graphic aGraphic(SdrExchangeView::GetObjGraphic(*pObj)); +Graphic aGraphic(SdrExchangeView::GetObjGraphic(*pObj)); + +// Writer graphic shapes are handled differently +if( mbWriterFilter && aGraphic.GetType() == GraphicType::NONE ) +{ +if (rxShape->getShapeType() == "com.sun.star.drawing.GraphicObjectShape") +{ +uno::Reference xPropertySet(rxShape, uno::UNO_QUERY); +uno::Reference xGraphic; +xPropertySet->getPropertyValue("Graphic") >>= xGraphic; + +if (!xGraphic.is()) +return false; + +aGraphic = Graphic(xGraphic); +} +} if( aGraphic.GetType() != GraphicType::NONE ) { diff --git a/filter/source/svg/svgfilter.cxx
[Libreoffice-bugs] [Bug 113994] qt5 VCL plugin crashes on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=113994 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #11 from Michael Weghorn --- I can't reproduce here with a current master build and running Debian testing with Plasma. Bernhard, Pekka: The following might help to narrow down the issue: 1) Are you running your Plasma session under X11 or Wayland? 2) Does the issue also occur when you directly run (adapt path as needed) e.g. SAL_USE_VCLPLUGIN=qt5 soffice.bin --writer i.e. you call 'soffice.bin' directly rather than using the 'soffice' shell wrapper that sets several environment variables (in '${instdir}/program/ooenv') that might cause the crash (for a reason, though...)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122114] New: Fix hardcoded location for .recently-used file
https://bugs.documentfoundation.org/show_bug.cgi?id=122114 Bug ID: 122114 Summary: Fix hardcoded location for .recently-used file Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: javi.po@gmail.com I've found that the location for the .recently-used file is hardcoded https://gerrit.libreoffice.org/plugins/gitiles/core/+/master/shell/source/unix/sysshell/recently_used_file.cxx#60 This should be inside of `$XDG_DATA_HOME` or at the very least be configurable through some other variable. The rest of the LibreOffice project has been compliant with xdg standards and I don't see why this location should be hardcoded as it is. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Instance.hxx |2 +- vcl/qt5/Qt5Instance.cxx | 13 - 2 files changed, 9 insertions(+), 6 deletions(-) New commits: commit d126c07e02963c1262eaa0f9f0aee0f8ed401550 Author: Katarina Behrens AuthorDate: Thu Dec 13 19:15:38 2018 +0100 Commit: Michael Weghorn CommitDate: Sat Dec 15 00:45:37 2018 +0100 tdf#122042: It's two clipboards, actually Change-Id: I0e975bb73211b1d4ddb2e721659f64b361d11322 (cherry picked from commit f89cf70331c5e493f26e292fd0d7796214efea55) Reviewed-on: https://gerrit.libreoffice.org/65167 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/vcl/inc/qt5/Qt5Instance.hxx b/vcl/inc/qt5/Qt5Instance.hxx index d848ff219792..91682bd87950 100644 --- a/vcl/inc/qt5/Qt5Instance.hxx +++ b/vcl/inc/qt5/Qt5Instance.hxx @@ -40,7 +40,7 @@ class VCLPLUG_QT5_PUBLIC Qt5Instance : public QObject, osl::Condition m_aWaitingYieldCond; int m_postUserEventId; const bool m_bUseCairo; -css::uno::Reference m_xClipboard; +std::unordered_map> m_aClipboards; public: std::unique_ptr m_pQApplication; diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx index 1acf49d4505a..2e21f2563d90 100644 --- a/vcl/qt5/Qt5Instance.cxx +++ b/vcl/qt5/Qt5Instance.cxx @@ -244,14 +244,17 @@ Qt5Instance::CreateClipboard(const css::uno::Sequence& arguments) css::uno::Reference(), -1); } -if (!m_xClipboard.is()) +auto it = m_aClipboards.find(sel); +if (it != m_aClipboards.end()) { -css::uno::Reference xClipboard( -static_cast(new VclQt5Clipboard())); -m_xClipboard = xClipboard; +return it->second; } -return m_xClipboard; +css::uno::Reference xClipboard( +static_cast(new VclQt5Clipboard())); +m_aClipboards[sel] = xClipboard; + +return xClipboard; } Reference Qt5Instance::CreateDragSource() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/source filter/Configuration_filter.mk filter/source
desktop/source/lib/init.cxx| 18 +-- filter/Configuration_filter.mk |2 filter/source/config/fragments/filters/calc_svg_Export.xcu | 30 + filter/source/svg/svgexport.cxx| 20 filter/source/svg/svgfilter.cxx| 18 +++ filter/source/svg/svgfilter.hxx| 18 +++ 6 files changed, 72 insertions(+), 34 deletions(-) New commits: commit 870d30c62bb5f579dfa4e6fb2e32dd796159f3b3 Author: Tamás Zolnai AuthorDate: Fri Dec 14 22:06:35 2018 +0100 Commit: Tamás Zolnai CommitDate: Sat Dec 15 00:20:21 2018 +0100 lok: Implement SVG export for Calc (SelectionOnly mode) Change-Id: Ic305e5305890fd1efa3a3130e5216f9c672870e5 Reviewed-on: https://gerrit.libreoffice.org/65175 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index e9675be766f6..0537d3808d61 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2619,13 +2619,19 @@ static size_t doc_renderShapeSelection(LibreOfficeKitDocument* pThis, char** pOu uno::Reference xOut = new utl::OOutputStreamWrapper(aOutStream); utl::MediaDescriptor aMediaDescriptor; -if (doc_getDocumentType(pThis) == LOK_DOCTYPE_PRESENTATION) -{ -aMediaDescriptor["FilterName"] <<= OUString("impress_svg_Export"); -} -else if(doc_getDocumentType(pThis) == LOK_DOCTYPE_TEXT) +switch (doc_getDocumentType(pThis)) { -aMediaDescriptor["FilterName"] <<= OUString("writer_svg_Export"); +case LOK_DOCTYPE_PRESENTATION: +aMediaDescriptor["FilterName"] <<= OUString("impress_svg_Export"); +break; +case LOK_DOCTYPE_TEXT: +aMediaDescriptor["FilterName"] <<= OUString("writer_svg_Export"); +break; +case LOK_DOCTYPE_SPREADSHEET: +aMediaDescriptor["FilterName"] <<= OUString("calc_svg_Export"); +break; +default: +SAL_WARN("lok", "Failed to render shape selection: Document type is not supported"); } aMediaDescriptor["SelectionOnly"] <<= true; aMediaDescriptor["OutputStream"] <<= xOut; diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk index b56e0ae39bc8..97023325c94e 100644 --- a/filter/Configuration_filter.mk +++ b/filter/Configuration_filter.mk @@ -802,11 +802,13 @@ $(eval $(call filter_Configuration_add_filters,fcfg_langpack,fcfg_writergraphics # fcfg_calcgraphics $(eval $(call filter_Configuration_add_types,fcfg_langpack,fcfg_calcgraphics_types.xcu,filter/source/config/fragments/types,\ png_Portable_Network_Graphic \ + svg_Scalable_Vector_Graphics \ )) $(eval $(call filter_Configuration_add_filters,fcfg_langpack,fcfg_calcgraphics_filters.xcu,filter/source/config/fragments/filters,\ calc_jpg_Export \ calc_png_Export \ + calc_svg_Export \ )) # fcfg_internalgraphics diff --git a/filter/source/config/fragments/filters/calc_svg_Export.xcu b/filter/source/config/fragments/filters/calc_svg_Export.xcu new file mode 100644 index ..703ce82e9778 --- /dev/null +++ b/filter/source/config/fragments/filters/calc_svg_Export.xcu @@ -0,0 +1,30 @@ + + +EXPORT ALIEN 3RDPARTYFILTER INTERNAL NOTINFILEDIALOG + +com.sun.star.comp.Draw.SVGFilter + + +SVG - Scalable Vector Graphics + +0 +svg_Scalable_Vector_Graphics + +com.sun.star.sheet.SpreadsheetDocument + diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index 729fd2e29c2c..2dd294fba105 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -531,13 +531,13 @@ bool SVGFilter::implExport( const Sequence< PropertyValue >& rDescriptor ) } } -if(mbWriterFilter) - return implExportWriter(xOStm); +if(mbWriterOrCalcFilter) + return implExportWriterOrCalc(xOStm); -return implExportImpressDraw(xOStm); +return implExportImpressOrDraw(xOStm); } -bool SVGFilter::implExportImpressDraw( const Reference< XOutputStream >& rxOStm) +bool SVGFilter::implExportImpressOrDraw( const Reference< XOutputStream >& rxOStm) { Reference< XComponentContext >xContext( ::comphelper::getProcessComponentContext() ) ; bool bRet = false; @@ -629,7 +629,7 @@ bool SVGFilter::implExportImpressDraw( const Reference< XOutputStream >& rxOStm) } -bool SVGFilter::implExportWriter( const Reference< XOutputStream >& rxOStm ) +bool SVGFilter::implExportWriterOrCalc( const Reference< XOutputStream >& rxOStm ) { Reference< XComponentContext >xContext(
[Libreoffice-bugs] [Bug 121560] Multiple but not all worksheets completely suddenly blank
https://bugs.documentfoundation.org/show_bug.cgi?id=121560 --- Comment #5 from studog --- Created attachment 147566 --> https://bugs.documentfoundation.org/attachment.cgi?id=147566=edit First backup after the problem recurrence -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121560] Multiple but not all worksheets completely suddenly blank
https://bugs.documentfoundation.org/show_bug.cgi?id=121560 --- Comment #4 from studog --- Created attachment 147565 --> https://bugs.documentfoundation.org/attachment.cgi?id=147565=edit Last backup before the problem recurrence -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121560] Multiple but not all worksheets completely suddenly blank
https://bugs.documentfoundation.org/show_bug.cgi?id=121560 --- Comment #3 from studog --- I've taken to backing up this spreadsheet, and the problem has recurred, I'll attach a before and after copy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122113] Icons blurry with visible artifacts with increased font scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=122113 oigyifquod changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122113] Icons blurry with visible artifacts with increased font scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=122113 --- Comment #3 from oigyifquod --- Created attachment 147564 --> https://bugs.documentfoundation.org/attachment.cgi?id=147564=edit Blurry icons with visible artifacts Blurry icons with visible artifacts -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/BarChart.cxx | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) New commits: commit abd9272ef1be9da58d405a0ddf3913a816a7e362 Author: Balazs Varga AuthorDate: Thu Dec 13 10:19:04 2018 +0100 Commit: László Németh CommitDate: Fri Dec 14 22:46:02 2018 +0100 Related: tdf#118705 Fix Column/Bar Chart data label placement Modify the chart data label rendering in case of Column/Bar chart only if the datapoint value is 0. This patch fix in case of NEAR_ORIGIN and CENTER DataLabelPlacement. Change-Id: Ia9857b5ac0cc5feaf2e1fd08e98c9f8534e5af04 Reviewed-on: https://gerrit.libreoffice.org/65082 Tested-by: Jenkins Reviewed-by: László Németh Tested-by: László Németh diff --git a/chart2/source/view/charttypes/BarChart.cxx b/chart2/source/view/charttypes/BarChart.cxx index 51dba0143bf2..42741fb37a2e 100644 --- a/chart2/source/view/charttypes/BarChart.cxx +++ b/chart2/source/view/charttypes/BarChart.cxx @@ -244,11 +244,13 @@ awt::Point BarChart::getLabelScreenPositionAndAlignment( { fY = (fBaseValue < fScaledUpperYValue) ? fScaledUpperYValue : fScaledLowerYValue; if( pPosHelper->isSwapXAndY() ) +// if datapoint value is 0 the label will appear RIGHT in case of Bar Chart if( fBaseValue == fScaledUpperYValue && fBaseValue == fScaledLowerYValue ) rAlignment = LABEL_ALIGN_RIGHT; else rAlignment = bNormalOutside ? LABEL_ALIGN_RIGHT : LABEL_ALIGN_LEFT; else +// if datapoint value is 0 the label will appear TOP in case of Column Chart if( fBaseValue == fScaledUpperYValue && fBaseValue == fScaledLowerYValue ) rAlignment = LABEL_ALIGN_TOP; else @@ -272,16 +274,31 @@ awt::Point BarChart::getLabelScreenPositionAndAlignment( { fY = (fBaseValue < fScaledUpperYValue) ? fScaledLowerYValue : fScaledUpperYValue; if( pPosHelper->isSwapXAndY() ) -rAlignment = bNormalOutside ? LABEL_ALIGN_RIGHT : LABEL_ALIGN_LEFT; +// if datapoint value is 0 the label will appear RIGHT in case of Bar Chart +if( fBaseValue == fScaledUpperYValue && fBaseValue == fScaledLowerYValue ) +rAlignment = LABEL_ALIGN_RIGHT; +else +rAlignment = bNormalOutside ? LABEL_ALIGN_RIGHT : LABEL_ALIGN_LEFT; else -rAlignment = bNormalOutside ? LABEL_ALIGN_TOP : LABEL_ALIGN_BOTTOM; +// if datapoint value is 0 the label will appear TOP in case of Column Chart +if( fBaseValue == fScaledUpperYValue && fBaseValue == fScaledLowerYValue ) +rAlignment = LABEL_ALIGN_TOP; +else +rAlignment = bNormalOutside ? LABEL_ALIGN_TOP : LABEL_ALIGN_BOTTOM; if(m_nDimension==3) fDepth = (fBaseValue < fScaledUpperYValue) ? fabs(fScaledLowerBarDepth) : fabs(fScaledUpperBarDepth); } break; case css::chart::DataLabelPlacement::CENTER: fY -= (fScaledUpperYValue-fScaledLowerYValue)/2.0; -rAlignment = LABEL_ALIGN_CENTER; +// if datapoint value is 0 the label will appear TOP/RIGHT in case of Column/Bar Charts +if( fBaseValue == fScaledUpperYValue && fBaseValue == fScaledLowerYValue ) +if( pPosHelper->isSwapXAndY() ) +rAlignment = LABEL_ALIGN_RIGHT; +else +rAlignment = LABEL_ALIGN_TOP; +else +rAlignment = LABEL_ALIGN_CENTER; if(m_nDimension==3) fDepth = fabs(fScaledUpperBarDepth-fScaledLowerBarDepth)/2.0; break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122113] Icons blurry with visible artifacts with increased font scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=122113 --- Comment #2 from oigyifquod --- Created attachment 147563 --> https://bugs.documentfoundation.org/attachment.cgi?id=147563=edit Font scaling set to 1.5 Font scaling set to 1.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122113] Icons blurry with visible artifacts with increased font scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=122113 --- Comment #1 from oigyifquod --- Created attachment 147562 --> https://bugs.documentfoundation.org/attachment.cgi?id=147562=edit System info System info -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122113] New: Icons blurry with visible artifacts with increased font scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=122113 Bug ID: 122113 Summary: Icons blurry with visible artifacts with increased font scaling Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: anonymous_...@live.co.uk Description: Using Fedora 29 64-bit, Cinnamon (v4.0.5) edition. Icons become blurry with visible artifacts when font scaling is set above 1.0 https://imgur.com/a/4AZXs6f Steps to Reproduce: 1. Set font scaling to 1.5 in system settings 2. Open LibreOffice Actual Results: Icons are blurry with visible artifacts Expected Results: Icons not blurry with no visible artifacts, icons should scale perfectly. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source sfx2/source
desktop/source/lib/init.cxx |3 ++- sfx2/source/control/unoctitm.cxx |1 + 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 13998b050f445bac3593a8bb77b7320d1be9990d Author: Tamás Zolnai AuthorDate: Fri Dec 14 17:36:41 2018 +0100 Commit: Tamás Zolnai CommitDate: Fri Dec 14 22:04:41 2018 +0100 lok: Handle Special character menu item's state correctly in online Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f Reviewed-on: https://gerrit.libreoffice.org/65188 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 65ccfdf4a411..e9675be766f6 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1911,7 +1911,8 @@ static void doc_iniUnoCommands () OUString(".uno:TransformDialog"), OUString(".uno:InsertPageHeader"), OUString(".uno:InsertPageFooter"), -OUString(".uno:OnlineAutoFormat") +OUString(".uno:OnlineAutoFormat"), +OUString(".uno:InsertSymbol") }; util::URL aCommandURL; diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index 2af30984afe9..94e4b16cc764 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1062,6 +1062,7 @@ static void InterceptLOKStateChangeEvent(const SfxViewFrame* pViewFrame, const c aEvent.FeatureURL.Path == "InsertRowsAfter" || aEvent.FeatureURL.Path == "InsertColumnsBefore" || aEvent.FeatureURL.Path == "InsertColumnsAfter" || + aEvent.FeatureURL.Path == "InsertSymbol" || aEvent.FeatureURL.Path == "DeleteRows" || aEvent.FeatureURL.Path == "DeleteColumns" || aEvent.FeatureURL.Path == "DeleteTable" || ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34694] [META] Improve usability of error messages
https://bugs.documentfoundation.org/show_bug.cgi?id=34694 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||98556 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98556 [Bug 98556] Reports docx files as corrupt if a writer is not installed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98556] Reports docx files as corrupt if a writer is not installed.
https://bugs.documentfoundation.org/show_bug.cgi?id=98556 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||34694 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=34694 [Bug 34694] [META] Improve usability of error messages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101952] UI bug when switching "Maximize" and "Unmaximize" when using gen/X11 backend
https://bugs.documentfoundation.org/show_bug.cgi?id=101952 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||119901 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119901 [Bug 119901] [META] Bugs related to maximized window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119901] [META] Bugs related to maximized window
https://bugs.documentfoundation.org/show_bug.cgi?id=119901 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||101952 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101952 [Bug 101952] UI bug when switching "Maximize" and "Unmaximize" when using gen/X11 backend -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108430] [META] Mouse cursor bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108430 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||104169 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104169 [Bug 104169] Change the mouse cursor icon when hovering the spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 104169] Change the mouse cursor icon when hovering the spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=104169 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108430 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108430 [Bug 108430] [META] Mouse cursor bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104169] Change the mouse cursor icon when hovering the spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=104169 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108430 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108430 [Bug 108430] [META] Mouse cursor bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112078] FILEOPEN: Add services button has unnecessary arrow when no services have been added
https://bugs.documentfoundation.org/show_bug.cgi?id=112078 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102732 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102732 [Bug 102732] [META] File dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102732] [META] File dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102732 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||112078 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112078 [Bug 112078] FILEOPEN: Add services button has unnecessary arrow when no services have been added -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||104382 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104382 [Bug 104382] Menus should be disabled when they have no enabled submenus -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||104382 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104382 [Bug 104382] Menus should be disabled when they have no enabled submenus -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104382] Menus should be disabled when they have no enabled submenus
https://bugs.documentfoundation.org/show_bug.cgi?id=104382 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||85811, 101912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=85811 [Bug 85811] [META] Main menu bar bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104382] Menus should be disabled when they have no enabled submenus
https://bugs.documentfoundation.org/show_bug.cgi?id=104382 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded but we should have full list of that menu items -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||105167 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105167 [Bug 105167] media playback toolbar - clicking on mute-button or dragging volume-control moves seek-control and video forward -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105167] media playback toolbar - clicking on mute-button or dragging volume-control moves seek-control and video forward
https://bugs.documentfoundation.org/show_bug.cgi?id=105167 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||103239 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122111] Hex2DEC not converting right
https://bugs.documentfoundation.org/show_bug.cgi?id=122111 --- Comment #4 from MM --- https://www.binaryhexconverter.com/hex-to-decimal-converter, https://hextodecimal.org/ or https://www.rapidtables.com/convert/number/hex-to-decimal.html gives 918232721453 as an answer. If I convert -181278906323 back to hex I get FFD5CAEF682D. So it seems the calculation of LO, AOO and gnumeric are wrong. They don't look for the first FF, which gives a negative. Or the first 6 are always set as F's by default. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - connectivity/qa connectivity/source
connectivity/qa/connectivity/mysql/mysql.cxx|2 + connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx | 29 +++- connectivity/source/drivers/mysqlc/mysqlc_resultset.hxx |4 +- 3 files changed, 24 insertions(+), 11 deletions(-) New commits: commit 7ca071120941f04b97e4d855102e88e87fe4cfa5 Author: Tamas Bunth AuthorDate: Mon Dec 10 10:43:14 2018 +0100 Commit: Andras Timar CommitDate: Fri Dec 14 21:22:51 2018 +0100 mysqlc: Fix obtaining field information in rs Result set field information should be stored correctly. It is queried from database on demand and stored locally. Change-Id: Ia62c62e6db32b45640b9fcd5f48c6249aecc41a2 Reviewed-on: https://gerrit.libreoffice.org/64861 Tested-by: Jenkins Reviewed-by: Tamás Bunth Reviewed-on: https://gerrit.libreoffice.org/65160 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/connectivity/qa/connectivity/mysql/mysql.cxx b/connectivity/qa/connectivity/mysql/mysql.cxx index f5e878590363..1a6d1e89e0e8 100644 --- a/connectivity/qa/connectivity/mysql/mysql.cxx +++ b/connectivity/qa/connectivity/mysql/mysql.cxx @@ -165,6 +165,7 @@ void MysqlTestDriver::testIntegerInsertAndQuery() Reference xResultSet = xStatement->executeQuery("SELECT id from myTestTable"); CPPUNIT_ASSERT_MESSAGE("result set cannot be instantiated after query", xResultSet.is()); Reference xRow(xResultSet, UNO_QUERY); +Reference xColumnLocate(xResultSet, UNO_QUERY); CPPUNIT_ASSERT_MESSAGE("cannot extract row from result set!", xRow.is()); for (long i = 0; i < ROW_COUNT; ++i) @@ -172,6 +173,7 @@ void MysqlTestDriver::testIntegerInsertAndQuery() bool hasRow = xResultSet->next(); CPPUNIT_ASSERT_MESSAGE("not enough result after query", hasRow); CPPUNIT_ASSERT_EQUAL(i, xRow->getLong(1)); // first and only column +CPPUNIT_ASSERT_EQUAL(i, xRow->getLong(xColumnLocate->findColumn("id"))); // test findColumn } CPPUNIT_ASSERT_MESSAGE("Cursor is not on last position.", xResultSet->isLast()); // cursor is on last position diff --git a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx index 392a037b3ed3..2c680d7e1328 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx @@ -136,6 +136,18 @@ void OResultSet::ensureResultFetched() } } +void OResultSet::ensureFieldInfoFetched() +{ +if (!m_aFields.empty()) +return; +unsigned nFieldCount = mysql_num_fields(m_pResult); +MYSQL_FIELD* pFields = mysql_fetch_fields(m_pResult); +m_aFields.reserve(nFieldCount); +for (unsigned i = 0; i < nFieldCount; ++i) +m_aFields.push_back(OUString{ +pFields[i].name, static_cast(strlen(pFields[i].name)), m_encoding }); +} + void OResultSet::fetchResult() { // Mysql C API does not allow simultaneously opened result sets, but sdbc does. @@ -145,20 +157,18 @@ void OResultSet::fetchResult() // TODO ensure that m_nRowCount = mysql_num_rows(m_pResult); +ensureFieldInfoFetched(); + // fetch all the data m_aRows.reserve(m_nRowCount); -m_nFieldCount = mysql_num_fields(m_pResult); -MYSQL_FIELD* pFields = mysql_fetch_fields(m_pResult); -m_aFields.assign(pFields, pFields + m_nFieldCount); - for (sal_Int32 row = 0; row < m_nRowCount; ++row) { MYSQL_ROW data = mysql_fetch_row(m_pResult); unsigned long* lengths = mysql_fetch_lengths(m_pResult); m_aRows.push_back(DataFields{}); // MYSQL_ROW is char**, array of strings -for (unsigned col = 0; col < m_nFieldCount; ++col) +for (std::size_t col = 0; col < m_aFields.size(); ++col) { m_aRows.back().push_back(OString{ data[col], static_cast(lengths[col]) }); } @@ -204,11 +214,12 @@ sal_Int32 SAL_CALL OResultSet::findColumn(const rtl::OUString& columnName) { MutexGuard aGuard(m_aMutex); checkDisposed(OResultSet_BASE::rBHelper.bDisposed); +ensureFieldInfoFetched(); -for (unsigned int i = 0; i < m_nFieldCount; ++i) +for (std::size_t i = 0; i < m_aFields.size(); ++i) { -if (columnName.equalsIgnoreAsciiCaseAscii(m_aFields[i].name)) -return i + 1; // sdbc indexes from 1 +if (columnName.equalsIgnoreAsciiCase(m_aFields[i])) +return static_cast(i) + 1; // sdbc indexes from 1 } throw SQLException("The column name '" + columnName + "' is not valid.", *this, "42S22", 0, @@ -1094,7 +1105,7 @@ css::uno::Reference SAL_CALL OResultSet::getProper void OResultSet::checkColumnIndex(sal_Int32 index) { -if (index < 1 || index > static_cast(m_nFieldCount)) +if (index < 1 || index > static_cast(m_aFields.size())) { /* static object for efficiency or thread safety is a problem ? */
[Libreoffice-bugs] [Bug 119931] Fix accessibility warnings in .ui files
https://bugs.documentfoundation.org/show_bug.cgi?id=119931 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||101912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||119931 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119931 [Bug 119931] Fix accessibility warnings in .ui files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120999] calc toolbar media arrangement
https://bugs.documentfoundation.org/show_bug.cgi?id=120999 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||113359 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113359 [Bug 113359] [META] Calc toolbar bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120999] calc toolbar media arrangement
https://bugs.documentfoundation.org/show_bug.cgi?id=120999 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||113359 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113359 [Bug 113359] [META] Calc toolbar bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113359] [META] Calc toolbar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113359 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||120999 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120999 [Bug 120999] calc toolbar media arrangement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108804] [META] Print preview bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108804 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121086 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121086 [Bug 121086] The first page in print preview shifts to the left when exporting to PDF (visual glitch) (gen) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121086] The first page in print preview shifts to the left when exporting to PDF (visual glitch) (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=121086 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108804 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108804 [Bug 108804] [META] Print preview bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||122002 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122002 [Bug 122002] Mail Merge toolbar hidden on next run if it was manually enabled -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||122002 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122002 [Bug 122002] Mail Merge toolbar hidden on next run if it was manually enabled -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122002] Mail Merge toolbar hidden on next run if it was manually enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=122002 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102998, 103239 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102998 [Bug 102998] [META] Mail merge bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103239 [Bug 103239] [META] Toolbars bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122002] Mail Merge toolbar hidden on next run if it was manually enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=122002 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||mikekagan...@hotmail.com --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Mike, there is a bug about your love MM toolbar :D -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122108] FILEOPEN XLSX, Conditional formatting missing its pattern when opened in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=122108 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug.I can confirm that the pattern background changes to a color background instead of remaining the same in Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||64438 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=64438 [Bug 64438] Dockable panels in LibreOffice not dockable using KDE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122110] FILESAVE XLSX, One of the cell changes its textcolor to blue for no apparent reason.
https://bugs.documentfoundation.org/show_bug.cgi?id=122110 --- Comment #4 from Durgapriyanka --- Thank you for reporting the bug. I can not reproduce the bug in Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64438] Dockable panels in LibreOffice not dockable using KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=64438 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102495 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122109] FILEOPEN XLSX, Table loses its style when opened in LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=122109 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. I can confirm that the bug is present in Microsoft excel 2007 Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded I do see that the table loses its style when opened in LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabvwsh2.cxx | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) New commits: commit edf6819a7dca6348954d6cbefb19631448602774 Author: Tamás Zolnai AuthorDate: Fri Dec 14 16:56:25 2018 +0100 Commit: Tamás Zolnai CommitDate: Fri Dec 14 20:32:43 2018 +0100 lok: Insert shape at the positon of the selected cell Calculation of the visible area is not working correctly in online case which leads to positioning of the shape outisde of the view. Instead of that calculation use the selected cell's position to insert the shape at, similar how image insertion works. Change-Id: I5c887261556c491962ed19f416ce480a63c24a9a Reviewed-on: https://gerrit.libreoffice.org/65177 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/sc/source/ui/view/tabvwsh2.cxx b/sc/source/ui/view/tabvwsh2.cxx index 531aa9052f9c..b21fdd31fd0c 100644 --- a/sc/source/ui/view/tabvwsh2.cxx +++ b/sc/source/ui/view/tabvwsh2.cxx @@ -324,11 +324,21 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq) sal_uInt32 nDefaultObjectSizeHeight = rAppOpt.GetDefaultObjectSizeHeight(); // calc position and size -tools::Rectangle aVisArea = pWin->PixelToLogic(tools::Rectangle(Point(0,0), pWin->GetOutputSizePixel())); -Point aPagePos = aVisArea.Center(); -aPagePos.AdjustX( -sal_Int32(nDefaultObjectSizeWidth / 2) ); -aPagePos.AdjustY( -sal_Int32(nDefaultObjectSizeHeight / 2) ); -tools::Rectangle aNewObjectRectangle(aPagePos, Size(nDefaultObjectSizeWidth, nDefaultObjectSizeHeight)); +bool bLOKIsActive = comphelper::LibreOfficeKit::isActive(); +Point aInsertPos; +if(!bLOKIsActive) +{ +tools::Rectangle aVisArea = pWin->PixelToLogic(tools::Rectangle(Point(0,0), pWin->GetOutputSizePixel())); +aInsertPos = aVisArea.Center(); +aInsertPos.AdjustX( -sal_Int32(nDefaultObjectSizeWidth / 2) ); +aInsertPos.AdjustY( -sal_Int32(nDefaultObjectSizeHeight / 2) ); +} +else +{ +aInsertPos = GetInsertPos(); +} + +tools::Rectangle aNewObjectRectangle(aInsertPos, Size(nDefaultObjectSizeWidth, nDefaultObjectSizeHeight)); ScDrawView* pDrView = GetScDrawView(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122107] FILEOPEN XLSX, Header is missing in LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=122107 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. I can confirm that the bug is present in Microsoft Excel 2007 Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122094] FILEOPEN XLSX, Conditional formatting condition not working the same in LO as MSO.
https://bugs.documentfoundation.org/show_bug.cgi?id=122094 Durgapriyanka changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. I can confirm that the bug is present in Microsoft excel 2007 Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source filter/Configuration_filter.mk filter/source
desktop/source/lib/init.cxx |9 filter/Configuration_filter.mk |2 filter/source/config/fragments/filters/writer_svg_Export.xcu | 30 + filter/source/svg/svgexport.cxx | 245 +++ filter/source/svg/svgfilter.cxx | 82 +++ filter/source/svg/svgfilter.hxx | 42 + 6 files changed, 312 insertions(+), 98 deletions(-) New commits: commit b052974a6574e4074794ffa590fe60f7c1726768 Author: Tamás Zolnai AuthorDate: Fri Dec 14 17:50:18 2018 +0100 Commit: Tamás Zolnai CommitDate: Fri Dec 14 19:52:48 2018 +0100 lok: Implement SVG export for Writer (SelectionOnly mode) Separate generic code from Impress / Draw specific code and implement shape selection handling in case of Writer. This is an internal filter, so it can be called only from the code. Change-Id: I807e04a0949530d6029037bb964c10c80197ff33 Reviewed-on: https://gerrit.libreoffice.org/65174 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 90994a92c257..65ccfdf4a411 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2618,7 +2618,14 @@ static size_t doc_renderShapeSelection(LibreOfficeKitDocument* pThis, char** pOu uno::Reference xOut = new utl::OOutputStreamWrapper(aOutStream); utl::MediaDescriptor aMediaDescriptor; -aMediaDescriptor["FilterName"] <<= OUString("impress_svg_Export"); +if (doc_getDocumentType(pThis) == LOK_DOCTYPE_PRESENTATION) +{ +aMediaDescriptor["FilterName"] <<= OUString("impress_svg_Export"); +} +else if(doc_getDocumentType(pThis) == LOK_DOCTYPE_TEXT) +{ +aMediaDescriptor["FilterName"] <<= OUString("writer_svg_Export"); +} aMediaDescriptor["SelectionOnly"] <<= true; aMediaDescriptor["OutputStream"] <<= xOut; diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk index d7a6322e5564..b56e0ae39bc8 100644 --- a/filter/Configuration_filter.mk +++ b/filter/Configuration_filter.mk @@ -790,11 +790,13 @@ $(eval $(call filter_Configuration_add_filters,fcfg_langpack,fcfg_impressgraphic $(eval $(call filter_Configuration_add_types,fcfg_langpack,fcfg_writergraphics_types.xcu,filter/source/config/fragments/types,\ jpg_JPEG \ png_Portable_Network_Graphic \ + svg_Scalable_Vector_Graphics \ )) $(eval $(call filter_Configuration_add_filters,fcfg_langpack,fcfg_writergraphics_filters.xcu,filter/source/config/fragments/filters,\ writer_jpg_Export \ writer_png_Export \ + writer_svg_Export \ )) # fcfg_calcgraphics diff --git a/filter/source/config/fragments/filters/writer_svg_Export.xcu b/filter/source/config/fragments/filters/writer_svg_Export.xcu new file mode 100644 index ..c08576cdd69b --- /dev/null +++ b/filter/source/config/fragments/filters/writer_svg_Export.xcu @@ -0,0 +1,30 @@ + + +EXPORT ALIEN 3RDPARTYFILTER INTERNAL NOTINFILEDIALOG + +com.sun.star.comp.Draw.SVGFilter + + +SVG - Scalable Vector Graphics + +0 +svg_Scalable_Vector_Graphics + +com.sun.star.text.TextDocument + diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index babf682a024f..729fd2e29c2c 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -504,12 +504,10 @@ bool EqualityBitmap::operator()( const ObjectRepresentation& rObjRep1, bool SVGFilter::implExport( const Sequence< PropertyValue >& rDescriptor ) { -Reference< XComponentContext >xContext( ::comphelper::getProcessComponentContext() ) ; Reference< XOutputStream >xOStm; std::unique_ptr pOStm; sal_Int32 nLength = rDescriptor.getLength(); const PropertyValue* pValue = rDescriptor.getConstArray(); -bool bRet = false; maFilterData.realloc( 0 ); @@ -533,11 +531,22 @@ bool SVGFilter::implExport( const Sequence< PropertyValue >& rDescriptor ) } } -if( xOStm.is() ) +if(mbWriterFilter) + return implExportWriter(xOStm); + +return implExportImpressDraw(xOStm); +} + +bool SVGFilter::implExportImpressDraw( const Reference< XOutputStream >& rxOStm) +{ +Reference< XComponentContext >xContext( ::comphelper::getProcessComponentContext() ) ; +bool bRet = false; + +if( rxOStm.is() ) { if( !mSelectedPages.empty() && !mMasterPageTargets.empty() ) { -Reference< XDocumentHandler > xDocHandler( implCreateExportDocumentHandler( xOStm ), UNO_QUERY ); +Reference< XDocumentHandler
[Libreoffice-bugs] [Bug 114192] Call psp::PrintFontManager::analyzeFontFile font scan only when needed
https://bugs.documentfoundation.org/show_bug.cgi?id=114192 Xisco Faulí changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90805] TOOLBAR: Enabling border color on an image should enable border
https://bugs.documentfoundation.org/show_bug.cgi?id=90805 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54953] CALC: Enhance "Insert" label appearance and Insert/Overwrite tooltips (per Comment 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=54953 Xisco Faulí changed: What|Removed |Added Keywords|bibisected, regression | --- Comment #16 from Xisco Faulí --- An enhancement can't be a regression... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122093] FILESAVE XLSX, Conditional formatting format changes when saved in LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=122093 Durgapriyanka changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Durgapriyanka --- Thank you for reporting the bug. I can confirm that the bug is present in Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Weekly QA Report (W49-2018)
Hi Thorsten, I imagine I misunderstood you when we talked about it in IRC. In the last monthly report I added a section to show when the keyword 'regression' was added and by whom [1] but what you were actually asking for was the evolution of regressions. Now I get it :-) I'll try to implement it for the next monthly report. Thanks for the suggestion Regards [1] https://qa.blog.documentfoundation.org/2018/12/04/qa-report-november-2018/ El 13/12/18 a les 0:04, Thorsten Behrens ha escrit: > Hi Xisco, > > Xisco Fauli wrote: >> Generated on 2018-12-11 based on stats from 2018-12-09. Note: Metabugs >> are ignored. >> > Thx a bunch for the weekly stats, and the extra data on the blog > (https://qa.blog.documentfoundation.org/2018/12/04/qa-report-november-2018/). > > As that question was asked from a number of people: any chance to add > a chart with the history of regressions, similar to the one for the > evolution of the unconfirmed bugs? > > Cheers, > > -- Thorsten > > ___ > List Name: Libreoffice-qa mailing list > Mail address: Libreoffice-qa@lists.freedesktop.org > Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa > Problems? > http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ > Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette > List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Xisco Faulí Libreoffice QA Team IRC: x1sc0 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: Branch 'private/mst/sw_redlinehide_4b' - 2 commits - sw/inc sw/source
sw/inc/swcrsr.hxx|3 sw/source/core/crsr/crsrsh.cxx |2 sw/source/core/crsr/findattr.cxx | 160 --- 3 files changed, 137 insertions(+), 28 deletions(-) New commits: commit 406a8b7d8b9e5acd993c261f3f0ccc9057e509ad Author: Michael Stahl AuthorDate: Fri Dec 14 18:18:12 2018 +0100 Commit: Michael Stahl CommitDate: Fri Dec 14 18:21:47 2018 +0100 sw_redlinehide_4b: adapt FindAttrs() Iterate over merged nodes, and iterate over extents in them, so the complex attribute-finding logic doesn't need to be changed. Change-Id: Id72ca9247165a0c93f0cf2a38b7a0249771ca2eb diff --git a/sw/source/core/crsr/findattr.cxx b/sw/source/core/crsr/findattr.cxx index 5d8da558aa89..d50e0c41d496 100644 --- a/sw/source/core/crsr/findattr.cxx +++ b/sw/source/core/crsr/findattr.cxx @@ -41,6 +41,7 @@ #include #include #include +#include #include #include @@ -976,7 +977,8 @@ typedef bool (*FnSearchAttr)( const SwTextNode&, SwAttrCheckArr&, SwPaM& ); static bool FindAttrsImpl(SwPaM & rSearchPam, const SfxItemSet& rSet, bool bNoColls, SwMoveFnCollection const & fnMove, -const SwPaM & rRegion, bool bInReadOnly, bool bMoveFirst) +const SwPaM & rRegion, bool bInReadOnly, bool bMoveFirst, +SwRootFrame const*const pLayout) { std::unique_ptr pPam(sw::MakeRegion(fnMove, rRegion)); @@ -1010,22 +1012,100 @@ static bool FindAttrsImpl(SwPaM & rSearchPam, pPam->GetPoint()->nContent.Assign( pNd, bSrchForward ? 0 : pNd->Len() ); } -while( nullptr != ( pNode = ::GetNode( *pPam, bFirst, fnMove, bInReadOnly ) ) ) +while (nullptr != (pNode = ::GetNode(*pPam, bFirst, fnMove, bInReadOnly, pLayout))) { +SwTextFrame const*const pFrame(pLayout && pNode->IsTextNode() +? static_cast(pNode->getLayoutFrame(pLayout)) +: nullptr); +assert(!pLayout || !pNode->IsTextNode() || pFrame); +// sw_redlinehide: it's apparently not possible to find break items +// with the UI, so checking one node is enough +SwContentNode const& rPropsNode(*(pFrame +? pFrame->GetTextNodeForParaProps() +: pNode)); + if( aCmpArr.Count() ) { if( !pNode->IsTextNode() ) // CharAttr are only in text nodes continue; -if( (!aOtherSet.Count() || -lcl_Search( *pNode, aOtherSet, bNoColls )) && -(*fnSearch)( *pNode->GetTextNode(), aCmpArr, *pPam )) +if (aOtherSet.Count() && +!lcl_Search(rPropsNode, aOtherSet, bNoColls)) +{ +continue; +} +sw::MergedPara const*const pMergedPara(pFrame ? pFrame->GetMergedPara() : nullptr); +if (pMergedPara) +{ +SwPosition const& rStart(*pPam->Start()); +SwPosition const& rEnd(*pPam->End()); +// no extents? fall back to searching index 0 of propsnode +// to find its node items +if (pMergedPara->extents.empty()) +{ +if (rStart.nNode.GetIndex() <= rPropsNode.GetIndex() +&& rPropsNode.GetIndex() <= rEnd.nNode.GetIndex()) +{ +SwPaM tmp(rPropsNode, 0, rPropsNode, 0); +bFound = (*fnSearch)(*pNode->GetTextNode(), aCmpArr, tmp); +if (bFound) +{ +*pPam = tmp; +} +} +} +else +{ +// iterate the extents, and intersect with input pPam: +// the found ranges should never include delete redlines +// so that subsequent Replace will not affect them +for (size_t i = 0; i < pMergedPara->extents.size(); ++i) +{ +auto const rExtent(pMergedPara->extents[bSrchForward +? i +: pMergedPara->extents.size() - i - 1]); +if (rExtent.pNode->GetIndex() < rStart.nNode.GetIndex() +|| rEnd.nNode.GetIndex() < rExtent.pNode->GetIndex()) +{ +continue; +} +sal_Int32 const nStart(rExtent.pNode == () +? rStart.nContent.GetIndex() +: 0); +if (rExtent.nEnd <= nStart) +{ +continue; +} +sal_Int32 const nEnd(rExtent.pNode == () +? rEnd.nContent.GetIndex() +: rExtent.pNode->Len()); +
[Libreoffice-bugs] [Bug 122092] FILEOPEN XLSX, LO uses formula instead of the mode repeating values.
https://bugs.documentfoundation.org/show_bug.cgi?id=122092 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Durgapriyanka --- Thank you for reporting the bug. I can confirm that the bug is present in Microsoft excel 2007 Version: 6.3.0.0.alpha0+ Build ID: 3c964980da07892a02d5ac721d80558c459532d0 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122054] Editing: Declined German terms containing more than one word, and Alphabetical Indexes
https://bugs.documentfoundation.org/show_bug.cgi?id=122054 --- Comment #8 from Jens Radloff --- Thanks, Dieter. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 Dieter Praas changed: What|Removed |Added Depends on||122054 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122054 [Bug 122054] Editing: Declined German terms containing more than one word, and Alphabetical Indexes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122054] Editing: Declined German terms containing more than one word, and Alphabetical Indexes
https://bugs.documentfoundation.org/show_bug.cgi?id=122054 Dieter Praas changed: What|Removed |Added Blocks||89606 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from Dieter Praas --- Now I can confirm it with Version: 6.2.0.0.beta1 (x64) Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (de_DE); UI-Language: en-GB Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89606 [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122111] Hex2DEC not converting right
https://bugs.documentfoundation.org/show_bug.cgi?id=122111 Xavier Van Wijmeersch changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED --- Comment #3 from Xavier Van Wijmeersch --- I don't think its wrong because tested with gnumeric and AOO 4.1.6; 4.2.0alpha -1,83E+011 is the result i see, and adjust the cell give -181278906323 But lets ask the expert's on this, set this back to unconfirmed Best regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122084] Autofilter menu disappears as I move the pointer
https://bugs.documentfoundation.org/show_bug.cgi?id=122084 --- Comment #4 from mich...@sidenius.org --- OK, I found a work around. Right click on the triangele icon and select "Selection List", then the menu stay open. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114437] Text is cropped because cell height is small on print preview / PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=114437 --- Comment #9 from Timur --- (In reply to Buovjaga from comment #5) > Repro, more or less, even though the font is substituted as I don't have it. Please explain. If I substitute Consolas with Liberation or Arial, preview is fine. Which would indicate it's an issue only with this font. (In reply to Ferry Toth from comment #7) > I our case text gets printed on top of outer text. See Screen Shot. Please attach you spreadsheet. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96248] assertion in SfxItemPool::Remove upon close with borders and changed date format
https://bugs.documentfoundation.org/show_bug.cgi?id=96248 --- Comment #18 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/73c3c3deff69ccd6a2f55952a911738496fb3c32%5E%21 tdf#120750: Revert "tdf#96248 delete SfxPoolItems with Which Id >= 4000" It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96248] assertion in SfxItemPool::Remove upon close with borders and changed date format
https://bugs.documentfoundation.org/show_bug.cgi?id=96248 Commit Notification changed: What|Removed |Added Whiteboard|haveValgrind target:5.3.0 |haveValgrind target:5.3.0 |target:6.3.0 target:6.2.0.1 |target:6.3.0 target:6.2.0.1 ||target:6.1.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120750] Crash applying bold to textbox control
https://bugs.documentfoundation.org/show_bug.cgi?id=120750 --- Comment #8 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/73c3c3deff69ccd6a2f55952a911738496fb3c32%5E%21 tdf#120750: Revert "tdf#96248 delete SfxPoolItems with Which Id >= 4000" It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120750] Crash applying bold to textbox control
https://bugs.documentfoundation.org/show_bug.cgi?id=120750 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0 target:6.2.0.1 |target:6.3.0 target:6.2.0.1 ||target:6.1.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - svl/source
svl/source/items/itempool.cxx | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) New commits: commit 73c3c3deff69ccd6a2f55952a911738496fb3c32 Author: Xisco Fauli AuthorDate: Thu Dec 13 17:10:29 2018 +0100 Commit: Xisco Faulí CommitDate: Fri Dec 14 18:44:57 2018 +0100 tdf#120750: Revert "tdf#96248 delete SfxPoolItems with Which Id >= 4000" This reverts commit c9493b344a9bd104d0a882f5e9407880c0c63c20. According to https://bugs.documentfoundation.org/show_bug.cgi?id=96248#c15 the asert was gone even before the patch... Anyway, better to have an assert than a crash Change-Id: I84389bf2e8e604f6967923c0eedaae3aec3455e6 Reviewed-on: https://gerrit.libreoffice.org/65115 Tested-by: Jenkins Reviewed-by: Jochen Nitschke Reviewed-by: Xisco Faulí (cherry picked from commit c5d0d424bd7e78455cb6f9578cf2425ac0787004) Reviewed-on: https://gerrit.libreoffice.org/65159 diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx index 76e9d90b485f..2ac29e44ada6 100644 --- a/svl/source/items/itempool.cxx +++ b/svl/source/items/itempool.cxx @@ -765,9 +765,16 @@ void SfxItemPool::Remove( const SfxPoolItem& rItem ) SfxPoolItem*& p = (*pItemArr)[nIdx]; assert(p == ); -assert(p->GetRefCount() && "removing Item without ref"); +if ( p->GetRefCount() ) //! +ReleaseRef( *p ); +else +{ +assert(false && "removing Item without ref"); +} -if (0 == ReleaseRef(*p)) +// FIXME: Hack, for as long as we have problems with the Outliner +// See other MI-REF +if ( 0 == p->GetRefCount() && nWhich < 4000 ) { DELETEZ(p); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122112] GTK3: Notebookbar not displayed after closing the component from fullscreen
https://bugs.documentfoundation.org/show_bug.cgi?id=122112 --- Comment #3 from Xisco Faulí --- Patch in gerrit: https://gerrit.libreoffice.org/#/c/65189/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs