[Libreoffice-bugs] [Bug 108542] [META] Chart label bugs and enhancements

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108542

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||122915


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122915
[Bug 122915] FILESAVE XLSX Single Data Label formatting disappears after
exported
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122915] FILESAVE XLSX Single Data Label formatting disappears after exported

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122915

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com,
   ||nem...@numbertext.org
 Blocks||108542


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108542
[Bug 108542] [META] Chart label bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122915] FILESAVE XLSX Single Data Label formatting disappears after exported

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122915

--- Comment #3 from NISZ LibreOffice Team  ---
Created attachment 148580
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148580=edit
The original file saved as XLSX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122915] FILESAVE XLSX Single Data Label formatting disappears after exported

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122915

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 148579
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148579=edit
Example ODS file from Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

Noel Grandin  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl,
   ||t...@libreoffice.org

--- Comment #11 from Noel Grandin  ---
I'm guessing that the CF_METAFILEPICT in the clipboard is what Apache Open
Office is using, and converting to our SVM format.

That will contain vector drawing instructions, which will produce a better
result (mostly, our metafile stuff has not always supported all of the nooks
and crannies of WMF)

So perhaps we need to tweak our preferences somewhere, to prefer metafile data
over bitmap data.
But that might mean checking with Thorsten Behrens and/or Bartosz Kosiorek, who
have been working on our metafile support.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122915] FILESAVE XLSX Single Data Label formatting disappears after exported

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122915

--- Comment #1 from NISZ LibreOffice Team  ---
Created attachment 148578
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148578=edit
Screenshot of the original and exported document side by side in Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2019-01-23 Thread Libreoffice Gerrit user
 vcl/source/image/ImplImageTree.cxx |   70 +++--
 1 file changed, 37 insertions(+), 33 deletions(-)

New commits:
commit dae31a2b10077a389cfe487196ce6a57b1211be2
Author: Tomaž Vajngerl 
AuthorDate: Wed Jan 23 19:20:53 2019 +0100
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 24 08:46:43 2019 +0100

cleanup ImplImageTree.cxx - whitespace, remove unneeded css::

Change-Id: Ic0c4d10d60bddc461fc20e98b8424c4e8480ee6e
Reviewed-on: https://gerrit.libreoffice.org/66822
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/image/ImplImageTree.cxx 
b/vcl/source/image/ImplImageTree.cxx
index ae8e29e353eb..c98351a5c73e 100644
--- a/vcl/source/image/ImplImageTree.cxx
+++ b/vcl/source/image/ImplImageTree.cxx
@@ -54,6 +54,8 @@
 
 #include 
 
+using namespace css;
+
 bool ImageRequestParameters::convertToDarkTheme()
 {
 static bool bIconsForDarkTheme = !!getenv("VCL_ICONS_FOR_DARK_THEME");
@@ -128,25 +130,25 @@ OUString getNameNoExtension(OUString const & sName)
 return sName.copy(0, nDotPosition);
 }
 
-std::shared_ptr wrapStream(css::uno::Reference< 
css::io::XInputStream > const & stream)
+std::shared_ptr wrapStream(uno::Reference 
const & rInputStream)
 {
 // This could use SvInputStream instead if that did not have a broken
 // SeekPos implementation for an XInputStream that is not also XSeekable
 // (cf. "@@@" at tags/DEV300_m37/svtools/source/misc1/strmadpt.cxx@264807
 // l. 593):
-OSL_ASSERT(stream.is());
-std::shared_ptr s(std::make_shared());
+OSL_ASSERT(rInputStream.is());
+std::shared_ptr 
aMemoryStream(std::make_shared());
 for (;;)
 {
-sal_Int32 const size = 2048;
-css::uno::Sequence< sal_Int8 > data(size);
-sal_Int32 n = stream->readBytes(data, size);
-s->WriteBytes(data.getConstArray(), n);
-if (n < size)
+const sal_Int32 nSize(2048);
+uno::Sequence aData(nSize);
+sal_Int32 nRead = rInputStream->readBytes(aData, nSize);
+aMemoryStream->WriteBytes(aData.getConstArray(), nRead);
+if (nRead < nSize)
 break;
 }
-s->Seek(0);
-return s;
+aMemoryStream->Seek(0);
+return aMemoryStream;
 }
 
 void loadImageFromStream(std::shared_ptr const & xStream, OUString 
const & rPath, ImageRequestParameters& rParameters)
@@ -236,7 +238,7 @@ OUString ImplImageTree::getImageUrl(OUString const & rName, 
OUString const & rSt
 if (checkPathAccess())
 {
 IconSet& rIconSet = getCurrentIconSet();
-const css::uno::Reference& 
rNameAccess = rIconSet.maNameAccess;
+const uno::Reference & rNameAccess = 
rIconSet.maNameAccess;
 
 LanguageTag aLanguageTag(rLang);
 
@@ -252,7 +254,7 @@ OUString ImplImageTree::getImageUrl(OUString const & rName, 
OUString const & rSt
 }
 }
 }
-catch (const css::uno::Exception & e)
+catch (const uno::Exception & e)
 {
 SAL_INFO("vcl", e);
 }
@@ -275,7 +277,7 @@ std::shared_ptr 
ImplImageTree::getImageStream(OUString const & r
 if (checkPathAccess())
 {
 IconSet& rIconSet = getCurrentIconSet();
-const css::uno::Reference& 
rNameAccess = rIconSet.maNameAccess;
+const uno::Reference& rNameAccess = 
rIconSet.maNameAccess;
 
 LanguageTag aLanguageTag(rLang);
 
@@ -283,7 +285,7 @@ std::shared_ptr 
ImplImageTree::getImageStream(OUString const & r
 {
 if (rNameAccess->hasByName(rPath))
 {
-css::uno::Reference aStream;
+uno::Reference aStream;
 bool ok = rNameAccess->getByName(rPath) >>= aStream;
 assert(ok);
 (void)ok; // prevent unused warning in release build
@@ -292,7 +294,7 @@ std::shared_ptr 
ImplImageTree::getImageStream(OUString const & r
 }
 }
 }
-catch (const css::uno::Exception & e)
+catch (const uno::Exception & e)
 {
 SAL_INFO("vcl", e);
 }
@@ -330,7 +332,7 @@ bool ImplImageTree::loadImage(OUString const & rName, 
OUString const & rStyle, B
 if (doLoadImage(aParameters))
 return true;
 }
-catch (css::uno::RuntimeException &)
+catch (uno::RuntimeException &)
 {}
 
 aCurrentStyle = fallbackStyle(aCurrentStyle);
@@ -401,11 +403,11 @@ bool ImplImageTree::doLoadImage(ImageRequestParameters& 
rParameters)
 {
 bFound = findImage(aPaths, rParameters);
 }
-catch (css::uno::RuntimeException&)
+catch (uno::RuntimeException&)
 {
 throw;
 }
-catch (const css::uno::Exception& e)
+catch (const uno::Exception& e)
 {
 SAL_INFO("vcl", 

[Libreoffice-bugs] [Bug 122915] New: FILESAVE XLSX Single Data Label formatting disappears after exported

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122915

Bug ID: 122915
   Summary: FILESAVE XLSX Single Data Label formatting disappears
after exported
   Product: LibreOffice
   Version: 5.0.0.5 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@nisz.hu

Description:
Single Data Label formatting disappears when the document is saved in XLSX
format.

Steps to Reproduce:
1. Create a new spreadsheet in LibreOffice Calc.
2. Insert a chart.
3. Choose Insert -> Data Labels (Charts).
4. Select Show value as number.
5. Press OK button.
6. Click the one data label and then click it again, so that it's the only
data label selected.
7. Right-click and select Format Single Data Label..
8. On the Font tab, change Font, Style or Size.
9. On the Font Effects tab, change Font color.
10. Press OK button.
11. Save the file as XLSX.
12. Reload the file.


Actual Results:
Single Data Label formatting disappears.

Expected Results:
Single Data Label formatting should appear.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121665] FILESAVE DOCX Only one Manual Column Break remains after export

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121665

--- Comment #8 from Justin L  ---
Created attachment 148577
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148577=edit
lost_column_break.odt: export test document

This ODT example loads properly all the way back to LO3.5, so we can use it to
bibisect the export.

Before LO3.6, it exports terribly - Word 2003 cannot read it.  Starting in 3.6,
MSWord imports the result which looks the same as today (although it looks bad
in LO itself). The export change was somewhere between May 11 - June 5 2012.

In LO4.4, the import more closely matches what Word sees, and I confirmed that
in LO60 it fully matches starting at cee02e81cd3b55fb46eacf5db5713e8bf4363bcd
identified in comment 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122857] Ctrl+left/right in insert-mode exits the mode

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122857

Konstantin Kharlamov  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from Konstantin Kharlamov  ---
(In reply to Xisco Faulí from comment #1)
> Thanks for reporting this issue.
> Could you please paste the info from Help - about LibreOffice ?
> 
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' once the information has been provided

Version: 6.1.4.2
Build ID: 6.1.4-4
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2019-01-23 Thread Libreoffice Gerrit user
 sc/source/filter/html/htmlexp.cxx|3 -
 sc/source/filter/html/htmlpars.cxx   |   78 +++
 sc/source/filter/lotus/lotattr.cxx   |7 +-
 sc/source/filter/lotus/tool.cxx  |   73 +++--
 sc/source/filter/oox/addressconverter.cxx|8 +-
 sc/source/filter/oox/autofilterbuffer.cxx|   27 +
 sc/source/filter/oox/condformatbuffer.cxx|   26 +++--
 sc/source/filter/oox/connectionsbuffer.cxx   |4 -
 sc/source/filter/oox/defnamesbuffer.cxx  |3 -
 sc/source/filter/oox/excelchartconverter.cxx |7 +-
 sc/source/filter/oox/externallinkbuffer.cxx  |8 +-
 sc/source/filter/oox/formulabase.cxx |3 -
 sc/source/filter/oox/formulaparser.cxx   |   12 ++--
 sc/source/filter/oox/numberformatsbuffer.cxx |8 +-
 sc/source/filter/oox/pivotcachebuffer.cxx|   54 +++---
 sc/source/filter/oox/pivottablebuffer.cxx|   67 ---
 sc/source/filter/oox/querytablebuffer.cxx|   10 +--
 sc/source/filter/oox/revisionfragment.cxx|6 --
 sc/source/filter/oox/richstring.cxx  |   12 ++--
 sc/source/filter/oox/scenariobuffer.cxx  |   14 ++--
 sc/source/filter/oox/sheetdatabuffer.cxx |   74 -
 sc/source/filter/oox/stylesbuffer.cxx|   20 +++---
 sc/source/filter/oox/tablebuffer.cxx |4 -
 sc/source/filter/oox/tablecolumnsbuffer.cxx  |6 +-
 sc/source/filter/oox/viewsettings.cxx|4 -
 sc/source/filter/oox/workbookfragment.cxx|   17 ++---
 sc/source/filter/oox/worksheetfragment.cxx   |   12 ++--
 sc/source/filter/orcus/xmlcontext.cxx|   59 +++-
 28 files changed, 303 insertions(+), 323 deletions(-)

New commits:
commit 72b8f54270877726d821d3f01225d8238c9d46ed
Author: Arkadiy Illarionov 
AuthorDate: Thu Jan 24 00:27:42 2019 +0300
Commit: Noel Grandin 
CommitDate: Thu Jan 24 08:35:12 2019 +0100

Simplify containers iterations in sc/source/filter/[h-o]*

Use range-based loop or replace with STL functions

Change-Id: I7e024d5bf97d942b8b43465e0779cf9e30df8eb0
Reviewed-on: https://gerrit.libreoffice.org/66827
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/html/htmlexp.cxx 
b/sc/source/filter/html/htmlexp.cxx
index f669074ba372..9715fa9299ed 100644
--- a/sc/source/filter/html/htmlexp.cxx
+++ b/sc/source/filter/html/htmlexp.cxx
@@ -1209,9 +1209,8 @@ bool ScHTMLExport::WriteFieldText( const EditTextObject* 
pData )
 std::vector aPortions;
 rEngine.GetPortions( nPar, aPortions );
 sal_Int32 nStart = 0;
-for ( std::vector::const_iterator 
it(aPortions.begin()); it != aPortions.end(); ++it )
+for ( const sal_Int32 nEnd : aPortions )
 {
-sal_Int32 nEnd = *it;
 ESelection aSel( nPar, nStart, nPar, nEnd );
 bool bUrl = false;
 // fields are single characters
diff --git a/sc/source/filter/html/htmlpars.cxx 
b/sc/source/filter/html/htmlpars.cxx
index eb6136b89cbd..5749949006d4 100644
--- a/sc/source/filter/html/htmlpars.cxx
+++ b/sc/source/filter/html/htmlpars.cxx
@@ -231,8 +231,8 @@ ScHTMLLayoutParser::~ScHTMLLayoutParser()
 delete pLocalColOffset;
 if ( pTables )
 {
-for( OuterMap::const_iterator it = pTables->begin(); it != 
pTables->end(); ++it)
-delete it->second;
+for( const auto& rEntry : *pTables)
+delete rEntry.second;
 pTables.reset();
 }
 }
@@ -1831,16 +1831,15 @@ ScHTMLTable::ScHTMLTable( ScHTMLTable& rParentTable, 
const HtmlImportInfo& rInfo
 {
 ProcessFormatOptions( maTableItemSet, rInfo );
 const HTMLOptions& rOptions = 
static_cast(rInfo.pParser)->GetOptions();
-HTMLOptions::const_iterator itr = rOptions.begin(), itrEnd = 
rOptions.end();
-for (; itr != itrEnd; ++itr)
+for (const auto& rOption : rOptions)
 {
-switch( itr->GetToken() )
+switch( rOption.GetToken() )
 {
 case HtmlOptionId::BORDER:
-mbBorderOn = itr->GetString().isEmpty() || 
(itr->GetNumber() != 0);
+mbBorderOn = rOption.GetString().isEmpty() || 
(rOption.GetNumber() != 0);
 break;
 case HtmlOptionId::ID:
-maTableName = itr->GetString();
+maTableName = rOption.GetString();
 break;
 default: break;
 }
@@ -2055,29 +2054,28 @@ void ScHTMLTable::DataOn( const HtmlImportInfo& rInfo )
 ScHTMLSize aSpanSize( 1, 1 );
 boost::optional pValStr, pNumStr;
 const HTMLOptions& rOptions = 
static_cast(rInfo.pParser)->GetOptions();
-HTMLOptions::const_iterator itr = rOptions.begin(), itrEnd = 
rOptions.end();
 sal_uInt32 nNumberFormat = 

[Libreoffice-bugs] [Bug 122149] Libreoffice gives access to the same file (for other Users) with a different UID/GID in Servermode

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122149

--- Comment #2 from Nadi Sanli  ---
A colleague told me he cant reproduce my problem which i described below, so
here is another try to clear it up:

Both Users are logged in via Servermode:
unoconv -c "socket,host=127.0.0.1,port=1;urp;StarOffice.ComponentContext"
file.odt 

1. User 1 creates creates /home/user1/file.odt
2. executes: foo --bar /home/user1/file.odt
3. executes: baz file.pdf

Then User2
4. creates /home/user2/file.odt
5. executes: cd /home/whatever/file.odt
6. executes: foo --bar home/user1/file.odt

After this the /home/whatever/file.whatever gets overwritten from User2 and the
name from User1 stays.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115179] Document is considered as unmodified after a table of contents update

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115179

--- Comment #3 from maxsi...@gmail.com ---
The bug is still reproducible in the latest stable version of LibreOffice.

Version: 6.0.7.3 (x64)
Build ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
Threads CPU : 8; OS : Windows 10.0; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 122893, which changed state.

Bug 122893 Summary: Change tracking: paragraph alignment lost after saving the 
document
https://bugs.documentfoundation.org/show_bug.cgi?id=122893

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2019-01-23 Thread Libreoffice Gerrit user
 sw/inc/editsh.hxx   |3 +-
 sw/qa/extras/uiwriter/uiwriter2.cxx |   51 
 sw/source/core/edit/edatmisc.cxx|   11 +++
 sw/source/uibase/uiview/viewtab.cxx |2 -
 4 files changed, 64 insertions(+), 3 deletions(-)

New commits:
commit 6a54dd844d1821165642bbcc16bd12a01a23393d
Author: László Németh 
AuthorDate: Wed Jan 23 15:05:21 2019 +0100
Commit: László Németh 
CommitDate: Thu Jan 24 08:17:27 2019 +0100

tdf#122901 track changes: keep paragraph top and bottom borders

applied in Show Changes mode, instead of losing them after
saving the document or hiding the changes.

The bug occurred in paragraphs with directly preceding tracked deletions.

Change-Id: I25a84aec0159f809dd7b67d4e530e87b01070f44
Reviewed-on: https://gerrit.libreoffice.org/66800
Reviewed-by: László Németh 
Tested-by: László Németh 

diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 18b67e8cf0dd..9c550e96f639 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -229,7 +229,8 @@ public:
  const bool bMergeIndentValuesOfNumRule = false ) const;
 bool GetCurAttr( SfxItemSet& ,
  const bool bMergeIndentValuesOfNumRule = false ) const;
-void SetAttrItem( const SfxPoolItem&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT );
+void SetAttrItem( const SfxPoolItem&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT,
+ const bool bParagraphSetting = false );
 void SetAttrSet( const SfxItemSet&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT,
  SwPaM* pCursor = nullptr, const bool bParagraphSetting = 
false );
 
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index c7d1ed25b446..8b05f26e6241 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -56,6 +56,7 @@ public:
 void testUnfloatButtonReadOnlyMode();
 void testUnfloating();
 void testTdf122893();
+void testTdf122901();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest2);
 CPPUNIT_TEST(testRedlineMoveInsertInDelete);
@@ -74,6 +75,7 @@ public:
 CPPUNIT_TEST(testUnfloatButtonReadOnlyMode);
 CPPUNIT_TEST(testUnfloating);
 CPPUNIT_TEST(testTdf122893);
+CPPUNIT_TEST(testTdf122901);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -738,6 +740,55 @@ void SwUiWriterTest2::testTdf122893()
 sal_Int16(200), getProperty(getParagraph(1), 
"ParaLineSpacing").Height);
 }
 
+void SwUiWriterTest2::testTdf122901()
+{
+load(DATA_DIRECTORY, "tdf105413.fodt");
+
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+// all paragraphs with zero borders
+for (int i = 1; i < 4; ++i)
+{
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0),
+ getProperty(getParagraph(i), 
"ParaTopMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0),
+ getProperty(getParagraph(i), 
"ParaBottomMargin"));
+}
+
+// turn on red-lining and show changes
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On | 
RedlineFlags::ShowInsert
+  | 
RedlineFlags::ShowDelete);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+   pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+// Increase paragraph borders in the 3th paragraph, similar to the default 
icon of the UI
+// "Increase Paragraph Spacing". Because of the tracked deleted region 
between them,
+// this sets also the same formatting in the first paragraph automatically
+// to keep the changed paragraph formatting at hiding tracked changes or 
saving the document
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->EndPara(/*bSelect=*/false);
+
+lcl_dispatchCommand(mxComponent, ".uno:ParaspaceIncrease", {});
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(101), 
getProperty(getParagraph(3), "ParaTopMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(101),
+ getProperty(getParagraph(3), 
"ParaBottomMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(getParagraph(2), 
"ParaTopMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(getParagraph(2), 
"ParaBottomMargin"));
+
+// first paragraph is also center-aligned with double line spacing
+CPPUNIT_ASSERT_EQUAL(sal_Int32(101), 
getProperty(getParagraph(1), "ParaTopMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(101),
+ getProperty(getParagraph(1), 
"ParaBottomMargin"));
+}
+
 

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2019-01-23 Thread Libreoffice Gerrit user
 sw/inc/editsh.hxx   |3 +
 sw/qa/extras/uiwriter/uiwriter2.cxx |   55 
 sw/source/core/edit/edatmisc.cxx|   27 -
 sw/source/uibase/shells/txtattr.cxx |2 -
 4 files changed, 83 insertions(+), 4 deletions(-)

New commits:
commit d97fc64a819f834302e384792668507df4cc412c
Author: László Németh 
AuthorDate: Wed Jan 23 11:27:01 2019 +0100
Commit: László Németh 
CommitDate: Thu Jan 24 08:15:52 2019 +0100

tdf#122893 track changes: keep paragraph alignment

and preset line spaces applied in Show Changes mode, instead of
losing them after saving the document or hiding the changes.

The bug occurred in paragraphs with directly preceding tracked deletions.

Change-Id: I33d9db8ee3522470c4f2dfdcfbea4060db8769a2
Reviewed-on: https://gerrit.libreoffice.org/66789
Reviewed-by: László Németh 
Tested-by: László Németh 

diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index fc804550f887..18b67e8cf0dd 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -230,7 +230,8 @@ public:
 bool GetCurAttr( SfxItemSet& ,
  const bool bMergeIndentValuesOfNumRule = false ) const;
 void SetAttrItem( const SfxPoolItem&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT );
-void SetAttrSet( const SfxItemSet&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT, SwPaM* pCursor = nullptr );
+void SetAttrSet( const SfxItemSet&, SetAttrMode nFlags = 
SetAttrMode::DEFAULT,
+ SwPaM* pCursor = nullptr, const bool bParagraphSetting = 
false );
 
 /** Get RES_CHRATR_* items of one type in the current selection.
  * @param nWhich WhichId of the collected items.
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 2f0242a6964c..c7d1ed25b446 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -54,6 +55,7 @@ public:
 void testUnfloatButton();
 void testUnfloatButtonReadOnlyMode();
 void testUnfloating();
+void testTdf122893();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest2);
 CPPUNIT_TEST(testRedlineMoveInsertInDelete);
@@ -71,6 +73,7 @@ public:
 CPPUNIT_TEST(testUnfloatButton);
 CPPUNIT_TEST(testUnfloatButtonReadOnlyMode);
 CPPUNIT_TEST(testUnfloating);
+CPPUNIT_TEST(testTdf122893);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -683,6 +686,58 @@ void SwUiWriterTest2::testUnfloating()
 
pWrtShell->GetLayout()->GetLower()->GetNext()->GetLower()->GetLower()->GetType());
 }
 
+void SwUiWriterTest2::testTdf122893()
+{
+load(DATA_DIRECTORY, "tdf105413.fodt");
+
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+// all paragraphs are left-aligned with preset single line spacing
+for (int i = 1; i < 4; ++i)
+{
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), 
getProperty(getParagraph(i), "ParaAdjust"));
+lcl_dispatchCommand(mxComponent, ".uno:SpacePara1", {});
+}
+
+// turn on red-lining and show changes
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On | 
RedlineFlags::ShowInsert
+  | 
RedlineFlags::ShowDelete);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+   pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+CPPUNIT_ASSERT_MESSAGE(
+"redlines should be visible",
+
IDocumentRedlineAccess::IsShowChanges(pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+// Set center-aligned paragraph with preset double line spacing in the 3th 
paragraph.
+// Because of the tracked deleted region between them,
+// this sets also the same formatting in the first paragraph automatically
+// to keep the changed paragraph formatting at hiding tracked changes or 
saving the document
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->Down(/*bSelect=*/false);
+pWrtShell->EndPara(/*bSelect=*/false);
+
+lcl_dispatchCommand(mxComponent, ".uno:CenterPara", {});
+lcl_dispatchCommand(mxComponent, ".uno:SpacePara2", {});
+
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3),
+ getProperty(getParagraph(3), 
"ParaAdjust")); // center-aligned
+CPPUNIT_ASSERT_EQUAL(sal_Int16(200),
+ getProperty(getParagraph(3), 
"ParaLineSpacing")
+ .Height); // double line spacing
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0),
+ getProperty(getParagraph(2), 
"ParaAdjust")); // left-aligned
+CPPUNIT_ASSERT_EQUAL(sal_Int16(100),
+ getProperty(getParagraph(2), 
"ParaLineSpacing")
+ .Height); // single line spacing
+

[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #84 from Jim Raykowski  ---
(In reply to Mike Kaganski from comment #83)
> So the only place in the codebase where SvxBackgroundTabPage is still added
> seems to be cui/source/tabpages/bbdlg.cxx?

patch for review is here:
https://gerrit.libreoffice.org/#/c/64016/

also

reportdesign/source/ui/dlg/dlgpage.cxx
https://gerrit.libreoffice.org/#/c/64991/

and

sw/source/ui/frmdlg/pattern.cxx
sw/source/uibase/app/appopt.cxx
https://gerrit.libreoffice.org/#/c/64673/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - basctl/source basegfx/source canvas/workben chart2/source connectivity/source cui/source

2019-01-23 Thread Libreoffice Gerrit user
 basctl/source/basicide/bastype2.cxx   |4 ++--
 basctl/source/basicide/bastype3.cxx   |6 +++---
 basctl/source/basicide/breakpoint.cxx |2 +-
 basctl/source/basicide/breakpoint.hxx |2 +-
 basctl/source/basicide/macrodlg.cxx   |2 +-
 basctl/source/basicide/macrodlg.hxx   |2 +-
 basctl/source/inc/bastype2.hxx|   12 ++--
 basegfx/source/range/b2drangeclipper.cxx  |2 +-
 canvas/workben/canvasdemo.cxx |2 +-
 chart2/source/controller/dialogs/tp_DataSource.cxx|2 +-
 chart2/source/controller/dialogs/tp_DataSource.hxx|2 +-
 connectivity/source/drivers/firebird/ResultSet.cxx|2 +-
 connectivity/source/drivers/firebird/ResultSet.hxx|2 +-
 connectivity/source/drivers/mysqlc/mysqlc_general.cxx |5 -
 connectivity/source/drivers/mysqlc/mysqlc_general.hxx |2 +-
 connectivity/source/inc/odbc/OTools.hxx   |2 +-
 cui/source/inc/chardlg.hxx|2 +-
 cui/source/inc/cuitabline.hxx |4 ++--
 cui/source/inc/numpages.hxx   |2 +-
 cui/source/inc/tabstpge.hxx   |2 +-
 cui/source/tabpages/chardlg.cxx   |2 +-
 cui/source/tabpages/numpages.cxx  |2 +-
 cui/source/tabpages/tabstpge.cxx  |2 +-
 cui/source/tabpages/tplnedef.cxx  |4 ++--
 24 files changed, 37 insertions(+), 34 deletions(-)

New commits:
commit 48fd4199a665130947033ee431db766c04d8d023
Author: Noel Grandin 
AuthorDate: Wed Jan 23 14:32:29 2019 +0200
Commit: Noel Grandin 
CommitDate: Thu Jan 24 07:46:27 2019 +0100

loplugin:constparams in connectivity..cui

Change-Id: Ia2ae97498a9aad8638c4b77ce20143eeec616751
Reviewed-on: https://gerrit.libreoffice.org/66792
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/drivers/firebird/ResultSet.cxx 
b/connectivity/source/drivers/firebird/ResultSet.cxx
index f08be6983771..38384282040b 100644
--- a/connectivity/source/drivers/firebird/ResultSet.cxx
+++ b/connectivity/source/drivers/firebird/ResultSet.cxx
@@ -57,7 +57,7 @@ using namespace ::com::sun::star::util;
 OResultSet::OResultSet(Connection* pConnection,
::osl::Mutex& rMutex,
const uno::Reference< XInterface >& xStatement,
-   isc_stmt_handle& aStatementHandle,
+   const isc_stmt_handle& aStatementHandle,
XSQLDA* pSqlda )
 : OResultSet_BASE(rMutex)
 , OPropertyContainer(OResultSet_BASE::rBHelper)
diff --git a/connectivity/source/drivers/firebird/ResultSet.hxx 
b/connectivity/source/drivers/firebird/ResultSet.hxx
index 008bc5b55263..ca1804629b2a 100644
--- a/connectivity/source/drivers/firebird/ResultSet.hxx
+++ b/connectivity/source/drivers/firebird/ResultSet.hxx
@@ -121,7 +121,7 @@ namespace connectivity
 OResultSet(Connection* pConnection,
::osl::Mutex& rMutex,
const css::uno::Reference< css::uno::XInterface >& 
xStatement,
-   isc_stmt_handle& aStatementHandle,
+   const isc_stmt_handle& aStatementHandle,
XSQLDA* aSqlda
   );
 
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_general.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
index 56b92afd2245..ed1a71dd460d 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
@@ -225,7 +225,10 @@ sal_Int32 mysqlStrToOOOType(const OUString& sType)
 return css::sdbc::DataType::VARCHAR;
 }
 
-OUString mysqlTypeToStr(MYSQL_FIELD* field) { return 
mysqlTypeToStr(field->type, field->flags); }
+OUString mysqlTypeToStr(MYSQL_FIELD const* field)
+{
+return mysqlTypeToStr(field->type, field->flags);
+}
 
 OUString mysqlTypeToStr(unsigned type, unsigned flags)
 {
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_general.hxx 
b/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
index f8d866964318..67dbd7342597 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
@@ -105,7 +105,7 @@ void throwSQLExceptionWithMsg(const char* msg, unsigned int 
errorNum,
 
 sal_Int32 mysqlToOOOType(int eType, int charsetnr) noexcept;
 
-OUString mysqlTypeToStr(MYSQL_FIELD* pField);
+OUString mysqlTypeToStr(MYSQL_FIELD const* pField);
 
 OUString mysqlTypeToStr(unsigned mysql_type, unsigned mysql_flags);
 
diff --git a/connectivity/source/inc/odbc/OTools.hxx 
b/connectivity/source/inc/odbc/OTools.hxx
index 377a42de0ada..3f2fddb8178e 100644
--- a/connectivity/source/inc/odbc/OTools.hxx
+++ 

[Libreoffice-commits] core.git: dbaccess/source hwpfilter/source oox/source

2019-01-23 Thread Libreoffice Gerrit user
 dbaccess/source/ui/dlg/TablesSingleDlg.cxx  |2 +-
 dbaccess/source/ui/inc/TablesSingleDlg.hxx  |2 +-
 dbaccess/source/ui/inc/UITools.hxx  |4 ++--
 dbaccess/source/ui/misc/UITools.cxx |4 ++--
 dbaccess/source/ui/querydesign/querydlg.cxx |2 +-
 dbaccess/source/ui/querydesign/querydlg.hxx |2 +-
 hwpfilter/source/solver.cxx |2 +-
 hwpfilter/source/solver.h   |2 +-
 oox/source/drawingml/shape.cxx  |2 +-
 oox/source/drawingml/table/tablecell.cxx|2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 976da2b60ebe4e8bb7c311c1c6325519db6c5bda
Author: Noel Grandin 
AuthorDate: Wed Jan 23 14:33:04 2019 +0200
Commit: Noel Grandin 
CommitDate: Thu Jan 24 07:46:46 2019 +0100

loplugin:constparams in dbaccess..oox

Change-Id: I9c04906dd492c6f8a816f57f40bc31406a871a78
Reviewed-on: https://gerrit.libreoffice.org/66793
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/dlg/TablesSingleDlg.cxx 
b/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
index b332f0018de6..8673bcf25b5b 100644
--- a/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
+++ b/dbaccess/source/ui/dlg/TablesSingleDlg.cxx
@@ -33,7 +33,7 @@ using namespace com::sun::star::container;
 
 // OTableSubscriptionDialog
 OTableSubscriptionDialog::OTableSubscriptionDialog(vcl::Window* pParent
-,SfxItemSet* _pItems
+,const SfxItemSet* _pItems
 ,const Reference< XComponentContext >& _rxORB
 ,const css::uno::Any& _aDataSourceName)
 : SfxSingleTabDialog(pParent, _pItems, "TablesFilterDialog",
diff --git a/dbaccess/source/ui/inc/TablesSingleDlg.hxx 
b/dbaccess/source/ui/inc/TablesSingleDlg.hxx
index 2df28c524308..a72f70fe756c 100644
--- a/dbaccess/source/ui/inc/TablesSingleDlg.hxx
+++ b/dbaccess/source/ui/inc/TablesSingleDlg.hxx
@@ -48,7 +48,7 @@ class ODbDataSourceAdministrationHelper;
 public:
 
 OTableSubscriptionDialog(vcl::Window* pParent
-,SfxItemSet* _pItems
+,const SfxItemSet* _pItems
 ,const css::uno::Reference< css::uno::XComponentContext >& _rxORB
 ,const css::uno::Any& _aDataSourceName
 );
diff --git a/dbaccess/source/ui/inc/UITools.hxx 
b/dbaccess/source/ui/inc/UITools.hxx
index 7a1d7613815a..8b08d08a31ee 100644
--- a/dbaccess/source/ui/inc/UITools.hxx
+++ b/dbaccess/source/ui/inc/UITools.hxx
@@ -183,11 +183,11 @@ namespace dbaui
 void callColumnFormatDialog(const css::uno::Reference< 
css::beans::XPropertySet>& _xAffectedCol,
 const css::uno::Reference< 
css::beans::XPropertySet>& _xField,
 SvNumberFormatter* _pFormatter,
-vcl::Window* _pParent);
+const vcl::Window* _pParent);
 
 /** second variant of the function before
 */
-bool callColumnFormatDialog(vcl::Window* _pParent,
+bool callColumnFormatDialog(const vcl::Window* _pParent,
 SvNumberFormatter* _pFormatter,
 sal_Int32 _nDataType,
 sal_Int32& _nFormatKey,
diff --git a/dbaccess/source/ui/misc/UITools.cxx 
b/dbaccess/source/ui/misc/UITools.cxx
index ae2c46f8ee55..af8ec154deb9 100644
--- a/dbaccess/source/ui/misc/UITools.cxx
+++ b/dbaccess/source/ui/misc/UITools.cxx
@@ -741,7 +741,7 @@ SvxCellHorJustify mapTextJustify(sal_Int32 _nAlignment)
 void callColumnFormatDialog(const Reference& xAffectedCol,
 const Reference& xField,
 SvNumberFormatter* _pFormatter,
-vcl::Window* _pParent)
+const vcl::Window* _pParent)
 {
 if (xAffectedCol.is() && xField.is())
 {
@@ -774,7 +774,7 @@ void callColumnFormatDialog(const Reference& 
xAffectedCol,
 }
 }
 
-bool callColumnFormatDialog(vcl::Window* _pParent,
+bool callColumnFormatDialog(const vcl::Window* _pParent,
 SvNumberFormatter* _pFormatter,
 sal_Int32 _nDataType,
 sal_Int32& _nFormatKey,
diff --git a/dbaccess/source/ui/querydesign/querydlg.cxx 
b/dbaccess/source/ui/querydesign/querydlg.cxx
index 2fa5ab16f66e..0370e6b0f38c 100644
--- a/dbaccess/source/ui/querydesign/querydlg.cxx
+++ b/dbaccess/source/ui/querydesign/querydlg.cxx
@@ -43,7 +43,7 @@ using namespace ::com::sun::star::sdbc;
 
 DlgQryJoin::DlgQryJoin( OQueryTableView * pParent,
const TTableConnectionData::value_type& _pData,
-   OJoinTableView::OTableWindowMap* _pTableMap,
+   const OJoinTableView::OTableWindowMap* _pTableMap,
const Reference< XConnection >& _xConnection,
bool _bAllowTableSelect)
 : ModalDialog( pParent, 

[Libreoffice-bugs] [Bug 122914] New: Opening a Style dialog's Borders tab adds Shadow properties to the property set in the style (again)

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122914

Bug ID: 122914
   Summary: Opening a Style dialog's Borders tab adds Shadow
properties to the property set in the style (again)
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com
CC: caol...@redhat.com

In https://git.libreoffice.org/core/+/b37a46fdf91dbc66f6ddc1c070aec70716d94a01,
addition of Shadow properties to the style's properties after simple opening
Borders tab in properties dialog was fixed (in 6.1). But it reappeared again in
6.2.

To reproduce: as in bug 115938, just open a style (Character or Paragraph)
properties dialog in Writer, check that Organizer doesn't have Shadow
properties listed, switch to Borders tab (don't modify anything!), switch back
to Organizer tab and see that the properties are there.

This is regression from
https://git.libreoffice.org/core/+/229483707c3ccb48d008d37f856bbeb6df199a90.
Also other tabs are now affected: Indents & Spacing, Alignment, Area.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122906] [WOPI] SSL error

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122906

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #1 from Aron Budea  ---
Never seen this error, which online and NC + Collabora Online app version is
this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121665] FILESAVE DOCX Only one Manual Column Break remains after export

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121665

--- Comment #7 from Justin L  ---
Before LO 6.0, the import wasn't actually correct - LO showed two carriage
returns in column 2, while Word has the last carriage return in column 3
instead.  After comment 6's patch, LO properly has the last CR in column 3.

Also worth noting is that Word and LO import lost_column_break_export.docx from
comment 3 identically.

Must have exposed an existing export problem. The patch in comment 6 is an
import patch, and importing looks fine in all cases. Not a true regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2019-01-23 Thread Libreoffice Gerrit user
 sw/source/filter/ww8/docxattributeoutput.cxx |6 +++---
 sw/source/filter/ww8/rtfattributeoutput.cxx  |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d113fe774252ada99ddec3eeaef080cb67919aa3
Author: Andrea Gelmini 
AuthorDate: Wed Jan 23 16:34:12 2019 +
Commit: Jens Carl 
CommitDate: Thu Jan 24 06:45:45 2019 +0100

Fix typos

Change-Id: I371d987884987fab8039c3329968f7a9282455f2
Reviewed-on: https://gerrit.libreoffice.org/66829
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index b1b915e1c447..67430375fb55 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -399,8 +399,8 @@ static void 
checkAndWriteFloatingTables(DocxAttributeOutput& rDocxAttributeOutpu
 
 void DocxAttributeOutput::StartParagraph( ww8::WW8TableNodeInfo::Pointer_t 
pTextNodeInfo )
 {
-// look ahead for floating tables that where put into a frame during import
-// flaoting tables in shapes are not supported: exclude this case
+// look ahead for floating tables that were put into a frame during import
+// floating tables in shapes are not supported: exclude this case
 if (!pTextNodeInfo && !m_rExport.SdrExporter().IsDMLAndVMLDrawingOpen())
 {
 checkAndWriteFloatingTables(*this);
@@ -4239,7 +4239,7 @@ void DocxAttributeOutput::TableVerticalCell( 
ww8::WW8TableNodeInfoInner::Pointer
 void DocxAttributeOutput::TableNodeInfoInner( 
ww8::WW8TableNodeInfoInner::Pointer_t pNodeInfoInner )
 {
 // This is called when the nested table ends in a cell, and there's no
-// paragraph benhind that; so we must check for the ends of cell, rows,
+// paragraph behind that; so we must check for the ends of cell, rows,
 // tables
 // ['true' to write an empty paragraph, MS Word insists on that]
 FinishTableRowCell( pNodeInfoInner, true );
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx 
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index 845ac653fd73..995a43bd0a9b 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -874,7 +874,7 @@ void RtfAttributeOutput::TableVerticalCell(
 void 
RtfAttributeOutput::TableNodeInfoInner(ww8::WW8TableNodeInfoInner::Pointer_t 
pNodeInfoInner)
 {
 // This is called when the nested table ends in a cell, and there's no
-// paragraph benhind that; so we must check for the ends of cell, rows,
+// paragraph behind that; so we must check for the ends of cell, rows,
 // and tables
 FinishTableRowCell(pNodeInfoInner);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122886] [META] Bugs with textboxes in shapes

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122886

--- Comment #1 from Aron Budea  ---
For reference, this commit added the context menu entry:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7f77b8a689f84a03495ac5911236b68f01ee7b24
author  Miklos Vajna   2014-06-19 10:11:10
+0200
committer   Miklos Vajna   2014-06-19 11:29:31
+0200

sw: add UI for adding a textbox for a draw shape

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

john Adward  changed:

   What|Removed |Added

Version|Inherited From OOo  |unspecified
  Component|Calc|General
Product|LibreOffice |Document Liberation Project

--- Comment #184 from john Adward  ---
Get FREE account and technical support for your McAfee consumer products and
services. Find solutions to top issues online. Live support via chat and
phones.
http://www.mcafeecomactivate.me/
http://www.mcafeecomactivate.me/mcafee-activate/
http://www.mcafeecomactivate.me/myaccount/
http://www.mcafeecomactivate.me/mcafee-log-in/
http://www.mcafeecomactivate.me/mcafee-antivirus-plus/
http://www.mcafeecomactivate.me/mcafee-livesafe/
http://www.mcafeecomactivate.me/mcafee-activate-product-key/
http://www.mcafeecomactivate.me/mcafee-retail-card/
http://www.mcafeecomactivate.me/mcafee-mtp-retail-card/
http://www.mcafeecomactivate.me/mcafee-mis-retail-card/
http://www.mcafeecomactivate.me/mcafee-mav-retail-card/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106810] set transparent background color in form controls

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106810

--- Comment #7 from Ryan  ---
This feature would be very useful and I'm hoping could be a quick fix. Some
forms have blocks so that it looks like a form when printing, therefore a
transparent background form control would be required.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97128] FILEOPEN: header with frame not properly shown in DOC

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97128

Justin L  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

--- Comment #183 from Robert Williams  ---
Visit mcafee.com/activate to step by step download and install McAfee products.
Purchase and activate your McAfee antivirus for Mac, Windows, iOS and Android
from mcafee.com/activate.
[url=https://quicksetupme.com/norton-nu16/]norton.com/nu16[/url] |
[url=https://askofficesetup.com/]office.com/setup[/url] |
[url=http://mcafee-com-activate-code.com/]mcafee.com/activate[/url] |
[url=https://mcafeeactivate.website/]mcafee.com/activate[/url] |
[url=https://get-office-2019.com/]office.com/setup[/url] |
[url=https://quicksetupme.com/]norton.com/setup[/url] |
[url=https://davidpcexpert.wordpress.com/blog/]mcafee.com/activate[/url] |
[url=https://mexwell1122.blogspot.com/]mcafee.com/activate[/url]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105651] Find dialog not functioning correctly for screen reader users.

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105651

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105622] Highlight more than 64 cells in Calc formula

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105622

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115174] Find "Whole words only" does not function properly

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115174

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115179] Document is considered as unmodified after a table of contents update

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115179

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 95425] Number format of data labels reset when format of data series is changed

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95425

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122913] New: Breaks->Insert checkbox isn't set to undetermined state on Paragraph Properties dialog (Text Flow tab) when different paragraphs with different value of it are sel

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122913

Bug ID: 122913
   Summary: Breaks->Insert checkbox isn't set to undetermined
state on Paragraph Properties dialog (Text Flow tab)
when different paragraphs with different value of it
are selected
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

Selecting multiple paragraphs with different paragraph properties normally
makes these properties have undetermined state in the selection's Paragraph
Properties dialog. But not for inserted page breaks.

Steps:
1. Create new text document
2. Type "loremipsum"
3. Apply any page style (double-clicking it on Stylist) - this step adds
Insert->Page break to the very first paragraph.
4. Ctrl+Home; Format->Paragraph->Text Flow tab; check that the Break setting is
checked; also check Hyphenation->Automatically, and Keep with next paragraph,
just for comparison; apply and close dialog.
5. Shift+Down to select the whole first paragraph, and the beginning of the
second.
6. Format->Paragraph->Text Flow tab

Actual: both Hyphenation->Automatically and Keep with next paragraph are in
undetermined state, showing that different paragraphs in the selection have
different values for the settings; but Break checkbox is simply unset.

Expected: Break checkbox must be also in undetermined state.

Tested with Version: 6.2.0.2 (x64)
Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

and with OpenOffice.org 3.3.0 OOO330m20 (Build:9567).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122835] Selecting a page's first line also selects beginning-of-page marker

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122835

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2913

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122835] Selecting a page's first line also selects beginning-of-page marker

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122835

--- Comment #7 from Mike Kaganski  ---
(In reply to Johannes Riecken from comment #6)

So yes, the problem is the page break explicitly set for the very first
paragraph (on DOCX import). Although not shown on your screencast (where you
did it wrong when selected the first line *up to start of the second* when
opened paragraph properties - try not selecting anything, and just put cursor
to first line when opening paragraph properties).

I'm still unsure if this is a bug, since Word has no notion of page styles (it
only applies page settings through direct formatting of section properties), so
LibreOffice has to map these section properties to auto-generated page  styles,
and only in most  simple cases, where only one section is present in the
document, could it in principle avoid applying the page break with page style.

Another way to reproduce would be this:
1. Create new test document.
2. Add loremipsum
3. Apply another page style (e.g., double-click at "First page" at Stylist's
page styles; no need to be at the first paragraph at this stage!)
4. Try copying first paragraph to the end (as in your step 5).

Step 3 applies page break with page style to the first paragraph; it's only not
needed on the very first paragraph of the document when no custom styles are
set (Default page style is used).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122898] FILESAVE DOCX, Shape loses its resize option when odt is saved as docx

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122898

Aron Budea  changed:

   What|Removed |Added

 Blocks||104442


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104442

Aron Budea  changed:

   What|Removed |Added

 Depends on||122898


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122898
[Bug 122898] FILESAVE DOCX, Shape loses its resize option when odt is saved as
docx
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115147] Sidebar pane offset and appearance is broken when editing charts

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115147

Aron Budea  changed:

   What|Removed |Added

Summary|Right pane offset and the   |Sidebar pane offset and
   |appearance was broken when  |appearance is broken when
   |editing charts  |editing charts
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3109
 Blocks||91063

--- Comment #10 from Aron Budea  ---
Bug 103109 is somewhat similar.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91063
[Bug 91063] [META] SIDEBAR: Properties tab for Charts
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91063] [META] SIDEBAR: Properties tab for Charts

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91063

Aron Budea  changed:

   What|Removed |Added

 Depends on||115147


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115147
[Bug 115147] Sidebar pane offset and appearance is broken when editing charts
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103109] Document scrollbar has positioning issues when contracting or uncontracting the Sidebar in chart edit mode

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103109

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5147

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #10 from V Stuart Foote  ---
So if I load the .CLP file from attachment 148573 into the Windows clipboard
using InsideClipboard I see the proprietary TC formats, but an empty CF_BITMAP
a CF_DIB, and a CF_DIBV5

A paste special into LO 6.1.4.2 offers "Bitmap Image (BMP)"; while a paste
special into AOO 4.1.6 offers "Bitmap"

Both bitmap pastes look to be low resolution ~72dpi

And, paste special into CorelDraw X7 offers "Device Independent Bitmap" and as
"Bitmap". Either renders the bitmap as RGB sized 128px x 128px at 72 x 72 dpi.

So, the handling of the DIB seems correct with the LibreOffice filters.  The
question then becomes is there something in the Copy to Bitmap function of
TurboCad that is no longer producing bitmap rasters of drawing elements at
desired resolution?  Alternatively, is there a vector format (WMF, EMF, SVG,
EPS) that was being provided but is now missing?


This is looking to be Not Our Bug as the ODF text document of attachment 147496
for the AOO rendering of what you call a "cut & paste" from TurboCad image to
be vector .SVM format--not a bitmap. 

So what does the Clipboard show when you've cut from TurboCad.  Could you post
a similar InsideClipboard.CLP dump of the clipboard for the Cut action?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - solenv/bin

2019-01-23 Thread Libreoffice Gerrit user
 solenv/bin/modules/installer/systemactions.pm |   76 +-
 1 file changed, 38 insertions(+), 38 deletions(-)

New commits:
commit fef416499d3559230d78288661d73fe59838273e
Author: Matthias Seidel 
AuthorDate: Wed Jan 23 23:07:15 2019 +
Commit: Matthias Seidel 
CommitDate: Wed Jan 23 23:07:15 2019 +

Removed whitespace, fixed typos

diff --git a/solenv/bin/modules/installer/systemactions.pm 
b/solenv/bin/modules/installer/systemactions.pm
index 181ac8b734ee..33e616bf33cd 100644
--- a/solenv/bin/modules/installer/systemactions.pm
+++ b/solenv/bin/modules/installer/systemactions.pm
@@ -8,7 +8,7 @@
 #  "License"); you may not use this file except in compliance
 #  with the License.  You may obtain a copy of the License at
 #
-#http://www.apache.org/licenses/LICENSE-2.0
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
 #  Unless required by applicable law or agreed to in writing,
 #  software distributed under the License is distributed on an
@@ -32,7 +32,7 @@ use installer::pathanalyzer;
 use installer::remover;
 
 ##
-# Creating a new direcotory
+# Creating a new directory
 ##
 
 sub create_directory
@@ -155,7 +155,7 @@ sub create_directory
 }
 
 ##
-# Creating a new direcotory with defined privileges
+# Creating a new directory with defined privileges
 ##
 
 sub create_directory_with_privileges
@@ -282,9 +282,9 @@ sub create_directory_with_privileges
 
 =item is_directory_empty ($path)
 Return
-1 if there are no files in the directory pointed to by $path
-0 if there are files
-   -1 if there is an error accessing the directory.
+ 1 if there are no files in the directory pointed to by $path
+ 0 if there are files
+-1 if there is an error accessing the directory.
 =cut
 sub is_directory_empty ($)
 {
@@ -309,7 +309,7 @@ sub is_directory_empty ($)
 
 
 ##
-# Removing a new direcotory
+# Removing a new directory
 ##
 
 sub remove_empty_directory
@@ -374,7 +374,7 @@ sub create_directories
 {
 my ($newdirectory, $languagesref) =@_;
 
-$installer::globals::unpackpath =~ 
s/\Q$installer::globals::separator\E\s*$//;  # removing ending slashes and 
backslashes
+$installer::globals::unpackpath =~ 
s/\Q$installer::globals::separator\E\s*$//; # removing ending slashes and 
backslashes
 
 my $path = "";
 
@@ -382,14 +382,14 @@ sub create_directories
 {
 if ( $installer::globals::temppathdefined ) { $path = 
$installer::globals::temppath; }
 else { $path = $installer::globals::unpackpath; }
-$path =~ s/\Q$installer::globals::separator\E\s*$//;# removing 
ending slashes and backslashes
+$path =~ s/\Q$installer::globals::separator\E\s*$//; # removing ending 
slashes and backslashes
 $path = $path . $installer::globals::separator;
 }
 elsif ( ( $newdirectory eq "jds" ) )
 {
 if ( $installer::globals::jdstemppathdefined ) { $path = 
$installer::globals::jdstemppath; }
 else { $path = $installer::globals::unpackpath; }
-$path =~ s/\Q$installer::globals::separator\E\s*$//;# removing 
ending slashes and backslashes
+$path =~ s/\Q$installer::globals::separator\E\s*$//; # removing ending 
slashes and backslashes
 $path = $path . $installer::globals::separator;
 installer::systemactions::create_directory($path);
 }
@@ -408,9 +408,9 @@ sub create_directories
 $infoline = "create_directories: Using $path for $newdirectory !\n";
 $installer::logger::Lang->print($infoline);
 
-if ($newdirectory eq "unzip" )  # special handling for common directory
+if ($newdirectory eq "unzip" ) # special handling for common directory
 {
-$path = $path  . ".." . $installer::globals::separator . "common" . 
$installer::globals::productextension . $installer::globals::separator;
+$path = $path . ".." . $installer::globals::separator . "common" . 
$installer::globals::productextension . $installer::globals::separator;
 create_directory($path);
 
 $path = $path . $newdirectory . $installer::globals::separator;
@@ -449,11 +449,11 @@ sub create_directories
 
 if ( $$languagesref ) { $locallanguagesref = $$languagesref; }
 
-if (!($locallanguagesref eq "" ))   # this will be a path like 
"01_49", for Profiles and ConfigurationFiles, idt-Files
+if (!($locallanguagesref eq "" )) # this will be a path like "01_49", 
for Profiles and ConfigurationFiles, idt-Files
 {
 my $languagestring = 
installer::languages::get_language_directory_name($$languagesref);
 
-$path = $path . $languagestring  . $installer::globals::separator;
+ 

[Libreoffice-bugs] [Bug 122846] CRASH: Clicking "Restart Now" after "Use OpenGL for all rendering"->"Apply" in Options Dialog

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122846

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2912

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122912] Another CRASH: "Apply"->"Restart Now" if UI Langauge is changed in Tools->Options

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122912

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2846

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122912] New: Another CRASH: "Apply"->"Restart Now" if UI Langauge is changed in Tools->Options

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122912

Bug ID: 122912
   Summary: Another CRASH: "Apply"->"Restart Now"  if UI Langauge
is changed in Tools->Options
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: himajin100...@gmail.com

Description:
see steps to reproduce

Steps to Reproduce:
This problem is very similar to tdf#122846 and tdf#121180

1. Make sure you have two or more UI Locales.

Currently Win-x86_64@42 provides en_US only, and I did not check whether there
are additional language packs for these nightlies

I often pass --with-lang="ja de" to autogen.sh when I make my own build.

2. Tools->Options From Start Center
3. LibreOfficeDev->Language Settings->Languages
4. User interface: English -> Japanese
5. Apply
6. Restart Now


Actual Results:
Crash

Expected Results:
No Crash


Reproducible: Always


User Profile Reset: No



Additional Info:
if Tools->Options is called NOT from Start Center(like Untitled), it doesn't
crash. but it doesn't seem to restart either.

I tested with my own local build, so It's meaningless to provide build-id

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122883] Incorrect view of background/watermark image from MSO

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122883

Mayan_Tigger  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122883] Incorrect view of background/watermark image from MSO

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122883

--- Comment #3 from Mayan_Tigger  ---
Created attachment 148576
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148576=edit
Here is the requested file in docx format

Here is the requested file in docx format

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

--- Comment #9 from V Stuart Foote  ---
attachment 148574 not comment :(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

V Stuart Foote  changed:

   What|Removed |Added

 Whiteboard||needs:TurboCad
 CC||armin.le.gr...@me.com,
   ||michael.me...@collabora.com
   ||, noelgran...@gmail.com

--- Comment #8 from V Stuart Foote  ---
So the Clipboard output shown in comment 148574 from TurboCad looks to only
hold CF_DIB (Device Independent Bitmap). But, if I understand correctly, that
is handled with ReadDIBBitmap(), so we should be able to filter it if it is
plumbed correctly for a paste action.

This got some tweaking with https://gerrit.libreoffice.org/#/c/55160/ 

Will check if the Insideclipboard .clp lets me bibisect behavior, or if I have
to scrounge a seat of TurboCad to test with.

But if this jumps out at any of you--Noel, Michael or Armin let me know...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122907] FORMATTING Style not correctly applied at conditional formatting

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122907

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
The issue happens because the cell has a direct format, and if I'm not wrong CF
respect them.

BTW there are a bit complicate formulas for the CF, if you go to A2 and set the
firsts formula 'AND(DAY(A2)=1;MONTH(A2)=1)' it should work. The matter here
it's go to the first cell of the CF's range, so relative ranges works properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - configure.ac

2019-01-23 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f3818e9a3984c81e2eb4b9ed6e5421584dfbe028
Author: Andras Timar 
AuthorDate: Wed Jan 23 23:57:42 2019 +
Commit: Andras Timar 
CommitDate: Wed Jan 23 23:57:42 2019 +

don't build MariaDB Connector with MPLv2 subset

Change-Id: I77159776e2f6625cdd23d1b11b36485325da2a3c

diff --git a/configure.ac b/configure.ac
index 1dc26523921c..795712ea084e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8104,7 +8104,7 @@ AC_SUBST(PYTHON_VERSION_MAJOR)
 AC_SUBST(PYTHON_VERSION_MINOR)
 
 ENABLE_MARIADBC=TRUE
-if test "$_os" = "iOS"; then
+if test "$_os" = "iOS" -o "$enable_mpl_subset" = "yes"; then
 ENABLE_MARIADBC=
 fi
 MARIADBC_MAJOR=1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

--- Comment #182 from marshall william  ---
Activation.kaspersky.com

Activation.kaspersky.com is the official page to activate your
kaspersky antivirus online. You just need to verify your activation code once
your visit the below mentioned URL.

https://www-activationkaspersky.com/

https://www-activationkaspersky.com/;>Activation.kaspersky.com

Once done your kaspersky antivrus will get activated after its
successfully installed on your computer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122911] New: Libre Office Impress does not handle german umlauts well

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122911

Bug ID: 122911
   Summary: Libre Office Impress does not handle german umlauts
well
   Product: LibreOffice
   Version: 6.1.4.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j.bless...@smartitconsulting.de

Description:
when using german umlauts it scrambles somtetime the text in presentation mnode
and in editor mode. It looks also like it is related to a specific font, if
switcheing the font to another font, its correct.
the font used is "Interstate bold"

Steps to Reproduce:
1.open existing impress doc
2.
3.

Actual Results:
some charachters seem do disappear and there are spaces show instead of the
characters. Umlauts are shown some cm outside the text...

Expected Results:
normal display of thge text


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

Amjad Qazi  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

--- Comment #7 from Amjad Qazi  ---
Created attachment 148575
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148575=edit
Image being copy/pasted as stored in InsideClipboard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

--- Comment #6 from Amjad Qazi  ---
Created attachment 148574
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148574=edit
Output image of InsideClipboard copy/paste

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

--- Comment #5 from Amjad Qazi  ---
Please find attached output from “InsideClipboard”, you will notice this does
not correspond to the output from nirsoft.net website. I have only been able to
reproduce this output over several attempts.

Copy and paste from TurboCad into Libre Draw works correctly and the image can
be correctly copy and pasted from Draw to Writer.

I also noticed that the image captured by InsideClipboard, attached, is
enclosed by two lines at the right and the bottom edges of the image and is
reproduced in this format in Libre Writer, any larger image is also compressed
into this size.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122072] Cut & paste image from TurboCad inserted in Writer doc is not correctly reproduced

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122072

--- Comment #4 from Amjad Qazi  ---
Created attachment 148573
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148573=edit
InsideClipboard saved file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115147] Right pane offset and the appearance was broken when editing charts

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115147

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
Version|5.2 all versions|5.1 all versions
 CC||ba...@caesar.elte.hu

--- Comment #9 from Aron Budea  ---
(In reply to Xisco Faulí from comment #4)
> because the sidebar menu didn't exists for charts in that version.
> Adding bibisectRequest to see when the menu was introduced
With the following commit, not particularly helpful, but the other relevant
commits should probably be close by:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=faed29cac93f8176bb937e6a8b437d6450b7a884
author  Markus Mohrhard
2015-07-14 15:07:29 +0200
committer   Markus Mohrhard
2015-07-16 08:15:17 +0200

for now show chart sidebar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82143] VIEWING: 100% CPU while Scrolling a specific document

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82143

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|DUPLICATE

--- Comment #26 from Xisco Faulí  ---
(In reply to Xisco Faulí from comment #25)
> The hang with sample1.docx was introduced with
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=18765b9fa739337d2d891513f6e2fb7c3ce23b50, which is already reported in
> bug 118104.
> Closing this issue as RESOLVED INSUFFICIENTDATA

Closing as a DUPLICATE of bug 118104 so we can track of it

*** This bug has been marked as a duplicate of bug 118104 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118104] Writer freezes after opening a file with 230 pages

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118104

Xisco Faulí  changed:

   What|Removed |Added

 CC||johannes.nickel@googlemail.
   ||com

--- Comment #9 from Xisco Faulí  ---
*** Bug 82143 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106503] Text Position in Writer And Calc Shapes is Inconsistent / Should Use the old defaults(Center Align)

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106503

Luke  changed:

   What|Removed |Added

Summary|Text Position in Writer And |Text Position in Writer And
   |Calc Shapes is Inconsistent |Calc Shapes is Inconsistent
   ||/ Should Use the old
   ||defaults(Center Align)
 CC||caol...@redhat.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106000] delete/edit comment in context box not an option if comment is escaped without writing anything in it.

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106000

Xisco Faulí  changed:

   What|Removed |Added

 CC||bogdan...@gmail.com

--- Comment #4 from Xisco Faulí  ---
*** Bug 122797 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118739] [META] Refactor ListBox/ComboBox to use RenderContext regressions

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118739
Bug 118739 depends on bug 122797, which changed state.

Bug 122797 Summary: Comments from Calc can not be deleted if the comment doesnt 
have text in it
https://bugs.documentfoundation.org/show_bug.cgi?id=122797

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122797] Comments from Calc can not be deleted if the comment doesnt have text in it

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122797

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
It seems like a duplicate of bug 106000

*** This bug has been marked as a duplicate of bug 106000 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: Branch 'libreoffice-6-2' - source/text

2019-01-23 Thread Libreoffice Gerrit user
 source/text/shared/06/youtubevideos.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2a1a5437380660d3221399116291407f5a16077d
Author: Olivier Hallot 
AuthorDate: Mon Jan 21 15:48:37 2019 -0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Jan 24 00:08:31 2019 +0100

Update New Features video for 6.2 help online

Change-Id: Ibe32ecee310b5d844c18e3cebec534328219325f
Reviewed-on: https://gerrit.libreoffice.org/66828
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins

diff --git a/source/text/shared/06/youtubevideos.xhp 
b/source/text/shared/06/youtubevideos.xhp
index a1552b98d..535190bae 100644
--- a/source/text/shared/06/youtubevideos.xhp
+++ b/source/text/shared/06/youtubevideos.xhp
@@ -17,7 +17,7 @@
 
 
 
-  https://www.youtube-nocookie.com/embed/JvoCpnwGNFU; 
id="vid_id61521568603544" type="video/youtube" width="560" 
height="315"/>
+https://www.youtube-nocookie.com/embed/59fbpIzEGsI; 
id="vid_id61521568603544" type="video/youtube" width="560" 
height="315"/>
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - helpcontent2

2019-01-23 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f793c2cecdce13383017501e8122465d243107af
Author: Olivier Hallot 
AuthorDate: Mon Jan 21 15:48:37 2019 -0200
Commit: Gerrit Code Review 
CommitDate: Thu Jan 24 00:08:31 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-2'
  - Update New Features video for 6.2 help online

Change-Id: Ibe32ecee310b5d844c18e3cebec534328219325f
Reviewed-on: https://gerrit.libreoffice.org/66828
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 196b47886583..2a1a54373806 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 196b47886583f7341d234e09a70e1271a121fb30
+Subproject commit 2a1a5437380660d3221399116291407f5a16077d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 100691] If hidden characters exist in headings, they appear visible in the table of contents

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100691

Xisco Faulí  changed:

   What|Removed |Added

 CC||michael.st...@cib.de

--- Comment #10 from Xisco Faulí  ---
Hi Michael,
I see you modified sw/source/core/tox/ToxTextGenerator.cxx recently in your
sw_redlinehide changes. Could you please take a look at this issue when you
have some time ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118599] EDITING: Paste uses wrong data

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118599

raal  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #13 from raal  ---
Closing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 73966] FORMATTING: bullets images should resize with text

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73966

Luke  changed:

   What|Removed |Added

 CC||zolnaitamas2...@gmail.com

--- Comment #7 from Luke  ---
Tamás,
You're working on this area. Would you be interested in taking a look at this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 122707] Writer: Print (selected) pages harder to use in new printer dialog in 6.3+

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122707

--- Comment #3 from Daniel Silva  ---
(In reply to Timur from comment #0)
> Since there seems to be enough space, I don't know why there's dropdown for: 
> Print all pages,
> Print pages,
> Print even pages,
> Print odd pages.
> IMHO, radio would be better.

There seems to be extra space available, but that space is reserved for custom
options of N-Up configuration that are hidden by default. Under "Pages per
sheet", select "Custom" option and those extra options will show up.

(In reply to Heiko Tietze from comment #2)
> The decision was made by the devs to save space. Talked to him about this
> during last year's conference. Not sure how much time Daniel is willing to
> put into the project after GSoC.

I think I am not in a position to make promises that I will have plenty of time
to still work in the print dialog, but I would like to continue contributing
whenever I can.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 122707] Writer: Print (selected) pages harder to use in new printer dialog in 6.3+

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122707

--- Comment #3 from Daniel Silva  ---
(In reply to Timur from comment #0)
> Since there seems to be enough space, I don't know why there's dropdown for: 
> Print all pages,
> Print pages,
> Print even pages,
> Print odd pages.
> IMHO, radio would be better.

There seems to be extra space available, but that space is reserved for custom
options of N-Up configuration that are hidden by default. Under "Pages per
sheet", select "Custom" option and those extra options will show up.

(In reply to Heiko Tietze from comment #2)
> The decision was made by the devs to save space. Talked to him about this
> during last year's conference. Not sure how much time Daniel is willing to
> put into the project after GSoC.

I think I am not in a position to make promises that I will have plenty of time
to still work in the print dialog, but I would like to continue contributing
whenever I can.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: oovbaapi/ooo sw/source

2019-01-23 Thread Libreoffice Gerrit user
 oovbaapi/ooo/vba/word/XWordBasic.idl |1 +
 sw/source/ui/vba/vbaapplication.cxx  |   20 
 2 files changed, 21 insertions(+)

New commits:
commit 82ed9aa096aea95c2a9fe0ca9c1d27b70dcbc8fa
Author: Tor Lillqvist 
AuthorDate: Wed Jan 23 18:33:50 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Jan 24 00:33:14 2019 +0200

Add WordBasic.FileClose()

Change-Id: Ifc48e5fbcc212f0e80cf6877e2781910e38e5e54

diff --git a/oovbaapi/ooo/vba/word/XWordBasic.idl 
b/oovbaapi/ooo/vba/word/XWordBasic.idl
index d704b92b122c..5150a431401b 100644
--- a/oovbaapi/ooo/vba/word/XWordBasic.idl
+++ b/oovbaapi/ooo/vba/word/XWordBasic.idl
@@ -18,6 +18,7 @@ interface XWordBasic
 
 void FileOpen( [in] string Name, [in] any ConfirmConversions, [in] any 
ReadOnly, [in] any AddToMru, [in] any PasswordDoc, [in] any PasswordDot, [in] 
any Revert, [in] any WritePasswordDoc, [in] any WritePasswordDot );
 void FileSave();
+void FileClose( [in] any Save );
 void ToolsOptionsView( [in] any DraftFont, [in] any WrapToWindow, [in] any 
PicturePlaceHolders, [in] any FieldCodes, [in] any BookMarks, [in] any 
FieldShading, [in] any StatusBar, [in] any HScroll, [in] any VScroll, [in] any 
StyleAreaWidth, [in] any Tabs, [in] any Spaces, [in] any Paras, [in] any 
Hyphens, [in] any Hidden, [in] any ShowAll, [in] any Drawings, [in] any 
Anchors, [in] any TextBoundaries, [in] any VRuler, [in] any Highlight );
 string WindowName();
 boolean ExistingBookmark( [in] string Name );
diff --git a/sw/source/ui/vba/vbaapplication.cxx 
b/sw/source/ui/vba/vbaapplication.cxx
index 6836f5ab7c5d..d9e33430c9d1 100644
--- a/sw/source/ui/vba/vbaapplication.cxx
+++ b/sw/source/ui/vba/vbaapplication.cxx
@@ -77,6 +77,7 @@ public:
 
 virtual void SAL_CALL FileOpen( const OUString& Name, const uno::Any& 
ConfirmConversions, const uno::Any& ReadOnly, const uno::Any& AddToMru, const 
uno::Any& PasswordDoc, const uno::Any& PasswordDot, const uno::Any& Revert, 
const uno::Any& WritePasswordDoc, const uno::Any& WritePasswordDot ) override;
 virtual void SAL_CALL FileSave() override;
+virtual void SAL_CALL FileClose( const css::uno::Any& Save ) override;
 virtual void SAL_CALL ToolsOptionsView( const css::uno::Any& DraftFont,
 const css::uno::Any& WrapToWindow,
 const css::uno::Any& 
PicturePlaceHolders,
@@ -539,6 +540,25 @@ SwWordBasic::FileSave()
 }
 
 void SAL_CALL
+SwWordBasic::FileClose( const css::uno::Any& Save )
+{
+uno::Reference< frame::XModel > xModel( mpApp->getCurrentDocument(), 
uno::UNO_SET_THROW );
+
+bool bSave = false;
+if (Save.hasValue() && (Save >>= bSave) && bSave)
+FileSave();
+
+// FIXME: Here I would much prefer to call VbaDocumentBase::Close() but 
not sure how to get at
+// the VbaDocumentBase of the current document. (Probably it is easy and I 
haven't looked hard
+// enough.)
+//
+// FIXME: Error handling. If there is no current document, return some 
kind of error? But for
+// now, just ignore errors. This code is written to work for a very 
specific customer use case
+// ayway, not for an arbitrary sequence of COM calls to the "VBA" API.
+dispatchRequests(xModel,".uno:CloseDoc");
+}
+
+void SAL_CALL
 SwWordBasic::ToolsOptionsView( const css::uno::Any& DraftFont,
const css::uno::Any& WrapToWindow,
const css::uno::Any& PicturePlaceHolders,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122910] New: Cut+undo of formulas loses absolute and performs a relative paste

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122910

Bug ID: 122910
   Summary: Cut+undo of formulas loses absolute and performs a
relative paste
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: openfo...@davidpbrown.co.uk

Simple unexpected result from cut-paste of formulas:
1. Create a cell with content eg A1
2. Create another cell linked to that with formula "=A1"
3. Cut the formula with Ctrl-X
4. Paste to any other cell with Ctrl-V, works.
5. Undo.
6 .Paste again with Ctrl-V and it fails as a redone formula relative to the
distance of the new cell from original cell, instead of see the same result.

Problem then for lack of visibility of that difference and likely introduction
of errors, on the back of minor corrections of intent to paste to one cell and
putting wrongly and re-correcting, which potentially might occur frequently
enough to not be minor.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #221 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ce218f3064f58a836be6f0fba75576bfbe031404%5E%21

tdf#45904 Move XElementAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #222 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/be3dce73f9ad16145b5f898058bab416504bc9c3%5E%21

tdf#45904 Move XIndexAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #220 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/cae2d0cda5d462889274a6ea0be30b8c0e9f8c6e%5E%21

tdf#45904 Move XEnumerationAccess Java test to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2019-01-23 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv |2 -
 sc/qa/extras/scsheetlinksobj.cxx|   11 
+-
 2 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit ce218f3064f58a836be6f0fba75576bfbe031404
Author: Jens Carl 
AuthorDate: Wed Jan 23 18:58:30 2019 +
Commit: Jens Carl 
CommitDate: Wed Jan 23 23:24:35 2019 +0100

tdf#45904 Move XElementAccess Java tests to C++

Move XElementAccess Java tests to C++ for ScSheetLinksObj.

Change-Id: I8265bb9234c93e8a6e64b55522e7f0543b3af7a9
Reviewed-on: https://gerrit.libreoffice.org/66815
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
index d6a8db0b257b..6a9e3218d0bb 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
@@ -3,5 +3,3 @@
 "ScSheetLinksObj";"com::sun::star::container::XNameAccess";"hasByName()"
 "ScSheetLinksObj";"com::sun::star::container::XIndexAccess";"getCount()"
 "ScSheetLinksObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
-"ScSheetLinksObj";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScSheetLinksObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/scsheetlinksobj.cxx b/sc/qa/extras/scsheetlinksobj.cxx
index 2d3b0d714732..2ec4ccf0be6e 100644
--- a/sc/qa/extras/scsheetlinksobj.cxx
+++ b/sc/qa/extras/scsheetlinksobj.cxx
@@ -8,8 +8,10 @@
  */
 
 #include 
+#include 
 #include 
 
+#include 
 #include 
 
 #include 
@@ -28,7 +30,9 @@ using namespace css;
 
 namespace sc_apitest
 {
-class ScSheetLinksObj : public CalcUnoApiTest, public 
apitest::XEnumerationAccess
+class ScSheetLinksObj : public CalcUnoApiTest,
+public apitest::XElementAccess,
+public apitest::XEnumerationAccess
 {
 public:
 ScSheetLinksObj();
@@ -39,6 +43,10 @@ public:
 
 CPPUNIT_TEST_SUITE(ScSheetLinksObj);
 
+// XElementAccess
+CPPUNIT_TEST(testGetElementType);
+CPPUNIT_TEST(testHasElements);
+
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
@@ -50,6 +58,7 @@ private:
 
 ScSheetLinksObj::ScSheetLinksObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XElementAccess(cppu::UnoType::get())
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2019-01-23 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv |2 --
 sc/qa/extras/scsheetlinksobj.cxx|9 
-
 2 files changed, 8 insertions(+), 3 deletions(-)

New commits:
commit be3dce73f9ad16145b5f898058bab416504bc9c3
Author: Jens Carl 
AuthorDate: Wed Jan 23 19:02:58 2019 +
Commit: Jens Carl 
CommitDate: Wed Jan 23 23:24:59 2019 +0100

tdf#45904 Move XIndexAccess Java tests to C++

Move XIndexAccess Java tests to C++ for ScSheetLinksObj.

Change-Id: I1662766ab9026da7c8ce97953e4f690d94c2d479
Reviewed-on: https://gerrit.libreoffice.org/66816
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
index 6a9e3218d0bb..9903e39826f0 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
@@ -1,5 +1,3 @@
 "ScSheetLinksObj";"com::sun::star::container::XNameAccess";"getByName()"
 "ScSheetLinksObj";"com::sun::star::container::XNameAccess";"getElementNames()"
 "ScSheetLinksObj";"com::sun::star::container::XNameAccess";"hasByName()"
-"ScSheetLinksObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScSheetLinksObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
diff --git a/sc/qa/extras/scsheetlinksobj.cxx b/sc/qa/extras/scsheetlinksobj.cxx
index 2ec4ccf0be6e..350924dcdd70 100644
--- a/sc/qa/extras/scsheetlinksobj.cxx
+++ b/sc/qa/extras/scsheetlinksobj.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -32,7 +33,8 @@ namespace sc_apitest
 {
 class ScSheetLinksObj : public CalcUnoApiTest,
 public apitest::XElementAccess,
-public apitest::XEnumerationAccess
+public apitest::XEnumerationAccess,
+public apitest::XIndexAccess
 {
 public:
 ScSheetLinksObj();
@@ -50,6 +52,10 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -59,6 +65,7 @@ private:
 ScSheetLinksObj::ScSheetLinksObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 , XElementAccess(cppu::UnoType::get())
+, XIndexAccess(1)
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: qadevOOo/objdsc sc/CppunitTest_sc_sheetlinksobj.mk sc/Module_sc.mk sc/qa

2019-01-23 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv |1 
 sc/CppunitTest_sc_sheetlinksobj.mk  |   43 
 sc/Module_sc.mk |1 
 sc/qa/extras/scsheetlinksobj.cxx|   94 
++
 4 files changed, 138 insertions(+), 1 deletion(-)

New commits:
commit cae2d0cda5d462889274a6ea0be30b8c0e9f8c6e
Author: Jens Carl 
AuthorDate: Wed Jan 23 18:52:20 2019 +
Commit: Jens Carl 
CommitDate: Wed Jan 23 23:24:05 2019 +0100

tdf#45904 Move XEnumerationAccess Java test to C++

Move XEnumerationAccess Java test to C++ for ScSheetLinksObj.

Change-Id: I68013a9717ab8da1dd4b15f489fc394c101cc016
Reviewed-on: https://gerrit.libreoffice.org/66814
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
index e8e7b8abb039..d6a8db0b257b 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinksObj.csv
@@ -5,4 +5,3 @@
 "ScSheetLinksObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScSheetLinksObj";"com::sun::star::container::XElementAccess";"getElementType()"
 "ScSheetLinksObj";"com::sun::star::container::XElementAccess";"hasElements()"
-"ScSheetLinksObj";"com::sun::star::container::XEnumerationAccess";"createEnumeration()"
diff --git a/sc/CppunitTest_sc_sheetlinksobj.mk 
b/sc/CppunitTest_sc_sheetlinksobj.mk
new file mode 100644
index ..15a80fe23658
--- /dev/null
+++ b/sc/CppunitTest_sc_sheetlinksobj.mk
@@ -0,0 +1,43 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sc_sheetlinksobj))
+
+$(eval $(call gb_CppunitTest_use_external,sc_sheetlinksobj,boost_headers))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sc_sheetlinksobj, \
+   sc/qa/extras/scsheetlinksobj \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sc_sheetlinksobj, \
+   cppu \
+   sal \
+   subsequenttest \
+   test \
+   unotest \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sc_sheetlinksobj,\
+   $$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,sc_sheetlinksobj))
+
+$(eval $(call gb_CppunitTest_use_ure,sc_sheetlinksobj))
+$(eval $(call gb_CppunitTest_use_vcl,sc_sheetlinksobj))
+
+$(eval $(call gb_CppunitTest_use_components,sc_sheetlinksobj,\
+   $(sc_unoapi_common_components) \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,sc_sheetlinksobj))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 8d7d327b0d1d..ddb29c745cc6 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -176,6 +176,7 @@ $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\
CppunitTest_sc_scenariosobj \
CppunitTest_sc_shapeobj \
CppunitTest_sc_sheetlinkobj \
+   CppunitTest_sc_sheetlinksobj \
CppunitTest_sc_sortdescriptorbaseobj \
CppunitTest_sc_spreadsheetsettings \
CppunitTest_sc_spreadsheetsettingsobj \
diff --git a/sc/qa/extras/scsheetlinksobj.cxx b/sc/qa/extras/scsheetlinksobj.cxx
new file mode 100644
index ..2d3b0d714732
--- /dev/null
+++ b/sc/qa/extras/scsheetlinksobj.cxx
@@ -0,0 +1,94 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+using namespace css;
+
+namespace sc_apitest
+{
+class ScSheetLinksObj : public CalcUnoApiTest, public 
apitest::XEnumerationAccess
+{
+public:
+ScSheetLinksObj();
+
+virtual uno::Reference init() override;
+virtual void setUp() override;
+virtual void tearDown() override;
+
+CPPUNIT_TEST_SUITE(ScSheetLinksObj);
+
+// XEnumerationAccess
+CPPUNIT_TEST(testCreateEnumeration);
+
+CPPUNIT_TEST_SUITE_END();
+
+private:
+uno::Reference m_xComponent;
+};
+
+ScSheetLinksObj::ScSheetLinksObj()
+: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+{
+}
+
+uno::Reference ScSheetLinksObj::init()
+{
+uno::Reference xDoc(m_xComponent, 

[Libreoffice-bugs] [Bug 122835] Selecting a page's first line also selects beginning-of-page marker

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122835

--- Comment #6 from Johannes Riecken  ---
Created attachment 148572
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148572=edit
screencast of bug with page-break paragraph styling

Here is a short screencast. Let me know if you need any other information. It
looks like the problem only appears with .docx files, be they generated by Word
or by LibreOffice. In a .docx file generated by Word the "insert page break
before" is checked under paragraph styling, but looks like when I generate the
.docx file within LibreOffice that's not the case. So here's the amended steps:

Steps to reproduce:
1. In a new document type LoremIpsum
2. Save as .docx, close LibreOffice and open the file again.
3. Move to the beginning of line 1 and select it with shift down arrow. 
4. Cut the line.
5. Move to the empty line at the end and paste.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - distro-configs/CPLinux-MPL.conf

2019-01-23 Thread Libreoffice Gerrit user
 distro-configs/CPLinux-MPL.conf |   62 
 1 file changed, 62 insertions(+)

New commits:
commit 9faf0001516c3c7898331a2f38863046b85fe5e1
Author: Andras Timar 
AuthorDate: Wed Jan 23 23:09:21 2019 +0100
Commit: Andras Timar 
CommitDate: Wed Jan 23 23:12:43 2019 +0100

CPLinux-MPL.conf

Change-Id: If0087ff8d079ee91e087d8589b7bcc99ad21efa5

diff --git a/distro-configs/CPLinux-MPL.conf b/distro-configs/CPLinux-MPL.conf
new file mode 100644
index ..cf23fed6dd61
--- /dev/null
+++ b/distro-configs/CPLinux-MPL.conf
@@ -0,0 +1,62 @@
+--enable-mpl-subset
+--with-vendor=Collabora
+--with-branding=icon-themes/galaxy/brand_cp
+--with-system-dicts
+--with-myspell-dicts
+--with-system-zlib
+--with-system-poppler
+--without-system-cairo
+--with-system-openssl
+--with-system-libpng
+--with-system-libxml
+--with-system-jpeg
+--with-system-expat
+--with-system-curl
+--with-system-icu
+--with-system-nss
+--without-system-jars
+--without-system-postgresql
+--without-java
+--without-junit
+--without-help
+--with-linker-hash-style=both
+--with-fonts
+--enable-noto-font
+--with-galleries=no
+--with-theme=galaxy tango
+--with-external-thes-dir=/usr/share/mythes
+--with-external-hyph-dir=/usr/share/hyphen
+--with-external-dict-dir=/usr/share/hunspell
+--disable-dbus
+--enable-extension-integration
+--disable-odk
+--disable-kde4
+--disable-gtk3
+--disable-gtk
+--disable-gstreamer-0-10
+--disable-gstreamer-1-0
+--disable-evolution2
+--disable-gio
+--disable-scripting-beanshell
+--disable-scripting-javascript
+--disable-ext-wiki-publisher
+--disable-report-builder
+--disable-ext-nlpsolver
+--disable-sdremote
+--disable-sdremote-bluetooth
+--disable-postgresql-sdbc
+--disable-firebird-sdbc
+--disable-randr
+--disable-ext-numbertext
+--disable-ext-ct2n
+--enable-epm
+--enable-python=internal
+--disable-online-update
+--disable-dconf
+--enable-mergelibs
+--with-package-format=deb
+--enable-release-build
+--with-lang=ar as ast bg bn-IN br ca ca-valencia cy cs da de el en-US en-GB es 
et eu fi fr ga gd gl gu he hi hr hu id is it ja km kn ko lt lv ml mr nb nl nn 
oc or pa-IN pl pt pt-BR ro ru sk sl sr sr-Latn sv ta te tr uk vi zh-CN zh-TW
+--with-webdav=serf
+--disable-lotuswordpro
+--disable-lpsolve
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122223] Document recovery dialog is not visible in the task bar

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=13

Michael Weghorn  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #9 from Michael Weghorn  ---
Thanks for testing.

(In reply to rwman from comment #8)
> But the window icon in the taskbar is default "X" icon, not the proper
> libreoffice one. Is it related to these messages i got when installed from
> the rpm files?
> 
> mkdir: cannot create directory
> ‘/usr/share/icons/hicolor/icon-theme.cache’: Not a directory
> mkdir: cannot create directory ‘/usr/share/icons/hicolor/index.theme’:
> Not a directory

I can't say right away.

> These are indeed regular files, not directories.
> Should i create new issue for the missing icons?

Yes, please do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119591] MacOS: Memory isn't released to the initial state when closing a file after saving

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119591

--- Comment #3 from Tor Lillqvist  ---
About Telesto's initial description: What you describe isn't necessarily a bug.
If the initial state is the Start Centre, it is very normal that after loading
a document (for instance, a Writer one) and then closing that document, a lot
of persistent data structures and code related to Writer functionality were
constructed in and/or loaded into memory. Those don't go away even if you close
the only Writer document open.

What would be a problem is if for each time you open the same document
(preferably a simple one that doesn't do any weird things like run BASIC macros
etc) and close it, the memory consumption increases a lot.

What Alex describes then sounds like a much more serious and different type of
problem indeed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: Changes to 'distro/collabora/collabora-online-cd-4'

2019-01-23 Thread Libreoffice Gerrit user
New branch 'distro/collabora/collabora-online-cd-4' available with the 
following commits:
commit fc33d6ee55a179dd78e1d7393eb1e36936aeec8c
Author: Andras Timar 
Date:   Tue May 29 21:55:40 2018 +0200

[cd] missing dependencies

(cherry picked from commit 0d5abf9189e2614305fa05361009af7e982ed91c)

Change-Id: I6d7b248c2f583a6c8fbfde8937a0bf6d30358f7b
(cherry picked from commit e21f347b06f3317dc47370aa0d33e2952528fa35)

commit 69b60076039400c71a0be527306affd716734731
Author: Ashod Nakashian 
Date:   Mon Mar 19 20:58:40 2018 -0400

[cd] leaflet: don't show 'failed to load doc' error

Change-Id: I5219a1f78f22dceb193d8a1856b3bd208e5ebbcf
(cherry picked from commit 19dd3f8d17fbfa7cb95ac879ebecc3e1b6d8a585)
(cherry picked from commit 0fb0b00996e71873c49f97442d8310fb8c3d8b31)

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Changes to 'refs/tags/CODE-4-RC3'

2019-01-23 Thread Libreoffice Gerrit user
Tag 'CODE-4-RC3' created by Andras Timar  at 
2019-01-23 21:54 +

CODE-4-RC3

Changes since CODE-4-RC2-79:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - 3 commits - bundled/include debian/changelog debian/control loolwsd.spec.in

2019-01-23 Thread Libreoffice Gerrit user
 bundled/include/LibreOfficeKit/LibreOfficeKit.h |   10 ++
 bundled/include/LibreOfficeKit/LibreOfficeKit.hxx   |   12 
 bundled/include/LibreOfficeKit/LibreOfficeKitInit.h |1 +
 debian/changelog|6 ++
 debian/control  |2 +-
 loolwsd.spec.in |8 ++--
 6 files changed, 36 insertions(+), 3 deletions(-)

New commits:
commit bdf2f619e92f105615b67c101442ddcb32ee
Author: Andras Timar 
AuthorDate: Wed Jan 23 22:51:57 2019 +0100
Commit: Andras Timar 
CommitDate: Wed Jan 23 22:51:57 2019 +0100

Bump package version to 4.0.0-5

Change-Id: I969151adec90edef63126129e3612a66f732f1ec

diff --git a/debian/changelog b/debian/changelog
index 07388db6b..252c78c81 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+loolwsd (4.0.0-5) unstable; urgency=medium
+
+  * see the git log: http://col.la/cool4
+
+ -- Andras Timar   Wed, 23 Jan 2019 22:50:00 +0100
+
 loolwsd (4.0.0-4) unstable; urgency=medium
 
   * see the git log: http://col.la/cool4
diff --git a/debian/control b/debian/control
index 3b4b5723a..7c891a7c4 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
 Package: loolwsd
 Section: web
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libsm6, libxinerama1, 
libxrender1, libgl1-mesa-glx, libcups2, libxcb-render0, libxcb-shm0, 
locales-all, adduser, expat, fontconfig, cpio, libcap2-bin, 
collaboraofficebasis6.0-calc (>= 6.0.10.20), collaboraofficebasis6.0-core (>= 
6.0.10.20), collaboraofficebasis6.0-graphicfilter (>= 6.0.10.20), 
collaboraofficebasis6.0-images (>= 6.0.10.20), collaboraofficebasis6.0-impress 
(>= 6.0.10.20), collaboraofficebasis6.0-ooofonts (>= 6.0.10.20), 
collaboraofficebasis6.0-writer (>= 6.0.10.20), collaboraoffice6.0 (>= 
6.0.10.20), collaboraoffice6.0-ure (>= 6.0.10.20), 
collaboraofficebasis6.0-en-us (>= 6.0.10.20), collaboraofficebasis6.0-draw (>= 
6.0.10.20), collaboraofficebasis6.0-extension-pdf-import (>= 6.0.10.20), 
collaboraofficebasis6.0-ooolinguistic (>= 6.0.10.20), 
collaboraoffice6.0-dict-en (>= 6.0.10.20)
+Depends: ${shlibs:Depends}, ${misc:Depends}, libsm6, libxinerama1, 
libxrender1, libgl1-mesa-glx, libcups2, libxcb-render0, libxcb-shm0, 
locales-all, adduser, expat, fontconfig, cpio, libcap2-bin, 
collaboraofficebasis6.0-calc (>= 6.0.10.21), collaboraofficebasis6.0-core (>= 
6.0.10.21), collaboraofficebasis6.0-graphicfilter (>= 6.0.10.21), 
collaboraofficebasis6.0-images (>= 6.0.10.21), collaboraofficebasis6.0-impress 
(>= 6.0.10.21), collaboraofficebasis6.0-ooofonts (>= 6.0.10.21), 
collaboraofficebasis6.0-writer (>= 6.0.10.21), collaboraoffice6.0 (>= 
6.0.10.21), collaboraoffice6.0-ure (>= 6.0.10.21), 
collaboraofficebasis6.0-en-us (>= 6.0.10.21), collaboraofficebasis6.0-draw (>= 
6.0.10.21), collaboraofficebasis6.0-extension-pdf-import (>= 6.0.10.21), 
collaboraofficebasis6.0-ooolinguistic (>= 6.0.10.21), 
collaboraoffice6.0-dict-en (>= 6.0.10.21)
 Conflicts: collaboraofficebasis6.0-gnome-integration, 
collaboraofficebasis6.0-kde-integration
 Description: LibreOffice Online WebSocket Daemon
  LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 1678c505b..9a7233932 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -12,7 +12,7 @@ Name:   loolwsd%{name_suffix}
 Name:   loolwsd
 %endif
 Version:@PACKAGE_VERSION@
-Release:4%{?dist}
+Release:5%{?dist}
 %if 0%{?suse_version} == 1110
 Group:  Productivity/Office/Suite
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
@@ -38,7 +38,7 @@ BuildRequires:  libcap-progs linux-glibc-devel 
systemd-rpm-macros
 BuildRequires:  libcap-progs
 %endif
 
-Requires:   collaboraoffice6.0 >= 6.0.10.20 collaboraoffice6.0-ure >= 
6.0.10.20 collaboraofficebasis6.0-core >= 6.0.10.20 
collaboraofficebasis6.0-writer >= 6.0.10.20 collaboraofficebasis6.0-impress >= 
6.0.10.20 collaboraofficebasis6.0-graphicfilter >= 6.0.10.20 
collaboraofficebasis6.0-en-US >= 6.0.10.20 collaboraofficebasis6.0-calc >= 
6.0.10.20 collaboraofficebasis6.0-ooofonts >= 6.0.10.20 
collaboraofficebasis6.0-images >= 6.0.10.20 collaboraofficebasis6.0-draw >= 
6.0.10.20 collaboraofficebasis6.0-extension-pdf-import >= 6.0.10.20 
collaboraofficebasis6.0-ooolinguistic >= 6.0.10.20 collaboraoffice6.0-dict-en 
>= 6.0.10.20
+Requires:   collaboraoffice6.0 >= 6.0.10.21 collaboraoffice6.0-ure >= 
6.0.10.21 collaboraofficebasis6.0-core >= 6.0.10.21 
collaboraofficebasis6.0-writer >= 6.0.10.21 collaboraofficebasis6.0-impress >= 
6.0.10.21 collaboraofficebasis6.0-graphicfilter >= 6.0.10.21 
collaboraofficebasis6.0-en-US >= 6.0.10.21 collaboraofficebasis6.0-calc >= 
6.0.10.21 collaboraofficebasis6.0-ooofonts >= 6.0.10.21 
collaboraofficebasis6.0-images >= 6.0.10.21 collaboraofficebasis6.0-draw >= 
6.0.10.21 

[Libreoffice-bugs] [Bug 122902] Impress hangs for a while when opening or saving a document. FILEOPEN FILESAVE

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122902

--- Comment #5 from Clay Spence  ---
Yes, the problem does not happen with that file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - oovbaapi/ooo sw/source

2019-01-23 Thread Libreoffice Gerrit user
 oovbaapi/ooo/vba/word/XWordBasic.idl |1 +
 sw/source/ui/vba/vbaapplication.cxx  |   20 
 2 files changed, 21 insertions(+)

New commits:
commit e4b3fd40e583fbcbeba0bfb0a1457c1f92e1cb0f
Author: Tor Lillqvist 
AuthorDate: Wed Jan 23 18:33:50 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Jan 23 18:35:44 2019 +0200

Add WordBasic.FileClose()

Change-Id: Ifc48e5fbcc212f0e80cf6877e2781910e38e5e54

diff --git a/oovbaapi/ooo/vba/word/XWordBasic.idl 
b/oovbaapi/ooo/vba/word/XWordBasic.idl
index d704b92b122c..5150a431401b 100644
--- a/oovbaapi/ooo/vba/word/XWordBasic.idl
+++ b/oovbaapi/ooo/vba/word/XWordBasic.idl
@@ -18,6 +18,7 @@ interface XWordBasic
 
 void FileOpen( [in] string Name, [in] any ConfirmConversions, [in] any 
ReadOnly, [in] any AddToMru, [in] any PasswordDoc, [in] any PasswordDot, [in] 
any Revert, [in] any WritePasswordDoc, [in] any WritePasswordDot );
 void FileSave();
+void FileClose( [in] any Save );
 void ToolsOptionsView( [in] any DraftFont, [in] any WrapToWindow, [in] any 
PicturePlaceHolders, [in] any FieldCodes, [in] any BookMarks, [in] any 
FieldShading, [in] any StatusBar, [in] any HScroll, [in] any VScroll, [in] any 
StyleAreaWidth, [in] any Tabs, [in] any Spaces, [in] any Paras, [in] any 
Hyphens, [in] any Hidden, [in] any ShowAll, [in] any Drawings, [in] any 
Anchors, [in] any TextBoundaries, [in] any VRuler, [in] any Highlight );
 string WindowName();
 boolean ExistingBookmark( [in] string Name );
diff --git a/sw/source/ui/vba/vbaapplication.cxx 
b/sw/source/ui/vba/vbaapplication.cxx
index 1a49c04635ab..a8279c18b413 100644
--- a/sw/source/ui/vba/vbaapplication.cxx
+++ b/sw/source/ui/vba/vbaapplication.cxx
@@ -76,6 +76,7 @@ public:
 
 virtual void SAL_CALL FileOpen( const OUString& Name, const uno::Any& 
ConfirmConversions, const uno::Any& ReadOnly, const uno::Any& AddToMru, const 
uno::Any& PasswordDoc, const uno::Any& PasswordDot, const uno::Any& Revert, 
const uno::Any& WritePasswordDoc, const uno::Any& WritePasswordDot ) override;
 virtual void SAL_CALL FileSave() override;
+virtual void SAL_CALL FileClose( const css::uno::Any& Save ) override;
 virtual void SAL_CALL ToolsOptionsView( const css::uno::Any& DraftFont,
 const css::uno::Any& WrapToWindow,
 const css::uno::Any& 
PicturePlaceHolders,
@@ -541,6 +542,25 @@ SwWordBasic::FileSave()
 }
 
 void SAL_CALL
+SwWordBasic::FileClose( const css::uno::Any& Save )
+{
+uno::Reference< frame::XModel > xModel( mpApp->getCurrentDocument(), 
uno::UNO_SET_THROW );
+
+sal_Bool bSave = false;
+if (Save.hasValue() && (Save >>= bSave) && bSave)
+FileSave();
+
+// FIXME: Here I would much prefer to call VbaDocumentBase::Close() but 
not sure how to get at
+// the VbaDocumentBase of the current document. (Probably it is easy and I 
haven't looked hard
+// enough.)
+//
+// FIXME: Error handling. If there is no current document, return some 
kind of error? But for
+// now, just ignore errors. This code is written to work for a very 
specific customer use case
+// ayway, not for an arbitrary sequence of COM calls to the "VBA" API.
+dispatchRequests(xModel,".uno:CloseDoc");
+}
+
+void SAL_CALL
 SwWordBasic::ToolsOptionsView( const css::uno::Any& DraftFont,
const css::uno::Any& WrapToWindow,
const css::uno::Any& PicturePlaceHolders,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 118599] EDITING: Paste uses wrong data

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118599

--- Comment #12 from Jeff Laramie  ---
(In reply to Xisco Faulí from comment #11)
> (In reply to Jeff Laramie from comment #10)
> > Version 5.4.7.2 from your site does not contain the bug.
> 
> Do you mean the problem is no longer reproduced with the latest version of
> LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?

I have not tried the newest version, but 5.4.7.2 was the newest version at the
time I tested, and it did not contain the bug. I have only been able to
replicate this bug using a Mageia packaged version running the KDE desktop.
Other desktops and versions work fine. It does not appear to be related to your
code and this bug report can be closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: source/text

2019-01-23 Thread Libreoffice Gerrit user
 source/text/sbasic/python/main.xhp |2 +-
 source/text/sbasic/python/python_ide.xhp   |2 +-
 source/text/sbasic/python/python_locations.xhp |2 +-
 source/text/swriter/04/0102.xhp|6 ++
 4 files changed, 5 insertions(+), 7 deletions(-)

New commits:
commit 85757c5b58b7fed1535d787053d4361d32e1374c
Author: Adolfo Jayme Barrientos 
AuthorDate: Wed Jan 23 15:25:58 2019 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Jan 23 15:25:58 2019 -0600

Fix some typos

Change-Id: Ife8c609e1db336417077a31d8a549614e00bd91b

diff --git a/source/text/sbasic/python/main.xhp 
b/source/text/sbasic/python/main.xhp
index 4f234f22b..3b8ed3730 100644
--- a/source/text/sbasic/python/main.xhp
+++ b/source/text/sbasic/python/main.xhp
@@ -28,7 +28,7 @@
 
 
 Working with Python Scripts in %PRODUCTNAME
-You can execute Python scripts 
choosing Tools - Macros – Run macro Editing scripts 
can be done with your preferred text editor. Python scripts are present in 
various locations detailed hereafter. You can refer to Programming examples for 
macros illustrating how to run Python interactive console from %PRODUCTNAME 
.
+You can execute Python scripts 
choosing Tools - Macros - Run Macro. Editing scripts can 
be done with your preferred text editor. Python scripts are present in various 
locations detailed hereafter. You can refer to Programming examples for macros 
illustrating how to run the Python interactive console from 
%PRODUCTNAME.
 
 
 
diff --git a/source/text/sbasic/python/python_ide.xhp 
b/source/text/sbasic/python/python_ide.xhp
index 33871a89c..d1bc36e1f 100644
--- a/source/text/sbasic/python/python_ide.xhp
+++ b/source/text/sbasic/python/python_ide.xhp
@@ -25,7 +25,7 @@
 python;editor
 
 Setting up an 
Integrated Development Environment (IDE) for Python
-Writing Python macros requires extra configuration steps in 
order set an IDE of choice.
+Writing Python macros requires extra configuration steps to 
set an IDE of choice.
 
 
 
diff --git a/source/text/sbasic/python/python_locations.xhp 
b/source/text/sbasic/python/python_locations.xhp
index b3ebeeda5..7d7681e78 100644
--- a/source/text/sbasic/python/python_locations.xhp
+++ b/source/text/sbasic/python/python_locations.xhp
@@ -48,7 +48,7 @@
 Document macros
 Document macros are 
embedded in the document and are accessible only when the document is 
open.
 Libraries, Modules and Macros
-Like BASIC macros, 
Python macros can organized in libraries, modules and macros.
+Like BASIC macros, 
Python macros can be organized in libraries, modules and macros.
 Creating a Python Library
 Libraries are 
folders in the container tree. To create a library, add a folder in the target 
container. The library name is the folder name.
 Creating a Python Module.
diff --git a/source/text/swriter/04/0102.xhp 
b/source/text/swriter/04/0102.xhp
index b8a98edec..2499e588c 100644
--- a/source/text/swriter/04/0102.xhp
+++ b/source/text/swriter/04/0102.xhp
@@ -107,12 +107,10 @@
  
  
  
- Shift+F5
+ Shift+F5
  
  
- Places the cursor at the position it had when the file was 
saved and reopened. This only works when the name of the author was entered in 

- Command - 
Preferences
- Tools 
-Options- %PRODUCTNAME - 
User Data.
+ Places the cursor at the position it had when the file was 
last saved. This only works if an author’s name is provided in %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME - 
User Data.
  
  
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2019-01-23 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 43978dba59cf6cfb747d4f6258bf951d4717c4c1
Author: Adolfo Jayme Barrientos 
AuthorDate: Wed Jan 23 15:25:58 2019 -0600
Commit: Gerrit Code Review 
CommitDate: Wed Jan 23 22:26:09 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Fix some typos

Change-Id: Ife8c609e1db336417077a31d8a549614e00bd91b

diff --git a/helpcontent2 b/helpcontent2
index b3686d53d108..85757c5b58b7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b3686d53d10873b1260091a4c6a898575516217e
+Subproject commit 85757c5b58b7fed1535d787053d4361d32e1374c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - solenv/bin

2019-01-23 Thread Libreoffice Gerrit user
 solenv/bin/make_installer.pl |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit e774041ec07d7f168c41a42b6ffa6aacc816d442
Author: Jim Jagielski 
AuthorDate: Wed Jan 23 19:51:08 2019 +
Commit: Jim Jagielski 
CommitDate: Wed Jan 23 19:51:08 2019 +

Fix confusing message... if EPM is patched, be sure to log that

diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index cce6c29f9a9e..b250735d0733 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -1117,8 +1117,14 @@ sub MakeNonWindowsBuild ($$$)
 if ( $installer::globals::call_epm )
 {
 # ... now epm can be started, to create the 
installation sets
-
-$installer::logger::Info->print( "... starting 
unpatched epm ... \n" );
+if ( $installer::globals::is_special_epm )
+{
+$installer::logger::Info->print( "... starting 
patched epm ... \n" );
+}
+else
+{
+$installer::logger::Info->print( "... starting 
unpatched epm ... \n" );
+}
 
 if ( $installer::globals::call_epm ) { 
installer::epmfile::call_epm($epmexecutable, $completeepmfilename, 
$packagename, $includepatharrayref); }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122909] V 6.0.7 or earlier: After opening a CSV file in Cal, all cells appear to be text, but cannot Format $xx.xx Cells to US Currency

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122909

Mike Kaganski  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Mike Kaganski  ---
This is normal, and indicates that you haven't set import options such that it
would detect special numbers (like currency). You either need to select proper
options at import (first of them is the said "Detect special numbers", and it
might be also necessary to tweak columns if their formatting does not conform
to your locale's conventions), or after such import, when all the data is text,
use Data->Text to Columns. *Formatting* already existing data will never change
its data type, and only can alter visual representation (if applicable).

See also this FAQ:
https://wiki.documentfoundation.org/Faq/Calc/How_to_convert_number_text_to_numeric_data
(there another way to convert is explained, using Find & Replace, but
personally I prefer Data->Text to Columns).

Closing NOTABUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82627

--- Comment #12 from Luke  ---
Justin,
Is this something you'd be interested in? We need to read the OOXML ‘Do not
rotate Text’ option. When it's set, use the current style. When it's not set,
we need to rotate the text exactly like we do now in native ODF Text Boxes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122887] Moving anchor for shape + text box leaves text box behind

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122887

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Telesto  ---
Repro
Version: 6.3.0.0.alpha0+
Build ID: 6740443311268b7d918bf4f43134d64fb78a0109
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-15_23:37:04
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

Did report something similar a long time ago.. @V Stuart Foote noted that there
are two types of text insertion. 

1. Take a Circle or Square (not working for Rectangle, but for most shapes)..
double click it -> Text cursor will appear..
2. Other way: Right-click shape, select Add Text Box.

There was some talk about unification..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122909] New: V 6.0.7 or earlier: After opening a CSV file in Cal, all cells appear to be text, but cannot Format $xx.xx Cells to US Currency

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122909

Bug ID: 122909
   Summary: V 6.0.7 or earlier: After opening a CSV file in Cal,
all cells appear to be text, but cannot Format $xx.xx
Cells to US Currency
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dmnor...@gmail.com

Description:
After opening a CSV file with CALC, tried to perform calculations example:
=sum(c2:c134) the result is 0. Cells in range appear to be text, but with no
apostrophe in front of the US currency value. After trying to Format Cells to
Currency, all the cells in the range now have an apostrophe inserted! After
manually removing the apostrophes, then the cells behave as numbers/currency.

Steps to Reproduce:
1.With Calc, open CSV file containing column of numbers (US currency)
2.Attempt to calculated sum of cells. [Cells are apparently test format.]
3.Format cells to US Currency
4.Look at cell content and note that each has an embedded "'" apostrophe,
indicating that they are  text!!!

Actual Results:
Cannot format apparently text cells to number, even though the cell content
appears to be a number, except the Format Cells Currency has added an
apostrophe ' designating the cell as text!!!

Expected Results:
Should be able to calculate.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 111931] Android: Writer - Unable to insert image into file

2019-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111931

--- Comment #13 from raal  ---
Pong!

Actually is not possible edit file in master, it's only viewer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/source

2019-01-23 Thread Libreoffice Gerrit user
 cui/source/tabpages/numpages.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 9223799e73177706bf3e2d3370b412b3d1fa531a
Author: Tamás Zolnai 
AuthorDate: Wed Jan 23 18:33:57 2019 +0100
Commit: Tamás Zolnai 
CommitDate: Wed Jan 23 21:10:47 2019 +0100

Bullets: Use relative size when it's supported

In Writer it might cause a problem to use relative
size with text based numberings.

Change-Id: Id19b5e45f0f932d1b69028f343daad7dec34ae23
Reviewed-on: https://gerrit.libreoffice.org/66811
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 

diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 5db0609b5b81..16b1186583a1 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -2438,10 +2438,13 @@ void SvxNumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const ::tool
 {
 vcl::Font aFont(aStdFont);
 Size aTmpSize(aStdFont.GetFontSize());
-aTmpSize.setWidth( aTmpSize.Width() * ( 
rFmt.GetBulletRelSize()) );
-aTmpSize.setWidth( aTmpSize.Width() / 100 ) ;
-aTmpSize.setHeight( aTmpSize.Height() * ( 
rFmt.GetBulletRelSize()) );
-aTmpSize.setHeight( aTmpSize.Height() / 100 ) ;
+
if(pActNum->IsFeatureSupported(SvxNumRuleFlags::BULLET_REL_SIZE))
+{
+aTmpSize.setWidth( aTmpSize.Width() * ( 
rFmt.GetBulletRelSize()) );
+aTmpSize.setWidth( aTmpSize.Width() / 100 ) ;
+aTmpSize.setHeight( aTmpSize.Height() * ( 
rFmt.GetBulletRelSize()) );
+aTmpSize.setHeight( aTmpSize.Height() / 100 ) ;
+}
 if(!aTmpSize.Height())
 aTmpSize.setHeight( 1 );
 aFont.SetFontSize(aTmpSize);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   4   5   >