[Libreoffice-bugs] [Bug 124009] Give us the option to hide "Title bar" of LibreOffice like in Firefox and Chrome. (This is not about "Fullscreen")
https://bugs.documentfoundation.org/show_bug.cgi?id=124009 prabesh...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124009] New: Give us the option to hide "Title bar" of LibreOffice like in Firefox and Chrome. (This is not about "Fullscreen")
https://bugs.documentfoundation.org/show_bug.cgi?id=124009 Bug ID: 124009 Summary: Give us the option to hide "Title bar" of LibreOffice like in Firefox and Chrome. (This is not about "Fullscreen") Product: LibreOffice Version: 6.2.1.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: prabesh...@gmail.com Created attachment 149896 --> https://bugs.documentfoundation.org/attachment.cgi?id=149896=edit Right now we need to depend upon third-party tweaks just to 'hide title bar'. As in the screenshot given: Maximizing the viewing space is a big thing for all users in any application. These days, almost all application give us the option to hide "Title bar" then Why not in LibreOffice too. Right now we need to depend upon third-party tweaks just to 'hide title bar'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35652] ACC: AT-SPI accessible tree omits objects which are not visible on the screen.
https://bugs.documentfoundation.org/show_bug.cgi?id=35652 --- Comment #18 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90852] TOOLBAR: 'Area Style / Filing' drop down control doesnt update 'Fill Color' drop down
https://bugs.documentfoundation.org/show_bug.cgi?id=90852 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94761] Bitmap patterns are blurry
https://bugs.documentfoundation.org/show_bug.cgi?id=94761 --- Comment #9 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116349] Writer table underlining indents text 1 mm at both sides
https://bugs.documentfoundation.org/show_bug.cgi?id=116349 --- Comment #5 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101125] libreoffice writer hangs for me when i attempt to open this .docx file.
https://bugs.documentfoundation.org/show_bug.cgi?id=101125 --- Comment #19 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116343] picture zoom using mouse does not work sometimes
https://bugs.documentfoundation.org/show_bug.cgi?id=116343 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79583] Other: Nonstandard Paper Size doesn't print
https://bugs.documentfoundation.org/show_bug.cgi?id=79583 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/source
sw/source/filter/xml/xmlimp.cxx |7 ---
1 file changed, 7 deletions(-)
New commits:
commit f053400c3f8c89ae122387dc64c63d2cfba86bbb
Author: Michael Stahl
AuthorDate: Wed Mar 6 12:03:32 2019 +0100
Commit: Thorsten Behrens
CommitDate: Tue Mar 12 04:15:07 2019 +0100
tdf#116195 sw: remove DisableOffPagePositioning handling from ODF import
SwXMLImport::SetConfigurationSettings() needs to handle only those
settings for which the default is different vs. old OOo/LO versions;
DisableOffPagePositioning however defaults to false, so we can just rely
on that default. The inverted bDisableOffPagePositioning check is
wrong.
(regression from fe3d5766fa3c42f6cf8d1ea47af820e0b1c1cf48)
Change-Id: I300fa597f58b586b49089bb555a00a6923862abe
Reviewed-on: https://gerrit.libreoffice.org/68801
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 8f3df3a5a1570eea4d931f737c474df8601377ec)
Reviewed-on: https://gerrit.libreoffice.org/69037
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx
index d838a8adb8a6..1f4d243f6c93 100644
--- a/sw/source/filter/xml/xmlimp.cxx
+++ b/sw/source/filter/xml/xmlimp.cxx
@@ -1358,7 +1358,6 @@ void SwXMLImport::SetConfigurationSettings(const Sequence
< PropertyValue > & aC
aExcludeWhenNotLoadingUserSettings.insert("TabOverMargin");
aExcludeWhenNotLoadingUserSettings.insert("PropLineSpacingShrinksFirstLine");
aExcludeWhenNotLoadingUserSettings.insert("SubtractFlysAnchoredAtFlys");
-aExcludeWhenNotLoadingUserSettings.insert("DisableOffPagePositioning");
sal_Int32 nCount = aConfigProps.getLength();
const PropertyValue* pValues = aConfigProps.getConstArray();
@@ -1392,7 +1391,6 @@ void SwXMLImport::SetConfigurationSettings(const Sequence
< PropertyValue > & aC
bool bTabOverMargin = false;
bool bPropLineSpacingShrinksFirstLine = false;
bool bSubtractFlysAnchoredAtFlys = false;
-bool bDisableOffPagePositioning = false;
bool bCollapseEmptyCellPara = false;
const PropertyValue* currentDatabaseDataSource = nullptr;
@@ -1486,8 +1484,6 @@ void SwXMLImport::SetConfigurationSettings(const Sequence
< PropertyValue > & aC
bPropLineSpacingShrinksFirstLine = true;
else if (pValues->Name == "SubtractFlysAnchoredAtFlys")
bSubtractFlysAnchoredAtFlys = true;
-else if (pValues->Name == "DisableOffPagePositioning")
-bDisableOffPagePositioning = true;
else if (pValues->Name == "CollapseEmptyCellPara")
bCollapseEmptyCellPara = true;
}
@@ -1650,9 +1646,6 @@ void SwXMLImport::SetConfigurationSettings(const Sequence
< PropertyValue > & aC
if (!bSubtractFlysAnchoredAtFlys)
xProps->setPropertyValue("SubtractFlysAnchoredAtFlys", makeAny(true));
-if ( bDisableOffPagePositioning )
-xProps->setPropertyValue("DisableOffPagePositioning", makeAny(true));
-
if (!bCollapseEmptyCellPara)
xProps->setPropertyValue("CollapseEmptyCellPara", makeAny(false));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - oox/source sd/qa
oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 22 +++-
sd/qa/unit/data/pptx/smartart-autoTxRot.pptx|binary
sd/qa/unit/import-tests-smartart.cxx| 91
3 files changed, 109 insertions(+), 4 deletions(-)
New commits:
commit aa773560eef3caebe010160f253084abbdce81c1
Author: Mike Kaganski
AuthorDate: Sat Dec 1 17:51:11 2018 +0300
Commit: Thorsten Behrens
CommitDate: Tue Mar 12 04:14:33 2019 +0100
tdf#121844: properly implement autoTxRot support
... after commit cf7b97d1328ec2f2c8254abb9ce67d63d9c54c80
Change-Id: If46265f49a85d92254fedb719d76ff7319c092cc
Reviewed-on: https://gerrit.libreoffice.org/64396
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/69050
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 876eb3d06c8d..0b0c77f40fd5 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -1007,20 +1007,34 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
break;
}
+// ECMA-376-1:2016 21.4.7.5 ST_AutoTextRotation (Auto Text
Rotation)
const sal_Int32 nautoTxRot = maMap.count(XML_autoTxRot) ?
maMap.find(XML_autoTxRot)->second : XML_upr;
+sal_Int32 nShapeRot = rShape->getRotation();
+while (nShapeRot < 0)
+nShapeRot += 360 * PER_DEGREE;
+while (nShapeRot > 360 * PER_DEGREE)
+nShapeRot -= 360 * PER_DEGREE;
switch(nautoTxRot)
{
case XML_upr:
{
-if (rShape->getRotation())
-pTextBody->getTextProperties().moRotation =
-F_PI180*90*rShape->getRotation();
+int n90x = 0;
+if (nShapeRot >= 315 * PER_DEGREE)
+/* keep 0 */;
+else if (nShapeRot > 225 * PER_DEGREE)
+n90x = -3;
+else if (nShapeRot >= 135 * PER_DEGREE)
+n90x = -2;
+else if (nShapeRot > 45 * PER_DEGREE)
+n90x = -1;
+pTextBody->getTextProperties().moRotation = n90x * 90 *
PER_DEGREE;
}
break;
case XML_grav:
{
-if (rShape->getRotation()==90*F_PI180 ||
rShape->getRotation()==180*F_PI180)
-pTextBody->getTextProperties().moRotation =
180*F_PI180;
+if (nShapeRot > (90 * PER_DEGREE) && nShapeRot < (270 *
PER_DEGREE))
+pTextBody->getTextProperties().moRotation = -180 *
PER_DEGREE;
}
break;
case XML_none:
diff --git a/sd/qa/unit/data/pptx/smartart-autoTxRot.pptx
b/sd/qa/unit/data/pptx/smartart-autoTxRot.pptx
new file mode 100644
index ..30e69a6de6c1
Binary files /dev/null and b/sd/qa/unit/data/pptx/smartart-autoTxRot.pptx differ
diff --git a/sd/qa/unit/import-tests-smartart.cxx
b/sd/qa/unit/import-tests-smartart.cxx
index 9de4061a072b..5317ac19c919 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -45,6 +45,7 @@ public:
void testDir();
void testMaxDepth();
void testRotation();
+void testTextAutoRotation();
void testVertialBoxList();
void testVertialBracketList();
void testTableList();
@@ -61,6 +62,7 @@ public:
CPPUNIT_TEST(testDir);
CPPUNIT_TEST(testMaxDepth);
CPPUNIT_TEST(testRotation);
+CPPUNIT_TEST(testTextAutoRotation);
CPPUNIT_TEST(testVertialBoxList);
CPPUNIT_TEST(testVertialBracketList);
CPPUNIT_TEST(testTableList);
@@ -216,6 +218,95 @@ void SdImportTestSmartArt::testRotation()
xDocShRef->DoClose();
}
+void SdImportTestSmartArt::testTextAutoRotation()
+{
+sd::DrawDocShellRef xDocShRef = loadURL(
+
m_directories.getURLFromSrc("sd/qa/unit/data/pptx/smartart-autoTxRot.pptx"),
PPTX);
+
+auto testText = [&](int pageNo, sal_Int32 txtNo, const OUString& expTx,
sal_Int32 expShRot,
+sal_Int32 expTxRot) {
+OString msgText = "Page: " + OString::number(pageNo) + " text: " +
OString::number(txtNo);
+uno::Reference xShapeGroup(getShapeFromPage(0,
pageNo, xDocShRef),
+ uno::UNO_QUERY_THROW);
+
+uno::Reference xTxt(xShapeGroup->getByIndex(txtNo),
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msgText.getStr(), expTx,
xTxt->getString());
+uno::Reference xTxtProps(xTxt,
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(msgText.getStr(), expShRot,
+
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - oox/source
oox/source/drawingml/diagram/diagramlayoutatoms.cxx | 31
1 file changed, 31 insertions(+)
New commits:
commit 994cb67e02342a1548a4a77dd3a6a73a368a25ca
Author: ekuiitr
AuthorDate: Tue Jul 10 23:28:56 2018 +0530
Commit: Thorsten Behrens
CommitDate: Tue Mar 12 04:13:34 2019 +0100
SmartArt Pyramid: Now lays out shapes
This algorithm was initially not implemented, because of that it was
not able to show shapes which relates to pyramid, but with this patch,
It rendered correctly except some minor adjustement values issues which
can be fixed in upcoming patches.
Change-Id: I298c812615956d67eb00e1b7544d7b171a4ac14a
Reviewed-on: https://gerrit.libreoffice.org/57241
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
Reviewed-on: https://gerrit.libreoffice.org/69051
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 13b327943159..876eb3d06c8d 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -821,7 +821,38 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
}
case XML_pyra:
+{
+if (rShape->getChildren().empty() || rShape->getSize().Width == 0
|| rShape->getSize().Height == 0)
+break;
+
+// const sal_Int32 nDir = maMap.count(XML_linDir) ?
maMap.find(XML_linDir)->second : XML_fromT;
+// const sal_Int32 npyraAcctPos = maMap.count(XML_pyraAcctPos) ?
maMap.find(XML_pyraAcctPos)->second : XML_bef;
+// const sal_Int32 ntxDir = maMap.count(XML_txDir) ?
maMap.find(XML_txDir)->second : XML_fromT;
+// const sal_Int32 npyraLvlNode = maMap.count(XML_pyraLvlNode) ?
maMap.find(XML_pyraLvlNode)->second : XML_level;
+// uncomment when use in code.
+
+sal_Int32 nCount = rShape->getChildren().size();
+double fAspectRatio = 0.32;
+
+awt::Size aChildSize = rShape->getSize();
+aChildSize.Width /= nCount;
+aChildSize.Height /= nCount;
+
+awt::Point aCurrPos(0, 0);
+aCurrPos.X = fAspectRatio*aChildSize.Width*(nCount-1);
+aCurrPos.Y = fAspectRatio*aChildSize.Height;
+
+for (auto & aCurrShape : rShape->getChildren())
+{
+aCurrShape->setPosition(aCurrPos);
+aCurrPos.X -= aChildSize.Height/(nCount-1);
+aChildSize.Width += aChildSize.Height;
+aCurrShape->setSize(aChildSize);
+aCurrShape->setChildSize(aChildSize);
+aCurrPos.Y += (aChildSize.Height);
+}
break;
+}
case XML_snake:
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 123304, which changed state. Bug 123304 Summary: Cannot disable default OpenType “liga” feature anymore in 6.2 https://bugs.documentfoundation.org/show_bug.cgi?id=123304 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/source include/vcl vcl/qa vcl/source
cui/source/dialogs/FontFeaturesDialog.cxx |4
include/vcl/font/Feature.hxx | 44 ---
include/vcl/font/FeatureParser.hxx| 11 -
vcl/qa/cppunit/FontFeatureTest.cxx| 182 ++
vcl/source/font/Feature.cxx | 35 -
vcl/source/font/FeatureParser.cxx | 38 ++
vcl/source/gdi/CommonSalLayout.cxx|4
7 files changed, 242 insertions(+), 76 deletions(-)
New commits:
commit 3450311c403af714d3fc0ba14b9f7673c717a6a2
Author: Khaled Hosny
AuthorDate: Mon Mar 11 20:55:24 2019 +0200
Commit: Khaled Hosny
CommitDate: Tue Mar 12 03:38:19 2019 +0100
tdf#123304: Allow the full feature syntax as pre 6.2
Fix regression from:
commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe
Author: Tomaž Vajngerl
Date: Fri Jun 15 19:32:15 2018 +0200
vcl: parser of font features included in the font name
Where hb_feature_from_string() was replaced by a simple parser that supports
avery limited subset of the syntax it supports (as documented in
https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string)
Reviewed-on: https://gerrit.libreoffice.org/69062
Reviewed-by: Khaled Hosny
Tested-by: Khaled Hosny
(cherry picked from commit 45deb5b714d2d011eb2a5ad91721a9c2c508a426)
Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f
Reviewed-on: https://gerrit.libreoffice.org/69068
Reviewed-by: Khaled Hosny
Tested-by: Khaled Hosny
diff --git a/cui/source/dialogs/FontFeaturesDialog.cxx
b/cui/source/dialogs/FontFeaturesDialog.cxx
index 8da13eda49e6..f9276441c1a8 100644
--- a/cui/source/dialogs/FontFeaturesDialog.cxx
+++ b/cui/source/dialogs/FontFeaturesDialog.cxx
@@ -74,7 +74,7 @@ void FontFeaturesDialog::initialize()
void FontFeaturesDialog::fillGrid(std::vector const&
rFontFeatures)
{
vcl::font::FeatureParser aParser(m_sFontName);
-std::unordered_map aExistingFeatures =
aParser.getFeaturesMap();
+auto aExistingFeatures = aParser.getFeaturesMap();
sal_Int32 i = 0;
for (vcl::font::Feature const& rFontFeature : rFontFeatures)
@@ -89,7 +89,7 @@ void
FontFeaturesDialog::fillGrid(std::vector const& rFontFe
m_aFeatureItems.emplace_back(m_xContentGrid.get());
-sal_uInt32 nValue = 0;
+uint32_t nValue = 0;
if (aExistingFeatures.find(nFontFeatureCode) !=
aExistingFeatures.end())
nValue = aExistingFeatures.at(nFontFeatureCode);
diff --git a/include/vcl/font/Feature.hxx b/include/vcl/font/Feature.hxx
index 299d0a55a9f2..76ba597b1ba2 100644
--- a/include/vcl/font/Feature.hxx
+++ b/include/vcl/font/Feature.hxx
@@ -21,13 +21,13 @@ namespace vcl
{
namespace font
{
-constexpr sal_uInt32 featureCode(const char sFeature[4])
+constexpr uint32_t featureCode(const char sFeature[4])
{
-return static_cast(sFeature[0]) << 24U |
static_cast(sFeature[1]) << 16U
- | static_cast(sFeature[2]) << 8U |
static_cast(sFeature[3]);
+return static_cast(sFeature[0]) << 24U |
static_cast(sFeature[1]) << 16U
+ | static_cast(sFeature[2]) << 8U |
static_cast(sFeature[3]);
}
-VCL_DLLPUBLIC OUString featureCodeAsString(sal_uInt32 nFeature);
+VCL_DLLPUBLIC OUString featureCodeAsString(uint32_t nFeature);
enum class FeatureParameterType
{
@@ -44,22 +44,22 @@ enum class FeatureType
struct VCL_DLLPUBLIC FeatureParameter
{
private:
-sal_uInt32 m_nCode;
+uint32_t m_nCode;
OUString m_sDescription;
const char* m_pDescriptionID;
public:
-FeatureParameter(sal_uInt32 nCode, OUString aDescription);
-FeatureParameter(sal_uInt32 nCode, const char* pDescriptionID);
+FeatureParameter(uint32_t nCode, OUString aDescription);
+FeatureParameter(uint32_t nCode, const char* pDescriptionID);
-sal_uInt32 getCode() const;
+uint32_t getCode() const;
OUString getDescription() const;
};
class VCL_DLLPUBLIC FeatureDefinition
{
private:
-sal_uInt32 m_nCode;
+uint32_t m_nCode;
OUString m_sDescription;
const char* m_pDescriptionID;
OUString m_sNumericPart;
@@ -69,18 +69,18 @@ private:
public:
FeatureDefinition();
-FeatureDefinition(sal_uInt32 nCode, OUString const& rDescription,
+FeatureDefinition(uint32_t nCode, OUString const& rDescription,
FeatureParameterType eType = FeatureParameterType::BOOL,
std::vector const& rEnumParameters
= std::vector{});
-FeatureDefinition(sal_uInt32 nCode, const char* pDescriptionID,
+FeatureDefinition(uint32_t nCode, const char* pDescriptionID,
OUString const& rNumericPart = OUString());
-FeatureDefinition(sal_uInt32 nCode, const char* pDescriptionID,
+FeatureDefinition(uint32_t nCode, const char* pDescriptionID,
std::vector aEnumParameters);
const std::vector& getEnumParameters() const;
OUString
[Libreoffice-bugs] [Bug 123494] Calc: There are two items "Paste special" in Function list on Toolbars tab in Customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123494 mulla.tasa...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123428] FILESAVE XLSX, Saving as xlsx in Calc creates new styles from the defaul ones.
https://bugs.documentfoundation.org/show_bug.cgi?id=123428 --- Comment #4 from mulla.tasa...@gmail.com --- Need Additional Steps to Reproduce Bug: 1. Open Calc. 2. Set some of the cell’s styles to for example Good. 3. Save as xlsx(Styles are not changed). 4. Reload. 5.To check Cell Style Click on Style-->Click Manage Style-->Style window will appear Select cell to verify Style. 6. The cells that had Good style now have Good 1 ( if you now change some of the cells to Good and repeat the steps they will have Good 2 and so forth) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123428] FILESAVE XLSX, Saving as xlsx in Calc creates new styles from the defaul ones.
https://bugs.documentfoundation.org/show_bug.cgi?id=123428 mulla.tasa...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from mulla.tasa...@gmail.com --- We need to add additional steps to reproduce the bug: Steps to Reproduce: 1. Open Calc. 2. Set some of the cell’s styles to for example Good. 3. Save as xlsx(Styles are not changed). 4. Reload. 5.To check Styles of cell go to Styles-->Click-Manage Styles () 5. The cells that had Good style now have Good 1 ( if you now change some of the cells to Good and repeat the steps they will have Good 2 and so forth) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/o3tl vcl/inc vcl/source
include/o3tl/lru_map.hxx|6 ++
vcl/inc/svdata.hxx |1 +
vcl/source/gdi/FileDefinitionWidgetDraw.cxx |2 +-
vcl/source/gdi/WidgetDefinition.cxx |2 +-
4 files changed, 9 insertions(+), 2 deletions(-)
New commits:
commit ab71569a7c1e1a262bfbfac998cf4acb092ed383
Author: Tomaž Vajngerl
AuthorDate: Tue Mar 12 01:11:20 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Mar 12 01:11:20 2019 +0100
fix build failures because of diff against master
Change-Id: Iefe4683f456750b53c96e1634d7930f4b042e573
diff --git a/include/o3tl/lru_map.hxx b/include/o3tl/lru_map.hxx
index 2f41521795fc..53b5d5c8d004 100644
--- a/include/o3tl/lru_map.hxx
+++ b/include/o3tl/lru_map.hxx
@@ -132,6 +132,12 @@ public:
{
return mLruList.size();
}
+
+void clear()
+{
+mLruMap.clear();
+mLruList.clear();
+}
};
}
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 10051ec30660..9a17b6f176ef 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -41,6 +41,7 @@
#include "ControlCacheKey.hxx"
#include "schedulerimpl.hxx"
#include
+#include
struct ImplPostEventData;
struct ImplTimerData;
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index 06b85f9a2928..d4ee5a1d6dd7 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -211,7 +211,7 @@ void drawFromDrawCommands(gfx::DrawRoot const& rDrawRoot,
SalGraphics& rGraphics
{
for (size_t i = 0; i < rPolygon.count(); ++i)
{
-auto& rPoint = rPolygon.getB2DPoint(i);
+auto const& rPoint = rPolygon.getB2DPoint(i);
double x = rPoint.getX();
double y = rPoint.getY();
diff --git a/vcl/source/gdi/WidgetDefinition.cxx
b/vcl/source/gdi/WidgetDefinition.cxx
index 668fe74bf403..069e0b99e0f0 100644
--- a/vcl/source/gdi/WidgetDefinition.cxx
+++ b/vcl/source/gdi/WidgetDefinition.cxx
@@ -184,7 +184,7 @@ void WidgetDefinitionState::addDrawImage(OUString const&
sSource)
void WidgetDefinitionState::addDrawExternal(OUString const& sSource)
{
-auto pCommand(std::make_unique());
+auto pCommand(std::make_shared());
pCommand->msSource = sSource;
mpDrawCommands.push_back(std::move(pCommand));
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/sharedformula.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 5c27a048658afcd2f78ef4d7e6c7128554ed3f4c Author: Eike Rathke AuthorDate: Mon Mar 11 21:39:00 2019 +0100 Commit: Eike Rathke CommitDate: Tue Mar 12 01:07:14 2019 +0100 Resolves: tdf#120013 tdf#123714 split-off group or single cell needs listening Change-Id: Ic511f618e9dde2288491c01cfcd889970fd6e4e5 Reviewed-on: https://gerrit.libreoffice.org/69066 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/core/tool/sharedformula.cxx b/sc/source/core/tool/sharedformula.cxx index 5a488aa36258..4fa12a6dfaed 100644 --- a/sc/source/core/tool/sharedformula.cxx +++ b/sc/source/core/tool/sharedformula.cxx @@ -71,6 +71,9 @@ bool SharedFormulaUtil::splitFormulaCellGroup(const CellStoreType::position_type else rPrevTop.EndListeningTo( rPrevTop.GetDocument(), nullptr, ScAddress( ScAddress::UNINITIALIZED)); rPrevTop.SetNeedsListening(true); + +// The new group or remaining single cell needs a new listening. +rTop.SetNeedsListening(true); } #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source include/vcl vcl/qa vcl/source
cui/source/dialogs/FontFeaturesDialog.cxx |4
include/vcl/font/Feature.hxx | 44 ---
include/vcl/font/FeatureParser.hxx| 11 -
vcl/qa/cppunit/FontFeatureTest.cxx| 182 ++
vcl/source/font/Feature.cxx | 35 -
vcl/source/font/FeatureParser.cxx | 35 ++---
vcl/source/gdi/CommonSalLayout.cxx|4
7 files changed, 240 insertions(+), 75 deletions(-)
New commits:
commit 45deb5b714d2d011eb2a5ad91721a9c2c508a426
Author: Khaled Hosny
AuthorDate: Mon Mar 11 20:55:24 2019 +0200
Commit: Khaled Hosny
CommitDate: Tue Mar 12 00:54:29 2019 +0100
tdf#123304: Allow the full feature syntax as pre 6.2
Fix regression from:
commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe
Author: Tomaž Vajngerl
Date: Fri Jun 15 19:32:15 2018 +0200
vcl: parser of font features included in the font name
Where hb_feature_from_string() was replaced by a simple parser that supports
avery limited subset of the syntax it supports (as documented in
https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string)
Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f
Reviewed-on: https://gerrit.libreoffice.org/69062
Reviewed-by: Khaled Hosny
Tested-by: Khaled Hosny
diff --git a/cui/source/dialogs/FontFeaturesDialog.cxx
b/cui/source/dialogs/FontFeaturesDialog.cxx
index 85a07e63971b..b4dd8e7fc63e 100644
--- a/cui/source/dialogs/FontFeaturesDialog.cxx
+++ b/cui/source/dialogs/FontFeaturesDialog.cxx
@@ -76,7 +76,7 @@ void FontFeaturesDialog::initialize()
void FontFeaturesDialog::fillGrid(std::vector const&
rFontFeatures)
{
vcl::font::FeatureParser aParser(m_sFontName);
-std::unordered_map aExistingFeatures =
aParser.getFeaturesMap();
+auto aExistingFeatures = aParser.getFeaturesMap();
sal_Int32 i = 0;
for (vcl::font::Feature const& rFontFeature : rFontFeatures)
@@ -91,7 +91,7 @@ void
FontFeaturesDialog::fillGrid(std::vector const& rFontFe
m_aFeatureItems.emplace_back(m_xContentGrid.get());
-sal_uInt32 nValue = 0;
+uint32_t nValue = 0;
if (aExistingFeatures.find(nFontFeatureCode) !=
aExistingFeatures.end())
nValue = aExistingFeatures.at(nFontFeatureCode);
diff --git a/include/vcl/font/Feature.hxx b/include/vcl/font/Feature.hxx
index 85e0d1bcfd0d..390abe33f8b7 100644
--- a/include/vcl/font/Feature.hxx
+++ b/include/vcl/font/Feature.hxx
@@ -18,13 +18,13 @@ namespace vcl
{
namespace font
{
-constexpr sal_uInt32 featureCode(const char sFeature[4])
+constexpr uint32_t featureCode(const char sFeature[4])
{
-return static_cast(sFeature[0]) << 24U |
static_cast(sFeature[1]) << 16U
- | static_cast(sFeature[2]) << 8U |
static_cast(sFeature[3]);
+return static_cast(sFeature[0]) << 24U |
static_cast(sFeature[1]) << 16U
+ | static_cast(sFeature[2]) << 8U |
static_cast(sFeature[3]);
}
-VCL_DLLPUBLIC OUString featureCodeAsString(sal_uInt32 nFeature);
+VCL_DLLPUBLIC OUString featureCodeAsString(uint32_t nFeature);
enum class FeatureParameterType
{
@@ -41,22 +41,22 @@ enum class FeatureType
struct VCL_DLLPUBLIC FeatureParameter
{
private:
-sal_uInt32 m_nCode;
+uint32_t m_nCode;
OUString m_sDescription;
const char* m_pDescriptionID;
public:
-FeatureParameter(sal_uInt32 nCode, OUString aDescription);
-FeatureParameter(sal_uInt32 nCode, const char* pDescriptionID);
+FeatureParameter(uint32_t nCode, OUString aDescription);
+FeatureParameter(uint32_t nCode, const char* pDescriptionID);
-sal_uInt32 getCode() const;
+uint32_t getCode() const;
OUString getDescription() const;
};
class VCL_DLLPUBLIC FeatureDefinition
{
private:
-sal_uInt32 m_nCode;
+uint32_t m_nCode;
OUString m_sDescription;
const char* m_pDescriptionID;
OUString m_sNumericPart;
@@ -66,18 +66,18 @@ private:
public:
FeatureDefinition();
-FeatureDefinition(sal_uInt32 nCode, OUString const& rDescription,
+FeatureDefinition(uint32_t nCode, OUString const& rDescription,
FeatureParameterType eType = FeatureParameterType::BOOL,
std::vector const& rEnumParameters
= std::vector{});
-FeatureDefinition(sal_uInt32 nCode, const char* pDescriptionID,
+FeatureDefinition(uint32_t nCode, const char* pDescriptionID,
OUString const& rNumericPart = OUString());
-FeatureDefinition(sal_uInt32 nCode, const char* pDescriptionID,
+FeatureDefinition(uint32_t nCode, const char* pDescriptionID,
std::vector aEnumParameters);
const std::vector& getEnumParameters() const;
OUString getDescription() const;
-sal_uInt32 getCode() const;
+uint32_t getCode() const;
FeatureParameterType getType() const;
operator bool() const;
@@ -85,9 +85,9 @@ public:
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 3 commits - vcl/inc vcl/source vcl/uiconfig
vcl/inc/svdata.hxx|4 vcl/source/app/svmain.cxx |3 vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 146 +++--- vcl/uiconfig/theme_definitions/definition.xml |2 4 files changed, 96 insertions(+), 59 deletions(-) New commits: commit fe4da4c2ec02159afe6206db78920e8fde7691d0 Author: Tomaž Vajngerl AuthorDate: Mon Mar 11 17:08:18 2019 +0100 Commit: Tomaž Vajngerl CommitDate: Tue Mar 12 00:38:24 2019 +0100 widget theme: change the tab item height to (min) 32 px Change-Id: I1919300071a06242fe832880b46c944989daa4b6 Reviewed-on: https://gerrit.libreoffice.org/69057 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit 212a40aaf7ec3316d5209b688f5f79821f99fbdc) diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx index a15010014aa4..06b85f9a2928 100644 --- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx +++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx @@ -775,10 +775,12 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion( if (!pPart) return false; -rNativeBoundingRegion = tools::Rectangle( -rBoundingControlRegion.TopLeft(), -Size(rBoundingControlRegion.GetWidth() + pPart->mnMarginWidth, - rBoundingControlRegion.GetHeight() + pPart->mnMarginHeight)); +long nWidth = std::max(rBoundingControlRegion.GetWidth() + pPart->mnMarginWidth, + long(pPart->mnWidth)); +long nHeight = std::max(rBoundingControlRegion.GetHeight() + pPart->mnMarginHeight, +long(pPart->mnHeight)); + +rNativeBoundingRegion = tools::Rectangle(aLocation, Size(nWidth, nHeight)); rNativeContentRegion = rNativeBoundingRegion; return true; } diff --git a/vcl/uiconfig/theme_definitions/definition.xml b/vcl/uiconfig/theme_definitions/definition.xml index e91953109554..5a4be114ea97 100644 --- a/vcl/uiconfig/theme_definitions/definition.xml +++ b/vcl/uiconfig/theme_definitions/definition.xml @@ -320,7 +320,7 @@ - + commit 7a6e7ed16ed57e131079ee79d06b03141117d9d7 Author: Tomaž Vajngerl AuthorDate: Mon Mar 11 16:52:37 2019 +0100 Commit: Tomaž Vajngerl CommitDate: Tue Mar 12 00:38:11 2019 +0100 better adjustment algorithm for dynamic sized widgets A algorithm that gives better results for dynamically sized widgets is to increase proportionally only the points in shapes that are over the half of the widget width (or height, when adjusting the other dimension). This preserves the margins and doesn't distort the shape of the paths, which is especially visible when the source needs to be largely resized in one dimension only. Change-Id: I2cceb249063387c0f7400ef8d75adb5899aa8c23 Reviewed-on: https://gerrit.libreoffice.org/69056 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit 897f6f6252f38e93764aa0e72135768ab1ec3679) diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx index ae303d966897..a15010014aa4 100644 --- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx +++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx @@ -168,24 +168,18 @@ void drawFromDrawCommands(gfx::DrawRoot const& rDrawRoot, SalGraphics& rGraphics basegfx::B2DRange aInputRectangle(rRectangle.maRectangle); +double fDeltaX = aTargetSurface.getWidth() - aSVGRect.getWidth(); +double fDeltaY = aTargetSurface.getHeight() - aSVGRect.getHeight(); + basegfx::B2DRange aFinalRectangle( -aTargetSurface.getMinX() + aInputRectangle.getMinX(), -aTargetSurface.getMinY() + aInputRectangle.getMinY(), -aTargetSurface.getMaxX() - (aSVGRect.getMaxX() - aInputRectangle.getMaxX()), -aTargetSurface.getMaxY() - (aSVGRect.getMaxY() - aInputRectangle.getMaxY())); - - aInputRectangle.transform(basegfx::utils::createTranslateB2DHomMatrix( --aInputRectangle.getMinX(), -aInputRectangle.getMinY())); - aInputRectangle.transform(basegfx::utils::createScaleB2DHomMatrix( -aFinalRectangle.getWidth() / aInputRectangle.getWidth(), -aFinalRectangle.getHeight() / aInputRectangle.getHeight())); - aInputRectangle.transform(basegfx::utils::createTranslateB2DHomMatrix( -aFinalRectangle.getMinX() - 0.5, -aFinalRectangle.getMinY() -- 0.5)); // compensate 0.5 for different interpretation of where the center of a pixel is +aInputRectangle.getMinX(),
[Libreoffice-bugs] [Bug 118711] DOC(X): Copy-pasting bulleted list entries insert page break
https://bugs.documentfoundation.org/show_bug.cgi?id=118711 Aron Budea changed: What|Removed |Added Severity|minor |normal --- Comment #6 from Aron Budea --- Simpler repro case: - open an empty DOCX, - add a line break, - copy both empty lines to the clipboard, - paste them into the second line. => A page break is inserted between the two. There are lots of possible repro cases, this is just the simplest of them. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105503] Tabstoptype in ruler not changeable
https://bugs.documentfoundation.org/show_bug.cgi?id=105503 Jon Yoder changed: What|Removed |Added Version|3.6.7.2 release |Inherited From OOo --- Comment #4 from Jon Yoder --- Tested with Mac version 6.2.0.3. Bug still present. Tested with Mac version 3.3.0 and confirmed bug was inherited from OpenOffice.org. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103703] When printing multiple duplex copies of a document with odd pages, the first page is printed on the back of the last page of the first copy
https://bugs.documentfoundation.org/show_bug.cgi?id=103703 --- Comment #14 from Cor Nouws --- (In reply to Gabor Kelemen from comment #13) > This one here is about the regression caused by bug #42099 > So I'd suggest to revert that one and enable the Print automatically > inserted blanks by default setting by default. Basically you would want to have duplex printing and mail merge with "print automatically inserted blank pages" turned on, and other printing not. If that is reached by reverting #42099, it is fine to do so. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 --- Comment #7 from jasonkres --- FYI, here's the actual case that led to this: 1. User is working on a sheet that is protected. 2. User sees a value in a protected cell that they would like to "reuse" in an unprotected cell -- including formatting, perhaps with some minor additional edits to the data. 3. So they Copy the protected cell and Paste it to an unprotected cell. At this point, the paste succeeds and it looks good onscreen. 4. But the user then finds unexpectedly that they cannot further edit (or even Delete) the destination because it has switched to be a protected cell. (Their option at this point is to Undo.) The reason it is unexpected from the user's point of view is that they think the cell is one that are supposed to be allowed to edit, and they are surprised that they were able to alter protection of the cell from unprotected to protected even though the sheet is currently "locked". -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 99685] Slides are flashing buffer of prior slide at the end of "Fade" transition, or end of "Fine Dissolve" transition
https://bugs.documentfoundation.org/show_bug.cgi?id=99685 --- Comment #30 from Buovjaga --- (In reply to Mark from comment #29) > Still not working for me, in fact the issue is worse it now flashes black > lines across the screen for longer and hurts my eyes. Please copy and paste here the contents of your Help - About. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 --- Comment #7 from jasonkres --- FYI, here's the actual case that led to this: 1. User is working on a sheet that is protected. 2. User sees a value in a protected cell that they would like to "reuse" in an unprotected cell -- including formatting, perhaps with some minor additional edits to the data. 3. So they Copy the protected cell and Paste it to an unprotected cell. At this point, the paste succeeds and it looks good onscreen. 4. But the user then finds unexpectedly that they cannot further edit (or even Delete) the destination because it has switched to be a protected cell. (Their option at this point is to Undo.) The reason it is unexpected from the user's point of view is that they think the cell is one that are supposed to be allowed to edit, and they are surprised that they were able to alter protection of the cell from unprotected to protected even though the sheet is currently "locked". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123961] FILEOPEN: Loading multi-page TIFF files would hang Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=123961 --- Comment #9 from Franklin Weng --- (In reply to Dieter Praas from comment #8) > Franklin, are you sure, that the attachment in comment 2 contains a > multi-page TIFF (I can't check that)? Yes. You can open it with okular under KDE or Gimp to check for that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/uiconfig
vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 74 +++--- vcl/uiconfig/theme_definitions/definition.xml |2 2 files changed, 35 insertions(+), 41 deletions(-) New commits: commit 212a40aaf7ec3316d5209b688f5f79821f99fbdc Author: Tomaž Vajngerl AuthorDate: Mon Mar 11 17:08:18 2019 +0100 Commit: Tomaž Vajngerl CommitDate: Mon Mar 11 23:09:18 2019 +0100 widget theme: change the tab item height to (min) 32 px Change-Id: I1919300071a06242fe832880b46c944989daa4b6 Reviewed-on: https://gerrit.libreoffice.org/69057 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx index 213547cc2d3a..64ef751c7476 100644 --- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx +++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx @@ -776,10 +776,12 @@ bool FileDefinitionWidgetDraw::getNativeControlRegion( if (!pPart) return false; -rNativeBoundingRegion = tools::Rectangle( -rBoundingControlRegion.TopLeft(), -Size(rBoundingControlRegion.GetWidth() + pPart->mnMarginWidth, - rBoundingControlRegion.GetHeight() + pPart->mnMarginHeight)); +long nWidth = std::max(rBoundingControlRegion.GetWidth() + pPart->mnMarginWidth, + long(pPart->mnWidth)); +long nHeight = std::max(rBoundingControlRegion.GetHeight() + pPart->mnMarginHeight, +long(pPart->mnHeight)); + +rNativeBoundingRegion = tools::Rectangle(aLocation, Size(nWidth, nHeight)); rNativeContentRegion = rNativeBoundingRegion; return true; } diff --git a/vcl/uiconfig/theme_definitions/definition.xml b/vcl/uiconfig/theme_definitions/definition.xml index e91953109554..5a4be114ea97 100644 --- a/vcl/uiconfig/theme_definitions/definition.xml +++ b/vcl/uiconfig/theme_definitions/definition.xml @@ -320,7 +320,7 @@ - + commit 897f6f6252f38e93764aa0e72135768ab1ec3679 Author: Tomaž Vajngerl AuthorDate: Mon Mar 11 16:52:37 2019 +0100 Commit: Tomaž Vajngerl CommitDate: Mon Mar 11 23:09:08 2019 +0100 better adjustment algorithm for dynamic sized widgets A algorithm that gives better results for dynamically sized widgets is to increase proportionally only the points in shapes that are over the half of the widget width (or height, when adjusting the other dimension). This preserves the margins and doesn't distort the shape of the paths, which is especially visible when the source needs to be largely resized in one dimension only. Change-Id: I2cceb249063387c0f7400ef8d75adb5899aa8c23 Reviewed-on: https://gerrit.libreoffice.org/69056 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx index 3c0ad43c99b7..213547cc2d3a 100644 --- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx +++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx @@ -165,24 +165,18 @@ void drawFromDrawCommands(gfx::DrawRoot const& rDrawRoot, SalGraphics& rGraphics basegfx::B2DRange aInputRectangle(rRectangle.maRectangle); +double fDeltaX = aTargetSurface.getWidth() - aSVGRect.getWidth(); +double fDeltaY = aTargetSurface.getHeight() - aSVGRect.getHeight(); + basegfx::B2DRange aFinalRectangle( -aTargetSurface.getMinX() + aInputRectangle.getMinX(), -aTargetSurface.getMinY() + aInputRectangle.getMinY(), -aTargetSurface.getMaxX() - (aSVGRect.getMaxX() - aInputRectangle.getMaxX()), -aTargetSurface.getMaxY() - (aSVGRect.getMaxY() - aInputRectangle.getMaxY())); - - aInputRectangle.transform(basegfx::utils::createTranslateB2DHomMatrix( --aInputRectangle.getMinX(), -aInputRectangle.getMinY())); - aInputRectangle.transform(basegfx::utils::createScaleB2DHomMatrix( -aFinalRectangle.getWidth() / aInputRectangle.getWidth(), -aFinalRectangle.getHeight() / aInputRectangle.getHeight())); - aInputRectangle.transform(basegfx::utils::createTranslateB2DHomMatrix( -aFinalRectangle.getMinX() - 0.5, -aFinalRectangle.getMinY() -- 0.5)); // compensate 0.5 for different interpretation of where the center of a pixel is +aInputRectangle.getMinX(), aInputRectangle.getMinY(), +aInputRectangle.getMaxX() + fDeltaX, aInputRectangle.getMaxY() + fDeltaY); + + aFinalRectangle.transform(basegfx::utils::createTranslateB2DHomMatrix( +aTargetSurface.getMinX()
[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103704 Bug 103704 depends on bug 99685, which changed state. Bug 99685 Summary: Slides are flashing buffer of prior slide at the end of "Fade" transition, or end of "Fine Dissolve" transition https://bugs.documentfoundation.org/show_bug.cgi?id=99685 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99685] Slides are flashing buffer of prior slide at the end of "Fade" transition, or end of "Fine Dissolve" transition
https://bugs.documentfoundation.org/show_bug.cgi?id=99685 Mark changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #29 from Mark --- Still not working for me, in fact the issue is worse it now flashes black lines across the screen for longer and hurts my eyes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ios/CustomTarget_iOS_setup.mk
ios/CustomTarget_iOS_setup.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 6088eeb6ea1c92be96418116556e32de6d33d038 Author: Tor Lillqvist AuthorDate: Mon Mar 11 17:16:20 2019 +0200 Commit: Tor Lillqvist CommitDate: Mon Mar 11 23:33:33 2019 +0200 We need share/theme_definitions in the iOS app Change-Id: I460a71f363eb3b7f89786b8bd02f4b8f9521f4c7 diff --git a/ios/CustomTarget_iOS_setup.mk b/ios/CustomTarget_iOS_setup.mk index e651dd63f5bb..faf8d25bf629 100644 --- a/ios/CustomTarget_iOS_setup.mk +++ b/ios/CustomTarget_iOS_setup.mk @@ -67,6 +67,7 @@ $(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk \ cp -R $(INSTDIR)/share/registry $(IOSRES) cp $(INSTDIR)/share/config/*zip $(IOSRES)/share/config cp -R $(INSTDIR)/share/liblangtag $(IOSRES)/share + cp -R $(INSTDIR)/share/theme_definitions $(IOSRES)/share mkdir -p $(IOSRES)/share/fonts/truetype cp $(INSTDIR)/share/fonts/truetype/Liberation* $(IOSRES)/share/fonts/truetype cp $(SRCDIR)/ios/welcome.odt $(IOSRES) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/build loleaflet/js loleaflet/Makefile.am loleaflet/src
loleaflet/Makefile.am | 10 +++---
loleaflet/build/deps.js |4
2 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 315fc0b3e8d4ccd968984d15e5913600316add99
Author: Henry Castro
AuthorDate: Mon Mar 11 16:53:39 2019 -0400
Commit: Henry Castro
CommitDate: Mon Mar 11 17:30:07 2019 -0400
loleaflet: move main.js to src/ directory
Simplify building loleaflet.
Change-Id: I3cdc6455b21e683b0331997766badd606c6aca43
diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index e64869516..00953227f 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -308,8 +308,7 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_DST) \
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
$(builddir)/dist/global.js \
$(builddir)/dist/jquery.mCustomScrollbar.js \
- $(builddir)/dist/w2ui-1.5.rc1.js \
- $(builddir)/dist/main.js
+ $(builddir)/dist/w2ui-1.5.rc1.js
@touch $@
else
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
@@ -335,8 +334,7 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
$(builddir)/dist/global.js \
$(srcdir)/js/jquery.mCustomScrollbar.js \
- $(srcdir)/js/w2ui-1.5.rc1.js \
- $(srcdir)/js/main.js
+ $(srcdir)/js/w2ui-1.5.rc1.js
@echo "Uglify loleaflet js files..."
NODE_PATH=$(abs_builddir)/node_modules $(NODE)
node_modules/uglify-js/bin/uglifyjs \
$(L10N_IOS_ALL_JS) \
@@ -344,7 +342,6 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(srcdir)/js/jquery.mCustomScrollbar.js \
$(srcdir)/js/w2ui-1.5.rc1.js \
$(builddir)/build/dist/loleaflet-src.js \
- $(srcdir)/js/main.js \
--output $@
endif
@@ -362,8 +359,7 @@ $(builddir)/dist/loleaflet.html:
$(srcdir)/html/loleaflet.html.m4 $(LOLEAFLET_HT
-DLOLEAFLET_JS="$(subst $(SPACE),$(COMMA),$(NODE_MODULES_JS) \
jquery.mCustomScrollbar.js \
w2ui-1.5.rc1.js \
- $(call LOLEAFLET_JS,$(srcdir)/build/build.js) \
- main.js)" \
+ $(call LOLEAFLET_JS,$(srcdir)/build/build.js))" \
$(srcdir)/html/loleaflet.html.m4 > $@
node_modules: npm-shrinkwrap.json
diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index c1247ab54..88f60116f 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -499,6 +499,10 @@ var deps = {
DivOverlay: {
src: ['layer/marker/DivOverlay.js'],
desc: 'Div overlay to put on the map.'
+ },
+
+ Main: {
+ src: ['main.js']
}
};
diff --git a/loleaflet/js/main.js b/loleaflet/src/main.js
similarity index 100%
rename from loleaflet/js/main.js
rename to loleaflet/src/main.js
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/CppunitTest_vcl_gen.mk vcl/Module_vcl.mk vcl/opengl vcl/qa
vcl/CppunitTest_vcl_gen.mk| 42 +
vcl/Module_vcl.mk |6 ++
vcl/opengl/salbmp.cxx |7 --
vcl/qa/cppunit/gen/data/tdf121120.png |binary
vcl/qa/cppunit/gen/gen.cxx| 84 ++
5 files changed, 132 insertions(+), 7 deletions(-)
New commits:
commit 20726c61680242eb647253651302dc048348687d
Author: Miklos Vajna
AuthorDate: Fri Mar 8 16:36:03 2019 +0100
Commit: Caolán McNamara
CommitDate: Mon Mar 11 22:26:36 2019 +0100
tdf#121120 vcl opengl: handle 8-bit palette bitmap as 24 bit RGB texture
This fixes the black rectangle instead of actual image content in the
bugdoc.
An alternative would be to handle this in the PNG import, but commit
66dbd4da3afcadb1393daf9be9cecff71b86509a (tdf#113918: Workaround: Load
1bpp indexed PNG as 8bpp indexed Bitmap, 2017-11-20) already tried
something similar and failed, leading to the revert in commit
25cd843664919974f0d21ca7a0b02cc43e9eeabb (tdf#115297: alternative fix
for displaying 1bit images, 2018-02-27).
The test is especially useful with SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen
specified on Linux, so the GL codepath is triggered.
(cherry picked from commit ba0abd02df8d62342497018f516535a2f1597fb6)
Change-Id: Ia9d049d09dce2ac34826ee427f74616a96a35c88
Reviewed-on: https://gerrit.libreoffice.org/69036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/CppunitTest_vcl_gen.mk b/vcl/CppunitTest_vcl_gen.mk
new file mode 100644
index ..84dd0ca25bb0
--- /dev/null
+++ b/vcl/CppunitTest_vcl_gen.mk
@@ -0,0 +1,42 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,vcl_gen))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,vcl_gen, \
+ vcl/qa/cppunit/gen/gen \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,vcl_gen, \
+ comphelper \
+ cppu \
+ cppuhelper \
+ sal \
+ sfx \
+ subsequenttest \
+ test \
+ tl \
+ unotest \
+ vcl \
+))
+
+$(eval $(call gb_CppunitTest_use_external,vcl_gen,boost_headers))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,vcl_gen))
+
+$(eval $(call gb_CppunitTest_use_ure,vcl_gen))
+$(eval $(call gb_CppunitTest_use_vcl_non_headless,vcl_gen))
+
+$(eval $(call gb_CppunitTest_use_rdb,vcl_gen,services))
+
+$(eval $(call gb_CppunitTest_use_configuration,vcl_gen))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index baef5f31e34e..cd50d11771f1 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -251,4 +251,10 @@ $(eval $(call gb_Module_add_screenshot_targets,vcl,\
CppunitTest_vcl_dialogs_test \
))
+ifneq ($(DISPLAY),)
+$(eval $(call gb_Module_add_slowcheck_targets,vcl,\
+CppunitTest_vcl_gen \
+))
+endif
+
# vim: set noet sw=4 ts=4:
diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index ca8f118c8003..2a579e813a5b 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -496,13 +496,6 @@ GLuint OpenGLSalBitmap::CreateTexture()
determineTextureFormat(mnBits, nFormat, nType);
}
-else if( mnBits == 8 && maPalette.IsGreyPalette() )
-{
-// no conversion needed for grayscale
-pData = mpUserBuffer.get();
-nFormat = GL_LUMINANCE;
-nType = GL_UNSIGNED_BYTE;
-}
else
{
VCL_GL_INFO( "::CreateTexture - convert from " << mnBits << " to
24 bits" );
diff --git a/vcl/qa/cppunit/gen/data/tdf121120.png
b/vcl/qa/cppunit/gen/data/tdf121120.png
new file mode 100644
index ..8e48fba385f9
Binary files /dev/null and b/vcl/qa/cppunit/gen/data/tdf121120.png differ
diff --git a/vcl/qa/cppunit/gen/gen.cxx b/vcl/qa/cppunit/gen/gen.cxx
new file mode 100644
index ..f5d1c1c6769c
--- /dev/null
+++ b/vcl/qa/cppunit/gen/gen.cxx
@@ -0,0 +1,84 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+using namespace com::sun::star;
+
+/// This test uses the gen backend (i.e. intentionally
[Libreoffice-bugs] [Bug 61566] Text toolbars should have two rows
https://bugs.documentfoundation.org/show_bug.cgi?id=61566 --- Comment #4 from Dave Close --- Thanks for the explanation. The last cited reference states, "LibreOffice believes that it should be pleasant and easy to use by anyone; and it will never take steps (like other softwares sometimes do) that will sacrifice one group of users’ preferences just to please another." But everything I see makes it hard or harder to use for those of us who prefer *TEXT* buttons, not pictures (icons). For example, there is no way to change all toolbars globally to text mode, and it appears to be very difficult, if not impossible, to make text mode changes persist when the same document is later reopened. One of the references cited seems to continue this bias against text mode by asserting that text labels should not or cannot be used with the notebookbar. I truly wish that the quotation above could be believed but it doesn't look that way to me. This ticket was opened because I prefer to use text buttons. Offering a new way to arrange icons is not a solution. If LO doesn't want to support text, that's certainly your privilege, but it won't make me happy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig filter/source include/svtools sc/source svtools/source svx/source
cui/source/options/dbregister.cxx | 10 -
cui/source/options/doclinkdialog.cxx | 114 +-
cui/source/options/doclinkdialog.hxx | 35 ++
cui/uiconfig/ui/databaselinkdialog.ui | 20 ++-
filter/source/xsltdialog/xmlfiltertabpagexslt.cxx |8 -
include/svtools/inettbc.hxx | 12 +-
include/svtools/urlcontrol.hxx|2
sc/source/ui/miscdlgs/datastreamdlg.cxx |4
sc/source/ui/miscdlgs/linkarea.cxx|8 -
svtools/source/control/inettbc.cxx| 37 ++-
svx/source/form/datanavi.cxx |2
svx/source/inc/datanavi.hxx |6 -
12 files changed, 139 insertions(+), 119 deletions(-)
New commits:
commit 5f9368a35d641c5b611fab9945969e92a0f368a1
Author: Caolán McNamara
AuthorDate: Mon Mar 11 15:55:24 2019 +
Commit: Caolán McNamara
CommitDate: Mon Mar 11 22:23:21 2019 +0100
weld ODocumentLinkDialog
Change-Id: I9dd3a25e68da00acff24f5ccfafbfc97d9efcf54
Reviewed-on: https://gerrit.libreoffice.org/69058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/dbregister.cxx
b/cui/source/options/dbregister.cxx
index a30e059c7c10..e71fac5ccd80 100644
--- a/cui/source/options/dbregister.cxx
+++ b/cui/source/options/dbregister.cxx
@@ -403,15 +403,15 @@ void DbRegistrationOptionsPage::insertNewEntry( const
OUString& _sName,const OUS
void DbRegistrationOptionsPage::openLinkDialog(const OUString& _sOldName,const
OUString& _sOldLocation,SvTreeListEntry const * _pEntry)
{
-ScopedVclPtrInstance< ODocumentLinkDialog > aDlg(this,_pEntry == nullptr);
+ODocumentLinkDialog aDlg(GetDialogFrameWeld(), _pEntry == nullptr);
-aDlg->setLink(_sOldName,_sOldLocation);
-aDlg->setNameValidator(LINK( this, DbRegistrationOptionsPage,
NameValidator ) );
+aDlg.setLink(_sOldName,_sOldLocation);
+aDlg.setNameValidator(LINK( this, DbRegistrationOptionsPage, NameValidator
) );
-if ( aDlg->Execute() == RET_OK )
+if (aDlg.run() == RET_OK)
{
OUString sNewName,sNewLocation;
-aDlg->getLink(sNewName,sNewLocation);
+aDlg.getLink(sNewName,sNewLocation);
if ( _pEntry == nullptr || sNewName != _sOldName || sNewLocation !=
_sOldLocation )
{
if ( _pEntry )
diff --git a/cui/source/options/doclinkdialog.cxx
b/cui/source/options/doclinkdialog.cxx
index 201cb18c7549..1baf362e778b 100644
--- a/cui/source/options/doclinkdialog.cxx
+++ b/cui/source/options/doclinkdialog.cxx
@@ -33,80 +33,60 @@
namespace svx
{
-
-
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::ucb;
using namespace ::svt;
-ODocumentLinkDialog::ODocumentLinkDialog( vcl::Window* _pParent, bool
_bCreateNew )
-: ModalDialog(_pParent, "DatabaseLinkDialog",
-"cui/ui/databaselinkdialog.ui")
+ODocumentLinkDialog::ODocumentLinkDialog(weld::Window* pParent, bool
_bCreateNew)
+: GenericDialogController(pParent, "cui/ui/databaselinkdialog.ui",
"DatabaseLinkDialog")
+, m_xBrowseFile(m_xBuilder->weld_button("browse"))
+, m_xName(m_xBuilder->weld_entry("name"))
+, m_xOK(m_xBuilder->weld_button("ok"))
+, m_xAltTitle(m_xBuilder->weld_label("alttitle"))
+, m_xURL(new URLBox(m_xBuilder->weld_combo_box("url")))
{
-get(m_pURL, "url");
-get(m_pOK, "ok");
-get(m_pName, "name");
-get(m_pBrowseFile, "browse");
-
if (!_bCreateNew)
-SetText(get("alttitle")->GetText());
+m_xDialog->set_title(m_xAltTitle->get_label());
-m_pURL->SetFilter("*.odb");
+m_xURL->SetSmartProtocol(INetProtocol::File);
+m_xURL->DisableHistory();
+m_xURL->SetFilter("*.odb");
-m_pName->SetModifyHdl( LINK(this, ODocumentLinkDialog, OnTextModified)
);
-m_pURL->SetModifyHdl( LINK(this, ODocumentLinkDialog, OnTextModified)
);
-m_pBrowseFile->SetClickHdl( LINK(this, ODocumentLinkDialog,
OnBrowseFile) );
-m_pOK->SetClickHdl( LINK(this, ODocumentLinkDialog, OnOk) );
-
-m_pURL->SetDropDownLineCount(10);
+m_xName->connect_changed( LINK(this, ODocumentLinkDialog,
OnEntryModified) );
+m_xURL->connect_changed( LINK(this, ODocumentLinkDialog,
OnComboBoxModified) );
+m_xBrowseFile->connect_clicked( LINK(this, ODocumentLinkDialog,
OnBrowseFile) );
+m_xOK->connect_clicked( LINK(this, ODocumentLinkDialog, OnOk) );
validate();
-
-m_pURL->SetDropDownLineCount( 5 );
}
ODocumentLinkDialog::~ODocumentLinkDialog()
{
-disposeOnce();
}
-void ODocumentLinkDialog::dispose()
+void ODocumentLinkDialog::setLink(const OUString& rName, const OUString&
rURL)
{
-
[Libreoffice-bugs] [Bug 124008] New: array declared with own type can't redim
https://bugs.documentfoundation.org/show_bug.cgi?id=124008 Bug ID: 124008 Summary: array declared with own type can't redim Product: LibreOffice Version: 6.2.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lo...@glasir.de Created attachment 149895 --> https://bugs.documentfoundation.org/attachment.cgi?id=149895=edit example for redim with and without Perserve-flag and own types It‘s not longer possible to ReDim arrays declared with own types but with the flag „preserve“ it still works. Example: Type myType sTypeAs String aValue As Variant iNo As Integer iRange As Integer oColour As Object End Type Sub Test Dim aType(10) As myType ReDim aType(20) As myType print Str(uBound(aType))'result: 10 ReDim Preserve aType(20) As myType print Str(uBound(aType))'result: 20 End Sub -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124007] Doesn't set up focus into text field in Autofilter window
https://bugs.documentfoundation.org/show_bug.cgi?id=124007 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 149894 --> https://bugs.documentfoundation.org/attachment.cgi?id=149894=edit Example ODS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124007] Doesn't set up focus into text field in Autofilter window
https://bugs.documentfoundation.org/show_bug.cgi?id=124007 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||103512 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103512 [Bug 103512] [META] AutoFilter-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124007 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124007 [Bug 124007] Doesn't set up focus into text field in Autofilter window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124007] New: Doesn't set up focus into text field in Autofilter window
https://bugs.documentfoundation.org/show_bug.cgi?id=124007 Bug ID: 124007 Summary: Doesn't set up focus into text field in Autofilter window Product: LibreOffice Version: 6.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: Doesn't set up focus into text field in Autofilter window Steps to Reproduce: 1. Open file from attach 2. Open Autofilter in column B (text cursor doesn't show in text field!) 3. Enter some letters 4. Press Enter key 5. It happens nothing Actual Results: After pressing on Enter key Autofilter doesn't work Expected Results: After pressing on Enter key Autofilter works Reproducible: Always User Profile Reset: No Additional Info: LO 6.2 release If you'll try repro it from scratch you'll get work Autofilter. May be hyperlinks in cells are problem? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123985] basic command "print" causes crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=123985 --- Comment #2 from F. Tremmel --- (In reply to raal from comment #1) > n crash with Version: 6.3.0.0.alpha0+ > Build ID: 732d630c3d2a168c725c18e4dd8df7a0a4f85566 > CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; > > Seems to be fixed with dev version. Please could you test it with > dev version? You can download it here: > http://dev-builds.libreoffice.org/daily/master/ > Thank you I will see what can be done. Since it is my work computer and Libreoffice is a daily tool, I would prefer if someone could confirm the error first. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 Heiko Tietze changed: What|Removed |Added CC||er...@redhat.com --- Comment #6 from Heiko Tietze --- (In reply to Oliver Brinzing from comment #5) > ...the way excel does it in case of copy and paste protected cells > into an unprotected area (while the sheet is protected) is much more > intuitiv, So the request changes to become more Excel-like? Sounds like a safety issue but please elaborate a bit. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 Heiko Tietze changed: What|Removed |Added CC||er...@redhat.com --- Comment #6 from Heiko Tietze --- (In reply to Oliver Brinzing from comment #5) > ...the way excel does it in case of copy and paste protected cells > into an unprotected area (while the sheet is protected) is much more > intuitiv, So the request changes to become more Excel-like? Sounds like a safety issue but please elaborate a bit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Bug 103239 depends on bug 61566, which changed state. Bug 61566 Summary: Text toolbars should have two rows https://bugs.documentfoundation.org/show_bug.cgi?id=61566 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61566] Text toolbars should have two rows
https://bugs.documentfoundation.org/show_bug.cgi?id=61566 Heiko Tietze changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #3 from Heiko Tietze --- (In reply to Dave Close from comment #2) > Where can I learn about the Notebookbar? https://help.libreoffice.org/6.2/en-US/text/shared/01/notebook_bar.html?DbPAR=SHARED#bm_id190920161758487840 https://blog.documentfoundation.org/blog/2016/12/21/the-document-foundation-announces-the-muffin-a-new-tasty-user-interface-concept-for-libreoffice/ https://design.blog.documentfoundation.org/2016/12/21/evolving-past-the-restrictions-of-toolbars/ https://design.blog.documentfoundation.org/2017/01/16/diy-ui-how-to-create-your-own-notebookbar/ https://wiki.documentfoundation.org/Design/ToolBar https://mikekaganski.wordpress.com/2017/01/12/libreoffice-muffin/ (and any of the gazillion news after the recently published version 6.2 that makes it non-experimental) The point is, toolbars are single row controls. LibreOffice aims to be as close to the system's look and feel as possible and we wont change the standard layout. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - svgio/qa
svgio/qa/cppunit/SvgRead.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 8a82814679c986e5627151ae84340974c468ac18 Author: Mike Kaganski AuthorDate: Mon Mar 11 22:18:14 2019 +0300 Commit: Tomaž Vajngerl CommitDate: Mon Mar 11 21:26:07 2019 +0100 Fix build [CXX] svgio/qa/cppunit/SvgRead.cxx C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2440: '': cannot convert from 'Color' to 'sal_Int32' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2672: 'CppUnit::assertEquals': no matching overloaded function found C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(103): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)': expects 4 arguments - 3 provided C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2440: '': cannot convert from 'Color' to 'sal_Int32' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2672: 'CppUnit::assertEquals': no matching overloaded function found C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(105): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)': expects 4 arguments - 3 provided C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2440: '': cannot convert from 'Color' to 'sal_Int32' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2672: 'CppUnit::assertEquals': no matching overloaded function found C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(134): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)': expects 4 arguments - 3 provided C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2440: '': cannot convert from 'Color' to 'sal_Int32' C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2672: 'CppUnit::assertEquals': no matching overloaded function found C:/lo/src/core2/svgio/qa/cppunit/SvgRead.cxx(136): error C2780: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)': expects 4 arguments - 3 provided C:\lo\src\core2\workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(127): note: see declaration of 'CppUnit::assertEquals' make[1]: *** [C:/lo/src/core2/solenv/gbuild/LinkTarget.mk:293: C:/lo/src/core2/workdir/CxxObject/svgio/qa/cppunit/SvgRead.o] Error 2 make: *** [Makefile:166: CppunitTest_svgio_read] Error 2 Change-Id: I4e1cf222a416772f1920194ccfcf459f40b577d6 Reviewed-on: https://gerrit.libreoffice.org/69064 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/svgio/qa/cppunit/SvgRead.cxx b/svgio/qa/cppunit/SvgRead.cxx index 996be9d21f08..8b13bd68bb45 100644 --- a/svgio/qa/cppunit/SvgRead.cxx +++ b/svgio/qa/cppunit/SvgRead.cxx @@ -100,9 +100,9 @@ void TestParsing::testSimpleRectangle() CPPUNIT_ASSERT_EQUAL(basegfx::B2DRange(10, 10, 110, 110), pDrawRect->maRectangle); CPPUNIT_ASSERT_EQUAL(3.0, pDrawRect->mnStrokeWidth); CPPUNIT_ASSERT(bool(pDrawRect->mpStrokeColor)); -CPPUNIT_ASSERT_EQUAL(sal_Int32(0xff), sal_Int32(Color(*pDrawRect->mpStrokeColor))); +CPPUNIT_ASSERT_EQUAL(ColorData(0xff), Color(*pDrawRect->mpStrokeColor).GetRGBColor()); CPPUNIT_ASSERT(bool(pDrawRect->mpFillColor)); -CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00cc00), sal_Int32(Color(*pDrawRect->mpFillColor))); +CPPUNIT_ASSERT_EQUAL(ColorData(0x00cc00), Color(*pDrawRect->mpFillColor).GetRGBColor()); } void TestParsing::testPath() @@ -131,9 +131,9 @@ void TestParsing::testPath() basegfx::utils::exportToSvgD(pDrawPath->maPolyPolygon, true, true, false)); CPPUNIT_ASSERT_EQUAL(0.0, pDrawPath->mnStrokeWidth); CPPUNIT_ASSERT(bool(pDrawPath->mpStrokeColor)); -
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/svdata.hxx |4 +
vcl/source/app/svmain.cxx |3 +
vcl/source/gdi/FileDefinitionWidgetDraw.cxx | 72 +---
3 files changed, 61 insertions(+), 18 deletions(-)
New commits:
commit 805b15ce536e3d6c40d0dc4f98b5aa6ffa5344c0
Author: Tomaž Vajngerl
AuthorDate: Mon Mar 11 16:38:32 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Mar 11 21:21:50 2019 +0100
cache file based widget images and draw commands
It is wasteful to parse svg icons all the time so lets cache the
result when this make sense in a LRU map.
Change-Id: I95cc317c9301138a9e384d270223ba147a123e59
Reviewed-on: https://gerrit.libreoffice.org/69055
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index cb666e718943..c5b3482642a2 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -42,6 +42,7 @@
#include
#include "ControlCacheKey.hxx"
#include "schedulerimpl.hxx"
+#include
struct ImplPostEventData;
struct ImplTimerData;
@@ -199,6 +200,9 @@ struct ImplSVGDIData
longmnAppFontX = 0; // AppFont
X-Numenator for 40/tel Width
longmnAppFontY = 0; // AppFont
Y-Numenator for 80/tel Height
boolmbFontSubChanged = false; // true:
FontSubstitution was changed between Begin/End
+
+o3tl::lru_map maThemeImageCache =
o3tl::lru_map(10);
+o3tl::lru_map maThemeDrawCommandsCache =
o3tl::lru_map(50);
};
struct ImplSVWinData
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 7f23e366cc67..6319208896ae 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -575,6 +575,9 @@ void DeInitVCL()
pSVData->maGDIData.maScaleCache.remove_if([](const
o3tl::lru_map::key_value_pair_t&)
{ return true; });
+pSVData->maGDIData.maThemeDrawCommandsCache.clear();
+pSVData->maGDIData.maThemeImageCache.clear();
+
// Deinit Sal
if (pSVData->mpDefInst)
{
diff --git a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
index e321734e9a6e..3c0ad43c99b7 100644
--- a/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
+++ b/vcl/source/gdi/FileDefinitionWidgetDraw.cxx
@@ -343,9 +343,26 @@ void
munchDrawCommands(std::vector> const& rDrawCom
nScaleFactor = comphelper::LibreOfficeKit::getDPIScale();
auto const& rDrawCommand = static_cast(*pDrawCommand);
-SvFileStream aFileStream(rDrawCommand.msSource,
StreamMode::READ);
+auto& rCacheImages =
ImplGetSVData()->maGDIData.maThemeImageCache;
+OUString rCacheKey = rDrawCommand.msSource + "@" +
OUString::number(nScaleFactor);
+auto& aIterator = rCacheImages.find(rCacheKey);
+
BitmapEx aBitmap;
-vcl::bitmap::loadFromSvg(aFileStream, "", aBitmap,
nScaleFactor);
+if (aIterator == rCacheImages.end())
+{
+SvFileStream aFileStream(rDrawCommand.msSource,
StreamMode::READ);
+
+vcl::bitmap::loadFromSvg(aFileStream, "", aBitmap,
nScaleFactor);
+if (!!aBitmap)
+{
+rCacheImages.insert(std::make_pair(rCacheKey,
aBitmap));
+}
+}
+else
+{
+aBitmap = aIterator->second;
+}
+
long nImageWidth = aBitmap.GetSizePixel().Width();
long nImageHeight = aBitmap.GetSizePixel().Height();
SalTwoRect aTR(0, 0, nImageWidth, nImageHeight, nX, nY,
nImageWidth / nScaleFactor,
@@ -370,27 +387,46 @@ void
munchDrawCommands(std::vector> const& rDrawCom
case DrawCommandType::EXTERNAL:
{
auto const& rDrawCommand = static_cast(*pDrawCommand);
-SvFileStream aFileStream(rDrawCommand.msSource,
StreamMode::READ);
-uno::Reference xContext(
-comphelper::getProcessComponentContext());
-const uno::Reference xSvgParser
-= graphic::SvgTools::create(xContext);
+auto& rCacheDrawCommands =
ImplGetSVData()->maGDIData.maThemeDrawCommandsCache;
-std::size_t nSize = aFileStream.remainingSize();
-std::vector aBuffer(nSize + 1);
-aFileStream.ReadBytes(aBuffer.data(), nSize);
-aBuffer[nSize] = 0;
+auto& aIterator =
rCacheDrawCommands.find(rDrawCommand.msSource);
-uno::Sequence aData(aBuffer.data(), nSize + 1);
-uno::Reference aInputStream(
-new comphelper::SequenceInputStream(aData));
+gfx::DrawRoot aDrawRoot;
-
[Libreoffice-commits] core.git: connectivity/registry
connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu |4 +--- connectivity/registry/jdbc/org/openoffice/Office/DataAccess/Drivers.xcu |4 +--- connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu |4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) New commits: commit 812316f63bc07520c9736af0360c711780fcbf55 Author: Caolán McNamara AuthorDate: Mon Mar 11 11:35:26 2019 + Commit: Caolán McNamara CommitDate: Mon Mar 11 21:00:54 2019 +0100 Related: tdf#123975 I think this needs to be initially unset i.e. https://help.libreoffice.org/Common/Special_Settings#Supports_primary_keys "This tri-state check box by default is set to the undetermined state" otherwise the fix for tdf#123975 has no effect this change initially in... commit 3208fcb3a36d75d6290d9c548430682f153b09db Date: Thu Sep 13 22:57:58 2018 +0200 tdf#119743: add Features entries in Properties block Drivers.xcu Change-Id: Ic08fb1330985b90eec10662d50462f4ec127b9f9 Reviewed-on: https://gerrit.libreoffice.org/69042 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu b/connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu index 22880e912407..91c9a15cfb0a 100644 --- a/connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu +++ b/connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu @@ -99,9 +99,7 @@ - -true - + diff --git a/connectivity/registry/jdbc/org/openoffice/Office/DataAccess/Drivers.xcu b/connectivity/registry/jdbc/org/openoffice/Office/DataAccess/Drivers.xcu index 03b4ee371cd1..65a0d72a2ed1 100644 --- a/connectivity/registry/jdbc/org/openoffice/Office/DataAccess/Drivers.xcu +++ b/connectivity/registry/jdbc/org/openoffice/Office/DataAccess/Drivers.xcu @@ -134,9 +134,7 @@ - -true - + diff --git a/connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu b/connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu index f0d1e03a7bec..f2dbd91c8ed7 100644 --- a/connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu +++ b/connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu @@ -141,9 +141,7 @@ - -true - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/dlg/advancedsettings.cxx | 31 +++-
dbaccess/source/ui/dlg/advancedsettings.hxx |3 ++
2 files changed, 33 insertions(+), 1 deletion(-)
New commits:
commit d89dc81a63a36d75f13064ae2a321f1d8903bf30
Author: Caolán McNamara
AuthorDate: Mon Mar 11 11:35:44 2019 +
Commit: Caolán McNamara
CommitDate: Mon Mar 11 21:00:07 2019 +0100
Resolves: tdf#123975 support tri-state for PrimaryKey ui
typically indeterminate is an initial state which is not returnable
to, this is not the case for PrimaryKey
Change-Id: I82f318e18ad9beabd9ca6e3003a736fee9a5e931
Reviewed-on: https://gerrit.libreoffice.org/69043
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/dbaccess/source/ui/dlg/advancedsettings.cxx
b/dbaccess/source/ui/dlg/advancedsettings.cxx
index 3a60598aac8f..38c50c6467bc 100644
--- a/dbaccess/source/ui/dlg/advancedsettings.cxx
+++ b/dbaccess/source/ui/dlg/advancedsettings.cxx
@@ -87,7 +87,10 @@ namespace dbaui
const SfxPoolItem& rItem = _rCoreAttrs.Get(nItemId);
booleanSetting.bOptionalBool = dynamic_cast() != nullptr;
booleanSetting.xControl =
m_xBuilder->weld_check_button(booleanSetting.sControlId);
-booleanSetting.xControl->connect_toggled(LINK(this,
SpecialSettingsPage, OnToggleHdl));
+if (booleanSetting.bOptionalBool)
+booleanSetting.xControl->connect_toggled(LINK(this,
SpecialSettingsPage, OnTriStateToggleHdl));
+else
+booleanSetting.xControl->connect_toggled(LINK(this,
SpecialSettingsPage, OnToggleHdl));
booleanSetting.xControl->show();
}
}
@@ -112,6 +115,25 @@ namespace dbaui
}
}
+IMPL_LINK(SpecialSettingsPage, OnTriStateToggleHdl, weld::ToggleButton&,
rToggle, void)
+{
+auto eOldState = m_aTriStates[];
+switch (eOldState)
+{
+case TRISTATE_INDET:
+rToggle.set_state(TRISTATE_FALSE);
+break;
+case TRISTATE_TRUE:
+rToggle.set_state(TRISTATE_INDET);
+break;
+case TRISTATE_FALSE:
+rToggle.set_state(TRISTATE_TRUE);
+break;
+}
+m_aTriStates[] = rToggle.get_state();
+OnToggleHdl(rToggle);
+}
+
IMPL_LINK(SpecialSettingsPage, OnToggleHdl, weld::ToggleButton&, rBtn,
void)
{
if ( == m_xAppendTableAlias.get() && m_xAsBeforeCorrelationName)
@@ -172,12 +194,16 @@ namespace dbaui
return;
}
+m_aTriStates.clear();
+
// the boolean items
for (auto const& booleanSetting : m_aBooleanSettings)
{
if (!booleanSetting.xControl)
continue;
+bool bTriState = false;
+
boost::optional aValue;
const SfxPoolItem* pItem =
_rSet.GetItem(booleanSetting.nItemId);
@@ -188,6 +214,7 @@ namespace dbaui
else if (const OptionalBoolItem *pOptionalItem =
dynamic_cast( pItem) )
{
aValue = pOptionalItem->GetFullValue();
+bTriState = true;
}
else
OSL_FAIL( "SpecialSettingsPage::implInitControls: unknown
boolean item type!" );
@@ -203,6 +230,8 @@ namespace dbaui
bValue = !bValue;
booleanSetting.xControl->set_active(bValue);
}
+if (bTriState)
+m_aTriStates[booleanSetting.xControl.get()] =
booleanSetting.xControl->get_state();
}
if (m_xAppendTableAlias && m_xAsBeforeCorrelationName)
diff --git a/dbaccess/source/ui/dlg/advancedsettings.hxx
b/dbaccess/source/ui/dlg/advancedsettings.hxx
index c4b7d7894c71..2c6314606135 100644
--- a/dbaccess/source/ui/dlg/advancedsettings.hxx
+++ b/dbaccess/source/ui/dlg/advancedsettings.hxx
@@ -59,6 +59,8 @@ namespace dbaui
std::unique_ptr m_xMaxRowScanLabel;
std::unique_ptr m_xMaxRowScan;
+std::map m_aTriStates;
+
BooleanSettingDescs m_aBooleanSettings;
boolm_bHasBooleanComparisonMode;
@@ -66,6 +68,7 @@ namespace dbaui
public:
DECL_LINK(OnToggleHdl, weld::ToggleButton&, void);
+DECL_LINK(OnTriStateToggleHdl, weld::ToggleButton&, void);
virtual boolFillItemSet ( SfxItemSet* _rCoreAttrs ) override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108734] [META] Character dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108734 Bug 108734 depends on bug 123949, which changed state. Bug 123949 Summary: Problema in Font Dialog https://bugs.documentfoundation.org/show_bug.cgi?id=123949 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123949] Problema in Font Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123949 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu Status|NEW |RESOLVED --- Comment #5 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 123711 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124000] FILEOPEN DOCX Last row of OLE object table is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=124000 --- Comment #5 from Gabor Kelemen --- (In reply to Durgapriyanka from comment #3) > Thank you for reporting the bug. The OLE object table doesn't open in my > writer. The table is empty with a blinking border line on the left side. > But, the table does open in MS Word. > > Version: 6.3.0.0.alpha0+ > Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 Part of the problem is that your build is 6 weeks old: https://gerrit.libreoffice.org/plugins/gitiles/core/+log/b6b28931435e44aca92b8c0e1659f701e3ed1a87 Now the example file was a little bit trimmed back for privacy reasons, and the content you see in Word is actually on the fourth sheet of the embedded XLSX. Until recently LO could only show the first page of such embedded files, until it was fixed in bug #122594. What you see is the first, empty sheet of the embedded file. Please update your local build :). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120685] Page setup in Draw will not honor exact custom dimensions
https://bugs.documentfoundation.org/show_bug.cgi?id=120685 --- Comment #2 from mwtjunkm...@gmail.com --- If the bug was confirmed, should the bug report be flagged as New rather than unconfirmed? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108734] [META] Character dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108734 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123949 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123949 [Bug 123949] Problema in Font Dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123949] Problema in Font Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123949 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||79045_79...@mail.ru, ||caol...@redhat.com Blocks||108734 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- $ git bisect bad e9c731fd858235b127b3910a3045a192a591574a is the first bad commit commit e9c731fd858235b127b3910a3045a192a591574a Author: Norbert Thiebaud Date: Fri Nov 9 16:05:54 2018 -0800 source sha:a977098f59a4c931c6f8a1d423720e682f5ed047 https://gerrit.libreoffice.org/#/c/62908/ CC: Caolan McNamara Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108734 [Bug 108734] [META] Character dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123910] Writer hangs when deleting a line of text
https://bugs.documentfoundation.org/show_bug.cgi?id=123910 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de Hardware|x86-64 (AMD64) |All OS|Linux (All) |All Ever confirmed|0 |1 --- Comment #3 from Dieter Praas --- I confirm it with Version: 6.3.0.0.alpha0+ (x64) Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded and with Version: 6.1.5.2 (x64) Build-ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123973] Master objects in a LO Draw document export with TIFF but not PNG or GIF
https://bugs.documentfoundation.org/show_bug.cgi?id=123973 --- Comment #2 from mwtjunkm...@gmail.com --- Created attachment 149893 --> https://bugs.documentfoundation.org/attachment.cgi?id=149893=edit Export this file's slide as a PNG Export the slide on this file as a PNG, then again as a GIF. The first line of text, being on the master, does not export. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123910] Writer hangs when deleting a line of text
https://bugs.documentfoundation.org/show_bug.cgi?id=123910 --- Comment #2 from Hal Miller --- Created attachment 149892 --> https://bugs.documentfoundation.org/attachment.cgi?id=149892=edit Try to backspace out that blank line on page 3 near the bottom -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124006] New: EDITING: copy & paste between two LO instances fails for formula's
https://bugs.documentfoundation.org/show_bug.cgi?id=124006 Bug ID: 124006 Summary: EDITING: copy & paste between two LO instances fails for formula's Product: LibreOffice Version: 6.1.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: oliver.brinz...@gmx.de steps to reproduce: - open two instances of LO Calc, e.g. LO 6.0.7.3 and LO 6.1.4.2 with same locale - LO 6.0.7.3, cell A1: enter =Today() - copy with ctrl+c - LO 6.1.4.2: paste with ctrl+v -> cell A1 shows number (e.g. 43535) instead of expected formula same behaviour if copied from AOO 4.1.5 to LO and vice versa copying from LO into Excel works: - open Excel 2016 - new a spreadsheet - cell A1: paste with ctrl+v - A1 shows =Today() copy from Excel into LO spreadsheet works too, Paste Special shows options: - Microsoft Excel Binary Interchange format (Biff8) - Microsoft Excel Binary Interchange format (Biff5) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sc/qa sc/source
sc/qa/unit/data/ods/pivot-table-str-and-err-in-data.ods |binary
sc/qa/unit/pivottable_filters_test.cxx | 29
sc/source/filter/excel/xepivotxml.cxx |7 ++-
3 files changed, 34 insertions(+), 2 deletions(-)
New commits:
commit ebc7f46f65cb853845eae9c2f7b96f341e4b0cb4
Author: Mike Kaganski
AuthorDate: Fri Mar 8 14:01:03 2019 +0300
Commit: Mike Kaganski
CommitDate: Mon Mar 11 20:18:35 2019 +0100
tdf#123939: string and error are same type for pivot cache in XLSX
Change-Id: Id39d322661f7537e8999acafee655c0cc16a78c1
Reviewed-on: https://gerrit.libreoffice.org/68911
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/69063
Tested-by: Mike Kaganski
diff --git a/sc/qa/unit/data/ods/pivot-table-str-and-err-in-data.ods
b/sc/qa/unit/data/ods/pivot-table-str-and-err-in-data.ods
new file mode 100644
index ..9c58dc8958ae
Binary files /dev/null and
b/sc/qa/unit/data/ods/pivot-table-str-and-err-in-data.ods differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx
b/sc/qa/unit/pivottable_filters_test.cxx
index 1a046296357f..4674ebb2533f 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -85,6 +85,7 @@ public:
void testPivotTableTabularModeXLSX();
void testTdf112106();
void testTdf123923();
+void testTdf123939();
CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
@@ -124,6 +125,7 @@ public:
CPPUNIT_TEST(testPivotTableTabularModeXLSX);
CPPUNIT_TEST(testTdf112106);
CPPUNIT_TEST(testTdf123923);
+CPPUNIT_TEST(testTdf123939);
CPPUNIT_TEST_SUITE_END();
@@ -2334,6 +2336,33 @@ void ScPivotTableFiltersTest::testTdf123923()
"v", "#REF!");
}
+void ScPivotTableFiltersTest::testTdf123939()
+{
+// tdf#123939: Excel warns on containsMixedTypes="1" if sharedItems has
only strings and errors
+
+ScDocShellRef xShell = loadDoc("pivot-table-str-and-err-in-data.",
FORMAT_ODS);
+CPPUNIT_ASSERT(xShell.is());
+
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(&(*xShell), FORMAT_XLSX);
+xmlDocPtr pTable = XPathHelper::parseExport(pXPathFile, m_xSFactory,
+
"xl/pivotCache/pivotCacheDefinition1.xml");
+CPPUNIT_ASSERT(pTable);
+
+assertXPathNoAttribute(pTable,
+
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:sharedItems",
+ "containsMixedTypes");
+
+// But we must emit containsMixedTypes="1" for a mix of errors and
non-string types!
+
+pTable = XPathHelper::parseExport(pXPathFile, m_xSFactory,
+
"xl/pivotCache/pivotCacheDefinition2.xml");
+CPPUNIT_ASSERT(pTable);
+
+assertXPath(pTable,
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:sharedItems",
+"containsMixedTypes", "1");
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 5d47d628cee7..2ed98873202f 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -267,6 +267,9 @@ void XclExpXmlPivotCaches::SavePivotCacheXml(
XclExpXmlStream& rStrm, const Entr
for (; it != itEnd; ++it)
{
ScDPItemData::Type eType = it->GetType();
+// tdf#123939 : error and string are same for cache; if both are
present, keep only one
+if (eType == ScDPItemData::Error)
+eType = ScDPItemData::String;
aDPTypes.insert(eType);
if (eType == ScDPItemData::Value)
{
@@ -292,8 +295,8 @@ void XclExpXmlPivotCaches::SavePivotCacheXml(
XclExpXmlStream& rStrm, const Entr
std::set aDPTypesWithoutBlank = aDPTypes;
aDPTypesWithoutBlank.erase(ScDPItemData::Empty);
-bool isContainsString =
aDPTypesWithoutBlank.find(ScDPItemData::String) != aDPTypesWithoutBlank.end() ||
-aDPTypesWithoutBlank.find(ScDPItemData::Error)
!= aDPTypesWithoutBlank.end();
+const bool isContainsString
+= aDPTypesWithoutBlank.find(ScDPItemData::String) !=
aDPTypesWithoutBlank.end();
bool isContainsBlank = aDPTypes.find(ScDPItemData::Empty) !=
aDPTypeEnd;
bool isContainsNumber = !isContainsDate &&
aDPTypesWithoutBlank.find(ScDPItemData::Value) != aDPTypesWithoutBlank.end();
bool isContainsNonDate = !(isContainsDate &&
aDPTypesWithoutBlank.size() <= 1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124000] FILEOPEN DOCX Last row of OLE object table is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=124000 --- Comment #4 from Dieter Praas --- (In reply to Durgapriyanka from comment #3) > Thank you for reporting the bug. The OLE object table doesn't open in my > writer. The table is empty with a blinking border line on the left side. I get the same result. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7f767f6886c46f2ace34ab3e169ebf6ffc2b20a Author: LibreOfficiant AuthorDate: Mon Mar 11 16:37:55 2019 +0100 Commit: Gerrit Code Review CommitDate: Mon Mar 11 20:12:13 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Compiler error due to incorrect indentation Change-Id: I041f9ac5d160ef2ebb23e77ce3d35f02e3b703e4 Reviewed-on: https://gerrit.libreoffice.org/69053 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 496aaf8cbcd0..669ede5358fc 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 496aaf8cbcd030c1ddfbc3776c23edd08307b96e +Subproject commit 669ede5358fc7aa63420bd61b62548f2d0b54519 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/python/python_import.xhp | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
New commits:
commit 669ede5358fc7aa63420bd61b62548f2d0b54519
Author: LibreOfficiant
AuthorDate: Mon Mar 11 16:37:55 2019 +0100
Commit: Olivier Hallot
CommitDate: Mon Mar 11 20:12:13 2019 +0100
Compiler error due to incorrect indentation
Change-Id: I041f9ac5d160ef2ebb23e77ce3d35f02e3b703e4
Reviewed-on: https://gerrit.libreoffice.org/69053
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/source/text/sbasic/python/python_import.xhp
b/source/text/sbasic/python/python_import.xhp
index 3ac240d87..43ec28107 100644
--- a/source/text/sbasic/python/python_import.xhp
+++ b/source/text/sbasic/python/python_import.xhp
@@ -85,24 +85,24 @@
adapted from
Bibliothèque de fonctions by Hubert Lambert
at
https://forum.openoffice.org/fr/forum/viewtopic.php?p=286213
-def
isImportedModule(module_name: str) - bool:
-
Check run time module list
-return
(module_name in sys.modules.keys())
-def
isLoadedLibrary(lib_name: str) - bool:
-
Check PYTHON_PATH content
-return
(lib_name in sys.path)
-def
loadLibrary(lib_name: str, module_name=None):
-
add directory to PYTHON_PATH, import named module
-doc =
XSCRIPTCONTEXT.getDocument()
-url =
uno.fileUrlToSystemPath(
-
{}/{}.format(doc.URL,Scripts/python/+lib_name)
-if not url in
sys.path:
-
sys.path.insert(0, url)
-if
module_name and not module_name in sys.modules.keys():
-return
zipimport.zipimporter(url).load_module(module_name)
-def
unloadLibrary(lib_name: str):
-
remove directory from PYTHON_PATH
-
sys.path.remove(lib_name)
+def
isImportedModule(module_name: str) - bool:
+
Check run time module list
+return
(module_name in sys.modules.keys())
+def
isLoadedLibrary(lib_name: str) - bool:
+
Check PYTHON_PATH content
+return
(lib_name in sys.path)
+def
loadLibrary(lib_name: str, module_name=None):
+
add directory to PYTHON_PATH, import named module
+doc =
XSCRIPTCONTEXT.getDocument()
+url =
uno.fileUrlToSystemPath(
+
{}/{}.format(doc.URL,Scripts/python/+lib_name)
+if not
url in sys.path:
+
sys.path.insert(0, url)
+if
module_name and not module_name in sys.modules.keys():
+
return zipimport.zipimporter(url).load_module(module_name)
+def
unloadLibrary(lib_name: str):
+
remove directory from PYTHON_PATH
+
sys.path.remove(lib_name)
g_exportedScripts
= (OnDocPostOpenLoadPython, OnDocQueryCloseUnloadPython)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123961] FILEOPEN: Loading multi-page TIFF files would hang Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=123961 --- Comment #8 from Dieter Praas --- Franklin, are you sure, that the attachment in comment 2 contains a multi-page TIFF (I can't check that)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61566] Text toolbars should have two rows
https://bugs.documentfoundation.org/show_bug.cgi?id=61566 Dave Close changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED --- Comment #2 from Dave Close --- I appreciate that this ticket was still active after six years (!) and I'd still love a real solution. But I've never heard of the Notebookbar and, apparently, neither has my current LibreOffice installation. Entering that term to search the help does not find any reference. I'm running Fedora's "Build ID" 6.1.5.2-2.fc29. Where can I learn about the Notebookbar? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103239 Bug 103239 depends on bug 61566, which changed state. Bug 61566 Summary: Text toolbars should have two rows https://bugs.documentfoundation.org/show_bug.cgi?id=61566 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/build loleaflet/js loleaflet/Makefile.am loleaflet/src scripts/unocommands.py
loleaflet/Makefile.am |6 +-
loleaflet/build/deps.js |6 ++
scripts/unocommands.py |2 +-
3 files changed, 8 insertions(+), 6 deletions(-)
New commits:
commit c1ba96f951661ee047af9fabe20ce00a1527acfe
Author: Henry Castro
AuthorDate: Mon Mar 11 14:27:47 2019 -0400
Commit: Henry Castro
CommitDate: Mon Mar 11 14:51:56 2019 -0400
loleaflet: move toolbar.js to src/control directory
Simplify building loleaflet.
TODO. Convert to L.Control.Toolbar
Change-Id: I6abedd19caa6f0c22267c661e67480507dcd8336
diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index d21a104d0..e64869516 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -309,7 +309,6 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_DST) \
$(builddir)/dist/global.js \
$(builddir)/dist/jquery.mCustomScrollbar.js \
$(builddir)/dist/w2ui-1.5.rc1.js \
- $(builddir)/dist/toolbar.js \
$(builddir)/dist/main.js
@touch $@
else
@@ -337,7 +336,6 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(builddir)/dist/global.js \
$(srcdir)/js/jquery.mCustomScrollbar.js \
$(srcdir)/js/w2ui-1.5.rc1.js \
- $(srcdir)/js/toolbar.js \
$(srcdir)/js/main.js
@echo "Uglify loleaflet js files..."
NODE_PATH=$(abs_builddir)/node_modules $(NODE)
node_modules/uglify-js/bin/uglifyjs \
@@ -346,7 +344,6 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(srcdir)/js/jquery.mCustomScrollbar.js \
$(srcdir)/js/w2ui-1.5.rc1.js \
$(builddir)/build/dist/loleaflet-src.js \
- $(srcdir)/js/toolbar.js \
$(srcdir)/js/main.js \
--output $@
endif
@@ -366,7 +363,6 @@ $(builddir)/dist/loleaflet.html:
$(srcdir)/html/loleaflet.html.m4 $(LOLEAFLET_HT
jquery.mCustomScrollbar.js \
w2ui-1.5.rc1.js \
$(call LOLEAFLET_JS,$(srcdir)/build/build.js) \
- toolbar.js \
main.js)" \
$(srcdir)/html/loleaflet.html.m4 > $@
@@ -448,7 +444,7 @@ pot:
admin/src/AdminSocketOverview.js \
admin/src/AdminSocketSettings.js \
admin/src/Util.js \
- js/toolbar.js \
+ scr/control/toolbar.js \
src/control/Control.AlertDialog.js \
src/control/Control.ContextMenu.js \
src/control/Control.DocumentRepair.js \
diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index ec9c8565a..c1247ab54 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -291,6 +291,12 @@ var deps = {
desc: 'Makes markers draggable (by mouse or touch).'
},
+ ControlToolbar: {
+ src: ['control/toolbar.js'],
+ heading: 'Controls',
+ desc: 'LibreOffice Online toolbar'
+ },
+
ControlPartsPreview: {
src: ['control/Control.js',
'control/Control.PartsPreview.js'],
diff --git a/loleaflet/js/toolbar.js b/loleaflet/src/control/toolbar.js
similarity index 100%
rename from loleaflet/js/toolbar.js
rename to loleaflet/src/control/toolbar.js
diff --git a/scripts/unocommands.py b/scripts/unocommands.py
index 27fca0d84..df29ef8e5 100755
--- a/scripts/unocommands.py
+++ b/scripts/unocommands.py
@@ -122,7 +122,7 @@ def extractToolbarCommands(path):
commands = []
# extract from the menu specifications
-f = open(path + '/loleaflet/js/toolbar.js', 'r')
+f = open(path + '/loleaflet/src/control/toolbar.js', 'r')
for line in f:
if line.find("_UNO(") >= 0:
commands += commandFromMenuLine(line)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120161] PRINTING, PDF Export: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 --- Comment #22 from Oliver Brinzing --- seems to be fixed with my dev build: Version: 6.3.0.0.alpha0+ (x64) Build ID: 11ea5fe055ed345154138c814e38e54c6624ee89 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded https://gerrit.libreoffice.org/plugins/gitiles/core/+log/11ea5fe055ed345154138c814e38e54c6624ee89 can this fix be backported to lo 6.1.6? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING, PDF Export: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 Oliver Brinzing changed: What|Removed |Added CC||s...@abma.de --- Comment #21 from Oliver Brinzing --- *** Bug 124001 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124001] file -> print -> selected area doesn't print selected area
https://bugs.documentfoundation.org/show_bug.cgi?id=124001 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Oliver Brinzing --- i think this issue is a duplicate of: PRINTING, PDF Export: Problem with selected cells which cross pages https://bugs.documentfoundation.org/show_bug.cgi?id=120161 *** This bug has been marked as a duplicate of bug 120161 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/dyncastvisibility.cxx |4 ++--
compilerplugins/clang/simplifyconstruct.cxx |4 ++--
compilerplugins/clang/stringstatic.cxx |5 ++---
compilerplugins/clang/weakobject.cxx|5 ++---
4 files changed, 8 insertions(+), 10 deletions(-)
New commits:
commit a62ad33b0eb1dac70f91a409d11ac1bcdb624842
Author: Luboš Luňák
AuthorDate: Tue Mar 5 16:15:22 2019 +0100
Commit: Noel Grandin
CommitDate: Mon Mar 11 19:44:33 2019 +0100
change some clang plugins to FilteringPlugins
As far as I can tell these do not need to scan everything, so the filtering
(and faster) base plugin is sufficient.
Change-Id: I0912a730bb5ec9670d1faa5c83f573902118cc95
Reviewed-on: https://gerrit.libreoffice.org/68872
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/dyncastvisibility.cxx
b/compilerplugins/clang/dyncastvisibility.cxx
index 6a1d84d91d3e..8b29f0735ca9 100644
--- a/compilerplugins/clang/dyncastvisibility.cxx
+++ b/compilerplugins/clang/dyncastvisibility.cxx
@@ -79,11 +79,11 @@ StringRef vis(Visibility v) {
}
class DynCastVisibility final:
-public RecursiveASTVisitor, public loplugin::Plugin
+public loplugin::FilteringPlugin
{
public:
explicit DynCastVisibility(loplugin::InstantiationData const & data):
-Plugin(data) {}
+FilteringPlugin(data) {}
bool shouldVisitTemplateInstantiations() const { return true; }
diff --git a/compilerplugins/clang/simplifyconstruct.cxx
b/compilerplugins/clang/simplifyconstruct.cxx
index 172a1bd48029..b48764302eae 100644
--- a/compilerplugins/clang/simplifyconstruct.cxx
+++ b/compilerplugins/clang/simplifyconstruct.cxx
@@ -18,11 +18,11 @@
namespace
{
-class SimplifyConstruct : public RecursiveASTVisitor,
public loplugin::Plugin
+class SimplifyConstruct : public loplugin::FilteringPlugin
{
public:
explicit SimplifyConstruct(loplugin::InstantiationData const& data)
-: Plugin(data)
+: FilteringPlugin(data)
{
}
diff --git a/compilerplugins/clang/stringstatic.cxx
b/compilerplugins/clang/stringstatic.cxx
index 7fa14c0766c7..1a46fdd3dee8 100644
--- a/compilerplugins/clang/stringstatic.cxx
+++ b/compilerplugins/clang/stringstatic.cxx
@@ -22,13 +22,12 @@
namespace {
class StringStatic
-: public clang::RecursiveASTVisitor
-, public loplugin::Plugin
+: public loplugin::FilteringPlugin
{
public:
explicit StringStatic(loplugin::InstantiationData const& rData):
-Plugin(rData) {}
+FilteringPlugin(rData) {}
void run() override;
bool VisitVarDecl(VarDecl const*);
diff --git a/compilerplugins/clang/weakobject.cxx
b/compilerplugins/clang/weakobject.cxx
index 70e81baa411a..1f801d6acdd2 100644
--- a/compilerplugins/clang/weakobject.cxx
+++ b/compilerplugins/clang/weakobject.cxx
@@ -19,12 +19,11 @@
namespace {
class WeakObject
-: public clang::RecursiveASTVisitor
-, public loplugin::Plugin
+: public loplugin::FilteringPlugin
{
public:
-explicit WeakObject(loplugin::InstantiationData const& rData):
Plugin(rData)
+explicit WeakObject(loplugin::InstantiationData const& rData):
FilteringPlugin(rData)
{}
void run() override {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124001] file -> print -> selected area doesn't print selected area
https://bugs.documentfoundation.org/show_bug.cgi?id=124001 --- Comment #3 from Matthias --- did you select "selected cells" in the print area? all cells shown in the print dialog preview IMHO is an error, too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123960 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123960 [Bug 123960] Conflicting shortcuts in Sheet menu of Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123960] Conflicting shortcuts in Sheet menu of Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=123960 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||98259 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Shortcut Alt+R doesn't link to any action in Calc. I looked in 6.1, 6.2 and current master. Alt+S shows menu because it is accesibility action for menu Sheet. I think you have had your own keyboard shortcuts for Calc earlier. Now you can add any shortcuts as you want from dialog Customize (Tools->Customize, tab Keyboard) This looks as NOTABUG Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123983] REad Error if embedded images are not into the Pictures directory
https://bugs.documentfoundation.org/show_bug.cgi?id=123983 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #12 from Oliver Brinzing --- this seems to have started with the rework of the image handling, e.g. http://document-foundation-mail-archive.969070.n3.nabble.com/API-CHANGE-dropping-string-properties-which-use-vnd-sun-star-GraphicObject-URL-td4235349.html i remember, there was an issue some month ago about the same problem: a file generated via webservice with images in root instead of images folder. unfortunately i cannot find the issue at the moment ... IMHO a picture in root (or any other folder) should work if href/path in content.xml/manifest.xml is correct. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123999] time change causes the return of "parameter index out of range... using mysql and J/connector
https://bugs.documentfoundation.org/show_bug.cgi?id=123999 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #8 from Julien Nabet --- Dan: would it be possible you create a minimum testcase with embedded hsqldb so it could be easily and quickly reproduceable? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123996] Libreoffice Calc cannot set cell's background color
https://bugs.documentfoundation.org/show_bug.cgi?id=123996 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug is present. I can move the colored cells to other column, but couldn't completely change the color of the background. Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113333] [META] EPS (Encapsulated PostScript) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=11 Bug 11 depends on bug 124005, which changed state. Bug 124005 Summary: LibreOffice Draw can’t open specific EPS image https://bugs.documentfoundation.org/show_bug.cgi?id=124005 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67464] Request for built-in EPS rendering ...
https://bugs.documentfoundation.org/show_bug.cgi?id=67464 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4005 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113333] [META] EPS (Encapsulated PostScript) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=11 V Stuart Foote changed: What|Removed |Added Depends on||124005 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124005 [Bug 124005] LibreOffice Draw can’t open specific EPS image -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124005] LibreOffice Draw can’t open specific EPS image
https://bugs.documentfoundation.org/show_bug.cgi?id=124005 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu Blocks||11 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||464 Status|UNCONFIRMED |RESOLVED --- Comment #2 from V Stuart Foote --- No native support for EPS, that is bug 67464 and Windows users need to install the appropriate helper programs. ghostscript http://downloads.ghostscript.com/public/ pstoedit http://sourceforge.net/projects/pstoedit/ Imagemagick http://www.imagemagick.org/download/ The TIFF preview will show if you have ghostscript Helper on your Windows box. Getting the vector image to install requires pstoedit to be present. But probably better to do the conversion to EMF or SVG external to LO. *** This bug has been marked as a duplicate of bug 80036 *** Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=11 [Bug 11] [META] EPS (Encapsulated PostScript) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80036] FILEOPEN: EPS picture doesn't appear in slides
https://bugs.documentfoundation.org/show_bug.cgi?id=80036 V Stuart Foote changed: What|Removed |Added CC||shanshandehongxing@outlook. ||com --- Comment #4 from V Stuart Foote --- *** Bug 124005 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/txtnode/txatbase.cxx | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
New commits:
commit 99f25bc344e931e66366e20664a23dc263fe3113
Author: Miklos Vajna
AuthorDate: Mon Mar 11 16:11:03 2019 +0100
Commit: Miklos Vajna
CommitDate: Mon Mar 11 19:28:53 2019 +0100
sw doc model xml dump: show text node's field hints
Change-Id: I17927231da389ce54d2fb8ade0091c7e7033a808
Reviewed-on: https://gerrit.libreoffice.org/69049
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/source/core/txtnode/txatbase.cxx
b/sw/source/core/txtnode/txatbase.cxx
index 82015ad57df2..8497116f1d7f 100644
--- a/sw/source/core/txtnode/txatbase.cxx
+++ b/sw/source/core/txtnode/txatbase.cxx
@@ -122,6 +122,11 @@ void SwTextAttr::dumpAsXml(xmlTextWriterPtr pWriter) const
pWhich = "meta";
break;
}
+case RES_TXTATR_FIELD:
+{
+pWhich = "field";
+break;
+}
default:
break;
}
@@ -129,8 +134,17 @@ void SwTextAttr::dumpAsXml(xmlTextWriterPtr pWriter) const
xmlTextWriterWriteAttribute(pWriter, BAD_CAST("which"),
BAD_CAST(pWhich));
if (oValue)
xmlTextWriterWriteAttribute(pWriter, BAD_CAST("value"),
BAD_CAST(oValue->getStr()));
-if (Which() == RES_TXTATR_AUTOFMT)
-GetAutoFormat().dumpAsXml(pWriter);
+switch (Which())
+{
+case RES_TXTATR_AUTOFMT:
+GetAutoFormat().dumpAsXml(pWriter);
+break;
+case RES_TXTATR_FIELD:
+GetFormatField().dumpAsXml(pWriter);
+break;
+default:
+break;
+}
xmlTextWriterEndElement(pWriter);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114039] [META] Field dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114039 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123967 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123967 [Bug 123967] Reference of Input Field (Variables) cannot be edited after creation; edit box for Reference in fact changes the fields' string -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123967] Reference of Input Field (Variables) cannot be edited after creation; edit box for Reference in fact changes the fields' string
https://bugs.documentfoundation.org/show_bug.cgi?id=123967 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||114039 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114039 [Bug 114039] [META] Field dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124000] FILEOPEN DOCX Last row of OLE object table is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=124000 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. The OLE object table doesn't open in my writer. The table is empty with a blinking border line on the left side. But, the table does open in MS Word. Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 --- Comment #5 from Oliver Brinzing --- (In reply to Heiko Tietze from comment #4) > You set cell protection first via Edit > Cell Protection (applied to > selection, on by default) and enable it subsequently per Tools > Protect > Sheet... Admittedly a bit weird but the function itself is working well. i know, but the way excel does it in case of copy and paste protected cells into an unprotected area (while the sheet is protected) is much more intuitiv, cause the user is able to edit the copied range later. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 123974] Paste into a protected Calc sheet should not paste the cell Protected status
https://bugs.documentfoundation.org/show_bug.cgi?id=123974 --- Comment #5 from Oliver Brinzing --- (In reply to Heiko Tietze from comment #4) > You set cell protection first via Edit > Cell Protection (applied to > selection, on by default) and enable it subsequently per Tools > Protect > Sheet... Admittedly a bit weird but the function itself is working well. i know, but the way excel does it in case of copy and paste protected cells into an unprotected area (while the sheet is protected) is much more intuitiv, cause the user is able to edit the copied range later. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 123969] VIEWING zoom 100% really 91%
https://bugs.documentfoundation.org/show_bug.cgi?id=123969 Nick Levinson changed: What|Removed |Added Status|RESOLVED|REOPENED Ever confirmed|0 |1 Resolution|NOTABUG |--- --- Comment #2 from Nick Levinson --- That makes sense, and I haven't seen a problem with the printouts and the horizontal ruler (my setup has no vertical ruler) seems to have the same effect as the canvas. However, LO is for use by people of whom many are not computer geeks and who therefore would expect something akin to real-life experience. They won't look in help, because they expect a computer to just work. The other zoom settings can be unrealistic as long as they're approximate and proportionate. But, to a lay person, 100% has to mean 100%. I'll set the status to reopen, but if this reason (common user expectation) is not good enough, then set it back and I'll leave it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 123395, which changed state. Bug 123395 Summary: NAVIGATOR, "copy outline to clipboard" should be available in context menu https://bugs.documentfoundation.org/show_bug.cgi?id=123395 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/strings.hrc |1 +
sw/source/uibase/inc/swcont.hxx|2 +-
sw/source/uibase/utlui/content.cxx | 15 +--
3 files changed, 15 insertions(+), 3 deletions(-)
New commits:
commit 9ccdb944a6bfde317febbf7cfc37ae8e6e6df8c9
Author: Wenzhe Pei
AuthorDate: Mon Mar 11 01:25:52 2019 +
Commit: Michael Stahl
CommitDate: Mon Mar 11 19:07:19 2019 +0100
tdf#123395 Add "Send Outline to Clipboard" to Navigator->Context menu
Change-Id: Ice8f6a99e437e99c7e169e230e034a04f42eea0d
Reviewed-on: https://gerrit.libreoffice.org/69026
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index 2093a2d8c14f..fe4ab39acd33 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -621,6 +621,7 @@
#define STR_ACCESS_TL_CONTENT NC_("STR_ACCESS_TL_CONTENT",
"Content Navigation View")
#define STR_OUTLINE_LEVEL NC_("STR_OUTLINE_LEVEL",
"Outline Level")
#define STR_DRAGMODENC_("STR_DRAGMODE", "Drag
Mode")
+#define STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY
NC_("STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY", "Send Outline to Clipboard")
#define STR_HYPERLINK NC_("STR_HYPERLINK", "Insert
as Hyperlink")
#define STR_LINK_REGION NC_("STR_LINK_REGION", "Insert
as Link")
#define STR_COPY_REGION NC_("STR_COPY_REGION", "Insert
as Copy")
diff --git a/sw/source/uibase/inc/swcont.hxx b/sw/source/uibase/inc/swcont.hxx
index 3d0aaf69a113..f116935d2edf 100644
--- a/sw/source/uibase/inc/swcont.hxx
+++ b/sw/source/uibase/inc/swcont.hxx
@@ -44,7 +44,7 @@ enum class ContentTypeId
};
// strings for context menus
-#define CONTEXT_COUNT 12
+#define CONTEXT_COUNT 13
#define GLOBAL_CONTEXT_COUNT 14
// modes for Drag 'n Drop
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 9d27cd0ef02f..a59152b00210 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -828,7 +828,8 @@ enum STR_CONTEXT_IDX
IDX_STR_ACTIVE = 8,
IDX_STR_INACTIVE = 9,
IDX_STR_EDIT_ENTRY = 10,
-IDX_STR_DELETE_ENTRY = 11
+IDX_STR_DELETE_ENTRY = 11,
+IDX_STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY = 12
};
static const char* STR_CONTEXT_ARY[] =
@@ -844,7 +845,8 @@ static const char* STR_CONTEXT_ARY[] =
STR_ACTIVE,
STR_INACTIVE,
STR_EDIT_ENTRY,
-STR_DELETE_ENTRY
+STR_DELETE_ENTRY,
+STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY
};
SwContentTree::SwContentTree(vcl::Window* pParent, SwNavigationPI* pDialog)
@@ -1316,6 +1318,10 @@ VclPtr SwContentTree::CreateContextMenu()
{
assert(dynamic_cast(static_cast(pEntry->GetUserData(;
SwContentType* pType =
static_cast(pEntry->GetUserData());
+if(ContentTypeId::OUTLINE == pType->GetType())
+{
+pPop->InsertItem(700,
m_aContextStrings[IDX_STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY]);
+}
if ( (pType->GetType() == ContentTypeId::POSTIT) &&
(!m_pActiveShell->GetView().GetDocShell()->IsReadOnly()) && (
pType->GetMemberCount() > 0) )
{
bSubPop4 = true;
@@ -3116,6 +3122,11 @@ void SwContentTree::ExecuteContextMenuAction( sal_uInt16
nSelectedPopupEntry )
m_pActiveShell->GetView().GetPostItMgr()->Delete();
break;
}
+case 700:
+{
+
m_pActiveShell->GetView().GetViewFrame()->GetDispatcher()->Execute(FN_OUTLINE_TO_CLIPBOARD);
+break;
+}
//Display
default:
if(nSelectedPopupEntry > 300 && nSelectedPopupEntry < 400)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123968] Input Field (Functions): direct editing is still used, not pop-up dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123968 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107739 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107739] [META] Field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107739 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123968 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123968 [Bug 123968] Input Field (Functions): direct editing is still used, not pop-up dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123972 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123972 [Bug 123972] UI menu disapppears before submenu can open -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123972 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123972 [Bug 123972] UI menu disapppears before submenu can open -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123972] UI menu disapppears before submenu can open
https://bugs.documentfoundation.org/show_bug.cgi?id=123972 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||101912, 85811 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=85811 [Bug 85811] [META] Main menu bar bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123980] HELP: Error on explanation for WORKDAY()
https://bugs.documentfoundation.org/show_bug.cgi?id=123980 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||120200 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120200 [Bug 120200] [META] Update or correct help for features -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features
https://bugs.documentfoundation.org/show_bug.cgi?id=120200 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123980 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123980 [Bug 123980] HELP: Error on explanation for WORKDAY() -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123984 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123984 [Bug 123984] Bad scaling of inserted video in Impress -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
