[Libreoffice-bugs] [Bug 123913] Junicode font does not retain "Bold" setting in styles settings

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123913

--- Comment #1 from mulla.tasa...@gmail.com ---
Hello

Thank you for reporting the bug. I can not reproduce the bug in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


I have saved the file as .doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123903] FILESAVE DOCX dashed and dotted line styles not saved in DOCX

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123903

--- Comment #3 from mulla.tasa...@gmail.com ---
Thank you for reporting the bug. 

I changed the style of two lines to fine dashed and ultra fine dotted.
after opening .docx file-1.style looks similar 
2.for continuous line-Line style in the properties showing continuous only
3.for other two lines(fine dashed and ultra fine dotted)-Line style in the
properties showing none

I can not reproduce the bug in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/uibase/uiview/view.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0a4249232be237a93ce92bec74780d8cee77fe5c
Author: Henry Castro 
AuthorDate: Tue Mar 19 16:17:09 2019 -0400
Commit: Henry Castro 
CommitDate: Wed Mar 20 05:21:50 2019 +0100

tdf#124162: Crash when trying to accept changes

Change-Id: If4a4034a891d6539b183f6083c0711b05ef7692d
Reviewed-on: https://gerrit.libreoffice.org/69441
Tested-by: Jenkins
Reviewed-by: Aron Budea 
(cherry picked from commit 2ac8d81a00bc9061f88dfd13a6a08873d92a5b86)
Reviewed-on: https://gerrit.libreoffice.org/69450
Reviewed-by: Henry Castro 

diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 2e048d72e617..c3a6711e6d50 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -1692,10 +1692,10 @@ void SwView::Notify( SfxBroadcaster& rBC, const 
SfxHint& rHint )
 case SfxHintId::RedlineChanged:
 {
 static sal_uInt16 const aSlotRedLine[] = {
-FN_REDLINE_NEXT_CHANGE,
-FN_REDLINE_PREV_CHANGE,
 FN_REDLINE_ACCEPT_DIRECT,
 FN_REDLINE_REJECT_DIRECT,
+FN_REDLINE_NEXT_CHANGE,
+FN_REDLINE_PREV_CHANGE,
 FN_REDLINE_ACCEPT_ALL,
 FN_REDLINE_REJECT_ALL,
 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 90657] Numbered lists in Word 6.0 wrongly imported

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90657

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104770] Scanned PDF shows hidden text

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104770

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88473] EDITING: Selection in Mode ‘Extended Selection’ Can’t be Corrected

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88473

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41900] VIEWING: Extended Tips of Status Bar are Displayed "below" the Screen

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=41900

--- Comment #14 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39068] PRINTING only first area with color formatted cells (background, border), same with PDFEXPORT

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39068

--- Comment #29 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116449] impress FILESAVE stores huge TablePreview.svm in odp file

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116449

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116419] Wrong calculation of coordinates when adding a text box to a shape

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116419

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58311] FORMATTING: Tab Causes two new Lines

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=58311

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95193] Wrong bookmarks in Impress PDF export with notes pages, notes not bookmarked but slides bookmarks doubled

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95193

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43187] EDITING - MSAccess 2007/2010 (.accdb) table data not editable/updatable - read only with 32 bit and 64bit LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43187

--- Comment #22 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124219] New: soffice won't launch because of missing symbol cairo_surface_get_device_scale

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124219

Bug ID: 124219
   Summary: soffice won't launch because of missing symbol
cairo_surface_get_device_scale
   Product: LibreOffice
   Version: 6.2.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: paul.jow...@systemic.com.au

Command:

soffice --headless

Error:
/opt/libreoffice6.2/program/soffice.bin: /lib64/libdbus-1.so.3: no version
information available (required by /opt/libreoffice6.2/program/libmergedlo.so)
/opt/libreoffice6.2/program/soffice.bin: symbol lookup error:
/opt/libreoffice6.2/program/libmergedlo.so: undefined symbol:
cairo_surface_get_device_scale

Linux (uname -a):
  Linux ip-172-30-2-127 4.14.77-70.59.amzn1.x86_64 #1 SMP Mon Nov 12 22:02:45
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Libs:
cairo.x86_641.12.14-6.8.amzn1  @amzn-main
cups.x86_64 1:1.4.2-67.21.amzn1@amzn-main
cups-libs.x86_641:1.4.2-67.21.amzn1@amzn-main
glibc.x86_642.17-222.173.amzn1 installed
glibc-common.x86_64 2.17-222.173.amzn1 installed
libXinerama.x86_64  1.1.2-2.7.amzn1@amzn-main
dbus.x86_64 1:1.6.12-14.28.amzn1   installed

In the same environment:
  Libre Office version 6.1.5.2 works
  Libre Office version 6.2.0.3 fails
  Libre Office version 6.2.1.2 fails

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61174] [META] Rework of Recent Documents List, options to prevent logging and to manage entries on the list

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61174

--- Comment #32 from Dan Dascalescu  ---
Pinning documents would be super useful as a fast way to open frequently
accessed documents. The accelerator should be a number key that will not
change, so that the user can memory Alt+F, U, 1..9.

Excel supports this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

CppunitTest_chart2_dump Unit Test Failure

2019-03-19 Thread Luke Benes
Hey Mike,
After 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=166a4989a0d1e5a6271c66bceb73a27970afc882

tdf#123504: 0 and 360 are different angles in charts

My 32-bit Windows  box is failing with the following error:

ChartDataTest::verify finished in: 2796ms
PivotChartDataButtonTest::verify finished in: 962ms
PointLineChartTest::verify finished in: 15087ms
GridTest::verify finished in: 5035ms
AxisLabelTest::verify finished in: 3948ms
AxisGeometryTest::verify finished in: 8078ms
D:/core/chart2/qa/extras/chart2dump/chart2dump.cxx:902:PieChartTest::verify
double equality assertion failed
- Expected: 3210
- Actual  : 3207
- Delta   : 0.1
- Failing test file is: pie_chart_100_and_0.ods

PieChartTest::verify finished in: 8407ms
ColumnBarChartTest::verify finished in: 10112ms
D:/core/chart2/qa/extras/chart2dump/chart2dump.cxx(902) : error : Assertion
Test name: PieChartTest::verify
double equality assertion failed
- Expected: 3210
- Actual  : 3207
- Delta   : 0.1
- Failing test file is: pie_chart_100_and_0.ods

Failures !!!
Run: 11   Failure total: 1   Failures: 1   Errors: 0

Error: a unit test failed, please do one of:
make CppunitTest_chart2_dump CPPUNITTRACE=TRUE # which is a shortcut for the 
following line
make CppunitTest_chart2_dump CPPUNITTRACE="'C:/Program Files (x86)/Microsoft 
Visual Studio/2017/Community/Common7/IDE/devenv.exe' /debugexe" # for 
interactive debugging in Visual Studio
make CppunitTest_chart2_dump CPPUNITTRACE="drmemory -free_max_frames 20" # for 
memory checking (install Dr.Memory first, and put it to your PATH)

You can limit the execution to just one particular test by:

make CppunitTest_chart2_dump CPPUNIT_TEST_NAME="testXYZ" ...above mentioned 
params...

make[1]: *** [D:/core/solenv/gbuild/CppunitTest.mk:114: 
D:/core/workdir/CppunitTest/chart2_dump.test] Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [Makefile:282: build] Error 2

Would you like any more debug info or info about my system?

Thanks

-Luke


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 122943] Opening a Style dialog's Highlighting/Area tabs adds properties to the property set in the style

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122943

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123972] UI menu disapppears before submenu can open

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123972

Nick Levinson  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Nick Levinson  ---
>From Help > About LibreOffice:

Version: 6.1.5.2

Build ID: 6.1.5.2-2.fc29

CPU threads: 2; OS: Linux 4.20; UI render: default; VCL: gtk3; 

Locale: en-US (en_US.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122329] When inputting Chinese in CODE, it would show double words instead of one with each input

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122329

--- Comment #10 from Babbles  ---
When the window size is narrowed by desktop PC, it changes to the smartphone
mode. Blue input button displayed at the bottom right.
At this time, if the user inputs Chinese characters ignoring the blue button,
this problem does not seem to occur by Chromium based browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124218] Toolbar tooltip should be placed below the mouse pointer, not beneath it.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124218

--- Comment #2 from typing...@gmail.com ---
Created attachment 150112
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150112=edit
Tooltip of Notepad++.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124218] Toolbar tooltip should be placed below the mouse pointer, not beneath it.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124218

--- Comment #1 from typing...@gmail.com ---
Created attachment 150111
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150111=edit
Tooltip of Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124218] New: Toolbar tooltip should be placed below the mouse pointer, not beneath it.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124218

Bug ID: 124218
   Summary: Toolbar tooltip should be placed below the mouse
pointer, not beneath it.
   Product: LibreOffice
   Version: 6.2.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: typing...@gmail.com

Description:
Unlike other programmes such as Notepad++, the tooltip is displayed below the
button regardless of the pointer size. If the pointer is big, then the tooltip
is obscured by the pointer. I will attach screenshots of Writer and Notepad++
for comparison.

Steps to Reproduce:
1. Place the mouse pointer on a toolbar item
2.
3.

Actual Results:
Tooltip beneath the pointer.

Expected Results:
Tooltip below the pointer.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62728] Support for PDF/A-2 (ISO 19005-2:2011)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62728

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Keywords||needsUXEval
 CC||tietze.he...@gmail.com

--- Comment #12 from Thorsten Behrens (CIB)  ---
(In reply to Cor Nouws from comment #11)
> (In reply to Thorsten Behrens (CIB) from comment #10)
> > Hmm - so I'd prefer to not clutter the PDF export dialog with even more
> from 20 to 21 is hardly more ;)
> 
I don't believe many users will be able to parse out the difference between
those two very long options, so yes I strongly believe for the average person,
keeping both would be a significantly worse UX. Even more so as A-2 is a much
better option if PDF/A is needed (but a user would probably choose randomly).

Setting ux advise keyword, and meanwhile this bug to fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 62728, which changed state.

Bug 62728 Summary: Support for PDF/A-2 (ISO 19005-2:2011)
https://bugs.documentfoundation.org/show_bug.cgi?id=62728

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119905] Infobar: text slightly overlaps the button

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119905

rptr  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |was...@zom.bi
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124202] No possible to connect to Internet sites from Calc (hyperlinks)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124202

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from m.a.riosv  ---
The link has a different text than the link, you can see the difference with
Menu/Insert/Hyperlink [Ctrl+K].

As the text it's fine cut+paste works fine because the right link it's
introduced.

Seems something in the file, because after correct and save & load the link is
incorrect, but it's fine in a file from scratch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123291] UI: Hex color input box for changing column chart node color doesn't work

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123291

--- Comment #2 from wpeat...@gmail.com ---
Reproduced in Windows on 6.1.5.2.

This affects every LibO component because they all use Format...Area dialog
box. 

Entering by hand a hex html-style color very annoying (you have to select each
character one by one and then type a replacement character). And it is
impossible to paste a hex color.

Another workaround is to click the "Pick" button and edit the hex color box in
that dialog -- it works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62728] Support for PDF/A-2 (ISO 19005-2:2011)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62728

--- Comment #11 from Cor Nouws  ---
(In reply to Thorsten Behrens (CIB) from comment #10)
> Hmm - so I'd prefer to not clutter the PDF export dialog with even more
from 20 to 21 is hardly more ;)

> options - the PDF/A-1 export is still usable via UNO, so e.g. an extension
> could provide that functionality - or perhaps changing the preset via
> advanced options dialog is acceptable for those cases?
I cannot judge that.
But would a listbox 

 Archive - none -
 PDF/A-1 ISO ..
 PDF/A-2b ISO ..
be an idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 98372] SIDEBAR: Research/Reference sidebar deck

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98372

--- Comment #17 from Keith Curtis  ---
I figured out how get a mobile view from Wiktionary, but it had just as many
sections. i.e, it will also need filtering. 

It might be possible to tell it what sections you want, but I'm not sure if
it's possible to tell it sections you *don't* want. I'll look around. If
LibreOffice knew that the word was a noun, it could request just that section
for example, and get the minimal amount of data, but that requires looking the
word up elsewhere first.

Another possibility is to get all the sections, filter out the ones LibreOffice
wouldn't want, and then request just that content. That requires more API
calls, and might not be faster, but it could be worth trying.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 98372] SIDEBAR: Research/Reference sidebar deck

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98372

--- Comment #17 from Keith Curtis  ---
I figured out how get a mobile view from Wiktionary, but it had just as many
sections. i.e, it will also need filtering. 

It might be possible to tell it what sections you want, but I'm not sure if
it's possible to tell it sections you *don't* want. I'll look around. If
LibreOffice knew that the word was a noun, it could request just that section
for example, and get the minimal amount of data, but that requires looking the
word up elsewhere first.

Another possibility is to get all the sections, filter out the ones LibreOffice
wouldn't want, and then request just that content. That requires more API
calls, and might not be faster, but it could be worth trying.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62728] Support for PDF/A-2 (ISO 19005-2:2011)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62728

--- Comment #10 from Thorsten Behrens (CIB)  ---
Hmm - so I'd prefer to not clutter the PDF export dialog with even more options
- the PDF/A-1 export is still usable via UNO, so e.g. an extension could
provide that functionality - or perhaps changing the preset via advanced
options dialog is acceptable for those cases?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/uibase/uiview/view.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2ac8d81a00bc9061f88dfd13a6a08873d92a5b86
Author: Henry Castro 
AuthorDate: Tue Mar 19 16:17:09 2019 -0400
Commit: Aron Budea 
CommitDate: Tue Mar 19 23:28:04 2019 +0100

tdf#124162: Crash when trying to accept changes

Change-Id: If4a4034a891d6539b183f6083c0711b05ef7692d
Reviewed-on: https://gerrit.libreoffice.org/69441
Tested-by: Jenkins
Reviewed-by: Aron Budea 

diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 59fc540e0d35..c48a59c22841 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -1698,10 +1698,10 @@ void SwView::Notify( SfxBroadcaster& rBC, const 
SfxHint& rHint )
 case SfxHintId::RedlineChanged:
 {
 static sal_uInt16 const aSlotRedLine[] = {
-FN_REDLINE_NEXT_CHANGE,
-FN_REDLINE_PREV_CHANGE,
 FN_REDLINE_ACCEPT_DIRECT,
 FN_REDLINE_REJECT_DIRECT,
+FN_REDLINE_NEXT_CHANGE,
+FN_REDLINE_PREV_CHANGE,
 FN_REDLINE_ACCEPT_ALL,
 FN_REDLINE_REJECT_ALL,
 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124217] New: Themes do not get correctly applied on tabbed user interface

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124217

Bug ID: 124217
   Summary: Themes do not get correctly applied on tabbed user
interface
   Product: LibreOffice
   Version: 6.2.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aerkia...@gmail.com

Description:
Firefox themes are not properly visible when user interface is tabbed.

Steps to Reproduce:
1. Go to Tools -> Options... -> LibreOffice -> Personalization
2. Select a preinstalled theme
3. Set View -> User Interface -> Tabbed

Actual Results:
The toolbar is completely white, with only two themed stripes at the top and
bottom.

Expected Results:
The whole toolbar should have the theme applied.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.2.1.2
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98372] SIDEBAR: Research/Reference sidebar deck

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98372

--- Comment #16 from Keith Curtis  ---
The wizards ship as a core feature and run in Python, why couldn't this? It is
good to use a more productive language in LibreOffice whenever possible, and a
research tab seems like a great example of something that would be good enough
in Python.

It is becoming the language of choice for neural networks, data science, etc. I
hope that LibreOffice one day will have PyTorch inside for the grammar checker,
and other places:
http://document-foundation-mail-archive.969070.n3.nabble.com/Fwd-AI-in-Microsoft-Office-td4231071.html

I wrote that code because it was an interesting little task for me. I think the
Beautiful Soup filter is a good start to taking the default output of
Wiktionary and making it reasonable enough to fit in a dialog box. There could
be other solutions such as requesting a mobile version. I might try to figure
that out next. Also, it should have an LRU cache to not hit their servers too
much. I'll put that in, as it's just one line of code ;-)

I could investigate how to create a simple UI, or figure out how to create /
update a research tab on the sidebar, but I've not done any LibreOffice UI
stuff yet. If someone else has more knowledge or time to learn, they could take
this Python and keep going. It should be possible to quickly build a very good
extension, and then people can decide what to do with it.

Thanks for the Wollmux reference. I may find their source and go through it.
Lightproof could also be another good starting point:
https://cgit.freedesktop.org/libreoffice/lightproof/tree

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 98372] SIDEBAR: Research/Reference sidebar deck

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98372

--- Comment #16 from Keith Curtis  ---
The wizards ship as a core feature and run in Python, why couldn't this? It is
good to use a more productive language in LibreOffice whenever possible, and a
research tab seems like a great example of something that would be good enough
in Python.

It is becoming the language of choice for neural networks, data science, etc. I
hope that LibreOffice one day will have PyTorch inside for the grammar checker,
and other places:
http://document-foundation-mail-archive.969070.n3.nabble.com/Fwd-AI-in-Microsoft-Office-td4231071.html

I wrote that code because it was an interesting little task for me. I think the
Beautiful Soup filter is a good start to taking the default output of
Wiktionary and making it reasonable enough to fit in a dialog box. There could
be other solutions such as requesting a mobile version. I might try to figure
that out next. Also, it should have an LRU cache to not hit their servers too
much. I'll put that in, as it's just one line of code ;-)

I could investigate how to create a simple UI, or figure out how to create /
update a research tab on the sidebar, but I've not done any LibreOffice UI
stuff yet. If someone else has more knowledge or time to learn, they could take
this Python and keep going. It should be possible to quickly build a very good
extension, and then people can decide what to do with it.

Thanks for the Wollmux reference. I may find their source and go through it.
Lightproof could also be another good starting point:
https://cgit.freedesktop.org/libreoffice/lightproof/tree

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: chart2/qa chart2/source

2019-03-19 Thread Libreoffice Gerrit user
 chart2/qa/extras/chart2dump/chart2dump.cxx |   
 3 +
 chart2/qa/extras/chart2dump/data/pie_chart_100_and_0.ods   
|binary
 chart2/qa/extras/chart2dump/reference/piecharttest/pie_chart_100_and_0.txt |   
20 ++
 chart2/source/view/main/PlottingPositionHelper.cxx |   
17 +---
 chart2/source/view/main/PolarLabelPositionHelper.cxx   |   
 8 ++--
 chart2/source/view/main/ShapeFactory.cxx   |   
11 -
 6 files changed, 46 insertions(+), 13 deletions(-)

New commits:
commit 166a4989a0d1e5a6271c66bceb73a27970afc882
Author: Mike Kaganski 
AuthorDate: Tue Mar 19 21:27:20 2019 +0300
Commit: Mike Kaganski 
CommitDate: Tue Mar 19 22:28:59 2019 +0100

tdf#123504: 0 and 360 are different angles in charts

This partly reverts commit 81302f33073e7629d724ed269f1fa21dad29e141.

Change-Id: I40cbe739eb4497b8217aca56a2c3661ed1e491f4
Reviewed-on: https://gerrit.libreoffice.org/69440
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index 030fb92e9918..4e91eeb9aa96 100644
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -855,7 +855,8 @@ DECLARE_DUMP_TEST(PieChartTest, Chart2DumpTest, false)
 "rotated_pie_chart.ods",
 "exploded_pie_chart.ods",
 "donut_chart.ods",
-"pie_chart_many_slices.ods"
+"pie_chart_many_slices.ods",
+"pie_chart_100_and_0.ods",
 };
 
 for (const OUString& sTestFile : aTestFiles)
diff --git a/chart2/qa/extras/chart2dump/data/pie_chart_100_and_0.ods 
b/chart2/qa/extras/chart2dump/data/pie_chart_100_and_0.ods
new file mode 100644
index ..a6ff5d6aa0e1
Binary files /dev/null and 
b/chart2/qa/extras/chart2dump/data/pie_chart_100_and_0.ods differ
diff --git 
a/chart2/qa/extras/chart2dump/reference/piecharttest/pie_chart_100_and_0.txt 
b/chart2/qa/extras/chart2dump/reference/piecharttest/pie_chart_100_and_0.txt
new file mode 100644
index ..40db143f4881
--- /dev/null
+++ b/chart2/qa/extras/chart2dump/reference/piecharttest/pie_chart_100_and_0.txt
@@ -0,0 +1,20 @@
+// nSeriesCount
+1
+/// Series 0 slices
+// nSlicesCountInSeries
+1
+/// /D=0:CS=0:CT=0:Series=0:Point=0
+// aSlicePosition.X
+3210
+// aSlicePosition.Y
+180
+// aSliceSize.Height
+8639
+// aSliceSize.Width
+8639
+// aSliceTransformation
+8639;0;3210;0;8639;180;0;0;1
+// static_cast(aSliceFillStyle)
+1
+// static_cast(aSliceFillColor)
+17798
\ No newline at end of file
diff --git a/chart2/source/view/main/PlottingPositionHelper.cxx 
b/chart2/source/view/main/PlottingPositionHelper.cxx
index 2382894e383a..c2c2d25b4c9c 100644
--- a/chart2/source/view/main/PlottingPositionHelper.cxx
+++ b/chart2/source/view/main/PlottingPositionHelper.cxx
@@ -32,7 +32,6 @@
 #include 
 
 #include 
-#include 
 
 namespace chart
 {
@@ -417,10 +416,11 @@ double PolarPlottingPositionHelper::getWidthAngleDegree( 
double& fStartLogicValu
 && !::rtl::math::approxEqual( fStartLogicValueOnAngleAxis, 
fEndLogicValueOnAngleAxis ) )
 fWidthAngleDegree = 360.0;
 
-while(fWidthAngleDegree<0.0)
-fWidthAngleDegree+=360.0;
-while(fWidthAngleDegree>360.0)
-fWidthAngleDegree-=360.0;
+// tdf#123504: both 0 and 360 are valid and different values here!
+while (fWidthAngleDegree < 0.0)
+fWidthAngleDegree += 360.0;
+while (fWidthAngleDegree > 360.0)
+fWidthAngleDegree -= 360.0;
 
 return fWidthAngleDegree;
 }
@@ -473,7 +473,12 @@ double 
PolarPlottingPositionHelper::transformToAngleDegree( double fLogicValueOn
 fRet = m_fAngleDegreeOffset
   + 
fAxisAngleScaleDirection*(fScaledLogicAngleValue-MinAngleValue)*360.0
 /fabs(MaxAngleValue-MinAngleValue);
-return NormAngle360(fRet);
+// tdf#123504: both 0 and 360 are valid and different values here!
+while (fRet > 360.0)
+fRet -= 360.0;
+while (fRet < 0)
+fRet += 360.0;
+return fRet;
 }
 
 /**
diff --git a/chart2/source/view/main/PolarLabelPositionHelper.cxx 
b/chart2/source/view/main/PolarLabelPositionHelper.cxx
index 6cea12f672cc..a3e9a7cd9778 100644
--- a/chart2/source/view/main/PolarLabelPositionHelper.cxx
+++ b/chart2/source/view/main/PolarLabelPositionHelper.cxx
@@ -24,8 +24,6 @@
 
 #include 
 
-#include 
-
 namespace chart
 {
 using namespace ::com::sun::star;
@@ -123,7 +121,11 @@ awt::Point 
PolarLabelPositionHelper::getLabelScreenPositionAndAlignmentForUnitCi
 //set LabelAlignment
 if( !bCenter )
 {
-fAngleDegree = NormAngle360(fAngleDegree);
+// tdf#123504: both 0 and 360 are valid and different values here!
+while (fAngleDegree > 360.0)
+fAngleDegree -= 360.0;
+while (fAngleDegree < 0.0)
+fAngleDegree += 360.0;
 
 bool 

[Libreoffice-bugs] [Bug 123991] Conflicts with the paper size defined in LO Writer 6.2.0 and 6.2.1, as "Oficio". Spanish version.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123991

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 CC||fit...@ubuntu.com,
   ||serval2...@yahoo.fr
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #2 from Julien Nabet  ---
Adolfo/Xisco: the pb was in translation here:
https://translations.documentfoundation.org/es/libo_ui/translate/#search=Oficio=source,target,notes=137293311=0
I put "Legal" instead of "Oficio".

I didn't find other branches than master for this one but perhaps missed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123020] Migration to Firebird db fails on "unknown token isc_dsql_prepare"

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123020

--- Comment #21 from Thomas Nilefalk  ---
I'm now at 6.2.1 and an attempted migration gives a completely empty error
dialog, "more" gives "SQL-status: invalid map key"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: readlicense_oo/license

2019-03-19 Thread Libreoffice Gerrit user
 readlicense_oo/license/license.xml |5 -
 1 file changed, 5 deletions(-)

New commits:
commit 711109008bd2a13bc5db2fed35de53d02af2dd3d
Author: Andras Timar 
AuthorDate: Tue Mar 19 16:34:59 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 19 22:20:41 2019 +0100

license: MySQL Connector/C++ is not included in LibreOffice

Change-Id: I047b9d06c0dbcdd2cbbd1a6363ead7f734f3a832
Reviewed-on: https://gerrit.libreoffice.org/69433
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index bc0d7f6c9f35..5c1bff921860 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -1125,11 +1125,6 @@
 limitation or exclusion may not apply to you because your country may not 
allow the exclusion or limitation of
 incidental, consequential or other damages.
 
-MySQL Connector/C++
-The following software may be included in this product:
-MySQL Connector/C++. Use of any of this software is governed by the terms 
of the license below:
-Copyright 2007-2008 MySQL AB, 2008-2009 Sun Microsystems Inc.
-Jump to GPL Version 2
 
 MyThes
 The following software may be included in this product: MyThes. Use 
of any of this software is governed by
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

2019-03-19 Thread Libreoffice Gerrit user
 readlicense_oo/license/license.xml |4 
 1 file changed, 4 deletions(-)

New commits:
commit ca3dd85719917783db8314574ab177192220662a
Author: Andras Timar 
AuthorDate: Tue Mar 19 16:34:08 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 19 22:20:24 2019 +0100

license: Mozilla is not included in LibreOffice

Change-Id: I103ffea5329aee1bac9dd983cb0a68f2f118d36e
Reviewed-on: https://gerrit.libreoffice.org/69432
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 6161d1fd5373..bc0d7f6c9f35 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -1125,10 +1125,6 @@
 limitation or exclusion may not apply to you because your country may not 
allow the exclusion or limitation of
 incidental, consequential or other damages.
 
-Mozilla
-The following software may be included in this product: Mozilla, 
Mozilla Address Book, NP SDK. Use of any of
-this software is governed by the terms of the license below:
-Jump to MPL 1.1
 MySQL Connector/C++
 The following software may be included in this product:
 MySQL Connector/C++. Use of any of this software is governed by the terms 
of the license below:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

2019-03-19 Thread Libreoffice Gerrit user
 readlicense_oo/license/license.xml |   78 -
 1 file changed, 78 deletions(-)

New commits:
commit 16f6db350138b6ae717e7b062d980dda09a8d3d6
Author: Andras Timar 
AuthorDate: Tue Mar 19 16:32:12 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 19 22:20:03 2019 +0100

license: GNU ISO C++ library is not included in LibreOffice

Change-Id: Ie612956aa6765d5afb76cddf7a6ce24b582f05fc
Reviewed-on: https://gerrit.libreoffice.org/69431
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index f4888e38c727..6161d1fd5373 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -239,84 +239,6 @@
 Robert Wilhelm
 Werner Lemberg
 
-GNU ISO C++ Library
-The following software may be included in this product: GNU ISO C++ 
Library. Use of any of this software is
-governed by the terms of the license below:
-© Free Software Foundation, Inc.
-Jump to GPL Version 2
-Additional License(s)
- 
-libstdc++:
-// Explicit instantiation file.
- 
-// Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002
-// Free Software Foundation, Inc.
-//
-// This file is part of the GNU ISO C++ Library.  This library is 
free
-// software; you can redistribute it and/or modify it under the
-// terms of the GNU General Public License as published by the
-// Free Software Foundation; either version 2, or (at your option)
-// any later version.
- 
-// This library is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
- 
-// You should have received a copy of the GNU General Public License 
along
-// with this library; see the file COPYING.  If not, write to the 
Free
-// Software Foundation, 59 Temple Place - Suite 330, Boston, MA
-02111-1307,
-// USA.
- 
-// As a special exception, you may use this file as part of a free
-software
-// library without restriction.  Specifically, if other files 
instantiate
-// templates or use macros or inline functions from this file, or 
you
-compile
-// this file and link it with other files to produce an executable, 
this
-// file does not by itself cause the resulting executable to be covered 
by
-// the GNU General Public License.  This exception does not however
-// invalidate any other reasons why the executable file might be
-covered by
-// the GNU General Public License.
- 
-libgcc:
-//
-// ISO C++ 14882:
-//
- 
-/* Copyright (C) 2001, 2002 Free Software Foundation, Inc.
-   Contributed by Jakub Jelinek .
- 
-   This file is part of GNU CC.
- 
-   GNU CC is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published 
by
-   the Free Software Foundation; either version 2, or (at your 
option)
-   any later version.
- 
-   GNU CC is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
- 
-   You should have received a copy of the GNU General Public License
-   along with GNU CC; see the file COPYING.  If not, write to
-   the Free Software Foundation, 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
- 
-/* As a special exception, if you link this library with other 
files,
-   some of which are compiled with GCC, to produce an executable,
-   this library does not by itself cause the resulting executable
-   to be covered by the GNU General Public License.
-   This exception does not however invalidate any other reasons why
-   the executable file might be covered by the GNU General Public
-License.  */
- 
-/* Locate the FDE entry for a given address, using PT_GNU_EH_FRAME 
ELF
-   segment and dl_iterate_phdr to avoid register/deregister calls at
-   DSO load/unload.  */
 
 Firebird
 The applicable and approved licenses for the source files of the 
Firebird RDBMS project are:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

2019-03-19 Thread Libreoffice Gerrit user
 readlicense_oo/license/license.xml |4 
 1 file changed, 4 deletions(-)

New commits:
commit 93801e9f43eeabb21abe1c50b39ded4db18ce963
Author: Andras Timar 
AuthorDate: Tue Mar 19 16:31:15 2019 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 19 22:19:46 2019 +0100

license: Xalan is not included in LibreOffice

Change-Id: I9a85b767bdfb916f9da4e0c310ee3cdc642ebf4d
Reviewed-on: https://gerrit.libreoffice.org/69430
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/readlicense_oo/license/license.xml 
b/readlicense_oo/license/license.xml
index 4d52da8bd26f..f4888e38c727 100644
--- a/readlicense_oo/license/license.xml
+++ b/readlicense_oo/license/license.xml
@@ -1815,10 +1815,6 @@
 AND FITNESS, IN NO EVENT SHALL SuSE BE LIABLE FOR ANY SPECIAL, INDIRECT OR 
CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN 
ACTION OF CONTRACT, NEGLIGENCE OR OTHER
 TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR 
PERFORMANCE OF THIS SOFTWARE.
-Xalan
-The following software may be included in this product: Xalan. Use of 
any of this software is governed by the
-terms of the license below:
-Jump to Apache License Version 
2.0
 
 XML Security Library (xmlsec)
 The following software may be included in this product: XML 
Security Library (xmlsec). Use of any of this
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/ui/fldui/fldpage.cxx |   30 --
 sw/source/ui/fldui/fldpage.hxx |   13 +++--
 2 files changed, 3 insertions(+), 40 deletions(-)

New commits:
commit 9d294b08a891f02f4e33bec0bf7d44d013abfa5e
Author: Caolán McNamara 
AuthorDate: Tue Mar 19 15:36:08 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 19 22:19:08 2019 +0100

more newly unused functions

Change-Id: Id89fb1104bdcfd1c14842b5c6641466c83f2f995
Reviewed-on: https://gerrit.libreoffice.org/69434
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/fldui/fldpage.cxx b/sw/source/ui/fldui/fldpage.cxx
index 2894bb908048..787c33f29728 100644
--- a/sw/source/ui/fldui/fldpage.cxx
+++ b/sw/source/ui/fldui/fldpage.cxx
@@ -281,16 +281,6 @@ void SwFieldPage::InsertField(sal_uInt16 nTypeId, 
sal_uInt16 nSubType, const OUS
 }
 }
 
-void SwFieldPage::SavePos( const ListBox* pLst1 )
-{
-if( pLst1 && pLst1->GetEntryCount() )
-m_aLstStrArr[ 0 ] = pLst1->GetSelectedEntry();
-else
-m_aLstStrArr[ 0 ].clear();
-m_aLstStrArr[ 1 ].clear();
-m_aLstStrArr[ 2 ].clear();
-}
-
 void SwFieldPage::SavePos( const weld::TreeView& rLst1 )
 {
 if (rLst1.n_children())
@@ -301,15 +291,6 @@ void SwFieldPage::SavePos( const weld::TreeView& rLst1 )
 m_aLstStrArr[ 2 ].clear();
 }
 
-void SwFieldPage::RestorePos(ListBox* pLst1)
-{
-sal_Int32 nPos = 0;
-if( pLst1 && pLst1->GetEntryCount() && !m_aLstStrArr[ 0 ].isEmpty() &&
- LISTBOX_ENTRY_NOTFOUND !=
-( nPos = pLst1->GetEntryPos(m_aLstStrArr[ 0 ] ) ) )
-pLst1->SelectEntryPos( nPos );
-}
-
 void SwFieldPage::RestorePos(weld::TreeView& rLst1)
 {
 sal_Int32 nPos = 0;
@@ -319,17 +300,6 @@ void SwFieldPage::RestorePos(weld::TreeView& rLst1)
 }
 
 // Insert new fields
-IMPL_LINK( SwFieldPage, TreeListBoxInsertHdl, SvTreeListBox*, pBtn, bool )
-{
-InsertHdl(pBtn);
-return false;
-}
-
-IMPL_LINK( SwFieldPage, ListBoxInsertHdl, ListBox&, rBox, void )
-{
-InsertHdl();
-}
-
 IMPL_LINK( SwFieldPage, TreeViewInsertHdl, weld::TreeView&, rBox, void )
 {
 InsertHdl();
diff --git a/sw/source/ui/fldui/fldpage.hxx b/sw/source/ui/fldui/fldpage.hxx
index a2720cb918ae..3ac09fc7cc46 100644
--- a/sw/source/ui/fldui/fldpage.hxx
+++ b/sw/source/ui/fldui/fldpage.hxx
@@ -24,15 +24,12 @@
 
 #define FIELD_COLUMN_WIDTH 76
 
-class ListBox;
-class SvTreeListBox;
-
 const int coLBCount = 3;
 
 class SwFieldPage : public SfxTabPage
 {
 OUStringm_aLstStrArr[ coLBCount ];
-SwFieldMgrm_aMgr;
+SwFieldMgr  m_aMgr;
 SwField *m_pCurField;
 SwWrtShell* m_pWrtShell;
 sal_Int32   m_nTypeSel;
@@ -54,22 +51,18 @@ protected:
 SwField*GetCurField()   { return m_pCurField;}
 SwWrtShell* GetWrtShell() { return m_pWrtShell;}
 
-DECL_LINK( ListBoxInsertHdl, ListBox&, void );
 DECL_LINK( TreeViewInsertHdl, weld::TreeView&, void );
-DECL_LINK( TreeListBoxInsertHdl, SvTreeListBox*, bool );
 DECL_LINK( NumFormatHdl, weld::TreeView&, void );
 voidInsertHdl(void *);
 
 voidInit();
-voidSavePos( const ListBox* pLst1);
 voidSavePos( const weld::TreeView& rLst1);
-voidRestorePos( ListBox* pLst1 );
 voidRestorePos( weld::TreeView& rLst1 );
 voidEnableInsert(bool bEnable);
-bool IsFieldEdit() const   { return m_bFieldEdit; }
+boolIsFieldEdit() const   { return m_bFieldEdit; }
 
 // insert field
-voidInsertField(  sal_uInt16 nTypeId,
+voidInsertField(sal_uInt16 nTypeId,
 sal_uInt16 nSubType,
 const OUString& rPar1,
 const OUString& rPar2,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extras/source include/vcl solenv/bin solenv/sanitizers sw/source sw/uiconfig vcl/source vcl/unx

2019-03-19 Thread Libreoffice Gerrit user
 extras/source/glade/libreoffice-catalog.xml.in |   12 
 include/vcl/weld.hxx   |1 
 solenv/bin/native-code.py  |3 
 solenv/sanitizers/ui/modules/swriter.suppr |2 
 sw/source/ui/fldui/fldvar.cxx  |  693 ++---
 sw/source/ui/fldui/fldvar.hxx  |   70 --
 sw/source/uibase/inc/condedit.hxx  |1 
 sw/source/uibase/inc/numfmtlb.hxx  |4 
 sw/uiconfig/swriter/ui/fldvarpage.ui   |6 
 vcl/source/app/salvtables.cxx  |5 
 vcl/unx/gtk3/gtk3gtkinst.cxx   |9 
 11 files changed, 351 insertions(+), 455 deletions(-)

New commits:
commit b1249cea2e99873605332de888d03f163cba0128
Author: Caolán McNamara 
AuthorDate: Tue Mar 19 15:43:51 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 19 22:17:40 2019 +0100

weld SwFieldVarPage

Change-Id: Ifd71cbb4c3ed3baa33136c5b86c042144faa5002
Reviewed-on: https://gerrit.libreoffice.org/69435
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index 020f29f1b5ca..41c1d9425d24 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -300,18 +300,10 @@
 generic-name="URLBox" parent="svtlo-SvtURLBox"
 icon-name="widget-gtk-comboboxtext"/>
 
-
-
 
 
-
-
 
@@ -358,10 +350,6 @@
 generic-name="Cursor Reference Edit" 
parent="foruilo-RefEdit"
 icon-name="widget-gtk-textentry"/>
 
-
-
 
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 910f977db66c..96f292c4d695 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -937,6 +937,7 @@ public:
 // nEndPos can be -1 in order to select all text
 virtual void select_region(int nStartPos, int nEndPos) = 0;
 virtual bool get_selection_bounds(int& rStartPos, int& rEndPos) = 0;
+virtual void replace_selection(const OUString& rText) = 0;
 // nCursorPos can be -1 to set to the end
 virtual void set_position(int nCursorPos) = 0;
 virtual int get_position() const = 0;
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 8c93cd1f081f..ac7a1fc3c34e 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -430,7 +430,6 @@ custom_widgets = [
 'ClassificationEditView',
 'ColorConfigCtrl',
 'ColumnEdit',
-'ConditionEdit',
 'ContentListBox',
 'ContextVBox',
 'CustomAnimationList',
@@ -453,7 +452,6 @@ custom_widgets = [
 'LookUpComboBox',
 'ManagedMenuButton',
 'MultiLineEditSyntaxHighlight',
-'NumFormatListBox',
 'OFileURLControl',
 'OptionalBox',
 'PageNumberListBox',
@@ -482,7 +480,6 @@ custom_widgets = [
 'SdPageObjsTLB',
 'SearchBox',
 'SearchResultsBox',
-'SelectionListBox',
 'SentenceEditWindow',
 'ShowNupOrderWindow',
 'ShowNupOrderWindow',
diff --git a/solenv/sanitizers/ui/modules/swriter.suppr 
b/solenv/sanitizers/ui/modules/swriter.suppr
index e92034ca2521..ecd5d213813e 100644
--- a/solenv/sanitizers/ui/modules/swriter.suppr
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -72,7 +72,7 @@ sw/uiconfig/swriter/ui/fldrefpage.ui://GtkLabel[@id='label4'] 
orphan-label
 sw/uiconfig/swriter/ui/fldvarpage.ui://GtkLabel[@id='nameft'] orphan-label
 sw/uiconfig/swriter/ui/fldvarpage.ui://GtkEntry[@id='name'] no-labelled-by
 sw/uiconfig/swriter/ui/fldvarpage.ui://GtkLabel[@id='valueft'] orphan-label
-sw/uiconfig/swriter/ui/fldvarpage.ui://swlo-ConditionEdit[@id='value'] 
no-labelled-by
+sw/uiconfig/swriter/ui/fldvarpage.ui://GtkEntry[@id='value'] no-labelled-by
 sw/uiconfig/swriter/ui/fldvarpage.ui://GtkLabel[@id='label5'] orphan-label
 sw/uiconfig/swriter/ui/fldvarpage.ui://GtkComboBoxText[@id='level'] 
no-labelled-by
 sw/uiconfig/swriter/ui/floatingnavigation.ui://GtkLabel[@id='label'] 
orphan-label
diff --git a/sw/source/ui/fldui/fldvar.cxx b/sw/source/ui/fldui/fldvar.cxx
index ce303e37dab6..05599ab2fd55 100644
--- a/sw/source/ui/fldui/fldvar.cxx
+++ b/sw/source/ui/fldui/fldvar.cxx
@@ -40,52 +40,47 @@
 #define USER_DATA_VERSION_1 "1"
 #define USER_DATA_VERSION USER_DATA_VERSION_1
 
-SwFieldVarPage::SwFieldVarPage(vcl::Window* pParent, const SfxItemSet *const 
pCoreSet )
-: SwFieldPage(pParent, "FieldVarPage",
-"modules/swriter/ui/fldvarpage.ui", pCoreSet)
+SwFieldVarPage::SwFieldVarPage(TabPageParent pParent, const SfxItemSet *const 
pCoreSet )
+: SwFieldPage(pParent, "modules/swriter/ui/fldvarpage.ui", "FieldVarPage", 
pCoreSet)
+, m_xTypeLB(m_xBuilder->weld_tree_view("type"))
+, m_xSelection(m_xBuilder->weld_widget("selectframe"))
+, m_xSelectionLB(m_xBuilder->weld_tree_view("select"))
+, 

[Libreoffice-commits] core.git: sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/ui/fldui/fldpage.cxx |   15 ---
 sw/source/ui/fldui/fldpage.hxx |2 --
 2 files changed, 17 deletions(-)

New commits:
commit 2c76763e8f050dce96aafdba4307fc9b38ad06f7
Author: Caolán McNamara 
AuthorDate: Tue Mar 19 15:33:14 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 19 22:17:55 2019 +0100

drop now unused SwFieldPage ctor

Change-Id: Iffba830b1eb3406661f110e8124b317d7f417858
Reviewed-on: https://gerrit.libreoffice.org/69429
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/fldui/fldpage.cxx b/sw/source/ui/fldui/fldpage.cxx
index 1fccc557c39b..2894bb908048 100644
--- a/sw/source/ui/fldui/fldpage.cxx
+++ b/sw/source/ui/fldui/fldpage.cxx
@@ -42,21 +42,6 @@
 using namespace ::com::sun::star;
 
 // note: pAttrSet may be null if the dialog is restored on startup
-SwFieldPage::SwFieldPage(vcl::Window *pParent, const OString& rID,
-const OUString& rUIXMLDescription, const SfxItemSet *const pAttrSet)
-: SfxTabPage(pParent, rID, rUIXMLDescription, pAttrSet)
-, m_pCurField(nullptr)
-, m_pWrtShell(nullptr)
-, m_nTypeSel(LISTBOX_ENTRY_NOTFOUND)
-, m_nSelectionSel(LISTBOX_ENTRY_NOTFOUND)
-, m_bFieldEdit(false)
-, m_bInsert(true)
-, m_bFieldDlgHtmlMode(false)
-, m_bRefresh(false)
-, m_bFirstHTMLInit(true)
-{
-}
-
 SwFieldPage::SwFieldPage(TabPageParent pParent, const OUString& 
rUIXMLDescription,
 const OString& rID, const SfxItemSet *pAttrSet)
 : SfxTabPage(pParent, rUIXMLDescription, rID, pAttrSet)
diff --git a/sw/source/ui/fldui/fldpage.hxx b/sw/source/ui/fldui/fldpage.hxx
index e640d409d7e2..a2720cb918ae 100644
--- a/sw/source/ui/fldui/fldpage.hxx
+++ b/sw/source/ui/fldui/fldpage.hxx
@@ -80,8 +80,6 @@ protected:
 using SfxTabPage::ActivatePage;
 
 public:
-SwFieldPage(vcl::Window *pParent, const OString& rID,
-const OUString& rUIXMLDescription, const SfxItemSet *pAttrSet);
 SwFieldPage(TabPageParent pParent, const OUString& rUIXMLDescription,
 const OString& rID, const SfxItemSet *pAttrSet);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

2019-03-19 Thread Libreoffice Gerrit user
 vcl/unx/kde4/KDEXLib.cxx |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

New commits:
commit ad313992da1cf89f5825a4d1eb020392b5e32c6d
Author: Stephan Bergmann 
AuthorDate: Tue Mar 19 17:29:53 2019 +0100
Commit: Michael Weghorn 
CommitDate: Tue Mar 19 21:54:01 2019 +0100

rhbz#1687589: KDE4 gpoll_wrapper can be called with SolarMutex unlocked

...when called from MountOperation::Mount 
(ucb/source/ucp/gio/gio_content.cxx),
which itself contains a SolarMutexReleaser since
2eb36dc4b846ab5886ae71fd2978b56b2a2d1d08 "Hack to not leave SolarMutex 
released
after g_main_loop_run call".  So calling SolarMutexReleaser ctor in
gpoll_wrapper will then cause comphelper::GenericSolarMutex::doRelease
(comphelper/source/misc/solarmutex.cxx) to call std::abort() because the
SolarMutex is not locked.

Change-Id: If893b427e404cf3d9e48430f84cff7d32b61bf87
Reviewed-on: https://gerrit.libreoffice.org/69436
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/unx/kde4/KDEXLib.cxx b/vcl/unx/kde4/KDEXLib.cxx
index 0852c543a6d7..22274690842b 100644
--- a/vcl/unx/kde4/KDEXLib.cxx
+++ b/vcl/unx/kde4/KDEXLib.cxx
@@ -210,8 +210,15 @@ static GPollFunc old_gpoll = nullptr;
 
 static gint gpoll_wrapper( GPollFD* ufds, guint nfds, gint timeout )
 {
-SolarMutexReleaser aReleaser;
-return old_gpoll( ufds, nfds, timeout );
+if (GetSalData()->m_pInstance->GetYieldMutex()->IsCurrentThread())
+{
+SolarMutexReleaser aReleaser;
+return old_gpoll( ufds, nfds, timeout );
+}
+else
+{
+return old_gpoll( ufds, nfds, timeout );
+}
 }
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123504] Impress fails to render donut and pie charts with 100 and 0 entries in only column

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123504

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #3 from Mike Kaganski  ---
https://gerrit.libreoffice.org/69440

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124216] Format fonts dialog, modify dialog: buttons doesn't work

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124216

--- Comment #1 from João  ---
Its impossible to change the formula font type.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124216] New: Format fonts dialog, modify dialog: buttons doesn't work

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124216

Bug ID: 124216
   Summary: Format fonts dialog, modify dialog: buttons doesn't
work
   Product: LibreOffice
   Version: 6.2.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joaoarc...@gmail.com

Created attachment 150110
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150110=edit
DIALO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124162] Crash when trying to accept changes

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124162

Henry Castro  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |hcas...@collabora.com
   |desktop.org |

--- Comment #13 from Henry Castro  ---
Aron,

I can reproduce it, working...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124162] Crash when trying to accept changes

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124162

Aron Budea  changed:

   What|Removed |Added

 CC||hcas...@collabora.com
 Status|UNCONFIRMED |NEW
 Blocks||105537
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1977

--- Comment #12 from Aron Budea  ---
In Linux I get an assertion failure in a debug build, with the same message as
Tor's in comment 7 (no crash otherwise). Interestingly there's no assertion if
the button is clicked in the Manage Changes dialog.

The menu item was added in the following commit, but I don't know what the
difference might be compared to the button. Henry, does the assert ring any
bells to you?
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2db44bd017daac8f668393bca24911e95125857a
author  Henry Castro 2017-11-04 12:18:53
-0400
committer   Henry Castro 2017-11-08 04:28:01
+0100

sw lok: add Accept/Reject All tracked changes, tdf#101977


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101977] TRACK CHANGES: More uno commands for accepting/rejecting changes

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101977

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4162

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Aron Budea  changed:

   What|Removed |Added

 Depends on||124162


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124162
[Bug 124162] Crash when trying to accept changes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2019-03-19 Thread Libreoffice Gerrit user
 source/text/sbasic/shared/03103350.xhp |1 
 source/text/sbasic/shared/03120102.xhp |  109 -
 2 files changed, 55 insertions(+), 55 deletions(-)

New commits:
commit 2434e43c17b0a4f6f47e1cb46909c9b1a4c6dda5
Author: Olivier Hallot 
AuthorDate: Mon Mar 18 10:50:20 2019 -0300
Commit: Olivier Hallot 
CommitDate: Tue Mar 19 20:33:57 2019 +0100

Inform pogrammer on VBA and LO Basic differences

Some Basic functions, like chr(), have the same name as in
VBA but VBA chr() function does not accept arguments above 255.

Change-Id: If66fec8216b824281287dfd34413584d6c2468a3
Reviewed-on: https://gerrit.libreoffice.org/69388
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/03103350.xhp 
b/source/text/sbasic/shared/03103350.xhp
index 80f3f0a9c..c22b91fb4 100644
--- a/source/text/sbasic/shared/03103350.xhp
+++ b/source/text/sbasic/shared/03103350.xhp
@@ -40,6 +40,7 @@
 
 The 
support for VBA is not complete, but covers a large portion of the common usage 
patterns.
 
+When VBA support is enabled, %PRODUCTNAME 
Basic functions arguments and return values are the same as their VBA functions 
counterparts. When the support is disabled, %PRODUCTNAME Basic functions may 
accept arguments and return values different of their VBA 
counterparts.
 
 Option VBASupport {1|0}
 
diff --git a/source/text/sbasic/shared/03120102.xhp 
b/source/text/sbasic/shared/03120102.xhp
index 484b2ec28..d6e56fdcb 100644
--- a/source/text/sbasic/shared/03120102.xhp
+++ b/source/text/sbasic/shared/03120102.xhp
@@ -1,69 +1,68 @@
 
 
-
+
 
-
-  
-Chr Function
-/text/sbasic/shared/03120102.xhp
-  
-
+
+
+Chr Function
+/text/sbasic/shared/03120102.xhp
+
+
 
-
+
+
+
+Chr function
+
+Chr Function
+Returns the character that corresponds to the specified 
character code.
+
 
+
 
-
-
-  Chr function
-
+Chr(Expression 
As Integer)
 
+
+String
 
-Chr 
Function
-Returns the 
character that corresponds to the specified character code.
-
+
+ 
Expression: a numeric expression that represent a valid 8 bit 
ASCII value (0-255) or a 16 bit Unicode value.
 
-Syntax:
-
-Chr(Expression 
As Integer)
-
+When VBA compatibility mode is enabled 
(OPTION 
VBASUPPORT 1), Expression is a numeric expression 
that represent a valid 8 bit ASCII value (0-255) only.
 
-Return 
value:
-String
+Use the 
Chr$ function to send special control sequences to a printer or to 
another output source. You can also use it to insert quotation marks in a 
string expression.
+
+
+, when VBA compatibility mode is 
enabled and expression is greater than 255.
 
-Parameters:
- 
Expression: Numeric variables that represent a valid 8 bit ASCII 
value (0-255) or a 16 bit Unicode value.
-Use the 
Chr$ function to send special control sequences to a printer or to 
another output source. You can also use it to insert quotation marks in a 
string expression.
-
-
+
+
+Sub ExampleChr
+' 
This example inserts quotation marks (ASCII value 34) in a string.
+
MsgBox "A "+ Chr$(34)+"short" + Chr$(34)+" trip."
+' 
The printout appears in the dialog as: A "short" trip.
+End Sub
+
 
-Example:
-
-Sub ExampleChr
-' This 
example inserts quotation marks (ASCII value 34) in a string.
-MsgBox "A "+ 
Chr$(34)+"short" + Chr$(34)+" trip."
-' The 
printout appears in the dialog as: A "short" trip.
-End Sub
-
-
-
-ASC
-
+
+ASC
+
 
 
-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2019-03-19 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 531a331ed2d5d8aa75002b271e8c90d108e55388
Author: Olivier Hallot 
AuthorDate: Mon Mar 18 10:50:20 2019 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Mar 19 20:33:57 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Inform pogrammer on VBA and LO Basic differences

Some Basic functions, like chr(), have the same name as in
VBA but VBA chr() function does not accept arguments above 255.

Change-Id: If66fec8216b824281287dfd34413584d6c2468a3
Reviewed-on: https://gerrit.libreoffice.org/69388
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 86716b1007ce..2434e43c17b0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 86716b1007ce47795e7e888908b540e034945172
+Subproject commit 2434e43c17b0a4f6f47e1cb46909c9b1a4c6dda5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2019-03-19 Thread Libreoffice Gerrit user
 vcl/inc/qt5/Qt5Menu.hxx |1 +
 vcl/qt5/Qt5Menu.cxx |6 ++
 2 files changed, 7 insertions(+)

New commits:
commit 612650147cb85e52d317142d022db99a28c0d98a
Author: Katarina Behrens 
AuthorDate: Fri Mar 15 23:29:55 2019 +0100
Commit: Katarina Behrens 
CommitDate: Tue Mar 19 20:33:03 2019 +0100

tdf#123379: implement native menu bar toggle on/off

qt5 didn't provide implementation of virtual SalMenu::ShowMenuBar
so native menu bar was visible at all times. Hopefully notebookbar
fans are happier now

Change-Id: Ie581397521369160e16f40231bade40100dcd6f6
Reviewed-on: https://gerrit.libreoffice.org/69327
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index adac6f6ccdad..b8a451657372 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -54,6 +54,7 @@ public:
 virtual void SetSubMenu(SalMenuItem* pSalMenuItem, SalMenu* pSubMenu, 
unsigned nPos) override;
 virtual void SetFrame(const SalFrame* pFrame) override;
 const Qt5Frame* GetFrame() const;
+virtual void ShowMenuBar(bool bVisible) override;
 Qt5Menu* GetTopLevel();
 virtual void SetItemBits(unsigned nPos, MenuItemBits nBits) override;
 virtual void CheckItem(unsigned nPos, bool bCheck) override;
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 4fdebe00f226..6112a7aa4e6c 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -544,6 +544,12 @@ Qt5Menu* Qt5Menu::GetTopLevel()
 return pMenu;
 }
 
+void Qt5Menu::ShowMenuBar(bool bVisible)
+{
+if (mpQMenuBar && (bVisible != mpQMenuBar->isVisible()))
+bVisible ? mpQMenuBar->show() : mpQMenuBar->hide();
+}
+
 const Qt5Frame* Qt5Menu::GetFrame() const
 {
 SolarMutexGuard aGuard;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124162] Crash when trying to accept changes

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124162

--- Comment #11 from Aron Budea  ---
Created attachment 150109
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150109=edit
Pre-edited sample

Attaching a pre-edited sample, the changes only need to be accepted via Edit ->
Track Changes -> Accept all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

How to write a unit test for dragging an adjust handle

2019-03-19 Thread Regina Henschel

Hi all,

it is about bug https://bugs.documentfoundation.org/show_bug.cgi?id=124212
Adjustment handle reacts wrongly, if custom shape has a non default viewBox
A fix is in https://gerrit.libreoffice.org/69439

But I have no idea how to make a unit test for it. Perhaps you?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 84830] Status bar’s Page Layout icons have no tooltips

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84830

--- Comment #7 from SuMullen  ---
 You have to engage with the https://awriter.org/topessaywriting-org-review/
audience. Too many sites, can overload and overwhelm yourself. So, there is no
need in using them all. However, there is a need to get your art out there.
Pick a few social sites and galleries. Get to know them. Test them to see how
they work for you and what kind of time you have to devote to them. If they are
working, stick with them. If you have more time, try a few more. 
Quit living by the seat of your pants.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95385] Sidebar : category General does not exist and inconsistent with cell formatting dialog

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95385

Vaibhav Rastogi  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |vaibh...@iitbhilai.ac.in
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124212] Adjustment handle reacts wrongly, if custom shape has a non default viewBox

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124212

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
   Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124215] New: Fontwork in Presentation mode not to crisp (bit fuzzy like a low res image) (non-openGL)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124215

Bug ID: 124215
   Summary: Fontwork in Presentation mode not to crisp (bit fuzzy
like a low res image) (non-openGL)
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Fontwork in Presentation mode not to crisp (bit fuzzy like a low res image)

Steps to Reproduce:
1. Open the attached file
2. Press F5

Actual Results:
Fuzzy look. Especially in non-OpenGL mode. It's better with, but still bit off 

Expected Results:
Fontwork should be sharp an crisp


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: bbf9b65f91e8136fa1a2e17960944b8720f5d58e
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-15_09:56:33
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124214] Fuzzy rendering of a FontWork after some stressing

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124214

--- Comment #1 from Telesto  ---
Created attachment 150108
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150108=edit
Screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124214] New: Fuzzy rendering of a FontWork after some stressing

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124214

Bug ID: 124214
   Summary: Fuzzy rendering of a FontWork after some stressing
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Fuzzy rendering of a FontWork after some stressing

Steps to Reproduce:
Fiddling around with Fontwork. No clue about the exact cause.. 

Actual Results:
Fuzzy fontwork; after some edit back to normal

Expected Results:
Crisp rendering


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: bbf9b65f91e8136fa1a2e17960944b8720f5d58e
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-15_09:56:33
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120697] Calc: Drop-down on 'Sum' button

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120697

Vaibhav Rastogi  changed:

   What|Removed |Added

   Assignee|vaibh...@iitbhilai.ac.in|libreoffice-b...@lists.free
   ||desktop.org
 CC||vaibh...@iitbhilai.ac.in

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124188] Image resizing

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124188

--- Comment #3 from amadorgil...@gmail.com ---
Thanks for the responses.

I have opened in safe mode, and the problem remained, but what I have not found
is that this version of libreoffice acts differently from what I am used to.

In previous versions, once I made a change to either the width or height of an
image with the "Keep ratio" box chosen, the other parameter would automatically
change as I entered the new dimension.

With this version, the other parameter only changes if I click or tab away from
the dimension I am changing.

This happens whether I am in safe mode or not.

I hope my explanation is clear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120697] Calc: Drop-down on 'Sum' button

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120697

Vaibhav Rastogi  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |vaibh...@iitbhilai.ac.in
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124030] libreoffice crashes, when selecting a MTRANS generated range

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124030

--- Comment #9 from NoRa  ---
Hi,

I'm sorry.

I've loaded the last daily build
LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_archive. I can't reproduce the error
with this version.

With version
Version: 6.2.1.2
Build-ID: 6.2.1-1
CPU-Threads: 8; BS: Linux 4.19; UI-Render: Standard; VCL: kde5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded

I got this error prompt:

qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 1266, resource
id: 25166447, major code: 40 (TranslateCoords), minor code: 0

So forget it, the bug will be solved in 6.3.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124211] Crash when pasting a sheet containing a 3D object

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124211

--- Comment #1 from Telesto  ---
Appears to be happening with templates too

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124213] New: A recovered document has "(Remote)" in the title

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124213

Bug ID: 124213
   Summary: A recovered document has "(Remote)" in the title
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
A recovered document has "(Remote)" in the title

Steps to Reproduce:
1. Open a new Writer document
2. Kill the proces tree in the ask manager
3. Restart LibreOffice & click restore/start
4. Notice "(Remote)"

Actual Results:
Shows remote

Expected Results:
Probably not.. not sure what it would mean


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: bbf9b65f91e8136fa1a2e17960944b8720f5d58e
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-15_09:56:33
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124212] Adjustment handle reacts wrongly, if custom shape has a non default viewBox

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124212

--- Comment #2 from Regina Henschel  ---
Created attachment 150107
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150107=edit
mirrored custom shape with XY handle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124212] Adjustment handle reacts wrongly, if custom shape has a non default viewBox

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124212

--- Comment #1 from Regina Henschel  ---
Created attachment 150106
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150106=edit
Custom shape with XY handle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124212] New: Adjustment handle reacts wrongly, if custom shape has a non default viewBox

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124212

Bug ID: 124212
   Summary: Adjustment handle reacts wrongly, if custom shape has
a non default viewBox
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 150105
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150105=edit
custom shape with polar handle

Open the attached documents and follow the instruction.

If you click the adjustment handle to move it, the position will jump to a
wrong place.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124211] New: Crash when pasting a sheet containing a 3D object

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124211

Bug ID: 124211
   Summary: Crash when pasting a sheet containing a 3D object
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Crash when pasting a sheet containing a 3D object

Steps to Reproduce:
1. Open Impress (Empty sheet; ignore template)
2. Insert a 3D object (cube)
3. Copy sheet in Slides panel (CTRL+C)
4. Press CTRL+V -> Crash

Actual Results:
Crash

Expected Results:
No crash


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: bbf9b65f91e8136fa1a2e17960944b8720f5d58e
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-15_09:56:33
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43808
Bug 43808 depends on bug 116404, which changed state.

Bug 116404 Summary: In Writer, when writing a new RTL document with locale 
defined as Hebrew and saving as docx the styles are saved as LTR
https://bugs.documentfoundation.org/show_bug.cgi?id=116404

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104520
Bug 104520 depends on bug 116404, which changed state.

Bug 116404 Summary: In Writer, when writing a new RTL document with locale 
defined as Hebrew and saving as docx the styles are saved as LTR
https://bugs.documentfoundation.org/show_bug.cgi?id=116404

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/CppunitTest_sw_uiwriter.mk sw/qa sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/CppunitTest_sw_uiwriter.mk   |1 
 sw/qa/extras/uiwriter/uiwriter2.cxx |   39 
 sw/source/filter/ww8/wrtw8sty.cxx   |6 -
 3 files changed, 41 insertions(+), 5 deletions(-)

New commits:
commit daa4aef1512eb7a6b615720725a5a682b0030f8e
Author: Justin Luth 
AuthorDate: Mon Feb 25 22:19:18 2019 +0300
Commit: Justin Luth 
CommitDate: Tue Mar 19 19:23:10 2019 +0100

try2 tdf#116404 filter\ww8: use bidi for default style in RTL locale

This reverts commit 06742182e5306d6d06e3253981723a69a3c978ab
and implements the same thing without altering the original document.
Thanks Miklos for pointing out that shortcoming.

Change-Id: I0eca9a730853f97251bc2a1cb1ee4128acf31c1f
Reviewed-on: https://gerrit.libreoffice.org/68358
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/CppunitTest_sw_uiwriter.mk b/sw/CppunitTest_sw_uiwriter.mk
index 3ca0a664d52e..eaf0b0d15a17 100644
--- a/sw/CppunitTest_sw_uiwriter.mk
+++ b/sw/CppunitTest_sw_uiwriter.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_uiwriter, \
 cppu \
 cppuhelper \
 editeng \
+i18nlangtag \
 msword \
 sal \
 sfx \
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 70d002897c9b..28217c7a3281 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -13,6 +13,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -57,6 +58,7 @@ public:
 void testUnfloatButton();
 void testUnfloatButtonReadOnlyMode();
 void testUnfloating();
+void testRTLparaStyle_LocaleArabic();
 void testTdf122893();
 void testTdf122901();
 void testTdf122942();
@@ -84,6 +86,7 @@ public:
 CPPUNIT_TEST(testUnfloatButton);
 CPPUNIT_TEST(testUnfloatButtonReadOnlyMode);
 CPPUNIT_TEST(testUnfloating);
+CPPUNIT_TEST(testRTLparaStyle_LocaleArabic);
 CPPUNIT_TEST(testTdf122893);
 CPPUNIT_TEST(testTdf122901);
 CPPUNIT_TEST(testTdf122942);
@@ -96,6 +99,24 @@ public:
 CPPUNIT_TEST(testMixedFormFieldInsertion);
 CPPUNIT_TEST_SUITE_END();
 
+virtual std::unique_ptr preTest(const char* filename) override
+{
+m_aSavedSettings = Application::GetSettings();
+if (OString(filename).indexOf("LocaleArabic") != -1)
+{
+std::unique_ptr pResetter(
+new Resetter([this]() { 
Application::SetSettings(this->m_aSavedSettings); }));
+AllSettings aSettings(m_aSavedSettings);
+aSettings.SetLanguageTag(LanguageTag("ar"));
+Application::SetSettings(aSettings);
+return pResetter;
+}
+return nullptr;
+}
+
+protected:
+AllSettings m_aSavedSettings;
+
 private:
 SwDoc* createDoc(const char* pName = nullptr);
 };
@@ -727,6 +748,24 @@ void SwUiWriterTest2::testUnfloating()
 }
 }
 
+void SwUiWriterTest2::testRTLparaStyle_LocaleArabic()
+{
+// New documents, created in RTL locales, were not round-tripping the 
paragraph style as RTL.
+// Set the locale to "ar" for this test - see preTest() at the top of this 
file.
+std::unique_ptr const pChanges(preTest("LocaleArabic"));
+
+createDoc(); // new, empty doc - everything defaults to RTL with Arabic 
locale
+
+// Save it and load it back.
+reload("Office Open XML Text", "tdf116404_paraStyleFrameDir.docx");
+
+uno::Reference xPageStyle(
+getStyles("ParagraphStyles")->getByName("Default Style"), 
uno::UNO_QUERY_THROW);
+// Test the text Direction value for the -none- based paragraph styles
+CPPUNIT_ASSERT_EQUAL_MESSAGE("RTL Writing Mode", sal_Int32(1),
+ getProperty(xPageStyle, 
"WritingMode"));
+}
+
 void SwUiWriterTest2::testTdf122893()
 {
 load(DATA_DIRECTORY, "tdf105413.fodt");
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index 7a3afc42ebd5..eb0cd1dc664d 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -43,7 +43,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -469,6 +468,7 @@ void MSWordStyles::SetStyleDefaults( const SwFormat& 
rFormat, bool bPap )
 {
 aFlags[ static_cast< sal_uInt16 >(RES_PARATR_WIDOWS) - 
RES_CHRATR_BEGIN ] = true;
 aFlags[ static_cast< sal_uInt16 >(RES_PARATR_HYPHENZONE) - 
RES_CHRATR_BEGIN ] = true;
+aFlags[ static_cast< sal_uInt16 >(RES_FRAMEDIR) - RES_CHRATR_BEGIN ] = 
true;
 }
 else
 {
@@ -598,10 +598,6 @@ void MSWordStyles::OutputStyle( SwFormat* pFormat, 
sal_uInt16 nPos )
 {
 assert( pFormat->GetPoolFormatId() == RES_POOLCOLL_STANDARD );
 aName = "Normal";
-
-// force bidi property to be SET, so that it exports an 
appropriate locale value
-if ( SfxItemState::SET != pFormat->GetItemState(RES_FRAMEDIR, 
false) )
-

[Libreoffice-bugs] [Bug 124189] FORMCONTROLS: Add "bottom" or "underline" as border option

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124189

--- Comment #4 from peterpqa  ---
My issue is how the form looks when printed out, as well as on-screen. A
printed 3D-look text box form control looks the same as flat-border, still
visually distracting and confusing. Please see my updated examples attachment.
Underlined text in a no-frame box can leave big white spaces, also distracting
and confusing. For me, a full-width underline looks best (Example 3). Thanks
for checking into this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124189] FORMCONTROLS: Add "bottom" or "underline" as border option

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124189

--- Comment #4 from peterpqa  ---
My issue is how the form looks when printed out, as well as on-screen. A
printed 3D-look text box form control looks the same as flat-border, still
visually distracting and confusing. Please see my updated examples attachment.
Underlined text in a no-frame box can leave big white spaces, also distracting
and confusing. For me, a full-width underline looks best (Example 3). Thanks
for checking into this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124189] FORMCONTROLS: Add "bottom" or "underline" as border option

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124189

peterpqa  changed:

   What|Removed |Added

 Attachment #150088|0   |1
is obsolete||

--- Comment #3 from peterpqa  ---
Created attachment 150104
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150104=edit
Writer text box form control border examples V2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124189] FORMCONTROLS: Add "bottom" or "underline" as border option

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124189

peterpqa  changed:

   What|Removed |Added

 Attachment #150088|0   |1
is obsolete||

--- Comment #3 from peterpqa  ---
Created attachment 150104
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150104=edit
Writer text box form control border examples V2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 76274] Files with XLT extension are not added to Recent documents

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76274

Vaibhav Rastogi  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |deepgagan231...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76274] Files with XLT extension are not added to Recent documents

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76274

Vaibhav Rastogi  changed:

   What|Removed |Added

   Assignee|vaibh...@iitbhilai.ac.in|libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124209] AM/PM time notation in CALC

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124209

--- Comment #1 from gmarco  ---
look at this too:

 format:  HH.MM.SS   HH.MM.SS AM/PM
=ORARIO(23;59;59)  23:59:59   11:59:59 p.m.
=ORARIO(24;59;59)  00:59:59   12:59:59 a.m. (senseless)
=ORARIO(24;59;60)  01:00:00   01:00:00 a.m. OK but look at SS=60
=ORARIO(23;59;60)  00:00:00   12:00:00 a.m. (senseless)
=ORARIO(23;60;60)  00:01:00   12:01:00 a.m." 
=ORARIO(23;60;61)  00:01:01   12:01:01 a.m." 
=ORARIO(23;119;59) 00:59:59   12:59:59 a.m." and look at MM=119
=ORARIO(23;119;60) 01:00:00   01:00:00 a.m. OK but look at MM=119
   and SS=60

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sw/source sw/uiconfig

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/ui/fldui/flddinf.cxx|  262 ---
 sw/source/ui/fldui/flddinf.hxx|   26 -
 sw/source/ui/fldui/flddok.cxx |  411 +-
 sw/source/ui/fldui/flddok.hxx |   41 +-
 sw/source/ui/fldui/fldpage.cxx|2 
 sw/source/ui/fldui/fldpage.hxx|2 
 sw/source/uibase/inc/numfmtlb.hxx |   97 ++-
 sw/source/uibase/utlui/numfmtlb.cxx   |   99 +--
 sw/uiconfig/swriter/ui/flddocinfopage.ui  |  136 -
 sw/uiconfig/swriter/ui/flddocumentpage.ui |  198 +++---
 sw/uiconfig/swriter/ui/fldrefpage.ui  |4 
 11 files changed, 761 insertions(+), 517 deletions(-)

New commits:
commit 31b017e31f4802f6d56acaa7b717fb84e4b6e318
Author: Caolán McNamara 
AuthorDate: Tue Mar 19 15:11:23 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 19 18:46:05 2019 +0100

weld SwFieldDokInfPage

Change-Id: I468f6927f089db19c3b461d965b1dc6222f65716
Reviewed-on: https://gerrit.libreoffice.org/69428
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx
index 13659f395655..340daf1470da 100644
--- a/sw/source/ui/fldui/flddinf.cxx
+++ b/sw/source/ui/fldui/flddinf.cxx
@@ -58,41 +58,28 @@ void FillFieldSelect(weld::TreeView& rListBox)
 rListBox.append_text(SwResId(FLD_SELECT[i]));
 }
 
-SwFieldDokInfPage::SwFieldDokInfPage(vcl::Window* pParent, const SfxItemSet 
*const pCoreSet)
-:  SwFieldPage(pParent, "FieldDocInfoPage",
-"modules/swriter/ui/flddocinfopage.ui", pCoreSet)
-, pSelEntry(nullptr)
+SwFieldDokInfPage::SwFieldDokInfPage(TabPageParent pParent, const SfxItemSet 
*const pCoreSet)
+:  SwFieldPage(pParent, "modules/swriter/ui/flddocinfopage.ui", 
"FieldDocInfoPage", pCoreSet)
 , nOldSel(0)
 , nOldFormat(0)
+, m_xTypeTLB(m_xBuilder->weld_tree_view("type"))
+, m_xSelection(m_xBuilder->weld_widget("selectframe"))
+, m_xSelectionLB(m_xBuilder->weld_tree_view("select"))
+, m_xFormat(m_xBuilder->weld_widget("formatframe"))
+, m_xFormatLB(new 
SwNumFormatTreeView(m_xBuilder->weld_tree_view("format")))
+, m_xFixedCB(m_xBuilder->weld_check_button("fixed"))
 {
-get(m_pTypeTLB, "type");
-get(m_pSelection, "selectframe");
-get(m_pFormat, "formatframe");
-get(m_pSelectionLB, "select");
-FillFieldSelect(*m_pSelectionLB);
-get(m_pFormatLB, "format");
-get(m_pFixedCB, "fixed");
-
-long nHeight = m_pTypeTLB->GetTextHeight() * 20;
-m_pTypeTLB->set_height_request(nHeight);
-m_pSelectionLB->set_height_request(nHeight);
-m_pFormatLB->set_height_request(nHeight);
-
-long nWidth = m_pTypeTLB->LogicToPixel(Size(FIELD_COLUMN_WIDTH, 0), 
MapMode(MapUnit::MapAppFont)).Width();
-m_pTypeTLB->set_width_request(nWidth);
-m_pFormatLB->set_width_request(nWidth);
-m_pSelectionLB->set_width_request(nWidth);
-
-m_pTypeTLB->SetSelectionMode(SelectionMode::Single);
-
m_pTypeTLB->SetStyle(m_pTypeTLB->GetStyle()|WB_HASLINES|WB_CLIPCHILDREN|WB_SORT|WB_HASBUTTONS|WB_HASBUTTONSATROOT|WB_HSCROLL);
-m_pTypeTLB->SetOptimalImageIndent();
-// Don't set font, so that the control's font is adopted!
-// Otherwise at wrong font bug to OV.
-m_pTypeTLB->SetSpaceBetweenEntries(0);
-
-m_pTypeTLB->SetNodeDefaultImages();
+m_xTypeTLB->make_sorted();
+FillFieldSelect(*m_xSelectionLB);
+
+auto nWidth = LogicToPixel(Size(FIELD_COLUMN_WIDTH, 0), 
MapMode(MapUnit::MapAppFont)).Width();
+auto nHeight = m_xTypeTLB->get_height_rows(20);
+m_xTypeTLB->set_size_request(nWidth, nHeight);
+m_xFormatLB->get_widget().set_size_request(nWidth, nHeight);
+m_xSelectionLB->set_size_request(nWidth, nHeight);
+
 //enable 'active' language selection
-m_pFormatLB->SetShowLanguageControl(true);
+m_xFormatLB->SetShowLanguageControl(true);
 
 const SfxUnoAnyItem* pItem = pCoreSet
 ? pCoreSet->GetItem(SID_DOCINFO, false)
@@ -106,31 +93,16 @@ SwFieldDokInfPage::~SwFieldDokInfPage()
 disposeOnce();
 }
 
-void SwFieldDokInfPage::dispose()
-{
-m_pTypeTLB.clear();
-m_pSelection.clear();
-m_pSelectionLB.clear();
-m_pFormat.clear();
-m_pFormatLB.clear();
-m_pFixedCB.clear();
-SwFieldPage::dispose();
-}
-
 void SwFieldDokInfPage::Reset(const SfxItemSet* )
 {
 Init(); // general initialisation
 
 // initialise TypeListBox
-m_pTypeTLB->SetUpdateMode(false);
-m_pTypeTLB->Clear();
-pSelEntry = nullptr;
+m_xTypeTLB->freeze();
+m_xTypeTLB->clear();
+m_xSelEntry.reset();
 
 // display SubTypes in TypeLB
-SvTreeListEntry* pEntry = nullptr;
-
-SvTreeListEntry* pInfo = nullptr;
-
 sal_uInt16 nSubType = USHRT_MAX;
 if (IsFieldEdit())
 {
@@ -140,17 +112,17 @@ void SwFieldDokInfPage::Reset(const SfxItemSet* )
 {
 m_sOldCustomFieldName = 

[Libreoffice-bugs] [Bug 124112] Insert drawing object in chart crashes LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124112

Xisco Faulí  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com
   Keywords|bibisectRequest |bibisected, bisected
Version|6.2.1.2 release |6.2.0.0.alpha1+

--- Comment #7 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6be7e2e9dd8027d284f1b00ef6e3b4654eec7d79

author  Noel Grandin  2018-08-30 13:54:33
+0200
committer   Noel Grandin  2018-09-03
08:27:48 +0200
commit  6be7e2e9dd8027d284f1b00ef6e3b4654eec7d79 (patch)
treed43e18e7ef12d29089f9eb34bbe95a78245261cc
parent  dff829e863fd05bedd5bcb713cd80c10fa582932 (diff)
pass SdrUndoAction around by std::unique_ptr
convert the LINK we use here to std::function, since LINK
does not currently handle std::unique_ptr

Bisected with: bibisect-linux64-6.2

Adding Cc: to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124210] New: Difficulty with inserting & moving images around page in Writer

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124210

Bug ID: 124210
   Summary: Difficulty with inserting & moving images around page
in Writer
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: publicf...@bak.rr.com

Description:



I insert an image and then I choose to reposition it, but the image won't move.
 I try to drag it with the mouse and nothing happens other than selecting it.

Something I've noticed is if I: Right-Click on image >Format Image >Type
>Position >Vertical 'from bottom' and there is a 'by' size with a number, in
this case 9.12" 'to baseline'.  

I manually set it to zero and that allows me to move the image.  However, after
dragging/moving it to another page and letting go of the mouse, it "snaps back"
to the original position and that number has been returned to whatever it was
before I changed the value, in this case 9.12"


WRAP is set to "optimal" and cannot be changed, the other options are not
selectable (None, Before/After, etc.)

ANCHOR is set to "as character".

I have 10 pages with 16 images, most are positioned adequately, but a couple
are not.


Steps to Reproduce:
1. Insert several images on different pages (I don't know if this is required
to reproduce but it's what I do)
2. Attempt to move images to another existing page.  For example move the image
on page 3 to page 1, and page 1 image to page 2.
3.

Actual Results:
Image fails to move at all.  After setting vertical position to zero as
previously described and attempting to move the image, it snaps back to its
original position and replaces vertical position value of zero with original
number.

Expected Results:
Image should be repositioned to new location



Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial6
CPU Threads: 8; OS Version: Linux 4.15; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

Ubuntu 16.04.6 LTS

$ glxinfo | grep OpenGL
OpenGL vendor string: nouveau
OpenGL renderer string: NVA8
OpenGL core profile version string: 3.3 (Core Profile) Mesa 18.0.5
OpenGL core profile shading language version string: 3.30
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 3.0 Mesa 18.0.5
OpenGL shading language version string: 1.30
OpenGL context flags: (none)
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.0 Mesa 18.0.5
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00
OpenGL ES profile extensions:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/UnitWOPISaveAs.cpp test/WopiTestServer.hpp wsd/ClientSession.cpp

2019-03-19 Thread Libreoffice Gerrit user
 test/UnitWOPISaveAs.cpp |7 ---
 test/WopiTestServer.hpp |2 +-
 wsd/ClientSession.cpp   |   16 ++--
 3 files changed, 15 insertions(+), 10 deletions(-)

New commits:
commit d87146d3fa1e1dd48b894ea63336822f0d271856
Author: Eduard Ardeleanu 
AuthorDate: Tue Mar 19 16:00:38 2019 +0200
Commit: Jan Holesovsky 
CommitDate: Tue Mar 19 18:31:15 2019 +0100

fix: saveAs breaks when '%' character is used within the filename

Change-Id: I2df059abd67be88acae8bd44ae2c74be7778a595
Reviewed-on: https://gerrit.libreoffice.org/69424
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/test/UnitWOPISaveAs.cpp b/test/UnitWOPISaveAs.cpp
index 19c9d5d17..ad79f4b59 100644
--- a/test/UnitWOPISaveAs.cpp
+++ b/test/UnitWOPISaveAs.cpp
@@ -34,7 +34,7 @@ public:
 void assertPutRelativeFileRequest(const Poco::Net::HTTPRequest& request) 
override
 {
 // spec says UTF-7...
-CPPUNIT_ASSERT_EQUAL(std::string("/jan/hole+AWE-ovsk+AP0-/hello 
world.pdf"), request.get("X-WOPI-SuggestedTarget"));
+CPPUNIT_ASSERT_EQUAL(std::string("/jan/hole+AWE-ovsk+AP0-/hello 
world+ACU-1.pdf"), request.get("X-WOPI-SuggestedTarget"));
 
 // make sure it is a pdf - or at least that it is larger than what it
 // used to be
@@ -44,7 +44,8 @@ public:
 bool filterSendMessage(const char* data, const size_t len, const WSOpCode 
/* code */, const bool /* flush */, int& /*unitReturn*/) override
 {
 const std::string message(data, len);
-const std::string expected("saveas: url=" + 
helpers::getTestServerURI() + "/something%20wopi/files/1?access_token=anything 
filename=hello%20world.pdf");
+
+const std::string expected("saveas: url=" + 
helpers::getTestServerURI() + "/something%20wopi/files/1?access_token=anything 
filename=hello%20world%251.pdf");
 if (message.find(expected) == 0)
 {
 // successfully exit the test if we also got the outgoing message
@@ -66,7 +67,7 @@ public:
 initWebsocket("/wopi/files/0?access_token=anything");
 
 helpers::sendTextFrame(*getWs()->getLOOLWebSocket(), "load 
url=" + getWopiSrc(), testName);
-helpers::sendTextFrame(*getWs()->getLOOLWebSocket(), "saveas 
url=wopi:///jan/hole%C5%A1ovsk%C3%BD/hello%20world.pdf", testName);
+helpers::sendTextFrame(*getWs()->getLOOLWebSocket(), "saveas 
url=wopi:///jan/hole%C5%A1ovsk%C3%BD/hello%20world%251.pdf", testName);
 SocketPoll::wakeupWorld();
 
 _phase = Phase::Polling;
diff --git a/test/WopiTestServer.hpp b/test/WopiTestServer.hpp
index 1854b9c11..ea5659912 100644
--- a/test/WopiTestServer.hpp
+++ b/test/WopiTestServer.hpp
@@ -172,7 +172,7 @@ protected:
 assertPutRelativeFileRequest(request);
 
 std::string wopiURL = helpers::getTestServerURI() + "/something 
wopi/files/1?access_token=anything";
-std::string content = "{ \"Name\":\"hello world.pdf\", \"Url\":\"" 
+ wopiURL + "\" }";
+std::string content = "{ \"Name\":\"hello world%1.pdf\", 
\"Url\":\"" + wopiURL + "\" }";
 
 std::ostringstream oss;
 oss << "HTTP/1.1 200 OK\r\n"
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 7f5938bb1..9eb5cef36 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -786,12 +786,12 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 return false;
 }
 
-std::string url, wopiFilename;
-Poco::URI::decode(encodedURL, url);
+// Save-as completed, inform the ClientSession.
+std::string wopiFilename;
 Poco::URI::decode(encodedWopiFilename, wopiFilename);
 
-// Save-as completed, inform the ClientSession.
-Poco::URI resultURL(url);
+// URI constructor implicitly decodes when it gets std::string as param
+Poco::URI resultURL(encodedURL);
 if (resultURL.getScheme() == "file")
 {
 std::string relative(resultURL.getPath());
@@ -801,8 +801,12 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 // Rewrite file:// URLs, as they are visible to the outside world.
 const Path path(docBroker->getJailRoot(), relative);
 if (Poco::File(path).exists())
-{
-resultURL.setPath(path.toString());
+{   
+// Encode path for special characters (i.e '%') since 
Poco::URI::setPath implicitly decodes the input param 
+std::string encodedPath;
+Poco::URI::encode(path.toString(), "", encodedPath);
+
+resultURL.setPath(encodedPath);
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/core/view/viewsh.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 68e47d3c7c2de280b3353cfbe86e1a03bb723bfa
Author: heiko tietze 
AuthorDate: Tue Mar 19 10:37:05 2019 +0100
Commit: Jim Raykowski 
CommitDate: Tue Mar 19 18:27:00 2019 +0100

tdf#118621 - Optional header/footer menu

Missing bits added to allow leaving the edit mode per escape

Change-Id: Ife6fd1b6106fafe5f16b36aea4c88127c16ccf23
Reviewed-on: https://gerrit.libreoffice.org/69408
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 3d106bb195c4..65b45e90379d 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -122,8 +122,9 @@ void SwViewShell::ToggleHeaderFooterEdit()
 }
 
 // Avoid corner case
-if ( !IsShowHeaderFooterSeparator( Header ) &&
- !IsShowHeaderFooterSeparator( Footer ) )
+if ( ( GetViewOptions()->IsUseHeaderFooterMenu() ) &&
+ ( !IsShowHeaderFooterSeparator( Header ) &&
+   !IsShowHeaderFooterSeparator( Footer ) ) )
 {
 mbHeaderFooterEdit = false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: 2 commits - esc-reporting/esc-analyze.py esc-reporting/esc-collect.py esc-reporting/esc-report.py

2019-03-19 Thread Libreoffice Gerrit user
 esc-reporting/esc-analyze.py |6 +-
 esc-reporting/esc-collect.py |9 +
 esc-reporting/esc-report.py  |   10 --
 3 files changed, 22 insertions(+), 3 deletions(-)

New commits:
commit 9e1b33c980bfbb8450dbb420709f56ac1127ea93
Author: Xisco Fauli 
AuthorDate: Tue Mar 19 18:10:35 2019 +0100
Commit: Xisco Fauli 
CommitDate: Tue Mar 19 18:10:35 2019 +0100

ESC: Add RTL bugs to Components regression count

diff --git a/esc-reporting/esc-collect.py b/esc-reporting/esc-collect.py
index e4242d6..52b266d 100755
--- a/esc-reporting/esc-collect.py
+++ b/esc-reporting/esc-collect.py
@@ -500,6 +500,15 @@ def get_esc_bugzilla(cfg):
   '=filter%3A%2C perf'
 rawList['ESC_COMPONENT_UPDATE']['all']['Writer: other']['count'], \
 rawList['ESC_COMPONENT_UPDATE']['all']['Writer: other']['list'] = 
do_ESC_counting(bz, url)
+rawList['ESC_COMPONENT_UPDATE']['all']['RTL'] = {}
+url = '_status=NEW' \
+  '_status=ASSIGNED' \
+  '_status=REOPENED' \
+  '_status=PLEASETEST' \
+  '=regression%2C filter%3Artf%2C ' \
+  '_type=allwords'
+rawList['ESC_COMPONENT_UPDATE']['all']['RTL']['count'], \
+rawList['ESC_COMPONENT_UPDATE']['all']['RTL']['list'] = 
do_ESC_counting(bz, url)
 
 for comp in ['Calc', 'Impress', 'Base', 'Draw', 'LibreOffice', 'Writer', 
'BASIC', 'Chart', 'Extensions',
  'Formula Editor', 'Impress Remote', 'Installation', 
'Linguistic', 'Printing and PDF export',
commit 9ce7bf417126023af433729e9cf93dd4f30738a8
Author: Xisco Fauli 
AuthorDate: Tue Mar 19 13:33:26 2019 +0100
Commit: Xisco Fauli 
CommitDate: Tue Mar 19 13:33:26 2019 +0100

ESC: Add iOS and Online to the report

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 8c69675..46ee623 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -220,7 +220,7 @@ def util_create_statList():
 'needsUXEval' : 0,
 'topicUI': 0},
  'qa': {'unconfirmed': {'count': 0, 'documentation': 0, 
'enhancement': 0, 'needsUXEval': 0,
- 'haveBacktrace': 0, 'needsDevAdvice': 0, 'android': 
0}},
+ 'haveBacktrace': 0, 'needsDevAdvice': 0, 'android': 
0, 'ios': 0, 'online': 0}},
  'easyhacks' : {'needsDevEval': 0,  'needsUXEval': 0, 
'cleanup_comments': 0,
 'total': 0, 'assigned': 0,
'open': 0},
  'esc': {}},
@@ -471,6 +471,10 @@ def analyze_qa():
 statList['data']['qa']['unconfirmed']['documentation'] += 1
   if row['component'] == 'Android app' or row['component'] == 'Android 
Viewer':
 statList['data']['qa']['unconfirmed']['android'] += 1
+  if row['component'] == 'iOS':
+statList['data']['qa']['unconfirmed']['ios'] += 1
+  if row['product'] == 'LibreOffice Online':
+statList['data']['qa']['unconfirmed']['online'] += 1
 
 util_build_period_stat(creationDate, email, 'qa', 'owner')
 
diff --git a/esc-reporting/esc-report.py b/esc-reporting/esc-report.py
index 3805566..d613fe5 100755
--- a/esc-reporting/esc-report.py
+++ b/esc-reporting/esc-report.py
@@ -551,7 +551,9 @@ def report_qa():
 "+ haveBackTrace: {} ({:+d})\n" \
 "+ needsDevAdvice: {} ({:+d})\n" \
 "+ documentation:  {} ({:+d})\n" \
-"+ android:  {} ({:+d})\n".format(
+"+ android:  {} ({:+d})\n" \
+"+ iOS:  {} ({:+d})\n" \
+"+ Online:  {} ({:+d})\n".format(
 statList['data']['qa']['unconfirmed']['count'],
 statList['diff']['qa']['unconfirmed']['count'],
 statList['data']['qa']['unconfirmed']['enhancement'],
@@ -565,7 +567,11 @@ def report_qa():
 statList['data']['qa']['unconfirmed']['documentation'],
 statList['diff']['qa']['unconfirmed']['documentation'],
 statList['data']['qa']['unconfirmed']['android'],
-statList['diff']['qa']['unconfirmed']['android'])
+statList['diff']['qa']['unconfirmed']['android'],
+statList['data']['qa']['unconfirmed']['ios'],
+statList['diff']['qa']['unconfirmed']['ios'],
+statList['data']['qa']['unconfirmed']['online'],
+statList['diff']['qa']['unconfirmed']['online'])
 print(text, file=fp)
 print(text, file=fpESC)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124112] Insert drawing object in chart crashes LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124112

Telesto  changed:

   What|Removed |Added

   Severity|normal  |major
   Priority|medium  |highest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124112] Insert drawing object in chart crashes LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124112

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124112] Insert drawing object in chart crashes LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124112

Telesto  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #6 from Telesto  ---
Repro
Version: 6.3.0.0.alpha0+
Build ID: bbf9b65f91e8136fa1a2e17960944b8720f5d58e
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-15_09:56:33
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

STR
1. Open the attached file
2. Enter the 'empty' chart with a smiley in it by double click
3. Move the smiley a bit
4. Exit the chart by clicking somewhere else in sheet
5. Double click the chart again -> Crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124112] Insert drawing object in chart crashes LibreOffice

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124112

--- Comment #5 from Telesto  ---
Created attachment 150103
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150103=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2019-03-19 Thread Libreoffice Gerrit user
 sw/source/core/doc/doc.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 8ec7648f0d8580950c1bdd2fb9de92953cc90914
Author: Mike Kaganski 
AuthorDate: Tue Mar 19 13:39:08 2019 +0100
Commit: Mike Kaganski 
CommitDate: Tue Mar 19 18:17:23 2019 +0100

Make condition logic slightly clearer

Change-Id: I8c35ddf047751cf06707efbbe11730414767a0af
Reviewed-on: https://gerrit.libreoffice.org/69416
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index 3691940ef2fb..fb544a775b0c 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -1830,10 +1830,10 @@ SwDoc::GetVbaEventProcessor()
 
 void SwDoc::SetMissingDictionaries( bool bIsMissing )
 {
-if( bIsMissing && meDictionaryMissing == MissingDictionary::Undefined )
-meDictionaryMissing = MissingDictionary::True;
-else if( !bIsMissing )
+if (!bIsMissing)
 meDictionaryMissing = MissingDictionary::False;
+else if (meDictionaryMissing == MissingDictionary::Undefined)
+meDictionaryMissing = MissingDictionary::True;
 };
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124191] Text copied from a PDF exported using Linux Libertine G is missing characters.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124191

--- Comment #3 from Frank Zimmerman  ---
Correction: for the first webpage link - only the first book was created with
LibreOffice 5. The rest are all tagged LibreOffice 6 (I think they were started
with LO 5 and finished with LO 6).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124191] Text copied from a PDF exported using Linux Libertine G is missing characters.

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124191

--- Comment #2 from Frank Zimmerman  ---
Cannot reproduce? I hope that's a good sign.

Here are some examples from my website. The books on the following page were
produced with LibreOffice 5. Try downloading one of the PDF's and copy/paste a
paragraph out into a text editor. Let me know what you get.

https://www.practicaprophetica.com/books/edward-irving/

The following book was produced with LibreOffice 6, not too long ago:

https://www.practicaprophetica.com/books/ftw/#Last-Day-Events

Go to the 10th page (part of the intro pages before the numbering starts), the
"Cover Picture" description, and copy out the first paragraph.

BTW I'm also using Win 10-64 bit, Version 1809. My current LibreOffice is
6.2.0.3 64 bit, but as shown from the first books linked in the page above,
this has been around since LibreOffice 5, so I'm not sure that makes any
difference.

I'm also pasting directly into a text editor (EditPad), so the fontname issue
you mention below is not applicable in that scenario (although I noticed it
also when pasting into LO).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/clang-format

2019-03-19 Thread Libreoffice Gerrit user
 solenv/clang-format/blacklist |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 6a864828e2976be16c12ecf028ebbedc95fdae61
Author: Stephan Bergmann 
AuthorDate: Tue Mar 19 15:35:39 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 19 17:44:05 2019 +0100

Add wrongly formatted files to blacklist

Change-Id: I2347e66c79e54ad0de33f51470e78e0bdf18cbac
Reviewed-on: https://gerrit.libreoffice.org/69426
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 14e4a4532e70..b48cd3acaa3e 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -10124,11 +10124,13 @@ sc/qa/extras/recordchanges-test.cxx
 sc/qa/extras/regression-test.cxx
 sc/qa/extras/scannotationshapeobj.cxx
 sc/qa/extras/scannotationsobj.cxx
+sc/qa/extras/scarealinkobj.cxx
 sc/qa/extras/sccellcursorobj.cxx
 sc/qa/extras/sccellobj.cxx
 sc/qa/extras/sccellrangeobj.cxx
 sc/qa/extras/sccellrangesobj.cxx
 sc/qa/extras/scdatabaserangeobj.cxx
+sc/qa/extras/scdatapilotitemobj.cxx
 sc/qa/extras/scdatapilottableobj.cxx
 sc/qa/extras/sceditfieldobj-cell.cxx
 sc/qa/extras/sceditfieldobj-header.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124004] Editing a style with bullets, font list too long for screen, no scroll bars

2019-03-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124004

Peter Freeth  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #11 from Peter Freeth  ---
OK, for anyone currently searching for a solution for this problem, here is a
workaround.

Using Gnome Tweaks you can try a theme which does show scroll arrows at the top
and bottom of the list, which the default Yaru (Ubuntu 18.10 theme does not.

On my system, Adwaita did the job.

You can then modify the desktop file in /usr/share/applications to open the
program with that theme.

For example, change this line:

Exec=libreoffice %U

To this:

Exec=env GTK_THEME=Adwaita libreoffice

I found that if I left the %U on the end, the desktop file would show an error
and fail to run.

You can also try editing the gtk css file
(/usr/share/themes/[themename]/gtk3.0/gtk.css) to add the following at the top:

.scrollbar scrollbar {
  -GtkScrollbar-has-backward-stepper: true;
  -GtkScrollbar-has-forward-stepper: true;
  -GtkScrollbar::stepper-size = 18
  }

Though I'm not sure the css edit made any difference to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/clang-format

2019-03-19 Thread Libreoffice Gerrit user
 solenv/clang-format/blacklist |   44 +-
 1 file changed, 22 insertions(+), 22 deletions(-)

New commits:
commit 861d6355c7173b532cfd658db73c3865b5a23377
Author: Stephan Bergmann 
AuthorDate: Tue Mar 19 15:31:07 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 19 17:08:23 2019 +0100

Sort solenv/clang-format/blacklist

(lexicographically, by Unicode code point values; to make it easier to add
further entries)

Change-Id: I0ed54cb96a088975c30cb21372acf191ce05731e
Reviewed-on: https://gerrit.libreoffice.org/69425
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index a1d1af410cdd..14e4a4532e70 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -3013,8 +3013,8 @@ dbaccess/qa/extras/rowsetclones.cxx
 dbaccess/qa/unit/dbaccess-dialogs-test.cxx
 dbaccess/qa/unit/dbtest_base.cxx
 dbaccess/qa/unit/embeddeddb_performancetest.cxx
-dbaccess/qa/unit/firebird.cxx
 dbaccess/qa/unit/firebird-regression.cxx
+dbaccess/qa/unit/firebird.cxx
 dbaccess/qa/unit/hsqldb.cxx
 dbaccess/source/core/api/BookmarkSet.cxx
 dbaccess/source/core/api/BookmarkSet.hxx
@@ -3892,6 +3892,7 @@ drawinglayer/source/primitive2d/mediaprimitive2d.cxx
 drawinglayer/source/primitive2d/metafileprimitive2d.cxx
 drawinglayer/source/primitive2d/modifiedcolorprimitive2d.cxx
 drawinglayer/source/primitive2d/objectinfoprimitive2d.cxx
+drawinglayer/source/primitive2d/pagehierarchyprimitive2d.cxx
 drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx
 drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
 drawinglayer/source/primitive2d/pointarrayprimitive2d.cxx
@@ -3908,7 +3909,6 @@ 
drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx
 drawinglayer/source/primitive2d/texteffectprimitive2d.cxx
 drawinglayer/source/primitive2d/textenumsprimitive2d.cxx
 drawinglayer/source/primitive2d/texthierarchyprimitive2d.cxx
-drawinglayer/source/primitive2d/pagehierarchyprimitive2d.cxx
 drawinglayer/source/primitive2d/textlayoutdevice.cxx
 drawinglayer/source/primitive2d/textlineprimitive2d.cxx
 drawinglayer/source/primitive2d/textprimitive2d.cxx
@@ -3985,8 +3985,8 @@ drawinglayer/source/tools/emfpregion.cxx
 drawinglayer/source/tools/emfpregion.hxx
 drawinglayer/source/tools/emfpstringformat.cxx
 drawinglayer/source/tools/emfpstringformat.hxx
-drawinglayer/source/tools/wmfemfhelper.cxx
 drawinglayer/source/tools/primitive2dxmldump.cxx
+drawinglayer/source/tools/wmfemfhelper.cxx
 dtrans/source/cnttype/mcnttfactory.cxx
 dtrans/source/cnttype/mcnttfactory.hxx
 dtrans/source/cnttype/mcnttype.cxx
@@ -5116,19 +5116,19 @@ fpicker/source/win32/VistaFilePickerEventHandler.cxx
 fpicker/source/win32/VistaFilePickerEventHandler.hxx
 fpicker/source/win32/VistaFilePickerImpl.cxx
 fpicker/source/win32/VistaFilePickerImpl.hxx
+fpicker/source/win32/WinImplHelper.cxx
+fpicker/source/win32/WinImplHelper.hxx
 fpicker/source/win32/afxres.h
 fpicker/source/win32/asyncrequests.cxx
 fpicker/source/win32/asyncrequests.hxx
 fpicker/source/win32/comptr.hxx
 fpicker/source/win32/platform_vista.h
 fpicker/source/win32/resource.h
+fpicker/source/win32/resourceprovider.cxx
+fpicker/source/win32/resourceprovider.hxx
 fpicker/source/win32/shared.hxx
 fpicker/source/win32/vistatypes.h
 fpicker/source/win32/workbench/Test_fps.cxx
-fpicker/source/win32/WinImplHelper.cxx
-fpicker/source/win32/WinImplHelper.hxx
-fpicker/source/win32/resourceprovider.cxx
-fpicker/source/win32/resourceprovider.hxx
 fpicker/test/svdem.cxx
 framework/inc/acceleratorconst.h
 framework/inc/classes/actiontriggercontainer.hxx
@@ -6220,6 +6220,7 @@ include/drawinglayer/primitive2d/mediaprimitive2d.hxx
 include/drawinglayer/primitive2d/metafileprimitive2d.hxx
 include/drawinglayer/primitive2d/modifiedcolorprimitive2d.hxx
 include/drawinglayer/primitive2d/objectinfoprimitive2d.hxx
+include/drawinglayer/primitive2d/pagehierarchyprimitive2d.hxx
 include/drawinglayer/primitive2d/pagepreviewprimitive2d.hxx
 include/drawinglayer/primitive2d/patternfillprimitive2d.hxx
 include/drawinglayer/primitive2d/pointarrayprimitive2d.hxx
@@ -6236,7 +6237,6 @@ 
include/drawinglayer/primitive2d/textdecoratedprimitive2d.hxx
 include/drawinglayer/primitive2d/texteffectprimitive2d.hxx
 include/drawinglayer/primitive2d/textenumsprimitive2d.hxx
 include/drawinglayer/primitive2d/texthierarchyprimitive2d.hxx
-include/drawinglayer/primitive2d/pagehierarchyprimitive2d.hxx
 include/drawinglayer/primitive2d/textlayoutdevice.hxx
 include/drawinglayer/primitive2d/textlineprimitive2d.hxx
 include/drawinglayer/primitive2d/textprimitive2d.hxx
@@ -7336,8 +7336,8 @@ 
include/svx/sdr/overlay/overlayprimitive2dsequenceobject.hxx
 include/svx/sdr/overlay/overlayselection.hxx
 include/svx/sdr/overlay/overlaytriangle.hxx
 include/svx/sdr/primitive2d/sdrattributecreator.hxx
-include/svx/sdr/primitive2d/sdrframeborderprimitive2d.hxx
 

  1   2   3   4   >