[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - starmath/source
starmath/source/ElementsDockingWindow.cxx |2 +-
starmath/source/edit.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 7303ca75d9fd0cf98cd38950711c32c892d94285
Author: Jan-Marek Glogowski
AuthorDate: Wed May 29 16:32:24 2019 +0200
Commit: Michael Weghorn
CommitDate: Tue Jun 4 07:53:57 2019 +0200
SM add a border to the editor and the element list
Change-Id: I708476919ce7750df6a691d75fe594c3f44d9126
Reviewed-on: https://gerrit.libreoffice.org/73173
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
Tested-by: Heiko Tietze
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 501b935d057547b1a785147a32e4e090ebd91a12)
Reviewed-on: https://gerrit.libreoffice.org/73385
Reviewed-by: Michael Weghorn
diff --git a/starmath/source/ElementsDockingWindow.cxx
b/starmath/source/ElementsDockingWindow.cxx
index 7491e71823b1..9483c650 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -259,7 +259,7 @@ const std::tuple SmElementsControl::
const size_t SmElementsControl::m_aCategoriesSize =
SAL_N_ELEMENTS(m_aCategories);
SmElementsControl::SmElementsControl(vcl::Window *pParent)
-: Control(pParent, WB_TABSTOP)
+: Control(pParent, WB_TABSTOP | WB_BORDER)
, mpDocShell(new SmDocShell(SfxModelFlags::EMBEDDED_OBJECT))
, m_nCurrentElement(SAL_MAX_UINT16)
, m_nCurrentRolloverElement(SAL_MAX_UINT16)
diff --git a/starmath/source/edit.cxx b/starmath/source/edit.cxx
index 643ef04a1960..515b924ee1ef 100644
--- a/starmath/source/edit.cxx
+++ b/starmath/source/edit.cxx
@@ -73,7 +73,7 @@ bool SmEditWindow::IsInlineEditEnabled()
SmEditWindow::SmEditWindow( SmCmdBoxWindow ) :
-Window (),
+Window (, WB_BORDER),
DropTargetHelper( this ),
rCmdBox (rMyCmdBoxWin),
aModifyIdle ("SmEditWindow ModifyIdle"),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 98522] Format of navigationbar in tablecontrols differ while zooming form
https://bugs.documentfoundation.org/show_bug.cgi?id=98522 Robert Großkopf changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #8 from Robert Großkopf --- Have tested it again with LO 6.2.4.2 on OpenSUSE 15 64bit rpm Linux. Couldn't reproduce the bug any more. Will set this one to WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125668] Equations are not converted correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=125668 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7658 Component|Writer |Formula Editor Ever confirmed|0 |1 Version|3.3.0 release |unspecified Blocks||107810 CC||caol...@redhat.com, ||rb.hensc...@t-online.de, ||t...@fixedpoint.jp, ||vstuart.fo...@utsa.edu --- Comment #3 from V Stuart Foote --- Confirming on current master/6.4.0alpha0 and 6.2.4.2 builds on Windows 10 There are several issues. First is font mishandling--because the OOXML is using Cambria Math and assigning Unicode SMP codepoints from the Mathematical Alphanumeric Symbols block. Specifically U+1d465 Mathamatical Italic Small X. Since the LibreOffice formula editor defaults to Liberation Serif for variables it has no coverage of the block, nor is there any font fallback, and the variable from the OLE formula shows a blank when rendered. But an easy workaround, setting LO formula editor to use the same font as MS Office Equation editor -- Cambria Math, the variable(s) will show on the document canvas. The other issues on slide one and two of attachment 151885, where a text box using bullets is holding the OLE formulas. 1) The import filter incorrectly positions and sizes the OLE to the full size of the imported Text box--stretching the formula. Should either keep defaults for LO Formula editor, or better read the font size from the object in XML 2) On filter import LibreOffice displays both the Text box bullets, but also the fallback image (media/image5.png on slide one, and media/image6.png on slide two). And slide two shows "double struck" for the text bullet as the import is positioned incorrectly, that is bug 117658 -- the import filter should do one or the other. Either import the just the image, or import just the bullets of the Text box. 3) On slide two, the Formula OLE for the bullet is not rendered, so only see the fallback image. But by deleting the initial text bullet it allows the Formula OLE to render. So the import filter is not handling the OLE in the text box when other text bullets are present. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107810 [Bug 107810] [META] OLE/Embedded object bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107810 V Stuart Foote changed: What|Removed |Added Depends on||125668 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125668 [Bug 125668] Equations are not converted correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117658] equations appear twice in pptx import
https://bugs.documentfoundation.org/show_bug.cgi?id=117658 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5668 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/xsltfilter/OleHandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 44c21ca9324997b8a3001e316c774b4ba34c2f0b Author: Andrea Gelmini AuthorDate: Tue May 14 21:23:36 2019 + Commit: Julien Nabet CommitDate: Tue Jun 4 07:11:57 2019 +0200 Fix typo Change-Id: Ia6977b47c3011e18827e173a2f95e5caa04ba774 Reviewed-on: https://gerrit.libreoffice.org/73418 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/filter/source/xsltfilter/OleHandler.cxx b/filter/source/xsltfilter/OleHandler.cxx index 1f727e363558..107dc49e 100644 --- a/filter/source/xsltfilter/OleHandler.cxx +++ b/filter/source/xsltfilter/OleHandler.cxx @@ -86,7 +86,7 @@ namespace XSLT Reference xSeek(m_rootStream->getInputStream(), UNO_QUERY); xSeek->seek(0); -//create an com.sun.star.embed.OLESimpleStorage from the temp stream +//create a com.sun.star.embed.OLESimpleStorage from the temp stream Sequence args(1); args[0] <<= xSeek; Reference cont( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/source
forms/source/xforms/propertysetbase.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 466a98b5ad26245f182166eece19fe16219feed3 Author: Andrea Gelmini AuthorDate: Tue May 14 21:23:15 2019 + Commit: Julien Nabet CommitDate: Tue Jun 4 07:12:28 2019 +0200 Fix typo Change-Id: I1a657bd08ff7a6108a20d57d5ebe9f104fcbe3fd Reviewed-on: https://gerrit.libreoffice.org/73420 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/forms/source/xforms/propertysetbase.hxx b/forms/source/xforms/propertysetbase.hxx index 409a4a6ebc8c..d46901e0a39c 100644 --- a/forms/source/xforms/propertysetbase.hxx +++ b/forms/source/xforms/propertysetbase.hxx @@ -240,7 +240,7 @@ protected: any notifications if the "current value" is also - which might be wrong, since the guessing of the "old value" differed from the real initial value which was . -Too confusing? Okay, than just call this method for every property you have. +Too confusing? Okay, then just call this method for every property you have. @param nHandle the handle of the property. Must denote a property supported by this instance, i.e. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/qa
forms/qa/complex/forms/CheckOGroupBoxModel.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1dfcec6ae560a0d7fdafbb5f9298e7d71f253b37 Author: Andrea Gelmini AuthorDate: Tue May 14 21:23:35 2019 + Commit: Julien Nabet CommitDate: Tue Jun 4 07:09:06 2019 +0200 Fix typo Change-Id: Ib72667f1360e190b15eac187b46fc563b9f65524 Reviewed-on: https://gerrit.libreoffice.org/73419 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/forms/qa/complex/forms/CheckOGroupBoxModel.java b/forms/qa/complex/forms/CheckOGroupBoxModel.java index 284840de3649..807d14c4fff1 100644 --- a/forms/qa/complex/forms/CheckOGroupBoxModel.java +++ b/forms/qa/complex/forms/CheckOGroupBoxModel.java @@ -113,7 +113,7 @@ public class CheckOGroupBoxModel } } // endfor -//get a array of bound properties +//get an array of bound properties String[] testPropsNames = tNames.toArray(new String[tNames.size()]); return testPropsNames; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125672] Fix AOL Mail Sign In Problems
https://bugs.documentfoundation.org/show_bug.cgi?id=125672 Email Help changed: What|Removed |Added Component|General |LibreOffice Product|Document Liberation Project |LibreOffice Online URL||https://getemailservices.co ||m/aol-mail-login/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125672] New: Fix AOL Mail Sign In Problems
https://bugs.documentfoundation.org/show_bug.cgi?id=125672 Bug ID: 125672 Summary: Fix AOL Mail Sign In Problems Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: emailonlinehelpl...@gmail.com If you are in trouble to login in your AOL account, contact AOL Support team to fix AOL Mail Sign In Problems. Visit our blog post, URL: https://getemailservices.com/aol-mail-login/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Mark Hung changed: What|Removed |Added Depends on||114272 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114272 [Bug 114272] [macOS] Some Asian characters are garbled with western fonts. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114272] [macOS] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 Mark Hung changed: What|Removed |Added Blocks||83066 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83066 [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92161] GBK encoded Chinese text not auto-detected
https://bugs.documentfoundation.org/show_bug.cgi?id=92161 Mark Hung changed: What|Removed |Added Blocks||113194 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113194 [Bug 113194] [META] Simplified Chinese (zh_CN) language-specific CJK issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113194] [META] Simplified Chinese (zh_CN) language-specific CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113194 Mark Hung changed: What|Removed |Added Depends on||92161 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=92161 [Bug 92161] GBK encoded Chinese text not auto-detected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104922] in "Text Grid" tab page in Page style, maximum "lines per page" and "characters per line" are set to 154 and 233 respectively when the values given by users are over th
https://bugs.documentfoundation.org/show_bug.cgi?id=104922 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104922] in "Text Grid" tab page in Page style, maximum "lines per page" and "characters per line" are set to 154 and 233 respectively when the values given by users are over th
https://bugs.documentfoundation.org/show_bug.cgi?id=104922 --- Comment #6 from Commit Notification --- Mark Hung committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c1c3a3c619bd596e2a64e2c9b9328b4adfa990eb%5E%21 tdf#104922 recover text grid setting properly. It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/misc/pggrid.cxx | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
New commits:
commit c1c3a3c619bd596e2a64e2c9b9328b4adfa990eb
Author: Mark Hung
AuthorDate: Fri May 31 23:22:43 2019 +0800
Commit: Mark Hung
CommitDate: Tue Jun 4 06:44:31 2019 +0200
tdf#104922 recover text grid setting properly.
Lines per page and chars per line can not be set before the
max values determined, otherwise we may get incorrect result
because of truncating to incorrect max values.
Change-Id: I9829af0dcfd744f4383a5f9034270b00fdfb15b8
Reviewed-on: https://gerrit.libreoffice.org/73280
Tested-by: Jenkins
Reviewed-by: Mark Hung
diff --git a/sw/source/ui/misc/pggrid.cxx b/sw/source/ui/misc/pggrid.cxx
index dbef0e81300b..860f913985cd 100644
--- a/sw/source/ui/misc/pggrid.cxx
+++ b/sw/source/ui/misc/pggrid.cxx
@@ -171,6 +171,8 @@ bool SwTextGridPage::FillItemSet(SfxItemSet *rSet)
voidSwTextGridPage::Reset(const SfxItemSet *rSet)
{
+sal_Int32 nLinesPerPage = 0;
+
if(SfxItemState::DEFAULT <= rSet->GetItemState(RES_TEXTGRID))
{
const SwTextGridItem& rGridItem = rSet->Get(RES_TEXTGRID);
@@ -185,7 +187,8 @@ voidSwTextGridPage::Reset(const SfxItemSet *rSet)
m_xDisplayCB->set_active(rGridItem.IsDisplayGrid());
GridTypeHdl(*pButton);
m_xSnapToCharsCB->set_active(rGridItem.IsSnapToChars());
-m_xLinesPerPageNF->set_value(rGridItem.GetLines());
+nLinesPerPage = rGridItem.GetLines();
+
SetLinesOrCharsRanges(*m_xLinesRangeFT , m_xLinesPerPageNF->get_max());
m_nRubyUserValue = rGridItem.GetBaseHeight();
m_bRubyUserValue = true;
@@ -198,6 +201,9 @@ voidSwTextGridPage::Reset(const SfxItemSet *rSet)
}
UpdatePageSize(*rSet);
+if (nLinesPerPage > 0)
+m_xLinesPerPageNF->set_value(nLinesPerPage);
+
m_xNoGridRB->save_state();
m_xLinesGridRB->save_state();
m_xSnapToCharsCB->save_state();
@@ -301,8 +307,9 @@ void SwTextGridPage::UpdatePageSize(const SfxItemSet& rSet)
if ( m_bSquaredMode )
{
-m_xCharsPerLineNF->set_value(m_aPageSize.Width() / nTextSize);
-m_xCharsPerLineNF->set_max(m_xCharsPerLineNF->get_value());
+sal_Int32 nCharsPerLine = m_aPageSize.Width() / nTextSize;
+m_xCharsPerLineNF->set_max(nCharsPerLine);
+m_xCharsPerLineNF->set_value(nCharsPerLine);
m_xLinesPerPageNF->set_max(m_aPageSize.Height() /
(
m_xTextSizeMF->denormalize(m_xTextSizeMF->get_value(FieldUnit::TWIP)) +
m_xRubySizeMF->denormalize(m_xRubySizeMF->get_value(FieldUnit::TWIP;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125542] Can't close editor via "X" of window manager
https://bugs.documentfoundation.org/show_bug.cgi?id=125542 --- Comment #6 from BottleOnTheGround --- Created attachment 151893 --> https://bugs.documentfoundation.org/attachment.cgi?id=151893=edit Screenshot of where to close the formula window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73953] UI Writer, enhancement request: Allow adjustment of comment bar width
https://bugs.documentfoundation.org/show_bug.cgi?id=73953 --- Comment #9 from BottleOnTheGround --- I also vote for this feature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125632] Enhancement: Enable resizing of comment column
https://bugs.documentfoundation.org/show_bug.cgi?id=125632 --- Comment #2 from BottleOnTheGround --- Interesting. The other Bug did not show up on the bug search. Thank you for point ing out. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125399] Can't open file from an MTP device, such as a phone
https://bugs.documentfoundation.org/show_bug.cgi?id=125399 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125607] URL to folder / directory no longer working in LO 6.2.4.2 for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=125607 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125386] Export as PNG is NOT scaling up when using Multi-language.
https://bugs.documentfoundation.org/show_bug.cgi?id=125386 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125380] FILESAVE XLSX write includes col record incompatible with LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=125380 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125398] Shadow shows on inserted images in doc/pdf files
https://bugs.documentfoundation.org/show_bug.cgi?id=125398 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125398] Shadow shows on inserted images in doc/pdf files
https://bugs.documentfoundation.org/show_bug.cgi?id=125398 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121125] Impress video show interference
https://bugs.documentfoundation.org/show_bug.cgi?id=121125 --- Comment #4 from QA Administrators --- Dear fusion_energy, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118855] Black Box or UI glitch appearing when maximizing a window from Taskbar in WIndows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=118855 --- Comment #6 from QA Administrators --- Dear revsamtp, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117851] "LibreOffice" top-level menu entry on macOS stays highlighted/selected while the About or Preferences dialog is open
https://bugs.documentfoundation.org/show_bug.cgi?id=117851 --- Comment #7 from QA Administrators --- Dear Tor Lillqvist, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118974] Writer Spell check slow
https://bugs.documentfoundation.org/show_bug.cgi?id=118974 --- Comment #8 from QA Administrators --- Dear stefan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120666] FILESAVE does not save master view
https://bugs.documentfoundation.org/show_bug.cgi?id=120666 --- Comment #7 from QA Administrators --- Dear john, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106586] Android viewer displays garbage when panning / zooming spreadsheets
https://bugs.documentfoundation.org/show_bug.cgi?id=106586 --- Comment #6 from QA Administrators --- Dear Keith Curtis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121918] Open word attachment to a GMail file crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=121918 --- Comment #3 from QA Administrators --- Dear Roy Dyton, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98522] Format of navigationbar in tablecontrols differ while zooming form
https://bugs.documentfoundation.org/show_bug.cgi?id=98522 --- Comment #7 from QA Administrators --- Dear robert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99792] Formula objects display eight handles but none of them can be used for anything
https://bugs.documentfoundation.org/show_bug.cgi?id=99792 --- Comment #10 from QA Administrators --- Dear Tor Lillqvist, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41304] EDITING: Cell formula shown without colors, colored frames missing around referenced cells
https://bugs.documentfoundation.org/show_bug.cgi?id=41304 --- Comment #15 from QA Administrators --- Dear stallersattel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35847] [UI] Wrong page style name in status bar after page preview
https://bugs.documentfoundation.org/show_bug.cgi?id=35847 --- Comment #11 from QA Administrators --- Dear Laurent BP, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121072] FILEOPEN PPTX: can't open powerpoint file that opens only with Office 365
https://bugs.documentfoundation.org/show_bug.cgi?id=121072 --- Comment #8 from QA Administrators --- Dear Fahad Al-Saidi, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115077] Merge mail wizard send empty images by mail in HTML format
https://bugs.documentfoundation.org/show_bug.cgi?id=115077 --- Comment #8 from QA Administrators --- Dear worms, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34850] incorrect positioning when dragging newly-created frame (editing formatting ui)
https://bugs.documentfoundation.org/show_bug.cgi?id=34850 --- Comment #12 from QA Administrators --- Dear Lawrence D'Oliveiro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Thorsten Behrens (CIB) changed: What|Removed |Added Depends on||125518 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125518 [Bug 125518] docx export: diagrams anchor and wrapping are not exported -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125646] calc undo doesn't separate auto-corrupt and user changes
https://bugs.documentfoundation.org/show_bug.cgi?id=125646 --- Comment #6 from Anthony Youngman --- (In reply to Jacques Guilleron from comment #5) > Hi Anthony, > > You can edit the cell content and use CTRL+M, to delete the URL formatting > and get a simple text Just tried it - doesn't work! > or, if you don't want at all URL Recognition, type > Tools > AutoCorrect Options... > select Options Tab and uncheck URL Recognition. > And how many people are going to know - or find - that? There's a reason I consider this a very nasty papercut bug - you should NOT leave your typical user cursing and swearing because they can't work out how to stop LO corrupting the text they typed in. I appreciate actually fixing the bug might be a lot harder than it looks, but with things as they currently stand, fixing the user's document is a lot harder than it should be. Much as I hate praising MS Office, it gets it right. It *ALWAYS* marks the user's changes and auto-correct changes as *SEPARATE* edits so you can undo one and not the other. LibreOffice, in *too* *many* places, conflates the changes so the user is stuffed with a choice of either the pre-edit state, or the post-corruption state, with no way to get to the desired state of "just give me what I typed, for fuck's sake!!!" And no - expecting the user to know esoteric work-arounds like you suggested is not a good solution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125671] New: Calc stops accepting keyboard input after pasting into a cell with data
https://bugs.documentfoundation.org/show_bug.cgi?id=125671 Bug ID: 125671 Summary: Calc stops accepting keyboard input after pasting into a cell with data Product: LibreOffice Version: 6.2.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s.stefa...@gmail.com Description: Calc 6.2.2.2 on KUbuntu Linux. After pasting text in a cell that already contains text calc stops accepting keyboard input for several seconds. This is very reproducible (see steps below). I also have seen a similar behavior in Writer but it seems to be harder to reproduce. It sometimes stops accepting input when a certain document is opened or after pasting a certain piece of document. Not reproducible with all documents (though a document that is affected seems to be always affected). I apologize if this has already been reported. I couldn't find a similar bug. Steps to Reproduce: 1. open Calc under Ubuntu linux (others?) 2. Type text in cell B3 = FOO 3. Type text in cell B4 = BAR 4. Hit CTRL+C to copy text from cell B4 5. Move to cell B3 6. Hit CTRL+V to paste the text. 7. Choose "Yes" in the dialog that warns about pasting data in a cell that already contains data 8. Now try to input text anywhere: it doesn't work for 20-30 seconds. Actual Results: Calc stops accepting keyboard input. Expected Results: Calc accepts keyboard input as usual. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.2.2 Build ID: 1:6.2.2-0ubuntu2 CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: kde5; Locale: en-GB (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Frame.hxx |1
vcl/qt5/Qt5Frame.cxx | 123 ++-
2 files changed, 28 insertions(+), 96 deletions(-)
New commits:
commit d8d8cdecdb760500b06cacef3d17c8e05332967d
Author: Jan-Marek Glogowski
AuthorDate: Sun Jun 2 15:38:25 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Tue Jun 4 02:25:33 2019 +0200
Qt5 introduce Qt5Frame::asChild() helper
Just a little refactoring.
Gets rid of the common used idom in the code:
m_pTopLevel ? m_pTopLevel : m_pQWidget
Change-Id: I3e96687d9d02c0b1a5537c6b6cea53e1ca3a2067
Reviewed-on: https://gerrit.libreoffice.org/73414
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 16743edc0fc6..3b590bd8e28c 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -123,6 +123,7 @@ public:
QWidget* GetQWidget() const { return m_pQWidget; }
Qt5MainWindow* GetTopLevelWindow() const { return m_pTopLevel; }
+QWidget* asChild() const;
void Damage(sal_Int32 nExtentsX, sal_Int32 nExtentsY, sal_Int32
nExtentsWidth,
sal_Int32 nExtentsHeight) const;
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index a4ad672bab16..a9ffbf7756aa 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -140,13 +140,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
if (aWinFlags == Qt::Window)
{
-QWidget* pParentWidget = nullptr;
-if (m_pParent)
-{
-pParentWidget
-= (m_pParent->m_pTopLevel) ? m_pParent->m_pTopLevel :
m_pParent->m_pQWidget;
-}
-
+QWidget* pParentWidget = m_pParent ? m_pParent->asChild() : nullptr;
m_pTopLevel = new Qt5MainWindow(*this, pParentWidget, aWinFlags);
m_pQWidget = new Qt5Widget(*this, aWinFlags);
m_pTopLevel->setCentralWidget(m_pQWidget);
@@ -160,8 +154,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
if (pParent && !(pParent->m_nStyle & SalFrameStyleFlags::PLUG))
{
QWindow* pParentWindow =
pParent->GetQWidget()->window()->windowHandle();
-QWindow* pChildWindow = (m_pTopLevel ?
m_pTopLevel->window()->windowHandle()
- :
m_pQWidget->window()->windowHandle());
+QWindow* pChildWindow = asChild()->window()->windowHandle();
if (pParentWindow && pChildWindow && (pParentWindow != pChildWindow))
pChildWindow->setTransientParent(pParentWindow);
}
@@ -218,10 +211,7 @@ Qt5Frame::~Qt5Frame()
{
Qt5Instance* pInst = static_cast(GetSalData()->m_pInstance);
pInst->eraseFrame(this);
-if (m_pTopLevel)
-delete m_pTopLevel;
-else
-delete m_pQWidget;
+delete asChild();
m_aSystemData.aShellWindow = 0;
}
@@ -303,60 +293,31 @@ bool Qt5Frame::PostEvent(std::unique_ptr
pData)
return true;
}
-bool Qt5Frame::isWindow() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isWindow();
-else
-return m_pQWidget->isWindow();
-}
+QWidget* Qt5Frame::asChild() const { return m_pTopLevel ? m_pTopLevel :
m_pQWidget; }
+
+bool Qt5Frame::isWindow() const { return asChild()->isWindow(); }
QWindow* Qt5Frame::windowHandle() const
{
// set attribute 'Qt::WA_NativeWindow' first to make sure a window handle
actually exists
-if (m_pTopLevel)
-{
-m_pTopLevel->setAttribute(Qt::WA_NativeWindow);
-return m_pTopLevel->windowHandle();
-}
-else
-{
-m_pQWidget->setAttribute(Qt::WA_NativeWindow);
-return m_pQWidget->windowHandle();
-}
+QWidget* pChild = asChild();
+pChild->setAttribute(Qt::WA_NativeWindow);
+return pChild->windowHandle();
}
QScreen* Qt5Frame::screen() const
{
QWindow* const pWindow = windowHandle();
-if (pWindow)
-return pWindow->screen();
-else
-return nullptr;
+return pWindow ? pWindow->screen() : nullptr;
}
-bool Qt5Frame::isMinimized() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isMinimized();
-else
-return m_pQWidget->isMinimized();
-}
+bool Qt5Frame::isMinimized() const { return asChild()->isMinimized(); }
-bool Qt5Frame::isMaximized() const
-{
-if (m_pTopLevel)
-return m_pTopLevel->isMaximized();
-else
-return m_pQWidget->isMaximized();
-}
+bool Qt5Frame::isMaximized() const { return asChild()->isMaximized(); }
void Qt5Frame::SetWindowStateImpl(Qt::WindowStates eState)
{
-if (m_pTopLevel)
-m_pTopLevel->setWindowState(eState);
-else
-m_pQWidget->setWindowState(eState);
+return asChild()->setWindowState(eState);
}
void Qt5Frame::SetTitle(const OUString& rTitle)
@@ -400,13 +361,7 @@ void Qt5Frame::DrawMenuBar() { /* not needed */}
void Qt5Frame::SetExtendedFrameStyle(SalExtStyle
[Libreoffice-bugs] [Bug 65260] FILEOPEN: DOCX imports Wordart as simple text box
https://bugs.documentfoundation.org/show_bug.cgi?id=65260 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #9 from Regina Henschel --- Such text decoration is still not available. Tested withVersion: 6.3.0.0.alpha1+ (x64) Build ID: bfd26fd04ba06d0eac3fb516c6548a1e6eacc6df CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125201] Scrolling down on Touchpad erratic (6.2.3.2 on Ubuntu 18.04)
https://bugs.documentfoundation.org/show_bug.cgi?id=125201 --- Comment #3 from Henrique SantAnna --- I can confirm it affects VCL: kde5; and VCL: qt5; but does not affect VCL: gtk3 It is reproducible with touch-pad scrolling, but is not with external usb mouse scrolling. Tested with: Version: 6.3.0.0.alpha1+ Build ID: 77ae0abe21f672cf4b7d2e069f1d40d20edc49a7 CPU threads: 4; OS: Linux 5.1; UI render: default; VCL: kde5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-31_15:33:33 Locale: pt-BR (pt_BR.UTF-8); UI-Language: en-US Calc: threaded And with: Versão: 6.2.4.2.0+ ID de compilação: 6.2.4-1 Threads da CPU:4; SO:Linux 5.1; Realizador da interface: GL; VCL: kde5; Local: pt-BR (pt_BR.UTF-8); Idioma de IU: pt-BR Calc: threaded The same behavior, with the fresh and the daily versions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125646] calc undo doesn't separate auto-corrupt and user changes
https://bugs.documentfoundation.org/show_bug.cgi?id=125646 --- Comment #5 from Jacques Guilleron --- Hi Anthony, You can edit the cell content and use CTRL+M, to delete the URL formatting and get a simple text or, if you don't want at all URL Recognition, type Tools > AutoCorrect Options... select Options Tab and uncheck URL Recognition. Cordially, Jacques -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 --- Comment #6 from DErik --- Included three files, FODT, OTT, and ODT to help diagnose and determine problem. File was created simply from a "New ..." command with the OTT included here as the default template to use when created new ODFs. None of the files have been edited, which is why the ODT and FODT have a lot of "garbage" in them. I left that stuff in the template to let me know what style each paragraph was actually assigned to it in an attempt to figure out how changing the style of the paragraph or the basic style configuration itself affected the objective paragraph and other paragraphs. Didn't really help me much; just confused me because of the various ways the changes I made to the paragraph style or the basic style was applied, or not applied. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 --- Comment #5 from DErik --- Created attachment 151892 --> https://bugs.documentfoundation.org/attachment.cgi?id=151892=edit Initially created and unedited file from template. Third of three files to diagnose and detect problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 --- Comment #4 from DErik --- Created attachment 151891 --> https://bugs.documentfoundation.org/attachment.cgi?id=151891=edit Template used to create the FODT Second of three files to diagnose and detect problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125373] Paragraph style editing and application is not applied to the paragraph properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=125373 --- Comment #3 from DErik --- Created attachment 151890 --> https://bugs.documentfoundation.org/attachment.cgi?id=151890=edit Flat ODF of unedited new file from template One of three files attached to help diagnose and detect problems. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/core/layout/calcmove.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 344275e11e24084c970ff19acfeed3ddf50d58bb
Author: Michael Stahl
AuthorDate: Sun Jun 2 13:58:01 2019 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 4 01:00:06 2019 +0200
tdf#119109 sw: tweak assertion in PrepareMake()
Empty section frames cause trouble for the assert added in
e14056e6e88d9b8d988b7b88b2776a8fc952031b:
* existing ones may be skipped by MoveBwd(), so a SwTextFrame moves to
the previous page but the SwSectionFrame that was its mpPrev remains
on this page; e.g. ooo110854-1.rtf
* a SwSectionFrame moves backward, then some SwTextFrame in it splits
and the follow tries to move forward, resulting in *new*
SwSectionFrames on this page that are empty (because the follow is
eventually joined again); e.g. abi3213-1.rtf
So if there's a section frame, assume it's SNAFU and don't assert.
Change-Id: Ibdca2aa39fae123583e5edf5173f80e8b70ef335
Reviewed-on: https://gerrit.libreoffice.org/7
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 1416c5426a757d32f223cab46bf9038bd7f21d48)
Reviewed-on: https://gerrit.libreoffice.org/73380
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/layout/calcmove.cxx
b/sw/source/core/layout/calcmove.cxx
index 051bd6ca5a9c..fc4bc4567079 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -319,6 +319,8 @@ void SwFrame::PrepareMake(vcl::RenderContext*
pRenderContext)
if (isLast && pFrame->GetUpper() != GetUpper())
{
assert(GetUpper()->Lower() == this
+// empty section frames are created all the time...
+|| GetUpper()->Lower()->IsSctFrame()
// tab frame/section frame may split multiple times
|| ( SwFlowFrame::CastFlowFrame(pFrame)
&&
SwFlowFrame::CastFlowFrame(GetUpper()->Lower())
@@ -441,6 +443,8 @@ void SwFrame::PrepareCursor()
if (isLast && pFrame->GetUpper() != GetUpper())
{
assert(GetUpper()->Lower() == this
+// empty section frames are created all the time...
+|| GetUpper()->Lower()->IsSctFrame()
// tab frame/section frame may split multiple times
|| ( SwFlowFrame::CastFlowFrame(pFrame)
&& SwFlowFrame::CastFlowFrame(GetUpper()->Lower())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=125670 Jan-Marek Glogowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |glo...@fbihome.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125007] AdoptOpenJDK is not recognized as JRE
https://bugs.documentfoundation.org/show_bug.cgi?id=125007 --- Comment #7 from Kenneth --- Confirm problem. OS and LO versions: OpenSUSE Tumbleweed x86_64 current as of right now. libreoffice-6.2.3.2-4.2.x86_64 libreoffice-base-6.2.3.2-4.2.x86_64 libreoffice-base-drivers-firebird-6.2.3.2-4.2.x86_64 libreoffice-branding-upstream-6.2.3.2-4.2.noarch libreoffice-calc-6.2.3.2-4.2.x86_64 libreoffice-draw-6.2.3.2-4.2.x86_64 libreoffice-filters-optional-6.2.3.2-4.2.x86_64 libreoffice-icon-themes-6.2.3.2-4.2.noarch libreoffice-impress-6.2.3.2-4.2.x86_64 libreoffice-l10n-en-6.2.3.2-4.2.noarch libreoffice-mailmerge-6.2.3.2-4.2.x86_64 libreoffice-math-6.2.3.2-4.2.x86_64 libreoffice-pyuno-6.2.3.2-4.2.x86_64 libreoffice-qt5-6.2.3.2-4.2.x86_64 libreoffice-share-linker-1-4.6.noarch libreoffice-writer-6.2.3.2-4.2.x86_64 java-1_8_0-openjdk-1.8.0.212-1.2.x86_64 java-1_8_0-openjdk-devel-1.8.0.212-1.2.x86_64 java-1_8_0-openjdk-headless-1.8.0.212-1.2.x86_64 java-1_8_0-openjdk-javadoc-1.8.0.212-1.2.noarch -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120774] kde5: Rearranging Impress slides via drag'n'drop not always working as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=120774 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.2.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120774] kde5: Rearranging Impress slides via drag'n'drop not always working as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=120774 --- Comment #8 from Commit Notification --- Katarina Behrens committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/901a356a4e2ce7b598fb600025baa1c09267a2bc%5E%21 tdf#120774: in 6.2, restrict workaround to kde4 vclplug only It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sd/source
sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx | 102
--
sd/source/ui/slidesorter/inc/controller/SlsSelectionFunction.hxx |2
2 files changed, 51 insertions(+), 53 deletions(-)
New commits:
commit 901a356a4e2ce7b598fb600025baa1c09267a2bc
Author: Katarina Behrens
AuthorDate: Mon Jun 3 18:14:31 2019 +0200
Commit: Thorsten Behrens
CommitDate: Tue Jun 4 00:56:03 2019 +0200
tdf#120774: in 6.2, restrict workaround to kde4 vclplug only
Fix of tdf#41996 is a workaround of kde4-specific condition and
has been since disabled on OS X (as tdf#51023). kde5 comes with
a new implementation of DnD and slide sorter in Impress now
exhibits exactly the same symptoms as on OS X in tdf#51023
Assuming that in 6.2 kde5 doesn't need this workaround anymore and
remaining platforms -- gtk[23] and Win -- never had issues with DnD
in slide sorter, keep it active only for kde4 vclplug.
We can't kill it with fire in its entirety, because kde4 has been
obsoleted only post-6.2
Change-Id: I1fd8bb9e5142ebd43f3a8bead417832c808c
Reviewed-on: https://gerrit.libreoffice.org/73403
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx
b/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx
index 4a3b05b1..2505486e5a8a 100644
--- a/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx
@@ -61,6 +61,7 @@
#include
#include
#include
+#include
#include
#include
@@ -225,17 +226,12 @@ public:
MultiSelectionModeHandler (
SlideSorter& rSlideSorter,
SelectionFunction& rSelectionFunction,
-#ifndef MACOSX
-const Point& rMouseModelPosition);
-#else
const Point& rMouseModelPosition,
-const sal_uInt32 nEventCode);
-#endif
+const sal_uInt32 nEventCode,
+bool bKDE4);
virtual ~MultiSelectionModeHandler() override;
-#ifndef MACOSX
void Initialize(const sal_uInt32 nEventCode);
-#endif
virtual SelectionFunction::Mode GetMode() const override;
virtual void Abort() override;
@@ -258,6 +254,7 @@ private:
bool mbAutoScrollInstalled;
sal_Int32 mnAnchorIndex;
sal_Int32 mnSecondIndex;
+bool mbKDE4;
void UpdateModelPosition (const Point& rMouseModelPosition);
void UpdateSelection();
@@ -281,18 +278,13 @@ class DragAndDropModeHandler : public
SelectionFunction::ModeHandler
public:
DragAndDropModeHandler (
SlideSorter& rSlideSorter,
-#ifndef MACOSX
-SelectionFunction& rSelectionFunction);
-#else
SelectionFunction& rSelectionFunction,
const Point& rMousePosition,
-vcl::Window* pWindow);
-#endif
+vcl::Window* pWindow,
+bool bKDE4);
virtual ~DragAndDropModeHandler() override;
-#ifndef MACOSX
void Initialize(const Point& rMousePosition, vcl::Window* pWindow);
-#endif
virtual SelectionFunction::Mode GetMode() const override;
virtual void Abort() override;
@@ -303,6 +295,7 @@ protected:
private:
std::unique_ptr> mpDragAndDropContext;
+bool mbKDE4;
};
//= SelectionFunction =
@@ -322,6 +315,7 @@ SelectionFunction::SelectionFunction (
mnShiftKeySelectionAnchor(-1),
mpModeHandler(new NormalModeHandler(rSlideSorter, *this))
{
+mbKDE4 = Application::GetToolkitName() == "kde4";
}
SelectionFunction::~SelectionFunction()
@@ -684,18 +678,21 @@ void SelectionFunction::SwitchToDragAndDropMode (const
Point& rMousePosition)
{
if (mpModeHandler->GetMode() != DragAndDropMode)
{
-#ifndef MACOSX
-std::shared_ptr handler(
-new DragAndDropModeHandler(mrSlideSorter, *this));
-SwitchMode(handler);
-// Delayed initialization, only after mpModeHanler is set, otherwise
DND initialization
-// could already trigger DND events, which would recursively trigger
this code again,
-// and without mpModeHandler set it would again try to set a new
handler.
-handler->Initialize(rMousePosition, mpWindow);
-#else
-SwitchMode(std::shared_ptr(
-new DragAndDropModeHandler(mrSlideSorter, *this, rMousePosition,
mpWindow)));
-#endif
+if (mbKDE4)
+{
+std::shared_ptr handler(
+new DragAndDropModeHandler(mrSlideSorter, *this,
rMousePosition, mpWindow, mbKDE4));
+SwitchMode(handler);
+// Delayed initialization, only after mpModeHanler is set,
otherwise DND initialization
+// could already trigger DND events, which would recursively
trigger this code again,
+// and without mpModeHandler set it would again try to set a new
handler.
+handler->Initialize(rMousePosition, mpWindow);
+}
+else
+{
+
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 84771b5cc0caa60bcd6f15868fe9b516c3e8f3a7 Author: Olivier Hallot AuthorDate: Sat Jun 1 13:11:27 2019 +0200 Commit: Gerrit Code Review CommitDate: Tue Jun 4 00:36:42 2019 +0200 Update git submodules * Update helpcontent2 from branch 'master' - fix icon size Change-Id: I9550ef8ccf4d10ad393ed615573ab9893632f371 Reviewed-on: https://gerrit.libreoffice.org/73305 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 3e4a49f5e61c..9a0f4fb18ab7 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3e4a49f5e61c535044538a23eaf7a6b222a7c57a +Subproject commit 9a0f4fb18ab7832dbafb4b789279411f5aa8cecd ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/swriter/guide/arrange_chapters.xhp |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9a0f4fb18ab7832dbafb4b789279411f5aa8cecd Author: Olivier Hallot AuthorDate: Sat Jun 1 13:11:27 2019 +0200 Commit: Olivier Hallot CommitDate: Tue Jun 4 00:36:42 2019 +0200 fix icon size Change-Id: I9550ef8ccf4d10ad393ed615573ab9893632f371 Reviewed-on: https://gerrit.libreoffice.org/73305 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/guide/arrange_chapters.xhp b/source/text/swriter/guide/arrange_chapters.xhp index 3a330cab2..693b024fb 100644 --- a/source/text/swriter/guide/arrange_chapters.xhp +++ b/source/text/swriter/guide/arrange_chapters.xhp @@ -59,12 +59,12 @@ - + Drag a heading to a new location in the Navigator list. -Click a heading in the Navigator list, and then click the Promote Chapter Icon or Demote Chapter icon Icon. +Click a heading in the Navigator list, and then click the Promote Chapter Icon promote or Demote Chapter icon Icon demote. To move the heading without the subordinate text, hold down CommandCtrl while you drag or click the Promote Chapter or Demote Chapter icons. @@ -76,7 +76,7 @@ Select the heading in the Navigator list. -Click the Promote Level Icon promote level or Demote Level icon Icon. +Click the Promote Level Icon promote level or Demote Level icon Icon demote level. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 96459, which changed state. Bug 96459 Summary: Unicode ExtB+ chars are badly handled in Impress https://bugs.documentfoundation.org/show_bug.cgi?id=96459 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96459] Unicode ExtB+ chars are badly handled in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=96459 Mark Hung changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #7 from Mark Hung --- Hi, I'm closing this issue because multiple test cases have been included in this issue. Each test case has its own test file and steps to reproduce. Reporting several test cases together makes it hard to communicate the status of the issue . I'm sure some of the test cases in this issue have been fixed. Please feel free to report each test case as a separate issue. Note: If the issues are related to file format, then each of the file format owes its own test case. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=125670 MM changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from MM --- Confirmed on windows 7 x64 with Version: 6.2.4.2 (x64) Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU threads: 3; OS: Windows 6.1; UI render: default; VCL: win crashreport.libreoffice.org/stats/crash_details/fc4b2310-70ee-4462-aa7c-3563953cec45 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96458] Unicode ExtB+ chars are badly handled in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=96458 Mark Hung changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #13 from Mark Hung --- Hi, I'm closing this issue because multiple test cases have been included in this issue. Each test case has its own test file and steps to reproduce. Reporting several test cases together makes it hard to communicate the status of the issue . I'm sure some of the test cases in this issue have been fixed. Please feel free to report each test case as a separate issue. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 96458, which changed state. Bug 96458 Summary: Unicode ExtB+ chars are badly handled in Calc https://bugs.documentfoundation.org/show_bug.cgi?id=96458 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103342 Bug 103342 depends on bug 107487, which changed state. Bug 107487 Summary: Unicode ExtB+ chars do not use fallback font correctly in Writer https://bugs.documentfoundation.org/show_bug.cgi?id=107487 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107487] Unicode ExtB+ chars do not use fallback font correctly in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=107487 Mark Hung changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 107487, which changed state. Bug 107487 Summary: Unicode ExtB+ chars do not use fallback font correctly in Writer https://bugs.documentfoundation.org/show_bug.cgi?id=107487 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125661] Copying a large sheet is very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=125661 --- Comment #1 from Durgapriyanka --- Thank you for reporting the bug. I can reproduce the bug in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded but, Cannot reproduce in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125665] Big ODT documents take too long to load or save
https://bugs.documentfoundation.org/show_bug.cgi?id=125665 --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded Time taken to open: 1m 30secs, to save: 1m 47 secs LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 Time taken to open: 16 secs, to save: 54 secs So version 3.3 opens and saves quicker than other versions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125657] DOCX Export Document with a picture and page break doesn't open in MS Word when saved as DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=125657 Gabor Kelemen changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||mikekagan...@hotmail.com --- Comment #5 from Gabor Kelemen --- Bibisected using bibisect-linux-64-6.3 to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1fe24bb1e2fbe44a4bf2c03297e259b3a18b1235 author Mike Kaganski 2019-04-19 02:24:00 +0300 committer Mike Kaganski 2019-04-19 21:20:46 +0200 Further cleanup of FastSerializerHelper's startElement/singleElement[NS] Drop FSEND_t: C-style varargs code was replaced since version 6.0 in commit d43fc40718217d89cc95cc3c0bc0b8e7926abcc0, so it's time to remove the last bits. Drop int-to-string macros that are simple wrappers over OString::number. Avoid unnecessary string type conversions. Adding Cc: to Mike Kaganski -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125666] Deleting a (large) sheet very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=125666 Telesto changed: What|Removed |Added Version|6.4.0.0.alpha0+ Master |Inherited From OOo Keywords||perf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125641] Slow scrolling responsiveness after saving a file with lots of comments
https://bugs.documentfoundation.org/show_bug.cgi?id=125641 Telesto changed: What|Removed |Added Keywords||perf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125646] calc undo doesn't separate auto-corrupt and user changes
https://bugs.documentfoundation.org/show_bug.cgi?id=125646 --- Comment #4 from Anthony Youngman --- (In reply to Jacques Guilleron from comment #2) > Hi Anthony, > > Do you know after use of "undo", you can use "redo" or CTRL+Y? > > Jacques And what use is that? Sorry, but the problem is that user changes and autocorrupt changes are, from calc's pov, ONE change! So redo will simply take me back to where I don't want to be, with my document auto-corrupted! The problem is that there is *no way* I can stop auto-corrupt from buggering about with my text, because it thinks it's an email address. (My workaround is to enter extra text, which means that my document is "wrong", because there is no way to get it to consist of THE TEXT I ENTERED!) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125666] Deleting a (large) sheet very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=125666 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded and LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125628] FORMATTING: Part of text loose yellow highlight reopening document
https://bugs.documentfoundation.org/show_bug.cgi?id=125628 raal changed: What|Removed |Added OS|Windows (All) |All Keywords|bibisectRequest |bibisected, bisected Version|6.2.4.2 release |5.1.0.3 release CC||r...@post.cz, ||zolnaitamas2...@gmail.com --- Comment #6 from raal --- This seems to have begun at the below commit. Adding Cc: to Zolnai Tamás ; Could you possibly take a look at this one? Thanks 3f2efee4c6f30740b97075671f44f8474dbb2c9b is the first bad commit commit 3f2efee4c6f30740b97075671f44f8474dbb2c9b Author: Matthew Francis Date: Wed May 27 20:14:41 2015 +0800 source-hash-08cfbbaca2d23727bc95912082ae46b8f8a37f03 commit 08cfbbaca2d23727bc95912082ae46b8f8a37f03 Author: Zolnai Tamás AuthorDate: Sun Mar 15 15:31:09 2015 +0100 Commit: Zolnai Tamás CommitDate: Sat Mar 21 16:19:10 2015 +0100 Char highlight: editing by "Highlighting" button -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125667] comment at illogical place
https://bugs.documentfoundation.org/show_bug.cgi?id=125667 --- Comment #1 from Durgapriyanka --- I can reproduce it in both Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded and LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125669] Some columns get lost when exporting a calc file to xhtml
https://bugs.documentfoundation.org/show_bug.cgi?id=125669 Durgapriyanka changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug present in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded and I can confirm the bug present in Version: 6.1.3.2 Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group threaded Not able to convert the file into xhtml inversion 3.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/item_refactor2' - basctl/source include/item item/source item/test svx/source
basctl/source/basicide/sbxitem.cxx |1
include/item/base/ItemBase.hxx |5 +
include/item/base/ItemControlBlock.hxx | 19
include/item/base/ItemSet.hxx | 50 ---
item/source/base/ItemControlBlock.cxx | 57
item/source/base/ItemSet.cxx | 150 ++---
item/test/ItemTest.cxx | 10 --
svx/source/items/TransformAnchor.cxx |1
8 files changed, 125 insertions(+), 168 deletions(-)
New commits:
commit 6c2f575f1ace404e6f97bec5cd740b6340851667
Author: Armin Le Grand
AuthorDate: Mon Jun 3 21:36:34 2019 +0200
Commit: Armin Le Grand
CommitDate: Mon Jun 3 21:36:34 2019 +0200
WIP: Use ItemControlBlock as TypeInfo
Removed last big change to have a global static
ItemControlBlock registry. Thought about things
and what is needed/wanted is RTTI for the Items.
Instead of using typeid(T).hash_code() it is
equally possible to use the ItemControlBlock of
each Item - it exists once as global static
instance. So use it's address. That way e.g. the
ItemSet holding it *will* hjave a direct reference
to the ItemControlBlock, so no need for a global
registration.
Checked, tested, adapted, works.
Change-Id: I4c9b6bfe4ba6858b234238d6125793378574af87
diff --git a/basctl/source/basicide/sbxitem.cxx
b/basctl/source/basicide/sbxitem.cxx
index b8488d3e04d8..3618bcb5d8b8 100644
--- a/basctl/source/basicide/sbxitem.cxx
+++ b/basctl/source/basicide/sbxitem.cxx
@@ -32,7 +32,6 @@ namespace Item
static ::Item::ItemControlBlock aItemControlBlock(
[](){ return new
Sbx(ScriptDocument::getApplicationScriptDocument()); },
[](const ItemBase& rRef){ return new Sbx(static_cast(rRef)); },
-typeid(Sbx).hash_code(),
"Sbx");
return aItemControlBlock;
diff --git a/include/item/base/ItemBase.hxx b/include/item/base/ItemBase.hxx
index ee465ad7f0f9..b780df6308ab 100644
--- a/include/item/base/ItemBase.hxx
+++ b/include/item/base/ItemBase.hxx
@@ -101,7 +101,12 @@ namespace Item
// this way accessible for all incarnations - at the cost of
// one local reference
friend bool isDefault(const ItemBase& rCandidate);
+friend class ItemSet;
ItemControlBlock& m_rItemControlBlock;
+const ItemControlBlock& getItemControlBlock() const
+{
+return m_rItemControlBlock;
+}
protected:
// PutValue/Any interface for automated instance creation from SfxType
diff --git a/include/item/base/ItemControlBlock.hxx
b/include/item/base/ItemControlBlock.hxx
index 0b9e5a03069b..8029f79a8d9e 100755
--- a/include/item/base/ItemControlBlock.hxx
+++ b/include/item/base/ItemControlBlock.hxx
@@ -38,19 +38,14 @@ namespace Item
std::unique_ptr m_aDefaultItem;
std::function m_aConstructDefaultItem;
std::function m_aCloneItem;
-size_t m_aHashCode;
OUStringm_aName;
-// EmptyItemControlBlock: default constructor *only* for internal use
-ItemControlBlock();
-
public:
ItemControlBlock(
std::functionaConstructDefaultItem,
std::functionaCloneItem,
-size_t aHashCode,
const OUString& rName);
-~ItemControlBlock();
+~ItemControlBlock() = default;
const ItemBase& getDefault() const;
bool isDefault(const ItemBase& rItem) const;
@@ -60,23 +55,11 @@ namespace Item
return m_aName;
}
-size_t getHashCode() const
-{
-return m_aHashCode;
-}
-
// clone-op, secured by returning a std::unique_ptr to make
// explicit the ownership you get when calling this
std::unique_ptr clone(const ItemBase&) const;
std::unique_ptr createFromAny(const
ItemBase::AnyIDArgs& rArgs);
-
-// static access to registered ItemControlBlocks
-static ItemControlBlock* getItemControlBlock(size_t HashCode);
-template< typename TItem > ItemControlBlock* getItemControlBlock()
-{
-return getItemControlBlock(typeid(TItem).HashCode());
-}
};
} // end of namespace Item
diff --git a/include/item/base/ItemSet.hxx b/include/item/base/ItemSet.hxx
index e78d8a55565f..e400fff73959 100644
--- a/include/item/base/ItemSet.hxx
+++ b/include/item/base/ItemSet.hxx
@@ -216,14 +216,14 @@ namespace Item
ModelSpecificItemValues::SharedPtr m_aModelSpecificIValues;
// the items as content
-std::unordered_map m_aItems;
+std::unordered_map m_aItems;
// helpers for reduction of template member implementations,
-// all based on typeid().hash_code()
-const ItemBase* implGetStateAndItem(size_t hash_code, IState& rIState,
bool bSearchParent)
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - avmedia/source
avmedia/source/gstreamer/gstplayer.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit e8eb9cf446ea6525284749f78fce6623170cb39b
Author: Caolán McNamara
AuthorDate: Tue Feb 19 10:18:16 2019 +
Commit: Katarina Behrens
CommitDate: Mon Jun 3 22:28:40 2019 +0200
gst 0.10 doesn't have gst_video_overlay_set_render_rectangle
Change-Id: I499e32ce86fabd18c52ac2f99713af0933572f7c
(cherry picked from commit abd6f2a38506f512d4846cf43a9fc9576d96ceb3)
Reviewed-on: https://gerrit.libreoffice.org/73395
Tested-by: Jenkins
Reviewed-by: Katarina Behrens
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index fb2193b3f67d..e900ed96ba47 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -515,9 +515,10 @@ GstBusSyncReply Player::processSyncMessage( GstMessage
*message )
if ( mnWindowID != 0 )
{
gst_video_overlay_set_window_handle( mpXOverlay, mnWindowID );
-
+#ifndef AVMEDIA_GST_0_10
if (maArea.Width > 0 && maArea.Height > 0)
gst_video_overlay_set_render_rectangle(mpXOverlay,
maArea.X, maArea.Y, maArea.Width, maArea.Height);
+#endif
}
return GST_BUS_DROP;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=125670 --- Comment #2 from Laurent BP --- Crash with Version: 6.2.4.2 Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125660] COMPARE DOCUMENTS: Crash in swlo!SwRedlineData::SetSeqNo
https://bugs.documentfoundation.org/show_bug.cgi?id=125660 raal changed: What|Removed |Added CC|s.mehrbr...@gmail.com |michael.st...@cib.de --- Comment #4 from raal --- (In reply to Telesto from comment #3) > @Raal > Slightly confused: Redline = Michael Stahl; as far I know Sorry, my fault -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=125670 Laurent BP changed: What|Removed |Added Attachment #151888|0 |1 is obsolete|| --- Comment #1 from Laurent BP --- Created attachment 151889 --> https://bugs.documentfoundation.org/attachment.cgi?id=151889=edit Update version without Master pages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Saving documents with broken zip streams (Re: minutes of ESC call ...)
Am 03.06.19 um 21:52 schrieb Luboš Luňák: > On Monday 03 of June 2019, Caolán McNamara wrote: >> On Mon, 2019-06-03 at 12:23 +0200, Luboš Luňák wrote: >>> On Thursday 30 of May 2019, Michael Meeks wrote: + some in the zip area - assuming they are threading related. >>> >>> Is this about those documents such >>> as /srv/crashtestdata/files/caolan/opendocument_stack_overflow_2.odt >>> ? How >>> can I reproduce that problem? If I try to fetch >>> buildsl...@vm138.documentfoundation.org: >>> an/opendocument_stack_overflow_2.odt , >>> it doesn't exist. >> >> I attach two of the examples here. The input name was foo.sample, the >> output to odt name appears higher up in the bt during the export. >> >> ./instdir/program/soffice.bin --headless --convert-to odt >> opendocument_stack_overflow.sample > > > Ok, so it's not a problem with my code, my changes just happened to show the > problem, and the problem is that those documents are broken. If you try to > unzip the documents, it will complain about incorrect CRC (although it still > will uncompress them). And what happens is that when we try to save the file, > apparently only by that point we'll read those zip streams, there will be a > ZipException about that, and the code in package/ is not exception-safe. So > ZipOutputStream::writeLOC() gets called but not the matching > ZipOutputStream::rawCloseEntry(). > > But this is actually broken on several levels. If I make the code to catch > the exception better, I'll need to make it somehow handle the fact that > writeLOC() prepared for writing en entry, but then there's nothing to write. > But that's actually not important, since ZipPackageStream::saveChild() will > still return failure, so ZipPackageFolder::saveContents() will throw an > exception, making the whole document saving fail. Which in turn means this > whole save business is irrelevant, as there's just no way to save the > document, even though we can load it and we can edit it. Which seems rather > lame. > > Any idea what to do about that? Is it really ok that we just refuse to save > it? Or should we save it even though the contents may be broken? IMHO the only sane solution would be to detect the broken CRCs on read and report a broken file to the user. Eventually we could offer some recovery option: mark the broken CRCs to be recalculated and keep the stuff or drop the broken ZIP entries. I guess most users can't make this decision, so I would opt for optional recovery of the entries, ignoring the CRCs. Easier solution: we just deny / abort loading the file and tell the user babout the broken file. It really strange that the broken CRCs are just detected on write and the document loads without a problem. Or do we ignore all ZIP entries, which we don't know, which would be strange too? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/svx sc/source svx/source
include/svx/ctredlin.hxx |1 +
sc/source/ui/miscdlgs/acredlin.cxx |2 +-
svx/source/dialog/ctredlin.cxx |7 +++
3 files changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 418c1d6143dd42e48ef52e0fb8c3d6e5d22c3cfa
Author: Caolán McNamara
AuthorDate: Sun Jun 2 15:52:28 2019 +0100
Commit: Caolán McNamara
CommitDate: Mon Jun 3 22:15:54 2019 +0200
Resolves: tdf#125589 we are initially unsorted
so turn on sorting on first sort request
Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78
Reviewed-on: https://gerrit.libreoffice.org/73345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index b6ae656d586f..16147e60bd08 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -92,6 +92,7 @@ private:
boolbAuthor;
boolbDate;
boolbComment;
+boolbSorted;
SvxRedlinDateMode nDaTiMode;
DateTimeaDaTiFirst;
DateTimeaDaTiLast;
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index c04fa55f0b85..44d89d2669be 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1748,7 +1748,7 @@ int ScAcceptChgDlg::ColCompareHdl(const weld::TreeIter&
rLeft, const weld::TreeI
weld::TreeView& rTreeView = pTheView->GetWidget();
sal_Int32 nCompare = 0;
-SCCOL nSortCol= rTreeView.get_sort_column();
+SCCOL nSortCol = rTreeView.get_sort_column();
if (CALC_DATE == nSortCol)
{
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index 22595f923e2a..9cdfe60d40d5 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -83,6 +83,7 @@
SvxRedlinTable::SvxRedlinTable(std::unique_ptr xWriterControl,
, bAuthor(false)
, bDate(false)
, bComment(false)
+, bSorted(false)
, nDaTiMode(SvxRedlinDateMode::BEFORE)
, aDaTiFirst( DateTime::EMPTY )
, aDaTiLast( DateTime::EMPTY )
@@ -121,6 +122,12 @@ SvxRedlinTable::~SvxRedlinTable()
IMPL_LINK(SvxRedlinTable, HeaderBarClick, int, nColumn, void)
{
+if (!bSorted)
+{
+pTreeView->make_sorted();
+bSorted = true;
+}
+
bool bSortAtoZ = pTreeView->get_sort_order();
//set new arrow positions in headerbar
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svx sc/source svx/source
include/svx/ctredlin.hxx |1 +
sc/source/ui/miscdlgs/acredlin.cxx |2 +-
svx/source/dialog/ctredlin.cxx |7 +++
3 files changed, 9 insertions(+), 1 deletion(-)
New commits:
commit e620291e7ce0d7c63a4e23bfcce3fdbd54789469
Author: Caolán McNamara
AuthorDate: Sun Jun 2 15:52:28 2019 +0100
Commit: Caolán McNamara
CommitDate: Mon Jun 3 22:15:38 2019 +0200
Resolves: tdf#125589 we are initially unsorted
so turn on sorting on first sort request
Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78
Reviewed-on: https://gerrit.libreoffice.org/73344
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index b6ae656d586f..16147e60bd08 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -92,6 +92,7 @@ private:
boolbAuthor;
boolbDate;
boolbComment;
+boolbSorted;
SvxRedlinDateMode nDaTiMode;
DateTimeaDaTiFirst;
DateTimeaDaTiLast;
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index c04fa55f0b85..44d89d2669be 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1748,7 +1748,7 @@ int ScAcceptChgDlg::ColCompareHdl(const weld::TreeIter&
rLeft, const weld::TreeI
weld::TreeView& rTreeView = pTheView->GetWidget();
sal_Int32 nCompare = 0;
-SCCOL nSortCol= rTreeView.get_sort_column();
+SCCOL nSortCol = rTreeView.get_sort_column();
if (CALC_DATE == nSortCol)
{
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index 22595f923e2a..9cdfe60d40d5 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -83,6 +83,7 @@
SvxRedlinTable::SvxRedlinTable(std::unique_ptr xWriterControl,
, bAuthor(false)
, bDate(false)
, bComment(false)
+, bSorted(false)
, nDaTiMode(SvxRedlinDateMode::BEFORE)
, aDaTiFirst( DateTime::EMPTY )
, aDaTiLast( DateTime::EMPTY )
@@ -121,6 +122,12 @@ SvxRedlinTable::~SvxRedlinTable()
IMPL_LINK(SvxRedlinTable, HeaderBarClick, int, nColumn, void)
{
+if (!bSorted)
+{
+pTreeView->make_sorted();
+bSorted = true;
+}
+
bool bSortAtoZ = pTreeView->get_sort_order();
//set new arrow positions in headerbar
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125660] COMPARE DOCUMENTS: Crash in swlo!SwRedlineData::SetSeqNo
https://bugs.documentfoundation.org/show_bug.cgi?id=125660 --- Comment #3 from Telesto --- @Raal Slightly confused: Redline = Michael Stahl; as far I know -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Saving documents with broken zip streams (Re: minutes of ESC call ...)
On Monday 03 of June 2019, Caolán McNamara wrote: > On Mon, 2019-06-03 at 12:23 +0200, Luboš Luňák wrote: > > On Thursday 30 of May 2019, Michael Meeks wrote: > > > + some in the zip area - assuming they are threading related. > > > > Is this about those documents such > > as /srv/crashtestdata/files/caolan/opendocument_stack_overflow_2.odt > > ? How > > can I reproduce that problem? If I try to fetch > > buildsl...@vm138.documentfoundation.org: > > an/opendocument_stack_overflow_2.odt , > > it doesn't exist. > > I attach two of the examples here. The input name was foo.sample, the > output to odt name appears higher up in the bt during the export. > > ./instdir/program/soffice.bin --headless --convert-to odt > opendocument_stack_overflow.sample Ok, so it's not a problem with my code, my changes just happened to show the problem, and the problem is that those documents are broken. If you try to unzip the documents, it will complain about incorrect CRC (although it still will uncompress them). And what happens is that when we try to save the file, apparently only by that point we'll read those zip streams, there will be a ZipException about that, and the code in package/ is not exception-safe. So ZipOutputStream::writeLOC() gets called but not the matching ZipOutputStream::rawCloseEntry(). But this is actually broken on several levels. If I make the code to catch the exception better, I'll need to make it somehow handle the fact that writeLOC() prepared for writing en entry, but then there's nothing to write. But that's actually not important, since ZipPackageStream::saveChild() will still return failure, so ZipPackageFolder::saveContents() will throw an exception, making the whole document saving fail. Which in turn means this whole save business is irrelevant, as there's just no way to save the document, even though we can load it and we can edit it. Which seems rather lame. Any idea what to do about that? Is it really ok that we just refuse to save it? Or should we save it even though the contents may be broken? -- Luboš Luňák l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125670] New: Crash in: OutputDevice::InitClipRegion on Slide show
https://bugs.documentfoundation.org/show_bug.cgi?id=125670 Bug ID: 125670 Summary: Crash in: OutputDevice::InitClipRegion on Slide show Product: LibreOffice Version: 6.0.7.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jumbo4...@yahoo.fr Created attachment 151888 --> https://bugs.documentfoundation.org/attachment.cgi?id=151888=edit Test file which crash This bug was filed from the crash reporting server and is br-fde3ca17-ae27-4188-b318-8f18d26545fc. = Steps to reproduce 1. Open attached file 2. F5 to launch slide Actual behavior Crash File contains only 1 grouped object, with 3 objects: title, bitmap of chart and a yellow bar No crash if object is ungrouped. No crash if color is modified of yellow bar No crash if one of the 3 sub-object is removed Crash with: - Version: 6.0.7.2 Build ID: 78c12ce5f2b8960f18b204a7ea82f971769f1679 Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; Locale : fr-FR (fr_FR.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92384] Search bar cannot be closed due to overlaid "search key not found" message (only with small window width)
https://bugs.documentfoundation.org/show_bug.cgi?id=92384 --- Comment #9 from Raphael Matias --- This may be a rookie mistake on my part, but it still caused the error message. I was importing an excel spreadsheet and had a space in front of a field heading. Once the space was removed the file imported no problem Note: The space only appears when you look to at the file in Excel; when Access tries to import, the dialog box gets rid of the space, but the space still causes problems. I learned this the hard way... https://www.buscado.com.br/agencia-de-marketing-digital.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125656] LibreOffice Writer crash at start after update from 6.2.3.2 to 6.2.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=125656 Xisco Faulí changed: What|Removed |Added Keywords||corruptProfile Resolution|--- |WONTFIX Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- thanks for reporting this issue. It's a corrupted profile issue which can be fixed by removing the user profile directory. I know it might be annoying but the profile rarely gets corrupted. We have the policy to close this kind of bugs as RESOLVED WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112567] FILESAVE XLSX Rows to Repeat and Columns to Repeat properties in XLSX files created with Calc are saved as incorrect Named ranges (w Hungarian locale)
https://bugs.documentfoundation.org/show_bug.cgi?id=112567 --- Comment #20 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/ac8368767d3c50c46a764987bf0fd783579f3d9f%5E%21 tdf#112567 XLSX export: correct built-in names It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112567] FILESAVE XLSX Rows to Repeat and Columns to Repeat properties in XLSX files created with Calc are saved as incorrect Named ranges (w Hungarian locale)
https://bugs.documentfoundation.org/show_bug.cgi?id=112567 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0 target:6.4.0 |target:6.3.0 target:6.4.0 ||target:6.3.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/qa sc/source
sc/qa/unit/data/ods/tdf112567.ods |binary
sc/qa/unit/subsequent_export-test.cxx | 31 +++
sc/source/filter/excel/xename.cxx | 25 -
3 files changed, 55 insertions(+), 1 deletion(-)
New commits:
commit ac8368767d3c50c46a764987bf0fd783579f3d9f
Author: László Németh
AuthorDate: Thu May 30 19:57:41 2019 +0200
Commit: Xisco Faulí
CommitDate: Mon Jun 3 21:37:47 2019 +0200
tdf#112567 XLSX export: correct built-in names
Non-en_US locale setting resulted broken XLSX export
with incorrect localized range separator. The previous
commit 19976f079800ec4c1d0d5d7e226986cb41f834c2
"tdf#112567 XLSX export: fix broken built-in names"
only avoided of the bad export of the XSLX documents
with correct definedName.
Note: this commit fixes the bad XLSX documents
during the next import/export cycle.
Change-Id: I9101c5df0f29c7a42fd49f4c2765dcf47a711916
Reviewed-on: https://gerrit.libreoffice.org/73220
Tested-by: Jenkins
Reviewed-by: László Németh
(cherry picked from commit 32a11727a0f709c11685d4200b1db08dac211dec)
Reviewed-on: https://gerrit.libreoffice.org/73381
diff --git a/sc/qa/unit/data/ods/tdf112567.ods
b/sc/qa/unit/data/ods/tdf112567.ods
new file mode 100644
index ..fda79997e534
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf112567.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 94bfd5ae4f36..416fb9f32139 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -220,6 +220,7 @@ public:
void testTdf91634XLSX();
void testTdf115159();
void testTdf112567();
+void testTdf112567b();
void testTdf123645XLSX();
void testTdf125173XLSX();
void testTdf79972XLSX();
@@ -348,6 +349,7 @@ public:
CPPUNIT_TEST(testTdf91634XLSX);
CPPUNIT_TEST(testTdf115159);
CPPUNIT_TEST(testTdf112567);
+CPPUNIT_TEST(testTdf112567b);
CPPUNIT_TEST(testTdf123645XLSX);
CPPUNIT_TEST(testTdf125173XLSX);
CPPUNIT_TEST(testTdf79972XLSX);
@@ -4334,6 +4336,35 @@ void ScExportTest::testTdf112567()
xDocSh->DoClose();
}
+void ScExportTest::testTdf112567b()
+{
+// Set the system locale to Hungarian (a language with different range
separator)
+SvtSysLocaleOptions aOptions;
+aOptions.SetLocaleConfigString("hu-HU");
+aOptions.Commit();
+comphelper::ScopeGuard g([] {
+aOptions.SetLocaleConfigString(OUString());
+aOptions.Commit();
+});
+
+ScDocShellRef xShell = loadDoc("tdf112567.", FORMAT_ODS);
+CPPUNIT_ASSERT(xShell.is());
+ScDocShellRef xDocSh = saveAndReload(xShell.get(), FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+xShell->DoClose();
+
+xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory,
"xl/workbook.xml", FORMAT_XLSX);
+CPPUNIT_ASSERT(pDoc);
+
+//assert the existing OOXML built-in name is not duplicated
+assertXPath(pDoc, "/x:workbook/x:definedNames/x:definedName", 1);
+
+//and it contains "," instead of ";"
+assertXPathContent(pDoc, "/x:workbook/x:definedNames/x:definedName[1]",
"Sheet1!$A:$A,Sheet1!$1:$1");
+
+xDocSh->DoClose();
+}
+
void ScExportTest::testTdf123645XLSX()
{
ScDocShellRef xDocSh = loadDoc("chart_hyperlink.", FORMAT_XLSX);
diff --git a/sc/source/filter/excel/xename.cxx
b/sc/source/filter/excel/xename.cxx
index ee418fb80d5c..35d84b86194e 100644
--- a/sc/source/filter/excel/xename.cxx
+++ b/sc/source/filter/excel/xename.cxx
@@ -92,6 +92,8 @@ public:
private:
/** Writes the body of the NAME record to the passed stream. */
virtual voidWriteBody( XclExpStream& rStrm ) override;
+/** Convert localized range separators */
+OUStringGetWithDefaultRangeSeparator( const OUString& rSymbol
) const;
private:
OUStringmaOrigName; /// The original user-defined name.
@@ -294,6 +296,27 @@ void XclExpName::Save( XclExpStream& rStrm )
XclExpRecord::Save( rStrm );
}
+OUString XclExpName::GetWithDefaultRangeSeparator( const OUString& rSymbol )
const
+{
+sal_Int32 nPos = rSymbol.indexOf(';');
+if ( nPos > -1 )
+{
+// convert with validation
+ScRange aRange;
+ScAddress::Details detailsXL( ::formula::FormulaGrammar::CONV_XL_A1 );
+ScRefFlags nRes = aRange.Parse( rSymbol.copy(0, nPos), (),
detailsXL );
+if ( nRes & ScRefFlags::VALID )
+{
+nRes = aRange.Parse( rSymbol.copy(nPos+1), (), detailsXL
);
+if ( nRes & ScRefFlags::VALID )
+{
+return rSymbol.replaceFirst(";", ",");
+}
+}
+}
+return rSymbol;
+}
+
void XclExpName::SaveXml( XclExpXmlStream& rStrm )
{
sax_fastparser::FSHelperPtr& rWorkbook = rStrm.GetCurrentStream();
@@ -314,7 +337,7 @@ void XclExpName::SaveXml( XclExpXmlStream& rStrm )
[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Gabor Kelemen changed: What|Removed |Added Depends on|104518 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104518 [Bug 104518] FILEOPEN XLS Pie chart colors not imported correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=109072 Gabor Kelemen changed: What|Removed |Added Depends on||104518 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104518 [Bug 104518] FILEOPEN XLS Pie chart colors not imported correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98274] Insert - Text from file should actually filter the file list instead of showing all files
https://bugs.documentfoundation.org/show_bug.cgi?id=98274 Heiko Tietze changed: What|Removed |Added Assignee|tietze.he...@gmail.com |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW --- Comment #12 from Heiko Tietze --- Abandoned my approach at https://gerrit.libreoffice.org/#/c/69384/. Read the comments for details. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104518] FILEOPEN XLS Pie chart colors not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=104518 Gabor Kelemen changed: What|Removed |Added Blocks|75057 |109072 --- Comment #4 from Gabor Kelemen --- This is an XLS file, adjusting meta bug. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75057 [Bug 75057] [META] OOXML Chart object issues https://bugs.documentfoundation.org/show_bug.cgi?id=109072 [Bug 109072] [META] XLS (binary) format bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
