[Libreoffice-bugs] [Bug 107555] Apply the 'Default Style' table style to newly inserted tables

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107555

--- Comment #16 from Dieter Praas  ---
(In reply to Jim Raykowski from comment #15)
> Dieter, Hieko, and all interested in finding a good solution for this, 
> 
> Currently when a table is inserted using either the Insert Table dialog or
> the Insert Table control button, "Default Style" autoformat is used only as
> a template to create the table and is not assigned the autoformat "Default
> Style".

The change of Default style template this will perhaps reduce confusion (bug
124206).

> This provides for user direct formatting not being replaced when
> rows are inserted

Actual there's a different behaviour, depending if you mark a whole row or just
put the cursor in a cell (see bug 126008).


> This could be
> extended to all autoformat styles by  adding a check box in the Insert Table
> dialog to use the table style as a template or as an autoformat. Maybe this
> will cause more confusion.

I'm not sure, if the majority of the users are aware about the differences
between template and autoformat (I also learnt something from your explanation,
Jim). So I also think, this could cause more confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl

2019-06-21 Thread Jan-Marek Glogowski (via logerrit)
 include/vcl/outdev.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3f8c4a59e9d98df86296dfd00d366523701e2c59
Author: Jan-Marek Glogowski 
AuthorDate: Sat Jun 22 01:01:26 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Sat Jun 22 05:56:33 2019 +0200

VCL move comment to the right function

Regression from commit da8aa9385153 ("VCL: Reorganize and rename
wallpaper functions").

Change-Id: I6a992c98c4e5657848ebbca946d5eddca4aa7161
Reviewed-on: https://gerrit.libreoffice.org/74549
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index fc52c7890b48..d51546bd974a 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1303,6 +1303,7 @@ public:
   sal_Int32 nIndex, 
sal_Int32 nLen,
   const long* pDXAry ) 
const;
 
+// tells whether this output device is RTL in an LTR UI or LTR in a RTL UI
 SAL_DLLPRIVATE bool ImplIsAntiparallel() const ;
 SAL_DLLPRIVATE void ReMirror( Point  ) const;
 SAL_DLLPRIVATE void ReMirror( tools::Rectangle  ) const;
@@ -1321,7 +1322,6 @@ public:
  vcl::TextLayoutCache 
const* = nullptr) const;
 SAL_DLLPRIVATE std::unique_ptr
 ImplGlyphFallbackLayout( 
std::unique_ptr, ImplLayoutArgs& ) const;
-// tells whether this output device is RTL in an LTR UI or LTR in a RTL UI
 SAL_DLLPRIVATE std::unique_ptr
 getFallbackLayout(
 LogicalFontInstance* pLogicalFont, int 
nFallbackLevel,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125765] FILEOPEN VIEWING XLSX applies first sheet gridlines settings for every sheet

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125765

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125764] hyperlink active region inaccurate in scaled sheet (truncated fractions?)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125764

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126015] Unable to spellcheck in Libreoffice Writer 6.0.7.3 on Ubuntu 18.04

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126015

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125784] LibreOffice Viewer on Android doesn't allow to copy text from a file

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125784

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121603] I cannot save the settings of my "view" in writer from one session to another.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121603

--- Comment #3 from QA Administrators  ---
Dear loveneedstruth,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121603] I cannot save the settings of my "view" in writer from one session to another.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121603

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125786] LibreOffice Viewer on Android only gives access to 9 first directories on the local file system

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125786

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126015] Unable to spellcheck in Libreoffice Writer 6.0.7.3 on Ubuntu 18.04

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126015

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125776] Setting a table background/ applying a table format isn't registered as a change

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125776

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122296] dosyaların kaydedilememesi

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122296

--- Comment #2 from QA Administrators  ---
Dear Münir,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120419] Printing Envelope Canon MX 922

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120419

--- Comment #4 from QA Administrators  ---
Dear Joe F,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115634] in special characters dialog buttons for recent and favorite characters are too small on high resolution screens

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115634

--- Comment #4 from QA Administrators  ---
Dear bordfeldt,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121602] Writer acts like it is auto-saving my work, and then crashes.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121602

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40941] FILEOPEN FORMATTING Draw shifts, breaks apart, and merges icons importing SVG

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=40941

--- Comment #14 from QA Administrators  ---
Dear Christopher M. Penalver,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121602] Writer acts like it is auto-saving my work, and then crashes.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121602

--- Comment #3 from QA Administrators  ---
Dear loveneedstruth,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120419] Printing Envelope Canon MX 922

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120419

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105681] 5.3.0.3 installer hangs when custom option to install to d: drive selected

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105681

--- Comment #8 from QA Administrators  ---
Dear John Kissane,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117616] lighten and darken of e.g. shape Square Bevel is lost, if a style with gradient is applied

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117616

--- Comment #2 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117967] On Linux LibreOffice doesn't protect users from accidental content overwrite when a file was updated outside of LibreOffice and the warning dialog was cancelled out of

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117967

--- Comment #5 from QA Administrators  ---
Dear yury.dubinsky,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108604] wrong kashida placement when exporting to PDF

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108604

--- Comment #13 from QA Administrators  ---
Dear Fahad Al-Saidi,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64461] SVG image text with "flowed text frame" will be imported as a black box

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64461

--- Comment #11 from QA Administrators  ---
Dear ilikebigbugs,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79976] GALLERY: enlarged image not crisp

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=79976

--- Comment #13 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40259] Unexpected behaviour with Shapes → Intersect

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=40259

--- Comment #19 from QA Administrators  ---
Dear RGB,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117170] If open *.doc or *.docx documents and string on center or justify align then text cursor don't move with space on end string.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117170

--- Comment #5 from QA Administrators  ---
Dear morphey008,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117899] changes parameters of conditional formatting "Formula is" if copy range from Calc and paste it to Writer as OLE

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117899

--- Comment #4 from QA Administrators  ---
Dear kompilainenn,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117957] Attached WMF file is not shown correctly.

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117957

--- Comment #7 from QA Administrators  ---
Dear a246246_246-kde,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117953] VIEWING: Default text position in form text box changes with scale (zoom) when aligned to right in Writer

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117953

--- Comment #3 from QA Administrators  ---
Dear cdlvcdlv,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126000] Crash deleting template

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126000

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0 target:6.3.0.1 |target:6.4.0 target:6.3.0.1
   |target:6.2.6 target:6.2.5   |target:6.2.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126000] Crash deleting template

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126000

--- Comment #9 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-2-5":

https://git.libreoffice.org/core/+/7e092051d563a8454d13b6a6ecc05b93e0f0135d%5E%21

tdf#126000 Crash deleting template

It will be available in 6.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126000] Crash deleting template

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126000

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0 target:6.3.0.1 |target:6.4.0 target:6.3.0.1
   |target:6.2.6|target:6.2.6 target:6.2.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-5' - sfx2/source

2019-06-21 Thread Noel Grandin (via logerrit)
 sfx2/source/control/thumbnailview.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 7e092051d563a8454d13b6a6ecc05b93e0f0135d
Author: Noel Grandin 
AuthorDate: Wed Jun 19 16:26:53 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 22 04:23:06 2019 +0200

tdf#126000 Crash deleting template

regression from
commit 72c191e046112df73c66be8dc8d1bec5a546fa60
Date:   Wed Sep 19 12:11:38 2018 +0200
loplugin:useuniqueptr in ThumbnailView

Reviewed-on: https://gerrit.libreoffice.org/74362
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 801bb2d4002cf2034315875440a6aee358951eb9)
Reviewed-on: https://gerrit.libreoffice.org/74372
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

Change-Id: I9bdcec5c2f14b1bd33998041d4b2d8cd2f7be052
Reviewed-on: https://gerrit.libreoffice.org/74428
Reviewed-by: Noel Grandin 
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 6efe09515c0c028c759f84275a8023f4c188437f)
Reviewed-on: https://gerrit.libreoffice.org/74460
Reviewed-by: Xisco Faulí 
Reviewed-by: Thorsten Behrens 
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index 83fae8ca76f9..df446321db0f 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -962,12 +962,16 @@ void ThumbnailView::RemoveItem( sal_uInt16 nItemId )
 
 if ( nPos < mFilteredItemList.size() ) {
 
+// keep it alive until after we have deleted it from the filter item 
list
+std::unique_ptr xKeepAliveViewItem;
+
 // delete item from the thumbnail list
-for (size_t i = 0, n = mItemList.size(); i < n; ++i)
+for (auto it = mItemList.begin(); it != mItemList.end(); ++it)
 {
-if (mItemList[i]->mnId == nItemId)
+if ((*it)->mnId == nItemId)
 {
-mItemList.erase(mItemList.begin()+i);
+xKeepAliveViewItem = std::move(*it);
+mItemList.erase(it);
 break;
 }
 }
@@ -982,7 +986,6 @@ void ThumbnailView::RemoveItem( sal_uInt16 nItemId )
 maItemStateHdl.Call(*it);
 }
 
-delete *it;
 mFilteredItemList.erase( it );
 mpStartSelRange = mFilteredItemList.end();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89471] FILEOPEN pdf: When opening a PDF with RTL language text in Draw, text gets mirrored

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89471

V Stuart Foote  changed:

   What|Removed |Added

 CC||vv...@yandex.ru
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=90800

--- Comment #25 from V Stuart Foote  ---
The MirrorString and MirrorMap of OOo bz#i90800 was stripped out early in LO
era with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ff140bb6b8b109f14c270ff059f0b8d71dab5d6c

While the MirrorString helper remains, not clear it still has any function, or
what should trigger it for a text run. And looking at processGlyphLine in
pdfiprocessor.cxx it does not look like we link up the FontAttributes with
fontID to make use of the ICU libs BiDi Unicode block detection that Khaled
notes in comment 18. 

@Artem, you have any interest?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126015] Unable to spellcheck in Libreoffice Writer 6.0.7.3 on Ubuntu 18.04

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126015

--- Comment #4 from JamesCobban  ---
Dieter,
The fact that I am running Ubuntu 18.04, the most recent long term support
release, should indicate that I am reluctant to take risks with my system.  On
the LibreOffice website the latest release recommended for people like me is
6.1.6 and 6.2.4 is advertised as being for the adventurous.

I understand the recommendation to approach Ubuntu support, since if spellcheck
were failing across the board, that is as a result of the common portion of the
LibreOffice code base, this would have been raised a long time ago.  However
against what component of Ubuntu do I raise the issue? And even then the most
probably response from the Ubuntu team will be to upgrade to 19.04 and try to
reproduce the problem there. 

I appreciate Julian's suggestion to install the package from the PPA but it has
been a couple of years since I last used a PPA.  The instructions in the
supplied URL are clear, but far from reassuring:

You can update your system with unsupported packages from this untrusted PPA by
adding ppa:libreoffice/ppa to your system's Software Sources. (Read about
installing)

sudo add-apt-repository ppa:libreoffice/ppa
sudo apt-get update

Will I be easily able to back out to a supported release of LibreOffice if I
issue those two commands?

Now suppose I install libreoffice-fresh. If the spellcheck still does not work
that is fine, because then the project team knows that this is a bug that must
be addressed, and you will suggest additional tests for me to perform and
additional information to collect.  But what if the fresh version WORKS?  That
is the problem has already been fixed or was some strange interaction between
the LibreOffice 6.0.7.3 and Ubuntu 18.04?  You can relax knowing that there is
a solution that you can offer to other users.  But what do I do since by that
point I am running an unsupported release of LibreOffice and will therefore
inevitably have to install a supported release at some point?

As the King of Siam says in the musical "The King and I": "A puzzlement."

Balancing all of these issues, and considering the advice you have supplied and
where it is coming from I believe I will bite the bullet and upgrade to Ubuntu
19.04 which comes with LibreOffice 6.2.2.  If that solves my problem everybody
is happy, and I have an improved version to boot. If I still have the issue I
will try installing the latest PPA then.

Thank you for your advice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125666] Deleting a (large) sheet very slow

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125666

--- Comment #2 from MM  ---
You don't even need to copy/paste anything.
Just open attachment 150858.
Make a new sheet. Now delete the newly created sheet and wait a long time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101211] "To Begin of Previous Page" and "To Begin of Next Page" commands dont set view to beginning of page

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101211

pb  changed:

   What|Removed |Added

 CC||blic...@comcast.net

--- Comment #9 from pb  ---
This is really the most elementary behavior of the pgup pgdn keys, and Writer
does it wrong.  If you are in view whole page mode, pgup and pgdn should move
to the prev/next page, not by some random amount that perhaps depends on the
window size, or maybe the current distance to the planet venus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101211] "To Begin of Previous Page" and "To Begin of Next Page" commands dont set view to beginning of page

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101211

pb  changed:

   What|Removed |Added

 CC||blic...@comcast.net

--- Comment #9 from pb  ---
This is really the most elementary behavior of the pgup pgdn keys, and Writer
does it wrong.  If you are in view whole page mode, pgup and pgdn should move
to the prev/next page, not by some random amount that perhaps depends on the
window size, or maybe the current distance to the planet venus.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 125851] Table layout changes when repeatedly enabling/disabling show track change (without any actual changes)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125851

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug.

I can reproduce the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sw/source

2019-06-21 Thread Jim Raykowski (via logerrit)
 include/sfx2/tabdlg.hxx   |1 +
 sw/source/ui/dialog/swdlgfact.cxx |3 +++
 2 files changed, 4 insertions(+)

New commits:
commit fc938b4310a8f5fcc8ee2846acfeb6f6d818b9f5
Author: Jim Raykowski 
AuthorDate: Tue Jun 18 15:36:09 2019 -0800
Commit: Jim Raykowski 
CommitDate: Fri Jun 21 23:24:12 2019 +0200

tdf#125362 Update tab dialog example set after Apply

Change-Id: I0f6ad5273b285080bf2bc55fca3a2365b5b42bbf
Reviewed-on: https://gerrit.libreoffice.org/74325
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 77f9125ef8d2..d98af8b09090 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -147,6 +147,7 @@ public:
 
 //calls Ok without closing dialog
 bool Apply();
+void Applied() { m_xExampleSet->Put(*GetInputSetImpl()); }
 };
 
 enum class DeactivateRC {
diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index a1f3b67fe6f4..c08ec419eb9c 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -317,7 +317,10 @@ void AbstractTabController_Impl::SetText( const OUString& 
rStr )
 IMPL_LINK_NOARG(AbstractApplyTabController_Impl, ApplyHdl, weld::Button&, void)
 {
 if (m_xDlg->Apply())
+{
 m_aHandler.Call(nullptr);
+m_xDlg->Applied();
+}
 }
 
 void AbstractApplyTabController_Impl::SetApplyHdl( const 
Link& rLink )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102211] Writer UI : in the paragraph style pane, organizer tab, the contains field is inconsistent

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102211

--- Comment #8 from Jim Raykowski  ---
Thank you Buovjaga for confirming. I will put this in.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107555] Apply the 'Default Style' table style to newly inserted tables

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107555

--- Comment #15 from Jim Raykowski  ---
Dieter, Hieko, and all interested in finding a good solution for this, 

Currently when a table is inserted using either the Insert Table dialog or the
Insert Table control button, "Default Style" autoformat is used only as a
template to create the table and is not assigned the autoformat "Default
Style". This provides for user direct formatting not being replaced when rows
are inserted or deleted or when the document is reopened. This could be
extended to all autoformat styles by  adding a check box in the Insert Table
dialog to use the table style as a template or as an autoformat. Maybe this
will cause more confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/source

2019-06-21 Thread Jan-Marek Glogowski (via logerrit)
 vcl/source/outdev/gradient.cxx |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 12cf9256fba688df367a2be7db17e0ed3d24c73c
Author: Jan-Marek Glogowski 
AuthorDate: Mon Jun 3 22:52:05 2019 +
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 22:59:04 2019 +0200

tdf#125670 just check gradient clipping on drawing

Otherwise the gradient won't be commited to the Metafile, as
mbOutputClipped will be true, because the output device will
have just one pixel size.

Reviewed-on: https://gerrit.libreoffice.org/73423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 710f3c63af2d8bee7d5e860614145799a3f0e491)

tdf#125777 restore old RenderContext before return

Related: tdf#125670 avoid possible performance issues for the general case

but retain recording of gradient to metafile

6acf23675414983bd07639703f43aa934c0a48ed
5efde15f1c192b15fe647362803442ac947b63de

Change-Id: Ia0c6569a28f2aa1a8f0e051b61d429e0ab23ef97
Reviewed-on: https://gerrit.libreoffice.org/74507
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 6047d537b5ea8f13f7e8d4739621c866af1d13fb)
Reviewed-on: https://gerrit.libreoffice.org/74515
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/outdev/gradient.cxx b/vcl/source/outdev/gradient.cxx
index aeace07e4710..2c6b884e6732 100644
--- a/vcl/source/outdev/gradient.cxx
+++ b/vcl/source/outdev/gradient.cxx
@@ -56,7 +56,7 @@ void OutputDevice::DrawGradient( const tools::PolyPolygon& 
rPolyPoly,
 if ( mbInitClipRegion )
 InitClipRegion();
 
-if ( mbOutputClipped )
+if (mbOutputClipped && !mpMetaFile)
 return;
 
 if ( rPolyPoly.Count() && rPolyPoly[ 0 ].GetSize() )
@@ -110,6 +110,12 @@ void OutputDevice::DrawGradient( const tools::PolyPolygon& 
rPolyPoly,
 if( mbInitClipRegion )
 InitClipRegion();
 
+if (mbOutputClipped)
+{
+Pop();
+return;
+}
+
 // try to draw gradient natively
 bDrawn = mpGraphics->DrawGradient( aClixPolyPoly, aGradient );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125670

--- Comment #16 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/12cf9256fba688df367a2be7db17e0ed3d24c73c%5E%21

tdf#125670 just check gradient clipping on drawing

It will be available in 6.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125670] Crash in: OutputDevice::InitClipRegion on Slide show

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125670

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.4.0 target:6.3.0.1 |target:6.4.0 target:6.3.0.1
   ||target:6.2.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126047] FORMATTING

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126047

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
(In reply to syllaslp from comment #0)
> Suggestion: Calc should allow different styles, applied to the same range,
> in conditional formatting.
> 
> The way it works nowadays is awful.
> 
> How it should work:
> 
> 1. It should allow setting up the order the conditional formats are applied.
Editing the conditional format it's possible to move up/down the inner
conditions

> 
> 2. If a conditional format affects DIFFERENT cell attributes: both
> conditional formats should be applied. Ex.: CF1 changes only cells
> background and CF2 changes only font color. If a cell content matches both
> CF1 and CF2, it will have a background ant color font changed.
Maybe amazing, but I think we are not going to view such enhancement in a short
time if implemented at some time, because I think not so easy to code, generate
an internal style mixing those, and perhaps slowing the spreadsheet.
In any case as the styles has inheritance, you can make a tree of styles and
apply the one that meets the conditions.

> 
> 3. If a conditional format affects the SAME cell attribute, I imagine 2
> possibilities, to be thought and chosen:
> 
> 3.1. Only the first CF is applied.
> 
> 3.2. Both of them are applied, so the last one remains.
> 
> 3.3. Another possibility is to warn the user and ask her/him to choose the
> desired behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126036

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #3 from Caolán McNamara  ---
The page style dialog missing "reset" is a bug, so I'll take this bug to fix
that specific problem at least.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126036

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #3 from Caolán McNamara  ---
The page style dialog missing "reset" is a bug, so I'll take this bug to fix
that specific problem at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/vcl sc/inc sc/source vcl/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 include/vcl/dialog.hxx|9 
 sc/inc/document.hxx   |8 +++-
 sc/inc/scopetools.hxx |8 
 sc/source/core/data/documen8.cxx  |6 +--
 sc/source/core/tool/scopetools.cxx|   13 ---
 sc/source/filter/oox/excelfilter.cxx  |3 -
 sc/source/filter/oox/workbookfragment.cxx |4 --
 sc/source/ui/app/scmod.cxx|   52 
 sc/source/ui/docshell/dbdocfun.cxx|   32 +++--
 sc/source/ui/docshell/dbdocimp.cxx|   14 ++-
 sc/source/ui/docshell/docfunc.cxx |   36 ---
 sc/source/ui/docshell/docsh.cxx   |   37 
 sc/source/ui/docshell/docsh3.cxx  |9 ++--
 sc/source/ui/docshell/docsh4.cxx  |   55 +-
 sc/source/ui/docshell/docsh5.cxx  |   21 ---
 sc/source/ui/docshell/externalrefmgr.cxx  |3 -
 sc/source/ui/docshell/impex.cxx   |3 -
 sc/source/ui/drawfunc/drawsh.cxx  |8 ++--
 sc/source/ui/drawfunc/drtxtob.cxx |2 -
 sc/source/ui/drawfunc/drtxtob1.cxx|6 +--
 sc/source/ui/drawfunc/graphsh.cxx |2 -
 sc/source/ui/inc/docsh.hxx|2 -
 sc/source/ui/inc/tabvwsh.hxx  |3 +
 sc/source/ui/inc/viewdata.hxx |3 -
 sc/source/ui/undo/undoblk.cxx |   12 +++---
 sc/source/ui/unoobj/docuno.cxx|2 -
 sc/source/ui/view/cellsh1.cxx |   14 +++
 sc/source/ui/view/cellsh2.cxx |2 -
 sc/source/ui/view/cliputil.cxx|2 -
 sc/source/ui/view/dbfunc.cxx  |4 +-
 sc/source/ui/view/dbfunc3.cxx |4 +-
 sc/source/ui/view/editsh.cxx  |6 +--
 sc/source/ui/view/spelleng.cxx|3 -
 sc/source/ui/view/tabview2.cxx|   10 ++---
 sc/source/ui/view/tabview3.cxx|6 ---
 sc/source/ui/view/tabvwsh4.cxx|7 ---
 sc/source/ui/view/tabvwshd.cxx|   27 --
 sc/source/ui/view/viewdata.cxx|8 
 sc/source/ui/view/viewfun2.cxx|4 +-
 sc/source/ui/view/viewfun3.cxx|8 ++--
 sc/source/ui/view/viewfun4.cxx|2 -
 sc/source/ui/view/viewfunc.cxx|2 -
 vcl/source/window/dialog.cxx  |6 ---
 43 files changed, 175 insertions(+), 293 deletions(-)

New commits:
commit f805e0b969fba5c3b2c2bad4d5b951873ec2908f
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 15:20:58 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 22:41:59 2019 +0200

reference childwins are all welded

Change-Id: I050b4bdff4eaa645316538725c69e83bee4a90c5
Reviewed-on: https://gerrit.libreoffice.org/74526
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index af372c270675..bebbd4fafb9a 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -225,6 +225,12 @@ namespace com { namespace sun { namespace star {
 }
 } } }
 
+namespace weld {
+
+class Window;
+
+}
+
 #define SC_DOC_NEW  0x
 
 #define SC_MACROCALL_ALLOWED0
@@ -977,7 +983,7 @@ public:
 ScFormulaParserPool& GetFormulaParserPool() const;
 
 boolHasAreaLinks() const;
-voidUpdateExternalRefLinks(vcl::Window* pWin);
+voidUpdateExternalRefLinks(weld::Window* pWin);
 voidUpdateAreaLinks();
 
 // originating DDE links
diff --git a/sc/inc/scopetools.hxx b/sc/inc/scopetools.hxx
index 7789d9645b8a..93f7238ec138 100644
--- a/sc/inc/scopetools.hxx
+++ b/sc/inc/scopetools.hxx
@@ -57,14 +57,6 @@ public:
 ~IdleSwitch();
 };
 
-class WaitPointerSwitch
-{
-VclPtr mpFrameWin;
-public:
-WaitPointerSwitch(vcl::Window* pWin);
-~WaitPointerSwitch();
-};
-
 /// Wrapper for ScDocument::DelayFormulaGrouping()
 class SC_DLLPUBLIC DelayFormulaGroupingSwitch
 {
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 059293291eee..b1459942f83f 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -805,7 +805,7 @@ bool ScDocument::IsInLinkUpdate() const
 return bInLinkUpdate || IsInDdeLinkUpdate();
 }
 
-void ScDocument::UpdateExternalRefLinks(vcl::Window* pWin)
+void ScDocument::UpdateExternalRefLinks(weld::Window* pWin)
 {
 if (!pExternalRefMgr)
 return;
@@ -829,7 +829,7 @@ void ScDocument::UpdateExternalRefLinks(vcl::Window* pWin)
 aRefLinks.push_back(pRefLink);
 }
 
-sc::WaitPointerSwitch aWaitSwitch(pWin);
+weld::WaitObject aWaitSwitch(pWin);
 
 pExternalRefMgr->enableDocTimer(false);
 ScProgress aProgress(GetDocumentShell(), ScResId(SCSTR_UPDATE_EXTDOCS), 
aRefLinks.size(), true);
@@ -856,7 +856,7 @@ void 

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 include/sfx2/basedlgs.hxx   |   32 --
 sfx2/source/dialog/basedlgs.cxx |  190 
 2 files changed, 1 insertion(+), 221 deletions(-)

New commits:
commit 5b8623863c71ced2cde5091ba4d402f1128e6761
Author: Caolán McNamara 
AuthorDate: Sun Jun 16 15:19:38 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 22:41:13 2019 +0200

remove newly unused SfxModelessDialog

Change-Id: I298a96bd3f45d10a92e5f2a853fc4e7a4c52228b
Reviewed-on: https://gerrit.libreoffice.org/74120
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx
index bbcaef188f4d..5a1b1ce16b28 100644
--- a/include/sfx2/basedlgs.hxx
+++ b/include/sfx2/basedlgs.hxx
@@ -60,37 +60,6 @@ public:
 virtual void dispose() override;
 };
 
-// class SfxModelessDialog --
-class SfxModelessDialog_Impl;
-class SFX2_DLLPUBLIC SfxModelessDialog: public ModelessDialog
-{
-SfxBindings*pBindings;
-std::unique_ptr< SfxModelessDialog_Impl > pImpl;
-
-SfxModelessDialog(SfxModelessDialog const &) = delete;
-SfxModelessDialog& operator =(SfxModelessDialog const &) = delete;
-
-void Init(SfxBindings *pBindinx, SfxChildWindow *pCW);
-
-DECL_DLLPRIVATE_STATIC_LINK(SfxModelessDialog, InstallLOKNotifierHdl, 
void*, vcl::ILibreOfficeKitNotifier*);
-protected:
-SfxModelessDialog( SfxBindings*, SfxChildWindow*,
-vcl::Window*, const OUString& rID, const OUString& rUIXMLDescription );
-virtual ~SfxModelessDialog() override;
-virtual void dispose() override;
-virtual boolClose() override;
-virtual voidResize() override;
-virtual voidMove() override;
-virtual voidStateChanged( StateChangedType nStateChange ) 
override;
-
-public:
-virtual boolEventNotify( NotifyEvent& rNEvt ) override;
-SfxBindings&GetBindings()
-{ return *pBindings; }
-
-DECL_LINK(TimerHdl, Timer *, void);
-};
-
 class SFX2_DLLPUBLIC SfxDialogController : public weld::GenericDialogController
 {
 private:
@@ -112,6 +81,7 @@ public:
 };
 
 class SfxModelessDialog_Impl;
+
 class SFX2_DLLPUBLIC SfxModelessDialogController : public SfxDialogController
 {
 SfxBindings* m_pBindings;
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index e1f74636c58f..4291b2000982 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -140,196 +140,6 @@ void SfxModalDialog::dispose()
 ModalDialog::dispose();
 }
 
-void SfxModelessDialog::StateChanged( StateChangedType nStateChange )
-{
-if ( nStateChange == StateChangedType::InitShow )
-{
-if ( !pImpl->aWinState.isEmpty() )
-{
-SetWindowState( pImpl->aWinState );
-}
-else
-{
-Point aPos = GetPosPixel();
-if ( !aPos.X() )
-{
-Size aParentSize = GetParent()->GetOutputSizePixel();
-Size aDlgSize = GetSizePixel();
-aPos.AdjustX(( aParentSize.Width() - aDlgSize.Width() ) / 2 );
-aPos.AdjustY(( aParentSize.Height() - aDlgSize.Height() ) / 2 
);
-
-Point aPoint;
-tools::Rectangle aRect = GetDesktopRectPixel();
-aPoint.setX( aRect.Right() - aDlgSize.Width() );
-aPoint.setY( aRect.Bottom() - aDlgSize.Height() );
-
-aPoint = OutputToScreenPixel( aPoint );
-
-if ( aPos.X() > aPoint.X() )
-aPos.setX( aPoint.X() ) ;
-if ( aPos.Y() > aPoint.Y() )
-aPos.setY( aPoint.Y() );
-
-if ( aPos.X() < 0 ) aPos.setX( 0 );
-if ( aPos.Y() < 0 ) aPos.setY( 0 );
-
-SetPosPixel( aPos );
-}
-}
-
-pImpl->bConstructed = true;
-}
-
-ModelessDialog::StateChanged( nStateChange );
-}
-
-void SfxModelessDialog::Resize()
-
-/*  [Description]
-
-This virtual method of the class FloatingWindow keeps track if a change
-in size has been made. When this method is overridden by a derived class,
-then the SfxFloatingWindow: Resize() must also be called.
-*/
-
-{
-ModelessDialog::Resize();
-if ( pImpl->bConstructed && pImpl->pMgr )
-{
-// start timer for saving window status information
-pImpl->aMoveIdle.Start();
-}
-}
-
-void SfxModelessDialog::Move()
-{
-ModelessDialog::Move();
-if ( pImpl->bConstructed && pImpl->pMgr && IsReallyVisible() )
-{
-// start timer for saving window status information
-pImpl->aMoveIdle.Start();
-}
-}
-
-/*
-Implements a timer event that is triggered by a move or resize of the 
window
-This will save config information to Views.xcu with a small delay
-*/

[Libreoffice-bugs] [Bug 125223] Right version number in Help/About...

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125223

--- Comment #20 from Aron Budea  ---
Then you haven't installed and/or aren't running the correct application.
Please check if you have LibreOfficeDev installed. If not, install it. Then run
LibreOfficeDev.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sd/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 sd/source/ui/view/ViewShellImplementation.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 153e0cacb9a8bdabbf6eb1cd84b6aa87ee45b44f
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 15:28:17 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 22:16:02 2019 +0200

SvxIMapDlg is welded

Change-Id: Ie244312cd3b2b291f0ab8f6ed223a50fb7d2ffe9
Reviewed-on: https://gerrit.libreoffice.org/74527
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/view/ViewShellImplementation.cxx 
b/sd/source/ui/view/ViewShellImplementation.cxx
index b6d4369cfc91..a7d67677277e 100644
--- a/sd/source/ui/view/ViewShellImplementation.cxx
+++ b/sd/source/ui/view/ViewShellImplementation.cxx
@@ -319,7 +319,7 @@ SvxIMapDlg* ViewShell::Implementation::GetImageMapDialog()
 SfxChildWindow* pChildWindow = SfxViewFrame::Current()->GetChildWindow(
 SvxIMapDlgChildWindow::GetChildWindowId());
 if (pChildWindow != nullptr)
-pDialog = dynamic_cast(pChildWindow->GetWindow());
+pDialog = 
dynamic_cast(pChildWindow->GetController().get());
 return pDialog;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108889] Crash: When editing a document which is opened at the moment of setting the undo count to zero (0)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108889

--- Comment #6 from Telesto  ---
I still repro.. Scope is very limited .. It's only happening with the file
opened at the point when changing undo from 100 to 0 

Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126042] Title and extension version number are mangled together in extension dialog

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126042

--- Comment #3 from Telesto  ---
For the record, I expect some installed extension ;-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126043] Tools -> Customize has a nagging delay of 3 seconds on each opening

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126043

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126042] Title and extension version number are mangled together in extension dialog

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126042

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug.

I cannot reproduce the bug in
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

In Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

The Extension dialog box is empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126043] Tools -> Customize has a nagging delay of 3 seconds on each opening

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126043

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Durgapriyanka  ---
Thank you for reporting the bug.

I can confirm the bug in
Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

But,cannot reproduce in 
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 sc/source/ui/Accessibility/AccessibleDocument.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 49c92a3b46b8f4c3303ea17a508f91a0c87d54f6
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 14:56:19 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 21:42:28 2019 +0200

remove then dispose, not dispose then remove

asserts seen in inline spelling in calc otherwise

Change-Id: If78142cb0a3e23de6eb0e5d40622a4c7d06df8ec
Reviewed-on: https://gerrit.libreoffice.org/74512
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx 
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index f9ea7367a6bb..b7876c1a6f61 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -1495,6 +1495,10 @@ void ScAccessibleDocument::Notify( SfxBroadcaster& rBC, 
const SfxHint& rHint )
 if (mpTempAccEdit)
 {
 mpTempAccEdit->LostFocus();
+}
+RemoveChild(mxTempAcc, true);
+if (mpTempAccEdit)
+{
 // tdf#125982 a11y use-after-free of editengine by
 // ScAccessibleEditObjectTextData living past the
 // the editengine of the editview passed in above
@@ -1502,7 +1506,6 @@ void ScAccessibleDocument::Notify( SfxBroadcaster& rBC, 
const SfxHint& rHint )
 mpTempAccEdit->dispose();
 mpTempAccEdit = nullptr;
 }
-RemoveChild(mxTempAcc, true);
 if (mpAccessibleSpreadsheet.is() && mpViewShell && 
mpViewShell->IsActive())
 mpAccessibleSpreadsheet->GotFocus();
 else if( mpViewShell && mpViewShell->IsActive())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125999] Add button name to extended tooltips

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125999

--- Comment #4 from Ulf Zibis  ---
I have some coaching clients whom I support on using LO.
For beginners I often have enabled the extended tooltips, so they better know
what a button is doing. The problem then is, when they have questions via
phone, they can't tell me the name of the button, they have questions on.
For example in Calc there are three buttons for sorting. It's difficult to
explain someone which button I mean, without knowing the name of the button.
Even for me with some rarely used functions it would better to always the know
the name to better remember it or find some info about it in the web.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 125999] Add button name to extended tooltips

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125999

--- Comment #4 from Ulf Zibis  ---
I have some coaching clients whom I support on using LO.
For beginners I often have enabled the extended tooltips, so they better know
what a button is doing. The problem then is, when they have questions via
phone, they can't tell me the name of the button, they have questions on.
For example in Calc there are three buttons for sorting. It's difficult to
explain someone which button I mean, without knowing the name of the button.
Even for me with some rarely used functions it would better to always the know
the name to better remember it or find some info about it in the web.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 125999] Add button name to extended tooltips

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125999

Ulf Zibis  changed:

   What|Removed |Added

 CC||ulf.zi...@gmx.de

--- Comment #3 from Ulf Zibis  ---
I have some coaching clients whom I support on using LO.
For beginners I often have enabled the extended tooltips, so they better know
what a button is doing. The problem then is, when they have questions via
phone, the can't tell me the name of the button, they have questions on.
For example in Calc there are three buttons for sorting. It's difficult to
explain someone which button I mean, without knowing the name of the button.
Even for me with some rarely used functions it would better the know the name
to better remember it or find some info in the web about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 125999] Add button name to extended tooltips

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125999

Ulf Zibis  changed:

   What|Removed |Added

 CC||ulf.zi...@gmx.de

--- Comment #3 from Ulf Zibis  ---
I have some coaching clients whom I support on using LO.
For beginners I often have enabled the extended tooltips, so they better know
what a button is doing. The problem then is, when they have questions via
phone, the can't tell me the name of the button, they have questions on.
For example in Calc there are three buttons for sorting. It's difficult to
explain someone which button I mean, without knowing the name of the button.
Even for me with some rarely used functions it would better the know the name
to better remember it or find some info in the web about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125223] Right version number in Help/About...

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125223

--- Comment #19 from Sebők Gábor  ---
No, it's definitely NOT a developer build!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source cui/uiconfig extras/source include/cui include/sfx2 include/svx include/vcl sc/source sd/inc sd/source sfx2/source solenv/bin svx/source s

2019-06-21 Thread Caolán McNamara (via logerrit)
 cui/Library_cui.mk   |1 
 cui/source/dialogs/SpellAttrib.cxx   |  105 -
 cui/source/dialogs/SpellAttrib.hxx   |  100 -
 cui/source/dialogs/SpellDialog.cxx   | 1654 ++-
 cui/source/dialogs/cuicharmap.cxx|2 
 cui/source/factory/dlgfact.cxx   |   27 
 cui/source/factory/dlgfact.hxx   |   16 
 cui/source/factory/init.cxx  |4 
 cui/source/inc/SpellDialog.hxx   |  189 +-
 cui/uiconfig/ui/spellingdialog.ui|  159 +
 extras/source/glade/libreoffice-catalog.xml.in   |3 
 include/cui/cuicharmap.hxx   |2 
 include/sfx2/basedlgs.hxx|3 
 include/svx/ClassificationEditView.hxx   |4 
 include/svx/langbox.hxx  |2 
 include/svx/svxdlg.hxx   |6 
 include/vcl/edit.hxx |2 
 include/vcl/weld.hxx |   10 
 sc/source/ui/inc/spelleng.hxx|4 
 sc/source/ui/view/cellsh.cxx |4 
 sc/source/ui/view/spelleng.cxx   |   33 
 sd/inc/Outliner.hxx  |6 
 sd/source/ui/view/Outliner.cxx   |   20 
 sfx2/source/appl/appinit.cxx |6 
 sfx2/source/dialog/basedlgs.cxx  |   15 
 solenv/bin/native-code.py|1 
 svx/source/dialog/SpellDialogChildWindow.cxx |6 
 svx/source/dialog/rubydialog.cxx |6 
 svx/source/dialog/srchdlg.cxx|6 
 sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx |9 
 vcl/source/app/salvtables.cxx|   33 
 vcl/source/control/edit.cxx  |4 
 vcl/source/edit/vclmedit.cxx |4 
 vcl/unx/gtk3/gtk3gtkinst.cxx |   50 
 34 files changed, 1369 insertions(+), 1127 deletions(-)

New commits:
commit 5261417cbb3051b812164838d19c0f748573df45
Author: Caolán McNamara 
AuthorDate: Fri Jun 14 21:56:44 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 21:33:30 2019 +0200

weld SpellDialog

a) use EditEngine instead of TextEngine as the former can be hosted in a
   foreign widget
b) use a SfxGrabBagItem to hold the custom spellchecking info inside the
   EditEngine
c) in longer paragraphs the current word is now auto-scrolled into view
d) rename Invalidate to InvalidateDialog

Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1
Reviewed-on: https://gerrit.libreoffice.org/74119
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index b02520529fab..e3cd0c36ba4f 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -135,7 +135,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/dialogs/SignSignatureLineDialog \
 cui/source/dialogs/sdrcelldlg \
 cui/source/dialogs/showcols \
-cui/source/dialogs/SpellAttrib \
 cui/source/dialogs/SpellDialog \
 cui/source/dialogs/splitcelldlg \
 cui/source/dialogs/srchxtra \
diff --git a/cui/source/dialogs/SpellAttrib.cxx 
b/cui/source/dialogs/SpellAttrib.cxx
deleted file mode 100644
index 9d761a55b3f1..
--- a/cui/source/dialogs/SpellAttrib.cxx
+++ /dev/null
@@ -1,105 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include "SpellAttrib.hxx"
-#include 
-
-using namespace svx;
-using namespace com::sun::star::linguistic2;
-using namespace com::sun::star::uno;
-
-
-SpellErrorAttrib::SpellErrorAttrib( const SpellErrorDescription& rDesc ) :
-TextAttrib(TEXTATTR_SPELL_ERROR),
-m_aSpellErrorDescription( rDesc )
-{
-}
-
-
-void SpellErrorAttrib::SetFont( vcl::Font&  ) const
-{
-//this attribute doesn't have a visual effect
-}
-
-

[Libreoffice-commits] core.git: sd/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 sd/source/ui/view/ViewShellImplementation.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fda464112540011dd6e2bd267720d2800af3a5f2
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 15:28:17 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 21:33:03 2019 +0200

SvxIMapDlg is welded

Change-Id: Ie244312cd3b2b291f0ab8f6ed223a50fb7d2ffe9
Reviewed-on: https://gerrit.libreoffice.org/74524
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/view/ViewShellImplementation.cxx 
b/sd/source/ui/view/ViewShellImplementation.cxx
index b6d4369cfc91..a7d67677277e 100644
--- a/sd/source/ui/view/ViewShellImplementation.cxx
+++ b/sd/source/ui/view/ViewShellImplementation.cxx
@@ -319,7 +319,7 @@ SvxIMapDlg* ViewShell::Implementation::GetImageMapDialog()
 SfxChildWindow* pChildWindow = SfxViewFrame::Current()->GetChildWindow(
 SvxIMapDlgChildWindow::GetChildWindowId());
 if (pChildWindow != nullptr)
-pDialog = dynamic_cast(pChildWindow->GetWindow());
+pDialog = 
dynamic_cast(pChildWindow->GetController().get());
 return pDialog;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104597] Persian in imported PDF gets reversed

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104597

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||471

--- Comment #10 from Justin L  ---
Probably a duplicate of bug 89471, but this one at least has a bisect commit to
look at, so I don't want to lose it in the messy comments of another bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89471] FILEOPEN pdf: When opening a PDF with RTL language text in Draw, text gets mirrored

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89471

Justin L  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4597

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 sw/source/uibase/fldui/fldwrap.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 2cd88135cf1b6260b34ba5148ec00c18818bfed3
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 15:41:05 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 21:13:24 2019 +0200

field dialogs all welded

Change-Id: I0a468ec6926b8b1cd5666839ea0de192c6d11d16
Reviewed-on: https://gerrit.libreoffice.org/74525
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/fldui/fldwrap.cxx 
b/sw/source/uibase/fldui/fldwrap.cxx
index 69cb72de640a..ce704d0ab51d 100644
--- a/sw/source/uibase/fldui/fldwrap.cxx
+++ b/sw/source/uibase/fldui/fldwrap.cxx
@@ -47,8 +47,6 @@ IMPL_LINK_NOARG(SwChildWinWrapper, UpdateHdl, Timer *, void)
 {
 if (GetController())
 GetController()->Activate();// update dialog
-else if (GetWindow())
-GetWindow()->Activate();// update dialog
 }
 
 // newly initialise dialog after Doc switch
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 32249] When importing PDF with text in it , it will be better to have a easy and fluent option to edit the imported Text

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=32249

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #17 from Justin L  ---
*** Bug 125838 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125838] add ability to merge textboxes and content into one: editing PDF imports

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125838

Justin L  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Justin L  ---


*** This bug has been marked as a duplicate of bug 32249 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - drawinglayer/source

2019-06-21 Thread Miklos Vajna (via logerrit)
 drawinglayer/source/primitive2d/sceneprimitive2d.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 945455c0af44bebe8ca0b111bf6664450192f919
Author: Miklos Vajna 
AuthorDate: Fri Jun 21 16:01:51 2019 +0200
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 20:15:56 2019 +0200

drawinglayer: disable multi-threaded rendering in sceneprimitive2d

It seems this is not stable yet:

- 
https://dev-builds.libreoffice.org/crashtest/27e3ed0d25735603d2c82744e3a8f5f3e0a8d043/backtraces/task395-core.16181.backtrace.txt
- https://ci.libreoffice.org/job/gerrit_linux_gcc_release/35032/console

Go back to disabling that by default for now.

Change-Id: I6cd870d2661bfb99b8ed5008c2542fede05ae8c8
Reviewed-on: https://gerrit.libreoffice.org/74523
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/drawinglayer/source/primitive2d/sceneprimitive2d.cxx 
b/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
index b747e8e6a759..6d9dd7a9c8c2 100644
--- a/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/sceneprimitive2d.cxx
@@ -372,7 +372,7 @@ namespace drawinglayer
 nOversampleValue ? nRasterHeight * nOversampleValue : 
nRasterHeight);
 
 // check for parallel execution possibilities
-static bool bMultithreadAllowed = true; // 
loplugin:constvars:ignore
+static bool bMultithreadAllowed = false; // 
loplugin:constvars:ignore
 sal_Int32 nThreadCount(0);
 comphelper::ThreadPool& 
rThreadPool(comphelper::ThreadPool::getSharedOptimalPool());
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126048] Non genera il report

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126048

Biagio  changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126048] New: Non genera il report

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126048

Bug ID: 126048
   Summary: Non genera il report
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: biagio.ferrar...@gmail.com

Created attachment 152351
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152351=edit
imagine dopo la creazione del rapporto(report)

Non genera il report

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126047] New: FORMATTING

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126047

Bug ID: 126047
   Summary: FORMATTING
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sylla...@gmail.com

Suggestion: Calc should allow different styles, applied to the same range, in
conditional formatting.

The way it works nowadays is awful.

How it should work:

1. It should allow setting up the order the conditional formats are applied.

2. If a conditional format affects DIFFERENT cell attributes: both conditional
formats should be applied. Ex.: CF1 changes only cells background and CF2
changes only font color. If a cell content matches both CF1 and CF2, it will
have a background ant color font changed.

3. If a conditional format affects the SAME cell attribute, I imagine 2
possibilities, to be thought and chosen:

3.1. Only the first CF is applied.

3.2. Both of them are applied, so the last one remains.

3.3. Another possibility is to warn the user and ask her/him to choose the
desired behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #66 from Commit Notification 
 ---
Arkadiy Illarionov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a4261757b89f6a198261006a8c9aa6b4eb8e19fb%5E%21

tdf#39593 Remove reportdesign::OSection::getImplementation

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: reportdesign/source

2019-06-21 Thread Arkadiy Illarionov (via logerrit)
 reportdesign/source/core/api/Section.cxx |   16 ++--
 reportdesign/source/core/inc/Section.hxx |3 +--
 reportdesign/source/core/sdr/RptPage.cxx |4 ++--
 3 files changed, 5 insertions(+), 18 deletions(-)

New commits:
commit a4261757b89f6a198261006a8c9aa6b4eb8e19fb
Author: Arkadiy Illarionov 
AuthorDate: Fri Jun 21 00:11:43 2019 +0300
Commit: Arkadiy Illarionov 
CommitDate: Fri Jun 21 19:38:17 2019 +0200

tdf#39593 Remove reportdesign::OSection::getImplementation

Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I3d0837ff3f47392e09ef276f141a8459add7a5ad
Reviewed-on: https://gerrit.libreoffice.org/74471
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov 

diff --git a/reportdesign/source/core/api/Section.cxx 
b/reportdesign/source/core/api/Section.cxx
index 69be4b7fc3c8..b030ae5508e7 100644
--- a/reportdesign/source/core/api/Section.cxx
+++ b/reportdesign/source/core/api/Section.cxx
@@ -571,24 +571,12 @@ sal_Bool SAL_CALL OSection::hasForms()
 
 sal_Int64 OSection::getSomething( const uno::Sequence< sal_Int8 > & rId )
 {
-if (rId.getLength() == 16 && 0 == 
memcmp(getUnoTunnelImplementationId().getConstArray(),  rId.getConstArray(), 16 
) )
+if (rId.getLength() == 16 && 0 == memcmp(getUnoTunnelId().getConstArray(), 
 rId.getConstArray(), 16 ) )
 return reinterpret_cast(this);
 return (m_xDrawPage_Tunnel.is()) ? m_xDrawPage_Tunnel->getSomething(rId) : 
0;
 }
 
-
-OSection* OSection::getImplementation( const uno::Reference< uno::XInterface 
>& _rxComponent )
-{
-OSection* pContent( nullptr );
-
-uno::Reference< lang::XUnoTunnel > xUnoTunnel( _rxComponent, 
uno::UNO_QUERY );
-if ( xUnoTunnel.is() )
-pContent = reinterpret_cast< OSection* >( xUnoTunnel->getSomething( 
getUnoTunnelImplementationId() ) );
-
-return pContent;
-}
-
-uno::Sequence< sal_Int8 > OSection::getUnoTunnelImplementationId()
+uno::Sequence< sal_Int8 > OSection::getUnoTunnelId()
 {
 static ::cppu::OImplementationId implId;
 
diff --git a/reportdesign/source/core/inc/Section.hxx 
b/reportdesign/source/core/inc/Section.hxx
index fb4fe75172ad..77a92db780bd 100644
--- a/reportdesign/source/core/inc/Section.hxx
+++ b/reportdesign/source/core/inc/Section.hxx
@@ -223,8 +223,7 @@ namespace reportdesign
 
 // css::lang::XUnoTunnel
 virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< 
sal_Int8 >& aIdentifier ) override;
-static OSection* getImplementation( const css::uno::Reference< 
css::uno::XInterface >& _rxComponent );
-static css::uno::Sequence< sal_Int8 > getUnoTunnelImplementationId();
+static css::uno::Sequence< sal_Int8 > getUnoTunnelId();
 
 void notifyElementAdded(const css::uno::Reference< 
css::drawing::XShape >& xShape);
 void notifyElementRemoved(const css::uno::Reference< 
css::drawing::XShape >& xShape);
diff --git a/reportdesign/source/core/sdr/RptPage.cxx 
b/reportdesign/source/core/sdr/RptPage.cxx
index c20f11f363cd..18484851739b 100644
--- a/reportdesign/source/core/sdr/RptPage.cxx
+++ b/reportdesign/source/core/sdr/RptPage.cxx
@@ -92,7 +92,7 @@ SdrObject* OReportPage::RemoveObject(size_t nObjNum)
 }
 
 // this code is evil, but what else shall I do
-reportdesign::OSection* pSection = 
reportdesign::OSection::getImplementation(m_xSection);
+reportdesign::OSection* pSection = 
comphelper::getUnoTunnelImplementation(m_xSection);
 uno::Reference< drawing::XShape> 
xShape(pObj->getUnoShape(),uno::UNO_QUERY);
 pSection->notifyElementRemoved(xShape);
 if (dynamic_cast< const OUnoObject *>( pObj ) !=  nullptr)
@@ -177,7 +177,7 @@ void OReportPage::NbcInsertObject(SdrObject* pObj, size_t 
nPos)
 }
 
 // this code is evil, but what else shall I do
-reportdesign::OSection* pSection = 
reportdesign::OSection::getImplementation(m_xSection);
+reportdesign::OSection* pSection = 
comphelper::getUnoTunnelImplementation(m_xSection);
 uno::Reference< drawing::XShape> 
xShape(pObj->getUnoShape(),uno::UNO_QUERY);
 pSection->notifyElementAdded(xShape);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: forms/source

2019-06-21 Thread Arkadiy Illarionov (via logerrit)
 forms/source/component/Columns.cxx |4 ++--
 forms/source/component/Columns.hxx |2 +-
 forms/source/component/Grid.cxx|   16 
 forms/source/component/Grid.hxx|2 --
 4 files changed, 7 insertions(+), 17 deletions(-)

New commits:
commit fbead41b7d6c0346ff3373279f9c01dc4c7e61fd
Author: Arkadiy Illarionov 
AuthorDate: Fri Jun 21 00:43:56 2019 +0300
Commit: Arkadiy Illarionov 
CommitDate: Fri Jun 21 19:32:06 2019 +0200

tdf#39593 Remove frm::OGridControlModel::getColumnImplementation

Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I3b662136778340a95216ac08035f7c25d5882349
Reviewed-on: https://gerrit.libreoffice.org/74472
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov 

diff --git a/forms/source/component/Columns.cxx 
b/forms/source/component/Columns.cxx
index 42de375a20b9..5fd625f3191c 100644
--- a/forms/source/component/Columns.cxx
+++ b/forms/source/component/Columns.cxx
@@ -115,7 +115,7 @@ namespace
 class theOGridColumnImplementationId : public rtl::Static< 
UnoTunnelIdInit, theOGridColumnImplementationId > {};
 }
 
-const Sequence& OGridColumn::getUnoTunnelImplementationId()
+const Sequence& OGridColumn::getUnoTunnelId()
 {
 return theOGridColumnImplementationId::get().getSeq();
 }
@@ -126,7 +126,7 @@ sal_Int64 SAL_CALL OGridColumn::getSomething( const 
Sequence& _rIdenti
 sal_Int64 nReturn(0);
 
 if  (   (_rIdentifier.getLength() == 16)
-&&  (0 == memcmp( getUnoTunnelImplementationId().getConstArray(), 
_rIdentifier.getConstArray(), 16 ))
+&&  (0 == memcmp( getUnoTunnelId().getConstArray(), 
_rIdentifier.getConstArray(), 16 ))
 )
 {
 nReturn = reinterpret_cast(this);
diff --git a/forms/source/component/Columns.hxx 
b/forms/source/component/Columns.hxx
index d98fdbd02e0e..2db0bfb2218a 100644
--- a/forms/source/component/Columns.hxx
+++ b/forms/source/component/Columns.hxx
@@ -70,7 +70,7 @@ public:
 DECLARE_UNO3_AGG_DEFAULTS(OGridControlModel, OGridColumn_BASE)
 virtual css::uno::Any SAL_CALL queryAggregation( const css::uno::Type& 
_rType ) override;
 
-static const css::uno::Sequence& getUnoTunnelImplementationId();
+static const css::uno::Sequence& getUnoTunnelId();
 // XUnoTunnel
 virtual sal_Int64 SAL_CALL getSomething( const 
css::uno::Sequence& _rIdentifier) override;
 
diff --git a/forms/source/component/Grid.cxx b/forms/source/component/Grid.cxx
index ba3bfd222bf8..80294635082f 100644
--- a/forms/source/component/Grid.cxx
+++ b/forms/source/component/Grid.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -688,15 +689,6 @@ Any OGridControlModel::getPropertyDefaultByHandle( 
sal_Int32 nHandle ) const
 return aReturn;
 }
 
-OGridColumn* OGridControlModel::getColumnImplementation(const 
css::uno::Reference& _rxIFace)
-{
-OGridColumn* pImplementation = nullptr;
-Reference< XUnoTunnel > xUnoTunnel( _rxIFace, UNO_QUERY );
-if ( xUnoTunnel.is() )
-pImplementation = 
reinterpret_cast(xUnoTunnel->getSomething(OGridColumn::getUnoTunnelImplementationId()));
-return pImplementation;
-}
-
 void OGridControlModel::gotColumn( const Reference< XInterface >& _rxColumn )
 {
 Reference< XSQLErrorBroadcaster > xBroadcaster( _rxColumn, UNO_QUERY );
@@ -753,7 +745,7 @@ ElementDescription* 
OGridControlModel::createElementMetaData( )
 
 void OGridControlModel::approveNewElement( const Reference< XPropertySet >& 
_rxObject, ElementDescription* _pElement )
 {
-OGridColumn* pCol = getColumnImplementation( _rxObject );
+OGridColumn* pCol = comphelper::getUnoTunnelImplementation( 
_rxObject );
 if ( !pCol )
 throw IllegalArgumentException();
 OInterfaceContainer::approveNewElement( _rxObject, _pElement );
@@ -777,7 +769,7 @@ void OGridControlModel::write(const 
Reference& _rxOutStream
 for (sal_Int32 i = 0; i < nLen; i++)
 {
 // first the service name for the underlying model
-OGridColumn* pCol = getColumnImplementation(m_aItems[i]);
+OGridColumn* pCol = 
comphelper::getUnoTunnelImplementation(m_aItems[i]);
 DBG_ASSERT(pCol != nullptr, "OGridControlModel::write : such items 
should never reach it into my container !");
 _rxOutStream << pCol->getModelName();
 // then the object itself
@@ -881,7 +873,7 @@ void OGridControlModel::read(const 
Reference& _rxInStream)
 sal_Int32 nMark = xMark->createMark();
 if (xCol.is())
 {
-OGridColumn* pCol = getColumnImplementation(xCol);
+OGridColumn* pCol = 
comphelper::getUnoTunnelImplementation(xCol);
 pCol->read(_rxInStream);
 }
 xMark->jumpToMark(nMark);
diff --git a/forms/source/component/Grid.hxx b/forms/source/component/Grid.hxx
index 43c3d277d064..6afaeb171472 100644
--- a/forms/source/component/Grid.hxx
+++ 

[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #65 from Commit Notification 
 ---
Arkadiy Illarionov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/fbead41b7d6c0346ff3373279f9c01dc4c7e61fd%5E%21

tdf#39593 Remove frm::OGridControlModel::getColumnImplementation

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Writer TextTable access via the UNO API

2019-06-21 Thread Andrew Pitonyak

In OOME, I do not really discuss this, but, I do in AndrewMacro.odt where I 
claim (in the section "Enumerating cells in any text table" that you need to 
first use getCellNames() and then use getCellByName(aName).

If you want to be even more complete, you may need to worry about things such 
as sections, floating frames, etc. Annoying, right? I don't think that I have 
ever written code that attempts to enumerate all of these things to get every 
XText object. Luckily, some of these things you can simplify by enumerating 
certain objects independtly; for example, you could enumerate a Single XText 
object in a single method, and then get all of the text tables using 
oDoc.getTextTables() and have a method to specifically handle text tables 
rather than recognizing them as you traverse the text; if you did not need to 
retain locality or something. 



On Friday, June 21, 2019 09:56 EDT, Michael Stahl  wrote:
 On 21.06.19 13:22, Adomas Venčkauskas wrote:
> Hello,
>
> I need my Java extension to iterate over all hyperlinks in a Writer
> document. This is fine with Paragraph TextPortion enumeration, but no
> portion enumeration is available in TextTables. What would be the best
> way to enumerate all hyperlinks in TextTables?

you first need to enumerate the cells in the table, then the cells
implement XText so you can enumerate the paragraphs in the cells like
the paragraphs in the top-level body text.

to enumerate the cells i guess you can use getCellNames().
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2019-06-21 Thread Miklos Vajna (via logerrit)
 sw/inc/postithelper.hxx|3 -
 sw/qa/extras/unowriter/unowriter.cxx   |   14 +
 sw/source/core/fields/postithelper.cxx |   88 +++--
 sw/source/uibase/docvw/PostItMgr.cxx   |2 
 4 files changed, 100 insertions(+), 7 deletions(-)

New commits:
commit ac246d6ea1bc43bfc82c9b4c69c9c0f1fd678129
Author: Miklos Vajna 
AuthorDate: Fri Jun 21 17:55:01 2019 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jun 21 19:17:58 2019 +0200

sw comments on frames: fix layout to place anchor next to the image

With this, if you load
sw/qa/extras/unowriter/data/image-comment-at-char.odt, the comment
anchor leads to the commented image, not to the anchor of the image
(between "aaa" and "bbb").

Change-Id: I99389c9fc849269eb20d0266f8f604db89faec12
Reviewed-on: https://gerrit.libreoffice.org/74519
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/inc/postithelper.hxx b/sw/inc/postithelper.hxx
index 3c22ad9fd357..0a0523cc8e4d 100644
--- a/sw/inc/postithelper.hxx
+++ b/sw/inc/postithelper.hxx
@@ -35,6 +35,7 @@ class IDocumentRedlineAccess;
 namespace sw { namespace annotation {
 class SwAnnotationWin;
 } }
+namespace sw::mark { class IMark; }
 
 struct SwPosition;
 
@@ -78,7 +79,7 @@ namespace SwPostItHelper
 SwLayoutStatus getLayoutInfos(
 SwLayoutInfo& o_rInfo,
 const SwPosition& rAnchorPos,
-const SwPosition* pAnnotationStartPos = nullptr );
+const sw::mark::IMark* pAnnotationMark = nullptr );
 
 long getLayoutHeight( const SwRootFrame* pRoot );
 void setSidebarChanged( SwRootFrame* pRoot, bool bBrowseMode );
diff --git a/sw/qa/extras/unowriter/unowriter.cxx 
b/sw/qa/extras/unowriter/unowriter.cxx
index 38c55cfb74dd..b7b38d4a6da3 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -24,6 +24,9 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -561,6 +564,17 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter, testImageCommentAtChar)
  getProperty(getRun(xPara, 4), 
"TextPortionType"));
 CPPUNIT_ASSERT_EQUAL(OUString("Text"),
  getProperty(getRun(xPara, 5), 
"TextPortionType"));
+
+// Without the accompanying fix in place, this test would have failed with 
'Expected:
+// 5892; Actual: 1738', i.e. the anchor pos was between the "aaa" and 
"bbb" portions, not at the
+// center of the page (horizontally) where the image is.
+SwView* pView = pDoc->GetDocShell()->GetView();
+SwPostItMgr* pPostItMgr = pView->GetPostItMgr();
+for (const auto& pItem : *pPostItMgr)
+{
+const SwRect& rAnchor = pItem->pPostIt->GetAnchorRect();
+CPPUNIT_ASSERT_EQUAL(static_cast(5892), rAnchor.Left());
+}
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/core/fields/postithelper.cxx 
b/sw/source/core/fields/postithelper.cxx
index dde8d8dcaecf..f613ae4187e7 100644
--- a/sw/source/core/fields/postithelper.cxx
+++ b/sw/source/core/fields/postithelper.cxx
@@ -36,14 +36,77 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 #include 
 
 class Point;
 
+namespace
+{
+/// Checks if pAnnotationMark covers exactly rAnchorPos (the comment anchor).
+bool AnnotationMarkCoversCommentAnchor(const sw::mark::IMark* pAnnotationMark,
+   const SwPosition& rAnchorPos)
+{
+if (!pAnnotationMark)
+{
+return false;
+}
+
+const SwPosition& rMarkStart = pAnnotationMark->GetMarkStart();
+const SwPosition& rMarkEnd = pAnnotationMark->GetMarkEnd();
+
+if (rMarkStart != rAnchorPos)
+{
+return false;
+}
+
+if (rMarkStart.nNode != rMarkEnd.nNode)
+{
+return false;
+}
+
+return rMarkEnd.nContent.GetIndex() == rMarkStart.nContent.GetIndex() + 1;
+}
+
+/**
+ * Finds the first draw object of rTextFrame which has the same anchor 
position as the start of
+ * rAnnotationMark.
+ */
+SwAnchoredObject* GetAnchoredObjectOfAnnotationMark(const sw::mark::IMark& 
rAnnotationMark,
+const SwTextFrame& 
rTextFrame)
+{
+const SwSortedObjs* pAnchored = rTextFrame.GetDrawObjs();
+if (!pAnchored)
+{
+return nullptr;
+}
+
+for (SwAnchoredObject* pObject : *pAnchored)
+{
+SwFrameFormat& rFrameFormat = pObject->GetFrameFormat();
+const SwPosition* pFrameAnchor = 
rFrameFormat.GetAnchor().GetContentAnchor();
+if (!pFrameAnchor)
+{
+continue;
+}
+
+if (rAnnotationMark.GetMarkStart() == *pFrameAnchor)
+{
+return pObject;
+}
+}
+
+return nullptr;
+}
+}
+
 SwPostItHelper::SwLayoutStatus SwPostItHelper::getLayoutInfos(
 SwLayoutInfo& o_rInfo,
 const SwPosition& rAnchorPos,
-const SwPosition* pAnnotationStartPos )
+const sw::mark::IMark* 

[Libreoffice-bugs] [Bug 126046] New: Media player doesn't respect aspect ratio of video; it's fit to mediaplayer window

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126046

Bug ID: 126046
   Summary: Media player doesn't respect aspect ratio of video;
it's fit to mediaplayer window
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Media player doesn't respect aspect ratio of video; it's fit to mediaplayer
window

Steps to Reproduce:
1. Open Impress
2. Tools -> Media Player
3. Take a video an play (resize the mediaplayer window if the aspect ratio
looks ok)

Actual Results:
Messy aspect ratio

Expected Results:
Honor aspect ratio


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126045] New: Media player drawing glitch at progress bar after pressing play

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126045

Bug ID: 126045
   Summary: Media player drawing glitch at progress bar after
pressing play
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Media player drawing glitch at progress bar after pressing play

Steps to Reproduce:
1. Open Impress
2. Tools -> Media Player
3. Open a MP3 -> Title is shown in with textbox
4. Press play -> Progress bar is partly overwriting the textbox

Actual Results:
Progress bar is partly overwriting the textbox

Expected Results:
Probably the textbox containing the title above the progress bar?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - helpcontent2

2019-06-21 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 548e12533f52d152aca0efdfe1250102f1264ba2
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 18:54:27 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:03:48 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve other symbols in Math help pages

Rezise image and clean svg's

Change-Id: Ic9ecf60fc43117b5a8483f33b74c0568892da08c
Reviewed-on: https://gerrit.libreoffice.org/74532
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 046b2831aa27..56d36bfa5150 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 046b2831aa27afe7065243e912f4886e47dd6414
+Subproject commit 56d36bfa51508ce80ba8162733a4292d4c8f986c
commit c46e25e324be776b01928ea693548fb664de2f71
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 18:16:37 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:03:33 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve format symbols in Math help pages

Rezise image and clean svg's

Change-Id: Ica8f8044f09b92e57387535a53727cd9afbd1292
Reviewed-on: https://gerrit.libreoffice.org/74531
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 6feec55d2aa9..046b2831aa27 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6feec55d2aa9edf75f11d96ab72143373c0ca93c
+Subproject commit 046b2831aa27afe7065243e912f4886e47dd6414
commit 1803d57c64d891fdb26a9cde0ef18fe61bcb130b
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 17:35:01 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:03:21 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve brackets symbols in Math help pages

Rezise image and clean svg's

Change-Id: Ia56446a840c5deca661f691113e22964e5ead985
Reviewed-on: https://gerrit.libreoffice.org/74530
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 53674dc8cec4..6feec55d2aa9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 53674dc8cec4ca160c70819074e02c6b554b229b
+Subproject commit 6feec55d2aa9edf75f11d96ab72143373c0ca93c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 3 commits - source/media source/text

2019-06-21 Thread Olivier Hallot (via logerrit)
 source/media/helpimg/starmath/al21801.svg |   72 --
 source/media/helpimg/starmath/al21802.svg |   72 --
 source/media/helpimg/starmath/al21803.svg |   72 --
 source/media/helpimg/starmath/al21804.svg |   71 --
 source/media/helpimg/starmath/al21805.svg |   71 --
 source/media/helpimg/starmath/al21806.svg |   74 ---
 source/media/helpimg/starmath/al21808.svg |   71 --
 source/media/helpimg/starmath/al21809.svg |   78 +---
 source/media/helpimg/starmath/al21810.svg |   78 +---
 source/media/helpimg/starmath/al21811.svg |   77 +---
 source/media/helpimg/starmath/al21812.svg |   77 +---
 source/media/helpimg/starmath/al21813.svg |   76 +---
 source/media/helpimg/starmath/al21814.svg |   78 +---
 source/media/helpimg/starmath/al21821.svg |   74 ---
 source/media/helpimg/starmath/al21822.svg |   82 ++---
 source/media/helpimg/starmath/al21823.svg |   73 ---
 source/media/helpimg/starmath/al21824.svg |   79 +---
 source/media/helpimg/starmath/al21825.svg |   78 +---
 source/media/helpimg/starmath/al21826.svg |   77 +---
 source/media/helpimg/starmath/co21901.svg |   64 +++-
 source/media/helpimg/starmath/co21902.svg |   64 +++-
 source/media/helpimg/starmath/co21903.svg |   63 +++-
 source/media/helpimg/starmath/co21904.svg |   66 +++--
 source/media/helpimg/starmath/co21905.svg |   66 +++--
 source/media/helpimg/starmath/co21906.svg |   72 --
 source/media/helpimg/starmath/co21907.svg |   96 -
 source/media/helpimg/starmath/co21908.svg |   68 +++--
 source/media/helpimg/starmath/co21909.svg |   75 ---
 source/media/helpimg/starmath/co21910.svg |   73 ---
 source/media/helpimg/starmath/co21911.svg |   72 --
 source/media/helpimg/starmath/co21912.svg |   66 +++--
 source/media/helpimg/starmath/co21916.svg |   66 +++--
 source/media/helpimg/starmath/co21917.svg |   66 +++--
 source/media/helpimg/starmath/co21918.svg |   65 +++--
 source/media/helpimg/starmath/mi21608.svg |   64 +++-
 source/media/helpimg/starmath/mi21612.svg |   64 +++-
 source/media/helpimg/starmath/mi21618.svg |   64 +++-
 source/media/helpimg/starmath/mi22003.svg |   65 +++--
 source/media/helpimg/starmath/mi22004.svg |   66 +++--
 source/media/helpimg/starmath/mi22005.svg |   66 +++--
 source/media/helpimg/starmath/mi22006.svg |   62 +++-
 source/media/helpimg/starmath/mi22007.svg |   62 +++-
 source/media/helpimg/starmath/mi22008.svg |   62 +++-
 source/media/helpimg/starmath/mi22009.svg |   62 +++-
 source/media/helpimg/starmath/mi22010.svg |   62 +++-
 source/media/helpimg/starmath/mi22011.svg |   62 +++-
 source/media/helpimg/starmath/mi22012.svg |   63 +++-
 source/media/helpimg/starmath/mi22013.svg |   63 +++-
 source/media/helpimg/starmath/mi22014.svg |   64 +++-
 source/media/helpimg/starmath/mi22015.svg |   64 +++-
 source/media/helpimg/starmath/mi22016.svg |   66 +++--
 source/media/helpimg/starmath/mi22017.svg |   67 +++--
 source/media/helpimg/starmath/mi22018.svg |   64 +++-
 source/media/helpimg/starmath/mi22019.svg |   64 +++-
 source/text/smath/01/03090500.xhp |  114 +++---
 source/text/smath/01/03090700.xhp |   90 +++
 source/text/smath/01/03091600.xhp |   42 +--
 57 files changed, 3424 insertions(+), 570 deletions(-)

New commits:
commit 56d36bfa51508ce80ba8162733a4292d4c8f986c
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 18:54:27 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 19:03:48 2019 +0200

Improve other symbols in Math help pages

Rezise image and clean svg's

Change-Id: Ic9ecf60fc43117b5a8483f33b74c0568892da08c
Reviewed-on: https://gerrit.libreoffice.org/74532
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/media/helpimg/starmath/mi21608.svg 
b/source/media/helpimg/starmath/mi21608.svg
index cdcf25ba9..2a21c3ce8 100644
--- a/source/media/helpimg/starmath/mi21608.svg
+++ b/source/media/helpimg/starmath/mi21608.svg
@@ -1,8 +1,58 @@
-
-http://www.w3.org/2000/svg; version="1.1">
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   

[Libreoffice-commits] core.git: 4 commits - helpcontent2

2019-06-21 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d73c7efd96fb8160284ebce817269bc043a03caa
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 16:16:56 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:03:05 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve Operator symbols in Math help pages

Rezise image and clean svg's

Change-Id: Iae35945a62d00cec4f49fb1e3b78ec35867d2c90
Reviewed-on: https://gerrit.libreoffice.org/74529
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index f005c1a7e350..53674dc8cec4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f005c1a7e350aed7f02599c98df322507d02b99f
+Subproject commit 53674dc8cec4ca160c70819074e02c6b554b229b
commit 21ddf3a6c4d664dab1906e1e0edceb53d7e0017c
Author: Olivier Hallot 
AuthorDate: Thu Jun 20 17:08:33 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:02:47 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve set operators symbols display in Help page

resize Math iset operators icons (svg's)

Change-Id: I6775b7742f1e1e4d3e484c35d4ce9de93c4ced1e
Reviewed-on: https://gerrit.libreoffice.org/74479
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index fea6f8b2894f..f005c1a7e350 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fea6f8b2894f26ebdafce5adde0e7ebf7e6be338
+Subproject commit f005c1a7e350aed7f02599c98df322507d02b99f
commit b8ff4921b212477d3082f1245aabba8c1936bb6b
Author: Olivier Hallot 
AuthorDate: Thu Jun 20 15:24:17 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:02:29 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve unary  Math symbols display in Help page

resize and arrange unary/binary symbols svg in Help page

Change-Id: I87fe6023efde717aa6e86c72449bb2b3f6d5d217
Reviewed-on: https://gerrit.libreoffice.org/74478
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 592cfdd7506b..fea6f8b2894f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 592cfdd7506b085016acb817fa99116a78f76e1c
+Subproject commit fea6f8b2894f26ebdafce5adde0e7ebf7e6be338
commit 50aefa68d1c28356f28c12ff6f570ed5d92490b6
Author: Olivier Hallot 
AuthorDate: Thu Jun 20 13:57:42 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:02:06 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve relations Math symbols display in Help page

resize and arrange relations symbols svg in Help page

Change-Id: I4c9373cbbd36741ab55d5c7f1429d61ef736b68b
Reviewed-on: https://gerrit.libreoffice.org/74477
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 589e7f29b4f0..592cfdd7506b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 589e7f29b4f02d45300d596036516f6b3c0bf202
+Subproject commit 592cfdd7506b085016acb817fa99116a78f76e1c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2019-06-21 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f76cf54440f9c6dace7b44825d1a250ad62b91c4
Author: Olivier Hallot 
AuthorDate: Thu Jun 20 11:49:17 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:01:36 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Improve functions Math symbols display in Help page

resize Math funcitons icons (svg's)

Change-Id: I36acb1b7d9ef9aafcd1dd88c24a4130918341d28
Reviewed-on: https://gerrit.libreoffice.org/74476
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3d96bec89634..589e7f29b4f0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3d96bec89634abb41c4bcac89814afd76f30833a
+Subproject commit 589e7f29b4f02d45300d596036516f6b3c0bf202
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126044] Colibre icon for insert -> Field -> Field name in Draw/Impress is a but confusing (file open icon)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126044

--- Comment #1 from Telesto  ---
Insert -> form control -> File section has also the same icon

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: 4 commits - source/media source/text

2019-06-21 Thread Olivier Hallot (via logerrit)
 source/media/helpimg/starmath/bi21301.svg |   76 +++-
 source/media/helpimg/starmath/bi21302.svg |   83 
 source/media/helpimg/starmath/bi21303.svg |   73 +++-
 source/media/helpimg/starmath/bi21304.svg |   75 +++-
 source/media/helpimg/starmath/bi21305.svg |   73 +++-
 source/media/helpimg/starmath/bi21306.svg |   73 +++-
 source/media/helpimg/starmath/bi21307.svg |   72 +++-
 source/media/helpimg/starmath/bi21308.svg |   72 +++-
 source/media/helpimg/starmath/bi21309.svg |   74 +++-
 source/media/helpimg/starmath/bi21310.svg |   75 +++-
 source/media/helpimg/starmath/bi21311.svg |   77 +++-
 source/media/helpimg/starmath/bi21312.svg |   77 +++-
 source/media/helpimg/starmath/bi21313.svg |   75 +++-
 source/media/helpimg/starmath/bi21314.svg |   76 +++-
 source/media/helpimg/starmath/bi21315.svg |   74 +++-
 source/media/helpimg/starmath/bi21316.svg |   74 +++-
 source/media/helpimg/starmath/bi21322.svg |   76 +++-
 source/media/helpimg/starmath/bi21323.svg |   77 +++-
 source/media/helpimg/starmath/bi21324.svg |   74 +++-
 source/media/helpimg/starmath/bi21325.svg |   75 +++-
 source/media/helpimg/starmath/bi21326.svg |   75 +++-
 source/media/helpimg/starmath/bi21327.svg |   75 +++-
 source/media/helpimg/starmath/bi21328.svg |   77 +++-
 source/media/helpimg/starmath/bi21329.svg |   78 +++-
 source/media/helpimg/starmath/bi21330.svg |   79 +++-
 source/media/helpimg/starmath/bi21331.svg |   80 +++-
 source/media/helpimg/starmath/bi21332.svg |   83 +++-
 source/media/helpimg/starmath/bi21333.svg |   77 +++-
 source/media/helpimg/starmath/bi21334.svg |   71 +++-
 source/media/helpimg/starmath/fo21601.svg |   84 +++-
 source/media/helpimg/starmath/fo21602.svg |   69 +++-
 source/media/helpimg/starmath/fo21603.svg |   69 +++-
 source/media/helpimg/starmath/fo21604.svg |   70 +++-
 source/media/helpimg/starmath/fo21605.svg |   70 +++-
 source/media/helpimg/starmath/fo21606.svg |   72 +++-
 source/media/helpimg/starmath/fo21607.svg |   72 +++-
 source/media/helpimg/starmath/fo21609.svg |   66 +++
 source/media/helpimg/starmath/fo21610.svg |   68 +++
 source/media/helpimg/starmath/fo21611.svg |   68 +++
 source/media/helpimg/starmath/fo21613.svg |   97 -
 source/media/helpimg/starmath/fo21614.svg |   77 +++-
 source/media/helpimg/starmath/fo21615.svg |   81 +++-
 source/media/helpimg/starmath/op21401.svg |   74 +++-
 source/media/helpimg/starmath/op21402.svg |   75 +++-
 source/media/helpimg/starmath/op21403.svg |   75 +++-
 source/media/helpimg/starmath/op21405.svg |   76 +++-
 source/media/helpimg/starmath/op21406.svg |   77 +++-
 source/media/helpimg/starmath/op21407.svg |   77 +++-
 source/media/helpimg/starmath/op21408.svg |   79 +++-
 source/media/helpimg/starmath/op21409.svg |   81 +++-
 source/media/helpimg/starmath/op21410.svg |   75 +++-
 source/media/helpimg/starmath/op21411.svg |   71 +++-
 source/media/helpimg/starmath/op21412.svg |   72 +++-
 source/media/helpimg/starmath/op21413.svg |   74 +++-
 source/media/helpimg/starmath/op21414.svg |   77 +++-
 source/media/helpimg/starmath/op21415.svg |   74 +++-
 source/media/helpimg/starmath/op21416.svg |   75 +++-
 source/media/helpimg/starmath/op21417.svg |   61 +++
 source/media/helpimg/starmath/op21418.svg |   62 +++
 source/media/helpimg/starmath/op21419.svg |   62 +++
 source/media/helpimg/starmath/op21420.svg |   62 +++
 source/media/helpimg/starmath/op21421.svg |   61 +++
 source/media/helpimg/starmath/op22001.svg |   62 +++
 source/media/helpimg/starmath/op22002.svg |   63 +++
 source/media/helpimg/starmath/un21201.svg |   66 +++
 source/media/helpimg/starmath/un21202.svg |   67 +++
 source/media/helpimg/starmath/un21203.svg |   65 +++
 source/media/helpimg/starmath/un21204.svg |   65 +++
 source/media/helpimg/starmath/un21205.svg |   71 +++-
 source/media/helpimg/starmath/un21206.svg |   73 +++-
 source/media/helpimg/starmath/un21207.svg |   74 +++-
 source/media/helpimg/starmath/un21208.svg |   74 +++-
 source/media/helpimg/starmath/un21209.svg |   74 +++-
 source/media/helpimg/starmath/un21210.svg |   72 +++-
 source/media/helpimg/starmath/un21211.svg |   74 +++-
 source/media/helpimg/starmath/un21212.svg |   74 +++-
 source/media/helpimg/starmath/un21213.svg |   70 +++-
 source/media/helpimg/starmath/un21214.svg |   79 +++-
 source/media/helpimg/starmath/un21215.svg |   74 +++-
 source/media/helpimg/starmath/un21221.svg |   76 +++-
 source/text/smath/01/03090100.xhp |   32 -
 source/text/smath/01/03090200.xhp |  174 +-
 source/text/smath/01/03090300.xhp |  514 ++
 source/text/smath/01/03090800.xhp |   44 +-
 84 files changed, 5365 insertions(+), 1271 deletions(-)

New commits:
commit 53674dc8cec4ca160c70819074e02c6b554b229b
Author: Olivier Hallot 
AuthorDate: Fri Jun 21 16:16:56 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 19:03:05 2019 +0200

Improve Operator symbols in Math help pages

Rezise image and clean svg's


[Libreoffice-commits] help.git: 2 commits - source/media source/text

2019-06-21 Thread Olivier Hallot (via logerrit)
 source/media/helpimg/starmath/fu21501.svg |   76 +--
 source/media/helpimg/starmath/fu21502.svg |   70 --
 source/media/helpimg/starmath/fu21503.svg |   77 +--
 source/media/helpimg/starmath/fu21504.svg |   81 +--
 source/media/helpimg/starmath/fu21505.svg |   67 -
 source/media/helpimg/starmath/fu21506.svg |   68 -
 source/media/helpimg/starmath/fu21507.svg |   73 +-
 source/media/helpimg/starmath/fu21508.svg |   73 +-
 source/media/helpimg/starmath/fu21509.svg |   70 +-
 source/media/helpimg/starmath/fu21510.svg |   71 +-
 source/media/helpimg/starmath/fu21511.svg |   72 +-
 source/media/helpimg/starmath/fu21512.svg |   73 +-
 source/media/helpimg/starmath/fu21513.svg |   75 +--
 source/media/helpimg/starmath/fu21514.svg |   78 +--
 source/media/helpimg/starmath/fu21515.svg |   79 +--
 source/media/helpimg/starmath/fu21516.svg |   79 +--
 source/media/helpimg/starmath/fu21517.svg |   80 ++-
 source/media/helpimg/starmath/fu21518.svg |   80 ++-
 source/media/helpimg/starmath/fu21519.svg |   79 ++-
 source/media/helpimg/starmath/fu21520.svg |   80 ++-
 source/media/helpimg/starmath/fu21521.svg |   83 ++--
 source/media/helpimg/starmath/fu21522.svg |   85 ++--
 source/media/helpimg/starmath/fu21523.svg |   85 ++--
 source/media/helpimg/starmath/fu21524.svg |   84 ++--
 source/media/helpimg/starmath/fu21908.svg |   71 --
 source/text/shared/explorer/database/menuview.xhp |4 
 source/text/smath/01/03090400.xhp |  150 +++---
 27 files changed, 1718 insertions(+), 345 deletions(-)

New commits:
commit 589e7f29b4f02d45300d596036516f6b3c0bf202
Author: Olivier Hallot 
AuthorDate: Thu Jun 20 11:49:17 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 19:01:36 2019 +0200

Improve functions Math symbols display in Help page

resize Math funcitons icons (svg's)

Change-Id: I36acb1b7d9ef9aafcd1dd88c24a4130918341d28
Reviewed-on: https://gerrit.libreoffice.org/74476
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/media/helpimg/starmath/fu21501.svg 
b/source/media/helpimg/starmath/fu21501.svg
index 47c7f802f..a6f0950a8 100644
--- a/source/media/helpimg/starmath/fu21501.svg
+++ b/source/media/helpimg/starmath/fu21501.svg
@@ -1,16 +1,66 @@
-
-http://www.w3.org/2000/svg; version="1.1">
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   version="1.1"
+   id="svg8"
+   sodipodi:docname="fu21501.svg"
+   width="23"
+   height="23"
+   inkscape:version="0.92.4 (5da689c313, 2019-01-14)">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+  
   
+ d="M 5.64065,16.311 V 6.679 h 0.6367 v 9.632 z"
+ id="path2"
+ inkscape:connector-curvature="0" />
   
+ d="m 15.33635,14.445 v 0.352 h -3.324 v -0.352 l 0.976,-0.179 
-1.695,-2.602 -1.985,2.617 1.008,0.164 v 0.352 h -2.64 v -0.352 l 0.851,-0.125 
2.414,-3.187 L 8.81635,8 7.94935,7.805 V 7.453 h 3.328 v 0.352 l -0.976,0.211 
1.414,2.109 1.625,-2.125 -1.008,-0.195 V 7.453 h 2.644 v 0.352 l -0.847,0.164 
-2.063,2.672 2.414,3.64 z"
+ id="path4"
+ inkscape:connector-curvature="0" />
   
-
\ No newline at end of file
+ d="M 16.72235,16.321 V 6.693 h 0.637 v 9.628 z"
+ id="path6"
+ inkscape:connector-curvature="0" />
+
diff --git a/source/media/helpimg/starmath/fu21502.svg 
b/source/media/helpimg/starmath/fu21502.svg
index bc07f8109..6f3d9098b 100644
--- a/source/media/helpimg/starmath/fu21502.svg
+++ b/source/media/helpimg/starmath/fu21502.svg
@@ -1,12 +1,62 @@
-
-http://www.w3.org/2000/svg; version="1.1">
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   version="1.1"
+   id="svg20"
+   sodipodi:docname="fu21502.svg"
+   width="23"
+   height="23"
+   inkscape:version="0.92.4 (5da689c313, 2019-01-14)">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+  
   
+ d="m 12.814,15.209 v 0.29 H 

[Libreoffice-commits] core.git: 2 commits - helpcontent2

2019-06-21 Thread Gabor Kelemen (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fa664e9d30ca9e69af8b5b2c1f3e7739b55f30bb
Author: Gabor Kelemen 
AuthorDate: Fri Jun 21 00:37:37 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:00:53 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Fix ahelps on Base View menu page

Add missing bookmarks and remove unneeded ahelp

Change-Id: I22c73e85869ffcdac235d740230f951c40d0503b
Reviewed-on: https://gerrit.libreoffice.org/74475
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index ae70eaf3dfab..3d96bec89634 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ae70eaf3dfabeb31fc54d83f91cbd664e602e91c
+Subproject commit 3d96bec89634abb41c4bcac89814afd76f30833a
commit f7b13a94645b158821c9d7db63c63da4b724a441
Author: Gabor Kelemen 
AuthorDate: Fri Jun 21 00:11:09 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 19:00:04 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Drop unneeded ahelp from Base Insert menu page

Change-Id: I0f8f13219e862cc3dd0439fe29fe1655d3cee972
Reviewed-on: https://gerrit.libreoffice.org/74474
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index e198ed22f7b7..ae70eaf3dfab 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e198ed22f7b7fd99e7b63d7e13cb52619f423b91
+Subproject commit ae70eaf3dfabeb31fc54d83f91cbd664e602e91c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126044] New: Colibre icon for insert -> Field -> Field name in Draw/Impress is a but confusing (file open icon)

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126044

Bug ID: 126044
   Summary: Colibre icon for insert -> Field -> Field name in
Draw/Impress is a but confusing (file open icon)
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Colibre icon for insert -> Field -> Field name in Draw/Impress is a but
confusing (file open icon)

Steps to Reproduce:
1. Open Draw
2. insert -> Field -> Field name

Actual Results:
Ambiguous icon

Expected Results:
Something else.. 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

2019-06-21 Thread Gabor Kelemen (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5427ce7c66ccf16b0a405fddb402c35181e47e4a
Author: Gabor Kelemen 
AuthorDate: Fri Jun 21 00:06:44 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 18:59:28 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Fix ahelps in Base Edit menu description page

- Add missing bookmarks
- Remove obsolete ones
- Move an item closer to its current position in the menu

Still a very obsolete page :(

Change-Id: I0f19f9a0ea61724bb725cbe9efb83afc8abcb19f
Reviewed-on: https://gerrit.libreoffice.org/74473
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 2d492d79f2da..e198ed22f7b7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2d492d79f2da5002a69e3ad277a8f6b83fea1c07
+Subproject commit e198ed22f7b7fd99e7b63d7e13cb52619f423b91
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2019-06-21 Thread Gabor Kelemen (via logerrit)
 source/text/shared/explorer/database/menuinsert.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ae70eaf3dfabeb31fc54d83f91cbd664e602e91c
Author: Gabor Kelemen 
AuthorDate: Fri Jun 21 00:11:09 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 19:00:04 2019 +0200

Drop unneeded ahelp from Base Insert menu page

Change-Id: I0f8f13219e862cc3dd0439fe29fe1655d3cee972
Reviewed-on: https://gerrit.libreoffice.org/74474
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/explorer/database/menuinsert.xhp 
b/source/text/shared/explorer/database/menuinsert.xhp
index d5d0c39b7..76b40bf50 100644
--- a/source/text/shared/explorer/database/menuinsert.xhp
+++ b/source/text/shared/explorer/database/menuinsert.xhp
@@ -32,7 +32,7 @@
 
 Insert
 
-The Insert menu of a database window.
+The Insert menu 
of a database window.
 Form
 Opens a new text document in form mode.
 Report
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2019-06-21 Thread Gabor Kelemen (via logerrit)
 source/text/shared/explorer/database/menuedit.xhp |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit e198ed22f7b7fd99e7b63d7e13cb52619f423b91
Author: Gabor Kelemen 
AuthorDate: Fri Jun 21 00:06:44 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 18:59:28 2019 +0200

Fix ahelps in Base Edit menu description page

- Add missing bookmarks
- Remove obsolete ones
- Move an item closer to its current position in the menu

Still a very obsolete page :(

Change-Id: I0f19f9a0ea61724bb725cbe9efb83afc8abcb19f
Reviewed-on: https://gerrit.libreoffice.org/74473
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/explorer/database/menuedit.xhp 
b/source/text/shared/explorer/database/menuedit.xhp
index 897f5e891..44c7e0869 100644
--- a/source/text/shared/explorer/database/menuedit.xhp
+++ b/source/text/shared/explorer/database/menuedit.xhp
@@ -33,24 +33,26 @@
 
 Edit
 
-The Edit menu of a database window.
+The Edit menu 
of a database window.
 Copy
 Copies the selected object to the clipboard.
 Paste
 Inserts an item from the clipboard. If you want, you can insert forms 
and reports, including subfolders, from one database file to 
another.
+
 Paste 
Special
 Inserts an item from the clipboard. If you want, you can insert forms 
and reports, including subfolders, from one database file to 
another.
 
+
+Select 
All
+Selects all entries, including subfolders, in the lower part of the 
database window.
 
 
-
 Edit
 Opens a window where you can edit the selected table, query, form, or 
report.
 
 
-
 Delete
-Deletes the selected table, query, form, or 
report.
+Deletes the selected table, query, form, or report.
 
 
 Rename
@@ -68,8 +70,6 @@
 
 Report 
Wizard
 Starts the Report 
Wizard for the selected table, query, or view.
-Select 
All
-Selects all entries, including subfolders, in the lower part of the 
database window.
 
 Database
 Opens a submenu.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2019-06-21 Thread Gabor Kelemen (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a264abfd56cc70d565707028be41ff94e65a7f43
Author: Gabor Kelemen 
AuthorDate: Thu Jun 20 19:39:58 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Fri Jun 21 18:57:58 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Fix ahelp for HTML page - Size spinbuttons

Change-Id: I527a54be3e69039810b0505b9c50cdb3128b1c45
Reviewed-on: https://gerrit.libreoffice.org/74465
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index ca3dda78509c..2d492d79f2da 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ca3dda78509c00f9dc95fe1fe8590fa88814a866
+Subproject commit 2d492d79f2da5002a69e3ad277a8f6b83fea1c07
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2019-06-21 Thread Gabor Kelemen (via logerrit)
 source/text/shared/optionen/01030500.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2d492d79f2da5002a69e3ad277a8f6b83fea1c07
Author: Gabor Kelemen 
AuthorDate: Thu Jun 20 19:39:58 2019 +0200
Commit: Olivier Hallot 
CommitDate: Fri Jun 21 18:57:58 2019 +0200

Fix ahelp for HTML page - Size spinbuttons

Change-Id: I527a54be3e69039810b0505b9c50cdb3128b1c45
Reviewed-on: https://gerrit.libreoffice.org/74465
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/optionen/01030500.xhp 
b/source/text/shared/optionen/01030500.xhp
index d23b3fbd1..f3d17acda 100644
--- a/source/text/shared/optionen/01030500.xhp
+++ b/source/text/shared/optionen/01030500.xhp
@@ -47,7 +47,7 @@
 
 
 Font 
sizes
-Use the spin buttons Size 1 to 
Size 7 to define the respective font sizes for the HTML font 
size=1 to font size=7 tags.
+Use the spin buttons Size 1 to Size 7 to 
define the respective font sizes for the HTML font size=1 to font 
size=7 tags.
 Import
 Defines the 
settings for importing HTML documents.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126043] New: Tools -> Customize has a nagging delay of 3 seconds on each opening

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126043

Bug ID: 126043
   Summary: Tools -> Customize has a nagging delay of 3 seconds on
each opening
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Tools -> Customize has a nagging delay of 3 seconds on each opening

Steps to Reproduce:
1. Open Writer
2. Tools -> Customize (open the dialog 2-3 times). First maybe a little
slower.. (initialization) 

Actual Results:
3 seconds before dialog

Expected Results:
1 - 1.5 seconds


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

but not in
6.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - basctl/source

2019-06-21 Thread Caolán McNamara (via logerrit)
 basctl/source/basicide/basides1.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 65f483a86d0702928c9283d3dacd05af0e5fc4b2
Author: Caolán McNamara 
AuthorDate: Fri Jun 21 14:14:44 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jun 21 18:48:18 2019 +0200

search dialog is welded

Change-Id: I51fa749266efed733aeff9d2e22d7d5f628468c1
Reviewed-on: https://gerrit.libreoffice.org/74514
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index c04f0c346893..9a6c1d91cbc0 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -173,9 +173,9 @@ void Shell::ExecuteSearch( SfxRequest& rReq )
 {
 SfxViewFrame* pViewFrame = GetViewFrame();
 SfxChildWindow* pChildWin = pViewFrame ? 
pViewFrame->GetChildWindow( SID_SEARCH_DLG ) : nullptr;
-vcl::Window* pParent = pChildWin ? 
pChildWin->GetWindow() : nullptr;
+auto xParent = pChildWin ? 
pChildWin->GetController() : nullptr;
 
-std::unique_ptr 
xQueryBox(Application::CreateMessageDialog(pParent ? pParent->GetFrameWeld() : 
nullptr,
+std::unique_ptr 
xQueryBox(Application::CreateMessageDialog(xParent ? xParent->getDialog() : 
nullptr,

VclMessageType::Question, VclButtonsType::YesNo,

IDEResId(RID_STR_SEARCHFROMSTART)));
 xQueryBox->set_default_response(RET_YES);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126042] Title and extension version number are mangled together in extension dialog

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126042

--- Comment #1 from Telesto  ---
Created attachment 152350
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152350=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126042] New: Title and extension version number are mangled together in extension dialog

2019-06-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126042

Bug ID: 126042
   Summary: Title and extension version number are mangled
together in extension dialog
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Title and extension version number are mangled together in extension dialog

Steps to Reproduce:
1. Open Writer
2. Tools -> Extension Manager

Actual Results:
Title and extension version number are mangled together in extension dialog

Expected Results:
Should be so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   >