[Libreoffice-bugs] [Bug 126467] Memory leak, crushes OS
https://bugs.documentfoundation.org/show_bug.cgi?id=126467 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEEDINFO --- Comment #4 from raal --- I doesn't see this bug in Version: 6.4.0.0.alpha0+ Build ID: 47a774fbef8c224e4853de3fdd0230b9442bb716 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; You can use appimage or snap for testing> https://www.libreoffice.org/download/appimage/ https://www.libreoffice.org/download/snap/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95420] Optimal row height not determined correctly for small font rows
https://bugs.documentfoundation.org/show_bug.cgi?id=95420 raal changed: What|Removed |Added CC||dcoll...@superdan.net --- Comment #10 from raal --- *** Bug 126490 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126490] FORMATTING: Row height not reduced for small fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=126490 raal changed: What|Removed |Added CC||r...@post.cz Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from raal --- Hello, Thank you for submitting the bug. The bug has previously been reported, so this bug will be added as a duplicate of it. You will automatically be CCed to updates made to the other bug. *** This bug has been marked as a duplicate of bug 95420 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126490] New: FORMATTING: Row height not reduced for small fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=126490 Bug ID: 126490 Summary: FORMATTING: Row height not reduced for small fonts Product: LibreOffice Version: 6.2.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dcoll...@superdan.net Description: Row heights are automatically set to large values if the font size is set to a large number. However, smaller-than-normal font sizes do not reduce the row height below the starting value. Steps to Reproduce: 1. Make a new Calc file. 2. Select all the cells. 3. Observe start font size 10 (row height 0.18"). 4. Set font size to 14 (observe row height 0.24"). 4. Set font size to 6 (observe row height 0.18"). Actual Results: Font size 10 and any smaller font size all generate the same row height (0.18"). Expected Results: Smaller font sizes (e.g., below 10) should generate correspondingly smaller row heights (symmetric with large font sizes generating larger row heights). Reproducible: Always User Profile Reset: No Additional Info: The steps above use direct formatting of the cells; the same behavior is seen if we modify font size in the styles (including default style). Manually selecting Optimal Row Height also does not change the row height from these results. As a consequence, if the user wants to fit more rows on a page using a small font, then we must manually determine and set an appropriate row height for that purpose. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121545] Borders and background from format header menu is missing formatting options
https://bugs.documentfoundation.org/show_bug.cgi?id=121545 Dieter Praas changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #9 from Dieter Praas --- Verified with Version: 6.4.0.0.alpha0+ (x64) Build ID: 2f2f4767089512c34514896bc37823f9310e9dd4 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-10_02:13:57 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126256] FORMATTING, FILEOPEN: Plain text document in (codepage 437) with commercial font displays incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=126256 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122240] LibreOffice is crashing when I try to open it
https://bugs.documentfoundation.org/show_bug.cgi?id=122240 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122844] Crash in: SwTableBox::GetSttIdx
https://bugs.documentfoundation.org/show_bug.cgi?id=122844 --- Comment #2 from QA Administrators --- Dear Paolo Redaelli, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122240] LibreOffice is crashing when I try to open it
https://bugs.documentfoundation.org/show_bug.cgi?id=122240 --- Comment #4 from QA Administrators --- Dear Edward, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122847] Bullets and Numbering format not working
https://bugs.documentfoundation.org/show_bug.cgi?id=122847 --- Comment #3 from QA Administrators --- Dear Kevin Loughrey, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122853] The slides are not moving forward while in full screen mode using Presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=122853 --- Comment #2 from QA Administrators --- Dear Johan Jooste, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126467] Memory leak, crushes OS
https://bugs.documentfoundation.org/show_bug.cgi?id=126467 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126467] Memory leak, crushes OS
https://bugs.documentfoundation.org/show_bug.cgi?id=126467 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126250] make function returning values or reference capable of returning values or reference
https://bugs.documentfoundation.org/show_bug.cgi?id=126250 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93975] Toolbar table borders control causes spacing to content issues (see comment #6)
https://bugs.documentfoundation.org/show_bug.cgi?id=93975 --- Comment #12 from QA Administrators --- Dear thanasis57, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121625] undesired drag while selecting a checkbox
https://bugs.documentfoundation.org/show_bug.cgi?id=121625 --- Comment #4 from QA Administrators --- Dear Fabio Zaffora, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118499] Custom Document Property Button Randomly Blinking
https://bugs.documentfoundation.org/show_bug.cgi?id=118499 --- Comment #4 from QA Administrators --- Dear Rizal Muttaqin, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88930] QUERY column type thought to be TEXT when coming from subquery
https://bugs.documentfoundation.org/show_bug.cgi?id=88930 --- Comment #11 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107055] FILEOPEN: DOCX DOC Change in Kerning Causing Cut-off Text in Table
https://bugs.documentfoundation.org/show_bug.cgi?id=107055 --- Comment #12 from QA Administrators --- Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116994] Undo isn't working for a comment which was shown at the moment adding a new sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=116994 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120666] FILESAVE does not save master view
https://bugs.documentfoundation.org/show_bug.cgi?id=120666 j...@lauterbachandassociates.net changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INSUFFICIENTDATA|--- --- Comment #9 from j...@lauterbachandassociates.net --- This problem is far from resolved. Impress will not save master view if program is closed and PC is rebooted. For example, if I change opening master view to use Calibri font instead of Arial and/or I change the indents or other aspects of a typical outline-type presentation slide, they are not saved. When I go make another presentation, I get the original Impress master view. Apparently, those who are in charge of Impress think that their choices or fonts and other aspects are the ones to use. If you want details, please tell me how I should send you the slide copy or other data you need, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - configure.ac instsetoo_native/util
configure.ac|2 +- instsetoo_native/util/openoffice.lst.in |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 71710e17a9449ec582949335895753bef39f4f11 Author: Thorsten Behrens AuthorDate: Sat Jul 20 01:48:23 2019 +0200 Commit: Thorsten Behrens CommitDate: Sun Jul 21 04:01:59 2019 +0200 Bump version to 6.1.7.2 (and get signed msi packages back) Change-Id: I49748d9a1e0c9af4e3e248b45bf59a282411c8b2 diff --git a/configure.ac b/configure.ac index 4097dd565e50..b2a074b5bc8e 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice powered by CIB],[6.1.7.1],[],[],[https://libreoffice.cib.eu/]) +AC_INIT([LibreOffice powered by CIB],[6.1.7.2],[],[],[https://libreoffice.cib.eu/]) AC_PREREQ([2.59]) diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index 7c8daf33f52f..6feb827aed65 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -27,7 +27,7 @@ Globals REGISTRYLAYERNAME Layers SERVICEPACK 1 UPDATE_DATABASE 1 -CREATE_MSP_INSTALLSET 1 +CREATE_MSP_INSTALLSET 0 UPDATE_DATABASE_LISTNAME finals_instsetoo.txt PACKAGEMAP package_names.txt,package_names_ext.txt WINDOWSPATCHLEVEL @LIBO_VERSION_PATCH@ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94395] line spacing change in paragraph style not displayed in Organizer
https://bugs.documentfoundation.org/show_bug.cgi?id=94395 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #17 from Jim Raykowski --- Hi All, here is a patch to make line spacing show in the organizer tab page contains area. It also patches bug 126466. https://gerrit.libreoffice.org/#/c/76069/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113138] FILESAVE general input/output error on save, files truncated
https://bugs.documentfoundation.org/show_bug.cgi?id=113138 --- Comment #11 from D Schumann --- I have had the same error several different times over the past month or two. I'm using 6.1.6.3 on Arch Linux. All saves are to the local hard drive. I suspect (but don't know for sure) that they are related to .docx or .xlsx files. I am taking a course where the instructor requires submissions of assignments in .docx format, so I am saving assignments in .docx format. I click "Save" and Libreoffice says "General Input/Output Error", and freezes up. I have to kill libreoffice, and then when it starts up again, it goes through the recovery steps, acts as if the document was recovered successfully, but shows the last successfully saved version of a document. I have lost days worth of work from the error, and I think it should be elevated in status. The most frustration aspect of this error is that once the "General Input/Output Error" pops up, I do not have the option of saving the document to a different format or under a different filename. This is a major failure of the software, in my opinion. One other thing - when this happens, it's clear that Libreoffice had problems with autosaving the document, but did not warn of the failure. This too is a major failure. I am going to try working with the documents in native .odt format and seeing if that fixes this problem, but I am hoping that you will elevate the problem and also add better error handling to the autosave and save functionality of Libreoffice. My issue sounds identical to Stanislav's. Local hard drive. No need to delete profile to start saving again, just kill and restart. Changes lost since last successful save. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - default_images/sw
default_images/sw/res/punkt.png |binary default_images/sw/res/punkt_h.png |binary 2 files changed New commits: commit d574acfca286e8d3b9d73559664294a6b2c3d86d Author: Matthias Seidel AuthorDate: Sat Jul 20 22:46:55 2019 + Commit: Matthias Seidel CommitDate: Sat Jul 20 22:46:55 2019 + Updated graphics (navigation) diff --git a/default_images/sw/res/punkt.png b/default_images/sw/res/punkt.png index c5870270382d..587f080e99de 100644 Binary files a/default_images/sw/res/punkt.png and b/default_images/sw/res/punkt.png differ diff --git a/default_images/sw/res/punkt_h.png b/default_images/sw/res/punkt_h.png index 9902f58db1e3..75426c941aa9 100644 Binary files a/default_images/sw/res/punkt_h.png and b/default_images/sw/res/punkt_h.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
CppCheck Report Failure
The cppcheck job failed with message: "Failed to run cppcheck." Note: The script generating this report was run at : 2019-21-07 01:04:01 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh cppcheck-report.log.gz Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 126164] EDITING Error at Paste: Instead to overwrite selected text by text from clipboard selected text iis copied to clipbpoard
https://bugs.documentfoundation.org/show_bug.cgi?id=126164 stefan_lange...@t-online.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from stefan_lange...@t-online.de --- It seems the bug was solved without anyone has explicitely corrected it: I cannot reproduce the described behavior neither with Version: 6.3.0.2 (x64) Build-ID: 728469fa359ba8c83d812146293a0b0aa53945ba CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded nor with Version: 6.4.0.0.alpha0+ (x64) Build ID: 140b070bb187e3d5e35a588a1d187e3a40e11547 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-20_12:36:59 Locale: de-DE (de_DE); UI-Language: en-US Calc: threaded Therefore I change the bug to RESOLVED with reason WORKSFORME. OK? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sd/uiconfig
sd/uiconfig/sdraw/ui/notebookbar.ui | 205 +++ sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui| 146 +++- sd/uiconfig/simpress/ui/notebookbar.ui| 205 +++ sd/uiconfig/simpress/ui/notebookbar_groupedbar_compact.ui | 242 +- 4 files changed, 748 insertions(+), 50 deletions(-) New commits: commit 59b5eca7030a091b9f39257897e757a51f2345e1 Author: andreas kainz AuthorDate: Sat Jul 20 17:02:35 2019 +0200 Commit: andreas_kainz CommitDate: Sun Jul 21 00:38:16 2019 +0200 tdf#124583 NB draw/impress sync -context-draw stuff Change-Id: I5e214c6f78a4b2e8c17861d813efba2dff90be53 Reviewed-on: https://gerrit.libreoffice.org/76025 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sd/uiconfig/sdraw/ui/notebookbar.ui b/sd/uiconfig/sdraw/ui/notebookbar.ui index 9213b216ef82..1c7145b3336a 100644 --- a/sd/uiconfig/sdraw/ui/notebookbar.ui +++ b/sd/uiconfig/sdraw/ui/notebookbar.ui @@ -12575,7 +12575,7 @@ -+ @@ -12697,7 +12697,7 @@ - + @@ -12806,7 +12806,7 @@ - + @@ -12940,7 +12940,7 @@ - + @@ -12998,7 +12998,7 @@ - + @@ -13120,7 +13120,7 @@ - + @@ -13220,7 +13220,7 @@ - + @@ -13230,6 +13230,187 @@ + +True +False +center +True + + +True +False +5 +5 +vertical + + +False +True +5 +0 + + + + +True +False +center +True +both +False +3 + + +True +False +.uno:GlueEditMode + + +True +True + + + + +False +True +2 + + + + + + + +False +True +10 + + + + +True +
[Libreoffice-bugs] [Bug 124583] notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 --- Comment #5 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/59b5eca7030a091b9f39257897e757a51f2345e1%5E%21 tdf#124583 NB draw/impress sync -context-draw stuff It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124583] notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124583] notebookbar draw add shape related stuff
https://bugs.documentfoundation.org/show_bug.cgi?id=124583 andreas_k changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sd/uiconfig
sd/uiconfig/sdraw/ui/notebookbar_single.ui |1 + sd/uiconfig/simpress/ui/notebookbar_compact.ui |1 - 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 8e28192c23c9e4aebd95f9af567df5c860d9a73e Author: andreas kainz AuthorDate: Sat Jul 20 15:50:05 2019 +0200 Commit: andreas_kainz CommitDate: Sun Jul 21 00:37:39 2019 +0200 NB fix context-MultiObject and 3D in draw and impress Change-Id: I8b173dc32309d205171524b9cf0249079585b55f Reviewed-on: https://gerrit.libreoffice.org/76001 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/sd/uiconfig/sdraw/ui/notebookbar_single.ui b/sd/uiconfig/sdraw/ui/notebookbar_single.ui index abd9c3309712..81aef999ba81 100644 --- a/sd/uiconfig/sdraw/ui/notebookbar_single.ui +++ b/sd/uiconfig/sdraw/ui/notebookbar_single.ui @@ -5642,6 +5642,7 @@+ diff --git a/sd/uiconfig/simpress/ui/notebookbar_compact.ui b/sd/uiconfig/simpress/ui/notebookbar_compact.ui index 591a2c68674e..76c6c15e54da 100644 --- a/sd/uiconfig/simpress/ui/notebookbar_compact.ui +++ b/sd/uiconfig/simpress/ui/notebookbar_compact.ui @@ -14069,7 +14069,6 @@ - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 102062] [META] Notebookbar: bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102062 Bug 102062 depends on bug 124583, which changed state. Bug 124583 Summary: notebookbar draw add shape related stuff https://bugs.documentfoundation.org/show_bug.cgi?id=124583 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/anyrefdg.hxx |2 +-
sc/source/ui/miscdlgs/anyrefdg.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 8c02e1790cc0f3dd7a9868f66173369d704df880
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:36:54 2019 +0100
Commit: Caolán McNamara
CommitDate: Sun Jul 21 00:31:39 2019 +0200
cid#1399198 Uncaught exception
Change-Id: Ibf07c82669919a3f905b416e92cfbe0f08d99a8d
Reviewed-on: https://gerrit.libreoffice.org/76004
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/inc/anyrefdg.hxx b/sc/source/ui/inc/anyrefdg.hxx
index 1417662956be..4684bdaf2031 100644
--- a/sc/source/ui/inc/anyrefdg.hxx
+++ b/sc/source/ui/inc/anyrefdg.hxx
@@ -53,7 +53,7 @@ class ScFormulaReferenceHelper
public:
ScFormulaReferenceHelper(IAnyRefDialog* _pDlg, SfxBindings* _pBindings);
-~ScFormulaReferenceHelper();
+~ScFormulaReferenceHelper() COVERITY_NOEXCEPT_FALSE;
void dispose();
voidShowSimpleReference(const OUString& rStr);
diff --git a/sc/source/ui/miscdlgs/anyrefdg.cxx
b/sc/source/ui/miscdlgs/anyrefdg.cxx
index 168070ea4e64..b9e5b271006e 100644
--- a/sc/source/ui/miscdlgs/anyrefdg.cxx
+++ b/sc/source/ui/miscdlgs/anyrefdg.cxx
@@ -53,7 +53,7 @@
ScFormulaReferenceHelper::ScFormulaReferenceHelper(IAnyRefDialog* _pDlg,SfxBindi
m_bEnableColorRef=aInputOption.GetRangeFinder();
}
-ScFormulaReferenceHelper::~ScFormulaReferenceHelper()
+ScFormulaReferenceHelper::~ScFormulaReferenceHelper() COVERITY_NOEXCEPT_FALSE
{
dispose();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 47896] Too many languages in Format/Language
https://bugs.documentfoundation.org/show_bug.cgi?id=47896 Tor Lillqvist changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47896] Too many languages in Format/Language
https://bugs.documentfoundation.org/show_bug.cgi?id=47896 --- Comment #18 from Tor Lillqvist --- Ed: Please don't touch tags or other fields that developers or QA people have set. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/lok-clipboard' - 14 commits - desktop/qa desktop/source include/LibreOfficeKit sc/source sfx2/source sw/source vcl/source
desktop/qa/data/objects.odt |binary
desktop/qa/desktop_lib/test_desktop_lib.cxx | 24 ++-
desktop/source/lib/init.cxx | 144 --
desktop/source/lib/lokclipboard.cxx | 176 +---
desktop/source/lib/lokclipboard.hxx | 80 +++-
include/LibreOfficeKit/LibreOfficeKit.h |4
include/LibreOfficeKit/LibreOfficeKit.hxx |8 -
sc/source/ui/app/seltrans.cxx | 12 +
sc/source/ui/app/transobj.cxx | 83 +++--
sc/source/ui/inc/seltrans.hxx |1
sc/source/ui/inc/transobj.hxx |1
sfx2/source/view/lokhelper.cxx | 17 ++
sw/source/filter/html/wrthtml.cxx | 30 ++--
sw/source/filter/html/wrthtml.hxx |6
sw/source/uibase/dochdl/swdtflvr.cxx| 42 ++
sw/source/uibase/inc/swdtflvr.hxx |1
vcl/source/treelist/transfer.cxx|3
17 files changed, 527 insertions(+), 105 deletions(-)
New commits:
commit 9af7b5aa10d2b741f3f9ad5545aeb17bbe3eec1a
Author: Michael Meeks
AuthorDate: Sat Jul 20 11:22:09 2019 +0100
Commit: Michael Meeks
CommitDate: Sat Jul 20 21:43:00 2019 +0100
clipboard: encourage paste to show up by having some dummy content.
Having an empty system clipboard is a hyper-unusual state, but quite
common for lok instances - so hide that with the dummy state.
Allows context-menu paste into new documents.
Change-Id: I9ce04cb8a0abfa054a67cb94922d7ac5992d1b29
diff --git a/desktop/source/lib/lokclipboard.cxx
b/desktop/source/lib/lokclipboard.cxx
index f53202903761..17a9c5c54e4f 100644
--- a/desktop/source/lib/lokclipboard.cxx
+++ b/desktop/source/lib/lokclipboard.cxx
@@ -69,6 +69,9 @@ LOKClipboard::LOKClipboard()
:
cppu::WeakComponentImplHelper(m_aMutex)
{
+// Encourage 'paste' menu items to always show up.
+uno::Reference xTransferable(new
LOKTransferable());
+setContents(xTransferable,
uno::Reference());
}
Sequence LOKClipboard::getSupportedServiceNames_static()
@@ -150,6 +153,18 @@ LOKTransferable::LOKTransferable(const OUString& sMimeType,
aContent <<= aSequence;
m_aContent.push_back(aContent);
}
+
+/// Use to ensure we have some dummy content on the clipboard to allow a 1st
'paste'
+LOKTransferable::LOKTransferable()
+{
+m_aContent.reserve(1);
+m_aFlavors = css::uno::Sequence(1);
+initFlavourFromMime(m_aFlavors[0], "text/plain");
+uno::Any aContent;
+aContent <<= OUString();
+m_aContent.push_back(aContent);
+}
+
// cf. sot/source/base/exchange.cxx for these two exceptional types.
void LOKTransferable::initFlavourFromMime(css::datatransfer::DataFlavor&
rFlavor,
OUString aMimeType)
diff --git a/desktop/source/lib/lokclipboard.hxx
b/desktop/source/lib/lokclipboard.hxx
index 1ade5c0a3e0b..3b8f9d8ee7c9 100644
--- a/desktop/source/lib/lokclipboard.hxx
+++ b/desktop/source/lib/lokclipboard.hxx
@@ -77,6 +77,7 @@ class LOKTransferable : public
cppu::WeakImplHelper& aSequence);
commit c620df6d9ea3e8896605349978367888f28a1904
Author: Michael Meeks
AuthorDate: Fri Jun 28 18:36:15 2019 +0100
Commit: Michael Meeks
CommitDate: Sat Jul 20 21:42:59 2019 +0100
Try harder to generate HTML from text.
Change-Id: I5b4778cceefc652274a72b779cd6c060a50bf06c
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 7562133b52c4..32d1edbed9ef 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3339,6 +3339,54 @@ static OUString getGenerator()
static bool getFromTransferrable(
const css::uno::Reference ,
+const OString , OString );
+
+static bool encodeImageAsHTML(
+const css::uno::Reference ,
+const OString , OString )
+{
+if (!getFromTransferrable(xTransferable, aMimeType, aRet))
+return false;
+
+// Encode in base64.
+auto aSeq = Sequence(reinterpret_cast(aRet.getStr()),
+ aRet.getLength());
+OUStringBuffer aBase64Data;
+comphelper::Base64::encode(aBase64Data, aSeq);
+
+// Embed in HTML.
+aRet = "\n"
+""
+""
+"";
+
+return true;
+}
+
+static bool encodeTextAsHTML(
+const css::uno::Reference ,
+const OString , OString )
+{
+if (!getFromTransferrable(xTransferable, aMimeType, aRet))
+return false;
+
+// Embed in HTML - FIXME: needs some escaping.
+aRet = "\n"
+""
+"" + aRet + "";
+
+return true;
+}
+
+static bool getFromTransferrable(
+const css::uno::Reference ,
const OString , OString )
{
OString aMimeType(aInMimeType);
@@ -3364,28 +3412,15 @@ static bool getFromTransferrable(
if (!xTransferable->isDataFlavorSupported(aFlavor))
{
-// If html is not supported, might be a graphic-selection, which
supports png.
-if (aInMimeType == "text/html"
[Libreoffice-commits] core.git: odk/examples odk/util
odk/examples/DevelopersGuide/Components/SimpleLicense/Makefile |2 +- odk/examples/DevelopersGuide/Components/dialogcomponent/Makefile |2 +- odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx |2 +- odk/examples/DevelopersGuide/Database/DriverSkeleton/SStatement.cxx |2 +- odk/examples/DevelopersGuide/Database/sdbcx.java |2 +- odk/examples/DevelopersGuide/Forms/KeyGenerator.java |2 +- odk/examples/DevelopersGuide/Forms/SalesFilter.java |4 ++-- odk/examples/DevelopersGuide/GUI/RoadmapItemStateChangeListener.java |2 +- odk/examples/DevelopersGuide/OfficeDev/ContextMenuInterceptor.java |2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/DocumentView.java |2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java |4 ++-- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java |4 ++-- odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java |4 ++-- odk/examples/DevelopersGuide/OfficeDev/Linguistic/LinguisticExamples.java |2 +- odk/examples/DevelopersGuide/examples.html |4 ++-- odk/examples/cpp/DocumentLoader/DocumentLoader.cxx |2 +- odk/examples/examples.html |2 +- odk/examples/java/ConverterServlet/ConverterServlet.java |2 +- odk/examples/java/Inspector/InspectorPane.java |6 +++--- odk/examples/java/Inspector/Makefile |2 +- odk/examples/java/MinimalComponent/Makefile |2 +- odk/examples/java/Spreadsheet/ChartTypeChange.java |2 +- odk/examples/java/Spreadsheet/EuroAdaption.java |6 +++--- odk/examples/java/Spreadsheet/SCalc.java |8 odk/examples/java/Storage/TestHelper.java |2 +- odk/examples/java/Text/BookmarkInsertion.java |6 +++--- odk/examples/java/Text/HardFormatting.java |4 ++-- odk/examples/java/Text/SWriter.java |4 ++-- odk/examples/java/Text/StyleCreation.java |2 +- odk/examples/java/Text/StyleInitialization.java | 10 +- odk/examples/java/Text/TextReplace.java |4 ++-- odk/examples/python/toolpanel/readme |4 ++-- odk/util/check.pl |2 +- 33 files changed, 55 insertions(+), 55 deletions(-) New commits: commit dd950a6edbd3abc45409724be8cabe1dee71b63d Author: Andrea Gelmini AuthorDate: Sat Jul 20 18:05:48 2019 +0200 Commit: Andrea Gelmini CommitDate: Sat Jul 20 22:39:25 2019 +0200 Fix typos Change-Id: Ib361243332b7219c0073c787c378c648e44705f2 Reviewed-on: https://gerrit.libreoffice.org/75487 Tested-by: Jenkins Reviewed-by: Andrea Gelmini diff --git a/odk/examples/DevelopersGuide/Components/SimpleLicense/Makefile b/odk/examples/DevelopersGuide/Components/SimpleLicense/Makefile index 8dd4f0502f94..efcac2aac3cf 100644 --- a/odk/examples/DevelopersGuide/Components/SimpleLicense/Makefile +++ b/odk/examples/DevelopersGuide/Components/SimpleLicense/Makefile @@ -42,7 +42,7 @@ include $(SETTINGS)/std.mk # Define non-platform/compiler specific settings -# we use the sample directory name dor separating this example +# we use the sample directory name for separating this example # from others in the output directory SAMPLE_NAME=LicenseTest SAMPLE_CLASS_OUT=$(OUT_CLASS)/$(SAMPLE_NAME) diff --git a/odk/examples/DevelopersGuide/Components/dialogcomponent/Makefile b/odk/examples/DevelopersGuide/Components/dialogcomponent/Makefile index f0b38086061a..23d766868eb4 100644 --- a/odk/examples/DevelopersGuide/Components/dialogcomponent/Makefile +++ b/odk/examples/DevelopersGuide/Components/dialogcomponent/Makefile @@ -42,7 +42,7 @@ include $(SETTINGS)/std.mk # Define
[Libreoffice-commits] core.git: odk/examples
odk/examples/cpp/remoteclient/remoteclient.cxx |2 +-
odk/examples/java/EmbedDocument/Container1/EmbedContApp.java |2 +-
odk/examples/java/Inspector/Inspector.java |2 +-
odk/examples/java/Spreadsheet/SCalc.java |4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 2286eb08e7a6a820ec71ed22945cf422fa88a16a
Author: Andrea Gelmini
AuthorDate: Sat Jul 20 19:29:05 2019 +0200
Commit: Andrea Gelmini
CommitDate: Sat Jul 20 22:36:27 2019 +0200
Fix typos in code
Extracted from https://gerrit.libreoffice.org/#/c/75487/1
Change-Id: I80f9247c5c961a33c0d2c8354ea0524820b33409
Reviewed-on: https://gerrit.libreoffice.org/76028
Reviewed-by: Michael Meeks
Tested-by: Andrea Gelmini
diff --git a/odk/examples/cpp/remoteclient/remoteclient.cxx
b/odk/examples/cpp/remoteclient/remoteclient.cxx
index 90f6280c15f4..7af63f15948b 100644
--- a/odk/examples/cpp/remoteclient/remoteclient.cxx
+++ b/odk/examples/cpp/remoteclient/remoteclient.cxx
@@ -168,7 +168,7 @@ sal_Int32 PipeClientMain::run( const Sequence< OUString > &
aArguments ) throw (
{
OString o = OUStringToOString( e.Message,
RTL_TEXTENCODING_ASCII_US );
printf( "%s\n", o.pData->buffer );
-printf( "couldn't access local resource ( possible security resons
)\n" );
+printf( "couldn't access local resource (possible security
reasons)\n" );
}
catch( NoConnectException )
{
diff --git a/odk/examples/java/EmbedDocument/Container1/EmbedContApp.java
b/odk/examples/java/EmbedDocument/Container1/EmbedContApp.java
index 2f198376652b..a275c27eaf7f 100644
--- a/odk/examples/java/EmbedDocument/Container1/EmbedContApp.java
+++ b/odk/examples/java/EmbedDocument/Container1/EmbedContApp.java
@@ -388,7 +388,7 @@ public class EmbedContApp extends Applet implements
MouseListener, XEmbeddedClie
if ( m_xStorage == null )
{
JOptionPane.showMessageDialog( m_aFrame,
-"No storage for oned
file!",
+"No storage for owned
file!",
"Error:",
JOptionPane.ERROR_MESSAGE );
return;
diff --git a/odk/examples/java/Inspector/Inspector.java
b/odk/examples/java/Inspector/Inspector.java
index 18d8d909a449..18a75bcdb469 100644
--- a/odk/examples/java/Inspector/Inspector.java
+++ b/odk/examples/java/Inspector/Inspector.java
@@ -88,7 +88,7 @@ public class Inspector{
private TDocSupplier oTDocSupplier;
private Introspector m_oIntrospector = null;
// TODO: improve these strings:
-private static final String sWRONGINSTALLATIONPATH = "Your selected
path does not refer to an SDK-Installation!";
+private static final String sWRONGINSTALLATIONPATH = "Your selected
path does not refer to a SDK-Installation!";
/** Creates a new instance of Dialog */
public _Inspector(XComponentContext _xComponentContext) {
m_xComponentContext = _xComponentContext;
diff --git a/odk/examples/java/Spreadsheet/SCalc.java
b/odk/examples/java/Spreadsheet/SCalc.java
index 96fdc1ad429d..85eea9e0fd04 100644
--- a/odk/examples/java/Spreadsheet/SCalc.java
+++ b/odk/examples/java/Spreadsheet/SCalc.java
@@ -307,7 +307,7 @@ public class SCalc {
XChartDocument xChart = UnoRuntime.queryInterface(
XChartDocument.class,oInt);
XDiagram oDiag = xChart.getDiagram();
-System.out.println("Change Diagramm to 3D");
+System.out.println("Change Diagram to 3D");
XPropertySet oCPS = UnoRuntime.queryInterface(
XPropertySet.class, oDiag );
oCPS.setPropertyValue("Dim3D", Boolean.TRUE);
@@ -317,7 +317,7 @@ public class SCalc {
XPropertySet.class, xChart.getTitle() );
oTPS.setPropertyValue("String","The new title");
} catch (Exception e){
-System.err.println("Changin Properties failed "+e);
+System.err.println("Changing Properties failed "+e);
e.printStackTrace(System.err);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svtools include/svx include/tools include/ucbhelper include/uno include/vbahelper
include/svtools/editbrowsebox.hxx|2 +-
include/svtools/embedhlp.hxx |2 +-
include/svtools/genericunodialog.hxx |4 ++--
include/svtools/htmlkywd.hxx |2 +-
include/svx/gridctrl.hxx |2 +-
include/svx/sdr/contact/viewcontact.hxx |4 ++--
include/svx/sdr/contact/viewcontactofe3d.hxx |2 +-
include/svx/sdr/contact/viewcontactofpageobj.hxx |2 +-
include/svx/sdr/contact/viewcontactofsdrobj.hxx |2 +-
include/svx/sdrmasterpagedescriptor.hxx |4 ++--
include/svx/sdrpageuser.hxx |4 ++--
include/svx/svdedtv.hxx |2 +-
include/svx/svdopage.hxx |4 ++--
include/svx/svdundo.hxx |2 +-
include/tools/ref.hxx|2 +-
include/tools/stream.hxx |2 +-
include/ucbhelper/simplecertificatevalidationrequest.hxx |2 +-
include/uno/environment.hxx |4 ++--
include/uno/mapping.hxx |2 +-
include/vbahelper/vbahelperinterface.hxx |2 +-
20 files changed, 26 insertions(+), 26 deletions(-)
New commits:
commit a14b659dc0b5d3de4fc7801907a83eda3476f3c1
Author: Andrea Gelmini
AuthorDate: Sat Jul 20 17:25:54 2019 +0200
Commit: Andrea Gelmini
CommitDate: Sat Jul 20 22:33:02 2019 +0200
Fix typos
Change-Id: I8561dc27229a2430bfdfd8ac806139b4450496c7
Reviewed-on: https://gerrit.libreoffice.org/76026
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/include/svtools/editbrowsebox.hxx
b/include/svtools/editbrowsebox.hxx
index 9468428bd185..b0ef6d7fb8d1 100644
--- a/include/svtools/editbrowsebox.hxx
+++ b/include/svtools/editbrowsebox.hxx
@@ -185,7 +185,7 @@ namespace svt
//= MultiLineTextCell
-/** a multi line edit which can be used in a cell of a EditBrowseBox
+/** a multi line edit which can be used in a cell of an EditBrowseBox
*/
class SVT_DLLPUBLIC MultiLineTextCell : public MultiLineEdit
{
diff --git a/include/svtools/embedhlp.hxx b/include/svtools/embedhlp.hxx
index ad9a592ae6c0..0078be7936d2 100644
--- a/include/svtools/embedhlp.hxx
+++ b/include/svtools/embedhlp.hxx
@@ -118,7 +118,7 @@ public:
// remembered Graphic (e.g. primitives) has changed compared to the
current one, but without actively
// fetching the Graphic what would be too expensive e.g. for charts
sal_uInt32 getGraphicVersion() const;
-voidSetDefaultSizeForChart( const Size& rSizeIn_100TH_MM
);//#i103460# charts do not necessaryly have an own size within ODF files, in
this case they need to use the size settings from the surrounding frame, which
is made available with this method
+voidSetDefaultSizeForChart( const Size& rSizeIn_100TH_MM
);//#i103460# charts do not necessarily have an own size within ODF files, in
this case they need to use the size settings from the surrounding frame, which
is made available with this method
};
}
diff --git a/include/svtools/genericunodialog.hxx
b/include/svtools/genericunodialog.hxx
index 108f8a61f09a..36a836ff83bf 100644
--- a/include/svtools/genericunodialog.hxx
+++ b/include/svtools/genericunodialog.hxx
@@ -177,7 +177,7 @@ namespace svt
/** smaller form of initialize.
The initialize method is called with a sequence
of com.sun.star.uno::Any's,
which is split up into the single elements, which are passed to
implInitialize. The default implementation
-tries to extract an com.sun.star.beans::PropertyValue from the
value an pass it to the
+tries to extract a com.sun.star.beans::PropertyValue from the
value a pass it to the
com.sun.star.beans::XPropertySet interface of the object.
*/
virtual void implInitialize(const css::uno::Any& _rValue);
@@ -201,7 +201,7 @@ namespace svt
boolimpl_ensureDialog_lck();
};
-/// helper class for guarding access to methods of a OGenericUnoDialog
+/// helper class for guarding access to methods of an OGenericUnoDialog
class UnoDialogEntryGuard
{
public:
diff --git a/include/svtools/htmlkywd.hxx b/include/svtools/htmlkywd.hxx
index 37a77d938a51..36e7512e83e0 100644
--- a/include/svtools/htmlkywd.hxx
+++ b/include/svtools/htmlkywd.hxx
@@ -455,7 +455,7 @@
#define OOO_STRING_SVTOOLS_HTML_O_target "target"
#define OOO_STRING_SVTOOLS_HTML_O_to "to"
-// attributes with an URI as value
+// attributes with a URI as value
#define OOO_STRING_SVTOOLS_HTML_O_action "action"
#define OOO_STRING_SVTOOLS_HTML_O_archive "archive"
#define OOO_STRING_SVTOOLS_HTML_O_background "background"
diff --git
[Libreoffice-commits] core.git: include/sfx2
include/sfx2/shell.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e69c38722bac136ead8640cf7a8d0dd557741740 Author: Andrea Gelmini AuthorDate: Thu Jul 11 22:24:54 2019 + Commit: Andrea Gelmini CommitDate: Sat Jul 20 22:31:16 2019 +0200 Fix typo Change-Id: I54359ad39a86a40780e884ae0d9ce5b64ff1966b Reviewed-on: https://gerrit.libreoffice.org/75771 Tested-by: Jenkins Reviewed-by: Andrea Gelmini diff --git a/include/sfx2/shell.hxx b/include/sfx2/shell.hxx index b4bd938a379d..2edcb6a36bb2 100644 --- a/include/sfx2/shell.hxx +++ b/include/sfx2/shell.hxx @@ -292,7 +292,7 @@ public: . On the given is automatically the current -Max-Undo-Action-Count setting set form the options. +Max-Undo-Action-Count setting set from the options. 'pNewUndoMgr' must exist until the Destructor of SfxShell instance is called or until the next 'SetUndoManager()'. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126489] CRASH: Using MRI extension
https://bugs.documentfoundation.org/show_bug.cgi?id=126489 Xisco Faulí changed: What|Removed |Added Keywords||bibisectRequest, regression CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Not reproducible in Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; Locale: ca-ES (ca_ES.UTF-8) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126489] New: CRASH: Using MRI extension
https://bugs.documentfoundation.org/show_bug.cgi?id=126489 Bug ID: 126489 Summary: CRASH: Using MRI extension Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Install MRI extension -> https://github.com/hanya/MRI/releases/download/v1.3.4/MRI-1.3.4.oxt 2. Open Calc 3. Tools - Add-on - MRI 4. Close the dialog 5. Repeat step 3 -> Crash Reproduced in Version: 6.4.0.0.alpha0+ Build ID: 140b070bb187e3d5e35a588a1d187e3a40e11547 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES-valencia (ca_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - qadevOOo/tests sc/source
qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell.java | 21
--
sc/source/ui/Accessibility/AccessibleDocument.cxx |3 -
2 files changed, 2 insertions(+), 22 deletions(-)
New commits:
commit 8f966c402779c4b1578115448b7972ba48e4f294
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:56:43 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 22:10:41 2019 +0200
cid#1448400 UC: Useless code
Change-Id: Iad2ec725a8dbc37aeceac3af8611853c910e7d79
Reviewed-on: https://gerrit.libreoffice.org/76023
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell.java
b/qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell.java
index 921a45e1a606..e80d6bc8a0ba 100644
--- a/qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell.java
+++ b/qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBoxTableCell.java
@@ -151,32 +151,13 @@ public class AccessibleBrowseBoxTableCell extends
TestCase {
the_frame2.setName("DatasourceBrowser");
-XInterface oObj = null;
-
-UnoRuntime.queryInterface(
-XInitialization.class, the_frame2.getController());
-
-Object[] params = new Object[3];
-PropertyValue param1 = new PropertyValue();
-param1.Name = "DataSourceName";
-param1.Value = "Bibliography";
-params[0] = param1;
-PropertyValue param2 = new PropertyValue();
-param2.Name = "CommandType";
-param2.Value = Integer.valueOf(com.sun.star.sdb.CommandType.TABLE);
-params[1] = param2;
-PropertyValue param3 = new PropertyValue();
-param3.Name = "Command";
-param3.Value = "biblio";
-params[2] = param3;
-
util.utils.waitForEventIdle(tParam.getMSF());
XWindow xWindow = secondController.getFrame().getContainerWindow();
XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
-oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot,
AccessibleRole.TABLE_CELL);
+XInterface oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot,
AccessibleRole.TABLE_CELL);
log.println("ImplementationName: "+util.utils.getImplName(oObj));
commit e114afa40289f16c14b9591ed97539b7ab673dc6
Author: Caolán McNamara
AuthorDate: Sat Jul 20 16:51:24 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 22:10:29 2019 +0200
cid#1451628 Dereference after null check
Change-Id: I6ec54ac4568959e70a2d894bf4a564ac1bed627d
Reviewed-on: https://gerrit.libreoffice.org/76027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index e947b655a9cb..5f434733a557 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -286,8 +286,7 @@ ScChildrenShapes::ScChildrenShapes(ScAccessibleDocument*
pAccessibleDocument, Sc
xSelectionSupplier =
uno::Reference(pViewFrame->GetFrame().GetController(),
uno::UNO_QUERY);
if (xSelectionSupplier.is())
{
-if (mpAccessibleDocument)
-
xSelectionSupplier->addSelectionChangeListener(mpAccessibleDocument);
+
xSelectionSupplier->addSelectionChangeListener(mpAccessibleDocument);
uno::Reference
xShapes(mpViewShell->getSelectedXShapes());
if (xShapes.is())
mnShapesSelected = xShapes->getCount();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126488] How shall we react if we encounter a crash report?
https://bugs.documentfoundation.org/show_bug.cgi?id=126488 --- Comment #2 from himajin100...@gmail.com --- +1 for UI improvement. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126488] How shall we react if we encounter a crash report?
https://bugs.documentfoundation.org/show_bug.cgi?id=126488 --- Comment #1 from himajin100...@gmail.com --- https://opengrok.libreoffice.org/xref/core/external/breakpad/README?r=abf38a15#1 In Windows 10, there is a folder like %APPDATA%LibreOffice\4\crash and there are some dmp files. and there is a file named "dump.ini" In the ini file you can find where the crash reporter sends data to https://crashreport.libreoffice.org/submit/ practically you use a text box labeled 'id search' at the top right side of https://crashreport.libreoffice.org/ there you input the part in the dmp filename before the extension -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'private/mmeeks/copy-paste'
New branch 'private/mmeeks/copy-paste' available with the following commits: commit 34116936e5a90400d1fff678719a081d69b484d7 Author: Michael Meeks Date: Sat Jul 20 11:22:09 2019 +0100 clipboard: encourage paste to show up by having some dummy content. Having an empty system clipboard is a hyper-unusual state, but quite common for lok instances - so hide that with the dummy state. Allows context-menu paste into new documents. Change-Id: I9ce04cb8a0abfa054a67cb94922d7ac5992d1b29 commit 7623b7c64819b1488f3767405f226a6a22638a17 Author: Michael Meeks Date: Fri Jun 28 18:36:15 2019 +0100 Try harder to generate HTML from text. Change-Id: I5b4778cceefc652274a72b779cd6c060a50bf06c commit c715c18dc8ec9abd72ed05b73a9f41ef1470c3bb Author: Michael Meeks Date: Sat Jul 20 11:15:05 2019 +0100 lok: minimal implementation of isComplex for calc for now. Change-Id: Ic4141d30a0ff48a9ec5ecc8e6119d9d779c4a0fc commit 7376f6cb28232cc47da656059cd947eacaebb539 Author: Michael Meeks Date: Fri Jun 28 12:30:40 2019 +0100 lok: vital to quote nested JSON inserted into a json property. Somehow this managed to work fine in most browsers, but when the Kit/Poco tried to parse JSON to extract viewID it could explode. Change-Id: I39d2ecc9ee95b7e6f67a23c8b15f9a1d01769ddc commit b2d70ac18e4f61b8bc68f0b091653a3a2992e0ab Author: Szymon Kłos Date: Sat Jul 20 11:07:56 2019 +0100 Set clipboard for a window when created This allows to paste in dialogs input using tunneled context menu. Change-Id: Ie6cc6f1a6cd453734c8f6084b0bd50d1d7ab6c09 commit 5fc8f0d923ee85c6b9e1998bf769b96678f2e905 Author: Michael Meeks Date: Sat Jul 20 11:07:01 2019 +0100 LOK: Copy Graphics as embedded PNG in HTML Change-Id: Id8c14d7304d30bfcd956b126dfe291ef044f62bf commit 0a3b5b30c8bdc8c3e159edd1552713d55948dedc Author: Michael Meeks Date: Sat Jul 20 11:05:49 2019 +0100 lok: cleanup clipboards associated with a view on destruction. Also defer destruction potentially indefinitely for bad users who quit without destroying views, documents, shutting down nicely etc. Change-Id: Ieea6ad00b2983d372b745179bfe3b884c3c64eb0 commit 155956a22846ba7a65c2abe2a0aa9d62cc860cf7 Author: Ashod Nakashian Date: Tue Jun 25 23:45:37 2019 -0400 LOK: Improved selection complexity detection Only Graphics and OLE now unconditionally trigger 'complex' case, and for all others, we actually tally the number of text characters. Currently anything above 512KB is flagged as 'complex'. Change-Id: I19fbef72f2eb725648b2a18c1ee41b1612d2bac0 commit 19ca75ec8e27a6651e36f2578bfa77de587899a5 Author: Michael Meeks Date: Sat Jul 20 11:01:38 2019 +0100 LOK: Enable embedding images in text/html format output Change-Id: Ibd8bed796678ee26de2ceb6e434dce24da4eab05 commit c4e89a07964f2f9d5286d5df8a7adca82c467742 Author: Ashod Nakashian Date: Tue Jun 25 12:36:52 2019 -0400 LOK: detect Graphics in isComplex for Writer Change-Id: I814d71a21fa5352a9a1051f5477cb452a0dc5c2f commit b673ee99cbd720cd6135ed2e51c256678aee1b1f Author: Ashod Nakashian Date: Mon Jun 24 22:07:08 2019 -0400 LOK: Implement getSelectionType Detects all complex scenarios, except for Graphics. DesktopLOKTest::testComplexSelection() has commented out check that currently fails due to the missing detection of Graphics nodes. Change-Id: Ifce17192d26daba218d2c3d38577cccec0699e99 commit 04876be2d6875b07604e324e51e1bbbfde1e000b Author: Michael Meeks Date: Sat Jul 20 10:55:35 2019 +0100 clipboard: get view setting correct before setClipboard. Change-Id: If8e9b057b819074f035c598569e3bf6d3d2fff00 commit 8d0384f3c3d655e94331a890ef90541bdd46cdd7 Author: Michael Meeks Date: Sat Jul 20 10:52:51 2019 +0100 lok: clipboard: per view clipboard creation. A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29 commit e245b0278e8d29300357d708161da2d721e8 Author: Michael Meeks Date: Sat Jul 20 10:43:39 2019 +0100 lok: clipboard: per view clipboard creation. A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/textsh1.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 73b322a581b98a74c9d1868aca6d8ae05696697c
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:51:02 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 21:13:49 2019 +0200
cid#1448363 Unchecked dynamic_cast sw
Change-Id: Id01e96db2df7fb5425b8ab86e66a9fd7577a107d
Reviewed-on: https://gerrit.libreoffice.org/76022
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index b5acb1ee9ce2..9a92fc9f438b 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1377,15 +1377,15 @@ void SwTextShell::Execute(SfxRequest )
else if ( pFieldBM && pFieldBM->GetFieldname() == ODF_FORMDATE )
{
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-sw::mark::DateFieldmark* pDateField =
dynamic_cast(pFieldBM);
-ScopedVclPtr
pDlg(pFact->CreateDateFormFieldDialog(rWrtSh.GetView().GetFrameWeld(),
pDateField, GetView().GetDocShell()->GetDoc()));
+sw::mark::DateFieldmark& rDateField =
dynamic_cast(*pFieldBM);
+ScopedVclPtr
pDlg(pFact->CreateDateFormFieldDialog(rWrtSh.GetView().GetFrameWeld(),
, GetView().GetDocShell()->GetDoc()));
if (pDlg->Execute() == RET_OK)
{
-pFieldBM->Invalidate();
+rDateField.Invalidate();
rWrtSh.InvalidateWindows( rWrtSh.GetView().GetVisArea() );
rWrtSh.UpdateCursor(); // cursor position might be invalid
// Hide the button here and make it visible later, to make
transparent background work with SAL_USE_VCLPLUGIN=gen
-
dynamic_cast<::sw::mark::DateFieldmark*>(pFieldBM)->HideButton();
+rDateField.HideButton();
}
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 74ce2c90ecc6f6375ff6743efdd0b84358ebd6a3
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:57:59 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 21:13:29 2019 +0200
cid#1448454 RV: Bad use of return value
Change-Id: I704b432a09bb4bbd0192bd0a3ae6b39012a14110
Reviewed-on: https://gerrit.libreoffice.org/76024
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
index e262a15c8a33..dc775c6e1d8c 100644
--- a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
+++ b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
@@ -319,7 +319,7 @@ public class _XMultiSelectionSupplier extends
MultiMethodTest {
i++;
if (ObjCompare != null) {
-ObjCompare.compare(shouldElement, nextElement);
+compRes = ObjCompare.compare(shouldElement, nextElement) == 0;
} else {
compRes = util.ValueComparer.equalValue(shouldElement,
nextElement);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/source vcl/source
sc/source/core/data/column4.cxx |4 ++--
sc/source/core/data/table7.cxx | 10 +-
vcl/source/bitmap/BitmapScaleSuperFilter.cxx |6 +++---
3 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 90011180cb21186dbd58b8be6d723416541e
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:45:21 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:48:29 2019 +0200
cid#1448415 Pointer to local outside scope
Change-Id: I35f20fa37a19ff921916cd0e8bb7bafbc66ec8b5
Reviewed-on: https://gerrit.libreoffice.org/76021
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx
index 4485de036c8d..ac16dd2aa939 100644
--- a/sc/source/core/data/column4.cxx
+++ b/sc/source/core/data/column4.cxx
@@ -290,14 +290,14 @@ void ScColumn::CopyOneCellFromClip(
sc::CopyFromClipContext& rCxt, SCROW nRow1,
// Duplicate the cell note over the whole pasted range.
ScDocument* pClipDoc = rCxt.getClipDoc();
-const ScAddress& rSrcPos =
pClipDoc->GetClipParam().getWholeRange().aStart;
+const ScAddress aSrcPos =
pClipDoc->GetClipParam().getWholeRange().aStart;
std::vector aNotes;
ScAddress aDestPos(nCol, nRow1, nTab);
aNotes.reserve(nDestSize);
for (size_t i = 0; i < nDestSize; ++i)
{
bool bCloneCaption = (nFlags & InsertDeleteFlags::NOCAPTIONS) ==
InsertDeleteFlags::NONE;
-aNotes.push_back(pNote->Clone(rSrcPos, *pDocument, aDestPos,
bCloneCaption).release());
+aNotes.push_back(pNote->Clone(aSrcPos, *pDocument, aDestPos,
bCloneCaption).release());
aDestPos.IncRow();
}
diff --git a/sc/source/core/data/table7.cxx b/sc/source/core/data/table7.cxx
index 48576f0d6018..203b1e417dbb 100644
--- a/sc/source/core/data/table7.cxx
+++ b/sc/source/core/data/table7.cxx
@@ -162,14 +162,14 @@ void ScTable::CopyOneCellFromClip(
OSL_ENSURE(pDrawLayer, "No drawing layer");
if (pDrawLayer)
{
-const ScAddress& rSrcStartPos
+const ScAddress aSrcStartPos
= rCxt.getClipDoc()->GetClipParam().getWholeRange().aStart;
-const ScAddress& rSrcEndPos =
rCxt.getClipDoc()->GetClipParam().getWholeRange().aEnd;
+const ScAddress aSrcEndPos =
rCxt.getClipDoc()->GetClipParam().getWholeRange().aEnd;
tools::Rectangle aSourceRect = rCxt.getClipDoc()->GetMMRect(
-rSrcStartPos.Col(), rSrcStartPos.Row(), rSrcEndPos.Col(),
rSrcEndPos.Row(),
-rSrcStartPos.Tab());
+aSrcStartPos.Col(), aSrcStartPos.Row(), aSrcEndPos.Col(),
aSrcEndPos.Row(),
+aSrcStartPos.Tab());
tools::Rectangle aDestRect = GetDoc().GetMMRect(nCol1, nRow1,
nCol2, nRow2, nTab);
-pDrawLayer->CopyFromClip(rCxt.getClipDoc()->mpDrawLayer.get(),
rSrcStartPos.Tab(),
+pDrawLayer->CopyFromClip(rCxt.getClipDoc()->mpDrawLayer.get(),
aSrcStartPos.Tab(),
aSourceRect, ScAddress(nCol1, nRow1,
nTab), aDestRect);
}
}
commit 1f3c1b4ca12400348f30f30c2fb7ddfe2c71b2f7
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:27:38 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:48:15 2019 +0200
cid#1448542 Unintended sign extension
Change-Id: I5ef8661a1c8e28537c96cb899d124012938f4b1f
Reviewed-on: https://gerrit.libreoffice.org/76017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
index 7f7d5bffdd3c..acb3ad04f2a3 100644
--- a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
+++ b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
@@ -790,9 +790,9 @@ void scaleDown24bit(ScaleContext , long nStartY, long
nEndY)
1 : (rCtx.maMapIX[nRight] -
rCtx.maMapIX[nLeft]);
}
-long nSum1 = 0;
-long nSum2 = 0;
-long nSum3 = 0;
+int nSum1 = 0;
+int nSum2 = 0;
+int nSum3 = 0;
BilinearWeightType nTotalWeightY = 0;
for (long i = 0; i<= nLineRange; i++)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/sdview4.cxx | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
New commits:
commit 9fa09e7a14c990e36e9eba7350fd2015e6b7082c
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:44:01 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:36:36 2019 +0200
cid#1448403 Use after free
Change-Id: Ie63c336da7296ecad6aef56d57b064e450361b5d
Reviewed-on: https://gerrit.libreoffice.org/76020
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/ui/view/sdview4.cxx b/sd/source/ui/view/sdview4.cxx
index 93d88afb7028..030468fd8271 100644
--- a/sd/source/ui/view/sdview4.cxx
+++ b/sd/source/ui/view/sdview4.cxx
@@ -360,20 +360,27 @@ SdrMediaObj* View::InsertMediaObj( const OUString&
rMediaURL, const OUString& rM
if( pPickObj )
ReplaceObjectAtView(pPickObj, *pPV, pNewMediaObj);
else
-InsertObjectAtView( pNewMediaObj, *pPV,
SdrInsertFlags::SETDEFLAYER );
+{
+if (!InsertObjectAtView(pNewMediaObj, *pPV,
SdrInsertFlags::SETDEFLAYER))
+pNewMediaObj = nullptr;
+}
OUString referer;
DrawDocShell * sh = GetDocSh();
if (sh != nullptr && sh->HasName()) {
referer = sh->GetMedium()->GetName();
}
-pNewMediaObj->setURL( rMediaURL, referer, rMimeType );
-if( pPickObj )
+if (pNewMediaObj)
{
-pNewMediaObj->AdjustToMaxRect( aRect );
-if( bIsPres )
-pNewMediaObj->SetUserCall( pUserCall );
+pNewMediaObj->setURL( rMediaURL, referer, rMimeType );
+
+if( pPickObj )
+{
+pNewMediaObj->AdjustToMaxRect( aRect );
+if( bIsPres )
+pNewMediaObj->SetUserCall( pUserCall );
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unofield.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1b54c782e6a29ad1dde990cd80f33da068fb52d8 Author: Caolán McNamara AuthorDate: Sat Jul 20 15:34:42 2019 +0100 Commit: Caolán McNamara CommitDate: Sat Jul 20 20:24:32 2019 +0200 cid#1448255 Out-of-bounds access Change-Id: I78eaaaea59162a7fc66e3cc0989a38acb8024eb3 Reviewed-on: https://gerrit.libreoffice.org/76018 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/source/core/unocore/unofield.cxx b/sw/source/core/unocore/unofield.cxx index 007c114339ac..3afe7a95ca88 100644 --- a/sw/source/core/unocore/unofield.cxx +++ b/sw/source/core/unocore/unofield.cxx @@ -405,9 +405,9 @@ static sal_uInt16 lcl_GetPropertyMapOfService( SwServiceType nServiceId ) case SwServiceType::FieldMasterDummy5: nRet = PROPERTY_MAP_FLDMSTR_DUMMY0; break; case SwServiceType::FieldTypeHiddenText: nRet = PROPERTY_MAP_FLDTYP_HIDDEN_TEXT; break; default: -OSL_FAIL( "wrong service id" ); nRet = USHRT_MAX; } +assert(nRet != USHRT_MAX && "wrong service id"); return nRet; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/filter/eppt/pptexanimations.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5d7bb1f0e6b3ddcad264d7aa346a5f02b0d19d54
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:26:16 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:04:04 2019 +0200
cid#1448375 Improper use of negative value
Change-Id: Iaea347e5ca91ad164ad970ec8f0a485fd8a0d75e
Reviewed-on: https://gerrit.libreoffice.org/76016
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/filter/eppt/pptexanimations.cxx
b/sd/source/filter/eppt/pptexanimations.cxx
index 21b8fbd3a370..6740b79174b2 100644
--- a/sd/source/filter/eppt/pptexanimations.cxx
+++ b/sd/source/filter/eppt/pptexanimations.cxx
@@ -904,7 +904,7 @@ sal_uInt32 AnimationExporter::GetPresetID( const OUString&
rPreset, sal_uInt32 n
if ( ( nLast != -1 ) && ( ( nLast + 1 ) < rPreset.getLength() ) )
{
OUString aNumber( rPreset.copy( nLast + 1 ) );
-nPresetId = aNumber.toInt32();
+nPresetId = aNumber.toUInt32();
bPresetId = true;
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - filter/source starmath/source
filter/source/flash/swfwriter1.cxx |4
starmath/source/cursor.cxx |3 ++-
2 files changed, 2 insertions(+), 5 deletions(-)
New commits:
commit edc8d9650d7fbd98d6b301c662724c97f61128e5
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:38:15 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:03:50 2019 +0200
cid#1448322 try silence Splice iterator mismatch
Change-Id: If419d66811e5a60d50575f7b984811a29785459a
Reviewed-on: https://gerrit.libreoffice.org/76019
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index 538a4f26bf94..2d74d454a2f6 100644
--- a/starmath/source/cursor.cxx
+++ b/starmath/source/cursor.cxx
@@ -743,7 +743,8 @@ bool SmCursor::InsertRow() {
if(pTable) {
std::unique_ptr pNewLineList(new SmNodeList);
//Move elements from pLineList to pNewLineList
-pNewLineList->splice(pNewLineList->begin(), *pLineList, it,
pLineList->end());
+SmNodeList& rLineList = *pLineList;
+pNewLineList->splice(pNewLineList->begin(), rLineList, it,
rLineList.end());
//Make sure it is valid again
it = pLineList->end();
if(it != pLineList->begin())
commit ca7c2f6cd48917fefdbee3585f6ccfd491582c5f
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:42:13 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 20:03:39 2019 +0200
cid#1448337 Unchecked return value from library
Change-Id: Idac1d04e725f3e6e96d0ec6e83fcba3086c7a5fc
Reviewed-on: https://gerrit.libreoffice.org/76007
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/filter/source/flash/swfwriter1.cxx
b/filter/source/flash/swfwriter1.cxx
index 7967468650c3..5416ab869442 100644
--- a/filter/source/flash/swfwriter1.cxx
+++ b/filter/source/flash/swfwriter1.cxx
@@ -722,14 +722,10 @@ sal_uInt16 Writer::defineBitmap( const BitmapEx
, sal_Int32 nJPEGQuali
uLongf compressed_size = raw_size + static_cast(raw_size/100)
+ 12;
std::unique_ptr pCompressed(new sal_uInt8[ compressed_size ]);
-#ifdef DBG_UTIL
if(compress2(pCompressed.get(), _size, aImageData.data(),
raw_size, Z_BEST_COMPRESSION) != Z_OK)
{
SAL_WARN( "filter.flash", "compress2 failed!" ); ((void)0);
}
-#else
-compress2(pCompressed.get(), _size, aImageData.data(),
raw_size, Z_BEST_COMPRESSION);
-#endif
// AS: SWF files let you provide an Alpha mask for JPEG images, but we have
// to ZLIB compress the alpha channel separately.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/options/optlingu.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bf7f7c7c385c62a1edfa94dab0334bac606a4732
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:24:36 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:30:50 2019 +0200
cid#1448212 Improper use of negative value
Change-Id: Ib707b7e29f72c90f100ac20eb9dada37a2460158
Reviewed-on: https://gerrit.libreoffice.org/76015
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index c915ec25ad69..945963ddc989 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -1470,7 +1470,7 @@ IMPL_LINK(SvxLinguTabPage, ClickHdl_Impl, weld::Button&,
rBtn, void)
DBG_ASSERT(nEntry != -1, "no entry selected");
if (nEntry != -1)
{
-OptionsUserData
aData(m_xLinguOptionsCLB->get_id(nEntry).toInt32());
+OptionsUserData
aData(m_xLinguOptionsCLB->get_id(nEntry).toUInt32());
if (aData.HasNumericValue())
{
sal_uInt16 nRID = aData.GetEntryId();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/IAnyRefDialog.hxx |2 +-
sc/source/ui/inc/anyrefdg.hxx |2 +-
sc/source/ui/miscdlgs/anyrefdg.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit c9a64e41d2819e2ac474c9dc302972334ca86e03
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:38:34 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:16:57 2019 +0200
cid#1399336 Uncaught exception
Change-Id: Ia2b0fee5be67009731af8cc79088020e770dddbf
Reviewed-on: https://gerrit.libreoffice.org/76005
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/inc/IAnyRefDialog.hxx
b/sc/source/ui/inc/IAnyRefDialog.hxx
index 0e4f81f41572..a9c876f15f0d 100644
--- a/sc/source/ui/inc/IAnyRefDialog.hxx
+++ b/sc/source/ui/inc/IAnyRefDialog.hxx
@@ -32,7 +32,7 @@ namespace formula
class SAL_NO_VTABLE IAnyRefDialog : public formula::IControlReferenceHandler
{
public:
-virtual ~IAnyRefDialog(){}
+virtual ~IAnyRefDialog() COVERITY_NOEXCEPT_FALSE {}
virtual void SetReference( const ScRange& rRef, ScDocument* pDoc ) = 0;
virtual void RefInputStart( formula::RefEdit* pEdit, formula::RefButton*
pButton = nullptr ) = 0;
diff --git a/sc/source/ui/inc/anyrefdg.hxx b/sc/source/ui/inc/anyrefdg.hxx
index cf5e7390cd6c..1417662956be 100644
--- a/sc/source/ui/inc/anyrefdg.hxx
+++ b/sc/source/ui/inc/anyrefdg.hxx
@@ -106,7 +106,7 @@ protected:
public:
ScRefHandler(SfxDialogController ,
SfxBindings* pB, bool bBindRef);
-virtual ~ScRefHandler() override;
+virtual ~ScRefHandler() COVERITY_NOEXCEPT_FALSE override;
virtual voidSetReference( const ScRange& rRef, ScDocument* pDoc )
override = 0;
virtual voidAddRefEntry() override;
diff --git a/sc/source/ui/miscdlgs/anyrefdg.cxx
b/sc/source/ui/miscdlgs/anyrefdg.cxx
index 7a498aced9cd..168070ea4e64 100644
--- a/sc/source/ui/miscdlgs/anyrefdg.cxx
+++ b/sc/source/ui/miscdlgs/anyrefdg.cxx
@@ -605,7 +605,7 @@ bool ScRefHandler::EnterRefMode()
return m_bInRefMode = true;
}
-ScRefHandler::~ScRefHandler()
+ScRefHandler::~ScRefHandler() COVERITY_NOEXCEPT_FALSE
{
disposeRefHandler();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113743] MediaWiki publisher does not work with Wiki configured to use Basic Authentication
https://bugs.documentfoundation.org/show_bug.cgi?id=113743 Julien Nabet changed: What|Removed |Added CC|serval2...@yahoo.fr | --- Comment #6 from Julien Nabet --- Dennis: IMHO, it's more a new feature than a bug. Anyway, I can't help here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126488] New: How shall we react if we encounter a crash report?
https://bugs.documentfoundation.org/show_bug.cgi?id=126488 Bug ID: 126488 Summary: How shall we react if we encounter a crash report? Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de Created attachment 152887 --> https://bugs.documentfoundation.org/attachment.cgi?id=152887=edit the window reporting a crash report I just experienced a LibreOffice Crash. Well, it is a development version, so I am not too much surprised about bugs and crashes. I have a current productive version in parallel for work that really matters. On the screen appeared this window titled “crash report“: „Please check the report and if no bug report is connected to the crash report yet, open a new bug report at bugs.documentfoundation.org. Add detailed instructions on how to reproduce the crash and then show crash ID into the crash report field. Thank you for your help in improving LibreOfficeDev.“ There also a white bar in this message which looks like being meant for entering something there. • Where do I find the crash report? Is it in my filesystem? Where? • What exactly shall I check for? • Where can I enter the description of what I did before the crash happened? • Where do I find the crash ID? BTW: I guess, the message is generated from LibreOffice when it is re-started after the crash and some information from the dump is already available in this moment. This message should be made a bit more instructive about the interaction of the user. Would it not be possible to show the type of crash reason (e.g. lost pointer, violated assertion or whatever can be distinguished in such a tragic situation). To help the user, one might ask him about the number of files open simultaneously in LO, if there were some with multiple windows among them, give the user some multiple choice field what he did (leaving a freely editable one) and other things someone hunting for bugs will be interested in. Possibly interesting questions associated with it also might be • Could your currently open files be restored? • Did you notice there significant losses in the reconstructed file(s)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - scripting/java vcl/source
scripting/java/Framework/com/sun/star/script/framework/security/SecurityDialog.java
|2 +-
vcl/source/gdi/pdfwriter_impl.cxx
|3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 51a596866d31544c75ca0f7314c4ffc8258c32d8
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:33:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:02:59 2019 +0200
cid#1448526 RANGE: Range checks
Change-Id: I3b9d9c648151b2a5b9cc6a015b88a59fa7ec4e53
Reviewed-on: https://gerrit.libreoffice.org/76003
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git
a/scripting/java/Framework/com/sun/star/script/framework/security/SecurityDialog.java
b/scripting/java/Framework/com/sun/star/script/framework/security/SecurityDialog.java
index 8291231e734f..078f63395384 100644
---
a/scripting/java/Framework/com/sun/star/script/framework/security/SecurityDialog.java
+++
b/scripting/java/Framework/com/sun/star/script/framework/security/SecurityDialog.java
@@ -226,7 +226,7 @@ public class SecurityDialog extends WeakBase implements
// XServiceInfo
public String[] getSupportedServiceNames() {
-String[] retValue = new String[0];
+String[] retValue = new String[1];
retValue[0] = __serviceName;
return retValue;
}
commit da6f7b73627e699c3c05077fe89fc66e97af6246
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:50:04 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:02:35 2019 +0200
cid#1448527 Unchecked return value
Change-Id: I31c7cc4ee308c7e3841067b5bc5536ac1382e941
Reviewed-on: https://gerrit.libreoffice.org/76010
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 4e054f673ca0..6515344d0644 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -5165,7 +5165,8 @@ sal_Int32 PDFWriterImpl::emitOutputIntent()
if ( !writeBuffer( aLine.getStr(), aLine.getLength() ) ) return 0;
//get file position
sal_uInt64 nBeginStreamPos = 0;
-m_aFile.getPos(nBeginStreamPos);
+if (osl::File::E_None != m_aFile.getPos(nBeginStreamPos))
+return 0;
beginCompression();
checkAndEnableStreamEncryption( nICCObject );
cmsHPROFILE hProfile = cmsCreate_sRGBProfile();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/flyincnt.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 510da828b267ab575b0ef5d0fafc1cb42ad31712
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:41:09 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:01:13 2019 +0200
cid#1401328 Uncaught exception
Change-Id: I4eab3d40bc1d8e8bea05c3aba2de0ab39ca107e4
Reviewed-on: https://gerrit.libreoffice.org/76006
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/core/layout/flyincnt.cxx
b/sw/source/core/layout/flyincnt.cxx
index 2d0e6259..4c23164d9de3 100644
--- a/sw/source/core/layout/flyincnt.cxx
+++ b/sw/source/core/layout/flyincnt.cxx
@@ -65,11 +65,11 @@ void SwFlyInContentFrame::SetRefPoint( const Point& rPoint,
{
// OD 2004-05-27 #i26791# - member moved to
OSL_ENSURE( rPoint != aRef || rRelAttr != GetCurrRelPos(), "SetRefPoint:
no change" );
-std::unique_ptr pNotify;
+std::unique_ptr> xNotify;
// No notify at a locked fly frame, if a fly frame is locked, there's
// already a SwFlyNotify object on the stack (MakeAll).
if( !IsLocked() )
-pNotify.reset(new SwFlyNotify( this ));
+xNotify.reset(new SwFlyNotify( this ));
aRef = rPoint;
SetCurrRelPos( rRelAttr );
SwRectFnSet aRectFnSet(GetAnchorFrame());
@@ -81,13 +81,13 @@ void SwFlyInContentFrame::SetRefPoint( const Point& rPoint,
// #i68520#
InvalidateObjRectWithSpaces();
-if( pNotify )
+if (xNotify)
{
InvalidatePage();
setFrameAreaPositionValid(false);
m_bInvalid = true;
Calc(getRootFrame()->GetCurrShell()->GetOut());
-pNotify.reset();
+xNotify.reset();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/HandleAnchorNodeChg.hxx |2 +-
sw/source/core/layout/atrfrm.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 0e9b0b53f8def0452cd1e5394c9c9bef1017aabe
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:47:22 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:01:47 2019 +0200
cid#1448405 Uncaught exception
Change-Id: Ic6be9108dc5a9ad43cd44ab57b034100c2474a07
Reviewed-on: https://gerrit.libreoffice.org/76008
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/inc/HandleAnchorNodeChg.hxx b/sw/inc/HandleAnchorNodeChg.hxx
index e01da4c932a6..2a5247e0451c 100644
--- a/sw/inc/HandleAnchorNodeChg.hxx
+++ b/sw/inc/HandleAnchorNodeChg.hxx
@@ -50,7 +50,7 @@ public:
SwFlyFrame const * _pKeepThisFlyFrame = nullptr );
/** calls , if re-creation of fly frames is
necessary. */
-~SwHandleAnchorNodeChg();
+~SwHandleAnchorNodeChg() COVERITY_NOEXCEPT_FALSE;
private:
// fly frame format, which is tracked for a anchor node change.
diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index 4969bdc54599..a23c3209ad14 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -3290,7 +3290,7 @@ SwHandleAnchorNodeChg::SwHandleAnchorNodeChg(
SwFlyFrameFormat& _rFlyFrameFormat
}
}
-SwHandleAnchorNodeChg::~SwHandleAnchorNodeChg()
+SwHandleAnchorNodeChg::~SwHandleAnchorNodeChg() COVERITY_NOEXCEPT_FALSE
{
if ( mbAnchorNodeChanged )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/scopetools.hxx |2 +-
sc/source/core/tool/scopetools.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 90ea2a7e9ffd0bea7ce8bb9432fbda6a9fa0cde5
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:48:39 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 19:00:16 2019 +0200
cid#1448465 Uncaught exception
Change-Id: Ic70f0926b4e26f82045a791eadf6af1e9d7949a9
Reviewed-on: https://gerrit.libreoffice.org/76009
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/inc/scopetools.hxx b/sc/inc/scopetools.hxx
index 135a7ff5e008..aa48cf7ebf95 100644
--- a/sc/inc/scopetools.hxx
+++ b/sc/inc/scopetools.hxx
@@ -63,7 +63,7 @@ class SC_DLLPUBLIC DelayFormulaGroupingSwitch
bool const mbOldValue;
public:
DelayFormulaGroupingSwitch(ScDocument& rDoc, bool delay);
-~DelayFormulaGroupingSwitch();
+~DelayFormulaGroupingSwitch() COVERITY_NOEXCEPT_FALSE;
void reset();
};
diff --git a/sc/source/core/tool/scopetools.cxx
b/sc/source/core/tool/scopetools.cxx
index 44e634ef1ecf..71a4cf15eb1d 100644
--- a/sc/source/core/tool/scopetools.cxx
+++ b/sc/source/core/tool/scopetools.cxx
@@ -63,7 +63,7 @@
DelayFormulaGroupingSwitch::DelayFormulaGroupingSwitch(ScDocument& rDoc, bool de
mrDoc.DelayFormulaGrouping(delay);
}
-DelayFormulaGroupingSwitch::~DelayFormulaGroupingSwitch()
+DelayFormulaGroupingSwitch::~DelayFormulaGroupingSwitch()
COVERITY_NOEXCEPT_FALSE
{
mrDoc.DelayFormulaGrouping(mbOldValue);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/opengl
vcl/opengl/gdiimpl.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 57dcc00dd674219d4e50f9cb4fa6b797762af223
Author: Caolán McNamara
AuthorDate: Sat Jul 20 14:51:52 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 18:59:53 2019 +0200
cid#1448247 Division or modulo by float zero
Change-Id: I591ac0446494a8a8c4b3481bdf91e60de0c9ebe1
Reviewed-on: https://gerrit.libreoffice.org/76011
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 1924d46f268b..d7187c9921cc 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -987,6 +987,9 @@ bool scaleTexture(const rtl::Reference< OpenGLContext >
,
{
int nWidth = rTexture.GetWidth();
int nHeight = rTexture.GetHeight();
+if (nWidth == 0 || nHeight == 0)
+return false;
+
int nNewWidth = nWidth / ixscale;
int nNewHeight = nHeight / iyscale;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126484] EDITING: LO WRITER only provides Navigator for Headlines
https://bugs.documentfoundation.org/show_bug.cgi?id=126484 Adalbert Hanßen changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Adalbert Hanßen --- Dieter, I checked it with Version: 6.2.5.2 (x64) Build-ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded (the version from your link): Bookmarks could be opened. They were listed alphabetically by tag name. I also checked it with LibreOfficeDev, Version: 6.4.0.0.alpha0+ Build ID: 4248d759744f83a68d334a8b347124719a2886a8 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-07-09_15:00:58 Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded Bookmarks could also be opened. They were also listed alphabetically by tag name. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126465] Calc FILEOPEN. Max number of rows is limited; lower than Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126465 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- please attach document with your 20 rows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - scripting/source svx/source sw/qa sw/source
scripting/source/basprov/basprov.cxx |9 - scripting/source/dlgprov/dlgevtatt.cxx|4 scripting/source/dlgprov/dlgprov.cxx | 12 +- scripting/source/protocolhandler/scripthandler.cxx|8 - scripting/source/provider/MasterScriptProvider.cxx|3 scripting/source/stringresource/stringresource.cxx|5 - svx/source/accessibility/AccessibleControlShape.cxx | 10 -- svx/source/accessibility/ChildrenManagerImpl.cxx |7 - svx/source/accessibility/ShapeTypeHandler.cxx | 15 +-- svx/source/core/graphichelper.cxx | 19 +--- svx/source/dialog/langbox.cxx |8 - svx/source/fmcomp/fmgridcl.cxx|4 svx/source/fmcomp/fmgridif.cxx| 18 +-- svx/source/fmcomp/gridcell.cxx| 11 +- svx/source/fmcomp/gridctrl.cxx|3 svx/source/form/datanavi.cxx | 24 ++--- svx/source/form/filtnav.cxx |2 svx/source/form/fmPropBrw.cxx |4 svx/source/form/fmpgeimp.cxx | 18 +-- svx/source/form/fmservs.cxx |2 svx/source/form/fmshimp.cxx | 37 +++- svx/source/form/fmundo.cxx|2 svx/source/form/fmvwimp.cxx | 11 +- svx/source/form/navigatortree.cxx |4 svx/source/form/navigatortreemodel.cxx|4 svx/source/gallery2/galmisc.cxx | 29 ++ svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx |2 svx/source/svdraw/svdoole2.cxx|2 svx/source/svdraw/svdouno.cxx |2 svx/source/tbxctrls/tbcontrl.cxx |2 svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx |9 - svx/source/unodraw/unopage.cxx|3 svx/source/unodraw/unoshtxt.cxx |2 svx/source/xml/xmleohlp.cxx |3 svx/source/xml/xmlexport.cxx |5 - svx/source/xml/xmlxtexp.cxx | 11 -- sw/qa/core/macros-test.cxx| 13 +- sw/qa/extras/inc/swmodeltestbase.hxx |8 - sw/qa/extras/ooxmlexport/ooxmlexport.cxx |2 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx| 36 +++ sw/qa/extras/ooxmlexport/ooxmlexport12.cxx| 46 -- sw/qa/extras/ooxmlexport/ooxmlexport2.cxx |6 - sw/qa/extras/ooxmlexport/ooxmlexport3.cxx |6 - sw/qa/extras/ooxmlexport/ooxmlexport4.cxx | 20 ++-- sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |8 - sw/qa/extras/ooxmlexport/ooxmlexport8.cxx | 22 ++-- sw/qa/extras/rtfexport/rtfexport.cxx | 13 +- sw/qa/extras/rtfexport/rtfexport2.cxx | 36 +++ sw/qa/extras/rtfexport/rtfexport3.cxx |6 - sw/qa/extras/rtfexport/rtfexport5.cxx | 33 +++ sw/source/core/docnode/finalthreadmanager.cxx |2 sw/source/core/edit/edfcol.cxx| 18 +-- sw/source/core/swg/SwXMLTextBlocks.cxx|5 - sw/source/core/swg/SwXMLTextBlocks1.cxx | 29 +- sw/source/core/txtnode/thints.cxx |2 sw/source/core/unocore/unochart.cxx | 11 +- sw/source/core/unocore/unodraw.cxx|3 sw/source/core/unocore/unoportenum.cxx|5 - sw/source/core/unocore/unostyle.cxx |2 sw/source/core/unocore/unotext.cxx|6 - sw/source/filter/html/htmlbas.cxx |4 sw/source/filter/html/htmlform.cxx
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/appopen.cxx|4 +-
sfx2/source/appl/appserv.cxx|4 +-
sfx2/source/appl/newhelp.cxx|4 +-
sfx2/source/appl/shutdownicon.cxx |8 ++--
sfx2/source/config/evntconf.cxx |3 -
sfx2/source/control/dispatch.cxx| 13 +++---
sfx2/source/dialog/backingcomp.cxx | 14 +--
sfx2/source/dialog/dockwin.cxx |2 -
sfx2/source/dialog/filedlghelper.cxx| 54 ++--
sfx2/source/dialog/mailmodel.cxx|3 -
sfx2/source/doc/DocumentSigner.cxx |3 -
sfx2/source/doc/SfxRedactionHelper.cxx |8 ++--
sfx2/source/doc/docfile.cxx |8 +---
sfx2/source/doc/exoticfileloadexception.cxx |6 +--
sfx2/source/doc/guisaveas.cxx |3 -
sfx2/source/doc/objmisc.cxx |2 -
sfx2/source/doc/objserv.cxx | 19 -
sfx2/source/doc/objstor.cxx |2 -
sfx2/source/doc/objxtor.cxx |4 +-
sfx2/source/doc/sfxbasemodel.cxx| 11 ++---
sfx2/source/inet/inettbc.cxx|2 -
sfx2/source/notify/eventsupplier.cxx|3 -
sfx2/source/sidebar/Panel.cxx |2 -
sfx2/source/view/sfxbasecontroller.cxx |4 +-
sfx2/source/view/viewfrm.cxx| 29 +--
sfx2/source/view/viewsh.cxx |9 ++--
26 files changed, 89 insertions(+), 135 deletions(-)
New commits:
commit 476a652361de507303c7298a40cc96fa4bda22a3
Author: Noel Grandin
AuthorDate: Fri Jul 19 20:11:22 2019 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 20 17:58:43 2019 +0200
loplugin:referencecasting in sfx2
Change-Id: I97cd8821aa9a6f462f9b271940483738655ee9cf
Reviewed-on: https://gerrit.libreoffice.org/75979
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/appl/appopen.cxx b/sfx2/source/appl/appopen.cxx
index 592fd4b28a16..067b009005dd 100644
--- a/sfx2/source/appl/appopen.cxx
+++ b/sfx2/source/appl/appopen.cxx
@@ -381,7 +381,7 @@ ErrCode SfxApplication::LoadTemplate( SfxObjectShellLock&
xDoc, const OUString &
xDoc->SetModified(false);
xDoc->ResetError();
-css::uno::Reference< css::frame::XModel > xModel ( xDoc->GetModel(),
css::uno::UNO_QUERY );
+css::uno::Reference< css::frame::XModel > xModel = xDoc->GetModel();
if ( xModel.is() )
{
std::unique_ptr pNew =
xDoc->GetMedium()->GetItemSet()->Clone();
@@ -1010,7 +1010,7 @@ void SfxApplication::OpenDocExec_Impl( SfxRequest& rReq )
}
else
{
-xTargetFrame.set(
Desktop::create(::comphelper::getProcessComponentContext()), UNO_QUERY );
+xTargetFrame =
Desktop::create(::comphelper::getProcessComponentContext());
}
}
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 90f584c3cf7e..fe24e15b8cc4 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -483,7 +483,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
{
Reference < XDesktop2 > xDesktop = Desktop::create(
::comphelper::getProcessComponentContext() );
-Reference< XIndexAccess > xTasks( xDesktop->getFrames(), UNO_QUERY
);
+Reference< XIndexAccess > xTasks = xDesktop->getFrames();
if ( !xTasks.is() )
break;
@@ -1128,7 +1128,7 @@ void SfxApplication::MiscState_Impl(SfxItemSet )
case SID_CLOSEDOCS:
{
Reference < XDesktop2 > xDesktop = Desktop::create(
::comphelper::getProcessComponentContext() );
-Reference< XIndexAccess > xTasks( xDesktop->getFrames(),
UNO_QUERY );
+Reference< XIndexAccess > xTasks = xDesktop->getFrames();
if ( !xTasks.is() || !xTasks->getCount() )
rSet.DisableItem(nWhich);
break;
diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx
index fc60111090e1..6dbd7b82f6eb 100644
--- a/sfx2/source/appl/newhelp.cxx
+++ b/sfx2/source/appl/newhelp.cxx
@@ -2233,7 +2233,7 @@ void SfxHelpTextWindow_Impl::FindHdl(sfx2::SearchDialog*
pDlg)
else if ( pDlg->IsWrapAround() && !bWrapAround )
{
Reference < text::XTextViewCursorSupplier > xCrsrSupp(
xController, uno::UNO_QUERY );
-Reference < text::XTextViewCursor > xTVCrsr(
xCrsrSupp->getViewCursor(), uno::UNO_QUERY );
+Reference < text::XTextViewCursor > xTVCrsr =
xCrsrSupp->getViewCursor();
if ( xTVCrsr.is() )
{
Reference < text::XTextDocument > xDoc(
xController->getModel(), uno::UNO_QUERY );
@@ -3026,7 +3026,7 @@ void SfxHelpWindow_Impl::DoAction( sal_uInt16 nActionId )
[Libreoffice-commits] core.git: include/sfx2
include/sfx2/lnkbase.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 254dfda42e2e7bd8be77ccdc702ed7b09a226e57 Author: Andrea Gelmini AuthorDate: Fri Jul 19 16:56:32 2019 + Commit: Julien Nabet CommitDate: Sat Jul 20 17:57:41 2019 +0200 Fix typo Change-Id: I198382ab9b755e472ab2e868024517d000997cbf Reviewed-on: https://gerrit.libreoffice.org/75983 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/sfx2/lnkbase.hxx b/include/sfx2/lnkbase.hxx index 19ade2d601b0..535a6bcf9292 100644 --- a/include/sfx2/lnkbase.hxx +++ b/include/sfx2/lnkbase.hxx @@ -57,8 +57,8 @@ class FileDialogHelper; #define OBJECT_CLIENT_SO 0x80 // a Link #define OBJECT_CLIENT_DDE 0x81 -//#define OBJECT_CLIENT_OLE 0x82 // a Ole-Link -//#define OBJECT_CLIENT_OLE_CACHE 0x83 // a Ole-Link with SvEmbeddedObject +//#define OBJECT_CLIENT_OLE 0x82 // an Ole-Link +//#define OBJECT_CLIENT_OLE_CACHE 0x83 // an Ole-Link with SvEmbeddedObject #define OBJECT_CLIENT_FILE 0x90 #define OBJECT_CLIENT_GRF 0x91 #define OBJECT_CLIENT_OLE 0x92 // embedded link ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl
include/svl/sigstruct.hxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9e81a56c8086a92d9b8a3b514b24b04180759a4d Author: Andrea Gelmini AuthorDate: Fri Jul 19 16:56:30 2019 + Commit: Julien Nabet CommitDate: Sat Jul 20 17:57:16 2019 +0200 Fix typo Change-Id: I4b5bc31e2513a36069643e8b302ed756985ed8b2 Reviewed-on: https://gerrit.libreoffice.org/75985 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/svl/sigstruct.hxx b/include/svl/sigstruct.hxx index ceed929752ab..f6ee242c84d1 100644 --- a/include/svl/sigstruct.hxx +++ b/include/svl/sigstruct.hxx @@ -48,7 +48,7 @@ struct SignatureReferenceInformation // For ODF: XAdES digests (SHA256) or the old SHA1, from css::xml::crypto::DigestID sal_Int32 nDigestID; OUString ouDigestValue; -/// Type of the reference: an URI (newer idSignedProperties references) or empty. +/// Type of the reference: a URI (newer idSignedProperties references) or empty. OUString ouType; SignatureReferenceInformation() : @@ -109,9 +109,9 @@ struct SignatureInformation //XML signatures are written again (unless they have been removed). //If the date time string is converted into the DateTime structure //then information can be lost because it only holds a fractional -//of a second with a accuracy of one hundredth of second. +//of a second with an accuracy of one hundredth of second. //If the string contains -//milli seconds (because the document was created by an application other than OOo) +//milliseconds (because the document was created by an application other than OOo) //and the converted time is written back, then the string looks different //and the signature is broken. OUString ouDateTime; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2
include/sfx2/viewfac.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 548186a6cb174f4b2a08201d25bf093e01abee75 Author: Andrea Gelmini AuthorDate: Fri Jul 19 16:56:31 2019 + Commit: Julien Nabet CommitDate: Sat Jul 20 17:56:31 2019 +0200 Fix typo Change-Id: I712da0f34f61fb036ed6b2faef2049dfe0d2a02b Reviewed-on: https://gerrit.libreoffice.org/75984 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/include/sfx2/viewfac.hxx b/include/sfx2/viewfac.hxx index aca473f619cb..5e96258dbb6c 100644 --- a/include/sfx2/viewfac.hxx +++ b/include/sfx2/viewfac.hxx @@ -42,7 +42,7 @@ public: /// returns a legacy view name. This is "view" with an appended ordinal/ID. OUString GetLegacyViewName() const; -/** returns a API-compatible view name. +/** returns an API-compatible view name. For details on which view names are specified, see the XModel2.getAvailableViewControllerNames documentation. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xiescher.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit d96ed8cccec07e7e2b99111c61a4277e32243b3d
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:06:05 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 17:55:25 2019 +0200
assign nLen during ctor
Change-Id: I9164bd2b653208214276c48ddf49b21436edbd63
Reviewed-on: https://gerrit.libreoffice.org/76012
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/filter/excel/xiescher.cxx
b/sc/source/filter/excel/xiescher.cxx
index 15fea088d3a2..c4d10a8eaf5a 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -3138,8 +3138,7 @@ void XclImpPictureObj::ReadPictFmla( XclImpStream& rStrm,
sal_uInt16 nLinkSize )
// a class name may follow inside the picture link
if( rStrm.GetRecPos() + 2 <= nLinkEnd )
{
-sal_uInt16 nLen;
-nLen = rStrm.ReaduInt16();
+sal_uInt16 nLen = rStrm.ReaduInt16();
if( nLen > 0 )
maClassName = (GetBiff() == EXC_BIFF8) ?
rStrm.ReadUniString( nLen ) : rStrm.ReadRawByteString( nLen );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/excform8.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 70b11d8ee1c93d1a31746086b858216a7d1cca7a
Author: Caolán McNamara
AuthorDate: Sat Jul 20 15:06:13 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jul 20 17:40:08 2019 +0200
cid#1448265 Untrusted value as argument
Change-Id: I31280f417e3542bb7596bab798e971b714b5285f
Reviewed-on: https://gerrit.libreoffice.org/76002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/filter/excel/excform8.cxx
b/sc/source/filter/excel/excform8.cxx
index 7965c1a55c02..4ac2697093f0 100644
--- a/sc/source/filter/excel/excform8.cxx
+++ b/sc/source/filter/excel/excform8.cxx
@@ -1382,6 +1382,13 @@ void ExcelToSc8::ConvertExternName(
std::unique_ptr& rpArray, XclI
nRow2 = rStrm.ReaduInt16();
nGrbitCol1 = rStrm.ReaduInt16();
nGrbitCol2 = rStrm.ReaduInt16();
+
+if (nExtTab1 >= nTabCount || nExtTab2 >= nTabCount)
+{
+bError = true;
+break;
+}
+
ScSingleRefData& rR1 = aCRD.Ref1;
ScSingleRefData& rR2 = aCRD.Ref2;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 4 commits - libreofficekit/qa pyuno/source vcl/unx
libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx |8 ++
libreofficekit/qa/gtktiledviewer/gtv-helpers.cxx|2
pyuno/source/module/pyuno_type.cxx |4 +
vcl/unx/generic/printer/cupsmgr.cxx | 36
vcl/unx/gtk/gloactiongroup.cxx |8 ++
5 files changed, 56 insertions(+), 2 deletions(-)
New commits:
commit ca9aae711332e5affef75b1f11c45761a5a3b4a5
Author: Julien Nabet
AuthorDate: Wed Nov 28 20:39:43 2018 +0100
Commit: Aron Budea
CommitDate: Sat Jul 20 16:51:32 2019 +0200
band-aid: deprecated-declarations related to cups
Change-Id: I07438840fc1c3cc8e70559d44954be0c49531525
Reviewed-on: https://gerrit.libreoffice.org/64191
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
(cherry picked from commit e9e49fceac43476d1233ee8106cba5f4831771b9)
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx
b/vcl/unx/generic/printer/cupsmgr.cxx
index 328e9246e9f5..a9d499035a5a 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -81,7 +81,14 @@ struct GetPPDAttribs
{
// This CUPS method is not at all thread-safe we need
// to dup the pointer to a static buffer it returns ASAP
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
OString aResult = cupsGetPPD(m_aParameter.getStr());
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
MutexGuard aGuard( *m_pSyncMutex );
m_aResult = aResult;
m_aCondition.set();
@@ -214,6 +221,10 @@ void CUPSManager::runDests()
// n#722902 - do a fast-failing check for cups working *at all* first
http_t* p_http;
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
if( (p_http=httpConnectEncrypt(
cupsServer(),
ippPort(),
@@ -230,6 +241,9 @@ void CUPSManager::runDests()
httpClose(p_http);
}
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
}
void CUPSManager::initialize()
@@ -438,7 +452,14 @@ const PPDParser* CUPSManager::createCUPSParser( const
OUString& rPrinter )
rtl_TextEncoding aEncoding = osl_getThreadTextEncoding();
OUString aFileName( OStringToOUString( aPPDFile, aEncoding
) );
// update the printer info with context information
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
ppd_file_t* pPPD = ppdOpenFile( aPPDFile.getStr() );
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
if( pPPD )
{
// create the new parser
@@ -446,7 +467,14 @@ const PPDParser* CUPSManager::createCUPSParser( const
OUString& rPrinter )
pCUPSParser->m_aFile = rPrinter;
pNewParser = pCUPSParser;
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
/*int nConflicts =*/ cupsMarkOptions( pPPD,
pDest->num_options, pDest->options );
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
SAL_INFO("vcl.unx.print", "processing the following
options for printer " << pDest->name << " (instance " << (pDest->instance ==
nullptr ? "null" : pDest->instance) << "):");
for( int k = 0; k < pDest->num_options; k++ )
SAL_INFO("vcl.unx.print",
@@ -467,7 +495,15 @@ const PPDParser* CUPSManager::createCUPSParser( const
OUString& rPrinter )
rInfo.m_aContext = rContext;
// clean up the mess
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
ppdClose( pPPD );
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
+
}
else
SAL_INFO("vcl.unx.print", "ppdOpenFile failed, falling
back to generic driver");
commit 986d47dbf57008643d8126e7d71de47f32a15508
Author: Julien Nabet
AuthorDate: Sat Sep 29 13:18:49 2018 +0200
Commit: Aron Budea
CommitDate: Sat Jul 20 16:42:47 2019 +0200
band-aid: deprecated-declarations related to gtk
Don't hesitate to revert this one but only if there's a patch to fix it.
Change-Id: Ib15352e1a94d0542120f6710acfe19887494ed51
Reviewed-on: https://gerrit.libreoffice.org/61142
Tested-by: Jenkins
Reviewed-by: Julien Nabet
(cherry picked from commit 618d474f059a75c2ac04df16c830d71a88690118)
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
index fb5e946c3f77..564c1de137c6 100644
---
[Libreoffice-bugs] [Bug 126485] Tabs and indents in numbering and item list were limited to less than 20 pt
https://bugs.documentfoundation.org/show_bug.cgi?id=126485 Regina Henschel changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #3 from Regina Henschel --- I see it OK in Version: 6.2.0.0.alpha1+ (x64) Build ID: bf4fc97131147d25b18d088023262c977f0b2787 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-10_01:58:33 Locale: de-DE (en_US); UI-Language: en-US Calc: CL and broken in Version: 6.2.0.1 (x64) Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: test/source
test/source/bootstrapfixture.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit ecce69dc554429e42bf3fc67d75ac86cf2120714
Author: Michael Stahl
AuthorDate: Fri Jul 19 18:12:23 2019 +0200
Commit: Michael Stahl
CommitDate: Sat Jul 20 16:50:37 2019 +0200
test: check validator exit code *after* checking validator output
ODF validator may now actually exit with non-0 since commit
b14e2f6c63c18894286c99ee8dde9070e24b41c2 - look for validation errors in
this case too.
Change-Id: I36f4437c54d9a60afee0663a0b9be206773c5378
Reviewed-on: https://gerrit.libreoffice.org/75964
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx
index e3ee687374c5..6e06d352dec1 100644
--- a/test/source/bootstrapfixture.cxx
+++ b/test/source/bootstrapfixture.cxx
@@ -194,9 +194,6 @@ void test::BootstrapFixture::validate(const OUString&
rPath, test::ValidationFor
OUString aCommand = aValidator + " " + rPath + " > " + aOutputFile;
int returnValue = system(OUStringToOString(aCommand,
RTL_TEXTENCODING_UTF8).getStr());
-CPPUNIT_ASSERT_EQUAL_MESSAGE(
-OUStringToOString("failed to execute: " + aCommand,
-RTL_TEXTENCODING_UTF8).getStr(), 0, returnValue);
OString aContentString = loadFile(aOutput.GetURL());
OUString aContentOUString = OStringToOUString(aContentString,
RTL_TEXTENCODING_UTF8);
@@ -231,6 +228,9 @@ void test::BootstrapFixture::validate(const OUString&
rPath, test::ValidationFor
CPPUNIT_FAIL(aContentString.getStr());
}
}
+CPPUNIT_ASSERT_EQUAL_MESSAGE(
+OUStringToOString("failed to execute: " + aCommand + "\n" +
aContentOUString,
+RTL_TEXTENCODING_UTF8).getStr(), 0, returnValue);
#else
(void)rPath;
(void)eFormat;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126476] FILESAVE DOCX Embedded OLE object not displayed in embedded DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=126476 Jacques Guilleron changed: What|Removed |Added CC||jal...@laposte.net Keywords||needsDevAdvice Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Jacques Guilleron --- Hi NISZ LibreOffice Team, I reproduce with LO 6.4.0.0.alpha0+ (x86) Build ID: 719f4a93e46a6b397356dbb605d2867639ca3942 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; Locale: en-US (fr_FR); UI-Language: en-US Calc: CL but not if embedded file is linked at insertion time. Have a nice day, Jacques -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45472] EDITING: Cursor position is miscalculated after selecting cells
https://bugs.documentfoundation.org/show_bug.cgi?id=45472 --- Comment #15 from Norbert Scheibner --- I know old bugs are boring, but it is still reproducible in 6.2.5.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126485] Tabs and indents in numbering and item list were limited to less than 20 pt
https://bugs.documentfoundation.org/show_bug.cgi?id=126485 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||rb.hensc...@t-online.de --- Comment #2 from Regina Henschel --- I can confirm this for Version: 6.4.0.0.alpha0+ (x64) Build ID: dc5229f80afb3a436ffed221c565b68f4e4ae668 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: CL The value, that you can enter, is limited to 20, regardless of the unit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Oliver Brinzing changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6487 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126487] id of objects changes on every access
https://bugs.documentfoundation.org/show_bug.cgi?id=126487 Oliver Brinzing changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5421 CC||oliver.brinz...@gmx.de -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120441] FILEOPEN: LibO consumes all memory on my Debian when loading this .XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=120441 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126487] New: id of objects changes on every access
https://bugs.documentfoundation.org/show_bug.cgi?id=126487 Bug ID: 126487 Summary: id of objects changes on every access Product: LibreOffice Version: 6.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: sdk Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hi-an...@yandex.ru When moving across document hierarchy, sometimes it's needed to determine whether 2 objects are the same thing *(not in terms of properties/values, but as in, really refer to the same thing)*. For example, when you have some cell1 and cell2, there's no need to waste energy comparing all properties with cell1 == cell2, when one can just do id(cell1) == id(cell2) (btw, the == operator doesn't work either). But for some reason for every access to any UNO object the object id changes. It doesn't sound right even in terms of performance (like, why to create every time a different instance?). # Steps to reproduce 1. Run python shell 2. In python shell execute the following commands >>> import uno >>> localContext = uno.getComponentContext() >>> list_of_same_objects = [localContext.ServiceManager for i in range(0,10)] >>> [id(obj) for obj in list_of_same_objects] [139769180615904, 139769180615928, 139769180615952, 139769180615976, 139769180616000, 139769180616024, 139769180616048, 139769180616072, 139769180616096, 139769180616120] ## Expected The last command should've returned list of the same numbers. ## Actual All numbers in the last command are different # Additional information See also: https://ask.libreoffice.org/en/question/201705/uno-determine-if-2-objects-refer-to-the-same-thing/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126078] global Autotext in German 'mfg' - missing space
https://bugs.documentfoundation.org/show_bug.cgi?id=126078 Oliver Brinzing changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Oliver Brinzing --- the root cause seems to be that content.xml's are linarized during packing process will try to fix, replacing space with . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122652 Bug 122652 depends on bug 120441, which changed state. Bug 120441 Summary: FILEOPEN: LibO consumes all memory on my Debian when loading this .XLS file https://bugs.documentfoundation.org/show_bug.cgi?id=120441 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120441] FILEOPEN: LibO consumes all memory on my Debian when loading this .XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=120441 Raphaël Hertzog changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #15 from Raphaël Hertzog --- Hello, I can no longer reproduce the problem with version 1:6.3.0~rc1-1 currently in Debian unstable. From my point of view, it's gone so I close the bug. It might also be an update somewhere else in the GTK stack that fixed the issue, I have no idea. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125123] [enhancement]Would Libreoffice Impress support inline math?
https://bugs.documentfoundation.org/show_bug.cgi?id=125123 --- Comment #2 from somebor...@163.com --- Sorry for bad descriptions and not replying in time. Here are two problems in total. First, while Writer treats Math more like texts,Impress treats it more like graphs.It can be quite inconvenient. Next,Impress is not compatible with Office Math.Interestingly,Writer seems to work well with Office Math. |::|::| |Application|Performance| |PowerPoint 2019|Well done.| |PowerPoint 2007|All Content is shown in a graph and animations are in disorder.| |Impress|A graph is shown while other things except Math are shown as well.Animations are in disorder.| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126217] in lubuntu window has no icon
https://bugs.documentfoundation.org/show_bug.cgi?id=126217 C changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from C --- same behavior persists in SAFE-MODE. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118793] Marks of wrong spellings do not appear in a document that is edited from write protected
https://bugs.documentfoundation.org/show_bug.cgi?id=118793 --- Comment #3 from Stefan Bartels --- The Bug is still present. About-Info: Version: 6.1.6.3 (x64) Build-ID: 5896ab1714085361c45cf540f76f60673dd96a72 CPU-Threads: 4; BS: Windows 6.3; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded Though Timur mentioned it is not worth keeping open, I think, it can't be a big job to do. Hopefully one has just to call the procedure of showing the misspellings after having saved a document or after having pressed the button to change the write-protected document. I admit, in general people are opening a document to change something in it and this will show the misspellings, but in my case it is different: I use such a document for teaching pupils. They do not have to change anything except the misspellings. But those are not shown unless they change anything else. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126467] Memory leak, crushes OS
https://bugs.documentfoundation.org/show_bug.cgi?id=126467 --- Comment #2 from radim.ja...@pm.me --- Hello Xisco Faulí, thank you for the quick reply. I didn't want to upgrade my base latest linux-mint libreoffice version, but after installing now the new 6.2.5, I am happy to say that this bug is not there anymore. Thank you. ps: Although I am still sad that the 6.0.7 is still the default libre-office version even in the new linux-mint 19.2. I'm afraid that many people could face this issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97946] LibreOffice components should be single apps on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=97946 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |cl...@documentfoundation.or |.freedesktop.org|g, ||heiko.tietze@documentfounda ||tion.org Keywords|needsUXEval | --- Comment #3 from Heiko Tietze --- Discussed this in the ESC meeting Jul/18 2019 and there was agreement to modify the installer. + only a matter of adding launchers (Christian) + provide a template and pull it into your dock easily + D installer gets you 1 application + perhaps a folder with some templates you can drag → launcher + no LibO code-change necessary. + lets find some volunteer that cares to write it (Michael) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 97946] LibreOffice components should be single apps on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=97946 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |cl...@documentfoundation.or |.freedesktop.org|g, ||heiko.tietze@documentfounda ||tion.org Keywords|needsUXEval | --- Comment #3 from Heiko Tietze --- Discussed this in the ESC meeting Jul/18 2019 and there was agreement to modify the installer. + only a matter of adding launchers (Christian) + provide a template and pull it into your dock easily + D installer gets you 1 application + perhaps a folder with some templates you can drag → launcher + no LibO code-change necessary. + lets find some volunteer that cares to write it (Michael) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 67007] UI: Name Box does not show a name in sheet scope when selecting a range
https://bugs.documentfoundation.org/show_bug.cgi?id=67007 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords|easyHack| CC||79045_79...@mail.ru --- Comment #12 from Roman Kuznetsov <79045_79...@mail.ru> --- I don't see any code points => remove EasyHack keyword and it's steill repro in Версия: 6.3.0.1 (x64) ID сборки: 41ac97386aba908b6db860cfb4cfe2da871886ae Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; VCL: win; Локаль: ru-RU (ru_RU); UI-Language: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126481] An option for Rounding mode in ScInterpreter::ScRound
https://bugs.documentfoundation.org/show_bug.cgi?id=126481 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- I think, that is nothing about rounding. That are the usual problems with converting between decimal and binary numbers and with double arithmetic. For example compare (show 15 decimal places) =233.75/1.1-212 =233.75*(1/1.1)-212 or =100/3-33 =100*(1/3)-33 =1000/30-33 =10/0.3-33 [The purpose of the parts -212 and -33 is to make differences in the last bits visible.] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/core/api/ReportDefinition.cxx |4 ++--
reportdesign/source/core/api/ReportEngineJFree.cxx|2 +-
reportdesign/source/core/sdr/ReportDrawPage.cxx |2 +-
reportdesign/source/core/sdr/RptObject.cxx|4 ++--
reportdesign/source/filter/xml/xmlfilter.cxx |4 ++--
reportdesign/source/ui/inspection/GeometryHandler.cxx |2 +-
reportdesign/source/ui/report/ViewsWindow.cxx |2 +-
7 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 140b070bb187e3d5e35a588a1d187e3a40e11547
Author: Noel Grandin
AuthorDate: Fri Jul 19 20:09:26 2019 +0200
Commit: Noel Grandin
CommitDate: Sat Jul 20 13:10:10 2019 +0200
loplugin:referencecasting in reportdesign
Change-Id: I911bfc95f479d130052a51143dd3073287853a8f
Reviewed-on: https://gerrit.libreoffice.org/75975
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx
b/reportdesign/source/core/api/ReportDefinition.cxx
index 600dd78628b1..f4994d40397d 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -1840,7 +1840,7 @@ uno::Reference< container::XIndexAccess > SAL_CALL
OReportDefinition::getViewDat
::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
if ( !m_pImpl->m_xViewData.is() )
{
-m_pImpl->m_xViewData.set(
document::IndexedPropertyValues::create(m_aProps->m_xContext), uno::UNO_QUERY);
+m_pImpl->m_xViewData =
document::IndexedPropertyValues::create(m_aProps->m_xContext);
uno::Reference< container::XIndexContainer >
xContainer(m_pImpl->m_xViewData,uno::UNO_QUERY);
for (const auto& rxController : m_pImpl->m_aControllers)
{
@@ -1907,7 +1907,7 @@ uno::Sequence< OUString > SAL_CALL
OReportDefinition::getDocumentSubStoragesName
{
::osl::MutexGuard aGuard(m_aMutex);
::connectivity::checkDisposed(ReportDefinitionBase::rBHelper.bDisposed);
-uno::Reference
xNameAccess(m_pImpl->m_xStorage,uno::UNO_QUERY);
+uno::Reference xNameAccess = m_pImpl->m_xStorage;
return xNameAccess.is() ? xNameAccess->getElementNames() : uno::Sequence<
OUString >();
}
diff --git a/reportdesign/source/core/api/ReportEngineJFree.cxx
b/reportdesign/source/core/api/ReportEngineJFree.cxx
index 3c712d8f1878..294572903558 100644
--- a/reportdesign/source/core/api/ReportEngineJFree.cxx
+++ b/reportdesign/source/core/api/ReportEngineJFree.cxx
@@ -275,7 +275,7 @@ uno::Reference< frame::XModel >
OReportEngineJFree::createDocumentAlive( const u
if ( !xFrameLoad.is() )
{
// if there is no frame given, find the right
-xFrameLoad.set( frame::Desktop::create(m_xContext),
uno::UNO_QUERY);
+xFrameLoad = frame::Desktop::create(m_xContext);
sal_Int32 const nFrameSearchFlag = frame::FrameSearchFlag::TASKS |
frame::FrameSearchFlag::CREATE;
uno::Reference< frame::XFrame> xFrame = uno::Reference<
frame::XFrame>(xFrameLoad,uno::UNO_QUERY_THROW)->findFrame("_blank",nFrameSearchFlag);
xFrameLoad.set( xFrame,uno::UNO_QUERY);
diff --git a/reportdesign/source/core/sdr/ReportDrawPage.cxx
b/reportdesign/source/core/sdr/ReportDrawPage.cxx
index 15910df12a12..00027a557a7b 100644
--- a/reportdesign/source/core/sdr/ReportDrawPage.cxx
+++ b/reportdesign/source/core/sdr/ReportDrawPage.cxx
@@ -90,7 +90,7 @@ uno::Reference< drawing::XShape >
OReportDrawPage::CreateShape( SdrObject *pObj
else
bChangeOrientation = rUnoObj.GetObjIdentifier() ==
OBJ_DLG_HFIXEDLINE;
SvxShapeControl* pShape = new SvxShapeControl( pObj );
-
xShape.set(static_cast(static_cast(pShape)),uno::UNO_QUERY);
+xShape = static_cast(pShape);
pShape->setShapeKind(pObj->GetObjIdentifier());
}
else if (dynamic_cast< const OCustomShape* >(pObj) != nullptr)
diff --git a/reportdesign/source/core/sdr/RptObject.cxx
b/reportdesign/source/core/sdr/RptObject.cxx
index bbfc0e47d41e..7a77b212e25e 100644
--- a/reportdesign/source/core/sdr/RptObject.cxx
+++ b/reportdesign/source/core/sdr/RptObject.cxx
@@ -568,7 +568,7 @@ bool OCustomShape::EndCreate(SdrDragStat& rStat,
SdrCreateCmd eCmd)
uno::Reference< beans::XPropertySet> OCustomShape::getAwtComponent()
{
-return uno::Reference<
beans::XPropertySet>(m_xReportComponent,uno::UNO_QUERY);
+return m_xReportComponent;
}
@@ -1072,7 +1072,7 @@ bool OOle2Obj::EndCreate(SdrDragStat& rStat, SdrCreateCmd
eCmd)
uno::Reference< beans::XPropertySet> OOle2Obj::getAwtComponent()
{
-return uno::Reference<
beans::XPropertySet>(m_xReportComponent,uno::UNO_QUERY);
+return m_xReportComponent;
}
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx
b/reportdesign/source/filter/xml/xmlfilter.cxx
index 5e97042ec818..0f5f539d0da5 100644
---
[Libreoffice-bugs] [Bug 126485] Tabs and indents in numbering and item list were limited to less than 20 pt
https://bugs.documentfoundation.org/show_bug.cgi?id=126485 --- Comment #1 from Franklin Weng --- Created attachment 152885 --> https://bugs.documentfoundation.org/attachment.cgi?id=152885=edit Screenshot, these two fields were limited no greater than 19.99 pt. Version of this screenshot: 版本：6.2.4.2 組建 ID：2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU 執行緒：4; OS：Linux 4.19; UI 算繪：預設; VCL: kde4; 語言地區：zh-TW (zh_TW.UTF-8); UI語言：zh-TW Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126486] Enhancement of Calc / Chart Wizard / step 3 (Data Series)
https://bugs.documentfoundation.org/show_bug.cgi?id=126486 --- Comment #1 from bernd-u.landm...@arcor.de --- First sentence under "Actual results" should read: Currently a secondary y-axis cannot be created before the chart is finalized. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126486] New: Enhancement of Calc / Chart Wizard / step 3 (Data Series)
https://bugs.documentfoundation.org/show_bug.cgi?id=126486 Bug ID: 126486 Summary: Enhancement of Calc / Chart Wizard / step 3 (Data Series) Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bernd-u.landm...@arcor.de Description: I would like to have the following enhancement in Calc, Chart Wizard: I often use the chart type XY (Scatter). It would be consequent and time-saving if already in the Chart Wizard, step 3 (Data Series), one could choose that a secondary y-axis shall be used and assign the data series to the primary or to the secondary y-axis. Actual Results: Currently a secondary y-axis cannot be created before the chart is . Subsequently, a secondary y-axis has to be created by selecting one Data Series and choosing "Secondary Y-axis". Then the remaining Data Series whose data shall be plotted with the secondary y-axis have to be selected one at a time and "Secondary Y-axix" has to be set. Expected Results: If this setting could be applied in Chart Wizard, step 3 (Data Series), the procedure would be much more straightforward. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66613] EDITING: sheet copied to another document does not retain a defined print range
https://bugs.documentfoundation.org/show_bug.cgi?id=66613 --- Comment #15 from rpr --- This six-year-old bug also exists in LO 6.2.5.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Help with making QR Code callable in calc
Hi, Can anybody help me fix https://ci.libreoffice.org/job/gerrit_mac/38038/consoleFull#-1950566921d893063f-7f3d-4b7e-b56f-4e0f225817cd Is it due to unimplemented oox files for QR Code? Shubham ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 113259] soffice --convert-to hangs on Windows Server 2016 when called multiple times
https://bugs.documentfoundation.org/show_bug.cgi?id=113259 Mike Kaganski changed: What|Removed |Added URL|http://www.webhostingreview | |sx.co.uk/siteground-uk-host | |ing-reviews/| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
