[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=45589 --- Comment #18 from zionoto --- (In reply to Yousuf Philips (jay) (retired) from comment #6) > Google Docs is the only word processor that shows bookmarks MS word has the possibility to show bookmarks as non printable chars: the bookmarks are represented by square brackets as follows: [bookmarked text] please see the attached screenshot I have just tested. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45589] Show bookmarks: make them visible in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=45589 --- Comment #17 from zionoto --- Created attachment 155159 --> https://bugs.documentfoundation.org/attachment.cgi?id=155159=edit ms Word book mark representation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107738] [META] Section bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107738 Dieter Praas changed: What|Removed |Added Depends on||125455 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125455 [Bug 125455] Content in sections disappear and formatting gets distorted after reopening the file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125455] Content in sections disappear and formatting gets distorted after reopening the file
https://bugs.documentfoundation.org/show_bug.cgi?id=125455 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Blocks||107738 --- Comment #4 from Dieter Praas --- Iqtedar, thank you for your document. That makes the problem more clear. But - as you also mentioned - it's not possible to reproduce the bug. So please try to provide a document, where is is possible - at least for you. Yu also can try, if an actual version of LO solves your problem. => Back to NEEDINFO Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107738 [Bug 107738] [META] Section bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112695] impress not listening on bluetooth or tcp 1599 for remote connection
https://bugs.documentfoundation.org/show_bug.cgi?id=112695 --- Comment #7 from hgkamath --- android-6 -> win10/portableapps-libreoffice. * The bluetooth connection worked. However, the libreoffice process is unstable via bluetooth and will crash after a few swipes, especially when slides are interacted with on computer while being controlled on phone. The app on android was stable, no preview, shows blank slides with notes, was able to control until the crashing. Crashing of portable-libreoffice (win) under bluetooth would perhaps be a different bug on its own * direct-wifi from phone to win10 mobile-hotspot worked. Connection seemed stabler than bluetooth. App showed blank slides with notes, can swipe back and forth. win10 firewall prompts to open port on public and private networks, which is to be allowed. In either case, android app is stable, able to configure both bluetooth and wifi connections. Able to swipe back forth, but no preview of slides. perhaps feature is under development, else that would be a different bug. * unable to test the phone->VPN-wifi->win10 with my present setup/network, but it seems likely it will work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128227] NAVIGATOR: Rename "Text Frame" to "Frame"
https://bugs.documentfoundation.org/show_bug.cgi?id=128227 --- Comment #7 from Dieter Praas --- (In reply to V Stuart Foote from comment #5) > Every object on document canvas will have a frame, a 'Text frame' is > specifically for managing text layout and can contain other objects. Images, > shapes, OLE objects, tables inserted into a 'Text frame' will still be > listed separately in Navigator. The 'Text frame' is the container, but its > function is to control flow of textual content in the layout--objects other > than text will flow in text along with their anchors. Linking 'Text frames' > is the way we layout the text on a page. Thnks for clarification, but a normal user (just me) doesn't know that. I could see, that Insert => Frame => Frame Interactively / Frame inserts an entry into the navigator, while Insert => Frame => Floating Frame doesn't. So my idea won't be the best solution, but I still think, that the actual situation is al little confusing. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128227] NAVIGATOR: Rename "Text Frame" to "Frame"
https://bugs.documentfoundation.org/show_bug.cgi?id=128227 --- Comment #7 from Dieter Praas --- (In reply to V Stuart Foote from comment #5) > Every object on document canvas will have a frame, a 'Text frame' is > specifically for managing text layout and can contain other objects. Images, > shapes, OLE objects, tables inserted into a 'Text frame' will still be > listed separately in Navigator. The 'Text frame' is the container, but its > function is to control flow of textual content in the layout--objects other > than text will flow in text along with their anchors. Linking 'Text frames' > is the way we layout the text on a page. Thnks for clarification, but a normal user (just me) doesn't know that. I could see, that Insert => Frame => Frame Interactively / Frame inserts an entry into the navigator, while Insert => Frame => Floating Frame doesn't. So my idea won't be the best solution, but I still think, that the actual situation is al little confusing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120117] Sidebar Disrupts Column/Row Freeze Status
https://bugs.documentfoundation.org/show_bug.cgi?id=120117 --- Comment #5 from Kevin Suo --- (In reply to QA Administrators from comment #4) The bug still exists in the most recent version. Actually it's not only the side bar, but a window resize can also cause the column wor freeze to be corrupted. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36709] First Line Indent Using Ch (Characters) as Units Won't Change Size as Font Size Grow
https://bugs.documentfoundation.org/show_bug.cgi?id=36709 --- Comment #15 from Kevin Suo --- (In reply to QA Administrators from comment #14) The bug still exists in the most recent version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2e81c006b85214d28927ae4e3e18eda5f3be944a Author: Olivier Hallot AuthorDate: Sat Oct 19 23:32:02 2019 -0300 Commit: Gerrit Code Review CommitDate: Sun Oct 20 04:47:40 2019 +0200 Update git submodules * Update helpcontent2 from branch 'master' - Fix a D'oh! error in Help page Plus update menus path for Customizing dialog Change-Id: I9cef13ca14dd0787c54c091b8ad0f8d8c18bd03f Reviewed-on: https://gerrit.libreoffice.org/81147 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 0825c1b1f728..d655a0a1f0f3 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 0825c1b1f72819a1cb43a2539a4c8de334bdbb67 +Subproject commit d655a0a1f0f37bd8d188ddd82121b125414495a9 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/00/0406.xhp | 417 ++--- source/text/shared/01/06140100.xhp |8 source/text/shared/01/06140101.xhp |6 source/text/shared/01/06140102.xhp |4 4 files changed, 218 insertions(+), 217 deletions(-) New commits: commit d655a0a1f0f37bd8d188ddd82121b125414495a9 Author: Olivier Hallot AuthorDate: Sat Oct 19 23:32:02 2019 -0300 Commit: Olivier Hallot CommitDate: Sun Oct 20 04:47:40 2019 +0200 Fix a D'oh! error in Help page Plus update menus path for Customizing dialog Change-Id: I9cef13ca14dd0787c54c091b8ad0f8d8c18bd03f Reviewed-on: https://gerrit.libreoffice.org/81147 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/00/0406.xhp b/source/text/shared/00/0406.xhp index e23a56ace..13891fd10 100644 --- a/source/text/shared/00/0406.xhp +++ b/source/text/shared/00/0406.xhp @@ -1,217 +1,216 @@ - + - - -Tools Menu -/text/shared/00/0406.xhp - - - -Tools Menu - -Choose Insert - Media - Clip Art Gallery or open Standard bar, click - - - - - -Icon - - - Gallery - - + + +Tools Menu +/text/shared/00/0406.xhp + + + +Tools Menu + +Choose Insert - Media - Clip Art Gallery or open Standard bar, click + + + + + +Icon + + +Gallery + + - - - - Choose Tools - Gallery or click the Gallery icon on the Standard bar -New Theme button - Files tab. - -Choose Tools - Spelling. -F7 key -On the Standard bar, click - - - - - -Icon - - - Spelling - - + + +Choose Tools - Gallery or click the Gallery icon on the Standard bar -New Theme button - Files tab. + +Choose Tools - Spelling. +F7 key +On the Standard bar, click + + + + + +Icon + + +Spelling + + + + + +Choose Tools - Language - Hangul/Hanja Conversion. Asian language support must be enabled. +Choose Tools - Language - Chinese Conversion. Asian language support must be enabled. +Choose Tools - Language - Chinese Conversion - Edit terms button. Asian language support must be enabled. +Choose Tools - Spelling. +Choose Tools - Spelling, then click Options. + +Choose Tools - Language - Thesaurus. +CommandCtrl+F7 + + +Choose Tools - Color Replacer ($[officename] Draw and $[officename] Impress). + +Choose Tools - Media Player. +Choose Tools - Macros - Organize Macros - %PRODUCTNAME Basic, or press OptionAlt+F11 (if not assigned by your system). +Choose Tools - Macros - Run Macros. +Choose Tools - Macros - Organize Macros - BeanShell. +Choose Tools - Macros - Organize Macros - JavaScript. +Choose Tools - Macros - Organize Macros - Python. + +Choose Tools - Macros - Record Macro. + +Choose Tools - Macros - Organize Macros - %PRODUCTNAME Basic,click the Organizer button,click the Libraries tab,and then click the Password button. +Choose Tools - Macros - Organize Macros - %PRODUCTNAME Basic,click the Organizer button. +Choose Tools - Extension Manager. +Choose Tools - Extension Manager, click Check for Updates button. +Choose Tools - XML Filter Settings. +Choose Tools - XML Filter Settings, then click New or Edit. +Choose Tools - XML Filter Settings, then click Test XSLTs. +Choose Tools - Customize. +Choose Tools - Customize - Menus tab. +Choose Tools - Customize - Menus tab, click the gear Icon gear menu dropdown menu and choose Add. +Choose Tools - Customize - Menus tab, click the gear Icon gear menu dropdown menu and choose Move. +Choose Tools - Customize - Keyboard tab. A document must be opened. +Choose Tools - Customize - Toolbars tab. +Choose Tools - Customize - Events tab. +Choose Tools - AutoCorrect - AutoCorrect Options. +Choose Tools - AutoCorrect - AutoCorrect Options - Options tab. +Choose Tools - AutoCorrect - AutoCorrect Options - Smart Tags tab. +Choose Tools - AutoCorrect - AutoCorrect Options - Replace tab. +Choose Tools - AutoCorrect - AutoCorrect Options - Exceptions tab. +Choose Tools - AutoCorrect - AutoCorrect Options - Localized Options tab. +Choose Tools - AutoCorrect - AutoCorrect Options - Word
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1db8d48f6067f26a8bbda286fb6d3001d72fa03f Author: Olivier Hallot AuthorDate: Fri Oct 18 22:26:09 2019 -0300 Commit: Gerrit Code Review CommitDate: Sun Oct 20 04:35:49 2019 +0200 Update git submodules * Update helpcontent2 from branch 'master' - Fix missing embed in comments Help page Change-Id: I9f38f2e9112052d817ece315d728d081676522b7 Reviewed-on: https://gerrit.libreoffice.org/81119 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index e12593f8053b..0825c1b1f728 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit e12593f8053bd1768c1f24b3f9213fb2bef204ef +Subproject commit 0825c1b1f72819a1cb43a2539a4c8de334bdbb67 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0405.xhp | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) New commits: commit 0825c1b1f72819a1cb43a2539a4c8de334bdbb67 Author: Olivier Hallot AuthorDate: Fri Oct 18 22:26:09 2019 -0300 Commit: Olivier Hallot CommitDate: Sun Oct 20 04:35:49 2019 +0200 Fix missing embed in comments Help page Change-Id: I9f38f2e9112052d817ece315d728d081676522b7 Reviewed-on: https://gerrit.libreoffice.org/81119 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0405.xhp b/source/text/shared/01/0405.xhp index c749a03d3..98f0d2789 100644 --- a/source/text/shared/01/0405.xhp +++ b/source/text/shared/01/0405.xhp @@ -67,10 +67,10 @@ Inserting Comments in Presentations Use the command Insert - Comment or the key combination above to insert a comment anchor to the current slidepage. A colored comment box is shown at the top left corner, to enter the text of the comment. A small colored box - the anchor - in the top left of the slidepage contains the initials of the author name, followed by a sequential number. Click on the anchor to open or close the corresponding comment. - -The author name and the comment creation date and time is shown at the bottom of the comment box. -The comment box contains an icon with a down arrow. Click the icon to open a menu with some commands to delete comments. -Choose a command to delete the current comment, or all comments from the same author as the current comment, or all comments in the document. + + The author name and the comment creation date and time is shown at the bottom of the comment box. + The comment box contains an icon with a down arrow. Click the icon to open a menu with commands for comment management. + Comments in Presentations @@ -85,20 +85,13 @@ Inserting Comments in Text Documentsissue 113019 112000 - Use the command Insert - Comment or the Command+OptionCtrl+Alt+C key combination to insert a comment anchor at the current cursor position. A colored comment box is shown at the page margin, to enter the text of the comment. A line connects the anchor to the comment box. If a text range is selected, the comment is attached to the text range. The commented text range is shadowed. - -The author name and the creation date and time of the comment is shown at the bottom of the comment box. - Comments in text documents - Editing comments - Every user with write permission to the document can edit and delete comments of all authors. - If the comment in a text document was written by another author, there is a Reply command in the context menu. This command inserts a new comment adjacent to the comment to which you want to reply. The comment anchor is the same for both comments. Type your reply text in the new comment. Save and send your document to other authors, then those authors can add replies, too.View - Comments command ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124269] The data sheet of the database cannot move the column. Cannot move the bar and insert bar after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=124269 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128169] pizza of death if desktop selected as destination for export/save as to a password protected PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=128169 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124269] The data sheet of the database cannot move the column. Cannot move the bar and insert bar after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=124269 --- Comment #3 from QA Administrators --- Dear evan, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128169] pizza of death if desktop selected as destination for export/save as to a password protected PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=128169 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124861] LibreOffice instalation hangs in windows 8.1 64bit
https://bugs.documentfoundation.org/show_bug.cgi?id=124861 --- Comment #2 from QA Administrators --- Dear dilsiam, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124265] After the data table is saved, open the edit and cannot insert the column.
https://bugs.documentfoundation.org/show_bug.cgi?id=124265 --- Comment #3 from QA Administrators --- Dear evan, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127974] Solver Macro cannot solve to a target because there is not suitable API object
https://bugs.documentfoundation.org/show_bug.cgi?id=127974 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124668] Cannot open Libre Office
https://bugs.documentfoundation.org/show_bug.cgi?id=124668 --- Comment #8 from QA Administrators --- Dear Lynn Musgrave, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124265] After the data table is saved, open the edit and cannot insert the column.
https://bugs.documentfoundation.org/show_bug.cgi?id=124265 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124857] FILEOPEN: Images shift and list design changes
https://bugs.documentfoundation.org/show_bug.cgi?id=124857 --- Comment #3 from QA Administrators --- Dear eng.kim1512, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112695] impress not listening on bluetooth or tcp 1599 for remote connection
https://bugs.documentfoundation.org/show_bug.cgi?id=112695 --- Comment #6 from QA Administrators --- Dear hgkamath, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36709] First Line Indent Using Ch (Characters) as Units Won't Change Size as Font Size Grow
https://bugs.documentfoundation.org/show_bug.cgi?id=36709 --- Comment #14 from QA Administrators --- Dear Cheng-Chia Tseng, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52238] Document templates get formated differently depending on user interface language setting
https://bugs.documentfoundation.org/show_bug.cgi?id=52238 --- Comment #13 from QA Administrators --- Dear Michael P., To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43848] selecting whole table with merged cells at certain position not possible with draging the mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=43848 --- Comment #16 from QA Administrators --- Dear dE, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45341] Saving document with a input list field as a .doc file makes the input list field read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=45341 --- Comment #15 from QA Administrators --- Dear khagaroth, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53489] FORMATTING: Doubled line in chart after removing line in represented table
https://bugs.documentfoundation.org/show_bug.cgi?id=53489 --- Comment #7 from QA Administrators --- Dear Samuel V., To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43107] Regular expression "\n" in replace field inputs "\n" instead of line(paragraph?) break
https://bugs.documentfoundation.org/show_bug.cgi?id=43107 --- Comment #23 from QA Administrators --- Dear Christopher M. Penalver, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120211] Display none para with text:bookmark-start tag displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=120211 --- Comment #5 from QA Administrators --- Dear Antoine POURCHEZ, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36569] Mouse click into Find Toolbar after undocking will not put caret into toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=36569 --- Comment #14 from QA Administrators --- Dear Ed, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70554] FORMATTING Sub- and superscript format is inherited by new paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=70554 --- Comment #11 from QA Administrators --- Dear TJ Corley, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points
https://bugs.documentfoundation.org/show_bug.cgi?id=112687 --- Comment #6 from QA Administrators --- Dear Antonello, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73494] Font fallback issue with text of mixed directionality in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=73494 --- Comment #9 from QA Administrators --- Dear Khaled Hosny, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49187] Selecting "Sentence case" doesn't correct every sentence in the text (exclamation and question marks work, full stop doesn't)
https://bugs.documentfoundation.org/show_bug.cgi?id=49187 --- Comment #10 from QA Administrators --- Dear Emir Sarı (away), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128249] Calc does not correctly show some Chinese characters
https://bugs.documentfoundation.org/show_bug.cgi?id=128249 --- Comment #3 from V Stuart Foote --- Can not confirm on Windows 10 Hoime 64-bit en-US (1903) with Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded The Formula input bar uses system font Segoe UI with fall back - it drops the 飏 (yang) fallback and shows an undefined codepoint when it is the last entry on the line. Forcing replacement of system font Segoe UI with Noto Sans CJK TC (from Tools -> Options -> Fonts: Replacement table) fixed the missing fallback glyph, and removes the annoying fallback resize. Otherwise the cells on the sheet pick up their assigned Noto Sans CJK TC and are always fully formed, last glyph or not. Please save a sample .ODS spreadsheet to 'Flat XML ODF Spreadsheet (.fods)' format and attach. But, think the missing glyphs are expected depending on the system locale, and are controllable by forcing a font substitution. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86143] Dragging merged from the corner puts it in a single cell
https://bugs.documentfoundation.org/show_bug.cgi?id=86143 --- Comment #13 from Franklin Weng --- (In reply to karsten.henning from comment #12) > I have reproduced the problem with the same version 6.3.3.1 according to > instructions both under Linux and under Windows. The behavior was identical > and therefore it is not a UX problem. The behavior was identical and therefore it is not an UI problem. What I said UX problem is that, is this behavior intuitive to users? Is this behavior matching what users naturally expect? > The expected behavior is to copy a merged cell in any direction with the > result that at the target also merged cells are created and counted as one > cell. > This is also the behavior in Excel. Right, so I think it is an UX problem. Regardless of what behavior Excel has, it is natural for users to expect this way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128249] Calc does not correctly show some Chinese characters
https://bugs.documentfoundation.org/show_bug.cgi?id=128249 --- Comment #2 from Owen Parry --- Please note, I priveded the strings as a UTF8 array for YOUR convenience. If I just pasted Chinese characters into the bug report, I have no way of knowing if you can copy them. On your end, use the UTF8 codepoints to convert to readable text and enter them into a cell. Here are the two strings as readable text: 吴珮飏 Pam（吴珮飏） If the font itself was at fault, I would expect to see the box character 100% of the time, that is not the case. As mentioned, either the first, last or all characters are sometimes by the box depending on what is currently selected in the editor. The input bar displays the cells contents correctly, until it is clicked, at which point all characters are converted to boxes. I have just tried with 'Noto Sans CJK'. If the document is saved used Noto, then reopened, the exact same problem exists. All other Chinese characters, as far as I can tell, are displayed correctly. The above combination of 3 characters are causing the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128261] New: The transitions are damaged
https://bugs.documentfoundation.org/show_bug.cgi?id=128261 Bug ID: 128261 Summary: The transitions are damaged Product: LibreOffice Version: 6.2.7.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: joimerjosereyestr...@gmail.com Description: The transitions found at the end of the program menu do not work. This is a problem that comes from previous versions. Steps to Reproduce: 1.Open Impress 2.Open the transitions menu 3.Click on the final group of transitions Actual Results: transitions are damaged Expected Results: To solve it as soon as possible Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128260] New: DOCX import issues from 3-S Thesis Template, most likely sections->Page Styles conversion filter fails somehow!
https://bugs.documentfoundation.org/show_bug.cgi?id=128260 Bug ID: 128260 Summary: DOCX import issues from 3-S Thesis Template, most likely sections->Page Styles conversion filter fails somehow! Product: LibreOffice Version: 6.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: e...@sheer.us Description: Using the FormatMyThesis 3-S template dotx file, or files derived from said winword-template, does not import quite right in LibreOffice. Specifically:- (1) the Page-numbers fail after about page 4 of content (chapter 1 starts footnotes etc.) (2) the Mechanic to make sure chapter etc. sections always start on an odd-numbered-page, is not working!. Having communicated with the author, I am now creating this bug-report. The 3 files of interest are:- http://ec2.sheer.us/~enyc/noidx/FMT-3-S-Thesis-Template-v1.0.dotx http://ec2.sheer.us/~enyc/noidx/FMT-3-S-Thesis-Template-v1.0_LO-6.3.2.2.pdf http://ec2.sheer.us/~enyc/noidx/FMT-3-S-Thesis-Template-v1.0_WinWord-2010.pdf So you can access the original dotx, and pdf export examles in any case. Steps to Reproduce: 1. wget and open dotx file from above. 2. Observe page numbers are not working further down the document, as per the LO pdf above. 3. Also Observe the automatically-inserted blank pages are not coming out. Actual Results: As per above page numbers and automatic blank pages are not working right. Expected Results: I would expect a lot of "converted" page styles in a messy fashion, but at least a correctly working imported document. Reproducible: Always User Profile Reset: Yes Additional Info: As above, import of sections and page-level-behavior work fully. Same misbehaviour with various LibreOffice on Linux distros, let alone trying 6.3.2.2 on windows-7-64bit as above!. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128248] Add an easy to use way for alternating cell coloring
https://bugs.documentfoundation.org/show_bug.cgi?id=128248 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Already available. 1. Make selection of cells 2. Format -> AutoFormat Styles... 3. select from the Format drop list 4. OK to apply -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128249] Calc does not correctly show some Chinese characters
https://bugs.documentfoundation.org/show_bug.cgi?id=128249 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from V Stuart Foote --- A 2,3 and 4-byte utf-8 coding will not work for direct Unicode input. Calc's =UNICHAR() function can be used against the _decimal_ value of the Unicode point--but is cumbersome compared to the global +x toggle implemented for bug 73691 Convert the input string to utf-16, LibreOffice handles that conversion to Unicode cleanly by prepending "U+", e.g. "U+0050" and then an +x to toggle applied from the end of the string. So, in utf-16 your sample string for Unicode toggle would be: u+0050u+0061u+006du+ff08u+5434u+73eeu+98cfu+ff09 Try that and see if you get better results. Please note that Droid CJK coverage requires an Ascender Pro purchase, not sure the opensource builds included the CJK. The Google Noto Sans CJK successor to Droid is probably a more functional font and is readily available opensource builds. So, if actually using Droid without a CJK locale--you will receive fallback font handling for some font with coverage on system. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128259] New: Formatting Function Conditional in CALC - images
https://bugs.documentfoundation.org/show_bug.cgi?id=128259 Bug ID: 128259 Summary: Formatting Function Conditional in CALC - images Product: LibreOffice Version: 6.3.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alexmaximiano@gmail.com Created attachment 155158 --> https://bugs.documentfoundation.org/attachment.cgi?id=155158=edit Video showing the error. Hi, I'm using Ubuntu 19.10 and using libreoffice version 6.3.2 (straight from iso). Using conditional image formatting as shown in the video does not change the images and the window is frozen with errors. Following is an attached video showing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128258] New: Calc feature request: more prominent visual hint for hidden rows or columns
https://bugs.documentfoundation.org/show_bug.cgi?id=128258 Bug ID: 128258 Summary: Calc feature request: more prominent visual hint for hidden rows or columns Product: LibreOffice Version: 6.1.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: chameleonsca...@protonmail.com Description: Currently, the only way to tell if rows or columns are hidden is by seeing the thicker separation in the headers. When I work intensively, I often forget that I have hidden cells and this visual hint is too subtle for me to notice it, which leads to me breaking my data and realizing it a while later. Moreover,if for whatever reason I decide to hide the headers themselves, now there's no way to tell if cells are hidden. Steps to Reproduce: Right-clic on a row or column in a header and select "Hide Rows" (or Columns). Actual Results: A thicker line separates the rows between which the hidden one is contained. Expected Results: An efficient solution would be to have an option to display thicker borders where hidden rows or columns are contained (this time on the sheet itself). In addition to that, a color for that thicker line would make it even more prominent and hard to miss. Of course, to ensure one could make this color stand out in any colorized sheet, this color should be changeable in the Preferences. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128257] Bullets Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 andreas_k changed: What|Removed |Added CC||kain...@gmail.com Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128257] New: Bullets Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 Bug ID: 128257 Summary: Bullets Dialog update Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com Created attachment 155157 --> https://bugs.documentfoundation.org/attachment.cgi?id=155157=edit Bullets Dialog 01 The idea is to make an better arrangement for the sd bullet dialog. Top master, Bottom proposal Bullet, Graphic and Number section renewal. Properties are aligned and each section get an alignment too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Failure
The cppcheck job failed with message: "Failed to run cppcheck." Note: The script generating this report was run at : 2019-20-10 00:40:22 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh cppcheck-report.log.gz Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #18 from Julien Nabet --- We checked Python but what about Java? On my pc: julien@debianamd:~$ java --version openjdk 11.0.5 2019-10-15 OpenJDK Runtime Environment (build 11.0.5+10-post-Debian-1) OpenJDK 64-Bit Server VM (build 11.0.5+10-post-Debian-1, mixed mode) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=128256 Telesto changed: What|Removed |Added Alias|non-linear, Refactor, |ViewToDevice-Refactor |ViewToDevice| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=128256 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Alias||Refactor, non-linear, ||ViewToDevice Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122713] High CPU usage when viewing spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=122713 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125677] Radio button selection changed when tabbing into the group.
https://bugs.documentfoundation.org/show_bug.cgi?id=125677 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125720] Calc: current cell indicator is not following the focused cell (in a particular Form configuration document)
https://bugs.documentfoundation.org/show_bug.cgi?id=125720 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125700] Radio button selection not changed using arrow keys anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=125700 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121963] button flashing - mouse wheel zooming breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=121963 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=128256 Telesto changed: What|Removed |Added Depends on||121963, 125720, 125677, ||125700, 122713 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121963 [Bug 121963] button flashing - mouse wheel zooming breaks https://bugs.documentfoundation.org/show_bug.cgi?id=122713 [Bug 122713] High CPU usage when viewing spreadsheet https://bugs.documentfoundation.org/show_bug.cgi?id=125677 [Bug 125677] Radio button selection changed when tabbing into the group. https://bugs.documentfoundation.org/show_bug.cgi?id=125700 [Bug 125700] Radio button selection not changed using arrow keys anymore https://bugs.documentfoundation.org/show_bug.cgi?id=125720 [Bug 125720] Calc: current cell indicator is not following the focused cell (in a particular Form configuration document) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=128256 Telesto changed: What|Removed |Added Depends on||127910 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127910 [Bug 127910] main menu and context menus empty when using form elements and OpenGL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127910] main menu and context menus empty when using form elements and OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=127910 Telesto changed: What|Removed |Added Blocks||128256 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128256 [Bug 128256] [META] Refactor calc non-linear ViewToDevice transform regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128256] New: [META] Refactor calc non-linear ViewToDevice transform regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=128256 Bug ID: 128256 Summary: [META] Refactor calc non-linear ViewToDevice transform regressions Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: author Armin Le Grand 2018-10-12 11:13:09 +0200 committer Armin Le Grand 2018-11-27 11:33:10 +0100 commit d464d505fbf6e53a38afdd3661d320fac8c760d6 (patch) tree3bf7db8591172bf948198f19d36df5df886486bb parent 3e1e2b6687b0259ae28441cc0d314de0d908776b (diff) Refactor calc non-linear ViewToDevice transform Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220
--- Comment #17 from jul...@palard.fr ---
Still investigating slowly, I bet this is near:
/usr/lib/libreoffice/share/extensions/voikko/pythonpath/PropertyManager.py(83)initialize()
in the call of:
self.__linguPropSet.addPropertyChangeListener("IsSpellWithDigits", self)
Which I bet is a Java function as __linguPropSet is a pyuno object
(com.sun.star.uno.XInterface)0x561ace7484c0{implementationName=com.sun.star.lingu2.LinguProps,
supportedServices={com.sun.star.linguistic2.LinguProperties},
supportedInterfaces={com.sun.star.linguistic2.XLinguProperties,com.sun.star.beans.XFastPropertySet,com.sun.star.beans.XPropertyAccess,com.sun.star.lang.XComponent,com.sun.star.lang.XServiceInfo,com.sun.star.lang.XTypeProvider,com.sun.star.uno.XWeak}}
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #16 from jul...@palard.fr --- Yes same version of python3-uno: Installed: 1:6.3.2-1+b1 thanks for trying hard to reproduce, I appreciate it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #15 from Julien Nabet --- I noticed the use of python3-uno Package: python3-uno Source: libreoffice (1:6.3.2-1) Version: 1:6.3.2-1+b1 but I suppose you've got the same version. I don't have more questions, so I'll put this back to UNCONFIRMED. I must recognize I'm stuck. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127494] Enhancement request: shortcut for "Search" line in Help menu
https://bugs.documentfoundation.org/show_bug.cgi?id=127494 --- Comment #3 from V Stuart Foote --- Implicit in implementation of enhancement for bug 91874 would be ability to assign shortcut to the search bar for keyboard only completion without need for mouse selection. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128255] No data collection without express, informed, meaningful user consent.
https://bugs.documentfoundation.org/show_bug.cgi?id=128255 V Stuart Foote changed: What|Removed |Added Resolution|--- |MOVED CC||c...@nouenoff.nl, ||jbfa...@libreoffice.org, ||ke...@collabora.com, ||marina.latini@libreoffice.o ||rg, ||markus.mohrhard@googlemail. ||com, ||michael.me...@collabora.com ||, vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- User is prompted on Crash recovery if they explicitly want to submit the Breakpad generated minidump crash report. No personally identifiable details are included beyond the cURL post details of the originating IP. User has explicit control over "Collect usage data and send it to The Document Foundation"--it is disabled by default on installation. It is only enabled by user action in the Tools -> Options -> LibreOffice General panel, or by setting an environment variable "LO_COLLECT_USAGE" true. There is no personally identifiable information beyond source IP and system network name, otherwise it is just tallys of command/control usage per document per session. IMHO the user is sufficiently advised, abd providing more complex user notification in the GUI is _visual noise_. IMHO => WF Otherwise, TDF Project and LibreOffice privacy statements (which admittedly do not address crash reporintg and usage data) are the purview of the TDF Board and their legal advisers. Discussion on appropriate ML no in the BZ --> MOVED For BoD -- if you take this up could you provide a suitable link to the discussion. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #14 from jul...@palard.fr --- OK, I may have something, but yet I'm not fluent with this Java/Python interaction. Right before the crash I see: > /usr/lib/python3/dist-packages/unohelper.py(252)getTypes()->( instanc...INTERFACE')>)>, )>, instanc...INTERFACE')>)>) -> return _unohelper_getHandle( self ) (Pdb) l 247 _g_typeTable[self.__class__] = ret 248 return ret 249 250 class Base(XTypeProvider): 251 def getTypes( self ): 252 -> return _unohelper_getHandle( self ) 253 def getImplementationId(self): 254 return () 255 256 class CurrentContext(XCurrentContext, Base ): 257 """a current context implementation, which first does a lookup in the given (Pdb) p _unohelper_getHandle( self ) ()>, )>, )>) (Pdb) n Fatal Python error: Python memory allocator called without holding the GIL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 --- Comment #30 from maryline.lato...@gmail.com --- Keep the smart user’s point of view in mind please. The aim of my original 127494 enhancements suggestion that was sadly marked as duplicate of this one is to use the mouse LESS and keep both your hands on the keyboard for efficiency. As it was possible with older versions. Remember? SAVE THE KEYBOARD SHORTCUTS! Don’t imitate Word’s mouse only interface. Please. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - configure.ac debian/changelog debian/control loolwsd.spec.in
configure.ac |2 +-
debian/changelog |6 ++
debian/control |2 +-
loolwsd.spec.in |2 +-
4 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 4d3a355ccf9d1271e5b74b539795638ef7dc6d6e
Author: Andras Timar
AuthorDate: Sat Oct 19 23:09:37 2019 +0200
Commit: Andras Timar
CommitDate: Sat Oct 19 23:09:37 2019 +0200
Bump package version to 4.0.8-1
Change-Id: Ic163fafbc9c92fc10d93956b1781bf371dd587e0
diff --git a/configure.ac b/configure.ac
index 0cc245430..5e8131b06 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.63])
-AC_INIT([loolwsd], [4.0.7], [libreoffice@lists.freedesktop.org])
+AC_INIT([loolwsd], [4.0.8], [libreoffice@lists.freedesktop.org])
LT_INIT([shared, disable-static, dlopen])
AM_INIT_AUTOMAKE([1.10 subdir-objects tar-pax -Wno-portability])
diff --git a/debian/changelog b/debian/changelog
index 5003f5446..642792d6d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+loolwsd (4.0.8-1) unstable; urgency=medium
+
+ * see the git log: http://col.la/cool40
+
+ -- Andras Timar Sat, 19 Oct 2019 22:55:00 +0200
+
loolwsd (4.0.7-1) unstable; urgency=medium
* see the git log: http://col.la/cool40
diff --git a/debian/control b/debian/control
index 5edc9b0d9..396c7d10e 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libsm6, libxinerama1,
libxrender1, libgl1-mesa-glx, libcups2, libxcb-render0, libxcb-shm0,
locales-all, adduser, expat, fontconfig, cpio, libcap2-bin,
collaboraofficebasis6.0-calc (= 6.0.10.29-20190912),
collaboraofficebasis6.0-core (= 6.0.10.29-20190912),
collaboraofficebasis6.0-graphicfilter (= 6.0.10.29-20190912),
collaboraofficebasis6.0-images (= 6.0.10.29-20190912),
collaboraofficebasis6.0-impress (= 6.0.10.29-20190912),
collaboraofficebasis6.0-ooofonts (= 6.0.10.29-20190912),
collaboraofficebasis6.0-writer (= 6.0.10.29-20190912), collaboraoffice6.0 (=
6.0.10.29-20190912), collaboraoffice6.0-ure (= 6.0.10.29-20190912),
collaboraofficebasis6.0-en-us (= 6.0.10.29-20190912),
collaboraofficebasis6.0-draw (= 6.0.10.29-20190912),
collaboraofficebasis6.0-extension-pdf-import (= 6.0.10.29-20190912),
collaboraofficebasis6.0-ooolinguistic (= 6.0.10.29-20190912)
+Depends: ${shlibs:Depends}, ${misc:Depends}, libsm6, libxinerama1,
libxrender1, libgl1-mesa-glx, libcups2, libxcb-render0, libxcb-shm0,
locales-all, adduser, expat, fontconfig, cpio, libcap2-bin,
collaboraofficebasis6.0-calc (= 6.0.10.29-20191019),
collaboraofficebasis6.0-core (= 6.0.10.29-20191019),
collaboraofficebasis6.0-graphicfilter (= 6.0.10.29-20191019),
collaboraofficebasis6.0-images (= 6.0.10.29-20191019),
collaboraofficebasis6.0-impress (= 6.0.10.29-20191019),
collaboraofficebasis6.0-ooofonts (= 6.0.10.29-20191019),
collaboraofficebasis6.0-writer (= 6.0.10.29-20191019), collaboraoffice6.0 (=
6.0.10.29-20191019), collaboraoffice6.0-ure (= 6.0.10.29-20191019),
collaboraofficebasis6.0-en-us (= 6.0.10.29-20191019),
collaboraofficebasis6.0-draw (= 6.0.10.29-20191019),
collaboraofficebasis6.0-extension-pdf-import (= 6.0.10.29-20191019),
collaboraofficebasis6.0-ooolinguistic (= 6.0.10.29-20191019)
Conflicts: collaboraofficebasis6.0-gnome-integration,
collaboraofficebasis6.0-kde-integration
Description: LibreOffice Online WebSocket Daemon
LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 9297f1e36..769246989 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -38,7 +38,7 @@ BuildRequires: libcap-progs linux-glibc-devel
systemd-rpm-macros python-polib
BuildRequires: libcap-progs
%endif
-Requires: collaboraoffice6.0 = 6.0.10.29-20190912 collaboraoffice6.0-ure
= 6.0.10.29-20190912 collaboraofficebasis6.0-core = 6.0.10.29-20190912
collaboraofficebasis6.0-writer = 6.0.10.29-20190912
collaboraofficebasis6.0-impress = 6.0.10.29-20190912
collaboraofficebasis6.0-graphicfilter = 6.0.10.29-20190912
collaboraofficebasis6.0-en-US = 6.0.10.29-20190912 collaboraofficebasis6.0-calc
= 6.0.10.29-20190912 collaboraofficebasis6.0-ooofonts = 6.0.10.29-20190912
collaboraofficebasis6.0-images = 6.0.10.29-20190912
collaboraofficebasis6.0-draw = 6.0.10.29-20190912
collaboraofficebasis6.0-extension-pdf-import = 6.0.10.29-20190912
collaboraofficebasis6.0-ooolinguistic = 6.0.10.29-20190912
+Requires: collaboraoffice6.0 = 6.0.10.29-20191019 collaboraoffice6.0-ure
= 6.0.10.29-20191019 collaboraofficebasis6.0-core = 6.0.10.29-20191019
collaboraofficebasis6.0-writer = 6.0.10.29-20191019
collaboraofficebasis6.0-impress = 6.0.10.29-20191019
collaboraofficebasis6.0-graphicfilter = 6.0.10.29-20191019
collaboraofficebasis6.0-en-US = 6.0.10.29-20191019 collaboraofficebasis6.0-calc
= 6.0.10.29-20191019 collaboraofficebasis6.0-ooofonts = 6.0.10.29-20191019
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #13 from jul...@palard.fr --- Hum no forget the last one about the traceback, it looks like I introduced it myself while trying to debug ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0-29' - instsetoo_native/util
instsetoo_native/util/openoffice.lst.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9812eeb3e506f6f16b339fa12a253381d8487eab Author: Andras Timar AuthorDate: Sat Oct 19 22:58:33 2019 +0200 Commit: Andras Timar CommitDate: Sat Oct 19 23:01:51 2019 +0200 Change PACKAGEREVISION to 20191019 Change-Id: If6b5a5f01e3f8338564bb52b867709ef836bdc5d diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index 2f8c0d458874..a26600d6668e 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -61,7 +61,7 @@ CollaboraOffice ADD_INCLUDE_FILES cli_ure/version/version.txt,unoil/climaker/version.txt ADDSYSTEMINTEGRATION 1 PACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@ -PACKAGEREVISION 20190912 +PACKAGEREVISION 20191019 LICENSENAME LGPL ROOTMODULEGID gid_Module_Root GLOBALPATCHFILEGID gid_File_Txt_Patchfiles ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127494] Enhancement request: shortcut for "Search" line in Help menu
https://bugs.documentfoundation.org/show_bug.cgi?id=127494 --- Comment #2 from maryline.lato...@gmail.com --- Sad it’s been marked as a duplicate. The aim of this enhancement suggestion is to use the mouse LESS and keep both your hands on the keyboard. As it was possible with older versions. SAVE THE KEYBOARD SHORTCUTS! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #12 from jul...@palard.fr --- > Could you check these libs: Yes: $ apt-cache policy unoconv uno-libs3 ure unoconv: Installed: (none) Candidate: 0.7-1.1 Version table: 0.7-1.1 990 990 https://deb.debian.org/debian bullseye/main amd64 Packages 500 https://deb.debian.org/debian sid/main amd64 Packages uno-libs3: Installed: 6.3.2-1+b1 Candidate: 6.3.2-1+b1 Version table: 6.3.3~rc1-1 500 500 https://deb.debian.org/debian sid/main amd64 Packages *** 6.3.2-1+b1 990 990 https://deb.debian.org/debian bullseye/main amd64 Packages 100 /var/lib/dpkg/status ure: Installed: 6.3.2-1+b1 Candidate: 6.3.2-1+b1 Version table: 6.3.3~rc1-1 500 500 https://deb.debian.org/debian sid/main amd64 Packages *** 6.3.2-1+b1 990 990 https://deb.debian.org/debian bullseye/main amd64 Packages 100 /var/lib/dpkg/status Oh, while I'm in this function, I can see the traceback being pretty printed, if it helps: File "/usr/lib/libreoffice/program/pythonloader.py", line 136, in activate mod = self.getModuleFromUrl( locationUrl ) File "/usr/lib/libreoffice/program/pythonloader.py", line 104, in getModuleFromUrl exec(codeobject, mod.__dict__) File "/usr/lib/libreoffice/share/extensions/voikko/lovoikko.py", line 15, in from SettingsEventHandler import SettingsEventHandler File "/usr/lib/python3/dist-packages/uno.py", line 359, in _uno_import return _builtin_import(name, *optargs, **kwargs) File "/usr/lib/libreoffice/share/extensions/voikko/pythonpath/SettingsEventHandler.py", line 18, in from PropertyManager import PropertyManager File "/usr/lib/python3/dist-packages/uno.py", line 359, in _uno_import return _builtin_import(name, *optargs, **kwargs) File "/usr/lib/libreoffice/share/extensions/voikko/pythonpath/PropertyManager.py", line 18, in from VoikkoHandlePool import VoikkoHandlePool File "/usr/lib/python3/dist-packages/uno.py", line 359, in _uno_import return _builtin_import(name, *optargs, **kwargs) File "/usr/lib/libreoffice/share/extensions/voikko/pythonpath/VoikkoHandlePool.py", line 15, in from libvoikko import Voikko, VoikkoException File "/usr/lib/python3/dist-packages/uno.py", line 359, in _uno_import return _builtin_import(name, *optargs, **kwargs) sadly I don't see the exception being handled, the only parameter is the traceback. I don't know if I can gather information about the running Java process at the moment of the exception (I'm more fluent in debugging Python than debugging Java). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #11 from Julien Nabet --- Could you check these libs: unoconv uno-libs3 ure ? Here what I got, I expect you got the same but since you also got unstable. root@debianamd:~# apt-cache policy unoconv unoconv: Installé : (aucun) Candidat : 0.7-1.1 Table de version : 0.7-1.1 500 500 http://ftp.fr.debian.org/debian stable/main amd64 Packages 500 http://ftp.fr.debian.org/debian testing/main amd64 Packages root@debianamd:~# apt-cache policy uno-libs3 uno-libs3: Installé : 6.3.2-1+b1 Candidat : 6.3.2-1+b1 Table de version : *** 6.3.2-1+b1 500 500 http://ftp.fr.debian.org/debian testing/main amd64 Packages 100 /var/lib/dpkg/status 6.1.5-3+deb10u3 500 500 http://ftp.fr.debian.org/debian stable/main amd64 Packages root@debianamd:~# apt-cache policy ure ure: Installé : 6.3.2-1+b1 Candidat : 6.3.2-1+b1 Table de version : *** 6.3.2-1+b1 500 500 http://ftp.fr.debian.org/debian testing/main amd64 Packages 100 /var/lib/dpkg/status 6.1.5-3+deb10u3 500 500 http://ftp.fr.debian.org/debian stable/main amd64 Packages -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #10 from jul...@palard.fr --- Looks like the error happen really near some: > /usr/lib/python3/dist-packages/uno.py(562)_uno_extract_printable_stacktrace() -> return ''.join(traceback.format_tb(trace)) probably right after. This looks called directly from Java (I have no stacktrace), the function runs well, and right after the return I have the crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/ui/dbui/mmresultdialogs.cxx | 67 --
1 file changed, 24 insertions(+), 43 deletions(-)
New commits:
commit 546e6c359e96a2e7f5aab7c158c7e843be6c8957
Author: Michael Weghorn
AuthorDate: Fri Oct 18 12:45:07 2019 +0200
Commit: Michael Weghorn
CommitDate: Sat Oct 19 22:44:37 2019 +0200
MM dialogs: Simplify code for from/to range a little bit
Change-Id: I8a845e24d0ce5aec6b2edc70fef42c39109ab6a3
Reviewed-on: https://gerrit.libreoffice.org/81092
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/sw/source/ui/dbui/mmresultdialogs.cxx
b/sw/source/ui/dbui/mmresultdialogs.cxx
index 9644ed99c538..4bb4b971d5a9 100644
--- a/sw/source/ui/dbui/mmresultdialogs.cxx
+++ b/sw/source/ui/dbui/mmresultdialogs.cxx
@@ -566,22 +566,18 @@ IMPL_LINK_NOARG(SwMMResultSaveDialog, SaveOutputHdl_Impl,
weld::Button&, void)
}
else
{
+const sal_uInt32 nDocumentCount =
xConfigItem->GetMergedDocumentCount();
sal_uInt32 nBegin = 0;
-sal_uInt32 nEnd = 0;
-sal_uInt32 documentCount = xConfigItem->GetMergedDocumentCount();
+sal_uInt32 nEnd = nDocumentCount;
-if (m_xSaveIndividualRB->get_active())
-{
-nBegin = 0;
-nEnd = documentCount;
-}
-else
+if (!m_xSaveIndividualRB->get_active())
{
nBegin = static_cast< sal_Int32 >(m_xFromNF->get_value() - 1);
nEnd= static_cast< sal_Int32 >(m_xToNF->get_value());
-if(nEnd > documentCount)
-nEnd = documentCount;
+if(nEnd > nDocumentCount)
+nEnd = nDocumentCount;
}
+
OUString sTargetTempURL = URIHelper::SmartRel2Abs(
INetURLObject(), utl::TempFile::CreateTempName(),
URIHelper::GetMaybeFileHdl());
@@ -756,21 +752,16 @@ IMPL_LINK_NOARG(SwMMResultPrintDialog, PrintHdl_Impl,
weld::Button&, void)
SwView* pTargetView = xConfigItem->GetTargetView();
assert(pTargetView);
+const sal_uInt32 nDocumentCount = xConfigItem->GetMergedDocumentCount();
sal_uInt32 nBegin = 0;
-sal_uInt32 nEnd = 0;
-sal_uInt32 documentCount = xConfigItem->GetMergedDocumentCount();
+sal_uInt32 nEnd = nDocumentCount;
-if (m_xPrintAllRB->get_active())
-{
-nBegin = 0;
-nEnd = documentCount;
-}
-else
+if (!m_xPrintAllRB->get_active())
{
nBegin = m_xFromNF->get_value() - 1;
nEnd= m_xToNF->get_value();
-if(nEnd > documentCount)
-nEnd = documentCount;
+if(nEnd > nDocumentCount)
+nEnd = nDocumentCount;
}
// If we skip autoinserted blanks, then the page numbers used in the print
range string
@@ -885,19 +876,15 @@ IMPL_LINK_NOARG(SwMMResultEmailDialog,
SendDocumentsHdl_Impl, weld::Button&, voi
lcl_UpdateEmailSettingsFromGlobalConfig(*xConfigItem);
}
//add the documents
+const sal_uInt32 nDocumentCount = xConfigItem->GetMergedDocumentCount();
sal_uInt32 nBegin = 0;
-sal_uInt32 nEnd = 0;
-if (m_xSendAllRB->get_active())
-{
-nBegin = 0;
-nEnd = xConfigItem->GetMergedDocumentCount();
-}
-else
+sal_uInt32 nEnd = nDocumentCount;
+if (!m_xSendAllRB->get_active())
{
nBegin = static_cast< sal_Int32 >(m_xFromNF->get_value() - 1);
nEnd= static_cast< sal_Int32 >(m_xToNF->get_value());
-if(nEnd > xConfigItem->GetMergedDocumentCount())
-nEnd = xConfigItem->GetMergedDocumentCount();
+if(nEnd > nDocumentCount)
+nEnd = nDocumentCount;
}
bool bAsBody = false;
rtl_TextEncoding eEncoding = ::osl_getThreadTextEncoding();
commit ff8e01b58c4d1a667c4db2163dcffade3de9fa7c
Author: Michael Weghorn
AuthorDate: Fri Oct 18 12:33:34 2019 +0200
Commit: Michael Weghorn
CommitDate: Sat Oct 19 22:44:26 2019 +0200
SwMMResultSaveDialog: Move some common code one level up
The dialog is called in any case.
Change-Id: I2cb14f227ad1e7417e2f44e4f0e357cb29d82fdc
Reviewed-on: https://gerrit.libreoffice.org/81091
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/sw/source/ui/dbui/mmresultdialogs.cxx
b/sw/source/ui/dbui/mmresultdialogs.cxx
index 6920fee3fe1c..9644ed99c538 100644
--- a/sw/source/ui/dbui/mmresultdialogs.cxx
+++ b/sw/source/ui/dbui/mmresultdialogs.cxx
@@ -529,15 +529,16 @@ IMPL_LINK_NOARG(SwMMResultSaveDialog, SaveOutputHdl_Impl,
weld::Button&, void)
SwView* pTargetView = xConfigItem->GetTargetView();
assert(pTargetView);
+OUString sFilter;
+OUString sPath = SwMailMergeHelper::CallSaveAsDialog(m_xDialog.get(),
sFilter);
+if (sPath.isEmpty())
+{
+// just return back to the dialog
+return;
+}
+
if (m_xSaveAsOneRB->get_active())
{
-OUString sFilter;
-const OUString sPath =
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #9 from jul...@palard.fr --- So my locales: LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE="en_US.utf8" LC_NUMERIC="en_US.utf8" LC_TIME="en_US.utf8" LC_COLLATE="en_US.utf8" LC_MONETARY="en_US.utf8" LC_MESSAGES="en_US.utf8" LC_PAPER="en_US.utf8" LC_NAME="en_US.utf8" LC_ADDRESS="en_US.utf8" LC_TELEPHONE="en_US.utf8" LC_MEASUREMENT="en_US.utf8" LC_IDENTIFICATION="en_US.utf8" LC_ALL=en_US.utf8 > Did you install any specific extensions? No, it's a brand new laptop, freshly installed. > Also when you indicated you uninstalled LO, did you include the profile in > ~/.config/libreoffice ? No but rm -fr it does not help (still crashes). Tried: $ sudo apt purge python3-libvoikko [sudo] password for mdk: Reading package lists... Done Building dependency tree Reading state information... Done The following packages will be REMOVED: libreoffice-voikko* python3-libvoikko* 0 upgraded, 0 newly installed, 2 to remove and 0 not upgraded. After this operation, 168 kB disk space will be freed. Do you want to continue? [Y/n] y (Reading database ... 328933 files and directories currently installed.) Removing libreoffice-voikko (5.0-3+b1) ... Removing python3-libvoikko (4.2-2) ... Processing triggers for libreoffice-common (1:6.3.2-1) ... Then no crash. Then: $ sudo apt install libreoffice-voikko Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: python3-libvoikko The following NEW packages will be installed: libreoffice-voikko python3-libvoikko 0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded. Need to get 50.5 kB of archives. After this operation, 168 kB of additional disk space will be used. Do you want to continue? [Y/n] y Get:1 https://cdn-aws.deb.debian.org/debian bullseye/main amd64 python3-libvoikko all 4.2-2 [27.1 kB] Get:2 https://cdn-aws.deb.debian.org/debian bullseye/main amd64 libreoffice-voikko amd64 5.0-3+b1 [23.4 kB] Fetched 50.5 kB in 2s (31.8 kB/s) Selecting previously unselected package python3-libvoikko. (Reading database ... 328897 files and directories currently installed.) Preparing to unpack .../python3-libvoikko_4.2-2_all.deb ... Unpacking python3-libvoikko (4.2-2) ... Selecting previously unselected package libreoffice-voikko. Preparing to unpack .../libreoffice-voikko_5.0-3+b1_amd64.deb ... Unpacking libreoffice-voikko (5.0-3+b1) ... Setting up python3-libvoikko (4.2-2) ... Setting up libreoffice-voikko (5.0-3+b1) ... Processing triggers for libreoffice-common (1:6.3.2-1) ... mdk@seraph$ rm -fr ~/.config/libreoffice/ mdk@seraph$ libreoffice # Then click on "Writer Document" Fatal Python error: Python memory allocator called without holding the GIL > what desktop do you use? Personally, I use gtk3. I don't really understand this question, I'll try to answer, tell me if I'm out of scope: I'm using i3wm, started by lightdm, on top of Xorg. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - debian/loolwsd.postrm
debian/loolwsd.postrm |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit d9c3d7df368fb8f19f969412f97ad6f26aa1a770 Author: Lionel Elie Mamane AuthorDate: Fri Oct 18 19:05:33 2019 +0200 Commit: Andras Timar CommitDate: Sat Oct 19 22:27:57 2019 +0200 debian package postrm: fix lintian warning Change-Id: I7db7a5549f4fdf3597be0df13b4ff447522b7b92 Reviewed-on: https://gerrit.libreoffice.org/81089 Reviewed-by: Andras Timar Tested-by: Andras Timar (cherry picked from commit 0c426536fac66a4cabf4b5feefd188022a56e594) Reviewed-on: https://gerrit.libreoffice.org/81143 diff --git a/debian/loolwsd.postrm b/debian/loolwsd.postrm index d4e1fd993..784ad65ba 100755 --- a/debian/loolwsd.postrm +++ b/debian/loolwsd.postrm @@ -1,3 +1,5 @@ #!/bin/sh -rm /etc/apt/apt.conf.d/25loolwsd +set -e + +rm -f /etc/apt/apt.conf.d/25loolwsd ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - debian/loolwsd.postrm
debian/loolwsd.postrm |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 0c426536fac66a4cabf4b5feefd188022a56e594 Author: Lionel Elie Mamane AuthorDate: Fri Oct 18 19:05:33 2019 +0200 Commit: Andras Timar CommitDate: Sat Oct 19 22:27:30 2019 +0200 debian package postrm: fix lintian warning Change-Id: I7db7a5549f4fdf3597be0df13b4ff447522b7b92 Reviewed-on: https://gerrit.libreoffice.org/81089 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/debian/loolwsd.postrm b/debian/loolwsd.postrm index d4e1fd993..784ad65ba 100755 --- a/debian/loolwsd.postrm +++ b/debian/loolwsd.postrm @@ -1,3 +1,5 @@ #!/bin/sh -rm /etc/apt/apt.conf.d/25loolwsd +set -e + +rm -f /etc/apt/apt.conf.d/25loolwsd ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97362] Convert Java complex tests to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=97362 Guillaume Monzerol changed: What|Removed |Added Assignee|guillaume.monze...@gmail.co |libreoffice-b...@lists.free |m |desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #8 from Julien Nabet --- Also when you indicated you uninstalled LO, did you include the profile in ~/.config/libreoffice ? Did you install any specific extensions? what desktop do you use? Personally, I use gtk3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #7 from Julien Nabet --- I installed libenchant-voikko which wasn't present, still no crash. What's your localization? (UI + local parameters) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117595] UI hangs on Tools -> Options (or Alt-F12)
https://bugs.documentfoundation.org/show_bug.cgi?id=117595 Timur changed: What|Removed |Added Resolution|WORKSFORME |NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220 --- Comment #6 from jul...@palard.fr --- In my case, opening LO and just clicking "Writer Document" is enough to crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128220] Fatal Python error: Python memory allocator called without holding the GIL
https://bugs.documentfoundation.org/show_bug.cgi?id=128220
--- Comment #5 from jul...@palard.fr ---
If it can help:
here's my apt list --installed | grep libreoffice:
libreoffice-base-core/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-base-drivers/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-base/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-calc/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-common/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-core/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-draw/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-gnome/testing,now 1:6.3.2-1+b1 amd64 [installed]
libreoffice-gtk3/testing,now 1:6.3.2-1+b1 amd64 [installed]
libreoffice-impress/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-java-common/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-math/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-nlpsolver/testing,now 0.9+LibO6.3.2-1 all [installed,automatic]
libreoffice-report-builder-bin/testing,now 1:6.3.2-1+b1 amd64
[installed,automatic]
libreoffice-report-builder/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-script-provider-bsh/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-script-provider-js/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-script-provider-python/testing,now 1:6.3.2-1 all
[installed,automatic]
libreoffice-sdbc-firebird/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-sdbc-mysql/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice-sdbc-postgresql/testing,now 1:6.3.2-1+b1 amd64
[installed,automatic]
libreoffice-style-colibre/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-style-elementary/testing,now 1:6.3.2-1 all [installed]
libreoffice-style-tango/testing,now 1:6.3.2-1 all [installed,automatic]
libreoffice-voikko/testing,unstable,now 5.0-3+b1 amd64 [installed]
libreoffice-wiki-publisher/testing,now 1.2.0+LibO6.3.2-1 all
[installed,automatic]
libreoffice-writer/testing,now 1:6.3.2-1+b1 amd64 [installed,automatic]
libreoffice/testing,now 1:6.3.2-1+b1 amd64 [installed]
mdk@seraph$ which python3
/usr/bin/python3
mdk@seraph$ dpkg -S $(which python3)
python3-minimal: /usr/bin/python3
mdk@seraph$ apt-cache policy python3-minimal
python3-minimal:
Installed: 3.7.5-1
Candidate: 3.7.5-1
Version table:
*** 3.7.5-1 990
990 https://deb.debian.org/debian bullseye/main amd64 Packages
500 https://deb.debian.org/debian sid/main amd64 Packages
100 /var/lib/dpkg/status
According to strace, it uses this Python, not Python 2, I see:
$ grep -i python --color /tmp/libreoffice.strace
14771 openat(AT_FDCWD,
"/usr/lib/libreoffice/program/services/scriptproviderforpython.rdb", O_RDONLY)
= 7
14771 openat(AT_FDCWD, "/usr/lib/libreoffice/program/libpythonloaderlo.so",
O_RDONLY|O_CLOEXEC) = 22
14771 openat(AT_FDCWD, "/usr/lib/libreoffice/program/libpython3.7m.so.1.0",
O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
14771 openat(AT_FDCWD, "/lib/x86_64-linux-gnu/libpython3.7m.so.1.0",
O_RDONLY|O_CLOEXEC) = 22
14771 access("/usr/lib/libreoffice/program/pythonloader.unorc", F_OK) = 0
14771 openat(AT_FDCWD, "/usr/lib/libreoffice/program/pythonloader.unorc",
O_RDONLY) = 22
[...]
14771 stat("/usr/lib/python3/dist-packages/libvoikko.py",
{st_mode=S_IFREG|0644, st_size=33294, ...}) = 0
Also:
$ apt list --installed | grep voikko
libenchant-voikko/testing,unstable,now 1.6.0-11.3 amd64
[installed,automatic]
libreoffice-voikko/testing,unstable,now 5.0-3+b1 amd64 [installed]
libvoikko1/testing,unstable,now 4.2-2 amd64 [installed,automatic]
python3-libvoikko/testing,unstable,now 4.2-2 all [installed,automatic]
voikko-fi/testing,unstable,now 2.3-1 amd64 [installed,automatic]
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127910] main menu and context menus empty when using form elements and OpenGL
https://bugs.documentfoundation.org/show_bug.cgi?id=127910 V Stuart Foote changed: What|Removed |Added CC||martin.wieb...@gmx.de --- Comment #14 from V Stuart Foote --- *** Bug 128253 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128253] Menu disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=128253 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- You look to be on Windows with OpenGL rendering enabled, disable OpenGL (Tools -> Options -> View dialog) that will work around the visual glitch. *** This bug has been marked as a duplicate of bug 127910 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98255] Excel keyboard shortcut bindings for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=98255 V Stuart Foote changed: What|Removed |Added CC||pos...@posteo.eu --- Comment #11 from V Stuart Foote --- *** Bug 128247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128247] Include a template for MS Office shortcuts to ease the transition to LO
https://bugs.documentfoundation.org/show_bug.cgi?id=128247 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- While scope here is entire suite, bug 98255 is already open against Calc where we already provide 'legacy' mode (Tools -> Options -> Calc -> Combatibility : 'Key Bindings' drop list. Low hanging fruit is for Calc becuase of that existing framework. But potential for 'theming'/'skinning' other modules in addition to Calc against keyboard shortcuts of other popular productivity and DTP programs. *** This bug has been marked as a duplicate of bug 98255 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/copy_paste_test.cxx|4 sc/qa/unit/ucalc_formula.cxx | 166 +++ sc/source/filter/html/htmlpars.cxx|2 sc/source/ui/Accessibility/AccessibleCell.cxx |2 sc/source/ui/docshell/docfunc.cxx | 185 +- 5 files changed, 181 insertions(+), 178 deletions(-) New commits: commit 2571a11aeb0bdca20242caa5c96f0a5b3ea5db90 Author: Michael Meeks AuthorDate: Sat Oct 19 15:28:13 2019 +0100 Commit: Michael Meeks CommitDate: Sat Oct 19 21:12:57 2019 +0200 sc: rowcol: tdf#50916 convert ucalc test, and docfunc. Change-Id: I692ecf758e06bf904a41b9316e32dff169408a05 Reviewed-on: https://gerrit.libreoffice.org/81140 Tested-by: Jenkins Reviewed-by: Michael Meeks diff --git a/sc/qa/unit/copy_paste_test.cxx b/sc/qa/unit/copy_paste_test.cxx index adc736553953..6f3b0622366b 100644 --- a/sc/qa/unit/copy_paste_test.cxx +++ b/sc/qa/unit/copy_paste_test.cxx @@ -280,7 +280,7 @@ void ScCopyPasteTest::testTdf124565() // Copy first row ScDocument aClipDoc(SCDOCMODE_CLIP); -ScRange aCopyRange(0, 0, 0, MAXCOL, 0, 0); +ScRange aCopyRange(0, 0, 0, aClipDoc.MaxCol(), 0, 0); pViewShell->GetViewData().GetMarkData().SetMarkArea(aCopyRange); pViewShell->GetViewData().GetView()->CopyToClip(, false, false, false, false); @@ -289,7 +289,7 @@ void ScCopyPasteTest::testTdf124565() SCCOL nCol = 0; SCROW nRow = 1; -ScRange aPasteRange(nCol, nRow, nTab, MAXCOL, nRow, nTab); +ScRange aPasteRange(nCol, nRow, nTab, aClipDoc.MaxCol(), nRow, nTab); pViewShell->GetViewData().GetMarkData().SetMarkArea(aPasteRange); pViewShell->GetViewData().GetView()->PasteFromClip(InsertDeleteFlags::ALL, ); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 66a83d4618aa..9266c4cca840 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -370,7 +370,7 @@ void Test::testFormulaParseReference() CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aStart.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aEnd.Tab()); CPPUNIT_ASSERT_EQUAL(static_cast(1), aRange.aEnd.Col()); -CPPUNIT_ASSERT_EQUAL(MAXROW, aRange.aEnd.Row()); +CPPUNIT_ASSERT_EQUAL(m_pDoc->MaxRow(), aRange.aEnd.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | ScRefFlags::COL2_VALID | ScRefFlags::ROW2_VALID | ScRefFlags::TAB2_VALID), static_cast(nRes & (ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | @@ -387,7 +387,7 @@ void Test::testFormulaParseReference() CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aStart.Col()); CPPUNIT_ASSERT_EQUAL(static_cast(1), aRange.aStart.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aEnd.Tab()); -CPPUNIT_ASSERT_EQUAL(MAXCOL, aRange.aEnd.Col()); +CPPUNIT_ASSERT_EQUAL(m_pDoc->MaxCol(), aRange.aEnd.Col()); CPPUNIT_ASSERT_EQUAL(static_cast(1), aRange.aEnd.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | ScRefFlags::COL2_VALID | ScRefFlags::ROW2_VALID | ScRefFlags::TAB2_VALID), @@ -405,7 +405,7 @@ void Test::testFormulaParseReference() CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aStart.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(4), aRange.aEnd.Tab()); CPPUNIT_ASSERT_EQUAL(static_cast(2), aRange.aEnd.Col()); -CPPUNIT_ASSERT_EQUAL(MAXROW, aRange.aEnd.Row()); +CPPUNIT_ASSERT_EQUAL(m_pDoc->MaxRow(), aRange.aEnd.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | ScRefFlags::COL2_VALID | ScRefFlags::ROW2_VALID | ScRefFlags::TAB2_VALID), static_cast(nRes & (ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | @@ -424,7 +424,7 @@ void Test::testFormulaParseReference() CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aStart.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aEnd.Tab()); CPPUNIT_ASSERT_EQUAL(static_cast(1), aRange.aEnd.Col()); -CPPUNIT_ASSERT_EQUAL(MAXROW, aRange.aEnd.Row()); +CPPUNIT_ASSERT_EQUAL(m_pDoc->MaxRow(), aRange.aEnd.Row()); CPPUNIT_ASSERT_EQUAL(static_cast(ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | ScRefFlags::COL2_VALID | ScRefFlags::ROW2_VALID | ScRefFlags::TAB2_VALID), static_cast(nRes & (ScRefFlags::COL_VALID | ScRefFlags::ROW_VALID | ScRefFlags::TAB_VALID | @@ -442,7 +442,7 @@ void Test::testFormulaParseReference() CPPUNIT_ASSERT_EQUAL(static_cast(0), aRange.aStart.Col()); CPPUNIT_ASSERT_EQUAL(static_cast(1), aRange.aStart.Row());
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #102 from Commit Notification --- Michael Meeks committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2571a11aeb0bdca20242caa5c96f0a5b3ea5db90 sc: rowcol: tdf#50916 convert ucalc test, and docfunc. It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126293] Save icon changes size when document gets modified
https://bugs.documentfoundation.org/show_bug.cgi?id=126293 --- Comment #14 from Michael Meeks --- Sure - why not if someone wants to test & maintain that, I don't have time personally, sorry ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d8f11761d89b3279e547f789d43d47c85a3ddba1 Author: Caolán McNamara AuthorDate: Sat Oct 19 17:48:59 2019 +0100 Commit: Caolán McNamara CommitDate: Sat Oct 19 21:06:25 2019 +0200 mariadb still uses char for my_bool mariadb-devel-10.3.17-1.fc30.x86_64 still has typedef char my_bool; Change-Id: I3d1f5423c8750180bc28c56bc0ead4f746fd1c23 Reviewed-on: https://gerrit.libreoffice.org/81137 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.hxx b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.hxx index 3450473ee895..660fd17de2b2 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.hxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.hxx @@ -39,7 +39,7 @@ using ::com::sun::star::uno::Reference; using ::com::sun::star::uno::RuntimeException; using ::com::sun::star::uno::Type; -#if defined MYSQL_VERSION_ID && (MYSQL_VERSION_ID >= 8) +#if defined MYSQL_VERSION_ID && (MYSQL_VERSION_ID >= 8) && !defined MARIADB_BASE_VERSION using my_bool = bool; #else using my_bool = char; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
New commits:
commit feb21e498afa8d6fd12a82fb56a2456b2db83e24
Author: Caolán McNamara
AuthorDate: Sat Oct 19 17:20:23 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 19 21:05:58 2019 +0200
Resolves: tdf#128241 reuse label to retain buildable_name
Change-Id: Ib5cb31279fdf6e2fa83ea46625c320185992bca1
Reviewed-on: https://gerrit.libreoffice.org/81136
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 0d8f4d30b7c1..0b93a5a3f270 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5370,7 +5370,21 @@ private:
static void set_tab_label_text(GtkNotebook *pNotebook, guint nPage, const
OUString& rText)
{
-gtk_notebook_set_tab_label_text(pNotebook,
gtk_notebook_get_nth_page(pNotebook, nPage), rText.toUtf8().getStr());
+OString sUtf8(rText.toUtf8());
+
+GtkWidget* pPage = gtk_notebook_get_nth_page(pNotebook, nPage);
+
+// tdf#128241 if there's already a label here, reuse it so the
buildable
+// name remains the same, gtk_notebook_set_tab_label_text will replace
+// the label widget with a new one
+GtkWidget* pTabWidget = gtk_notebook_get_tab_label(pNotebook, pPage);
+if (pTabWidget && GTK_IS_LABEL(pTabWidget))
+{
+gtk_label_set_label(GTK_LABEL(pTabWidget), sUtf8.getStr());
+return;
+}
+
+gtk_notebook_set_tab_label_text(pNotebook, pPage, sUtf8.getStr());
}
void append_useless_page(GtkNotebook *pNotebook)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 V Stuart Foote changed: What|Removed |Added CC||eido.ask...@gmail.com --- Comment #29 from V Stuart Foote --- *** Bug 128242 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128242] Add support for execution of commands by typing the corresponding command name
https://bugs.documentfoundation.org/show_bug.cgi?id=128242 V Stuart Foote changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 91874 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: fpicker/source include/vcl vcl/qa vcl/source
fpicker/source/office/fpdialogbase.hxx |2 +-
include/vcl/dialog.hxx |2 +-
vcl/qa/cppunit/lifecycle.cxx |2 +-
vcl/source/window/dialog.cxx |6 +++---
4 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 54960717cded98c5f73a752271375daf08129a18
Author: Caolán McNamara
AuthorDate: Sat Oct 19 17:05:51 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Oct 19 21:04:38 2019 +0200
strip Dialog ctor down
Change-Id: Ic00f5a5fe562022524c60a23509722f9e2406524
Reviewed-on: https://gerrit.libreoffice.org/81135
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/fpicker/source/office/fpdialogbase.hxx
b/fpicker/source/office/fpdialogbase.hxx
index c49c6d56b638..5b921b9379d0 100644
--- a/fpicker/source/office/fpdialogbase.hxx
+++ b/fpicker/source/office/fpdialogbase.hxx
@@ -66,7 +66,7 @@ class SvtFileDialog_Base : public Dialog, public
::svt::IFilePickerController
{
public:
SvtFileDialog_Base( vcl::Window* pParent, const OUString& rID, const
OUString& rUIXMLDescription )
-: Dialog( pParent, rID, rUIXMLDescription, WindowType::MODALDIALOG,
InitFlag::Default )
+: Dialog(pParent, rID, rUIXMLDescription)
{
}
diff --git a/include/vcl/dialog.hxx b/include/vcl/dialog.hxx
index 15827443ba45..275dd6c76b57 100644
--- a/include/vcl/dialog.hxx
+++ b/include/vcl/dialog.hxx
@@ -82,7 +82,7 @@ public:
protected:
explicitDialog( WindowType nType );
-explicitDialog( vcl::Window* pParent, const OUString& rID, const
OUString& rUIXMLDescription, WindowType nType, InitFlag eFlag =
InitFlag::Default );
+explicitDialog( vcl::Window* pParent, const OUString& rID, const
OUString& rUIXMLDescription);
virtual voidDraw( OutputDevice* pDev, const Point& rPos, const Size&
rSize, DrawFlags nFlags ) override;
virtual voidsettingOptimalLayoutSize(Window *pBox) override;
diff --git a/vcl/qa/cppunit/lifecycle.cxx b/vcl/qa/cppunit/lifecycle.cxx
index ff057eff3bb4..51d90776bb44 100644
--- a/vcl/qa/cppunit/lifecycle.cxx
+++ b/vcl/qa/cppunit/lifecycle.cxx
@@ -297,7 +297,7 @@ void LifecycleTest::testLeakage()
aObjects.push_back(LeakTestObject::Create(xVBox));
}
-aObjects.push_back(LeakTestObject::Create(xParent,
"PrintProgressDialog", "vcl/ui/printprogressdialog.ui",
WindowType::MODALDIALOG));
+aObjects.push_back(LeakTestObject::Create(xParent,
"PrintProgressDialog", "vcl/ui/printprogressdialog.ui"));
xParent.clear();
for (auto i = aObjects.rbegin(); i != aObjects.rend(); ++i)
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index f0c54aef9b9c..3bba7d2fc787 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -558,9 +558,9 @@ void Dialog::doDeferredInit(WinBits nBits)
mbIsDeferredInit = false;
}
-Dialog::Dialog(vcl::Window* pParent, const OUString& rID, const OUString&
rUIXMLDescription, WindowType nType, InitFlag eFlag)
-: SystemWindow(nType)
-, mnInitFlag(eFlag)
+Dialog::Dialog(vcl::Window* pParent, const OUString& rID, const OUString&
rUIXMLDescription)
+: SystemWindow(WindowType::DIALOG)
+, mnInitFlag(InitFlag::Default)
{
ImplLOKNotifier(pParent);
ImplInitDialogData();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - wsd/DocumentBroker.cpp
wsd/DocumentBroker.cpp | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
New commits:
commit 77cbe4e376649dee87dbe37f95a48e9bb6403a0b
Author: Ashod Nakashian
AuthorDate: Wed Oct 16 09:05:04 2019 -0400
Commit: Andras Timar
CommitDate: Sat Oct 19 20:58:40 2019 +0200
wsd: save using a fully-loaded view
Using a view that hasn't finished loading
for saving the document will fail, and there
is no recovery from that (by using a loaded
view as fallback, for example).
This can happen when a new view is being loaded
while the last one is closing. We might in this
case end up using the new view to save the document
before closing it, however this will fail if
the new view hasn't loaded yet, potentially
losing some late modifications.
We avoid this by always picking a loaded view
for saving, or the first.
Change-Id: I03ee9c48a9d43487dd90672060870972b98fdc99
Reviewed-on: https://gerrit.libreoffice.org/80896
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index ed64b93ef..657ea999b 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -993,18 +993,19 @@ bool DocumentBroker::autoSave(const bool force)
// Which session to use when auto saving ?
std::string savingSessionId;
-for (auto& sessionIt : _sessions)
+for (auto& session : _sessions)
{
-// Save the document using an editable session, or first ...
-if (savingSessionId.empty() || !sessionIt.second->isReadOnly())
+// Save the document using an editable and loaded session, or first ...
+if (savingSessionId.empty()
+|| (!session.second->isReadOnly() &&
session.second->isViewLoaded()))
{
-savingSessionId = sessionIt.second->getId();
+savingSessionId = session.second->getId();
}
// or if any of the sessions is document owner, use that.
-if (sessionIt.second->isDocumentOwner())
+if (session.second->isDocumentOwner())
{
-savingSessionId = sessionIt.second->getId();
+savingSessionId = session.second->getId();
break;
}
}
@@ -1210,9 +1211,11 @@ size_t DocumentBroker::removeSession(const std::string&
id)
const bool lastEditableSession = !it->second->isReadOnly() &&
!haveAnotherEditableSession(id);
-LOG_INF("Removing session [" << id << "] on docKey [" << _docKey <<
-"]. Have " << _sessions.size() << " sessions. markToDestroy: "
<< _markToDestroy <<
-", LastEditableSession: " << lastEditableSession);
+LOG_INF("Removing session ["
+<< id << "] on docKey [" << _docKey << "]. Have " <<
_sessions.size()
+<< " sessions. IsReadOnly: " << it->second->isReadOnly() << ",
IsViewLoaded: "
+<< it->second->isViewLoaded() << ". markToDestroy: " <<
_markToDestroy
+<< ", LastEditableSession: " << lastEditableSession);
// If last editable, save and don't remove until after uploading to
storage.
if (!lastEditableSession || !autoSave(isPossiblyModified()))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - kit/ChildSession.cpp test/httpwstest.cpp wsd/ClientSession.cpp
kit/ChildSession.cpp |1 +
test/httpwstest.cpp |5 +++--
wsd/ClientSession.cpp |8 +---
3 files changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 230fcd2f07192f30fb6d6671d905800fde71495e
Author: Ashod Nakashian
AuthorDate: Wed Oct 16 09:12:02 2019 -0400
Commit: Andras Timar
CommitDate: Sat Oct 19 20:59:31 2019 +0200
testSaveOnDisconnect: sync after pasting and better logging
Change-Id: Iaacbe0bdc6a7ba88d2f09c343d9579315033acbb
Reviewed-on: https://gerrit.libreoffice.org/80898
Reviewed-by: Andras Timar
Tested-by: Andras Timar
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 6699c67a5..d75809532 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -208,6 +208,7 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
sendTextFrame("error: cmd=load kind=faileddocloading");
}
+LOG_TRC("isDocLoaded state after loadDocument: " << _isDocLoaded <<
'.');
return _isDocLoaded;
}
else if (!_isDocLoaded)
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 6c6e9a625..d95c61a3a 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -777,7 +777,7 @@ void HTTPWSTest::testSaveOnDisconnect()
void HTTPWSTest::testSavePassiveOnDisconnect()
{
-const char* testname = "saveOnPassiveDisconnect ";
+const char* testname = "savePassiveOnDisconnect ";
const std::string text = helpers::genRandomString(40);
TST_LOG("Test string: [" << text << "].");
@@ -971,7 +971,8 @@ void HTTPWSTest::testLargePaste()
const std::string documentContents = oss.str();
TST_LOG("Pasting " << documentContents.size() << " characters into
document.");
-sendTextFrame(socket, "paste mimetype=text/html\n" + documentContents,
testname);
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\n" +
documentContents, testname);
+getResponseString(socket, "textselection:", testname, 1000);
// Check if the server is still alive.
// This resulted first in a hang, as respose for the message never
arrived, then a bit later in a Poco::TimeoutException.
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 112eb511e..8517f0bb3 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -205,7 +205,7 @@ bool ClientSession::_handleInput(const char *buffer, int
length)
{
// If this session is the owner of the file & 'EnableOwnerTermination'
feature
// is turned on by WOPI, let it close all sessions
-if (_isDocumentOwner && _wopiFileInfo &&
_wopiFileInfo->getEnableOwnerTermination())
+if (isDocumentOwner() && _wopiFileInfo &&
_wopiFileInfo->getEnableOwnerTermination())
{
LOG_DBG("Session [" << getId() << "] requested owner termination");
docBroker->closeDocument("ownertermination");
@@ -1187,7 +1187,9 @@ void ClientSession::removeOutdatedTilesOnFly()
double elapsedTimeMs =
std::chrono::duration_cast(std::chrono::steady_clock::now()
- tileIter->second).count();
if(elapsedTimeMs > TILE_ROUNDTRIP_TIMEOUT_MS)
{
-LOG_WRN("Tracker tileID was dropped because of time out.
Tileprocessed message did not arrive");
+LOG_WRN("Tracker tileID " << tileIter->first << " was dropped
because of time out ("
+ << elapsedTimeMs
+ << " ms). Tileprocessed message did not
arrive in time.");
_tilesOnFly.erase(tileIter);
}
else
@@ -1279,7 +1281,7 @@ void ClientSession::dumpState(std::ostream& os)
Session::dumpState(os);
os << "\t\tisReadOnly: " << isReadOnly()
- << "\n\t\tisDocumentOwner: " << _isDocumentOwner
+ << "\n\t\tisDocumentOwner: " << isDocumentOwner()
<< "\n\t\tisAttached: " << _isAttached
<< "\n\t\tkeyEvents: " << _keyEvents;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - test/TileCacheTests.cpp
test/TileCacheTests.cpp |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit e173427bd9ca5939339994180f5b51ea11393050
Author: Ashod Nakashian
AuthorDate: Wed Oct 16 09:09:59 2019 -0400
Commit: Andras Timar
CommitDate: Sat Oct 19 20:59:09 2019 +0200
testTileWriteIDHandling: don't block for too long
When polling for tile messages, the last wait
(which will timeout) by default will be 10 seconds.
This is too long to make the tests fast enough, and
also results in the internal cache from evicting
tiles in some cases.
Change-Id: I6c2b80022ffcef2b21c99dd57bca61e7daaadc86
Reviewed-on: https://gerrit.libreoffice.org/80897
Reviewed-by: Andras Timar
Tested-by: Andras Timar
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index fd453d995..575caf9f0 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -1226,7 +1226,8 @@ void TileCacheTests::testTileWireIDHandling()
bool gotTile = false;
do
{
-std::vector tile = getResponseMessage(socket, "tile:", testname);
+// If we wait for too long, the cached tiles will get evicted.
+std::vector tile = getResponseMessage(socket, "tile:", testname,
500);
gotTile = !tile.empty();
if(gotTile)
++arrivedTiles;
@@ -1238,7 +1239,7 @@ void TileCacheTests::testTileWireIDHandling()
sendChar(socket, 'x', skNone, testname);
assertResponseString(socket, "invalidatetiles:", testname);
-// For the second input wsd will send one tile, since some of them are
indentical
+// For the second input wsd will send one tile, since some of them are
identical.
arrivedTiles = 0;
do
{
@@ -1376,7 +1377,7 @@ void TileCacheTests::testTileBeingRenderedHandling()
bool gotTile = false;
do
{
-std::vector tile = getResponseMessage(socket, "tile:", testname);
+std::vector tile = getResponseMessage(socket, "tile:", testname,
500);
gotTile = !tile.empty();
if(gotTile)
++arrivedTiles;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - test/helpers.hpp test/httpwstest.cpp
test/helpers.hpp|4 ++--
test/httpwstest.cpp | 37 +
2 files changed, 31 insertions(+), 10 deletions(-)
New commits:
commit 93abce99d02aa417feeae12f9232b0be83a74e35
Author: Ashod Nakashian
AuthorDate: Sun Oct 13 21:27:53 2019 -0400
Commit: Andras Timar
CommitDate: Sat Oct 19 20:58:17 2019 +0200
test: fix segfault due to invalid iterator position
The SVG can have self-closing tags, which wasn't accounted
for. Finding end-tags that aren't matching start tags
resulted in segfaults due to out-of-bounds writing.
Change-Id: I749ba7f59351cf635fdc1cd30b3be5260b3c6b16
Reviewed-on: https://gerrit.libreoffice.org/80895
Reviewed-by: Andras Timar
Tested-by: Andras Timar
diff --git a/test/helpers.hpp b/test/helpers.hpp
index 480c5ca6e..caa3390e3 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -673,9 +673,9 @@ inline bool svgMatch(const char *testname, const
std::vector , co
newName += ".new";
TST_LOG_APPEND("Updated template writing to: " << newName << "\n");
TST_LOG_END;
+
FILE *of = fopen(Poco::Path(TDOC, newName).toString().c_str(), "w");
-size_t unused = fwrite(response.data(), response.size(), 1, of);
-(void)unused;
+CPPUNIT_ASSERT(fwrite(response.data(), response.size(), 1, of) ==
response.size());
fclose(of);
return false;
}
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 012938f2a..6c6e9a625 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -60,19 +60,40 @@ namespace
*/
void stripDescriptions(std::vector& svg)
{
+static const std::string startDesc("");
+static const std::string endDesc("");
+static const std::string selfClose("/>");
+
while (true)
{
-std::string startDesc("");
-auto itStart = std::search(svg.begin(), svg.end(), startDesc.begin(),
startDesc.end());
+const auto itStart = std::search(svg.begin(), svg.end(),
startDesc.begin(), startDesc.end());
if (itStart == svg.end())
return;
-std::string endDesc("");
-auto itEnd = std::search(svg.begin(), svg.end(), endDesc.begin(),
endDesc.end());
-if (itEnd == svg.end())
-return;
+const auto itClose = std::search(itStart + 1, svg.end(),
selfClose.begin(), selfClose.end());
-svg.erase(itStart, itEnd + endDesc.size());
+const auto itEnd = std::search(itStart + 1, svg.end(),
endDesc.begin(), endDesc.end());
+
+if (itEnd != svg.end() && itClose != svg.end())
+{
+if (itEnd < itClose)
+svg.erase(itStart, itEnd + endDesc.size());
+else
+svg.erase(itStart, itClose + selfClose.size());
+}
+else if (itEnd != svg.end())
+{
+svg.erase(itStart, itEnd + endDesc.size());
+}
+else if (itClose != svg.end())
+{
+svg.erase(itStart, itClose + selfClose.size());
+}
+else
+{
+// No more closing tags; possibly broken, as we found an opening
tag.
+return;
+}
}
}
}
@@ -2707,7 +2728,7 @@ void HTTPWSTest::testRenderShapeSelectionImpress()
sendTextFrame(socket, "rendershapeselection mimetype=image/svg+xml",
testname);
std::vector responseSVG = getResponseMessage(socket,
"shapeselectioncontent:", testname);
CPPUNIT_ASSERT(!responseSVG.empty());
-auto it = std::find(responseSVG.begin(), responseSVG.end(),'\n');
+auto it = std::find(responseSVG.begin(), responseSVG.end(), '\n');
if (it != responseSVG.end())
responseSVG.erase(responseSVG.begin(), ++it);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
