[Libreoffice-bugs] [Bug 112059] Events fired by subform changed, when form is write-protected

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112059

--- Comment #10 from Robert Großkopf  ---
Bug still exists with LO 6.4.0.0 beta1 on OpenSUSE 15.1 64bit rpm Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129255] New: calc: wrong results, proposal to clear shared formula ./. autocalculate problems

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129255

Bug ID: 129255
   Summary: calc: wrong results, proposal to clear shared formula
./. autocalculate problems
   Product: LibreOffice
   Version: 4.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: newbie...@gmx.de

Description:

sorry @all, 

I have an unusual, and difficult, suggestion to get a handle on an annoying
problem. 

Situation: since about five years (4.1 -> 4.2) LO calc suffers from errors in
the interaction between shared formulas and autocalculate. 

Neither the developers nor the testers are able to think through the complexity
of relationships and dependencies that simple users can construct in sheets. 

Users construct complex sheets, and are not able to completely control their
results.  

Users are not aware that displayed results may be wrong. 

Users need a reliable program, they need correct results. 

Developers and Testers must (also) be able to dedicate themselves to other
tasks. 

The processing of the complex 'shared formula ./. autocalculate' has brought
over several years only success messages for individual aspects being fixed,
the basic problem still remains. 

See: https://bugs.documentfoundation.org/show_bug.cgi?id=111428#c21

I am not close enough to programming to decide whether the problem can be
solved with the current tools, my mathematical knowledge and my knowledge about
the structures in program and data are not enough to prove a theoretical
solvability. 

I am close enough to 'testing' to think that it is largely impossible to prove
the correctness of all possible calculations by testing or to present them as
sufficiently 'probable'. 

Imho that the malfunctions resulting from this bug-complex are serious and
undermine the trustworthiness of the program. 

Hence the following suggestion: 

A 'task-force' of developers and testers is formed to handle this problem with
priority. 

The problem is approached from another side, it is started from the last
correct version and checked how complex it is to remove the special handling of
'shared formulae' from calc. 

(Neutralizing the original implementation, working through and if necessary
neutralizing all patches based on it). 

If enough manpower is available, two groups can work in opposite directions,
one as above and the second one goes 'backwards' through all patches that refer
to autocalculate and shared formulae and tries to show their correctness. 

It may be that in this work the actual error is noticed and can be fixed. 

If it is not found - hopefully - a version without 'shared formulas' will be
created that: 

1) maybe works a little slower, but 

2) provides correct results. 

1. is probably to be overcome on the basis of the efficiency of current
hardware, 

2. is important! 

I think I'm talking about one to two man-years of development here, that's 'not
nice' :-( 
 ... but the alternative to keep 'poking in the fog' and hope that by chance
you will find the real flaw among all the patches in the meantime is: 
- uncertain in the result, 
- Also expensive, so far certainly more than two man-years have been consumed
for this complex, 
- also costly, after finding the error - at an uncertain point in time - all
patches installed afterwards - based on it - would have to be checked, 

There might also be a third group trying to correct all the bugs found in the
first affected version, maybe you'll find a solution - the right one - quickly. 

All in all, i would like to raise awareness of the problem and contribute to
the solution, rather than sticking to the role 'bad guy' - who still finds bugs
- 


Steps to Reproduce:
See: https://bugs.documentfoundation.org/show_bug.cgi?id=111428#c21

it's only one flavour of this problem, you easily get plenty similar once you
raise the complexity in a sheet. 

Actual Results:
cells unintentionally excluded form autocalculate, 

Expected Results:
korrekt results in all cells


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 9ab43aebad67383057d2cc3f754ce2193fa78b4e
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: GL; VCL:
win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108769] [META] DOCX (OOXML) character-related issues

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108769
Bug 108769 depends on bug 99602, which changed state.

Bug 99602 Summary: FILESAVE: subscript in character style not converted into 
docx
https://bugs.documentfoundation.org/show_bug.cgi?id=99602

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129222] + transfer data to new tab

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129222

--- Comment #5 from Todd  ---
Ah Ha!  You are correct!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129242] FILEOPEN: DOCX: borders between cells in table are missing

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129242

Szabolcs Toth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |szabolcs...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119620] [EDITING] Create sheet during active cell editing puts content on newly created sheet

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119620

Oliver Brinzing  changed:

   What|Removed |Added

Summary|Copy a cell and add a new   |[EDITING] Create sheet
   |worksheet copies the cells  |during active cell editing
   |value into the new  |puts content on newly
   |worksheet at random |created sheet
   |position|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129222] + transfer data to new tab

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129222

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Oliver Brinzing  ---
(In reply to Todd from comment #3)
> (In reply to Oliver Brinzing from comment #2)
> > seems to be a duplicate of:
> > 
> > Bug 119620 - Copy a cell and add a new worksheet copies the cells value into
> > the new worksheet at random position
> > 
> > *** This bug has been marked as a duplicate of bug 119620 ***
> 
> Are you sure of that?  The other bug concerns copy and paste.  This one does
> not.  This one is not closing the cell when the + button is pressed.  No
> clipboard involved.

The original bug report is misleading, please have a look at comments:
https://bugs.documentfoundation.org/show_bug.cgi?id=119620#c1
https://bugs.documentfoundation.org/show_bug.cgi?id=119620#c3

and another duplicate:
Bug 128527 - [EDITING] Create sheet during active cell editing puts content on
newly created sheet

*** This bug has been marked as a duplicate of bug 119620 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119620] Copy a cell and add a new worksheet copies the cells value into the new worksheet at random position

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119620

--- Comment #11 from Oliver Brinzing  ---
*** Bug 129222 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129254] when copy and pasting lots of text from a pdf writer freezes

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129254

--- Comment #3 from Elmar  ---
Created attachment 156385
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156385=edit
and more

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129254] when copy and pasting lots of text from a pdf writer freezes

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129254

--- Comment #1 from Elmar  ---
Created attachment 156383
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156383=edit
hopefully helpful info

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129254] when copy and pasting lots of text from a pdf writer freezes

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129254

--- Comment #2 from Elmar  ---
Created attachment 156384
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156384=edit
more info

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129252] Context menus, and regular menu items appear blank when viewed through an OpenGL RDP session to nVidia client, workaround disable OpenGL

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129252

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
Summary|Context menus, and regular  |Context menus, and regular
   |menu items appear blank |menu items appear blank
   |when viewed through an RDP  |when viewed through an
   |session |OpenGL RDP session to
   ||nVidia client, workaround
   ||disable OpenGL
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129254] New: when copy and pasting lots of text from a pdf writer freezes

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129254

Bug ID: 129254
   Summary: when copy and pasting lots of text from a pdf writer
freezes
   Product: LibreOffice
   Version: 6.5.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@iafrica.com

Description:
writer freezes after multiple pasting

Steps to Reproduce:
1. create new document
2. open pdf
3. select chunks of text (no pictures)
4. paste unformatted text
5. repeat 3-4 >10x

Actual Results:
Writer freezes
on kill and restart, opens doc's again but loses everything since last autosave

Expected Results:
should not freeze

Have been using 
Version: 6.0.7.3
Build ID: 1:6.0.7-0ubuntu0.18.04.10
as alternative, and no freeze after 13pages of copying


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
Version: 6.5.0.0.alpha0+
Build ID: 508dce40f8fda55767b9f78251725e225db2bd2f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-11-26_21:16:48
Locale: en-GB (en_ZA.UTF-8); UI-Language: en-GB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129252] Context menus, and regular menu items appear blank when viewed through an RDP session

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129252

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from V Stuart Foote  ---
OP replied in PM


Turning off the the Use OpenGL for all rendering setting worked fine.  It
turned on the Use Hardware Acceleration, but the menus do work properly.  I'm
glad it's not a serious problem.  

So, I am sure you can close it.  but I am including the MSinfo32 info you
requested.  

David Figueroa

Through RDP:
Name NVIDIA GeForce GTX 750 Ti
PNP Device ID PCI\VEN_10DE_1380_37533842_A2\4&3834D97&0&0008
Adapter Type GeForce GTX 750 Ti, NVIDIA compatible
Adapter Description NVIDIA GeForce GTX 750 Ti
Adapter RAM (2,147,483,648) bytes
Installed Drivers
C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll
Driver Version 26.21.14.3200
INF File oem36.inf (Section050 section)
Color Planes Not Available
Color Table Entries 4294967296
Resolution 1920 x 1080 x 24 hertz
Bits/Pixel 32
Memory Address 0xF600-0xF6FF
Memory Address 0xE000-0xEFFF
Memory Address 0xF000-0xF1FF
I/O Port 0xE000-0xE07F
IRQ Channel IRQ 16
I/O Port 0x03B0-0x03BB
I/O Port 0x03C0-0x03DF
Memory Address 0xA-0xB
Driver
C:\WINDOWS\SYSTEM32\DRIVERSTORE\FILEREPOSITORY\NV_DISPI.INF_AMD64_DB678424D2641C3D\NVLDDMKM.SYS
(26.21.14.3200, 21.07 MB (22,094,728 bytes), 11/5/2019 6:30 PM)

Name Microsoft Remote Display Adapter
PNP Device ID SWD\REMOTEDISPLAYENUM\RDPIDD_INDIRECTDISPLAY_0001
Adapter Type Not Available, Microsoft compatible
Adapter Description Microsoft Remote Display Adapter
Adapter RAM Not Available
Installed Drivers Not Available
Driver Version 10.0.18362.329
INF File rdpidd.inf (RdpIdd_Install.NT section)
Color Planes Not Available
Color Table Entries 4294967296
Resolution 1920 x 1080 x 32 hertz
Bits/Pixel 32
Driver C:\WINDOWS\SYSTEM32\DRIVERS\WUDFRD.SYS (10.0.18362.1, 291.00 KB (297,984
bytes), 3/18/2019 10:44 PM)

>From Splashtop/Local:
Name NVIDIA GeForce GTX 750 Ti
PNP Device ID PCI\VEN_10DE_1380_37533842_A2\4&3834D97&0&0008
Adapter Type GeForce GTX 750 Ti, NVIDIA compatible
Adapter Description NVIDIA GeForce GTX 750 Ti
Adapter RAM (2,147,483,648) bytes
Installed Drivers
C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_db678424d2641c3d\nvldumdx.dll
Driver Version 26.21.14.3200
INF File oem36.inf (Section050 section)
Color Planes Not Available
Color Table Entries 4294967296
Resolution 1920 x 1080 x 24 hertz
Bits/Pixel 32
Memory Address 0xF600-0xF6FF
Memory Address 0xE000-0xEFFF
Memory Address 0xF000-0xF1FF
I/O Port 0xE000-0xE07F
IRQ Channel IRQ 16
I/O Port 0x03B0-0x03BB
I/O Port 0x03C0-0x03DF
Memory Address 0xA-0xB
Driver
C:\WINDOWS\SYSTEM32\DRIVERSTORE\FILEREPOSITORY\NV_DISPI.INF_AMD64_DB678424D2641C3D\NVLDDMKM.SYS
(26.21.14.3200, 21.07 MB (22,094,728 bytes), 11/5/2019 6:30 PM)


-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129253] New: Sidebar is not displayed in letter wizard dialog

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129253

Bug ID: 129253
   Summary: Sidebar is not displayed in letter wizard dialog
   Product: LibreOffice
   Version: 6.4.0.0.beta1+
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s...@e06.itscom.net

Description:
Left side of the letter wizard dialog is blank. List of steps were shown in the
area in 6.3.3.2.

Steps to Reproduce:
1.Open Writer
2.Select File > Wizards > Letter...

Actual Results:
Letter wizard opens without sidebar.

Expected Results:
List of steps is displayed at the left.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Mac OS X (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129252] Context menus, and regular menu items appear blank when viewed through an RDP session

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129252

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
The text of the Help -> About LibreOffice dialog shows OpenGL rendering is
enabled across the RDP session--that is probably not going to work.

So, while logged on locally at the box, set the rendering to Default GDI --
done from Tools -> Options -> View panel -- and restart LibreOffice.

Then do your remote desktop session to the box and see if issue clears and
menus/dialogs are fully rendered.

Also, could you post the details about the GPU chipset and driver on the
system(s) not rendering their Menus across RDP.  You can copy the msinfo32.exe
content for the Components -> Display panel.  Do it locally and then again when
you have remoted onto the system.  Just clip a PNG, or copy paste is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129252] New: Context menus, and regular menu items appear blank when viewed through an RDP session

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129252

Bug ID: 129252
   Summary: Context menus, and regular menu items appear blank
when viewed through an RDP session
   Product: LibreOffice
   Version: 6.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.figue...@protonmail.com

Created attachment 156382
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156382=edit
LibreWriter document with screenshots of the bug under various scenarios

Libre Office v6.3.2.2
Windows 10

Affects all of the apps in LibreOffice.

When I connect to a system with RDP and right-click or select a menu, the menu
frame appears, but it is flat gray.  The options are not visible. 

Reproduction:
1. Launch Writer/Calc,etc. through an RDP session - running it locally on the
machine works properly every time. 
2. Select a menu, or right click to get a context menu
3. The menu frame appears and is empty

Should happen:
The menu should be populated. The hotkeys work, so the menu items are there,
just not visible.  When running the LibreOffice applications locally on that
same system, the menus work exactly as expected.  It only has an issue through
RDP.

This affects all users, and since it works completely correctly locally on the
system, it is not a corruption in the profile.
According to the OpenGL report, it is using the software renderer (from what I
can tell).  The video card in the system is an Nvidia GTX 750 Ti with the
NVidia drivers.  

Report:
Renderer: GDI Generic
Vendor: Microsoft Corporation
Version: 1.1.0
Shading language version: N/A

Max texture size: 1024 x 1024
Max texture coordinates: 0
Max vertex texture image units: 0
Max texture image units: 0
Max geometry texture units: 0
Max anisotropic filtering value: 0
Max number of light sources: 8
Max viewport size: 16384 x 16384
Max uniform vertex components: 0
Max uniform fragment components: 0
Max geometry uniform components: 0
Max varying vectors: 0
Max samples: 0
Max draw buffers: 0


GL Extensions: 3


GL_WIN_swap_hint
GL_EXT_paletted_texture
GL_EXT_bgra
Core features
v1.2 (7 % - 1/14)v1.3 (0 % - 0/9)v1.4 (0 % - 0/15)v1.5 (0 % - 0/3)v2.0 (0 % -
0/10)v2.1 (0 % - 0/3)v3.0 (0 % - 0/23)v3.1 (0 % - 0/7)v3.2 (0 % - 0/10)v3.3 (0
% - 0/10)v4.0 (0 % - 0/14)v4.1 (0 % - 0/7)v4.2 (0 % - 0/13)v4.3 (0 % -
0/20)v4.4 (0 % - 0/10)v4.5 (0 % - 0/11)v4.6 (0 % - 0/11)vARB 2015 (0 % -
0/12)OpenGL driver version check (Current: 0, Latest known: ):
Latest version of display drivers found
According the database, you are running the latest display drivers for your
video card.
No multitexturing support
This may cause performance loss in some applications.
No secondary color support
Some applications may not render polygon highlights correctly.
No S3TC compression support
This may cause performance loss in some applications.
No texture edge clamp support
This feature adds clamping control to edge texel filtering. Some programs may
not render textures correctly (black line on borders.)
No vertex program support
This feature enables vertex programming (equivalent to DX8 Vertex Shader.) Some
current or future OpenGL programs may require this feature.
No fragment program support
This feature enables per pixel programming (equivalent to DX9 Pixel Shader.)
Some current or future OpenGL programs may require this feature.
No OpenGL Shading Language support
This may break compatibility for applications using per pixel shading.
No Frame buffer object support
This may break compatibility for applications using render to texture
functions.
Few texture units found
This may slow down some applications using fragment programs or extensive
texture mapping.
Extension verification: 
GL_EXT_color_subtable was not found, but has the entry point glColorSubTableEXT

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126755] [Font Features dialog]Show predefined OpenType tags

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126755

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127022] menu bar is broken in RTL interface on Windows

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127022

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125760] UI: Notes View: Currently selected / opened slide is not visible during edit

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125760

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122612] loolwsd taking all RAM / killing server, regardless of loolwsd.xml:config/memproportion

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122612

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127009] "Selection" property is empty when selecting a slide in Slides pane

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127009

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128743] Disturbing Background Start Center Image with GTK3 Backend

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128743

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128281] Labels in Installer are cut off when using 200% scaling, 6.2.x is fine

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128281

--- Comment #18 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128281] Labels in Installer are cut off when using 200% scaling, 6.2.x is fine

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128281

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109362] [META] Custom/object animation bugs and enhancements

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109362
Bug 109362 depends on bug 124685, which changed state.

Bug 124685 Summary: [6.2.2.2/Win64] SLIDESHOW Libreoffice Impress custom 
animation skips frames with OpenGL disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=124685

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128954] Multiple instances of global menu entries

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128954

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128473] Emoji Not Visible in PDF Exported File

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128473

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128917] LO segfaults in libpdfiumlo.so on CIFS mount, under certain conditions

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128917

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126565] Import XML data in a new sheet does not work

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126565

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128473] Emoji Not Visible in PDF Exported File

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128473

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128743] Disturbing Background Start Center Image with GTK3 Backend

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128743

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126565] Import XML data in a new sheet does not work

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126565

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113893] FILESAVE Saving + loading with copied content produces unexpected newlines

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113893

--- Comment #9 from QA Administrators  ---
Dear Walter,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113510] [META] Bugs that cause CPU to run at 100%

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113510
Bug 113510 depends on bug 124622, which changed state.

Bug 124622 Summary: opening a file causes soffice.bin to use 100% CPU (one 
core), doing lstat calls all over the user's home dir, if profile exists
https://bugs.documentfoundation.org/show_bug.cgi?id=124622

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125813] Copia e incolla difficoltoso

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125813

--- Comment #3 from QA Administrators  ---
Dear silvanoverducci,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124685] [6.2.2.2/Win64] SLIDESHOW Libreoffice Impress custom animation skips frames with OpenGL disabled

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124685

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125152] Crash in: basctllo.dll

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125152

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125152] Crash in: basctllo.dll

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125152

--- Comment #5 from QA Administrators  ---
Dear georg.weickelt,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124685] [6.2.2.2/Win64] SLIDESHOW Libreoffice Impress custom animation skips frames with OpenGL disabled

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124685

--- Comment #7 from QA Administrators  ---
Dear fred4u,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114457] MacOS: OfaTreeOptionsDialog::LoadNodes(Module*, rtl::OUString const&) is leaking a bit

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114457

--- Comment #13 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124622] opening a file causes soffice.bin to use 100% CPU (one core), doing lstat calls all over the user's home dir, if profile exists

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124622

--- Comment #7 from QA Administrators  ---
Dear Pas,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113893] FILESAVE Saving + loading with copied content produces unexpected newlines

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113893

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124622] opening a file causes soffice.bin to use 100% CPU (one core), doing lstat calls all over the user's home dir, if profile exists

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124622

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104633] Image doesn't retain dimensions after a copy and paste

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104633

--- Comment #11 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112059] Events fired by subform changed, when form is write-protected

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112059

--- Comment #9 from QA Administrators  ---
Dear Robert Großkopf,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37903] EDITING: Moving object using ALT - cursor keys also moves the object behind it

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37903

--- Comment #17 from QA Administrators  ---
Dear gleppert,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96971] SetXORMode - mac requires apparently un-needed parameter ...

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96971

--- Comment #14 from QA Administrators  ---
Dear Michael Meeks,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107839] BeforeUpdating and AfterUpdating events are not firing when records are edited in a Table Control

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107839

--- Comment #11 from QA Administrators  ---
Dear Howard Johnson,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94512] SIDEBAR collapses when previewing a document

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94512

--- Comment #8 from QA Administrators  ---
Dear Jean-Francois Nifenecker,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94319] Copy/Paste of lines (and grouped object with lines inside) places the copy in unpredictable location

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94319

--- Comment #36 from QA Administrators  ---
Dear MarjaE,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118233] ReportBuilder: filter setting function inconsistent in use of aliases when report based on nested query

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118233

--- Comment #8 from QA Administrators  ---
Dear Gerhard Schaber,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95446] After image is deleted, view is not scrolled and caret is misplaced

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95446

--- Comment #7 from QA Administrators  ---
Dear rbruenner,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119431] External database jdbc hsqldb, Crash in the case of SELECT, SQL query, access to the database

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119431

--- Comment #26 from QA Administrators  ---
Dear Krzysztof,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120310] Ambiguous error message returned when attempting to use certain special characters in field names

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120310

--- Comment #14 from QA Administrators  ---
Dear elflng.libreoffice,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121711] FILEOPEN: LibreOffice apparently executes embedded website code

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121711

--- Comment #9 from QA Administrators  ---
Dear Yan,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121727] slow spellchecking area calculation make document appear to hang

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121727

--- Comment #15 from QA Administrators  ---
Dear LFlo,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121924] FILEOPEN PPTX custom geometry identifiers vc and hc are not rendered correctly

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121924

--- Comment #2 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121922] FILEOPEN PPTX Stroke of multi-path shape is drawn different

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121922

--- Comment #2 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126248

Kevin Suo  changed:

   What|Removed |Added

Summary|Asian Font is Wrongly   |Calc 6.3: Asian Font is
   |Applied to Western Text |Wrongly Applied to Western
   ||Text

--- Comment #6 from Kevin Suo  ---
This is a disaster. We are not able to work in Calc with Simplified Chinese
locale with the 6.3+ version. Could someone investigate? I can help to debug on
master with a debug build if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/mmeeks/fixing' - 75 commits - common/Common.hpp common/IoUtil.cpp common/LOOLWebSocket.hpp common/Session.cpp common/Session.hpp common/Util.cpp commo

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 2e372b70b32d4e052458547daa229c537442774f
Author: Michael Meeks 
AuthorDate: Thu Apr 6 17:58:41 2017 +0100
Commit: Michael Meeks 
CommitDate: Thu Apr 6 17:58:41 2017 +0100

Let the DocBroker thread clean itself up and expire.

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index a5a995dfd..0ee997389 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -241,6 +241,18 @@ void DocumentBroker::pollThread()
 LOG_INF("No more sessions in doc [" << _docKey << "]. 
Terminating.");
 _stop = true;
 }
+
+// Remove idle documents after 1 hour.
+const bool idle = getIdleTimeSecs() >= 3600;
+
+// Cleanup used and dead entries.
+if ((isLoaded() || _markToDestroy) &&
+(getSessionsCount() == 0 || !isAlive() || idle))
+{
+LOG_INF("Terminating " << (idle ? "idle" : "dead") <<
+" DocumentBroker for docKey [" << getDocKey() << "].");
+_stop = true;
+}
 }
 
 LOG_INF("Finished polling doc [" << _docKey << "]. stop: " << _stop << ", 
continuePolling: " <<
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index d05437e9c..fd8d20e80 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -304,7 +304,7 @@ public:
 void handleTileCombinedResponse(const std::vector& payload);
 
 void destroyIfLastEditor(const std::string& id);
-bool isMarkedToDestroy() const { return _markToDestroy; }
+bool isMarkedToDestroy() const { return _markToDestroy || _stop; }
 
 bool handleInput(const std::vector& payload);
 
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index e5d4cb689..439ab67ed 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -235,33 +235,15 @@ void cleanupDocBrokers()
 {
 auto docBroker = it->second;
 
-// If document busy at the moment, cleanup later.
-auto lock = docBroker->getDeferredLock();
-if (lock.try_lock())
+// Remove only when not alive.
+if (!docBroker->isAlive())
 {
-// Remove idle documents after 1 hour.
-const bool idle = (docBroker->getIdleTimeSecs() >= 3600);
-
-// Cleanup used and dead entries.
-if ((docBroker->isLoaded() || docBroker->isMarkedToDestroy()) &&
-(docBroker->getSessionsCount() == 0 || !docBroker->isAlive() 
|| idle))
-{
-LOG_INF("Terminating " << (idle ? "idle" : "dead") <<
-" DocumentBroker for docKey [" << it->first << "].");
-docBroker->stop();
-
-// Remove only when not alive.
-if (!docBroker->isAlive())
-{
-LOG_INF("Removing " << (idle ? "idle" : "dead") <<
-" DocumentBroker for docKey [" << it->first << 
"].");
-it = DocBrokers.erase(it);
-continue;
-}
-}
+LOG_INF("Removing DocumentBroker for docKey [" << it->first << 
"].");
+it = DocBrokers.erase(it);
+continue;
+} else {
+++it;
 }
-
-++it;
 }
 
 if (count != DocBrokers.size())
commit fb4fbdd575d6971c92a5222da1fe245f5791bd78
Author: Jan Holesovsky 
AuthorDate: Tue Apr 4 19:54:08 2017 +0200
Commit: Michael Meeks 
CommitDate: Thu Apr 6 16:58:42 2017 +0100

Disable the unreliable unit tests.

Change-Id: I1de9cc566b1b88563152aa36a5505867e46ea2af

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 59dadfaa9..128f559dd 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -61,7 +61,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testImpressTiles);
 CPPUNIT_TEST(testClientPartImpress);
 CPPUNIT_TEST(testClientPartCalc);
-CPPUNIT_TEST(testTilesRenderedJustOnce);
+// FIXME CPPUNIT_TEST(testTilesRenderedJustOnce);
 // CPPUNIT_TEST(testTilesRenderedJustOnceMultiClient); // always fails, 
seems complicated to fix
 #if ENABLE_DEBUG
 CPPUNIT_TEST(testSimultaneousTilesRenderedJustOnce);
diff --git a/test/httpcrashtest.cpp b/test/httpcrashtest.cpp
index b6230d5a6..deeed9907 100644
--- a/test/httpcrashtest.cpp
+++ b/test/httpcrashtest.cpp
@@ -56,7 +56,7 @@ class HTTPCrashTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST_SUITE(HTTPCrashTest);
 
 CPPUNIT_TEST(testBarren);
-CPPUNIT_TEST(testCrashKit);
+// FIXME CPPUNIT_TEST(testCrashKit);
 CPPUNIT_TEST(testRecoverAfterKitCrash);
 CPPUNIT_TEST(testCrashForkit);
 
diff --git a/test/httpwserror.cpp b/test/httpwserror.cpp
index d658905db..254b2982c 100644
--- a/test/httpwserror.cpp
+++ b/test/httpwserror.cpp
@@ -37,7 +37,7 @@ class HTTPWSError : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST_SUITE(HTTPWSError);
 
 CPPUNIT_TEST(testBadDocLoadFail);
-

[Libreoffice-commits] online.git: Branch 'feature/lifecycle' - 18 commits - loleaflet/README loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/configure.ac loolwsd/.gitignore loo

2019-12-06 Thread Ashod Nakashian (via logerrit)
Rebased ref, commits from common ancestor:
commit ff1bb35b6a99155e9ea58853d7c7c3dc5acc9031
Author: Ashod Nakashian 
AuthorDate: Wed Dec 23 09:56:46 2015 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Dec 23 09:56:46 2015 -0500

loolwsd: fixes to loolmap

Change-Id: I58ce3dbbd6bbd1e3eb860ba6c3044ba4a61e281d

diff --git a/loolwsd/loolmap.c b/loolwsd/loolmap.c
index 08b149a2a..21792b9d8 100644
--- a/loolwsd/loolmap.c
+++ b/loolwsd/loolmap.c
@@ -1,6 +1,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -120,15 +121,15 @@ static void total_smaps(unsigned proc_id, const char 
*file, const char *cmdline)
 error(EXIT_FAILURE, errno, "%s\n", cmdline);
 
   printf("%s\n", cmdline);
-  printf("Process ID:%20ld\n", proc_id);
+  printf("Process ID:%20d\n", proc_id);
   printf("--\n");
-  printf("Shared Clean  :%20ld kB\n", total_shared_clean);
-  printf("Shared Dirty  :%20ld kB\n", total_shared_dirty);
-  printf("Private Clean :%20ld kB\n", total_private_clean);
-  printf("Private Dirty :%20ld kB\n", total_private_dirty);
+  printf("Shared Clean  :%20lld kB\n", total_shared_clean);
+  printf("Shared Dirty  :%20lld kB\n", total_shared_dirty);
+  printf("Private Clean :%20lld kB\n", total_private_clean);
+  printf("Private Dirty :%20lld kB\n", total_private_dirty);
   printf("--\n");
-  printf("Shared:%20ld kB\n", total_shared_clean + total_shared_dirty);
-  printf("Private   :%20ld kB\n\n", total_private_clean + 
total_private_dirty);
+  printf("Shared:%20lld kB\n", total_shared_clean + 
total_shared_dirty);
+  printf("Private   :%20lld kB\n\n", total_private_clean + 
total_private_dirty);
 }
 
 int main(int argc, char **argv)
@@ -145,7 +146,7 @@ int main(int argc, char **argv)
   getopt(argc, argv, "");
 
   if (argc != 2)
-error(EXIT_FAILURE, EINVAL);
+error(EXIT_FAILURE, EINVAL, "incorrect arguments");
 
   root_proc = opendir("/proc");
   if (!root_proc)
@@ -154,7 +155,7 @@ int main(int argc, char **argv)
   while ( ( dir_proc = readdir(root_proc) ) )
   {
 if ( !dir_proc && !dir_proc->d_name )
-  error(EXIT_FAILURE, ENOTDIR );
+  error(EXIT_FAILURE, ENOTDIR, "bad dir");
 
 if ( *dir_proc->d_name > '0' && *dir_proc->d_name <= '9' )
 {
@@ -165,13 +166,15 @@ int main(int argc, char **argv)
   !strstr(cmdline, argv[0]) )
   {
 snprintf(path_proc, sizeof(path_proc), "/proc/%s/%s", 
dir_proc->d_name, "smaps");
-total_smaps(pid_proc, path_proc, cmdline);
-  }
+ total_smaps(pid_proc, path_proc, cmdline);
+   }
 }
   }
 
   if ( errno )
-error(EXIT_FAILURE, errno);
+error(EXIT_FAILURE, errno, "fail");
 
   return EXIT_SUCCESS;
 }
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 48b1aa328f469514319c9d41e1360c76120b7d2c
Author: Henry Castro 
AuthorDate: Wed Dec 23 09:55:56 2015 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Dec 23 09:55:56 2015 -0500

loolwsd: merged loolmap

Change-Id: I43845ce5f45c01a67db32ab136ad96b70bc31217

diff --git a/loolwsd/.gitignore b/loolwsd/.gitignore
index 1461eea5d..a50e3e6a4 100644
--- a/loolwsd/.gitignore
+++ b/loolwsd/.gitignore
@@ -13,6 +13,7 @@
 /config.log
 /config.status
 /configure
+/compile
 /depcomp
 /install-sh
 /missing
@@ -20,6 +21,7 @@
 /systemplate
 /test-driver
 /jails
+/loolwsd.spec
 
 *.o
 *.exe
@@ -33,6 +35,7 @@ loadtest
 loolwsd
 loolkit
 loolbroker
+loolmap
 sockettransporttest
 
 # Debug output
diff --git a/loolwsd/Makefile.am b/loolwsd/Makefile.am
index d1f76cbc2..02fe17601 100644
--- a/loolwsd/Makefile.am
+++ b/loolwsd/Makefile.am
@@ -1,6 +1,6 @@
 SUBDIRS = test
 
-bin_PROGRAMS = loolwsd loolbroker loolkit
+bin_PROGRAMS = loolwsd loolbroker loolkit loolmap
 
 dist_bin_SCRIPTS = loolwsd-systemplate-setup
 
@@ -25,6 +25,8 @@ loolkit_SOURCES = LOOLKit.cpp $(broker_shared_sources)
 
 loolbroker_SOURCES = LOOLBroker.cpp $(broker_shared_sources)
 
+loolmap_SOURCES = loolmap.c
+
 noinst_HEADERS = LOKitHelper.hpp LOOLProtocol.hpp LOOLSession.hpp 
MasterProcessSession.hpp ChildProcessSession.hpp LOOLWSD.hpp LoadTest.hpp 
MessageQueue.hpp TileCache.hpp Util.hpp Png.hpp \
  bundled/include/LibreOfficeKit/LibreOfficeKit.h 
bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h \
  bundled/include/LibreOfficeKit/LibreOfficeKitInit.h 
bundled/include/LibreOfficeKit/LibreOfficeKitTypes.h
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index dce87dcb7..fe58ce892 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -13,6 +13,7 @@ AC_CONFIG_HEADERS([config.h])
 
 # Checks for programs.
 AC_PROG_CXX
+AC_PROG_CC
 
 AC_LANG_PUSH([C++])
 
diff --git a/loolwsd/loolmap.c b/loolwsd/loolmap.c
new file mode 100644
index 0..08b149a2a
--- /dev/null
+++ b/loolwsd/loolmap.c
@@ -0,0 +1,177 @@
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 

[Libreoffice-commits] online.git: Branch 'feature/lok_dialog' - 113 commits - bundled/include common/Crypto.cpp common/Crypto.hpp common/Message.hpp common/Seccomp.cpp common/Session.cpp common/Sessio

2019-12-06 Thread Pranav Kant (via logerrit)
Rebased ref, commits from common ancestor:
commit d7c81cf7c807bb4e2624a02bd304cb75a1924e78
Author: Pranav Kant 
AuthorDate: Wed Oct 25 00:10:45 2017 -0700
Commit: Pranav Kant 
CommitDate: Wed Oct 25 00:23:03 2017 -0700

factor out more code

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 34bcb5672..e19f33528 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -223,11 +223,11 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
 }
 else if (tokens[0] == "dialog")
 {
-return sendDialog(buffer, length, tokens, docBroker);
+return sendDialog(buffer, length, tokens, docBroker, false);
 }
 else if (tokens[0] == "dialogchild")
 {
-return sendDialogChild(buffer, length, tokens, docBroker);
+return sendDialog(buffer, length, tokens, docBroker, true);
 }
 else if (tokens[0] == "tilecombine")
 {
@@ -436,32 +436,20 @@ bool ClientSession::sendTile(const char * /*buffer*/, int 
/*length*/, const std:
 }
 
 bool ClientSession::sendDialog(const char * /*buffer*/, int /*length*/, const 
std::vector& tokens,
-   const std::shared_ptr& 
docBroker)
+   const std::shared_ptr& 
docBroker, bool child)
 {
+const std::string dialogCmd = child ? "dialogchild" : "dialog";
 try
 {
-docBroker->handleDialogRequest(tokens[1], shared_from_this());
-}
-catch (const std::exception& exc)
-{
-LOG_ERR("Failed to process dialog command: " << exc.what());
-return sendTextFrame("error: cmd=dialog kind=invalid");
-}
-
-return true;
-}
-
-bool ClientSession::sendDialogChild(const char * /*buffer*/, int /*length*/, 
const std::vector& tokens,
-const std::shared_ptr& 
docBroker)
-{
-try
-{
-docBroker->handleDialogChildRequest(tokens[1], shared_from_this());
+if (child)
+docBroker->handleDialogRequest(tokens[1], shared_from_this(), 
true);
+else
+docBroker->handleDialogRequest(tokens[1], shared_from_this(), 
false);
 }
 catch (const std::exception& exc)
 {
-LOG_ERR("Failed to process dialogchild command: " << exc.what());
-return sendTextFrame("error: cmd=dialogchild kind=invalid");
+LOG_ERR("Failed to process " + dialogCmd + " command: " << exc.what());
+return sendTextFrame("error: cmd=" + dialogCmd + " kind=invalid");
 }
 
 return true;
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 48ea303b2..b16fe448b 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -125,9 +125,7 @@ private:
 bool sendTile(const char* buffer, int length, const 
std::vector& tokens,
   const std::shared_ptr& docBroker);
 bool sendDialog(const char* buffer, int length, const 
std::vector& tokens,
-const std::shared_ptr& docBroker);
-bool sendDialogChild(const char* buffer, int length, const 
std::vector& tokens,
- const std::shared_ptr& docBroker);
+const std::shared_ptr& docBroker, bool 
child);
 bool sendCombinedTiles(const char* buffer, int length, const 
std::vector& tokens,
const std::shared_ptr& docBroker);
 
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 56a8c5a49..76255287e 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1077,11 +1077,11 @@ bool DocumentBroker::handleInput(const 
std::vector& payload)
 }
 else if (command == "dialogpaint:")
 {
-handleDialogPaintResponse(payload);
+handleDialogPaintResponse(payload, false);
 }
 else if (command == "dialogchildpaint:")
 {
-handleDialogChildPaintResponse(payload);
+handleDialogPaintResponse(payload, true);
 }
 else if (command == "errortoall:")
 {
@@ -1175,25 +1175,14 @@ void DocumentBroker::handleTileRequest(TileDesc& tile,
 }
 
 void DocumentBroker::handleDialogRequest(const std::string& dialogId,
- const std::shared_ptr& 
/*session*/)
+ const std::shared_ptr& 
/*session*/,
+ bool child)
 {
 assertCorrectThread();
 std::unique_lock lock(_mutex);
-
-LOG_DBG("Sending dialog render request for dialog " << dialogId);
-const std::string request = "dialog " + dialogId;
-_childProcess->sendTextFrame(request);
-}
-
-void DocumentBroker::handleDialogChildRequest(const std::string& dialogId,
-  const 
std::shared_ptr& /*session*/)
-{
-assertCorrectThread();
-std::unique_lock lock(_mutex);
-
-LOG_DBG("Sending dialog child render request for dialog " << dialogId);
-const std::string request = "dialogchild " + dialogId;
-

[Libreoffice-commits] online.git: Branch 'private/mmeeks/thread-png' - 21 commits - bundled/include common/Log.cpp common/Log.hpp common/Png.hpp common/Util.cpp configure.ac gtk/README ios/Mobile.xcod

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 629b69b4d606d0402fd58a3ecc427c6548ee6227
Author: Michael Meeks 
AuthorDate: Sat Apr 20 01:53:12 2019 +0100
Commit: Michael Meeks 
CommitDate: Fri Apr 26 19:59:31 2019 +0100

PNG compression - thread it.

Change-Id: I238fe6701a1d1cb486473c67faba8c56e9c98dcb

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 25050e04b..6b66449b4 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -737,6 +737,101 @@ private:
 static FILE* ProcSMapsFile = nullptr;
 #endif
 
+class ThreadPool {
+std::mutex _mutex;
+std::condition_variable _cond;
+std::condition_variable _complete;
+typedef std::function ThreadFn;
+std::queue _work;
+std::vector _threads;
+size_t _working;
+std::atomic _exit;
+public:
+ThreadPool()
+: _working(0),
+  _exit(false)
+{
+int maxConcurrency = 2;
+#if MOBILEAPP
+#  warning "Good defaults ? - 2 for iOS, 4 for Android ?"
+#else
+const char *max = getenv("MAX_CONCURRENCY");
+if (max)
+maxConcurrency = atoi(max);
+#endif
+LOG_TRC("PNG compression thread pool size " << maxConcurrency);
+for (int i = 1; i < maxConcurrency; ++i)
+_threads.push_back(std::thread(::work, this));
+}
+~ThreadPool()
+{
+assert(_working == 0);
+_exit = true;
+_cond.notify_all();
+for (auto  : _threads)
+it.join();
+}
+
+size_t count() const
+{
+return _work.size();
+}
+
+void pushWorkUnlocked(const ThreadFn )
+{
+_work.push(fn);
+}
+
+void runOne(std::unique_lock< std::mutex >& lock)
+{
+assert(!_work.empty());
+
+ThreadFn fn = _work.front();
+_work.pop();
+_working++;
+lock.unlock();
+
+try {
+fn();
+} catch (...)
+{
+LOG_ERR("Exception during worker fn execution");
+}
+
+lock.lock();
+_working--;
+if (_work.empty() && _working == 0)
+_complete.notify_all();
+}
+
+void run()
+{
+std::unique_lock< std::mutex > lock(_mutex);
+assert(_working == 0);
+
+// Avoid notifying threads if we don't need to.
+bool useThreads = _threads.size() > 1 && _work.size() > 1;
+if (useThreads)
+_cond.notify_all();
+
+while(!_work.empty())
+runOne(lock);
+
+if (useThreads && (_working > 0 || !_work.empty()))
+_complete.wait(lock, [this]() { return _working == 0 && 
_work.empty(); } );
+}
+
+void work()
+{
+std::unique_lock< std::mutex > lock(_mutex);
+while (!_exit)
+{
+_cond.wait(lock, [this]() { return !_work.empty(); });
+runOne(lock);
+}
+}
+};
+
 /// A document container.
 /// Owns LOKitDocument instance and connections.
 /// Manages the lifetime of a document.
@@ -948,6 +1043,14 @@ public:
 renderTiles(tileCombined, true);
 }
 
+static void pushRendered(std::vector ,
+ const TileDesc , TileWireId wireId, size_t 
imgSize)
+{
+renderedTiles.push_back(desc);
+renderedTiles.back().setWireId(wireId);
+renderedTiles.back().setImgSize(imgSize);
+}
+
 void renderTiles(TileCombined , bool combined)
 {
 auto& tiles = tileCombined.getTiles();
@@ -1016,6 +1119,9 @@ public:
 const int pixelWidth = tileCombined.getWidth();
 const int pixelHeight = tileCombined.getHeight();
 
+static ThreadPool pool;
+
+std::vector renderedTiles;
 size_t tileIndex = 0;
 for (Util::Rectangle& tileRect : tileRecs)
 {
@@ -1035,13 +1141,15 @@ public:
 // The tile content is identical to what the client already 
has, so skip it
 LOG_TRC("Match for tile #" << tileIndex << " at (" << 
positionX << "," <<
 positionY << ") oldhash==hash (" << hash << "), 
wireId: " << wireId << " skipping");
-tiles.erase(tiles.begin() + tileIndex);
+tileIndex++;
 continue;
 }
 
-size_t imgSize;
+size_t imgSize = -1;
+if (_pngCache.copyFromCache(hash, output, imgSize))
+pushRendered(renderedTiles, tiles[tileIndex], wireId, imgSize);
 
-if (!_pngCache.copyFromCache(hash, output, imgSize))
+else
 {
 LOG_DBG("PNG cache with hash " << hash << " missed.");
 
@@ -1051,43 +1159,52 @@ public:
 pixelWidth, pixelHeight,
 mode);
 
-PngCache::CacheData data(new std::vector< char >() );
-data->reserve(pixmapWidth * pixmapHeight * 1);
+// Queue to be executed inside 'run'
+
pool.pushWorkUnlocked([=](){
+  

[Libreoffice-commits] online.git: Branch 'private/mmeeks/deltas' - 180 commits - bundled/include common/Crypto.cpp common/Crypto.hpp common/Message.hpp common/Seccomp.cpp common/Session.cpp common/Ses

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 32c630f29ce6e0619de66cfbde3a8f24910f6269
Author: Michael Meeks 
AuthorDate: Mon Oct 23 20:59:10 2017 +0100
Commit: Michael Meeks 
CommitDate: Fri Oct 27 18:30:29 2017 +0100

Deltas - collapse multiple rows to a single row.

Change-Id: Ia2a617c2adbbc4e66b7c773c2280ec609aead16e

diff --git a/kit/Delta.hpp b/kit/Delta.hpp
index 82f871bbf..e1890370c 100644
--- a/kit/Delta.hpp
+++ b/kit/Delta.hpp
@@ -64,6 +64,7 @@ class DeltaGenerator {
 
 // How do the rows look against each other ?
 size_t lastMatchOffset = 0;
+size_t lastCopy = 0;
 for (int y = 0; y < prev._height; ++y)
 {
 // Life is good where rows match:
@@ -78,12 +79,25 @@ class DeltaGenerator {
 if (prev._rows[match].identical(cur._rows[y]))
 {
 // TODO: if offsets are >256 - use 16bits?
+if (lastCopy > 0)
+{
+char cnt = output[lastCopy];
+if (output[lastCopy + 1] + cnt == (char)(match) &&
+output[lastCopy + 2] + cnt == (char)(y))
+{
+output[lastCopy]++;
+matched = true;
+continue;
+}
+}
 
-// hopefully find blocks of this.
 lastMatchOffset = match - y;
-output.push_back('c'); // copy-row
+output.push_back('c');   // copy-row
+lastCopy = output.size();
+output.push_back(1); // count
 output.push_back(match); // src
-output.push_back(y); // dest
+output.push_back(y); // dest
+
 matched = true;
 continue;
 }
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 23c529a3d..a647eea22 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1306,13 +1306,20 @@ L.TileLayer = L.GridLayer.extend({
 
// FIXME; can we operate directly on the image ?
var imgData = ctx.getImageData(0, 0, canvas.width, 
canvas.height);
-   var oldData = new Uint8ClampedArray(imgData);
+   var oldData = new Uint8ClampedArray(imgData.data);
+
var delta = img;
var pixSize = canvas.width * canvas.height * 4;
var offset = 0;
 
console.log('Applying a delta of length ' + 
delta.length + ' pix size: ' + pixSize + '\nhex: ' + hex2string(delta));
 
+   // Green-tinge the old-Data ...
+// for (var i = 0; i < pixSize; ++i)
+// {
+// oldData[i*4 + 1] = 128;
+// }
+
// wipe to grey.
 // for (var i = 0; i < pixSize * 4; ++i)
 // {
@@ -1325,15 +1332,19 @@ L.TileLayer = L.GridLayer.extend({
switch (delta[i])
{
case 99: // 'c': // copy row
-   var srcRow = delta[i+1];
-   var destRow = delta[i+2]
-   i+= 3;
-   console.log('copy row ' + srcRow + ' to 
' + destRow);
-   var src = srcRow * canvas.width * 4;
-   var dest = destRow * canvas.width * 4;
-   for (var i = 0; i < canvas.width * 4; 
++i)
+   var count = delta[i+1];
+   var srcRow = delta[i+2];
+   var destRow = delta[i+3];
+   i+= 4;
+   console.log('copy ' + count + ' row(s) 
' + srcRow + ' to ' + destRow);
+   for (var cnt = 0; cnt < count; ++cnt)
{
-   imgData.data[dest + i] = 
oldData[src + i];
+   var src = (srcRow + cnt) * 
canvas.width * 4;
+   var dest = (destRow + cnt) * 
canvas.width * 4;
+   for (var j = 0; j < 
canvas.width * 4; ++j)
+   {
+   imgData.data[dest + j] 
= oldData[src + j];
+   }
  

[Libreoffice-commits] online.git: Branch 'private/mmeeks/monitoring' - 78 commits - common/Common.hpp common/Log.cpp common/Seccomp.cpp common/SigUtil.cpp configure.ac debian/control debian/loolwsd.po

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 44e065d01852ac282ab2fdee35f095f3fa73ee26
Author: Michael Meeks 
AuthorDate: Fri May 18 18:32:33 2018 +0100
Commit: Michael Meeks 
CommitDate: Fri May 18 18:32:57 2018 +0100

Remove test monitor.

Change-Id: I55f93ffec68745b194a778b541db1011962f735d

diff --git a/loolwsd.xml.in b/loolwsd.xml.in
index 4937055a3..d4ca9b3ea 100644
--- a/loolwsd.xml.in
+++ b/loolwsd.xml.in
@@ -117,7 +117,6 @@
 
 
 
-   ws://localhost:9042/foo
 
 
 
commit 7475120c81a64c0dc7333b2e929b4832795fa1e8
Author: Michael Meeks 
AuthorDate: Fri May 18 17:35:19 2018 +0100
Commit: Michael Meeks 
CommitDate: Fri May 18 17:35:19 2018 +0100

If a monitor is dis-connected, try to re-connect it.

Change-Id: I04f254acfe823f07e7fb11b277e661c09e146ebd

diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index 0350c714d..723bb22f9 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -445,6 +445,17 @@ void Admin::pollingThread()
 lastNet = now;
 }
 
+// (re)-connect (with sync. DNS - urk) to one monitor at a time
+if (_pendingConnects.size())
+{
+MonitorConnectRecord rec = _pendingConnects[0];
+if (rec._when < now)
+{
+_pendingConnects.erase(_pendingConnects.begin());
+connectToMonitorSync(rec._uri);
+}
+}
+
 // Handle websockets & other work.
 const int timeout = capAndRoundInterval(std::min(std::min(cpuWait, 
memWait), netWait));
 LOG_TRC("Admin poll for " << timeout << "ms.");
@@ -627,11 +638,13 @@ void Admin::dumpState(std::ostream& os)
 class MonitorSocketHandler : public AdminSocketHandler
 {
 bool _connecting;
+std::string _uri;
 public:
 
-MonitorSocketHandler(Admin *admin) :
+MonitorSocketHandler(Admin *admin, const std::string ) :
 AdminSocketHandler(admin),
-_connecting(true)
+_connecting(true),
+_uri(uri)
 {
 }
 int getPollEvents(std::chrono::steady_clock::time_point now,
@@ -652,11 +665,27 @@ public:
 _connecting = false;
 return AdminSocketHandler::performWrites();
 }
+
+void onDisconnect() override
+{
+LOG_WRN("Monitor " << _uri << " dis-connected, re-trying in 20 
seconds");
+Admin::instance().scheduleMonitorConnect(_uri, 
std::chrono::steady_clock::now() + std::chrono::seconds(20));
+}
 };
 
-void Admin::connectToMonitor(const Poco::URI )
+void Admin::connectToMonitorSync(const std::string )
+{
+insertNewWebSocketSync(Poco::URI(uri), 
std::make_shared(this, uri));
+}
+
+void Admin::scheduleMonitorConnect(const std::string , 
std::chrono::steady_clock::time_point when)
 {
-insertNewWebSocketSync(uri, std::make_shared(this));
+assertCorrectThread();
+
+MonitorConnectRecord todo;
+todo._when = when;
+todo._uri = uri;
+_pendingConnects.push_back(todo);
 }
 
 void Admin::start()
@@ -675,7 +704,7 @@ void Admin::start()
 Poco::URI monitor(uri);
 if (monitor.getScheme() == "wss" || monitor.getScheme() == "ws")
 {
-addCallback([=] { connectToMonitor(monitor); } );
+addCallback([=] { scheduleMonitorConnect(uri, 
std::chrono::steady_clock::now()); });
 haveMonitors = true;
 }
 else
diff --git a/wsd/Admin.hpp b/wsd/Admin.hpp
index fbd15f8ac..ed9ca55f8 100644
--- a/wsd/Admin.hpp
+++ b/wsd/Admin.hpp
@@ -116,6 +116,9 @@ public:
 notifyForkit();
 }
 
+/// Attempt a synchronous connection to a monitor with @uri @when that 
future comes
+void scheduleMonitorConnect(const std::string , 
std::chrono::steady_clock::time_point when);
+
 private:
 /// Notify Forkit of changed settings.
 void notifyForkit();
@@ -133,7 +136,7 @@ private:
 }
 
 /// Synchronous connection setup to remote monitoring server
-void connectToMonitor(const Poco::URI );
+void connectToMonitorSync(const std::string );
 
 private:
 /// The model is accessed only during startup & in
@@ -148,6 +151,12 @@ private:
 size_t _totalSysMemKb;
 size_t _totalAvailMemKb;
 
+struct MonitorConnectRecord {
+std::chrono::steady_clock::time_point _when;
+std::string _uri;
+};
+std::vector _pendingConnects;
+
 std::atomic _cpuStatsTaskIntervalMs;
 std::atomic _memStatsTaskIntervalMs;
 std::atomic _netStatsTaskIntervalMs;
commit c5cef26fb6dfa4153e7d7ef16eb3fd366696aebc
Author: Michael Meeks 
AuthorDate: Fri May 18 16:05:36 2018 +0100
Commit: Michael Meeks 
CommitDate: Fri May 18 16:06:03 2018 +0100

Shutdown kit process if connection dies.

Change-Id: I34e627a03a9859ccd3ae9f9925fe6ab080697b72

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index d7f4cc05b..b76dc1094 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2092,6 +2092,12 @@ protected:
 LOG_ERR("Bad or unknown token [" << tokens[0] << "]");

[Libreoffice-commits] online.git: Branch 'private/mmeeks/unitbits' - 262 commits - loleaflet/dist loleaflet/.gitattributes loleaflet/.gitignore loleaflet/loleaflet.spec.in loleaflet/Makefile loleaflet

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit c06a7caf61b69ad2de74b07310570503a17c2400
Author: Michael Meeks 
AuthorDate: Sat Apr 16 20:44:53 2016 +0100
Commit: Michael Meeks 
CommitDate: Sat Apr 16 20:44:53 2016 +0100

Attempt at a --nocaps argument to run with no caps, ie. under valgrind.

diff --git a/loolwsd/LOOLForKit.cpp b/loolwsd/LOOLForKit.cpp
index ffebf5652..4d7ba5f28 100644
--- a/loolwsd/LOOLForKit.cpp
+++ b/loolwsd/LOOLForKit.cpp
@@ -44,6 +44,7 @@ using Poco::Thread;
 using Poco::Timestamp;
 using Poco::Util::Application;
 
+static bool NoCapsForKit = false;
 static std::string UnitTestLibrary;
 static std::atomic ForkCounter( 0 );
 
@@ -117,7 +118,7 @@ static int createLibreOfficeKit(const std::string& 
childRoot,
 Thread::sleep(std::stoul(std::getenv("SLEEPKITFORDEBUGGER")) * 
1000);
 }
 
-lokit_main(childRoot, sysTemplate, loTemplate, loSubPath);
+lokit_main(childRoot, sysTemplate, loTemplate, loSubPath, 
NoCapsForKit);
 }
 else
 {
@@ -213,6 +214,11 @@ int main(int argc, char** argv)
 eq = std::strchr(cmd, '=');
 UnitTestLibrary = std::string(eq+1);
 }
+// we are running in no-privilege mode - with no chroot etc.
+else if (std::strstr(cmd, "--nocaps") == cmd)
+{
+NoCapsForKit = true;
+}
 #endif
 }
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 7f55ec966..1a91bb636 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -847,7 +847,8 @@ namespace {
 void lokit_main(const std::string& childRoot,
 const std::string& sysTemplate,
 const std::string& loTemplate,
-const std::string& loSubPath)
+const std::string& loSubPath,
+bool noCapabilities)
 {
 // Reinitialize logging when forked.
 Log::initialize("kit");
@@ -874,102 +875,112 @@ void lokit_main(const std::string& childRoot,
 Util::setTerminationSignals();
 Util::setFatalSignals();
 
-static const std::string instdir_path = "/" + loSubPath + "/program";
-LibreOfficeKit* loKit = nullptr;
+std::string instdir_path;
 
+Path jailPath;
+bool bRunInsideJail = !noCapabilities;
 try
 {
-const Path jailPath = Path::forDirectory(childRoot + Path::separator() 
+ jailId);
-Log::info("Jail path: " + jailPath.toString());
-File(jailPath).createDirectories();
+if (bRunInsideJail)
+{
+instdir_path = "/" + loSubPath + "/program";
 
-// Create a symlink inside the jailPath so that the absolute pathname 
loTemplate, when
-// interpreted inside a chroot at jailPath, points to loSubPath 
(relative to the chroot).
-symlinkPathToJail(jailPath, loTemplate, loSubPath);
+jailPath = Path::forDirectory(childRoot + Path::separator() + 
jailId);
+Log::info("Jail path: " + jailPath.toString());
+File(jailPath).createDirectories();
 
-// Font paths can end up as realpaths so match that too.
-char *resolved = realpath(loTemplate.c_str(), NULL);
-if (resolved)
-{
-if (strcmp(loTemplate.c_str(), resolved))
-symlinkPathToJail(jailPath, std::string(resolved), loSubPath);
-free (resolved);
-}
+// Create a symlink inside the jailPath so that the absolute 
pathname loTemplate, when
+// interpreted inside a chroot at jailPath, points to loSubPath 
(relative to the chroot).
+symlinkPathToJail(jailPath, loTemplate, loSubPath);
 
-Path jailLOInstallation(jailPath, loSubPath);
-jailLOInstallation.makeDirectory();
-File(jailLOInstallation).createDirectory();
+// Font paths can end up as realpaths so match that too.
+char *resolved = realpath(loTemplate.c_str(), NULL);
+if (resolved)
+{
+if (strcmp(loTemplate.c_str(), resolved))
+symlinkPathToJail(jailPath, std::string(resolved), 
loSubPath);
+free (resolved);
+}
 
-// Copy (link) LO installation and other necessary files into it from 
the template.
-bool bLoopMounted = false;
-if (getenv("LOOL_BIND_MOUNT"))
-{
-Path usrSrcPath(sysTemplate, "usr");
-Path usrDestPath(jailPath, "usr");
-File(usrDestPath).createDirectory();
-std::string mountCommand =
-std::string("loolmount ") +
-usrSrcPath.toString() +
-std::string(" ") +
-usrDestPath.toString();
-Log::debug("Initializing jail bind mount.");
-bLoopMounted = !system(mountCommand.c_str());
-Log::debug("Initialized jail bind mount.");
-}
-linkOrCopy(sysTemplate, jailPath,
-   bLoopMounted ? COPY_NO_USR : COPY_ALL);
-

[Libreoffice-commits] online.git: Branch 'feature/anonymization-cd' - 17 commits - common/Log.cpp common/Log.hpp common/Seccomp.cpp common/Seccomp.hpp common/Session.cpp common/Session.hpp common/Util

2019-12-06 Thread Ashod Nakashian (via logerrit)
Rebased ref, commits from common ancestor:
commit 2b46475ced9d13d257467c559a73fb5f1b4cb58a
Author: Ashod Nakashian 
AuthorDate: Sun Jun 10 22:40:32 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Fri Jun 15 01:18:13 2018 -0400

wsd: anonymize saveas

Change-Id: I58e349781952a97c3251b0e52e26abb34d44e9c0

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 57c1326bb..b273c86f0 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -1127,6 +1127,8 @@ bool ChildSession::saveAs(const char* /*buffer*/, int 
/*length*/, const std::vec
 return false;
 }
 
+const std::string urlAnonym = anonymizeUrl(url);
+
 // if the url is a 'wopi:///something/blah.odt', then save to a temporary
 Poco::URI wopiURL(url);
 if (wopiURL.getScheme() == "wopi")
@@ -1162,13 +1164,13 @@ bool ChildSession::saveAs(const char* /*buffer*/, int 
/*length*/, const std::vec
 
 getLOKitDocument()->setView(_viewId);
 
-LOG_DBG("Calling LOK's saveAs with: '" << url.c_str() << "', '" <<
+LOG_DBG("Calling LOK's saveAs with: '" << urlAnonym << "', '" <<
 (format.size() == 0 ? "(nullptr)" : format.c_str()) << "', '" 
<<
 (filterOptions.size() == 0 ? "(nullptr)" : 
filterOptions.c_str()) << "'.");
 
 success = getLOKitDocument()->saveAs(url.c_str(),
-format.size() == 0 ? nullptr :format.c_str(),
-filterOptions.size() == 0 ? nullptr : filterOptions.c_str());
+ format.empty() ? nullptr : 
format.c_str(),
+ filterOptions.empty() ? nullptr : 
filterOptions.c_str());
 
 if (!success)
 {
diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index f1fe5d79e..422d5a863 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -722,7 +722,6 @@ StorageBase::SaveResult 
WopiStorage::saveLocalFileToStorage(const Authorization&
 
 LOG_INF("Uploading URI via WOPI [" << uriAnonym << "] from [" << 
filePathAnonym + "].");
 
-std::ostringstream oss;
 StorageBase::SaveResult saveResult(StorageBase::SaveResult::FAILED);
 try
 {
@@ -794,13 +793,35 @@ StorageBase::SaveResult 
WopiStorage::saveLocalFileToStorage(const Authorization&
 
 Poco::Net::HTTPResponse response;
 std::istream& rs = psession->receiveResponse(response);
+
+std::ostringstream oss;
 Poco::StreamCopier::copyStream(rs, oss);
+std::string responseString = oss.str();
+
+const std::string wopiLog(isSaveAs ? "WOPI::PutRelativeFile" : 
"WOPI::PutFile");
+
+if (Log::infoEnabled())
+{
+if (LOOLWSD::AnonymizeFilenames)
+{
+Poco::JSON::Object::Ptr object;
+if (parseJSON(responseString, object))
+{
+// Anonymize the filename
+std::string filename;
+getWOPIValue(object, "Name", filename);
+object->set("Name", LOOLWSD::anonymizeUsername(filename));
+// Stringify to log.
+std::ostringstream ossResponse;
+object->stringify(ossResponse);
+responseString = ossResponse.str();
+}
+}
 
-std::string wopiLog(isSaveAs? "WOPI::PutRelativeFile": 
"WOPI::PutFile");
-LOG_INF(wopiLog << " response: " << oss.str());
-LOG_INF(wopiLog << " uploaded " << size << " bytes from [" << 
filePathAnonym <<
-"] -> [" << uriAnonym << "]: " <<
-response.getStatus() << " " << response.getReason());
+LOG_INF(wopiLog << " response: " << responseString);
+LOG_INF(wopiLog << " uploaded " << size << " bytes from [" << 
filePathAnonym <<
+"] -> [" << uriAnonym << "]: " << response.getStatus() << 
" " << response.getReason());
+}
 
 if (response.getStatus() == Poco::Net::HTTPResponse::HTTP_OK)
 {
@@ -815,10 +836,10 @@ StorageBase::SaveResult 
WopiStorage::saveLocalFileToStorage(const Authorization&
 if (isSaveAs)
 {
 const std::string name = getJSONValue(object, 
"Name");
-LOG_TRC(wopiLog << " returns Name [" << name << "].");
+LOG_TRC(wopiLog << " returns Name [" << 
LOOLWSD::anonymizeUrl(name) << "].");
 
 const std::string url = getJSONValue(object, 
"Url");
-LOG_TRC(wopiLog << " returns Url [" << url << "].");
+LOG_TRC(wopiLog << " returns Url [" << 
LOOLWSD::anonymizeUrl(url) << "].");
 
 saveResult.setSaveAsResult(name, url);
 }
commit b8dfb55ba6c76de9916047e2ca46cf58b24ae241
Author: Ashod Nakashian 
AuthorDate: Sun Jun 10 22:30:42 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Fri Jun 15 01:18:13 2018 -0400

wsd: anonymize downloadas


[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - 45 commits - common/FileUtil.cpp common/IoUtil.cpp common/Log.cpp common/MessageQueue.cpp common/Protocol.cpp common/Session.cpp

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 5ad0df4ec9cfa9fdeaa5ab25d6e7cebb6fba61f4
Author: Michael Meeks 
AuthorDate: Fri Mar 10 10:52:33 2017 +
Commit: Michael Meeks 
CommitDate: Fri Mar 10 10:52:33 2017 +

Re-work socket buffer sizing and setting.

Avoid writing more data than can be absorbed by our socket buffer.
It is fine to set socket buffer sizes after bind/accept.

diff --git a/net/Socket.hpp b/net/Socket.hpp
index f1778d00d..89d9b176d 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -39,11 +39,10 @@
 /// A non-blocking, streaming socket.
 class Socket
 {
-// Guestimates; verify, or read from the kernel ?
-static const int MaximumSendBufferSize = 128 * 1024;
-static const int DefaultSendBufferSize = 16 * 1024;
-static const int MinimumSendBufferSize = 4 * 1024;
 public:
+static const int DefaultSendBufferSize = 16 * 1024;
+static const int MaximumSendBufferSize = 128 * 1024;
+
 Socket() :
 _fd(socket(AF_INET, SOCK_STREAM | SOCK_NONBLOCK, 0)),
 _sendBufferSize(DefaultSendBufferSize)
@@ -87,40 +86,55 @@ public:
 (char *) , sizeof(val));
 }
 
-/// Sets the send buffer in size bytes.
-/// Must be called before accept or connect.
+/// Sets the kernel socket send buffer in size bytes.
 /// Note: TCP will allocate twice this size for admin purposes,
 /// so a subsequent call to getSendBufferSize will return
 /// the larger (actual) buffer size, if this succeeds.
 /// Note: the upper limit is set via /proc/sys/net/core/wmem_max,
 /// and there is an unconfigurable lower limit as well.
 /// Returns true on success only.
-bool setSendBufferSize(const int size)
+bool setSocketBufferSize(const int size)
 {
-int rc = ::setsockopt(_fd, SOL_SOCKET, SO_SNDBUF, size, sizeof(size));
-bool success = (rc == 0);
-
-_sendBufferSize = std::min(std::max(size, MinimumSendBufferSize), // 
old guess.
-   MaximumSendBufferSize);
-int readSize = _sendBufferSize;
-const int rc = ::getsockopt(_fd, SOL_SOCKET, SO_SNDBUF, , 
sizeof(size));
-if (rc == 0)
-_sendBufferSize = readSize;
+int rc = ::setsockopt(_fd, SOL_SOCKET, SO_SNDBUF, , sizeof(size));
 
-return success && rc == 0;
+_sendBufferSize = getSocketBufferSize();
+if (rc != 0 || _sendBufferSize < 0 )
+{
+LOG_ERR("Error getting socket buffer size " << errno);
+_sendBufferSize = DefaultSendBufferSize;
+return false;
+}
+else
+{
+if (_sendBufferSize > MaximumSendBufferSize * 2)
+{
+LOG_TRC("Clamped send buffer size to " << 
MaximumSendBufferSize << " from " << _sendBufferSize);
+_sendBufferSize = MaximumSendBufferSize;
+}
+else
+LOG_TRC("Set socket buffer size to " << _sendBufferSize);
+return true;
+}
 }
 
 /// Gets the actual send buffer size in bytes, -1 for failure.
+int getSocketBufferSize() const
+{
+int size;
+unsigned int len = sizeof(size);
+const int rc = ::getsockopt(_fd, SOL_SOCKET, SO_SNDBUF, , );
+return (rc == 0 ? size : -1);
+}
+
+/// Gets our fast cache of the socket buffer size
 int getSendBufferSize() const
 {
 return _sendBufferSize;
-return (rc == 0 ? size : -1);
 }
 
 /// Sets the receive buffer size in bytes.
-/// Must be called before accept or connect.
 /// Note: TCP will allocate twice this size for admin purposes,
-/// so a subsequent call to getSendBufferSize will return
+/// so a subsequent call to getReceieveBufferSize will return
 /// the larger (actual) buffer size, if this succeeds.
 /// Note: the upper limit is set via /proc/sys/net/core/rmem_max,
 /// and there is an unconfigurable lower limit as well.
@@ -196,8 +210,8 @@ protected:
 #if ENABLE_DEBUG
 _owner = std::this_thread::get_id();
 
-const int oldSize = getSendBufferSize();
-setSendBufferSize(0);
+const int oldSize = getSocketBufferSize();
+setSocketBufferSize(0);
 LOG_TRC("Socket #" << _fd << " buffer size: " << getSendBufferSize() 
<< " (was " << oldSize << ")");
 #endif
 
@@ -711,8 +725,9 @@ protected:
 ssize_t len;
 do
 {
-len = writeData(&_outBuffer[0], 
std::max((int)_outBuffer.size(),
- _sendBufferSize));
+// Writing more than we can absorb in the kernel causes SSL 
wasteage.
+len = writeData(&_outBuffer[0], 
std::min((int)_outBuffer.size(),
+ getSendBufferSize()));
 
 auto& log = Log::logger();
 if (log.trace() && len > 0) {
@@ -794,9 

[Libreoffice-commits] online.git: Branch 'private/mmeeks/copypaste' - 11 commits - common/Message.hpp common/Util.cpp common/Util.hpp kit/ChildSession.cpp kit/ChildSession.hpp loleaflet/src net/WebSoc

2019-12-06 Thread Michael Meeks (via logerrit)
Rebased ref, commits from common ancestor:
commit 2d956b4c3719699365630f16efec84e22c9a0cd0
Author: Michael Meeks 
AuthorDate: Wed May 29 13:11:01 2019 +0100
Commit: Michael Meeks 
CommitDate: Wed May 29 15:10:47 2019 +0100

Add pasteresult: message to allow re-try with a different format.

Change-Id: Ia3d7aacdcf2b819437eb2da68a79dd99ed7dca42

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 91a3ad296..f4387d60d 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -997,15 +997,19 @@ bool ChildSession::paste(const char* buffer, int length, 
const std::vector 0)
 {
 std::unique_lock lock(_docManager.getDocumentMutex());
@@ -1013,9 +1017,17 @@ bool ChildSession::paste(const char* buffer, int length, 
const std::vectorsetView(_viewId);
 
 LOG_TRC("Paste data of size " << size << " bytes and hash " << 
SpookyHash::Hash64(data, size, 0));
-if (!getLOKitDocument()->paste(mimeType.c_str(), data, size))
+success = getLOKitDocument()->paste(mimeType.c_str(), data, size);
+if (!success)
 LOG_WRN("Paste failed " << getLOKitLastError());
 }
+if (success)
+result += "success";
+else if (fallback)
+result += "fallback";
+else
+result += "fail";
+sendTextFrame(result);
 
 return true;
 }
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index b9a23067a..71705148a 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -493,6 +493,9 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('editor:')) {
this._updateEditor(textMsg);
}
+   else if (textMsg.startsWith('pasteresult:')) {
+   this._pasteResult(textMsg);
+   }
else if (textMsg.startsWith('validitylistbutton:')) {
this._onValidityListButtonMsg(textMsg);
}
@@ -2493,6 +2496,23 @@ L.TileLayer = L.GridLayer.extend({
return '';
},
 
+   // Sometimes our smart-paste fails & we need to try again.
+   _pasteResult : function(textMsg)
+   {
+   textMsg = textMsg.substring('pasteresult:'.length + 1);
+   console.log('Paste state: ' + textMsg);
+   if (textMsg == 'fallback') {
+   if (this._pasteFallback != null) {
+   console.log('Paste failed- falling back to 
HTML');
+   
this._map._socket.sendMessage(this._pasteFallback);
+   } else {
+   console.log('No paste fallback present.');
+   }
+   }
+
+   this._pasteFallback = null;
+   },
+
_dataTransferToDocument: function (dataTransfer, preferInternal) {
 
// Look for our HTML meta magic.
@@ -2511,6 +2531,9 @@ L.TileLayer = L.GridLayer.extend({
return;
}
 
+   console.log('Resetting paste fallback');
+   this._pasteFallback = null;
+
// Suck HTML content out of dataTransfer now while it feels 
like working.
var content = this._readContentSync(dataTransfer);
 
@@ -2541,10 +2564,12 @@ L.TileLayer = L.GridLayer.extend({
return;
}
 
-   // Try Fetch the data directly ourselves instead.
-   if (meta != '') {
+   if (meta != '') { // in Smart server side paste mode ...
// FIXME: really should short-circuit on the server.
console.log('Doing async paste of data from remote 
origin\n\t"' + meta + '" is not\n\t"' + id + '"');
+
+   this._pasteFallback = content;
+
var tilelayer = this;
var oReq = new XMLHttpRequest();
oReq.onload = function(e) {
@@ -2556,18 +2581,24 @@ L.TileLayer = L.GridLayer.extend({
} else {
console.log('Error code ' + oReq.status 
+ ' fetching from URL "' + meta + '": ' + e + ' falling back to local.');

tilelayer._map._socket.sendMessage(content);
+   this._pasteFallback = null;
}
}
oReq.onerror = function(e) {
console.log('Error fetching from URL "' + meta 
+ '": ' + e + ' falling back to local.');
tilelayer._map._socket.sendMessage(content);
+   this._pasteFallback = null;
};
oReq.open('GET', meta);
oReq.responseType = 'arraybuffer';

[Libreoffice-commits] online.git: Branch 'private/Ashod/repairactions' - 3 commits - loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/ClientSession.cpp loolwsd/protocol.txt loolwsd/test

2019-12-06 Thread Ashod Nakashian (via logerrit)
Rebased ref, commits from common ancestor:
commit abdefeec68a0790f5b8ac567fb2ec2edca29697e
Author: Ashod Nakashian 
AuthorDate: Sun Aug 28 12:26:01 2016 -0400
Commit: Ashod Nakashian 
CommitDate: Sun Aug 28 12:45:12 2016 -0400

loolwsd: getrepairactions unittests added

Change-Id: I8df51d30e127cdfe0311a4e730de5d40bdd657ce

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 423e69825..56756af01 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -88,6 +88,8 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testFontList);
 CPPUNIT_TEST(testStateUnoCommand);
 CPPUNIT_TEST(testColumnRowResize);
+CPPUNIT_TEST(testEmptyRepairActions);
+CPPUNIT_TEST(testRepairActions);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -124,6 +126,8 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testFontList();
 void testStateUnoCommand();
 void testColumnRowResize();
+void testEmptyRepairActions();
+void testRepairActions();
 
 void loadDoc(const std::string& documentURL);
 
@@ -2030,6 +2034,76 @@ void HTTPWSTest::testColumnRowResize()
 }
 }
 
+void HTTPWSTest::testEmptyRepairActions()
+{
+try
+{
+const auto testname = "repairactions ";
+auto socket = loadDocAndGetSocket("hello.odt", _uri, testname);
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "getrepairactions");
+const std::string prefix = "repairactions:";
+const auto response = getResponseMessage(socket, prefix, testname);
+const std::string repairActions(response.data(), response.size());
+CPPUNIT_ASSERT_EQUAL(std::string("repairactions: [{ \"undo\": {\n
\"actions\": \"\"\n}\n}, { \"redo\": {\n\"actions\": \"\"\n}\n}]"), 
repairActions);
+
+const auto jsonString = repairActions.substr(prefix.size());
+
+Poco::JSON::Parser parser;
+const auto result = parser.parse(jsonString);
+const auto& json = result.extract();
+auto redo = json->getObject(0);
+auto redoActions = redo->getArray("actions");
+CPPUNIT_ASSERT(!redoActions);
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
+void HTTPWSTest::testRepairActions()
+{
+try
+{
+const auto testname = "repairactions ";
+auto socket = loadDocAndGetSocket("hello.odt", _uri, testname);
+
+sendTextFrame(socket, "uno .uno:SelectAll");
+sendTextFrame(socket, "uno .uno:Delete");
+
+// Check if the document contains the pasted text.
+sendTextFrame(socket, "getrepairactions");
+const std::string prefix = "repairactions:";
+const auto response = getResponseMessage(socket, prefix, testname);
+const std::string repairActions(response.data(), response.size());
+
+const auto jsonString = repairActions.substr(prefix.size());
+
+Poco::JSON::Parser parser;
+const auto result = parser.parse(jsonString);
+const auto& json = result.extract();
+
+auto undo = json->getObject(0)->get("undo");
+auto subUndo = undo.extract();
+auto undoActionsVar = subUndo->get("actions");
+auto undoActions = undoActionsVar.extract();
+CPPUNIT_ASSERT_MESSAGE("Expected one undo action in the actions 
array.", !!undoActions);
+CPPUNIT_ASSERT_EQUAL(std::size_t(1), undoActions->size());
+CPPUNIT_ASSERT_EQUAL(std::string("Delete 'Hello world'"), 
undoActions->getObject(0)->get("comment").toString());
+
+auto redo = json->getObject(1)->get("redo");
+auto subRedo = redo.extract();
+auto redoActionsVar = subRedo->get("actions");
+CPPUNIT_ASSERT_EQUAL(std::string(), redoActionsVar.toString());
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(HTTPWSTest);
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit f18aebb04e7a0a90e518759c9e48e1251160e376
Author: Ashod Nakashian 
AuthorDate: Sun Aug 28 12:25:40 2016 -0400
Commit: Ashod Nakashian 
CommitDate: Sun Aug 28 12:45:12 2016 -0400

loolwsd: unittest cleanups

Change-Id: Ic383915012ac1c254960d976cc89d3f7c1a2cb02

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index fd7abef80..d24d5e08b 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -82,9 +82,9 @@ std::vector 
readDataFromFile(std::unique_ptr& file)
 }
 
 inline
-void getDocumentPathAndURL(const char* document, std::string& documentPath, 
std::string& documentURL)
+void getDocumentPathAndURL(const std::string& docFilename, std::string& 
documentPath, std::string& documentURL)
 {
-documentPath = Util::getTempFilePath(TDOC, document);
+documentPath = Util::getTempFilePath(TDOC, docFilename);
 documentURL = "lool/ws/file://" + 

[Libreoffice-bugs] [Bug 129219] Further refinement of OpenType/Graphite Font features in the “Character” dialogue

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129219

--- Comment #9 from V Stuart Foote  ---
(In reply to Tobias Hemm from comment #8)
>...
> If you mean the feature "Hidden" from the tab "Font Effects": I don’t care
> what happens to it. I can’t imagine what one would need it for. And it’s
> definitely not needed in the OpenType tab. So I think there will be no "two
> sets", if that’s what you mean, because – as I said – the feature "Small
> capitals" under "Font Effects" is a fake feature anyway. You can keep it
> implemented, but I, personally, wouldn’t use it at all. Typographers don’t
> use it, because it looks ugly. And the feature "All Capitals" can be in
> either tab. It doesn’t matter, where.
>...

Reality is that the vast majority of fonts have limited support for OpenType
(even fewer with Graphite) smart font features.  Meaning the VCL font 'effects'
must remain relevant and viable in LibreOffice ODF document preparation.

And, as implemented we include Graphite/OpenType features into ODF by
annotation of font names recorded to style with the feature to be rendered--so
one might call that a 'fake feature'. But myself, I am happy to now have the
ability to utilize the smart font features with fonts that support them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 129219] Further refinement of OpenType/Graphite Font features in the “Character” dialogue

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129219

--- Comment #9 from V Stuart Foote  ---
(In reply to Tobias Hemm from comment #8)
>...
> If you mean the feature "Hidden" from the tab "Font Effects": I don’t care
> what happens to it. I can’t imagine what one would need it for. And it’s
> definitely not needed in the OpenType tab. So I think there will be no "two
> sets", if that’s what you mean, because – as I said – the feature "Small
> capitals" under "Font Effects" is a fake feature anyway. You can keep it
> implemented, but I, personally, wouldn’t use it at all. Typographers don’t
> use it, because it looks ugly. And the feature "All Capitals" can be in
> either tab. It doesn’t matter, where.
>...

Reality is that the vast majority of fonts have limited support for OpenType
(even fewer with Graphite) smart font features.  Meaning the VCL font 'effects'
must remain relevant and viable in LibreOffice ODF document preparation.

And, as implemented we include Graphite/OpenType features into ODF by
annotation of font names recorded to style with the feature to be rendered--so
one might call that a 'fake feature'. But myself, I am happy to now have the
ability to utilize the smart font features with fonts that support them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126129] Screen-presentation with an Impress project shows only fragment

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126129

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #4 from V Stuart Foote  ---
Looking at the native 4K display in OPs comment 0, likely a dupe of bug 40534
and fixed at 6.4.0 and 6.3.3 builds.

Can verify by disabling Hardware Acceleration in Tools -> Options -> View
panels.

And, as your system supports OpenGL rendering that should render slides as
well.

Also, using HA will work if you reduce the screen resolution, to about 1600 x
900.

If that is true, please close as duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76131] Existing pinned icon on Win7/8 is taskbar invalid after re-installation/update

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76131

V Stuart Foote  changed:

   What|Removed |Added

 CC||cmb...@shaw.ca

--- Comment #38 from V Stuart Foote  ---
*** Bug 129246 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129246] Reinstall or Update wipes out task bar "jump Lists"

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129246

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 76131 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129251] After SAVE AS, document field "file name" retains previous value

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129251

st...@steverumberg.com changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from st...@steverumberg.com ---
Cancel this report -- user error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129251] New: After SAVE AS, document field "file name" retains previous value

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129251

Bug ID: 129251
   Summary: After SAVE AS, document field "file name" retains
previous value
   Product: LibreOffice
   Version: 6.2.6.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: st...@steverumberg.com

Description:
When saving a document with a new name, the document information "File name"
still prints the name of the original file instead of the new filename

Steps to Reproduce:
1. Create a document. Insert > Field > Document > File Name.  
The document filename should display where the field was placed (e.g. in the
footer).

2. Save the document.
3. Open document again and SAVE AS with a new filename.
4. Print (or Preview) the document.  


Actual Results:
The "filename" field shows the ORIGINAL filename


Expected Results:
It should show the NEW filename.



Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.5.2 (x64)
Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129250] Manage changes dialog: (seemingly) useless clickable header for Action column

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129250

--- Comment #1 from Ming Hua  ---
Created attachment 156381
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156381=edit
An example document with three tracked changes

This should be easily reproduced with any file containing tracked changes.  But
for convenience I'm attaching an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33173] Tabbed UI (Writer): Division/section-per-tab (similar to Lotus WordPro)

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=33173

--- Comment #48 from Todd  ---
Hi All,

John Brassington (jo...@email2.me) ask me if I would add this to the
conversation as he gets echoes from this bug report but can not post to it for
some weird system reason.

  "We still cannot move off of Lotus Wordpro, because so much of our work
relies on the 
  internal brilliant filing system of Tabs.

  A single document can span some 20 years, with Group tabs (labelled say
2019, 2018 etc)
  holding individual tabs (documents - tabs within tabs).

  Fortunately, all of Lotus Smartsuit (Wordpro, 123 etc) works on Windows
10 Pro (32 & 64).

  If Lotus could do it 15 years ago - what would be so difficult now?

  John"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129250] New: Manage changes dialog: (seemingly) useless clickable header for Action column

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129250

Bug ID: 129250
   Summary: Manage changes dialog: (seemingly) useless clickable
header for Action column
   Product: LibreOffice
   Version: 6.2.8.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ming.v@qq.com

In the manage changes dialog (Edit -> Track Changes -> Manage...), the list of
changes have four columns: Action, Author, Date, and Comment.

All the column headers are clickable.  For the latter three, clicking the
header will sort the list in ascending/descending order, with an arrow shown on
the header for indication.  However, clicking on the Action header doesn't seem
to change the list order in any meaningful way, or changing the order at all.

Currently there seems to be only two kinds of actions - addition and deletion. 
Sorting based on this doesn't make much sense anyway.  I am not sure what the
correct solution is, though.

I first notice this bug in 6.2.x series, but I can also reproduce in 6.3.x as
well as 6.4.0 beta1, all on Windows 10.  So I'm not bothering with the "About
LO" information here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

2019-12-06 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/test/fakebool.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit c1fbdc8717fa68f4c432511ace8b58c97b1386ad
Author: Stephan Bergmann 
AuthorDate: Thu Nov 28 13:42:29 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Dec 6 23:52:27 2019 +0100

Document fishy loplugin:fakebool behavior

...as exploited in the change of LockingGuard
(extensions/source/activex/SOActiveX.cxx) in
55e596956e56b175ab17b682e7c8ac7daeb9289a "loplugin:external (clang-cl)"

Change-Id: I599ac72b68651fc733dd37c95ce9105c175fee9e
Reviewed-on: https://gerrit.libreoffice.org/83995
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/fakebool.cxx 
b/compilerplugins/clang/test/fakebool.cxx
index 26b5d7e2f791..936e970e5e85 100644
--- a/compilerplugins/clang/test/fakebool.cxx
+++ b/compilerplugins/clang/test/fakebool.cxx
@@ -17,6 +17,20 @@ struct S {
 sal_Bool b; // expected-error {{FieldDecl, use "bool" instead of 
'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
 };
 
+struct S2 {
+sal_Bool & b_;
+// The following should arguably not warn, but currently does (and does 
find cases that actually
+// can be cleaned up; if it ever produces false warnings for cases that 
cannot, we need to fix
+// it):
+S2(sal_Bool & b): // expected-error {{ParmVarDecl, use "bool" instead of 
'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}}
+b_(b) {}
+};
+
 }
 
+struct S3 {
+sal_Bool b_;
+void f() { S2 s(b_); }
+};
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 129222] + transfer data to new tab

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129222

Todd  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|UNCONFIRMED

--- Comment #3 from Todd  ---
(In reply to Oliver Brinzing from comment #2)
> seems to be a duplicate of:
> 
> Bug 119620 - Copy a cell and add a new worksheet copies the cells value into
> the new worksheet at random position
> 
> *** This bug has been marked as a duplicate of bug 119620 ***

Are you sure of that?  The other bug concerns copy and paste.  This one does
not.  This one is not closing the cell when the + button is pressed.  No
clipboard involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129243] "Application Colors" panel too wide on second opening

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129243

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8132
   Keywords||bibisected, bisected,
   ||regression

--- Comment #4 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2019-10-14 10:46:48 +0100
committer   Caolán McNamara 2019-10-14 12:50:47
+0200
commit  42294bdf528934095d5314fe334324e708e9543c (patch)
tree8619b1ac09043ecb693ef6398646eea4c2a59a94
parent  8715a067a3547cf91a3ed73fd893a621d5ee1a1c (diff)
Resolves: tdf#128132 language page not opened

Bisected with: bibisect-linux64-6.4

Adding Cc: Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - android/app

2019-12-06 Thread Jan Holesovsky (via logerrit)
 android/app/src/main/res/drawable/ic_sort_black_24dp.xml  |   13 
--
 android/app/src/main/res/drawable/ic_sort_by_alpha_black_24dp.xml |9 ++
 android/app/src/main/res/menu/view_menu.xml   |2 -
 android/app/src/main/res/values/arrays.xml|4 +--
 4 files changed, 12 insertions(+), 16 deletions(-)

New commits:
commit 3ecc73d37ff5d57050ccb6f29028a7a3c51a8fcc
Author: Jan Holesovsky 
AuthorDate: Fri Dec 6 16:06:38 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Fri Dec 6 23:35:55 2019 +0100

android: Set only English as the supported language for now.

Change-Id: I55a66b8e8f83252267fb9959cf563bc584fe682d
Reviewed-on: https://gerrit.libreoffice.org/84645
Reviewed-by: Jan Holesovsky 
Tested-by: Jenkins CollaboraOffice 

diff --git a/android/app/src/main/res/values/arrays.xml 
b/android/app/src/main/res/values/arrays.xml
index 116e7a4fc..7adfbd56d 100644
--- a/android/app/src/main/res/values/arrays.xml
+++ b/android/app/src/main/res/values/arrays.xml
@@ -10,7 +10,7 @@
 
 
 en
-tr
+
 
 
 0
@@ -38,7 +38,7 @@
 
 
 English
-Turkçe
+
 
 
 @string/sort_az
commit 4ca81d1b2c02b996f2a47aa8938875213a74f0f6
Author: Jan Holesovsky 
AuthorDate: Fri Dec 6 16:00:16 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Fri Dec 6 23:35:49 2019 +0100

android: Change the sort icon to distinguish it from the other.

Recommended by Pedro - thank you!

Change-Id: Ic4e0f42566a8d565d14c359cd479edf5ddc62525
Reviewed-on: https://gerrit.libreoffice.org/84643
Reviewed-by: Jan Holesovsky 
Tested-by: Jenkins CollaboraOffice 

diff --git a/android/app/src/main/res/drawable/ic_sort_black_24dp.xml 
b/android/app/src/main/res/drawable/ic_sort_black_24dp.xml
deleted file mode 100644
index d582deea6..0
--- a/android/app/src/main/res/drawable/ic_sort_black_24dp.xml
+++ /dev/null
@@ -1,13 +0,0 @@
-
-
-http://schemas.android.com/apk/res/android;>
-
-
diff --git a/android/app/src/main/res/drawable/ic_sort_by_alpha_black_24dp.xml 
b/android/app/src/main/res/drawable/ic_sort_by_alpha_black_24dp.xml
new file mode 100644
index 0..97bf945e8
--- /dev/null
+++ b/android/app/src/main/res/drawable/ic_sort_by_alpha_black_24dp.xml
@@ -0,0 +1,9 @@
+http://schemas.android.com/apk/res/android;
+android:width="24dp"
+android:height="24dp"
+android:viewportWidth="24.0"
+android:viewportHeight="24.0">
+
+
diff --git a/android/app/src/main/res/menu/view_menu.xml 
b/android/app/src/main/res/menu/view_menu.xml
index 67f059647..f7dfa6521 100644
--- a/android/app/src/main/res/menu/view_menu.xml
+++ b/android/app/src/main/res/menu/view_menu.xml
@@ -32,7 +32,7 @@
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/test sc/qa test/source

2019-12-06 Thread Eike Rathke (via logerrit)
 include/test/sheet/xspreadsheets2.hxx |1 
 sc/qa/extras/sctablesheetsobj.cxx |1 
 test/source/sheet/xspreadsheets2.cxx  |   54 ++
 3 files changed, 56 insertions(+)

New commits:
commit ec1478f7da29fc5df5aa2d1ff373d60bdd5b01e0
Author: Eike Rathke 
AuthorDate: Fri Dec 6 20:36:13 2019 +0100
Commit: Eike Rathke 
CommitDate: Fri Dec 6 23:19:14 2019 +0100

Test results across all imported and inserted sheets.

Change-Id: I573467a962a2835765cc5672b81cce4c7772ddff
Reviewed-on: https://gerrit.libreoffice.org/84669
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/include/test/sheet/xspreadsheets2.hxx 
b/include/test/sheet/xspreadsheets2.hxx
index 1340b80be216..6c2cd0952b28 100644
--- a/include/test/sheet/xspreadsheets2.hxx
+++ b/include/test/sheet/xspreadsheets2.hxx
@@ -36,6 +36,7 @@ public:
 void testImportNamedRangeRedefinedInSource();
 void testImportNewNamedRange();
 void testImportCellStyle();
+void testLastAfterInsertCopy();
 
 virtual css::uno::Reference< css::lang::XComponent > getComponent() = 0;
 virtual css::uno::Reference< css::uno::XInterface > init() = 0;
diff --git a/sc/qa/extras/sctablesheetsobj.cxx 
b/sc/qa/extras/sctablesheetsobj.cxx
index 6a8f0928d954..99d55ea75a16 100644
--- a/sc/qa/extras/sctablesheetsobj.cxx
+++ b/sc/qa/extras/sctablesheetsobj.cxx
@@ -53,6 +53,7 @@ public:
 CPPUNIT_TEST(testImportNamedRangeRedefinedInSource);
 CPPUNIT_TEST(testImportNewNamedRange);
 CPPUNIT_TEST(testImportCellStyle);
+CPPUNIT_TEST(testLastAfterInsertCopy);
 
 // XNameContainer
 CPPUNIT_TEST(testRemoveByName);
diff --git a/test/source/sheet/xspreadsheets2.cxx 
b/test/source/sheet/xspreadsheets2.cxx
index fc7f1023fc1c..dee4e3136a09 100644
--- a/test/source/sheet/xspreadsheets2.cxx
+++ b/test/source/sheet/xspreadsheets2.cxx
@@ -44,6 +44,9 @@ static constexpr OUStringLiteral 
gaSrcSheetName("SheetToCopy");
 static constexpr OUStringLiteral gaSrcFileName("rangenamessrc.ods");
 static constexpr OUStringLiteral gaDestFileBase("ScNamedRangeObj.ods");
 
+static sal_Int32 nInsertedSheets(0);
+
+
 XSpreadsheets2::XSpreadsheets2()
 {
 }
@@ -275,6 +278,56 @@ void XSpreadsheets2::testImportCellStyle()
 CPPUNIT_ASSERT_EQUAL_MESSAGE("New style: VertJustify not set", 
table::CellVertJustify_CENTER, 
static_cast(aVertJustify));
 }
 
+void XSpreadsheets2::testLastAfterInsertCopy()
+{
+/** Test that results in row 1 of all inserted sheets are equal to the
+source sheet. The loaded destination document is kept open so several
+sheets are imported.
+*/
+
+CPPUNIT_ASSERT(nInsertedSheets > 0);
+constexpr sal_Int32 nCols = 7;
+
+uno::Reference< container::XNameAccess> 
xSrcNameAccess(init(),UNO_QUERY_THROW);
+xSrcSheet.set( xSrcNameAccess->getByName(gaSrcSheetName), UNO_QUERY_THROW);
+
+OUString aSrcString[nCols];
+for (sal_Int32 nCol=0; nCol < nCols; ++nCol)
+{
+uno::Reference< table::XCell > xSrcCell = 
xSrcSheet->getCellByPosition(nCol, 0);
+uno::Reference< text::XTextRange > xSrcTextRange(xSrcCell, 
UNO_QUERY_THROW);
+aSrcString[nCol] = xSrcTextRange->getString();
+}
+// The named range 'initial2' is already present in the destination
+// document defined to $Sheet1.$B$2 and thus is not copied, pointing to
+// "content2" instead.
+aSrcString[6] = "content2";
+
+xDestDoc = getDoc(gaDestFileBase);
+CPPUNIT_ASSERT(xDestDoc.is());
+uno::Reference< container::XIndexAccess > xDestSheetIndexAccess 
(xDestDoc->getSheets(), UNO_QUERY_THROW);
+CPPUNIT_ASSERT( nInsertedSheets < xDestSheetIndexAccess->getCount());
+for (sal_Int32 nSheet=0; nSheet < nInsertedSheets; ++nSheet)
+{
+xDestSheet.set( xDestSheetIndexAccess->getByIndex(nSheet), 
UNO_QUERY_THROW);
+for (sal_Int32 nCol=0; nCol < nCols; ++nCol)
+{
+uno::Reference< table::XCell > xDestCell = 
xDestSheet->getCellByPosition(nCol, 0);
+uno::Reference< text::XTextRange > xDestTextRange(xDestCell, 
UNO_QUERY_THROW);
+OUString aDestString = xDestTextRange->getString();
+
+if (nCol == 4 && aDestString == "Err:540")
+// The created external reference to the source document not
+// allowed may result in Err:540
+continue;
+
+OString aMessage("Imported result does not match, sheet " + 
OString::number(nSheet)
++ " column " + OString::number(nCol));
+CPPUNIT_ASSERT_EQUAL_MESSAGE( aMessage.getStr(), aSrcString[nCol], 
aDestString);
+}
+}
+}
+
 uno::Reference< sheet::XSpreadsheetDocument> XSpreadsheets2::getDoc(const 
OUString& aFileBase)
 {
 OUString aFileURL;
@@ -308,6 +361,7 @@ void XSpreadsheets2::importSheetToCopy()
 sal_Int32 nDestPos = 0;
 sal_Int32 nDestPosEffective = xDestSheets->importSheet(xDocument, 
gaSrcSheetName, nDestPos);
 

[Libreoffice-bugs] [Bug 127237] FileOpen: PPTX Shading - Table Background color missing in Impress

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127237

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127237] FileOpen: PPTX Shading - Table Background color missing in Impress

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127237

--- Comment #15 from Commit Notification 
 ---
nd101 committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/6e873fd94a192f503fd1aff205bdfb5ad465c7ef

tdf#127237 fix table background color in Impress import

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - oox/inc oox/source sd/qa

2019-12-06 Thread nd101 (via logerrit)
 oox/inc/drawingml/table/tableproperties.hxx|2 ++
 oox/source/drawingml/table/tablecell.cxx   |6 ++
 oox/source/drawingml/table/tablecontext.cxx|2 ++
 oox/source/drawingml/table/tableproperties.cxx |1 +
 sd/qa/unit/data/pptx/tdf127237.pptx|binary
 sd/qa/unit/export-tests-ooxml1.cxx |   22 ++
 6 files changed, 33 insertions(+)

New commits:
commit 6e873fd94a192f503fd1aff205bdfb5ad465c7ef
Author: nd101 
AuthorDate: Mon Sep 2 10:29:12 2019 +0800
Commit: Xisco Faulí 
CommitDate: Fri Dec 6 22:41:35 2019 +0100

tdf#127237 fix table background color in Impress import

When the background color is set at the table level in PPTX,
instead of at cell level, the background color fails to
show up in Impress.

Change-Id: I2838e5b56e4a2414494ee99c0f8975b7256ac6dc
Reviewed-on: https://gerrit.libreoffice.org/78377
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit 4c2254cbebca53c34fa48a1dd90cebe434f24274)
Reviewed-on: https://gerrit.libreoffice.org/84644
Reviewed-by: Xisco Faulí 

diff --git a/oox/inc/drawingml/table/tableproperties.hxx 
b/oox/inc/drawingml/table/tableproperties.hxx
index dd50cd7a694d..010fc67df416 100644
--- a/oox/inc/drawingml/table/tableproperties.hxx
+++ b/oox/inc/drawingml/table/tableproperties.hxx
@@ -54,6 +54,7 @@ public:
 voidsetBandRow(bool b)  { mbBandRow = b; };
 boolisBandCol() const   { return 
mbBandCol; };
 voidsetBandCol(bool b)  { mbBandCol = b; };
+Color&  getBgColor(){ return maBgColor; };
 
 void pushToPropSet( const ::oox::core::XmlFilterBase& rFilterBase,
 const css::uno::Reference < css::beans::XPropertySet > & xPropSet,
@@ -70,6 +71,7 @@ private:
 std::shared_ptr< TableStyle >   mpTableStyle;   // or the 
complete TableStyle
 std::vector< sal_Int32 >mvTableGrid;
 std::vector< TableRow > mvTableRows;
+Color   maBgColor;
 
 boolmbFirstRow;
 boolmbFirstCol;
diff --git a/oox/source/drawingml/table/tablecell.cxx 
b/oox/source/drawingml/table/tablecell.cxx
index f27117fd2b42..50dda7080bb0 100644
--- a/oox/source/drawingml/table/tablecell.cxx
+++ b/oox/source/drawingml/table/tablecell.cxx
@@ -424,6 +424,12 @@ void TableCell::pushToXCell( const 
::oox::core::XmlFilterBase& rFilterBase, cons
 applyLineAttributes( rFilterBase, xPropSet, 
aLinePropertiesTopLeftToBottomRight, PROP_DiagonalTLBR );
 applyLineAttributes( rFilterBase, xPropSet, 
aLinePropertiesBottomLeftToTopRight, PROP_DiagonalBLTR );
 
+if (rProperties.getBgColor().isUsed() && 
!maFillProperties.maFillColor.isUsed() && maFillProperties.moFillType.get() == 
XML_noFill)
+{
+maFillProperties.moFillType = XML_solidFill;
+maFillProperties.maFillColor = rProperties.getBgColor();
+}
+
 aFillProperties.assignUsed( maFillProperties );
 ShapePropertyMap aPropMap( rFilterBase.getModelObjectHelper() );
 
diff --git a/oox/source/drawingml/table/tablecontext.cxx 
b/oox/source/drawingml/table/tablecontext.cxx
index 3371e105f691..90191f615d4d 100644
--- a/oox/source/drawingml/table/tablecontext.cxx
+++ b/oox/source/drawingml/table/tablecontext.cxx
@@ -57,6 +57,8 @@ TableContext::onCreateContext( ::sal_Int32 aElementToken, 
const AttributeList& r
 mrTableProperties.setBandCol( rAttribs.getBool( XML_bandCol, false 
) );
 }
 break;
+case A_TOKEN(solidFill):
+return new ColorContext(*this, mrTableProperties.getBgColor());
 case A_TOKEN( tableStyle ): // CT_TableStyle
 {
 std::shared_ptr< TableStyle >& rTableStyle = 
mrTableProperties.getTableStyle();
diff --git a/oox/source/drawingml/table/tableproperties.cxx 
b/oox/source/drawingml/table/tableproperties.cxx
index b6f9a8a59cfc..a32353d52f1f 100644
--- a/oox/source/drawingml/table/tableproperties.cxx
+++ b/oox/source/drawingml/table/tableproperties.cxx
@@ -49,6 +49,7 @@ TableProperties::TableProperties()
 , mbBandRow( false )
 , mbBandCol( false )
 {
+maBgColor.setUnused();
 }
 
 static void CreateTableRows( const uno::Reference< XTableRows >& xTableRows, 
const std::vector< TableRow >& rvTableRows )
diff --git a/sd/qa/unit/data/pptx/tdf127237.pptx 
b/sd/qa/unit/data/pptx/tdf127237.pptx
new file mode 100644
index ..f63423cd47e8
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf127237.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx 
b/sd/qa/unit/export-tests-ooxml1.cxx
index 79b18b7cb914..769bf6e52456 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -55,6 +55,7 @@ class SdOOXMLExportTest1 : public SdModelTestBaseXML
 {
 public:
 void testFdo90607();
+

[Libreoffice-bugs] [Bug 129243] "Application Colors" panel too wide on second opening

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129243

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org

--- Comment #3 from Xisco Faulí  ---
Reproduced in

Version: 6.5.0.0.alpha0+
Build ID: b5a4570e214f0e965a8b32cee3c615856ae07ac4
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124438] [META] Presenter console bugs and enhancements

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124438
Bug 124438 depends on bug 127921, which changed state.

Bug 127921 Summary: Presenter View of Impress 6.3.x doesn't remember slide 
after Slides and Close, as it used to, but returns to 1 during presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=127921

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129249] Tip window

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129249

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thanks for reporting this issue. It's a duplicate of bug 128524 and it will be
fixed in LibreOffice 6.3.4

*** This bug has been marked as a duplicate of bug 128524 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/Module_sw.mk sw/qa sw/UITest_writer_tests7.mk

2019-12-06 Thread Artur Neumann (via logerrit)
 sw/Module_sw.mk   |1 
 sw/UITest_writer_tests7.mk|   16 +++
 sw/qa/uitest/writer_tests7/data/tdf127652.odt |binary
 sw/qa/uitest/writer_tests7/tdf127652.py   |   56 ++
 4 files changed, 73 insertions(+)

New commits:
commit 06e45d45877349417000def82c20eaae4bfc3ee3
Author: Artur Neumann 
AuthorDate: Thu Nov 28 13:51:12 2019 +0545
Commit: Xisco Faulí 
CommitDate: Fri Dec 6 22:27:50 2019 +0100

UI test for tdf#127652

Test that the cursor is placed correctly after deleting a section
that overlaps page boundaries

Change-Id: I466770c7edadf09f11260ede236e598d3d1a875b
Reviewed-on: https://gerrit.libreoffice.org/83963
Reviewed-by: Xisco Faulí 
Tested-by: Xisco Faulí 

diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 2dbd5f161f22..101d3b73921b 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -151,6 +151,7 @@ $(eval $(call gb_Module_add_uicheck_targets,sw,\
UITest_writer_tests4 \
UITest_writer_tests5 \
UITest_writer_tests6 \
+   UITest_writer_tests7 \
UITest_table \
UITest_sw_findReplace \
UITest_sw_findSimilarity \
diff --git a/sw/UITest_writer_tests7.mk b/sw/UITest_writer_tests7.mk
new file mode 100644
index ..b6de351eed13
--- /dev/null
+++ b/sw/UITest_writer_tests7.mk
@@ -0,0 +1,16 @@
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call  gb_UITest_UITest,writer_tests7))
+
+$(eval $(call gb_UITest_add_modules,writer_tests7,$(SRCDIR)/sw/qa/uitest,\
+   writer_tests7/ \
+))
+
+$(eval $(call gb_UITest_set_defs,writer_tests7, \
+TDOC="$(SRCDIR)/sw/qa/uitest/writer_tests7/data" \
+))
diff --git a/sw/qa/uitest/writer_tests7/data/tdf127652.odt 
b/sw/qa/uitest/writer_tests7/data/tdf127652.odt
new file mode 100644
index ..12b2b156bd23
Binary files /dev/null and b/sw/qa/uitest/writer_tests7/data/tdf127652.odt 
differ
diff --git a/sw/qa/uitest/writer_tests7/tdf127652.py 
b/sw/qa/uitest/writer_tests7/tdf127652.py
new file mode 100644
index ..b6e181c61b98
--- /dev/null
+++ b/sw/qa/uitest/writer_tests7/tdf127652.py
@@ -0,0 +1,56 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.path import get_srcdir_url
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+
+def get_url_for_data_file(file_name):
+   return get_srcdir_url() + "/sw/qa/uitest/writer_tests7/data/" + file_name
+
+class tdf127652 (UITestCase):
+
+def test_mark_delete_undo_delete_tdf127652 (self):
+
+self.ui_test.load_file(get_url_for_data_file("tdf127652.odt"))
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+# go to the start of page 4
+xWriterEdit.executeAction("GOTO", mkPropertyValues({"PAGE": "4"}))
+xWriterEdit.executeAction("CLICK", tuple())
+
+# mark a section that overlaps multiple pages
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"DOWN"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"DOWN"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"SHIFT+UP"}))
+
+# delete the marked section
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"DELETE"}))
+
+# go to the start of page 4
+xWriterEdit.executeAction("GOTO", mkPropertyValues({"PAGE": "4"}))
+xWriterEdit.executeAction("CLICK", tuple())
+
+# move up to page 3
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+
+# check that we are on the third page
+# in the bug one issue was that the cursor was places in the wrong 
place
+# moving up to the previous page would 

[Libreoffice-bugs] [Bug 129248] Writer can't remember chosen database after closing

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129248

--- Comment #3 from Julien Nabet  ---
If it doesn't include confidential/private part, you may attach it here so
someone can try to remove it.
You may also try yourself.
Rename the extension to zip, unzip and find the string in files.
Then remove it, zip again, put back the extension and try.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129249] New: Tip window

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129249

Bug ID: 129249
   Summary: Tip window
   Product: LibreOffice
   Version: 6.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: emneiek...@gmail.com

Description:
After opening libreoffice, a tip windows comes. You will notice that, the tips
that written have some problem. They come in single line, so I have to stretch
that window to see the whole tip.

Steps to Reproduce:
1.Open libreoffice, the tip windows pops up
2read the tip
3.

Actual Results:
unaligned text

Expected Results:
new line


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/CppunitTest_connectivity_commontools.mk connectivity/CppunitTest_connectivity_sharedresources.mk emfio/CppunitTest_emfio_emf_test.mk

2019-12-06 Thread Stephan Bergmann (via logerrit)
 connectivity/CppunitTest_connectivity_commontools.mk |2 ++
 connectivity/CppunitTest_connectivity_sharedresources.mk |2 ++
 emfio/CppunitTest_emfio_emf_test.mk  |1 +
 3 files changed, 5 insertions(+)

New commits:
commit 97b3e455802cfc08568ec5e8379c509efe3e47b1
Author: Stephan Bergmann 
AuthorDate: Fri Dec 6 19:33:59 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Dec 6 21:33:55 2019 +0100

Fix some new dependencies on boost_headers

...caused by a8cd98c437f2c3b5c4f7c139aa7223c5cfb74d1a "use o3tl::optional
instead of pointer", see :

> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/connectivity/qa/connectivity/resource/sharedresources_test.cxx:10:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/test/bootstrapfixture.hxx:16:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/salctype.hxx:25:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/graph.hxx:27:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/bitmapex.hxx:23:
> 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/o3tl/optional.hxx:20:10:
 fatal error: 'boost/none.hpp' file not found
> #include 
>  ^~~~
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/connectivity/qa/connectivity/commontools/FValue_test.cxx:20:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/test/bootstrapfixture.hxx:16:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/salctype.hxx:25:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/graph.hxx:27:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/bitmapex.hxx:23:
> 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/o3tl/optional.hxx:20:10:
 fatal error: 'boost/none.hpp' file not found
> #include 
>  ^~~~
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/emfio/qa/cppunit/emf/EmfImportTest.cxx:13:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/test/bootstrapfixture.hxx:16:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/salctype.hxx:25:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/graph.hxx:27:
> In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/vcl/bitmapex.hxx:23:
> 
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/include/o3tl/optional.hxx:20:10:
 fatal error: 'boost/none.hpp' file not found
> #include 
>  ^~~~

Change-Id: I86ccc030a8f34b9ee6a853e843c9eb6f2d987406
Reviewed-on: https://gerrit.libreoffice.org/84664
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/CppunitTest_connectivity_commontools.mk 
b/connectivity/CppunitTest_connectivity_commontools.mk
index 15a9d7e4633e..81dfe9e6861d 100644
--- a/connectivity/CppunitTest_connectivity_commontools.mk
+++ b/connectivity/CppunitTest_connectivity_commontools.mk
@@ -14,6 +14,8 @@ $(eval $(call 
gb_CppunitTest_set_include,connectivity_commontools,\
$$(INCLUDE) \
 ))
 
+$(eval $(call 
gb_CppunitTest_use_external,connectivity_commontools,boost_headers))
+
 $(eval $(call gb_CppunitTest_use_ure,connectivity_commontools))
 $(eval $(call gb_CppunitTest_use_vcl,connectivity_commontools))
 
diff --git a/connectivity/CppunitTest_connectivity_sharedresources.mk 
b/connectivity/CppunitTest_connectivity_sharedresources.mk
index 78209cfbbdf0..9af3f8ca2442 100644
--- a/connectivity/CppunitTest_connectivity_sharedresources.mk
+++ b/connectivity/CppunitTest_connectivity_sharedresources.mk
@@ -15,6 +15,8 @@ $(eval $(call 
gb_CppunitTest_set_include,connectivity_sharedresources,\
$$(INCLUDE) \
 ))
 
+$(eval $(call 
gb_CppunitTest_use_external,connectivity_sharedresources,boost_headers))
+
 $(eval $(call gb_CppunitTest_use_ure,connectivity_sharedresources))
 $(eval $(call gb_CppunitTest_use_vcl,connectivity_sharedresources))
 
diff --git a/emfio/CppunitTest_emfio_emf_test.mk 
b/emfio/CppunitTest_emfio_emf_test.mk
index 4f892b42c27b..123e4b3549bd 100644
--- a/emfio/CppunitTest_emfio_emf_test.mk
+++ b/emfio/CppunitTest_emfio_emf_test.mk
@@ -10,6 +10,7 @@
 

[Libreoffice-bugs] [Bug 122493] No presenter Notes in LibreImpress rehearsal timing

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122493

Timur  changed:

   What|Removed |Added

Version|unspecified |3.3.0 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64483] FILEOPEN Text positioning in slide wrong in PPT file

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64483

Timur  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from Timur  ---
Obvious that this was wrong bug report with many issues. And that alone
could've close it as Invalid. But let's see current state. 
As for current slide 8, yes, same in master 6.5+.
But the reason is trivial, in shape it's typed:
 "  Kemuliaan Tuhan"
Like this, with many spaces. And than "Resize shape to fit text" plus "Wrap
text in shape".
I'm not sure LO is wrong here. It just shows extra spaces in a new row.
Maybe MSO loks better because it corrects user mistake. 
But I don't see this as worth for keeping bug open.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113331] [META] PPT (binary) format bug tracker

2019-12-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113331
Bug 113331 depends on bug 64483, which changed state.

Bug 64483 Summary: FILEOPEN Text positioning in slide wrong in PPT file
https://bugs.documentfoundation.org/show_bug.cgi?id=64483

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2019-12-06 Thread Caolán McNamara (via logerrit)
 cui/source/tabpages/tpline.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 444161dde3beeed5306d2f2432fcd99aa94c3c0b
Author: Caolán McNamara 
AuthorDate: Fri Dec 6 14:43:35 2019 +
Commit: Caolán McNamara 
CommitDate: Fri Dec 6 21:22:31 2019 +0100

Resolves: tdf#128923 should be able to change attributes of multiple 
lines...

without changing color

Change-Id: I76cf21af4611afc11bf1861abe7d0b903362e798
Reviewed-on: https://gerrit.libreoffice.org/84637
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index 89fc0dc227ef..beb9018d4361 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -455,6 +455,7 @@ bool SvxLineTabPage::FillItemSet( SfxItemSet* rAttrs )
 }
 
 // Line color
+if (m_xLbColor->IsValueChangedFromSaved())
 {
 NamedColor aColor = m_xLbColor->GetSelectedEntry();
 XLineColorItem aItem(aColor.second, aColor.first);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

  1   2   3   4   5   >