[Libreoffice-bugs] [Bug 129483] Crash in: ScPatternAttr::operator==(SfxPoolItem const &)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129483

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Hello Miguel,
you forgot to attach the document...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

--- Comment #34 from Techsteq Solution  ---
Very interesting, good job and thanks for sharing such a good blog.
Visit:- https://www.techsteq.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129487] New: Contents are repeated in pagemaker file conversion

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129487

Bug ID: 129487
   Summary: Contents are repeated in pagemaker file conversion
   Product: Document Liberation Project
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: libpagemaker
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rajeeshknamb...@gmail.com

Created attachment 156662
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156662=edit
Sample files

I'm trying to convert a pagemaker file with 4 pages. The converted text file
has entire content repeated 4 times.

How to reproduce:
-

$ pmd2text pmdtest.pmd | less

Observe that same contents are repeated 4 times.

The attached archive contains 4 files:
1. The PMD file contains extended ASCII characters and used to display
Malayalam text (in pre-Unicode era).
2. The PDF file is for comparison (even though it might look greek to the LO
developers, but might help).
3. The converted text file.
4. If you must view the contents, an ASCII font is also attached.


Expected result: contents are not repeated on conversion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84838] trying to Copy text causes crash shutdown on windows document in SUSE

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84838

Julien Nabet  changed:

   What|Removed |Added

URL|https://www.theacademicpape |
   |rs.co.uk/dissertation-writi |
   |ng-services-uk.php  |
   Keywords|corruptProfile  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 65038] EDITING: Search doesn't replace regular expression with Look assertions (ahead-behind)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65038

--- Comment #10 from Mike Kaganski  ---
In tdf#75806, leading characters were added to analyzed part of string in
TextSearch::searchForward. This fixes look-behind assertions. To handle
look-ahead assertions, similarly trailing characters need to be added there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128604] Base UI - Incomplete border line in table design panel - KDE/QT

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128604

Alex Thurgood  changed:

   What|Removed |Added

Summary|Base UI - Incomplete border |Base UI - Incomplete border
   |line in table design panel  |line in table design panel
   ||- KDE/QT

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119419] Insert Field into Writer document attempts to connect to all registered database sources in sequence before displaying dialog

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119419

--- Comment #7 from Alex Thurgood  ---
Still reproducible in

Version: 6.5.0.0.alpha0+
Build ID: 8d23959b9eb014b625e3d7a8ee8aea51cdc6abbf
CPU threads: 4; OS: Mac OS X 10.15.1; UI render: default; VCL: osx; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129449] FIND: Empty paragraph at the end of a document is not found when searching for paragraph styles in Find & Replace

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129449

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW
Summary|Empty lines are not found   |FIND: Empty
   |or not shown when searching |paragraph at the end of a
   |for paragraph styles in |document is not found when
   |Find & Replace  |searching for paragraph
   ||styles in Find & Replace

--- Comment #1 from Dieter Praas  ---
I confirm it with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

But I think, we have two issues

a) If last paragraph is empty it is not found when searching for paragraph
style (this is a bug)
b) LO should indicate that a paragraph style is found in an empty paragraph
(enhancement)

So I propose to narrow down this bug report to the first issue and to open a
new report for the second.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129476] [UI] The term "table heading" should be "table header".

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129476

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Heiko Tietze  ---
We talked in the design meeting about heading vs header. And regarding the
table it's more like a "heading" in terms of a chapter title than a "header"
that usually comes on top of a page. So the current terms are WFM (native
speaker are welcome to reopen the issue).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 129476] [UI] The term "table heading" should be "table header".

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129476

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Heiko Tietze  ---
We talked in the design meeting about heading vs header. And regarding the
table it's more like a "heading" in terms of a chapter title than a "header"
that usually comes on top of a page. So the current terms are WFM (native
speaker are welcome to reopen the issue).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 129417] Rename PDF export option from "Full-sheet previews" to something else

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129417

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Severity|normal  |enhancement
   Keywords|needsUXEval |

--- Comment #4 from Heiko Tietze  ---
Rimut suggested in the design meeting "Whole sheet export". Personally, I don't
see a big advantage in any combination of Full/Whole-sheet preview/export - but
also not a disadvantage. So do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 129417] Rename PDF export option from "Full-sheet previews" to something else

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129417

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Severity|normal  |enhancement
   Keywords|needsUXEval |

--- Comment #4 from Heiko Tietze  ---
Rimut suggested in the design meeting "Whole sheet export". Personally, I don't
see a big advantage in any combination of Full/Whole-sheet preview/export - but
also not a disadvantage. So do it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: desktop/inc desktop/source drawinglayer/source dtrans/source

2019-12-18 Thread Noel Grandin (via logerrit)
 desktop/inc/dp_misc.h |4 
++--
 desktop/source/app/app.cxx|2 +-
 desktop/source/deployment/dp_persmap.cxx  |6 
+++---
 desktop/source/deployment/dp_services.cxx |2 +-
 desktop/source/deployment/gui/dp_gui_service.cxx  |2 +-
 desktop/source/deployment/manager/dp_manager.cxx  |2 +-
 desktop/source/deployment/misc/dp_ucb.cxx |4 
++--
 desktop/source/deployment/misc/lockfile.cxx   |2 +-
 desktop/source/deployment/registry/configuration/dp_configuration.cxx |4 
++--
 desktop/source/deployment/registry/package/dp_package.cxx |4 
++--
 desktop/source/lib/init.cxx   |4 
++--
 desktop/source/lib/lokclipboard.cxx   |2 +-
 desktop/source/migration/migration.cxx|2 +-
 desktop/source/migration/migration_impl.hxx   |2 +-
 desktop/source/migration/services/cexports.cxx|2 +-
 desktop/source/migration/services/cexportsoo3.cxx |2 +-
 desktop/source/migration/services/wordbookmigration.cxx   |4 
++--
 drawinglayer/source/drawinglayeruno/drawinglayeruno.cxx   |2 +-
 dtrans/source/cnttype/mctfentry.cxx   |2 +-
 dtrans/source/generic/dtrans.cxx  |2 +-
 dtrans/source/win32/clipb/wcbentry.cxx|2 +-
 dtrans/source/win32/dnd/dndentry.cxx  |2 +-
 dtrans/source/win32/dtobj/DTransHelper.cxx|2 +-
 dtrans/source/win32/dtobj/FmtFilter.cxx   |4 
++--
 dtrans/source/win32/ftransl/ftranslentry.cxx  |2 +-
 25 files changed, 34 insertions(+), 34 deletions(-)

New commits:
commit bd9d2c3205af57dc6ae9821a3bc9c098bf97dba1
Author: Noel Grandin 
AuthorDate: Thu Dec 19 08:15:56 2019 +0200
Commit: Noel Grandin 
CommitDate: Thu Dec 19 08:20:02 2019 +0100

sal_Char->char in desktop..dtrans

Change-Id: I6ad7d6acf081c16f904eb1b2506b545a88046c48
Reviewed-on: https://gerrit.libreoffice.org/85470
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/desktop/inc/dp_misc.h b/desktop/inc/dp_misc.h
index 236a9ee18f2c..1ed5b3e5e1ce 100644
--- a/desktop/inc/dp_misc.h
+++ b/desktop/inc/dp_misc.h
@@ -34,8 +34,8 @@
 
 namespace dp_misc {
 
-const sal_Char CR = 0x0d;
-const sal_Char LF = 0x0a;
+const char CR = 0x0d;
+const char LF = 0x0a;
 
 
 class MutexHolder
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 4afbed28e6b3..7fd35ee3d574 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -593,7 +593,7 @@ bool Desktop::QueryExit()
 {
 }
 
-const sal_Char SUSPEND_QUICKSTARTVETO[] = "SuspendQuickstartVeto";
+const char SUSPEND_QUICKSTARTVETO[] = "SuspendQuickstartVeto";
 
 Reference< XDesktop2 > xDesktop = css::frame::Desktop::create( 
::comphelper::getProcessComponentContext() );
 Reference< XPropertySet > xPropertySet(xDesktop, UNO_QUERY_THROW);
diff --git a/desktop/source/deployment/dp_persmap.cxx 
b/desktop/source/deployment/dp_persmap.cxx
index 63d02f51d41a..14e1f2076e47 100644
--- a/desktop/source/deployment/dp_persmap.cxx
+++ b/desktop/source/deployment/dp_persmap.cxx
@@ -66,7 +66,7 @@ PersistentMap::~PersistentMap()
 // replace "%" with "%%"
 static OString encodeString( const OString& rStr)
 {
-const sal_Char* pChar = rStr.getStr();
+const char* pChar = rStr.getStr();
 const sal_Int32 nLen = rStr.getLength();
 sal_Int32 i = nLen;
 // short circuit for the simple non-encoded case
@@ -101,7 +101,7 @@ static OString encodeString( const OString& rStr)
 
 // replace "%0".."%F" with 0x00..0x0F
 // replace "%%" with "%"
-static OString decodeString( const sal_Char* pEncChars, int nLen)
+static OString decodeString( const char* pEncChars, int nLen)
 {
 const char* pChar = pEncChars;
 sal_Int32 i = nLen;
@@ -117,7 +117,7 @@ static OString decodeString( const sal_Char* pEncChars, int 
nLen)
 pChar = pEncChars;
 for( i = nLen; --i >= 0;)
 {
-sal_Char c = *(pChar++);
+char c = *(pChar++);
 // handle escaped character
 if( c == '%')
 {
diff --git a/desktop/source/deployment/dp_services.cxx 
b/desktop/source/deployment/dp_services.cxx
index ba642fdbff10..bfaeb801141f 100644
--- a/desktop/source/deployment/dp_services.cxx
+++ b/desktop/source/deployment/dp_services.cxx
@@ -28,7 +28,7 @@ namespace sdecl = comphelper::service_decl;
 extern "C" {
 
 SAL_DLLPUBLIC_EXPORT void * deployment_component_getFactory(
-sal_Char const * pImplName, 

[Libreoffice-bugs] [Bug 84838] trying to Copy text causes crash shutdown on windows document in SUSE

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84838

romandavis  changed:

   What|Removed |Added

   Keywords||corruptProfile
URL||https://www.theacademicpape
   ||rs.co.uk/dissertation-writi
   ||ng-services-uk.php

--- Comment #9 from romandavis  ---
This is a big mistake if we do so and crept our widow and the first step in
writing a bug report is to identify exactly what the problem is.
https://www.theacademicpapers.co.uk/dissertation-writing-services-uk.php

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 129219] Further refinement of OpenType/Graphite Font features in the “Character” dialogue

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129219

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #14 from Heiko Tietze  ---
(In reply to Tobias Hemm from comment #12)
> I would suggest now: Leave the "Font Effects" tab as it is at the moment,
> and implement another tab called "OpenType". Some Benjamins won’t be
> interested in that, since they don’t know what it means, and they don’t need
> it.

Unfortunately it's not so simple ;-)

> So let me summarize what what needs to be done:
> – move the already existing dialogue to a separate tab called "OpenType"
> – group and order the features in a sensible way
> – change some features’ activation mode to drop-downs and bullets (see list)
> – keep not available features visible, and grey them out
> 
> That’s it. No problems, no duplicates, no confusion.

By no means the UX input should be discouraging or block your work. We pondered
over the various aspects and you made a final decision with the input from UX.
Go ahead and let's talk about those details plus sensible defaults later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 129219] Further refinement of OpenType/Graphite Font features in the “Character” dialogue

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129219

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #14 from Heiko Tietze  ---
(In reply to Tobias Hemm from comment #12)
> I would suggest now: Leave the "Font Effects" tab as it is at the moment,
> and implement another tab called "OpenType". Some Benjamins won’t be
> interested in that, since they don’t know what it means, and they don’t need
> it.

Unfortunately it's not so simple ;-)

> So let me summarize what what needs to be done:
> – move the already existing dialogue to a separate tab called "OpenType"
> – group and order the features in a sensible way
> – change some features’ activation mode to drop-downs and bullets (see list)
> – keep not available features visible, and grey them out
> 
> That’s it. No problems, no duplicates, no confusion.

By no means the UX input should be discouraging or block your work. We pondered
over the various aspects and you made a final decision with the input from UX.
Go ahead and let's talk about those details plus sensible defaults later.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124548] Activating Area tab, "None" is always focused, regardless of which fill type is selected

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124548

--- Comment #7 from Jim Raykowski  ---
Grabbing focus to the active sub page button when the area tab page is
activated will cause unexpected keyboard navigation behavior by moving the
focus to the active button when the tab page is visited. 

Perhaps this could be done for mouse selection only. It would change the
current mouse selection behavior of focus being set on the tab if focus is
currently on any other tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129486] The most reliable HP printer offline support

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129486

Peter Morgan Stark  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
URL||https://www.assistanceforal
   ||l.com/services/printer-supp
   ||ort/hp-printer-support/

--- Comment #1 from Peter Morgan Stark  ---
Are you using HP printer at home or office? If yes, then you are in a solid
company of millions of people who love HP printers because of their reliability
and efficiency. 


https://bit.ly/2NDmzL6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129456] ComicSansMS font is displayed as "Comic Sans MS" font, contrary to Word

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129456

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
In

Version: 6.5.0.0.alpha0+ (x64)
Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

I only can see ComicSansMS. 

But I can't find ComicSansMS in the font list (not in Word and not in LO). I
conly can find Comic Sans MS. How did you create that file?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: editeng/source embeddedobj/source embeddedobj/test embedserv/source emfio/source eventattacher/source include/editeng

2019-12-18 Thread Noel Grandin (via logerrit)
 editeng/source/misc/svxacorr.cxx |   14 +++---
 editeng/source/uno/unofield.cxx  |2 +-
 embeddedobj/source/commonembedding/register.cxx  |2 +-
 embeddedobj/source/msole/oleregister.cxx |2 +-
 embeddedobj/test/MainThreadExecutor/register.cxx |2 +-
 embeddedobj/test/mtexecutor/mteregister.cxx  |2 +-
 embedserv/source/embed/register.cxx  |2 +-
 emfio/source/reader/emfreader.cxx|2 +-
 eventattacher/source/eventattacher.cxx   |2 +-
 include/editeng/svxacorr.hxx |4 ++--
 10 files changed, 17 insertions(+), 17 deletions(-)

New commits:
commit a56955a4b323dd3e78ea49f2b3f3eebca5d5586c
Author: Noel Grandin 
AuthorDate: Thu Dec 19 08:22:49 2019 +0200
Commit: Noel Grandin 
CommitDate: Thu Dec 19 08:12:46 2019 +0100

sal_Char->char in editeng..eventattacher

Change-Id: Ia9c736042a07a17377db6d88c5bcd2b468e98777
Reviewed-on: https://gerrit.libreoffice.org/85471
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index cad718e86f6a..8160a448925f 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -105,11 +105,11 @@ namespace o3tl {
 }
 static const sal_Unicode cNonBreakingSpace = 0xA0;
 
-static const sal_Char pXMLImplWrdStt_ExcptLstStr[] = "WordExceptList.xml";
-static const sal_Char pXMLImplCplStt_ExcptLstStr[] = "SentenceExceptList.xml";
-static const sal_Char pXMLImplAutocorr_ListStr[]   = "DocumentList.xml";
+static const char pXMLImplWrdStt_ExcptLstStr[] = "WordExceptList.xml";
+static const char pXMLImplCplStt_ExcptLstStr[] = "SentenceExceptList.xml";
+static const char pXMLImplAutocorr_ListStr[]   = "DocumentList.xml";
 
-static const sal_Char
+static const char
 /* also at these beginnings - Brackets and all kinds of begin characters */
 sImplSttSkipChars[] = "\"\'([{\x83\x84\x89\x91\x92\x93\x94",
 /* also at these ends - Brackets and all kinds of begin characters */
@@ -180,7 +180,7 @@ static bool lcl_IsSymbolChar( CharClass const & rCC, const 
OUString& rTxt,
 return false;
 }
 
-static bool lcl_IsInAsciiArr( const sal_Char* pArr, const sal_Unicode c )
+static bool lcl_IsInAsciiArr( const char* pArr, const sal_Unicode c )
 {
 bool bRet = false;
 for( ; *pArr; ++pArr )
@@ -2024,7 +2024,7 @@ bool SvxAutoCorrectLanguageLists::IsFileChanged_Imp()
 
 void SvxAutoCorrectLanguageLists::LoadXMLExceptList_Imp(
 std::unique_ptr& 
rpLst,
-const sal_Char* pStrmName,
+const char* pStrmName,
 tools::SvRef& rStg)
 {
 if( rpLst )
@@ -2094,7 +2094,7 @@ void SvxAutoCorrectLanguageLists::LoadXMLExceptList_Imp(
 
 void SvxAutoCorrectLanguageLists::SaveExceptList_Imp(
 const SvStringsISortDtor& rLst,
-const sal_Char* pStrmName,
+const char* pStrmName,
 tools::SvRef const ,
 bool bConvert )
 {
diff --git a/editeng/source/uno/unofield.cxx b/editeng/source/uno/unofield.cxx
index d6fc905078c2..66e2ad13a647 100644
--- a/editeng/source/uno/unofield.cxx
+++ b/editeng/source/uno/unofield.cxx
@@ -499,7 +499,7 @@ std::unique_ptr 
SvxUnoTextField::CreateFieldData() const throw()
 else
 aContent = mpImpl->msString2;
 
-sal_Int32 nPos = aContent.lastIndexOf( sal_Char(' '), 0 );
+sal_Int32 nPos = aContent.lastIndexOf( ' ', 0 );
 if( nPos > 0 )
 {
 aFirstName = aContent.copy( 0, nPos );
diff --git a/embeddedobj/source/commonembedding/register.cxx 
b/embeddedobj/source/commonembedding/register.cxx
index adb377544625..148fd5ad534f 100644
--- a/embeddedobj/source/commonembedding/register.cxx
+++ b/embeddedobj/source/commonembedding/register.cxx
@@ -29,7 +29,7 @@ using namespace ::com::sun::star;
 extern "C" {
 
 SAL_DLLPUBLIC_EXPORT void * embobj_component_getFactory(
-const sal_Char * pImplName, void * pServiceManager,
+const char * pImplName, void * pServiceManager,
 SAL_UNUSED_PARAMETER void * /*pRegistryKey*/ )
 {
 void * pRet = nullptr;
diff --git a/embeddedobj/source/msole/oleregister.cxx 
b/embeddedobj/source/msole/oleregister.cxx
index 7af86e8db9ae..cd3f5915807a 100644
--- a/embeddedobj/source/msole/oleregister.cxx
+++ b/embeddedobj/source/msole/oleregister.cxx
@@ -32,7 +32,7 @@ using namespace ::com::sun::star;
 extern "C" {
 
 SAL_DLLPUBLIC_EXPORT void * emboleobj_component_getFactory(
-const sal_Char * pImplName, void * pServiceManager,
+const char * pImplName, void * pServiceManager,
 SAL_UNUSED_PARAMETER void * /*pRegistryKey*/ )
 {
 void * pRet = nullptr;
diff --git a/embeddedobj/test/MainThreadExecutor/register.cxx 

[Libreoffice-bugs] [Bug 129486] New: The most reliable HP printer offline support

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129486

Bug ID: 129486
   Summary: The most reliable HP printer offline support
   Product: Impress Remote
   Version: 1.0.1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cvetapatrick45...@gmail.com

Description:
Are you facing HP printer connection issues? Is it not possible for you to
print documents easily in wireless manner? Do not worry as we provide complete
HP printer setup support to all HP customers. 

Just dial 1-877-916-7666 to contact our reliable and loved HP support helpline.
This toll free service remains active at all ties on all 7 days of the week. 

https://www.assistanceforall.com/services/printer-support/hp-printer-support/


Actual Results:
https://www.assistanceforall.com/services/printer-support/hp-printer-support/

Expected Results:
https://www.assistanceforall.com/services/printer-support/hp-printer-support/


Reproducible: Always


User Profile Reset: No



Additional Info:
https://www.assistanceforall.com/services/printer-support/hp-printer-support/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129427] Invisible symbols should be formatted

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129427

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter Praas  ---
DM, perhaps I don't understand your problem. If I change text with formatting
marks, formatting is also shown for this marks (italics, size, font, ...).
Please specify your problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 129276] Feature request - add option for creating layers for images

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129276

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Heiko Tietze  ---
Plenty of options to hide images, let's reserve the layers for Draw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 129276] Feature request - add option for creating layers for images

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129276

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Heiko Tietze  ---
Plenty of options to hide images, let's reserve the layers for Draw.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120275] [META] Writer table alignment bugs and enhancements

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120275

Dieter Praas  changed:

   What|Removed |Added

 Depends on||129458


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129458
[Bug 129458] .docx import: incorrect alignment of tables
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129458] .docx import: incorrect alignment of tables

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129458

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4580
 Blocks||120275
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
I confirm it with 

Version: 6.5.0.0.alpha0+ (x64)
Build ID: e26d89371f0e4f41476c9a99be01d98dedb76776
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

in comparison with MS Word 2016


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120275
[Bug 120275] [META] Writer table alignment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104580] FILEOPEN DOCX: Table alignment is a little bit off

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104580

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||9458

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128956] Switching between two versions of LibreOffice resets user profile

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128956

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1956

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101956] FILEOPEN: No JRE or JDK found in OSX 10.9 and lower, 10.10 and up need full JDK

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101956

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8956

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #12 from Commit Notification 
 ---
Batuhan Görkem Benzer committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b1f3135de3211b0b750571ecdcd9dcab752b544

tdf#124176: Use pragma once instead of header guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/source

2019-12-18 Thread Batuhan Görkem Benzer (via logerrit)
 cui/source/options/sdbcdriverenum.hxx  |8 +---
 cui/source/options/securityoptions.hxx |5 +
 2 files changed, 2 insertions(+), 11 deletions(-)

New commits:
commit 7b1f3135de3211b0b750571ecdcd9dcab752b544
Author: Batuhan Görkem Benzer 
AuthorDate: Wed Dec 18 12:00:05 2019 -0500
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 07:38:25 2019 +0100

tdf#124176: Use pragma once instead of header guard

Change-Id: I720508aa4bfd77f15b5d713e4d948b06af0be4c2
Reviewed-on: https://gerrit.libreoffice.org/85414
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/cui/source/options/sdbcdriverenum.hxx 
b/cui/source/options/sdbcdriverenum.hxx
index 6dfbfd62ff12..ef25bca00430 100644
--- a/cui/source/options/sdbcdriverenum.hxx
+++ b/cui/source/options/sdbcdriverenum.hxx
@@ -17,9 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_SDBCDRIVERENUM_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_SDBCDRIVERENUM_HXX
-
+#pragma once
 
 #include 
 
@@ -53,8 +51,4 @@ namespace offapp
 
 }   // namespace offapp
 
-
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_SDBCDRIVERENUM_HXX
-
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/securityoptions.hxx 
b/cui/source/options/securityoptions.hxx
index 1176bd7fe818..d5ed7b01ac25 100644
--- a/cui/source/options/securityoptions.hxx
+++ b/cui/source/options/securityoptions.hxx
@@ -16,8 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_SECURITYOPTIONS_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_SECURITYOPTIONS_HXX
+#pragma once
 
 #include 
 
@@ -61,6 +60,4 @@ namespace svx
 };
 }
 
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_SECURITYOPTIONS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source

2019-12-18 Thread Mesut Çifci (via logerrit)
 cui/source/options/doclinkdialog.hxx |5 +
 cui/source/options/fontsubs.hxx  |6 ++
 2 files changed, 3 insertions(+), 8 deletions(-)

New commits:
commit 0b827a6a64300430b43dfb48daab33f81d3494de
Author: Mesut Çifci 
AuthorDate: Wed Dec 18 20:00:26 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 07:37:55 2019 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I377809c01053ebaf2fe004478e144509adbbdd1f
Reviewed-on: https://gerrit.libreoffice.org/85416
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/cui/source/options/doclinkdialog.hxx 
b/cui/source/options/doclinkdialog.hxx
index 0e66ebfd6b0c..f9e48f3e57c9 100644
--- a/cui/source/options/doclinkdialog.hxx
+++ b/cui/source/options/doclinkdialog.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_DOCLINKDIALOG_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_DOCLINKDIALOG_HXX
+#pragma once
 
 #include 
 #include 
@@ -59,6 +58,4 @@ namespace svx
 };
 }
 
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_DOCLINKDIALOG_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/fontsubs.hxx b/cui/source/options/fontsubs.hxx
index 880c11675858..0de6d711c3ed 100644
--- a/cui/source/options/fontsubs.hxx
+++ b/cui/source/options/fontsubs.hxx
@@ -16,8 +16,8 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_FONTSUBS_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_FONTSUBS_HXX
+
+#pragma once
 
 #include 
 
@@ -57,6 +57,4 @@ public:
 virtual voidReset( const SfxItemSet* rSet ) override;
 };
 
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_FONTSUBS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #11 from Commit Notification 
 ---
Mesut Çifci committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b827a6a64300430b43dfb48daab33f81d3494de

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - editeng/source

2019-12-18 Thread Muhammet Kara (via logerrit)
 editeng/source/editeng/impedit.cxx |   44 +++--
 1 file changed, 37 insertions(+), 7 deletions(-)

New commits:
commit dc456be2f315bacea4e65d63d3765a54b126cb86
Author: Muhammet Kara 
AuthorDate: Thu Dec 19 08:32:57 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 07:36:58 2019 +0100

lok: Resolves: Calc - selecting a hyperlink doesn't show link in dialog

Change-Id: Ic4264fad8035029ba6593c91fa57efa772d394ca
Reviewed-on: https://gerrit.libreoffice.org/85468
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 

diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 384c44ea93b1..7b920638537c 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -867,6 +867,23 @@ void ImpEditView::CalcAnchorPoint()
 }
 }
 
+namespace
+{
+
+// Build JSON message to be sent to Online
+OString buildHyperlinkJSON(const OUString& sText, const OUString& sLink)
+{
+boost::property_tree::ptree aTree;
+aTree.put("text", sText);
+aTree.put("link", sLink);
+std::stringstream aStream;
+boost::property_tree::write_json(aStream, aTree, false);
+
+return OString(aStream.str().c_str()).trim();
+}
+
+} // End of anon namespace
+
 void ImpEditView::ShowCursor( bool bGotoCursor, bool bForceVisCursor )
 {
 // No ShowCursor in an empty View ...
@@ -1121,21 +1138,34 @@ void ImpEditView::ShowCursor( bool bGotoCursor, bool 
bForceVisCursor )
 }
 else
 {
+
 // is cursor at a mispelled word ?
 Reference< linguistic2::XSpellChecker1 >  xSpeller( 
pEditEngine->pImpEditEngine->GetSpeller() );
 bool bIsWrong = xSpeller.is() && IsWrongSpelledWord(aPaM, 
/*bMarkIfWrong*/ false);
-
 OString sHyperlink;
+
 if (const SvxFieldItem* pFld = GetField(aPos, nullptr, 
nullptr))
 {
 if (auto pUrlField = dynamic_cast(pFld->GetField()))
 {
-boost::property_tree::ptree aTree;
-aTree.put("text", pUrlField->GetRepresentation());
-aTree.put("link", pUrlField->GetURL());
-std::stringstream aStream;
-boost::property_tree::write_json(aStream, aTree, 
false);
-sHyperlink = OString(aStream.str().c_str()).trim();
+sHyperlink = 
buildHyperlinkJSON(pUrlField->GetRepresentation(), pUrlField->GetURL());
+}
+}
+else if (GetEditSelection().HasRange())
+{
+EditView* pActiveView = GetEditViewPtr();
+
+if (pActiveView)
+{
+const SvxFieldItem* pFieldItem = 
pActiveView->GetFieldAtSelection();
+if (pFieldItem)
+{
+const SvxFieldData* pField = 
pFieldItem->GetField();
+if ( auto pUrlField = dynamic_cast( pField) )
+{
+sHyperlink = 
buildHyperlinkJSON(pUrlField->GetRepresentation(), pUrlField->GetURL());
+}
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 127125] Digital Signature Problem

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127125

--- Comment #6 from Dissertation Writing Service 
 ---
Feeling exhausted of old online administrations? Presently utilize Online
Dissertation Writing Services to get together with the new changes. Our master
authors give your college work in a way that will stun your teachers. In this
way, hustle just a bit! Also, click on
https://www.dissertationwritingace.co.uk/.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106984] Searching the CharEscapement attribute does not work from macro

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106984

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 42989] FORMATTING: Selecting Multiple Cells with Different Formats Show as Same Format and Can't Be Changed as a Group

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=42989

--- Comment #10 from mosesantony2013  ---
Bugs are being a great issue nowadays. 
http://howtofixmyprinter.com/how-to-fix-a-printer-that-wont-print/ Bugs fixing
is something that I am looking for. This bug hunting session will definitely
help me out in handling the issues that i have to deal with. Many will be
beneficial because of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127590] [META] Application Programming Interface (API), when all scripted languages are affected

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127590
Bug 127590 depends on bug 75806, which changed state.

Bug 75806 Summary: SearchWords in ReplaceDescriptor
https://bugs.documentfoundation.org/show_bug.cgi?id=75806

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125949] Presentation does not move forward in Linux (not smooth in Windows)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125949

--- Comment #12 from Commit Notification 
 ---
Gülşah Köse committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/dc8706343cebdebc0c1ae2ea00075455088534c8

tdf#125949 Check hardware acceleration on slideshow.

It will be available in 6.4.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125949] Presentation does not move forward in Linux (not smooth in Windows)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125949

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.5.0 target:6.4.0.1 |target:6.5.0 target:6.4.0.1
   ||target:6.4.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - slideshow/Library_slideshow.mk slideshow/source

2019-12-18 Thread Gülşah Köse (via logerrit)
 slideshow/Library_slideshow.mk |4 
 slideshow/source/engine/effectrewinder.cxx |7 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit dc8706343cebdebc0c1ae2ea00075455088534c8
Author: Gülşah Köse 
AuthorDate: Wed Dec 18 15:06:38 2019 +0300
Commit: Gülşah Köse 
CommitDate: Thu Dec 19 07:02:51 2019 +0100

tdf#125949 Check hardware acceleration on slideshow.

Follow up commit for 8eb2d2972583b909a249f5b0f22a9b1fbf533d24
Allows animation if hardware acceleration disabled.

Change-Id: I7997936435134e36e2bf3d3d54ff1bf157cb205c
Reviewed-on: https://gerrit.libreoffice.org/85380
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit 3e88fc6b0eef06e1e12fcfe765e3092c6c06ce5c)
Reviewed-on: https://gerrit.libreoffice.org/85431

diff --git a/slideshow/Library_slideshow.mk b/slideshow/Library_slideshow.mk
index ec3d65989bff..23b8b86ac311 100644
--- a/slideshow/Library_slideshow.mk
+++ b/slideshow/Library_slideshow.mk
@@ -35,6 +35,10 @@ $(eval $(call gb_Library_use_externals,slideshow,\
  ))
 endif
 
+$(eval $(call gb_Library_use_custom_headers,slideshow,\
+   officecfg/registry \
+))
+
 $(eval $(call gb_Library_use_sdk_api,slideshow))
 
 $(eval $(call gb_Library_use_libraries,slideshow,\
diff --git a/slideshow/source/engine/effectrewinder.cxx 
b/slideshow/source/engine/effectrewinder.cxx
index 5db91ff9a621..d8889024108b 100644
--- a/slideshow/source/engine/effectrewinder.cxx
+++ b/slideshow/source/engine/effectrewinder.cxx
@@ -30,6 +30,9 @@
 #include 
 #include 
 #include 
+
+#include 
+
 using ::com::sun::star::uno::Reference;
 using namespace ::com::sun::star;
 
@@ -346,7 +349,9 @@ bool EffectRewinder::notifyAnimationStart (const 
AnimationNodeSharedPtr& rpNode)
 {
 Reference xNode (rpNode->getXAnimationNode());
 
-if(xNode.is() && hasBlockedAnimation(xNode) )
+if( xNode.is() &&
+!officecfg::Office::Canvas::ForceSafeServiceImpl::get() &&
+hasBlockedAnimation(xNode) )
 skipSingleMainSequenceEffects();
 
 // This notification is only relevant for us when the rpNode belongs to
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Alakbar Alikperov

2019-12-18 Thread alakbar Alakbarov
All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 65038] EDITING: Search doesn't replace regular expression with Look assertions (ahead-behind)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65038

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=75
   ||806

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129420] Decrease performance when select many aleatory cells with Ctrl pressed.

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129420

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||caol...@redhat.com
 Blocks||103182

--- Comment #15 from Roman Kuznetsov <79045_79...@mail.ru> ---
Caolan, can you look at it?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||129420


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129420
[Bug 129420] Decrease performance when select many aleatory cells with Ctrl
pressed.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: i18npool/source

2019-12-18 Thread Mike Kaganski (via logerrit)
 i18npool/source/search/textsearch.cxx |   35 +-
 1 file changed, 18 insertions(+), 17 deletions(-)

New commits:
commit eb973a46ba0e34026db2d2929f2aa10505623872
Author: Mike Kaganski 
AuthorDate: Wed Dec 18 15:23:08 2019 +0300
Commit: Mike Kaganski 
CommitDate: Thu Dec 19 05:29:55 2019 +0100

tdf#75806: use actual string leading characters for correct precondition 
match

Having an arbitrary prepended character prevents e.g. matching start of a 
word
for search continuation. Trimming the string to the start of the search 
breaks
correct look-behind assertion matching (e.g. for regexes like 
`(?https://gerrit.libreoffice.org/85382
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/i18npool/source/search/textsearch.cxx 
b/i18npool/source/search/textsearch.cxx
index 4174c6cd1e86..b0361bee89a3 100644
--- a/i18npool/source/search/textsearch.cxx
+++ b/i18npool/source/search/textsearch.cxx
@@ -310,8 +310,22 @@ SearchResult TextSearch::searchForward( const OUString& 
searchStr, sal_Int32 sta
 if ( xTranslit.is() )
 {
 // apply normal transliteration (1<->1, 1<->0)
-css::uno::Sequence offset(endPos - startPos);
-in_str = xTranslit->transliterate( searchStr, startPos, endPos - 
startPos, offset );
+
+sal_Int32 nInStartPos = startPos;
+if (pRegexMatcher && startPos > 0)
+{
+// tdf#89665, tdf#75806: An optimization to avoid transliterating 
the whole string, yet
+// transliterate enough of the leading text to allow sensible 
look-behind assertions.
+// 100 is chosen arbitrarily in the hope that look-behind 
assertions would largely fit.
+// See http://userguide.icu-project.org/strings/regexp for 
look-behind assertion syntax.
+// When search regex doesn't start with an assertion, 3 is to 
allow startPos to be in
+// the middle of a surrogate pair, preceded by another surrogate 
pair.
+const sal_Int32 nMaxLeadingLen = 
aSrchPara.searchString.startsWith("(?") ? 100 : 3;
+nInStartPos -= std::min(nMaxLeadingLen, startPos);
+}
+
+css::uno::Sequence offset(endPos - nInStartPos);
+in_str = xTranslit->transliterate( searchStr, nInStartPos, endPos - 
nInStartPos, offset );
 
 // JP 20.6.2001: also the start and end positions must be corrected!
 sal_Int32 newStartPos =
@@ -321,19 +335,6 @@ SearchResult TextSearch::searchForward( const OUString& 
searchStr, sal_Int32 sta
 ? FindPosInSeq_Impl( offset, endPos )
 : in_str.getLength();
 
-sal_Int32 nExtraOffset = 0;
-if (pRegexMatcher && startPos > 0)
-{
-// avoid matching ^ here - in_str omits a prefix of the searchStr
-// this is a really lame way to do it, but ICU only offers
-// useAnchoringBounds() to disable *both* bounds but what is needed
-// here is to disable only one bound and respect the other
-in_str = "X" + in_str;
-nExtraOffset = 1;
-newStartPos += nExtraOffset;
-newEndPos += nExtraOffset;
-}
-
 sres = (this->*fnForward)( in_str, newStartPos, newEndPos );
 
 // Map offsets back to untransliterated string.
@@ -345,7 +346,7 @@ SearchResult TextSearch::searchForward( const OUString& 
searchStr, sal_Int32 sta
 const sal_Int32 nGroups = sres.startOffset.getLength();
 for ( sal_Int32 k = 0; k < nGroups; k++ )
 {
-const sal_Int32 nStart = sres.startOffset[k] - nExtraOffset;
+const sal_Int32 nStart = sres.startOffset[k];
 // Result offsets are negative (-1) if a group expression was
 // not matched.
 if (nStart >= 0)
@@ -354,7 +355,7 @@ SearchResult TextSearch::searchForward( const OUString& 
searchStr, sal_Int32 sta
 //   the position of the next character - return 
the
 //   next position behind the last found character!
 //   "a b c" find "b" must return 2,3 and not 
2,4!!!
-const sal_Int32 nStop = sres.endOffset[k] - nExtraOffset;
+const sal_Int32 nStop = sres.endOffset[k];
 if (nStop >= 0)
 {
 if (nStop > 0)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source

2019-12-18 Thread Tolunay Dündar (via logerrit)
 cui/source/options/optaboutconfig.hxx   |5 +
 cui/source/options/optaccessibility.hxx |5 +
 2 files changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 9ed0afc79b7da20d08153c2c3e302b061292358f
Author: Tolunay Dündar 
AuthorDate: Wed Dec 18 20:00:02 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 04:43:11 2019 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I47be8a0488b7ff7ce176f10aaf90b8be6913cc8a
Reviewed-on: https://gerrit.libreoffice.org/85412
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/cui/source/options/optaboutconfig.hxx 
b/cui/source/options/optaboutconfig.hxx
index b7781859eb4b..69a207da6712 100644
--- a/cui/source/options/optaboutconfig.hxx
+++ b/cui/source/options/optaboutconfig.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_OPTABOUTCONFIG_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_OPTABOUTCONFIG_HXX
+#pragma once
 
 #include 
 
@@ -93,6 +92,4 @@ public:
 }
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/optaccessibility.hxx 
b/cui/source/options/optaccessibility.hxx
index 93886c73555d..35d5fdefde03 100644
--- a/cui/source/options/optaccessibility.hxx
+++ b/cui/source/options/optaccessibility.hxx
@@ -16,8 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_OPTACCESSIBILITY_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_OPTACCESSIBILITY_HXX
+#pragma once
 
 #include 
 
@@ -40,6 +39,4 @@ public:
 virtual voidReset( const SfxItemSet* rSet ) override;
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #10 from Commit Notification 
 ---
Tolunay Dündar committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ed0afc79b7da20d08153c2c3e302b061292358f

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #9 from Commit Notification 
 ---
Yusuf Keten committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/583c1c34ae9c974f68d21ee6b74baf87ab08c6cf

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cppcanvas/source

2019-12-18 Thread Yusuf Keten (via logerrit)
 cppcanvas/source/inc/action.hxx  |5 +
 cppcanvas/source/inc/canvasgraphichelper.hxx |5 +
 cppcanvas/source/inc/implrenderer.hxx|5 +
 cppcanvas/source/inc/outdevstate.hxx |5 +
 cppcanvas/source/inc/tools.hxx   |5 +
 5 files changed, 5 insertions(+), 20 deletions(-)

New commits:
commit 583c1c34ae9c974f68d21ee6b74baf87ab08c6cf
Author: Yusuf Keten 
AuthorDate: Wed Dec 18 22:13:49 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 04:40:17 2019 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: Id65f17c9785e9db3eecfb1fba6902a04906077e5
Reviewed-on: https://gerrit.libreoffice.org/85428
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/cppcanvas/source/inc/action.hxx b/cppcanvas/source/inc/action.hxx
index 67e67c5aa4dd..bf122292a2fd 100644
--- a/cppcanvas/source/inc/action.hxx
+++ b/cppcanvas/source/inc/action.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CPPCANVAS_SOURCE_INC_ACTION_HXX
-#define INCLUDED_CPPCANVAS_SOURCE_INC_ACTION_HXX
+#pragma once
 
 #include 
 
@@ -146,6 +145,4 @@ namespace cppcanvas
 }
 }
 
-#endif // INCLUDED_CPPCANVAS_SOURCE_INC_ACTION_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cppcanvas/source/inc/canvasgraphichelper.hxx 
b/cppcanvas/source/inc/canvasgraphichelper.hxx
index 48e0b9c35cd2..c1c23657a3f4 100644
--- a/cppcanvas/source/inc/canvasgraphichelper.hxx
+++ b/cppcanvas/source/inc/canvasgraphichelper.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CPPCANVAS_SOURCE_INC_CANVASGRAPHICHELPER_HXX
-#define INCLUDED_CPPCANVAS_SOURCE_INC_CANVASGRAPHICHELPER_HXX
+#pragma once
 
 #include 
 #include 
@@ -69,6 +68,4 @@ namespace cppcanvas
 }
 }
 
-#endif // INCLUDED_CPPCANVAS_SOURCE_INC_CANVASGRAPHICHELPER_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cppcanvas/source/inc/implrenderer.hxx 
b/cppcanvas/source/inc/implrenderer.hxx
index c1224a40c212..6c260c3f3ecd 100644
--- a/cppcanvas/source/inc/implrenderer.hxx
+++ b/cppcanvas/source/inc/implrenderer.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CPPCANVAS_SOURCE_INC_IMPLRENDERER_HXX
-#define INCLUDED_CPPCANVAS_SOURCE_INC_IMPLRENDERER_HXX
+#pragma once
 
 #include 
 
@@ -245,6 +244,4 @@ namespace cppcanvas
 }
 }
 
-#endif // INCLUDED_CPPCANVAS_SOURCE_INC_IMPLRENDERER_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cppcanvas/source/inc/outdevstate.hxx 
b/cppcanvas/source/inc/outdevstate.hxx
index 5c1a4c0d9166..590a7b2ec674 100644
--- a/cppcanvas/source/inc/outdevstate.hxx
+++ b/cppcanvas/source/inc/outdevstate.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CPPCANVAS_SOURCE_INC_OUTDEVSTATE_HXX
-#define INCLUDED_CPPCANVAS_SOURCE_INC_OUTDEVSTATE_HXX
+#pragma once
 
 #include 
 #include 
@@ -124,6 +123,4 @@ namespace cppcanvas
 }
 }
 
-#endif // INCLUDED_CPPCANVAS_SOURCE_INC_OUTDEVSTATE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cppcanvas/source/inc/tools.hxx b/cppcanvas/source/inc/tools.hxx
index 80a238881790..fab00805a93e 100644
--- a/cppcanvas/source/inc/tools.hxx
+++ b/cppcanvas/source/inc/tools.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CPPCANVAS_SOURCE_INC_TOOLS_HXX
-#define INCLUDED_CPPCANVAS_SOURCE_INC_TOOLS_HXX
+#pragma once
 
 #include 
 #include 
@@ -33,6 +32,4 @@ namespace cppcanvas
 }
 }
 
-#endif // INCLUDED_CPPCANVAS_SOURCE_INC_TOOLS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Muhammet Kara (via logerrit)
 loleaflet/src/map/handler/Map.TouchGesture.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 97a463ae8cedd01e0b4fb09ec0870b7729497f51
Author: Muhammet Kara 
AuthorDate: Thu Dec 19 05:58:56 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 04:37:11 2019 +0100

Amend hyperlink popup click patch

Change-Id: I2c2d5ad0ae209d34ac09dcdea7b6ca14b910e482
Reviewed-on: https://gerrit.libreoffice.org/85465
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 

diff --git a/loleaflet/src/map/handler/Map.TouchGesture.js 
b/loleaflet/src/map/handler/Map.TouchGesture.js
index 6b472a27e..f59604c82 100644
--- a/loleaflet/src/map/handler/Map.TouchGesture.js
+++ b/loleaflet/src/map/handler/Map.TouchGesture.js
@@ -298,7 +298,7 @@ L.Map.TouchGesture = L.Handler.extend({
this._toolbar.remove();
 
// clicked a hyperlink popup - not really designed for this.
-   if (this._map.hyperlinkPopup !== null && e.target != null &&
+   if (this._map.hyperlinkPopup && e.target &&
this._map.hyperlinkPopup._contentNode == 
e.target.parentNode)
this._map.fire('hyperlinkclicked', {url: 
e.target.href});
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 129169] HELP: "Selecting a new color" page needs to improve "To access this command..." section.

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129169

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129177] [macOS] Change the language pack format into .oxt for better manageability

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129177

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129194] Impress pptx in presentation mode freezes after windows going into sleep mode

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129194

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129178] [macOS] (At least) Bundle all system provided localisations with LibreOffice

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129178

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129457] writer pdf text import crash

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129457

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129465] Form in LO Base: Text and option are not at the same level

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129465

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121985] Editing any slide element (text, shapes, images, etc.) causes noticeable lags

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121985

--- Comment #14 from QA Administrators  ---
Dear Stefan Zurucker,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124522] Installation fails on Windows x86

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124522

--- Comment #11 from QA Administrators  ---
Dear Dimitar Nanev,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120883] [META] Hyphenation bugs and enhancements

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120883
Bug 120883 depends on bug 121474, which changed state.

Bug 121474 Summary: Hyphenation for Indonesian Language is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=121474

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121474] Hyphenation for Indonesian Language is not working

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121474

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121985] Editing any slide element (text, shapes, images, etc.) causes noticeable lags

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121985

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125498] Can't insert any PNG image into document

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125498

--- Comment #26 from QA Administrators  ---
Dear tantrido,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121474] Hyphenation for Indonesian Language is not working

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121474

--- Comment #5 from QA Administrators  ---
Dear M. S. Rosyidi,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125402] I believe I overloaded the memory

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125402

--- Comment #4 from QA Administrators  ---
Dear Lon,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96215] LibreOffice hangs/won't start if some mounted shares are inaccessible

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96215

--- Comment #9 from QA Administrators  ---
Dear Saren Tasciyan,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125402] I believe I overloaded the memory

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125402

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113117
Bug 113117 depends on bug 124522, which changed state.

Bug 124522 Summary: Installation fails on Windows x86
https://bugs.documentfoundation.org/show_bug.cgi?id=124522

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124522] Installation fails on Windows x86

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124522

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104739] FILEOPEN: Some symbols are incorrectly displayed

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104739

--- Comment #5 from QA Administrators  ---
Dear Xisco Faulí,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72364] PDF import fails on Unix on CIFS mounts (windows shares)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=72364

--- Comment #12 from QA Administrators  ---
Dear Lionel Elie Mamane,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Michael Meeks (via logerrit)
 loleaflet/src/layer/tile/TileLayer.js |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 63c7055068ca920064804c6b90a14b8d337ad3b2
Author: Michael Meeks 
AuthorDate: Thu Dec 19 02:32:49 2019 +
Commit: Michael Meeks 
CommitDate: Thu Dec 19 04:30:56 2019 +0100

mobile: fix busy-idle loop consuming CPU.

Loop is a constant re-layout:

hide
_onUserListRefresh
onRefresh
trigger
refresh
(anonymous)
setTimeout (async)
hide

introduced by: e8b5f75ebe838fcebceddb9bf8590efb28cc8007
mobile: Don't show the user list in the native app.

Change-Id: I4a9efaf5e2779cf21b838b99ef4928b26e2f6358
Reviewed-on: https://gerrit.libreoffice.org/85464
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index e189795e3..0a3d848b0 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1368,9 +1368,15 @@ L.TileLayer = L.GridLayer.extend({

!window.ThisIsAMobileApp &&

((window.mode.isMobile() && $.inArray('mobile', map['wopi'].HideUserList) < 0) 
||
(window.mode.isTablet() 
&& $.inArray('tablet', map['wopi'].HideUserList) < 0));
+
+   // Otherwise we can get an infinte, fast busy timeout loop.
+   if (toolbar.get('userlist').hidden == !showUserList)
+   return;
+
map.off('deselectuser', window.deselectUser);
map.off('addview', window.onAddView);
map.off('removeview', window.onRemoveView);
+
if (showUserList) {
toolbar.show('userlist');
toolbar.show('userlistbreak');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Muhammet Kara (via logerrit)
 loleaflet/src/control/Control.Toolbar.js |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 92889c28aff7f240b8f21c1436672354a448ce81
Author: Muhammet Kara 
AuthorDate: Thu Dec 19 05:23:07 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 04:26:55 2019 +0100

Close hyperlinkPopup when we get out of InsertMode

Change-Id: Ia7ae55f8a8d1b02ca7ae17c03fca7f835534237c
Reviewed-on: https://gerrit.libreoffice.org/85463
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Muhammet Kara 

diff --git a/loleaflet/src/control/Control.Toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
index bf1997688..f807684d4 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -1861,6 +1861,12 @@ function onCommandStateChanged(e) {
}
else if (commandName === '.uno:InsertMode') {
updateToolbarItem(statusbar, 'InsertMode', 
$('#InsertMode').html(state ? L.Styles.insertMode[state].toLocaleString() : 
'Insert mode: 
inactive').parent().html());
+
+   if (!state && map.hyperlinkPopup) {
+   map.hyperlinkUnderCursor = null;
+   map.closePopup(map.hyperlinkPopup);
+   map.hyperlinkPopup = null;
+   }
}
else if (commandName === '.uno:StatusSelectionMode' ||
 commandName === '.uno:SelectionMode') {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128987

--- Comment #4 from Stanislaus J. Pinasthika  ---
No reproduce in
Version: 6.3.4.2
Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: kde5; 
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

and

Version: 6.5.0.0.alpha0+
Build ID: 5030be4e85179147476b1e441eb618fb6ed58235
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-11-28_20:14:48
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: CL

can you tell us about the detail of the Writer?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128987] Bad font rendering in Writer, mainly with serif fonts: it seems like font kerning has gone awry

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128987

Stanislaus J. Pinasthika  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Stanislaus J. Pinasthika  ---
set to NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - ucb/source

2019-12-18 Thread Thorsten Behrens (via logerrit)
 ucb/source/ucp/webdav-neon/NeonLockStore.cxx |4 
 ucb/source/ucp/webdav-neon/NeonSession.cxx   |1 +
 ucb/source/ucp/webdav-neon/webdavcontent.cxx |2 ++
 3 files changed, 7 insertions(+)

New commits:
commit b24d61f43b0fbde918ecf0b05761a4da8a106188
Author: Thorsten Behrens 
AuthorDate: Thu Dec 19 03:42:48 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Dec 19 03:43:34 2019 +0100

More diagnostics

Change-Id: Ib29e6422623d407a0526272752c03ab4452b0a9d

diff --git a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx 
b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
index 85b821b2bd87..c2558c5fc8d6 100644
--- a/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonLockStore.cxx
@@ -77,6 +77,8 @@ void TickerThread::execute()
 nCount = nNth;
 }
 
+SAL_INFO( "ucb.ucp.webdav", "TickerThread: wait." );
+
 TimeValue aTV;
 aTV.Seconds = 0;
 aTV.Nanosec = 10 / nNth;
@@ -230,11 +232,13 @@ void NeonLockStore::refreshLocks()
 {
 rInfo.nLastChanceToSendRefreshRequest
 = nlastChanceToSendRefreshRequest;
+SAL_INFO( "ucb.ucp.webdav", "refreshed lock." );
 }
 else
 {
 // refresh failed. stop auto-refresh.
 rInfo.nLastChanceToSendRefreshRequest = -1;
+SAL_INFO( "ucb.ucp.webdav", "failed to refresh lock." );
 }
 }
 }
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx 
b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index c1336c07a9c0..6eaa3f542a99 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -862,6 +862,7 @@ void NeonSession::OPTIONS( const OUString & inPath,
 //check if http error is in the 200 class (no error)
 if (theRetVal == NE_OK && ne_get_status(req)->klass != 2) {
 theRetVal = NE_ERROR;
+SAL_INFO( "ucb.ucp.webdav", "OPTIONS - got an error <" << 
ne_get_status(req)->klass << ">" );
 }
 
 if ( theRetVal == NE_OK )
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx 
b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 0f99aa1fe637..10690b142c89 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -3927,6 +3927,8 @@ Content::ResourceType Content::getResourceType(
 NeonUri   theUri( rURL );
 OUString  aHostName  = theUri.GetHost();
 sal_Int32 nPort  = theUri.GetPort();
+SAL_WARN( "ucb.ucp.webdav", "Content::getResourceType 
returned errors, DAV ExceptionCode: " << DAVException::DAV_HTTP_TIMEOUT << ", 
from host: "  << aHostName );
+
 throw DAVException( DAVException::DAV_HTTP_TIMEOUT,
 NeonUri::makeConnectionEndPointString( 
aHostName,

nPort ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Michael Meeks (via logerrit)
 loleaflet/src/map/handler/Map.TouchGesture.js |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 25446b4a82ba0bea615edcedc9529d194a825827
Author: Michael Meeks 
AuthorDate: Thu Dec 19 01:48:10 2019 +
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 03:33:21 2019 +0100

mobile: launch links from link popups when tapped.

Change-Id: I5ba9234d8c253ffdcbfd0d93c6ef72a70ff46f17
Reviewed-on: https://gerrit.libreoffice.org/85462
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Muhammet Kara 

diff --git a/loleaflet/src/map/handler/Map.TouchGesture.js 
b/loleaflet/src/map/handler/Map.TouchGesture.js
index d682cb4c5..6b472a27e 100644
--- a/loleaflet/src/map/handler/Map.TouchGesture.js
+++ b/loleaflet/src/map/handler/Map.TouchGesture.js
@@ -297,6 +297,11 @@ L.Map.TouchGesture = L.Handler.extend({
if (window.ThisIsTheiOSApp)
this._toolbar.remove();
 
+   // clicked a hyperlink popup - not really designed for this.
+   if (this._map.hyperlinkPopup !== null && e.target != null &&
+   this._map.hyperlinkPopup._contentNode == 
e.target.parentNode)
+   this._map.fire('hyperlinkclicked', {url: 
e.target.href});
+
this._map.fire('closepopups');
this._map.fire('closemobilewizard');
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2019-12-18 Thread Tomaž Vajngerl (via logerrit)
 sc/source/ui/view/gridwin.cxx |   26 +++---
 1 file changed, 19 insertions(+), 7 deletions(-)

New commits:
commit 7fb88645d20c1b1ec4aca41d0d96c457333282a7
Author: Tomaž Vajngerl 
AuthorDate: Wed Dec 18 22:32:07 2019 +0100
Commit: Michael Meeks 
CommitDate: Thu Dec 19 03:04:06 2019 +0100

lok: send "EMPTY" if the rect is empty for cell selection or fill

It can happen that the selection or auto-fill rectangles are
empty and if that's the case then we need to send "EMPTY" string
and not the content of an empty rectangle (0, 0, -32768, -32768).

This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in
calc.

Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3
Reviewed-on: https://gerrit.libreoffice.org/85441
Tested-by: Jenkins
Reviewed-by: Michael Meeks 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 28fbef5fb1f7..c6833d7fe2aa 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5930,7 +5930,10 @@ void ScGridWindow::UpdateKitSelection(const 
std::vector& rRect
 }
 
 ScTabViewShell* pViewShell = pViewData->GetViewShell();
-pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
aBoundingBox.toString().getStr());
+OString sBoundingBoxString = "EMPTY";
+if (!aBoundingBox.IsEmpty())
+sBoundingBoxString = aBoundingBox.toString();
+pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
sBoundingBoxString.getStr());
 pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, 
rectanglesToString(aLogicRects).getStr());
 
 for (SfxViewShell* it = SfxViewShell::GetFirst(); it;
@@ -5980,7 +5983,11 @@ void ScGridWindow::updateOtherKitSelections() const
 OString aRectsString = rectanglesToString(aOtherLogicRects);
 if (it == pViewShell)
 {
-
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
aBoundingBox.toString().getStr());
+OString sBoundingBoxString = "EMPTY";
+if (!aBoundingBox.IsEmpty())
+sBoundingBoxString = aBoundingBox.toString();
+
+
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
sBoundingBoxString.getStr());
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, 
aRectsString.getStr());
 }
 else
@@ -6000,13 +6007,18 @@ void updateLibreOfficeKitAutoFill(const ScViewData* 
pViewData, tools::Rectangle
 double nPPTX = pViewData->GetPPTX();
 double nPPTY = pViewData->GetPPTY();
 
-// selection start handle
-tools::Rectangle aLogicRectangle(
-rRectangle.Left()  / nPPTX, rRectangle.Top() / nPPTY,
-rRectangle.Right() / nPPTX, rRectangle.Bottom() / nPPTY);
+OString sRectangleString = "EMPTY";
+if (!rRectangle.IsEmpty())
+{
+// selection start handle
+tools::Rectangle aLogicRectangle(
+rRectangle.Left()  / nPPTX, rRectangle.Top() / nPPTY,
+rRectangle.Right() / nPPTX, rRectangle.Bottom() / nPPTY);
+sRectangleString = aLogicRectangle.toString();
+}
 
 ScTabViewShell* pViewShell = pViewData->GetViewShell();
-pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_AUTO_FILL_AREA, 
aLogicRectangle.toString().getStr());
+pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_AUTO_FILL_AREA, 
sRectangleString.getStr());
 }
 
 } //end anonymous namespace
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Muhammet Kara (via logerrit)
 loleaflet/src/control/Toolbar.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0d2db9ba308924b783b3c2e0e1c9fd6c98b30ccf
Author: Muhammet Kara 
AuthorDate: Thu Dec 19 03:45:12 2019 +0300
Commit: Michael Meeks 
CommitDate: Thu Dec 19 03:03:19 2019 +0100

Non-case sensitive link checking in the hyperlink dialog

Change-Id: I1f31946e68d22c89acffdba5a5b55203892712c1
Reviewed-on: https://gerrit.libreoffice.org/85460
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js
index 52735d7da..07d802835 100644
--- a/loleaflet/src/control/Toolbar.js
+++ b/loleaflet/src/control/Toolbar.js
@@ -436,7 +436,7 @@ L.Map.include({
},
 
makeURLFromStr: function(str) {
-   if (!(str.startsWith('http://') || str.startsWith('https://'))) 
{
+   if (!(str.toLowerCase().startsWith('http://') || 
str.toLowerCase().startsWith('https://'))) {
str = 'http://' + str;
}
return str;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-0' - 2 commits - loleaflet/po

2019-12-18 Thread Eloy Crespo (via logerrit)
 loleaflet/po/ui-es.po|  539 
 loleaflet/po/ui-pt_BR.po |  575 +--
 2 files changed, 660 insertions(+), 454 deletions(-)

New commits:
commit 8c726580d7b8f935add9d35355ce33230f102f81
Author: Eloy Crespo 
AuthorDate: Wed Dec 18 23:43:36 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 01:59:26 2019 +0100

Updated es translation.

Change-Id: I4b95d8ef566a0475362e6d87cf259a06801fa523
Reviewed-on: https://gerrit.libreoffice.org/85447
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/po/ui-es.po b/loleaflet/po/ui-es.po
index fd04a8ffe..430b9c448 100644
--- a/loleaflet/po/ui-es.po
+++ b/loleaflet/po/ui-es.po
@@ -6,17 +6,19 @@ msgid ""
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2019-11-04 20:16+0100\n"
-"PO-Revision-Date: 2019-11-04 20:33+0100\n"
-"Language: es\n"
+"POT-Creation-Date: 2019-12-18 12:26+0100\n"
+"PO-Revision-Date: 2019-12-14 18:56+\n"
+"Last-Translator: Adolfo Jayme Barrientos \n"
+"Language-Team: Spanish \n"
+"Language: \n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"X-Generator: Poedit 2.2.1\n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 3.9.1\n"
 "X-Pootle-Path: /es/libo_online/loleaflet-ui-es.po\n"
 "X-Pootle-Revision: 3939976\n"
-"Last-Translator: \n"
-"Language-Team: \n"
 
 #: admin/admin.strings.js:6
 msgid "Admin console"
@@ -118,8 +120,8 @@ msgstr "Gráfico de CPU"
 msgid "Network Graph"
 msgstr "Gráfico de red"
 
-#: admin/admin.strings.js:31 src/layer/marker/Annotation.js:249
-#: src/layer/tile/TileLayer.js:377
+#: admin/admin.strings.js:31 src/layer/marker/Annotation.js:251
+#: src/layer/tile/TileLayer.js:383
 msgid "Save"
 msgstr "Guardar"
 
@@ -141,15 +143,11 @@ msgstr "Intervalo de tiempo de estadísticas de CPU (en 
ms)"
 
 #: admin/admin.strings.js:36
 msgid "Maximum Document process virtual memory (in MB) - reduce only"
-msgstr ""
-"Memoria virtual máxima para procesamiento de documentos (en MB) — solo "
-"reducción"
+msgstr "Memoria virtual máxima para procesamiento de documentos (en MB) — solo 
reducción"
 
 #: admin/admin.strings.js:37
 msgid "Maximum Document process stack memory (in KB) - reduce only"
-msgstr ""
-"Memoria de pila máxima para procesamiento de documentos (en kB) — solo "
-"reducción"
+msgstr "Memoria de pila máxima para procesamiento de documentos (en kB) — solo 
reducción"
 
 #: admin/admin.strings.js:38
 msgid "Maximum file size allowed to write to disk (in MB) - reduce only"
@@ -183,7 +181,7 @@ msgstr "Recibidos"
 msgid "Sent"
 msgstr "Enviados"
 
-#: admin/src/AdminSocketBase.js:46
+#: admin/src/AdminSocketBase.js:54
 msgid "Connection error"
 msgstr "Error de conexión"
 
@@ -237,11 +235,9 @@ msgstr "Editar"
 
 #: src/control/Control.AlertDialog.js:76
 msgid "The server encountered a %0 error while parsing the %1 command."
-msgstr ""
-"Se produjo el error %0 en el servidor durante el procesamiento de la orden "
-"%1."
+msgstr "Se produjo el error %0 en el servidor durante el procesamiento de la 
orden %1."
 
-#: src/control/Control.ContextMenu.js:172
+#: src/control/Control.ContextMenu.js:234
 msgid "Paste Special"
 msgstr "Pegado especial"
 
@@ -257,7 +253,7 @@ msgstr "Tipo"
 msgid "Index"
 msgstr "Índice"
 
-#: src/control/Control.DocumentRepair.js:48 src/layer/tile/TileLayer.js:273
+#: src/control/Control.DocumentRepair.js:48 src/layer/tile/TileLayer.js:279
 msgid "Comment"
 msgstr "Comentario"
 
@@ -273,7 +269,7 @@ msgstr "Cronomarcador"
 msgid "Jump to state"
 msgstr "Saltar al estado"
 
-#: src/control/Control.DocumentRepair.js:95 src/control/Control.Toolbar.js:2354
+#: src/control/Control.DocumentRepair.js:95 src/control/Control.Toolbar.js:2442
 msgid "You"
 msgstr "Usted"
 
@@ -293,126 +289,186 @@ msgstr "Iniciar carga"
 msgid "Start cross copy/paste"
 msgstr "Iniciar el copiado/pegado cruzado"
 
-#: src/control/ColorPicker.js:104
+#: src/control/ColorPicker.js:121
 msgid "No color"
-msgstr ""
+msgstr "Sin color"
+
+#: src/control/Control.JSDialogBuilder.js:150
+msgid "Linear"
+msgstr "Lineal"
+
+#: src/control/Control.JSDialogBuilder.js:153
+msgid "Axial"
+msgstr "Axial"
+
+#: src/control/Control.JSDialogBuilder.js:156
+msgid "Radial"
+msgstr "Radial"
+
+#: src/control/Control.JSDialogBuilder.js:159
+msgid "Elipsoid"
+msgstr "Elipsoide"
 
-#: src/control/Control.JSDialogBuilder.js:415
+#: src/control/Control.JSDialogBuilder.js:163
+msgid "Quadratic"
+msgstr "Cuadrático"
+
+#: src/control/Control.JSDialogBuilder.js:166
+msgid "Square"
+msgstr "Cuadrado"
+
+#: src/control/Control.JSDialogBuilder.js:169
+msgid "Fixed size"
+msgstr "Tamaño fijo"
+
+#: src/control/Control.JSDialogBuilder.js:541
 msgid "\""
-msgstr ""
+msgstr "\""
 
-#: src/control/Control.JSDialogBuilder.js:417
+#: 

[Libreoffice-commits] core.git: cui/source

2019-12-18 Thread Onur Yilmaz (via logerrit)
 cui/source/options/certpath.hxx |5 +
 cui/source/options/cfgchart.hxx |5 +
 2 files changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 42a1a1c6b91907f81e15066ffab219411f18c4db
Author: Onur Yilmaz 
AuthorDate: Wed Dec 18 20:00:14 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 01:50:29 2019 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I2f58499164254eab1d2f628b3b64710e1d2efbeb
Reviewed-on: https://gerrit.libreoffice.org/85415
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/cui/source/options/certpath.hxx b/cui/source/options/certpath.hxx
index c23812eefed3..b040a31d3c94 100644
--- a/cui/source/options/certpath.hxx
+++ b/cui/source/options/certpath.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_CERTPATH_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_CERTPATH_HXX
+#pragma once
 
 #include 
 
@@ -37,6 +36,4 @@ public:
 OUString getDirectory() const;
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/cfgchart.hxx b/cui/source/options/cfgchart.hxx
index 4984d1bd31e8..acbe41a9b41e 100644
--- a/cui/source/options/cfgchart.hxx
+++ b/cui/source/options/cfgchart.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CUI_SOURCE_OPTIONS_CFGCHART_HXX
-#define INCLUDED_CUI_SOURCE_OPTIONS_CFGCHART_HXX
+#pragma once
 
 #include 
 #include 
@@ -98,6 +97,4 @@ private:
 SvxChartColorTable  m_aColorTable;
 };
 
-#endif // INCLUDED_CUI_SOURCE_OPTIONS_CFGCHART_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #8 from Commit Notification 
 ---
Onur Yilmaz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/42a1a1c6b91907f81e15066ffab219411f18c4db

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - translations

2019-12-18 Thread Andras Timar (via logerrit)
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1582de1f4865b0327aa14c4f67657cd8b36fadac
Author: Andras Timar 
AuthorDate: Thu Dec 19 01:27:49 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Dec 19 01:27:57 2019 +0100

Update git submodules

* Update translations from branch 'distro/collabora/cp-6.2'
  - Update es and pt-BR translations

Change-Id: I7f48a97e1fb0eab4537e056785c33a2a6ef7dc88

diff --git a/translations b/translations
index 21a72a15fc8e..a06c7f48d883 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 21a72a15fc8e4540c5f095ca9b23ae6c5bd875c6
+Subproject commit a06c7f48d88361349bd0500f8310197f9e8d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] translations.git: Branch 'distro/collabora/cp-6.2' - source/es source/pt-BR

2019-12-18 Thread Andras Timar (via logerrit)
 source/es/officecfg/registry/data/org/openoffice/Office/UI.po|  359 
+-
 source/pt-BR/officecfg/registry/data/org/openoffice/Office/UI.po |  319 

 2 files changed, 647 insertions(+), 31 deletions(-)

New commits:
commit a06c7f48d88361349bd0500f8310197f9e8d
Author: Andras Timar 
AuthorDate: Thu Dec 19 01:27:49 2019 +0100
Commit: Andras Timar 
CommitDate: Thu Dec 19 01:27:49 2019 +0100

Update es and pt-BR translations

Change-Id: I7f48a97e1fb0eab4537e056785c33a2a6ef7dc88

diff --git a/source/es/officecfg/registry/data/org/openoffice/Office/UI.po 
b/source/es/officecfg/registry/data/org/openoffice/Office/UI.po
index b94d803a3e9..60cbbc62519 100644
--- a/source/es/officecfg/registry/data/org/openoffice/Office/UI.po
+++ b/source/es/officecfg/registry/data/org/openoffice/Office/UI.po
@@ -1,20 +1,19 @@
-#. extracted from officecfg/registry/data/org/openoffice/Office/UI
 msgid ""
 msgstr ""
-"Project-Id-Version: PACKAGE VERSION\n"
+"Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2018-12-18 19:46+0100\n"
-"PO-Revision-Date: 2019-02-19 13:54+\n"
+"POT-Creation-Date: 2019-12-18 23:05+0100\n"
+"PO-Revision-Date: 2019-12-19 01:24+0100\n"
 "Last-Translator: Adolfo Jayme Barrientos \n"
-"Language-Team: LANGUAGE \n"
 "Language: es\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 "X-Accelerator-Marker: ~\n"
-"X-Generator: Pootle 2.8\n"
+"X-Generator: Poedit 2.2.1\n"
 "X-POOTLE-MTIME: 1550584475.00\n"
+"Language-Team: \n"
 
 #: BaseWindowState.xcu
 msgctxt ""
@@ -2381,7 +2380,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "Insert Co~lumns Before"
-msgstr ""
+msgstr "Insertar columnas antes"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -2390,7 +2389,7 @@ msgctxt ""
 "ContextLabel\n"
 "value.text"
 msgid "Columns ~Before"
-msgstr ""
+msgstr "Columnas antes"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -2399,7 +2398,7 @@ msgctxt ""
 "PopupLabel\n"
 "value.text"
 msgid "Insert Columns ~Before"
-msgstr ""
+msgstr "Insertar columnas antes"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -2435,7 +2434,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "Insert Co~lumns After"
-msgstr ""
+msgstr "Insertar columnas después"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -2444,7 +2443,7 @@ msgctxt ""
 "ContextLabel\n"
 "value.text"
 msgid "Columns ~After"
-msgstr ""
+msgstr "Columnas después"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -2453,7 +2452,7 @@ msgctxt ""
 "PopupLabel\n"
 "value.text"
 msgid "Insert Columns ~After"
-msgstr ""
+msgstr "Insertar columnas después"
 
 #: CalcCommands.xcu
 msgctxt ""
@@ -7333,6 +7332,15 @@ msgctxt ""
 msgid "Slide Transition"
 msgstr "Transición entre diapositivas"
 
+#: DrawImpressCommands.xcu
+msgctxt ""
+"DrawImpressCommands.xcu\n"
+"..DrawImpressCommands.UserInterface.Commands..uno:MasterSlidesPanel\n"
+"Label\n"
+"value.text"
+msgid "Master Slides"
+msgstr "Patrones de diapositivas"
+
 #: DrawImpressCommands.xcu
 msgctxt ""
 "DrawImpressCommands.xcu\n"
@@ -7493,7 +7501,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "~Slide Number"
-msgstr ""
+msgstr "Número de diapositiva"
 
 #: DrawImpressCommands.xcu
 msgctxt ""
@@ -7511,7 +7519,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "Slide Tit~le"
-msgstr ""
+msgstr "Título de diapositiva"
 
 #: DrawImpressCommands.xcu
 msgctxt ""
@@ -7529,7 +7537,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "Slide ~Count"
-msgstr ""
+msgstr "Contar diapositivas"
 
 #: DrawImpressCommands.xcu
 msgctxt ""
@@ -8126,12 +8134,13 @@ msgid "~Interaction..."
 msgstr "~Interacción..."
 
 #: DrawImpressCommands.xcu
+#, fuzzy
 msgctxt ""
 "DrawImpressCommands.xcu\n"
 "..DrawImpressCommands.UserInterface.Commands..uno:PresentationLayout\n"
 "Label\n"
 "value.text"
-msgid "Master Slide..."
+msgid "Master Slide D~esign..."
 msgstr "Patrón de diapositivas…"
 
 #: DrawImpressCommands.xcu
@@ -8467,6 +8476,15 @@ msgctxt ""
 msgid "Ellipse"
 msgstr "Elipse"
 
+#: DrawImpressCommands.xcu
+msgctxt ""
+"DrawImpressCommands.xcu\n"
+"..DrawImpressCommands.UserInterface.Commands..uno:RedactedExportToolbox\n"
+"Label\n"
+"value.text"
+msgid "Redacted Export"
+msgstr "Exportación censurada"
+
 #: DrawImpressCommands.xcu
 msgctxt ""
 "DrawImpressCommands.xcu\n"
@@ -8897,7 +8915,7 @@ msgctxt ""
 "Label\n"
 "value.text"
 msgid "Zoom & Pan"
-msgstr ""
+msgstr "Escala y panorámica"
 
 #: DrawImpressCommands.xcu
 msgctxt ""
@@ -9970,6 +9988,24 @@ msgctxt ""
 msgid "Hanging Indent"
 msgstr "Sangría francesa"
 
+#: DrawImpressCommands.xcu
+msgctxt ""
+"DrawImpressCommands.xcu\n"
+"..DrawImpressCommands.UserInterface.Popups..uno:RedactedExportBlack\n"
+"Label\n"
+"value.text"
+msgid "Redacted Export (Black)"
+msgstr "Exportación censurada (negro)"
+
+#: DrawImpressCommands.xcu
+msgctxt ""
+"DrawImpressCommands.xcu\n"

[Libreoffice-bugs] [Bug 129457] writer pdf text import crash

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129457

--- Comment #9 from paolo_debort...@yahoo.com ---
I have the same result with every .pdf file.

when I try to connect .pdf as a ole object, the software blocks and the only
one solution is forcing close the window.

when I try to insert text from .txt document, it doesn't do anything at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: android/lib loleaflet/src

2019-12-18 Thread Michael Meeks (via logerrit)
 android/lib/src/main/cpp/androidapp.cpp  |   42 +++
 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |  124 
++
 loleaflet/src/control/Control.JSDialogBuilder.js |2 
 loleaflet/src/map/Map.js |2 
 4 files changed, 126 insertions(+), 44 deletions(-)

New commits:
commit 76114dd957e8f121969dd206213b3a31a4de7afc
Author: Michael Meeks 
AuthorDate: Wed Dec 18 17:10:04 2019 +
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 01:19:08 2019 +0100

android: improved native copy/paste.

don't do copy/paste in the JS if we can avoid it.
support text & html for cut / copy and share code.
inject our own origin cookie to allow local short-circuiting.

Change-Id: I3187104e9602e86b50cf52d45a9277db44ca8b3b
Reviewed-on: https://gerrit.libreoffice.org/85455
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 

diff --git a/android/lib/src/main/cpp/androidapp.cpp 
b/android/lib/src/main/cpp/androidapp.cpp
index d964d3579..577df5a90 100644
--- a/android/lib/src/main/cpp/androidapp.cpp
+++ b/android/lib/src/main/cpp/androidapp.cpp
@@ -333,11 +333,47 @@ Java_org_libreoffice_androidlib_LOActivity_saveAs(JNIEnv 
*env, jobject instance,
 env->ReleaseStringUTFChars(format_, format);
 }
 
+static jstring tojstringAndFree(JNIEnv *env, char *str)
+{
+if (!str)
+return env->NewStringUTF("");
+jstring ret = env->NewStringUTF(str);
+free(str);
+return ret;
+}
+
 extern "C"
-JNIEXPORT jstring JNICALL
-Java_org_libreoffice_androidlib_LOActivity_getTextSelection(JNIEnv *env, 
jobject instance) {
+JNIEXPORT jobjectArray JNICALL
+Java_org_libreoffice_androidlib_LOActivity_getClipboardContent(JNIEnv *env, 
jobject instance)
+{
+const char *mimeTypes[] = { "text/plain;charset=utf-8", "text/html", 
nullptr };
+size_t outCount = 0;
+char  **outMimeTypes = nullptr;
+size_t *outSizes = nullptr;
+char  **outStreams = nullptr;
+
+jobjectArray values = 
(jobjectArray)env->NewObjectArray(2,env->FindClass("java/lang/String"),env->NewStringUTF(""));
+
+if (getLOKDocument()->getClipboard(mimeTypes,
+   , ,
+   , ))
+{
+if (outCount != 2)
+LOG_DBG("clipboard fetch produced wrong results");
+else
+{
+env->SetObjectArrayElement(values,0,tojstringAndFree(env, 
outStreams[0]));
+env->SetObjectArrayElement(values,1,tojstringAndFree(env, 
outStreams[1]));
+free (outMimeTypes[0]);
+free (outMimeTypes[1]);
+free (outMimeTypes);
+free (outStreams);
+}
+}
+else
+LOG_DBG("failed to fetch mime-types");
 
-return 
env->NewStringUTF(getLOKDocument()->getTextSelection("text/plain;charset=utf-8"));
+return values;
 }
 
 extern "C"
diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index e1efc01f9..713032122 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -78,6 +78,9 @@ public class LOActivity extends AppCompatActivity {
 
 private int providerId;
 
+/// Unique number identifying this app + document.
+private long loadDocumentMillis = 0;
+
 @Nullable
 private URI documentUri;
 
@@ -478,6 +481,8 @@ public class LOActivity extends AppCompatActivity {
 mWebView.loadUrl(finalUrlToLoad);
 
 documentLoaded = true;
+
+loadDocumentMillis = android.os.SystemClock.uptimeMillis();
 }
 
 static {
@@ -564,46 +569,13 @@ public class LOActivity extends AppCompatActivity {
 case "uno":
 switch (messageAndParam[1]) {
 case ".uno:Paste":
-clipData = clipboardManager.getPrimaryClip();
-if (clipData != null) {
-if 
(clipData.getDescription().hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
-final ClipData.Item clipItem = 
clipData.getItemAt(0);
-nativeHandler.post(new Runnable() {
-@Override
-public void run() {
-
LOActivity.this.paste("text/plain;charset=utf-16", 
clipItem.getText().toString());
-}
-});
-}
-return false;
-}
+return performPaste();
+case ".uno:Copy":
+case ".uno:Cut":
+populateClipboard();
 break;
- 

[Libreoffice-bugs] [Bug 129457] writer pdf text import crash

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129457

--- Comment #8 from paolo_debort...@yahoo.com ---
Created attachment 156661
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156661=edit
crash result window

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129457] writer pdf text import crash

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129457

--- Comment #7 from paolo_debort...@yahoo.com ---
Created attachment 156660
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156660=edit
example .pdf file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - unotools/source

2019-12-18 Thread Jan Holesovsky (via logerrit)
 unotools/source/i18n/resmgr.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit ccd8a05b417361fdbe9c3736e9097e5c12efa479
Author: Jan Holesovsky 
AuthorDate: Wed Dec 18 23:07:11 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 01:01:40 2019 +0100

android: Use correct path for the .mo resource files.

They are read by boost::locale, so we cannot have them as normal assets,
instead we have to have them in asset's 'unpack', so that they are
unpacked to the filesystem and can be read as normal files.

Change-Id: I5e902ee4b5294d1f693f51993b8bc2069f1c835a
Reviewed-on: https://gerrit.libreoffice.org/85442
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 

diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx
index ca384cf42a72..a7a1606a6aaa 100644
--- a/unotools/source/i18n/resmgr.cxx
+++ b/unotools/source/i18n/resmgr.cxx
@@ -68,6 +68,10 @@
 #include 
 #include 
 
+#ifdef ANDROID
+#include 
+#endif
+
 #if defined(_WIN32) && defined(DBG_UTIL)
 #include 
 #include 
@@ -140,11 +144,15 @@ namespace Translate
 boost::locale::generator gen;
 gen.characters(boost::locale::char_facet);
 gen.categories(boost::locale::message_facet | 
boost::locale::information_facet);
+#if defined(ANDROID)
+OString sPath(OString(lo_get_app_data_dir()) + "/program/resource");
+#else
 OUString uri("$BRAND_BASE_DIR/$BRAND_SHARE_RESOURCE_SUBDIR/");
 rtl::Bootstrap::expandMacros(uri);
 OUString path;
 osl::File::getSystemPathFromFileURL(uri, path);
 OString sPath(OUStringToOString(path, osl_getThreadTextEncoding()));
+#endif
 gen.add_messages_path(sPath.getStr());
 #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID
 bindtextdomain(pPrefixName, sPath.getStr());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 129028] When focus is in the Infobar some key input actions occur in the document

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129028

Jim Raykowski  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||skillCpp

--- Comment #2 from Jim Raykowski  ---
Code pointer: overide Window::EventNotify in SfxInfoBarWindow to handle key
input of interest.

Places to look how a key input event filter can be done for SfxInfoBarWindow. 

sfx2/source/sidebar/SidebarDockingWindow.cxx
SidebarDockingWindow::EventNotify

sfx2/source/control/charmapcontrol.cxx
SfxCharmapCtrl::EventNotify

Key input that should be passed to the parent Window::EventNotify for handling
are tab, space, and enter. The rest should be consumed by the
SfxInfoBarWindow::EventNotify.

SfxInfoBarWindow class definition and member function code 
include/sfx2/infobar.hxx 
sfx2/source/dialog/infobar.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2019-12-18 Thread Miklos Vajna (via logerrit)
 sw/source/uibase/sidebar/WrapPropertyPanel.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 803c3a7824883ccf7d0841aabff591c014d20195
Author: Miklos Vajna 
AuthorDate: Wed Dec 18 22:34:06 2019 +0100
Commit: Miklos Vajna 
CommitDate: Thu Dec 19 00:27:50 2019 +0100

sw lok: disable Edit Contour button in image sidebar

This can be enabled when the underlying dialog is OK under LOK.

Change-Id: Id74d20de55e77842d707e345b2193ca9113594e8
Reviewed-on: https://gerrit.libreoffice.org/85435
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/source/uibase/sidebar/WrapPropertyPanel.cxx 
b/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
index e596d8d8dc72..b9d01096a1f7 100644
--- a/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
+++ b/sw/source/uibase/sidebar/WrapPropertyPanel.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 const char UNO_WRAPOFF[] = ".uno:WrapOff";
 const char UNO_WRAPLEFT[] = ".uno:WrapLeft";
@@ -148,6 +149,13 @@ void WrapPropertyPanel::Initialize()
 
 Link EditContourLink = LINK(this, WrapPropertyPanel, 
EditContourHdl);
 mpEditContour->SetClickHdl(EditContourLink);
+
+if (comphelper::LibreOfficeKit::isActive())
+{
+// Disable Edit Contour button for LOK purposes.
+mpEditContour->Hide();
+}
+
 Link EnableContourLink = LINK(this,WrapPropertyPanel, 
EnableContourHdl);
 mpEnableContour->SetClickHdl(EnableContourLink);
 mpSpacingLB->SetSelectHdl(LINK(this, WrapPropertyPanel, SpacingLBHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-0' - loleaflet/src

2019-12-18 Thread Jan Holesovsky (via logerrit)
 loleaflet/src/control/Control.JSDialogBuilder.js |   13 +
 1 file changed, 1 insertion(+), 12 deletions(-)

New commits:
commit 27bc2c2705ea44ab2abae3536f1de6a714d41946
Author: Jan Holesovsky 
AuthorDate: Wed Dec 18 23:57:00 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 00:27:42 2019 +0100

Revert "android: Translate the style names in the mobile wizard."

This is not needed any more when we use the .mo files correctly.

This reverts commit ddf0612e2f361af1f9284125a0dee98844ef7832.

Change-Id: I13260c30e874ced89667b4dc45ec7d6e26ec5138
Reviewed-on: https://gerrit.libreoffice.org/85453
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index 4b329c40e..6d788bcac 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -1037,11 +1037,6 @@ L.Control.JSDialogBuilder = L.Control.extend({
}
}
title = builder._cleanText(title);
-
-   // FIXME find out why Android needs this & fix
-   if (window.ThisIsTheAndroidApp)
-   title = _(title);
-
data.text = title;
 
var entries = [];
@@ -1104,13 +1099,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
 
_comboboxEntry: function(parentContainer, data, builder) {
var fixedtext = L.DomUtil.create('p', 'mobile-wizard', 
parentContainer);
-
-   // FIXME find out why Android needs this & fix
-   if (window.ThisIsTheAndroidApp)
-   fixedtext.innerHTML = _(builder._cleanText(data.text));
-   else
-   fixedtext.innerHTML = builder._cleanText(data.text);
-
+   fixedtext.innerHTML = builder._cleanText(data.text);
fixedtext.parent = data.parent;
 
if (data.style && data.style.length)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 129485] New: Data Range and #headers: Err: 504

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129485

Bug ID: 129485
   Summary: Data Range and #headers: Err: 504
   Product: LibreOffice
   Version: 6.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: guichard.adr...@gmail.com

Created attachment 156659
  --> https://bugs.documentfoundation.org/attachment.cgi?id=156659=edit
Test case #headers

When opening Excel file using data range #header selector, an error 504 is
shown in cells.

Example:
=MATCH(Tab1[#headers],Tab2[#headers],0)

in Excel this formula shows the correct answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-0' - android/lib

2019-12-18 Thread Jan Holesovsky (via logerrit)
 android/lib/build.gradle |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 8cbdaffe4695276be6754e7fc8e7861711a2955e
Author: Jan Holesovsky 
AuthorDate: Wed Dec 18 23:14:05 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 00:25:53 2019 +0100

android: The .mo resource (translation) files have to be in 'unpack'.

So that they are copied to the normal filesystem and boost::local can
pick them up from there.

Change-Id: Ic36288b14023decf9e507b5d7d883849010cd2a7
Reviewed-on: https://gerrit.libreoffice.org/85445
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/android/lib/build.gradle b/android/lib/build.gradle
index 631524dce..997bdfd23 100644
--- a/android/lib/build.gradle
+++ b/android/lib/build.gradle
@@ -74,6 +74,11 @@ task copyUnpackAssets(type: Copy) {
 includes = ["types.rdb"]
 rename 'types.rdb', 'udkapi.rdb'
 }
+
+into('resource') {
+from "${liboInstdir}/${liboSharedResFolder}"
+includes = ['**']
+}
 }
 into('user/fonts') {
 from "${liboInstdir}/share/fonts/truetype"
@@ -124,11 +129,6 @@ task copyAssets(type: Copy) {
 into('program') {
 from "${liboInstdir}/program"
 includes = ['services.rdb', 'services/services.rdb']
-
-into('resource') {
-from "${liboInstdir}/${liboSharedResFolder}"
-includes = ['*en-US.res']
-}
 }
 into('share') {
 from "${liboInstdir}/share"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: android/lib

2019-12-18 Thread Jan Holesovsky (via logerrit)
 android/lib/build.gradle |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e07dca49eb0a271ea800462ae08f8e18f46b699e
Author: Jan Holesovsky 
AuthorDate: Wed Dec 18 23:14:05 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Thu Dec 19 00:25:34 2019 +0100

android: The .mo resource (translation) files have to be in 'unpack'.

So that they are copied to the normal filesystem and boost::local can
pick them up from there.

Change-Id: Ic36288b14023decf9e507b5d7d883849010cd2a7
Reviewed-on: https://gerrit.libreoffice.org/85454
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/android/lib/build.gradle b/android/lib/build.gradle
index 631524dce..997bdfd23 100644
--- a/android/lib/build.gradle
+++ b/android/lib/build.gradle
@@ -74,6 +74,11 @@ task copyUnpackAssets(type: Copy) {
 includes = ["types.rdb"]
 rename 'types.rdb', 'udkapi.rdb'
 }
+
+into('resource') {
+from "${liboInstdir}/${liboSharedResFolder}"
+includes = ['**']
+}
 }
 into('user/fonts') {
 from "${liboInstdir}/share/fonts/truetype"
@@ -124,11 +129,6 @@ task copyAssets(type: Copy) {
 into('program') {
 from "${liboInstdir}/program"
 includes = ['services.rdb', 'services/services.rdb']
-
-into('resource') {
-from "${liboInstdir}/${liboSharedResFolder}"
-includes = ['*en-US.res']
-}
 }
 into('share') {
 from "${liboInstdir}/share"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/uiconfig

2019-12-18 Thread Andras Timar (via logerrit)
 sw/uiconfig/swriter/ui/sidebartableedit.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 99830646f28381d41743f57b2cf4c7bed797b4bd
Author: Andras Timar 
AuthorDate: Thu Dec 19 00:18:59 2019 +0100
Commit: Andras Timar 
CommitDate: Thu Dec 19 00:22:18 2019 +0100

interface domain is sw for this ui resource

Change-Id: I9a0fce51d52ab3c0d1c7540834112cff1f3e572f

diff --git a/sw/uiconfig/swriter/ui/sidebartableedit.ui 
b/sw/uiconfig/swriter/ui/sidebartableedit.ui
index 6f9c477bffd6..aa01759ea491 100644
--- a/sw/uiconfig/swriter/ui/sidebartableedit.ui
+++ b/sw/uiconfig/swriter/ui/sidebartableedit.ui
@@ -1,6 +1,6 @@
 
 
-
+
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/src

2019-12-18 Thread Muhammet Kara (via logerrit)
 loleaflet/src/control/Toolbar.js |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit b84c980df87a94023e344d89a73c2b6b891eca6d
Author: Muhammet Kara 
AuthorDate: Thu Dec 19 01:52:21 2019 +0300
Commit: Muhammet Kara 
CommitDate: Thu Dec 19 00:22:13 2019 +0100

Fix Writer: insert link - broken after save & re-load

Change-Id: I7675e808ab132cfe9f8afa75d34a71bd3acb730d
Reviewed-on: https://gerrit.libreoffice.org/85450
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Muhammet Kara 

diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js
index 1dd4b37f3..52735d7da 100644
--- a/loleaflet/src/control/Toolbar.js
+++ b/loleaflet/src/control/Toolbar.js
@@ -435,6 +435,13 @@ L.Map.include({
return parser.parseFromString(html, 
'text/html').documentElement.getElementsByTagName('body')[0].textContent;
},
 
+   makeURLFromStr: function(str) {
+   if (!(str.startsWith('http://') || str.startsWith('https://'))) 
{
+   str = 'http://' + str;
+   }
+   return str;
+   },
+
showHyperlinkDialog: function() {
var map = this;
var text = '';
@@ -466,7 +473,7 @@ L.Map.include({
},
'Hyperlink.URL': {
type: 'string',
-   value: data.link
+   value: 
map.makeURLFromStr(data.link)
}
};
map.sendUnoCommand('.uno:SetHyperlink', 
command);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source

2019-12-18 Thread Tomaž Vajngerl (via logerrit)
 sc/source/ui/view/gridwin.cxx |   26 +++---
 1 file changed, 19 insertions(+), 7 deletions(-)

New commits:
commit df6871286d7b769bc47554955213a2d727c47875
Author: Tomaž Vajngerl 
AuthorDate: Wed Dec 18 22:32:07 2019 +0100
Commit: Michael Meeks 
CommitDate: Thu Dec 19 00:08:54 2019 +0100

lok: send "EMPTY" if the rect is empty for cell selection or fill

It can happen that the selection or auto-fill rectangles are
empty and if that's the case then we need to send "EMPTY" string
and not the content of an empty rectangle (0, 0, -32768, -32768).

This can happen for CELL_SELECTION_AREA or CELL_AUTO_FILL_AREA in
calc.

Change-Id: I9a60e3907a2ab8b0e0fd1a2ff81137fba6c8e9a3
Reviewed-on: https://gerrit.libreoffice.org/85437
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 638c8b645aa6..b591b974dabf 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5902,7 +5902,10 @@ void ScGridWindow::UpdateKitSelection(const 
std::vector& rRect
 }
 
 ScTabViewShell* pViewShell = pViewData->GetViewShell();
-pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
aBoundingBox.toString().getStr());
+OString sBoundingBoxString = "EMPTY";
+if (!aBoundingBox.IsEmpty())
+sBoundingBoxString = aBoundingBox.toString();
+pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
sBoundingBoxString.getStr());
 pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, 
rectanglesToString(aLogicRects).getStr());
 
 for (SfxViewShell* it = SfxViewShell::GetFirst(); it;
@@ -5955,7 +5958,11 @@ void ScGridWindow::updateOtherKitSelections() const
 OString aRectsString = rectanglesToString(aOtherLogicRects);
 if (it == pViewShell)
 {
-
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
aBoundingBox.toString().getStr());
+OString sBoundingBoxString = "EMPTY";
+if (!aBoundingBox.IsEmpty())
+sBoundingBoxString = aBoundingBox.toString();
+
+
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_SELECTION_AREA, 
sBoundingBoxString.getStr());
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_TEXT_SELECTION, 
aRectsString.getStr());
 }
 else
@@ -5975,13 +5982,18 @@ void updateLibreOfficeKitAutoFill(const ScViewData* 
pViewData, tools::Rectangle
 double nPPTX = pViewData->GetPPTX();
 double nPPTY = pViewData->GetPPTY();
 
-// selection start handle
-tools::Rectangle aLogicRectangle(
-rRectangle.Left()  / nPPTX, rRectangle.Top() / nPPTY,
-rRectangle.Right() / nPPTX, rRectangle.Bottom() / nPPTY);
+OString sRectangleString = "EMPTY";
+if (!rRectangle.IsEmpty())
+{
+// selection start handle
+tools::Rectangle aLogicRectangle(
+rRectangle.Left()  / nPPTX, rRectangle.Top() / nPPTY,
+rRectangle.Right() / nPPTX, rRectangle.Bottom() / nPPTY);
+sRectangleString = aLogicRectangle.toString();
+}
 
 ScTabViewShell* pViewShell = pViewData->GetViewShell();
-pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_AUTO_FILL_AREA, 
aLogicRectangle.toString().getStr());
+pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_CELL_AUTO_FILL_AREA, 
sRectangleString.getStr());
 }
 
 } //end anonymous namespace
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 129484] Crash when trying to view property of a component from forms (gtk3)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129484

--- Comment #3 from Julien Nabet  ---
I don't think it's related but I noticed this on console:
warn:svx:384959:384959:svx/source/form/formcontrolfactory.cxx:178:
DBG_UNHANDLED_EXCEPTION in rtl::OUString
svxform::{anonymous}::lcl_getUniqueLabel_nothrow(const
com::sun::star::uno::Reference&, const
rtl::OUString&) exception: com.sun.star.uno.RuntimeException message:
unsatisfied query for interface of type com.sun.star.container.XIndexAccess!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129484] Crash when trying to view property of a component from forms (gtk3)

2019-12-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129484

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #2 from Julien Nabet  ---
Caolán: thought you might be interested in this one since it's specific to
gtk3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   5   >