Need Help: How to create non modal dialog in LO Java extension
Hi Team, I want to create a non modal Uno dialog in my java extension for Libre Office. I came across the UnoDialogSample.java file given in the examples section but this creates only modal dialog. Searched in many forums but didnt manage to get any solution. Please help me on How to Create Non Modal (modeless) Uno Dialog through Java extension. -- Best Regards, Harish Kumar.B ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 129752] Paste Special, Skip Empty Cells Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=129752 NISZ LibreOffice Team changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from NISZ LibreOffice Team --- This sounds like our bug #129701 *** This bug has been marked as a duplicate of bug 129701 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 NISZ LibreOffice Team changed: What|Removed |Added CC||larrywbrad...@gmail.com --- Comment #7 from NISZ LibreOffice Team --- *** Bug 129752 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - writerfilter/CppunitTest_writerfilter_dmapper.mk writerfilter/qa writerfilter/source
writerfilter/CppunitTest_writerfilter_dmapper.mk |1
writerfilter/qa/cppunittests/dmapper/CellColorHandler.cxx | 75 ++
writerfilter/qa/cppunittests/dmapper/data/tdf129205.docx |binary
writerfilter/source/dmapper/CellColorHandler.cxx |2
4 files changed, 77 insertions(+), 1 deletion(-)
New commits:
commit dfd75ec6d4dcfec57607a8cf7c7a509c33bf2caa
Author: Miklos Vajna
AuthorDate: Thu Jan 2 09:01:17 2020 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Jan 3 08:11:39 2020 +0100
tdf#129205 DOCX import: handle the paragraph
property
Reading the spec, "nil" is the opposite of "clear": i.e. if the
(background) color is red and the fill (color) is green, then "clear"
means green. And you would expect "nil" means red, but it's just nothing
in Word.
Fix the problem by doing the same: don't set any paragraph property for
the "nil" case and keep doing it for the common "clear" case.
(cherry picked from commit fbe7612d654be9dfe1ea6f2e67900eb4eec4202a)
Change-Id: I30af8a7fb55fb9bab2d12e120069a479fc7ab0a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86098
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/writerfilter/CppunitTest_writerfilter_dmapper.mk
b/writerfilter/CppunitTest_writerfilter_dmapper.mk
index fbb302297c94..9805e28228a0 100644
--- a/writerfilter/CppunitTest_writerfilter_dmapper.mk
+++ b/writerfilter/CppunitTest_writerfilter_dmapper.mk
@@ -16,6 +16,7 @@ $(eval $(call
gb_CppunitTest_use_externals,writerfilter_dmapper,\
))
$(eval $(call gb_CppunitTest_add_exception_objects,writerfilter_dmapper, \
+writerfilter/qa/cppunittests/dmapper/CellColorHandler \
writerfilter/qa/cppunittests/dmapper/DomainMapperTableHandler \
))
diff --git a/writerfilter/qa/cppunittests/dmapper/CellColorHandler.cxx
b/writerfilter/qa/cppunittests/dmapper/CellColorHandler.cxx
new file mode 100644
index ..ab3dc7cec6c3
--- /dev/null
+++ b/writerfilter/qa/cppunittests/dmapper/CellColorHandler.cxx
@@ -0,0 +1,75 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+using namespace ::com::sun::star;
+
+namespace
+{
+/// Tests for writerfilter/source/dmapper/CellColorHandler.cxx.
+class Test : public test::BootstrapFixture, public unotest::MacrosTest
+{
+private:
+uno::Reference mxComponentContext;
+uno::Reference mxComponent;
+
+public:
+void setUp() override;
+void tearDown() override;
+uno::Reference& getComponent() { return mxComponent; }
+};
+
+void Test::setUp()
+{
+test::BootstrapFixture::setUp();
+
+
mxComponentContext.set(comphelper::getComponentContext(getMultiServiceFactory()));
+mxDesktop.set(frame::Desktop::create(mxComponentContext));
+}
+
+void Test::tearDown()
+{
+if (mxComponent.is())
+mxComponent->dispose();
+
+test::BootstrapFixture::tearDown();
+}
+
+char const DATA_DIRECTORY[] = "/writerfilter/qa/cppunittests/dmapper/data/";
+
+CPPUNIT_TEST_FIXTURE(Test, test129205)
+{
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"tdf129205.docx";
+getComponent() = loadFromDesktop(aURL);
+uno::Reference xTextDocument(getComponent(),
uno::UNO_QUERY);
+uno::Reference
xParaEnumAccess(xTextDocument->getText(),
+
uno::UNO_QUERY);
+uno::Reference xParaEnum =
xParaEnumAccess->createEnumeration();
+uno::Reference xPara(xParaEnum->nextElement(),
uno::UNO_QUERY);
+drawing::FillStyle eFillStyle = drawing::FillStyle::FillStyle_NONE;
+xPara->getPropertyValue("FillStyle") >>= eFillStyle;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: drawing::FillStyle_NONE
+// - Actual : FillStyle_SOLID
+// i.e. the paragraph had a solid fill, making the header image invisible.
+CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_NONE, eFillStyle);
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/qa/cppunittests/dmapper/data/tdf129205.docx
b/writerfilter/qa/cppunittests/dmapper/data/tdf129205.docx
new file mode 100644
index ..4289254d0a97
Binary files /dev/null and
b/writerfilter/qa/cppunittests/dmapper/data/tdf129205.docx differ
diff --git a/writerfilter/source/dmapper/CellColorHandler.cxx
b/writerfilter/source/dmapper/CellColorHandler.cxx
index b5889742c29a..a830b5783116 100644
--- a/writerfilter/source/dmapper/CellColorHandler.cxx
+++ b/writerfilter/source/dmapper/CellColorHandler.cxx
@@ -276,7 +276,7 @@
[Libreoffice-bugs] [Bug 120172] [META] Button controls bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120172 Bug 120172 depends on bug 125536, which changed state. Bug 125536 Summary: Garbled combo box within Format / Character / Font dialog box on macOS https://bugs.documentfoundation.org/show_bug.cgi?id=125536 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 125536, which changed state. Bug 125536 Summary: Garbled combo box within Format / Character / Font dialog box on macOS https://bugs.documentfoundation.org/show_bug.cgi?id=125536 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129751] Interface problem: Conditional formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=129751 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #2 from Oliver Brinzing --- i cannot confirm this with: Win 10 x64, 1920x1080 125% Version: 6.3.4.2 (x64) Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129752] Paste Special, Skip Empty Cells Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=129752 --- Comment #1 from larrybradley --- Created attachment 156914 --> https://bugs.documentfoundation.org/attachment.cgi?id=156914=edit Workbook illustrating Skip Empty Cells function does not Skip empty rows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129752] New: Paste Special, Skip Empty Cells Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=129752 Bug ID: 129752 Summary: Paste Special, Skip Empty Cells Does Not Work Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: larrywbrad...@gmail.com Description: Copying multiple rows,then pasting somewhere else using "Paste Special, Skip Empty cells," does not skip the empty rows. It past empty rows as well as non-empty rows. I get it: an empty cell and an empty row are not the same thing. Still, when you do the same function with Excel, it skips the empty rows. The "Skip Empty Cells feature" is pretty useless if it also does not skip empty rows. Steps to Reproduce: 1.Select multiple rows. 2.Paste Special, Skip Empty Cells. 3. Actual Results: 1.Select multiple rows. 2.Paste Special, Skip Empty Cells. Expected Results: It pastes empty rows. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126280] PRINTING: Clicking Print window's Properties button crashes Calc - Crash in: ml1750u.DLL
https://bugs.documentfoundation.org/show_bug.cgi?id=126280 whon...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #4 from whon...@gmail.com --- Re-tested issue against Version: 6.3.4.2 (x64). Worked as expected in Version: 6.3.4.2 (x64). Issue resolved. = Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62654] FORMATTING: ENHANCEMENT: List numbering with maximum number of optional zero-filled leading digits
https://bugs.documentfoundation.org/show_bug.cgi?id=62654 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=35 ||217 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35217] Outline/numbering style formatting limitation
https://bugs.documentfoundation.org/show_bug.cgi?id=35217 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=62 ||654 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90658] FILEOPEN Date field in Word 6.0 document have wrong formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=90658 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #10 from sdc.bla...@youmail.dk --- 1. Open Sample Document 2. Look at Properties ( File > Properties ) 3. Notice that Title is: 28.1.1998 4. Change to: 28.01.1998 5. Save/Reload Result: Success Tested with: Version: 6.5.0.0.alpha0+ (x64) Build ID: 444f0d256957544d26b9af9a0898364e829df1b5 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: sv-SE (en_DK); UI-Language: en-US Calc: threaded I do not have a copy of Word to test the original document, but if the title was also 28.1.1998 in Word -- then I would be inclined to say: NAB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129507] Erase Ink on Slide does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=129507 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129503] mail merge broken; fields are not populated with database records at all
https://bugs.documentfoundation.org/show_bug.cgi?id=129503 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129746] Changing printer before printing messes automatic page orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=129746 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129265] Exporting a large document as PDF results in a general input/output error
https://bugs.documentfoundation.org/show_bug.cgi?id=129265 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] specific form based sheet gets empty/invisible menu options and no mouseover comment pop-out in LO 6.4.0.1 WIN10 x64 with OpenGL (and Skia for master/6.5.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129265] Exporting a large document as PDF results in a general input/output error
https://bugs.documentfoundation.org/show_bug.cgi?id=129265 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129487] Contents are repeated in pagemaker file conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=129487 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104448] [META] DOCX SAXParseException
https://bugs.documentfoundation.org/show_bug.cgi?id=104448 Bug 104448 depends on bug 75972, which changed state. Bug 75972 Summary: FILEOPEN: SAXParseException on one .DOCX (summary in comment 7) https://bugs.documentfoundation.org/show_bug.cgi?id=75972 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125678] Crash on slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=125678 --- Comment #10 from QA Administrators --- Dear Daniel T., Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104867] Impress does not compress repeated(copied) images with Minimize Presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=104867 --- Comment #7 from QA Administrators --- Dear Maxim Britov, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129504] Breeze dark theme does not get selected automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=129504 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129448] FORMATTING: Line spacing (wrongly) affects automatic first-line indent of Chinese text
https://bugs.documentfoundation.org/show_bug.cgi?id=129448 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Bug 104450 depends on bug 75972, which changed state. Bug 75972 Summary: FILEOPEN: SAXParseException on one .DOCX (summary in comment 7) https://bugs.documentfoundation.org/show_bug.cgi?id=75972 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 125678, which changed state. Bug 125678 Summary: Crash on slideshow https://bugs.documentfoundation.org/show_bug.cgi?id=125678 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125678] Crash on slideshow
https://bugs.documentfoundation.org/show_bug.cgi?id=125678 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75972] FILEOPEN: SAXParseException on one .DOCX (summary in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=75972 --- Comment #13 from QA Administrators --- Dear Orbel, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125505] LibreOffice writer changing font color does not take effect at screen
https://bugs.documentfoundation.org/show_bug.cgi?id=125505 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75972] FILEOPEN: SAXParseException on one .DOCX (summary in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=75972 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125505] LibreOffice writer changing font color does not take effect at screen
https://bugs.documentfoundation.org/show_bug.cgi?id=125505 --- Comment #6 from QA Administrators --- Dear quichehsu, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129751] Interface problem: Conditional formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=129751 --- Comment #1 from Leandro Martín Drudi --- Created attachment 156913 --> https://bugs.documentfoundation.org/attachment.cgi?id=156913=edit The window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129751] New: Interface problem: Conditional formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=129751 Bug ID: 129751 Summary: Interface problem: Conditional formatting Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Description: When you try to apply three-color conditional formatting, part of the options are hidden Steps to Reproduce: 1. Format Menu 2. Conditional formatting 3. Condition 4. All cels 5. Color scale (3 colors) Actual Results: The Maximum conditional configuration is hidden in a 50% Expected Results: Be able to resize the window or not hide the options Reproducible: Always User Profile Reset: Yes Additional Info: I try in a High resolution monitor (1920x1080) and low resolution and the same happens. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129740] Error to compose the style.xml sub-document in Writer (LibreofficeDev 6.4), using different header for first page
https://bugs.documentfoundation.org/show_bug.cgi?id=129740 Ismael Cedillo changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cannot review Gerrit patch
Hi Chris, I can confirm, that it does not work in the old UI. Chris Sherlock schrieb am 02-Jan-20 um 23:01: On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: Hey Chris, Chris Sherlock wrote: Quick ping. Anyone able to assist? Not really - seems to work fine here, though not using the old UI. Cheers, — Thorsten Cool. Out of interest, how on earth do I get back to the new UI? I switched to the old UI as a test, but there is no option to go back to the newest UI! For me it is at the bottom of the page, at the right side, text "Switch to New UI". Kind regards Regin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1c743f157047a697e4f232d51ac7bc70ec98dd12 Author: Seth Chaiklin AuthorDate: Fri Jan 3 02:07:53 2020 +0100 Commit: Gerrit Code Review CommitDate: Fri Jan 3 02:07:53 2020 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 169466b5553e03aef51d91f2b1588dc48be86c4d - tdf#129497 update help information for paragraph style dialog - add information about "reset" button to Organizer tab - improve access information to Organizer tab Change-Id: I6563ea713a99b9966d401f6db51330c65836c8d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86106 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 1499595f8bb1..169466b5553e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 1499595f8bb1ef82b511999629f8d7a140c903a5 +Subproject commit 169466b5553e03aef51d91f2b1588dc48be86c4d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/00/00040500.xhp | 13 + source/text/shared/01/05040100.xhp |3 +++ 2 files changed, 12 insertions(+), 4 deletions(-) New commits: commit 169466b5553e03aef51d91f2b1588dc48be86c4d Author: Seth Chaiklin AuthorDate: Thu Jan 2 14:34:23 2020 +0100 Commit: Olivier Hallot CommitDate: Fri Jan 3 02:07:53 2020 +0100 tdf#129497 update help information for paragraph style dialog - add information about "reset" button to Organizer tab - improve access information to Organizer tab Change-Id: I6563ea713a99b9966d401f6db51330c65836c8d3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86106 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/00/00040500.xhp b/source/text/shared/00/00040500.xhp index 805a93511..0cb7b8ad0 100644 --- a/source/text/shared/00/00040500.xhp +++ b/source/text/shared/00/00040500.xhp @@ -145,13 +145,18 @@ Choose Format - Cells - Background tab. -Choose Format - Page Style - Organizer tab. -Choose View - Styles - open context menu of an entry and choose Modify/New - Organizer tab. +Choose Format - Page Style - Organizer tab. (Writer documents) +Choose Styles - Edit Style - Organizer tab. (Writer documents) +Choose View - Styles (F11) - open context menu of an entry and choose Modify/New - Organizer tab. -Choose Format - Page - Organizer tab. +Choose Format - Page - Organizer tab. (Calc documents) Choose View - Styles - open context menu of an entry and choose Modify/New - Organizer tab. + +Choose Format - Styles - Edit Styles - Organizer tab. (Draw documents) +Choose View - Styles - open context menu of an entry and choose Modify/New - Organizer tab. + Choose Format - Page - Page tab. Choose Slide - Properties - Page tab (in $[officename] Impress). @@ -274,4 +279,4 @@ Menu Format - Asian phonetic guide. - + \ No newline at end of file diff --git a/source/text/shared/01/05040100.xhp b/source/text/shared/01/05040100.xhp index 5e458636b..fc832b905 100644 --- a/source/text/shared/01/05040100.xhp +++ b/source/text/shared/01/05040100.xhp @@ -37,6 +37,8 @@ Set the options for the selected style. + + @@ -63,6 +65,7 @@ Contains Describes the relevant formatting used in the current style. + Update Style ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129750] New: Start window freezes frequently.
https://bugs.documentfoundation.org/show_bug.cgi?id=129750 Bug ID: 129750 Summary: Start window freezes frequently. Product: LibreOffice Version: 6.3.4.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ohh...@gmail.com Description: Regardless of OpenGL enabled/disabled the start window (the one with recent files, templates, etc.) often freezes, which usually requires to kill the process via Task Manager. Steps to Reproduce: 1. Click on LibreOffice 6.3 on the desktop. 2. Observe whether a mouse cursor indicates business or not. 3. Actual Results: Often the cursor indicates that something is happening - therefore nothing can be done via the window, because it does not respond. Expected Results: Click on the LibreOffice icon and be able to do anything it allows to do - right off the bat :) . Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 6.3.4.2 (x86) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; Locale: en-US (pl_PL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123120] Bug: Calc fails to recalculate dependent cells
https://bugs.documentfoundation.org/show_bug.cgi?id=123120 --- Comment #9 from b. --- bug may be kept closed, sheet is too complicated, just to check reliability of calc for the 'bug hunting session', and to save others some time if they attempt an recheck ... (solution at the end) with ver: Version: 6.4.0.1 (x64) Build ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: CL > 1. Open bug 3 (attached) ok > 2. Delete contents of g.X6 (note g.X16 remains =16, which is incorrect) g.X16 changes to blank, empty or similar > 3. Select c.W281 (it equals 35, which is incorrect) c.W281 now shows -1, i can't find why it should calculate to other value, > 4. Press F9 (nothing happens) running ants, but no change in C.W281 > 5. Press F9 again c.W281 changes to 34 (which is correct) running ants, but no change in C.W281, also on third, fourth and so on press of F9, but changes in g.row6, some 'd' changed to 'a' > I attach the spreadsheet bug 3 (also the macro code which is not executed in > the steps above but which you might need). implemented and error message on file open and close gone, thus correct? > 6. g.X16=13 (which is correct). g.X16 still blank, empty or similar on hard recalc - strg-shift-F9 - a long process is started and at the end g.I6:g.X6 are empty .. things which might affect the results: i'd put the macro code in a module of the file, had to re-bind AddListener and RmvListener from that position to open and close event, not checked if other macros are neccessary for recalc ... maybe your script is a little bit inaccurate and and step 2. was intended as: 2. Delete contents of g.*W*6 - you placed the cursor there ... !W6!, not! X6??? then g.W16 changes to empty, and g.X16 to 13, and c.W281 to 34 ... just as you requested ... just after deleting g.W6 ... same with ver 6.2.8.2, thus one can say actual versions are ok for your needs ... <<< one bug killed! >>> -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 --- Comment #17 from kurt.pfei...@gmail.com --- (In reply to Michael Meeks from comment #15) > The hybrid PDF functionality was a great innovation, and the standard didn't > cover it then of course. Indeed the hybrid PDF functionality i s a great innovation. However it could even then have been (and still can be implemented) by using the standard conforming method of embedding the source file. If done, this would have the advantage that every standard compliant PDF viewer or PDF processing software could auto-discover the embedded source file and let the user "do something" with it even in the absence of a LibreOffice installation on his system. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
13 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 13 of 13 defect(s)
** CID 1456612: Null pointer dereferences (NULL_RETURNS)
*** CID 1456612: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/access/AccessibilityCheck.cxx: 353 in
swTextContrastCheck::checkTextRange(const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Reference &,
SwTextNode *)()
347 const SwAttrSet& rPageSet = rPageFormat.GetAttrSet();
348
349 const XFillStyleItem* pXFillStyleItem(
350 rPageSet.GetItem(XATTR_FILLSTYLE,
false));
351 Color aPageBackground;
352
>>> CID 1456612: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pXFillStyleItem" when
>>> calling "GetValue".
353 if (pXFillStyleItem->GetValue() ==
css::drawing::FillStyle_SOLID)
354 {
355 const XFillColorItem* rXFillColorItem
356 = rPageSet.GetItem(XATTR_FILLCOLOR,
false);
357 aPageBackground = rXFillColorItem->GetColorValue();
358 }
** CID 1456611: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 1716 in
ScDocShell::PrepareSaveGuard::~PrepareSaveGuard()()
*** CID 1456611: Error handling issues (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 1716 in
ScDocShell::PrepareSaveGuard::~PrepareSaveGuard()()
1710 }
1711 }
1712 if (mrDocShell.GetCreateMode()== SfxObjectCreateMode::STANDARD)
1713 mrDocShell.SfxObjectShell::SetVisArea( tools::Rectangle() );
// "Normally" worked on => no VisArea.
1714 }
1715
>>> CID 1456611: Error handling issues (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown
>>> but the throw list "noexcept" doesn't allow it to be thrown. This will
>>> cause a call to unexpected() which usually calls terminate().
1716 ScDocShell::PrepareSaveGuard::~PrepareSaveGuard()
1717 {
1718 if (mrDocShell.m_aDocument.HasExternalRefManager())
1719 {
1720 ScExternalRefManager* pRefMgr =
mrDocShell.m_aDocument.GetExternalRefManager();
1721 if (pRefMgr && pRefMgr->hasExternalData())
** CID 1456610: Uninitialized members (UNINIT_CTOR)
/include/vcl/pdfwriter.hxx: 640 in
vcl::PDFWriter::PDFWriterContext::PDFWriterContext()()
*** CID 1456610: Uninitialized members (UNINIT_CTOR)
/include/vcl/pdfwriter.hxx: 640 in
vcl::PDFWriter::PDFWriterContext::PDFWriterContext()()
634 Encryption(),
635 SignPDF( false ),
636 DPIx( 0 ),
637 DPIy( 0 ),
638 ColorMode( PDFWriter::DrawColor ),
639 UseReferenceXObject( false )
>>> CID 1456610: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "UniversalAccessibilityCompliance" is not
>>> initialized in this constructor nor in any functions that it calls.
640 {}
641 };
642
643 PDFWriter( const PDFWriterContext& rContext, const
css::uno::Reference< css::beans::XMaterialHolder >& );
644 ~PDFWriter();
645
** CID 1456609: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/drawinglayer/source/tools/emfppath.cxx: 31 in
emfplushelper::GetEmfPlusInteger(int)()
*** CID 1456609: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
/drawinglayer/source/tools/emfppath.cxx: 31 in
emfplushelper::GetEmfPlusInteger(int)()
25
26 namespace emfplushelper
27 {
28 static sal_Int16 GetEmfPlusInteger(sal_Int32 nInt)
29 {
30 if (nInt & 0x8000)
>>> CID 1456609: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(nInt & 0x7fff) >> 16" is 0 regardless of the values of its operands.
>>> This occurs as a return value.
31 return (nInt & 0x7FFF) >> 16;
32
33 return nInt >> 24;
34 }
35
36 EMFPPath::EMFPPath (sal_Int32 _nPoints, bool bLines)
** CID 1456608: Null pointer dereferences (FORWARD_NULL)
Re: Cannot review Gerrit patch
On 2 Jan 2020, at 10:24 am, Thorsten Behrens wrote: > > Hey Chris, > > Chris Sherlock wrote: >> Quick ping. Anyone able to assist? >> > Not really - seems to work fine here, though not using the old UI. > > Cheers, > > — Thorsten Cool. Out of interest, how on earth do I get back to the new UI? I switched to the old UI as a test, but there is no option to go back to the newest UI! Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Using SourceTrail as additional explorer tool detection
> On 2 Jan 2020, at 7:50 am, William Gathoye (LibreOffice) > wrote: > > Hello everyone, > > By spending most of my LibreOffice time on Twitter for the LibreOfficeFR > twitter account, I noticed quite a few sponsored tweets for a recent > code explorer tool called SourceTrail. > > Regis [1], from the LibreOfficeFR community, mentioned this tool as well. > > Could we see in SourceTrail a more recent alternative to our OpenGrok > instance? Is this a tool we can recommend newcomers to use to get to > know the LibreOffice source code? > > Regards, > > [1] https://twitter.com/regmoi/status/1209959677183827968 I can’t read French (my loss), but can you provide more info on what SourceTrail is? Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Translation markers in wiki
Greetings, I notice that wiki pages now have lots of strings like "" appearing approximately one per paragraph with sequentially increasing numbers. I assume that these are flags to help somebody or something keep track of translations. Right? What should I do when I add a paragraph? (My search foo must be weak these days. I *did* try to find the answer.) Thanks, Terry. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 108392] [META] Master slide bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108392 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||127137 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=127137 [Bug 127137] EDITING Sidebar: master slide dropdown assigns master only to the first selected slide -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129746] Changing printer before printing messes automatic page orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=129746 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Version|6.4.0.1 rc |6.3.4.2 release Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||regression --- Comment #1 from m.a.riosv --- Repro also: Versión: 6.3.4.2 (x64) Id. de compilación: 60da17e045e08f1793c57c00ba83cdfce946d0aa Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: GL; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: CL Version: 6.5.0.0.alpha0+ (x64) Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL Works with: Versión: 6.2.7.1 (x64) Id. de compilación: 23edc44b61b830b7d749943e020e96f5a7df63bf Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: But looks a visualization issue on the box, unticking an ticking the preview shows correctly, and other actions have the same effect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 --- Comment #16 from Julien Nabet --- Thank you Michael for your very quick feedback! :-) I took a look at https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdf which 1.4 version (released in 2001 according to https://fr.wikipedia.org/wiki/Portable_Document_Format#Versions). Version 1.4 had already "EmbeddedFiles" keyword (see 3.3 part). So wondered why adding the non standard "AdditionalStreams" whereas this keyword was existing. Or perhaps I wrongly understood this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129744] Customized Alt+Left and Alt+Right key bindings are ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=129744 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEW OS|Linux (All) |All --- Comment #1 from V Stuart Foote --- Confirmed, also on Windows builds Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL While the default Writer keyboard shortcus + and + assignments to 'To Word Left' and 'To Word Right' function as expected. Though duplicating existing shortcuts, user assignment of these edit cursor movements to based shortcuts should otherwise work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129748] LibreOffice tip of the day it has no new line on long sentences
https://bugs.documentfoundation.org/show_bug.cgi?id=129748 V Stuart Foote changed: What|Removed |Added Version|3.3.2 release |6.3.3.2 release CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- fixed at 6.3.4... *** This bug has been marked as a duplicate of bug 128524 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129723] Index: allow each level to be "Run On" or "Set Out" independently
https://bugs.documentfoundation.org/show_bug.cgi?id=129723 R. Green changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129749] New: Index: Allow use of "n" to specify entries in footnotes and endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=129749 Bug ID: 129749 Summary: Index: Allow use of "n" to specify entries in footnotes and endnotes Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: greenandpleasant2000-supp...@yahoo.co.uk It is standard practice to use the letter n after the page number, for index terms which are located in footnotes or endnotes. Examples: 29n = Entry term is found in the footnote on page 29. 127n3 = Entry term is found on page 127, footnote or endnote 3. (Details in the "Chicago Manual of Style", chapter on Indexes.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 --- Comment #15 from Michael Meeks --- The hybrid PDF functionality was a great innovation, and the standard didn't cover it then of course. It would be great to find some resources / and/or interested people to implement the new standard using EmbeddedFiles. Alexis - are you interested in some code pointers there ? hacking the core to rename a few attributes and re-structuring the stream is likely to be a good start. I imagine a Collaboran would be happy to mentor someone that wanted to work on this themselves, but we can't resource a fix absent a customer ourselves today. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 Jean-Baptiste Faure changed: What|Removed |Added Version|3.3.0 release |Inherited From OOo CC||jbfa...@libreoffice.org --- Comment #14 from Jean-Baptiste Faure --- According to comment #13 I changed version to inherited from OOo. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129716] error 519 (#VALUE) description in caLc
https://bugs.documentfoundation.org/show_bug.cgi?id=129716 --- Comment #2 from Adam --- OK, but finding a specific reason why string which looks like a number is a text ( local decimal separator) takes a few houres -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129748] New: LibreOffice tip of the day it has no new line on long sentences
https://bugs.documentfoundation.org/show_bug.cgi?id=129748 Bug ID: 129748 Summary: LibreOffice tip of the day it has no new line on long sentences Product: LibreOffice Version: 3.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: moyanocasco.francis...@gmail.com Description: LibreOffice 'tip of the day' it has no new line on long sentences. The version and others are Versión: 6.3.3.2.0+ Id. de compilación: 30(Build:2) Subprocs. CPU: 4; SO: Linux 4.12; Repres. IU: predet.; VCL: kde5; Configuración regional: es-ES (es_ES.UTF-8); Idioma de IU: es-ES Steps to Reproduce: 1.Start LibreOffice or one of its components (writer, calc, etc) 2. Look at the Tip of the Day Actual Results: Long sentences without newline. You lose the part of the tip of the day Expected Results: Short sentences. You can see all the tip of the day Reproducible: Always User Profile Reset: No Additional Info: Versión: 6.3.3.2.0+ Id. de compilación: 30(Build:2) Subprocs. CPU: 4; SO: Linux 4.12; Repres. IU: predet.; VCL: kde5; Configuración regional: es-ES (es_ES.UTF-8); Idioma de IU: es-ES Calc: threaded Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129262] Exporting a large document as EPUB hangs the system
https://bugs.documentfoundation.org/show_bug.cgi?id=129262 --- Comment #5 from Alberto Salvia Novella --- Created attachment 156912 --> https://bugs.documentfoundation.org/attachment.cgi?id=156912=edit Book.odt In order to satisfy the bug tracker upload file size limit, I have cut the document into the first 50 pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129265] Exporting a large document as PDF results in a general input/output error
https://bugs.documentfoundation.org/show_bug.cgi?id=129265 --- Comment #4 from Alberto Salvia Novella --- Created attachment 156911 --> https://bugs.documentfoundation.org/attachment.cgi?id=156911=edit Book.odt In order to satisfy the bug tracker upload file size limit, I have cut the document into the first 50 pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129734] Sometimes words marked as non needing spelling correction are still underlined as such
https://bugs.documentfoundation.org/show_bug.cgi?id=129734 Alberto Salvia Novella changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from Alberto Salvia Novella --- Version: 6.2.8.2 Build ID: 6.2.8-3 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: es-ES (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129734] Sometimes words marked as non needing spelling correction are still underlined as such
https://bugs.documentfoundation.org/show_bug.cgi?id=129734 Alberto Salvia Novella changed: What|Removed |Added OS|All |Linux (All) Hardware|All |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129734] Sometimes words marked as non needing spelling correction are still underlined as such
https://bugs.documentfoundation.org/show_bug.cgi?id=129734 --- Comment #2 from Alberto Salvia Novella --- Created attachment 156910 --> https://bugs.documentfoundation.org/attachment.cgi?id=156910=edit Book.odt In order to satisfy the bug tracker upload file size limit, I have cut the document into the first 50 pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66580] exported PDF is invalid because of forbidden custom keys in the trailer
https://bugs.documentfoundation.org/show_bug.cgi?id=66580 Julien Nabet changed: What|Removed |Added CC||michael.me...@collabora.com ||, qui...@gmail.com, ||serval2...@yahoo.fr, ||vmik...@collabora.com Priority|lowest |medium Severity|trivial |normal --- Comment #13 from Julien Nabet --- Michael/Miklos/Tomaž: I don't know who's PDF expert so thought one of you might have some idea. The problem here is "AdditionalStreams" keyword doesn't exist in PDF standard. Taking a look at git history of d217c079d7b3ca7b5039428594e7cdfdf9a0c4a9, it's been added with: commit d217c079d7b3ca7b5039428594e7cdfdf9a0c4a9 Author: Ivo Hinkelmann Date: Mon Mar 26 10:21:15 2007 + INTEGRATION: CWS ipdf (1.92.80); FILE MERGED 2007/01/19 16:08:58 pl 1.92.80.8: #137143# ecnrypt add streams 2007/01/19 11:48:56 pl 1.92.80.7: RESYNC: (1.99-1.102); FILE MERGED 2006/10/04 18:52:04 pl 1.92.80.6: RESYNC: (1.96-1.99); FILE MERGED 2006/07/25 09:31:00 pl 1.92.80.5: RESYNC: (1.93-1.96); FILE MERGED 2006/07/04 16:34:49 pl 1.92.80.4: removed a warning 2006/07/04 13:48:22 pl 1.92.80.3: RESYNC: (1.92-1.93); FILE MERGED 2006/06/26 15:00:09 pl 1.92.80.2: #137143# emit document checksum 2006/06/12 16:53:42 pl 1.92.80.1: #137143# add AddStream interface Shouldn't it be removed, put in readonly (I mean LO may read this on old files but should replace the keyword when modifying) or at minimum make this deprecated? Instead there's "EmbeddedFiles" in specs (see https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdf_reference_archive/pdf_reference_1-7.pdf) LO should respect PDF standard, I put this one to normal importance but it should be even higher than this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129708] Impress: Long operation during typing
https://bugs.documentfoundation.org/show_bug.cgi?id=129708 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129716] error 519 (#VALUE) description in caLc
https://bugs.documentfoundation.org/show_bug.cgi?id=129716 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Olivier Hallot --- The Help tells for error 519: (..) or a cell that is referenced in the formula contains text instead of a number. Which is exactly the case. Also the error text in Help is more generic and cover broader situations than a decimal separator locale issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40469] Modifed Frame Style Options Not Preserved, "Keep Ratio" Option Unavailable
https://bugs.documentfoundation.org/show_bug.cgi?id=40469 --- Comment #30 from hardy --- Sorry for not responding ealier. (The notify email does not always work for me...) I have retested what Julien did in comment #28 (with LO 6.3) an what I did in comment #27 (with LO 6.2). And now I can also NOT reproduce the buggy behavior, as outlined in comment #12 (or Julien's comment #28). I have no clue what I did different the time before. But when I go back to the very first description of this bug (from the year 2005), then I CAN STILL reproduce the buggy behavior described there. I could reproduce this with LO 6.2. I will quote the original bug report to describe what I did: - Simple problem, no solution: I just want to define a Frame style that positions images and assigns them a fixed width, but with the height calculated automatically from the image's proportions (aspect ratio). That's not possible, since for images the "AutoSize" function is not available and the "Keep aspect" is obviously ignored when applying frame styles. To reproduce - Create new writer doc. - Insert a small image (e.g. bigapple.gif from the gallary) - Check image's "Keep aspect ratio" to ON. - Create or edit a frame style to place the object somewhere (e.g. right page border) and set: Width: 4 cm Height (at least): 1 cm AutoSize: ON (P.S. Why is "Keep aspect ratio always grey?) - Apply style Result: Image is rescaled to 4cm width (OK for me) and 1 cm height (wrong!). So obviously a) the frame style's AutoSize does not work for images b) the "Keep aspect ratio" is ignored as well when applying a frame style to an image. Fazit: It's not possible to assign a frame style to an image without having to manually correct the aspect ratio afterwards. I consider this an important issue if images are to be placed as marginalia (with a fixed width) beside the text, but the aspect ratio needs of course to be correct. - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129747] Several footnotes in a multipage table causes massive display and formatting problems
https://bugs.documentfoundation.org/show_bug.cgi?id=129747 --- Comment #1 from William Friedman --- Created attachment 156909 --> https://bugs.documentfoundation.org/attachment.cgi?id=156909=edit Test document Here is the document that demonstrates that footnotes and long tables do not interact well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129747] New: Several footnotes in a multipage table causes massive display and formatting problems
https://bugs.documentfoundation.org/show_bug.cgi?id=129747 Bug ID: 129747 Summary: Several footnotes in a multipage table causes massive display and formatting problems Product: LibreOffice Version: 6.1.6.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: will.fried...@gmail.com Description: I work frequently with tables that have 2 rows and many columns (5-10) that span many pages, the top row being a header that repeats on each page. I often need to insert footnotes into the table, both in the header row and in the second row. After inserting a few footnotes, I will inevitably experience problems with the display of the table. In the attached document, which is a sample of the kind of thing I work with daily, as soon as I inserted the third footnote, the table suddenly jumped to the second page and instead of spanning multiple pages, seems to think it's all on one page; the cursor will continue to go down below the displayed text. These problems disappear as soon as I set footnotes to display at the end of the document rather than on each page, but this is no solution, since I need footnotes to display on the pages themselves. This seems possibly related to https://bugs.documentfoundation.org/show_bug.cgi?id=125885 and https://bugs.documentfoundation.org/show_bug.cgi?id=120139. Steps to Reproduce: 1. Open the attached document; see that the table is displayed incorrectly. 2. Set footnotes to appear at the end of the document; see that the table displays correctly. 3. To try it from scratch: open a new document. 4. Write some text. 5. Insert a table with 2 rows and 10 columns, header repeating on each page. 6. Insert enough dummy text in the table to make it span multiple pages. 7. Start inserting footnotes at random places. It should very quickly mess up how the table is displayed. Actual Results: Table display is messed up; it moves to the second page, does not display all the text nor split it onto the next page correctly. Expected Results: Table and footnotes should be displayed properly. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129746] New: Changing printer before printing messes automatic page orientation
https://bugs.documentfoundation.org/show_bug.cgi?id=129746 Bug ID: 129746 Summary: Changing printer before printing messes automatic page orientation Product: LibreOffice Version: 6.4.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcoagpi...@sapo.pt Created attachment 156908 --> https://bugs.documentfoundation.org/attachment.cgi?id=156908=edit Video showing the behaviour on Windows 10 I have LO 6.4.0.1 installed, but I believe this also happens with 6.3. My default printer is a virtual PDF printer. I was in Calc and wanted to print into a physical printer. When I clicked in the print button it shows the orientation of the contents correctly (landscape) but after changing the printer, the automatic orientation messes landscape/portrait. See the attached video of it happening. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] specific form based sheet gets empty/invisible menu options and no mouseover comment pop-out in LO 6.4.0.1 WIN10 x64 with OpenGL (and Skia for master/6.5.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 --- Comment #12 from V Stuart Foote --- (In reply to V Stuart Foote from comment #11) Should add, with 6.4.0.1 and master/6.5.0 menus are fine with default CPU rendering and with Hardware Acceleration--though the comment in D8 still does not pop-up on mouse over. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] specific form based sheet gets empty/invisible menu options and no mouseover comment pop-out in LO 6.4.0.1 WIN10 x64 with OpenGL (and Skia for master/6.5.0)
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 V Stuart Foote changed: What|Removed |Added Summary|UI Calc-File has|specific form based sheet |empty/invisible menu|gets empty/invisible menu |options in LO 6.4.0.1 WIN10 |options and no mouseover |x64 |comment pop-out in LO ||6.4.0.1 WIN10 x64 with ||OpenGL (and Skia for ||master/6.5.0) Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||regression CC||er...@redhat.com, ||michael.me...@collabora.com ||, qui...@gmail.com, ||vmik...@collabora.com --- Comment #11 from V Stuart Foote --- So, this is weird! In attachment 156905, I am seeing a rendering issue (empty menus) but just with sheet/table:name="Planung" And this is am on Windows 10 64-bit en-US (1903) with nVidia Quadro K2000 GPU (driver 26.21.14.4128, Nov 2019) With OpenGL rendering enabled no issue with Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL but with recent master/6.5.0 (TB77 build 2019-12-31) Version: 6.5.0.0.alpha0+ (x64) Build ID: 444f0d256957544d26b9af9a0898364e829df1b5 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL and for the 6.4.0.1 release build (/a Administrative install) Version: 6.4.0.1 (x64) Build ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL Just this sheet/table:name="Planung" for the ODS archive, UI Context menus and Main menu render blank, and the pop-up comment in cell D8 is not opening. Other sheets of the document have no issue and do open context/main menus, and show the pop-up comments on mouse over. Weird issue on this sheet also affects the new Skia/Vulkan rendering on the master/6.5.0 build. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129423] Make export tests export-only where applicable (DECLARE_*EXPORT_TEST => DECLARE_*EXPORT_EXPORTONLY_TEST)
https://bugs.documentfoundation.org/show_bug.cgi?id=129423 --- Comment #7 from Commit Notification --- Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/873ce9b271b00e044912f4849ae2649b4fa21efd tdf#129423: Make export tests export-only where applicable It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport5.cxx | 196 ++
1 file changed, 44 insertions(+), 152 deletions(-)
New commits:
commit 873ce9b271b00e044912f4849ae2649b4fa21efd
Author: Onur Yilmaz
AuthorDate: Thu Dec 26 01:16:52 2019 +0300
Commit: Mike Kaganski
CommitDate: Thu Jan 2 20:03:10 2020 +0100
tdf#129423: Make export tests export-only where applicable
Change-Id: I4f143f37154646fd7d4d1df1e680aa1dd9dd1b17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85824
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 8e394f7a445c..9cc5e69775cf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -44,11 +44,9 @@ protected:
}
};
-DECLARE_OOXMLEXPORT_TEST(testFDO76248, "FDO76248.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFDO76248, "FDO76248.docx")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
- return;
// In two cases the a:graphicData elements had no children, which is
invalid.
assertXPath(pXmlDoc, "//a:graphicData[not(*)]", 0);
}
@@ -92,7 +90,7 @@ DECLARE_OOXMLEXPORT_TEST(testTscp, "tscp.docx")
CPPUNIT_ASSERT_EQUAL(false,
static_cast(xStatements->hasMoreElements()));
}
-DECLARE_OOXMLEXPORT_TEST(testfdo76589 , "fdo76589.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testfdo76589 , "fdo76589.docx")
{
/* Numbered list was not preserve after RT.
* In numbering.xml, when NumberingType is "decimal" and level is zero,
@@ -100,8 +98,6 @@ DECLARE_OOXMLEXPORT_TEST(testfdo76589 , "fdo76589.docx")
* It should be
*/
xmlDocPtr pXmlDoc = parseExport("word/numbering.xml");
-if (!pXmlDoc)
-return;
assertXPath ( pXmlDoc,
"/w:numbering/w:abstractNum[1]/w:lvl[1]/w:lvlText","val","%1" );
}
@@ -131,13 +127,10 @@ DECLARE_OOXMLEXPORT_TEST(testfdo79008, "fdo79008.docx")
return;
}
-DECLARE_OOXMLEXPORT_TEST(testAuthorPropertySdt, "author-property.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testAuthorPropertySdt,
"author-property.docx")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
- return;
-
assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:dataBinding",
"xpath", "/ns1:coreProperties[1]/ns0:creator[1]");
assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:dataBinding",
"storeItemID","{6C3C8BC8-F283-45AE-878A-BAB7291924A1}");
// FIXME: the next property doesn't match, though it's correct in theory.
A bug in assertXPath?
@@ -145,7 +138,7 @@ DECLARE_OOXMLEXPORT_TEST(testAuthorPropertySdt,
"author-property.docx")
//"xmlns:ns0='http://purl.org/dc/elements/1.1/'
xmlns:ns1='http://schemas.openxmlformats.org/package/2006/metadata/core-properties'");
}
-DECLARE_OOXMLEXPORT_TEST(testFDO76586, "fdo76586.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFDO76586, "fdo76586.docx")
{
/*
* In the test file gridCol had only one value for entire table width
@@ -154,24 +147,19 @@ DECLARE_OOXMLEXPORT_TEST(testFDO76586, "fdo76586.docx")
*/
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
- return;
-
// there is only one table in the test file
assertXPath(pXmlDoc, "//w:tblGrid/w:gridCol[1]", "w", "1601");
assertXPath(pXmlDoc, "//w:tblGrid/w:gridCol[2]", "w", "7843");
}
-DECLARE_OOXMLEXPORT_TEST(testFDO76587 , "fdo76587.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFDO76587 , "fdo76587.docx")
{
xmlDocPtr pXmlDoc = parseExport("word/styles.xml");
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc, "/w:styles/w:style[8]/w:pPr/w:spacing", "line",
"240");
assertXPath(pXmlDoc, "/w:styles/w:style[8]/w:pPr/w:spacing", "lineRule",
"auto");
}
-DECLARE_OOXMLEXPORT_TEST(testFDO77890 , "fdo77890.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFDO77890 , "fdo77890.docx")
{
/*
Ensure that the page break is preserved i.e it should not be converted to
a section break, in case
@@ -179,17 +167,13 @@ DECLARE_OOXMLEXPORT_TEST(testFDO77890 , "fdo77890.docx")
For additional comments please refer to
https://www.libreoffice.org/bugzilla/show_bug.cgi?id=77890#c2
*/
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc, "/w:document/w:body/w:p[2]/w:r[2]/w:br", "type",
"page");
}
-DECLARE_OOXMLEXPORT_TEST(testNumberedList,"NumberedList.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testNumberedList,"NumberedList.docx")
{
//fdo74150:In document.xml, for pStyle = "NumberedList1", iLvl and numId
was not preserved
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr[1]/w:pStyle", "val",
"NumberedList1");
assertXPath(pXmlDoc,
[Libreoffice-bugs] [Bug 129423] Make export tests export-only where applicable (DECLARE_*EXPORT_TEST => DECLARE_*EXPORT_EXPORTONLY_TEST)
https://bugs.documentfoundation.org/show_bug.cgi?id=129423 --- Comment #6 from Commit Notification --- Onur Yilmaz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/408f84f6b95a99013b841e1d923ec4cb05bd2a5c tdf#129423: Make export tests export-only where applicable It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport6.cxx | 104 +++---
1 file changed, 27 insertions(+), 77 deletions(-)
New commits:
commit 408f84f6b95a99013b841e1d923ec4cb05bd2a5c
Author: Onur Yilmaz
AuthorDate: Thu Dec 26 02:13:26 2019 +0300
Commit: Mike Kaganski
CommitDate: Thu Jan 2 20:01:05 2020 +0100
tdf#129423: Make export tests export-only where applicable
Change-Id: I15d76ded5342ec2dacfaade3da9e61c8f23deacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85826
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index d460679b50ba..3b5726dceb28 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -47,20 +47,16 @@ DECLARE_OOXMLEXPORT_TEST(testDmlShapeTitle,
"dml-shape-title.docx")
CPPUNIT_ASSERT_EQUAL(OUString("Description"),
getProperty(getShape(1), "Description"));
}
-DECLARE_OOXMLEXPORT_TEST(testDmlZorder, "dml-zorder.odt")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDmlZorder, "dml-zorder.odt")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
// This was "0": causing that in Word, the second shape was on top, while
in the original odt the first shape is on top.
assertXPath(pXmlDoc,
"/w:document/w:body/w:p/w:r/mc:AlternateContent[1]/mc:Choice/w:drawing/wp:anchor",
"relativeHeight", "2");
}
-DECLARE_OOXMLEXPORT_TEST(testDmlShapeRelsize, "dml-shape-relsize.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDmlShapeRelsize,
"dml-shape-relsize.docx")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
// Relative size wasn't exported all, then relativeFrom was "page", not
"margin".
assertXPath(pXmlDoc,
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:anchor/wp14:sizeRelH",
"relativeFrom", "margin");
}
@@ -76,11 +72,9 @@ DECLARE_OOXMLEXPORT_TEST(testDmlPictureInTextframe,
"dml-picture-in-textframe.do
CPPUNIT_ASSERT_EQUAL(false,
bool(xNameAccess->hasByName("word/media/image2.gif")));
}
-DECLARE_OOXMLEXPORT_TEST(testDmlGroupshapeRelsize,
"dml-groupshape-relsize.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDmlGroupshapeRelsize,
"dml-groupshape-relsize.docx")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
// Relative size wasn't imported.
assertXPath(pXmlDoc,
"/w:document/w:body/w:p/w:r/mc:AlternateContent/mc:Choice/w:drawing/wp:anchor/wp14:sizeRelH",
"relativeFrom", "margin");
}
@@ -349,15 +343,13 @@ DECLARE_OOXMLEXPORT_TEST(testDMLGroupShapeChildPosition,
"dml-groupshape-childpo
CPPUNIT_ASSERT_EQUAL(sal_Int32(mbExported ? 14026 : 14023),
xChildGroup->getPosition().Y);
}
-DECLARE_OOXMLEXPORT_TEST(testDMLGradientFillTheme,
"dml-gradientfill-theme.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDMLGradientFillTheme,
"dml-gradientfill-theme.docx")
{
// Problem was when a fill gradient was imported from a theme, (fillRef in
ooxml)
// not just the theme was written out but the explicit values too
// Besides the duplication of values it causes problems with writing out
// into document.xml, while phClr can be used
just for theme definitions.
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
-if (!pXmlDoc)
-return;
// check no explicit gradFill has been exported
assertXPath(pXmlDoc,
@@ -443,36 +435,30 @@ DECLARE_OOXMLEXPORT_TEST(testTableFloatingMargins,
"table-floating-margins.docx"
CPPUNIT_ASSERT_EQUAL(sal_Int32(1000), getProperty(xFrame,
"TopMargin"));
CPPUNIT_ASSERT_EQUAL(sal_Int32(2000), getProperty(xFrame,
"BottomMargin"));
+if (!mbExported)
+return;
// Paragraph bottom margin wasn't 0 in the A1 cell of the floating table.
xmlDocPtr pXmlDoc = parseExport();
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p/w:pPr/w:spacing", "after", "0");
}
-DECLARE_OOXMLEXPORT_TEST(testTdf127814, "tdf127814.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf127814, "tdf127814.docx")
{
// Paragraph top margin was 0 in a table started on a new page
xmlDocPtr pXmlDoc = parseExport();
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p/w:pPr/w:spacing", "before", "0");
}
-DECLARE_OOXMLEXPORT_TEST(testTdf128752, "tdf128752.docx")
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128752, "tdf128752.docx")
{
// Paragraph bottom margin was 200, docDefault instead of table style
setting
xmlDocPtr pXmlDoc = parseExport();
-if (!pXmlDoc)
-return;
assertXPath(pXmlDoc,
"/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:p[1]/w:pPr/w:spacing", "after",
"0");
}
-DECLARE_OOXMLEXPORT_TEST(testTdf119054, "tdf119054.docx")
[Libreoffice-commits] core.git: sot/source svx/source
sot/source/sdstor/stgdir.cxx|2 +-
svx/source/form/fmshimp.cxx |2 +-
svx/source/sdr/contact/viewcontactofvirtobj.cxx |2 +-
svx/source/svdraw/svdobj.cxx|2 +-
svx/source/svdraw/svdocapt.cxx |2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 9ef226c581ddf025e36aebefaa48c051354c520b
Author: Yusuf Keten
AuthorDate: Sun Dec 29 02:52:10 2019 +0300
Commit: Mike Kaganski
CommitDate: Thu Jan 2 19:58:48 2020 +0100
tdf#96505 Get rid of cargo cult long integer literals
Change-Id: I6b21f25738458a1d85905a3a02eb17c51a626b0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85932
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sot/source/sdstor/stgdir.cxx b/sot/source/sdstor/stgdir.cxx
index f31488fd07c2..4002d637230d 100644
--- a/sot/source/sdstor/stgdir.cxx
+++ b/sot/source/sdstor/stgdir.cxx
@@ -478,7 +478,7 @@ sal_Int32 StgDirEntry::Write( const void* p, sal_Int32 nLen
)
if( nNew > m_pStgStrm->GetSize() )
{
if( !SetSize( nNew ) )
-return 0L;
+return 0;
m_pStgStrm->Pos2Page( m_nPos );
}
nLen = m_pStgStrm->Write( p, nLen );
diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 845fbf030b85..ca14eef60bd8 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -2461,7 +2461,7 @@ IMPL_LINK(FmXFormShell, OnSearchContextRequest_Lock,
FmSearchContext&, rfmscCont
rfmscContextInfo.arrFields.clear();
rfmscContextInfo.xCursor = nullptr;
rfmscContextInfo.strUsedFields.clear();
-return 0L;
+return 0;
}
rfmscContextInfo.xCursor = xIter;
diff --git a/svx/source/sdr/contact/viewcontactofvirtobj.cxx
b/svx/source/sdr/contact/viewcontactofvirtobj.cxx
index c78670aa03fb..4efb3d65797d 100644
--- a/svx/source/sdr/contact/viewcontactofvirtobj.cxx
+++ b/svx/source/sdr/contact/viewcontactofvirtobj.cxx
@@ -56,7 +56,7 @@ sal_uInt32 ViewContactOfVirtObj::GetObjectCount() const
// As can be seen, with primitives, the problem will be solved using
// a transformPrimitive, so this solution can stay with primitives.
-return 0L;
+return 0;
}
drawinglayer::primitive2d::Primitive2DContainer
ViewContactOfVirtObj::createViewIndependentPrimitive2DSequence() const
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 76338b2a144e..db6238c704ba 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -1691,7 +1691,7 @@ bool SdrObject::IsPolyObj() const
sal_uInt32 SdrObject::GetPointCount() const
{
-return 0L;
+return 0;
}
Point SdrObject::GetPoint(sal_uInt32 /*i*/) const
diff --git a/svx/source/svdraw/svdocapt.cxx b/svx/source/svdraw/svdocapt.cxx
index 81b34988f0bc..dc7bdaf3aa4d 100644
--- a/svx/source/svdraw/svdocapt.cxx
+++ b/svx/source/svdraw/svdocapt.cxx
@@ -654,7 +654,7 @@ void SdrCaptionObj::NbcSetTailPos(const Point& rPos)
sal_uInt32 SdrCaptionObj::GetSnapPointCount() const
{
// TODO: Implementation missing.
-return 0L;
+return 0;
}
Point SdrCaptionObj::GetSnapPoint(sal_uInt32 /*i*/) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96505] Get rid of cargo cult "long" integer literals
https://bugs.documentfoundation.org/show_bug.cgi?id=96505 --- Comment #63 from Commit Notification --- Yusuf Keten committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9ef226c581ddf025e36aebefaa48c051354c520b tdf#96505 Get rid of cargo cult long integer literals It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129745] New: Help button in Paragraph Style dialog tab only remembers its "identity" once
https://bugs.documentfoundation.org/show_bug.cgi?id=129745 Bug ID: 129745 Summary: Help button in Paragraph Style dialog tab only remembers its "identity" once Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Any document, right-click, Paragraph, Edit Style (which opens Paragraph Style dialog box) 2. Click on Help button twice Actual Result: First time, opens help page for the tab. Second time, opens the generic introduction page: https://help.libreoffice.org/6.5/en-US/text/swriter/main.html?System=WIN=WRITER Expected Result: Always opens the relevant help page for the relevant tab. Additional information: 1. Same effect for different tabs in the Paragraph Style dialog 2. Have not tested with other dialog boxes 3. Works correctly with 6.3.4.2 tested with Version: 6.5.0.0.alpha0+ (x64) Build ID: 444f0d256957544d26b9af9a0898364e829df1b5 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; Locale: sv-SE (en_DK); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/qa cui/uiconfig cui/UIConfig_cui.mk solenv/sanitizers
cui/UIConfig_cui.mk|1 cui/qa/unit/data/cui-dialogs-test.txt |1 cui/uiconfig/ui/blackorwhitelistentrydialog.ui | 331 - solenv/sanitizers/ui/cui.suppr | 14 - 4 files changed, 347 deletions(-) New commits: commit c4aa1277bdb7958990a2cabdbda44c72d9712d3c Author: Caolán McNamara AuthorDate: Wed Jan 1 18:35:28 2020 + Commit: Caolán McNamara CommitDate: Thu Jan 2 19:43:57 2020 +0100 blackorwhitelistentrydialog never got used Change-Id: I5985bf966879fafa6472a8fb51ee63d07f7dd734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86075 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk index 19c8f21e7e73..fe330ceca65d 100644 --- a/cui/UIConfig_cui.mk +++ b/cui/UIConfig_cui.mk @@ -28,7 +28,6 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\ cui/uiconfig/ui/backgroundpage \ cui/uiconfig/ui/baselinksdialog \ cui/uiconfig/ui/bitmaptabpage \ - cui/uiconfig/ui/blackorwhitelistentrydialog \ cui/uiconfig/ui/borderareatransparencydialog \ cui/uiconfig/ui/borderbackgrounddialog \ cui/uiconfig/ui/borderpage \ diff --git a/cui/qa/unit/data/cui-dialogs-test.txt b/cui/qa/unit/data/cui-dialogs-test.txt index b9f8f99813f6..115a2697ef6d 100644 --- a/cui/qa/unit/data/cui-dialogs-test.txt +++ b/cui/qa/unit/data/cui-dialogs-test.txt @@ -69,7 +69,6 @@ cui/ui/assigncomponentdialog.ui cui/ui/autocorrectdialog.ui cui/ui/backgroundpage.ui cui/ui/baselinksdialog.ui -cui/ui/blackorwhitelistentrydialog.ui cui/ui/borderareatransparencydialog.ui cui/ui/borderbackgrounddialog.ui cui/ui/borderpage.ui diff --git a/cui/uiconfig/ui/blackorwhitelistentrydialog.ui b/cui/uiconfig/ui/blackorwhitelistentrydialog.ui deleted file mode 100644 index bcb663daeb27.. --- a/cui/uiconfig/ui/blackorwhitelistentrydialog.ui +++ /dev/null @@ -1,331 +0,0 @@ - - - - - - - - - - - - - -Any -0 - - -Linux -1 - - -OS X -2 - - -Windows -3 - - - - -False -6 -dummy -dialog - - -False -vertical -12 - - -False -end - - -gtk-ok -True -True -True -True -True -True - - -False -True -0 - - - - -gtk-cancel -True -True -True -True - - -False -True -1 - - - - -gtk-help -True -True -True -True - - -False -True -2 -True - - - - -False -True -end -0 - - - - -True -False -0 -none - - -True -False -6 -12 - - -True -False -True -12 - - -True -False -True -6 -6 - - -True -False -True -os-liststore - - -1 -0 - - - - -True -True -True -True -22 - - -1 -1 - - - - -True -True -True -True -12 - - -
[Libreoffice-commits] core.git: chart2/qa
0 files changed New commits: commit 33a141d81b8f078aa9caacda6bf858decd48ade9 Author: Andrea Gelmini AuthorDate: Thu Jan 2 16:47:50 2020 +0100 Commit: Julien Nabet CommitDate: Thu Jan 2 19:40:51 2020 +0100 Removed executable permission on file Change-Id: Id1ed8cb31ae07276184d074aefc436ec3d8136fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86132 Tested-by: Jenkins Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/chart2/qa/extras/data/pptx/tdf125444.pptx b/chart2/qa/extras/data/pptx/tdf125444.pptx old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129744] New: Customized Alt+Left and Alt+Right key bindings are ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=129744 Bug ID: 129744 Summary: Customized Alt+Left and Alt+Right key bindings are ignored Product: LibreOffice Version: 6.3.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: han...@ucsc.edu Description: Binding Alt+Left and Alt+Right to "To Word Left" and "To Word Right" does not work and hitting those keys just moves the cursor by one character instead of an entire word. It's as if the Alt modifier is ignored and pressing Alt+Left is handled as if just Left were pressed. Steps to Reproduce: 1. Tools - Customize - Keyboard 2. Select "Alt+Left" under Shortcut Keys 3. Under Functions, select "To Word Left" 4. Click modify, click OK 5. Type some words into the document 6. Hit Alt+Left Actual Results: Cursor moves left by one character Expected Results: Cursor moves by one word Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/unowriter/unowriter.cxx | 38 +++
sw/source/core/crsr/crsrsh.cxx |2 -
2 files changed, 38 insertions(+), 2 deletions(-)
New commits:
commit d8a188d8d59ae51621a0540fe931e1c70db285fe
Author: Mike Kaganski
AuthorDate: Thu Jan 2 19:30:06 2020 +0300
Commit: Mike Kaganski
CommitDate: Thu Jan 2 19:30:38 2020 +0100
tdf#129743: don't delete mark of current cursor when creating new cursor
The deletion was there since initial import in commit
84a3db80b4fd66c6854b3135b5f69b61fd828e62. It's unclear why would it
be necessary and what depend on it. All tests pass => let's drop it.
Another (less intrusive, and IMO more of a workaround) way would be
to move setting mark of pCursor after the loop over GetNext() in
SwCursorShell::SetSelection.
Change-Id: I5402db58d8f829799bc16b8f4f6014bcea133995
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86142
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/extras/unowriter/unowriter.cxx
b/sw/qa/extras/unowriter/unowriter.cxx
index 630a72afa6b1..1cceb108181d 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -786,6 +787,43 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter,
testTextConvertToTableLineSpacing)
CPPUNIT_ASSERT_EQUAL(static_cast(convertTwipToMm100(220)),
aLineSpacing.Height);
}
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testMultiSelect)
+{
+// Create a new document and add a text with several repeated sequences.
+loadURL("private:factory/swriter", nullptr);
+uno::Reference xTextDocument(mxComponent,
css::uno::UNO_QUERY_THROW);
+auto xSimpleText = xTextDocument->getText();
+xSimpleText->insertString(xSimpleText->getStart(), "abc abc abc", false);
+
+// Create a search descriptor and find all occurencies of search string
+css::uno::Reference xSearchable(mxComponent,
css::uno::UNO_QUERY_THROW);
+auto xSearchDescriptor = xSearchable->createSearchDescriptor();
+xSearchDescriptor->setPropertyValue("SearchStyles", css::uno::Any(false));
+xSearchDescriptor->setPropertyValue("SearchCaseSensitive",
css::uno::Any(false));
+xSearchDescriptor->setPropertyValue("SearchBackwards",
css::uno::Any(true));
+xSearchDescriptor->setPropertyValue("SearchRegularExpression",
css::uno::Any(false));
+xSearchDescriptor->setSearchString("Abc");
+auto xSearchResult = xSearchable->findAll(xSearchDescriptor);
+
+// Select them all
+auto xController = xTextDocument->getCurrentController();
+css::uno::Reference xSelectionSupplier(
+xController, css::uno::UNO_QUERY_THROW);
+xSelectionSupplier->select(css::uno::Any(xSearchResult));
+css::uno::Reference
xSelection(xSelectionSupplier->getSelection(),
+
css::uno::UNO_QUERY_THROW);
+// Now check that they all are selected.
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xSelection->getCount());
+for (sal_Int32 i = 0; i < xSelection->getCount(); ++i)
+{
+css::uno::Reference
xTextRange(xSelection->getByIndex(i),
+
css::uno::UNO_QUERY_THROW);
+// For i=0, result was empty (cursor was put before the last occurence
without selection)
+const OString sComment = "i=" + OString::number(i);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(sComment.getStr(), OUString("abc"),
xTextRange->getString());
+}
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 838159a28034..29293a841ebe 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -127,8 +127,6 @@ SwPaM * SwCursorShell::CreateCursor()
// copied PaM (#i75172#)
pNew->swapContent(*m_pCurrentCursor);
-m_pCurrentCursor->DeleteMark();
-
UpdateCursor( SwCursorShell::SCROLLWIN );
return pNew;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/osx
vcl/inc/osx/salnativewidgets.h | 60 - vcl/osx/salnativewidgets.cxx | 1625 ++--- 2 files changed, 768 insertions(+), 917 deletions(-) New commits: commit 9d31d8f1d8d3a73f8c07ca39f5ed45e2bb7b088c Author: Thorsten Wagner AuthorDate: Wed Jan 1 14:43:38 2020 +0100 Commit: Noel Grandin CommitDate: Thu Jan 2 19:15:07 2020 +0100 tdf#125536 macOS native Carbon widgets reworked Change-Id: Id60895a48f59cb3c55db39d18cd27fed2108727e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86066 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/inc/osx/salnativewidgets.h b/vcl/inc/osx/salnativewidgets.h index 1ba697afafa2..67d3a37612e7 100644 --- a/vcl/inc/osx/salnativewidgets.h +++ b/vcl/inc/osx/salnativewidgets.h @@ -20,42 +20,50 @@ #ifndef INCLUDED_VCL_INC_OSX_SALNATIVEWIDGETS_H #define INCLUDED_VCL_INC_OSX_SALNATIVEWIDGETS_H -// since 10.4 ... no metrics are returned, and we have to fix the values -#define BUTTON_WIDTH 16 -#define BUTTON_HEIGHT 17 +#define TAB_HEIGHT 20 // height of tab header in pixels +#define TAB_TEXT_MARGIN 12// left/right margin of text within tab headers +#define VCL_TAB_TEXT_SEPARATOR 2 // Space between two tabs required by VCL -//standard height of the AHIG -//tabs -#define TAB_HEIGHT_NORMAL 20 +#define FOCUS_RING_WIDTH 4 // width of focus ring in pixels -#define TAB_TEXT_OFFSET 12 -#define VCL_TAB_TEXT_OFFSET 2 +#define MEDIUM_PROGRESS_INDICATOR_HEIGHT 10 // height of medium progress indicator in pixels +#define LARGE_PROGRESS_INDICATOR_HEIGHT 16 // height of large progress indicator in pixels -//listboxes, comboboxes (they have the same dimensions) -#define COMBOBOX_HEIGHT_NORMAL 20 -#define DROPDOWN_BUTTON_WIDTH 20 +#define PUSH_BUTTON_NORMAL_HEIGHT 21 // height of normal push button without focus ring in pixels +#define PUSH_BUTTON_SMALL_HEIGHT 15 // height of small push button without focus ring in pixels -//text edit -#define TEXT_EDIT_HEIGHT_NORMAL 22 +#define RADIO_BUTTON_SMALL_SIZE 14 // width/height of small radio button without focus ring in pixels +#define RADIO_BUTTON_TEXT_SEPARATOR 3 // space between radio button and following text in pixels -//spin box -#define SPIN_BUTTON_SPACE 2 -#define SPIN_BUTTON_WIDTH 13 -#define SPIN_UPPER_BUTTON_HEIGHT11 -#define SPIN_LOWER_BUTTON_HEIGHT10 +#define CHECKBOX_SMALL_SIZE 14 // width/heiht of checkbox without focus ring in pixels +#define CHECKBOX_TEXT_SEPARATOR 3 // space between checkbox and following text in pixels -// progress bar -#define INTRO_PROGRESS_HEIGHT 9 +#define SLIDER_WIDTH 19 // width of slider in pixels +#define SLIDER_HEIGHT 18 // height of slider in pixels -// for some controls, like spinbuttons + spinboxes, or listboxes -// we need it to adjust text position beside radio and check buttons +#define EDITBOX_HEIGHT 21 // height of editbox without focus ring in pixels +#define EDITBOX_BORDER_WIDTH 1 // width of editbox border in pixels +#define EDITBOX_INSET_MARGIN 1 // width of left/right as well as top/bottom editbox margin in pixels -#define TEXT_SEPARATOR 3 +#define COMBOBOX_HEIGHT 20// height of combobox without focus ring in pixels +#define COMBOBOX_BUTTON_WIDTH 18 // width of combobox button without focus ring in pixels +#define COMBOBOX_BORDER_WIDTH 1 // width of combobox border in pixels +#define COMBOBOX_TEXT_MARGIN 1// left/right margin of text in pixels -// extra border for focus ring -#define FOCUS_RING_WIDTH 4 +#define LISTBOX_HEIGHT 20// height of listbox without focus ring in pixels +#define LISTBOX_BUTTON_WIDTH 18 // width of listbox button without focus ring in pixels +#define LISTBOX_BORDER_WIDTH 1 // width of listbox border in pixels +#define LISTBOX_TEXT_MARGIN 1// left/right margin of text in pixels -#define CLIP_FUZZ 1 +#define SPIN_BUTTON_WIDTH 13 // width of spin button without focus ring in pixels +#define SPIN_UPPER_BUTTON_HEIGHT 11 // height of upper spin button without focus ring in pixels +#define SPIN_LOWER_BUTTON_HEIGHT 11 // height of lower spin button without focus ring in pixels + +// FIXME: spinboxes are positioned one pixel shifted to the right by VCL. As positioning as well as size should be equal to +// corresponing editboxes, comboboxes or listboxes, positioning of spinboxes should by equal too. Issue cannot be fixed within +// native widget drawing code. As a workaround, an offset is considered for spinboxes to align spinboxes correctly. + +#define SPINBOX_OFFSET 1 // left offset for alignment with editboxes, comboboxes, and listboxes #endif // INCLUDED_VCL_INC_OSX_SALNATIVEWIDGETS_H diff --git a/vcl/osx/salnativewidgets.cxx b/vcl/osx/salnativewidgets.cxx index 6e94cd3e4df3..5248251480c5 100644 --- a/vcl/osx/salnativewidgets.cxx +++ b/vcl/osx/salnativewidgets.cxx @@ -36,6 +36,22 @@ #include "cuidraw.hxx" +//
[Libreoffice-commits] core.git: configmgr/source
configmgr/source/access.cxx| 94 ++---
configmgr/source/access.hxx|2
configmgr/source/childaccess.cxx | 16 ++--
configmgr/source/childaccess.hxx |1
configmgr/source/components.cxx| 11 ++-
configmgr/source/components.hxx|1
configmgr/source/configurationprovider.cxx | 15 ++--
configmgr/source/defaultprovider.cxx |2
configmgr/source/lock.cxx | 12 ++-
configmgr/source/lock.hxx |3
configmgr/source/readonlyaccess.cxx|2
configmgr/source/readwriteaccess.cxx |2
configmgr/source/rootaccess.cxx| 17 ++---
configmgr/source/rootaccess.hxx|2
configmgr/source/update.cxx| 10 +--
15 files changed, 105 insertions(+), 85 deletions(-)
New commits:
commit cb109d6518cc36155f9d0665932de0a54fdb6f4a
Author: Noel Grandin
AuthorDate: Thu Jan 2 08:05:01 2020 +0100
Commit: Noel Grandin
CommitDate: Thu Jan 2 19:07:20 2020 +0100
Revert "no need to use shared_ptr here"
This reverts commit 122598af564082786f01b4eafdb9f09f0cffdf5f.
Reason for revert: shared_ptr was introduced for fdo#31494, to avoid issues
during shutdown
Change-Id: I1c3ef4a966b9244da1e504806e917d1918b83803
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86095
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index 0564cb3bad88..9fe7f31cc00f 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -171,7 +171,7 @@ void Access::initBroadcaster(
css::uno::Sequence< css::uno::Type > Access::getTypes()
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
std::vector< css::uno::Type > types;
types.push_back(cppu::UnoType< css::uno::XInterface >::get());
@@ -222,7 +222,7 @@ css::uno::Sequence< css::uno::Type > Access::getTypes()
css::uno::Sequence< sal_Int8 > Access::getImplementationId()
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
return css::uno::Sequence< sal_Int8 >();
}
@@ -230,7 +230,7 @@ css::uno::Sequence< sal_Int8 > Access::getImplementationId()
OUString Access::getImplementationName()
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
return "org.openoffice-configmgr::Access";
}
@@ -243,7 +243,7 @@ sal_Bool Access::supportsService(OUString const &
ServiceName)
css::uno::Sequence< OUString > Access::getSupportedServiceNames()
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
std::vector services;
services.emplace_back("com.sun.star.configuration.ConfigurationAccess");
@@ -274,7 +274,7 @@ void Access::dispose() {
assert(thisIs(IS_ANY));
Broadcaster bc;
{
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
if (getParentAccess().is()) {
throw css::uno::RuntimeException(
@@ -296,7 +296,7 @@ void Access::addEventListener(
{
assert(thisIs(IS_ANY));
{
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
if (!xListener.is()) {
throw css::uno::RuntimeException(
@@ -317,7 +317,7 @@ void Access::removeEventListener(
css::uno::Reference< css::lang::XEventListener > const & aListener)
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
DisposeListeners::iterator i(disposeListeners_.find(aListener));
if (i != disposeListeners_.end()) {
@@ -327,7 +327,7 @@ void Access::removeEventListener(
css::uno::Type Access::getElementType() {
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
rtl::Reference< Node > p(getNode());
switch (p->kind()) {
@@ -350,7 +350,7 @@ css::uno::Type Access::getElementType() {
sal_Bool Access::hasElements() {
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
return !getAllChildren().empty(); //TODO: optimize
}
@@ -394,7 +394,7 @@ bool Access::getByNameFast(const OUString & name,
css::uno::Any & value)
css::uno::Any Access::getByName(OUString const & aName)
{
assert(thisIs(IS_ANY));
-osl::MutexGuard g(theConfigLock());
+osl::MutexGuard g(*lock_);
checkLocalizedPropertyAccess();
css::uno::Any value;
if (!getByNameFast(aName,
[Libreoffice-commits] core.git: extras/source include/svx solenv/bin svx/source
extras/source/glade/libreoffice-catalog.xml.in |4 -
include/svx/papersizelistbox.hxx | 13 -
solenv/bin/native-code.py |1
svx/source/dialog/papersizelistbox.cxx | 62 -
4 files changed, 80 deletions(-)
New commits:
commit c7043c0f2aab380648c8e35b8724107a881978b3
Author: Caolán McNamara
AuthorDate: Wed Jan 1 21:05:17 2020 +
Commit: Caolán McNamara
CommitDate: Thu Jan 2 18:54:46 2020 +0100
PaperSizeListBox is now unused
Change-Id: I0ce2fbb7f0346f55984a419f741319690a209434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86121
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/extras/source/glade/libreoffice-catalog.xml.in
b/extras/source/glade/libreoffice-catalog.xml.in
index c9bcb3b9b73a..ad20ad5fac51 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -122,10 +122,6 @@
generic-name="Fill Attr ListBox" parent="GtkComboBox"
icon-name="widget-gtk-combobox"/>
-
-
diff --git a/include/svx/papersizelistbox.hxx b/include/svx/papersizelistbox.hxx
index 4dea2e176dde..5ede4fc81bc6 100644
--- a/include/svx/papersizelistbox.hxx
+++ b/include/svx/papersizelistbox.hxx
@@ -22,7 +22,6 @@
#include
#include
-#include
#include
enum class PaperSizeApp
@@ -31,18 +30,6 @@ enum class PaperSizeApp
Draw
};
-class SVX_DLLPUBLIC PaperSizeListBox final : public ListBox
-{
-public:
-PaperSizeListBox( vcl::Window* pParent );
-
-void FillPaperSizeEntries( PaperSizeApp eApp );
-void SetSelection( Paper eSize );
-Paper GetSelection() const;
-
-Size GetOptimalSize() const override;
-};
-
class SVX_DLLPUBLIC SvxPaperSizeListBox
{
private:
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index d99370c3c18f..91c7df2d1403 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -502,7 +502,6 @@ custom_widgets = [
'IndexBox',
'ManagedMenuButton',
'OptionalBox',
-'PaperSizeListBox',
'PriorityHBox',
'PriorityMergedHBox',
'PropertyControl',
diff --git a/svx/source/dialog/papersizelistbox.cxx
b/svx/source/dialog/papersizelistbox.cxx
index f1ac6d4c0e40..c9c7a3001339 100644
--- a/svx/source/dialog/papersizelistbox.cxx
+++ b/svx/source/dialog/papersizelistbox.cxx
@@ -20,70 +20,8 @@
#include
#include
#include
-#include
#include "page.hrc"
-PaperSizeListBox::PaperSizeListBox(vcl::Window* pParent)
-: ListBox( pParent, WB_BORDER | WB_DROPDOWN)
-{
-SetDropDownLineCount(6);
-}
-
-VCL_BUILDER_FACTORY(PaperSizeListBox);
-
-void PaperSizeListBox::FillPaperSizeEntries( PaperSizeApp eApp )
-{
-const std::pair* pPaperAry = eApp == PaperSizeApp::Std ?
-RID_SVXSTRARY_PAPERSIZE_STD : RID_SVXSTRARY_PAPERSIZE_DRAW;
-sal_uInt32 nCnt = eApp == PaperSizeApp::Std ?
-SAL_N_ELEMENTS(RID_SVXSTRARY_PAPERSIZE_STD) :
SAL_N_ELEMENTS(RID_SVXSTRARY_PAPERSIZE_DRAW);
-
-for ( sal_uInt32 i = 0; i < nCnt; ++i )
-{
-OUString aStr = SvxResId(pPaperAry[i].first);
-Paper eSize = static_cast(pPaperAry[i].second);
-sal_Int32 nPos = InsertEntry( aStr );
-SetEntryData( nPos,
reinterpret_cast(static_cast(eSize)) );
-}
-}
-
-void PaperSizeListBox::SetSelection( Paper ePreselectPaper )
-{
-sal_Int32 nEntryCount = GetEntryCount();
-sal_Int32 nSelPos = LISTBOX_ENTRY_NOTFOUND;
-sal_Int32 nUserPos = LISTBOX_ENTRY_NOTFOUND;
-
-for (sal_Int32 i = 0; i < nEntryCount; ++i )
-{
-Paper eTmp =
static_cast(reinterpret_cast(GetEntryData(i)));
-
-if ( eTmp == ePreselectPaper )
-{
-nSelPos = i;
-break;
-}
-
-if ( eTmp == PAPER_USER )
- nUserPos = i;
-}
-
-// preselect current paper format - #115915#: ePaper might not be in
aPaperSizeBox so use PAPER_USER instead
-SelectEntryPos( ( nSelPos != LISTBOX_ENTRY_NOTFOUND ) ? nSelPos : nUserPos
);
-}
-
-Paper PaperSizeListBox::GetSelection() const
-{
-const sal_Int32 nPos = GetSelectedEntryPos();
-Paper ePaper =
static_cast(reinterpret_cast(GetEntryData( nPos )));
-
-return ePaper;
-}
-
-Size PaperSizeListBox::GetOptimalSize() const
-{
-return Size(150, ListBox::GetOptimalSize().Height());
-}
-
SvxPaperSizeListBox::SvxPaperSizeListBox(std::unique_ptr
pControl)
: m_xControl(std::move(pControl))
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/pagefooterpanel.ui | 17 + sw/uiconfig/swriter/ui/pageformatpanel.ui |2 ++ sw/uiconfig/swriter/ui/pageheaderpanel.ui | 19 +-- sw/uiconfig/swriter/ui/pagestylespanel.ui | 25 +++-- 4 files changed, 35 insertions(+), 28 deletions(-) New commits: commit 9c7c5001f257ea9b5771d839cf7d0b039cfae79c Author: Caolán McNamara AuthorDate: Wed Jan 1 20:36:08 2020 + Commit: Caolán McNamara CommitDate: Thu Jan 2 18:54:25 2020 +0100 use same margins etc on writer sidebar panels Change-Id: I03a490abd6d35967ec5f873a8345c11466e30dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86119 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/pagefooterpanel.ui b/sw/uiconfig/swriter/ui/pagefooterpanel.ui index 2df5d8d831fd..7ef21bb84030 100644 --- a/sw/uiconfig/swriter/ui/pagefooterpanel.ui +++ b/sw/uiconfig/swriter/ui/pagefooterpanel.ui @@ -1,5 +1,5 @@ - + @@ -19,6 +19,7 @@ True False +end 6 @@ -44,10 +45,9 @@ True False -end -True Margins: footermarginpreset +1 False @@ -64,6 +64,7 @@ False +True Custom @@ -75,9 +76,9 @@ True False -end Spacing: spacingpreset +1 0 @@ -88,9 +89,9 @@ True False -end Same Content: samecontentLB +1 0 @@ -101,7 +102,7 @@ True False -end +True 1 @@ -112,7 +113,7 @@ True False -end +True 1 @@ -123,7 +124,7 @@ True False -end +True 1 diff --git a/sw/uiconfig/swriter/ui/pageformatpanel.ui b/sw/uiconfig/swriter/ui/pageformatpanel.ui index deacf8cc7354..9a55247e4655 100644 --- a/sw/uiconfig/swriter/ui/pageformatpanel.ui +++ b/sw/uiconfig/swriter/ui/pageformatpanel.ui @@ -138,6 +138,7 @@ True False +True 1 @@ -147,6 +148,7 @@ False +True Custom diff --git a/sw/uiconfig/swriter/ui/pageheaderpanel.ui b/sw/uiconfig/swriter/ui/pageheaderpanel.ui index 8e45f56b030b..1f935d4bf65d 100644 --- a/sw/uiconfig/swriter/ui/pageheaderpanel.ui +++ b/sw/uiconfig/swriter/ui/pageheaderpanel.ui @@ -1,5 +1,5 @@ - + @@ -19,6 +19,7 @@ True False +end 6 @@ -44,10 +45,9 @@ True False -end -True Margins: headermarginpreset +1 False @@ -64,6 +64,7 @@ False +True Custom @@ -75,9 +76,9 @@ True False -end Spacing: spacingpreset +1 0 @@ -88,9 +89,9 @@ True False -end Same Content: samecontentLB +1 0 @@ -101,7 +102,7 @@ True False -end +True 1 @@ -112,7 +113,7 @@ True False -end +True 1 @@ -123,7 +124,7 @@ True False -end +True 1 @@ -137,8 +138,6 @@ 0 0 -1 -1 diff --git a/sw/uiconfig/swriter/ui/pagestylespanel.ui b/sw/uiconfig/swriter/ui/pagestylespanel.ui index f8acc399e109..6b3a71400a92 100644 --- a/sw/uiconfig/swriter/ui/pagestylespanel.ui +++ b/sw/uiconfig/swriter/ui/pagestylespanel.ui @@ -34,7 +34,6 @@ True False center -12 True True 6 @@ -71,7 +70,8 @@ True -True +False +True
[Libreoffice-commits] core.git: vcl/inc vcl/qa vcl/source
vcl/inc/window.h |5 -
vcl/qa/cppunit/outdev.cxx| 15 +++
vcl/source/control/edit.cxx |2 +-
vcl/source/gdi/impanmvw.cxx |8
vcl/source/window/cursor.cxx |4 ++--
vcl/source/window/paint.cxx |8 ++--
6 files changed, 32 insertions(+), 10 deletions(-)
New commits:
commit b0fa356eed82a0452e6bcb915f179f5e2d02943a
Author: Miklos Vajna
AuthorDate: Thu Jan 2 18:02:41 2020 +0100
Commit: Miklos Vajna
CommitDate: Thu Jan 2 18:48:13 2020 +0100
tdf#129662 vcl: rtl: fix scrollbar in dropdowns
Regression from commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e
(tdf#101978 vcl combobox/listbox floating window: avoid flicker,
2019-06-17).
High-level vcl double-buffering never set up RTL status of the virtual
device correctly, but now that double-buffering is used at more places,
this got noticed.
Change-Id: Iba378cef3a693b0712389fab519f38ee222577d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86134
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index 970e7c58b0c3..4da4a3adc5d2 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -396,8 +396,10 @@ public:
bool mbLOKParentNotifier;
};
+namespace vcl
+{
/// Sets up the buffer to have settings matching the window, and restores the
original state in the dtor.
-class PaintBufferGuard
+class VCL_DLLPUBLIC PaintBufferGuard
{
ImplFrameData* mpFrameData;
VclPtr m_pWindow;
@@ -415,6 +417,7 @@ public:
/// Returns either the frame's buffer or the window, in case of no
buffering.
vcl::RenderContext* GetRenderContext();
};
+}
// helper methods
diff --git a/vcl/qa/cppunit/outdev.cxx b/vcl/qa/cppunit/outdev.cxx
index 2f42412e75aa..e99a35f67adf 100644
--- a/vcl/qa/cppunit/outdev.cxx
+++ b/vcl/qa/cppunit/outdev.cxx
@@ -17,6 +17,7 @@
#include
#include
#include
+#include
#include
@@ -34,6 +35,7 @@ public:
void testDrawTransformedBitmapEx();
void testDrawTransformedBitmapExFlip();
void testRTL();
+void testRTLGuard();
CPPUNIT_TEST_SUITE(VclOutdevTest);
CPPUNIT_TEST(testVirtualDevice);
@@ -45,6 +47,7 @@ public:
CPPUNIT_TEST(testDrawTransformedBitmapEx);
CPPUNIT_TEST(testDrawTransformedBitmapExFlip);
CPPUNIT_TEST(testRTL);
+CPPUNIT_TEST(testRTLGuard);
CPPUNIT_TEST_SUITE_END();
};
@@ -269,6 +272,18 @@ void VclOutdevTest::testRTL()
CPPUNIT_ASSERT(pBuffer->IsRTLEnabled());
}
+void VclOutdevTest::testRTLGuard()
+{
+ScopedVclPtrInstance pWindow(nullptr, WB_APP | WB_STDWORK);
+pWindow->EnableRTL();
+pWindow->RequestDoubleBuffering(true);
+ImplFrameData* pFrameData = pWindow->ImplGetWindowImpl()->mpFrameData;
+vcl::PaintBufferGuard aGuard(pFrameData, pWindow);
+// Without the accompanying fix in place, this test would have failed,
because the RTL status
+// from pWindow was not propagated to aGuard.
+CPPUNIT_ASSERT(aGuard.GetRenderContext()->IsRTLEnabled());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(VclOutdevTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index ddf942f76c15..4525eb630613 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -977,7 +977,7 @@ void Edit::ImplClearBackground(vcl::RenderContext&
rRenderContext, const tools::
{
// ImplPaintBorder() is a NOP, we have a native border, and this is a
sub-edit of a control.
// That means we have to draw the parent native widget to paint the
edit area to clear our background.
-PaintBufferGuard g(ImplGetWindowImpl()->mpFrameData, GetParent());
+vcl::PaintBufferGuard g(ImplGetWindowImpl()->mpFrameData, GetParent());
GetParent()->Paint(rRenderContext, rRectangle);
}
}
diff --git a/vcl/source/gdi/impanmvw.cxx b/vcl/source/gdi/impanmvw.cxx
index 0537c349e0f3..7818a3dcc0ed 100644
--- a/vcl/source/gdi/impanmvw.cxx
+++ b/vcl/source/gdi/impanmvw.cxx
@@ -152,11 +152,11 @@ void ImplAnimView::drawToPos( sal_uLong nPos )
{
VclPtr pRenderContext = mpRenderContext;
-std::unique_ptr pGuard;
+std::unique_ptr pGuard;
if (mpRenderContext->GetOutDevType() == OUTDEV_WINDOW)
{
vcl::Window* pWindow =
static_cast(mpRenderContext.get());
-pGuard.reset(new
PaintBufferGuard(pWindow->ImplGetWindowImpl()->mpFrameData, pWindow));
+pGuard.reset(new
vcl::PaintBufferGuard(pWindow->ImplGetWindowImpl()->mpFrameData, pWindow));
pRenderContext = pGuard->GetRenderContext();
}
@@ -184,11 +184,11 @@ void ImplAnimView::draw( sal_uLong nPos, VirtualDevice*
pVDev )
{
VclPtr pRenderContext = mpRenderContext;
-std::unique_ptr pGuard;
+std::unique_ptr pGuard;
if (!pVDev && mpRenderContext->GetOutDevType() == OUTDEV_WINDOW)
{
vcl::Window* pWindow =
static_cast(mpRenderContext.get());
-pGuard.reset(new
[Libreoffice-bugs] [Bug 129743] XSelectionSupplier::select does not first range of passed multi-range
https://bugs.documentfoundation.org/show_bug.cgi?id=129743 Wolfgang Jäger changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #4 from Wolfgang Jäger --- Tried to repair. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129743] XSelectionSupplier::select does not first range of passed multi-range
https://bugs.documentfoundation.org/show_bug.cgi?id=129743 --- Comment #3 from Wolfgang Jäger --- Sorry. Was too rash! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129743] XSelectionSupplier::select does not first range of passed multi-range
https://bugs.documentfoundation.org/show_bug.cgi?id=129743 Wolfgang Jäger changed: What|Removed |Added CC||j...@psilosoph.de Status|ASSIGNED|NEW Assignee|mikekagan...@hotmail.com|libreoffice-b...@lists.free ||desktop.org --- Comment #2 from Wolfgang Jäger --- Tested with V6.4.0.1RC (Also with V5.4.4 and V3.3.0 : Same behaviour.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #141 from Thorsten Wagner --- SDK 10.13 seems to be the only SDK to build LO with sharp text on retina displays. Sharp text is back again on macOS Mojave with SDK 10.13 too. Minimum SDK release is currently 10.12. Due to API changes between SDK 10.12 and 10.13 which have been incorporated in LO code already, LO cannot be build with SDK 10.12. Mimimum SDK release should be increased to 10.13. Furthermore LO should be build with SDK 10.13 only until issue is fixed (maybe an issue of Apple within Carbon code). Although Xcode ships with a current release of the SDK, it is possible to install additional SDKs here: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs Additional SDKs can be extracted from ealier Xcode releases, which are all downloadable from Apple. SDK with lowest (oldest) release is is choosen by LO build scripts. Unitl minimum SDK release has not been increased to 10.13, a lower (older) release than 10.13 should not be installed side by side. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129743] XSelectionSupplier::select does not first range of passed multi-range
https://bugs.documentfoundation.org/show_bug.cgi?id=129743 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/86142 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129743] New: XSelectionSupplier::select does not first range of passed multi-range
https://bugs.documentfoundation.org/show_bug.cgi?id=129743 Bug ID: 129743 Summary: XSelectionSupplier::select does not first range of passed multi-range Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com 1. Create a new text document; 2. Type this text: "abc abc abc" 3. Run this BASIC code: Sub Main d = ThisComponent f = d.createSearchDescriptor() f.SearchString = "abc" c = d.findAll(f) d.currentController.select(c) End Sub Expected result: three pieces of "abc" text selected Actual result: second and third pieces are selected, but first is not; cursor blinks after "c" of the first (not selected) occurence of "abc". Already reproducible with OpenOffice.org 3.3.0 OOO330m20 (Build:9567) and with Version: 6.4.0.1 (x64) Build ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded Ref.: https://ask.libreoffice.org/en/question/223441 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Toolbar.js | 41 ---
loleaflet/src/layer/tile/CalcTileLayer.js|3 -
loleaflet/src/layer/tile/ImpressTileLayer.js |3 -
loleaflet/src/layer/tile/WriterTileLayer.js |3 -
4 files changed, 34 insertions(+), 16 deletions(-)
New commits:
commit a458fdcc0ba7a5cb10f5e5756c784717a4eec2ad
Author: Iván Sánchez Ortega
AuthorDate: Wed Jun 26 14:17:51 2019 +
Commit: Jan Holesovsky
CommitDate: Thu Jan 2 18:18:12 2020 +0100
There must be only one cursor - either in the search or in the document.
Previously clicking into the search input field did not hide the cursor
in the document.
Change-Id: Ia524d39de0825190c51257a3c9a0a4257ca45150
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/83353
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
diff --git a/loleaflet/src/control/Control.Toolbar.js
b/loleaflet/src/control/Control.Toolbar.js
index a854e6cde..f053d2b55 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -95,8 +95,8 @@ function _cancelSearch() {
// odd, but on mobile we need to invoke it twice
toolbar.hide('cancelsearch');
}
- else
- map.focus();
+
+ map._onGotFocus();
}
function onClick(e, id, item, subItem) {
@@ -1185,8 +1185,7 @@ function initNormalToolbar() {
},
onRefresh: function() {
$('#tb_actionbar_item_userlist
.w2ui-tb-caption').addClass('loleaflet-font');
- $('#search-input').off('input',
onSearch).on('input', onSearch);
- $('#search-input').off('keydown',
onSearchKeyDown).on('keydown', onSearchKeyDown);
+ setupSearchInput();
var showInDesktop = map['wopi'].HideUserList
!== null &&
map['wopi'].HideUserList !== undefined &&
@@ -1214,6 +1213,13 @@ function initNormalToolbar() {
});
}
+function setupSearchInput() {
+ $('#search-input').off('input', onSearchInput).on('input',
onSearchInput);
+ $('#search-input').off('keypress', onSearchKeyPress).on('keypress',
onSearchKeyPress);
+ $('#search-input').off('focus', onSearchFocus).on('focus',
onSearchFocus);
+ $('#search-input').off('blur', onSearchBlur).on('blur', onSearchBlur);
+}
+
var userJoinedPopupMessage = '' + _('%user has joined') + '';
var userLeftPopupMessage = '' + _('%user has left') + '';
var userPopupTimeout = null;
@@ -1266,7 +1272,7 @@ function unoCmdToToolbarId(commandname)
return id;
}
-function onSearch() {
+function updateSearchButtons() {
var toolbar = _inMobileMode() ? w2ui['searchbar'] : w2ui['actionbar'];
// conditionally disabling until, we find a solution for tdf#108577
if (L.DomUtil.get('search-input').value === '') {
@@ -1275,15 +1281,21 @@ function onSearch() {
toolbar.hide('cancelsearch');
}
else {
- if (map.getDocType() === 'text')
- map.search(L.DomUtil.get('search-input').value, false,
'', 0, true /* expand search */);
toolbar.enable('searchprev');
toolbar.enable('searchnext');
toolbar.show('cancelsearch');
}
}
-function onSearchKeyDown(e) {
+function onSearchInput() {
+ updateSearchButtons();
+ if (map.getDocType() === 'text') {
+ // perform the immediate search in Writer
+ map.search(L.DomUtil.get('search-input').value, false, '', 0,
true /* expand search */);
+ }
+}
+
+function onSearchKeyPress(e) {
var entry = L.DomUtil.get('search-input');
if ((e.keyCode === 71 && e.ctrlKey) || e.keyCode === 114 || e.keyCode
=== 13) {
if (e.shiftKey) {
@@ -1301,6 +1313,16 @@ function onSearchKeyDown(e) {
}
}
+function onSearchFocus() {
+ // hide the caret in the main document
+ map._onLostFocus();
+ updateSearchButtons();
+}
+
+function onSearchBlur() {
+ map._onGotFocus();
+}
+
function documentNameConfirm() {
var value = $('#document-name-input').val();
if (value !== null && value != '' && value != map['wopi'].BaseFileName)
{
@@ -2609,7 +2631,6 @@ global.insertTable = insertTable;
global.insertShapes = insertShapes;
global.createShapesPanel = createShapesPanel;
global.onUpdatePermission = onUpdatePermission;
-global.onSearch = onSearch;
-global.onSearchKeyDown = onSearchKeyDown;
+global.setupSearchInput = setupSearchInput;
}(window));
diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js
b/loleaflet/src/layer/tile/CalcTileLayer.js
index 1aaae8ad2..f753d1a51 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++
[Libreoffice-bugs] [Bug 129742] Libreoffice Crash on startup in Arch Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=129742 --- Comment #1 from Victor --- Forgot to mention, I am running this on Arch Linux, all packages are up to date as of 2020-01-02 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129742] New: Libreoffice Crash on startup in Arch Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=129742 Bug ID: 129742 Summary: Libreoffice Crash on startup in Arch Linux Product: LibreOffice Version: 6.3.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vm...@victormelo.com Im getting a crash on startup with all Libreoffice apps on both versions 6.3.4 & 6.2.8. If I set the environment variable SAL_USE_VCLPLUGIN to "gen", writer/calc starts up. But as soon as I click on the "View" menu option, it crashes. I've removed my libreoffice config, disabled hardware acceleration, disabled java, yet the problem still persists. I've received the following error: soffice \terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException' Fatal exception: Signal 6 Stack: /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3b474)[0x7ff30a293474] /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3b5fc)[0x7ff30a2935fc] /usr/lib/libc.so.6(+0x3bfb0)[0x7ff309fcdfb0] /usr/lib/libc.so.6(gsignal+0x145)[0x7ff309fcdf25] /usr/lib/libc.so.6(abort+0x12b)[0x7ff309fb7897] /usr/lib/libstdc++.so.6(+0x9681d)[0x7ff309e1781d] /usr/lib/libstdc++.so.6(+0xa34da)[0x7ff309e244da] /usr/lib/libstdc++.so.6(+0xa24aa)[0x7ff309e234aa] /usr/lib/libstdc++.so.6(__gxx_personality_v0+0x2a5)[0x7ff309e23e75] /usr/lib/libgcc_s.so.1(+0x10723)[0x7ff309c2f723] /usr/lib/libgcc_s.so.1(_Unwind_Resume+0x12e)[0x7ff309c3001e] /usr/lib/libreoffice/program/libvcllo.so(+0x2d3284)[0x7ff306a18284] /usr/lib/libreoffice/program/libuno_sal.so.3(+0x16cf2)[0x7ff30a26ecf2] /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3b560)[0x7ff30a293560] /usr/lib/libc.so.6(+0x3bfb0)[0x7ff309fcdfb0] /usr/lib/libc.so.6(gsignal+0x145)[0x7ff309fcdf25] /usr/lib/libc.so.6(abort+0x12b)[0x7ff309fb7897] /usr/lib/libreoffice/program/libvcllo.so(+0x2d13d6)[0x7ff306a163d6] /usr/lib/libreoffice/program/libvclplug_gtk3lo.so(+0x9c2ca)[0x7ff3011ac2ca] /usr/lib/libglib-2.0.so.0(g_main_context_dispatch+0x14f)[0x7ff302e1626f] /usr/lib/libglib-2.0.so.0(+0x6c1b1)[0x7ff302e181b1] /usr/lib/libglib-2.0.so.0(g_main_context_iteration+0x31)[0x7ff302e181f1] /usr/lib/libreoffice/program/libvclplug_gtk3lo.so(+0x9d59d)[0x7ff3011ad59d] /usr/lib/libreoffice/program/libvcllo.so(+0x63e773)[0x7ff306d83773] /usr/lib/libreoffice/program/libvcllo.so(_ZN11Application7ExecuteEv+0x46)[0x7ff306d85626] /usr/lib/libreoffice/program/libsofficeapp.so(+0x32b77)[0x7ff30a1bcb77] /usr/lib/libreoffice/program/libvcllo.so(_Z10ImplSVMainv+0x64)[0x7ff306d8bc34] /usr/lib/libreoffice/program/libsofficeapp.so(soffice_main+0x9b)[0x7ff30a1e304b] /usr/lib/libreoffice/program/soffice.bin(+0x102e)[0x558d559be02e] /usr/lib/libc.so.6(__libc_start_main+0xf3)[0x7ff309fb9153] /usr/lib/libreoffice/program/soffice.bin(+0x106e)[0x558d559be06e] And here is my backtrace: warning: Currently logging to gdbtrace.log. Turn the logging off and on to make the new setting effective. [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/lib/libthread_db.so.1". Dwarf Error: wrong version in compilation unit header (is 0, should be 2, 3, 4 or 5) [in module /usr/lib/libstdc++.so.6] /usr/lib/../share/gcc-9.2.0/python/libstdcxx/v6/xmethods.py:731: SyntaxWarning: list indices must be integers or slices, not str; perhaps you missed a comma? refcounts = ['_M_refcount']['_M_pi'] [Detaching after fork from child process 7040] [New Thread 0x7fffee087700 (LWP 7064)] [New Thread 0x7fffed886700 (LWP 7065)] [New Thread 0x7fffecb89700 (LWP 7066)] [New Thread 0x7fffd700 (LWP 7067)] [New Thread 0x7fffdf7fe700 (LWP 7068)] [New Thread 0x7fffdeffd700 (LWP 7069)] [New Thread 0x7fffc700 (LWP 7070)] [Thread 0x7fffc700 (LWP 7070) exited] [New Thread 0x7fffc700 (LWP 7071)] [Thread 0x7fffc700 (LWP 7071) exited] [New Thread 0x7fffc700 (LWP 7072)] [Thread 0x7fffc700 (LWP 7072) exited] [Detaching after vfork from child process 7073] [New Thread 0x7fffc700 (LWP 7075)] [Thread 0x7fffc700 (LWP 7075) exited] [Thread 0x7fffdf7fe700 (LWP 7068) exited] [Thread 0x7fffee087700 (LWP 7064) exited] [New Thread 0x7fffee087700 (LWP 7076)] warning: the debug information found in "/usr/lib/jvm/java-13-openjdk/lib/server/libjvm.debuginfo" does not match "/usr/lib/jvm/java-13-openjdk/lib/server/libjvm.so" (CRC mismatch). warning: the debug information found in "/usr/lib/jvm/java-13-openjdk/lib/libverify.debuginfo" does not match "/usr/lib/jvm/java-13-openjdk/lib/libverify.so" (CRC mismatch). warning: the debug information found in "/usr/lib/jvm/java-13-openjdk/lib/libjava.debuginfo" does not match "/usr/lib/jvm/java-13-openjdk/lib/libjava.so" (CRC mismatch). warning: the debug information found in "/usr/lib/jvm/java-13-openjdk/lib/libzip.debuginfo" does not match
[Libreoffice-bugs] [Bug 129730] FILESAVE: Tables in writer docx file slightly shifted left outside of the text boundary when opened with MS word
https://bugs.documentfoundation.org/show_bug.cgi?id=129730 --- Comment #3 from Durgapriyanka --- Thank you for reporting the bug. I can reproduce the bug in Version: 6.4.0.0.alpha1+ (x86) Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30 Locale: en-US (en_US); UI-Language: en-US Calc: threaded But, not in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/source
android/source/Makefile | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 27172d6cfb8612d14d11dd8f43843d4b6cfaa0bd Author: Jan Holesovsky AuthorDate: Thu Jan 2 14:58:18 2020 +0100 Commit: Jan Holesovsky CommitDate: Thu Jan 2 18:11:43 2020 +0100 android: Avoid building the apk when configured with --enable-android-lok. Change-Id: I6e82d1c1c00d67f5ff370a7625e33efbb172ca38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86110 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky (cherry picked from commit f4c83939edb9adb9d81a8a442f5449e619df03dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86131 Tested-by: Jenkins diff --git a/android/source/Makefile b/android/source/Makefile index 3fbfcddb0dd3..b64802ec9e78 100644 --- a/android/source/Makefile +++ b/android/source/Makefile @@ -16,10 +16,8 @@ native-code.cxx: $(SRCDIR)/solenv/bin/native-code.py $< -j -g core -g writer -g calc -g draw -g edit > $@ install: - ./gradlew $(if $(verbose),--info) $(if $(versionCode),-PcmdVersionCode=$(versionCode)) install$(if $(DISABLE_UI),StrippedUI,FullUI)$(if $(ENABLE_ANDROID_EDITING),Editing)Debug - @echo - @echo 'Run it with "make run"' - @echo + if test "$$ENABLE_ANDROID_LOK" != "TRUE" ; then ./gradlew $(if $(verbose),--info) $(if $(versionCode),-PcmdVersionCode=$(versionCode)) install$(if $(DISABLE_UI),StrippedUI,FullUI)$(if $(ENABLE_ANDROID_EDITING),Editing)Debug ; fi + @if test "$$ENABLE_ANDROID_LOK" != "TRUE" ; then echo ; echo 'Run it with "make run"' ; echo ; fi uninstall: $(ANDROID_SDK_HOME)/platform-tools/adb uninstall $(ANDROID_PACKAGE_NAME) @@ -30,10 +28,10 @@ clean: rm -f liboSettings.gradle build-gradle: liboSettings.gradle local.properties link-so - ./gradlew $(if $(verbose),--info) $(if $(versionCode),-PcmdVersionCode=$(versionCode)) assemble$(if $(DISABLE_UI),StrippedUI,FullUI)$(if $(ENABLE_ANDROID_EDITING),Editing)$(if $(ENABLE_RELEASE_BUILD),Release,Debug) + if test "$$ENABLE_ANDROID_LOK" != "TRUE" ; then ./gradlew $(if $(verbose),--info) $(if $(versionCode),-PcmdVersionCode=$(versionCode)) assemble$(if $(DISABLE_UI),StrippedUI,FullUI)$(if $(ENABLE_ANDROID_EDITING),Editing)$(if $(ENABLE_RELEASE_BUILD),Release,Debug) ; fi run: - $(ANDROID_SDK_HOME)/platform-tools/adb shell am start -n $(ANDROID_PACKAGE_NAME)/.ui.LibreOfficeUIActivity + if test "$$ENABLE_ANDROID_LOK" != "TRUE" ; then $(ANDROID_SDK_HOME)/platform-tools/adb shell am start -n $(ANDROID_PACKAGE_NAME)/.ui.LibreOfficeUIActivity ; fi debugrun: @echo "please debug with lldb from within Android Studio, or setup ndk-gdb manually (see android/README for details)" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: android/app
android/app/src/main/java/org/libreoffice/androidapp/storage/DocumentProviderSettingsActivity.java
|8
android/app/src/main/res/xml/documentprovider_preferences.xml
|4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 5d1f50c9757be8859a1282b8cd35a83dd8976cc2
Author: Jan Holesovsky
AuthorDate: Thu Jan 2 17:59:23 2020 +0100
Commit: Jan Holesovsky
CommitDate: Thu Jan 2 18:10:31 2020 +0100
android: Disable OTG also in the Provider settings.
Change-Id: Ic1fa98461f27cd849afcd7d56ecd58fc1a96fb10
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86138
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git
a/android/app/src/main/java/org/libreoffice/androidapp/storage/DocumentProviderSettingsActivity.java
b/android/app/src/main/java/org/libreoffice/androidapp/storage/DocumentProviderSettingsActivity.java
index 243198d95..c7c1532b1 100644
---
a/android/app/src/main/java/org/libreoffice/androidapp/storage/DocumentProviderSettingsActivity.java
+++
b/android/app/src/main/java/org/libreoffice/androidapp/storage/DocumentProviderSettingsActivity.java
@@ -68,7 +68,10 @@ public class DocumentProviderSettingsActivity extends
AppCompatActivity {
addPreferencesFromResource(R.xml.documentprovider_preferences);
Preference extSDPreference =
findPreference(KEY_PREF_EXTERNAL_SD_PATH_URI);
+
+/* FIXME fix or remove
Preference otgPreference = findPreference(KEY_PREF_OTG_PATH_URI);
+*/
extSDPreference.setOnPreferenceClickListener(new
Preference.OnPreferenceClickListener() {
@Override
@@ -78,6 +81,8 @@ public class DocumentProviderSettingsActivity extends
AppCompatActivity {
return true;
}
});
+
+/* FIXME fix or remove
otgPreference.setOnPreferenceClickListener(new
Preference.OnPreferenceClickListener() {
@Override
public boolean onPreferenceClick(Preference preference) {
@@ -86,6 +91,7 @@ public class DocumentProviderSettingsActivity extends
AppCompatActivity {
return true;
}
});
+*/
}
private void startBrowserSelectorActivity(String prefKey, String mode)
{
@@ -97,3 +103,5 @@ public class DocumentProviderSettingsActivity extends
AppCompatActivity {
}
}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/android/app/src/main/res/xml/documentprovider_preferences.xml
b/android/app/src/main/res/xml/documentprovider_preferences.xml
index 2c95da294..e4602c561 100644
--- a/android/app/src/main/res/xml/documentprovider_preferences.xml
+++ b/android/app/src/main/res/xml/documentprovider_preferences.xml
@@ -33,11 +33,11 @@
android:key="pref_extsd_path_uri"
android:title="@string/external_sd_path"
app:iconSpaceReserved="false" />
-
+app:iconSpaceReserved="false" /-->
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: android/app
android/app/src/main/java/org/libreoffice/androidapp/storage/external/ExtsdDocumentsProvider.java
| 12 +-
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 1da821c72a354a6a9f63bf6d6cdcf314232bd00c
Author: Jan Holesovsky
AuthorDate: Thu Jan 2 18:04:03 2020 +0100
Commit: Jan Holesovsky
CommitDate: Thu Jan 2 18:09:48 2020 +0100
android: Show the External SD item when the user has set something
explicitly.
Change-Id: I628ba55f1a7fc7115784695c065d23672cefc4a2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86139
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git
a/android/app/src/main/java/org/libreoffice/androidapp/storage/external/ExtsdDocumentsProvider.java
b/android/app/src/main/java/org/libreoffice/androidapp/storage/external/ExtsdDocumentsProvider.java
index c6f481910..e19d5f67e 100644
---
a/android/app/src/main/java/org/libreoffice/androidapp/storage/external/ExtsdDocumentsProvider.java
+++
b/android/app/src/main/java/org/libreoffice/androidapp/storage/external/ExtsdDocumentsProvider.java
@@ -169,16 +169,16 @@ public class ExtsdDocumentsProvider implements
IExternalDocumentProvider,
@Override
public boolean checkProviderAvailability(Context context) {
-// too many devices (or I am just unlucky) don't report the mounted
state properly, and other
-// devices also consider dedicated part of internal storage to be
"mounted" so cannot use
-// getExternalStorageState().equals(Environment.MEDIA_MOUNTED) &&
isExternalStorageRemovable()
-// but they refer to the primary external storage anyway, so what
currently is covered by the
-// "LocalDocumentsProvider"
+SharedPreferences preferences =
PreferenceManager.getDefaultSharedPreferences(context);
+String rootPathURI =
preferences.getString(DocumentProviderSettingsActivity.KEY_PREF_EXTERNAL_SD_PATH_URI,
"");
-return hasRemovableStorage &&
ContextCompat.checkSelfPermission(context,
Manifest.permission.WRITE_EXTERNAL_STORAGE) ==
PackageManager.PERMISSION_GRANTED;
+// either we know we have the storage or the user has set something
explicitly
+return (hasRemovableStorage || !rootPathURI.isEmpty()) &&
ContextCompat.checkSelfPermission(context,
Manifest.permission.WRITE_EXTERNAL_STORAGE) ==
PackageManager.PERMISSION_GRANTED;
}
@Override
public void onSharedPreferenceChanged(SharedPreferences sharedPreferences,
String key) {
}
}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: android/app
android/app/src/main/java/org/libreoffice/androidapp/storage/external/BrowserSelectorActivity.java
| 31 +++---
1 file changed, 23 insertions(+), 8 deletions(-)
New commits:
commit 7aae12a0cc9a6df7da40b04d8c5d36ecf3f6c451
Author: Jan Holesovsky
AuthorDate: Thu Jan 2 17:21:20 2020 +0100
Commit: Jan Holesovsky
CommitDate: Thu Jan 2 18:08:58 2020 +0100
android: Remove some sub-Android-5-specific code.
We don't target anything below Android 5 any more.
Change-Id: Ic6bb8b0fbd64af6a061dba1422cafc144509c67a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86136
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git
a/android/app/src/main/java/org/libreoffice/androidapp/storage/external/BrowserSelectorActivity.java
b/android/app/src/main/java/org/libreoffice/androidapp/storage/external/BrowserSelectorActivity.java
index e992a0860..d4c2e830c 100644
---
a/android/app/src/main/java/org/libreoffice/androidapp/storage/external/BrowserSelectorActivity.java
+++
b/android/app/src/main/java/org/libreoffice/androidapp/storage/external/BrowserSelectorActivity.java
@@ -1,3 +1,12 @@
+/* -*- tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
package org.libreoffice.androidapp.storage.external;
import android.annotation.TargetApi;
@@ -9,6 +18,7 @@ import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.preference.PreferenceManager;
+import android.provider.DocumentsContract;
import android.util.Log;
import org.libreoffice.androidapp.R;
@@ -55,11 +65,7 @@ public class BrowserSelectorActivity extends
AppCompatActivity {
}
private void findSDCard() {
-if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
-useDocumentTreeBrowser();
-} else {
-useInternalBrowser(DocumentProviderFactory.EXTSD_PROVIDER_INDEX);
-}
+useDocumentTreeBrowser(DocumentProviderFactory.EXTSD_PROVIDER_INDEX);
}
private void useInternalBrowser(int providerIndex) {
@@ -67,18 +73,25 @@ public class BrowserSelectorActivity extends
AppCompatActivity {
(IExternalDocumentProvider)
DocumentProviderFactory.getInstance()
.getProvider(providerIndex);
String previousDirectoryPath = preferences.getString(preferenceKey,
provider.guessRootURI(this));
+
Intent i = new Intent(this, DirectoryBrowserActivity.class);
i.putExtra(DirectoryBrowserActivity.DIRECTORY_PATH_EXTRA,
previousDirectoryPath);
startActivityForResult(i, REQUEST_INTERNAL_BROWSER);
}
-@TargetApi(Build.VERSION_CODES.LOLLIPOP)
-private void useDocumentTreeBrowser() {
+private void useDocumentTreeBrowser(int providerIndex) {
+IExternalDocumentProvider provider =
+(IExternalDocumentProvider)
DocumentProviderFactory.getInstance()
+.getProvider(providerIndex);
+String previousDirectoryPath = preferences.getString(preferenceKey,
provider.guessRootURI(this));
+
Intent i = new Intent(Intent.ACTION_OPEN_DOCUMENT_TREE);
+i.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
+i.addFlags(Intent.FLAG_GRANT_WRITE_URI_PERMISSION);
+i.putExtra(DocumentsContract.EXTRA_INITIAL_URI, previousDirectoryPath);
startActivityForResult(i, REQUEST_DOCUMENT_TREE);
}
-@TargetApi(Build.VERSION_CODES.LOLLIPOP)
@Override
protected void onActivityResult(int requestCode, int resultCode, Intent
data) {
//listeners are registered here as onActivityResult is called before
onResume
@@ -152,3 +165,5 @@ public class BrowserSelectorActivity extends
AppCompatActivity {
}
}
}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
