date:20200125

[Libreoffice-commits] core.git: bridges/source connectivity/source dbaccess/source embeddedobj/source filter/source io/source oox/source package/source sax/source sc/source sdext/source sd/source sfx2

2020-01-25 Thread Noel Grandin (via logerrit)

 bridges/source/jni_uno/jni_data.cxx|1 -
 connectivity/source/drivers/flat/ETable.cxx|1 -
 dbaccess/source/ui/misc/UITools.cxx|1 -
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx  |1 -
 embeddedobj/source/msole/olevisual.cxx |3 +--
 filter/source/config/cache/filterfactory.cxx   |2 --
 io/source/stm/omark.cxx|4 
 oox/source/export/shapes.cxx   |1 -
 oox/source/shape/ShapeContextHandler.cxx   |2 --
 package/source/manifest/ManifestImport.cxx |1 -
 sax/source/expatwrap/sax_expat.cxx |1 -
 sc/source/core/data/documen5.cxx   |1 -
 sc/source/filter/excel/excrecds.cxx|1 -
 sc/source/filter/excel/xeformula.cxx   |1 -
 sc/source/ui/view/dbfunc.cxx   |1 -
 sd/source/filter/html/htmlattr.cxx |2 --
 sd/source/filter/xml/sdxmlwrp.cxx  |1 -
 sd/source/ui/animations/SlideTransitionPane.cxx|1 -
 sd/source/ui/dlg/PhotoAlbumDialog.cxx  |1 -
 sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx |1 -
 sdext/source/presenter/PresenterNotesView.cxx  |9 -
 sdext/source/presenter/PresenterToolBar.cxx|1 -
 sfx2/source/dialog/versdlg.cxx |1 -
 sfx2/source/doc/doctemplates.cxx   |2 +-
 slideshow/source/engine/opengl/TransitionImpl.cxx  |2 +-
 slideshow/source/engine/slide/shapemanagerimpl.cxx |1 -
 svx/source/dialog/imapwnd.cxx  |2 --
 svx/source/dialog/rubydialog.cxx   |1 -
 svx/source/form/formcontroller.cxx |1 -
 svx/source/gallery2/galtheme.cxx   |1 -
 svx/source/gengal/gengal.cxx   |2 --
 svx/source/svdraw/svdoashp.cxx |1 -
 sw/source/core/access/accmap.cxx   |5 +
 sw/source/core/undo/unins.cxx  |2 --
 sw/source/filter/ww8/WW8TableInfo.cxx  |2 --
 sw/source/filter/xml/wrtxml.cxx|1 -
 ucb/source/ucp/cmis/cmis_content.cxx   |3 +--
 ucb/source/ucp/webdav-neon/webdavcontent.cxx   |1 -
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx|2 --
 vcl/source/gdi/gdimtf.cxx  |3 ---
 vcl/source/gdi/salmisc.cxx |1 -
 vcl/source/treelist/iconviewimpl.cxx   |2 --
 vcl/source/window/brdwin.cxx   |1 -
 vcl/unx/generic/gdi/gdiimpl.cxx|   10 --
 44 files changed, 5 insertions(+), 80 deletions(-)

New commits:
commit 51b5b93092d6231615de470c62494c24e54828a1
Author: Noel Grandin 
AuthorDate: Sat Jan 25 17:49:47 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 26 08:01:42 2020 +0100

remove some unused local vars

found by a more aggressive variant of loplugin:unusedvariables.

This is my first pass, committing the simplest and most obviously
unnecessary vars

Change-Id: I9676a6e39a101937097788548764506c93811c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/bridges/source/jni_uno/jni_data.cxx 
b/bridges/source/jni_uno/jni_data.cxx
index daff48a48492..06e8467f7e7c 100644
--- a/bridges/source/jni_uno/jni_data.cxx
+++ b/bridges/source/jni_uno/jni_data.cxx
@@ -2339,7 +2339,6 @@ void Bridge::map_to_java(
 
 if (0 < nElements)
 {
-TypeDescr element_td( element_type );
 uno_Sequence * const * elements = 
reinterpret_cast(seq->elements);
 for ( sal_Int32 nPos = 0; nPos < nElements; ++nPos )
 {
diff --git a/connectivity/source/drivers/flat/ETable.cxx 
b/connectivity/source/drivers/flat/ETable.cxx
index 2da5d6ab8570..142d191be8c9 100644
--- a/connectivity/source/drivers/flat/ETable.cxx
+++ b/connectivity/source/drivers/flat/ETable.cxx
@@ -82,7 +82,6 @@ void OFlatTable::fillColumns(const css::lang::Locale& 
_aLocale)
 setRowPos(rowNum++, rowPos);
 
 // read first row
-QuotedTokenizedString aFirstLine;
 if(bRead)
 {
 bRead = readLine(, );
diff --git a/dbaccess/source/ui/misc/UITools.cxx 
b/dbaccess/source/ui/misc/UITools.cxx
index 257a10f3b8c0..0522d4ab834e 100644
--- a/dbaccess/source/ui/misc/UITools.cxx
+++ b/dbaccess/source/ui/misc/UITools.cxx
@@ -145,7 +145,6 @@ SQLExceptionInfo createConnection(  const OUString& 
_rsDataSourceName,
 catch(const Exception&)
 {
 }
-SQLExceptionInfo aInfo;
 
 return

[Libreoffice-commits] core.git: accessibility/source basic/source chart2/source dbaccess/source filter/source framework/source package/source sc/source sd/source sfx2/source svtools/source svx/source

2020-01-25 Thread Noel Grandin (via logerrit)

 accessibility/source/standard/vclxaccessiblelist.cxx|2 +-
 accessibility/source/standard/vclxaccessibletoolbox.cxx |2 +-
 basic/source/classes/sb.cxx |2 +-
 basic/source/classes/sbxmod.cxx |2 +-
 basic/source/runtime/runtime.cxx|4 ++--
 basic/source/sbx/sbxbase.cxx|4 ++--
 chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx |2 +-
 dbaccess/source/core/dataaccess/documentdefinition.cxx  |4 ++--
 filter/source/svg/svgexport.cxx |8 
 filter/source/xsltdialog/xmlfilterdialogcomponent.cxx   |2 +-
 framework/source/uielement/menubarmanager.cxx   |2 +-
 framework/source/uielement/toolbarmanager.cxx   |2 +-
 package/source/xstor/ohierarchyholder.cxx   |4 ++--
 sc/source/core/data/documen8.cxx|2 +-
 sc/source/core/tool/addinlis.cxx|2 +-
 sc/source/ui/Accessibility/AccessibleContextBase.cxx|4 ++--
 sc/source/ui/unoobj/cellsuno.cxx|2 +-
 sc/source/ui/unoobj/chart2uno.cxx   |2 +-
 sc/source/ui/unoobj/dapiuno.cxx |2 +-
 sd/source/filter/eppt/pptexsoundcollection.cxx  |2 +-
 sd/source/ui/slideshow/slideshowimpl.cxx|4 ++--
 sd/source/ui/slideshow/slideshowviewimpl.cxx|2 +-
 sd/source/ui/view/viewshel.cxx  |8 
 sfx2/source/appl/linksrc.cxx|2 +-
 sfx2/source/control/statcach.cxx|2 +-
 sfx2/source/doc/objxtor.cxx |2 +-
 sfx2/source/doc/sfxbasemodel.cxx|4 ++--
 sfx2/source/view/sfxbasecontroller.cxx  |2 +-
 svtools/source/uno/miscservices.cxx |2 +-
 svx/source/accessibility/ChildrenManagerImpl.cxx|2 +-
 svx/source/sdr/overlay/overlaymanagerbuffered.cxx   |2 +-
 sw/source/core/ole/ndole.cxx|4 ++--
 sw/source/core/view/printdata.cxx   |2 +-
 sw/source/filter/html/swhtml.cxx|4 ++--
 sw/source/uibase/uno/unotxdoc.cxx   |2 +-
 toolkit/source/awt/vclxaccessiblecomponent.cxx  |2 +-
 vcl/source/control/ivctrl.cxx   |2 +-
 vcl/source/treelist/treelistbox.cxx |2 +-
 vcl/source/window/dndeventdispatcher.cxx|2 +-
 vcl/source/window/menu.cxx  |2 +-
 vcl/unx/generic/dtrans/X11_clipboard.cxx|2 +-
 41 files changed, 56 insertions(+), 56 deletions(-)

New commits:
commit b9fe4f26eaf1099b8d0907b8d9cbf52c86914466
Author: Noel Grandin 
AuthorDate: Sat Jan 25 15:05:53 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 26 08:01:13 2020 +0100

rename some local variables

mostly to make the job of my very aggressive unused local vars plugin
easier

Change-Id: Ifc21a920841f8589f8b7e10de39dba6622a5d501
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87399
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/accessibility/source/standard/vclxaccessiblelist.cxx 
b/accessibility/source/standard/vclxaccessiblelist.cxx
index deb5ca1c723f..2077fcdf874b 100644
--- a/accessibility/source/standard/vclxaccessiblelist.cxx
+++ b/accessibility/source/standard/vclxaccessiblelist.cxx
@@ -347,7 +347,7 @@ void VCLXAccessibleList::ProcessWindowEvent (const 
VclWindowEvent& rVclWindowEve
 {
 // Create a reference to this object to prevent an early release of the
 // listbox (VclEventId::ObjectDying).
-Reference< XAccessible > xTemp = this;
+Reference< XAccessible > xHoldAlive = this;
 
 switch ( rVclWindowEvent.GetId() )
 {
diff --git a/accessibility/source/standard/vclxaccessibletoolbox.cxx 
b/accessibility/source/standard/vclxaccessibletoolbox.cxx
index 1508cf0b5184..c456b93997b4 100644
--- a/accessibility/source/standard/vclxaccessibletoolbox.cxx
+++ b/accessibility/source/standard/vclxaccessibletoolbox.cxx
@@ -495,7 +495,7 @@ void VCLXAccessibleToolBox::FillAccessibleStateSet( 
utl::AccessibleStateSetHelpe
 void VCLXAccessibleToolBox::ProcessWindowEvent( const VclWindowEvent& 
rVclWindowEvent )
 {
 // to prevent an early release of the toolbox (VclEventId::ObjectDying)
-Reference< XAccessibleContext > xTemp = this;
+Reference< XAccessibleContext > xHoldAlive = this;
 
 switch ( rVclWindowEvent.GetId() )
 {
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index 310bc293dfdb..12f2e2bea8c2 100644
---

[Libreoffice-commits] core.git: comphelper/source cppuhelper/source

2020-01-25 Thread Noel Grandin (via logerrit)

 comphelper/source/container/interfacecontainer2.cxx |   13 ++---
 cppuhelper/source/interfacecontainer.cxx|   13 ++---
 2 files changed, 12 insertions(+), 14 deletions(-)

New commits:
commit de60c73db31ec34ffb2e008829083bb7ddcb3061
Author: Noel Grandin 
AuthorDate: Sat Jan 25 17:41:43 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 26 08:00:59 2020 +0100

simplify InterfaceContainerHelper::clear

instead of relying on side-effects from instantiating an iterator

Change-Id: Ie66b9e7ceeb3c4a0f4243fdd0a5ac37af77e98ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87412
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/container/interfacecontainer2.cxx 
b/comphelper/source/container/interfacecontainer2.cxx
index 36141f7a7e19..1524600affd0 100644
--- a/comphelper/source/container/interfacecontainer2.cxx
+++ b/comphelper/source/container/interfacecontainer2.cxx
@@ -271,18 +271,17 @@ void OInterfaceContainerHelper2::disposeAndClear( const 
EventObject & rEvt )
 
 void OInterfaceContainerHelper2::clear()
 {
-ClearableMutexGuard aGuard( rMutex );
-OInterfaceIteratorHelper2 aIt( *this );
+MutexGuard aGuard( rMutex );
 // Release container, in case new entries come while disposing
 OSL_ENSURE( !bIsList || bInUse, "OInterfaceContainerHelper2 not in use" );
-if( !bIsList && aData.pAsInterface )
+if (bInUse)
+copyAndResetInUse();
+if (bIsList)
+delete aData.pAsVector;
+else if (aData.pAsInterface)
 aData.pAsInterface->release();
-// set the member to null, use the iterator to delete the values
 aData.pAsInterface = nullptr;
 bIsList = false;
-bInUse = false;
-// release mutex before aIt destructor call
-aGuard.clear();
 }
 
 
diff --git a/cppuhelper/source/interfacecontainer.cxx 
b/cppuhelper/source/interfacecontainer.cxx
index 38cca295755b..035f93848bf2 100644
--- a/cppuhelper/source/interfacecontainer.cxx
+++ b/cppuhelper/source/interfacecontainer.cxx
@@ -281,18 +281,17 @@ void OInterfaceContainerHelper::disposeAndClear( const 
EventObject & rEvt )
 
 void OInterfaceContainerHelper::clear()
 {
-ClearableMutexGuard aGuard( rMutex );
-OInterfaceIteratorHelper aIt( *this );
+MutexGuard aGuard( rMutex );
 // Release container, in case new entries come while disposing
 OSL_ENSURE( !bIsList || bInUse, "OInterfaceContainerHelper not in use" );
-if( !bIsList && aData.pAsInterface )
+if (bInUse)
+copyAndResetInUse();
+if (bIsList)
+delete aData.pAsVector;
+else if (aData.pAsInterface)
 aData.pAsInterface->release();
-// set the member to null, use the iterator to delete the values
 aData.pAsInterface = nullptr;
 bIsList = false;
-bInUse = false;
-// release mutex before aIt destructor call
-aGuard.clear();
 }
 
 // specialized class for type
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||107738

--- Comment #2 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #1)
> Isn't
> that enough?

I would say it is enough to find a hidden section, but not enough to prevent
from unwanted delete. So I would narrow down this enhancement to a warning
message, when you try to delete a hidden section. Comment would only help, if
comments are displayed in your actual view.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107738
[Bug 107738] [META] Section bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107738] [META] Section bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107738

Dieter Praas  changed:

   What|Removed |Added

 Depends on||130199


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130199
[Bug 130199] Add some indicator for mark place of hidden section in document
like comment or something
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||107738

--- Comment #2 from Dieter Praas  ---
(In reply to V Stuart Foote from comment #1)
> Isn't
> that enough?

I would say it is enough to find a hidden section, but not enough to prevent
from unwanted delete. So I would narrow down this enhancement to a warning
message, when you try to delete a hidden section. Comment would only help, if
comments are displayed in your actual view.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107738
[Bug 107738] [META] Section bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 130195] Change text spacing crashes LO

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130195

--- Comment #3 from Dieter Praas  ---
Axel, could you please also add link to the crash report? Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130195] Change text spacing crashes LO

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130195

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
Axel, thank you for reporting the bug. Please specify the first step, because
AFAIK there is no header in an impress file. What I did:
1. I opened atachment from comment 1
2. ctrl+A
3. ctrl+C
4. I opened a new document in writer and put cursor into header
5. ctrl+V
6. There is not text field, but an image and it looks the same as in impress

Tested with

Version: 6.5.0.0.alpha0+ (x64)
Build ID: 350d25da375f221edfa37309324ce3c68cf297ef
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

and with

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

So please provide a clearer set of step-by-step instructions on how to
reproduce the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130200] Writer crashes on inserting a subdocument to a master document using the “enter” key.

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130200

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8544
 CC||dgp-m...@gmx.de
 Blocks||107805

--- Comment #1 from Dieter Praas  ---
Thomas, thank you for reporting the crash. I can't reproduce it with

Version: 6.3.4.2 (x64)
Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

It might be related to bug 128544. Could you please try to reproduce it again
and add the link to the crash report? Thank you.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107805
[Bug 107805] [META] Writer master document issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107805] [META] Writer master document issues

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107805

Dieter Praas  changed:

   What|Removed |Added

 Depends on||130200


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130200
[Bug 130200] Writer crashes on inserting a subdocument to a master document
using the “enter” key.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128544] MASTER DOCUMENT: Crash in fps_officelo.dll

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128544

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0200

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 5 commits - cypress_test/data cypress_test/integration_tests

2020-01-25 Thread Tamás Zolnai (via logerrit)

 cypress_test/data/desktop/empty.odt  |binary
 cypress_test/data/mobile/empty.odt   |binary
 cypress_test/integration_tests/common/helper.js  |   25 
 cypress_test/integration_tests/desktop/copy_paste_spec.js|   35 +
 cypress_test/integration_tests/desktop/example_desktop_test_spec.js  |   20 
 cypress_test/integration_tests/desktop/example_desktop_test_spec2.js |   41 -
 cypress_test/integration_tests/desktop/shape_operations_spec.js  |   30 +
 cypress_test/integration_tests/mobile/focus_spec.js  |   21 
 cypress_test/integration_tests/mobile/insert_object_spec.js  |  265 
++
 cypress_test/integration_tests/mobile/mobile_wizard_state_spec.js|   21 
 cypress_test/integration_tests/mobile/toolbar_spec.js|   21 
 11 files changed, 371 insertions(+), 108 deletions(-)

New commits:
commit 38d2bd876837c293e81b7e383c30421798559b01
Author: Tamás Zolnai 
AuthorDate: Sun Jan 26 06:33:14 2020 +0100
Commit: Tamás Zolnai 
CommitDate: Sun Jan 26 06:42:53 2020 +0100

cypress: mobile: Basic tests of insertion mobile wizard.

Change-Id: I2c2b2406ae390856c001dff1b4827586a40e05be

diff --git a/cypress_test/integration_tests/mobile/insert_object_spec.js 
b/cypress_test/integration_tests/mobile/insert_object_spec.js
new file mode 100644
index 0..ef551323e
--- /dev/null
+++ b/cypress_test/integration_tests/mobile/insert_object_spec.js
@@ -0,0 +1,265 @@
+/* global describe it cy beforeEach require expect afterEach*/
+
+var helper = require('../common/helper');
+
+describe('Insert objects via insertion wizard.', function() {
+   beforeEach(function() {
+   helper.loadTestDoc('empty.odt', true);
+
+   // Click on edit button
+   cy.get('#mobile-edit-button').click();
+
+   // Open insertion wizard
+   cy.get('#tb_actionbar_item_insertion_mobile_wizard')
+   .should('not.have.class', 'disabled')
+   .click();
+   });
+
+   afterEach(function() {
+   cy.get('.closemobile').click();
+   cy.wait(200); // wait some time to actually release the document
+   });
+
+   it('Insert local image.', function() {
+   // We check whether the entry is there
+   cy.get('.menu-entry-with-icon')
+   .contains('Local Image...');
+   // We not not test the insertion, it might depend on the system.
+   });
+
+   it('Insert comment.', function() {
+   cy.get('.menu-entry-with-icon')
+   .contains('Comment')
+   .click();
+
+   // Comment insertion dialog is opened
+   cy.get('.loleaflet-annotation-table')
+   .should('exist');
+
+   // Push cancel to close the dialog
+   
cy.get('.vex-dialog-button-secondary.vex-dialog-button.vex-last')
+   .click();
+   // TODO: fix console error here
+   });
+
+   it('Insert table.', function() {
+   // Open Table submenu
+   cy.get('.sub-menu-title')
+   .contains('Table')
+   .click();
+   cy.get('.mobile-wizard.ui-text')
+   .should('be.visible');
+
+   // Scroll to the bottom
+   cy.get('#mobile-wizard-content').scrollTo(0, 1000);
+
+   // Push insert table button
+   cy.get('.inserttablecontrols button')
+   .should('be.visible')
+   .click();
+
+   // Table is inserted with the markers shown
+   cy.get('.leaflet-marker-icon.table-column-resize-marker')
+   .should('exist')
+   .should('have.length', 3);
+   cy.get('.leaflet-marker-icon.table-row-resize-marker')
+   .should('exist')
+   .should('have.length', 2);
+   });
+
+   it('Insert field.', function() {
+   // Open fields submenu
+   cy.get('.sub-menu-title')
+   .contains('More Fields...')
+   .click();
+   cy.get('.menu-entry-with-icon')
+   .contains('Page Number')
+   .click();
+
+   // Do a selection to see something is inserted
+   cy.get('body').type('{shift}{leftarrow}');
+   cy.get('.leaflet-marker-icon')
+   .should('exist')
+   .should('have.length', 2);
+   });
+
+   it('Insert header.', function() {
+   // Get the blinking cursor pos
+   cy.get('#document-container').type('');
+   var cursorOrigLeft = 0;
+   cy.get('.blinking-cursor')
+

[Libreoffice-bugs] [Bug 130201] Calc alignment sidebar remove text orientation option

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130201

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
And what about CJK, or CTL with script that commonly use vertical TBLR, TBRL,
or BTRL layout? Support for mixed use to support that in the Sidebar is
fundamental, removal is very western centric.

Its fine the way it is, IMHO => INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
The hidden section shows in the Navigator, and a click on the section, or 
navigate by 'Section' will position to start of the hidden section. Isn't that
enough?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
The hidden section shows in the Navigator, and a click on the section, or 
navigate by 'Section' will position to start of the hidden section. Isn't that
enough?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 130196] Changing nav-order in navigator does not work on single page

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130196

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
Confirmed with STR on
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 07b1159b79135857dd9a450c3bb9ae0a944ebcf9
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126150] Bug submission is not working

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126150

--- Comment #3 from QA Administrators  ---
Dear Warren L. Berardi,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129937] Control+s fails to save a file when the cursor is in the find bar

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129937

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129939] Mouse scroll disabled after switching virtual desktop

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129939

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81916] Other: Language Pack installer is not signed

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81916

--- Comment #6 from QA Administrators  ---
Dear Yuri Per,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116688] Crash in: BigPtrArray::Index2Block(unsigned __int64) when disabling Mendeley extension

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116688

--- Comment #16 from QA Administrators  ---
Dear Clemens Prill,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126150] Bug submission is not working

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126150

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100995] Toolbar icons display incorrect zoom factor and pixellation on OSX Sierra HiDPI

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100995

--- Comment #19 from QA Administrators  ---
Dear Gerald,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

CppCheck Report Update

2020-01-25 Thread cppcheck.libreoff...@gmail.com



A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2020-26-01 03:45:25 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107248] Improvements to the version control dialog

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107248

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected
 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
(In reply to Yousuf Philips (jay) (retired) from comment #0)
> 1. The dialog title used to begin with the string 'Versions of ' before the
> filename, but this strangely went missing in 4.2. @Xisco, @Bouvjaga: Can you
> bibisect this?

(In reply to Terrence Enger from comment #2)
> I am setting keyword bibisected.  However, I think it more likely that
> I have a problem in my environment than that Writer really was broken
> for four days, so I am leaving keyword bibisectRequest.
It's not just your environment. However, it must be the last commit in that
range, there's a case of "Versions of" that was deleted, but not added
elsewhere:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=52bce8fadde39e32c0008babadc2c22cc501f753
author  Caolán McNamara 2013-07-16 09:12:42
+0100
committer   Caolán McNamara 2013-07-16 12:45:56
+0100

convert versions of dialog to .ui

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122600] UI: Creating a new style, doesn't automatically show tab Organize in style dialog

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=122600

Aron Budea  changed:

   What|Removed |Added

Version|5.0.6.3 release |4.4.0.3 release
   Keywords|bibisectRequest |bibisected, bisected
   Hardware|x86-64 (AMD64)  |All
 CC||ba...@caesar.elte.hu,
   ||caol...@redhat.com

--- Comment #3 from Aron Budea  ---
Bibisected to the following commit using repo bibisect-44max. Adding CC: to
Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e904562af54545684b32d2042ded6bdb9459edca
author  Caolán McNamara 2014-07-24 11:55:46
+0100
committer   Caolán McNamara 2014-07-24 12:46:57
+0100

Related: fdo#81641 create new styles with an initial name

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103987] FILESAVE: DOCX File corrupted after roundtrip

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103987

Aron Budea  changed:

   What|Removed |Added

 Blocks||80997


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80997
[Bug 80997] FILESAVE: RT Text is missing around textbox because textbox has a
wrap property
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80997] FILESAVE: RT Text is missing around textbox because textbox has a wrap property

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80997

Aron Budea  changed:

   What|Removed |Added

 Depends on||103987
 CC||ba...@caesar.elte.hu
   Keywords|bibisectRequest, regression |
Summary|FILESAVE: MSO says file is  |FILESAVE: RT Text is
   |damaged after roundtrip of  |missing around textbox
   |DOCX (with textbox that has |because textbox has a wrap
   |a wrap property)|property

--- Comment #7 from Aron Budea  ---
The corruption is reported in bug 103987, thus I am adding that bug as
dependency.

For the record I didn't see missing text in Word 2013 when roundtripped the
document with the 4.4 build preceding the regression in bug 103987.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103987
[Bug 103987] FILESAVE: DOCX File corrupted after roundtrip
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130201] Calc alignment sidebar remove text orientation option

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130201

--- Comment #1 from andreas_k  ---
Created attachment 157430
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157430=edit
without Text Orientation options

I prefer an simple sidebar with the main options. Vertically stacked is still
in the sidebar cause it can be useful for table headers (but can be also
removed if wanted)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130201] New: Calc alignment sidebar remove text orientation option

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130201

Bug ID: 130201
   Summary: Calc alignment sidebar remove text orientation option
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

Created attachment 157429
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157429=edit
Text Orientation needed?

I don't see an big advantage of have Text Orientation options in the sidebar.
There is an dialog for it.

In addition if you use text orientation the Text move out of the cell so from
my point of view it's a bit broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130201] Calc alignment sidebar remove text orientation option

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130201

andreas_k  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||kain...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130102] default sidebar width

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130102

--- Comment #12 from andreas_k  ---
As now the sidebar width is the MINIMUM of the first visual UI elements.

I don't think that an MINIMUM is the best decision for the default, would it be
possible to use MINIMUM + 20% as default.

Optimum = Minimum * 1,20

That would solve a lot of issues if other translation stuff is a bit longer
than the default widgets.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 130102] default sidebar width

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130102

--- Comment #12 from andreas_k  ---
As now the sidebar width is the MINIMUM of the first visual UI elements.

I don't think that an MINIMUM is the best decision for the default, would it be
possible to use MINIMUM + 20% as default.

Optimum = Minimum * 1,20

That would solve a lot of issues if other translation stuff is a bit longer
than the default widgets.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107585] [META] Microsoft Office binary, text and xml file formats

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107585

Aron Budea  changed:

   What|Removed |Added

 Depends on||104442


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Aron Budea  changed:

   What|Removed |Added

 Depends on|104442  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104442

Aron Budea  changed:

   What|Removed |Added

Summary|[META] DOCX (OOXML) shape   |[META] OOXML shape
   |(DrawingML and VML) related |(DrawingML and VML) related
   |issues  |issues
 Blocks|104520  |107585
  Component|Writer  |LibreOffice

--- Comment #3 from Aron Budea  ---
Adjusting META bug to reflect that it's a general OOXML shape tracker, not
specific to DOCX.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=107585
[Bug 107585] [META] Microsoft Office binary, text and xml file formats
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Aron Budea  changed:

   What|Removed |Added

 Depends on||130058


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130058
[Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as
extraneous line below
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104468

Aron Budea  changed:

   What|Removed |Added

 Depends on|130058  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130058
[Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as
extraneous line below
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104238] [META] Impress image bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104238

Aron Budea  changed:

   What|Removed |Added

 Depends on||130058


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130058
[Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as
extraneous line below
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as extraneous line below

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130058

Aron Budea  changed:

   What|Removed |Added

 Blocks|104468  |104238, 108226


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104238
[Bug 104238] [META] Impress image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=104468
[Bug 104468] [META] DOCX (OOXML) image-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as extraneous line below

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130058

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||104468


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104468
[Bug 104468] [META] DOCX (OOXML) image-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104468

Aron Budea  changed:

   What|Removed |Added

 Depends on||130058


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130058
[Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as
extraneous line below
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130058] FILEOPEN PPTX: image shadow that should be invisible shown as extraneous line below

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130058

Aron Budea  changed:

   What|Removed |Added

Version|5.2 all versions|4.0.0.3 release
   Keywords|bibisectRequest, regression |implementationError
Summary|FILEOPEN PPTX: extraneous   |FILEOPEN PPTX: image shadow
   |line below an image |that should be invisible
   ||shown as extraneous line
   ||below

--- Comment #5 from Aron Budea  ---
The line is a shadow on the image, in PowerPoint it can't be seen (probably
because it's configured that way), but in Impress it's shown.

The change could be bisected to the following using repo bibisect-43all (it was
already buggy in oldest commit of bibisect-41max):
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=9351d0e4181924c3f72be24081fc7af027aa41f7..fba5febdf60b37be69d2ffc66445d3e324826346

Found two commits in the range that deal with import of shadows on objects:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f0efecfb69b336e064e7c8dd2597655eff07944f
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e1a509f4a362d21248b439c99e3b55f4fa9ba1bd

All in all, it seems like an implementation error rather than a regression,
it's just previously the shadow wasn't imported at all (when making the shadow
visible in PP, it still can't be seen when imported in an older LO version).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130058] FILEOPEN PPTX: extraneous line below an image

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130058

Aron Budea  changed:

   What|Removed |Added

 Attachment #157228|application/vnd.ms-powerpoi |application/vnd.openxmlform
  mime type|nt  |ats-officedocument.presenta
   ||tionml.presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129221] Numbered bullets don't restart after header in importred .docx file

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129221

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=78
   ||939
   Keywords|bibisectRequest |bibisected, bisected,
   ||filter:docx
 CC||ba...@caesar.elte.hu,
   ||vmik...@collabora.com

--- Comment #13 from Aron Budea  ---
This went bad in to steps, bibisected using repo bibisect-44max.
First the numbering stopped getting imported with following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e49d2b31fb2020d065b4ad940d1031d07b10f32b
author  Vinaya Mandke   2014-06-06
14:12:48 +0530
committer   Miklos Vajna   2014-06-10 09:57:45
+0200

"fdo#78939 [DOCX] Hang while opening due to incorrect modification of Style"

Then the numbering came back, but didn't restart anymore:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c03b691a7cd8eba128204c851b99e0b75c580c0c
author  Miklos Vajna   2014-11-17 16:54:12
+0100
committer   Miklos Vajna   2014-11-17 16:55:12
+0100

"DOCX import: handle  from parent styles as well"

Adding CC: to Miklos Vajna.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126389] "New" in macro editing dialog does not create a new macro

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126389

--- Comment #8 from Konstantin Kharlamov  ---
(In reply to Regina Henschel from comment #7)
> (In reply to Konstantin Kharlamov from comment #0)
> > # Steps to reproduce
> > 
> > 1. Open `lowriter` or `localc` (reproducible in either)
> > 2. Go to Tools → Macros → Edit Macros
> > 3. Now, a macros editing window should appear. There, click the button that
> > says "New" on it.
> > 
> > ## Expected
> > 
> > A new empty macro should get created (probably should ask first about the
> > language a user wants to use)
> 
> That is the general tool for new documents. That exists in all modules. You
> see it too in the Math-Editor and in the Chart-Editor. It behaves the same
> in all places. Simple click uses the current preselected kind of action, for
> other actions open the list by clicking on the triangle and select the
> action.

If opening a new lowriter/localc window is an intended behavior of this button,
then IMO it's better to remove it whatsoever. A user can open a new LO instance
for example by clicking File → New inside already opened lowriter/local window.
Having this button in IDE (and probably in math-editor and chart-editor) only
creates a confusion. I don't know what chart-editor looks like, but from the
hearing of that I see no reason why I would expect a "New" button not to create
a new chart but rather to create an LO instance.

Suppose you clicked "New" button inside localc. Do you expect it to open an
lowriter instance or localc? If the latter, then this is because buttons inside
any given program window should match the functional that this window is
intended to provide. I see no reason why it should hold for localc but not for
macros-editor or chart-editor.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129150] Menu: Format - Page

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129150

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #7 from Regina Henschel  ---
Impress and Draw have a separate menu for all things, which belong to sides or
pages, respectively.

That was introduced with bug 91857.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx officecfg/registry sc/source sd/source svtools/source svx/source svx/util sw/source

2020-01-25 Thread Caolán McNamara (via logerrit)

 include/svx/verttexttbxctrl.hxx |   38 ++-
 officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu |   88 +++
 sc/source/ui/app/scdll.cxx  |7 
 sd/source/ui/app/sddll.cxx  |8 
 svtools/source/uno/popupwindowcontroller.cxx|   11 
 svx/source/tbxctrls/verttexttbxctrl.cxx |  120 
+++---
 svx/util/svx.component  |8 
 sw/source/uibase/app/swmodule.cxx   |7 
 8 files changed, 213 insertions(+), 74 deletions(-)

New commits:
commit eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b
Author: Caolán McNamara 
AuthorDate: Sat Jan 25 20:04:13 2020 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 25 22:44:57 2020 +0100

Resolves: tdf#130159 hide writedirection unless CTL is enabled

rework as ToolboxControllers registered in Controller.xcu

Change-Id: I3e7fea09fe83d1ed6400218c41384f82b38b07a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87419
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/svx/verttexttbxctrl.hxx b/include/svx/verttexttbxctrl.hxx
index 157a1f85def9..12498068c467 100644
--- a/include/svx/verttexttbxctrl.hxx
+++ b/include/svx/verttexttbxctrl.hxx
@@ -19,37 +19,53 @@
 #ifndef INCLUDED_SVX_VERTTEXTTBXCTRL_HXX
 #define INCLUDED_SVX_VERTTEXTTBXCTRL_HXX
 
-#include 
+#include 
+
+#include 
+#include 
+
 #include 
 
+//HACK to avoid duplicate ImplInheritanceHelper symbols with MSVC:
+class SAL_DLLPUBLIC_TEMPLATE SvxVertCTLTextTbxCtrl_Base:
+public cppu::ImplInheritanceHelper
+{
+using ImplInheritanceHelper::ImplInheritanceHelper;
+};
+
 /*
   control to remove/insert cjk settings dependent vertical text toolbox item
  */
-class SvxVertCTLTextTbxCtrl : public SfxToolBoxControl
+class SvxVertCTLTextTbxCtrl : public SvxVertCTLTextTbxCtrl_Base
 {
 public:
-SvxVertCTLTextTbxCtrl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
+explicit SvxVertCTLTextTbxCtrl(const 
css::uno::Reference& rContext);
+
 virtual ~SvxVertCTLTextTbxCtrl() override;
 
-// XInitialization
-virtual void SAL_CALL initialize(const css::uno::Sequence& 
rArguments) override;
+// XServiceInfo
+virtual OUString SAL_CALL getImplementationName() override = 0;
+virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) 
override;
+virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() 
override;
 
-virtual voidStateChanged( sal_uInt16 nSID, SfxItemState 
eState,
-  const SfxPoolItem* pState ) 
override;
+// XStatusListener
+virtual void SAL_CALL statusChanged(const css::frame::FeatureStateEvent& 
rEvent) override;
 };
 
 class SVX_DLLPUBLIC SvxCTLTextTbxCtrl final : public SvxVertCTLTextTbxCtrl
 {
 public:
-SFX_DECL_TOOLBOX_CONTROL();
-SvxCTLTextTbxCtrl(sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
+SvxCTLTextTbxCtrl(const css::uno::Reference& 
rContext);
+
+virtual OUString SAL_CALL getImplementationName() override;
 };
 
 class SVX_DLLPUBLIC SvxVertTextTbxCtrl final : public SvxVertCTLTextTbxCtrl
 {
 public:
-SFX_DECL_TOOLBOX_CONTROL();
-SvxVertTextTbxCtrl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
+SvxVertTextTbxCtrl(const css::uno::Reference& 
rContext);
+
+virtual OUString SAL_CALL getImplementationName() override;
 };
 
 #endif
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
index 8ed8d5c901de..b9c4d64f4278 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
@@ -1371,6 +1371,94 @@
   com.sun.star.comp.svx.LineEndToolBoxControl
 
   
+  
+
+  .uno:TextdirectionTopToBottom
+
+
+  
+
+
+  com.sun.star.comp.svx.VertTextToolBoxControl
+
+  
+  
+
+  .uno:TextdirectionLeftToRight
+
+
+  
+
+
+  com.sun.star.comp.svx.VertTextToolBoxControl
+
+  
+  
+
+  .uno:VerticalCaption
+
+
+  
+
+
+  com.sun.star.comp.svx.VertTextToolBoxControl
+
+  
+  
+
+  .uno:DrawFontworkVertical
+
+
+  
+
+
+  com.sun.star.comp.svx.VertTextToolBoxControl
+
+  
+  
+
+  .uno:VerticalText
+
+
+  
+
+
+  com.sun.star.comp.svx.VertTextToolBoxControl
+
+  
+  
+
+  .uno:VerticalTextFitToSizeTool
+
+
+  
+
+
+

[Libreoffice-commits] core.git: sw/source

2020-01-25 Thread Caolán McNamara (via logerrit)

 sw/source/uibase/misc/redlndlg.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9ce254a7797405b3b655ba4e5be2190cddad2902
Author: Caolán McNamara 
AuthorDate: Sat Jan 25 17:54:23 2020 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 25 22:44:43 2020 +0100

Resolves: tdf#130174 explicitly call SelectHdl

Change-Id: Ibda5c3595f8e02bba9faa027f4c90762aa817b42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87418
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/misc/redlndlg.cxx 
b/sw/source/uibase/misc/redlndlg.cxx
index d3159a43eb0f..fb73cd8dbc29 100644
--- a/sw/source/uibase/misc/redlndlg.cxx
+++ b/sw/source/uibase/misc/redlndlg.cxx
@@ -863,6 +863,7 @@ void SwRedlineAcceptDlg::CallAcceptReject( bool bSelect, 
bool bAccept )
 rTreeView.select(nPos);
 rTreeView.scroll_to_row(nPos);
 rTreeView.set_cursor(nPos);
+SelectHdl(rTreeView);
 }
 m_pTPView->EnableUndo();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126389] "New" in macro editing dialog does not create a new macro

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126389

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #7 from Regina Henschel  ---
(In reply to Konstantin Kharlamov from comment #0)
> # Steps to reproduce
> 
> 1. Open `lowriter` or `localc` (reproducible in either)
> 2. Go to Tools → Macros → Edit Macros
> 3. Now, a macros editing window should appear. There, click the button that
> says "New" on it.
> 
> ## Expected
> 
> A new empty macro should get created (probably should ask first about the
> language a user wants to use)

That is the general tool for new documents. That exists in all modules. You see
it too in the Math-Editor and in the Chart-Editor. It behaves the same in all
places. Simple click uses the current preselected kind of action, for other
actions open the list by clicking on the triangle and select the action.

BTW: It is a BASIC IDE, you cannot use it for other programming languages than
BASIC.

For to get a new "macro", you simple write it. For getting a new module
right-click the tabbar and choose item Insert > Basic-Module.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130194] placeholder visible in UI

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130194

Julien Nabet  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Julien Nabet  ---
Indeed, I just fixed it here:
https://weblate.documentfoundation.org/translate/libo_ui-master/swmessages/nl/?checksum=9840f02bc2a046ab

I expect it should be ok on next release 6.3.5.

Remark: there was the same pb for Thai language (see
https://weblate.documentfoundation.org/translate/libo_ui-master/swmessages/th/?checksum=9840f02bc2a046ab)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130198] Make possibly use a current value from "Input list" field as variable value

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130198

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
What do you want to do with the variable? Please say a little bit more about
the use case.

You can mark the input list in the text and set a reference on it. Later you
can insert a reference to it with type "Reference". That will show the current
value of the input field at other places in the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130200] New: Writer crashes on inserting a subdocument to a master document using the “enter” key.

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130200

Bug ID: 130200
   Summary: Writer crashes on inserting a subdocument to a master
document using the “enter” key.
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ohh...@gmail.com

Description:
I use LibreOffice dialogs for open/save. I discovered that Writer crashes each
and every time if I use the “enter” keyboard button to insert a file as a
subdocument.

Interestingly, if I perform the same operation, but instead of pressing the
“enter” key I click the “Insert” button, it works completely fine.

Steps to Reproduce:
1. I’ve just created a new master document, saved it.
2. From the Navigator I’ve clicked *Insert › File*, single-click an .odt file
to insert and press the *enter* button from the keyboard.

Actual Results:
Writer crashed. A new window (“LibreOffice 6.3 Document Recovery”) showed up
with a message beginning with “Due to an error, LibreOffice crashed.”

Expected Results:
The chosen file should be inserted as a subdocument.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123972] UI menu disapppears before submenu can open

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123972

Nick Levinson  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED
Version|6.1.5.2 release |6.3.3.2 release

--- Comment #10 from Nick Levinson  ---
That page offers LO 6.3.4 for early adopters and I don't want to introduce
instability onto my laptop and for stability it offers LO 6.2.8 when I already
have 6.3.3.2.

The effect continues, with Writer alt-f (File menu) or alt-o (Format menu). If
released too quickly for the first menu item's submenu to open, the menu
closes. The menu has to be reselected to open the submenu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114233] [META] PDF insert/embed bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114233

Buovjaga  changed:

   What|Removed |Added

 Depends on||129976


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129976
[Bug 129976] PDF image loses white background, when presentation is exported to
PDF
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129976] PDF image loses white background, when presentation is exported to PDF

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129976

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org,
   ||vmik...@collabora.com
 OS|Linux (All) |All
Version|6.3.3.2 release |5.4.0.3 release
Summary|Slide exported as PDF looks |PDF image loses white
   |different (i.e. wrong) than |background, when
   |preview |presentation is exported to
   ||PDF
  Component|Impress |Printing and PDF export
 Blocks||114233
   Keywords||bibisected, regression

--- Comment #3 from Buovjaga  ---
The chart is in fact a PDF image. You can see this by doing right-click - edit
with external tool. It opens as .tmp.pdf.

I bibisected with win32-5.4 and got this range:
https://gerrit.libreoffice.org/plugins/gitiles/core/+log/ff8b873936aa72b17309da4bfc2775573a5b1f55..169bd7718264b0e312052757f9bbd2321e1399c2

Looking at the range actually got me to try and figure out the type of the
image. It has many commits about "PDF export of PDF image" by Miklos. Bug
107018 bug 107013 and bug 107089 are referenced.

Adding Cc: to Miklos Vajna


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114233
[Bug 114233] [META] PDF insert/embed bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: avmedia/source configmgr/source connectivity/source desktop/source extensions/source include/basegfx include/vcl jvmfwk/plugins lingucomponent/source onlineupdate/sourc

2020-01-25 Thread A_GAN (via logerrit)

 avmedia/source/vlc/vlcplayer.cxx   |2 +-
 avmedia/source/vlc/wrapper/Player.cxx  |6 +++---
 avmedia/source/vlc/wrapper/SymbolLoader.hxx|4 ++--
 configmgr/source/components.cxx|2 +-
 connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx |2 +-
 desktop/source/app/app.cxx |2 +-
 desktop/source/app/crashreport.cxx |8 
 desktop/source/app/officeipcthread.cxx |2 +-
 desktop/source/app/updater.cxx |2 +-
 extensions/source/config/ldap/ldapaccess.hxx   |4 ++--
 include/basegfx/numeric/ftools.hxx |2 +-
 include/vcl/vclptr.hxx |4 ++--
 include/vcl/vclreferencebase.hxx   |2 +-
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx |4 ++--
 lingucomponent/source/lingutil/lingutil.cxx|2 +-
 onlineupdate/source/update/updater/archivereader.cxx   |2 +-
 onlineupdate/source/update/updater/progressui_win.cxx  |2 +-
 onlineupdate/source/update/updater/updater.cxx |6 +++---
 salhelper/source/simplereferenceobject.cxx |8 
 sfx2/source/appl/openuriexternally.cxx |2 +-
 sfx2/source/appl/shutdownicon.hxx  |2 +-
 soltools/mkdepend/collectdircontent.cxx|4 ++--
 soltools/mkdepend/collectdircontent.hxx|2 +-
 sw/qa/extras/odfexport/odfexport.cxx   |2 +-
 sw/qa/extras/uiwriter/uiwriter.cxx |2 +-
 sw/qa/extras/uiwriter/uiwriter2.cxx|2 +-
 toolkit/source/awt/vclxtoolkit.cxx |4 ++--
 ucb/source/ucp/file/prov.cxx   |2 +-
 unotools/source/ucbhelper/tempfile.cxx |4 ++--
 vcl/source/gdi/print3.cxx  |2 +-
 vcl/source/window/builder.cxx  |2 +-
 vcl/source/window/layout.cxx   |2 +-
 32 files changed, 49 insertions(+), 49 deletions(-)

New commits:
commit 42e811a80a3c6f0ca5da359c4a526a1cc3e0d528
Author: A_GAN 
AuthorDate: Sat Jan 25 04:33:09 2020 +0200
Commit: Mike Kaganski 
CommitDate: Sat Jan 25 22:02:16 2020 +0100

tdf#130137 Replace remaining uses of WNT define checks with _WIN32

Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/avmedia/source/vlc/vlcplayer.cxx b/avmedia/source/vlc/vlcplayer.cxx
index bbb386240998..bd2cc92baeec 100644
--- a/avmedia/source/vlc/vlcplayer.cxx
+++ b/avmedia/source/vlc/vlcplayer.cxx
@@ -173,7 +173,7 @@ namespace
 
 #if defined MACOSX
 const intptr_t id = reinterpret_cast( pEnvData->mpNSView );
-#elif defined WNT
+#elif defined _WIN32
 const intptr_t id = reinterpret_cast( pEnvData->hWnd );
 #else
 const intptr_t id = static_cast( pEnvData->aWindow );
diff --git a/avmedia/source/vlc/wrapper/Player.cxx 
b/avmedia/source/vlc/wrapper/Player.cxx
index acdda3754129..e80b8df043bb 100644
--- a/avmedia/source/vlc/wrapper/Player.cxx
+++ b/avmedia/source/vlc/wrapper/Player.cxx
@@ -40,7 +40,7 @@ namespace { extern "C" {
 void ( *libvlc_media_player_set_xwindow ) ( libvlc_media_player_t *p_mi, 
uint32_t drawable );
 #elif defined MACOSX
 void ( *libvlc_media_player_set_nsobject ) ( libvlc_media_player_t *p_mi, 
void *drawable );
-#elif defined WNT
+#elif defined _WIN32
 void ( *libvlc_media_player_set_hwnd ) ( libvlc_media_player_t *p_mi, void 
*drawable );
 #else
 #error unknown OS
@@ -83,7 +83,7 @@ namespace avmedia::vlc::wrapper
 SYM_MAP( libvlc_media_player_set_xwindow ),
 #elif defined MACOSX
 SYM_MAP( libvlc_media_player_set_nsobject ),
-#elif defined WNT
+#elif defined _WIN32
 SYM_MAP( libvlc_media_player_set_hwnd ),
 #endif
 SYM_MAP( libvlc_media_player_has_vout ),
@@ -220,7 +220,7 @@ namespace avmedia::vlc::wrapper
 libvlc_media_player_set_xwindow( mPlayer, static_cast(id) );
 #elif defined MACOSX
 libvlc_media_player_set_nsobject( mPlayer, reinterpret_cast( id 
) );
-#elif defined WNT
+#elif defined _WIN32
 libvlc_media_player_set_hwnd( mPlayer, reinterpret_cast( id ) );
 #endif
 }
diff --git a/avmedia/source/vlc/wrapper/SymbolLoader.hxx 
b/avmedia/source/vlc/wrapper/SymbolLoader.hxx
index aae124cb2575..03952eaff371 100644
--- a/avmedia/source/vlc/wrapper/SymbolLoader.hxx
+++ b/avmedia/source/vlc/wrapper/SymbolLoader.hxx
@@ -40,7 +40,7 @@ struct ApiMap
 const char LibName[] = "libvlc.so.5";
 #elif defined( MACOSX )
 const char LibName[] =

[Libreoffice-commits] core.git: compilerplugins/clang connectivity/source

2020-01-25 Thread Julien Nabet (via logerrit)

 compilerplugins/clang/mergeclasses.results   |2 +-
 connectivity/source/drivers/odbc/ORealDriver.cxx |   10 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 5568023a716b945fa3e1398859ee9682b8f71a9a
Author: Julien Nabet 
AuthorDate: Sat Jan 25 18:23:11 2020 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 25 21:58:39 2020 +0100

Typo ORealObdcDriver->ORealOdbcDriver

Thank you Terrence Enger for having spotted this!

Change-Id: I234ded85edf837e398675427fdf3e9cd3a3969a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87417
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/compilerplugins/clang/mergeclasses.results 
b/compilerplugins/clang/mergeclasses.results
index 3f7408a2fe60..3e084ce65dea 100644
--- a/compilerplugins/clang/mergeclasses.results
+++ b/compilerplugins/clang/mergeclasses.results
@@ -241,7 +241,7 @@ merge connectivity::file::OStatement_Base with 
connectivity::file::OStatement_BA
 merge connectivity::hsqldb::IMethodGuardAccess with 
connectivity::hsqldb::OHsqlConnection
 merge connectivity::java_lang_Exception with 
connectivity::java_sql_SQLException_BASE
 merge connectivity::java_sql_Statement_Base with connectivity::OStatement_BASE2
-merge connectivity::odbc::ODBCDriver with connectivity::odbc::(anonymous 
namespace)::ORealObdcDriver
+merge connectivity::odbc::ODBCDriver with connectivity::odbc::(anonymous 
namespace)::ORealOdbcDriver
 merge connectivity::odbc::OStatement_Base with 
connectivity::odbc::OStatement_BASE2
 merge connectivity::sdbcx::IObjectCollection with (anonymous 
namespace)::OHardRefMap
 merge connectivity::sdbcx::OKey with connectivity::OTableKeyHelper
diff --git a/connectivity/source/drivers/odbc/ORealDriver.cxx 
b/connectivity/source/drivers/odbc/ORealDriver.cxx
index 4654a150d793..f6432dbf57cf 100644
--- a/connectivity/source/drivers/odbc/ORealDriver.cxx
+++ b/connectivity/source/drivers/odbc/ORealDriver.cxx
@@ -26,18 +26,18 @@ namespace connectivity::odbc
 {
 namespace {
 
-class ORealObdcDriver : public ODBCDriver
+class ORealOdbcDriver : public ODBCDriver
 {
 protected:
 virtual oslGenericFunction  getOdbcFunction(ODBC3SQLFunctionId 
_nIndex)  const override;
 virtual SQLHANDLE   EnvironmentHandle(OUString &_rPath) override;
 public:
-explicit ORealObdcDriver(const css::uno::Reference< 
css::lang::XMultiServiceFactory >& _rxFactory) : ODBCDriver(_rxFactory) {}
+explicit ORealOdbcDriver(const css::uno::Reference< 
css::lang::XMultiServiceFactory >& _rxFactory) : ODBCDriver(_rxFactory) {}
 };
 
 }
 
-oslGenericFunction ORealObdcDriver::getOdbcFunction(ODBC3SQLFunctionId 
_nIndex) const
+oslGenericFunction ORealOdbcDriver::getOdbcFunction(ODBC3SQLFunctionId 
_nIndex) const
 {
 oslGenericFunction pFunction = nullptr;
 switch(_nIndex)
@@ -261,11 +261,11 @@ oslGenericFunction 
ORealObdcDriver::getOdbcFunction(ODBC3SQLFunctionId _nIndex)
 
 css::uno::Reference< css::uno::XInterface > ODBCDriver_CreateInstance(const 
css::uno::Reference< css::lang::XMultiServiceFactory >& _rxFactory)
 {
-return *(new ORealObdcDriver(_rxFactory));
+return *(new ORealOdbcDriver(_rxFactory));
 }
 
 // ODBC Environment (common for all Connections):
-SQLHANDLE ORealObdcDriver::EnvironmentHandle(OUString &_rPath)
+SQLHANDLE ORealOdbcDriver::EnvironmentHandle(OUString &_rPath)
 {
 // Is (for this instance) already an Environment made?
 if (!m_pDriverHandle)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130199] Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 130199] New: Add some indicator for mark place of hidden section in document like comment or something

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130199

Bug ID: 130199
   Summary: Add some indicator for mark place of hidden section in
document like comment or something
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Add some indicator for mark place of hidden section in document like comment or
something

Steps to Reproduce:
1. Open Writer
2. Create a section (Insert-Section)
3. Enter some text into your section
4. Hide your section
5. Now you didn't place in text where your section is and you can VERY EASY
delete it as empty paragraph is you forgot where it is.
6. Suggest mark place with hidden section somehow (like comment or may be some
float icon). Also may be need add warning message when you try delete hidden
section?

Actual Results:
if you hidden a section then you don't see it at all its place into text. There
are no any indicators

Expected Results:
you can easy find all hidden section in your document because will be some
indicators for it


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126096] Hyperlink to in-document target adds path when exported to PDF from Draw

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126096

lroll...@in-con.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #4 from lroll...@in-con.com ---
Unfortunately, this issue persists in LibreOffice version 6 (as tested on
6.2.4.2).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128943] Remove frames around rotation wheel and reference edge widget within Format / Cells / Alignment dialog

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128943

Thorsten Wagner  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |thorsten.wagne...@gmail.com
   |desktop.org |
 CC||caol...@redhat.com

--- Comment #6 from Thorsten Wagner  ---
@ Caolan

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129938] Wrong position for pasted elements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129938

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #5 from Buovjaga  ---
(In reply to Papipio from comment #2)
> For reproducing this bug:
> - draw a small straight horizontal line (2 or 3 cm) in the middle of the
> page,
> - copy this line,
> - paste it: it is pasted a bit on the left under the original line.

No such problem for me.

Arch Linux 64-bit
Version: 6.5.0.0.alpha0+
Build ID: d4561921dde7d350b3b4d5f793871bea8ba4546d
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: kf5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 23 January 2020

Arch Linux 64-bit
Version: 6.3.4.2.0+
Build ID: 6.3.4-2
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: kde5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded

Also tried gtk3 backend.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130198] Make possibly use a current value from "Input list" field as variable value

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130198

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||129294


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129294
[Bug 129294] [META] Variable field bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129294] [META] Variable field bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129294

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||130198


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130198
[Bug 130198] Make possibly use a current value from "Input list" field as
variable value
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129961] FILEOPEN PPTX: shadow effect for table completely missing

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129961

Buovjaga  changed:

   What|Removed |Added

 Blocks||108226
   Keywords||filter:pptx

--- Comment #4 from Buovjaga  ---
Looks like the table borders and cell colours were not rendered at all in
versions earlier than 6.5, so at least this is progress.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Buovjaga  changed:

   What|Removed |Added

 Depends on||129961


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129961
[Bug 129961] FILEOPEN PPTX: shadow effect for table completely missing
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130198] New: Make possibly use a current value from "Input list" field as variable value

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130198

Bug ID: 130198
   Summary: Make possibly use a current value from "Input list"
field as variable value
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Make possibly use a current value from "Input list" field as variable value.
There are many cases for variable using.
And would be very cool to have a simple opportunity to set a variable value 
from list in document using "Input list" field.

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126389] "New" in macro editing dialog does not create a new macro

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126389

Konstantin Kharlamov  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from Konstantin Kharlamov  ---
(In reply to Xisco Faulí from comment #5)
> Hello Konstantin Kharlamov,
> A new major release of LibreOffice is available since this bug was reported.
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the latest version.

Still reproducible in 6.3.4.2. Text from "about" window:

Version: 6.3.4.2.0+
Build ID: 6.3.4-2
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3;
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114609] pptx incorrect textbox shadow

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114609

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||9916

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129916] FILEOPEN PPTX: shadow size for rectangle is only a fraction of Office 365

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129916

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4609

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Gsoc 2020

2020-01-25 Thread Ilmari Lauhakangas

For what it's worth, I am able to access 
http://archive.apache.org/dist/ant/binaries/apache-ant-1.9.4-bin.zip 
just fine.


Ilmari

anshu khare kirjoitti 25.1.2020 klo 16.55:

Hi sir,

I executed the whole process again.
But it's again giving the same error.

Regards
Anshu

On Sat, 25 Jan, 2020, 7:08 PM Mark Hung, > wrote:


Hi anshu khare,

You should proceed only after you successfully completes setup. Http
500 means server side error. Try to run setup again.


anshu khare mailto:anshukhar...@gmail.com>>
於 2020年1月25日 週六 21:01 寫道：

Hi mentors

I am Anshu and I want to contribute to this organization. I was
trying to build libre-office on windows. When I ran ./setup I
got the output as follows :

Check directory 'packages' ... : Created
Check directory 'opt' ... : Created
Check directory 'ext_tar' ... : Created
Check directory 'adm' ... : Created
Check directory 'tb' ... : Created
Cloning into 'buildbot'...
Cloned /home/hp/lode/adm/buildbot
Check directory '/home/hp/lode/opt/bin' ... : Created
--2020-01-25 14:32:45--
http://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
Resolving dev-www.libreoffice.org
 (dev-www.libreoffice.org
)... 89.238.68.201,
2a00:1828:a012:201::1
Connecting to dev-www.libreoffice.org
 (dev-www.libreoffice.org
)|89.238.68.201|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
[following]
--2020-01-25 14:32:46--
https://dev-www.libreoffice.org/bin/cygwin/make-4.2.1-msvc.exe
Connecting to dev-www.libreoffice.org
 (dev-www.libreoffice.org
)|89.238.68.201|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 291328 (284K) [application/octet-stream]
Saving to: ‘make-4.2.1-msvc.exe’

      0K .. .. .. .. ..
17%  308K 1s
     50K .. .. .. .. ..
35%  294K 1s
    100K .. .. .. .. ..
52% 2.12M 0s
    150K .. .. .. .. ..
70%  432K 0s
    200K .. .. .. .. ..
87% 1.36M 0s
    250K .. .. .. 
100% 3.37M=0.5s


2020-01-25 14:32:48 (550 KB/s) - ‘make-4.2.1-msvc.exe’ saved
[291328/291328]

--2020-01-25 14:32:48--
http://archive.apache.org/dist/ant/binaries/apache-ant-1.9.4-bin.zip
Resolving archive.apache.org 
(archive.apache.org )... 163.172.17.199
Connecting to archive.apache.org 
(archive.apache.org
)|163.172.17.199|:80... connected.
HTTP request sent, awaiting response... 500 Operation not permitted
2020-01-25 14:32:48 ERROR 500: Operation not permitted.

/home/hp/lode/bin/utils.sh: line 120: module: parameter null or
not set

After this when I run cd dev/core, it says no such file exists.
Could you please help me with it?

Regards
Anshu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org

https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 130197] Paragraph Sidebar SpinButton width

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130197

--- Comment #1 from andreas_k  ---
Created attachment 157428
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157428=edit
Sidebar Table

As you can see here the table sidebar didn't fit into the width cause the width
size come from paragraph sidebar cause it's open by default. So if the width of
paragraph was the largest or at least not shrinked, it will be easier to fit
all widgets.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130178] Graphic (chart) text distorted & axis labels missing (but not in Excel 2013)

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130178

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #4 from m.a.riosv  ---
Created attachment 157427
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157427=edit
How to set up a font replacement

The issue comes from the use 'Darwin' font in that title, I have not it
installed, so the issue is there but not is a LibreOffice issue.

You need to install the font in your system.

Or using LibreOffice options for font replace, solves the issue for me.
You can see how on the attached screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130178] Graphic (chart) text distorted & axis labels missing (but not in Excel 2013)

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130178

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130197] New: Paragraph Sidebar SpinButton width

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130197

Bug ID: 130197
   Summary: Paragraph Sidebar SpinButton width
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

Created attachment 157426
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157426=edit
sidebar width

in sidebarparagraph.ui file the GtkSpinButton
- aboveparaspacing
- belowparaspacing
- beforetextindent
- aftertextindent
- firstlineindent

are smaller than they should be which result into problems at sidebar width.

As sidebarparagraph is the widest sidebar AND the default sidebar (in writer)
all other sidebar widgets follow the size of the default one, so if the
sidebarparagraph.ui wasn't shrinked all other widths will be easier to fit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130180] copying sheets, even together, breaks formulas that link between them

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130180

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
It's simple you must avoid the reference to the sheet being absolute.
With:
=$Sheet1.a1 refers to the original file, what it right it is an absolute
reference.

but instead using
=Sheet1.a1 do as you like, again it does right not carrying the reference the
the original file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102283] [META] Slide/page pane bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102283

Buovjaga  changed:

   What|Removed |Added

 Depends on||129822


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129822
[Bug 129822] [UI] Impress "create new slide by double clicking" creates new
slide at wrong location
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129822] [UI] Impress "create new slide by double clicking" creates new slide at wrong location

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129822

Buovjaga  changed:

   What|Removed |Added

Version|6.0.1.1 release |4.2.0.4 release
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
   Keywords||implementationError
 Blocks||102283

--- Comment #2 from Buovjaga  ---
This feature was apparently added in 4.2 and has always had this bug.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102283
[Bug 102283] [META] Slide/page pane bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129644] Calc chart export as image to pdf producing broken pdf file

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129644

Buovjaga  changed:

   What|Removed |Added

 OS|Linux (All) |All
   Keywords||implementationError
 Blocks||103378
Version|6.2.8.2 release |5.3.0.3 release
   Severity|normal  |minor

--- Comment #2 from Buovjaga  ---
Apparently PDF as a format option was added in 5.3 and it has never produced
working files.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Buovjaga  changed:

   What|Removed |Added

 Depends on||129644


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129644
[Bug 129644] Calc chart export as image to pdf producing broken pdf file
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: uitest/libreoffice

2020-01-25 Thread Mike Kaganski (via logerrit)

 uitest/libreoffice/connection.py |   16 
 1 file changed, 12 insertions(+), 4 deletions(-)

New commits:
commit 150b67b57bd25ba9c8ec9c28c7aed3cc0b557bfd
Author: Mike Kaganski 
AuthorDate: Fri Jan 24 19:02:23 2020 +0100
Commit: Mike Kaganski 
CommitDate: Sat Jan 25 20:03:15 2020 +0100

UITest: Actually time-out the wait

Without that, if XDesktop::terminate() fails (e.g., because an assert in
a test was false while a modal dialog was open, which left the dialog
open, and so TerminationVetoException was thrown in XDesktop::terminate()
by a listener), the wait never ends, and the assertion message gets lost
when buildbot terminates the build, as happened in
https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/51496/console.

The timeout only available since python 3.3.

The soffice process is not terminated in this case; hopefully it will be
terminated when build cleanup will occur.

Change-Id: I924775d0e58619d1fbd603e80ed1f8d047c91145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87362
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/uitest/libreoffice/connection.py b/uitest/libreoffice/connection.py
index cb3ae1a0128e..3dbae4cca355 100644
--- a/uitest/libreoffice/connection.py
+++ b/uitest/libreoffice/connection.py
@@ -9,6 +9,7 @@ import subprocess
 import time
 import uuid
 import os
+import sys
 
 try:
 import pyuno
@@ -130,10 +131,17 @@ class OfficeConnection:
 else:
 self.soffice.terminate()
 
-ret = self.soffice.wait()
-self.xContext = None
-self.socket = None
-self.soffice = None
+
+try:
+if sys.version_info >= (3,3):
+ret = self.soffice.wait(30) # will throw when timed out
+else:
+ret = self.soffice.wait() # no timeout in python that old
+finally:
+self.xContext = None
+self.socket = None
+self.soffice = None
+
 if ret != 0:
 raise Exception("Exit status indicates failure: " + str(ret))
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 122667] Delete sheet causes many Exception in getAccessibleName() warnings

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=122667

--- Comment #16 from Jim Avera  ---
The point is that something in how LO interacts with gnome is making LO break
and spew errors onto the terminal.

I can't tell you exactly what triggers the errors, only that I've narrowed it
down to some OS interaction which occurs when a particular gnome extension
installed.  

The setup script I provided allows easy test and debugging without requiring
you (i.e. a developer) to actually install this gnome extension in your
personal setup.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130196] New: Changing nav-order in navigator does not work on single page

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130196

Bug ID: 130196
   Summary: Changing nav-order in navigator does not work on
single page
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 157425
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157425=edit
File with named shapes to test Navigator

Error: Changing nav-order in Navigator does not work, if only one page exists.

To reproduce the error:

Open attached document.
Open the navigator as floating window by pressing Ctrl+Shift+F5.
Go back to main window, but keep Navigator open.
Press Tab-key several times.
Notice, that the order of the shapes in the Navigator is the same as the order
in which the tab key goes through the shapes.

Now try to drag the "Rectangle" shape before the "Triangle" shape or to any
other position in the Navigator. You will always see a 'forbidden' sign.

Insert a second page.

Now try again to drag the "Rectangle" shape before the "Triangle" shape. Now it
works.

Go back to main window, but keep Navigator open.

Press Tab-key several times. Notice, that the order in which the tab key goes
through the shapes corresponds to the changed order in the navigator. So
changing nav-order via Navigator works in principle, but not if only one page
exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129723] INDEX DIALOG: allow each level to be "Run On" or "Set Out" independently

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129723

--- Comment #3 from R. Green  ---
To meet publishing standards, the following change also needs to be made.

If a run-on list of subentries appears after an entry, it is separated from the
entry by either a colon and space ("Chicago Manual of Style"), or semicolon and
space ("New Hart's Rules").

For example (using the Chicago style):

"Native American peoples: Ahualucos, 273, 274; Chichimecs, 67–68; Huastecs,
154; Toltecs, 128–36; Zapotecs, 168–72"

(Note: "Native American peoples" is the entry, and the rest are subentries)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112390] Double click for some Toolbar button actions duplicates the action, not catching the double click as selection when needed

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112390

V Stuart Foote  changed:

   What|Removed |Added

 CC||qui...@gmail.com,
   ||rayk...@gmail.com,
   ||t...@libreoffice.org
Summary|Double-clicking various |Double click for some
   |toolbar buttons opens two   |Toolbar button actions
   |file dialogs (Windows)  |duplicates the action, not
   ||catching the double click
   ||as selection when needed

--- Comment #10 from V Stuart Foote  ---
This remains an issue in master / 7.00. 

For some back ends and os/de combinations do Toolbar actions need explicit
double click handlers?

=-testing-=
Version: 7.0.0.0.alpha0+ (x64)
Build ID: a22de0aacc9fb4197e9051f572b1a9298b2472e2
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130195] Change text spacing crashes LO

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130195

--- Comment #1 from Axel Braun  ---
Created attachment 157424
  --> https://bugs.documentfoundation.org/attachment.cgi?id=157424=edit
header (copy into .odt)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130195] New: Change text spacing crashes LO

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130195

Bug ID: 130195
   Summary: Change text spacing crashes LO
   Product: LibreOffice
   Version: 6.4.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: axel.br...@gmx.de

Description:
I created a page header in Impress - some boxes grouped together, one with text
that contains character spacing.
Copy the header into a .odt, mark the text in box and change spacing -> LO
crashes

Steps to Reproduce:
1. copy page header into text document
2. be surprised that the textbox has now a line break
3. mark text
4. change character spacing (smaller) 
5. click OK -> crash

Actual Results:
it crashes

Expected Results:
it changes the spacing


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.2
Build-ID: 40(Build:2)
CPU-Threads: 4; BS: Linux 5.4; UI-Render: Standard; VCL: kf5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #45 from Commit Notification 
 ---
Faruk Demirbaş committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/37b20089669e5d6f20db863ed770647ba8b1bd37

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #44 from Commit Notification 
 ---
Batuhan Taskaya committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44139efb6a64735d3c6fe1f1b0f0007eff3a7504

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: formula/inc

2020-01-25 Thread Faruk Demirbaş (via logerrit)

 formula/inc/core_resource.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 37b20089669e5d6f20db863ed770647ba8b1bd37
Author: Faruk Demirbaş 
AuthorDate: Sat Jan 25 15:05:07 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sat Jan 25 19:10:42 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I4a4e18cf3c61aaebb467e43ebbf846e8860f4105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87388
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/formula/inc/core_resource.hxx b/formula/inc/core_resource.hxx
index 1990a36c14e3..8a8f49b77b0f 100644
--- a/formula/inc/core_resource.hxx
+++ b/formula/inc/core_resource.hxx
@@ -17,14 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_FORMULA_SOURCE_CORE_INC_CORE_RESOURCE_HXX
-#define INCLUDED_FORMULA_SOURCE_CORE_INC_CORE_RESOURCE_HXX
+#pragma once
 
 #include 
 #include 
 
 FORMULA_DLLPUBLIC OUString ForResId(const char *pId);
 
-#endif // INCLUDED_FORMULA_SOURCE_CORE_INC_CORE_RESOURCE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source pyuno/inc

2020-01-25 Thread Batuhan Taskaya (via logerrit)

 dbaccess/source/sdbtools/connection/datasourcemetadata.hxx |5 +
 dbaccess/source/sdbtools/connection/objectnames.hxx|5 +
 dbaccess/source/sdbtools/connection/tablename.hxx  |5 +
 dbaccess/source/sdbtools/inc/connectiondependent.hxx   |5 +
 dbaccess/source/sdbtools/inc/connectiontools.hxx   |5 +
 pyuno/inc/pyuno.hxx|4 +---
 6 files changed, 6 insertions(+), 23 deletions(-)

New commits:
commit 44139efb6a64735d3c6fe1f1b0f0007eff3a7504
Author: Batuhan Taskaya 
AuthorDate: Sat Jan 25 14:58:32 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sat Jan 25 19:09:34 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: Ic35fce6fbc9c41a004f93952df83496ca1809004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87380
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/dbaccess/source/sdbtools/connection/datasourcemetadata.hxx 
b/dbaccess/source/sdbtools/connection/datasourcemetadata.hxx
index 7b7fa365b7c9..232f97f601ae 100644
--- a/dbaccess/source/sdbtools/connection/datasourcemetadata.hxx
+++ b/dbaccess/source/sdbtools/connection/datasourcemetadata.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_DATASOURCEMETADATA_HXX
-#define INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_DATASOURCEMETADATA_HXX
+#pragma once
 
 #include 
 
@@ -67,6 +66,4 @@ namespace sdbtools
 
 } // namespace sdbtools
 
-#endif // INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_DATASOURCEMETADATA_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/sdbtools/connection/objectnames.hxx 
b/dbaccess/source/sdbtools/connection/objectnames.hxx
index 9c42bd67b98f..439db0967101 100644
--- a/dbaccess/source/sdbtools/connection/objectnames.hxx
+++ b/dbaccess/source/sdbtools/connection/objectnames.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_OBJECTNAMES_HXX
-#define INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_OBJECTNAMES_HXX
+#pragma once
 
 #include 
 
@@ -72,6 +71,4 @@ namespace sdbtools
 
 } // namespace sdbtools
 
-#endif // INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_OBJECTNAMES_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/sdbtools/connection/tablename.hxx 
b/dbaccess/source/sdbtools/connection/tablename.hxx
index 4b2f4313344f..3a7ece21a182 100644
--- a/dbaccess/source/sdbtools/connection/tablename.hxx
+++ b/dbaccess/source/sdbtools/connection/tablename.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_TABLENAME_HXX
-#define INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_TABLENAME_HXX
+#pragma once
 
 #include 
 
@@ -82,6 +81,4 @@ namespace sdbtools
 
 } // namespace sdbtools
 
-#endif // INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_TABLENAME_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/sdbtools/inc/connectiondependent.hxx 
b/dbaccess/source/sdbtools/inc/connectiondependent.hxx
index 37fb95b16588..d315d70187fb 100644
--- a/dbaccess/source/sdbtools/inc/connectiondependent.hxx
+++ b/dbaccess/source/sdbtools/inc/connectiondependent.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONDEPENDENT_HXX
-#define INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONDEPENDENT_HXX
+#pragma once
 
 #include 
 #include 
@@ -133,6 +132,4 @@ namespace sdbtools
 
 } // namespace sdbtools
 
-#endif // INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONDEPENDENT_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/sdbtools/inc/connectiontools.hxx 
b/dbaccess/source/sdbtools/inc/connectiontools.hxx
index 5e4837112b3f..a3dd610f861e 100644
--- a/dbaccess/source/sdbtools/inc/connectiontools.hxx
+++ b/dbaccess/source/sdbtools/inc/connectiontools.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONTOOLS_HXX
-#define INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONTOOLS_HXX
+#pragma once
 
 #include "connectiondependent.hxx"
 
@@ -81,6 +80,4 @@ namespace sdbtools
 
 } // namespace sdbtools
 
-#endif // INCLUDED_DBACCESS_SOURCE_SDBTOOLS_CONNECTION_CONNECTIONTOOLS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/pyuno/inc/pyuno.hxx b/pyuno/inc/pyuno.hxx
index e2cdc5f0329e..e50dde9bb119 100644
--- a/pyuno/inc/pyuno.hxx
+++ b/pyuno/inc/pyuno.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_PYUNO_INC_PYUNO_HXX
-#define INCLUDED_PYUNO_INC_PYUNO_HXX
+#pragma

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #43 from Commit Notification 
 ---
Canberk TURAN committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/134507a663871d45951fdbd4291fa337ed70a1f4

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

2020-01-25 Thread Canberk TURAN (via logerrit)

 connectivity/source/inc/calc/CCatalog.hxx  |5 +
 connectivity/source/inc/calc/CConnection.hxx   |5 +
 connectivity/source/inc/calc/CDatabaseMetaData.hxx |5 +
 connectivity/source/inc/calc/CDriver.hxx   |5 +
 connectivity/source/inc/calc/CTable.hxx|5 +
 5 files changed, 5 insertions(+), 20 deletions(-)

New commits:
commit 134507a663871d45951fdbd4291fa337ed70a1f4
Author: Canberk TURAN 
AuthorDate: Sat Jan 25 16:20:54 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sat Jan 25 19:06:43 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I7b32821caa1ade54ead49205aded36f4707b3e01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87400
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/connectivity/source/inc/calc/CCatalog.hxx 
b/connectivity/source/inc/calc/CCatalog.hxx
index 57051fe8e183..724b5fb129a0 100644
--- a/connectivity/source/inc/calc/CCatalog.hxx
+++ b/connectivity/source/inc/calc/CCatalog.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCATALOG_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCATALOG_HXX
+#pragma once
 
 #include 
 
@@ -38,6 +37,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCATALOG_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/inc/calc/CConnection.hxx 
b/connectivity/source/inc/calc/CConnection.hxx
index cc8cc59702b9..3cd139635a2c 100644
--- a/connectivity/source/inc/calc/CConnection.hxx
+++ b/connectivity/source/inc/calc/CConnection.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCONNECTION_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCONNECTION_HXX
+#pragma once
 
 #include 
 #include 
@@ -148,6 +147,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CCONNECTION_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/inc/calc/CDatabaseMetaData.hxx 
b/connectivity/source/inc/calc/CDatabaseMetaData.hxx
index 7cda0f1c8ef2..a46d09c14b1c 100644
--- a/connectivity/source/inc/calc/CDatabaseMetaData.hxx
+++ b/connectivity/source/inc/calc/CDatabaseMetaData.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDATABASEMETADATA_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDATABASEMETADATA_HXX
+#pragma once
 
 #include 
 
@@ -42,6 +41,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDATABASEMETADATA_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/inc/calc/CDriver.hxx 
b/connectivity/source/inc/calc/CDriver.hxx
index 89e92f4144c4..73b2f564c149 100644
--- a/connectivity/source/inc/calc/CDriver.hxx
+++ b/connectivity/source/inc/calc/CDriver.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDRIVER_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDRIVER_HXX
+#pragma once
 
 #include 
 
@@ -53,6 +52,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CDRIVER_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/inc/calc/CTable.hxx 
b/connectivity/source/inc/calc/CTable.hxx
index 570a6bc87134..057ba2a2354d 100644
--- a/connectivity/source/inc/calc/CTable.hxx
+++ b/connectivity/source/inc/calc/CTable.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLE_HXX
-#define INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLE_HXX
+#pragma once
 
 #include 
 #include 
@@ -76,6 +75,4 @@ namespace connectivity
 }
 }
 
-#endif // INCLUDED_CONNECTIVITY_SOURCE_INC_CALC_CTABLE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #42 from Commit Notification 
 ---
Faruk Demirbaş committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a44ca770302e8aa7079de96bda0c2fe2e7cc92bb

tdf#124176: Use pragma once instead of include guards

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc

2020-01-25 Thread Faruk Demirbaş (via logerrit)

 sc/inc/NumberFormatControl.hxx |6 ++
 sc/inc/documentlinkmgr.hxx |5 +
 sc/inc/filtopt.hxx |5 +
 sc/inc/fonthelper.hxx  |5 +
 sc/inc/forbiuno.hxx|5 +
 5 files changed, 6 insertions(+), 20 deletions(-)

New commits:
commit a44ca770302e8aa7079de96bda0c2fe2e7cc92bb
Author: Faruk Demirbaş 
AuthorDate: Sat Jan 25 16:28:07 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sat Jan 25 19:01:50 2020 +0100

tdf#124176: Use pragma once instead of include guards

Change-Id: I2c74c77115df7c9fd29ccf7722d00c71687046fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87402
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/sc/inc/NumberFormatControl.hxx b/sc/inc/NumberFormatControl.hxx
index e2c8712b7032..56ec8ed0e3cb 100644
--- a/sc/inc/NumberFormatControl.hxx
+++ b/sc/inc/NumberFormatControl.hxx
@@ -16,8 +16,8 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_SC_NUMBERFORMATCONTROL_HXX
-#define INCLUDED_SC_NUMBERFORMATCONTROL_HXX
+
+#pragma once
 
 #include "scdllapi.h"
 #include 
@@ -40,6 +40,4 @@ public:
 
 } // end of namespace sc
 
-#endif // INCLUDED_SC_NUMBERFORMATCONTROL_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/documentlinkmgr.hxx b/sc/inc/documentlinkmgr.hxx
index b0c85826b4db..99a3ca3e5a95 100644
--- a/sc/inc/documentlinkmgr.hxx
+++ b/sc/inc/documentlinkmgr.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_SC_INC_DOCUMENTLINKMGR_HXX
-#define INCLUDED_SC_INC_DOCUMENTLINKMGR_HXX
+#pragma once
 
 #include 
 #include 
@@ -68,6 +67,4 @@ private:
 
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/filtopt.hxx b/sc/inc/filtopt.hxx
index 212fca328232..50dfdfbbf373 100644
--- a/sc/inc/filtopt.hxx
+++ b/sc/inc/filtopt.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SC_INC_FILTOPT_HXX
-#define INCLUDED_SC_INC_FILTOPT_HXX
+#pragma once
 
 #include 
 #include "scdllapi.h"
@@ -40,6 +39,4 @@ public:
 boolGetWK3Flag() const  { return bWK3Flag; }
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/fonthelper.hxx b/sc/inc/fonthelper.hxx
index f3ecf2bfb9c5..0f94b41400cc 100644
--- a/sc/inc/fonthelper.hxx
+++ b/sc/inc/fonthelper.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_SC_INC_FONTHELPER_HXX
-#define INCLUDED_SC_INC_FONTHELPER_HXX
+#pragma once
 
 #include "scdllapi.h"
 #include 
@@ -46,6 +45,4 @@ struct SC_DLLPUBLIC ScDxfFont
 }
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/forbiuno.hxx b/sc/inc/forbiuno.hxx
index ac599c010a47..b6440f4eb7fb 100644
--- a/sc/inc/forbiuno.hxx
+++ b/sc/inc/forbiuno.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SC_INC_FORBIUNO_HXX
-#define INCLUDED_SC_INC_FORBIUNO_HXX
+#pragma once
 
 #include 
 #include 
@@ -40,6 +39,4 @@ public:
 virtual voidNotify( SfxBroadcaster& rBC, const SfxHint& rHint ) 
override;
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #41 from Commit Notification 
 ---
Efdal İncesu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/99c5669b4f54a3e55625ec0896852ed4154d2765

tdf#124176: Use pragma once instead of include guard

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sc/inc test/source

2020-01-25 Thread Efdal İncesu (via logerrit)

 include/sfx2/checkin.hxx   |6 ++
 sc/inc/calcmacros.hxx  |5 +
 sc/inc/columnset.hxx   |5 +
 sc/inc/strings.hxx |4 +---
 test/source/isheadless.hxx |5 +
 5 files changed, 6 insertions(+), 19 deletions(-)

New commits:
commit 99c5669b4f54a3e55625ec0896852ed4154d2765
Author: Efdal İncesu 
AuthorDate: Sat Jan 25 16:24:28 2020 +0300
Commit: Muhammet Kara 
CommitDate: Sat Jan 25 18:58:16 2020 +0100

tdf#124176: Use pragma once instead of include guard

Change-Id: Ic525a57880067fc589346b87237c08fae4644ac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87403
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/include/sfx2/checkin.hxx b/include/sfx2/checkin.hxx
index 680160cedd97..78535f7aab9d 100644
--- a/include/sfx2/checkin.hxx
+++ b/include/sfx2/checkin.hxx
@@ -6,8 +6,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
-#ifndef INCLUDED_SFX2_CHECKIN_HXX
-#define INCLUDED_SFX2_CHECKIN_HXX
+
+#pragma once
 
 #include 
 
@@ -28,6 +28,4 @@ public:
 bool IsMajor() const;
 };
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/calcmacros.hxx b/sc/inc/calcmacros.hxx
index ca51c62adb54..c0c68d4487cf 100644
--- a/sc/inc/calcmacros.hxx
+++ b/sc/inc/calcmacros.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_SC_INC_CALCMACROS_HXX
-#define INCLUDED_SC_INC_CALCMACROS_HXX
+#pragma once
 
 #define DEBUG_COLUMN_STORAGE 0
 #define DEBUG_PIVOT_TABLE 0
@@ -35,6 +34,4 @@ using std::cerr;
 using std::endl;
 #endif
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/columnset.hxx b/sc/inc/columnset.hxx
index 879c9098b9d6..d7d9a4de5ec6 100644
--- a/sc/inc/columnset.hxx
+++ b/sc/inc/columnset.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_SC_INC_COLUMNSET_HXX
-#define INCLUDED_SC_INC_COLUMNSET_HXX
+#pragma once
 
 #include "types.hxx"
 
@@ -36,6 +35,4 @@ public:
 
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/inc/strings.hxx b/sc/inc/strings.hxx
index dcd76c281aa9..f21fccf77b6a 100644
--- a/sc/inc/strings.hxx
+++ b/sc/inc/strings.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_SC_INC_STRINGS_HXX
-#define INCLUDED_SC_INC_STRINGS_HXX
+#pragma once
 
 #define SCSTR_FIELDSEP  
",\t44\t;\t59\t:\t58\t{%TAB}\t9\t{%SPACE}\t32 "
 #define SCSTR_TEXTSEP   "\"\t34\t'\t39"
@@ -23,6 +22,5 @@
 #define STR_ACC_RIGHTAREA_DESCR ""
 #define STR_ACC_HEADER_DESCR""
 #define STR_ACC_FOOTER_DESCR""
-#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/test/source/isheadless.hxx b/test/source/isheadless.hxx
index 8a3e81e6ee72..c9f22232bd15 100644
--- a/test/source/isheadless.hxx
+++ b/test/source/isheadless.hxx
@@ -7,8 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_TEST_SOURCE_ISHEADLESS_HXX
-#define INCLUDED_TEST_SOURCE_ISHEADLESS_HXX
+#pragma once
 
 #include 
 
@@ -32,6 +31,4 @@ inline bool isHeadless() {
 
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 90613] FILEOPEN: DOCX import blank document created from MSO normal.dotm

2020-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90613

--- Comment #17 from junk_2...@live.co.uk ---
I original reported this as:
Bug #104819 - Formatting: Corrupt Document/Format After Save When Starting With
Empty .docx Document
which has been marked as a duplicate of this bug.

I can confirm that following the steps in Bug #104819 that this issue is still
present in LibreOffice 6.3.4.2 on Windows 10.

The "saved" document can be re-opened by LibreOffice, however all formatting
etc is "missing". It appears to just open as a plain text file.
If you try to open the saved document using Microsoft Word 2013, the document
is reported as being "corrupt" and not "recoverable"

Version used details:
Version: 6.3.4.2 (x64)
Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 211 matches

Mail list logo