Blurry display on Retina macOS computers
> On 12 Feb 2020, at 09:23, Tor Lillqvist wrote: > > In a nutshell, you need to build with macOS SDK 10.13, as SDK 10.14 and 10.15 > produce blurry results > > But that sounds just like a silly workaround. Does anybody have any insight > in what the actual thing going on here is? > > --tml That may be true - but it would be an effective bandaid before a proper fix is found (we’re now up to 18 dupes and 64 in CC on the bug…) Thorsten Wagner found the bandaid, and Emmeran Seehuber tried looking into the underlying issue Taking the liberty to include them on CC here in case they have further input, Emmeran asked for more pointers to look into it Best, Eivind From https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c145 I also tried to look into it. (master on MacOS 10.15.2 with SDK 10.15) AquaSalGraphics::CheckContext(): The backingScaleFactor of the window is correct (2.0 for Retina) and so is the size of the CGLayer used as draw buffer for the window (i.e. twice the window width x height). That looks all fine. For me it seems something gets into a broken state in the CGContextRef while painting the document content. Because not only the text but also all lines are blurred. This is just guessing, but maybe a scale with a factor other than 2 or something like this? It would have to be something affected at compile time, i.e. a constant of the SDK headers which changed between SDK 10.12 and 10.13. Or a helper function in a SDK library. The strange thing is, the print preview of Calc looks fine, i.e. not blurry, everything sharp. The print preview of Writer on the other side is blurry. I have this effect both with my master build and the official 6.3.4.2 build. So the print preview of Calc does something different than the rest, because it seems the CGContextRef is not getting in this bogus blurry state. Any idea how to investigate this future? (I'm new to the LibreOffice code base; Pointers are welcome) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130615] Typing lags when typing inside tables
https://bugs.documentfoundation.org/show_bug.cgi?id=130615 --- Comment #2 from galeny...@yahoo.com --- Have tested this on 2 iMacs. Currently running one on: macOS High Sierra Version 10.13.6 Imac Retina 4K, 2.5 inch, Late 2015 3.3 Ghz, Intel Core i7 16 GB RAM Graphics: Intel Iris Pro Graphics 6200 1536 MB The issue is the same on this Mac and other similarly configured model. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130631] New: alt-letter menu accelerators are broken in non-latin keyboard layouts on linux
https://bugs.documentfoundation.org/show_bug.cgi?id=130631 Bug ID: 130631 Summary: alt-letter menu accelerators are broken in non-latin keyboard layouts on linux Product: LibreOffice Version: 6.4.0.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@royal.net Description: Linux and LibreOffice with English UK UI (Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB), English US and Russian keyboard layouts are installed. In English layout Alt-letters act as menu accelerators but in Russian layout they generate plain Cyrillic characters. Both Writer and Calc are affected. Steps to Reproduce: prerequisites: English and Russian keyboard layouts are installed 1. start writer 2. switch to Russian keyboard layout 3. press Alt-F Actual Results: cyrillic letter А (the Cyrillic character located on F keyboard button in Russian layout) is typed into the document body Expected Results: File menu should've been opened Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.0.3 Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: kf5; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108770 Bug 108770 depends on bug 129531, which changed state. Bug 129531 Summary: Fileopen: Outline numbering levels from DOCX not recognized https://bugs.documentfoundation.org/show_bug.cgi?id=129531 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/returnconstant.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 379d6e1dbe74a13dfe8d007e64cecdd1260c93ef
Author: Stephan Bergmann
AuthorDate: Wed Feb 12 17:04:44 2020 +0100
Commit: Stephan Bergmann
CommitDate: Thu Feb 13 08:14:08 2020 +0100
aImmediateMacro is unused
...ever since fdc50b0a1b9741c5610a2b6c793c8fcdf5573c76 "new
loplugin:returnconstant"
Change-Id: Ib7f8760a95112aa31e1dd2ae15229c42e5fee812
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88547
Reviewed-by: Noel Grandin
Reviewed-by: Stephan Bergmann
Tested-by: Jenkins
diff --git a/compilerplugins/clang/returnconstant.cxx
b/compilerplugins/clang/returnconstant.cxx
index e33a35664e62..c2c0442bf63d 100644
--- a/compilerplugins/clang/returnconstant.cxx
+++ b/compilerplugins/clang/returnconstant.cxx
@@ -118,14 +118,12 @@ bool ReturnConstant::TraverseCXXMethodDecl(CXXMethodDecl*
functionDecl)
return true;
// ignore LINK macro stuff
-std::string aImmediateMacro = "";
if
(compiler.getSourceManager().isMacroBodyExpansion(compat::getBeginLoc(functionDecl))
||
compiler.getSourceManager().isMacroArgExpansion(compat::getBeginLoc(functionDecl)))
{
StringRef name{
Lexer::getImmediateMacroName(compat::getBeginLoc(functionDecl),
compiler.getSourceManager(),
compiler.getLangOpts()) };
-aImmediateMacro = name.str();
if (name.find("IMPL_LINK") != StringRef::npos
|| name.find("IMPL_STATIC_LINK") != StringRef::npos
|| name.find("DECL_LINK") != StringRef::npos
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Dieter changed: What|Removed |Added Depends on||130615 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=130615 [Bug 130615] Typing lags when typing inside tables -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130615] Typing lags when typing inside tables
https://bugs.documentfoundation.org/show_bug.cgi?id=130615 Dieter changed: What|Removed |Added Blocks||103100 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- I can't confirm this with Version: 6.3.4.2 (x64) Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded Perhaps Mac only? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.ContextMenu.js |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
New commits:
commit 6543ad21bbeeb23bf96f67a50edceef7053b914d
Author: Michael Meeks
AuthorDate: Thu Feb 13 04:47:38 2020 +
Commit: Andras Timar
CommitDate: Thu Feb 13 07:57:18 2020 +0100
mobile: Delete insertion - use graphic selection rather than clip.
The clipboard population is asynchronous and might come too late.
Was missing the Delete item on Android.
Change-Id: I05515f151c8d730e2aa1cb61eceacd0c3b90c455
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88579
Reviewed-by: Ashod Nakashian
Tested-by: Jenkins CollaboraOffice
diff --git a/loleaflet/src/control/Control.ContextMenu.js
b/loleaflet/src/control/Control.ContextMenu.js
index 9912729ce..9bc7a23c2 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -157,11 +157,8 @@ L.Control.ContextMenu = L.Control.extend({
},
_amendContextMenuData: function(obj) {
-
- // Add a 'delete' entry for mobile when selection is
ole/image/shape
- if (this._map._clip && this._map._clip._selectionType ===
'complex' &&
- window.mode.isMobile()) {
-
+ // Add a 'delete' entry for mobile for graphic selection.
+ if (this._map._docLayer.hasGraphicSelection() &&
window.mode.isMobile()) {
var insertIndex = -1;
obj.menu.forEach(function(item, index) {
if (item.command === '.uno:Paste') {
@@ -174,7 +171,6 @@ L.Control.ContextMenu = L.Control.extend({
{ text: _('Delete'), type: 'command',
command: '.uno:Delete', enabled: true });
}
}
-
},
_createContextMenuStructure: function(obj) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130613] Libre Writer problem either with layout or with autokey
https://bugs.documentfoundation.org/show_bug.cgi?id=130613 --- Comment #1 from Dieter --- Duns, I think main problem is about installation, so I changed component. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130613] Libre Writer problem either with layout or with autokey
https://bugs.documentfoundation.org/show_bug.cgi?id=130613 Dieter changed: What|Removed |Added Component|Writer |Installation CC||dgp-m...@gmx.de -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130614] Crash in: SfxItemPool::IsInRange(unsigned short)
https://bugs.documentfoundation.org/show_bug.cgi?id=130614 Xisco Faulí changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125520] EDITING: Calc: Error when dragging and dropping OLE objects with 'Insert as Copy'
https://bugs.documentfoundation.org/show_bug.cgi?id=125520 Xisco Faulí changed: What|Removed |Added Whiteboard|target:6.4.0 target:7.0.0 | |target:6.4.2| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125520] EDITING: Calc: Error when dragging and dropping OLE objects with 'Insert as Copy'
https://bugs.documentfoundation.org/show_bug.cgi?id=125520 --- Comment #11 from Commit Notification --- Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as Copy'" It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130614] Crash in: SfxItemPool::IsInRange(unsigned short)
https://bugs.documentfoundation.org/show_bug.cgi?id=130614 --- Comment #10 from Commit Notification --- Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as Copy'" It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125520] EDITING: Calc: Error when dragging and dropping OLE objects with 'Insert as Copy'
https://bugs.documentfoundation.org/show_bug.cgi?id=125520 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0 target:7.0.0 |target:6.4.0 target:7.0.0 ||target:6.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - svx/source
svx/source/svdraw/svdxcgv.cxx | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
New commits:
commit d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f
Author: Xisco Faulí
AuthorDate: Wed Feb 12 11:51:34 2020 +0100
Commit: Xisco Faulí
CommitDate: Thu Feb 13 07:41:21 2020 +0100
tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as
Copy'"
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371.
Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 09e6824bc868990095233825c415556399dd0652)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88500
Reviewed-by: Xisco Faulí
diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index f18d536b7bf2..8fcd742ec71f 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -744,17 +744,8 @@ std::unique_ptr
SdrExchangeView::CreateMarkedObjModel() const
if(nullptr == pNewObj)
{
-// not cloned yet
-if (pObj->GetObjIdentifier() == OBJ_OLE2)
-{
-// tdf#125520
-pNewObj =
pObj->CloneSdrObject(pObj->getSdrModelFromSdrObject());
-}
-else
-{
-// use default way
-pNewObj = pObj->CloneSdrObject(*pNewModel);
-}
+// not cloned yet, use default way
+pNewObj = pObj->CloneSdrObject(*pNewModel);
}
if(pNewObj)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130614] Crash in: SfxItemPool::IsInRange(unsigned short)
https://bugs.documentfoundation.org/show_bug.cgi?id=130614 Commit Notification changed: What|Removed |Added Whiteboard|target:7.0.0|target:7.0.0 target:6.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124443] AutoInput tooltip positioning is inconsistent when editing formula, covering different parts of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=124443 Ayhan Yalçınsoy changed: What|Removed |Added Assignee|ayhanyalcin...@pisilinux.or |libreoffice-b...@lists.free |g |desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124443] AutoInput tooltip positioning is inconsistent when editing formula, covering different parts of UI
https://bugs.documentfoundation.org/show_bug.cgi?id=124443 Ayhan Yalçınsoy changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/baside2.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit d75781dcd619a747b17b6c897ba44dc6ff8b5c7e
Author: Andreas Heinisch
AuthorDate: Wed Feb 12 22:48:45 2020 +0100
Commit: Noel Grandin
CommitDate: Thu Feb 13 07:20:20 2020 +0100
tdf#57307 - Expand word boundaries to include connector punctuations
Include connector punctuations when adding a variable to the watch
window using "Enable Watch (F7)" in order to add the correct variable name.
Change-Id: Idaf7699dde3f4147d603c6aea4b2381e2af497a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88575
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/basctl/source/basicide/baside2.cxx
b/basctl/source/basicide/baside2.cxx
index 5d3bb561b275..85db57dfbfdd 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -695,14 +695,11 @@ void ModulWindow::BasicAddWatch()
bool bAdd = true;
if ( !GetEditView()->HasSelection() )
{
-TextPaM aWordStart;
-OUString aWord = GetEditEngine()->GetWord(
GetEditView()->GetSelection().GetEnd(), );
+// tdf#57307 - expand selection to include connector punctuations
+TextSelection aSel;
+OUString aWord = GetEditEngine()->GetWord(
GetEditView()->GetSelection().GetEnd(), (), () );
if ( !aWord.isEmpty() )
-{
-TextSelection aSel( aWordStart );
-aSel.GetEnd().GetIndex() += aWord.getLength();
GetEditView()->SetSelection( aSel );
-}
else
bAdd = false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabvwsh2.cxx | 12
1 file changed, 12 insertions(+)
New commits:
commit 7a27ac1060fcf8a6bbf9e03ad1457633dcd1ad06
Author: Muhammet Kara
AuthorDate: Wed Feb 12 05:42:11 2020 +0300
Commit: Andras Timar
CommitDate: Thu Feb 13 06:56:01 2020 +0100
mobile: Center inserted shapes on visible area
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488
Tested-by: Jenkins
Reviewed-by: Andras Timar
diff --git a/sc/source/ui/view/tabvwsh2.cxx b/sc/source/ui/view/tabvwsh2.cxx
index 117edd72493d..da77a4278655 100644
--- a/sc/source/ui/view/tabvwsh2.cxx
+++ b/sc/source/ui/view/tabvwsh2.cxx
@@ -19,6 +19,7 @@
#include
#include
+#include
#include
#include
#include
@@ -320,6 +321,7 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq)
// calc position and size
bool bLOKIsActive = comphelper::LibreOfficeKit::isActive();
+bool bIsMobile =
comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView());
Point aInsertPos;
if(!bLOKIsActive)
{
@@ -328,6 +330,16 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq)
aInsertPos.AdjustX( -sal_Int32(nDefaultObjectSizeWidth / 2) );
aInsertPos.AdjustY( -sal_Int32(nDefaultObjectSizeHeight / 2) );
}
+else if (bIsMobile)
+{
+aInsertPos = GetViewData().getLOKVisibleArea().Center();
+
+aInsertPos.setX(sc::TwipsToHMM(aInsertPos.X()));
+aInsertPos.setY(sc::TwipsToHMM(aInsertPos.Y()));
+
+aInsertPos.AdjustX( -sal_Int32(nDefaultObjectSizeWidth / 2) );
+aInsertPos.AdjustY( -sal_Int32(nDefaultObjectSizeHeight / 2) );
+}
else
{
aInsertPos = GetInsertPos();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - configure.ac
configure.ac |1 + 1 file changed, 1 insertion(+) New commits: commit 302ddf9f9ccca2e1583d09e2588e9c9c9d30b976 Author: Jan Holesovsky AuthorDate: Tue Feb 11 23:55:52 2020 +0100 Commit: Jan Holesovsky CommitDate: Thu Feb 13 06:53:00 2020 +0100 If asked to do so, enable icecream even in the 'build' part of configure. Otherwise it is used only in the 'host' part of the cross-compile build. Change-Id: Ifb8d88e18c131e3019a4f3168afc1b743f3cc8e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88483 Tested-by: Jenkins CollaboraOffice Reviewed-by: Jan Holesovsky diff --git a/configure.ac b/configure.ac index 0d00032d3210..e0a3bca717fe 100644 --- a/configure.ac +++ b/configure.ac @@ -4597,6 +4597,7 @@ if test "$cross_compiling" = "yes"; then --disable-gtk3 \ --disable-pdfimport \ --disable-postgresql-sdbc \ +--enable-icecream="$enable_icecream" \ --with-parallelism="$with_parallelism" \ --without-doxygen \ --without-java \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127833] Field shading in comments not properly refreshed
https://bugs.documentfoundation.org/show_bug.cgi?id=127833 --- Comment #4 from Lukeoss --- Field shading in comments not properly refreshed. When you select https://www.bestessays.com.au/nursing-assignment-help.php from these mention fields then you are waiting to get comments on these properly refreshed which showing them proper work from those things to be refreshed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js |1 +
1 file changed, 1 insertion(+)
New commits:
commit 1bc10345432aa1858867228ecb57b46c1ccbde1c
Author: Michael Meeks
AuthorDate: Thu Feb 13 04:25:36 2020 +
Commit: Ashod Nakashian
CommitDate: Thu Feb 13 06:07:14 2020 +0100
Avoid exception dragging during shutdown.
Really TileLayer.js should have a clean on remove that dis-connects
from drag, resize etc. but it doesn't yet.
Change-Id: Ia2c2268875187a2f1115b7d357fd56ab825bb77f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88578
Reviewed-by: Michael Meeks
Tested-by: Ashod Nakashian
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index a69741462..9a9d7f004 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -446,6 +446,7 @@ L.GridLayer = L.Layer.extend({
},
_updateScrollOffset: function () {
+ if (!this._map) return;
var centerPixel = this._map.project(this._map.getCenter());
var newScrollPos =
centerPixel.subtract(this._map.getSize().divideBy(2));
var x = Math.round(newScrollPos.x < 0 ? 0 : newScrollPos.x);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130630] Calc seems to not be able to handle percentages in cell when linking
https://bugs.documentfoundation.org/show_bug.cgi?id=130630 Casey Goodwin changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130630] New: Calc seems to not be able to handle percentages in cell when linking
https://bugs.documentfoundation.org/show_bug.cgi?id=130630 Bug ID: 130630 Summary: Calc seems to not be able to handle percentages in cell when linking Product: LibreOffice Version: 6.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: casey360...@gmail.com When performing an equation that deals with a percentage, say figuring local sales tax into a grocery list, Calc mis-handles the equation. For example, if C14 has a total of 449.98, cell A18 has the tax rate of 10.10%, and cell D14 has the equation "=C14*B18" the total amount of tax owed is displayed. If you then try to add the values of D14 and C14 using the equation "=C14+D14" the cell displays "49542.80%". I copied this exact spreadsheet into my wifes copy of Microsoft Office 365 Student Excel and it displayed the proper value of D14+C14 in the cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/ImpressTileLayer.js |1 +
loleaflet/src/layer/tile/TileLayer.js|2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 2adc32fab52944da935a226269c67dbf98654319
Author: Michael Meeks
AuthorDate: Thu Feb 13 02:55:50 2020 +
Commit: Ashod Nakashian
CommitDate: Thu Feb 13 04:48:44 2020 +0100
impress: cleanup preview invalidator & avoid null this._map on close.
Change-Id: I96f9cb217c6a479dfee91dc471ab442cd2d014ae
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88576
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Ashod Nakashian
diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js
b/loleaflet/src/layer/tile/ImpressTileLayer.js
index 568796e47..3938a973a 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -279,6 +279,7 @@ L.ImpressTileLayer = L.TileLayer.extend({
onRemove: function (map) {
map.off('updatemaxbounds', this._onUpdateMaxBounds, this);
+ clearTimeout(this._previewInvalidator);
},
onAnnotationCancel: function () {
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 46bd3c0a7..7be34c242 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -3161,7 +3161,7 @@ L.TileLayer = L.GridLayer.extend({
},
_invalidatePreviews: function () {
- if (this._map._docPreviews && this._previewInvalidations.length
> 0) {
+ if (this._map && this._map._docPreviews &&
this._previewInvalidations.length > 0) {
var toInvalidate = {};
for (var i = 0; i < this._previewInvalidations.length;
i++) {
var invalidBounds =
this._previewInvalidations[i];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130258] Sending a fax containing macros is impossible.
https://bugs.documentfoundation.org/show_bug.cgi?id=130258 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130527] Calc spoils xlsx file when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=130527 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124999] Notebook Bar sluggish when window is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=124999 --- Comment #5 from QA Administrators --- Dear Vrajaraja Govinda Das, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105777] Pasting image in Calc: wrong placement when there's previous image overlapping currently selected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=105777 --- Comment #4 from QA Administrators --- Dear andy-scull, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70975] Support for (Markdown and) reStructuredText RST
https://bugs.documentfoundation.org/show_bug.cgi?id=70975 Ming Hua changed: What|Removed |Added URL|https://nailcaresolution.co | |m/best-nail-buffer/ | Version|1.0.5 |unspecified Product|Impress Remote |LibreOffice Component|General |Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract138c' - 9 commits - comphelper/Library_comphelper.mk comphelper/source configmgr/README.vars configmgr/source configure.ac desktop/source ex
Rebased ref, commits from common ancestor:
commit 47578e07235673d6b05cf1b71602dcddc51d60d2
Author: Samuel Mehrbrodt
AuthorDate: Thu Jan 23 14:05:33 2020 +0100
Commit: Thorsten Behrens
CommitDate: Thu Feb 13 02:12:09 2020 +0100
Release 6.2.9.2
Change-Id: I881936cd6d8192e392420f58070def4834d60ec3
diff --git a/configure.ac b/configure.ac
index a6c7f84e13e9..6d962c3acddf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([LibreOffice],[6.2.9.1],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.2.9.2],[],[],[http://documentfoundation.org/])
AC_PREREQ([2.59])
commit a1a15546c2c0df4d0ae202eb3628a522b5cdd133
Author: Mike Kaganski
AuthorDate: Thu Jan 23 12:56:00 2020 +0300
Commit: Thorsten Behrens
CommitDate: Thu Feb 13 02:12:09 2020 +0100
Logger should be initialized with local context
... otherwise its output will go to connected soffice, and will not
reach the unopkg console, e.g. trying to execute
unopkg add wrong_extension_name
while an instance of soffice is running.
Change-Id: Ic0b0c48f9b3e8be084e0fdd1838cb0614da6817e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87248
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
(cherry picked from commit 5fe5c3a3f485f925a327cdc7b95c8691f6078608)
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index e7f7c0c26938..72c5ff315b4b 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -313,13 +313,13 @@ extern "C" int unopkg_main()
// Initialize logging. This will log errors to the console and
// also to file if the --log-file parameter was provided.
-logger.reset(new comphelper::EventLogger(xComponentContext, "unopkg"));
+logger.reset(new comphelper::EventLogger(xLocalComponentContext,
"unopkg"));
const Reference xLogger(logger->getLogger());
xLogger->setLevel(LogLevel::WARNING);
-Reference
xLogFormatter(SimpleTextFormatter::create(xComponentContext));
+Reference
xLogFormatter(SimpleTextFormatter::create(xLocalComponentContext));
Sequence < beans::NamedValue > aSeq { { "Formatter",
Any(xLogFormatter) } };
-
xConsoleHandler.set(ConsoleHandler::createWithSettings(xComponentContext,
aSeq));
+
xConsoleHandler.set(ConsoleHandler::createWithSettings(xLocalComponentContext,
aSeq));
xLogger->addLogHandler(xConsoleHandler);
xConsoleHandler->setLevel(LogLevel::WARNING);
xLogger->setLevel(LogLevel::WARNING);
@@ -328,7 +328,7 @@ extern "C" int unopkg_main()
if (!logFile.isEmpty())
{
Sequence < beans::NamedValue > aSeq2 { { "Formatter",
Any(xLogFormatter) }, {"FileURL", Any(logFile)} };
-
xFileHandler.set(css::logging::FileHandler::createWithSettings(xComponentContext,
aSeq2));
+
xFileHandler.set(css::logging::FileHandler::createWithSettings(xLocalComponentContext,
aSeq2));
xFileHandler->setLevel(LogLevel::WARNING);
xLogger->addLogHandler(xFileHandler);
}
commit b3d2369fbc3e173e2ce1ed89a87d136da6fe4236
Author: Samuel Mehrbrodt
AuthorDate: Mon Jan 20 11:12:12 2020 +0100
Commit: Thorsten Behrens
CommitDate: Thu Feb 13 02:12:09 2020 +0100
tdf#129917 Use temp user profile when installing shared extensions
Change-Id: I62dd163758e6348a62fc8a0b25150a62f282de90
diff --git a/configmgr/README.vars b/configmgr/README.vars
new file mode 100644
index ..d4ebae297e1b
--- /dev/null
+++ b/configmgr/README.vars
@@ -0,0 +1,3 @@
+Environment variables in configmgr:
+
+LO_NO_REGISTRYMODIFICATIONS - Don't write registrymodifications.xcu
diff --git a/configmgr/source/writemodfile.cxx
b/configmgr/source/writemodfile.cxx
index b3592bb1a8af..e6f76b582985 100644
--- a/configmgr/source/writemodfile.cxx
+++ b/configmgr/source/writemodfile.cxx
@@ -31,6 +31,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -563,6 +564,9 @@ void writeValueContent(TempFile ,
o3tl::u16string_view value) {
void writeModFile(
Components & components, OUString const & url, Data const & data)
{
+OUString sTokenOut;
+if (rtl::Bootstrap::get("LO_NO_REGISTRYMODIFICATIONS", sTokenOut))
+return;
sal_Int32 i = url.lastIndexOf('/');
assert(i != -1);
OUString dir(url.copy(0, i));
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index 045ee94ec7ef..e7f7c0c26938 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -31,6 +31,7 @@
#include
[Libreoffice-commits] online.git: wsd/DocumentBroker.hpp
wsd/DocumentBroker.hpp | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
New commits:
commit faee2bdb24bcc77b879e5b9329889209c113f4a1
Author: Michael Meeks
AuthorDate: Thu Feb 13 00:23:43 2020 +
Commit: Michael Meeks
CommitDate: Thu Feb 13 00:33:05 2020 +
Revert "Fix removal of kit procs when they are blocked"
This reverts commit 3046c5748bb54b16738aa5a7ee5e90b9420d68ac.
This breaks mobile apps for now. Apparently the 'close'
forces a different ordering than expected on the Child.
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 8b2b42551..890e89e38 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -119,23 +119,14 @@ public:
// Shutdown the socket.
if (_ws)
-{
_ws->shutdown();
-// If socket was shutdown and buffers cleared then there's no
-// reason to keep the object. This is crucial for
DocumentBroker
-// to be considered as not alive and associated kit process
-// terminated in cleanupDocBrokers. Otherwise if kit process
-// hangs then the asociated DocumentBroker object won't be
-// removed and kit process won't be forcefully terminated. This
-// is in conjunction with not clearing _pid data member which
-// is needed later in call to terminate().
-_ws.reset();
-}
}
catch (const std::exception& ex)
{
LOG_ERR("Error while closing child process: " << ex.what());
}
+
+_pid = -1;
}
/// Kill or abandon the child.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130625] EDITING: Find/Replace in array formula not working
https://bugs.documentfoundation.org/show_bug.cgi?id=130625 --- Comment #3 from Steve Edmonds --- This arose when importing an XLSX sheet and finding import of standard MS named ranges is not supported. (bug 130577) Finding now that Edit>Find & Replace does not work for array formulae means simply renaming the violating named ranges is not a viable workaround for the bug 130577. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130617] Screenshot for Options - LibreOffice - General shows %PRODUCTNAME
https://bugs.documentfoundation.org/show_bug.cgi?id=130617 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Olivier Hallot --- Known problem, I need to find a way to pass the real value to the screenshot makefile. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130599] Help content XSLT: add ability to override headings when embedding sections
https://bugs.documentfoundation.org/show_bug.cgi?id=130599 --- Comment #2 from Olivier Hallot --- It is also perfectly possible to add a new (optional) attribute to the tag in the DTD and set the desired heading level of the target, and adapt in the XSLT. Fact is that headings can come in either format or . Proper handling of the new attribute in XLST is not too complex. It will be written in the pieces where mode="emnbedded". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130620] Add help about "Windows Default Apps" button in Tools - Options - LibreOffice - General
https://bugs.documentfoundation.org/show_bug.cgi?id=130620 sdc.bla...@youmail.dk changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130599] Help content XSLT: add ability to override headings when embedding sections
https://bugs.documentfoundation.org/show_bug.cgi?id=130599 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Olivier Hallot --- There is a alternate solution to set the desired heading level in embedded headings: use and https://wiki.documentfoundation.org/Documentation/Understanding,_Authoring_and_Editing_Openoffice.org_Help/3#embedvar https://wiki.documentfoundation.org/Documentation/Understanding,_Authoring_and_Editing_Openoffice.org_Help/3#variable Take the case of https://help.libreoffice.org/7.0/en-US/text/swriter/main0102.html the source of the heading "Undo" is Looking at the href= contents, we have Can this removed? undoing;editing editing;undoing Undo Reverses the last command or the last entry you typed. To select the command that you want to reverse, click the arrow next to the Undo icon on the Standard bar. We are interested in Undo which we wrap in a Undo In the Menu help page, replace by The paragraph that follows the heading shall also be wraped in the same scheme. There will be a significant rework for the menus description, though. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70975] Support for (Markdown and) reStructuredText RST
https://bugs.documentfoundation.org/show_bug.cgi?id=70975 sam sammy changed: What|Removed |Added URL||https://nailcaresolution.co ||m/best-nail-buffer/ --- Comment #19 from sam sammy --- Thanks for this blog post, I really like the way you described this article. best nail buffer block https://nailcaresolution.com/best-nail-buffer/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44462] Provide a proper 'File Association Manager' for the windows version of Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=44462 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0620 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130620] Add help about "Windows Default Apps" button in Tools - Options - LibreOffice - General
https://bugs.documentfoundation.org/show_bug.cgi?id=130620 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=44 ||462 Summary|What is the "Windows|Add help about "Windows |Default Apps" button in |Default Apps" button in |Tools - Options - |Tools - Options - |LibreOffice - General |LibreOffice - General |supposed to do? | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86190] use GLM library instead of basegfx
https://bugs.documentfoundation.org/show_bug.cgi?id=86190 Thorsten Behrens (CIB) changed: What|Removed |Added Keywords|difficultyBeginner, | |easyHack, skillCpp, | |topicCleanup| CC||t...@libreoffice.org --- Comment #6 from Thorsten Behrens (CIB) --- Not as clearly defined as we would expect these days -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Makefile.am test/httpwstest.cpp
Makefile.am |2 +- test/httpwstest.cpp |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) New commits: commit 4fc7bc76dbe9ad4845cdeb5377e57c212cfb5acd Author: Tamás Zolnai AuthorDate: Wed Feb 12 19:17:13 2020 +0100 Commit: Tamás Zolnai CommitDate: Wed Feb 12 22:46:34 2020 +0100 tests: Change the order of cypress-test and other tests. So we can see how stable the cypress tests are. Now other unit tests under tests folder are failing randomly, so it's hard to monitor the cypress tests. Enable one unstable unit test, which was disabled for the same reason. Change-Id: Ib1646de1647c9a2bdb769bbb6b92a5794dd7a598 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88559 Tested-by: Tamás Zolnai Reviewed-by: Tamás Zolnai diff --git a/Makefile.am b/Makefile.am index c6d417185..d064de9c2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -14,7 +14,7 @@ endif else -SUBDIRS = . test loleaflet cypress_test +SUBDIRS = . loleaflet cypress_test test export ENABLE_DEBUG diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp index 4a2ea298b..3f90fabca 100644 --- a/test/httpwstest.cpp +++ b/test/httpwstest.cpp @@ -41,8 +41,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture CPPUNIT_TEST(testSaveOnDisconnect); CPPUNIT_TEST(testSavePassiveOnDisconnect); -// This test is failing -//CPPUNIT_TEST(testReloadWhileDisconnecting); +CPPUNIT_TEST(testReloadWhileDisconnecting); CPPUNIT_TEST(testInactiveClient); CPPUNIT_TEST(testViewInfoMsg); CPPUNIT_TEST(testUndoConflict); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130628] Uninstalling LibreOffice requires Windows Explorer to close
https://bugs.documentfoundation.org/show_bug.cgi?id=130628 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Please read that it can be done restarting the computer. Maybe there is some file used for both app that needs some action. And as I know, windows explorer restart itself after being closed. BTW you can restart default values for LibreOffice on Menu/Help/Restart on Safe Mode, with a clean profile. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130614] Crash in: SfxItemPool::IsInRange(unsigned short)
https://bugs.documentfoundation.org/show_bug.cgi?id=130614 --- Comment #9 from Commit Notification --- Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09e6824bc868990095233825c415556399dd0652 tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as Copy'" It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125520] EDITING: Calc: Error when dragging and dropping OLE objects with 'Insert as Copy'
https://bugs.documentfoundation.org/show_bug.cgi?id=125520 --- Comment #10 from Commit Notification --- Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/09e6824bc868990095233825c415556399dd0652 tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as Copy'" It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125520] EDITING: Calc: Error when dragging and dropping OLE objects with 'Insert as Copy'
https://bugs.documentfoundation.org/show_bug.cgi?id=125520 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:7.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130614] Crash in: SfxItemPool::IsInRange(unsigned short)
https://bugs.documentfoundation.org/show_bug.cgi?id=130614 Commit Notification changed: What|Removed |Added Whiteboard||target:7.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdxcgv.cxx | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
New commits:
commit 09e6824bc868990095233825c415556399dd0652
Author: Xisco Faulí
AuthorDate: Wed Feb 12 11:51:34 2020 +0100
Commit: Thorsten Behrens
CommitDate: Wed Feb 12 22:28:22 2020 +0100
tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as
Copy'"
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371.
Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index 827b0720b69d..f55e964a6223 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -744,17 +744,8 @@ std::unique_ptr
SdrExchangeView::CreateMarkedObjModel() const
if(nullptr == pNewObj)
{
-// not cloned yet
-if (pObj->GetObjIdentifier() == OBJ_OLE2)
-{
-// tdf#125520
-pNewObj =
pObj->CloneSdrObject(pObj->getSdrModelFromSdrObject());
-}
-else
-{
-// use default way
-pNewObj = pObj->CloneSdrObject(*pNewModel);
-}
+// not cloned yet, use default way
+pNewObj = pObj->CloneSdrObject(*pNewModel);
}
if(pNewObj)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130625] EDITING: Find/Replace in array formula not working
https://bugs.documentfoundation.org/show_bug.cgi?id=130625 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- It is so, but I don't if it is a limitation or it is by purpose, because changes in arrays could imply e.g. change the range on where the array extends, and I don't know if it is possible or affordable on the fly while replacing. Let's see if same dev can bring light on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf130610_bold_in_2_styles.ott |binary
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 29
sw/source/filter/ww8/wrtw8nds.cxx| 65 +++
sw/source/filter/ww8/wrtww8.hxx |2
4 files changed, 96 insertions(+)
New commits:
commit 0c6ef9ba325fc37f325a2848e013852d2780a5ca
Author: Serge Krot
AuthorDate: Tue Feb 11 16:04:26 2020 +0100
Commit: Thorsten Behrens
CommitDate: Wed Feb 12 22:24:19 2020 +0100
tdf#130610 docx export: handle bold as toggle properties
Change-Id: I4c60b7eab6430a64ea1c8bcf40d0036d0b38516f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88460
Reviewed-by: Michael Stahl
Tested-by: Jenkins
diff --git a/sw/qa/extras/ooxmlexport/data/tdf130610_bold_in_2_styles.ott
b/sw/qa/extras/ooxmlexport/data/tdf130610_bold_in_2_styles.ott
new file mode 100755
index ..35937d9a8aa3
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf130610_bold_in_2_styles.ott differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 3bdae52c4d65..9fce4ad0e091 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -107,6 +108,34 @@ DECLARE_OOXMLEXPORT_TEST(testTdf87569d,
"tdf87569_drawingml.docx")
text::RelOrientation::FRAME, nValue);
}
+DECLARE_OOXMLEXPORT_TEST(testTdf130610, "tdf130610_bold_in_2_styles.ott")
+{
+// check character properties
+{
+uno::Reference xStyle(
+getStyles("CharacterStyles")->getByName("WollMuxRoemischeZiffer"),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Bold", awt::FontWeight::BOLD,
getProperty(xStyle, "CharWeight"));
+}
+
+// check paragraph properties
+{
+uno::Reference xStyle(
+getStyles("ParagraphStyles")->getByName("WollMuxVerfuegungspunkt"),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Bold", awt::FontWeight::BOLD,
getProperty(xStyle, "CharWeight"));
+}
+
+// check inline text properties
+{
+xmlDocPtr pXmlDoc =parseExport("word/document.xml");
+if (pXmlDoc)
+{
+assertXPath(pXmlDoc, "/w:document/w:body/w:p[2]/w:r/w:rPr/w:b");
+}
+}
+}
+
DECLARE_OOXMLEXPORT_TEST(testTdf120315, "tdf120315.docx")
{
// tdf#120315 cells of the second column weren't vertically merged
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx
b/sw/source/filter/ww8/wrtw8nds.cxx
index d06072c6de5a..70a855efc7ed 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -39,6 +39,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -466,6 +467,12 @@ void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool
bWriteCombChars)
if ( pCharFormatItem )
ClearOverridesFromSet( *pCharFormatItem, aExportSet );
+// check toggle properties in DOCX output
+{
+SvxWeightItem aBoldProperty(WEIGHT_BOLD, RES_CHRATR_WEIGHT);
+handleToggleProperty(aExportSet, pCharFormatItem, RES_CHRATR_WEIGHT,
);
+}
+
// tdf#113790: AutoFormat style overwrites char style, so remove all
// elements from CHARFMT grab bag which are set in AUTOFMT grab bag
if (const SfxGrabBagItem *pAutoFmtGrabBag = dynamic_cast(pGrabBag))
@@ -528,6 +535,64 @@ void SwWW8AttrIter::OutAttr( sal_Int32 nSwPos, bool
bWriteCombChars)
m_rExport.AttrOutput().OutputItem( *pGrabBag );
}
+// Toggle Properties
+//
+// If the value of the toggle property appears at multiple levels of the style
hierarchy (17.7.2), their
+// effective values shall be combined as follows:
+//
+// value_{effective} = val_{table} XOR val_{paragraph} XOR val_{character}
+//
+// If the value specified by the document defaults is true, the effective
value is true.
+// Otherwise, the values are combined by a Boolean XOR as follows:
+// i.e., the effective value to be applied to the content shall be true if its
effective value is true for
+// an odd number of levels of the style hierarchy.
+//
+// To prevent such logic inside output, it is required to write inline w:b
token on content level.
+void SwWW8AttrIter::handleToggleProperty(SfxItemSet& rExportSet, const
SwFormatCharFormat* pCharFormatItem,
+sal_uInt16 nWhich, const SfxPoolItem* pValue)
+{
+if (!rExportSet.HasItem(nWhich) && pValue)
+{
+bool hasPropertyInCharStyle = false;
+bool hasPropertyInParaStyle = false;
+
+// get bold flag from specified character style
+if (pCharFormatItem)
+{
+if (const SwCharFormat* pCharFormat =
pCharFormatItem->GetCharFormat())
+{
+const SfxPoolItem* pItem = nullptr;
+if
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - include/svx sw/qa sw/source
include/svx/sdtacitm.hxx|2 +-
sw/qa/core/data/html/pass/ofz20455.html |binary
sw/source/filter/html/htmlcss1.cxx | 18 +-
sw/source/filter/html/swcss1.hxx|5 -
sw/source/filter/html/swhtml.cxx|2 +-
sw/source/filter/html/swhtml.hxx|2 ++
6 files changed, 21 insertions(+), 8 deletions(-)
New commits:
commit c9605cc66bcc655f3d7c8f3264efa691de42aed5
Author: Caolán McNamara
AuthorDate: Mon Feb 3 12:06:23 2020 +
Commit: Thorsten Behrens
CommitDate: Wed Feb 12 22:23:02 2020 +0100
ofz#20455 sw: HTML import: fix invalid table in footer
The obvious problem was that a bookmark failed to be copied to the
correct node, it was created on a SwStartNode, which failed in
makeMark() and caused a null-pointer.
The target position was off by 1 node because there was a spurious
StartNode/EndNode pair directly below the table:
[ 41] 0x5b13430 TableNode ,
[ 42]0x5b1d010 StartNode ,
[ 43] 0x5b12a50StartNode ,
[ 44] 0x5b135f0TextNode "",
This was created by a special case in SwTableNode::MakeCopy() because
.GetTabSortBoxes().size() == 1.
But the table had actually quite a bunch more cells in the nodes-array,
just they were not yet in the SwTable.
In an exciting twist of events, it turns out the table was copied while
it was not yet finished parsing: the problem was that in the middle of
the table, some CSS set some page attributes, and this caused a
first-page page style to be created in SwCSS1Parser::ParseStyleSheet(),
by copying the master page style.
Unfortunately the table was in the , so it was
copied in this incomplete and inconsistent state.
It might be possible to get rid of the special case in
SwTableNode::MakeCopy() by restricting the special case skipping of
StartNodes at the start in SwNodes::CopyNodes() a bit so that StartNodes
whose EndNodes are copied aren't skipped; at least that's the most
reasonable explanation for the special case.
But for now just fix the HTML import.
Additionally, only on MacOSX, using libc++, this triggered an assert:
Assertion failed: (!pImpl->mpStaticDefaults || typeid(rItem) ==
typeid(GetDefaultItem(nWhich))), function PutImpl, file
/Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/svl/source/items/itempool.cxx,
line 611.
Probably because SdrTextAniCountItem is not marked DLLPUBLIC.
Change-Id: Ia167265e7540eea649801eaac2b89f9e18b685cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87859
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 086e43148059a7ebc6caa416fa82bb60fd2cc92f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88494
Reviewed-by: Thorsten Behrens
diff --git a/include/svx/sdtacitm.hxx b/include/svx/sdtacitm.hxx
index bf145c8b6b6c..f34e5589ed53 100644
--- a/include/svx/sdtacitm.hxx
+++ b/include/svx/sdtacitm.hxx
@@ -23,7 +23,7 @@
#include
// Number of loops. 0=infinite.
-class SdrTextAniCountItem final : public SfxUInt16Item {
+class SAL_DLLPUBLIC_RTTI SdrTextAniCountItem final : public SfxUInt16Item {
public:
SdrTextAniCountItem(sal_uInt16 nVal=0):
SfxUInt16Item(SDRATTR_TEXT_ANICOUNT,nVal) {}
diff --git a/sw/qa/core/data/html/pass/ofz20455.html
b/sw/qa/core/data/html/pass/ofz20455.html
new file mode 100644
index ..6e5ca0aa7e85
Binary files /dev/null and b/sw/qa/core/data/html/pass/ofz20455.html differ
diff --git a/sw/source/filter/html/htmlcss1.cxx
b/sw/source/filter/html/htmlcss1.cxx
index e7a1827543a6..4f8d8bbe7d03 100644
--- a/sw/source/filter/html/htmlcss1.cxx
+++ b/sw/source/filter/html/htmlcss1.cxx
@@ -90,11 +90,13 @@ void SwCSS1Parser::ChgPageDesc( const SwPageDesc *pPageDesc,
m_pDoc->ChgPageDesc( pos, rNewPageDesc );
}
-SwCSS1Parser::SwCSS1Parser( SwDoc *pD, const sal_uInt32 aFHeights[7], const
OUString& rBaseURL, bool bNewDoc ) :
-SvxCSS1Parser( pD->GetAttrPool(), rBaseURL,
- aItemIds, SAL_N_ELEMENTS(aItemIds)),
-m_pDoc( pD ),
-m_nDropCapCnt( 0 ),
+SwCSS1Parser::SwCSS1Parser(SwDoc *const pDoc, SwHTMLParser const& rParser,
+const sal_uInt32 aFHeights[7], const OUString& rBaseURL, bool const
bNewDoc)
+: SvxCSS1Parser(pDoc->GetAttrPool(), rBaseURL,
+ aItemIds, SAL_N_ELEMENTS(aItemIds))
+, m_pDoc( pDoc )
+, m_rHTMLParser(rParser)
+, m_nDropCapCnt( 0 ),
m_bIsNewDoc( bNewDoc ),
m_bBodyBGColorSet( false ),
m_bBodyBackgroundSet( false ),
@@ -1344,6 +1346,12 @@ const SwPageDesc *SwCSS1Parser::GetPageDesc( sal_uInt16
nPoolId, bool bCreate )
const SwPageDesc *pPageDesc = FindPageDesc(m_pDoc, nPoolId);
if( !pPageDesc && bCreate )
{
+if (m_rHTMLParser.IsReadingHeaderOrFooter())
+{ // (there should be
[Libreoffice-bugs] [Bug 130629] Crash in Writer when inserting shape again after undoing a previous insertion
https://bugs.documentfoundation.org/show_bug.cgi?id=130629 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
[Libreoffice-bugs] [Bug 130629] New: Crash in Writer when inserting shape again after undoing a previous insertion
https://bugs.documentfoundation.org/show_bug.cgi?id=130629 Bug ID: 130629 Summary: Crash in Writer when inserting shape again after undoing a previous insertion Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Keywords: haveBacktrace Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 105948, 108741 Created attachment 157831 --> https://bugs.documentfoundation.org/attachment.cgi?id=157831=edit Backtrace Crash only happens when the shape is inserted with the single click method, by Ctrl-clicking on the toolbar button. - Start a new document. - Add a shape by Ctrl-clicking on the basic shape icon on the toolbar. - Press undo until there are no more undo steps (takes 2 undos for some reason). - Click on the basic shape icon on the toolbar (this just unselects the button). - Ctrl-click on the basic shape icon on the toolbar. => Crash. Attaching backtrace. Observed using LO 7.0.0.0.alpha0+ (d41d7ecb60fb38204fafcb1aa4595992721855e6), 3.3.0 / Ubuntu. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Aron Budea changed: What|Removed |Added Depends on||130629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=130629 [Bug 130629] Crash in Writer when inserting shape again after undoing a previous insertion -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: android/lib
android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |6
++
1 file changed, 6 insertions(+)
New commits:
commit 9497681bd98d5cfc70a914e8e79e00a527813cdd
Author: Jan Holesovsky
AuthorDate: Wed Feb 12 21:49:17 2020 +0100
Commit: Jan Holesovsky
CommitDate: Wed Feb 12 21:52:55 2020 +0100
android: Avoid a WebView-related error in the log.
Namely "WebView.destroy() called while WebView is still attached to window".
Change-Id: I6963a553ac05af6426ffe3c054bdcff28a725e3b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88571
Tested-by: Jan Holesovsky
Reviewed-by: Jan Holesovsky
diff --git
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index a964ad392..90021f1c6 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -35,6 +35,7 @@ import android.provider.DocumentsContract;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
+import android.view.ViewGroup;
import android.view.WindowManager;
import android.webkit.JavascriptInterface;
import android.webkit.ValueCallback;
@@ -460,6 +461,11 @@ public class LOActivity extends AppCompatActivity {
super.onDestroy();
Log.i(TAG, "onDestroy() - we know we are leaving the document");
nativeLooper.quit();
+
+// Remove the webview from the hierarchy & destroy
+final ViewGroup viewGroup = (ViewGroup) mWebView.getParent();
+if (viewGroup != null)
+viewGroup.removeView(mWebView);
mWebView.destroy();
// Most probably the native part has already got a 'BYE' from
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130627] FORMATTING: LibreOffice Writer crash when trying to center a text in a text zone.
https://bugs.documentfoundation.org/show_bug.cgi?id=130627 --- Comment #2 from Ming Hua --- Sorry, bug 130286 is probably closer to what happened here. *** This bug has been marked as a duplicate of bug 130286 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130286] Crash in: SwDrawTextShell::Execute(SfxRequest &)
https://bugs.documentfoundation.org/show_bug.cgi?id=130286 Ming Hua changed: What|Removed |Added CC||trem...@gmail.com --- Comment #13 from Ming Hua --- *** Bug 130627 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130628] Uninstalling LibreOffice requires Windows Explorer to close
https://bugs.documentfoundation.org/show_bug.cgi?id=130628 --- Comment #1 from Jamie Dimmel --- Created attachment 157830 --> https://bugs.documentfoundation.org/attachment.cgi?id=157830=edit Screenshot of dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130627] FORMATTING: LibreOffice Writer crash when trying to center a text in a text zone.
https://bugs.documentfoundation.org/show_bug.cgi?id=130627 Ming Hua changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Ming Hua --- Thanks for reporting the bug. It seems what you've encountered is the same as bug 130482, and it has been fixed in the source code repository. A fixed version will be released for 6.4.2. I'm going to mark this bug as a DUPLICATE. If you think it's a different bug, just change the status back to UNCONFIRMED. *** This bug has been marked as a duplicate of bug 130482 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130628] New: Uninstalling LibreOffice requires Windows Explorer to close
https://bugs.documentfoundation.org/show_bug.cgi?id=130628 Bug ID: 130628 Summary: Uninstalling LibreOffice requires Windows Explorer to close Product: LibreOffice Version: 6.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jedim...@gmail.com Description: After having trouble with my install defaulting to A4 paper (even though everything points to US & Letter paper) I decided to try uninstalling completely and then reinstalling to fix the issue. That's when I got the prompt: "The following applications should be closed before continuing the installation: Windows Explorer". The default option was to "Automatically close applications and attempt to restart them after setup is complete". Note that this was not prompting for Internet Explorer, it was prompting for Windows Explorer, as in the very desktop itself. I can't see how this can be a good idea. If something goes wrong with the install, then you can't use Explorer to kill the program or restart or anything. And why does it need to close it? No other program I have ever installed has ever had to close Windows Explorer! Require a restart, yes; close Windows Explorer?, no. I don't know if a reinstall is going to fix the original issue, but if it doesn't I am certainly going to go back to an earlier version, as this is just crazy. Steps to Reproduce: 1.Close all programs (including web browser) except for Windows Explorer 2.Uninstall program 3.See prompt to close the app, and click Ok to close Actual Results: Closed all programs (including web browser), but left Windows Explorer open (both in separate windows, and of course, the desktop itself). When prompted I chose Ok, and Windows Explorer (both windows & desktop) closed, leaving a blank screen and the uninstall dialog. On finishing install it re-opened Windows Explorer. Expected Results: No prompt should have been given for Windows Explorer to close. If it needs to be restarted to accomplish the uninstall, then that should be required, but NOT restarting the very desktop shell. Reproducible: Always User Profile Reset: No Additional Info: Can't do that as I uninstalled the app. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 --- Comment #3 from Grey --- Gentlemen, first off, my apologies for the delay in responding. Rereading, don't see this as viable approach. Difficult to "integrate" whatever external libs are available by os/DE--and then issues for consistency cross platform. Which is a show-stopper. Okay. I leave the approach to whatever the developers deem best. All I know is that GIMP, Blender, Krita, Inkscape, Scribus, etc. all have a pipette/eyedropper tool. I don't presume to know how those applications have integrated said tool but it leads me to believe the problem is not surmountable nor novel technology. IMHO => WF Well, then...that settles that. Thanks for your time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126525] Use external color pickers as provided by os/DE, or other projects
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 --- Comment #3 from Grey --- Gentlemen, first off, my apologies for the delay in responding. Rereading, don't see this as viable approach. Difficult to "integrate" whatever external libs are available by os/DE--and then issues for consistency cross platform. Which is a show-stopper. Okay. I leave the approach to whatever the developers deem best. All I know is that GIMP, Blender, Krita, Inkscape, Scribus, etc. all have a pipette/eyedropper tool. I don't presume to know how those applications have integrated said tool but it leads me to believe the problem is not surmountable nor novel technology. IMHO => WF Well, then...that settles that. Thanks for your time. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/headless
vcl/headless/svpgdi.cxx | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
New commits:
commit 548a28b213e680a6ffd4c3822e97131a64311956
Author: Armin Le Grand
AuthorDate: Sat Feb 8 12:14:09 2020 +0100
Commit: Armin Le Grand
CommitDate: Wed Feb 12 21:38:28 2020 +0100
tdf#130478 add direct dash paint in cairo
Make use of mentioned task's 1st commit now
and implement direct dashing for cairo. All
the data is now available (that was the work),
make use of it.
Keeping a local static bool to control it, so
later if needed can be switched on/off e.g
using some global var/setting.
Cairo will now do buffering of complex polygon
data in cairo path data (from some compexity
on and timer/mem-controlled), but not dismantle
to own, stroked data.
With bDoDirectCairoStroke disabled, the dis-
mantled data will be buffered - more mem, but
should also help - at least it gets reused
now that it is possible to keep it at the
original geometry (incoming polygon) at all
Change-Id: Ic08f659d7ccbedc910ec678b1509ee1a7f3f2112
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88262
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88557
Tested-by: Jenkins CollaboraOffice
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 8dcdcc5df44c..bcfde817b604 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1305,7 +1305,16 @@ bool SvpSalGraphics::drawPolyLine(
const double fDotDashLength(nullptr != pStroke ?
std::accumulate(pStroke->begin(), pStroke->end(), 0.0) : 0.0);
const bool bStrokeUsed(0.0 != fDotDashLength);
-if(pSystemDependentData_CairoPath)
+// MM01 decide if to stroke direcly
+static bool bDoDirectCairoStroke(true);
+
+// MM01 activate to stroke direcly
+if(bDoDirectCairoStroke && bStrokeUsed)
+{
+cairo_set_dash(cr, pStroke->data(), pStroke->size(), 0.0);
+}
+
+if(!bDoDirectCairoStroke && pSystemDependentData_CairoPath)
{
// MM01 - check on stroke change. Used against not used, or if both
used,
// equal or different?
@@ -1347,7 +1356,7 @@ bool SvpSalGraphics::drawPolyLine(
// MM01 need to do line dashing as fallback stuff here now
basegfx::B2DPolyPolygon aPolyPolygonLine;
-if(bStrokeUsed)
+if(!bDoDirectCairoStroke && bStrokeUsed)
{
// apply LineStyle
basegfx::utils::applyLineDashing(
@@ -1359,7 +1368,7 @@ bool SvpSalGraphics::drawPolyLine(
}
else
{
-// no line dashing, just copy
+// no line dashing or direct stroke, just copy
aPolyPolygonLine.append(rPolyLine);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa writerfilter/qa writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport10.cxx|4 +-
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx|4 +-
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx |4 --
sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |2 -
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |2 -
writerfilter/qa/cppunittests/dmapper/GraphicImport.cxx| 17
++
writerfilter/qa/cppunittests/dmapper/data/inline-anchored-zorder.docx |binary
writerfilter/source/dmapper/GraphicImport.cxx | 11
+-
8 files changed, 33 insertions(+), 11 deletions(-)
New commits:
commit 99847d6b3005c5444ed5a46ca578c0e40149d77c
Author: Miklos Vajna
AuthorDate: Wed Feb 12 15:02:18 2020 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 12 21:34:28 2020 +0100
DOCX import: fix ZOrder of inline vs anchored shapes
Shapes which are anchored but are not in the background should be always
on top of as-char anchored shapes in OOXML terms. Writer supports a
custom ZOrder even for as-char shapes, so make sure that they are
always behind anchored shapes.
To avoid unnecessary work, make sure that when there are multiple inline
shapes, we don't pointlessly reorder them (the old vs new style of the
sorting controls exactly this, what happens when two shapes have the
same ZOrder, and all inline shapes have a 0 ZOrder).
Adapt a few tests that used ZOrder indexes to access shapes, but the
intention was to just refer to a shape: fix the index and migrate to
shape names where possible.
Change-Id: I670e4dc2acbd2a0c6d47fe964cb5e3f2300e6848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88540
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
index dca06548b815..6d11c3c12590 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
@@ -482,11 +482,11 @@ DECLARE_OOXMLEXPORT_TEST(testStrict, "strict.docx")
getParagraphOfText(1, xHeaderText, "This is a header.");
// Picture was missing.
-uno::Reference xServiceInfo(getShape(1),
uno::UNO_QUERY);
+uno::Reference xServiceInfo(getShapeByName("Picture
2"), uno::UNO_QUERY);
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextGraphicObject"));
// SmartArt was missing.
-xServiceInfo.set(getShape(2), uno::UNO_QUERY);
+xServiceInfo.set(getShape(1), uno::UNO_QUERY);
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.drawing.GroupShape"));
// Chart was missing.
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 27c66c141357..c3a8c4948397 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -484,10 +484,10 @@ DECLARE_OOXMLEXPORT_TEST(testTdf119201, "tdf119201.docx")
auto xShape(getShape(1));
CPPUNIT_ASSERT_MESSAGE("First shape should be visible.",
getProperty(xShape, "Visible"));
CPPUNIT_ASSERT_MESSAGE("First shape should be printable.",
getProperty(xShape, "Printable"));
-xShape = getShape(2);
+xShape = getShapeByName("Rectangle 1");
CPPUNIT_ASSERT_MESSAGE("Second shape should not be visible.",
!getProperty(xShape, "Visible"));
CPPUNIT_ASSERT_MESSAGE("Second shape should not be printable.",
!getProperty(xShape, "Printable"));
-xShape = getShape(3);
+xShape = getShapeByName("Oval 2");
CPPUNIT_ASSERT_MESSAGE("Third shape should be visible.",
getProperty(xShape, "Visible"));
CPPUNIT_ASSERT_MESSAGE("Third shape should be printable.",
getProperty(xShape, "Printable"));
}
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
index 05466e36b70f..998d7cd5b2d8 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
@@ -998,9 +998,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf102466, "tdf102466.docx")
// check content of the first page
{
-uno::Reference
xDrawPageSupplier(mxComponent, uno::UNO_QUERY);
-uno::Reference xIndexAccess =
xDrawPageSupplier->getDrawPage();
-uno::Reference
xFrame(xIndexAccess->getByIndex(0), uno::UNO_QUERY);
+uno::Reference xFrame(getShapeByName("Marco1"),
uno::UNO_QUERY);
// no border
CPPUNIT_ASSERT_EQUAL(sal_Int32(0), getProperty(xFrame,
"LineWidth"));
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
index 344b493dae4b..e057f4e1c856 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
@@ -564,7 +564,7 @@ DECLARE_OOXMLEXPORT_TEST(test76317, "test76317.docx")
DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(fdo76591,
[Libreoffice-bugs] [Bug 79721] writer slow on shapes, locks up if huge amount of shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=79721 karolbienkow...@protonmail.com changed: What|Removed |Added CC||karolbienkowski@protonmail. ||com --- Comment #40 from karolbienkow...@protonmail.com --- The bug still exists in 6.4 Version: 6.4.0.3 Build ID: 6.4.0-2 CPU threads: 4; OS:Linux 5.5; UI render:GL; VCL: kf5; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dochdl/swdtflvr.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 7155d0011ecde39c9ea27ef19d475686d80574ee Author: Dennis Francis AuthorDate: Fri Feb 7 12:08:21 2020 +0530 Commit: Andras Timar CommitDate: Wed Feb 12 21:27:58 2020 +0100 Classify shape(s) selections as 'complex'... in isComplex() of XTransferable2 implementation SwTransferable. This method is used by online via doc_getSelectionType() to determine the type of selection. In writer this method used to classify shape objects as non-complex which translates to 'text' in online, so if a shape is selected in online, the js code there would treat it as text. This is problematic when you want to send the correct align uno commands based on selection type. So returning true in isComplex() for writer would correctly treat the shape selections as 'complex' in online Writer. Change-Id: I09fcd9e4fab48aa0d7e7d04c88bae9e1281a1b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88158 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky (cherry picked from commit c7178a12e6e57e3d85cecd09e9c0373ececbb33f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88495 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx b/sw/source/uibase/dochdl/swdtflvr.cxx index a0230ef3630a..6dbb5c50046b 100644 --- a/sw/source/uibase/dochdl/swdtflvr.cxx +++ b/sw/source/uibase/dochdl/swdtflvr.cxx @@ -455,6 +455,9 @@ sal_Bool SAL_CALL SwTransferable::isComplex() } } +if (m_pWrtShell->GetSelectionType() == SelectionType::DrawObject) +return true; // Complex + // Simple return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/cursor.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit c70d31a274b9e7b47dbf6622c84a7a3431360b9e Author: Ashod Nakashian AuthorDate: Sun Feb 2 14:37:38 2020 -0500 Commit: Andras Timar CommitDate: Wed Feb 12 21:27:09 2020 +0100 vcl: avoid accessing null member on unloading views Change-Id: If4e416c7257c861b9e13352b3329d9719b159e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87830 Reviewed-by: Michael Meeks Tested-by: Aron Budea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88538 Tested-by: Jenkins diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx index 3b55bea61690..340fbb77d985 100644 --- a/vcl/source/window/cursor.cxx +++ b/vcl/source/window/cursor.cxx @@ -201,8 +201,9 @@ void vcl::Cursor::ImplDoShow( bool bDrawDirect, bool bRestore ) // show the cursor, if there is an active window and the cursor // has been selected in this window pWindow = Application::GetFocusWindow(); -if ( !pWindow || !pWindow->mpWindowImpl || (pWindow->mpWindowImpl->mpCursor != this) || pWindow->mpWindowImpl->mbInPaint -|| !pWindow->mpWindowImpl->mpFrameData->mbHasFocus ) +if (!pWindow || !pWindow->mpWindowImpl || (pWindow->mpWindowImpl->mpCursor != this) +|| pWindow->mpWindowImpl->mbInPaint +|| !pWindow->mpWindowImpl->mpFrameData->mbHasFocus) pWindow = nullptr; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: How to build only changed files
Hi, mohamed sameh schrieb am 12-Feb-20 um 20:46: Hello, I have a question. if I change one or more files and want to run 'make' to check that the project still builds, do I have to run a complete build everytime which takes a lot of time or is there a way to only build the affected files only ? Thanks If your change is only inside one module, you can use .build, e.g. make svx.build or in case of Windows /opt/lo/bin/make svx.build That is only while developing. When you think you are finished, then you need a complete build to be sure, that no unit tests are broken. Find more about it on https://wiki.documentfoundation.org/Development/GenericBuildingHints Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130623] Base: Empty Field Properties (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=130623 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125205] Spreadsheet cell Horizontal alignment (Left) indent is not saved/preserved round trip to OOXML
https://bugs.documentfoundation.org/show_bug.cgi?id=125205 --- Comment #4 from alexandrepe...@gmail.com --- The bug persists on 6.4.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: How to build only changed files
mohamed sameh kirjoitti 12.2.2020 klo 21.46: Hello, I have a question. if I change one or more files and want to run 'make' to check that the project still builds, do I have to run a complete build everytime which takes a lot of time or is there a way to only build the affected files only ? Make is smart enough that it will only compile what it needs to. Try it out. Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 --- Comment #17 from endo...@hotmail.fr --- I have found this bug following these steps too: Description: When adding borders on merged cells, right border is missing. When merging bordered cells, right border disappear. Steps to Reproduce: 1. Open Libre Office Draw 2. Insert > Table... 3a. Right-click on table > "table properties..." > "Borders" tab: make a border around the table 3b. select all cells in a row, right-click > merge cells Actual Results: Steps 3a and 3d can be done in any order: 3a > 3b : merged cells does not have right borders 3b > 3a : right borders disappear when merging cells Expected Results: Borders must work on merged cells as they do on non merged ones. - right borders must not disappear when merging cells - right borders must be displayed when applying borders on merged cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130627] FORMATTING: LibreOffice Writer crash when trying to center a text in a text zone.
https://bugs.documentfoundation.org/show_bug.cgi?id=130627 trem...@gmail.com changed: What|Removed |Added Version|unspecified |6.4.0.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130626] No right border on table when merging table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=130626 endo...@hotmail.fr changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from endo...@hotmail.fr --- Sorry, duplicate of 34403 *** This bug has been marked as a duplicate of bug 34403 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 endo...@hotmail.fr changed: What|Removed |Added CC||endo...@hotmail.fr --- Comment #16 from endo...@hotmail.fr --- *** Bug 130626 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130627] New: FORMATTING: LibreOffice Writer crash when trying to center a text in a text zone.
https://bugs.documentfoundation.org/show_bug.cgi?id=130627 Bug ID: 130627 Summary: FORMATTING: LibreOffice Writer crash when trying to center a text in a text zone. Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: trem...@gmail.com I have imported an image. I add a new text zone box over it, write some text, highlight that text and select Format/Align/Center. Writer crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 endo...@hotmail.fr changed: What|Removed |Added Attachment #157829|Missing right borders when |Missing right borders when description|merging full row|merging full row in 6.1.5.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 endo...@hotmail.fr changed: What|Removed |Added Attachment #157828|Reproducing 34403 steps |Reproducing 34403 steps in description||6.1.5.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 --- Comment #15 from endo...@hotmail.fr --- Created attachment 157829 --> https://bugs.documentfoundation.org/attachment.cgi?id=157829=edit Missing right borders when merging full row -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 --- Comment #14 from endo...@hotmail.fr --- Created attachment 157828 --> https://bugs.documentfoundation.org/attachment.cgi?id=157828=edit Reproducing 34403 steps -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34403] FORMATTING: borders wrong for merged cells with overlapping line segments
https://bugs.documentfoundation.org/show_bug.cgi?id=34403 --- Comment #13 from endo...@hotmail.fr --- Can reproduce this on LibreOffice 6.1.5.2 on Debian. Version: 6.1.5.2 Build ID: 1:6.1.5-3+deb10u5 Threads CPU : 8; OS : Linux 4.19; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.utf8); Calc: group threaded When reproducing steps, i have right border on merged cell, and i have unwanted border under the third (umerged) cell. When i merge full row, there is no right border. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80658] LOCALHELP: write help page for Calc Stream
https://bugs.documentfoundation.org/show_bug.cgi?id=80658 Martin Srebotnjak changed: What|Removed |Added CC||ko...@libreoffice.org --- Comment #8 from Martin Srebotnjak --- Adding Kohei: could you please check if the proposed help page for this function is ok or needs any more info? Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
How to build only changed files
Hello, I have a question. if I change one or more files and want to run 'make' to check that the project still builds, do I have to run a complete build everytime which takes a lot of time or is there a way to only build the affected files only ? Thanks ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 130626] No right border on table when merging table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=130626 --- Comment #1 from endo...@hotmail.fr --- Created attachment 157827 --> https://bugs.documentfoundation.org/attachment.cgi?id=157827=edit Draw: missing right borders on merged cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130626] New: No right border on table when merging table cells
https://bugs.documentfoundation.org/show_bug.cgi?id=130626 Bug ID: 130626 Summary: No right border on table when merging table cells Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: endo...@hotmail.fr Description: When adding borders on merged cells, right border is missing. When merging bordered cells, right border disappear. Steps to Reproduce: 1. Open Libre Office Draw 2. Insert > Table... 3a. Right-click on table > "table properties..." > "Borders" tab: make a border around the table 3b. select all cells in a row, right-click > merge cells Actual Results: Steps 3a and 3d can be done in any order: 3a > 3b : merged cells does not have right borders 3b > 3a : right borders disappear when merging cells Expected Results: Borders must work on merged cells as they do on non merged ones. - right borders must not disappear when merging cells - right borders must be displayed when applying borders on merged cells Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.1.5.2 Build ID: 1:6.1.5-3+deb10u5 Threads CPU : 8; OS : Linux 4.19; UI Render : par défaut; VCL: gtk3; Locale : fr-FR (fr_FR.utf8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130625] EDITING: Find/Replace in array formula not working
https://bugs.documentfoundation.org/show_bug.cgi?id=130625 Steve Edmonds changed: What|Removed |Added CC||st...@edmondsfamily.co.nz --- Comment #1 from Steve Edmonds --- Created attachment 157826 --> https://bugs.documentfoundation.org/attachment.cgi?id=157826=edit Calc sheet with array formulae for testing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130625] New: EDITING: Find/Replace in array formula not working
https://bugs.documentfoundation.org/show_bug.cgi?id=130625 Bug ID: 130625 Summary: EDITING: Find/Replace in array formula not working Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: st...@edmondsfamily.co.nz Description: Using Edit>find & replace in formulae does not perform the replacement in array formulae. Steps to Reproduce: 1.Create 2 named ranges, each a single cell. I.E _mu (=0.3) and _mu2 (=0.5). See attachment D44/D45 2.Create an array formula using _mu. See attachment D48:M49 3.Use find _mu, replace _mu2 formulae Actual Results: Search results show _mu is found in the array formulae _mu is not replaced by _mu2 in the array formula Expected Results: _mu is replaced by _mu2 in the array formulae Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.4.2.0+ Build ID: 30(Build:2) CPU threads: 4; OS: Linux 4.12; UI render: default; VCL: kde5; Locale: en-NZ (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #73 from Muhammet Kara --- (In reply to Mohamed Sameh from comment #72) > https://gerrit.libreoffice.org/c/core/+/88473/1 > I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for > some reason gerrit failed to build can anyone point out to me how I could > fix this ? I only made 3 changes and I can't see what could have possibly > gone wrong. > I am still building at my local machine to see if I will face a similar > problem but it is taking a lot of time. Please check your patch on Gerrit for the comments/review. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #72 from Mohamed Sameh --- https://gerrit.libreoffice.org/c/core/+/88473/1 I solved this easyhack in one file 'avmedia/source/win/manager.hxx', but for some reason gerrit failed to build can anyone point out to me how I could fix this ? I only made 3 changes and I can't see what could have possibly gone wrong. I am still building at my local machine to see if I will face a similar problem but it is taking a lot of time. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/map/handler/Map.TouchGesture.js |7 +++
1 file changed, 7 insertions(+)
New commits:
commit a867a1b79cf78282e2fce12a5ad02d5cb17f3641
Author: Pranam Lashkari
AuthorDate: Wed Feb 12 05:43:10 2020 +0530
Commit: Henry Castro
CommitDate: Wed Feb 12 20:00:30 2020 +0100
Tile loading enabled while autoscrolling
if scrolled too fast tiles could not load until auto scrolling stops
and user had to wait for approx 2 sec and wait for tile to load
follow up for: https://gerrit.libreoffice.org/c/online/+/88072
Change-Id: I09541f5400288398ac7680c6d96e224e2ad6ef66
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88485
Tested-by: Henry Castro
Reviewed-by: Henry Castro
diff --git a/loleaflet/src/map/handler/Map.TouchGesture.js
b/loleaflet/src/map/handler/Map.TouchGesture.js
index 72f6c4166..0d972d58a 100644
--- a/loleaflet/src/map/handler/Map.TouchGesture.js
+++ b/loleaflet/src/map/handler/Map.TouchGesture.js
@@ -635,7 +635,14 @@ L.Map.TouchGesture = L.Handler.extend({
this._map.dragging._draggable._startPoint =
this._startSwipePoint;
this._map.dragging._draggable._startPos = this._newPos;
this._newPos._add(delta);
+
this._map.dragging._draggable._onMove(e);
+
+ // Updates the tiles
+ clearInterval(this._map._docLayer._tilesPreFetcher);
+ this._map._docLayer._preFetchBorder = null;
+ this._map._docLayer._preFetchTiles();
+
this.autoscrollAnimReq =
L.Util.requestAnimFrame(this._autoscroll, this, true);
}
else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127589] Filesave XLSX: Missing data in two graphs that were shown before
https://bugs.documentfoundation.org/show_bug.cgi?id=127589 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Eike Rathke --- Taking. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/bastype3.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 88d54208f14a1a3941df0a9bc3097ccff2a43368
Author: Andrea Gelmini
AuthorDate: Wed Feb 12 19:15:13 2020 +0100
Commit: Julien Nabet
CommitDate: Wed Feb 12 19:56:13 2020 +0100
Fix typo
Change-Id: I2b0fe68cf5346a6788bbd63242eadf872d58a87e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88556
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/basctl/source/basicide/bastype3.cxx
b/basctl/source/basicide/bastype3.cxx
index 19ca594a213b..d54d635db981 100644
--- a/basctl/source/basicide/bastype3.cxx
+++ b/basctl/source/basicide/bastype3.cxx
@@ -128,7 +128,7 @@ IMPL_LINK(SbTreeListBox, RequestingChildrenHdl, const
weld::TreeIter&, rEntry, b
void SbTreeListBox::ScanAllEntries()
{
// instead of always freezing, freeze on the first add/remove, which keeps
gtk
-// from relayouting the tree if its not necessary
+// from relayouting the tree if it's not necessary
m_bFreezeOnFirstAddRemove = true;
ScanEntry( ScriptDocument::getApplicationScriptDocument(),
LIBRARY_LOCATION_USER );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130624] document created with older version doesn't open correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=130624 Oliver Brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #2 from Oliver Brinzing --- cause(In reply to ipomo from comment #0) > Description: > Formulas in an older document are not displayed and make writer extremely > slow. File attached Attached file, created with "LibreOffice/3.6$Linux_x86 LibreOffice_project" contains "http://; linked pictures: w:frame draw:style-name="fr1" draw:name="Grafik1" text:anchor-type="as-char" svg:width="2.884cm" svg:height="0.9cm" draw:z-index="0"> http://www.ina-de-brabandt.de/analysis/e/g2/e-ableiten-a5e.png; xlink:type="simple" xlink:show="embed" xlink:actuate="onLoad"/> f_a(x)=(x+2a)/exp(x) I guess this is the root cause for the problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86941] add more conditional formatting unit tests
https://bugs.documentfoundation.org/show_bug.cgi?id=86941 --- Comment #5 from Buovjaga --- (In reply to Abhishek from comment #4) > Hi, I would like to work on this hack. Where can I find Old bug reports? Can > U suggest me some examplary idea for unit test? See the ones here that are RESOLVED FIXED: https://bugs.documentfoundation.org/showdependencytree.cgi?id=87351_resolved=0 I am sure there are more outside of the meta. You can also search through the git commit log. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97667] add xml dump methods for calc pool items
https://bugs.documentfoundation.org/show_bug.cgi?id=97667 Buovjaga changed: What|Removed |Added CC||abhishek.iitkg...@gmail.com --- Comment #10 from Buovjaga --- The patch: https://gerrit.libreoffice.org/c/core/+/88475 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130345] FIREBIRD: Impossible to create an autovalue key when inserting a new table
https://bugs.documentfoundation.org/show_bug.cgi?id=130345 --- Comment #3 from Robert Großkopf --- Difference to HSQLDB: The wizard is the same. The key could be set, but no AutoValue. But in HSQLDB you could change the table afterwards. You could set the AutoValue in the tableeditor without any problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130624] document created with older version doesn't open correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=130624 ip...@gmx.de changed: What|Removed |Added CC||ip...@gmx.de --- Comment #1 from ip...@gmx.de --- Created attachment 157825 --> https://bugs.documentfoundation.org/attachment.cgi?id=157825=edit Writer document with math formulas -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
