[Libreoffice-commits] online.git: common/Unit.cpp

[Tor Lillqvist (via logerrit)]

 common/Unit.cpp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f49aa533e0eb06b6e7afecf2dcc631f2843d116c
Author: Tor Lillqvist 
AuthorDate: Mon Feb 24 09:12:38 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Mon Feb 24 08:54:22 2020 +0100

Fix iOS build (and maybe Android, too)

Change-Id: Id6645ce7fe0f70d7e7cec0059ad25624d1057ad5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89319
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/common/Unit.cpp b/common/Unit.cpp
index b34466c39..19cacc8aa 100644
--- a/common/Unit.cpp
+++ b/common/Unit.cpp
@@ -206,7 +206,9 @@ void UnitBase::exitTest(TestResult result)
 LOG_INF("exitTest: " << (int)result << ". Flagging to shutdown.");
 _setRetValue = true;
 _retValue = result == TestResult::Ok ? EX_OK : EX_SOFTWARE;
+#if !MOBILEAPP
 SigUtil::requestShutdown();
+#endif
 SocketPoll::wakeupWorld();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - oox/source sd/qa

[Gülşah Köse (via logerrit)]

 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |   12 +---
 sd/qa/unit/import-tests-smartart.cxx|   19 +++
 2 files changed, 24 insertions(+), 7 deletions(-)

New commits:
commit 3c10f574cd342bfdb6b11ea9bb89849c978dab5e
Author: Gülşah Köse 
AuthorDate: Thu Feb 20 14:13:40 2020 +0300
Commit: Gülşah Köse 
CommitDate: Mon Feb 24 08:48:58 2020 +0100

tdf130839: Corrects second level left margin in Smartart

Change-Id: Ifec339759427336fd53012e0a8a906d240be9654
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit eeaa7aba6e7ace8b69d7056645b15be2f996d8fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89278

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 12dcae71663c..51b4c8c96472 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -1224,10 +1224,16 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 aParagraph->getProperties().setLevel(nLevel);
 if (nLevel >= nStartBulletsAtLevel)
 {
+if 
(!aParagraph->getProperties().getParaLeftMargin().has_value())
+{
+sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
+aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
+}
+
+if 
(!aParagraph->getProperties().getFirstLineIndentation().has_value())
+aParagraph->getProperties().getFirstLineIndentation() 
= -285750 / EMU_PER_HMM;
+
 // It is not possible to change the bullet style for text.
-sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
-aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
-aParagraph->getProperties().getFirstLineIndentation() = 
-285750 / EMU_PER_HMM;
 OUString aBulletChar = OUString::fromUtf8(u8"•");
 
aParagraph->getProperties().getBulletList().setBulletChar(aBulletChar);
 
aParagraph->getProperties().getBulletList().setSuffixNone();
diff --git a/sd/qa/unit/import-tests-smartart.cxx 
b/sd/qa/unit/import-tests-smartart.cxx
index 842cc979ca9c..f0ab9ff067f5 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -101,7 +101,7 @@ public:
 void testFontSize();
 void testVerticalBlockList();
 void testBulletList();
-void testMissingBullet();
+void testMissingBulletAndIndent();
 void testRecursion();
 void testDataFollow();
 void testOrgChart2();
@@ -145,7 +145,7 @@ public:
 CPPUNIT_TEST(testFontSize);
 CPPUNIT_TEST(testVerticalBlockList);
 CPPUNIT_TEST(testBulletList);
-CPPUNIT_TEST(testMissingBullet);
+CPPUNIT_TEST(testMissingBulletAndIndent);
 CPPUNIT_TEST(testRecursion);
 CPPUNIT_TEST(testDataFollow);
 CPPUNIT_TEST(testOrgChart2);
@@ -1278,7 +1278,7 @@ void SdImportTestSmartArt::testVerticalBlockList()
 xDocShRef->DoClose();
 }
 
-void SdImportTestSmartArt::testMissingBullet()
+void SdImportTestSmartArt::testMissingBulletAndIndent()
 {
 sd::DrawDocShellRef xDocShRef = loadURL(
 
m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/smartart-missing-bullet.pptx"),
@@ -1298,8 +1298,19 @@ void SdImportTestSmartArt::testMissingBullet()
 
 sal_Int16 nNumberingLevel = -1;
 xPara1->getPropertyValue("NumberingLevel")>>= nNumberingLevel;
-
 CPPUNIT_ASSERT_EQUAL(sal_Int16(1), nNumberingLevel);
+
+uno::Reference< container::XIndexAccess > xNumRule;
+xPara1->getPropertyValue("NumberingRules") >>= xNumRule;
+uno::Sequence aBulletProps;
+xNumRule->getByIndex(1) >>= aBulletProps;
+
+for (int i = 0; i < aBulletProps.getLength(); ++i)
+{
+const beans::PropertyValue& rProp = aBulletProps[i];
+if(rProp.Name == "LeftMargin")
+CPPUNIT_ASSERT_EQUAL(sal_Int32(309), rProp.Value.get());
+}
 }
 
 void SdImportTestSmartArt::testBulletList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 123838] Issue on CAST() (FirebirdSQL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123838

--- Comment #4 from Kaitlyn  ---
Thanks a lot for sharing this information. It is through this post I came to
understand the importance of the cast(). I think the suggestion shared by other
users on fixing the issue of the cast() is helpful. I haven't tried it yet.
Hope it is helpful.
https://privatetoursofdc.com/washington-dc-tour/unique-attractions-to-visit-when-on-washington-dc-bus-tours/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109299] Empty cells are not copied to external application like Notepad (while copied to another spreadsheet)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109299

Timur  changed:

   What|Removed |Added

   Keywords||bisected

--- Comment #15 from Timur  ---
This should be the range:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=43c7830b03d141ae11d8617c0fdabefa32dd243c..ce97851773a06103504972eb2771eecd7dd81e36

Not obvious which is the commit.
Maybe
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e747a4e87e6abf581a5b0c381f706b581c2a0fbc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127801] SCROLLING: Optimal View Zoom Moves Left-Right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127801

--- Comment #16 from Heiko Tietze  ---
It makes no sense to bind scrolling on/off to the zoom factor. Whether you get
a horizontal scroll bar should depend solely on the content width. So again, if
"Optimal" is not working for you why not using "Page Width"? Point is that we
have plenty of zoom options that might have an unexpected label but work
perfectly in all situations. I don't see room for improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127801] SCROLLING: Optimal View Zoom Moves Left-Right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127801

--- Comment #16 from Heiko Tietze  ---
It makes no sense to bind scrolling on/off to the zoom factor. Whether you get
a horizontal scroll bar should depend solely on the content width. So again, if
"Optimal" is not working for you why not using "Page Width"? Point is that we
have plenty of zoom options that might have an unexpected label but work
perfectly in all situations. I don't see room for improvement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - oox/source sd/qa

[Gülşah Köse (via logerrit)]

 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |   12 +---
 sd/qa/unit/import-tests-smartart.cxx|   19 +++
 2 files changed, 24 insertions(+), 7 deletions(-)

New commits:
commit 73cac1031131021819a0fbd4d60554196aea230c
Author: Gülşah Köse 
AuthorDate: Thu Feb 20 14:13:40 2020 +0300
Commit: Gülşah Köse 
CommitDate: Mon Feb 24 08:23:59 2020 +0100

tdf130839: Corrects second level left margin in Smartart

Change-Id: Ifec339759427336fd53012e0a8a906d240be9654
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit eeaa7aba6e7ace8b69d7056645b15be2f996d8fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89277

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 14af84da6ac4..1b6a821f3a0a 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -1224,10 +1224,16 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 aParagraph->getProperties().setLevel(nLevel);
 if (nLevel >= nStartBulletsAtLevel)
 {
+if 
(!aParagraph->getProperties().getParaLeftMargin().has_value())
+{
+sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
+aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
+}
+
+if 
(!aParagraph->getProperties().getFirstLineIndentation().has_value())
+aParagraph->getProperties().getFirstLineIndentation() 
= -285750 / EMU_PER_HMM;
+
 // It is not possible to change the bullet style for text.
-sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
-aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
-aParagraph->getProperties().getFirstLineIndentation() = 
-285750 / EMU_PER_HMM;
 OUString aBulletChar = OUString::fromUtf8(u8"•");
 
aParagraph->getProperties().getBulletList().setBulletChar(aBulletChar);
 
aParagraph->getProperties().getBulletList().setSuffixNone();
diff --git a/sd/qa/unit/import-tests-smartart.cxx 
b/sd/qa/unit/import-tests-smartart.cxx
index 2d47381c4e67..d14c4bc6950a 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -101,7 +101,7 @@ public:
 void testFontSize();
 void testVerticalBlockList();
 void testBulletList();
-void testMissingBullet();
+void testMissingBulletAndIndent();
 void testRecursion();
 void testDataFollow();
 void testOrgChart2();
@@ -145,7 +145,7 @@ public:
 CPPUNIT_TEST(testFontSize);
 CPPUNIT_TEST(testVerticalBlockList);
 CPPUNIT_TEST(testBulletList);
-CPPUNIT_TEST(testMissingBullet);
+CPPUNIT_TEST(testMissingBulletAndIndent);
 CPPUNIT_TEST(testRecursion);
 CPPUNIT_TEST(testDataFollow);
 CPPUNIT_TEST(testOrgChart2);
@@ -1277,7 +1277,7 @@ void SdImportTestSmartArt::testVerticalBlockList()
 xDocShRef->DoClose();
 }
 
-void SdImportTestSmartArt::testMissingBullet()
+void SdImportTestSmartArt::testMissingBulletAndIndent()
 {
 sd::DrawDocShellRef xDocShRef = loadURL(
 
m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/smartart-missing-bullet.pptx"),
@@ -1297,8 +1297,19 @@ void SdImportTestSmartArt::testMissingBullet()
 
 sal_Int16 nNumberingLevel = -1;
 xPara1->getPropertyValue("NumberingLevel")>>= nNumberingLevel;
-
 CPPUNIT_ASSERT_EQUAL(sal_Int16(1), nNumberingLevel);
+
+uno::Reference< container::XIndexAccess > xNumRule;
+xPara1->getPropertyValue("NumberingRules") >>= xNumRule;
+uno::Sequence aBulletProps;
+xNumRule->getByIndex(1) >>= aBulletProps;
+
+for (int i = 0; i < aBulletProps.getLength(); ++i)
+{
+const beans::PropertyValue& rProp = aBulletProps[i];
+if(rProp.Name == "LeftMargin")
+CPPUNIT_ASSERT_EQUAL(sal_Int32(309), rProp.Value.get());
+}
 }
 
 void SdImportTestSmartArt::testBulletList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Jim Raykowski (via logerrit)]

 sfx2/source/sidebar/SidebarDockingWindow.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 7d803018968c229e8e77b6e8f6f242a76c4b24d7
Author: Jim Raykowski 
AuthorDate: Sat Feb 22 19:44:59 2020 -0900
Commit: Noel Grandin 
CommitDate: Mon Feb 24 08:04:16 2020 +0100

Make undo/redo shortcuts work from sidebar docking window

Change-Id: I20ec2363d156d51528d4cce618311b8b919dfb87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89314
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/sidebar/SidebarDockingWindow.cxx 
b/sfx2/source/sidebar/SidebarDockingWindow.cxx
index b74b96d79932..553d6df95455 100644
--- a/sfx2/source/sidebar/SidebarDockingWindow.cxx
+++ b/sfx2/source/sidebar/SidebarDockingWindow.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -276,6 +277,11 @@ bool SidebarDockingWindow::EventNotify(NotifyEvent& rEvent)
 Close();
 return true;
 }
+if (".uno:Undo" == aCommand || ".uno:Redo" == aCommand)
+{
+comphelper::dispatchCommand(aCommand, {});
+return true;
+}
 }
 else if (MouseNotifyEvent::MOUSEBUTTONDOWN == nType)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Jim Raykowski (via logerrit)]

 vcl/source/window/window.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9e329cd476298383d4e68b868f487a1f4ccca9d8
Author: Jim Raykowski 
AuthorDate: Sun Feb 23 12:34:07 2020 -0900
Commit: Noel Grandin 
CommitDate: Mon Feb 24 08:03:39 2020 +0100

gtk3: allow handling of ctrl key accelerators

Change-Id: I681354f3b069a16d07a20bcc1fe110397d0ea2a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89315
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index cf56c9331e5e..7afb1fb36e6d 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -1821,10 +1821,10 @@ void Window::KeyInput( const KeyEvent& rKEvt )
 KeyCode cod = rKEvt.GetKeyCode ();
 bool autoacc = ImplGetSVData()->maNWFData.mbAutoAccel;
 
-// do not respond to accelerators unless Alt is held */
+// do not respond to accelerators unless Alt or Ctrl is held */
 if (cod.GetCode () >= 0x200 && cod.GetCode () <= 0x219)
 {
-if (autoacc && cod.GetModifier () != KEY_MOD2)
+if (autoacc && cod.GetModifier () != KEY_MOD2 && !(cod.GetModifier() & 
KEY_MOD1))
 return;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/inc framework/source

[Jim Raykowski (via logerrit)]

 framework/inc/classes/resource.hxx|9 +++---
 framework/inc/strings.hrc |1 
 framework/inc/uielement/toolbarmanager.hxx|1 
 framework/source/uielement/toolbarmanager.cxx |   36 +++---
 4 files changed, 40 insertions(+), 7 deletions(-)

New commits:
commit 0fb4f2107d08febd4925dce6d96b41da9917e9ae
Author: Jim Raykowski 
AuthorDate: Sat Dec 21 14:54:28 2019 -0900
Commit: Noel Grandin 
CommitDate: Mon Feb 24 08:00:46 2020 +0100

tdf#130163 Show undock or dock menu item in toolbar menu

This patch removes toolbar menu item 'Dock Toolbar' enable state and
shows 'Undock Toolbar' menu item when toolbar is docked and 'Dock
Toolbar' menu item when toolbar is undocked. It also sets the
accelerator key displayed for these items to Shift+Ctrl+F10

Change-Id: I0e4673529438c42452026602785857066ea7874a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85673
Tested-by: Noel Grandin 
Reviewed-by: Noel Grandin 

diff --git a/framework/inc/classes/resource.hxx 
b/framework/inc/classes/resource.hxx
index a9f98e607baa..04f00677c69d 100644
--- a/framework/inc/classes/resource.hxx
+++ b/framework/inc/classes/resource.hxx
@@ -22,10 +22,11 @@
 
 #define MENUITEM_TOOLBAR_VISIBLEBUTTON  1
 #define MENUITEM_TOOLBAR_CUSTOMIZETOOLBAR   2
-#define MENUITEM_TOOLBAR_DOCKTOOLBAR3
-#define MENUITEM_TOOLBAR_DOCKALLTOOLBAR 4
-#define MENUITEM_TOOLBAR_LOCKTOOLBARPOSITION5
-#define MENUITEM_TOOLBAR_CLOSE  6
+#define MENUITEM_TOOLBAR_UNDOCKTOOLBAR  3
+#define MENUITEM_TOOLBAR_DOCKTOOLBAR4
+#define MENUITEM_TOOLBAR_DOCKALLTOOLBAR 5
+#define MENUITEM_TOOLBAR_LOCKTOOLBARPOSITION6
+#define MENUITEM_TOOLBAR_CLOSE  7
 
 #endif
 
diff --git a/framework/inc/strings.hrc b/framework/inc/strings.hrc
index ef3ad73c1956..d3f28fcc9e21 100644
--- a/framework/inc/strings.hrc
+++ b/framework/inc/strings.hrc
@@ -27,6 +27,7 @@
 #define STR_CLOSEDOC_ANDRETURN  
NC_("STR_CLOSEDOC_ANDRETURN", "~Close & Return to " )
 #define STR_TOOLBAR_VISIBLE_BUTTONS 
NC_("STR_TOOLBAR_VISIBLE_BUTTONS", "Visible ~Buttons")
 #define STR_TOOLBAR_CUSTOMIZE_TOOLBAR   
NC_("STR_TOOLBAR_CUSTOMIZE_TOOLBAR", "~Customize Toolbar...")
+#define STR_TOOLBAR_UNDOCK_TOOLBAR  
NC_("STR_TOOLBAR_UNDOCK_TOOLBAR", "U~ndock Toolbar" )
 #define STR_TOOLBAR_DOCK_TOOLBAR
NC_("STR_TOOLBAR_DOCK_TOOLBAR", "~Dock Toolbar" )
 #define STR_TOOLBAR_DOCK_ALL_TOOLBARS   
NC_("STR_TOOLBAR_DOCK_ALL_TOOLBARS", "Dock ~All Toolbars" )
 #define STR_TOOLBAR_LOCK_TOOLBAR
NC_("STR_TOOLBAR_LOCK_TOOLBAR", "~Lock Toolbar Position" )
diff --git a/framework/inc/uielement/toolbarmanager.hxx 
b/framework/inc/uielement/toolbarmanager.hxx
index f43a3511b85d..8f3eb4c2b2eb 100644
--- a/framework/inc/uielement/toolbarmanager.hxx
+++ b/framework/inc/uielement/toolbarmanager.hxx
@@ -94,6 +94,7 @@ class ToolBarManager : public ToolbarManager_Base
 enum ExecuteCommand
 {
 EXEC_CMD_CLOSETOOLBAR,
+EXEC_CMD_UNDOCKTOOLBAR,
 EXEC_CMD_DOCKTOOLBAR,
 EXEC_CMD_DOCKALLTOOLBARS
 };
diff --git a/framework/source/uielement/toolbarmanager.cxx 
b/framework/source/uielement/toolbarmanager.cxx
index 78a5c1198584..d224cfc2a955 100644
--- a/framework/source/uielement/toolbarmanager.cxx
+++ b/framework/source/uielement/toolbarmanager.cxx
@@ -1447,8 +1447,22 @@ void ToolBarManager::AddCustomizeMenuItems(ToolBox const 
* pToolBar)
 nGroupLen = pMenu->GetItemCount();
 }
 
-if (MenuItemAllowed(MENUITEM_TOOLBAR_DOCKTOOLBAR))
-pMenu->InsertItem(MENUITEM_TOOLBAR_DOCKTOOLBAR, 
FwkResId(STR_TOOLBAR_DOCK_TOOLBAR));
+if (pToolBar->IsFloatingMode())
+{
+if (MenuItemAllowed(MENUITEM_TOOLBAR_DOCKTOOLBAR))
+{
+pMenu->InsertItem(MENUITEM_TOOLBAR_DOCKTOOLBAR, 
FwkResId(STR_TOOLBAR_DOCK_TOOLBAR));
+pMenu->SetAccelKey(MENUITEM_TOOLBAR_DOCKTOOLBAR, 
vcl::KeyCode(KEY_F10, true, true, false, false));
+}
+}
+else
+{
+if (MenuItemAllowed(MENUITEM_TOOLBAR_UNDOCKTOOLBAR))
+{
+pMenu->InsertItem(MENUITEM_TOOLBAR_UNDOCKTOOLBAR, 
FwkResId(STR_TOOLBAR_UNDOCK_TOOLBAR));
+pMenu->SetAccelKey(MENUITEM_TOOLBAR_UNDOCKTOOLBAR, 
vcl::KeyCode(KEY_F10, true, true, false, false));
+}
+}
 
 if (MenuItemAllowed(MENUITEM_TOOLBAR_DOCKALLTOOLBAR))
 pMenu->InsertItem(MENUITEM_TOOLBAR_DOCKALLTOOLBAR, 
FwkResId(STR_TOOLBAR_DOCK_ALL_TOOLBARS));
@@ -1475,7 +1489,6 @@ void ToolBarManager::AddCustomizeMenuItems(ToolBox const 
* pToolBar)
 
 if ( !bIsFloating )
 {
-pMenu->EnableItem(MENUITEM_TOOLBAR_DOCKTOOLBAR, false);
 pMenu->EnableItem(MENUITEM_TOOLBAR_DOCKALLTOOLBAR, false);
 Reference< XDockableWindow 

[Libreoffice-commits] core.git: sw/inc sw/source

[Jim Raykowski (via logerrit)]

 sw/inc/strings.hrc |4 
 sw/source/uibase/inc/conttree.hxx  |2 
 sw/source/uibase/inc/swcont.hxx|2 
 sw/source/uibase/utlui/content.cxx |  233 -
 4 files changed, 139 insertions(+), 102 deletions(-)

New commits:
commit 08313c42abc5fb735948f37789ef993c93b6ab5e
Author: Jim Raykowski 
AuthorDate: Fri Feb 21 00:08:53 2020 -0900
Commit: Noel Grandin 
CommitDate: Mon Feb 24 07:58:38 2020 +0100

tdf#108766 Add outline tracking to all content navigation view

Here is effort to implement this request and improve code understanding/
readability in the areas touched.

A choice of one of three modes of outline tracking is avaliable through
the outline/heading content context menu. They are:

Default - does not collapse expanded outline entries
Focus - collapses all outline entries other than tracked
Off

The need for persistance of this setting is uncertain so has been left
for future implementation.

Change-Id: I9cb6420537d7ff9f584e94029a0c053f21f1ef8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89287
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index c2bb4ef19562..93df4d272220 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -643,6 +643,10 @@
 #define STR_OUTLINE_LEVEL   NC_("STR_OUTLINE_LEVEL", 
"Outline Level")
 #define STR_DRAGMODENC_("STR_DRAGMODE", "Drag 
Mode")
 #define STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY 
NC_("STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY", "Send Outline to Clipboard")
+#define STR_OUTLINE_TRACKINGNC_("STR_OUTLINE_TRACKING", 
"Outline Tracking")
+#define STR_OUTLINE_TRACKING_DEFAULT
NC_("STR_OUTLINE_TRACKING_DEFAULT", "Default")
+#define STR_OUTLINE_TRACKING_FOCUS  
NC_("STR_OUTLINE_TRACKING_FOCUS", "Focus")
+#define STR_OUTLINE_TRACKING_OFF
NC_("STR_OUTLINE_TRACKING_OFF", "Off")
 #define STR_GOTONC_("STR_GOTO", "Go to")
 #define STR_SELECT  NC_("STR_SELECT", "Select")
 #define STR_DEMOTE_CHAPTER  NC_("STR_DEMOTE_CHAPTER", 
"Demote Chapter")
diff --git a/sw/source/uibase/inc/conttree.hxx 
b/sw/source/uibase/inc/conttree.hxx
index e9c227875c22..c134e10551b3 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -102,6 +102,8 @@ class SwContentTree final
 ContentTypeId   m_nLastSelType;
 sal_uInt8   m_nOutlineLevel;
 
+sal_uInt32  m_nOutlineTracking = 1;
+
 enum class State { ACTIVE, CONSTANT, HIDDEN } m_eState;
 
 boolm_bDocChgdInDragging  :1;
diff --git a/sw/source/uibase/inc/swcont.hxx b/sw/source/uibase/inc/swcont.hxx
index fb2d0a9d4b79..cb334f9141eb 100644
--- a/sw/source/uibase/inc/swcont.hxx
+++ b/sw/source/uibase/inc/swcont.hxx
@@ -44,7 +44,7 @@ enum class ContentTypeId
 };
 
 // strings for context menus
-#define CONTEXT_COUNT   13
+#define CONTEXT_COUNT   17
 #define GLOBAL_CONTEXT_COUNT 14
 
 // modes for Drag 'n Drop
diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 19a7b81f35c7..d0b1934aa1d8 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -830,7 +830,11 @@ enum STR_CONTEXT_IDX
 IDX_STR_INACTIVE = 9,
 IDX_STR_EDIT_ENTRY = 10,
 IDX_STR_DELETE_ENTRY = 11,
-IDX_STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY = 12
+IDX_STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY = 12,
+IDX_STR_OUTLINE_TRACKING = 13,
+IDX_STR_OUTLINE_TRACKING_DEFAULT = 14,
+IDX_STR_OUTLINE_TRACKING_FOCUS = 15,
+IDX_STR_OUTLINE_TRACKING_OFF = 16
 };
 
 }
@@ -849,7 +853,11 @@ static const char* STR_CONTEXT_ARY[] =
 STR_INACTIVE,
 STR_EDIT_ENTRY,
 STR_DELETE_ENTRY,
-STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY
+STR_SEND_OUTLINE_TO_CLIPBOARD_ENTRY,
+STR_OUTLINE_TRACKING,
+STR_OUTLINE_TRACKING_DEFAULT,
+STR_OUTLINE_TRACKING_FOCUS,
+STR_OUTLINE_TRACKING_OFF
 };
 
 SwContentTree::SwContentTree(vcl::Window* pParent, SwNavigationPI* pDialog)
@@ -1227,7 +1235,13 @@ VclPtr SwContentTree::CreateContextMenu()
 VclPtrInstance pSubPop1;
 VclPtrInstance pSubPop2;
 VclPtrInstance pSubPop3;
+VclPtrInstance pSubPopOutlineTracking;
 
+for(int i = 1; i <= 3; ++i)
+{
+pSubPopOutlineTracking->InsertItem(i + 10, m_aContextStrings[i + 
IDX_STR_OUTLINE_TRACKING], MenuItemBits::AUTOCHECK | MenuItemBits::RADIOCHECK);
+}
+pSubPopOutlineTracking->CheckItem(10 + m_nOutlineTracking);
 for(int i = 1; i <= MAXLEVEL; ++i)
 {
 pSubPop1->InsertItem(i + 100, OUString::number(i), 
MenuItemBits::AUTOCHECK | MenuItemBits::RADIOCHECK);
@@ -1405,6 +1419,8 @@ VclPtr SwContentTree::CreateContextMenu()
 pPop->InsertSeparator();
 if (bOutline)
 {
+pPop->InsertItem(4, 

[Libreoffice-bugs] [Bug 38835] strip out non-trivial globals before main

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38835

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #51 from Buovjaga  ---
(In reply to Hrithik Raj from comment #50)
> Apologies. I am new to open source.Can you tell me where is the code where i
> have to look for this bug. I can see a directory in comment 2 .

Please read *all* of the comments and not just up to comment 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source sd/qa

[Gülşah Köse (via logerrit)]

 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |   12 +---
 sd/qa/unit/import-tests-smartart.cxx|   19 +++
 2 files changed, 24 insertions(+), 7 deletions(-)

New commits:
commit eeaa7aba6e7ace8b69d7056645b15be2f996d8fb
Author: Gülşah Köse 
AuthorDate: Thu Feb 20 14:13:40 2020 +0300
Commit: Gülşah Köse 
CommitDate: Mon Feb 24 07:33:34 2020 +0100

tdf130839: Corrects second level left margin in Smartart

Change-Id: Ifec339759427336fd53012e0a8a906d240be9654
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index f047a2c2670e..41f38b744d1b 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -1224,10 +1224,16 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 aParagraph->getProperties().setLevel(nLevel);
 if (nLevel >= nStartBulletsAtLevel)
 {
+if 
(!aParagraph->getProperties().getParaLeftMargin().has_value())
+{
+sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
+aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
+}
+
+if 
(!aParagraph->getProperties().getFirstLineIndentation().has_value())
+aParagraph->getProperties().getFirstLineIndentation() 
= -285750 / EMU_PER_HMM;
+
 // It is not possible to change the bullet style for text.
-sal_Int32 nLeftMargin = 285750 * (nLevel - 
nStartBulletsAtLevel + 1) / EMU_PER_HMM;
-aParagraph->getProperties().getParaLeftMargin() = 
nLeftMargin;
-aParagraph->getProperties().getFirstLineIndentation() = 
-285750 / EMU_PER_HMM;
 OUString aBulletChar = OUString::fromUtf8(u8"•");
 
aParagraph->getProperties().getBulletList().setBulletChar(aBulletChar);
 
aParagraph->getProperties().getBulletList().setSuffixNone();
diff --git a/sd/qa/unit/import-tests-smartart.cxx 
b/sd/qa/unit/import-tests-smartart.cxx
index 2d47381c4e67..d14c4bc6950a 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -101,7 +101,7 @@ public:
 void testFontSize();
 void testVerticalBlockList();
 void testBulletList();
-void testMissingBullet();
+void testMissingBulletAndIndent();
 void testRecursion();
 void testDataFollow();
 void testOrgChart2();
@@ -145,7 +145,7 @@ public:
 CPPUNIT_TEST(testFontSize);
 CPPUNIT_TEST(testVerticalBlockList);
 CPPUNIT_TEST(testBulletList);
-CPPUNIT_TEST(testMissingBullet);
+CPPUNIT_TEST(testMissingBulletAndIndent);
 CPPUNIT_TEST(testRecursion);
 CPPUNIT_TEST(testDataFollow);
 CPPUNIT_TEST(testOrgChart2);
@@ -1277,7 +1277,7 @@ void SdImportTestSmartArt::testVerticalBlockList()
 xDocShRef->DoClose();
 }
 
-void SdImportTestSmartArt::testMissingBullet()
+void SdImportTestSmartArt::testMissingBulletAndIndent()
 {
 sd::DrawDocShellRef xDocShRef = loadURL(
 
m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/smartart-missing-bullet.pptx"),
@@ -1297,8 +1297,19 @@ void SdImportTestSmartArt::testMissingBullet()
 
 sal_Int16 nNumberingLevel = -1;
 xPara1->getPropertyValue("NumberingLevel")>>= nNumberingLevel;
-
 CPPUNIT_ASSERT_EQUAL(sal_Int16(1), nNumberingLevel);
+
+uno::Reference< container::XIndexAccess > xNumRule;
+xPara1->getPropertyValue("NumberingRules") >>= xNumRule;
+uno::Sequence aBulletProps;
+xNumRule->getByIndex(1) >>= aBulletProps;
+
+for (int i = 0; i < aBulletProps.getLength(); ++i)
+{
+const beans::PropertyValue& rProp = aBulletProps[i];
+if(rProp.Name == "LeftMargin")
+CPPUNIT_ASSERT_EQUAL(sal_Int32(309), rProp.Value.get());
+}
 }
 
 void SdImportTestSmartArt::testBulletList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter.cxx |   25 +
 sw/source/core/edit/acorrect.cxx   |7 +++
 2 files changed, 28 insertions(+), 4 deletions(-)

New commits:
commit 28ddbaabf895234fb9cfa121ae74e56bef158b5c
Author: Michael Stahl 
AuthorDate: Thu Feb 20 18:28:45 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Feb 24 07:33:02 2020 +0100

tdf#130274 sw_redlinehide: fix ChgAutoCorrWord() if replaced text ...

... is fully deleted.

This crashes on English text with 'i'->'I' substitution.

The assumption that there's some part of the found text that is not
deleted is only correct for the case where tracked changes are hidden,
but not when they are shown.

(regression from 9926ea7dd07f1f3d012ddf97941a42bb7fa5717d)

Change-Id: I0e81494659ea7e187101a703f64483dd68c73d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89151
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit b7922b56e2dcf1dc1abbf5574bcb672068fa8dbd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89136
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index c73e7f30cbca..2a874457d83b 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -193,6 +193,7 @@ public:
 void testFdo85554();
 void testAutoCorr();
 void testTdf83260();
+void testTdf130274();
 void testMergeDoc();
 void testCreatePortions();
 void testBookmarkUndo();
@@ -403,6 +404,7 @@ public:
 CPPUNIT_TEST(testFdo85554);
 CPPUNIT_TEST(testAutoCorr);
 CPPUNIT_TEST(testTdf83260);
+CPPUNIT_TEST(testTdf130274);
 CPPUNIT_TEST(testMergeDoc);
 CPPUNIT_TEST(testCreatePortions);
 CPPUNIT_TEST(testBookmarkUndo);
@@ -1608,6 +1610,29 @@ void SwUiWriterTest::testTdf83260()
 }
 }
 
+void SwUiWriterTest::testTdf130274()
+{
+SwDoc *const pDoc(createDoc());
+SwWrtShell *const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwAutoCorrect corr(*SvxAutoCorrCfg::Get().GetAutoCorrect());
+
+CPPUNIT_ASSERT(!pWrtShell->GetLayout()->IsHideRedlines());
+CPPUNIT_ASSERT(!IDocumentRedlineAccess::IsRedlineOn(
+pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+// "tset" may be replaced by the AutoCorrect in the test profile
+pWrtShell->Insert("tset");
+// select from left to right
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 4, 
/*bBasicCall=*/false);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 4, 
/*bBasicCall=*/false);
+
+pWrtShell->SetRedlineFlags(pWrtShell->GetRedlineFlags() | 
RedlineFlags::On);
+// this would crash in AutoCorrect
+pWrtShell->AutoCorrect(corr, '.');
+
+
CPPUNIT_ASSERT(!pDoc->getIDocumentRedlineAccess().GetRedlineTable().empty());
+}
+
 void SwUiWriterTest::testMergeDoc()
 {
 SwDoc* const pDoc1(createDoc("merge-change1.odt"));
diff --git a/sw/source/core/edit/acorrect.cxx b/sw/source/core/edit/acorrect.cxx
index 8f54e69f1b46..a4a4ccf71de6 100644
--- a/sw/source/core/edit/acorrect.cxx
+++ b/sw/source/core/edit/acorrect.cxx
@@ -406,10 +406,10 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 if (sw::GetRanges(ranges, *rEditSh.GetDoc(), aPam))
 {
 pDoc->getIDocumentContentOperations().ReplaceRange(aPam, 
pFnd->GetLong(), false);
+bRet = true;
 }
-else
+else if (!ranges.empty())
 {
-assert(!ranges.empty());
 assert(ranges.front()->GetPoint()->nNode == 
ranges.front()->GetMark()->nNode);
 pDoc->getIDocumentContentOperations().ReplaceRange(
 *ranges.front(), pFnd->GetLong(), false);
@@ -417,6 +417,7 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 {
 DeleteSelImpl(**it);
 }
+bRet = true;
 }
 
 // tdf#83260 After calling 
sw::DocumentContentOperationsManager::ReplaceRange
@@ -424,8 +425,6 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 // ReplaceRange shows changes, this moves deleted nodes from 
special section to document.
 // Then Show mode is disabled again. As a result pTextNd may 
be invalidated.
 pTextNd = rCursor.GetNode().GetTextNode();
-
-bRet = true;
 }
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter.cxx |   25 +
 sw/source/core/edit/acorrect.cxx   |7 +++
 2 files changed, 28 insertions(+), 4 deletions(-)

New commits:
commit 1e97fb44829481845a7e768392f92f6c00f324de
Author: Michael Stahl 
AuthorDate: Thu Feb 20 18:28:45 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Feb 24 07:32:21 2020 +0100

tdf#130274 sw_redlinehide: fix ChgAutoCorrWord() if replaced text ...

... is fully deleted.

This crashes on English text with 'i'->'I' substitution.

The assumption that there's some part of the found text that is not
deleted is only correct for the case where tracked changes are hidden,
but not when they are shown.

(regression from 9926ea7dd07f1f3d012ddf97941a42bb7fa5717d)

Change-Id: I0e81494659ea7e187101a703f64483dd68c73d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89151
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit b7922b56e2dcf1dc1abbf5574bcb672068fa8dbd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89135
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 06261d60df84..eacde2daf67d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -202,6 +202,7 @@ public:
 void testFdo85554();
 void testAutoCorr();
 void testTdf83260();
+void testTdf130274();
 void testMergeDoc();
 void testCreatePortions();
 void testBookmarkUndo();
@@ -408,6 +409,7 @@ public:
 CPPUNIT_TEST(testFdo85554);
 CPPUNIT_TEST(testAutoCorr);
 CPPUNIT_TEST(testTdf83260);
+CPPUNIT_TEST(testTdf130274);
 CPPUNIT_TEST(testMergeDoc);
 CPPUNIT_TEST(testCreatePortions);
 CPPUNIT_TEST(testBookmarkUndo);
@@ -1618,6 +1620,29 @@ void SwUiWriterTest::testTdf83260()
 }
 }
 
+void SwUiWriterTest::testTdf130274()
+{
+SwDoc *const pDoc(createDoc());
+SwWrtShell *const pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+SwAutoCorrect corr(*SvxAutoCorrCfg::Get().GetAutoCorrect());
+
+CPPUNIT_ASSERT(!pWrtShell->GetLayout()->IsHideRedlines());
+CPPUNIT_ASSERT(!IDocumentRedlineAccess::IsRedlineOn(
+pDoc->getIDocumentRedlineAccess().GetRedlineFlags()));
+
+// "tset" may be replaced by the AutoCorrect in the test profile
+pWrtShell->Insert("tset");
+// select from left to right
+pWrtShell->Left(CRSR_SKIP_CHARS, /*bSelect=*/false, 4, 
/*bBasicCall=*/false);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 4, 
/*bBasicCall=*/false);
+
+pWrtShell->SetRedlineFlags(pWrtShell->GetRedlineFlags() | 
RedlineFlags::On);
+// this would crash in AutoCorrect
+pWrtShell->AutoCorrect(corr, '.');
+
+
CPPUNIT_ASSERT(!pDoc->getIDocumentRedlineAccess().GetRedlineTable().empty());
+}
+
 void SwUiWriterTest::testMergeDoc()
 {
 SwDoc* const pDoc1(createDoc("merge-change1.odt"));
diff --git a/sw/source/core/edit/acorrect.cxx b/sw/source/core/edit/acorrect.cxx
index 431b8c1552f3..7304e6e7b702 100644
--- a/sw/source/core/edit/acorrect.cxx
+++ b/sw/source/core/edit/acorrect.cxx
@@ -406,10 +406,10 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 if (sw::GetRanges(ranges, *rEditSh.GetDoc(), aPam))
 {
 pDoc->getIDocumentContentOperations().ReplaceRange(aPam, 
pFnd->GetLong(), false);
+bRet = true;
 }
-else
+else if (!ranges.empty())
 {
-assert(!ranges.empty());
 assert(ranges.front()->GetPoint()->nNode == 
ranges.front()->GetMark()->nNode);
 pDoc->getIDocumentContentOperations().ReplaceRange(
 *ranges.front(), pFnd->GetLong(), false);
@@ -417,6 +417,7 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 {
 DeleteSelImpl(**it);
 }
+bRet = true;
 }
 
 // tdf#83260 After calling 
sw::DocumentContentOperationsManager::ReplaceRange
@@ -424,8 +425,6 @@ bool SwAutoCorrDoc::ChgAutoCorrWord( sal_Int32& rSttPos, 
sal_Int32 nEndPos,
 // ReplaceRange shows changes, this moves deleted nodes from 
special section to document.
 // Then Show mode is disabled again. As a result pTextNd may 
be invalidated.
 pTextNd = rCursor.GetNode().GetTextNode();
-
-bRet = true;
 }
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130866] paragraph font style does not change on selecting another paragraph style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130866

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Kevin Suo  ---
To make sure we are following the same Steps to Reproduce, please see if the
following steps are correct:

1. Type "abcd" in the first paragraph, and set "d" to bold, by selecting "d"
and then clicking the "Bold" toolbar icon.

2. Put cursor at the end of "b", hit Enter to create a new paragraph, and type
"efg". Now "efg" is showing "bold". 
--> This is expected, as I have set "d" as direct formatting in the previous
paragrapy, so the new paragraph has "inherited" the direct formatting.

3. Select "efg", and click the "Bold" toolbar icon again.
--> "efg" now becomes un-bold. This also correct and expected.

So where is the problem?

By saying "Style", I understand that you are not referring to the "Styles" in
the sidebar (i.e., the Styles dialog as appears when you hit F11).

I mark this as NEEDINFO. Please provide your feedback and then set the status
back to UNCONFIRMED.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127020] Fonts are blurry on MacOS Retina displays

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127020

--- Comment #3 from Nick  ---
A fix is described here:
https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c181

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130890] Please no false autocorrection by default!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130890

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #1 from Kevin Suo  ---
You can disable auto correction by deselect:
Tools > Auto Correct > When Typing.

Auto correct works in many other languages such as English etc, I don't think
it is worth disabling by default? 

Actually for me it really does not matter as I use Simplified Chinese and this
feature never work in Chinese language.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130891] Radio buttons do not work in fillable PDF forms since 6.3.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130891

Kevin Suo  changed:

   What|Removed |Added

Summary|Radio buttons do not work   |Radio buttons do not work
   |in fillable PDF forms since |in fillable PDF forms since
   |6.1.6   |6.3.0
Version|6.2.0.0.alpha0+ |6.3.0.0.beta2+
   Keywords||bibisected, bisected,
   ||regression
  Component|Writer  |Printing and PDF export
 CC||katarina.behr...@cib.de

--- Comment #4 from Kevin Suo  ---
Bibisected using the bibisect-linux-64-6.3 repo
(https://wiki.documentfoundation.org/QA/Bibisect/Linux#Versions):

$ git bisect log
# bad: [d69ce43ec33c664199e197a216c76232d3d182ad] source
sha:a955330e052cc12c622982f38c5f5d138484013a
# good: [9afa9f91ebeb50e79eef17c1eb0a74c0e042a8f4] source
sha:75ae16fc2b9c5bca79b4e5b178d9952a15c4e3bf
git bisect start 'master' '9afa9f91ebeb50e79eef17c1eb0a74c0e042a8f4'
# good: [2468f6c563bfda05b7fdbb34345d008df881777f] source
sha:cd815d75fd039e59eb9f5e2bf0509d46bc1143fd
git bisect good 2468f6c563bfda05b7fdbb34345d008df881777f
# good: [aaa098c98ee934b201afb82cf548d2935cb01181] source
sha:74bb4f6f4ccc6877de12d22d1d8badd955ed1144
git bisect good aaa098c98ee934b201afb82cf548d2935cb01181
# good: [a9cb2cfd88c027dd3f011d1238e3bdaa9c605745] source
sha:3dfcc485b19f918f434f34ee0157f5dca96bad43
git bisect good a9cb2cfd88c027dd3f011d1238e3bdaa9c605745
# good: [bec4368d98e83ea4b7793fdfb93511387a320c13] source
sha:547dfdd56f52e779a795aefc56c78836fdb01ca4
git bisect good bec4368d98e83ea4b7793fdfb93511387a320c13
# bad: [5ff364317212f4c42697fea05fabe188861f1bf0] source
sha:ab1b1167b52f2fe73da921eb73abc299b497d3c2
git bisect bad 5ff364317212f4c42697fea05fabe188861f1bf0
# good: [7b7479fa87566bbe21519863ea28a255cf1bc749] source
sha:1aa93766ee3994af9975e96e8ea60e02078de2d8
git bisect good 7b7479fa87566bbe21519863ea28a255cf1bc749
# bad: [d33eb6b29ebc8614f1f31d8646bb4856e199e7b1] source
sha:24ead97534d7fde86c3593705f36a39e7e7cbb08
git bisect bad d33eb6b29ebc8614f1f31d8646bb4856e199e7b1
# bad: [b40b92de18b7a4b273422161fd5ceb7480d568a8] source
sha:2be31163b54862076fed47a032761139318da02c
git bisect bad b40b92de18b7a4b273422161fd5ceb7480d568a8
# bad: [3635db0da176e0f7c0a7b3e1c6466b22453d89d2] source
sha:280016e6c7df52de040e3b086747237bb9d84e2c
git bisect bad 3635db0da176e0f7c0a7b3e1c6466b22453d89d2
# bad: [9c4fee65c4b6ce8fc5af00b76c24350f964b4096] source
sha:f8ba3e24a48752414c5f69faec7d71ba387e1441
git bisect bad 9c4fee65c4b6ce8fc5af00b76c24350f964b4096
# bad: [998e100d322541e7d24455605cd28b2fb6aa19fc] source
sha:76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb
git bisect bad 998e100d322541e7d24455605cd28b2fb6aa19fc
# good: [9c6a30c79e3a9070d5ab1df50310fe1ede6ea021] source
sha:1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433
git bisect good 9c6a30c79e3a9070d5ab1df50310fe1ede6ea021

# first bad commit: [998e100d322541e7d24455605cd28b2fb6aa19fc] source
sha:76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb

author Thorsten Behrens  2019-04-09 02:19:14 +0200
committer Katarina Behrens  2019-07-03 14:48:45 +0200
commit  76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb

tdf#113448 don't export any font for radio buttons

Adding Katarina Behrens to CC: would you please take a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: getting started with contributions in libreoffice online android app

[RUTUJA BHAGWAN KENDRE]

Thank you so much sir. I will proceed as directed.

On Mon, Feb 24, 2020, 10:08 AM Miguel Teixeira 
wrote:

> Hi!
>
> First, to get started, you should be familiar with building LibreOffice
> for Android.
>
> For this, you can use:
> *https://wiki.documentfoundation.org/Development/BuildingForAndroid
> *
>
> After fix all of your possible "first times problems" with the compilation
> and finally build your LibreOffice,
> see the fourth topic, called *"Hacking it"*.
> *https://wiki.documentfoundation.org/Development/BuildingForAndroid#Hacking_it
> *
>
> It say:
>
> *"We appreciate any help with the development - every patch counts :-) If
> you don't know what to work on, have a look at Android Most Annoying Bugs
> .*
>
> *More information about the development can be found in:*
>
>- *Cross-compiling README:
>https://cgit.freedesktop.org/libreoffice/core/tree/README.cross
>*
>- *Android development README:
>https://cgit.freedesktop.org/libreoffice/core/tree/android/README
>*
>
> *"*
>
> Have hacking fun!
> Best regards,
>
> Em seg., 24 de fev. de 2020 às 00:49, RUTUJA BHAGWAN KENDRE <
> rken...@cs.iitr.ac.in> escreveu:
>
>>Can anyone please reply, it will be very helpful to me.
>>
>>
>>
>>
>>
>>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: getting started with contributions in libreoffice online android app

[Miguel Teixeira]

Hi!

First, to get started, you should be familiar with building LibreOffice for
Android.

For this, you can use:
*https://wiki.documentfoundation.org/Development/BuildingForAndroid
*

After fix all of your possible "first times problems" with the compilation
and finally build your LibreOffice,
see the fourth topic, called *"Hacking it"*.
*https://wiki.documentfoundation.org/Development/BuildingForAndroid#Hacking_it
*

It say:

*"We appreciate any help with the development - every patch counts :-) If
you don't know what to work on, have a look at Android Most Annoying Bugs
.*

*More information about the development can be found in:*

   - *Cross-compiling README:
   https://cgit.freedesktop.org/libreoffice/core/tree/README.cross
   *
   - *Android development README:
   https://cgit.freedesktop.org/libreoffice/core/tree/android/README
   *

*"*

Have hacking fun!
Best regards,

Em seg., 24 de fev. de 2020 às 00:49, RUTUJA BHAGWAN KENDRE <
rken...@cs.iitr.ac.in> escreveu:

>Can anyone please reply, it will be very helpful to me.
>
>
>
>
>
>> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: getting started with contributions in libreoffice online android app

[RUTUJA BHAGWAN KENDRE]

   Can anyone please reply, it will be very helpful to me.





>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 130841, which changed state.

Bug 130841 Summary: kf5 main window loses status bar on macro triggered resize
https://bugs.documentfoundation.org/show_bug.cgi?id=130841

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130841] kf5 main window loses status bar on macro triggered resize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130841

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Jan-Marek Glogowski  ---
The lost status bar for kf5 is fixed. See bug 130893 for the 2nd problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130893] XWindow::SetPosSize resizing based on XWindow::GetPosSize shrinks the window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130893

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0841
 Ever confirmed|0   |1
 Blocks||102495, 103182

--- Comment #1 from Jan-Marek Glogowski  ---
Confirmed already in bug 130841.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||130893


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130893
[Bug 130893] XWindow::SetPosSize resizing based on XWindow::GetPosSize shrinks
the window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130841] kf5 main window loses status bar on macro triggered resize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130841

Jan-Marek Glogowski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0893

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||130893


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130893
[Bug 130893] XWindow::SetPosSize resizing based on XWindow::GetPosSize shrinks
the window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130893] New: XWindow::SetPosSize resizing based on XWindow::GetPosSize shrinks the window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130893

Bug ID: 130893
   Summary: XWindow::SetPosSize resizing based on
XWindow::GetPosSize shrinks the window
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: glo...@fbihome.de

This is a follow up from bug 130841, as I couldn't find a solution for this
problem, originally the 2nd bug found and described in it. The bug is easily
reproducible using the bug document from that bug. This way the other, kf5
specific bug can be closed, as it's fixed by the pushed patches.

Every time you do the non-resize, the window shrinks by the height of the
native menu bar, because of the frame geometry <> client size difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130892] FILEOPEN Percentage format in ODS pie chart is disregarded in existing files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130892

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Aron Budea  changed:

   What|Removed |Added

 Depends on||130892


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130892
[Bug 130892] FILEOPEN Percentage format in ODS pie chart is disregarded in
existing files
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130892] New: FILEOPEN Percentage format in ODS pie chart is disregarded in existing files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130892

Bug ID: 130892
   Summary: FILEOPEN Percentage format in ODS pie chart is
disregarded in existing files
   Product: LibreOffice
   Version: 6.3.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
CC: balazs.varga...@gmail.com, libreoff...@nisz.hu
Blocks: 90486

Open attachment 149666 from bug 123774.

=> The percentages should be showed with 3 decimals, but are shown with none.

This is a regression from the following commit (also backported to 6.4.0 and
6.3.5). Adding CC: to Balazs Varga.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e57d90cd4e51a1353eafc87bb29cfe6076704a7c
author  Balazs Varga 2019-12-10
12:53:08 +0100
committer   László Németh2019-12-16 08:58:25
+0100

"tdf#129173 tdf#129175 Fix number format of data labels"

When Balazs fixed bug 123774, we came to the conclusion that the fix only
applied to new files, because some chart property wasn't stored correctly
before. It seems that the same is the case here (starting with a different
commit): creating a new file with similar properties shows the percentages
correcly.

However, since plenty of files with various charts properties already exist in
the wild, old files should be handled correctly as well.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130891] Radio buttons do not work in fillable PDF forms since 6.1.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130891

--- Comment #3 from Kevin Suo  ---
Created attachment 158129
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158129=edit
test odt file exported as pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130891] Radio buttons do not work in fillable PDF forms since 6.1.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130891

--- Comment #2 from Kevin Suo  ---
Created attachment 158128
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158128=edit
test odt file with ratio buttons

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130891] Radio buttons do not work in fillable PDF forms since 6.1.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130891

Kevin Suo  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||suokunl...@126.com

--- Comment #1 from Kevin Suo  ---
Confirmed in:

版本: 6.3.5.2
Build ID: dd0751754f11728f69b42ee2af66670068624673
CPU 线程: 4; 操作系统: Linux 5.4; UI 渲染: 默认; VCL: gtk3; 
区域语言: zh-CN (zh_CN.UTF-8); UI 语言: zh-CN
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130532] Relationship graph does not show up one to one relationship

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130532

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130540] FIREBIRD JDBC: Tableeditor will show all Integer-Types as Currency Format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130540

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126835] Odd cursor movement when adding new rows to a Autoformattted table using tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126835

--- Comment #2 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111630] Truetype Font Wingdings has additional space after each character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111630

--- Comment #54 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74382] EDITING: Let Format > Character... apply to a drawing textbox to affect all text within the box

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74382

--- Comment #4 from QA Administrators  ---
Dear dg1727,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125937] Lib5-text do not open the same way in Lib6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125937

--- Comment #11 from QA Administrators  ---
Dear Jesper Friborg,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111630] Truetype Font Wingdings has additional space after each character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111630

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130891] New: Radio buttons do not work in fillable PDF forms since 6.1.6

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130891

Bug ID: 130891
   Summary: Radio buttons do not work in fillable PDF forms since
6.1.6
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leighha...@gmail.com

Description:
When using radio buttons in fillable PDF forms, they do not work.  They appear
but one cannot select them in the PDF form.  This bug has persisted since
version 6.2.

Steps to Reproduce:
1. In writer document.  place 2 x radio buttons on page
2. Export As PDF
3. Try to select the radio button or buttons.  Can't mark them as selected.

Actual Results:
Radio buttons appear on PDF output, but cannot be selected/clicked.

Expected Results:
Clicking on a radio button should activate it and change its state from
unselected to selected.  If 2 radio buttons with the same name, selected state
should change to clicked radio button, deselecting other radio button.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
This bug began in version 6.2 and has persisted in all versions of Libreoffice
since.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126400] LibreOffice math does not get focus back after using the 'elements' panel when floating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126400

--- Comment #8 from Daniel MOYNE  ---
as shown on the screenshot one formula "f(x)=2x^2+3x-5" has been substituted to
the original one. It appears with another font and corresponds to another
existing on probably copied once

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126400] LibreOffice math does not get focus back after using the 'elements' panel when floating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126400

--- Comment #7 from Daniel MOYNE  ---
Created attachment 158127
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158127=edit
screenshot of bug

screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126400] LibreOffice math does not get focus back after using the 'elements' panel when floating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126400

--- Comment #6 from Daniel MOYNE  ---
The simplest way to solve the problem is to execute the following command on
the "Element window" when it gets the focus:
++
It will then reinstall the "Element window" in the right panel of the main
window. In this case there is no further problems with the focus issue. The
same method can be applied on the "Formule editor window" when it is separated
from the main window.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_dark_svg icon-themes/sifr_svg

[rizmut (via logerrit)]

 icon-themes/sifr/links.txt |   20 ++---
 icon-themes/sifr/sd/res/click_16.png   |binary
 icon-themes/sifr/sd/res/del1bmp.png|binary
 icon-themes/sifr/sd/res/delall.png |binary
 icon-themes/sifr/sd/res/effect_16.png  |binary
 icon-themes/sifr/sd/res/effectfade_16.png  |binary
 icon-themes/sifr/sd/res/effectpath_16.png  |binary
 icon-themes/sifr/sd/res/effectshape_16.png |binary
 icon-themes/sifr/sd/res/get1obj.png|binary
 icon-themes/sifr/sd/res/getallob.png   |binary
 icon-themes/sifr/sd/res/layout_empty.png   |binary
 icon-themes/sifr/sd/res/layout_head01.png  |binary
 icon-themes/sifr/sd/res/layout_head02.png  |binary
 icon-themes/sifr/sd/res/layout_head02a.png |binary
 icon-themes/sifr/sd/res/layout_head02b.png |binary
 icon-themes/sifr/sd/res/layout_head03.png  |binary
 icon-themes/sifr/sd/res/layout_head03a.png |binary
 icon-themes/sifr/sd/res/layout_head03b.png |binary
 icon-themes/sifr/sd/res/layout_head03c.png |binary
 icon-themes/sifr/sd/res/layout_head04.png  |binary
 icon-themes/sifr/sd/res/layout_head06.png  |binary
 icon-themes/sifr/sd/res/layout_textonly.png|binary
 icon-themes/sifr/sd/res/layout_vertical01.png  |binary
 icon-themes/sifr/sd/res/layout_vertical02.png  |binary
 icon-themes/sifr_dark/links.txt|   20 ++---
 icon-themes/sifr_dark/sd/res/click_16.png  |binary
 icon-themes/sifr_dark/sd/res/del1bmp.png   |binary
 icon-themes/sifr_dark/sd/res/delall.png|binary
 icon-themes/sifr_dark/sd/res/effect_16.png |binary
 icon-themes/sifr_dark/sd/res/effectfade_16.png |binary
 icon-themes/sifr_dark/sd/res/effectpath_16.png |binary
 icon-themes/sifr_dark/sd/res/effectshape_16.png|binary
 icon-themes/sifr_dark/sd/res/get1obj.png   |binary
 icon-themes/sifr_dark/sd/res/getallob.png  |binary
 icon-themes/sifr_dark/sd/res/layout_empty.png  |binary
 icon-themes/sifr_dark/sd/res/layout_head01.png |binary
 icon-themes/sifr_dark/sd/res/layout_head02.png |binary
 icon-themes/sifr_dark/sd/res/layout_head02a.png|binary
 icon-themes/sifr_dark/sd/res/layout_head02b.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03.png |binary
 icon-themes/sifr_dark/sd/res/layout_head03a.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03b.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03c.png|binary
 icon-themes/sifr_dark/sd/res/layout_head04.png |binary
 icon-themes/sifr_dark/sd/res/layout_head06.png |binary
 icon-themes/sifr_dark/sd/res/layout_textonly.png   |binary
 icon-themes/sifr_dark/sd/res/layout_vertical01.png |binary
 icon-themes/sifr_dark/sd/res/layout_vertical02.png |binary
 icon-themes/sifr_dark_svg/sd/res/click_16.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/del1bmp.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/delall.svg|1 
 icon-themes/sifr_dark_svg/sd/res/effect_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectfade_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectpath_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectshape_16.svg|1 
 icon-themes/sifr_dark_svg/sd/res/get1obj.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/getallob.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/layout_empty.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head01.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02a.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02b.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03a.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03b.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03c.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head04.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head06.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_textonly.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/layout_vertical01.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_vertical02.svg |1 
 icon-themes/sifr_svg/sd/res/click_16.svg   |1 
 icon-themes/sifr_svg/sd/res/del1bmp.svg|1 
 icon-themes/sifr_svg/sd/res/delall.svg |1 
 icon-themes/sifr_svg/sd/res/effect_16.svg  |1 
 icon-themes/sifr_svg/sd/res/effectfade_16.svg  |1 
 icon-themes/sifr_svg/sd/res/effectpath_16.svg  |1 
 

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

--- Comment #2 from Commit Notification 
 ---
rizmut committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/626460484abcd6ced21471e4942c3b499e20552d

Sifr: fix for tdf#130885: missing Slide Layout icons

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.0.0|target:7.0.0 target:6.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130890] New: Please no false autocorrection by default!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130890

Bug ID: 130890
   Summary: Please no false autocorrection by default!
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: peter.reitin...@gmail.com

Description:
At least in German, the autocorrection by default is absolute bullshit (sorry).
When I am typing quickly, the result is absolute nonsens because of the many
wrong automatic corrections!
It was impossible to switch it off easily. I tried: 
- deactivate Extras/Automatische Rechtschreibprüfung
- deactivate Extras/Autokorrektur/Während der Eingabe

None of the above prevented libre office writer to correct words in my input
lines. Why?? I can write on my own, I do not want to be corrected. Thank you!
:-)

Actual Results:
Type german text in german LibreOffice Writer and there will be a lot of wrong
corrections that maybe make sense SOMETIMES but it is absolutely annoying to
undo all of these wrong corrections. It prevents absolutely from quick
typing!!!

Expected Results:
As said, many wrong autocorrections without any confirmation of mine


Reproducible: Always


User Profile Reset: No



Additional Info:
No autocorrections by default, only after user choses a menu or whatsoever to
make the software correct one!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130877] Resize image - SHIFT does not keep aspect ratio when using corner handles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130877

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
Do not hold SHIFT. That works at least since version 5.4 that way, that
dragging corner of an image keeps ratio and dragging side handles change ratio.
Without any SHIFT.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127801] SCROLLING: Optimal View Zoom Moves Left-Right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127801

Y  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #15 from Y  ---
My *observation* is that the current "Optimal View":
- maximize horizontal space use (very desirable)
- allows for accidental horizontal scrolling (undesirable)

My *wish* is to have a mode that:
- maximize horizontal space use, like the current "Optimal View"
- locks horizontal scrolling to prevent accidental trackpad movements, like the
current "Page Width" view

In terms of *suggestions*, I do not know if there is a use-case that makes the
current "Optimal View" horizontal scrolling behaviour desirable.  Therefore,
suggestion depends on whether horizontal scrolling has desirable function in
Optimal View.

If horizontal scrolling is desirable in Optimal View, I suggest adding a switch
to lock/unlock horizontal scrolling.

If horizontal scrolling is undesirable in Optimal View, I suggest locking
horizontal scrolling in "Optimal View."

Others have better insight than me to make the decision.  For me, horizontal
scrolling is generally rarely desirable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 127801] SCROLLING: Optimal View Zoom Moves Left-Right

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127801

Y  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #15 from Y  ---
My *observation* is that the current "Optimal View":
- maximize horizontal space use (very desirable)
- allows for accidental horizontal scrolling (undesirable)

My *wish* is to have a mode that:
- maximize horizontal space use, like the current "Optimal View"
- locks horizontal scrolling to prevent accidental trackpad movements, like the
current "Page Width" view

In terms of *suggestions*, I do not know if there is a use-case that makes the
current "Optimal View" horizontal scrolling behaviour desirable.  Therefore,
suggestion depends on whether horizontal scrolling has desirable function in
Optimal View.

If horizontal scrolling is desirable in Optimal View, I suggest adding a switch
to lock/unlock horizontal scrolling.

If horizontal scrolling is undesirable in Optimal View, I suggest locking
horizontal scrolling in "Optimal View."

Others have better insight than me to make the decision.  For me, horizontal
scrolling is generally rarely desirable.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125510] Highly visible icon missing within Sifr icon set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125510

--- Comment #18 from Thorsten Wagner  ---
Created attachment 158126
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158126=edit
Screenshot 7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125510] Highly visible icon missing within Sifr icon set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125510

--- Comment #15 from Thorsten Wagner  ---
Created attachment 158123
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158123=edit
Screenshot 4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125510] Highly visible icon missing within Sifr icon set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125510

--- Comment #17 from Thorsten Wagner  ---
Created attachment 158125
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158125=edit
Screenshot 6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125510] Highly visible icon missing within Sifr icon set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125510

--- Comment #16 from Thorsten Wagner  ---
Created attachment 158124
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158124=edit
Screenshot 5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125510] Highly visible icon missing within Sifr icon set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125510

--- Comment #14 from Thorsten Wagner  ---
Great work - Sifr becomes more and more usable!

See attached screenshots 4 to 7 to find some remaining issues:

(1) In Writer new Display Views icon is too large (see screenshot 4, red box).
Required size is shown in screenshot 5, red box to compare.

(2) In Draw there is an out of bounds icon too (see screenshot 6).

(3) It would be very nice to get rid of Breeze fallbacks. Icons to illustrate
password protected files within Startcenter have no Sifr counterparts currently
(see screenshot 7).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130889] New: Low text resolution on MacOS after update 6.3.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130889

Bug ID: 130889
   Summary: Low text resolution on MacOS after update 6.3.4.2
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nlo...@gmail.com

Description:
After an update to Version: 6.3.4.2, the quality of text in cells reduced
substantially. The text in cells is no longer crisp and clear, but rather of
low resolution. This poor resolution does not apply to the text in the
interface, only to the in-cell text. 

Steps to Reproduce:
1. Launch Calc
2. Enter text in a cell
3.

Actual Results:
Text is of low resolution

Expected Results:
Text should be crisp


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Mac OS X (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #18 from Smith Kennedy  ---
(In reply to Cor Nouws from comment #17)
> Wasn't this a use case in which you have to type TAB at the start of the
> heading to move it to the next level?

Sort of but you shouldn't have to type TAB - it should assume the right
numbering level based on the style. You shouldn't have to touch the style AND
the numbering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_dark_svg icon-themes/sifr_svg

[rizmut (via logerrit)]

 icon-themes/sifr/links.txt |   20 ++---
 icon-themes/sifr/sd/res/click_16.png   |binary
 icon-themes/sifr/sd/res/del1bmp.png|binary
 icon-themes/sifr/sd/res/delall.png |binary
 icon-themes/sifr/sd/res/effect_16.png  |binary
 icon-themes/sifr/sd/res/effectfade_16.png  |binary
 icon-themes/sifr/sd/res/effectpath_16.png  |binary
 icon-themes/sifr/sd/res/effectshape_16.png |binary
 icon-themes/sifr/sd/res/get1obj.png|binary
 icon-themes/sifr/sd/res/getallob.png   |binary
 icon-themes/sifr/sd/res/layout_empty.png   |binary
 icon-themes/sifr/sd/res/layout_head01.png  |binary
 icon-themes/sifr/sd/res/layout_head02.png  |binary
 icon-themes/sifr/sd/res/layout_head02a.png |binary
 icon-themes/sifr/sd/res/layout_head02b.png |binary
 icon-themes/sifr/sd/res/layout_head03.png  |binary
 icon-themes/sifr/sd/res/layout_head03a.png |binary
 icon-themes/sifr/sd/res/layout_head03b.png |binary
 icon-themes/sifr/sd/res/layout_head03c.png |binary
 icon-themes/sifr/sd/res/layout_head04.png  |binary
 icon-themes/sifr/sd/res/layout_head06.png  |binary
 icon-themes/sifr/sd/res/layout_textonly.png|binary
 icon-themes/sifr/sd/res/layout_vertical01.png  |binary
 icon-themes/sifr/sd/res/layout_vertical02.png  |binary
 icon-themes/sifr_dark/links.txt|   20 ++---
 icon-themes/sifr_dark/sd/res/click_16.png  |binary
 icon-themes/sifr_dark/sd/res/del1bmp.png   |binary
 icon-themes/sifr_dark/sd/res/delall.png|binary
 icon-themes/sifr_dark/sd/res/effect_16.png |binary
 icon-themes/sifr_dark/sd/res/effectfade_16.png |binary
 icon-themes/sifr_dark/sd/res/effectpath_16.png |binary
 icon-themes/sifr_dark/sd/res/effectshape_16.png|binary
 icon-themes/sifr_dark/sd/res/get1obj.png   |binary
 icon-themes/sifr_dark/sd/res/getallob.png  |binary
 icon-themes/sifr_dark/sd/res/layout_empty.png  |binary
 icon-themes/sifr_dark/sd/res/layout_head01.png |binary
 icon-themes/sifr_dark/sd/res/layout_head02.png |binary
 icon-themes/sifr_dark/sd/res/layout_head02a.png|binary
 icon-themes/sifr_dark/sd/res/layout_head02b.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03.png |binary
 icon-themes/sifr_dark/sd/res/layout_head03a.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03b.png|binary
 icon-themes/sifr_dark/sd/res/layout_head03c.png|binary
 icon-themes/sifr_dark/sd/res/layout_head04.png |binary
 icon-themes/sifr_dark/sd/res/layout_head06.png |binary
 icon-themes/sifr_dark/sd/res/layout_textonly.png   |binary
 icon-themes/sifr_dark/sd/res/layout_vertical01.png |binary
 icon-themes/sifr_dark/sd/res/layout_vertical02.png |binary
 icon-themes/sifr_dark_svg/sd/res/click_16.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/del1bmp.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/delall.svg|1 
 icon-themes/sifr_dark_svg/sd/res/effect_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectfade_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectpath_16.svg |1 
 icon-themes/sifr_dark_svg/sd/res/effectshape_16.svg|1 
 icon-themes/sifr_dark_svg/sd/res/get1obj.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/getallob.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/layout_empty.svg  |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head01.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02a.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head02b.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03a.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03b.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head03c.svg|1 
 icon-themes/sifr_dark_svg/sd/res/layout_head04.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_head06.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_textonly.svg   |1 
 icon-themes/sifr_dark_svg/sd/res/layout_vertical01.svg |1 
 icon-themes/sifr_dark_svg/sd/res/layout_vertical02.svg |1 
 icon-themes/sifr_svg/sd/res/click_16.svg   |1 
 icon-themes/sifr_svg/sd/res/del1bmp.svg|1 
 icon-themes/sifr_svg/sd/res/delall.svg |1 
 icon-themes/sifr_svg/sd/res/effect_16.svg  |1 
 icon-themes/sifr_svg/sd/res/effectfade_16.svg  |1 
 icon-themes/sifr_svg/sd/res/effectpath_16.svg  |1 
 

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

--- Comment #1 from Commit Notification 
 ---
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a9748a444e7a295a235f2db5a217884ccb4805c2

Sifr: fix for tdf#130885: missing Slide Layout icons

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98381] Pasting text at the beginning of a style changes the style to that of the pasted text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98381

--- Comment #23 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #22)
> a) Keep the source PS not only for empty target paragraphs but also ignore
> all white-space: when pasting somewhere in the middle of a paragraph it is
> very unlikely that the source PS should be applied, so just ignoring
> white-space might solve the actual problem
So if there is an paragraph with a single space, and the pasting is done at the
beginning of the paragraph: ignore the space and if the pasting is done after
the space, do not ignore it. (To make the trick even more specific.. ;) )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

Cor Nouws  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
Version|3.5.7.2 release |Inherited From OOo

--- Comment #17 from Cor Nouws  ---
Wasn't this a use case in which you have to type TAB at the start of the
heading to move it to the next level?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

--- Comment #4 from muso  ---
I just notice that there is even a dataloss:the "l" in "AgCl" is not shown in
Writer and also not in the PDF export

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130888] New: Basic is Faulty in creating / deleting User Defined Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130888

Bug ID: 130888
   Summary: Basic is Faulty in creating / deleting User Defined
Properties
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: atem...@rogers.com

I created the BASIC example below that illustrates and replicates the bug. You
can copy this code into any Writer document's Basic IDE, compile it, then run
the macros as I'll outline.

The problem is that I can create a User Defined Property from a BASIC macro,
and I can then access it, and print its current value. But if I try to use
another macro to delete the UDP, I get a run-time error. (It gets even weirder
than this.) You can reproduce this bug as follows:

First of all, you can run BugTest1() to create the UDP, "UDP1" with value:
"This is a User Defined Property!"

Next, run BugTest2(). It will simply access the new UDP and print its current
value in a MsgBox(). So far, so good. Now comes the bizarre behavior.

Now run BugTest3() which simply tries to delete the newly created UDP. (By
DeleteUDProperty("UDP1")) It results in a run-time error.

There is more odd behavior to explain here. To begin with, after you've run
BugTest1() to create the UDP, then go to File --> Properties --> Custom
Properties, you won't find the newly created UDP listed there. BUT -- when you
run BugTest2() it can somehow access it, and display its value. BugTest3() as
shown cannot delete it. Now, if you've run the three tests, had the run-time
error, and now save the file AND CLOSE IT, then reopen it, then look at the
UDPs (File --> Properties --> Custom Properties) you'll see that the UDP we
created with BugTest1() has suddenly shown up in the list. If you NOW run
ButTest3(), you'll see that the UDP can now be successfully deleted by the
macro without generating any run-time error.

Again, you can use BugTest1() to create the UDP, then click on the Save icon to
save the file, and still the UDP will not be listed in the Custom Properties.
You must actually close the document, and then reopen it to get it listed.

I can also confirm that this bug is present in OpenOffice 4.1.6 and behaves
exactly the same, so this was almost certainly something that Libre inherited
when it was forked. (I also upgraded to Libre 6.3.4.2 before filing this
report, just to make sure it still persists.)

Being a long-time, amateur programmer, the most likely explanation that I can
think of for this behavior is that the UDPs appear to be read from the document
into some temporary store that is accessed by all the macro functions
(hasPropertyByName(), addProperty(), setPropertyValue() and
getPropertyValue()). Whatever modifications occur here seem to be held back and
are only written to the document when it is closed. On the other hand,
removeProperty() seems to access a different store of the UDPs, possibly the
document itself, so it can't delete a UDP that the other functions create until
AFTER the document has actually been closed and reopened.

I hope this is a clear-enough explanation of what's happening. Thanks.



'
-


Sub CreateUDProperty(UDProp As String, Value As String)

  DocUDProps = ThisComponent.DocumentProperties.UserDefinedProperties

  If DocUDProps.getPropertySetInfo().hasPropertyByName(UDProp) = false Then
 DocUDProps.addProperty(UDProp, 0, Value)
  Else
 DocUDProps.setPropertyValue(UDProp, Value)
  End If

End Sub



Sub DeleteUDProperty(UDProp As String)

  DocUDProps = ThisComponent.DocumentProperties.UserDefinedProperties

  If DocUDProps.getPropertySetInfo().hasPropertyByName(UDProp) = True Then
 MsgBox("About to delete " & UDProp)
 MsgBox("Current value of " & UDProp & " is " &
DocUDProps.getPropertyValue(UDProp))
 DocUDProps.removeProperty(UDProp)
  End If

End Sub


Sub BugTest1()

  CreateUDProperty("UDP1", "This is a User Defined Property!")
  MsgBox("Created UDP1.")

End Sub


Sub BugTest2()

  DocUDProps = ThisComponent.DocumentProperties.UserDefinedProperties

  If DocUDProps.getPropertySetInfo().hasPropertyByName("UDP1") Then
 MsgBox("Here is UDP1: " & DocUDProps.getPropertyValue("UDP1")
  Else
 MsgBox("Can't find UDP1!")
  End If

End Sub


Sub BugTest3()

  DeleteUDProperty("UDP1")

End Sub

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127020] Fonts are blurry on MacOS Retina displays

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127020

Daniel Fyles  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---

--- Comment #2 from Daniel Fyles  ---
As of LibreOffice 6.3.4.2 this bug is back, exactly as described previously.

Which is to say that most of the UI is the correct resolution, but all of the
document and some UI elements are "blurred".

This is running on an iMac Retina 5K, 27inch, Late 2015
MacOS Catalina 10.15.3

I'd be more than happy to provide any further details required.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

--- Comment #3 from muso  ---
Created attachment 158122
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158122=edit
test file containing the SVG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

--- Comment #2 from muso  ---
Created attachment 158121
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158121=edit
PDF export result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122586] Classification: by using the dialog, Watermark text from policy is not placed in the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122586

Cor Nouws  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #8 from Cor Nouws  ---
(In reply to Dieter from comment #6)
> I'm not sure, if I did it right, but for me it seems to be fixed in
> 
> Version: 6.2.5.2 (x64)
> 
> Cor, are you still able to reproduce it? => NEEDINFO
Still a problem in Versie: 6.4.0.3
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU-threads: 8; Besturingssysteem: Linux 5.3; UI-render: standaard; VCL: gtk3; 
Locale: nl-NL (en_US.UTF-8); UI-taal: nl-NL
Calc: threaded

New document > Toolbar > Confidential
  > Watermark in document

New document > Dialog > Confidential > OK
  > NO Watermark in document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

muso  changed:

   What|Removed |Added

 Attachment #158120|screenshot on how it liooks |screenshot on how it looks
description|in Writer   |in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

--- Comment #1 from muso  ---
Created attachment 158120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158120=edit
screenshot on how it liooks in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130887] New: SVG display issue with outlined text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130887

Bug ID: 130887
   Summary: SVG display issue with outlined text
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: uwesto...@web.de

Created attachment 158119
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158119=edit
the SVG file to test

Writer has a problem with displaying test:

- open a new document
- insert the attached SVG

result: the text "Diaphragm" is displayed bold despite this it not the case in
the SVG.

- now export the document to PDF

result: I attached the PDF I get and you can see that "Diaphragm" is now
correct but the text "Housing" is no longer a vector text but a pixel text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115078] Automatically insert a decimal point like in Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115078

--- Comment #20 from Cor Nouws  ---
(In reply to cknapp from comment #19)
> Is there a bounty program here for features? I'd throw $50 at the project if
Thanks for this positive gesture!

> this can at least get put on the list to be added in the next year or two.
There is not yet a bounty program, but possibly it will be there somewhere in
this year?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

[Szymon Kłos (via logerrit)]

 sw/uiconfig/swriter/ui/wordcount.ui |  700 ++--
 1 file changed, 506 insertions(+), 194 deletions(-)

New commits:
commit 542f509a41cf0cae7fca0660ba3858c6b0e9bf52
Author: Szymon Kłos 
AuthorDate: Thu Feb 20 11:39:52 2020 +0100
Commit: Szymon Kłos 
CommitDate: Sun Feb 23 22:05:33 2020 +0100

Put labels in boxes to avoid reordering in online

Change-Id: I2bfb05d36703b1c9cd8d22bf1f95b87e16631825
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89205
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sw/uiconfig/swriter/ui/wordcount.ui 
b/sw/uiconfig/swriter/ui/wordcount.ui
index c9d4a82bf46d..4c73c8d117f2 100644
--- a/sw/uiconfig/swriter/ui/wordcount.ui
+++ b/sw/uiconfig/swriter/ui/wordcount.ui
@@ -69,50 +69,117 @@
 6
 12
 
-  
+  
 True
 False
-Words
-1
+vertical
+
+  
+True
+False
+end
+Selection
+
+  
+
+  
+  
+False
+True
+0
+  
+
   
   
-0
-1
+1
+0
   
 
 
-  
+  
 True
 False
-Characters including spaces
-1
+vertical
+
+  
+False
+end
+Document
+
+  
+
+  
+  
+False
+True
+0
+  
+
   
   
-0
-2
+1
+6
   
 
 
-  
+  
+False
+end
+Document
+
+  
+
+  
+  
+2
+0
+  
+
+
+  
 True
 False
-Characters excluding spaces
-1
+vertical
+
+  
+True
+False
+Words
+1
+  
+  
+False
+True
+0
+  
+
   
   
 0
-3
+1
   
 
 
-  
+  
 True
 False
-end
-True
-0
-right
-1
+vertical
+
+  
+True
+False
+end
+True
+0
+right
+1
+  
+  
+False
+True
+0
+  
+
   
   
 1
@@ -120,100 +187,179 @@
   
 
 
-  
+  
 True
 False
-end
-True
-0
-right
-1
+vertical
+
+  
+False
+end
+True
+0
+right
+1
+  
+  
+False
+True
+0
+  
+
   
   
-1
-2
+2
+1
   
 
 
-  
+  
 True
 False
-end
-True
-0
-right
-1
+vertical
+
+  
+True
+False
+Characters including spaces
+1
+  
+  
+False
+True
+0
+  
+ 

[Libreoffice-commits] core.git: sw/source sw/uiconfig

[Szymon Kłos (via logerrit)]

 sw/source/ui/dialog/wordcountdialog.cxx  |   41 ++
 sw/source/uibase/inc/wordcountdialog.hxx |8 +
 sw/uiconfig/swriter/ui/wordcount.ui  |  184 ---
 3 files changed, 216 insertions(+), 17 deletions(-)

New commits:
commit 4ab0993f2537fade3c02b788508519070f44ebb8
Author: Szymon Kłos 
AuthorDate: Thu Feb 20 11:24:05 2020 +0100
Commit: Szymon Kłos 
CommitDate: Sun Feb 23 22:05:01 2020 +0100

WordCountDIalog in vertical mobile version

Change-Id: I335bee6fd03c202cb7e82b3205a92b48f5e861a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89204
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sw/source/ui/dialog/wordcountdialog.cxx 
b/sw/source/ui/dialog/wordcountdialog.cxx
index 7dc7370f4b82..5e4b3aa0208d 100644
--- a/sw/source/ui/dialog/wordcountdialog.cxx
+++ b/sw/source/ui/dialog/wordcountdialog.cxx
@@ -28,6 +28,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+
+#define IS_MOBILE (comphelper::LibreOfficeKit::isActive() && 
comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView()))
 
 SwWordCountFloatDlg::~SwWordCountFloatDlg()
 {
@@ -83,6 +87,8 @@ void SwWordCountFloatDlg::showCJK(bool bShowCJK)
 m_xCurrentCjkcharsFT->set_visible(bShowCJK);
 m_xDocCjkcharsFT->set_visible(bShowCJK);
 m_xCjkcharsLabelFT->set_visible(bShowCJK);
+if (m_xCjkcharsLabel2FT.get())
+m_xCjkcharsLabel2FT->set_visible(bShowCJK);
 }
 
 void SwWordCountFloatDlg::showStandardizedPages(bool bShowStandardizedPages)
@@ -90,6 +96,8 @@ void SwWordCountFloatDlg::showStandardizedPages(bool 
bShowStandardizedPages)
 m_xCurrentStandardizedPagesFT->set_visible(bShowStandardizedPages);
 m_xDocStandardizedPagesFT->set_visible(bShowStandardizedPages);
 m_xStandardizedPagesLabelFT->set_visible(bShowStandardizedPages);
+if (m_xStandardizedPagesLabel2FT.get())
+m_xStandardizedPagesLabel2FT->set_visible(bShowStandardizedPages);
 }
 
 SwWordCountFloatDlg::SwWordCountFloatDlg(SfxBindings* _pBindings,
@@ -97,19 +105,42 @@ SwWordCountFloatDlg::SwWordCountFloatDlg(SfxBindings* 
_pBindings,
  weld::Window *pParent,
  SfxChildWinInfo const * pInfo)
 : SfxModelessDialogController(_pBindings, pChild, pParent, 
"modules/swriter/ui/wordcount.ui", "WordCountDialog")
+, m_xCloseButton(m_xBuilder->weld_button("close"))
+, m_xHelpButton(m_xBuilder->weld_button("help"))
+, m_xDocumentLabelFT(m_xBuilder->weld_label(IS_MOBILE ? 
"documentlabel-mobile" : "documentlabel"))
+, m_xWordsLabelFT(m_xBuilder->weld_label(IS_MOBILE ? "wordslabel-mobile" : 
"wordslabel"))
+, m_xIncludingSpacesLabelFT(m_xBuilder->weld_label(IS_MOBILE ? 
"inclspaceslabel-mobile" : "inclspaceslabel"))
+, m_xExcludingSpacesLabelFT(m_xBuilder->weld_label(IS_MOBILE ? 
"exclspaceslabel-mobile" : "exclspaceslabel"))
 , m_xCurrentWordFT(m_xBuilder->weld_label("selectwords"))
 , m_xCurrentCharacterFT(m_xBuilder->weld_label("selectchars"))
 , 
m_xCurrentCharacterExcludingSpacesFT(m_xBuilder->weld_label("selectcharsnospaces"))
 , m_xCurrentCjkcharsFT(m_xBuilder->weld_label("selectcjkchars"))
 , 
m_xCurrentStandardizedPagesFT(m_xBuilder->weld_label("selectstandardizedpages"))
-, m_xDocWordFT(m_xBuilder->weld_label("docwords"))
-, m_xDocCharacterFT(m_xBuilder->weld_label("docchars"))
-, 
m_xDocCharacterExcludingSpacesFT(m_xBuilder->weld_label("doccharsnospaces"))
-, m_xDocCjkcharsFT(m_xBuilder->weld_label("doccjkchars"))
-, m_xDocStandardizedPagesFT(m_xBuilder->weld_label("docstandardizedpages"))
+, m_xDocWordFT(m_xBuilder->weld_label(IS_MOBILE ? "docwords-mobile" : 
"docwords"))
+, m_xDocCharacterFT(m_xBuilder->weld_label(IS_MOBILE ? "docchars-mobile" : 
"docchars"))
+, m_xDocCharacterExcludingSpacesFT(m_xBuilder->weld_label(IS_MOBILE ? 
"doccharsnospaces-mobile" : "doccharsnospaces"))
+, m_xDocCjkcharsFT(m_xBuilder->weld_label(IS_MOBILE ? "doccjkchars-mobile" 
: "doccjkchars"))
+, m_xDocStandardizedPagesFT(m_xBuilder->weld_label(IS_MOBILE ? 
"docstandardizedpages-mobile" : "docstandardizedpages"))
 , m_xCjkcharsLabelFT(m_xBuilder->weld_label("cjkcharsft"))
+, m_xCjkcharsLabel2FT(IS_MOBILE ? m_xBuilder->weld_label("cjkcharsft2") : 
nullptr)
 , m_xStandardizedPagesLabelFT(m_xBuilder->weld_label("standardizedpages"))
+, m_xStandardizedPagesLabel2FT(IS_MOBILE ? 
m_xBuilder->weld_label("standardizedpages2") : nullptr)
 {
+if (IS_MOBILE)
+{
+m_xCloseButton->set_visible(false);
+m_xHelpButton->set_visible(false);
+}
+
+m_xDocumentLabelFT->show();
+m_xDocWordFT->show();
+m_xDocCharacterFT->show();
+m_xDocCharacterExcludingSpacesFT->show();
+
+m_xWordsLabelFT->show();
+m_xIncludingSpacesLabelFT->show();
+m_xExcludingSpacesLabelFT->show();
+
 showCJK(SvtCJKOptions().IsAnyEnabled());
 

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/map/handler/Map.TouchGesture.js |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit ac961d7b67fcb5fb97cb6a620c913debb74ba8c1
Author: Ashod Nakashian 
AuthorDate: Sun Feb 23 13:42:26 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 22:04:48 2020 +0100

leaflet: don't process multi-taps as single-tap

Change-Id: Ifaad116c5c6fb34ac40a12113a1d3b7532a8d7ac
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89311
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/map/handler/Map.TouchGesture.js 
b/loleaflet/src/map/handler/Map.TouchGesture.js
index c0d4bb4ce..849f64d69 100644
--- a/loleaflet/src/map/handler/Map.TouchGesture.js
+++ b/loleaflet/src/map/handler/Map.TouchGesture.js
@@ -302,6 +302,20 @@ L.Map.TouchGesture = L.Handler.extend({
},
 
_onTap: function (e) {
+
+   // We receive each tap here, even when double- and triple-taps
+   // are detected. This is undesirable as the subsequent taps
+   // processed here interfere with the double- and triple-tap
+   // handlers, confusing Core (and the user) as the result
+   // is not what's expected (objects not getting selected,
+   // edit mode not entered, or toggled, keyboard toggles, etc.).
+   // We only process the first tap and subsequent ones are handled
+   // by the double-tap and triple-tap handlers below.
+   // Note: Hammer has requireFailure() which supressses this call
+   // when multi-taps are detected. This isn't working for us.
+   if (e.tapCount > 1)
+   return;
+
var point = e.pointers[0],
containerPoint = 
this._map.mouseEventToContainerPoint(point),
layerPoint = 
this._map.containerPointToLayerPoint(containerPoint),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/map/handler/Map.TouchGesture.js |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit ecab3d959854f5955d165f8a6b9b8ea01447f1d7
Author: Ashod Nakashian 
AuthorDate: Sat Feb 22 11:26:14 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 22:04:30 2020 +0100

leaflet: tolerate larger multi-tap threshold

When double-tapping (or tripple) the user is almost
always going to place their finger at different
coordinates for each of the taps. There is a default
threshold of 10 units between the taps in Hammer
to tolerate for this error when detecting multiple
taps, rather than individual taps.

This threshold of 10 is really small and unrealistic
for our needs, as in most cases double-tapping (which
we use very often to select words and begin editing
in Impress) is not detected (single-taps are issued
instead). This makes interaction/usability very hard.

Here we increase the threshold to a comfortable 100.
If this causes any other usability issues, we can
lower it acccordingly, but so far it only improved
the experience for me.

Change-Id: I3fee43c3efaa4507cae09b7c564cb4c0c1b5384e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89310
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/map/handler/Map.TouchGesture.js 
b/loleaflet/src/map/handler/Map.TouchGesture.js
index 3259f94d5..c0d4bb4ce 100644
--- a/loleaflet/src/map/handler/Map.TouchGesture.js
+++ b/loleaflet/src/map/handler/Map.TouchGesture.js
@@ -48,7 +48,14 @@ L.Map.TouchGesture = L.Handler.extend({
 
var singleTap = this._hammer.get('tap');
var doubleTap = this._hammer.get('doubletap');
-   var tripleTap = new Hammer.Tap({event: 'tripletap', 
taps: 3 });
+
+   // Multi-tap detection tolerates a slight change in 
coordinates
+   // between the taps. The default of 10 is too small for 
our needs.
+   // So we use something more sensible to make it easier 
for users.
+   var posThreshold = 100;
+   doubleTap.options.posThreshold = posThreshold;
+
+   var tripleTap = new Hammer.Tap({event: 'tripletap', 
taps: 3, posThreshold: posThreshold });
this._hammer.add(tripleTap);
tripleTap.recognizeWith([doubleTap, singleTap]);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/helpers.hpp test/test.cpp

[Ashod Nakashian (via logerrit)]

 test/helpers.hpp |   76 ---
 test/test.cpp|   48 +++---
 2 files changed, 100 insertions(+), 24 deletions(-)

New commits:
commit c742ca10118f19fa2af9671b97a3ee0ad71f5c0a
Author: Ashod Nakashian 
AuthorDate: Sun Feb 23 13:32:10 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 22:04:04 2020 +0100

wsd: improve test logging

Logs from test are now more atomic (less interleaving).
And each integration-test (old-style tests running from
new-style tests) will now print clearly when it begins
and when it fails, making it easier to find failures.
Misc other minor cleanups in test logging.

Change-Id: Iff664e42a04d1c6dbf1332b2884c35183ef85e21
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89309
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/test/helpers.hpp b/test/helpers.hpp
index 1a0205475..32ed6efc7 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -31,7 +31,6 @@
 
 #include 
 #include "common/FileUtil.hpp"
-#include "test/test.hpp"
 #include 
 #include 
 
@@ -41,22 +40,71 @@
 
 // Oh dear std::cerr and/or its re-direction is not
 // necessarily thread safe on Linux
+// This is the canonical test log function.
+inline void writeTestLog(const char* const p)
+{
+fputs(p, stderr);
+fflush(stderr);
+}
+
+inline void writeTestLog(const std::string& s) { writeTestLog(s.c_str()); }
+
 #ifdef TST_LOG_REDIRECT
-  void tstLog(const std::ostringstream );
+void tstLog(const std::ostringstream& stream);
 #else
-  inline void tstLog(const std::ostringstream )
-  {
-  fprintf(stderr, "%s", stream.str().c_str());
-  }
+inline void tstLog(const std::ostringstream& stream) { 
writeTestLog(stream.str()); }
 #endif
-#define TST_LOG_NAME_BEGIN(NAME, X) do { \
-char t[64]; Poco::DateTime time; snprintf(t, 
sizeof(t), "%.2u:%.2u:%.2u.%.6u (@%zums) ", \
-time.hour(), time.minute(), time.second(), 
time.millisecond() * 1000 + time.microsecond(), 
helpers::timeSinceTestStartMs()); \
-std::ostringstream str; str << NAME << t << X; 
tstLog(str); } while (false)
-#define TST_LOG_BEGIN(X) TST_LOG_NAME_BEGIN(testname, X)
-#define TST_LOG_APPEND(X) do { std::ostringstream str; str << X; tstLog(str); 
} while (false)
-#define TST_LOG_END do { std::ostringstream str; str << "| " << __FILE__ << 
':' << __LINE__ << std::endl; tstLog(str); } while (false)
-#define TST_LOG_NAME(NAME, X) TST_LOG_NAME_BEGIN(NAME, X); TST_LOG_END
+
+#define TST_LOG_NAME_BEGIN(OSS, NAME, X, FLUSH)
\
+do 
\
+{  
\
+char t[64];
\
+Poco::DateTime time;   
\
+snprintf(t, sizeof(t), "%.2u:%.2u:%.2u.%.6u (@%zums) ", time.hour(), 
time.minute(),\
+ time.second(), time.millisecond() * 1000 + 
time.microsecond(),\
+ helpers::timeSinceTestStartMs()); 
\
+OSS << NAME << t << X; 
\
+if (FLUSH) 
\
+tstLog(OSS);   
\
+} while (false)
+
+#define TST_LOG_BEGIN(X)   
\
+do 
\
+{  
\
+std::ostringstream oss;
\
+TST_LOG_NAME_BEGIN(oss, testname, X, true);
\
+} while (false)
+
+#define TST_LOG_APPEND(X)  
\
+do 
\
+{  
\
+std::ostringstream str;
\
+str << X;  
\
+tstLog(str);   
\
+} while (false)
+
+#define TST_LOG_END_X(OSS)   

[Libreoffice-commits] online.git: common/Unit.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD.cpp

[Ashod Nakashian (via logerrit)]

 common/Unit.cpp|4 ++--
 wsd/DocumentBroker.cpp |4 ++--
 wsd/DocumentBroker.hpp |4 ++--
 wsd/LOOLWSD.cpp|9 -
 4 files changed, 14 insertions(+), 7 deletions(-)

New commits:
commit 18ab1ccaed1db2dc7c306166fbc0730f8fad9570
Author: Ashod Nakashian 
AuthorDate: Sun Feb 23 13:24:07 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 21:48:07 2020 +0100

wsd: cleanly shutdown when unittest times out

Termination flag is a very harsh way of exiting.
It works in most cases, but not when we have a
modified document. What happens is the following:

Unit-test flags for termination.
During session cleanup we have to save the modified doc.
Because save is in progress we don't 'disconnect' the view.
This leaves the view in loaded state until saving is done.
But because of the termination flag we don't wait for saving.
DocBroker sends 'exit' to child to forcefully exit.
This causes at least one assertion due to active LOKWindows (Sidebar).

Instead of the above, we flag for graceful shutdown from unittests,
and after we wait to cleanup all DocBrokers, we flag for termination.
This way, we get clean shutdown and all assertions/validations
pass, while we guarantee never to deadlock the unittests,
in case we end up waiting forever for shutdown to complete.

Change-Id: I7fc34137ea373e329795b1ed0090261c085e955a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89308
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/common/Unit.cpp b/common/Unit.cpp
index 82cd82342..b34466c39 100644
--- a/common/Unit.cpp
+++ b/common/Unit.cpp
@@ -203,10 +203,10 @@ void UnitBase::exitTest(TestResult result)
 return;
 }
 
-LOG_INF("exitTest: " << (int)result << ". Flagging for termination.");
+LOG_INF("exitTest: " << (int)result << ". Flagging to shutdown.");
 _setRetValue = true;
 _retValue = result == TestResult::Ok ? EX_OK : EX_SOFTWARE;
-SigUtil::setTerminationFlag();
+SigUtil::requestShutdown();
 SocketPoll::wakeupWorld();
 }
 
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 1eed16ea0..88c22a303 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1381,8 +1381,8 @@ size_t DocumentBroker::removeSession(const std::string& 
id)
 << " sessions. IsReadOnly: " << session->isReadOnly()
 << ", IsViewLoaded: " << session->isViewLoaded() << ", 
IsWaitDisconnected: "
 << session->inWaitDisconnected() << ", MarkToDestroy: " << 
_markToDestroy
-<< ", LastEditableSession: " << lastEditableSession
-<< ", dontSaveIfUnmodified: " << dontSaveIfUnmodified);
+<< ", LastEditableSession: " << lastEditableSession << ", 
DontSaveIfUnmodified: "
+<< dontSaveIfUnmodified << ", IsPossiblyModified: " << 
isPossiblyModified());
 
 // If last editable, save and don't remove until after uploading to 
storage.
 if (!lastEditableSession || !autoSave(isPossiblyModified(), 
dontSaveIfUnmodified))
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 890e89e38..5e3bea9aa 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -113,7 +113,7 @@ public:
 // Request the child to exit
 if (isAlive())
 {
-LOG_DBG("Stopping ChildProcess [" << _pid << "]");
+LOG_DBG("Stopping ChildProcess [" << _pid << "] by sending 
'exit' command.");
 sendTextFrame("exit");
 }
 
@@ -126,7 +126,7 @@ public:
 LOG_ERR("Error while closing child process: " << ex.what());
 }
 
-_pid = -1;
+_pid = -1; // Detach from child.
 }
 
 /// Kill or abandon the child.
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 678b4ddc6..f9fc062e2 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -3518,9 +3518,10 @@ int LOOLWSD::innerMain()
 SigUtil::requestShutdown();
 }
 #endif
+
 // Don't stop the DocBroker, they will exit.
 constexpr size_t sleepMs = 500;
-constexpr size_t count = (COMMAND_TIMEOUT_MS * 4) / sleepMs;
+constexpr size_t count = (COMMAND_TIMEOUT_MS * 6) / sleepMs;
 for (size_t i = 0; i < count; ++i)
 {
 std::unique_lock docBrokersLock(DocBrokersMutex);
@@ -3535,6 +3536,12 @@ int LOOLWSD::innerMain()
 std::this_thread::sleep_for(std::chrono::milliseconds(sleepMs));
 }
 
+if (UnitWSD::isUnitTesting() && !SigUtil::getTerminationFlag())
+{
+LOG_INF("Setting TerminationFlag to avoid deadlocking unittest.");
+SigUtil::setTerminationFlag();
+}
+
 // Disable thread checking - we'll now cleanup lots of things if we can
 Socket::InhibitThreadChecks = true;
 SocketPoll::InhibitThreadChecks = true;
___
Libreoffice-commits mailing list

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/core/Socket.js |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit c17fd41dbc31faa0357da91b688f7d4d2c8d9bd1
Author: Ashod Nakashian 
AuthorDate: Fri Feb 21 06:14:27 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 21:47:41 2020 +0100

leaflet: reuse Socket._doSend to send and log

Change-Id: Ie7fb45972b4f1c132b57012d1e4f01681352dc8b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89197
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index 49bdc41d5..a173ef784 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -138,12 +138,7 @@ L.Socket = L.Class.extend({
}
 
if (socketState === 1) {
-   this.socket.send(msg);
-   // Only attempt to log text frames, not binary ones.
-   if (typeof msg === 'string') {
-   L.Log.log(msg, L.OUTGOING, coords);
-   this._logSocket('OUTGOING', msg);
-   }
+   this._doSend(msg);
}
else {
// push message while trying to connect socket again.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Log.hpp wsd/Storage.cpp

[Ashod Nakashian (via logerrit)]

 common/Log.hpp  |  219 
 wsd/Storage.cpp |1 
 2 files changed, 113 insertions(+), 107 deletions(-)

New commits:
commit ddd3108767af2da6933044d182ca68c139141afe
Author: Ashod Nakashian 
AuthorDate: Wed Feb 19 22:00:08 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Sun Feb 23 21:46:55 2020 +0100

wsd: logging improvements and formatting

Some multi-line log entries were missing
because we didn't flush.

Change-Id: Iabf9e6f1ffee707ff51b831a12c7990f35bb7913
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89196
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/common/Log.hpp b/common/Log.hpp
index 495b4f0e9..35aaa0834 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -257,146 +257,153 @@ namespace Log
 #else
 // We know that when building with Xcode, __FILE__ will always be a full path, 
with several slashes,
 // so this will always work. We want just the file name, they are unique 
anyway.
-#define LOG_FILE_NAME(f) (strrchr(f, '/')+1)
+#define LOG_FILE_NAME(f) (strrchr(f, '/') + 1)
 #endif
 
-#define LOG_END(LOG, FILEP) \
-do  \
-{   \
-if (FILEP)  \
-LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; \
+#define LOG_END(LOG, FILEP)
\
+do 
\
+{  
\
+if (FILEP) 
\
+LOG << "| " << LOG_FILE_NAME(__FILE__) << ':' << __LINE__; 
\
+LOG.flush();   
\
 } while (false)
 
 #ifdef __ANDROID__
 
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
 \
-char b_[1024]; 
 \
-std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL), 
std::ostringstream::ate); \
-oss_ << std::boolalpha << X;   
 \
-LOG_END(oss_, FILEP);  
 \
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
+char b_[1024]; 
\
+std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL), 
std::ostringstream::ate);\
+oss_ << std::boolalpha << X;   
\
+LOG_END(oss_, FILEP);  
\
 ((void)__android_log_print(ANDROID_LOG_DEBUG, "loolwsd", "%s %s", LVL, 
oss_.str().c_str()))
 
 #else
 
-#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
 \
-Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
 \
-char b_[1024]; 
 \
-std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL), 
std::ostringstream::ate); \
-oss_ << std::boolalpha << X;   
 \
-LOG_END(oss_, FILEP);  
 \
-m_.setText(oss_.str());
 \
+#define LOG_BODY_(LOG, PRIO, LVL, X, FILEP)
\
+Poco::Message m_(LOG.name(), "", Poco::Message::PRIO_##PRIO);  
\
+char b_[1024]; 
\
+std::ostringstream oss_(Log::prefix(b_, sizeof(b_) - 1, LVL), 
std::ostringstream::ate);\
+oss_ << std::boolalpha << X;   
\
+LOG_END(oss_, FILEP);  
\
+m_.setText(oss_.str());
\
 LOG.log(m_);
 
 #endif
 
-#define LOG_TRC(X)  \
-do  \
-{   \
-auto _ = Log::logger(); \
-if (!Log::isShutdownCalled() && log_.trace()) \
-{   \
-

[Libreoffice-bugs] [Bug 130681] Charts disappear when saving docx as odt

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130681

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:7.0.0|

--- Comment #29 from Julien Nabet  ---
Just another patch related too this one but not the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130681] Charts disappear when saving docx as odt

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130681

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114931] UI: Expert Configuration dialog - Left key do not work in list of properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114931

Cor Nouws  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #2 from Cor Nouws  ---
@caolan: maybe you are interested in this one too? thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130681] Charts disappear when saving docx as odt

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130681

--- Comment #28 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/17f49b0cddaac5657a9c308328215a0eb3a87442

Related tdf#130681: use "Standard" page style if nothing else found

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Julien Nabet (via logerrit)]

 chart2/source/view/main/ChartView.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 17f49b0cddaac5657a9c308328215a0eb3a87442
Author: Julien Nabet 
AuthorDate: Sat Feb 15 17:36:52 2020 +0100
Commit: Julien Nabet 
CommitDate: Sun Feb 23 20:42:46 2020 +0100

Related tdf#130681: use "Standard" page style if nothing else found

Opening docx from 
https://bugs.documentfoundation.org/attachment.cgi?id=157891
I noticed this log:

warn:chart2:151346:151346:chart2/source/view/main/ChartView.cxx:1406:DBG_UNHANDLED_EXCEPTION
 in
void chart::{anonymous}::lcl_setDefaultWritingMode(const 
std::shared_ptr&, chart::ChartModel&) exception: 
com.sun.star.container.NoSuchElementException

bt:
0  0x7fffd652d857 in chart::(anonymous 
namespace)::lcl_setDefaultWritingMode(std::shared_ptr 
const&, chart::ChartModel&)
(pDrawModelWrapper=std::shared_ptr (use count 
1, weak count 0) = {...}, rModel=...) at 
/home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1386
1  0x7fffd6533d3f in chart::ChartView::createShapes() 
(this=0x5b750050) at 
/home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2461
2  0x7fffd65340d6 in chart::ChartView::impl_updateView(bool) 
(this=0x5b750050, bCheckLockedCtrler=true) at 
/home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2530
3  0x7fffd652fc7c in 
chart::ChartView::getExplicitValuesForAxis(com::sun::star::uno::Reference,
 chart::ExplicitScaleData&, chart::ExplicitIncrementData&)
   (this=0x5b750050, xAxis=uno::Reference to (chart::Axis *) 
0x5b88fe68, rExplicitScale=..., rExplicitIncrement=...) at 
/home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1703
4  0x7fffd5e00ce9 in 
chart::wrapper::Chart2ModelContact::getExplicitValuesForAxis(com::sun::star::uno::Reference
 const&, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) 
(this=0x5b74b330, xAxis=uno::Reference to (chart::Axis *) 0x5b88fe68, 
rOutExplicitScale=..., rOutExplicitIncrement=...)
   at 
/home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx:141
5  0x7fffd5e6203d in 
chart::wrapper::WrappedScaleProperty::getPropertyValue(chart::wrapper::WrappedScaleProperty::tScaleProperty,
 com::sun::star::uno::Reference const&) 
const (this=0x5b8214d0, 
eScaleProperty=chart::wrapper::WrappedScaleProperty::SCALE_PROP_MAX, 
xInnerPropertySet=uno::Reference to (chart::Axis *) 0x5b88feb0)
   at 
/home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:365
6  0x7fffd5e61256 in 
chart::wrapper::WrappedScaleProperty::getPropertyValue(com::sun::star::uno::Reference
 const&) const
   (this=0x5b8214d0, xInnerPropertySet=uno::Reference to (chart::Axis 
*) 0x5b88feb0) at 
/home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:134
7  0x7fffd6785913 in 
chart::WrappedProperty::getPropertyState(com::sun::star::uno::Reference
 const&) const
   (this=0x5b8214d0, xInnerPropertyState=uno::Reference to (chart::Axis 
*) 0x5b88ff10) at 
/home/julien/lo/libreoffice/chart2/source/tools/WrappedProperty.cxx:105
8  0x7fffd678721a in 
chart::WrappedPropertySet::getPropertyState(rtl::OUString const&) 
(this=0x5b818aa0, rPropertyName="Max")
   at 
/home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:285
9  0x7fffd67874ae in 
chart::WrappedPropertySet::getPropertyStates(com::sun::star::uno::Sequence
 const&) (this=0x5b818aa0, rNameSeq=uno::Sequence of length 82 = {...})
   at 
/home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:315
10 0x7fffed317df6 in (anonymous 
namespace)::FilterPropertiesInfo_Impl::FillPropertyStateArray(std::__debug::vector >&, 
com::sun::star::uno::Reference const&, 
rtl::Reference const&, bool) (this=0x5b822090, 
rPropStates=std::__debug::vector of length 0, capacity 0, rPropSet=
   uno::Reference to (chart::wrapper::AxisWrapper *) 0x5b818ac8, 
rPropMapper=rtl::Reference to 0x5b7b80d0, bDefault=false) at 
/home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:349
11 0x7fffed319411 in 
SvXMLExportPropertyMapper::Filter_(com::sun::star::uno::Reference
 const&, bool, bool) const
   (this=0x5b79d560, xPropSet=uno::Reference to 
(chart::wrapper::AxisWrapper *) 0x5b818ac8, bDefault=false, 
bEnableFoFontFamily=false)
   at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:616
12 0x7fffed318e9a in 
SvXMLExportPropertyMapper::Filter(com::sun::star::uno::Reference
 const&, bool) const
   (this=0x5b79d560, rPropSet=uno::Reference to 
(chart::wrapper::AxisWrapper *) 0x5b818ac8, bEnableFoFontFamily=false) at 
/home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:546
13 0x7fffecfcc301 in 

[Libreoffice-bugs] [Bug 34133] Add option (+settings?) to compress and resize images: automatically on insertion of an image, or via a separate menu entry for all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34133

Cor Nouws  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo
Summary|Add ability to  |Add option (+settings?) to
   |automatically compress and  |compress and resize images:
   |resize images   |automatically on insertion
   ||of an image, or via a
   ||separate menu entry for all
   ||images

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38835] strip out non-trivial globals before main

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38835

--- Comment #50 from Hrithik Raj  ---
(In reply to Buovjaga from comment #49)
> (In reply to Hrithik Raj from comment #48)
> > Hi there this is Hrithik Raj And i would like to fix this bug.I have assiged
> > it to me.
> > What to do next?
> 
> Please don't change the assignee field. I have now had to change it back
> twice. See my comment 47.
> 
> If you have questions, please be more specific. We assume you have read the
> description and looked at previous code changes related to this easy hack.
> Thus, "what to do next" is not an appropriate question to start with.

Apologies. I am new to open source.Can you tell me where is the code where i
have to look for this bug. I can see a directory in comment 2 .

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130886] Menu command [Edit macro…] is undocumented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130886

Christopher Yeleighton  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130886] Menu command [Edit macro…] is undocumented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130886

Christopher Yeleighton  changed:

   What|Removed |Added

URL||file:///usr/lib64/libreoffi
   ||ce/help/en-US/text/shared/0
   ||1/06130001.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130886] New: Menu command [Edit macro…] is undocumented

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130886

Bug ID: 130886
   Summary: Menu command [Edit macro…] is undocumented
   Product: LibreOffice
   Version: 6.2.7.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: giecr...@stegny.2a.pl
CC: olivier.hal...@libreoffice.org

Besides, the ellipsis is missing in the command name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bridges/source

[Stephan Bergmann (via logerrit)]

 bridges/source/cpp_uno/gcc3_linux_x86-64/call.s |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5b4f3153fe54fb2f9db5f9d4f176fe68f0baf7f
Author: Stephan Bergmann 
AuthorDate: Sun Feb 23 19:02:45 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Feb 23 19:46:00 2020 +0100

.eh_frame section should probably have type @unwind

(i.e., SHT_X86_64_UNWIND) rather than @progbits (i.e., SHT_PROGBITS).
Discussion at 

"SHT_X86_64_UNWIND" sounds like both @unwind and @progbits are used in 
practice,
but Clang/LLVM now started to fail with

> 
/home/sbergman/lo/core/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s:79:2: 
error: changed section type for .eh_frame, expected: 0x7001
>  .section .eh_frame,"a",@progbits
>  ^

after  "[MC][ELF] Error for sh_type, 
sh_flags
or sh_entsize change".

Change-Id: I07cae987f7449c526a7130beee7a71d01afc457e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89305
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s 
b/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s
index 57d0c9f94657..447ac0cecfdd 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/call.s
@@ -76,7 +76,7 @@ privateSnippetExecutor:
# see 
http://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html
# for details of the .eh_frame, the "Common Information Entry" and 
"Frame Description Entry" formats
# and http://mentorembedded.github.io/cxx-abi/exceptions.pdf for more 
info
-   .section.eh_frame,"a",@progbits
+   .section.eh_frame,"a",@unwind
 .Lframe1:
.long   .LECIE1-.LSCIE1
 .LSCIE1:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130251] When UI has 'Dark Theme' the Sifr icon theme should be accurate in color and contrast

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130251

--- Comment #7 from Rizal Muttaqin  ---
(In reply to Peter from comment #6)
> I looked for addition package, but can not find it..., please suggest...
> 
> I used version 6.3.4.2 from the canonical repo...

sudo apt-get install libreoffice-style-* -y

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130251] When UI has 'Dark Theme' the Sifr icon theme should be accurate in color and contrast

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130251

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||125965


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125965
[Bug 125965] [META] Sifr icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125965

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||130251


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130251
[Bug 130251] When UI has 'Dark Theme' the Sifr icon theme should be accurate in
color and contrast
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125965

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||130885


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130885
[Bug 130885] Sifr: Missing Slide Layout Image
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||125965


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125965
[Bug 125965] [META] Sifr icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130885] Sifr: Missing Slide Layout Image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130885

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|Sifr:   |Sifr: Missing Slide Layout
   ||Image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs