[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/gfxlink.hxx |4 --
vcl/inc/TypeSerializer.hxx|4 ++
vcl/source/gdi/TypeSerializer.cxx | 71 ++
vcl/source/gdi/gfxlink.cxx| 71 --
vcl/source/gdi/impgraph.cxx |7 ++-
vcl/source/gdi/metaact.cxx|4 +-
6 files changed, 82 insertions(+), 79 deletions(-)
New commits:
commit bdfd0feefe3785e1ea68bf1f1f987147c8fe9335
Author: Tomaž Vajngerl
AuthorDate: Wed Mar 4 16:51:27 2020 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Mar 5 08:38:40 2020 +0100
vcl: move read and write to/from GfxLink to TypeSerializer
Change-Id: Ie99d00ea54296f5f3a909ade7115d9a9251f688e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89983
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/gfxlink.hxx b/include/vcl/gfxlink.hxx
index 33f1321b6953..0376149f7025 100644
--- a/include/vcl/gfxlink.hxx
+++ b/include/vcl/gfxlink.hxx
@@ -103,10 +103,6 @@ public:
boolExportNative( SvStream& rOStream ) const;
boolIsEMF() const; // WMF & EMF stored under the same type
(NativeWmf)
-public:
-
-friend SvStream& WriteGfxLink( SvStream& rOStream, const GfxLink&
rGfxLink );
-friend SvStream& ReadGfxLink( SvStream& rIStream, GfxLink& rGfxLink );
};
#endif
diff --git a/vcl/inc/TypeSerializer.hxx b/vcl/inc/TypeSerializer.hxx
index 861da5681178..76842aeee3d2 100644
--- a/vcl/inc/TypeSerializer.hxx
+++ b/vcl/inc/TypeSerializer.hxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
class TypeSerializer : public tools::GenericTypeSerializer
{
@@ -31,6 +32,9 @@ public:
void readGradient(Gradient& rGradient);
void writeGradient(const Gradient& rGradient);
+
+void readGfxLink(GfxLink& rGfxLink);
+void writeGfxLink(const GfxLink& rGfxLink);
};
#endif
diff --git a/vcl/source/gdi/TypeSerializer.cxx
b/vcl/source/gdi/TypeSerializer.cxx
index a54f3558c7ef..ad2f1400da85 100644
--- a/vcl/source/gdi/TypeSerializer.cxx
+++ b/vcl/source/gdi/TypeSerializer.cxx
@@ -19,6 +19,7 @@
#include
#include
+#include
TypeSerializer::TypeSerializer(SvStream& rStream)
: GenericTypeSerializer(rStream)
@@ -78,3 +79,73 @@ void TypeSerializer::writeGradient(const Gradient& rGradient)
mrStream.WriteUInt16(rGradient.GetEndIntensity());
mrStream.WriteUInt16(rGradient.GetSteps());
}
+
+void TypeSerializer::readGfxLink(GfxLink& rGfxLink)
+{
+sal_uInt16 nType = 0;
+sal_uInt32 nDataSize = 0;
+sal_uInt32 nUserId = 0;
+
+Size aSize;
+MapMode aMapMode;
+bool bMapAndSizeValid = false;
+
+{
+VersionCompat aCompat(mrStream, StreamMode::READ);
+
+// Version 1
+mrStream.ReadUInt16(nType);
+mrStream.ReadUInt32(nDataSize);
+mrStream.ReadUInt32(nUserId);
+
+if (aCompat.GetVersion() >= 2)
+{
+readSize(aSize);
+ReadMapMode(mrStream, aMapMode);
+bMapAndSizeValid = true;
+}
+}
+
+auto nRemainingData = mrStream.remainingSize();
+if (nDataSize > nRemainingData)
+{
+SAL_WARN("vcl", "graphic link stream is smaller than requested size");
+nDataSize = nRemainingData;
+}
+
+std::unique_ptr pBuffer(new sal_uInt8[nDataSize]);
+mrStream.ReadBytes(pBuffer.get(), nDataSize);
+
+rGfxLink = GfxLink(std::move(pBuffer), nDataSize,
static_cast(nType));
+rGfxLink.SetUserId(nUserId);
+
+if (bMapAndSizeValid)
+{
+rGfxLink.SetPrefSize(aSize);
+rGfxLink.SetPrefMapMode(aMapMode);
+}
+}
+
+void TypeSerializer::writeGfxLink(const GfxLink& rGfxLink)
+{
+{
+VersionCompat aCompat(mrStream, StreamMode::WRITE, 2);
+
+// Version 1
+mrStream.WriteUInt16(sal_uInt16(rGfxLink.GetType()));
+mrStream.WriteUInt32(rGfxLink.GetDataSize());
+mrStream.WriteUInt32(rGfxLink.GetUserId());
+
+// Version 2
+writeSize(rGfxLink.GetPrefSize());
+WriteMapMode(mrStream, rGfxLink.GetPrefMapMode());
+}
+
+if (rGfxLink.GetDataSize())
+{
+if (rGfxLink.GetData())
+mrStream.WriteBytes(rGfxLink.GetData(), rGfxLink.GetDataSize());
+}
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/gfxlink.cxx b/vcl/source/gdi/gfxlink.cxx
index 186961c2ac7d..785d86d3be7f 100644
--- a/vcl/source/gdi/gfxlink.cxx
+++ b/vcl/source/gdi/gfxlink.cxx
@@ -24,8 +24,6 @@
#include
#include
#include
-#include
-
GfxLink::GfxLink()
: meType(GfxLinkType::NONE)
@@ -147,75 +145,6 @@ bool GfxLink::ExportNative( SvStream& rOStream ) const
return ( rOStream.GetError() == ERRCODE_NONE );
}
-SvStream& WriteGfxLink( SvStream& rOStream, const GfxLink& rGfxLink )
-{
-std::unique_ptr pCompat(new VersionCompat( rOStream,
StreamMode::WRITE, 2 ));
-TypeSerializer aSerializer(rOStream);
-
-// Version 1
-
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/gfxlink.hxx| 33 -
vcl/source/gdi/gfxlink.cxx |2 +-
2 files changed, 21 insertions(+), 14 deletions(-)
New commits:
commit b677a4cc3eeb6eea8bb34aff0b06afe987931e6f
Author: Tomaž Vajngerl
AuthorDate: Wed Mar 4 13:19:26 2020 +0100
Commit: Tomaž Vajngerl
CommitDate: Thu Mar 5 08:38:23 2020 +0100
vcl: put first and last native type into GfxLinkType enum
Until now we had define GFX_LINK_FIRST_NATIVE_ID and define
GFX_LINK_LAST_NATIVE_ID which pointed to the first and last type
n the GfxLinkType which represented the native type. A more
elegant way to solve this is to assign an alias to the first and
last value. So now we have "NativeFirst" and "NativeLast" defined
in the GfxLinkType enum instead.
Change-Id: I5613a1b544fc7ae4f8b884df94c6fa4e2fb322d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89982
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/gfxlink.hxx b/include/vcl/gfxlink.hxx
index fc21aa296aae..33f1321b6953 100644
--- a/include/vcl/gfxlink.hxx
+++ b/include/vcl/gfxlink.hxx
@@ -28,25 +28,32 @@
class SvStream;
+/** GfxLink graphic types that are supported by GfxLink.
+ *
+ * It is important that the numbers for native types stay the same, because
+ * they are used in serialization to MTF.
+ */
enum class GfxLinkType
{
NONE = 0,
EpsBuffer= 1,
-NativeGif= 2,// Don't forget to update the following defines
-NativeJpg= 3,// Don't forget to update the following defines
-NativePng= 4,// Don't forget to update the following defines
-NativeTif= 5,// Don't forget to update the following defines
-NativeWmf= 6,// Don't forget to update the following defines
-NativeMet= 7,// Don't forget to update the following defines
-NativePct= 8,// Don't forget to update the following defines
-NativeSvg= 9,// Don't forget to update the following defines
-NativeMov= 10, // Don't forget to update the following defines
+NativeGif= 2,
+NativeJpg= 3,
+NativePng= 4,
+NativeTif= 5,
+NativeWmf= 6,
+NativeMet= 7,
+NativePct= 8,
+NativeSvg= 9,
+NativeMov= 10,
NativeBmp= 11,
-NativePdf= 12// Don't forget to update the following defines
-};
+NativePdf= 12, // If a new type is added, make sure to change
NativeLast too
-#define GFX_LINK_FIRST_NATIVE_IDGfxLinkType::NativeGif
-#define GFX_LINK_LAST_NATIVE_ID GfxLinkType::NativePdf
+// Alias for when the first native type starts and last native
+// type ends.
+NativeFirst = NativeGif,
+NativeLast = NativePdf,
+};
class Graphic;
diff --git a/vcl/source/gdi/gfxlink.cxx b/vcl/source/gdi/gfxlink.cxx
index 1a383de72ccc..186961c2ac7d 100644
--- a/vcl/source/gdi/gfxlink.cxx
+++ b/vcl/source/gdi/gfxlink.cxx
@@ -71,7 +71,7 @@ bool GfxLink::operator==( const GfxLink& rGfxLink ) const
bool GfxLink::IsNative() const
{
-return( meType >= GFX_LINK_FIRST_NATIVE_ID && meType <=
GFX_LINK_LAST_NATIVE_ID );
+return meType >= GfxLinkType::NativeFirst && meType <=
GfxLinkType::NativeLast;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlstyli.cxx |4 ++--
sc/source/filter/xml/xmlstyli.hxx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 7d6420aee31328a11634d443602a26f671436c76
Author: Noel Grandin
AuthorDate: Wed Mar 4 15:22:55 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 5 08:22:36 2020 +0100
use FastParser in XMLTableStylesContext
Change-Id: If06d8cfc856aa5180199bce2bc747fa9bd667bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89994
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/filter/xml/xmlstyli.cxx
b/sc/source/filter/xml/xmlstyli.cxx
index 7baf38fae5d1..39b1511cee22 100644
--- a/sc/source/filter/xml/xmlstyli.cxx
+++ b/sc/source/filter/xml/xmlstyli.cxx
@@ -696,9 +696,9 @@ XMLTableStylesContext::~XMLTableStylesContext()
{
}
-void XMLTableStylesContext::EndElement()
+void XMLTableStylesContext::endFastElement(sal_Int32 nElement)
{
-SvXMLStylesContext::EndElement();
+SvXMLStylesContext::endFastElement(nElement);
if (bAutoStyles)
GetImport().GetTextImport()->SetAutoStyles( this );
else
diff --git a/sc/source/filter/xml/xmlstyli.hxx
b/sc/source/filter/xml/xmlstyli.hxx
index 8031e5f90ad0..09542b47dc81 100644
--- a/sc/source/filter/xml/xmlstyli.hxx
+++ b/sc/source/filter/xml/xmlstyli.hxx
@@ -155,7 +155,7 @@ public:
XMLTableStylesContext( SvXMLImport& rImport, bool bAutoStyles );
virtual ~XMLTableStylesContext() override;
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
virtual rtl::Reference < SvXMLImportPropertyMapper >
GetImportPropertyMapper(
XmlStyleFamily nFamily ) const override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlstyli.cxx |2 +-
sc/source/filter/xml/xmlstyli.hxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 5c44f44147b5490cc792949989f4baba2137beed
Author: Noel Grandin
AuthorDate: Wed Mar 4 15:20:05 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 5 08:22:54 2020 +0100
use FastParser in ScXMLMasterStylesContext
Change-Id: I432a3b5a1087a50b2cdc959b42bc58209a6cedfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89993
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/filter/xml/xmlstyli.cxx
b/sc/source/filter/xml/xmlstyli.cxx
index 39b1511cee22..b83f6cf06a45 100644
--- a/sc/source/filter/xml/xmlstyli.cxx
+++ b/sc/source/filter/xml/xmlstyli.cxx
@@ -943,7 +943,7 @@ SvXMLStyleContext
*ScXMLMasterStylesContext::CreateStyleStyleChildContext(
return nullptr;
}
-void ScXMLMasterStylesContext::EndElement()
+void ScXMLMasterStylesContext::endFastElement(sal_Int32 )
{
FinishStyles(true);
}
diff --git a/sc/source/filter/xml/xmlstyli.hxx
b/sc/source/filter/xml/xmlstyli.hxx
index 09542b47dc81..1bbb01ee145c 100644
--- a/sc/source/filter/xml/xmlstyli.hxx
+++ b/sc/source/filter/xml/xmlstyli.hxx
@@ -184,7 +184,7 @@ public:
ScXMLMasterStylesContext( SvXMLImport& rImport );
virtual ~ScXMLMasterStylesContext() override;
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
};
class ScMasterPageContext : public XMLTextMasterPageContext
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131141] (Icon-Theme-Sukapura) - [META] Sukapura icons
https://bugs.documentfoundation.org/show_bug.cgi?id=131141 Rizal Muttaqin changed: What|Removed |Added Depends on||131135 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131135 [Bug 131135] Table icons incorrect when using Sukapura icon set -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131135] Table icons incorrect when using Sukapura icon set
https://bugs.documentfoundation.org/show_bug.cgi?id=131135 Rizal Muttaqin changed: What|Removed |Added Blocks||131141 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131141 [Bug 131141] (Icon-Theme-Sukapura) - [META] Sukapura icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131141] New: (Icon-Theme-Sukapura) - [META] Sukapura icons
https://bugs.documentfoundation.org/show_bug.cgi?id=131141 Bug ID: 131141 Summary: (Icon-Theme-Sukapura) - [META] Sukapura icons Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz_17_...@yahoo.co.id Description: In this META we'll add any bug about Sukapura icon set problems -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126561] Day Night Drugs
https://bugs.documentfoundation.org/show_bug.cgi?id=126561 Day Night Drugs changed: What|Removed |Added Summary|mastersworth|Day Night Drugs URL|https://www.marketing2busin |https://www.daynightdrugs.c |ess.com/crm-look-like-in-20 |om/eye-care/careprost-eye-d |20/ |rops-0-03-3-ml-eye-drops.ht ||ml Alias||Day, Night, Drugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126561] Day Night Drugs
https://bugs.documentfoundation.org/show_bug.cgi?id=126561 Day Night Drugs changed: What|Removed |Added Alias||Online, Pharmacy -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113980] Insert Row and Insert Column in Standard Toolbar not available after (Auto-) Filter has been applied
https://bugs.documentfoundation.org/show_bug.cgi?id=113980 Buovjaga changed: What|Removed |Added Status|REOPENED|RESOLVED CC||qfsuar...@yahoo.es Resolution|--- |FIXED --- Comment #13 from Buovjaga --- (In reply to Emersson Augusto Suarez Ortiz from comment #12) > Hi Every Body, this bug is still present, you're able to insert a new column > or row if you're in the column that has apply the filter, if your on another > column you can't insert a new column. > > To reproduce that, you still can open the file, then apply the filter in any > column, then move to another column and try to insert a column. This is an old report. Please open a new one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 Bug 108364 depends on bug 113980, which changed state. Bug 113980 Summary: Insert Row and Insert Column in Standard Toolbar not available after (Auto-) Filter has been applied https://bugs.documentfoundation.org/show_bug.cgi?id=113980 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #5 from Heiko Tietze --- Going through the old tickets with needsUX; sorry for the delay. We talked about this topic in the design meeting and agree with the problem. Solution could be to not only search for the actual term like ' or --> but also for the autocorrected forms ‘’ (open and close) or → respectively. Could be enabled via checkbox but I'd suggest to just always do it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #5 from Heiko Tietze --- Going through the old tickets with needsUX; sorry for the delay. We talked about this topic in the design meeting and agree with the problem. Solution could be to not only search for the actual term like ' or --> but also for the autocorrected forms ‘’ (open and close) or → respectively. Could be enabled via checkbox but I'd suggest to just always do it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130928] Area Fill update presets
https://bugs.documentfoundation.org/show_bug.cgi?id=130928 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |c...@nouenoff.nl, |.freedesktop.org|heiko.tietze@documentfounda ||tion.org Keywords|needsUXEval | Severity|normal |enhancement --- Comment #13 from Heiko Tietze --- We discussed this topic in the design meeting. While the number of gradients is excessive right now and makes it difficult to pick the right item, it's a different topic for patterns. And the argument counts that creation of patterns is a bit cumbersome. So go with this change. Still -1 to change gradients and bitmaps. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130928] Area Fill update presets
https://bugs.documentfoundation.org/show_bug.cgi?id=130928 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |c...@nouenoff.nl, |.freedesktop.org|heiko.tietze@documentfounda ||tion.org Keywords|needsUXEval | Severity|normal |enhancement --- Comment #13 from Heiko Tietze --- We discussed this topic in the design meeting. While the number of gradients is excessive right now and makes it difficult to pick the right item, it's a different topic for patterns. And the argument counts that creation of patterns is a bit cumbersome. So go with this change. Still -1 to change gradients and bitmaps. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130953] Improve listing of (table) styles to reflect that newly created styles are in the document only (not available elsewhere)
https://bugs.documentfoundation.org/show_bug.cgi?id=130953 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #6 from Heiko Tietze --- We discussed the topic in the design meeting. The issue is less relevant for other styles since paragraph styles are always stored in the document. So it's a solution when we get rid of the autoformat dialog (don't find a respective ticket). However, since table styles might be installed per extension (see also bug 124046) the situation is less clear, and actually it would be good to have the same opportunity for all styles. Simple solution to distinguish system from user styles is to show the latter on the bottom after a horizontal ruler. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130953] Improve listing of (table) styles to reflect that newly created styles are in the document only (not available elsewhere)
https://bugs.documentfoundation.org/show_bug.cgi?id=130953 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #6 from Heiko Tietze --- We discussed the topic in the design meeting. The issue is less relevant for other styles since paragraph styles are always stored in the document. So it's a solution when we get rid of the autoformat dialog (don't find a respective ticket). However, since table styles might be installed per extension (see also bug 124046) the situation is less clear, and actually it would be good to have the same opportunity for all styles. Simple solution to distinguish system from user styles is to show the latter on the bottom after a horizontal ruler. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 Bug 98259 depends on bug 98333, which changed state. Bug 98333 Summary: Bringing uniformity to styles shortcuts https://bugs.documentfoundation.org/show_bug.cgi?id=98333 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98333] Bringing uniformity to styles shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=98333 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Heiko Tietze --- We discussed the topic in the design meeting. The discussion hasn't progressed so far and is quite controversial. Users are familiar with the existing shortcuts and may see any change as a regression. So the conclusion is to resolve this request as WF. At least as long bug 123768 is not done. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 98333] Bringing uniformity to styles shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=98333 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Heiko Tietze --- We discussed the topic in the design meeting. The discussion hasn't progressed so far and is quite controversial. Users are familiar with the existing shortcuts and may see any change as a regression. So the conclusion is to resolve this request as WF. At least as long bug 123768 is not done. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130441] Make Styles command (.uno:DesignerDialog) toggle the sidebar on/off (like F11 does)
https://bugs.documentfoundation.org/show_bug.cgi?id=130441 Heiko Tietze changed: What|Removed |Added Summary|Make Styles command (icon) |Make Styles command |on toolbar toggle the |(.uno:DesignerDialog) |Styles Window (like F11 |toggle the sidebar on/off |does) |(like F11 does) Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Ever confirmed|0 |1 Keywords|needsDevAdvice | Severity|normal |enhancement --- Comment #8 from Heiko Tietze --- We discussed the topic in the design meeting and decided to agree with the request. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130441] Make Styles command (.uno:DesignerDialog) toggle the sidebar on/off (like F11 does)
https://bugs.documentfoundation.org/show_bug.cgi?id=130441 Heiko Tietze changed: What|Removed |Added Summary|Make Styles command (icon) |Make Styles command |on toolbar toggle the |(.uno:DesignerDialog) |Styles Window (like F11 |toggle the sidebar on/off |does) |(like F11 does) Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Ever confirmed|0 |1 Keywords|needsDevAdvice | Severity|normal |enhancement --- Comment #8 from Heiko Tietze --- We discussed the topic in the design meeting and decided to agree with the request. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131063] Navigate document content when selection is made by single click in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=131063 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #2 from Heiko Tietze --- We discussed this topic in the design meeting. Provided the video showcases a switch from the current double click behavior to go to the heading or the object towards a single click we have concerns. + con: usually the default action (go-to) is done by double click + con: single click blocks context menu for not active object + keep the context menu could be done also by special handling of right button + con: breaks flow where you work in Headings-part, and select e.g. an image or work in a table + pro: weird situation when a different item is selected as the active position; wouldn't be an issue with single click + similar issue with styles & formatting where single click does not apply the style (bug 94427) + rather a different topic IMO (Cor) + pro: in document selection is a single click and changes the Navigator + with no clear need, let's not break the known behavior, present left and right (Cor) + tend to weight the pro higher (Heiko) + the other way round for me; will likely hate it (Cor) Jim, please comment if the assumption is wrong. Otherwise it's up to you to balance the pro and cons, keeping the ticket open. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131063] Navigate document content when selection is made by single click in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=131063 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #2 from Heiko Tietze --- We discussed this topic in the design meeting. Provided the video showcases a switch from the current double click behavior to go to the heading or the object towards a single click we have concerns. + con: usually the default action (go-to) is done by double click + con: single click blocks context menu for not active object + keep the context menu could be done also by special handling of right button + con: breaks flow where you work in Headings-part, and select e.g. an image or work in a table + pro: weird situation when a different item is selected as the active position; wouldn't be an issue with single click + similar issue with styles & formatting where single click does not apply the style (bug 94427) + rather a different topic IMO (Cor) + pro: in document selection is a single click and changes the Navigator + with no clear need, let's not break the known behavior, present left and right (Cor) + tend to weight the pro higher (Heiko) + the other way round for me; will likely hate it (Cor) Jim, please comment if the assumption is wrong. Otherwise it's up to you to balance the pro and cons, keeping the ticket open. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: PDF processing
Hi, On 03/03/2020 12.26, Pietro Paolini wrote: > I am quite curious about this fantastic feature of LibreOffice which > allows me to open a PDF and edit it in the UI - even though it seems > to screw the fonts a bit. I wanted to have a look at the source code > to see if there is some sort of PDF "model" being built from the > original PDF document, for instance a set of objects each describing > the graphic meanings of a particular region within the page. I did > not succeed very much as I am not familiar with the codebase and the > project is quite big. > > Can anybody point me in the right direction ? Is there a specific > place where this PDF "normalization" takes place ? At a quick glance, 'sdext/source/pdfimport' looks like a good place to start with; I personally don't know more related to your more specific question. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-ux-advise] [Bug 131005] UNO command to dock all toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=131005 Heiko Tietze changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Heiko Tietze --- We discussed the topic in the design meeting and recommend to abandon the patch and resurrect when user have a need. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129971] roadrunner email setting
https://bugs.documentfoundation.org/show_bug.cgi?id=129971 Mistrym changed: What|Removed |Added URL|https://www.emailtechnicals |https://roadrunnerhelpline. |upport.us/blog/effective-st |com/roadrunner-email-settin |eps-to-setup-roadrunner-ema |gs/ |il/ | --- Comment #2 from Mistrym --- I keep owning a problem receiving/synching e-mail over my about three Apple apparatus (MacBook Guru, i-pad along with i-phone ) together with Time-Warner Cable/Spectrum. I utilize the suggested configurations out of TWC but it's perhaps not doing work. Apple techs are valuable (and individual ) together with me personally I receive turfed straight back once again to TWC who consult regardless of whether I am employing their configurations. for more information visit us https://roadrunnerhelpline.com/roadrunner-email-settings/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/filter/xml/xmlStyleImport.cxx |4 ++--
dbaccess/source/filter/xml/xmlStyleImport.hxx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 5c5bbdd1b7e77499ea71aa7c57f7287bb063bf79
Author: Noel Grandin
AuthorDate: Wed Mar 4 15:12:39 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Mar 5 07:23:00 2020 +0100
use FastParser in OTableStylesContext
Change-Id: I5f893528b593f4511e471ce202bddb3720786ae1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89992
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/filter/xml/xmlStyleImport.cxx
b/dbaccess/source/filter/xml/xmlStyleImport.cxx
index e308f23d5c54..9bfed000e432 100644
--- a/dbaccess/source/filter/xml/xmlStyleImport.cxx
+++ b/dbaccess/source/filter/xml/xmlStyleImport.cxx
@@ -149,9 +149,9 @@ OTableStylesContext::~OTableStylesContext()
}
-void OTableStylesContext::EndElement()
+void OTableStylesContext::endFastElement(sal_Int32 nElement)
{
-SvXMLStylesContext::EndElement();
+SvXMLStylesContext::endFastElement(nElement);
if (bAutoStyles)
GetImport().GetTextImport()->SetAutoStyles( this );
else
diff --git a/dbaccess/source/filter/xml/xmlStyleImport.hxx
b/dbaccess/source/filter/xml/xmlStyleImport.hxx
index 06c02bf16291..8eeb7ac7dd54 100644
--- a/dbaccess/source/filter/xml/xmlStyleImport.hxx
+++ b/dbaccess/source/filter/xml/xmlStyleImport.hxx
@@ -89,7 +89,7 @@ namespace dbaxml
OTableStylesContext( SvXMLImport& rImport, bool bAutoStyles );
virtual ~OTableStylesContext() override;
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
virtual rtl::Reference < SvXMLImportPropertyMapper >
GetImportPropertyMapper(
XmlStyleFamily nFamily ) const override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/macOS-weld' - include/vcl vcl/inc vcl/Library_vclplug_osx.mk vcl/osx vcl/source
Rebased ref, commits from common ancestor:
commit a8436bcbdd0d8ccc68d5b52b0c0d9f9bac30fae9
Author: Tor Lillqvist
AuthorDate: Wed Mar 4 19:34:41 2020 +0200
Commit: Tor Lillqvist
CommitDate: Thu Mar 5 08:00:31 2020 +0200
WIP: macOS welding
Not to be merged to master as such, contains lots of SAL_DEBUG and
other crack.
Change-Id: I5865118c6e4c34f0513ecbd2d759642bc15ad31a
diff --git a/include/vcl/builder.hxx b/include/vcl/builder.hxx
index 3e22639569b8..109c3ba33613 100644
--- a/include/vcl/builder.hxx
+++ b/include/vcl/builder.hxx
@@ -504,7 +504,7 @@ protected:
/*
* @return true if rValue is "True", "true", "1", etc.
*/
-bool toBool(const OUString );
+bool VCL_DLLPUBLIC toBool(const OUString );
#endif
diff --git a/vcl/Library_vclplug_osx.mk b/vcl/Library_vclplug_osx.mk
index 6b94c6c25df1..01f34aec2b00 100644
--- a/vcl/Library_vclplug_osx.mk
+++ b/vcl/Library_vclplug_osx.mk
@@ -51,7 +51,9 @@ $(eval $(call gb_Library_use_libraries,vclplug_osx,\
sal \
salhelper \
tl \
+utl \
vcl \
+xmlreader \
))
$(eval $(call gb_Library_use_externals,vclplug_osx,\
diff --git a/vcl/inc/osx/salframe.h b/vcl/inc/osx/salframe.h
index 2fcdef3609e9..3e150a5fafdf 100644
--- a/vcl/inc/osx/salframe.h
+++ b/vcl/inc/osx/salframe.h
@@ -159,6 +159,8 @@ public:
// done setting up the clipregion
virtual void EndSetClipRegion() override;
+virtual weld::Window* GetFrameWeld() const override;
+
void UpdateFrameGeometry();
// trigger painting of the window
diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h
index edece53b6bea..f0701748145f 100644
--- a/vcl/inc/osx/salinst.h
+++ b/vcl/inc/osx/salinst.h
@@ -32,6 +32,8 @@
#include
#ifdef MACOSX
+#include
+#include
#include
#endif
#include
@@ -142,6 +144,9 @@ public:
// Is this the NSAppThread?
virtual bool IsMainThread() const override;
+virtual weld::Builder* CreateBuilder(weld::Widget* pParent, const
OUString& rUIRoot, const OUString& rUIFile) override;virtual
weld::MessageDialog* CreateMessageDialog(weld::Widget* pParent, VclMessageType
eMessageType, VclButtonsType eButtonType, const OUString )
override;
+virtual weld::Window* GetFrameWeld(const
css::uno::Reference& rWindow) override;
+
void startedPrintJob() { mnActivePrintJobs++; }
void endedPrintJob() { mnActivePrintJobs--; }
@@ -157,6 +162,130 @@ public:
CGImageRef CreateCGImage( const Image& );
NSImage* CreateNSImage( const Image& );
+#ifdef MACOSX
+
+typedef cppu::WeakComponentImplHelper SalAppKitXWindow_Base;
+
+class SalAppKitXWindow : public SalAppKitXWindow_Base
+{
+private:
+osl::Mutex m_aHelperMtx;
+weld::Window* m_pWeldWidget;
+NSView* m_pView;
+
+public:
+
+SalAppKitXWindow(weld::Window* pWeldWidget, NSView* pView)
+: SalAppKitXWindow_Base(m_aHelperMtx)
+, m_pWeldWidget(pWeldWidget)
+, m_pView(pView)
+{
+}
+
+void clear()
+{
+m_pWeldWidget = nullptr;
+m_pView = nullptr;
+}
+
+NSView* getView() const
+{
+return m_pView;
+}
+
+weld::Window* getFrameWeld() const
+{
+return m_pWeldWidget;
+}
+
+// css::awt::XWindow
+void SAL_CALL setPosSize(sal_Int32, sal_Int32, sal_Int32, sal_Int32,
sal_Int16) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+css::awt::Rectangle SAL_CALL getPosSize() override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setVisible(sal_Bool) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setEnable(sal_Bool) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setFocus() override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addWindowListener(const css::uno::Reference<
css::awt::XWindowListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+void SAL_CALL removeWindowListener(const css::uno::Reference<
css::awt::XWindowListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addFocusListener(const css::uno::Reference<
css::awt::XFocusListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL removeFocusListener(const css::uno::Reference<
css::awt::XFocusListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addKeyListener(const css::uno::Reference<
css::awt::XKeyListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL removeKeyListener(const css::uno::Reference<
css::awt::XKeyListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
[Libreoffice-bugs] [Bug 128078] Improve loading of large autocorrect lists
https://bugs.documentfoundation.org/show_bug.cgi?id=128078 --- Comment #12 from tommy27 --- relevant or not relevant, I can tell that situations is better in 6.4.1 now the loading takes 16 seconds on the same computer of my previous benchmark. still slower than 5.3.6 (5 secs) and 6.1.6 (10 secs) but faster tha 6.3.4 (20 seconds) probably this has been a positive side effect of some other code tweak. having said that, I hope that some developer will one day address this annoying performance issue. Stuart's insights about the code refactoring look interesting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sal vcl/source
include/sal/log-areas.dox |1
vcl/source/window/builder.cxx | 66 +-
2 files changed, 34 insertions(+), 33 deletions(-)
New commits:
commit 9f6ae57d6a60d54a72243095a6e4c0fc8f6bda07
Author: Tor Lillqvist
AuthorDate: Thu Mar 5 00:14:23 2020 +0200
Commit: Tor Lillqvist
CommitDate: Thu Mar 5 06:32:01 2020 +0100
Add a separate log tag for the UI builder
Change-Id: I54d0233574fa84f1fe988a88f6220985e9149b83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90004
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index ea0c34e5223f..1d8414ed98e8 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -460,6 +460,7 @@ certain functionality.
@li @c vcl
@li @c vcl.a11y
@li @c vcl.app
+@li @c vcl.builder
@li @c vcl.control
@li @c vcl.ct - CoreText-using code for macOS and iOS
@li @c vcl.debugevent
diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index c32e59ab2b37..194c1d4aacd9 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -459,7 +459,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
}
catch (const css::uno::Exception )
{
-DBG_UNHANDLED_EXCEPTION("vcl.layout", "Unable to read .ui file");
+DBG_UNHANDLED_EXCEPTION("vcl.builder", "Unable to read .ui file");
CrashReporter::addKeyValue("VclBuilderException", "Unable to read .ui
file: " + rExcept.Message, CrashReporter::Write);
throw;
}
@@ -505,7 +505,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
pSource->SetAccessibleRelationMemberOf(pTarget);
else
{
-SAL_WARN("vcl.layout", "unhandled a11y relation :" <<
rType);
+SAL_WARN("vcl.builder", "unhandled a11y relation :" <<
rType);
}
}
}
@@ -702,7 +702,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
pTargetButton->SetStyle(pTargetButton->GetStyle() |
WB_SMALLSTYLE);
}
else
-SAL_WARN_IF(eType != SymbolType::IMAGE, "vcl.layout",
"unimplemented symbol type for radiobuttons");
+SAL_WARN_IF(eType != SymbolType::IMAGE, "vcl.builder",
"unimplemented symbol type for radiobuttons");
if (eType == SymbolType::IMAGE)
{
Image const aImage(StockImage::Yes,
@@ -725,7 +725,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
case 4:
break;
default:
-SAL_WARN("vcl.layout", "unsupported image size " <<
rImageInfo.m_nSize);
+SAL_WARN("vcl.builder", "unsupported image size " <<
rImageInfo.m_nSize);
break;
}
}
@@ -799,7 +799,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
//drop maps, etc. that we don't need again
m_pParserState.reset();
-SAL_WARN_IF(!m_sID.isEmpty() && (!m_bToplevelParentFound &&
!get_by_name(m_sID)), "vcl.layout",
+SAL_WARN_IF(!m_sID.isEmpty() && (!m_bToplevelParentFound &&
!get_by_name(m_sID)), "vcl.builder",
"Requested top level widget \"" << m_sID << "\" not found in " <<
sUIFile);
#if defined SAL_LOG_WARN
@@ -819,7 +819,7 @@ VclBuilder::VclBuilder(vcl::Window* pParent, const
OUString& sUIDir, const OUStr
}
}
}
-SAL_WARN_IF(nButtons && !bHasDefButton, "vcl.layout", "No default
button defined in " << sUIFile);
+SAL_WARN_IF(nButtons && !bHasDefButton, "vcl.builder", "No default
button defined in " << sUIFile);
}
#endif
@@ -1070,7 +1070,7 @@ namespace
return VclResId(SV_BUTTONTEXT_YES);
else if (rType == "gtk-no")
return VclResId(SV_BUTTONTEXT_NO);
-SAL_WARN("vcl.layout", "unknown stock type: " << rType);
+SAL_WARN("vcl.builder", "unknown stock type: " << rType);
return OUString();
}
@@ -1734,7 +1734,7 @@ VclBuilder::customMakeWidget GetCustomMakeWidget(const
OString& name)
aI->second->getFunctionSymbol(sFunction));
#elif !HAVE_FEATURE_DESKTOP
pFunction = lo_get_custom_widget_func(sFunction.toUtf8().getStr());
-SAL_WARN_IF(!pFunction, "vcl.layout", "Could not find " << sFunction);
+SAL_WARN_IF(!pFunction, "vcl.builder", "Could not find " << sFunction);
assert(pFunction);
#else
pFunction = reinterpret_cast(
@@ -1767,7 +1767,7 @@ VclPtr VclBuilder::makeObject(vcl::Window
*pParent, const OString &
sal_uInt16 nNewPageId = nNewPageCount;
pTabControl->InsertPage(nNewPageId, OUString());
[Libreoffice-commits] core.git: include/test sc/qa
include/test/container/xnamereplace.hxx |2 +-
sc/qa/extras/scautoformatsobj.cxx |6 --
sc/qa/extras/scstylefamilyobj.cxx |4 ++--
sc/qa/extras/sctablesheetsobj.cxx |2 +-
4 files changed, 8 insertions(+), 6 deletions(-)
New commits:
commit 70d40d57f46afd593a86a12281546b570c2fd330
Author: Jens Carl
AuthorDate: Sat Feb 29 12:05:41 2020 -0800
Commit: Jens Carl
CommitDate: Thu Mar 5 06:28:53 2020 +0100
Rename method setReplacementElement()
... to setElement() to have a uniform interface with
similar classes like XNameContainer.
Change-Id: I2058e3ea9f14a5792a07f23f4bd13c4708dccdfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89784
Tested-by: Jens Carl
Reviewed-by: Jens Carl
diff --git a/include/test/container/xnamereplace.hxx
b/include/test/container/xnamereplace.hxx
index ddfbb4027eb7..a5e7fe516657 100644
--- a/include/test/container/xnamereplace.hxx
+++ b/include/test/container/xnamereplace.hxx
@@ -31,7 +31,7 @@ public:
virtual css::uno::Reference init() = 0;
void testReplaceByName();
-void setReplacementElement(const css::uno::Any& rElement) {
m_aReplacementElement = rElement; }
+void setElement(const css::uno::Any& rElement) { m_aReplacementElement =
rElement; }
protected:
~XNameReplace() {}
diff --git a/sc/qa/extras/scautoformatsobj.cxx
b/sc/qa/extras/scautoformatsobj.cxx
index 42cee493c9e2..ed799c018ef4 100644
--- a/sc/qa/extras/scautoformatsobj.cxx
+++ b/sc/qa/extras/scautoformatsobj.cxx
@@ -109,9 +109,11 @@ uno::Reference ScAutoFormatsObj::init()
uno::makeAny(xMSF->createInstance("com.sun.star.sheet.TableAutoFormat")));
}
// XNameContainer
-
setElement(uno::makeAny(xMSF->createInstance("com.sun.star.sheet.TableAutoFormat")));
+XNameContainer::setElement(
+
uno::makeAny(xMSF->createInstance("com.sun.star.sheet.TableAutoFormat")));
// XNameReplace
-
setReplacementElement(uno::makeAny(xMSF->createInstance("com.sun.star.sheet.TableAutoFormat")));
+XNameReplace::setElement(
+
uno::makeAny(xMSF->createInstance("com.sun.star.sheet.TableAutoFormat")));
return xTAF;
}
diff --git a/sc/qa/extras/scstylefamilyobj.cxx
b/sc/qa/extras/scstylefamilyobj.cxx
index fe5d8fb2ec19..a5843a8f3a1f 100644
--- a/sc/qa/extras/scstylefamilyobj.cxx
+++ b/sc/qa/extras/scstylefamilyobj.cxx
@@ -107,9 +107,9 @@ uno::Reference ScStyleFamilyObj::init()
uno::Reference
xCS(xMSF->createInstance("com.sun.star.style.CellStyle"),
uno::UNO_SET_THROW);
// XNameContainer
-
setElement(uno::makeAny(xMSF->createInstance("com.sun.star.style.CellStyle")));
+
XNameContainer::setElement(uno::makeAny(xMSF->createInstance("com.sun.star.style.CellStyle")));
// XNameReplace
-
setReplacementElement(uno::makeAny(xMSF->createInstance("com.sun.star.style.CellStyle")));
+
XNameReplace::setElement(uno::makeAny(xMSF->createInstance("com.sun.star.style.CellStyle")));
uno::Reference xNC(xNA_SF,
uno::UNO_QUERY_THROW);
xNC->insertByName("ScStyleFamilyObj", uno::makeAny(xCS));
diff --git a/sc/qa/extras/sctablesheetsobj.cxx
b/sc/qa/extras/sctablesheetsobj.cxx
index 286ff839622c..a8ffa36b2ed8 100644
--- a/sc/qa/extras/sctablesheetsobj.cxx
+++ b/sc/qa/extras/sctablesheetsobj.cxx
@@ -145,7 +145,7 @@ uno::Reference ScTableSheetsObj::init()
XNameContainer::setElement(
uno::makeAny(xMSF->createInstance("com.sun.star.sheet.Spreadsheet")));
// XNameReplace
-
setReplacementElement(uno::makeAny(xMSF->createInstance("com.sun.star.sheet.Spreadsheet")));
+
XNameReplace::setElement(uno::makeAny(xMSF->createInstance("com.sun.star.sheet.Spreadsheet")));
return xReturn;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131140] New: [PATCH] Add a negative number to the example of NPV.
https://bugs.documentfoundation.org/show_bug.cgi?id=131140 Bug ID: 131140 Summary: [PATCH] Add a negative number to the example of NPV. Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: h...@topbug.net CC: olivier.hal...@libreoffice.org Created attachment 158399 --> https://bugs.documentfoundation.org/attachment.cgi?id=158399=edit patch Otherwise the user may doubt whether negative numbers can be used. --- source/text/scalc/01/04060119.xhp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/text/scalc/01/04060119.xhp b/source/text/scalc/01/04060119.xhp index ea6686d20a1a..9805881768f1 100644 --- a/source/text/scalc/01/04060119.xhp +++ b/source/text/scalc/01/04060119.xhp @@ -338,9 +338,9 @@ Value1, Value2, ..., Value30 are up to 30 values, which represent deposits or withdrawals. -What is the net present value of periodic payments of 10, 20 and 30 currency units with a discount rate of 8.75%. At time zero the costs were paid as -40 currency units. +What is the net present value of periodic payments of 10, 20, 30 and -5 currency units with a discount rate of 8.75%. At time zero the costs were paid as -40 currency units. -=NPV(8.75%;10;20;30) = 49.43 currency units. The net present value is the returned value minus the initial costs of 40 currency units, therefore 9.43 currency units. +=NPV(8.75%;10;20;30;-5) = 45.68 currency units. The net present value is the returned value minus the initial costs of 40 currency units, therefore 5.68 currency units. calculating;nominal interest rates -- 2.20.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102835] Feature request: Endnote by chapter near end of document.
https://bugs.documentfoundation.org/show_bug.cgi?id=102835 --- Comment #8 from peter josvai --- I agree, too, this is a very important feature, and a very important feature request... this -- allowing endnotes numbering to restart per chapter, and being able to place it "near the end" -- is what will make Writer the writers' choice... I mean, this is what's missing still, this is without which one cannot rely FULLY on Writer... from scratch to finalizing a book project... without this functionality, one will write... and then give it to a pro, who will use other software, to edit handle the text, and hand it over to a print house, and create the ebook versions of it... make no mistake, writers are a minority, a tiny, or super-tiny minority among Writer users! yet they should be viewed as most relevant or "representative" users, I believe... I know, this is an office suite... and office workers are not writers... but they should be using the writers' tool, when they write, and not the other way around :) right? - - - thank you for developing Writer - - - -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 102835] Feature request: Endnote by chapter near end of document.
https://bugs.documentfoundation.org/show_bug.cgi?id=102835 --- Comment #8 from peter josvai --- I agree, too, this is a very important feature, and a very important feature request... this -- allowing endnotes numbering to restart per chapter, and being able to place it "near the end" -- is what will make Writer the writers' choice... I mean, this is what's missing still, this is without which one cannot rely FULLY on Writer... from scratch to finalizing a book project... without this functionality, one will write... and then give it to a pro, who will use other software, to edit handle the text, and hand it over to a print house, and create the ebook versions of it... make no mistake, writers are a minority, a tiny, or super-tiny minority among Writer users! yet they should be viewed as most relevant or "representative" users, I believe... I know, this is an office suite... and office workers are not writers... but they should be using the writers' tool, when they write, and not the other way around :) right? - - - thank you for developing Writer - - - -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 123116] Always allow table row to break across pages when longer than a page
https://bugs.documentfoundation.org/show_bug.cgi?id=123116 --- Comment #3 from Justin L --- WIP patch: https://gerrit.libreoffice.org/c/core/+/90005 The good thing about the current method is that is DOES match MSWord 2003. So I probably should at the minimum try to match Word compatibility mode. Whether to do a LO compatibility mode check is another question... Probably if Word thought they needed to do it with a compat switch, LO should do the same. The difference is that MSWord has a "change this document out of compatibility mode" function, but I don't recall seeing anything like that in LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103683] PDF export mediabox trimbox cropbox bleedbox artbox
https://bugs.documentfoundation.org/show_bug.cgi?id=103683 --- Comment #12 from richbond --- You shared a useful post and thanks for sharing this to us. AirDroid desktop is an Android app that allows you to manage your phone's files, text messages, and incoming calls from any computer. Download airdroid for pc here. https://pcapps.me/download-airdroid-for-pc-mac/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125194] Moving a graphic object -- obstacle
https://bugs.documentfoundation.org/show_bug.cgi?id=125194 --- Comment #6 from QA Administrators --- Dear Peter Benedek, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127402] Cannot print an unsaved LibreOffice Writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=127402 --- Comment #2 from QA Administrators --- Dear Robert Haggerty, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126110] Collabora online/code docker - owncloud refused to connect cURL error 7
https://bugs.documentfoundation.org/show_bug.cgi?id=126110 --- Comment #7 from QA Administrators --- Dear Andrew, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126681] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=126681 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125194] Moving a graphic object -- obstacle
https://bugs.documentfoundation.org/show_bug.cgi?id=125194 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51264] Validation of signed documents against CRL takes too long when in Linux behind a proxy
https://bugs.documentfoundation.org/show_bug.cgi?id=51264 --- Comment #13 from QA Administrators --- Dear nuno.ponte, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126681] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=126681 --- Comment #6 from QA Administrators --- Dear perryaire, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97487] Comments badly anchored when commenting the last word in a text
https://bugs.documentfoundation.org/show_bug.cgi?id=97487 --- Comment #6 from QA Administrators --- Dear noe.brucy, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127782] New Print dialog is too high
https://bugs.documentfoundation.org/show_bug.cgi?id=127782 Ming Hua changed: What|Removed |Added CC||psoste...@yahoo.com.br --- Comment #50 from Ming Hua --- *** Bug 131139 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131139] Print dialog box in Writer is too tall for screen so the button is off the bottom on ubuntu 18.04
https://bugs.documentfoundation.org/show_bug.cgi?id=131139 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Ming Hua --- Thanks for reporting this bug. This issue has been reported as bug 127782 and already been fixed in the source repository. The upcoming release 6.4.3 will have the fix. I'll mark this bug as a DUPLICATE. If you disagree, feel free to set it back to UNCONFIRMED with a brief explanation. *** This bug has been marked as a duplicate of bug 127782 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130958] Dates formatted incorrectly in 6.3
https://bugs.documentfoundation.org/show_bug.cgi?id=130958 --- Comment #8 from Steve Boatman --- There had been a quesiton regarding if the first verion of this spreadsheet had been created in Excel. I said no but after thinking about it more, it's possible. So, today I rebuilt everyting from scratch in Libreoffice 6.2.8.2. After dealing with all the diffiulties of custom formatting I had everything working as espected. I then downloades Libreoffice 6.3.5.2 for Windows and the date rendering problem is there again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131139] New: Print dialog box in Writer is too tall for screen so the button is off the bottom on ubuntu 18.04
https://bugs.documentfoundation.org/show_bug.cgi?id=131139 Bug ID: 131139 Summary: Print dialog box in Writer is too tall for screen so the button is off the bottom on ubuntu 18.04 Product: LibreOffice Version: 6.4.1.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: psoste...@yahoo.com.br Description: Print dialog box in Writer is too tall for screen so the button is off the bottom on gnome in ubuntu 18,04 Actual Results: . Expected Results: . Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113980] Insert Row and Insert Column in Standard Toolbar not available after (Auto-) Filter has been applied
https://bugs.documentfoundation.org/show_bug.cgi?id=113980 Emersson Augusto Suarez Ortiz changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #12 from Emersson Augusto Suarez Ortiz --- Hi Every Body, this bug is still present, you're able to insert a new column or row if you're in the column that has apply the filter, if your on another column you can't insert a new column. To reproduce that, you still can open the file, then apply the filter in any column, then move to another column and try to insert a column. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 Bug 108364 depends on bug 113980, which changed state. Bug 113980 Summary: Insert Row and Insert Column in Standard Toolbar not available after (Auto-) Filter has been applied https://bugs.documentfoundation.org/show_bug.cgi?id=113980 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131138] New: Cannot export a master document to EPUB.
https://bugs.documentfoundation.org/show_bug.cgi?id=131138 Bug ID: 131138 Summary: Cannot export a master document to EPUB. Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ohh...@gmail.com Description: I cannot export my e-book (a master document) into an .epub format. It always ends up with an error message. Steps to Reproduce: 1. Open a master document. 2. Choose *File › Export As › Export as EPIB...*. Actual Results: An error pops up: “Error saving the document Thomas Leigh - Meditation Experience: Wrong parameter. The operation was started under an invalid parameter.” Expected Results: The document should be saved to .epub successfully. Reproducible: Always User Profile Reset: No Additional Info: The problem persists at least since LibreOffice v. 6.3.4 to the v. 6.4.1. The feature of exporting to .epub seems to work well in case of a normal (non-master) document. If it would help, I can provide You with my document and all its sub-documents... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101305] UI - dark blue selection within template browser as well as within recent documents view
https://bugs.documentfoundation.org/show_bug.cgi?id=101305 --- Comment #17 from Thorsten Wagner --- What is the use case for a multi-select within Startcenter? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: ODF 1.2, xml:id attribute
Michael H wrote: > (hint to developers, I would really love that selecting "linking" turns > this encoded text stream off, and keeps linking to the files instead of > text encoded blocks of data in the files [...]) > Patches welcome. ;) Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/macOS-weld' - include/vcl vcl/inc vcl/Library_vclplug_osx.mk vcl/osx vcl/source
Rebased ref, commits from common ancestor:
commit 47a16992bd539a45a7f3aac02aef1053925bec4f
Author: Tor Lillqvist
AuthorDate: Wed Mar 4 19:34:41 2020 +0200
Commit: Tor Lillqvist
CommitDate: Thu Mar 5 01:39:56 2020 +0200
WIP: macOS welding
Not to be merged to master as such, contains lots of SAL_DEBUG and
other crack.
Change-Id: I5865118c6e4c34f0513ecbd2d759642bc15ad31a
diff --git a/include/vcl/builder.hxx b/include/vcl/builder.hxx
index 3e22639569b8..109c3ba33613 100644
--- a/include/vcl/builder.hxx
+++ b/include/vcl/builder.hxx
@@ -504,7 +504,7 @@ protected:
/*
* @return true if rValue is "True", "true", "1", etc.
*/
-bool toBool(const OUString );
+bool VCL_DLLPUBLIC toBool(const OUString );
#endif
diff --git a/vcl/Library_vclplug_osx.mk b/vcl/Library_vclplug_osx.mk
index 6b94c6c25df1..01f34aec2b00 100644
--- a/vcl/Library_vclplug_osx.mk
+++ b/vcl/Library_vclplug_osx.mk
@@ -51,7 +51,9 @@ $(eval $(call gb_Library_use_libraries,vclplug_osx,\
sal \
salhelper \
tl \
+utl \
vcl \
+xmlreader \
))
$(eval $(call gb_Library_use_externals,vclplug_osx,\
diff --git a/vcl/inc/osx/salframe.h b/vcl/inc/osx/salframe.h
index 2fcdef3609e9..3e150a5fafdf 100644
--- a/vcl/inc/osx/salframe.h
+++ b/vcl/inc/osx/salframe.h
@@ -159,6 +159,8 @@ public:
// done setting up the clipregion
virtual void EndSetClipRegion() override;
+virtual weld::Window* GetFrameWeld() const override;
+
void UpdateFrameGeometry();
// trigger painting of the window
diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h
index edece53b6bea..f0701748145f 100644
--- a/vcl/inc/osx/salinst.h
+++ b/vcl/inc/osx/salinst.h
@@ -32,6 +32,8 @@
#include
#ifdef MACOSX
+#include
+#include
#include
#endif
#include
@@ -142,6 +144,9 @@ public:
// Is this the NSAppThread?
virtual bool IsMainThread() const override;
+virtual weld::Builder* CreateBuilder(weld::Widget* pParent, const
OUString& rUIRoot, const OUString& rUIFile) override;virtual
weld::MessageDialog* CreateMessageDialog(weld::Widget* pParent, VclMessageType
eMessageType, VclButtonsType eButtonType, const OUString )
override;
+virtual weld::Window* GetFrameWeld(const
css::uno::Reference& rWindow) override;
+
void startedPrintJob() { mnActivePrintJobs++; }
void endedPrintJob() { mnActivePrintJobs--; }
@@ -157,6 +162,130 @@ public:
CGImageRef CreateCGImage( const Image& );
NSImage* CreateNSImage( const Image& );
+#ifdef MACOSX
+
+typedef cppu::WeakComponentImplHelper SalAppKitXWindow_Base;
+
+class SalAppKitXWindow : public SalAppKitXWindow_Base
+{
+private:
+osl::Mutex m_aHelperMtx;
+weld::Window* m_pWeldWidget;
+NSView* m_pView;
+
+public:
+
+SalAppKitXWindow(weld::Window* pWeldWidget, NSView* pView)
+: SalAppKitXWindow_Base(m_aHelperMtx)
+, m_pWeldWidget(pWeldWidget)
+, m_pView(pView)
+{
+}
+
+void clear()
+{
+m_pWeldWidget = nullptr;
+m_pView = nullptr;
+}
+
+NSView* getView() const
+{
+return m_pView;
+}
+
+weld::Window* getFrameWeld() const
+{
+return m_pWeldWidget;
+}
+
+// css::awt::XWindow
+void SAL_CALL setPosSize(sal_Int32, sal_Int32, sal_Int32, sal_Int32,
sal_Int16) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+css::awt::Rectangle SAL_CALL getPosSize() override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setVisible(sal_Bool) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setEnable(sal_Bool) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL setFocus() override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addWindowListener(const css::uno::Reference<
css::awt::XWindowListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+void SAL_CALL removeWindowListener(const css::uno::Reference<
css::awt::XWindowListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addFocusListener(const css::uno::Reference<
css::awt::XFocusListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL removeFocusListener(const css::uno::Reference<
css::awt::XFocusListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL addKeyListener(const css::uno::Reference<
css::awt::XKeyListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
+void SAL_CALL removeKeyListener(const css::uno::Reference<
css::awt::XKeyListener >& ) override
+{
+throw css::uno::RuntimeException("not implemented");
+}
+
[Libreoffice-bugs] [Bug 131137] New: Checkbox "Do not distort objects in curve" does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=131137 Bug ID: 131137 Summary: Checkbox "Do not distort objects in curve" does nothing Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Start Draw. Go to Tools > Options > General. Check the options "Do not distort objects in curve". The help says about it:"Maintains relative alignment of Bézier points and 2D drawing objects to each other when you distort the object." Go back to Draw and try something which corresponds to the help text. I can not see any difference to the behavior with checkbox not checked. Go back to Tools > Options > General. Notice, the checkbox is no longer checked. So something is wrong: Feature does not exist => remove checkbox Checkbox is defect or feature is broken => repair It works as intended => Improve help text about this feature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131136] New: Unclear option "Use printer metrics for document formatting"
https://bugs.documentfoundation.org/show_bug.cgi?id=131136 Bug ID: 131136 Summary: Unclear option "Use printer metrics for document formatting" Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Go to Tools > Options > Draw > General. It has a section 'Compatibility' with the option "Use printer metrics for document formatting". The purpose of that option is not clear. Does it work at all? I see no difference whether it is on or off. Option is obsolete => remove it Option is broken => fix it Option works as intended => Improve its description in the help -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130902] FILEOPEN Calc crashes when opening an .ods file created by itself
https://bugs.documentfoundation.org/show_bug.cgi?id=130902 szots...@gmail.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from szots...@gmail.com --- Document is sent in e-mail and as I wrote there it doesn't crash with the setting 'SAL_USE_VCLPLUGIN=gen soffice'. Thank you for the hint! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'feature/macOS-weld'
New branch 'feature/macOS-weld' available with the following commits: commit 8f0287f8f7fd6ccb542caca3b0d392dd001f7c5f Author: Tor Lillqvist Date: Wed Mar 4 19:34:41 2020 +0200 WIP: macOS welding Not to be merged to master as such, contains lots of SAL_DEBUG and other crack. Change-Id: I5865118c6e4c34f0513ecbd2d759642bc15ad31a commit 844b1695e9a527f60dd16e03ec0479defe11e244 Author: Tor Lillqvist Date: Wed Mar 4 19:33:25 2020 +0200 Add some more source files for completeness and breakpinting convenience Change-Id: Ica219e6443aad119c5f303e5c7bb2aef391fd848 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130233] Skia: quality of font rendering to canvas is degraded
https://bugs.documentfoundation.org/show_bug.cgi?id=130233 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #8 from Regina Henschel --- Created attachment 158398 --> https://bugs.documentfoundation.org/attachment.cgi?id=158398=edit screenshot of menu text and document text I see bad font rendering too, both in menus and in the text. I have got a "Intel HD Graphics 630" on Windows 10. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126434] Editing OLE drawing object : layout invisible in OLE draw canvas after a copy/paste onto Writer canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=126434 --- Comment #11 from Ferry Toth --- I confirm this is resolved in 6.3.4, thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131083] Calc crashes when marking cells and you exit without saving
https://bugs.documentfoundation.org/show_bug.cgi?id=131083 --- Comment #25 from Michael Weghorn --- (In reply to mgruber from comment #24) > How many attempts did you try? > At one point I've had Calc exit 8x smoothly before it crashed. > I know it's really odd that it doesn't crash predictably every time. Probably 15-20 times. > You can try to play around with other cells, typing some random stuff in, > marking others and so on. I did that, but - unfortunately in this case - it still didn't crash for me. > > Unfortunately, I see no explicit information like where memory was free'd > > etc., > > Is there anything I can configure in Valgrind to get these informations? No, Valgrind ususally prints that by itself if it has that information. *Maybe*, taking more time to analyse the backtrace, valgrind output and related code in the qt5 VCL plugin (and maybe Qt library itself) might already be enough to get an understanding of what may be happening. I personally have to say I currently can't really say whether I'll find that time soon, but if anybody else wants to take a look, please do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/dtoa
external/dtoa/coverity.patch | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
New commits:
commit 22cbdc7b11e25ec8afc697096c008eac95022f02
Author: Caolán McNamara
AuthorDate: Wed Mar 4 17:37:16 2020 +
Commit: Caolán McNamara
CommitDate: Wed Mar 4 22:12:47 2020 +0100
always include assert.h and don't provide a different assert define
rely on the -DNDEBUG we pass in on non-debug builds to to disable assert
Change-Id: I089be56aa6fcddb78507bb0f0457c67c226437a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89989
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/external/dtoa/coverity.patch b/external/dtoa/coverity.patch
index 3113e5dbc8ff..8fb1765315af 100644
--- a/external/dtoa/coverity.patch
+++ b/external/dtoa/coverity.patch
@@ -1,6 +1,23 @@
--- dtor/src/dtoa.c.coverity
+++ dtor/src/dtoa.c
-@@ -2303,6 +2303,7 @@
+@@ -216,14 +216,14 @@
+ typedef unsigned Long ULong;
+ #endif
+
+-#ifdef DEBUG
+ #include
++
++#ifdef DEBUG
+ #include "stdio.h"
+ #define Bug(x) {fprintf(stderr, "%s\n", x); exit(1);}
+ #define Debug(x) x
+ int dtoa_stats[7]; /* strtod_{64,96,bigcomp},dtoa_{exact,64,96,bigcomp} */
+ #else
+-#define assert(x) /*nothing*/
+ #define Debug(x) /*nothing*/
+ #endif
+
+@@ -2301,6 +2301,7 @@
if ((y = d1)) {
if ((k = lo0bits())) {
x[0] = y | z << (32 - k);
@@ -8,7 +25,7 @@
z >>= k;
}
else
-@@ -3031,6 +3032,7 @@
+@@ -3029,6 +3030,7 @@
|| ((n = nbits & kmask) !=0
&& hi0bits(x[k-1]) < 32-n)) {
rshift(b,1);
@@ -16,7 +33,7 @@
if (++e > Emax)
goto ovfl;
}
-@@ -3347,6 +3349,7 @@
+@@ -3345,6 +3347,7 @@
if ((dd = s0[j++] - '0' - dig))
goto ret;
if (!b->x[0] && b->wds == 1) {
@@ -24,7 +41,7 @@
if (i < nd)
dd = 1;
goto ret;
-@@ -3609,6 +3612,7 @@
+@@ -3607,6 +3610,7 @@
switch(c = *++s) {
case '-':
esign = 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/text/XMLLineNumberingImportContext.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 368e9a829e07b3f8624898d69d2c00ec3bc590ec Author: Caolán McNamara AuthorDate: Wed Mar 4 14:09:56 2020 + Commit: Caolán McNamara CommitDate: Wed Mar 4 22:12:13 2020 +0100 ofz#21045 Invalid-enum-value runtime error: load of value 65535, which is not a valid value for type 'enum LineNumberingToken' Change-Id: I432ba6f46838b499c690f717216b61b127dc2dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89977 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/xmloff/source/text/XMLLineNumberingImportContext.cxx b/xmloff/source/text/XMLLineNumberingImportContext.cxx index 6cd7f48575b9..6207df4e48cf 100644 --- a/xmloff/source/text/XMLLineNumberingImportContext.cxx +++ b/xmloff/source/text/XMLLineNumberingImportContext.cxx @@ -110,7 +110,7 @@ void XMLLineNumberingImportContext::SetAttribute( sal_uInt16 nPrefixKey, static const SvXMLTokenMap aTokenMap(aLineNumberingTokenMap); -enum LineNumberingToken eToken = static_cast(aTokenMap.Get(nPrefixKey, rLocalName)); +auto eToken = aTokenMap.Get(nPrefixKey, rLocalName); bool bTmp(false); sal_Int32 nTmp; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131135] New: Table icons incorrect when using Sukapura icon set
https://bugs.documentfoundation.org/show_bug.cgi?id=131135 Bug ID: 131135 Summary: Table icons incorrect when using Sukapura icon set Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: drewjensen.in...@gmail.com Created attachment 158397 --> https://bugs.documentfoundation.org/attachment.cgi?id=158397=edit Screen shot with Sukapura icons Tested on Ubuntu 18.04 and Version: 7.0.0.0.alpha0+ Build ID: 45ca47ac39c03df4de52d627a764f16068b1eab0 Reproduce 1 - Start LO and from Options->View select the Sukapura icons 2 - Open any .odb file with tables 2 - Change to the Table view section results Tables are listed with Calc document icons. expected Tables listed with a unique Table icon See attached screen shot of a file which includes a View, which seems alight and I would suggest a Table icon would be just one of what depicts two joined tables in that icon -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116079] Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
https://bugs.documentfoundation.org/show_bug.cgi?id=116079
--- Comment #11 from Julien Nabet ---
With this patch, I can open the file:
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index f70995763c4c..d2cfb1417afa 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -1044,13 +1044,6 @@ void FastSaxParserImpl::parse()
nRead = rEntity.maConverter.readAndConvert( seqOut, BUFFER_SIZE );
if( nRead <= 0 )
{
-if( rEntity.mpParser != nullptr )
-{
-if( xmlParseChunk( rEntity.mpParser, reinterpret_cast(seqOut.getConstArray()), 0, 1 ) != XML_ERR_OK )
-rEntity.throwException( mxDocumentLocator, true );
-if (rEntity.hasException())
-rEntity.throwException(mxDocumentLocator, true);
-}
break;
}
This part has been put with:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=82d08580e368afbc9d73da3613845a36a89b0a8c
author Luboš Luňák 2014-11-14 17:13:41 +0100
committer Luboš Luňák 2014-11-14 17:20:00
+0100
commit 82d08580e368afbc9d73da3613845a36a89b0a8c (patch)
treeef353fcfd8d7b427a0ecf2281eb7c0264f6fc9a6
parent 37800290245fd0462295a8bbaabd9d761929fa65 (diff)
switch saxparser from expat to libxml2
I don't know if it's ok or not.
nRead is sal_Int32 but it seems it can't be negative.
Also perhaps meta.xml with just encoding is ok but another xml file with just
encoding is not ok
=> a bit stuck here.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/bitmap/BitmapFilterStackBlur.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6a05f8810684024303047ac9105be4ff5ae8c536 Author: Andrea Gelmini AuthorDate: Tue Mar 3 17:50:20 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Mar 4 21:57:57 2020 +0100 Fix typo Change-Id: I48d8000abc0cd835781dffe6b2b6621639a5435f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89900 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/vcl/source/bitmap/BitmapFilterStackBlur.cxx b/vcl/source/bitmap/BitmapFilterStackBlur.cxx index d88480787b8b..28a0cbc80ffe 100644 --- a/vcl/source/bitmap/BitmapFilterStackBlur.cxx +++ b/vcl/source/bitmap/BitmapFilterStackBlur.cxx @@ -476,13 +476,13 @@ void centerExtendBitmap(Bitmap& rBitmap, sal_Int32 nExtendSize, Color aColor) /** * Implementation of stack blur - a fast Gaussian blur approximation. - * nRadius - blur radious, valid values are between 2 and 254 + * nRadius - blur radius, valid values are between 2 and 254 * bExtend - extend the bitmap in all directions by the radius * * Stack Blur Algorithm by Mario Klingemann * (http://www.quasimondo.com/StackBlurForCanvas/StackBlurDemo.html) * - * Additionally eferences and implementations: + * Additionally references and implementations: * - Blur.js by Jacob Kelley * (http://www.blurjs.com) * - BlurEffectForAndroidDesign by Nicolas Pomepuy ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 84379] CONTEXT MENU: Easily add fields when in the header and footer
https://bugs.documentfoundation.org/show_bug.cgi?id=84379 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #6 from andreas_k --- as there is no duplicated but since 2 years it look like users are ok that they can't customize the header/footer context menu. I propose to close this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106571] Remove context menu for default Gradients/Bitmaps/Patterns/Hatches or add restore tool
https://bugs.documentfoundation.org/show_bug.cgi?id=106571 andreas_k changed: What|Removed |Added CC||kain...@gmail.com --- Comment #6 from andreas_k --- I don't see the point if an user want to delete an default (system installed) preset. If you want to delete an preset there is an additional dialog which ask if you really want to delete the preset. So from my point of view it's not possible that an user will delete something by mistake cause there is this additional dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119682] Change Draw's image export default format from gif to png
https://bugs.documentfoundation.org/show_bug.cgi?id=119682 --- Comment #6 from andreas_k --- so did someone know how can fix this bug? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130928] Area Fill update presets
https://bugs.documentfoundation.org/show_bug.cgi?id=130928 --- Comment #12 from andreas_k --- fyi I found out that you can delete ab preset gradient, bitmap, hatch, pattern with right click menu. So if an user want less presets, it can be done easy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130928] Area Fill update presets
https://bugs.documentfoundation.org/show_bug.cgi?id=130928 --- Comment #12 from andreas_k --- fyi I found out that you can delete ab preset gradient, bitmap, hatch, pattern with right click menu. So if an user want less presets, it can be done easy. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkinst.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 4e755e622f2d782d657626b6234fb3acd3d08e15
Author: Caolán McNamara
AuthorDate: Wed Mar 4 17:04:07 2020 +
Commit: Caolán McNamara
CommitDate: Wed Mar 4 21:38:35 2020 +0100
scroll to the row when putting the cursor in it
Change-Id: If1edbf1d0f94176a12a9359c17179301304f2c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89988
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 8c384f5477df..a79a3b6fa654 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -9560,6 +9560,7 @@ public:
{
disable_notify_events();
GtkTreePath* path = gtk_tree_path_new_from_indices(pos, -1);
+gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
gtk_tree_view_set_cursor(m_pTreeView, path, nullptr, false);
gtk_tree_path_free(path);
enable_notify_events();
@@ -10064,6 +10065,7 @@ public:
const GtkInstanceTreeIter& rGtkIter = static_cast(rIter);
GtkTreeModel *pModel = GTK_TREE_MODEL(m_pTreeStore);
GtkTreePath* path = gtk_tree_model_get_path(pModel,
const_cast());
+gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
gtk_tree_view_set_cursor(m_pTreeView, path, nullptr, false);
gtk_tree_path_free(path);
enable_notify_events();
@@ -10614,6 +10616,7 @@ public:
}
g_list_free(pRenderers);
+gtk_tree_view_scroll_to_cell(m_pTreeView, path, pColumn, false, 0, 0);
gtk_tree_view_set_cursor(m_pTreeView, path, pColumn, true);
gtk_tree_path_free(path);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx
include/vcl/weld.hxx |2 ++
vcl/source/app/salvtables.cxx |7 +++
vcl/unx/gtk3/gtk3gtkinst.cxx |7 +++
3 files changed, 16 insertions(+)
New commits:
commit 7af11e2e051eedd790e0ed8c8ac0e1e667c1001b
Author: Caolán McNamara
AuthorDate: Wed Mar 4 14:45:18 2020 +
Commit: Caolán McNamara
CommitDate: Wed Mar 4 21:38:05 2020 +0100
add iter_previous_sibling
Change-Id: Ic9ff26361cc9fed32760260e085660f05e13f4d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89987
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 6476695bbb27..220fabbd16fa 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -890,6 +890,8 @@ public:
virtual bool get_iter_first(TreeIter& rIter) const = 0;
// set iter to point to next node at the current level
virtual bool iter_next_sibling(TreeIter& rIter) const = 0;
+// set iter to point to previous node at the current level
+virtual bool iter_previous_sibling(TreeIter& rIter) const = 0;
// set iter to point to next node, depth first, then sibling
virtual bool iter_next(TreeIter& rIter) const = 0;
virtual bool iter_children(TreeIter& rIter) const = 0;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index fb688c2570fe..c9c2a4cbea4e 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -4111,6 +4111,13 @@ public:
return rVclIter.iter != nullptr;
}
+virtual bool iter_previous_sibling(weld::TreeIter& rIter) const override
+{
+SalInstanceTreeIter& rVclIter =
static_cast(rIter);
+rVclIter.iter = rVclIter.iter->PrevSibling();
+return rVclIter.iter != nullptr;
+}
+
virtual bool iter_next(weld::TreeIter& rIter) const override
{
SalInstanceTreeIter& rVclIter =
static_cast(rIter);
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index d9e3320fe09a..8c384f5477df 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -10083,6 +10083,13 @@ public:
return gtk_tree_model_iter_next(pModel, );
}
+virtual bool iter_previous_sibling(weld::TreeIter& rIter) const override
+{
+GtkInstanceTreeIter& rGtkIter =
static_cast(rIter);
+GtkTreeModel *pModel = GTK_TREE_MODEL(m_pTreeStore);
+return gtk_tree_model_iter_previous(pModel, );
+}
+
virtual bool iter_next(weld::TreeIter& rIter) const override
{
GtkInstanceTreeIter& rGtkIter =
static_cast(rIter);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116079] Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
https://bugs.documentfoundation.org/show_bug.cgi?id=116079 --- Comment #10 from Julien Nabet --- I noticed that meta.xml contained just: and nothing else afterwards. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: uitest/uitest
uitest/uitest/test.py | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
New commits:
commit d1a4f95def7d65165a992613784564c02b1c76bb
Author: Miklos Vajna
AuthorDate: Wed Mar 4 17:10:13 2020 +0100
Commit: Miklos Vajna
CommitDate: Wed Mar 4 21:36:15 2020 +0100
uitest: speed up close_doc()
I used solenv/gbuild/Trace.mk to measure where the time is spent at the
end of an incremental 'make check'. The last 95 seconds in spent
executing UITest_demo_ui alone.
If that test is executed in isolation, it takes 135 seconds. Profiling
the test shows that some of that time is spent on waiting for an
OnViewClosed event to be emitted after .uno:CloseDoc is dispatched.
I'm not sure how this worked in the past, but seems that in case there
is a single view, then we currently only emit OnUnloaded, which means we
wait a minute for an event that does not arrive, then we silently move
on.
Fix the problem by closing the document via dispose(), the old code also
just discarded all changes to the file.
The new cost of UITest_demo_ui is 73 seconds (54% of baseline).
The overall 'make check' is 84 seconds faster with this, too.
Change-Id: I97e8e2af3ba355b8029920076e070d619b110b77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89984
Reviewed-by: Miklos Vajna
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/uitest/uitest/test.py b/uitest/uitest/test.py
index 72b2a810c380..b4ad24e5c31c 100644
--- a/uitest/uitest/test.py
+++ b/uitest/uitest/test.py
@@ -162,21 +162,19 @@ class UITest(object):
raise DialogNotClosedException()
def close_doc(self):
-with EventListener(self._xContext, ["DialogExecute", "OnViewClosed"] )
as event:
-if not self._xUITest.executeDialog(".uno:CloseDoc"):
-print(".uno:CloseDoc failed")
-time_ = 0
-while time_ < MAX_WAIT:
-if event.hasExecuted("DialogExecute"):
-xCloseDlg = self._xUITest.getTopFocusWindow()
-xNoBtn = xCloseDlg.getChild("discard")
-xNoBtn.executeAction("CLICK", tuple())
-return
-elif event.hasExecuted("OnViewClosed"):
-return
-
-time_ += DEFAULT_SLEEP
-time.sleep(DEFAULT_SLEEP)
+desktop = self.get_desktop()
+active_frame = desktop.getActiveFrame()
+if not active_frame:
+print("close_doc: no active frame")
+return
+component = active_frame.getController().getModel()
+if not component:
+print("close_doc: active frame has no component")
+return
+component.dispose()
+frames = desktop.getFrames()
+if frames:
+frames[0].activate()
def execute_blocking_action(self, action, dialog_element=None,
args=(), dialog_handler=None, printNames=False):
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116079] Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
https://bugs.documentfoundation.org/show_bug.cgi?id=116079 --- Comment #9 from Julien Nabet --- Created attachment 158396 --> https://bugs.documentfoundation.org/attachment.cgi?id=158396=edit bt with debug symbols Here's the bt from throw xml::sax::SAXParseException -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source sw/source
sc/source/ui/view/gridwin.cxx | 10 +++---
sw/source/uibase/docvw/edtwin.cxx |6 ++
2 files changed, 13 insertions(+), 3 deletions(-)
New commits:
commit 9323307d675b71c501534ee98872a2f00b465bc2
Author: Mert Tumer
AuthorDate: Wed Feb 26 18:48:46 2020 +0300
Commit: Andras Timar
CommitDate: Wed Mar 4 21:19:58 2020 +0100
fix ToC links give unhelpful url popups
core expects ctrl+click for internal links too and
it should not expect it if it is tiled rendering
Change-Id: Id841f0e9729e46f00988ea0b4eb29bd65098a740
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89559
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
(cherry picked from commit 3fe9dfca2d44d9e41ee329883f199359c673f382)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89919
Tested-by: Jenkins
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 5ca54bae2a93..d690b59fccc6 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2202,14 +2202,18 @@ void ScGridWindow::MouseButtonUp( const MouseEvent&
rMEvt )
if ( GetEditUrl( rMEvt.GetPosPixel(), , , ) )
{
nMouseStatus = SC_GM_NONE; // Ignore double-click
-
+bool isTiledRendering = comphelper::LibreOfficeKit::isActive();
// ScGlobal::OpenURL() only understands Calc A1 style syntax.
// Convert it to Calc A1 before calling OpenURL().
if (pDoc->GetAddressConvention() ==
formula::FormulaGrammar::CONV_OOO)
{
+if (aUrl.startsWith("#")) {
+ScGlobal::OpenURL(aUrl, aTarget, isTiledRendering);
+return;
+}
// in mobile view there is no ctrl+click and for hyperlink
popup
// the cell coordinates must be sent along with click position
for elegance
-if (comphelper::LibreOfficeKit::isActive() &&
+if (isTiledRendering &&
comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView()))
{
ScTabViewShell* pViewShell = pViewData->GetViewShell();
@@ -2260,7 +2264,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent& rMEvt
)
aBuf.append('#');
OUString
aUrlCalcA1(aTempAddr.Format(ScRefFlags::ADDR_ABS_3D, pDoc,
formula::FormulaGrammar::CONV_OOO));
aBuf.append(aUrlCalcA1);
-ScGlobal::OpenURL(aBuf.makeStringAndClear(), aTarget);
+ScGlobal::OpenURL(aBuf.makeStringAndClear(), aTarget,
isTiledRendering);
}
}
diff --git a/sw/source/uibase/docvw/edtwin.cxx
b/sw/source/uibase/docvw/edtwin.cxx
index a1e1a6f26db2..d60b347c6bb0 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -4650,6 +4650,12 @@ void SwEditWin::MouseButtonUp(const MouseEvent& rMEvt)
}
else if ( IsAttrAtPos::InetAttr ==
aContentAtPos.eContentAtPos )
{
+if (comphelper::LibreOfficeKit::isActive())
+{
+OUString val((*static_cast(aContentAtPos.aFnd.pAttr)).GetValue());
+if (val.startsWith("#"))
+bExecHyperlinks = true;
+}
if ( bExecHyperlinks &&
aContentAtPos.aFnd.pAttr )
rSh.ClickToINetAttr( *static_cast(aContentAtPos.aFnd.pAttr), nFilter );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127782] New Print dialog is too high
https://bugs.documentfoundation.org/show_bug.cgi?id=127782 --- Comment #49 from Commit Notification --- Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/9c3171d4209f8eceb0152d7d9f70456c5813914e Resolves tdf#127782 - New Print dialog is too high It will be available in 6.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127782] New Print dialog is too high
https://bugs.documentfoundation.org/show_bug.cgi?id=127782 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0 target:6.4.1 |target:6.5.0 target:6.4.1 |target:7.0.0|target:7.0.0 target:6.4.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - vcl/source
vcl/source/window/printdlg.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9c3171d4209f8eceb0152d7d9f70456c5813914e
Author: Heiko Tietze
AuthorDate: Tue Feb 25 11:58:02 2020 +0100
Commit: Heiko Tietze
CommitDate: Wed Mar 4 21:17:58 2020 +0100
Resolves tdf#127782 - New Print dialog is too high
Amends Iea41f9cf335b75210de0acf5688fddd5e3dd3dbb
Change-Id: Ic669332245ad9c5ee6366765da8a5bc632dd159c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89423
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
(cherry picked from commit b268715912d4c2034b9b9d38e75446bef7bbb11f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89921
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index b42a1ce41213..7d340559806a 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -147,8 +147,8 @@ void PrintDialog::PrintPreviewWindow::Resize()
void PrintDialog::PrintPreviewWindow::SetDrawingArea(weld::DrawingArea*
pDrawingArea)
{
-pDrawingArea->set_size_request(pDrawingArea->get_approximate_digit_width()
* 55,
- pDrawingArea->get_text_height() * 40);
+pDrawingArea->set_size_request(pDrawingArea->get_approximate_digit_width()
* 45,
+ pDrawingArea->get_text_height() * 30);
CustomWidgetController::SetDrawingArea(pDrawingArea);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Minutes from the UX/design meeting 2020-Mar-04
Present: jackandmixers, Cor, Shivam, Rizal, Heiko Comments from: Stuart, Eike, Jay, Maxim Tickets * UNO command to dock all toolbars + https://bugs.documentfoundation.org/show_bug.cgi?id=131005 + adding UNO commands is easy but hard to remove later + push (Cor), abandon/wait (Heiko), unsure (shivam) => better abandon * Navigate document content when selection is made in the Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=131063 + single or double click for default action (go-to) + con: usually the default action (go-to) is done by double click + con: single click blocks context menu for not active object + keep the context menu could be done also by special handling of right button + con: breaks flow where you work in Headings-part, and select e.g. an image or work in a table + con (by another user in BugZilla): I'm split as single click default action makes a pure selection impossible. For example, you cannot promote a chapter without jumping to it. Or rename a shape. + pro: weird situiation when a different item is selected as the active position; wouldnt be an issue with single click + similar issue with styles & formatting where single click does not apply the style + rather a different topic IMO (Cor) + pro: in document selection is a single click and changes the Navigator + with no clear need, let's not break the known behavior, present left and right (Cor) + tend to weight the pro higher (Heiko) + the other way round for me; will likely hate it (Cor) => comment with this consideration on the ticket * Make Styles command (icon) on toolbar toggle the Styles Window (like F11 does) + https://bugs.documentfoundation.org/show_bug.cgi?id=130441 + toggle on/off is not switching from any other tab + many very similar commands, confusing for users (Heiko) + +1 (Stuart, Cor) => go with the change * Bringing uniformity to styles shortcuts + https://bugs.documentfoundation.org/show_bug.cgi?id=98333 + final decision would be good; either WF or green light + Shift+Ctrl+Anything requires two hands (Eike) + -1 to any major change of shortcuts unless tdf#123768 is done (Heiko) + agree with WF as users are familiar with existing shortcuts (Cor) => WF * Improve listing of (table) styles + https://bugs.documentfoundation.org/show_bug.cgi?id=130953 + we have styles stored in the current document vs. permanent styles (Maxim) + some ideas: styles from the current document in italic, with an icon up-front... + paragraph styles are always stored in the document, problem would vanish when we get rid of the autoformat dialog (Cor) + extensions could add more styles + another option for TS could be to show it after a spearator => focus on TS and get rid of autoformat dialog => DUP to "get rid of autoformat dialog" * 'Slide Design' dialog: rename check 'Exchange background page' to "Apply slide master to all slides" + https://bugs.documentfoundation.org/show_bug.cgi?id=84342 + "Apply to all slides (with similar Master as the selected slide)" + better use shorter label and tooltip => accepted (Cor) * Area Fill update presets + https://bugs.documentfoundation.org/show_bug.cgi?id=130928 + which pattern and how many, see c7f. + too many defaults make it difficult to find the right item (Cor) + patterns are not easy to create and more presets make sense (Andreas) => go with the new pattern list * Find and Find-&-Replace need character auto-replacement to support string searches and replacements + https://bugs.documentfoundation.org/show_bug.cgi?id=91030 + search also for auto-replacements when looking for something like an apostrophe or WF => search not only for the actual chars but also potentially autocorrected signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Minutes from the UX/design meeting 2020-Mar-04
Present: jackandmixers, Cor, Shivam, Rizal, Heiko Comments from: Stuart, Eike, Jay, Maxim Tickets * UNO command to dock all toolbars + https://bugs.documentfoundation.org/show_bug.cgi?id=131005 + adding UNO commands is easy but hard to remove later + push (Cor), abandon/wait (Heiko), unsure (shivam) => better abandon * Navigate document content when selection is made in the Navigator + https://bugs.documentfoundation.org/show_bug.cgi?id=131063 + single or double click for default action (go-to) + con: usually the default action (go-to) is done by double click + con: single click blocks context menu for not active object + keep the context menu could be done also by special handling of right button + con: breaks flow where you work in Headings-part, and select e.g. an image or work in a table + con (by another user in BugZilla): I'm split as single click default action makes a pure selection impossible. For example, you cannot promote a chapter without jumping to it. Or rename a shape. + pro: weird situiation when a different item is selected as the active position; wouldnt be an issue with single click + similar issue with styles & formatting where single click does not apply the style + rather a different topic IMO (Cor) + pro: in document selection is a single click and changes the Navigator + with no clear need, let's not break the known behavior, present left and right (Cor) + tend to weight the pro higher (Heiko) + the other way round for me; will likely hate it (Cor) => comment with this consideration on the ticket * Make Styles command (icon) on toolbar toggle the Styles Window (like F11 does) + https://bugs.documentfoundation.org/show_bug.cgi?id=130441 + toggle on/off is not switching from any other tab + many very similar commands, confusing for users (Heiko) + +1 (Stuart, Cor) => go with the change * Bringing uniformity to styles shortcuts + https://bugs.documentfoundation.org/show_bug.cgi?id=98333 + final decision would be good; either WF or green light + Shift+Ctrl+Anything requires two hands (Eike) + -1 to any major change of shortcuts unless tdf#123768 is done (Heiko) + agree with WF as users are familiar with existing shortcuts (Cor) => WF * Improve listing of (table) styles + https://bugs.documentfoundation.org/show_bug.cgi?id=130953 + we have styles stored in the current document vs. permanent styles (Maxim) + some ideas: styles from the current document in italic, with an icon up-front... + paragraph styles are always stored in the document, problem would vanish when we get rid of the autoformat dialog (Cor) + extensions could add more styles + another option for TS could be to show it after a spearator => focus on TS and get rid of autoformat dialog => DUP to "get rid of autoformat dialog" * 'Slide Design' dialog: rename check 'Exchange background page' to "Apply slide master to all slides" + https://bugs.documentfoundation.org/show_bug.cgi?id=84342 + "Apply to all slides (with similar Master as the selected slide)" + better use shorter label and tooltip => accepted (Cor) * Area Fill update presets + https://bugs.documentfoundation.org/show_bug.cgi?id=130928 + which pattern and how many, see c7f. + too many defaults make it difficult to find the right item (Cor) + patterns are not easy to create and more presets make sense (Andreas) => go with the new pattern list * Find and Find-&-Replace need character auto-replacement to support string searches and replacements + https://bugs.documentfoundation.org/show_bug.cgi?id=91030 + search also for auto-replacements when looking for something like an apostrophe or WF => search not only for the actual chars but also potentially autocorrected signature.asc Description: OpenPGP digital signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 131134] When cursor jumps to start or end of file with up/down keys, save column via pressing up/down keys again.
https://bugs.documentfoundation.org/show_bug.cgi?id=131134 Canberk TURAN changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |canberkktur...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131134] When cursor jumps to start or end of file with up/down keys, save column via pressing up/down keys again.
https://bugs.documentfoundation.org/show_bug.cgi?id=131134 Canberk TURAN changed: What|Removed |Added Summary|When cursor at last line|When cursor jumps to start ||or end of file with up/down ||keys, save column via ||pressing up/down keys ||again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Cor Nouws changed: What|Removed |Added Component|Writer |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Cor Nouws changed: What|Removed |Added Component|Writer |LibreOffice -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl Version|4.2.8.2 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91030] Writer: Find and Find-&-Replace need character auto-replacement to support string searches and replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=91030 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl Version|4.2.8.2 release |Inherited From OOo -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] online.git: cypress_test/integration_tests
cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js |
10 --
1 file changed, 4 insertions(+), 6 deletions(-)
New commits:
commit 6114b8c8cef37ec517a7b5c8fb47fd144d7ad03a
Author: Tamás Zolnai
AuthorDate: Wed Mar 4 20:18:30 2020 +0100
Commit: Tamás Zolnai
CommitDate: Wed Mar 4 21:10:13 2020 +0100
cypress: mobile: enable some mobile wizard's state related checks.
Change-Id: I0bf19450f14e8e8d99e1a103558499d53f21f760
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89995
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tamás Zolnai
diff --git
a/cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js
b/cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js
index 676eb2703..47790dc47 100644
--- a/cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/mobile_wizard_state_spec.js
@@ -45,9 +45,8 @@ describe('Mobile wizard state tests', function() {
.click();
// Mobile wizard is opened and it has any content
- // TODO: fix this bug
- /*cy.get('#mobile-wizard-content')
- .should('not.be.empty'); */
+ cy.get('#mobile-wizard-content')
+ .should('not.be.empty');
cy.get('#tb_actionbar_item_mobile_wizard table')
.should('have.class', 'checked');
});
@@ -82,9 +81,8 @@ describe('Mobile wizard state tests', function() {
cy.get('#tb_actionbar_item_mobile_wizard')
.click();
- // TODO: fix this bug
- //cy.get('#mobile-wizard-content')
- // .should('not.be.empty');
+ cy.get('#mobile-wizard-content')
+ .should('not.be.empty');
cy.get('#tb_actionbar_item_mobile_wizard table')
.should('have.class', 'checked');
});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 131133] When saving an rtf document in txt format, the source footnotes are not saved with the rest of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=131133 Charles Dobie changed: What|Removed |Added CC||cdo...@superaje.com --- Comment #1 from Charles Dobie --- Created attachment 158395 --> https://bugs.documentfoundation.org/attachment.cgi?id=158395=edit genealogy descendant report in .rtf format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131134] New: When cursor at last line
https://bugs.documentfoundation.org/show_bug.cgi?id=131134 Bug ID: 131134 Summary: When cursor at last line Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: canberkktur...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 Dieter changed: What|Removed |Added Depends on||131122 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131122 [Bug 131122] Tables in Libreoffice Writer do not save column width settings -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131133] New: When saving an rtf document in txt format, the source footnotes are not saved with the rest of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=131133 Bug ID: 131133 Summary: When saving an rtf document in txt format, the source footnotes are not saved with the rest of the document Product: LibreOffice Version: 6.3.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cdo...@superaje.com Description: My genealogy program generates descendant lists in .rtf format. For various reasons I need the list in .txt format, so I loaded the .rtf list into LibreOffice and saved it as a .txt file. The document is saved and looks fine, except for the fact that the source footnotes are missing. This happens all the time. Steps to Reproduce: 1. Load the attached .rtf file into LibreOffice Writer 2. Save the file as a .txt file 3. Look at the bottom of the .txt file -- the source footnotes will be missing Actual Results: The source footnotes of the .txt document are missing Expected Results: The source footnotes should have been saved in .txt format at the end of the document. Reproducible: Always User Profile Reset: No Additional Info: If the same .rtf document is saved in .html format, the source footnotes are saved properly, but of course in .html format. Version: 6.3.5.2 (x64) Build ID: dd0751754f11728f69b42ee2af66670068624673 CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-CA (en_CA); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Dieter changed: What|Removed |Added Depends on||131104 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131104 [Bug 131104] Pasted text is reformated -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131104] Pasted text is reformated
https://bugs.documentfoundation.org/show_bug.cgi?id=131104 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||102593 Version|3.3.0 release |5.4.7.2 release --- Comment #6 from Dieter --- I confirm it with Version: 7.0.0.0.alpha0+ (x64) Build ID: eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-GB Calc: threaded and also with LO 5.4.7.2 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdxcgv.cxx | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
New commits:
commit d08d5c1857482cb3789ed2896921abeb83f4d217
Author: Armin Le Grand
AuthorDate: Wed Mar 4 17:40:50 2020 +0100
Commit: Armin Le Grand
CommitDate: Wed Mar 4 20:53:49 2020 +0100
tdf#125520 enhance internal OLE cloning
For D/Copy te temp SdrModel had no
IEmbeddedHelper/Persist, so use the one from
the source SDrModel in the temporary one
for transfer/cloning. Should be okay, the
persist is part of the DocumentModels, handed
to the SDrModel for usage and *not* destroyed
when SdrModel gets destroyed
Change-Id: I46e9e371ef8802d6c1c5bfe761b26651ae6e1f73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89986
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index 1c5664a2602e..4ba25a6c1265 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -734,7 +734,20 @@ std::unique_ptr
SdrExchangeView::CreateMarkedObjModel() const
if(nullptr == pNewObj)
{
-// not cloned yet, use default way
+// not cloned yet
+if (pObj->GetObjIdentifier() == OBJ_OLE2)
+{
+// tdf#125520 - temp SdrModel will need a
comphelper::IEmbeddedHelper
+// to succesfully clone the OLE content, use the one from
source model
+// in the temporary SdrModel - it gets not deleted in SdrModel
destructor.
+// As long as the temporary SdrModel is used temprary (and
does NOT get
+// extended to a full document) this *should* work. There stay
some
+// concerns about what may happen in BG and if saved/loaded
from clipboard,
+// so this *might* need to be enhanced in the future.
+pNewModel->SetPersist(mpModel->GetPersist());
+}
+
+// use default way
pNewObj = pObj->CloneSdrObject(*pNewModel);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130953] Improve listing of (table) styles to reflect that newly created styles are in the document only (not available elsewhere)
https://bugs.documentfoundation.org/show_bug.cgi?id=130953 Cor Nouws changed: What|Removed |Added Summary|Improve listing of (table) |Improve listing of (table) |styles |styles to reflect that ||newly created styles are in ||the document only (not ||available elsewhere) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 130953] Improve listing of (table) styles to reflect that newly created styles are in the document only (not available elsewhere)
https://bugs.documentfoundation.org/show_bug.cgi?id=130953 Cor Nouws changed: What|Removed |Added Summary|Improve listing of (table) |Improve listing of (table) |styles |styles to reflect that ||newly created styles are in ||the document only (not ||available elsewhere) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131122] Tables in Libreoffice Writer do not save column width settings
https://bugs.documentfoundation.org/show_bug.cgi?id=131122 Vladimir changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 Assignee|libreoffice-b...@lists.free |smolin.vo...@yandex.ru |desktop.org | --- Comment #3 from Vladimir --- Created attachment 158394 --> https://bugs.documentfoundation.org/attachment.cgi?id=158394=edit Spreadsheet file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
