[Libreoffice-bugs] [Bug 132426] Saving an opened txt with a specific character encoding is overwritten when saved

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132426

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
Andreas, thank you for reporting the bug. Please attach a sample document, as
this makes it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2020-05-01 Thread Julien Nabet (via logerrit)
 sw/source/uibase/shells/annotsh.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 8729c9751253f955840cffd24e2e31b1535a095a
Author: Julien Nabet 
AuthorDate: Sat May 2 00:24:31 2020 +0200
Commit: Julien Nabet 
CommitDate: Sat May 2 07:35:33 2020 +0200

tdf#132603: fix crash when selecting part of a comment

See bt here:
https://bugs.documentfoundation.org/attachment.cgi?id=160206

Regression from:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=65404e2c72ea2d5d3f6c074121005b8b9369e7fb
author  Samuel Mehrbrodt   2020-04-08 08:54:21 
+0200
committer   Samuel Mehrbrodt   2020-04-09 
11:14:15 +0200
commit  65404e2c72ea2d5d3f6c074121005b8b9369e7fb (patch)
tree15eeeb5b634c461611893dbe3b49d689ef71f5c4
parent  40d83914d43f60a196dfabddea0b52e2046b333a (diff)
Move is*Locked methods to object shell
They depend on the model, not the view.
Follow-up to 523922ee9d033fd304d2b50a72b76853ddcfbcdf

Change-Id: I9267e856a0f0fb22778dcd95974bb4217fd3712f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93308
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/uibase/shells/annotsh.cxx 
b/sw/source/uibase/shells/annotsh.cxx
index df50cb78163d..0c81d1d9 100644
--- a/sw/source/uibase/shells/annotsh.cxx
+++ b/sw/source/uibase/shells/annotsh.cxx
@@ -963,7 +963,8 @@ void SwAnnotationShell::StateClpbrd(SfxItemSet )
 }
 case SID_COPY:
 {
-if (!pOLV->HasSelection() || 
GetObjectShell()->isContentExtractionLocked())
+SfxObjectShell* pObjectShell = GetObjectShell();
+if (!pOLV->HasSelection() || (pObjectShell && 
pObjectShell->isContentExtractionLocked()) )
 rSet.DisableItem( nWhich );
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132207] Undo large table takes long time

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132207

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132173] Find Function Wizard Does not Enter Array Formula Correctly

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132173

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132156] Crash swlo!BigPtrArray::Index2Block+0xc8:

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132156

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127936] Editing: Bad allocation crash during find & replace

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127936

--- Comment #4 from QA Administrators  ---
Dear Geoffrey Skinner,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132182] Browse button in Database Propreties has small width

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132182

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132191] FORMATTING: Refreshing a range deletes background color even with "keep formatting" option enabled.

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132191

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127936] Editing: Bad allocation crash during find & replace

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127936

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132184] Data source combobox has bad height

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132184

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127916] Right to left direction is not working in ubuntu

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127916

--- Comment #3 from QA Administrators  ---
Dear ahmed.gebo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127940] When saving a document on shared drive it takes near 40 seconds

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127940

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127916] Right to left direction is not working in ubuntu

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127916

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127940] When saving a document on shared drive it takes near 40 seconds

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127940

--- Comment #3 from QA Administrators  ---
Dear Carlo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-qa] Automatic Formatting _Underline_ /Italics/ *Bold* -Strikethrough-

2020-05-01 Thread Marc Paré
Someone on a list other than LibreOffice pointed out that the initial
settings in AutoCorrect are set with the following formatting
feature-default of, when you type:
_CausesTextToBeUnderlined_  /CausesTextToBeItalicized/  
*CausesTextToBeBold  -CausesTextToBeStruckThrough-

As I would see this more of a formatting "feature" and not of a
formatting "correction", I wonder if the initial user-default with these
switched ON makes sense. To me, such a "feature" would be best
rationalized as a feature one would offer to a user wishing to use
keyboard alternatives to the conventional Ctrl-B, Ctrl-U etc switches.

I wonder if, from a regular user point of view, it would make better
sense to have the initial settings in "Tools-->AutoCorrect-->AutoCorrect
Options-->Options" set with these switches OFF (default). This would
then mean that, should a user start typing a URL such as /home/test,
that user would not continually have to battle to rid him/herself of the
"home" being formatted into an italics "home" and not being allowed to
complete the URL without being formatting before typing the complete
line as is. I would argue, that, setting the switches to the OFF
position as the LibreOffice default, would return a format that one
would expect when typing any stings such as /home/test etc.

Having these switches turned ON as the LibreOffice default, from the
point of view of a regular-user wishing to adopt the LibreOffice suite,
returns a behaviour that is NOT expected, and, raises the level of
frustration a little more as to deciding whether to adopt the suite or
expecting to trouble-shoot an issue where the result goes contrary to
what one would expect.

I wonder if we could re-consider the ON-default and leave these switches
to the OFF position?

This would then give a better result of, where more-advanced-users,
wishing to adopt the LibreOffice suite, and, wanting to expand
formatting switches, being pleasantly surprised that these switches
exist (a positive reaction), rather than what we presently have, where,
a regular-user wishing to adopt the LibreOffice suite, experiencing the
unpleasant auto-correction switches formatting text in a way that is not
expected (a negative reaction) and making that user doubt his/her choice
of LIbreOffice adoption.

Leaving new-LibreOffice adopters with a good impression, with very few,
if any, complaints would seem to be a good goal; making the initial
default to the OFF position, in my opinion, a good change.

Marc

-- 
Marc Paré
m...@marcpare.com
https://www.parEntreprise.com
parEntreprise.com Supports OpenDocument Formats (ODF)
parEntreprise.com Supports http://www.LibreOffice.org


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38093

--- Comment #60 from Jim Raykowski  ---
@Francewhoa, Thanks for contributing the mock up and ideas. I didn't put a lot
of thought into the UI. The main focus of this first patch set is proof of
concept.

For the Navigator UI there needs to be a way to distinguish between the
Navigator tree and the in document collapse/expand operations.

As of yet, I haven't a clue how to do an in document UI for this. Perhaps
something similar to what code editors do for code block folding by using a
symbol in the margin. There is also the hover over idea. 

Lots of interesting and fun challenges ahead.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132495] Version 6.3.5.2: Percentage not shown properly in Calc charts

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132495

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |

--- Comment #2 from Aron Budea  ---
There's good chance this is also fixed in the freshly released 6.3.6 update.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 56696] No option to make recent documents list show items for just the currently active LibO module

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=56696

Ming Hua  changed:

   What|Removed |Added

 CC||c...@sopchak.me

--- Comment #33 from Ming Hua  ---
*** Bug 132606 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132606] Recently Used Files Limited to Current App

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132606

Ming Hua  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||ming.v@qq.com

--- Comment #1 from Ming Hua  ---
Hi Carl, thanks for reporting this bug.

(In reply to Carl Sopchak from comment #0)
> Description:
> I doubt I'm the first to suggest this, but haven't seen a bugzilla report
> (too many to sift through)...
Bugzilla is definitely hard to navigate for unfamiliar users.  But this issue
has indeed been reported before, as bug 56696.  Marking as DUPLICATE.

> It makes absolutely no sense to me why LibreOffice Writer would list Calc
> files in its recently used list.  Even in a single app, I find the Recently
> used list to be too short and not of much help.  Sharing the list across all
> LibreOffice apps makes the list practically useless.
> 
> PLEASE change this behavior so that each app has it's own Recently Used
> Files list.

*** This bug has been marked as a duplicate of bug 56696 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132580] Italics button just not work in docx files (in odt it works fine) after save and reopen the file the italics formatting is gone.

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132580

bart...@tushmail.com changed:

   What|Removed |Added

 CC||bart...@tushmail.com

--- Comment #5 from bart...@tushmail.com ---
I followed the steps in Ming Hua's post and I had the same result. 

I did this on Linux/Debian 10 with LibreOffice 6.1 , 6.4 and 7.0

(In reply to dinospao132 from comment #2)
> Hello, i test your reproduce steps and i didn't find problem too, but in my
> files i have this problem, i had open this files with ms office too i don't
> know if destroy this the format
Dinospao, you wrote 
   "in my files i have this problem". 
Does this mean that you created your files in MS Word and then opened them in
LibreOffice, or the other way around?

If that's the case, which version of MS Word are you using, and which version
of LibreOffice are you using?

The more I know what you were doing, including the version numbers, the more
chance I have to successfully reproduce your problem. ;-)

~~~

   Here are the versions that I used:

Version: 6.1.5.2
Build ID: 1:6.1.5-3+deb10u5
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded

Version: 6.4.3.2
Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 7.0.0.0.alpha0+
Build ID: 4d03bd252274308f64332e7c0523068c38ac684a
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2020-04-26_05:59:56
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132606] New: Recently Used Files Limited to Current App

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132606

Bug ID: 132606
   Summary: Recently Used Files Limited to Current App
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: c...@sopchak.me

Description:
I doubt I'm the first to suggest this, but haven't seen a bugzilla report (too
many to sift through)...

It makes absolutely no sense to me why LibreOffice Writer would list Calc files
in its recently used list.  Even in a single app, I find the Recently used list
to be too short and not of much help.  Sharing the list across all LibreOffice
apps makes the list practically useless.

PLEASE change this behavior so that each app has it's own Recently Used Files
list.

Regards,

Carl

Steps to Reproduce:
Open a file in Calc, open Writer and do CTRL-F-U.  You see the Calc file.

Actual Results:
Files opened across the LibreOffice universe are shown in the CTRL-F-U list of
files.

Expected Results:
You should not see files that are for other LibreOffice components.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.5.2
Build ID: 6.3.5.2-5.fc31
CPU threads: 4; OS: Linux 5.6; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Distro:Fedora

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - helpcontent2

2020-05-01 Thread Ilmari Lauhakangas (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0cab83016707ab95b9bc98d7bbc8c46b67018599
Author: Ilmari Lauhakangas 
AuthorDate: Sat May 2 02:53:23 2020 +0300
Commit: Gerrit Code Review 
CommitDate: Sat May 2 01:53:23 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-6-4'
  to 1bbe610c73586f36d1e1354484388cac479dbd27
  - Help CSS: allow title in header to be wider

Added a column and let the title section to grow into it.
Also removed the hardcoded size from the Xapian search input.

Change-Id: Id391264a17556a35d54b705621deb9bdecc16af2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93278
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 52eb45cd79ed75eb37b46c579860cee4e6180138)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93142
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 5521fc8d7175..1bbe610c7358 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 5521fc8d7175abd8fe2b457c677c6fab38114778
+Subproject commit 1bbe610c73586f36d1e1354484388cac479dbd27
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Branch 'libreoffice-6-4' - help3xsl/default.css help3xsl/online_transform.xsl

2020-05-01 Thread Ilmari Lauhakangas (via logerrit)
 help3xsl/default.css  |   32 +++-
 help3xsl/online_transform.xsl |2 +-
 2 files changed, 24 insertions(+), 10 deletions(-)

New commits:
commit 1bbe610c73586f36d1e1354484388cac479dbd27
Author: Ilmari Lauhakangas 
AuthorDate: Fri May 1 18:15:37 2020 +0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat May 2 01:53:23 2020 +0200

Help CSS: allow title in header to be wider

Added a column and let the title section to grow into it.
Also removed the hardcoded size from the Xapian search input.

Change-Id: Id391264a17556a35d54b705621deb9bdecc16af2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93278
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 52eb45cd79ed75eb37b46c579860cee4e6180138)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93142
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index a0d8fccee..2c67d206c 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -831,6 +831,17 @@ li.disabled a {
 box-shadow: 0 2px 8px 0 rgba(0,0,0,.05);
 padding: 10px 50px 40px 50px;
 }
+.xapian-omega-search {
+width: 100%;
+}
+.xapian-omega-search form {
+display: flex;
+justify-content: center;
+}
+.omega-autofocus {
+max-width: 200px;
+width: 100%
+}
 }
 @media screen and (min-width: 1440px) {
 #Contents {
@@ -849,6 +860,9 @@ li.disabled a {
  label[for=accordion-1]:after {
 content: "";
 }
+.omega-autofocus {
+max-width: 400px;
+}
 }
 /* Use @supports to sneak these rules past IE */
 @supports (grid-area: auto) {
@@ -870,22 +884,22 @@ li.disabled a {
 }
 body {
 display: grid;
-grid-template-columns: 360px 80px 1fr;
+grid-template-columns: 360px 100px 300px 1fr;
 grid-template-rows: minmax(1em, auto) minmax(1em, auto) 1fr 
minmax(1em, auto);
-grid-template-areas: "header search donation"
- "rightside main main"
- "leftside main main"
- ". footer footer"
+grid-template-areas: "header header search donation"
+ "rightside main main main"
+ "leftside main main main"
+ ". footer footer footer"
 }
 }
 @media screen and (min-width: 1440px) {
 body {
 display: grid;
-grid-template-columns: 360px 450px 450px 1fr;
+grid-template-columns: 360px 100px 400px 400px 1fr;
 grid-template-rows: 1fr minmax(1em, auto) minmax(1em, auto);
-grid-template-areas: "header search search donation"
- "leftside main main rightside"
- ". footer footer ."
+grid-template-areas: "header header search search donation"
+ "leftside main main main rightside"
+ ". footer footer footer ."
 }
 .donation {
 max-width: 300px;
diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl
index f22262780..3a6337eaa 100644
--- a/help3xsl/online_transform.xsl
+++ b/help3xsl/online_transform.xsl
@@ -226,7 +226,7 @@
 
 
 
-
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 118260] Multi-line description in cell or on image, IME's position is bad

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118260

--- Comment #15 from Ming Hua  ---
Created attachment 160209
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160209=edit
MS IME, horizontal layout

On the other hand, with MS IME that puts the keyboard input in-line, it behaves
fine without covering the input line.  However here the MS IME for Chinese uses
horizontal layout for candidate words, and I don't know how (or even if it's
possible) to change it to vertical layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118260] Multi-line description in cell or on image, IME's position is bad

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118260

Ming Hua  changed:

   What|Removed |Added

 CC||ming.v@qq.com

--- Comment #14 from Ming Hua  ---
Created attachment 160208
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160208=edit
Sogou IME, vertical layout

I guess I can "more or less" confirm this bug on a Chinese system.  Though due
to the different design of the IME I do not suffer from the reported behavior
like the reporter does.

Attached is the screenshot of my situation, using Sogou IME with vertical
layout for candidate words.  As you can see, my IME puts the keyboard input on
the pop-up widget instead of on-site in the Calc cell, therefore even if the
pop-up is in an awkward position that covers the input line, it doesn't impede
my typing process.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132604] Assertion when inserting an image in Writer (gtk3)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132604

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #3 from Aron Budea  ---
Confirmed with LO 7.0.0.0.alpha0+ (60fcd4427231e8c48cd3bf8307e280fd3a13a84f) /
Ubuntu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132601] A shape can be anchored in header and dragged into to the text. Making it impossible to delete

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132601

Bart  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||bart...@tushmail.com
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Bart  ---
(Pt: the attached file is missing. ;-) )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132605] New: Connector dialog does not allow negative value for Line Skew

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132605

Bug ID: 132605
   Summary: Connector dialog does not allow negative value for
Line Skew
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 160207
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160207=edit
document with connectors to reproduce the error

Open attached document. It has three standard connectors.
The top-left one has default settings for property "Line Skew".
In the top-right one line 2 of the connector has a value of -4cm, in the bottom
one line 2 has a value of 4cm.

Open the dialog "Connector" (from context menu) of the top-right one. Notice,
that the value for "line 2" is set to 0. Try to set a negative value for "line
2". It is is not possible.

The dialog must allow negative values for Line Skew, because these values
describe the offset to the default value.

I see the error in Version: 5.1.6.1
Build ID: f3e25ec0581f5012f54d8810dcddd5824f4ee374
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
Locale: de-DE (en_US); Calc: group

Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd325abf1ac077904985) and Version
LibreOffice 3.5.4.2 Build ID: 165a79a-7059095-e13bb37-fef39a4-9503d18 had the
error, that the Line Skew fields were not enabled at all and only one line had
a handle in the UI.

But AOO416m1(Build:9790)  -  Rev. 1844436 2018-10-23 12:57 has it correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

Julien Nabet  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #4 from Julien Nabet  ---
I gave a try with:
https://gerrit.libreoffice.org/c/core/+/93308

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

Julien Nabet  changed:

   What|Removed |Added

   Priority|medium  |high
   Keywords||regression

--- Comment #3 from Julien Nabet  ---
I don't reproduce this with LO Debian package 6.4.3
=> regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Severity|normal  |major
 OS|Windows (All)   |All
 Status|UNCONFIRMED |NEW
   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 160206
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160206=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today + enable-dbgutil, I could
reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - vcl/source

2020-05-01 Thread Tomaž Vajngerl (via logerrit)
 vcl/source/filter/GraphicFormatDetector.cxx |   55 
 1 file changed, 24 insertions(+), 31 deletions(-)

New commits:
commit 5d0892b74d656e7885093b21e29511d2a95c7bf1
Author: Tomaž Vajngerl 
AuthorDate: Sat May 2 00:12:05 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Sat May 2 00:12:05 2020 +0200

vcl: Simplify searchEntry in GraphicFormatDetector

Makes the code much more readable..

Change-Id: I99d89652bda4ac74c867d70ec565403510c58c61

diff --git a/vcl/source/filter/GraphicFormatDetector.cxx 
b/vcl/source/filter/GraphicFormatDetector.cxx
index 1ad825ee47c7..56624074366e 100644
--- a/vcl/source/filter/GraphicFormatDetector.cxx
+++ b/vcl/source/filter/GraphicFormatDetector.cxx
@@ -67,8 +67,7 @@ bool isPCT(SvStream& rStream, sal_uLong nStreamPos, sal_uLong 
nStreamLen)
 return false;
 }
 
-sal_uInt8* ImplSearchEntry(sal_uInt8* pSource, sal_uInt8 const* pDest, 
sal_uLong nComp,
-   sal_uLong nSize)
+sal_uInt8* searchEntry(sal_uInt8* pSource, const char* pDest, sal_uLong nComp, 
sal_uLong nSize)
 {
 while (nComp-- >= nSize)
 {
@@ -321,14 +320,18 @@ bool GraphicFormatDetector::checkPSD()
 
 bool GraphicFormatDetector::checkEPS()
 {
-if ((mnFirstLong == 0xC5D0D3C6)
-|| (ImplSearchEntry(maFirstBytes.data(), reinterpret_cast("%!PS-Adobe"),
-10, 10)
-&& ImplSearchEntry([15], reinterpret_cast("EPS"), 3, 3)))
+if (mnFirstLong == 0xC5D0D3C6)
 {
 msDetectedFormat = "EPS";
 return true;
 }
+else if (searchEntry(maFirstBytes.data(), "%!PS-Adobe", 10, 10)
+ && searchEntry([15], "EPS", 3, 3))
+{
+msDetectedFormat = "EPS";
+return true;
+}
+
 return false;
 }
 
@@ -416,8 +419,7 @@ bool GraphicFormatDetector::checkRAS()
 
 bool GraphicFormatDetector::checkXPM()
 {
-if (ImplSearchEntry(maFirstBytes.data(), reinterpret_cast("/* XPM */"), 256,
-9))
+if (searchEntry(maFirstBytes.data(), "/* XPM */", 256, 9))
 {
 msDetectedFormat = "XPM";
 return true;
@@ -432,13 +434,11 @@ bool GraphicFormatDetector::checkXBM()
 
 mrStream.Seek(mnStreamPosition);
 mrStream.ReadBytes(pBuffer.get(), nSize);
-sal_uInt8* pPtr
-= ImplSearchEntry(pBuffer.get(), reinterpret_cast("#define"), nSize, 7);
+sal_uInt8* pPtr = searchEntry(pBuffer.get(), "#define", nSize, 7);
 
 if (pPtr)
 {
-if (ImplSearchEntry(pPtr, reinterpret_cast("_width"),
-pBuffer.get() + nSize - pPtr, 6))
+if (searchEntry(pPtr, "_width", pBuffer.get() + nSize - pPtr, 6))
 {
 msDetectedFormat = "XBM";
 return true;
@@ -473,27 +473,20 @@ bool GraphicFormatDetector::checkSVG()
 
 bool bIsSvg(false);
 
-// check for Xml
+// check for XML
 // #119176# SVG files which have no xml header at all have shown up this 
is optional
-if (ImplSearchEntry(pCheckArray, reinterpret_cast("("version"), nCheckSize,
-   7)) // does it have a version (required for xml)
-{
-// check for DOCTYPE svg combination
-if (ImplSearchEntry(pCheckArray, reinterpret_cast("DOCTYPE"), nCheckSize,
-7) // 'DOCTYPE' is there
-&& ImplSearchEntry(pCheckArray, reinterpret_cast("svg"), nCheckSize,
-   3)) // 'svg' is there
-{
-bIsSvg = true;
-}
+// check for "xml" then "version" then "DOCTYPE" and "svg" tags
+if (searchEntry(pCheckArray, "("("https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132604] Assertion when inserting an image in Writer (gtk3)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132604

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com
   Keywords||haveBacktrace
 Blocks||105537

--- Comment #2 from Julien Nabet  ---
Caolán: thought you might be interested in this one since it's specific to
gtk3.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132604] Assertion when inserting an image in Writer (gtk3)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132604

--- Comment #1 from Julien Nabet  ---
Created attachment 160205
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160205=edit
bt with debug symbols (gtk3)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Julien Nabet  changed:

   What|Removed |Added

 Depends on||132604


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132604
[Bug 132604] Assertion when inserting an image in Writer (gtk3)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132604] New: Assertion when inserting an image in Writer (gtk3)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132604

Bug ID: 132604
   Summary: Assertion when inserting an image in Writer (gtk3)
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
On pc Debian x86-64 with master sources + enable-dbgutil + gtk3, I got an
assert when inserting an image in Writer.

Steps to Reproduce:
1. Launch Writer
2. Menu Insert/Image
3. Choose Image then click "Open"

Actual Results:
Assertion

Expected Results:
No assertion


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+
Build ID: 3b46fa70b2b7f91a9a7c05bf54293e761d7df161
CPU threads: 12; OS: Linux 5.5; UI render: default; VCL: gtk3; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132602] No Option to Chose Firebird when opening a New Base database

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132602

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Ming Hua is right.

The problem is LO isn't ready for the moment to propose Firebird odb creation
in non experimental mode.
You can still open old Firebird odb files without enabling experimental option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

--- Comment #1 from Regina Henschel  ---
Created attachment 160204
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160204=edit
VS 2019 Call Stack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132603] New: Crash when selecting part of a comment

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132603

Bug ID: 132603
   Summary: Crash when selecting part of a comment
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 160203
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160203=edit
document to reproduce the crash

Open attached document. Select a word in the comment. --> crash

Record changes and show changes are on.

I'm using a debug build Version: 7.0.0.0.alpha0+ (x64)
Build ID: 309569f7d1d144e7b1bcaa0211f04e9b26b9f2fd
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: CL

The error message is
Exception thrown: read access violation.
**this** was 0x38. occurred

The call stack will be attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sfx2/source

2020-05-01 Thread Aron Budea (via logerrit)
 sfx2/source/sidebar/SidebarController.cxx |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 0e9f41e24abcba5fe1fefc9cdee17bc0ca05057d
Author: Aron Budea 
AuthorDate: Sun Feb 16 23:46:57 2020 +0100
Commit: Aron Budea 
CommitDate: Fri May 1 23:57:54 2020 +0200

sidebar: Distinguish between Impress and the rest for LOK

The parameter introduced in 26bcfbe48b30e0a525a0f25b73ddcacdd158256b
was unused.

Change-Id: Iee928520bb1a4033cf10f0ca60c687b73d09aaf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88829
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 
(cherry picked from commit 99751473531c6d022c2089bf162901b41a616895)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93141
Tested-by: Aron Budea 
Reviewed-by: Aron Budea 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index 5c69f97d0b59..081835fd6f91 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -74,13 +74,13 @@ namespace
 const static sal_Int32 gnWidthCloseThreshold (70);
 const static sal_Int32 gnWidthOpenThreshold (40);
 
-std::string UnoNameFromDeckId(const OUString& rsDeckId)
+std::string UnoNameFromDeckId(const OUString& rsDeckId, bool isImpress = 
false)
 {
 if (rsDeckId == "SdCustomAnimationDeck")
 return ".uno:CustomAnimation";
 
 if (rsDeckId == "PropertyDeck")
-return ".uno:Sidebar";
+return isImpress ? ".uno:ModifyPage" : ".uno:Sidebar";
 
 if (rsDeckId == "SdLayoutsDeck")
 return ".uno:ModifyPage";
@@ -240,7 +240,7 @@ void SidebarController::disposeDecks()
 {
 if (const SfxViewShell* pViewShell = mpViewFrame->GetViewShell())
 {
-const std::string hide = UnoNameFromDeckId(msCurrentDeckId);
+const std::string hide = UnoNameFromDeckId(msCurrentDeckId, 
vcl::EnumContext::Application::Impress == 
vcl::EnumContext::GetApplicationEnum(GetCurrentContext().msApplication));
 if (!hide.empty())
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
(hide + 
"=false").c_str());
@@ -757,13 +757,13 @@ void SidebarController::SwitchToDeck (
 {
 if (msCurrentDeckId != rDeckDescriptor.msId)
 {
-const std::string hide = UnoNameFromDeckId(msCurrentDeckId);
+const std::string hide = UnoNameFromDeckId(msCurrentDeckId, 
vcl::EnumContext::Application::Impress == 
vcl::EnumContext::GetApplicationEnum(GetCurrentContext().msApplication));
 if (!hide.empty())
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
(hide + 
"=false").c_str());
 }
 
-const std::string show = UnoNameFromDeckId(rDeckDescriptor.msId);
+const std::string show = UnoNameFromDeckId(rDeckDescriptor.msId, 
vcl::EnumContext::Application::Impress == 
vcl::EnumContext::GetApplicationEnum(GetCurrentContext().msApplication));
 if (!show.empty())
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
(show + 
"=true").c_str());
@@ -1287,7 +1287,7 @@ void SidebarController::UpdateDeckOpenState()
 
 if (const SfxViewShell* pViewShell = 
mpViewFrame->GetViewShell())
 {
-const std::string uno = UnoNameFromDeckId(msCurrentDeckId);
+const std::string uno = UnoNameFromDeckId(msCurrentDeckId, 
vcl::EnumContext::Application::Impress == 
vcl::EnumContext::GetApplicationEnum(GetCurrentContext().msApplication));
 if (!uno.empty())
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
 (uno + 
"=true").c_str());
@@ -1325,7 +1325,7 @@ void SidebarController::UpdateDeckOpenState()
 
 if (const SfxViewShell* pViewShell = 
mpViewFrame->GetViewShell())
 {
-const std::string uno = UnoNameFromDeckId(msCurrentDeckId);
+const std::string uno = UnoNameFromDeckId(msCurrentDeckId, 
vcl::EnumContext::Application::Impress == 
vcl::EnumContext::GetApplicationEnum(GetCurrentContext().msApplication));
 if (!uno.empty())
 
pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED,
 (uno + 
"=false").c_str());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132602] No Option to Chose Firebird when opening a New Base database

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132602

Ming Hua  changed:

   What|Removed |Added

 CC||ming.v@qq.com

--- Comment #1 from Ming Hua  ---
Thanks for reporting, Firebird support was indeed set back to "experimental
feature" in 6.3.6, compared to earlier 6.3.x releases.

However this was intentional, not an oversight, see
https://git.libreoffice.org/core/+/5e3cb1833da113d6ec09001e7e365d24bd4289ee
for rationale.

Should be NOTABUG or WONTFIX in my opinion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - vcl/qa

2020-05-01 Thread Tomaž Vajngerl (via logerrit)
 vcl/qa/cppunit/TypeSerializerTest.cxx |  200 ++
 vcl/qa/cppunit/data/123_Numbers.gif   |binary
 2 files changed, 200 insertions(+)

New commits:
commit e1de157d06f06bf12f882a6ce8217ba71103433e
Author: Tomaž Vajngerl 
AuthorDate: Fri May 1 23:52:31 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri May 1 23:52:31 2020 +0200

vcl: extend TypeSerializerTest for Graphic serialization

Add test case for Animation and GDIMetaFile serialization.

Change-Id: Ibe2fa9982c8faea36e1f26ca9c6b735ae0ebd8ea

diff --git a/vcl/qa/cppunit/TypeSerializerTest.cxx 
b/vcl/qa/cppunit/TypeSerializerTest.cxx
index c7ad8827a28d..0193ce272142 100644
--- a/vcl/qa/cppunit/TypeSerializerTest.cxx
+++ b/vcl/qa/cppunit/TypeSerializerTest.cxx
@@ -17,6 +17,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -53,11 +55,15 @@ class TypeSerializerTest : public CppUnit::TestFixture
 void testGradient();
 void testGraphic_Vector();
 void testGraphic_Bitmap_NoGfxLink();
+void testGraphic_Animation();
+void testGraphic_GDIMetaFile();
 
 CPPUNIT_TEST_SUITE(TypeSerializerTest);
 CPPUNIT_TEST(testGradient);
 CPPUNIT_TEST(testGraphic_Vector);
 CPPUNIT_TEST(testGraphic_Bitmap_NoGfxLink);
+CPPUNIT_TEST(testGraphic_Animation);
+CPPUNIT_TEST(testGraphic_GDIMetaFile);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -276,6 +282,200 @@ void TypeSerializerTest::testGraphic_Bitmap_NoGfxLink()
 }
 }
 
+void TypeSerializerTest::testGraphic_Animation()
+{
+test::Directories aDirectories;
+OUString aURL = aDirectories.getURLFromSrc(DATA_DIRECTORY) + 
"123_Numbers.gif";
+SvFileStream aStream(aURL, StreamMode::READ);
+GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter();
+Graphic aGraphic = rGraphicFilter.ImportUnloadedGraphic(aStream);
+aGraphic.makeAvailable();
+CPPUNIT_ASSERT_EQUAL(GraphicType::Bitmap, aGraphic.GetType());
+CPPUNIT_ASSERT_EQUAL(true, aGraphic.IsAnimated());
+
+// Test WriteGraphic
+{
+SvMemoryStream aMemoryStream;
+WriteGraphic(aMemoryStream, aGraphic);
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(15167), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("69d0f80832a0aebcbda7ad43ecadf85e99fc1057"),
+ toHexString(aHash));
+
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+sal_uInt16 nType;
+aMemoryStream.ReadUInt16(nType);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0x4D42), nType);
+
+// Read it back
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+Graphic aNewGraphic;
+ReadGraphic(aMemoryStream, aNewGraphic);
+CPPUNIT_ASSERT_EQUAL(GraphicType::Bitmap, aNewGraphic.GetType());
+CPPUNIT_ASSERT_EQUAL(true, aNewGraphic.IsAnimated());
+}
+
+// Test WriteGraphic - Native Format 5
+{
+SvMemoryStream aMemoryStream;
+aMemoryStream.SetVersion(SOFFICE_FILEFORMAT_50);
+aMemoryStream.SetCompressMode(SvStreamCompressFlags::NATIVE);
+WriteGraphic(aMemoryStream, aGraphic);
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(1582), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("da3b9600340fa80a895f2107357e4ab65a9292eb"),
+ toHexString(aHash));
+
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+sal_uInt32 nType;
+aMemoryStream.ReadUInt32(nType);
+CPPUNIT_ASSERT_EQUAL(COMPAT_FORMAT('N', 'A', 'T', '5'), nType);
+
+// Read it back
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+Graphic aNewGraphic;
+ReadGraphic(aMemoryStream, aNewGraphic);
+CPPUNIT_ASSERT_EQUAL(GraphicType::Bitmap, aNewGraphic.GetType());
+CPPUNIT_ASSERT_EQUAL(true, aNewGraphic.IsAnimated());
+}
+
+// Test TypeSerializer
+{
+SvMemoryStream aMemoryStream;
+{
+TypeSerializer aSerializer(aMemoryStream);
+aSerializer.writeGraphic(aGraphic);
+}
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+CPPUNIT_ASSERT_EQUAL(sal_uInt64(15167), aMemoryStream.remainingSize());
+std::vector aHash = calculateHash(aMemoryStream);
+
CPPUNIT_ASSERT_EQUAL(std::string("69d0f80832a0aebcbda7ad43ecadf85e99fc1057"),
+ toHexString(aHash));
+
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+sal_uInt16 nType;
+aMemoryStream.ReadUInt16(nType);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0x4D42), nType);
+
+// Read it back
+aMemoryStream.Seek(STREAM_SEEK_TO_BEGIN);
+Graphic aNewGraphic;
+{
+TypeSerializer aSerializer(aMemoryStream);
+

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source

2020-05-01 Thread Stephan Bergmann (via logerrit)
 sc/source/core/opencl/formulagroupcl.cxx |  745 +++
 1 file changed, 376 insertions(+), 369 deletions(-)

New commits:
commit 75139b712f62cdce7e2d5ad3bec2283a8f334c43
Author: Stephan Bergmann 
AuthorDate: Fri Dec 6 17:04:11 2019 +0100
Commit: Tor Lillqvist 
CommitDate: Fri May 1 23:34:13 2020 +0200

Incomplete OpAverage, OpCount must not be used in dynamic_cast

...even in template code (which compilers often only analyze late during
compilation, but which Clang trunk now apparently processes more 
aggressively,
presumably since  "Reapply 'Fix crash on switch
conditions of non-integer types in templates'", emitting errors about 
incomplete
types)

Change-Id: I851d266007f72cc4063f299412eadacbc6084f70
Reviewed-on: https://gerrit.libreoffice.org/84657
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93248
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/sc/source/core/opencl/formulagroupcl.cxx 
b/sc/source/core/opencl/formulagroupcl.cxx
index 14feb0d0a7a2..2a646c25a71b 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -958,9 +958,6 @@ protected:
 /// Handling a Double Vector that is used as a sliding window input
 /// to either a sliding window average or sum-of-products
 /// Generate a sequential loop for reductions
-class OpAverage;
-class OpCount;
-
 template
 class DynamicKernelSlidingArgument : public Base
 {
@@ -1271,185 +1268,7 @@ public:
 }
 
 /// Emit the definition for the auxiliary reduction kernel
-virtual void GenSlidingWindowFunction( std::stringstream& ss )
-{
-if (!dynamic_cast(mpCodeGen.get()))
-{
-std::string name = Base::GetName();
-ss << "__kernel void " << name;
-ss << "_reduction(__global double* A, "
-"__global double *result,int arrayLength,int windowSize){\n";
-ss << "double tmp, current_result =" <<
-mpCodeGen->GetBottom();
-ss << ";\n";
-ss << "int writePos = get_group_id(1);\n";
-ss << "int lidx = get_local_id(0);\n";
-ss << "__local double shm_buf[256];\n";
-if (mpDVR->IsStartFixed())
-ss << "int offset = 0;\n";
-else // if (!mpDVR->IsStartFixed())
-ss << "int offset = get_group_id(1);\n";
-if (mpDVR->IsStartFixed() && mpDVR->IsEndFixed())
-ss << "int end = windowSize;\n";
-else if (!mpDVR->IsStartFixed() && !mpDVR->IsEndFixed())
-ss << "int end = offset + windowSize;\n";
-else if (mpDVR->IsStartFixed() && !mpDVR->IsEndFixed())
-ss << "int end = windowSize + get_group_id(1);\n";
-else if (!mpDVR->IsStartFixed() && mpDVR->IsEndFixed())
-ss << "int end = windowSize;\n";
-ss << "end = min(end, arrayLength);\n";
-
-ss << "barrier(CLK_LOCAL_MEM_FENCE);\n";
-ss << "int loop = arrayLength/512 + 1;\n";
-ss << "for (int l=0; lGen2(
-"A[loopOffset + lidx + offset]", "tmp") << ", tmp);\n";
-ss << "tmp = legalize(" << mpCodeGen->Gen2(
-"A[loopOffset + lidx + offset + 256]", "tmp") << ", tmp);\n";
-ss << "} else if ((loopOffset + lidx + offset) < end)\n";
-ss << "tmp = legalize(" << mpCodeGen->Gen2(
-"A[loopOffset + lidx + offset]", "tmp") << ", tmp);\n";
-ss << "shm_buf[lidx] = tmp;\n";
-ss << "barrier(CLK_LOCAL_MEM_FENCE);\n";
-ss << "for (int i = 128; i >0; i/=2) {\n";
-ss << "if (lidx < i)\n";
-ss << "shm_buf[lidx] = ";
-// Special case count
-if (dynamic_cast(mpCodeGen.get()))
-ss << "shm_buf[lidx] + shm_buf[lidx + i];\n";
-else
-ss << mpCodeGen->Gen2("shm_buf[lidx]", "shm_buf[lidx + i]") << 
";\n";
-ss << "barrier(CLK_LOCAL_MEM_FENCE);\n";
-ss << "}\n";
-ss << "if (lidx == 0)\n";
-ss << "current_result =";
-if (dynamic_cast(mpCodeGen.get()))
-ss << "current_result + shm_buf[0]";
-else
-ss << mpCodeGen->Gen2("current_result", "shm_buf[0]");
-ss << ";\n";
-ss << "barrier(CLK_LOCAL_MEM_FENCE);\n";
-ss << "}\n";
-ss << "if (lidx == 0)\n";
-ss << "result[writePos] = current_result;\n";
-ss << "}\n";
-}
-else
-{
-std::string 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source

2020-05-01 Thread Stephan Bergmann (via logerrit)
 sc/source/core/opencl/formulagroupcl.cxx |   19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

New commits:
commit b8c1399761f80708062a492248692514616c6a58
Author: Stephan Bergmann 
AuthorDate: Tue Nov 19 16:32:49 2019 +0100
Commit: Tor Lillqvist 
CommitDate: Fri May 1 23:33:51 2020 +0200

Extend loplugin:external to warn about classes

(Just for one source file, unlike the original commit.)

...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend
loplugin:external to warn about enums".

Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:

  filter/source/svg/svgexport.cxx
  sc/source/filter/excel/xelink.cxx
  sc/source/filter/excel/xilink.cxx
  svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx

All other free functions mentioning moved classes appear to be harmless and 
not
give rise to (silent, even) ADL breakage.  (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered 
by
computeAffectedTypes, even though they could also be affected by 
ADL-breakage---
but don't seem to be in any acutal case across the code base.)

For friend declarations using elaborate type specifiers, like

  class C1 {};
  class C2 { friend class C1; };

* If C2 (but not C1) is moved into an unnamed namespace, the friend 
declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; 
see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has 
been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")

* If C1 (but not C2) is moved into an unnamed namespace, the friend 
declaration
must be changed too, see 

"elaborated-type-specifier friend not looked up in unnamed namespace".

Apart from that, to keep changes simple and mostly mechanical (which should 
help
avoid regressions), out-of-line definitions of class members have been left 
in
the enclosing (named) namespace.  But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
 "explicit 
specialization of
template from unnamed namespace using unqualified-id in enclosing 
namespace".

Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.

And in some cases, mention of affected types in blacklists in other 
loplugins
needed to be adapted.

And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of 
which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl 
is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is.  GCC warns 
about
such combinations with enabled-by-default -Wsubobject-linkage, but "The 
compiler
doesn’t give this warning for types defined in the main .C file, as those 
are
unlikely to have multiple definitions."
()  The
warned-about classes also don't have multiple definitions in the given 
test, so
disable the warning when including the .cxx.

Original Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4

Change-Id: Idbb47dac7dfa1029da603c716ccc3a1d35687ea6
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93247
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/sc/source/core/opencl/formulagroupcl.cxx 
b/sc/source/core/opencl/formulagroupcl.cxx
index 6ba5ba23d6e9..14feb0d0a7a2 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -267,6 +267,8 @@ size_t VectorRef::Marshal( cl_kernel k, int argno, int, 
cl_program )
 /// automatically disables use of OpenCL for a formula group. If at some point 
there are resources
 /// to drain the OpenCL swamp, this should go away.
 
+namespace {
+
 class ConstStringArgument : public DynamicKernelArgument
 {
 public:
@@ -797,6 +799,8 @@ public:
 virtual size_t Marshal( cl_kernel, int, int, cl_program ) override;
 };
 
+}
+
 /// Marshal a string vector reference
 size_t DynamicKernelStringArgument::Marshal( cl_kernel k, int argno, int, 
cl_program )
 {
@@ -886,6 +890,8 @@ size_t DynamicKernelStringArgument::Marshal( cl_kernel k, 
int argno, int, cl_pro
 return 1;
 }
 
+namespace {

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - connectivity/Library_mysqlc.mk connectivity/Library_postgresql-sdbc-impl.mk desktop/CppunitTest_desktop_app.mk desktop/CppunitTest_de

2020-05-01 Thread Stephan Bergmann (via logerrit)
 connectivity/Library_mysqlc.mk  |2 +-
 connectivity/Library_postgresql-sdbc-impl.mk|1 -
 desktop/CppunitTest_desktop_app.mk  |1 -
 desktop/CppunitTest_desktop_lokinit.mk  |1 -
 desktop/Library_crashreport.mk  |1 -
 desktop/Library_sofficeapp.mk   |3 ---
 external/clucene/Library_clucene.mk |1 -
 external/pdfium/Library_pdfium.mk   |1 -
 jurt/Library_jpipe.mk   |4 
 libreofficekit/CppunitTest_libreofficekit_tiledrendering.mk |1 -
 libreofficekit/Executable_gtktiledviewer.mk |1 -
 libreofficekit/Executable_tilebench.mk  |1 -
 onlineupdate/Executable_test_updater_dialog.mk  |1 -
 onlineupdate/Executable_updater.mk  |1 -
 sal/Library_sal.mk  |3 ---
 sc/CppunitTest_sc_ucalc.mk  |6 --
 sc/Library_sc.mk|6 --
 smoketest/Executable_libtest.mk |1 -
 solenv/gbuild/platform/linux.mk |2 +-
 solenv/gbuild/platform/unxgcc.mk|   10 +-
 svl/Library_svl.mk  |5 -
 svx/Executable_gengal.mk|2 --
 vcl/Executable_icontest.mk  |1 -
 vcl/Executable_lo_kde5filepicker.mk |1 -
 vcl/Executable_mtfdemo.mk   |1 -
 vcl/Executable_ui-previewer.mk  |1 -
 vcl/Executable_vcldemo.mk   |1 -
 vcl/Executable_visualbackendtest.mk |1 -
 vcl/Library_desktop_detector.mk |1 -
 vcl/Library_vcl.mk  |6 --
 vcl/Library_vclplug_gen.mk  |1 -
 vcl/Library_vclplug_gtk.mk  |1 -
 vcl/Library_vclplug_gtk3.mk |1 -
 vcl/Library_vclplug_gtk3_kde5.mk|1 -
 vcl/Library_vclplug_kde5.mk |1 -
 vcl/Library_vclplug_qt5.mk  |1 -
 vcl/StaticLibrary_glxtest.mk|1 -
 37 files changed, 11 insertions(+), 64 deletions(-)

New commits:
commit 3f51807aed5f97eae4bddea01173d138658463c5
Author: Stephan Bergmann 
AuthorDate: Thu Apr 25 11:48:39 2019 +0200
Commit: Tor Lillqvist 
CommitDate: Fri May 1 23:32:41 2020 +0200

Cut down on -pthread/-lpthread proliferation

Building against libstdc++ effectively always requires -pthread anyway (as
various standard C++ headers require it, see the comment added to
solenv/gbuild/platform/unxgcc.mk), so many explicit uses of 
-pthread/-lpthread
can be removed.

Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests 
that
libc++ indeed doesn't need -pthread as libstdc++ does.

The remaining uses of -pthread/-lpthread are mostly in configure.ac for the
various BSDs (which somebody else might want to clean up now), and related 
to
external projects.  I tried to be careful to remove -pthread/-lpthread from
makefiles only when C++ object files are involved (so -pthread will now be
included on the link command line by default).

Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1
Reviewed-on: https://gerrit.libreoffice.org/71291
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93206
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/connectivity/Library_mysqlc.mk b/connectivity/Library_mysqlc.mk
index 455f9b2224df..0999b46d3eec 100644
--- a/connectivity/Library_mysqlc.mk
+++ b/connectivity/Library_mysqlc.mk
@@ -24,7 +24,7 @@ $(eval $(call gb_Library_set_include,mysqlc,\
 $(eval $(call gb_Library_add_libs,mysqlc,\
$(if $(filter-out WNT,$(OS)),$(if $(filter HAIKU MACOSX SOLARIS,$(OS)),\
-lz -lm,-rdynamic -lz -lcrypt -lm)) \
-   $(if $(filter LINUX,$(OS)),-lpthread -ldl,) \
+   $(if $(filter LINUX,$(OS)),-ldl,) \
 ))
 
 $(eval $(call gb_Library_use_sdk_api,mysqlc))
diff --git a/connectivity/Library_postgresql-sdbc-impl.mk 
b/connectivity/Library_postgresql-sdbc-impl.mk
index 53cebd01a242..80c746f802dc 100644
--- a/connectivity/Library_postgresql-sdbc-impl.mk
+++ b/connectivity/Library_postgresql-sdbc-impl.mk
@@ -61,7 +61,6 @@ $(eval $(call gb_Library_add_libs,postgresql-sdbc-impl,\
$(if $(WITH_GSSAPI),$(GSSAPI_LIBS)) \
$(if 

[Libreoffice-bugs] [Bug 132594] No display of labels in pie charts if xlsx created with Excel 2007 (regression in 6.4 vs 6.0 and 5.2)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132594

Ming Hua  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ming.v@qq.com
Version|6.4.2.2 release |6.3.5.2 release
   Keywords||bibisectRequest,
   ||filter:xlsx, regression
 Status|UNCONFIRMED |NEW

--- Comment #2 from Ming Hua  ---
(In reply to fdegr...@gmail.com from comment #0)
> Example here:
> https://github.com/jmcnamara/XlsxWriter/files/4564212/chart_pie2.xlsx
Reproduced with this example in 6.4.3:
版本: 6.4.3.2 (x64)
Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU 线程: 2; 操作系统: Windows 10.0 Build 18363; UI 渲染: GL; VCL: win; 
区域语言: zh-CN (zh_CN); UI 语言: zh-CN
Calc: threaded

... as well as 6.3.5:
Version: 6.3.5.2 (x64)
Build ID: dd0751754f11728f69b42ee2af66670068624673
CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: zh-CN (zh_CN); UI-Language: en-US
Calc: threaded

But can not reproduce in 6.2.8:
Version: 6.2.8.2 (x64)
Build ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee
CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: zh-CN (zh_CN); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132602] New: No Option to Chose Firebird when opening a New Base database

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132602

Bug ID: 132602
   Summary: No Option to Chose Firebird when opening a New Base
database
   Product: LibreOffice
   Version: 6.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: putman...@gmail.com

Description:
No Option to chose Firebird Embedded when opening a New Base database. Only
HSQLDB is showing. When you enable Experiment Features under
Tools/Advanced/Optional Features Firebird Embedded Database option appears.
Correct Option was present in prior release.

Steps to Reproduce:
1.Open a new Base database
2.No Option in choosing Firebird Embedded Database
3.Enable Experimental Features


Actual Results:
HSQLDB

Expected Results:
Firebird


Reproducible: Always


User Profile Reset: No



Additional Info:
Software should offer an option in choosing either Embedded Database Firebird
or HSQLDB

Looks like an error in the release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132592] Original image size off after compression without reducing the image resolution

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132592

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132592] Original image size off after compression without reducing the image resolution

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132592

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in

Version: 6.4.0.0.alpha1+ (x86)
Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default;
VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131662] Customize dialog is too high

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131662

Bart  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131956] Crash on file reload after file recovery

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131956

Telesto  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||caol...@redhat.com

--- Comment #7 from Telesto  ---
Adding CC to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131956] Crash on file reload after file recovery

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131956

--- Comment #6 from Telesto  ---
Created attachment 160202
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160202=edit
Bibisect log

Bisected to
author  Caolán McNamara 2019-02-23 13:42:55 +
committer   Caolán McNamara 2019-02-27 22:18:22
+0100
commit  cfe41185bc8514949d1938ee1d7cd56968682510 (patch)
tree8d990aae964cf0ed6ed49c06a86133057481ae7d
parent  3e1306c283c2aca372a8384801a1e206f208e1cb (diff)
weld LicenseDialogImpl

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cfe41185bc8514949d1938ee1d7cd56968682510

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120695] FILEOPEN unixODBC connection to sqlite database not working

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120695

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from Julien Nabet  ---
The pb was brought with:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3208fcb3a36d75d6290d9c548430682f153b09db
author  Julien Nabet   2018-09-13 22:57:58 +0200
committer   Julien Nabet   2018-09-20 23:06:41
+0200
commit  3208fcb3a36d75d6290d9c548430682f153b09db (patch)
treeaf6d363ce1d2aaffa3e2c479c5f79909ba1d1ba5
parent  2739dee0eab2edbba898cb7115579e43ea89399d (diff)
tdf#119743: add Features entries in Properties block Drivers.xcu
in order to save special options of a database file.

Regression from d6fce54c82868b82bd6fa190db6047d69bbb3ecf
Read https://bugs.documentfoundation.org/show_bug.cgi?id=119743#c5
for detailed explanation

then fixed with:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f33eb08a2b74e5de033af9b5f5283b220ac58ded
author  Julien Nabet   2019-03-09 17:39:44 +0100
committer   Mike Kaganski  2019-03-10
06:25:44 +0100
commit  f33eb08a2b74e5de033af9b5f5283b220ac58ded (patch)
tree62aa41c03f593a3f42bc3100eaa30e39e10c360b
parent  59f58b432f6998cf1255dd4439a20c9369d01187 (diff)
tdf#121092: synchronize defaults for ODBC settings
The defaults for EnableSQL92Check, PreferDosLikeLineEnds,
RespectDriverResultSetType
in connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu made
consistent with respective defaults in
ODatabaseModelImpl::getDefaultDataSourceSettings

When inconsistent, the settings don't ever get written to the ODB's
content.xml (likely they are filtered out as default at different levels).
This change allows the non-default to be written. Since the defaults in
ODatabaseModelImpl::getDefaultDataSourceSettings are there at least since
2006 (commit 0eb026293c88d422d701d1a06735d9cce5457ca9), so that in any
existing ODB the settings are absent if they are equal to those defaults,
they are not changed.

It should be fixed in last stable LO version 6.3.5 or brand new 6.4.3.
However it will work only for brand new odb files. For old files, you must
uncheck the option manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104790
Bug 104790 depends on bug 120695, which changed state.

Bug 120695 Summary: FILEOPEN unixODBC connection to sqlite database not working
https://bugs.documentfoundation.org/show_bug.cgi?id=120695

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #52 from Julien Nabet  ---
jorojmaqui: any update with LO 6.3.5 or LO 6.4.3 + brand new LO profile (see
https://wiki.documentfoundation.org/UserProfile#Windows) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103184

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||126074


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=126074
[Bug 126074] Icon styles should not modify official application icons in start
center (and other relevant places)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 126074] Icon styles should not modify official application icons in start center (and other relevant places)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126074

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103184
 CC||thomas.le...@gmail.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 126074] Icon styles should not modify official application icons in start center (and other relevant places)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126074

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103184
 CC||thomas.le...@gmail.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103184

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||132398


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132398
[Bug 132398] Adopt new application icons for LibreOffice 7.0
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132398] Adopt new application icons for LibreOffice 7.0

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132398

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103184


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 132398] Adopt new application icons for LibreOffice 7.0

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132398

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||103184


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 127854] Add ability to keep vector image and compress replacement image in image compression dialog

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127854

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108437
 CC||thomas.le...@gmail.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108437
[Bug 108437] [META] Image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108437] [META] Image bugs and enhancements

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108437

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||127854


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127854
[Bug 127854] Add ability to keep vector image and compress replacement image in
image compression dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132579] Insert caption box at the wrong position for a gallery item

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132579

Telesto  changed:

   What|Removed |Added

Version|7.0.0.0.alpha0+ Master  |6.1.5.2 release
   Keywords|possibleRegression  |bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38093

--- Comment #59 from Francewhoa 
 ---
Created attachment 160201
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160201=edit
Mockup Navigator Expand Collapse---v3

I fixed my typos in this mockup version 3. I'm new to this "Attachments" form.
Learning it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119111] Shapes losing position and z-index

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119111

--- Comment #27 from Telesto  ---
(In reply to DM from comment #26)
> Created attachment 156289 [details]
> Cut-Doc-and-Repaste to give shapes unique names issue
> 
> As a method to rename shapes to unique names, I've just tried opening the
> attached document, highlighted its contents (Ctrl-A) cut it all out (Ctrl-X)
> and repasted it back (Ctrl-V), and this disrupts the layout in a way that it
> shouldn't.
> Since this is a rather simple document affected, I anticipate it could have
> much larger impacts on my other docs.
> 
> Version: 6.4.0.0.beta1 (x64)
> Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920
> CPU threads: 2; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
> Locale: en-GB (en_GB); UI-Language: en-GB
> Calc: threaded

Working properly with (but not with 6.4.3.2) 
Version: 7.0.0.0.alpha0+ (x64)
Build ID: f845f74afaf087a46c82ee4209e29caca0980b71
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38093

Francewhoa  changed:

   What|Removed |Added

 Attachment #160200|0   |1
is obsolete||
 Attachment #160200||Mockup Navigator Expand
   filename||Collapse---v2.jpg
 Attachment #160200|Mockup-Navigator-Expend-or- |Mockup Navigator Expand
description|Collapse-Expand-All-Heading |Collapse---v2
   |s-and-Collapse-All-Headings |
   |-v2.jpg |

--- Comment #58 from Francewhoa 
 ---
Comment on attachment 160200
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160200
Mockup Navigator Expand Collapse---v2

This is a note to myself. I simplified this attachment name. I'll upload
version 3 shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132590] Export selection cuts off pixels on the right side and at the bottom side

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132590

--- Comment #3 from Bart  ---
Oops, I forgot ...

If you upload
   "Unbenannt 1.odg"
then that also answers 
   "what's the size of your rectangle?" ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #92 from Commit Notification 
 ---
Yusuf Keten committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8fb7ecd9cdbe1898c41eaecd9894df8e8f01e25

tdf#124176: Use pragma once instead of include guards

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2020-05-01 Thread Yusuf Keten (via logerrit)
 sc/source/filter/inc/addressconverter.hxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit b8fb7ecd9cdbe1898c41eaecd9894df8e8f01e25
Author: Yusuf Keten 
AuthorDate: Tue Apr 28 21:48:31 2020 +0300
Commit: Eike Rathke 
CommitDate: Fri May 1 22:01:04 2020 +0200

tdf#124176: Use pragma once instead of include guards

Change-Id: I72c978c9d392d1aba1ca99feeacee021835adf52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93098
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/source/filter/inc/addressconverter.hxx 
b/sc/source/filter/inc/addressconverter.hxx
index 0d5b3dac1b70..6447b1b63565 100644
--- a/sc/source/filter/inc/addressconverter.hxx
+++ b/sc/source/filter/inc/addressconverter.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_SC_SOURCE_FILTER_INC_ADDRESSCONVERTER_HXX
-#define INCLUDED_SC_SOURCE_FILTER_INC_ADDRESSCONVERTER_HXX
+#pragma once
 
 #include 
 #include 
@@ -502,6 +501,5 @@ private:
 } // namespace xls
 } // namespace oox
 
-#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132590] Export selection cuts off pixels on the right side and at the bottom side

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132590

Bart  changed:

   What|Removed |Added

 CC||bart...@tushmail.com

--- Comment #2 from Bart  ---
I'm trying to recreate the image that you got. At first the things that I get
on my screen look as expected. So I want to do it exactly the way you did. 

If you have the rectangle in Draw and if you right-click and select 
   "Position and Size ..."
then what is the size of your rectangle?

If needed, feel free to make a new rectangle. I just need to have an impression
of the size of the rectangle that you made and saved.

If you export it, then what are the values for the Width, Height and
Resolution?

Thanks!

PS: I'm not a developer. I'm a user myself and I submitted a few bug reports.
I'm trying to confirm the bugs that other people reported here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/unotools

2020-05-01 Thread Michael Stahl (via logerrit)
 include/unotools/saveopt.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9608f72347a8ec99f454802cc3cabc6e32d92370
Author: Michael Stahl 
AuthorDate: Wed Apr 22 20:18:09 2020 +0200
Commit: Eike Rathke 
CommitDate: Fri May 1 21:53:09 2020 +0200

ODF export: fix wrong definition of ODFSVER_LATEST_EXTENDED

The only real use of ODFSVER_LATEST_EXTENDED is as translated value of
the default ODFVER_LATEST; it must match ODFSVER_012_EXTENDED
which is larger than ODFSVER_LATEST | ODFSVER_EXTENDED because
it *is* used in comparisons as the return value of
GetODFSaneDefaultVersion().
(Guess the comment means not to use it as literal in comparisons.)

Change-Id: I6ac5e012f314e86acdcb7ac7d615c747cd7b8a52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92726
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/include/unotools/saveopt.hxx b/include/unotools/saveopt.hxx
index 7c189534d2da..029ab6f0b1cb 100644
--- a/include/unotools/saveopt.hxx
+++ b/include/unotools/saveopt.hxx
@@ -81,8 +81,8 @@ public:
 ODFSVER_013_EXTENDED = 13,  ///< ODF 1.3 extended
 
 // The latest defined standard. Adapt when a new one is published.
-ODFSVER_LATEST = ODFSVER_012,   ///< 
@internal DO NOT USE in comparisons
-ODFSVER_LATEST_EXTENDED = ODFSVER_LATEST | ODFSVER_EXTENDED ///< 
@internal DO NOT USE in comparisons
+ODFSVER_LATEST = ODFSVER_012,   ///< @internal DO NOT 
USE in comparisons
+ODFSVER_LATEST_EXTENDED = ODFSVER_012_EXTENDED  ///< @internal DO NOT 
USE in comparisons
 };
 
 SvtSaveOptions();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132274] Writer does not allow a user-set default view/zoom (overwriting the zoom level stored in a document, that is used by default)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132274

--- Comment #3 from Thomas Lendo  ---
Very good idea.

Could this be implemented for other programs as well, couldn't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38093

--- Comment #57 from Francewhoa 
 ---
Created attachment 160200
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160200=edit
Mockup-Navigator-Expend-or-Collapse-Expand-All-Headings-and-Collapse-All-Headings-v2.jpg

I forgot to attach my contributed mockup in my comment 56 above. For easy
future references, I'm attaching it to this comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38093

--- Comment #56 from Francewhoa 
 ---
Thanks Jim for both your contribution and for the video in comment 54 above :)
This is fantastic. And videos are useful for users who are not software
engineers. But interested to contribute to LO.

- - - - - - - - - - - - - - - - - - 


Strengths

• A first benefit of using the Navigator like you did in your video is that
many users are familiar with this Navigator. As it's being around for a long
time. So it's likely that end-users would have an easier learning curve about
the collapse and expand new features.

• A second benefit of using the Navigator is that in very large document, it's
sometime much easier to use the Navigator than the Document canvas. The
Navigator shows a summary of the whole document Headings. Compare to the
Document canvas with with very large documents the users would have to do lots
of scrolling up and down.

• In the Navigator, the wordings "Fold in Document" and "Unfold in Document"
are concise. Which looks & feels clean and uncluttered.

• The collapse and expand are very fast & responsive :)

- - - - - - - - - - - - - - - - - - 


Challenges


Here are three challenge below. With suggested resolution. Feel free to choose
any other resolutions or design to your liking. The following are just
suggestions for your consideration.


Challenge 1

• Within the Navigator, the wording "Fold in Document" & "Unfold in Document"
might be cryptic & not clear for some users using the English version of LO. 
This is a suggested resolution. How about using terms most users are more
familiar with? Such as "Expand Heading" or "Collapse Heading"
One benefit with those wordings is that they make it clear that there is a
relationship between the Document Headings and the Collapse or Expand features.

The number 3 in this mockup I made today show this suggested wordings
resolution at
https://i.postimg.cc/Pxc45tX9/Mockup-Navigator-Expend-or-Collapse-Expand-All-Headings-and-Collapse-All-Headings-v2.jpg


Challenge 2

• The "Fold in Document" & "Unfold in Document" would likely meet the need of
users with small LO Documents. But for very large Documents it would likely
not. I mean if a small Document has 10 headings, it's realistic for the user to
click up to 10 times to collapse or expand heading to her/his liking. But if a
large document has 10,000+ headings, it's not realistic for the user to click
up to 10,000 times. 
This is a suggested resolution. How about this, within the Navigator, add a new
top menu titled "Expend/Collapse", then add those two additional sub-menu. I
mean this workflow: 
1. "Expend/Collapse" ---> "Expand Heading"
2. "Expend/Collapse" ---> "Collapse Heading"
3. "Expend/Collapse" ---> "Expand All Headings"
4. "Expend/Collapse" ---> "Collapse All Headings". 

What those options do is self explain. For example, with a large Document the
user could start by clicking on "Collapse All Headings". Then use the other
"Expand Heading" option with only a few headings which are presently of
interest.

The numbers 1, 2, 3 in this mockup show this suggested resolution at
https://i.postimg.cc/Pxc45tX9/Mockup-Navigator-Expend-or-Collapse-Expand-All-Headings-and-Collapse-All-Headings-v2.jpg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/css loleaflet/images loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/css/notebookbar.css   |   32 ++--
 loleaflet/images/lc_footnotedialog.svg  |1 
 loleaflet/images/lc_insertcaptiondialog.svg |1 
 loleaflet/images/lc_updateall.svg   |1 
 loleaflet/images/lc_updatecurindex.svg  |1 
 loleaflet/src/control/Control.NotebookbarBuilder.js |2 +
 6 files changed, 35 insertions(+), 3 deletions(-)

New commits:
commit 3c73ef8765a7ddfa3568b156385b3786b4784f38
Author: Szymon Kłos 
AuthorDate: Thu Apr 30 12:40:56 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:40:29 2020 +0200

notebookbar: icons & layout the references tab

Change-Id: I52f319be7dc17cfe8376e673d46adb691f994df7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93300
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/css/notebookbar.css b/loleaflet/css/notebookbar.css
index 85c0c077f..fbbe66873 100644
--- a/loleaflet/css/notebookbar.css
+++ b/loleaflet/css/notebookbar.css
@@ -139,7 +139,8 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
 #DrawText.notebookbar img,
 #VerticalText.notebookbar img,
 #BasicShapes.notebookbar img,
-#table-Insert-Section-Symbol #CharmapControl.notebookbar img{
+#table-Insert-Section-Symbol #CharmapControl.notebookbar img
+{
height: 32px !important;
width: 32px !important;
 }
@@ -155,7 +156,8 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
 #ObjectForwardOne.notebookbar img,
 #SendToBack.notebookbar img,
 #ObjectBackOne.notebookbar img,
-#PageDialog.notebookbar img {
+#PageDialog.notebookbar img
+{
height: 32px !important;
width: 32px !important;
 }
@@ -167,6 +169,30 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
 #InsertBreak.notebookbar,
 #Watermark.notebookbar,
 #LineNumberingDialog.notebookbar
- {
+{
+   margin-top: 10px;
+}
+
+/* References Tab */
+
+#table-ReferencesBox
+{
+   margin-top: 5px;
+}
+
+#InsertMultiIndex.notebookbar img,
+#InsertFootnote.notebookbar img,
+#InsertReferenceField.notebookbar img,
+#InsertAuthoritiesEntry.notebookbar img,
+#UpdateAll.notebookbar img
+{
+   height: 32px !important;
+   width: 32px !important;
+}
+
+#UpdateCurIndex.notebookbar,
+#FootnoteDialog.notebookbar,
+#InsertCaptionDialog.notebookbar
+{
margin-top: 10px;
 }
\ No newline at end of file
diff --git a/loleaflet/images/lc_footnotedialog.svg 
b/loleaflet/images/lc_footnotedialog.svg
new file mode 100644
index 0..f1e621a3c
--- /dev/null
+++ b/loleaflet/images/lc_footnotedialog.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_insertcaptiondialog.svg 
b/loleaflet/images/lc_insertcaptiondialog.svg
new file mode 100644
index 0..5268ce5da
--- /dev/null
+++ b/loleaflet/images/lc_insertcaptiondialog.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_updateall.svg 
b/loleaflet/images/lc_updateall.svg
new file mode 100644
index 0..6e844f32e
--- /dev/null
+++ b/loleaflet/images/lc_updateall.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_updatecurindex.svg 
b/loleaflet/images/lc_updatecurindex.svg
new file mode 100644
index 0..e26fc6a01
--- /dev/null
+++ b/loleaflet/images/lc_updatecurindex.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index d9c13f358..9bd26f66e 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -69,6 +69,8 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
this._toolitemHandlers['.uno:AttributePageSize'] = function() 
{};
this._toolitemHandlers['.uno:PageColumnType'] = function() {};
this._toolitemHandlers['.uno:SelectObject'] = function() {};
+   this._toolitemHandlers['.uno:BibliographyComponent'] = 
function() {};
+   this._toolitemHandlers['.uno:ViewDataSourceBrowser'] = 
function() {};
this._toolitemHandlers['vnd.sun.star.findbar:FocusToFindbar'] = 
function() {};
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: 2 commits - loleaflet/css loleaflet/images loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/css/notebookbar.css   |   51 
 loleaflet/images/lc_basicshapes.svg |1 
 loleaflet/images/lc_drawtext.svg|1 
 loleaflet/images/lc_formatgroup.svg |1 
 loleaflet/images/lc_hyphenate.svg   |1 
 loleaflet/images/lc_insertbookmark.svg  |1 
 loleaflet/images/lc_insertbreak.svg |1 
 loleaflet/images/lc_insertfieldctrl.svg |1 
 loleaflet/images/lc_insertreferencefield.svg|1 
 loleaflet/images/lc_linenumberingdialog.svg |1 
 loleaflet/images/lc_pagedialog.svg  |1 
 loleaflet/images/lc_titlepagedialog.svg |1 
 loleaflet/images/lc_verticaltext.svg|1 
 loleaflet/images/lc_watermark.svg   |1 
 loleaflet/src/control/Control.NotebookbarBuilder.js |   25 +
 15 files changed, 89 insertions(+)

New commits:
commit 23ec45bf5864ed8fd66bc5e9b4b8e5ec76ad8732
Author: Szymon Kłos 
AuthorDate: Thu Apr 30 11:49:16 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:40:10 2020 +0200

notebookbar: icons & layout the layout tab

Change-Id: I69ded05cd834b8249bb057d55adcb2da14dd1a33
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93299
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/css/notebookbar.css b/loleaflet/css/notebookbar.css
index cbdd0b7a7..85c0c077f 100644
--- a/loleaflet/css/notebookbar.css
+++ b/loleaflet/css/notebookbar.css
@@ -130,7 +130,7 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
margin-top: 10px;
 }
 
-#InsertPagebreak.notebookbar img,
+#table-Insert-Section-Pagebreak #InsertPagebreak.notebookbar img,
 #table-Insert-Section-Table #InsertTable.notebookbar img,
 #InsertObjectChart.notebookbar img,
 #table-Insert-Section-Image #InsertGraphic.notebookbar img,
@@ -142,4 +142,31 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
 #table-Insert-Section-Symbol #CharmapControl.notebookbar img{
height: 32px !important;
width: 32px !important;
+}
+
+/* Layout Tab */
+
+#table-LayoutBox, #table-Wrap8.notebookbar {
+   margin-top: 5px;
+}
+
+#FormatGroup.notebookbar img,
+#BringToFront.notebookbar img,
+#ObjectForwardOne.notebookbar img,
+#SendToBack.notebookbar img,
+#ObjectBackOne.notebookbar img,
+#PageDialog.notebookbar img {
+   height: 32px !important;
+   width: 32px !important;
+}
+
+#table-Layout-Section-ParaMargin {
+   display: none;
+}
+
+#InsertBreak.notebookbar,
+#Watermark.notebookbar,
+#LineNumberingDialog.notebookbar
+ {
+   margin-top: 10px;
 }
\ No newline at end of file
diff --git a/loleaflet/images/lc_formatgroup.svg 
b/loleaflet/images/lc_formatgroup.svg
new file mode 100644
index 0..a8bd1bf35
--- /dev/null
+++ b/loleaflet/images/lc_formatgroup.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_hyphenate.svg 
b/loleaflet/images/lc_hyphenate.svg
new file mode 100644
index 0..978d9c9d5
--- /dev/null
+++ b/loleaflet/images/lc_hyphenate.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git a/loleaflet/images/lc_insertbreak.svg 
b/loleaflet/images/lc_insertbreak.svg
new file mode 100644
index 0..247345c3b
--- /dev/null
+++ b/loleaflet/images/lc_insertbreak.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_linenumberingdialog.svg 
b/loleaflet/images/lc_linenumberingdialog.svg
new file mode 100644
index 0..4917b24dc
--- /dev/null
+++ b/loleaflet/images/lc_linenumberingdialog.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_pagedialog.svg 
b/loleaflet/images/lc_pagedialog.svg
new file mode 100644
index 0..68f5bffaf
--- /dev/null
+++ b/loleaflet/images/lc_pagedialog.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_watermark.svg 
b/loleaflet/images/lc_watermark.svg
new file mode 100644
index 0..b5ad67e58
--- /dev/null
+++ b/loleaflet/images/lc_watermark.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index 533bd1475..d9c13f358 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -64,6 +64,11 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
this._toolitemHandlers['.uno:EmojiControl'] = function() {};
this._toolitemHandlers['.uno:InsertDraw'] = function() {};
this._toolitemHandlers['.uno:EditGlossary'] = function() {};
+   

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - configure.ac

2020-05-01 Thread Stephan Bergmann (via logerrit)
 configure.ac |   17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)

New commits:
commit d996e8074ce122c887617c2c7fb20c4a67530aa3
Author: Stephan Bergmann 
AuthorDate: Mon Apr 20 11:40:24 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Fri May 1 21:39:39 2020 +0200

Add --with-latest-c++ to explicitly opt in for -std=c++20/-std:c++latest

cd472d1d8489f30797f47d3f6dafede28c1feb90 "Compile as C++2a, where 
available" had
started to unconditionally check for support of -std=c++2a (and later also
-std=c++20) for Clang and GCC, but that can cause occasional issues 
especially
for Linux distros, see e.g. 55c724b93dfd4c9a1afb10d60fbc2d7a9a66cf61 
"replace
boost::bimap in sdext pdfimport" or

"/usr/include/boost/format/alt_sstream_impl.hpp incompatible with -std=c++20
(std::allocator::allocate hint argument)" (where
677c8de4fa79cd9b278b142013ba7f1c9e4e41c3 "external/boost: Adapt to
std::allocator parts removed in C++20" is not picked up due to
--with-system-boost).

So better require an explicit opt-in via a new --with-latest-c++.  And 
while at
it, also make that enable -std:c++latest for MSVC.

Change-Id: I2d1f03144fad9a7884562e56b1b76cab5eb8f080
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92555
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93204
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 76cc8f5f3ca8..c64fa51b7dbf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2144,6 +2144,12 @@ libo_FUZZ_ARG_WITH(lxml,
  report widget classes and ids.]),
 ,)
 
+libo_FUZZ_ARG_WITH(latest-c++,
+AS_HELP_STRING([--with-latest-c++],
+[Try to enable the latest features of the C++ compiler, even if they 
are not yet part of a
+ published standard.]),,
+[$with_latest_c__=no])
+
 dnl ===
 dnl Branding
 dnl ===
@@ -6248,14 +6254,21 @@ libo_FUZZ_ARG_ENABLE(c++17,
 AC_MSG_CHECKING([whether $CXX supports C++17, C++14, or C++11])
 CXXFLAGS_CXX11=
 if test "$COM" = MSC -a "$COM_IS_CLANG" != TRUE; then
-CXXFLAGS_CXX11=-std:c++17
+if test "$with_latest_c__" = yes; then
+CXXFLAGS_CXX11=-std:c++latest
+else
+CXXFLAGS_CXX11=-std:c++17
+fi
 elif test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
 dnl But only use C++17 if the gperf that is being used knows not to emit
 dnl "register" in C++ output:
 printf 'foo\n' | $GPERF -L C++ > conftest.inc
 my_flags='-std=gnu++14 -std=gnu++1y -std=c++14 -std=c++1y -std=gnu++11 
-std=gnu++0x -std=c++11 -std=c++0x'
 if test "$enable_c__17" != no; then
-my_flags="-std=gnu++2a -std=c++2a -std=gnu++17 -std=gnu++1z -std=c++17 
-std=c++1z $my_flags"
+my_flags="-std=gnu++17 -std=gnu++1z -std=c++17 -std=c++1z $my_flags"
+if test "$with_latest_c__" = yes; then
+my_flags="-std=gnu++2a -std=c++2a $my_flags"
+fi
 fi
 for flag in $my_flags; do
 if test "$COM" = MSC; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/css loleaflet/images loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/css/notebookbar.css  
  |   31 +-
 loleaflet/images/lc_charmapcontrol.svg 
  |1 
 loleaflet/images/lc_editstyle.svg  
  |1 
 loleaflet/images/lc_insertannotation.svg   
  |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3demphasis26familyname3astring3dcharacterstyles.svg
 |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3dheading20126familyname3astring3dparagraphstyles.svg
   |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3dheading20226familyname3astring3dparagraphstyles.svg
   |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3dheading20326familyname3astring3dparagraphstyles.svg
   |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3dheading20426familyname3astring3dparagraphstyles.svg
   |1 
 
loleaflet/images/lc_styleapply3fstyle3astring3dstrong20emphasis26familyname3astring3dcharacterstyles.svg
 |1 
 loleaflet/src/control/Control.NotebookbarBuilder.js
  |6 +
 11 files changed, 44 insertions(+), 2 deletions(-)

New commits:
commit 9e020d60241ccf36d6ae99f6d0e47a1f47794c89
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 12:11:59 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:39:38 2020 +0200

notebookbar: icons & layout the home tab

Change-Id: I73f8b1dcc51994f89db6debce83bcf20dfa90c31
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93296
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/css/notebookbar.css b/loleaflet/css/notebookbar.css
index 4cf5403bb..585075e39 100644
--- a/loleaflet/css/notebookbar.css
+++ b/loleaflet/css/notebookbar.css
@@ -81,7 +81,7 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
border: 1px solid silver;
 }
 
-/* Reset attributes control */
+/* Home tab */
 #clearFormatting.notebookbar div img {
width: 24px !important;
height: 24px !important;
@@ -89,4 +89,33 @@ div[id*='Row'].notebookbar, div[id*='Column'].notebookbar, 
#SendToBack.notebookb
 
 #clearFormatting.notebookbar {
height: 24px !important;
+}
+
+#Paste.notebookbar img, #InsertAnnotation.notebookbar img, 
#SearchDialog.notebookbar img {
+   height: 32px !important;
+   width: 32px !important;
+}
+
+#ControlCodes.notebookbar {
+   padding-left: 30px !important;
+}
+
+#fontnamecombobox.notebookbar ~ .select2 {
+   width: 150px !important;
+}
+
+#fontsizecombobox.notebookbar ~ .select2 {
+   width: 50px !important;
+}
+
+#applystyle.notebookbar ~ .select2 {
+   width: 170px !important;
+}
+
+#table-StyleParagraphSection1.notebookbar, #table-GroupB15.notebookbar, 
#table-GroupB11.notebookbar {
+   margin-top: -5px;
+}
+
+#Copy.notebookbar, #clearFormatting.notebookbar, #table-GroupB20.notebookbar {
+   margin-top: 10px;
 }
\ No newline at end of file
diff --git a/loleaflet/images/lc_charmapcontrol.svg 
b/loleaflet/images/lc_charmapcontrol.svg
new file mode 100644
index 0..87497d495
--- /dev/null
+++ b/loleaflet/images/lc_charmapcontrol.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/images/lc_editstyle.svg 
b/loleaflet/images/lc_editstyle.svg
new file mode 100644
index 0..8d9d0dec1
--- /dev/null
+++ b/loleaflet/images/lc_editstyle.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git a/loleaflet/images/lc_insertannotation.svg 
b/loleaflet/images/lc_insertannotation.svg
new file mode 100644
index 0..2b0e791fa
--- /dev/null
+++ b/loleaflet/images/lc_insertannotation.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git 
a/loleaflet/images/lc_styleapply3fstyle3astring3demphasis26familyname3astring3dcharacterstyles.svg
 
b/loleaflet/images/lc_styleapply3fstyle3astring3demphasis26familyname3astring3dcharacterstyles.svg
new file mode 100644
index 0..8c61f612b
--- /dev/null
+++ 
b/loleaflet/images/lc_styleapply3fstyle3astring3demphasis26familyname3astring3dcharacterstyles.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git 
a/loleaflet/images/lc_styleapply3fstyle3astring3dheading20126familyname3astring3dparagraphstyles.svg
 
b/loleaflet/images/lc_styleapply3fstyle3astring3dheading20126familyname3astring3dparagraphstyles.svg
new file mode 100644
index 0..885e34997
--- /dev/null
+++ 
b/loleaflet/images/lc_styleapply3fstyle3astring3dheading20126familyname3astring3dparagraphstyles.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git 
a/loleaflet/images/lc_styleapply3fstyle3astring3dheading20226familyname3astring3dparagraphstyles.svg
 

[Libreoffice-commits] online.git: 2 commits - loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/src/control/Control.NotebookbarBuilder.js |   27 
 loleaflet/src/control/Control.Toolbar.js|9 ++
 loleaflet/src/control/Control.TopToolbar.js |3 --
 3 files changed, 37 insertions(+), 2 deletions(-)

New commits:
commit bd9637ae1211423090ec1f10eadabb9e68582d53
Author: Szymon Kłos 
AuthorDate: Thu Apr 30 11:09:24 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:39:12 2020 +0200

notebookbar: insert shapes popup

Change-Id: Icb75574372f48bf101ce14fc22bdf373e5e2026a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93298
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index d94e795fa..4614f27b9 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -36,6 +36,7 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
this._toolitemHandlers['.uno:Cut'] = 
this._clipboardButtonControl;
this._toolitemHandlers['.uno:Copy'] = 
this._clipboardButtonControl;
this._toolitemHandlers['.uno:Paste'] = 
this._clipboardButtonControl;
+   this._toolitemHandlers['.uno:BasicShapes'] = 
this._shapesControl;
 
this._toolitemHandlers['.uno:SelectWidth'] = function() {};
 
@@ -202,6 +203,22 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
});
},
 
+   _shapesControl: function(parentContainer, data, builder) {
+   var control = builder._unoToolButton(parentContainer, data, 
builder);
+
+   $(control.container).unbind('click');
+   $(control.container).click(function () {
+   if (!$('.insertshape-grid').length) {
+   
$(control.container).w2overlay(window.getShapesPopupHtml());
+   window.insertShapes();
+
+   $('.insertshape-grid .row .col').click(function 
() {
+   $(control.container).w2overlay();
+   });
+   }
+   });
+   },
+
_insertGraphicControl: function(parentContainer, data, builder) {
var control = builder._unoToolButton(parentContainer, data, 
builder);
 
diff --git a/loleaflet/src/control/Control.Toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
index 7a2290667..26777205c 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -502,6 +502,14 @@ function insertShapes(mobile) {
});
 }
 
+function getShapesPopupHtml() {
+   return '\
+   \
+   \
+   \
+   ';
+}
+
 function getColorPickerData(type) {
var uno;
if (type === 'Font Color') {
@@ -1063,6 +1071,7 @@ global.onClick = onClick;
 global.hideTooltip = hideTooltip;
 global.insertTable = insertTable;
 global.getInsertTablePopupHtml = getInsertTablePopupHtml;
+global.getShapesPopupHtml = getShapesPopupHtml;
 global.insertShapes = insertShapes;
 global.createShapesPanel = createShapesPanel;
 global.onUpdatePermission = onUpdatePermission;
diff --git a/loleaflet/src/control/Control.TopToolbar.js 
b/loleaflet/src/control/Control.TopToolbar.js
index 0e5f9f51d..7fda20d6d 100644
--- a/loleaflet/src/control/Control.TopToolbar.js
+++ b/loleaflet/src/control/Control.TopToolbar.js
@@ -223,8 +223,7 @@ L.Control.TopToolbar = L.Control.extend({
{id: 'remotegraphic', text: 
_UNO('.uno:InsertGraphic', '', true)},
]},
{type: 'button',  id: 'insertobjectchart',  img: 
'insertobjectchart', hint: _UNO('.uno:InsertObjectChart', '', true), uno: 
'InsertObjectChart'},
-   {type: 'drop',  id: 'insertshapes',  img: 
'basicshapes_ellipse', hint: _('Insert shapes'), overlay: {onShow: 
window.insertShapes},
-   html: ''},
+   {type: 'drop',  id: 'insertshapes',  img: 
'basicshapes_ellipse', hint: _('Insert shapes'), overlay: {onShow: 
window.insertShapes}, html: window.getShapesPopupHtml()},
{type: 'button',  id: 'link',  img: 'link', hint: 
_UNO('.uno:HyperlinkDialog', '', true), disabled: true},
{type: 'button',  id: 'insertsymbol', img: 
'insertsymbol', hint: _UNO('.uno:InsertSymbol', '', true), uno: 'InsertSymbol'},
{type: 'spacer'},
commit 8970ab16df4e8a0fc39f01fb6a26480b3a3bc01c
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 13:17:47 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:38:56 2020 +0200

notebookbar: insert symbol control


[Libreoffice-commits] online.git: 2 commits - loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/src/control/Control.NotebookbarBuilder.js |   36 
 1 file changed, 36 insertions(+)

New commits:
commit a2f6921fec76990d064c55c1af803905c4320a84
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 11:59:05 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:38:48 2020 +0200

notebookbar: linespacing control

Change-Id: Idb481aec70fe43d143a16d978492372f650320df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93293
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index 4f0b067df..b0eb08e03 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -31,6 +31,7 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
this._toolitemHandlers['.uno:InsertTable'] = 
this._insertTableControl;
this._toolitemHandlers['.uno:InsertGraphic'] = 
this._insertGraphicControl;
this._toolitemHandlers['.uno:InsertAnnotation'] = 
this._insertAnnotationControl;
+   this._toolitemHandlers['.uno:LineSpacing'] = 
this._lineSpacingControl;
this._toolitemHandlers['.uno:Cut'] = 
this._clipboardButtonControl;
this._toolitemHandlers['.uno:Copy'] = 
this._clipboardButtonControl;
this._toolitemHandlers['.uno:Paste'] = 
this._clipboardButtonControl;
@@ -243,6 +244,27 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
}
},
 
+   _lineSpacingControl: function(parentContainer, data, builder) {
+   var control = builder._unoToolButton(parentContainer, data, 
builder);
+
+   $(control.container).unbind('click');
+   $(control.container).click(function () {
+   $(control.container).w2menu({
+   items: [
+   {id: 'spacepara1', text: 
_UNO('.uno:SpacePara1'), uno: 'SpacePara1'},
+   {id: 'spacepara15', text: 
_UNO('.uno:SpacePara15'), uno: 'SpacePara15'},
+   {id: 'spacepara2', text: 
_UNO('.uno:SpacePara2'), uno: 'SpacePara2'},
+   {type: 'break'},
+   {id: 'paraspaceincrease', text: 
_UNO('.uno:ParaspaceIncrease'), uno: 'ParaspaceIncrease'},
+   {id: 'paraspacedecrease', text: 
_UNO('.uno:ParaspaceDecrease'), uno: 'ParaspaceDecrease'}
+   ],
+   onSelect: function (event) {
+   builder.map.sendUnoCommand('.uno:' + 
event.item.uno);
+   }
+   });
+   });
+   },
+
build: function(parent, data, hasVerticalParent, parentHasManyChildren) 
{
this._amendJSDialogData(data);
 
commit 2f98cbbf91bcd2f0b9ce113482acb0d5bc92b8c6
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 09:26:33 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:38:37 2020 +0200

notebookbar: override copy, cut & paste actions

Change-Id: I5338d844fd279f33d3832fdb2e05d83ee0a79a3f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93292
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index e2fb923d5..4f0b067df 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -31,6 +31,9 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
this._toolitemHandlers['.uno:InsertTable'] = 
this._insertTableControl;
this._toolitemHandlers['.uno:InsertGraphic'] = 
this._insertGraphicControl;
this._toolitemHandlers['.uno:InsertAnnotation'] = 
this._insertAnnotationControl;
+   this._toolitemHandlers['.uno:Cut'] = 
this._clipboardButtonControl;
+   this._toolitemHandlers['.uno:Copy'] = 
this._clipboardButtonControl;
+   this._toolitemHandlers['.uno:Paste'] = 
this._clipboardButtonControl;
 
this._toolitemHandlers['.uno:SelectWidth'] = function() {};
 
@@ -229,6 +232,17 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
$(control.container).click(function () 
{builder.map.insertComment();});
},
 
+   _clipboardButtonControl: function(parentContainer, data, builder) {
+   var control = builder._unoToolButton(parentContainer, data, 
builder);
+
+   if (builder.map._clip) {
+   $(control.container).unbind('click');
+   

[Libreoffice-commits] online.git: 2 commits - loleaflet/images loleaflet/src

2020-05-01 Thread Szymon Kłos (via logerrit)
 loleaflet/images/sc_defaultcharstyle.svg|1 +
 loleaflet/src/control/Control.JSDialogBuilder.js|3 ++-
 loleaflet/src/control/Control.NotebookbarBuilder.js |8 
 3 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit cc15dafe3441ba3159ba3976ccf044ff1032caff
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 08:47:19 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:38:23 2020 +0200

notebookbar: insert annotation control

Change-Id: I07adf35f49b5d2d5b8c51d98ab082d984d948fe2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93291
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/src/control/Control.NotebookbarBuilder.js 
b/loleaflet/src/control/Control.NotebookbarBuilder.js
index 3751ec75f..e2fb923d5 100644
--- a/loleaflet/src/control/Control.NotebookbarBuilder.js
+++ b/loleaflet/src/control/Control.NotebookbarBuilder.js
@@ -30,6 +30,7 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
 
this._toolitemHandlers['.uno:InsertTable'] = 
this._insertTableControl;
this._toolitemHandlers['.uno:InsertGraphic'] = 
this._insertGraphicControl;
+   this._toolitemHandlers['.uno:InsertAnnotation'] = 
this._insertAnnotationControl;
 
this._toolitemHandlers['.uno:SelectWidth'] = function() {};
 
@@ -221,6 +222,13 @@ L.Control.NotebookbarBuilder = 
L.Control.JSDialogBuilder.extend({
});
},
 
+   _insertAnnotationControl: function(parentContainer, data, builder) {
+   var control = builder._unoToolButton(parentContainer, data, 
builder);
+
+   $(control.container).unbind('click');
+   $(control.container).click(function () 
{builder.map.insertComment();});
+   },
+
build: function(parent, data, hasVerticalParent, parentHasManyChildren) 
{
this._amendJSDialogData(data);
 
commit 6cbc982df60c9926cac08459ee17fa4f2bd1c774
Author: Szymon Kłos 
AuthorDate: Wed Apr 29 12:20:28 2020 +0200
Commit: Szymon Kłos 
CommitDate: Fri May 1 21:38:12 2020 +0200

notebookbar: encode buttons ids to allow applying css styles

- encode also img path to avoid invalid chars

Change-Id: Ie10d3249fec65ac955b556f6d3206701282ca0b7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93294
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/loleaflet/images/sc_defaultcharstyle.svg 
b/loleaflet/images/sc_defaultcharstyle.svg
new file mode 100644
index 0..877355484
--- /dev/null
+++ b/loleaflet/images/sc_defaultcharstyle.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index 2c1536b09..459172901 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -1492,6 +1492,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
var prefixLength = '.uno:'.length;
if (name.substr(0, prefixLength) == '.uno:')
cleanName = name.substr(prefixLength);
+   cleanName = encodeURIComponent(cleanName).replace(/\%/g, '');
return 'images/lc_' + cleanName.toLowerCase() + '.svg';
},
 
@@ -1521,7 +1522,7 @@ L.Control.JSDialogBuilder = L.Control.extend({
controls['container'] = div;
 
if (data.command) {
-   var id = data.command.substr('.uno:'.length);
+   var id = 
encodeURIComponent(data.command.substr('.uno:'.length)).replace(/\%/g, '');
div.id = id;
 
var icon = builder._createIconPath(data.command);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sfx2/inc sfx2/source

2020-05-01 Thread andreas kainz (via logerrit)
 sfx2/inc/doctempl.hrc|4 ++--
 sfx2/source/doc/doctemplates.cxx |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e5e64558322b0e6efc75c7fca1cbd0af40044153
Author: andreas kainz 
AuthorDate: Fri May 1 11:19:54 2020 +0200
Commit: andreas_kainz 
CommitDate: Fri May 1 21:28:52 2020 +0200

Template: update category list sort

Change-Id: I6e3b25d65fa0fa57c4bfdac38c3cb6f24aa78f01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93246
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sfx2/inc/doctempl.hrc b/sfx2/inc/doctempl.hrc
index 23a199ef47ce..46773035e9b7 100644
--- a/sfx2/inc/doctempl.hrc
+++ b/sfx2/inc/doctempl.hrc
@@ -25,6 +25,7 @@
 const char* TEMPLATE_LONG_NAMES_ARY[] =
 {
 NC_("TEMPLATE_LONG_NAMES_ARY", "My Templates"),
+NC_("TEMPLATE_LONG_NAMES_ARY", "Styles"),
 NC_("TEMPLATE_LONG_NAMES_ARY", "Business Correspondence"),
 NC_("TEMPLATE_LONG_NAMES_ARY", "Other Business Documents"),
 NC_("TEMPLATE_LONG_NAMES_ARY", "Personal Correspondence and Documents"),
@@ -34,8 +35,7 @@ const char* TEMPLATE_LONG_NAMES_ARY[] =
 NC_("TEMPLATE_LONG_NAMES_ARY", "Presentation Backgrounds"),
 NC_("TEMPLATE_LONG_NAMES_ARY", "Presentations"),
 NC_("TEMPLATE_LONG_NAMES_ARY", "Miscellaneous"),
-NC_("TEMPLATE_LONG_NAMES_ARY", "Labels"),
-NC_("TEMPLATE_LONG_NAMES_ARY", "Styles")
+NC_("TEMPLATE_LONG_NAMES_ARY", "Labels")
 };
 
 #endif
diff --git a/sfx2/source/doc/doctemplates.cxx b/sfx2/source/doc/doctemplates.cxx
index fb193080652e..966293d4de23 100644
--- a/sfx2/source/doc/doctemplates.cxx
+++ b/sfx2/source/doc/doctemplates.cxx
@@ -481,6 +481,7 @@ void SfxDocTplService_Impl::getDefaultLocale()
 const char* TEMPLATE_SHORT_NAMES_ARY[] =
 {
 "standard",
+"styles",
 "officorr",
 "offimisc",
 "personal",
@@ -490,8 +491,7 @@ const char* TEMPLATE_SHORT_NAMES_ARY[] =
 "layout",
 "presnt",
 "misc",
-"labels",
-"styles"
+"labels"
 };
 
 void SfxDocTplService_Impl::readFolderList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132601] New: A shape can be anchored in header and dragged into to the text. Making it impossible to delete

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132601

Bug ID: 132601
   Summary: A shape can be anchored in header and dragged into to
the text. Making it impossible to delete
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
A shape can be anchored in header and dragged into to the text. Making it
impossible to delete

Steps to Reproduce:
1. Open the attached file
2. Try to select the blue bar

Delete the header.. image gone
3. Insert a shape into the header
4. Drag it into the text

Actual Results:
Impossible to reach

Expected Results:
Don't allow the header image to much out header area?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: f845f74afaf087a46c82ee4209e29caca0980b71
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132600] Page break still around after unchecking Insert page break

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132600

--- Comment #1 from Telesto  ---
Created attachment 160199
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160199=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132600] New: Page break still around after unchecking Insert page break

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132600

Bug ID: 132600
   Summary: Page break still around after unchecking Insert page
break
   Product: LibreOffice
   Version: 7.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Page break still around after unchecking Insert page break

Steps to Reproduce:
1. Open the attached file
2. Hoover with the mouse above the page breaker
3. Choose Edit pagebreak
4. Uncheck insert page break & press OK

Actual Results:
Nothing

Expected Results:
Deletion of the page breaker?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: f845f74afaf087a46c82ee4209e29caca0980b71
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132599] New: Option to stop words hyphenating across pages

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132599

Bug ID: 132599
   Summary: Option to stop words hyphenating across pages
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: greenandpleasant2000-supp...@yahoo.co.uk

Created attachment 160198
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160198=edit
LibreOffice doc. showing inter-pahe hyphens

If Hyphenation is set to "Automatically" (in Paragraph Style > Text Flow),
there is a problem with words hyphenating from one page to another.

According to New Harts Rules (OUP, 2005, "Line Endings", p. 40), a recto
(right-hand) page should not end with a hyphen (probably the same rule in the
Chicago Manual of Style). This rule obviously applies to hard copy in  book
format; but for PC documents it also makes sense to apply the restriction on
hyphenation to "verso" (left-hand) pages.

For example, open the attached document. Look at the hyphenation from pp. 1-2,
and 5-6. This is awkward to read. In a long document, you have to turn off
hyphenation for each hyphenated "inter-page" word : this is time-consuming, and
a document update may require you to do the whole thing over again.

SUGGESTION: Add two tick-box options to the Paragraph Style > Text Flow TAB:

1. Don't hyphenate words from recto to verso pages.
2. Don't hyphenate words across any pages.

Instead of hypenation, the last word will be moved, automatically, to the next
page.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132596] Crash in: SwPosition::SwPosition(SwPosition const &)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132596

--- Comment #1 from Telesto  ---
Bug file 92372

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132596] Crash in: SwPosition::SwPosition(SwPosition const &)

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132596

--- Comment #2 from Telesto  ---
File from bug 92372

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 129702, which changed state.

Bug 129702 Summary: [UI] Smart tags wrongly listed in AutoCorrect options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129702

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103341
Bug 103341 depends on bug 129702, which changed state.

Bug 129702 Summary: [UI] Smart tags wrongly listed in AutoCorrect options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129702

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/uiconfig

2020-05-01 Thread Caolán McNamara (via logerrit)
 cui/uiconfig/ui/smarttagoptionspage.ui |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 161fde0052c6d0616ba54a0799e84d58b2c80688
Author: Caolán McNamara 
AuthorDate: Fri May 1 17:01:15 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri May 1 21:08:41 2020 +0200

Resolves: tdf#129702 take text from correct model column

Change-Id: If9af51348e5a254a0c5ab621fa162cdda4565e49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93290
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/smarttagoptionspage.ui 
b/cui/uiconfig/ui/smarttagoptionspage.ui
index 08cbb87ae8e6..3effd4bad9e6 100644
--- a/cui/uiconfig/ui/smarttagoptionspage.ui
+++ b/cui/uiconfig/ui/smarttagoptionspage.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -123,7 +123,7 @@
 
   
   
-0
+1
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 108815] [META] Print range/area bugs and enhancements

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108815

Buovjaga  changed:

   What|Removed |Added

 Depends on||129960


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129960
[Bug 129960] Print range for sheet 13 or higher not saved to ODS format, if
linked data is used
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129960] Print range for sheet 13 or higher not saved to ODS format, if linked data is used

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129960

Buovjaga  changed:

   What|Removed |Added

Summary|Unable to print sheet 13 or |Print range for sheet 13 or
   |higher if linked data is|higher not saved to ODS
   |used|format, if linked data is
   ||used
 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
   Keywords||bibisected, bisected,
   ||regression
 Blocks||108815
 OS|Windows (All)   |All
 Status|UNCONFIRMED |NEW
 CC||ilmari.lauhakangas@libreoff
   ||ice.org,
   ||sberg...@redhat.com
Version|6.3.4.2 release |5.0.0.5 release

--- Comment #1 from Buovjaga  ---
Bibisected with win32-5.0 to
https://git.libreoffice.org/core/+/bfa4494560884635a03c4db89588a118f9a2be0b%5E!/

loplugin:simplifybool

Adding Cc: to Stephan Bergmann

Note: having an example attachment would not be of use. The second file needs
to be created anew every time (as I did with bibisecting). However, there is no
need to paste anything into sheets 1-12. Just create enough sheets and use
sheet 13.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108815
[Bug 108815] [META] Print range/area bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132598] Converting word document with grids causes overlapping grids.

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132598

--- Comment #2 from Rhys Young  ---
Created attachment 160197
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160197=edit
Grid incorrect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132598] Converting word document with grids causes overlapping grids.

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132598

--- Comment #1 from Rhys Young  ---
Created attachment 160196
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160196=edit
Normal grid

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132597] New: Crash in: swlo.dll

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132597

Bug ID: 132597
   Summary: Crash in: swlo.dll
   Product: LibreOffice
   Version: 6.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Created attachment 160195
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160195=edit
Example file

This bug was filed from the crash reporting server and is
br-00cc51bd-07a9-450c-90ab-29a75a34abfd.
=

1. Open the attached file
2. CTRL+A
3. CTRL+C
4. CTRL+N
5. CTRL+SHIFT+V
6. CTRL+Z

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132598] New: Converting word document with grids causes overlapping grids.

2020-05-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132598

Bug ID: 132598
   Summary: Converting word document with grids causes overlapping
grids.
   Product: LibreOffice
   Version: 6.3.5.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rhys.yo...@d2l.com

Description:
When converting the word document to pdf form it does not parse the grids
properly. Changed all text in the document to protect client data.

Steps to Reproduce:
1. Convert file to PDF using 'soffice --headless --nolockcheck --nodefault
--nofirststartwizard --nologo --norestore --convert-to pdf --outdir /tmp
/tmp/test.docx'
2. Open PDF using a viewer
3. Observe the grids looking weird

Actual Results:
Grids should look normal

Expected Results:
Grids do not look normal


Reproducible: Always


User Profile Reset: No



Additional Info:
None

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >