[Libreoffice-bugs] [Bug 133464] use of getSheets() in macro throws error

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133464

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de

--- Comment #1 from Oliver Brinzing  ---
(In reply to Henry Hall from comment #0)

>When the spreadsheet is opened error messages are thrown:

This issue looks like a duplicate of:
Bug 123005 - FILEOPEN: Error on creating
getCurrentController().getActiveSheet() for basic script from location=document

> The idea is to avoid having to type in the sheet names, and pull values from
> the desired sheet.

Maybe this could be a workaround:

=MID(CELL("FILENAME");FIND("#$";CELL("FILENAME")&0*RAND())+2;256)

Bug 121422 - The CELL function does not change the result after changing the
name of the sheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97694] Base macros cannot be digitally signed

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97694

--- Comment #27 from Oliver Brinzing  ---
(In reply to Stephan from comment #26)

> A little bit off-topic, but: Why does LO forget the signature of macros in a
> template file when a document is produced from it? The macros are exported
> to the document, but the signature is lost...

this should be fixed with:
Bug 42316 - Creating a new document from a template removes the signature from
all Macros

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101181

--- Comment #21 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9dcbf7b0098e59c22ec17d86c270d610e0416f72

tdf#49247, tdf#101181: output glow and soft edge effects to metafile

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101181

--- Comment #22 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c9f4952b98da9adad1b556414c5fcecafedca473

tdf#101181: use buffer device with alpha in glow effect

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: drawinglayer/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclprocessor2d.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 8c84448febf817875ad0d377de0f0b34987992cb
Author: Mike Kaganski 
AuthorDate: Thu May 28 20:13:50 2020 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:26:16 2020 +0200

Use buffer with alpha in 
VclProcessor2D::RenderUnifiedTransparencePrimitive2D

This allows UnifiedTransparencePrimitive2D to produce truly transparent 
image,
usable later in the stack - specifically by glow and soft edge effect.

Change-Id: I27e9bfbfb9c60856bc3fad1a483623c90d5cabff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94969
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclprocessor2d.cxx
index 60b372b0ef48..e64995c8b50a 100644
--- a/drawinglayer/source/processor2d/vclprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclprocessor2d.cxx
@@ -841,13 +841,14 @@ void VclProcessor2D::RenderUnifiedTransparencePrimitive2D(
 // transparence is in visible range
 basegfx::B2DRange 
aRange(rTransCandidate.getChildren().getB2DRange(getViewInformation2D()));
 aRange.transform(maCurrentTransformation);
-impBufferDevice aBufferDevice(*mpOutputDevice, aRange);
+impBufferDevice aBufferDevice(*mpOutputDevice, aRange, true);
 
 if (aBufferDevice.isVisible())
 {
 // remember last OutDev and set to content
 OutputDevice* pLastOutputDevice = mpOutputDevice;
 mpOutputDevice = ();
+mpOutputDevice->Erase();
 
 // paint content to it
 process(rTransCandidate.getChildren());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/primitive2d/glowprimitive2d.cxx |   16 
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |   15 +++
 include/drawinglayer/primitive2d/glowprimitive2d.hxx|5 -
 3 files changed, 7 insertions(+), 29 deletions(-)

New commits:
commit c9f4952b98da9adad1b556414c5fcecafedca473
Author: Mike Kaganski 
AuthorDate: Thu May 28 17:51:15 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:25:48 2020 +0200

tdf#101181: use buffer device with alpha in glow effect

Change-Id: Iddc94a5cfdee03befdf245ee086a872f0bfaf7a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95051
Tested-by: Jenkins
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/primitive2d/glowprimitive2d.cxx 
b/drawinglayer/source/primitive2d/glowprimitive2d.cxx
index bf49b8e215b5..fb6a599ab4e2 100644
--- a/drawinglayer/source/primitive2d/glowprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/glowprimitive2d.cxx
@@ -60,22 +60,6 @@ GlowPrimitive2D::getB2DRange(const 
geometry::ViewInformation2D& rViewInformation
 return aRetval;
 }
 
-void GlowPrimitive2D::get2DDecomposition(
-Primitive2DDecompositionVisitor& rVisitor,
-const geometry::ViewInformation2D& /*rViewInformation*/) const
-{
-if (getChildren().empty())
-return;
-
-// create a modifiedColorPrimitive containing the *black* color and the 
content. Using black
-// on white allows creating useful mask in 
VclPixelProcessor2D::processGlowPrimitive2D.
-basegfx::BColorModifierSharedPtr aBColorModifier
-= std::make_shared(basegfx::BColor());
-
-const Primitive2DReference xRef(new 
ModifiedColorPrimitive2D(getChildren(), aBColorModifier));
-rVisitor.append(xRef);
-}
-
 // provide unique ID
 ImplPrimitive2DIDBlock(GlowPrimitive2D, PRIMITIVE2D_ID_GLOWPRIMITIVE2D)
 
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 3c1a1087adcf..d4ee5f39b7a0 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -983,30 +983,29 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const 
primitive2d::GlowPrimitiv
 // Consider glow transparency (initial transparency near the object edge)
 const sal_uInt8 nTransparency = 
rCandidate.getGlowColor().GetTransparency();
 
-impBufferDevice aBufferDevice(*mpOutputDevice, aRange);
+impBufferDevice aBufferDevice(*mpOutputDevice, aRange, true);
 if (aBufferDevice.isVisible())
 {
 // remember last OutDev and set to content
 OutputDevice* pLastOutputDevice = mpOutputDevice;
 mpOutputDevice = ();
-// Processing will draw whatever geometry on white background, 
applying *black*
-// replacement color. The black color replacement is added in 2d 
decomposition of
-// glow primitive.
 mpOutputDevice->Erase();
 process(rCandidate);
 const tools::Rectangle 
aRect(static_cast(std::floor(aRange.getMinX())),
  
static_cast(std::floor(aRange.getMinY())),
  
static_cast(std::ceil(aRange.getMaxX())),
  
static_cast(std::ceil(aRange.getMaxY(;
-Bitmap bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), 
aRect.GetSize());
+BitmapEx bmpEx = mpOutputDevice->GetBitmapEx(aRect.TopLeft(), 
aRect.GetSize());
 
-AlphaMask mask = ProcessAndBlurAlphaMask(bitmap, fBlurRadius, 
fBlurRadius, nTransparency);
+AlphaMask mask
+= ProcessAndBlurAlphaMask(bmpEx.GetAlpha(), fBlurRadius, 
fBlurRadius, nTransparency);
 
 // The end result is the bitmap filled with glow color and blurred 
8-bit alpha mask
 const basegfx::BColor aGlowColor(
 
maBColorModifierStack.getModifiedColor(rCandidate.getGlowColor().getBColor()));
-bitmap.Erase(Color(aGlowColor));
-BitmapEx result(bitmap, mask);
+Bitmap bmp = bmpEx.GetBitmap();
+bmp.Erase(Color(aGlowColor));
+BitmapEx result(bmp, mask);
 
 // back to old OutDev
 mpOutputDevice = pLastOutputDevice;
diff --git a/include/drawinglayer/primitive2d/glowprimitive2d.hxx 
b/include/drawinglayer/primitive2d/glowprimitive2d.hxx
index 5c3029882de2..62a585276b85 100644
--- a/include/drawinglayer/primitive2d/glowprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/glowprimitive2d.hxx
@@ -52,11 +52,6 @@ public:
 virtual basegfx::B2DRange
 getB2DRange(const geometry::ViewInformation2D& rViewInformation) const 
override;
 
-///  create decomposition
-virtual void
-get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor,
-   const geometry::ViewInformation2D& rViewInformation) 
const override;
-
 /// provide unique ID
 virtual sal_uInt32 getPrimitive2DID() 

[Libreoffice-commits] core.git: drawinglayer/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |   97 +
 drawinglayer/source/processor2d/vclmetafileprocessor2d.hxx |5 
 2 files changed, 102 insertions(+)

New commits:
commit 9dcbf7b0098e59c22ec17d86c270d610e0416f72
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:25:23 2020 +0200

tdf#49247, tdf#101181: output glow and soft edge effects to metafile

Change-Id: Ie660ae372fc0b5f97f685b6d1e82b9e8a12e7e30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94192
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index 231bf8bc9259..297fd725c7b7 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -38,6 +38,8 @@
 #include  // for PDFExtOutDevData Graphic support
 #include  // for PDFExtOutDevData Graphic 
support
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -927,6 +929,12 @@ void VclMetafileProcessor2D::processBasePrimitive2D(const 
primitive2d::BasePrimi
 static_cast(rCandidate));
 break;
 }
+case PRIMITIVE2D_ID_GLOWPRIMITIVE2D:
+case PRIMITIVE2D_ID_SOFTEDGEPRIMITIVE2D:
+{
+processPrimitive2DOnPixelProcessor(rCandidate);
+break;
+}
 default:
 {
 // process recursively
@@ -2312,6 +2320,95 @@ void 
VclMetafileProcessor2D::processStructureTagPrimitive2D(
 }
 }
 
+VclPtr VclMetafileProcessor2D::CreateBufferDevice(
+const basegfx::B2DRange& rCandidateRange, const double fMaxQuadratPixels,
+geometry::ViewInformation2D& rViewInfo, tools::Rectangle& rRectLogic, 
Size& rSizePixel)
+{
+basegfx::B2DRange aViewRange(rCandidateRange);
+aViewRange.transform(maCurrentTransformation);
+rRectLogic = 
tools::Rectangle(static_cast(std::floor(aViewRange.getMinX())),
+  
static_cast(std::floor(aViewRange.getMinY())),
+  
static_cast(std::ceil(aViewRange.getMaxX())),
+  
static_cast(std::ceil(aViewRange.getMaxY(;
+const tools::Rectangle 
aRectPixel(mpOutputDevice->LogicToPixel(rRectLogic));
+rSizePixel = aRectPixel.GetSize();
+const double fViewVisibleArea(rSizePixel.getWidth() * 
rSizePixel.getHeight());
+double fReduceFactor(1.0);
+
+if (fViewVisibleArea > fMaxQuadratPixels)
+{
+// reduce render size
+fReduceFactor = sqrt(fMaxQuadratPixels / fViewVisibleArea);
+rSizePixel = Size(basegfx::fround(rSizePixel.getWidth() * 
fReduceFactor),
+  basegfx::fround(rSizePixel.getHeight() * 
fReduceFactor));
+}
+
+VclPtrInstance pBufferDevice(DeviceFormat::DEFAULT, 
DeviceFormat::DEFAULT);
+if (pBufferDevice->SetOutputSizePixel(rSizePixel))
+{
+// create and set MapModes for target devices
+MapMode aNewMapMode(mpOutputDevice->GetMapMode());
+aNewMapMode.SetOrigin(Point(-rRectLogic.Left(), -rRectLogic.Top()));
+pBufferDevice->SetMapMode(aNewMapMode);
+
+// prepare view transformation for target renderers
+// ATTENTION! Need to apply another scaling because of the potential 
DPI differences
+// between Printer and VDev (mpOutputDevice and pBufferDevice here).
+// To get the DPI, LogicToPixel from (1,1) from MapUnit::MapInch needs 
to be used.
+basegfx::B2DHomMatrix 
aViewTransform(pBufferDevice->GetViewTransformation());
+const Size aDPIOld(mpOutputDevice->LogicToPixel(Size(1, 1), 
MapMode(MapUnit::MapInch)));
+const Size aDPINew(pBufferDevice->LogicToPixel(Size(1, 1), 
MapMode(MapUnit::MapInch)));
+const double fDPIXChange(static_cast(aDPIOld.getWidth())
+ / static_cast(aDPINew.getWidth()));
+const double fDPIYChange(static_cast(aDPIOld.getHeight())
+ / static_cast(aDPINew.getHeight()));
+
+if (!basegfx::fTools::equal(fDPIXChange, 1.0) || 
!basegfx::fTools::equal(fDPIYChange, 1.0))
+{
+aViewTransform.scale(fDPIXChange, fDPIYChange);
+}
+
+// also take scaling from Size reduction into account
+if (!basegfx::fTools::equal(fReduceFactor, 1.0))
+{
+aViewTransform.scale(fReduceFactor, fReduceFactor);
+}
+
+// create view information and pixel renderer. Reuse known 
ViewInformation
+// except new transformation and range
+rViewInfo = geometry::ViewInformation2D(
+getViewInformation2D().getObjectTransformation(), aViewTransform, 
aViewRange,
+getViewInformation2D().getVisualizedPage(), 
getViewInformation2D().getViewTime(),
+

[Libreoffice-commits] core.git: 2 commits - drawinglayer/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |   21 ++--
 drawinglayer/source/processor2d/vclprocessor2d.cxx  |5 +++
 2 files changed, 12 insertions(+), 14 deletions(-)

New commits:
commit d5a995c0296df61cd6c9341779bccbf8989ecc75
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:25:05 2020 +0200

Use buffer with alpha in VclProcessor2D::RenderTransparencePrimitive2D

This allows TransparencePrimitive2D to produce truly transparent image,
usable later in the stack - specifically by soft edge effect.

Change-Id: I54e6f9a8fd196247b1130446af3d21b082820f01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95038
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclprocessor2d.cxx
index 9e3cf43208bc..60b372b0ef48 100644
--- a/drawinglayer/source/processor2d/vclprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclprocessor2d.cxx
@@ -870,7 +870,7 @@ void VclProcessor2D::RenderTransparencePrimitive2D(
 
 basegfx::B2DRange 
aRange(rTransCandidate.getChildren().getB2DRange(getViewInformation2D()));
 aRange.transform(maCurrentTransformation);
-impBufferDevice aBufferDevice(*mpOutputDevice, aRange);
+impBufferDevice aBufferDevice(*mpOutputDevice, aRange, true);
 
 if (!aBufferDevice.isVisible())
 return;
@@ -878,6 +878,7 @@ void VclProcessor2D::RenderTransparencePrimitive2D(
 // remember last OutDev and set to content
 OutputDevice* pLastOutputDevice = mpOutputDevice;
 mpOutputDevice = ();
+mpOutputDevice->Erase();
 
 // paint content to it
 process(rTransCandidate.getChildren());
@@ -889,6 +890,8 @@ void VclProcessor2D::RenderTransparencePrimitive2D(
 basegfx::BColorModifierStack 
aLastBColorModifierStack(maBColorModifierStack);
 maBColorModifierStack = basegfx::BColorModifierStack();
 
+mpOutputDevice->Erase();
+
 // paint mask to it (always with transparence intensities, evtl. with AA)
 process(rTransCandidate.getTransparence());
 
commit 425125e31f9053e0e4895fb13e1e267ec5d26487
Author: Mike Kaganski 
AuthorDate: Thu May 28 15:13:15 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:24:53 2020 +0200

tdf#49247: Reimplement soft edges to keep object transparency

So the objects that were semi-transparent don't become opaque upon
applying soft edge effect. This requires that the objects are
actually semi-transparent, so that we can get alpha mask from bitmap

Change-Id: Ic4af9bea19e5e71139d3f065797583f7c7c78815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95034
Tested-by: Jenkins
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 9e44ef292d34..3c1a1087adcf 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -1027,33 +1027,28 @@ void VclPixelProcessor2D::processSoftEdgePrimitive2D(
 // Blur radius is equal to soft edge radius
 const double fBlurRadius = aRadiusVector.getLength();
 
-impBufferDevice aBufferDevice(*mpOutputDevice, aRange);
+impBufferDevice aBufferDevice(*mpOutputDevice, aRange, true);
 if (aBufferDevice.isVisible())
 {
 // remember last OutDev and set to content
 OutputDevice* pLastOutputDevice = mpOutputDevice;
 mpOutputDevice = ();
-// Processing will draw whatever geometry on white background, 
applying *black*
-// replacement color
 mpOutputDevice->Erase();
-rCandidate.setMaskGeneration();
 process(rCandidate);
-rCandidate.setMaskGeneration(false);
+
 const tools::Rectangle 
aRect(static_cast(std::floor(aRange.getMinX())),
  
static_cast(std::floor(aRange.getMinY())),
  
static_cast(std::ceil(aRange.getMaxX())),
  
static_cast(std::ceil(aRange.getMaxY(;
-Bitmap bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), 
aRect.GetSize());
-
-AlphaMask mask = ProcessAndBlurAlphaMask(bitmap, -fBlurRadius, 
fBlurRadius, 0);
+BitmapEx bitmap = mpOutputDevice->GetBitmapEx(aRect.TopLeft(), 
aRect.GetSize());
 
-// The end result is the original bitmap with blurred 8-bit alpha mask
+AlphaMask aMask = bitmap.GetAlpha();
+AlphaMask blurMask = ProcessAndBlurAlphaMask(aMask, -fBlurRadius, 
fBlurRadius, 0);
 
-mpOutputDevice->Erase();
-process(rCandidate);
-bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), aRect.GetSize());
+aMask.BlendWith(blurMask);
 
-BitmapEx result(bitmap, mask);
+// The end result is the 

[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101181

--- Comment #20 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2cfe93da835eb500c9a170d22fce19fbd1de9473

tdf#49247, tdf#101181: don't rely on automatic scaling of alpha mask

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101181

--- Comment #19 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/541e5a9e84c42fbf20158b01a4feaa0f226e9ed0

tdf#49247, tdf#101181: Fix effect bounds

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101181

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.0.0|target:7.0.0 target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - drawinglayer/source vcl/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |   21 +---
 vcl/source/outdev/outdev.cxx|   12 +++--
 2 files changed, 23 insertions(+), 10 deletions(-)

New commits:
commit 541e5a9e84c42fbf20158b01a4feaa0f226e9ed0
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:23:26 2020 +0200

tdf#49247, tdf#101181: Fix effect bounds

This will avoid cutting rightmost and bottommost pixels from the effects,
caused by casting of range dimensions to integers.

Change-Id: Icad9c06c33bafae9531bc45559acecd3581fad89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95020
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 131e51f34913..32afe33e6147 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -993,8 +993,11 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const 
primitive2d::GlowPrimitiv
 // glow primitive.
 mpOutputDevice->Erase();
 process(rCandidate);
-Bitmap bitmap = mpOutputDevice->GetBitmap(Point(aRange.getMinX(), 
aRange.getMinY()),
-  Size(aRange.getWidth(), 
aRange.getHeight()));
+const tools::Rectangle 
aRect(static_cast(std::floor(aRange.getMinX())),
+ 
static_cast(std::floor(aRange.getMinY())),
+ 
static_cast(std::ceil(aRange.getMaxX())),
+ 
static_cast(std::ceil(aRange.getMaxY(;
+Bitmap bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), 
aRect.GetSize());
 
 AlphaMask mask = ProcessAndBlurAlphaMask(bitmap, fBlurRadius, 
fBlurRadius, nTransparency);
 
@@ -1007,7 +1010,7 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const 
primitive2d::GlowPrimitiv
 
 // back to old OutDev
 mpOutputDevice = pLastOutputDevice;
-mpOutputDevice->DrawBitmapEx(Point(aRange.getMinX(), 
aRange.getMinY()), result);
+mpOutputDevice->DrawBitmapEx(aRect.TopLeft(), result);
 }
 else
 SAL_WARN("drawinglayer", "Temporary buffered virtual device is not 
visible");
@@ -1036,8 +1039,11 @@ void VclPixelProcessor2D::processSoftEdgePrimitive2D(
 rCandidate.setMaskGeneration();
 process(rCandidate);
 rCandidate.setMaskGeneration(false);
-Bitmap bitmap = mpOutputDevice->GetBitmap(Point(aRange.getMinX(), 
aRange.getMinY()),
-  Size(aRange.getWidth(), 
aRange.getHeight()));
+const tools::Rectangle 
aRect(static_cast(std::floor(aRange.getMinX())),
+ 
static_cast(std::floor(aRange.getMinY())),
+ 
static_cast(std::ceil(aRange.getMaxX())),
+ 
static_cast(std::ceil(aRange.getMaxY(;
+Bitmap bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), 
aRect.GetSize());
 
 AlphaMask mask = ProcessAndBlurAlphaMask(bitmap, -fBlurRadius, 
fBlurRadius, 0);
 
@@ -1045,15 +1051,14 @@ void VclPixelProcessor2D::processSoftEdgePrimitive2D(
 
 mpOutputDevice->Erase();
 process(rCandidate);
-bitmap = mpOutputDevice->GetBitmap(Point(aRange.getMinX(), 
aRange.getMinY()),
-   Size(aRange.getWidth(), 
aRange.getHeight()));
+bitmap = mpOutputDevice->GetBitmap(aRect.TopLeft(), aRect.GetSize());
 
 // alpha mask will be scaled up automatically to match bitmap
 BitmapEx result(bitmap, mask);
 
 // back to old OutDev
 mpOutputDevice = pLastOutputDevice;
-mpOutputDevice->DrawBitmapEx(Point(aRange.getMinX(), 
aRange.getMinY()), result);
+mpOutputDevice->DrawBitmapEx(aRect.TopLeft(), result);
 }
 else
 SAL_WARN("drawinglayer", "Temporary buffered virtual device is not 
visible");
commit 946b01e2d4a41b06415f6371b7b52dca090e7b86
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:23:16 2020 +0200

Consider mpAlphaVDev when processing metafile in OutputDevice::DrawOutDev

Change-Id: Ia9709bba6eb2a64781297ca260341693b0e39107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95019
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/source/outdev/outdev.cxx b/vcl/source/outdev/outdev.cxx
index 18f273b8185a..020a57a6a40c 100644
--- a/vcl/source/outdev/outdev.cxx
+++ b/vcl/source/outdev/outdev.cxx
@@ -415,8 +415,16 @@ void OutputDevice::DrawOutDev( const Point& rDestPt, const 
Size& rDestSize,
 
 if ( mpMetaFile )
 {
-const Bitmap aBmp( rOutDev.GetBitmap( rSrcPt, rSrcSize ) );
- 

[Libreoffice-commits] core.git: drawinglayer/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclhelperbufferdevice.cxx |  120 --
 drawinglayer/source/processor2d/vclhelperbufferdevice.hxx |4 
 2 files changed, 80 insertions(+), 44 deletions(-)

New commits:
commit d4bfa55209eedcaae51c9ccba466f39620f82d49
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:23:57 2020 +0200

Allow creation of virtual device with alpha as content of impBufferDevice

impBufferDevice now can create its mpContent with alpha; that is used
when painting, blending mpContent's alpha with mpMask/mpAlpha/fTrans.

That allows to paint to the buffer device and get actual transparency
of the painted objects in one pass, to process further (e.g., modify
transparency separately, or use it to get mask).

Required for subsequent soft edge effect improvement

Change-Id: If19c160581ce9a515d86222dd2fab06f746df2da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95030
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx 
b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
index 534c512daa42..647825959108 100644
--- a/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
+++ b/drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
@@ -42,11 +42,22 @@ namespace
 class VDevBuffer : public Timer, protected cppu::BaseMutex
 {
 private:
+struct Entry
+{
+VclPtr buf;
+bool isTransparent = false;
+Entry(const VclPtr& vdev, bool bTransparent)
+: buf(vdev)
+, isTransparent(bTransparent)
+{
+}
+};
+
 // available buffers
-std::vector> maFreeBuffers;
+std::vector maFreeBuffers;
 
 // allocated/used buffers (remembered to allow deleting them in destructor)
-std::vector> maUsedBuffers;
+std::vector maUsedBuffers;
 
 // remember what outputdevice was the template passed to 
VirtualDevice::Create
 // so we can test if that OutputDevice was disposed before reusing a
@@ -58,7 +69,7 @@ public:
 virtual ~VDevBuffer() override;
 
 VclPtr alloc(OutputDevice& rOutDev, const Size& rSizePixel, 
bool bClear,
-bool bMonoChrome);
+bool bMonoChrome, bool bTransparent);
 void free(VirtualDevice& rDevice);
 
 // Timer virtuals
@@ -81,19 +92,19 @@ VDevBuffer::~VDevBuffer()
 
 while (!maFreeBuffers.empty())
 {
-maFreeBuffers.back().disposeAndClear();
+maFreeBuffers.back().buf.disposeAndClear();
 maFreeBuffers.pop_back();
 }
 
 while (!maUsedBuffers.empty())
 {
-maUsedBuffers.back().disposeAndClear();
+maUsedBuffers.back().buf.disposeAndClear();
 maUsedBuffers.pop_back();
 }
 }
 
 VclPtr VDevBuffer::alloc(OutputDevice& rOutDev, const Size& 
rSizePixel, bool bClear,
-bool bMonoChrome)
+bool bMonoChrome, bool bTransparent)
 {
 ::osl::MutexGuard aGuard(m_aMutex);
 VclPtr pRetval;
@@ -107,9 +118,9 @@ VclPtr VDevBuffer::alloc(OutputDevice& 
rOutDev, const Size& rSize
 
 for (auto a = maFreeBuffers.begin(); a != maFreeBuffers.end(); ++a)
 {
-assert(*a && "Empty pointer in VDevBuffer (!)");
+assert(a->buf && "Empty pointer in VDevBuffer (!)");
 
-if (nBits == (*a)->GetBitCount())
+if (nBits == a->buf->GetBitCount() && bTransparent == 
a->isTransparent)
 {
 // candidate is valid due to bit depth
 if (aFound != maFreeBuffers.end())
@@ -119,16 +130,16 @@ VclPtr VDevBuffer::alloc(OutputDevice& 
rOutDev, const Size& rSize
 {
 // found is valid
 const bool bCandidateOkay(
-(*a)->GetOutputWidthPixel() >= 
rSizePixel.getWidth()
-&& (*a)->GetOutputHeightPixel() >= 
rSizePixel.getHeight());
+a->buf->GetOutputWidthPixel() >= 
rSizePixel.getWidth()
+&& a->buf->GetOutputHeightPixel() >= 
rSizePixel.getHeight());
 
 if (bCandidateOkay)
 {
 // found and candidate are valid
-const sal_uLong 
aSquare((*aFound)->GetOutputWidthPixel()
-* 
(*aFound)->GetOutputHeightPixel());
-const sal_uLong 
aCandidateSquare((*a)->GetOutputWidthPixel()
- * 
(*a)->GetOutputHeightPixel());
+const sal_uLong 
aSquare(aFound->buf->GetOutputWidthPixel()
+* 
aFound->buf->GetOutputHeightPixel());
+ 

[Libreoffice-commits] core.git: 2 commits - drawinglayer/source include/vcl vcl/source

2020-05-28 Thread Mike Kaganski (via logerrit)
 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |   11 +++
 include/vcl/alpha.hxx   |1 
 vcl/source/gdi/alpha.cxx|   23 
 3 files changed, 29 insertions(+), 6 deletions(-)

New commits:
commit 6806616023242aded27b1fae8637d32c9626d472
Author: Mike Kaganski 
AuthorDate: Thu May 14 14:42:24 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:23:50 2020 +0200

Add AlphaMask::BlendWith method to blend 8-bit alpha masks

Required for subsequent soft edge effect improvement

Change-Id: I9351b827a83c5651100e73a6846c834f491b861d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95027
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/vcl/alpha.hxx b/include/vcl/alpha.hxx
index f87ac133970a..159c61243efa 100644
--- a/include/vcl/alpha.hxx
+++ b/include/vcl/alpha.hxx
@@ -56,6 +56,7 @@ public:
 voidErase( sal_uInt8 cTransparency );
 voidReplace( const Bitmap& rMask, sal_uInt8 rReplaceTransparency );
 voidReplace( sal_uInt8 cSearchTransparency, sal_uInt8 
cReplaceTransparency );
+voidBlendWith(const Bitmap& rOther);
 
 BitmapReadAccess*  AcquireAlphaReadAccess() { return 
Bitmap::AcquireReadAccess(); }
 BitmapWriteAccess* AcquireAlphaWriteAccess() { return 
Bitmap::AcquireWriteAccess(); }
diff --git a/vcl/source/gdi/alpha.cxx b/vcl/source/gdi/alpha.cxx
index fde0e94583a9..1385f803be8d 100644
--- a/vcl/source/gdi/alpha.cxx
+++ b/vcl/source/gdi/alpha.cxx
@@ -138,6 +138,29 @@ void AlphaMask::Replace( sal_uInt8 cSearchTransparency, 
sal_uInt8 cReplaceTransp
 }
 }
 
+void AlphaMask::BlendWith(const Bitmap& rOther)
+{
+AlphaMask aOther(rOther); // to 8 bits
+Bitmap::ScopedReadAccess pOtherAcc(aOther);
+AlphaScopedWriteAccess pAcc(*this);
+if (pOtherAcc && pAcc && pOtherAcc->GetBitCount() == 8 && 
pAcc->GetBitCount() == 8)
+{
+const long nHeight = std::min(pOtherAcc->Height(), pAcc->Height());
+const long nWidth = std::min(pOtherAcc->Width(), pAcc->Width());
+for (long x = 0; x < nWidth; ++x)
+{
+for (long y = 0; y < nHeight; ++y)
+{
+// Use sal_uInt16 for following multiplication
+const sal_uInt16 nGrey1 = pOtherAcc->GetPixelIndex(y, x);
+const sal_uInt16 nGrey2 = pAcc->GetPixelIndex(y, x);
+const double fGrey = std::round(nGrey1 + nGrey2 - nGrey1 * 
nGrey2 / 255.0);
+pAcc->SetPixelIndex(y, x, static_cast(fGrey));
+}
+}
+}
+}
+
 void AlphaMask::ReleaseAccess( BitmapReadAccess* pAccess )
 {
 if( pAccess )
commit 2cfe93da835eb500c9a170d22fce19fbd1de9473
Author: Mike Kaganski 
AuthorDate: Thu May 28 12:48:28 2020 +0300
Commit: Mike Kaganski 
CommitDate: Fri May 29 06:23:37 2020 +0200

tdf#49247, tdf#101181: don't rely on automatic scaling of alpha mask

Scale it back explicitly in ProcessAndBlurAlphaMask

Change-Id: I8e8a58c117d8b59db40b416edadc559b47dc300a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95021
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 32afe33e6147..9e44ef292d34 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -917,18 +917,17 @@ void 
VclPixelProcessor2D::processMetaFilePrimitive2D(const primitive2d::BasePrim
 
 namespace
 {
-/* Returns 8-bit alpha mask created from passed mask. The result may be scaled 
down; it's
-   expected that it will be automatically scaled up back when applied to the 
bitmap.
+/* Returns 8-bit alpha mask created from passed mask.
 
Negative fErodeDilateRadius values mean erode, positive - dilate.
nTransparency defines minimal transparency level.
 */
-AlphaMask ProcessAndBlurAlphaMask(const Bitmap& rBWMask, double 
fErodeDilateRadius,
+AlphaMask ProcessAndBlurAlphaMask(const Bitmap& rMask, double 
fErodeDilateRadius,
   double fBlurRadius, sal_uInt8 nTransparency)
 {
 // Only completely white pixels on the initial mask must be considered for 
transparency. Any
 // other color must be treated as black. This creates 1-bit B bitmap.
-BitmapEx mask(rBWMask.CreateMask(COL_WHITE));
+BitmapEx mask(rMask.CreateMask(COL_WHITE));
 
 // Scaling down increases performance without noticeable quality loss. 
Additionally,
 // current blur implementation can only handle blur radius between 2 and 
254.
@@ -963,6 +962,8 @@ AlphaMask ProcessAndBlurAlphaMask(const Bitmap& rBWMask, 
double fErodeDilateRadi
 // calculate blurry effect
 BitmapFilter::Filter(mask, BitmapFilterStackBlur(fBlurRadius));
 
+mask.Scale(rMask.GetSizePixel());
+
 return 

[Libreoffice-bugs] [Bug 127779] Problem with conversion in the worksheet

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127779

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128474] PC crashed with Draw

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128474

--- Comment #3 from QA Administrators  ---
Dear Patrick,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133015] FILEOPEN PPTX: text box gets displaced by text coming from master page (which Office 365 does not show)

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133015

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133276] Wrong characters formatting (kerning) after odt file opened in LO 6.4.3.2 Writer

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133276

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132669] Background-graphic/-colour disappears when I move a text box

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132669

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127841] LibreOffice version 6.3.2.2

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127841

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133019] LibreOffice crashes when pressing Run Macro (without JRE installed).

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133019

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132821] PDF Sign is not working in Kubuntu and Windows

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132821

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133276] Wrong characters formatting (kerning) after odt file opened in LO 6.4.3.2 Writer

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133276

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127841] LibreOffice version 6.3.2.2

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127841

--- Comment #6 from QA Administrators  ---
Dear Ivan Ratoyevsky,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121919] Basic Runtime Error 423

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121919

--- Comment #18 from QA Administrators  ---
Dear Tony Donnelly,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127844] CRASH: Adding chart hangs when selecting entire column as data range

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127844

--- Comment #4 from QA Administrators  ---
Dear matthew,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 128474] PC crashed with Draw

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128474

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132821] PDF Sign is not working in Kubuntu and Windows

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132821

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127779] Problem with conversion in the worksheet

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127779

--- Comment #6 from QA Administrators  ---
Dear Marek Verey,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120996] When a comment pop up, the first time is ok but next the background is transparent and difficults to read

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120996

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127730] .tmp files are being created in the document's own folder, not in the directory specified in "options/Paths"

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127730

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127844] CRASH: Adding chart hangs when selecting entire column as data range

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127844

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121919] Basic Runtime Error 423

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121919

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 127730] .tmp files are being created in the document's own folder, not in the directory specified in "options/Paths"

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127730

--- Comment #6 from QA Administrators  ---
Dear peter josvai,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108908
Bug 108908 depends on bug 121919, which changed state.

Bug 121919 Summary: Basic Runtime Error 423
https://bugs.documentfoundation.org/show_bug.cgi?id=121919

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129112] "Format -> Conditional -> Manage" dialog not usable

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129112

--- Comment #3 from QA Administrators  ---
Dear AHX2323,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129089] Using LibreOffice Writer version 6.3.3 I can modify all of the styles except those pertaining to the footnotes with an imported document.

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129089

--- Comment #3 from QA Administrators  ---
Dear Pen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120996] When a comment pop up, the first time is ok but next the background is transparent and difficults to read

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120996

--- Comment #16 from QA Administrators  ---
Dear David,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 684a0d2ef43d17a2e939ec021caf6519a40c0cce
Author: Henry Castro 
AuthorDate: Wed May 27 11:31:03 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 04:22:50 2020 +0200

loleaflet: makefile: replace ENABLE_DEBUG var

Now, it does not depend on ./configure script
it is configurable to set BUNDLE=DEBUG or RELEASE (i.e. Android platform)

Change-Id: Id43f156a05ea22f74334e7fdbe60d53b8b5a2891
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94982
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 4f6c29a19..47fd0c4c5 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -2,6 +2,8 @@ MAKEFLAGS = --no-builtin-rules
 CTAGS = ctags
 
 L10N_PO = $(wildcard $(srcdir)/po/*.po)
+BUNDLE ?= $(if $(filter true,$(ENABLE_DEBUG)),DEBUG,RELEASE)
+IS_DEBUG = $(if $(filter DEBUG,$(BUNDLE)),true,)
 
 if ENABLE_ANDROIDAPP
 DIST_FOLDER = $(abs_top_srcdir)/android/lib/src/main/assets/dist
@@ -141,7 +143,7 @@ LOLEAFLET_CSS_M4 = $(strip $(foreach 
file,$(LOLEAFLET_CSS),$(notdir $(file
 $(eval $(call file_targets,$(LOLEAFLET_CSS)))
 
 NODE_MODULES_JS =\
-   $(if $(filter 
true,$(ENABLE_DEBUG)),node_modules/hammerjs/hammer.js,node_modules/hammerjs/hammer.min.js)
 \
+   $(if 
$(IS_DEBUG),node_modules/hammerjs/hammer.js,node_modules/hammerjs/hammer.min.js)
 \
node_modules/jquery/dist/jquery.js \
node_modules/jquery-mousewheel/jquery.mousewheel.js \
node_modules/jquery-contextmenu/dist/jquery.contextMenu.js \
@@ -326,8 +328,6 @@ INTERMEDIATE_DIR ?= $(abs_builddir)/build
 
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
-BUNDLE ?= $(if $(filter true,$(ENABLE_DEBUG)),DEBUG,RELEASE)
-
 define bundle_loleaflet
$(if $(filter DEBUG,$(1)),\
@touch $@,
@@ -414,7 +414,7 @@ endif
 
 $(DIST_FOLDER)/admin-bundle.js: $(LOLEAFLET_ADMIN_DST) \
$(INTERMEDIATE_DIR)/admin-src.js
-   @NODE_PATH=$(abs_builddir)/node_modules:$(INTERMEDIATE_DIR) $(NODE) 
node_modules/browserify/bin/cmd.js -g browserify-css $(if $(filter 
true,$(ENABLE_DEBUG)),--debug,-g uglifyify) -o $@ $(srcdir)/admin/main-admin.js
+   @NODE_PATH=$(abs_builddir)/node_modules:$(INTERMEDIATE_DIR) $(NODE) 
node_modules/browserify/bin/cmd.js -g browserify-css $(if 
$(IS_DEBUG),--debug,-g uglifyify) -o $@ $(srcdir)/admin/main-admin.js
 
 $(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
@mkdir -p $(dir $@)
@@ -448,7 +448,7 @@ $(DIST_FOLDER)/loleaflet.html: 
$(srcdir)/html/loleaflet.html.m4 \
$(DIST_FOLDER)/global.js \
$(DIST_FOLDER)/bundle.js
@echo "Generating loleaflet.html..."
-   @m4 -PE -DDEBUG=$(ENABLE_DEBUG) \
+   @m4 -PE -DDEBUG=$(IS_DEBUG) \
-DIOSAPP=$(ENABLE_IOSAPP) \
-DGTKAPP=$(ENABLE_GTKAPP) \
-DANDROIDAPP=$(ENABLE_ANDROIDAPP) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   28 ++--
 1 file changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 9b0fd0d7c48fb676a1bc50c307fed28a2cf135fb
Author: Henry Castro 
AuthorDate: Thu May 28 12:08:06 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 04:23:06 2020 +0200

loleaflet: makefile: simplify IS_DEBUG var

Change-Id: I5322d9308f63fb0e501aa883cfbe3cfd7c4fb663
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95062
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 47fd0c4c5..5d96e3940 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -329,7 +329,7 @@ INTERMEDIATE_DIR ?= $(abs_builddir)/build
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
 define bundle_loleaflet
-   $(if $(filter DEBUG,$(1)),\
+   $(if $(IS_DEBUG),\
@touch $@,
@m4 -PE -DIOSAPP=$(ENABLE_IOSAPP) \
-DGTKAPP=$(ENABLE_GTKAPP) \
@@ -342,22 +342,22 @@ define bundle_loleaflet
 endef
 
 define prereq_loleaflet
-   $(if $(filter DEBUG,$(1)),$(LOLEAFLET_JS_DST),$(LOLEAFLET_JS_SRC))
+   $(if $(IS_DEBUG),$(LOLEAFLET_JS_DST),$(LOLEAFLET_JS_SRC))
 endef
 
 define bundle_css
-   $(if $(filter DEBUG,$(1)),\
+   $(if $(IS_DEBUG),\
@touch $@,\
@echo "Uglify loleaflet css files..."
@$(NODE) node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@)
 endef
 
 define prereq_css
-   $(if $(filter DEBUG,$(1)),$(LOLEAFLET_CSS_DST),$(LOLEAFLET_CSS))
+   $(if $(IS_DEBUG),$(LOLEAFLET_CSS_DST),$(LOLEAFLET_CSS))
 endef
 
 define bundle_all
-   $(if $(filter DEBUG,$(1)),\
+   $(if $(IS_DEBUG),\
@touch $@,\
@echo "Uglify loleaflet js files..."
@m4 -PE -DL10N_IOS_ALL_JS=$(L10N_IOS_ALL_JS) \
@@ -371,12 +371,12 @@ define bundle_all
 endef
 
 define prereq_all
-   $(if $(filter DEBUG,$(1)),$(NODE_MODULES_JS_DST) 
$(LOLEAFLET_LIBS_JS_DST),\
+   $(if $(IS_DEBUG),$(NODE_MODULES_JS_DST) $(LOLEAFLET_LIBS_JS_DST),\
$(NODE_MODULES_JS_SRC) $(LOLEAFLET_LIBS_JS_SRC))
 endef
 
 define global_file
-   $(if $(filter DEBUG,$(1)),
+   $(if $(IS_DEBUG),
@cp $< $@,
@echo "Uglify global.js file..."
@$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@)
@@ -422,25 +422,25 @@ $(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/admin/src 
--ignore-path $(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@awk 'FNR == 1 {print ""} 1' $(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_ADMIN_JS)) > $@
 
-$(INTERMEDIATE_DIR)/loleaflet-src.js: $(call prereq_loleaflet,$(BUNDLE))
+$(INTERMEDIATE_DIR)/loleaflet-src.js: $(call prereq_loleaflet)
@mkdir -p $(dir $@)
$(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
@echo "Checking for loleaflet JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
-   $(call bundle_loleaflet($(BUNDLE)))
+   $(call bundle_loleaflet)
 
-$(DIST_FOLDER)/bundle.css: $(call prereq_css,$(BUNDLE))
+$(DIST_FOLDER)/bundle.css: $(call prereq_css)
@mkdir -p $(dir $@)
-   $(call bundle_css,$(BUNDLE))
+   $(call bundle_css)
 
-$(DIST_FOLDER)/bundle.js: $(INTERMEDIATE_DIR)/loleaflet-src.js $(call 
prereq_all,$(BUNDLE))
+$(DIST_FOLDER)/bundle.js: $(INTERMEDIATE_DIR)/loleaflet-src.js $(call 
prereq_all)
@mkdir -p $(dir $@)
-   $(call bundle_all,$(BUNDLE))
+   $(call bundle_all)
 
 $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
@mkdir -p $(dir $@)
-   $(call global_file,$(BUNDLE))
+   $(call global_file)
 
 $(DIST_FOLDER)/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 \
$(LOLEAFLET_HTML_DST) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f511d7d6756cb50a55dd77444ed3123cd9958081
Author: Henry Castro 
AuthorDate: Wed May 27 11:00:13 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 04:22:11 2020 +0200

loleaflet: makefile: update PHONY targets

Change-Id: I3201c3f155aae597871f682686a8acdba47ae8a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94979
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 6bf27c77e..44765b243 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -382,6 +382,8 @@ define global_file
@$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@)
 endef
 
+.PHONY: build-loleaflet
+
 all-local: build-loleaflet
 
 if !ENABLE_MOBILEAPP
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: .gitignore loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 .gitignore|2 +-
 loleaflet/Makefile.am |5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit bd298d037bdba2a564f427746a0e691ed1a11239
Author: Henry Castro 
AuthorDate: Wed May 27 11:16:08 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 04:22:33 2020 +0200

loleaflet: makefile: set default INTERMEDIATE_DIR var

and configurable.

Change-Id: I4f1b111e1f9ce4e8c9e0b13755dce04f99672e1e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94981
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/.gitignore b/.gitignore
index 0fc2cab91..4537a7669 100644
--- a/.gitignore
+++ b/.gitignore
@@ -56,7 +56,7 @@ loolwsd.log
 *.mo
 
 # loleaflet
-loleaflet/build/dist
+loleaflet/build
 loleaflet/dist
 loleaflet/npm-shrinkwrap.json
 loleaflet/jsconfig.json
diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 44765b243..4f6c29a19 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -322,7 +322,7 @@ COMMA := ,
 EMPTY :=
 SPACE := $(EMPTY) $(EMPTY)
 LOLEAFLET_VERSION = $(shell cd $(srcdir) && git log -1 --pretty=format:"%h")
-INTERMEDIATE_DIR := $(if $(filter 
true,$(ENABLE_DEBUG)),$(abs_builddir),$(abs_builddir)/build)
+INTERMEDIATE_DIR ?= $(abs_builddir)/build
 
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
@@ -417,6 +417,7 @@ $(DIST_FOLDER)/admin-bundle.js: $(LOLEAFLET_ADMIN_DST) \
@NODE_PATH=$(abs_builddir)/node_modules:$(INTERMEDIATE_DIR) $(NODE) 
node_modules/browserify/bin/cmd.js -g browserify-css $(if $(filter 
true,$(ENABLE_DEBUG)),--debug,-g uglifyify) -o $@ $(srcdir)/admin/main-admin.js
 
 $(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
+   @mkdir -p $(dir $@)
@echo "Checking for admin JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/admin/src 
--ignore-path $(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@awk 'FNR == 1 {print ""} 1' $(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_ADMIN_JS)) > $@
@@ -638,7 +639,7 @@ l10n: pot
 
 clean-local:
@rm -rf $(DIST_FOLDER)
-   @rm -rf $(builddir)/build/dist
+   @rm -rf $(INTERMEDIATE_DIR)
@rm -f $(abs_srcdir)/jsconfig.json
@rm -f $(abs_srcdir)/admin/jsconfig.json
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 15d4d3156d62a5f6114d519a0b2c7660fa0bbc0b
Author: Henry Castro 
AuthorDate: Wed May 27 10:08:16 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 03:56:08 2020 +0200

loleaflet: makefile: move the command to check UNO commands

Change-Id: Ic841b0de22d3e62779fe0c112a33c942ba87b160
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94977
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index ef34d4c5d..6bf27c77e 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -383,7 +383,6 @@ define global_file
 endef
 
 all-local: build-loleaflet
-   $(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
 
 if !ENABLE_MOBILEAPP
 ADMIN_BUNDLE = $(DIST_FOLDER)/admin-bundle.js
@@ -422,6 +421,7 @@ $(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
 
 $(INTERMEDIATE_DIR)/loleaflet-src.js: $(call prereq_loleaflet,$(BUNDLE))
@mkdir -p $(dir $@)
+   $(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
@echo "Checking for loleaflet JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133488] New: The latest update 6.3.6.2 has completely ruined my spreadsheets

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133488

Bug ID: 133488
   Summary: The latest update 6.3.6.2 has completely ruined my
spreadsheets
   Product: LibreOffice
   Version: 6.3.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: boblampar...@gmail.com

Description:
Font changed, dates just a jumble of ###, bit of a mess really

Actual Results:
Simply open the calc spreadsheet

Expected Results:
Nothing


Reproducible: Always


User Profile Reset: No



Additional Info:
Worked!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8f9eea9e7ac425d6c7a2130114b0c875a3b9085d
Author: Henry Castro 
AuthorDate: Wed May 27 09:54:06 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 03:30:18 2020 +0200

loleaflet: makefile: remove old depecrated expansion

I probably forgot to remove it

Change-Id: I0183605fdf07235a7e3d61e91893133690feb074
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94974
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 157705865..ef34d4c5d 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -454,7 +454,7 @@ $(DIST_FOLDER)/loleaflet.html: 
$(srcdir)/html/loleaflet.html.m4 \
-DGLOBAL_JS="$(DIST_FOLDER)/global.js" \
-DLOLEAFLET_JS="$(subst $(SPACE),$(COMMA),$(NODE_MODULES_JS) \
$(LOLEAFLET_LIBS_JS) \
-   $(call LOLEAFLET_JS,$(srcdir)/build/build.js))" \
+   $(LOLEAFLET_JS))" \
-DVENDOR="$(VENDOR)" \
$(srcdir)/html/loleaflet.html.m4 > $@
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 5abf8900ddce81910cdf349d9d21a5cc940f23aa
Author: Henry Castro 
AuthorDate: Tue May 26 20:17:22 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 03:12:01 2020 +0200

loleaflet: makefile: simplify global file rule

Change-Id: I9c9bf7fa48f8c9dcd318195235cb99e407215543
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94913
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index b085eab02..157705865 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -375,6 +375,13 @@ define prereq_all
$(NODE_MODULES_JS_SRC) $(LOLEAFLET_LIBS_JS_SRC))
 endef
 
+define global_file
+   $(if $(filter DEBUG,$(1)),
+   @cp $< $@,
+   @echo "Uglify global.js file..."
+   @$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@)
+endef
+
 all-local: build-loleaflet
$(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
 
@@ -428,12 +435,9 @@ $(DIST_FOLDER)/bundle.js: 
$(INTERMEDIATE_DIR)/loleaflet-src.js $(call prereq_all
@mkdir -p $(dir $@)
$(call bundle_all,$(BUNDLE))
 
-if ENABLE_DEBUG
-else
 $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
-   @echo "Uglify global.js file..."
-   @$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@
-endif
+   @mkdir -p $(dir $@)
+   $(call global_file,$(BUNDLE))
 
 $(DIST_FOLDER)/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 \
$(LOLEAFLET_HTML_DST) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   40 +++-
 1 file changed, 23 insertions(+), 17 deletions(-)

New commits:
commit 942fce4ea59ffc1d541515f27b93384da67cf6c7
Author: Henry Castro 
AuthorDate: Tue May 26 19:28:52 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 02:39:13 2020 +0200

loleaflet: makefile: simplify rule bundle.js

Change-Id: I805b3a46a5864ca31e22ab685d6749c748255372
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94912
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 20f14bc8c..b085eab02 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -356,6 +356,25 @@ define prereq_css
$(if $(filter DEBUG,$(1)),$(LOLEAFLET_CSS_DST),$(LOLEAFLET_CSS))
 endef
 
+define bundle_all
+   $(if $(filter DEBUG,$(1)),\
+   @touch $@,\
+   @echo "Uglify loleaflet js files..."
+   @m4 -PE -DL10N_IOS_ALL_JS=$(L10N_IOS_ALL_JS) \
+   -DNODE_MODULES_JS=$(subst 
$(SPACE),$(COMMA),$(NODE_MODULES_JS)) \
+   -DLOLEAFLET_LIBS_JS=$(subst 
$(SPACE),$(COMMA),$(LOLEAFLET_LIBS_JS_SRC)) \
+   -DLOLEAFLET_JS=$(INTERMEDIATE_DIR)/loleaflet-src.js \
+   $(srcdir)/bundle.js.m4 > $(INTERMEDIATE_DIR)/bundle.js
+   @$(NODE) node_modules/uglify-js/bin/uglifyjs \
+   $(INTERMEDIATE_DIR)/bundle.js \
+   --output $@)
+endef
+
+define prereq_all
+   $(if $(filter DEBUG,$(1)),$(NODE_MODULES_JS_DST) 
$(LOLEAFLET_LIBS_JS_DST),\
+   $(NODE_MODULES_JS_SRC) $(LOLEAFLET_LIBS_JS_SRC))
+endef
+
 all-local: build-loleaflet
$(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
 
@@ -405,28 +424,15 @@ $(DIST_FOLDER)/bundle.css: $(call prereq_css,$(BUNDLE))
@mkdir -p $(dir $@)
$(call bundle_css,$(BUNDLE))
 
+$(DIST_FOLDER)/bundle.js: $(INTERMEDIATE_DIR)/loleaflet-src.js $(call 
prereq_all,$(BUNDLE))
+   @mkdir -p $(dir $@)
+   $(call bundle_all,$(BUNDLE))
+
 if ENABLE_DEBUG
-$(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_DST) \
-   $(INTERMEDIATE_DIR)/loleaflet-src.js \
-   $(LOLEAFLET_LIBS_JS_DST)
-   @touch $@
 else
 $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
@echo "Uglify global.js file..."
@$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@
-
-$(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_SRC) \
-   $(INTERMEDIATE_DIR)/loleaflet-src.js \
-   $(LOLEAFLET_LIBS_JS_SRC)
-   @echo "Uglify loleaflet js files..."
-   @m4 -PE -DL10N_IOS_ALL_JS=$(L10N_IOS_ALL_JS) \
-   -DNODE_MODULES_JS=$(subst $(SPACE),$(COMMA),$(NODE_MODULES_JS)) 
\
-   -DLOLEAFLET_LIBS_JS=$(subst 
$(SPACE),$(COMMA),$(LOLEAFLET_LIBS_JS_SRC)) \
-   -DLOLEAFLET_JS=$(builddir)/build/dist/loleaflet-src.js \
-   $(srcdir)/bundle.js.m4 > $(INTERMEDIATE_DIR)/bundle.js
-   $(NODE) node_modules/uglify-js/bin/uglifyjs \
-   $(INTERMEDIATE_DIR)/bundle.js \
-   --output $@
 endif
 
 $(DIST_FOLDER)/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   23 ---
 1 file changed, 16 insertions(+), 7 deletions(-)

New commits:
commit b86f226bec4455889c83ea5c015a921f1be8c177
Author: Henry Castro 
AuthorDate: Tue May 26 18:00:51 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 02:15:22 2020 +0200

loleaflet: makefile: simplify bundling CSS

So it can be flexible to bundle Debug or Release

Change-Id: I02bb653d7ead2e3d2e72bca8911efe2573885af4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94910
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index c91e19cc7..20f14bc8c 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -58,6 +58,7 @@ LOLEAFLET_ADMIN_DST = $(patsubst 
$(srcdir)/admin/%,$(DIST_FOLDER)/admin/%,$(LOLE
 
 define file_target
 $(1): $(2)
+   @mkdir -p $$(dir $$@)
@if test -z '$(ENABLE_BROWSERSYNC)'; then \
`cp $$< $$@`; \
else \
@@ -344,6 +345,17 @@ define prereq_loleaflet
$(if $(filter DEBUG,$(1)),$(LOLEAFLET_JS_DST),$(LOLEAFLET_JS_SRC))
 endef
 
+define bundle_css
+   $(if $(filter DEBUG,$(1)),\
+   @touch $@,\
+   @echo "Uglify loleaflet css files..."
+   @$(NODE) node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@)
+endef
+
+define prereq_css
+   $(if $(filter DEBUG,$(1)),$(LOLEAFLET_CSS_DST),$(LOLEAFLET_CSS))
+endef
+
 all-local: build-loleaflet
$(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
 
@@ -389,19 +401,16 @@ $(INTERMEDIATE_DIR)/loleaflet-src.js: $(call 
prereq_loleaflet,$(BUNDLE))
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
$(call bundle_loleaflet($(BUNDLE)))
 
-if ENABLE_DEBUG
-$(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS_DST)
-   @touch $@
+$(DIST_FOLDER)/bundle.css: $(call prereq_css,$(BUNDLE))
+   @mkdir -p $(dir $@)
+   $(call bundle_css,$(BUNDLE))
 
+if ENABLE_DEBUG
 $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_DST) \
$(INTERMEDIATE_DIR)/loleaflet-src.js \
$(LOLEAFLET_LIBS_JS_DST)
@touch $@
 else
-$(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS)
-   @echo "Uglify loleaflet css files..."
-   @$(NODE) node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@
-
 $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
@echo "Uglify global.js file..."
@$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 103474] FORMATTING: bracket shape not shown correctly

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103474

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3475

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133475] FILEOPEN PPTX Brace shape appears distorted

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133475

Aron Budea  changed:

   What|Removed |Added

Version|Inherited From OOo  |3.5.0 release
   Keywords||bibisected, filter:pptx,
   ||regression
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3474
 CC||ba...@caesar.elte.hu
 Blocks||108226

--- Comment #3 from Aron Budea  ---
This bug is actually a regression, and not present in 3.3.0 (version was set to
Inherited from OOo). It's also similar to bug 103474, and started in the same
range:

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=e5f71ca7c27259360a401d94ed6a53038608b941..73ec894e0d5aea6f8462c2e42d064c317d4a82ec
(at the newer state of this range the two endpoints are connected, and the
shape forms a triagle, this changed afterwards, but before 3.6.0.4, which shows
the current state)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Aron Budea  changed:

   What|Removed |Added

 Depends on||133475


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133475
[Bug 133475] FILEOPEN PPTX Brace shape appears distorted
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108198] [META] ODF export is unsuitable or invalid XML

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108198

Regina Henschel  changed:

   What|Removed |Added

 Depends on||133487


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133487
[Bug 133487] z-index wrong for shape with style:run-through="background"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133487] z-index wrong for shape with style:run-through="background"

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133487

Regina Henschel  changed:

   What|Removed |Added

 Blocks||108198


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108198
[Bug 108198] [META] ODF export is unsuitable or invalid XML
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133487] New: z-index wrong for shape with style:run-through="background"

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133487

Bug ID: 133487
   Summary: z-index wrong for shape with
style:run-through="background"
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 161386
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161386=edit
Example with wrong z-index

Open attached document. You see a red triangle in background, then a blue
ellipse in the middle and a yellow rectangle in front. So for the z-index you
would expect
red index < blue index < yellow index. But when opening the file you will find
red (2), blue (0) and yellow (1).

For z-index ODF 1.3 says in 19.231, part 3 of the spec:
"The draw:z-index values increase from back to front."
And especially for the case style:run-through:
"For a shape on which the style:run-through 20.351 attribute with value
foreground is in effect, producers should not generate a draw:z-index value
that is smaller than the value of any draw:z-index on a shape on which the
style:run-through attribute with value background is in effect."

Because negative values are not allowed, the z-index values should be
red(0), blue(1), yellow(2), for example.

The ODF 1.2 spec had not such clear rules, but only states "The draw:z-index
attribute defines a rendering order for shapes in a document instance."
It becomes more precise in ODF 1.3 with issue
https://issues.oasis-open.org/browse/OFFICE-2122. The implementation in LO 7.0
needs to be adapted for ODF 1.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 76898] It is not possible to reset the Standard Filter

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76898

--- Comment #17 from Rizal Muttaqin  ---
(In reply to Martin van Zijl from comment #16)
> Created attachment 161384 [details]
> Video demo of "remove" buttons for individual conditions.

Coool!! Will happy to see this patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   41 ++---
 1 file changed, 22 insertions(+), 19 deletions(-)

New commits:
commit 445ca4269a43497c792389a73e703adaf56ab0bf
Author: Henry Castro 
AuthorDate: Tue May 26 15:25:28 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 01:26:30 2020 +0200

loleaflet: makefile: simplify the rules for bundling loleaflet

So it can be flexible to bundle Debug or Release
and it can be used in other platform (i.e. Android)

Change-Id: Ia98abc0711c98b8f34654956534ce414f34dbdb4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94891
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 583198820..c91e19cc7 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -325,6 +325,25 @@ INTERMEDIATE_DIR := $(if $(filter 
true,$(ENABLE_DEBUG)),$(abs_builddir),$(abs_bu
 
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
+BUNDLE ?= $(if $(filter true,$(ENABLE_DEBUG)),DEBUG,RELEASE)
+
+define bundle_loleaflet
+   $(if $(filter DEBUG,$(1)),\
+   @touch $@,
+   @m4 -PE -DIOSAPP=$(ENABLE_IOSAPP) \
+   -DGTKAPP=$(ENABLE_GTKAPP) \
+   -DANDROIDAPP=$(ENABLE_ANDROIDAPP) \
+   -DMOBILEAPPNAME="$(APP_NAME)" \
+   -DVERSION=$(LOLEAFLET_VERSION) \
+   -DCOPYRIGHT=$(srcdir)/src/copyright.js \
+   -DLOLEAFLET_JS=$(subst $(SPACE),$(COMMA),$(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_JS))) \
+   $(srcdir)/loleaflet-src.js.m4 > $@)
+endef
+
+define prereq_loleaflet
+   $(if $(filter DEBUG,$(1)),$(LOLEAFLET_JS_DST),$(LOLEAFLET_JS_SRC))
+endef
+
 all-local: build-loleaflet
$(abs_top_srcdir)/scripts/unocommands.py --check $(abs_top_srcdir)
 
@@ -363,16 +382,14 @@ $(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/admin/src 
--ignore-path $(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@awk 'FNR == 1 {print ""} 1' $(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_ADMIN_JS)) > $@
 
-
-
-if ENABLE_DEBUG
-$(INTERMEDIATE_DIR)/loleaflet-src.js: $(LOLEAFLET_JS_DST)
+$(INTERMEDIATE_DIR)/loleaflet-src.js: $(call prereq_loleaflet,$(BUNDLE))
@mkdir -p $(dir $@)
@echo "Checking for loleaflet JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
-   @touch $@
+   $(call bundle_loleaflet($(BUNDLE)))
 
+if ENABLE_DEBUG
 $(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS_DST)
@touch $@
 
@@ -381,20 +398,6 @@ $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_DST) \
$(LOLEAFLET_LIBS_JS_DST)
@touch $@
 else
-$(INTERMEDIATE_DIR)/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
-   @mkdir -p $(dir $@)
-   @echo "Checking for loleaflet JS errors..."
-   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
-   $(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
-   @m4 -PE -DIOSAPP=$(ENABLE_IOSAPP) \
-   -DGTKAPP=$(ENABLE_GTKAPP) \
-   -DANDROIDAPP=$(ENABLE_ANDROIDAPP) \
-   -DMOBILEAPPNAME="$(APP_NAME)" \
-   -DVERSION=$(LOLEAFLET_VERSION) \
-   -DCOPYRIGHT=$(srcdir)/src/copyright.js \
-   -DLOLEAFLET_JS=$(subst $(SPACE),$(COMMA),$(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_JS))) \
-   $(srcdir)/loleaflet-src.js.m4 > $@
-
 $(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS)
@echo "Uglify loleaflet css files..."
@$(NODE) node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 96923] Criteria evaluation of COUNTIF, COUNTIFS, SUMIF, SUMIFS, AVERAGEIF, AVERAGEIFS

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96923

--- Comment #17 from kon...@gmx.com ---
Confirmed in LibreOffice 6.4.3.2.

See the attachment "Inconsistency between comparison order".

I get the following results:

1) If comparing a number to a number (2nd and 3rd argument to SUMIFS), we get a
match as expected.

2) If comparing a number to a string, we get a match.

3) If comparing a string to a number, we DON'T get a match.

4) If comparing a string to a number, but with an explicit equality operator
("="&) we get a match.

In Excel, all cases (1-4) result in a match. Because of the unexpected
inconsistency, I would say that this is indeed a bug, and that the Excel
behavior of having all four cases result in a match should be followed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96923] Criteria evaluation of COUNTIF, COUNTIFS, SUMIF, SUMIFS, AVERAGEIF, AVERAGEIFS

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96923

--- Comment #16 from kon...@gmx.com ---
Created attachment 161385
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161385=edit
Inconsistency between comparison order

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |1 -
 1 file changed, 1 deletion(-)

New commits:
commit eedf587d51d381d5851ac019079c055a4d50cdd2
Author: Henry Castro 
AuthorDate: Tue May 26 14:07:52 2020 -0400
Commit: Henry Castro 
CommitDate: Fri May 29 01:11:06 2020 +0200

loleaflet: makefile: remove unnecessary prerequisite

Change-Id: Ifaa47e323f66235f6a18a832e738c04ccc9ef95e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94884
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 9b5707c0f..583198820 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -338,7 +338,6 @@ build-loleaflet: $(LOLEAFLET_L10N_DST) \
$(LOLEAFLET_IMAGES_CUSTOM_DST) \
$(JQUERY_LIGHTNESS_DIST_IMAGES) \
$(JQUERY_MINIFIED_DIST_IMAGES) \
-   $(INTERMEDIATE_DIR)/loleaflet-src.js \
$(ADMIN_BUNDLE) \
$(DIST_FOLDER)/bundle.css \
$(DIST_FOLDER)/device-mobile.css \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133485] Append % percent sign also while entering a leading decimal separator in a percent formatted cell

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133485

Eike Rathke  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133486] New: FILESAVE Save or Save as fails when cell format was changed earlier

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133486

Bug ID: 133486
   Summary: FILESAVE Save or Save as fails when cell format was
changed earlier
   Product: LibreOffice
   Version: 7.0.0.0.alpha1+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stefan_lange...@t-online.de

(Only) the first attempt to save or "save as" (special) documents results in
error message "Error saving document xxx: Write error. The file could not be
written."(seen in german: "Fehler beim Speichern des Dokumentes xxx:
Schreibfehler. Die Datei konnte nicht geschrieben werden."). At further
attempts the error message is not displayed and the document is saved.

Reproduce the problem:
- New -> spreadsheet document
- enter something in cell A1
- select cell A1 and right click in the cell -> Format cells
- change horizontal alignment from "Standard" to "Left"
- save and close the document
- reopen the saved document
- try to save or "save as" the document (without any chhanges)
- error message "Error saving document xxx: Write error. ..." is displayed!

- click OK and try to save again -> document is saved without error message

The problem was reproduced with
version 7.0.0.0.beta1 (x64) (Build 94f789cbb5b4a511c319542c7bdc31ff3b3c)
and also with
version 7.1.0.0.apha0+ (x64) (Build 41d8b41767032681a9897b7551f011d450e3725e).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/cib_contract138c' - 2 commits - forms/source svx/source

2020-05-28 Thread Caolán McNamara (via logerrit)
 forms/source/xforms/submission.cxx|3 +++
 forms/source/xforms/submission/submission.hxx |6 ++
 svx/source/svdraw/svdograf.cxx|9 -
 3 files changed, 17 insertions(+), 1 deletion(-)

New commits:
commit cdad81ab69a54a6ed8895ae3a5cd3e78044dcce6
Author: Caolán McNamara 
AuthorDate: Mon May 11 20:46:43 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Thu May 28 23:29:05 2020 +0200

limit forms to http[s]

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93993
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 5d101a65c31e6c2f8dd0edffe05f69055cbd481c)

Conflicts:
forms/source/xforms/submission.cxx

Change-Id: I3ed0bc626f693ec03f610dc7361f93cad914c9d8

diff --git a/forms/source/xforms/submission.cxx 
b/forms/source/xforms/submission.cxx
index 08e04b8b2a33..d7bbf54678a0 100644
--- a/forms/source/xforms/submission.cxx
+++ b/forms/source/xforms/submission.cxx
@@ -256,6 +256,9 @@ bool Submission::doSubmit( const Reference< 
XInteractionHandler >& xHandler )
 }
 
 xSubmission->setEncoding(getEncoding());
+if (!xSubmission->IsWebProtocol())
+return false;
+
 CSubmission::SubmissionResult aResult = xSubmission->submit( xHandler );
 
 if (aResult == CSubmission::SUCCESS)
diff --git a/forms/source/xforms/submission/submission.hxx 
b/forms/source/xforms/submission/submission.hxx
index 7d726392c736..f93146d5923e 100644
--- a/forms/source/xforms/submission/submission.hxx
+++ b/forms/source/xforms/submission/submission.hxx
@@ -127,6 +127,12 @@ public:
 , m_xContext(::comphelper::getProcessComponentContext())
 {}
 
+bool IsWebProtocol() const
+{
+INetProtocol eProtocol = m_aURLObj.GetProtocol();
+return eProtocol == INetProtocol::Http || eProtocol == 
INetProtocol::Https;
+}
+
 virtual ~CSubmission() {}
 
 void setEncoding(const OUString& aEncoding)
commit c0e5a86f9c28cf334771bd5ba6ab5a48edead57c
Author: Caolán McNamara 
AuthorDate: Mon May 11 17:02:50 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Thu May 28 23:26:23 2020 +0200

use the LinkManager persist to determine the Referer

Change-Id: I4e93878972492a93af368ffa0560412132431a24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94061
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 3ee652e1c18186a5de47797aa4b02defcb29c210)

diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index 38e57ac81694..091a95425898 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -19,8 +19,10 @@
 
 #include 
 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -102,8 +104,13 @@ SdrGraphicLink::SdrGraphicLink(SdrGrafObj& rObj)
 {
 sfx2::LinkManager::GetDisplayNames( this, nullptr, 
, nullptr,  );
 
+OUString sReferer(getReferer());
+SfxObjectShell * sh = pLinkManager->GetPersist();
+if (sh != nullptr && sh->HasName())
+sReferer = sh->GetMedium()->GetName();
+
 Graphic aGraphic;
-if (sfx2::LinkManager::GetGraphicFromAny(rMimeType, rValue, 
getReferer(), aGraphic, nullptr))
+if (sfx2::LinkManager::GetGraphicFromAny(rMimeType, rValue, sReferer, 
aGraphic, nullptr))
 {
 rGrafObj.ImpSetLinkedGraphic(aGraphic);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133485] Append % percent sign also while entering a leading decimal separator in a percent formatted cell

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133485

Eike Rathke  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||er...@redhat.com
 OS|Windows (All)   |All
   Hardware|x86-64 (AMD64)  |All
Summary|A CALC cell formated as |Append % percent sign also
   |"percent" (-12.95%) returns |while entering a leading
   |wrong number.   |decimal separator in a
   ||percent formatted cell

--- Comment #1 from Eike Rathke  ---
Note that while entering 2 a percent sign is appended so the input is 2%
Also note that while entering .2 no percent sign is appended (because the input
does not start with a digit) so the result is correctly 20%, whereas while
entering 0.2 a percent sign is appended to form 0.2%
Same for .002 vs 0.002

One could argue that if a leading decimal separator is entered the percent sign
should also be appended, to cause less confusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

--- Comment #3 from Florian Rime  ---
Yes I try with a brand new file, it's the same problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

--- Comment #2 from Florian Rime  ---
Yes I try with a brand new file, it's the same problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sfx2/source vcl/osx

2020-05-28 Thread Stephan Bergmann (via logerrit)
 sfx2/source/appl/shutdowniconaqua.mm |2 +-
 vcl/osx/OSXTransferable.cxx  |4 +++-
 vcl/osx/a11ytextattributeswrapper.mm |2 +-
 vcl/osx/a11ywrapper.mm   |4 ++--
 vcl/osx/printaccessoryview.mm|5 +++--
 vcl/osx/salprn.cxx   |2 +-
 6 files changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 651844c9b122fd8463ad1dde4f9a0200efc345a3
Author: Stephan Bergmann 
AuthorDate: Thu May 28 19:07:57 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Thu May 28 23:11:00 2020 +0200

loplugin:sequenceloop (macOS)

Change-Id: Ie1f5c925a058ef79df3f5183051c87fa8d342fb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sfx2/source/appl/shutdowniconaqua.mm 
b/sfx2/source/appl/shutdowniconaqua.mm
index 78c89f33865c..3fa4d61443a0 100644
--- a/sfx2/source/appl/shutdowniconaqua.mm
+++ b/sfx2/source/appl/shutdowniconaqua.mm
@@ -189,7 +189,7 @@ class RecentFilesStringLength : public 
::cppu::WeakImplHelper< css::util::XStrin
 {
 for ( int i = 0; i < nPickListMenuItems; i++ )
 {
-css::uno::Sequence< css::beans::PropertyValue >& rPickListEntry = 
aHistoryList[i];
+css::uno::Sequence< css::beans::PropertyValue > const & 
rPickListEntry = aHistoryList[i];
 RecentMenuEntry aRecentFile;
 
 for ( const css::beans::PropertyValue& rProp : rPickListEntry )
diff --git a/vcl/osx/OSXTransferable.cxx b/vcl/osx/OSXTransferable.cxx
index 77417f3c29bb..92f997f90d34 100644
--- a/vcl/osx/OSXTransferable.cxx
+++ b/vcl/osx/OSXTransferable.cxx
@@ -19,6 +19,8 @@
 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -143,7 +145,7 @@ Sequence< DataFlavor > SAL_CALL 
OSXTransferable::getTransferDataFlavors(  )
 
 sal_Bool SAL_CALL OSXTransferable::isDataFlavorSupported(const DataFlavor& 
aFlavor)
 {
-for (const DataFlavor& rFlavor : mFlavorList)
+for (const DataFlavor& rFlavor : std::as_const(mFlavorList))
   if (compareDataFlavors(aFlavor, rFlavor))
 return true;
 
diff --git a/vcl/osx/a11ytextattributeswrapper.mm 
b/vcl/osx/a11ytextattributeswrapper.mm
index 433906d7d9b3..897514b559f7 100644
--- a/vcl/osx/a11ytextattributeswrapper.mm
+++ b/vcl/osx/a11ytextattributeswrapper.mm
@@ -192,7 +192,7 @@ using namespace ::com::sun::star::uno;
 }
 }
 
-+(void)applyAttributesFrom:(Sequence < PropertyValue >)attributes 
toString:(NSMutableAttributedString *)string forRange:(NSRange)range 
fontDescriptor:(AquaA11yFontDescriptor*)fontDescriptor {
++(void)applyAttributesFrom:(Sequence < PropertyValue > const &)attributes 
toString:(NSMutableAttributedString *)string forRange:(NSRange)range 
fontDescriptor:(AquaA11yFontDescriptor*)fontDescriptor {
 NSAutoreleasePool * pool = [ [ NSAutoreleasePool alloc ] init ];
 // constants
 static const OUString attrUnderline("CharUnderline");
diff --git a/vcl/osx/a11ywrapper.mm b/vcl/osx/a11ywrapper.mm
index d3a42058dca9..6ed9774c24a2 100644
--- a/vcl/osx/a11ywrapper.mm
+++ b/vcl/osx/a11ywrapper.mm
@@ -313,7 +313,7 @@ static std::ostream <<(std::ostream , NSObject 
*obj) {
 if ( mActsAsRadioGroup ) {
 NSMutableArray * children = [ [ NSMutableArray alloc ] init ];
 Reference < XAccessibleRelationSet > rxAccessibleRelationSet = [ self 
accessibleContext ] -> getAccessibleRelationSet();
-AccessibleRelation relationMemberOf = rxAccessibleRelationSet -> 
getRelationByType ( AccessibleRelationType::MEMBER_OF );
+AccessibleRelation const relationMemberOf = rxAccessibleRelationSet -> 
getRelationByType ( AccessibleRelationType::MEMBER_OF );
 if ( relationMemberOf.RelationType == 
AccessibleRelationType::MEMBER_OF && relationMemberOf.TargetSet.hasElements() ) 
{
 for ( const auto& i : relationMemberOf.TargetSet ) {
 Reference < XAccessible > rMateAccessible( i, UNO_QUERY );
@@ -1045,7 +1045,7 @@ static Reference < XAccessibleContext > hitTestRunner ( 
css::awt::Point point,
 Reference < XAccessibleRelationSet > relationSet = [ 
static_cast(element) accessibleContext ] -> 
getAccessibleRelationSet();
 if ( relationSet.is() && relationSet -> containsRelation ( 
AccessibleRelationType::SUB_WINDOW_OF )) {
 // we have a valid relation to the parent element
-AccessibleRelation relation = relationSet -> 
getRelationByType ( AccessibleRelationType::SUB_WINDOW_OF );
+AccessibleRelation const relation = relationSet -> 
getRelationByType ( AccessibleRelationType::SUB_WINDOW_OF );
 for ( const auto & i : relation.TargetSet ) {
 Reference < XAccessible > rxAccessible ( i, UNO_QUERY 
);
 if ( rxAccessible.is() && rxAccessible -> 
getAccessibleContext().is() ) {
diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm
index 

[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116280

Telesto  changed:

   What|Removed |Added

 Depends on||133340


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133340
[Bug 133340] Slow and choppy slides (with large GIF) after save (fine on file
opening) & slow save
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133351] Memory usage increased a lot with (large) animated gifs

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133351

Telesto  changed:

   What|Removed |Added

 Blocks||116280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116280
[Bug 116280] [META] Regressions introduced by the image handling refactoring
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Julien Nabet  ---
Do you reproduce this with a brand new file?
If no, could you attached an example file? (after having sanitized it - see
https://wiki.documentfoundation.org/QA/Bugzilla/Sanitizing_Files_Before_Submission
-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116280

Telesto  changed:

   What|Removed |Added

 Depends on||133351


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133351
[Bug 133351] Memory usage increased a lot with (large) animated gifs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133340] Slow and choppy slides (with large GIF) after save (fine on file opening) & slow save

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133340

Telesto  changed:

   What|Removed |Added

 Blocks||116280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116280
[Bug 116280] [META] Regressions introduced by the image handling refactoring
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 5c9020ac66bf4c815696e81df10a5ef3fa3149fe
Author: Henry Castro 
AuthorDate: Tue May 26 10:45:55 2020 -0400
Commit: Henry Castro 
CommitDate: Thu May 28 23:05:23 2020 +0200

loleaflet: makefile: rename LOLEAFLET_PREFIX var

In order to not confuse it is renamed to INTERMEDIATE_DIR

Change-Id: Iccdea0d77b17c3d4285b891b79a408a795328d13
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94873
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 50fb781b9..9b5707c0f 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -321,7 +321,7 @@ COMMA := ,
 EMPTY :=
 SPACE := $(EMPTY) $(EMPTY)
 LOLEAFLET_VERSION = $(shell cd $(srcdir) && git log -1 --pretty=format:"%h")
-LOLEAFLET_PREFIX := $(if $(filter 
true,$(ENABLE_DEBUG)),$(abs_builddir),$(abs_builddir)/build)
+INTERMEDIATE_DIR := $(if $(filter 
true,$(ENABLE_DEBUG)),$(abs_builddir),$(abs_builddir)/build)
 
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
@@ -338,7 +338,7 @@ build-loleaflet: $(LOLEAFLET_L10N_DST) \
$(LOLEAFLET_IMAGES_CUSTOM_DST) \
$(JQUERY_LIGHTNESS_DIST_IMAGES) \
$(JQUERY_MINIFIED_DIST_IMAGES) \
-   $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
+   $(INTERMEDIATE_DIR)/loleaflet-src.js \
$(ADMIN_BUNDLE) \
$(DIST_FOLDER)/bundle.css \
$(DIST_FOLDER)/device-mobile.css \
@@ -356,10 +356,10 @@ if ENABLE_ANDROIDAPP
 endif
 
 $(DIST_FOLDER)/admin-bundle.js: $(LOLEAFLET_ADMIN_DST) \
-   $(LOLEAFLET_PREFIX)/dist/admin-src.js
-   @NODE_PATH=$(abs_builddir)/node_modules:$(LOLEAFLET_PREFIX)/dist 
$(NODE) node_modules/browserify/bin/cmd.js -g browserify-css $(if $(filter 
true,$(ENABLE_DEBUG)),--debug,-g uglifyify) -o $@ $(srcdir)/admin/main-admin.js
+   $(INTERMEDIATE_DIR)/admin-src.js
+   @NODE_PATH=$(abs_builddir)/node_modules:$(INTERMEDIATE_DIR) $(NODE) 
node_modules/browserify/bin/cmd.js -g browserify-css $(if $(filter 
true,$(ENABLE_DEBUG)),--debug,-g uglifyify) -o $@ $(srcdir)/admin/main-admin.js
 
-$(LOLEAFLET_PREFIX)/dist/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
+$(INTERMEDIATE_DIR)/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
@echo "Checking for admin JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/admin/src 
--ignore-path $(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@awk 'FNR == 1 {print ""} 1' $(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_ADMIN_JS)) > $@
@@ -367,7 +367,7 @@ $(LOLEAFLET_PREFIX)/dist/admin-src.js: 
$(LOLEAFLET_ADMIN_ALL)
 
 
 if ENABLE_DEBUG
-$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_DST)
+$(INTERMEDIATE_DIR)/loleaflet-src.js: $(LOLEAFLET_JS_DST)
@mkdir -p $(dir $@)
@echo "Checking for loleaflet JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
@@ -378,11 +378,11 @@ $(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS_DST)
@touch $@
 
 $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_DST) \
-   $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
+   $(INTERMEDIATE_DIR)/loleaflet-src.js \
$(LOLEAFLET_LIBS_JS_DST)
@touch $@
 else
-$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
+$(INTERMEDIATE_DIR)/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
@mkdir -p $(dir $@)
@echo "Checking for loleaflet JS errors..."
@$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
@@ -405,16 +405,16 @@ $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
@$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@
 
 $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_SRC) \
-   $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
+   $(INTERMEDIATE_DIR)/loleaflet-src.js \
$(LOLEAFLET_LIBS_JS_SRC)
@echo "Uglify loleaflet js files..."
@m4 -PE -DL10N_IOS_ALL_JS=$(L10N_IOS_ALL_JS) \
-DNODE_MODULES_JS=$(subst $(SPACE),$(COMMA),$(NODE_MODULES_JS)) 
\
-DLOLEAFLET_LIBS_JS=$(subst 
$(SPACE),$(COMMA),$(LOLEAFLET_LIBS_JS_SRC)) \
-DLOLEAFLET_JS=$(builddir)/build/dist/loleaflet-src.js \
-   $(srcdir)/bundle.js.m4 > $(LOLEAFLET_PREFIX)/dist/bundle.js
+   $(srcdir)/bundle.js.m4 > $(INTERMEDIATE_DIR)/bundle.js
$(NODE) node_modules/uglify-js/bin/uglifyjs \
-   $(LOLEAFLET_PREFIX)/dist/bundle.js \
+   $(INTERMEDIATE_DIR)/bundle.js \
--output $@
 endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2020-05-28 Thread Olivier Hallot (via logerrit)
 source/text/simpress/guide/printing.xhp |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 912ac9dd36968cb60ddd9c2c1bdedfee8492d989
Author: Olivier Hallot 
AuthorDate: Thu May 28 17:58:41 2020 -0300
Commit: Olivier Hallot 
CommitDate: Thu May 28 23:01:18 2020 +0200

Adjust heading in page

Change-Id: I7c66bc49afe5f63acbe9b36fa7480a85045ea35e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95067
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/simpress/guide/printing.xhp 
b/source/text/simpress/guide/printing.xhp
index e1620ade0..6bf194ae6 100644
--- a/source/text/simpress/guide/printing.xhp
+++ b/source/text/simpress/guide/printing.xhp
@@ -37,15 +37,15 @@
   handout printing
   layout;printing handouts
 MW made "handouts;.." a one level entry and added 
"layout;..."
-Printing Presentations
-
-  Default printer settings
+Printing 
Presentations
+
+  Default printer settings
   
  
  To 
set the default printing options for $[officename] Impress, choose 
%PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME 
Impress - Print.
  
   
-  Setting printer options for the current presentation
+  Setting printer options for the current 
presentation
   
  
 Choose File - Print.
@@ -55,7 +55,7 @@
 These settings override the default printer options in 
%PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME 
Impress - Print for the current print job only.
  
   
-  Choosing a print layout for handouts
+  Choosing a print layout for handouts
   
  
 Choose File - Print.
@@ -67,7 +67,7 @@
 Select the number of slides to print per page of 
paper.
  
   
-  Defining print options for handouts
+  Defining print options for handouts
   
  
 Click the Handout tab.
@@ -87,7 +87,7 @@
 The 
fields in the master handout view on screen are not updated, but the text that 
you entered will be printed.
  
   
-  Printing handouts or notes
+  Printing handouts or notes
   
  
 Choose File - Print.
@@ -99,8 +99,8 @@
 Select Handouts or Notes and select 
the number of slides to print on each page of paper.
  
   
-  If you want 
another layout of the slides on the printed paper pages, use the mouse to move 
the slides around on the Handout view.
-  Printing a range of slides
+  If you want another layout of the slides on the 
printed paper pages, use the mouse to move the slides around on the Handout 
view.
+  Printing a range of slides
   
  
 Choose View - Slide Sorter.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2020-05-28 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1a3aa986f258233189895bb5a9f0f73eec64940c
Author: Olivier Hallot 
AuthorDate: Thu May 28 18:01:18 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Thu May 28 23:01:18 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 912ac9dd36968cb60ddd9c2c1bdedfee8492d989
  - Adjust heading in page

Change-Id: I7c66bc49afe5f63acbe9b36fa7480a85045ea35e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95067
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 184c50cd4da2..912ac9dd3696 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 184c50cd4da27926f185e1fc79f6e6fcd9a10cc6
+Subproject commit 912ac9dd36968cb60ddd9c2c1bdedfee8492d989
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133477] EDITING Gradient types Square and Quadratic have incorrect center

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133477

BogdanB  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1

--- Comment #5 from BogdanB  ---
Agree.
The angle should not change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132792] Crash in: mergedlo.dll

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132792

Telesto  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit da49edd7d16ac47ec89009f7c55ebfe579eb480c
Author: Henry Castro 
AuthorDate: Tue May 26 09:20:50 2020 -0400
Commit: Henry Castro 
CommitDate: Thu May 28 22:46:05 2020 +0200

loleaflet: makefile: remove duplicates prerequisites

Change-Id: I409225be5f69524105967d3a72466ff284afc724
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94866
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 827d97b59..50fb781b9 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -418,9 +418,11 @@ $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_SRC) \
--output $@
 endif
 
-$(DIST_FOLDER)/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 
$(LOLEAFLET_HTML_DST) $(LOLEAFLET_WELCOME_DST) $(DIST_FOLDER)/bundle.css 
$(DIST_FOLDER)/global.js \
-\
-   $(DIST_FOLDER)/bundle.css $(DIST_FOLDER)/bundle.js
+$(DIST_FOLDER)/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 \
+   $(LOLEAFLET_HTML_DST) \
+   $(DIST_FOLDER)/bundle.css \
+   $(DIST_FOLDER)/global.js \
+   $(DIST_FOLDER)/bundle.js
@echo "Generating loleaflet.html..."
@m4 -PE -DDEBUG=$(ENABLE_DEBUG) \
-DIOSAPP=$(ENABLE_IOSAPP) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - helpcontent2

2020-05-28 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 94c217984e456196047ce41096d4a6f05bf66382
Author: Olivier Hallot 
AuthorDate: Thu May 28 17:43:34 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Thu May 28 22:43:34 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-0'
  to ec1bf858a6efae449cf6c1bbf237e6cb1c358a26
  - tdf#132586 Add RAND.NV() and RANDBETWEEN.NV()

Change-Id: I181d4f7ce0ccca38339568c034754c40ef345026
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94724
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit 7e39048579d0049c19299c1e31a2878e21e218ec)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94967
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 9fe963cf3ca6..ec1bf858a6ef 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9fe963cf3ca64dbb5c4b57165ba7aac42d43ada8
+Subproject commit ec1bf858a6efae449cf6c1bbf237e6cb1c358a26
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Branch 'libreoffice-7-0' - source/text

2020-05-28 Thread Olivier Hallot (via logerrit)
 source/text/scalc/01/04060106.xhp |   55 --
 1 file changed, 47 insertions(+), 8 deletions(-)

New commits:
commit ec1bf858a6efae449cf6c1bbf237e6cb1c358a26
Author: Olivier Hallot 
AuthorDate: Sat May 23 11:34:25 2020 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu May 28 22:43:34 2020 +0200

tdf#132586 Add RAND.NV() and RANDBETWEEN.NV()

Change-Id: I181d4f7ce0ccca38339568c034754c40ef345026
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94724
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
(cherry picked from commit 7e39048579d0049c19299c1e31a2878e21e218ec)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94967
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/scalc/01/04060106.xhp 
b/source/text/scalc/01/04060106.xhp
index 36bde5f4d..a226f3637 100644
--- a/source/text/scalc/01/04060106.xhp
+++ b/source/text/scalc/01/04060106.xhp
@@ -413,14 +413,14 @@
 
 
 EXP
-Returns e raised to the power of a number. The 
constant e has a value of approximately 2.71828182845904.
+Returns e raised to the power of a 
number. The constant e has a value of approximately 
2.71828182845904.
 
 
 EXP(Number)
 Number is the power to which e is to be 
raised.
 
 
-=EXP(1) returns 2.71828182845904, the mathematical constant 
e to Calc's accuracy.see also POWER, LN
+=EXP(1) returns 2.71828182845904, the mathematical constant 
e to Calc's accuracy.see also POWER, 
LN
 
 
 
@@ -1504,8 +1504,8 @@
 
 
 
-  random numbers; between limits
-  RANDBETWEEN function
+random numbers; between limits
+RANDBETWEEN function
 
 mw changed "random numbers;"
 
@@ -1521,12 +1521,27 @@
 
 
 =RANDBETWEEN(20;30) returns an integer of between 20 and 
30.see also RAND
+
+
+random numbers non-volatile; between limits
+RANDBETWEEN.NV function
+
+
+RANDBETWEEN.NV
+Returns an non-volatile integer random number in 
a specified range.
+
+
+RANDBETWEEN.NV(Bottom; 
Top)
+Returns an non-volatile 
integer random number between integers Bottom and Top 
(both inclusive). A non-volatile function is not recalculated at new input 
events or pressing F9. However, the function is recalculated 
when pressing F9 with the cursor on the cell containing the 
function, when opening the file, and when Top or 
Bottom are recalculated.
+
+=RANDBETWEEN.NV(20;30) returns a 
non-volatile integer between 20 and 30.
+=RANDBETWEEN.NV(A1;30) returns a 
non-volatile integer between the value of cell A1 and 30. The function is 
recalculated when the contents of cell A1 change.
 
 
 
 
-  RAND function
-  random numbers;between 0 and 1
+RAND function
+random numbers;between 0 and 1
 
 mw added one entry
 
@@ -1537,10 +1552,34 @@
 
 RAND()
 This function 
produces a new random number each time Calc recalculates. To force Calc to 
recalculate manually press F9.
-To generate 
random numbers which never recalculate, copy cells each containing =RAND(), and 
use Edit - Paste Special (with Paste All and Formulas not 
marked and Numbers marked).
-
+To generate 
random numbers which never recalculate, either:
+
+
+Copy cells each 
containing =RAND(), and use Edit - Paste Special (with 
Paste All and Formulas not marked and 
Numbers marked).
+
+
+Use the Fill Cell 
command with random numbers (Sheet - Fill Cells - Fill Random 
Numbers).
+
+
+Use the RAND.NV() 
function for non-volatile random numbers.
+
+
 
 =RAND() returns a random number between 0 and 
1.see also RANDBETWEEN
+
+
+random numbers non-volatile;between 0 and 1
+RAND.NV function
+
+
+RAND.NV
+Returns a non-volatile random number between 0 and 
1.
+
+
+RAND.NV()
+This function produces 
a non-volatile random number on input. A non-volatile function is not 
recalculated at new input events. The function does not recalculate when 
pressing F9, except when the cursor is on the cell 
containing the function. The function is recalculated when opening the 
file.
+
+=RAND.NV() returns a non-volatile 
random number between 0 and 1.
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 198709f5edff61d52479e0c42c970dbe908aef71
Author: Henry Castro 
AuthorDate: Tue May 26 10:03:25 2020 -0400
Commit: Henry Castro 
CommitDate: Thu May 28 22:30:15 2020 +0200

loleaflet: makefile: remove order only prerequisites

This is no longer required, now node_modules is installed
before invoking "all" target

Change-Id: I720f1906f2f88b104d560a096f51344edebfab44
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94870
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 1a1f6ce13..827d97b59 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -332,7 +332,7 @@ if !ENABLE_MOBILEAPP
 ADMIN_BUNDLE = $(DIST_FOLDER)/admin-bundle.js
 endif
 
-build-loleaflet: | $(LOLEAFLET_L10N_DST) \
+build-loleaflet: $(LOLEAFLET_L10N_DST) \
$(L10N_JSON) \
$(LOLEAFLET_IMAGES_DST) \
$(LOLEAFLET_IMAGES_CUSTOM_DST) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/quartz

2020-05-28 Thread Stephan Bergmann (via logerrit)
 vcl/quartz/salbmp.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 2d13059635ecc8505023c052e29ed2bb164d6af4
Author: Stephan Bergmann 
AuthorDate: Thu May 28 19:13:46 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Thu May 28 22:25:54 2020 +0200

loplugin:simplifypointertobool (macOS)

Change-Id: Ie26580277fa6d0734b8af1eb029e0883a3c6f886
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95064
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index 2f6820b2877e..87861256be43 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -145,7 +145,7 @@ bool QuartzSalBitmap::Create( const SalBitmap& rSalBmp, 
sal_uInt16 nNewBitCount
 {
 const QuartzSalBitmap& rSourceBitmap = static_cast(rSalBmp);
 
-if (isValidBitCount(nNewBitCount) && rSourceBitmap.m_pUserBuffer.get())
+if (isValidBitCount(nNewBitCount) && rSourceBitmap.m_pUserBuffer)
 {
 mnBits = nNewBitCount;
 mnWidth = rSourceBitmap.mnWidth;
@@ -249,7 +249,7 @@ bool QuartzSalBitmap::CreateContext()
 }
 }
 
-if (m_pContextBuffer.get())
+if (m_pContextBuffer)
 {
 maGraphicContext.set(CGBitmapContextCreate(m_pContextBuffer.get(), 
mnWidth, mnHeight,
bitsPerComponent, 
nContextBytesPerRow,
@@ -695,7 +695,7 @@ static const BitmapPalette& GetDefaultPalette( int mnBits, 
bool bMonochrome )
 BitmapBuffer* QuartzSalBitmap::AcquireBuffer( BitmapAccessMode /*nMode*/ )
 {
 // TODO: AllocateUserData();
-if (!m_pUserBuffer.get())
+if (!m_pUserBuffer)
 return nullptr;
 
 BitmapBuffer* pBuffer = new BitmapBuffer;
@@ -843,7 +843,7 @@ CGImageRef QuartzSalBitmap::CreateColorMask( int nX, int 
nY, int nWidth,
  int nHeight, Color nMaskColor ) 
const
 {
 CGImageRef xMask = nullptr;
-if (m_pUserBuffer.get() && (nX + nWidth <= mnWidth) && (nY + nHeight <= 
mnHeight))
+if (m_pUserBuffer && (nX + nWidth <= mnWidth) && (nY + nHeight <= 
mnHeight))
 {
 const sal_uInt32 nDestBytesPerRow = nWidth << 2;
 std::unique_ptr pMaskBuffer(new (std::nothrow) 
sal_uInt32[ nHeight * nDestBytesPerRow / 4] );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133477] EDITING Gradient types Square and Quadratic have incorrect center

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133477

--- Comment #4 from Tomaz Vajngerl  ---
That would then mean it's a different bug and not that there is no bug,
wouldn't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


More information about hung Jenkins builds

2020-05-28 Thread Stephan Bergmann
Following up on the results of the email thread starting at 
 
"How are Jenkins builds killed exactly?", 
 
"kill-wrapper: pstree of hung processes" had tried to improve the 
information provided for a hung and aborted Jenkins build.  Typically, 
such a build is aborted because one or more tests hang, and it would be 
interesting to at least learn which tests hung.  To that end, that 
commit tried to print pstree output of any leftover processes---but 
failed, see the comment at 
 
"kill-wrapper: pstree of hung processes" for details.


Now, 
 
"Incorporate timeout-on-idle into kill-wrapper, renaming to 
timeout-kill-wrapper" and its follow-up 
 
"Simplify transition from old kill-wrapper to new timeout kill-wrapper" 
fix that, by moving the timeout handling from Jenkins into lode's 
bin/kill-wrapper.  (Which accepts an optional second argument now, 
specifying a stdout/-err inactivity timeout in seconds, after which the 
pstree output is generated and the process tree gets killed.  Leaving 
the argument out or specifying it as zero disables that timeout logic.)


For now, I have updated 
 to use the 
new kill-wrapper timeout feature instead of Jenkins' "Abort the build if 
it's stuck" option.  (And am planning to roll it out to other Linux 
Jenkins jobs that could benefit from it, once it has proven sufficiently 
stable.)


 is a 
live example of such an aborted Gerrit Jenkins job.  One noticeable 
difference is that such a job is now marked as failed (red dot) rather 
than as aborted (gray dot).  But a new "kill-wrapper" (i.e., 
) 
failure cause label should make the actual reason of the failure 
obvious.  And the pstree output 
(), 
while probably a bit overwhelming, should show that apparently all of 
UITest_calc_tests, UITest_calc_tests4, UITest_calc_tests7, UITest_chart, 
and UITest_demo_ui hung in this case.  That should give at least a hint 
where to start local debugging...


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 133440] Closing LibreOffice with some images on the clipboard takes a while and needs up to 2 GB ram

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133440

--- Comment #8 from Telesto  ---
The memory usage is less problematic with smaller images (didn't check that).
But the behavior is still noticeable with smaller ones.. 

And the copy to the clipboard is somehow broken to. Relaunching LibreOffice &
paste produces not the right results.. And that part did work quite well before

Anyway, thanks for responding so fast :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133440] Closing LibreOffice with some images on the clipboard takes a while and needs up to 2 GB ram

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133440

Telesto  changed:

   What|Removed |Added

   Keywords|regression  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |   16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

New commits:
commit 81ec172a1030df461dd9d210e32179217abe368b
Author: Henry Castro 
AuthorDate: Tue May 26 08:36:34 2020 -0400
Commit: Henry Castro 
CommitDate: Thu May 28 22:06:51 2020 +0200

loleaflet: makefile: simplify NODE_PATH var

Change-Id: I96a221f92aa2d3785cc6c83add84fc37680a6183
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/94860
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 00e77e662..1a1f6ce13 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -9,6 +9,8 @@ else
 DIST_FOLDER = $(builddir)/dist
 endif
 
+export NODE_PATH=$(abs_builddir)/node_module
+
 if !ENABLE_MOBILEAPP
 L10N_JSON = $(patsubst $(srcdir)/po/%.po,$(DIST_FOLDER)/l10n/%.json,$(L10N_PO))
 else
@@ -359,7 +361,7 @@ $(DIST_FOLDER)/admin-bundle.js: $(LOLEAFLET_ADMIN_DST) \
 
 $(LOLEAFLET_PREFIX)/dist/admin-src.js: $(LOLEAFLET_ADMIN_ALL)
@echo "Checking for admin JS errors..."
-   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/eslint/bin/eslint.js $(srcdir)/admin/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
+   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/admin/src 
--ignore-path $(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@awk 'FNR == 1 {print ""} 1' $(patsubst 
%.js,$(srcdir)/%.js,$(LOLEAFLET_ADMIN_JS)) > $@
 
 
@@ -368,7 +370,7 @@ if ENABLE_DEBUG
 $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_DST)
@mkdir -p $(dir $@)
@echo "Checking for loleaflet JS errors..."
-   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/eslint/bin/eslint.js $(srcdir)/src \
+   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
@touch $@
 
@@ -383,7 +385,7 @@ else
 $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
@mkdir -p $(dir $@)
@echo "Checking for loleaflet JS errors..."
-   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/eslint/bin/eslint.js $(srcdir)/src \
+   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src \
$(srcdir)/js --ignore-path $(srcdir)/.eslintignore --config 
$(srcdir)/.eslintrc
@m4 -PE -DIOSAPP=$(ENABLE_IOSAPP) \
-DGTKAPP=$(ENABLE_GTKAPP) \
@@ -396,11 +398,11 @@ $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: 
$(LOLEAFLET_JS_SRC)
 
 $(DIST_FOLDER)/bundle.css: $(LOLEAFLET_CSS)
@echo "Uglify loleaflet css files..."
-   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@
+   @$(NODE) node_modules/uglifycss/uglifycss $(LOLEAFLET_CSS) > $@
 
 $(DIST_FOLDER)/global.js: $(srcdir)/js/global.js
@echo "Uglify global.js file..."
-   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/uglify-js/bin/uglifyjs $< --output $@
+   @$(NODE) node_modules/uglify-js/bin/uglifyjs $< --output $@
 
 $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_SRC) \
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
@@ -411,7 +413,7 @@ $(DIST_FOLDER)/bundle.js: $(NODE_MODULES_JS_SRC) \
-DLOLEAFLET_LIBS_JS=$(subst 
$(SPACE),$(COMMA),$(LOLEAFLET_LIBS_JS_SRC)) \
-DLOLEAFLET_JS=$(builddir)/build/dist/loleaflet-src.js \
$(srcdir)/bundle.js.m4 > $(LOLEAFLET_PREFIX)/dist/bundle.js
-   NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/uglify-js/bin/uglifyjs \
+   $(NODE) node_modules/uglify-js/bin/uglifyjs \
$(LOLEAFLET_PREFIX)/dist/bundle.js \
--output $@
 endif
@@ -448,7 +450,7 @@ Makefile: $(srcdir)/Makefile.in 
$(top_builddir)/config.status node_modules
 $(DIST_FOLDER)/device-%.css: $(srcdir)/css/device-%.css
@mkdir -p $(dir $@)
@if test -z '$(ENABLE_BROWSERSYNC)'; then \
-   NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/uglifycss/uglifycss $< > $@ ; \
+   $(NODE) node_modules/uglifycss/uglifycss $< > $@ ; \
else \
ln -sf $(abs_srcdir)/$< $@ ; \
fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 133485] New: A CALC cell formated as "percent" (-12.95%) returns wrong number.

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133485

Bug ID: 133485
   Summary: A CALC cell formated as "percent" (-12.95%) returns
wrong number.
   Product: LibreOffice
   Version: 6.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dh...@compuserve.com

Description:
using LibreOffice Version: 6.4.4.2 (x64) Build ID:
3d775be2011f3886db32dfd395a6a6d1ca2630ff 
in which a cell formated as "percent" (-12.95%) returns wrong number. 
Entering a '2' results in showing 2%. 
Entering a '.2' results in showing 20% instead of 0.20% as expected.
If I enter '.002' the result shows 0.20% which appears to be the correct number
used in calculating the math.


Steps to Reproduce:
1. format cell "percent" (-12.95%)
2. enter '2' in this cell
3. view = 2%
4. enter '.2' in this cell
5. view = 20%
6. enter .002 in this cell
7. view = 0.20%

Actual Results:
explained above

Expected Results:
I would expect that entering '.2' would result in a view which would indicate
two-tenths of a percent, not twenty percent. This has been true for quite some
time and I have simply adjusted by entering the raw number indicating the
actual mathmatical number I need. Evidently whole numbers are all that are
calculated so '.2' would indeed be calculated as 20% even though it was meant
to be used as 2/10%.


Reproducible: Always


User Profile Reset: No



Additional Info:
If I enter '=.2/100' in the percent formatted cell I do get the proper view of
0.20%. Live and learn!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133440] Closing LibreOffice with some images on the clipboard takes a while and needs up to 2 GB ram

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133440

--- Comment #7 from Caolán McNamara  ---
I see that the images are 4000x2664 pixels in size. On the face of things I
wouldn't see it as a regression as such, seeing as saving the document without
its images isn't a state we want to revert to, nor is losing the clipboard
contents on exit. Though clearly it would be better to produce more optimized
output if that's possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133459] FILESAVE, FORMATTING: Date TextField in Header, Footer with user defind format is changed.

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133459

--- Comment #3 from Wolfgang Jäger  ---
(In reply to ajlittoz from comment #2)
> Maybe another AskLO question
> https://ask.libreoffice.org/en/question/246102/why-doesnt-writer-remember-my-
> custom-formatted-date-field/ could be affected by the same bug.

This was the ask.libreoffice question I had linked to anyway ("in pursuit
of..."). 
Why did you remove the keyword "regression"?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133484] New: Crash if I on click the header and footer bouton

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133484

Bug ID: 133484
   Summary: Crash if I on click the header and footer bouton
   Product: LibreOffice
   Version: 6.4.4.2 release
  Hardware: PowerPC
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: florianr...@bluewin.ch

Description:
The spreadsheet program Crash if I on click the header and footer bouton with
all the documents that I opened
than the overview or the main window

Actual Results:
open a document in spreadsheet program press on header and footer, is it Crash

Expected Results:
find a solution to work


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
LibreOffice_6.4.4_MacOS_x86-64_langpack_fr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 76898] It is not possible to reset the Standard Filter

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76898

Martin van Zijl  changed:

   What|Removed |Added

 Attachment #161384|Video demo of "remove"  |Video demo of "remove"
description|buttons for conditions. |buttons for individual
   ||conditions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 76898] It is not possible to reset the Standard Filter

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76898

Martin van Zijl  changed:

   What|Removed |Added

 Attachment #161311|0   |1
is obsolete||

--- Comment #16 from Martin van Zijl  ---
Created attachment 161384
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161384=edit
Video demo of "remove" buttons for conditions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 76898] It is not possible to reset the Standard Filter

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76898

--- Comment #15 from Martin van Zijl  ---
(In reply to Rizal Muttaqin from comment #14)
> (In reply to Heiko Tietze from comment #13)
> > (In reply to Martin van Zijl from comment #12)
> > > UX Team -- please take a look at this enhancement.
> > 
> > Awesome! Nitpicking: the button looks a bit squeezed. If you use a standard
> > image it might be better. Adding icon designers to get the right image.
> 
> We can use sc_delete.png/sc_delete.svg for this button.
> 
> Anything, your work is brilliant Martin!!

Thanks for the tip. I will use "sc_delete.png" for the button instead of "x". I
also added a tooltip that says "Remove". I've pushed the updated code to
Gerrit, and I'll update the video demo shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 133267] Undo inserting a row above extremely slow

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133267

Telesto  changed:

   What|Removed |Added

   Assignee|tele...@surfxs.nl   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133463] Much more memory usage while saving is much and a part tends do stick around

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133463

Telesto  changed:

   What|Removed |Added

 CC||zolnaitamas2...@gmail.com

--- Comment #4 from Telesto  ---
Adding CC to Zolnai Tamás

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133440] Closing LibreOffice with some images on the clipboard takes a while and needs up to 2 GB ram

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133440

Telesto  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #6 from Telesto  ---
Adding CC to Caolán McNamara

Note: it's probably Windows only

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/Makefile.am

2020-05-28 Thread Henry Castro (via logerrit)
 loleaflet/Makefile.am |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 7e83696158f7e21daf7d4ed8ba99a28cdcfd4e76
Author: Henry Castro 
AuthorDate: Thu May 28 11:27:32 2020 -0400
Commit: Henry Castro 
CommitDate: Thu May 28 21:48:51 2020 +0200

loleaflet: makefile: update Makefile rule

Change-Id: If52e0c1094e71cd52e665a0bbbdda2f4a9f0cd5f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95059
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 1959b1204..00e77e662 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -439,8 +439,10 @@ node_modules: package.json archived-packages
 
 Makefile: $(srcdir)/Makefile.in $(top_builddir)/config.status node_modules
@case '$?' in \
-*node_modules*) \
- touch Makefile;; \
+*config.status*) \
+ cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) am--refresh;; \
+*) \
+ cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@;; \
esac;
 
 $(DIST_FOLDER)/device-%.css: $(srcdir)/css/device-%.css
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2020-05-28 Thread Tor Lillqvist (via logerrit)
 sc/source/ui/view/gridwin.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit da68d45ff872cefb8606467c12aedece76a877d7
Author: Tor Lillqvist 
AuthorDate: Thu May 28 18:18:27 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Thu May 28 21:45:53 2020 +0200

tdf#128502: Remove one more assertion

See bda60c9b1ca6a0fbfde9f3428489f33729cc81f1.

Change-Id: If67f0696c56b0984dcfffdcf748d4f412874a64f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95061
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index e7ba202632a2..1de54e8f03e5 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -5939,7 +5939,6 @@ void ScGridWindow::UpdateKitSelection(const 
std::vector& rRect
 if (it == pViewShell)
 continue;
 auto pOther = dynamic_cast(it);
-assert(pOther);
 if (!pOther)
 return;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   4   >