[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/rtfexport/rtfexport4.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit f6d00c3fdc4a134aa67d4e51e6afc3df786bb67b
Author: Justin Luth
AuthorDate: Fri Sep 11 13:05:29 2020 +0300
Commit: Justin Luth
CommitDate: Sat Sep 12 07:47:00 2020 +0200
sw rtfexport: add explanation comments to unit test
Change-Id: I6b2579c6c92f0090fe7bee732ab6c8571272e9b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102454
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/rtfexport/rtfexport4.cxx
b/sw/qa/extras/rtfexport/rtfexport4.cxx
index dbf8cf016ff9..55eb4a2b8c48 100644
--- a/sw/qa/extras/rtfexport/rtfexport4.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport4.cxx
@@ -333,12 +333,14 @@ DECLARE_RTFEXPORT_TEST(testTdf129522_removeShadowStyle,
"tdf129522_removeShadowS
DECLARE_RTFEXPORT_TEST(testTdf136587_noStyleName, "tdf136587_noStyleName.rtf")
{
+// An exception stopped all style definitions.
uno::Reference paragraphStyles =
getStyles("ParagraphStyles");
uno::Reference
xStyleProps(paragraphStyles->getByName("Style15"),
uno::UNO_QUERY_THROW);
CPPUNIT_ASSERT_EQUAL(sal_Int16(style::ParagraphAdjust_CENTER),
getProperty(xStyleProps, "ParaAdjust"));
+// The problem was that the default style wasn't imported at all, so the
fontsize was only 12.
xStyleProps.set(paragraphStyles->getByName("Default Paragraph Style"),
uno::UNO_QUERY_THROW);
CPPUNIT_ASSERT_EQUAL(32.0f, getProperty(xStyleProps, "CharHeight"));
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116345] Impress: Video in an ODP file endlessly zooms in when running the presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=116345 --- Comment #12 from Victor Mathews --- Videos are edited by the use of different software but at the back end, all the things are written in the form of coding. Learning coding from https://awriter.org/best-resume-writing-service-reviews/ as it is an easy opportunity for beginners and professionals both. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136237] LibreOffice Will Not Close
https://bugs.documentfoundation.org/show_bug.cgi?id=136237 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136165] Transparent background when exporting a page with image to PNG
https://bugs.documentfoundation.org/show_bug.cgi?id=136165 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136228] Powerpoint compatibility: image is displaced in Impress and covering the text
https://bugs.documentfoundation.org/show_bug.cgi?id=136228 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136231] powerpoint compatibility: text not displayed identically even when substitute fonts have same metrics
https://bugs.documentfoundation.org/show_bug.cgi?id=136231 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136230] search functionality for special characters is too bad
https://bugs.documentfoundation.org/show_bug.cgi?id=136230 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136229] Powerpoint title appearing smaller in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=136229 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 136165] Transparent background when exporting a page with image to PNG
https://bugs.documentfoundation.org/show_bug.cgi?id=136165 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 134293] Inconsistent double-click AutoFill behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=134293 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131342] Crash in: libc-2.23.so
https://bugs.documentfoundation.org/show_bug.cgi?id=131342 --- Comment #2 from QA Administrators --- Dear libreoffice, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131350] Impress / Bulleted list: bullets appear in "0%" size, cannot be made larger
https://bugs.documentfoundation.org/show_bug.cgi?id=131350 --- Comment #2 from QA Administrators --- Dear Klaus Schaaf, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136013] FILEOPEN Importing tsv/csv with no string delimiter causes whitespace only trailing column to corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=136013 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136225] Chinese script has wrong rotation in a specific PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=136225 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136227] FILEOPEN DOCX with a large table slow (4 seconds ODT 28 seconds DOCX)
https://bugs.documentfoundation.org/show_bug.cgi?id=136227 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130962] ActiveX component can't be created
https://bugs.documentfoundation.org/show_bug.cgi?id=130962 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123798] libre office tells in a text box that there are some updates but there is nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=123798 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131355] None of my Libre Office files will now open.
https://bugs.documentfoundation.org/show_bug.cgi?id=131355 --- Comment #2 from QA Administrators --- Dear Paul J Hauser, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136176] Wrong object position after filesave and fileopen/reload if slant is used on a vertically flipped object in draw
https://bugs.documentfoundation.org/show_bug.cgi?id=136176 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123798] libre office tells in a text box that there are some updates but there is nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=123798 --- Comment #8 from QA Administrators --- Dear Pablo, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[ANN] orcus 0.16.0 on master
Hi there, The orcus library has been upgraded to 0.16.0 on the master branch. You can find the release notes for the new version here: https://gitlab.com/orcus/orcus/-/releases/0.16.0 Also the ixion library version 0.16.0 has been released too which may be of interest to distro packagers. The release notes are found here: https://gitlab.com/ixion/ixion/-/releases/0.16.0 Best, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 136220] Long fields lose its part on page end if external text updated
https://bugs.documentfoundation.org/show_bug.cgi?id=136220 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84381] SIDEBAR: Properties deck (Area/Line content panels) should respond more accurately to selected objects
https://bugs.documentfoundation.org/show_bug.cgi?id=84381 --- Comment #10 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130962] ActiveX component can't be created
https://bugs.documentfoundation.org/show_bug.cgi?id=130962 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136122] Notes joined to a cell in Calc are not correctly treated when export to xhtml format
https://bugs.documentfoundation.org/show_bug.cgi?id=136122 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/drop-findcmap' - 4 commits - include/vcl vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/win
Rebased ref, commits from common ancestor:
commit ae879f7cc2fe1e23f070d9b35d31a273d9862ea4
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:34:11 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:54:56 2020 +0200
Qt5 implement GetGlyphWidths
Basically implement it the same way then Windows and MacOS.
Change-Id: I643581af49aeb9274505e90e12acbe5bcf0c98fb
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 39d117b8ca12..26b09b8bdc26 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -297,9 +297,13 @@ const void* Qt5Graphics::GetEmbedFontData(const
PhysicalFontFace*, long* /*pData
void Qt5Graphics::FreeEmbedFontData(const void* /*pData*/, long /*nDataLen*/)
{}
-void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* /*pPFF*/, bool
/*bVertical*/,
- std::vector& /*rWidths*/,
Ucs2UIntMap& /*rUnicodeEnc*/)
+void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* pFontFace, bool
bVertical,
+ std::vector& rWidths, Ucs2UIntMap&
rUnicodeEnc)
{
+const Qt5FontFace* pQt5FontFace = static_cast(pFontFace);
+const QRawFont aRawFont(QRawFont::fromFont(pQt5FontFace->CreateFont()));
+Qt5TrueTypeFont aTTF(*pQt5FontFace, aRawFont);
+SalGraphics::GetGlyphWidths(aTTF, *pFontFace, bVertical, rWidths,
rUnicodeEnc);
}
namespace
commit 69b02e1db6025123d6168f3e62ab7b381e5a63c3
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:31:51 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:54:55 2020 +0200
Forward existing FontCharMap from PhysicalFontFace
Since removed code in the previous commit is primary used in
CreateFontSubset and GetGlyphWidths, you have a high chance, that
the CMAP was already used for displaying a font, so it's already
decoded and can be forwarded. Also the lookup should be faster in
general this way.
Change-Id: Icf4d8a1a84ff6ccdaccb7e870abe5df3837f9541
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index bcbf74b07aa1..86cb718809b3 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -470,11 +470,13 @@ class TrueTypeFont;
* @param nLen- size of memory buffer
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum,
+ TrueTypeFont** ttf, const
FontCharMapRef xCharMap = nullptr);
#if !defined(_WIN32)
/**
* TrueTypeFont constructor.
@@ -483,11 +485,13 @@ class TrueTypeFont;
* @param fname - name of TrueType font file
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf,
+const FontCharMapRef xCharMap =
nullptr);
#endif
bool VCL_DLLPUBLIC getTTCoverage(
@@ -728,7 +732,7 @@ protected:
SFErrCodes indexGlyphData();
public:
-AbstractTrueTypeFont(const char* fileName = nullptr);
+AbstractTrueTypeFont(const char* fileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
virtual ~AbstractTrueTypeFont();
const char* fileName() const { return m_pFileName; }
@@ -765,7 +769,7 @@ public:
sal_uInt32 ntables;
-TrueTypeFont(const char* pFileName = nullptr);
+TrueTypeFont(const char* pFileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
~TrueTypeFont() override;
SFErrCodes open(sal_uInt32 facenum);
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 1c137f37bfc4..39d117b8ca12 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -137,14 +137,15 @@ class Qt5TrueTypeFont : public vcl::AbstractTrueTypeFont
mutable QByteArray m_aFontTable[vcl::NUM_TAGS];
public:
-Qt5TrueTypeFont(const QRawFont& aRawFont);
+Qt5TrueTypeFont(const Qt5FontFace& aFontFace, const QRawFont& aRawFont);
bool hasTable(sal_uInt32 ord) const override;
const sal_uInt8* table(sal_uInt32 ord, sal_uInt32& size) const override;
};
[Libreoffice-bugs] [Bug 112317] Fragmentary/partial display of border rectangle placed on Footnote Characters style in documents added footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=112317 --- Comment #5 from QA Administrators --- Dear KerryGee, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106076] Find and replace formatted text -- intransparencies and inconsistencies?
https://bugs.documentfoundation.org/show_bug.cgi?id=106076 --- Comment #13 from QA Administrators --- Dear Butch, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/liborcus
external/liborcus/0001-Alpha-value-of-0-means-fully-transparent.-I-m-sure-2.patch
| 50
external/liborcus/0001-add-xml-path.patch
| 119 --
external/liborcus/0001-workaround-a-linking-problem-on-windows.patch
| 45 ---
external/liborcus/0001-xls-xml-Import-hidden-row-and-column-flags.patch
| 81 --
external/liborcus/0001-xls-xml-Pick-up-border-colors.patch
| 69 -
external/liborcus/0002-We-are-supposed-to-use-the-foreground-color-for-soli.patch
| 49
6 files changed, 413 deletions(-)
New commits:
commit 0ec032b6a42bcf3dee11cfd9f4fc702905b7ba94
Author: Kohei Yoshida
AuthorDate: Fri Sep 11 21:09:22 2020 -0400
Commit: Kohei Yoshida
CommitDate: Sat Sep 12 05:49:28 2020 +0200
Remove unused patches.
Change-Id: I2a1dbe15f2df42b4f74e0c00b91ace6c0d3f5f8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102503
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida
diff --git
a/external/liborcus/0001-Alpha-value-of-0-means-fully-transparent.-I-m-sure-2.patch
b/external/liborcus/0001-Alpha-value-of-0-means-fully-transparent.-I-m-sure-2.patch
deleted file mode 100644
index 6adae9ba2352..
---
a/external/liborcus/0001-Alpha-value-of-0-means-fully-transparent.-I-m-sure-2.patch
+++ /dev/null
@@ -1,50 +0,0 @@
-From 98d2b3377da71b713a37f9004acff3c02c22ce2b Mon Sep 17 00:00:00 2001
-From: Kohei Yoshida
-Date: Wed, 31 Jan 2018 22:11:25 -0500
-Subject: [PATCH 1/2] Alpha value of 0 means fully transparent. I'm sure 255
- was intended.
-
-(cherry picked from commit f7953a814d6a43205791b6cc01c528ef5d4b1ce3)
- src/liborcus/gnumeric_sheet_context.cpp | 4 ++--
- src/liborcus/odf_styles_context.cpp | 2 +-
- 2 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/src/liborcus/gnumeric_sheet_context.cpp
b/src/liborcus/gnumeric_sheet_context.cpp
-index 8659cc3..6bd1471 100644
a/src/liborcus/gnumeric_sheet_context.cpp
-+++ b/src/liborcus/gnumeric_sheet_context.cpp
-@@ -132,7 +132,7 @@ public:
- {
- spreadsheet::color_elem_t red, green, blue;
- gnumeric_helper::parse_RGB_color_attribute(red, green, blue,
attr.value);
--m_styles.set_fill_fg_color(0, red, green, blue);
-+m_styles.set_fill_fg_color(255, red, green, blue);
-
- m_fill = true;
-
-@@ -145,7 +145,7 @@ public:
- {
- spreadsheet::color_elem_t red, green, blue;
- gnumeric_helper::parse_RGB_color_attribute(red, green, blue,
attr.value);
--m_styles.set_fill_bg_color(0, red, green, blue);
-+m_styles.set_fill_bg_color(255, red, green, blue);
-
- m_fill = true;
- }
-diff --git a/src/liborcus/odf_styles_context.cpp
b/src/liborcus/odf_styles_context.cpp
-index d988f7d..f9c422a 100644
a/src/liborcus/odf_styles_context.cpp
-+++ b/src/liborcus/odf_styles_context.cpp
-@@ -739,7 +739,7 @@ void styles_context::start_element(xmlns_id_t ns,
xml_token_t name, const std::v
- {
- spreadsheet::color_elem_t red, green, blue;
- func.get_background_color(red, green, blue);
--mp_styles->set_fill_bg_color(0, red, green, blue);
-+mp_styles->set_fill_bg_color(255, red, green, blue);
- }
-
- size_t fill_id = mp_styles->commit_fill();
---
-2.7.4
-
diff --git a/external/liborcus/0001-add-xml-path.patch
b/external/liborcus/0001-add-xml-path.patch
deleted file mode 100644
index 3f9a16bb880f..
--- a/external/liborcus/0001-add-xml-path.patch
+++ /dev/null
@@ -1,119 +0,0 @@
-diff --git a/include/orcus/xml_structure_tree.hpp
b/include/orcus/xml_structure_tree.hpp
-index
58cabfd116fa24e35ff27cf8d7512b6e73df33f4..c88808d24bd74c175fa4017328d3e54b4c588c5e
100644
a/include/orcus/xml_structure_tree.hpp
-+++ b/include/orcus/xml_structure_tree.hpp
-@@ -127,6 +127,20 @@ public:
- size_t get_xmlns_index(xmlns_id_t ns) const;
-
- std::string get_xmlns_short_name(xmlns_id_t ns) const;
-+
-+/**
-+ * Get a XPath like ID for the element inside of the XML tree.
-+ *
-+ */
-+std::string get_path() const;
-+
-+/**
-+ * Select an element by a path expression. The path expression may be
-+ * generated by xml_structure_tree::walker::get_path.
-+ *
-+ * @param path a simple XPath like expression
-+ */
-+element select_by_path(const std::string& path);
- };
-
- xml_structure_tree(xmlns_context& xmlns_cxt);
-diff --git a/src/liborcus/xml_structure_tree.cpp
b/src/liborcus/xml_structure_tree.cpp
-index
2778bc05f32841a9441bf471913872e119256895..6622bc57cd2595f12bba80d4bbdb5c24cd6e7bc6
100644
a/src/liborcus/xml_structure_tree.cpp
-+++
[Libreoffice-commits] core.git: configure.ac download.lst external/liborcus RepositoryExternal.mk sc/source
RepositoryExternal.mk|4 configure.ac |2 download.lst |4 external/liborcus/0001-Mark-all-untentionally-unused-variables.patch | 376 ++ external/liborcus/ExternalPackage_liborcus.mk|8 external/liborcus/ExternalProject_liborcus.mk|4 external/liborcus/Library_orcus-parser.mk|1 external/liborcus/Library_orcus.mk |4 external/liborcus/UnpackedTarball_liborcus.mk|1 external/liborcus/libtool.patch.0| 10 external/liborcus/windows-constants-hack.patch |2 sc/source/filter/inc/orcusinterface.hxx | 21 sc/source/filter/orcus/interface.cxx | 82 +- sc/source/filter/orcus/xmlcontext.cxx|7 sc/source/ui/xmlsource/xmlsourcedlg.cxx |6 15 files changed, 480 insertions(+), 52 deletions(-) New commits: commit 109ed8f775dddfede012d56d078abd70b45490c0 Author: Kohei Yoshida AuthorDate: Wed Sep 9 21:23:48 2020 -0400 Commit: Kohei Yoshida CommitDate: Sat Sep 12 05:49:10 2020 +0200 Upgrade liborcus to 0.16.0. Change-Id: Iae29fb26417dfc161698a81bee84e81545969065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102502 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index d9fa980d7f24..1f0a91de142a 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -3270,7 +3270,7 @@ $(call gb_LinkTarget_set_include,$(1),\ ) $(call gb_LinkTarget_add_libs,$(1),\ - -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/liborcus/.libs -lorcus-0.15 \ + -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/liborcus/.libs -lorcus-0.16 \ ) $(if $(SYSTEM_BOOST), \ @@ -3289,7 +3289,7 @@ $(call gb_LinkTarget_set_include,$(1),\ ) $(call gb_LinkTarget_add_libs,$(1),\ - -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/parser/.libs -lorcus-parser-0.15 \ + -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/parser/.libs -lorcus-parser-0.16 \ ) endef diff --git a/configure.ac b/configure.ac index 8e8d5eb662d9..06398bfa99a7 100644 --- a/configure.ac +++ b/configure.ac @@ -10126,7 +10126,7 @@ AC_SUBST(ENABLE_FUZZERS) dnl === dnl Orcus dnl === -libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.15 >= 0.15.0]) +libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.16 >= 0.16.0]) if test "$with_system_orcus" != "yes"; then if test "$SYSTEM_BOOST" = "TRUE"; then # === diff --git a/download.lst b/download.lst index ee4ba8a1c83b..345ddd19537b 100644 --- a/download.lst +++ b/download.lst @@ -206,8 +206,8 @@ export OPENLDAP_SHA256SUM := cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb89 export OPENLDAP_TARBALL := openldap-2.4.45.tgz export OPENSSL_SHA256SUM := ddb04774f1e32f0c49751e21b67216ac87852ceb056b75209af2443400636d46 export OPENSSL_TARBALL := openssl-1.1.1g.tar.gz -export ORCUS_SHA256SUM := cfb2aa60825f2a78589ed030c07f46a1ee16ef8a2d1bf2279192fbc1ae5a5f61 -export ORCUS_TARBALL := liborcus-0.15.4.tar.bz2 +export ORCUS_SHA256SUM := 854c6ec167ace59baa2984e175bac7b5b2af91bfde4bb10d2088b87a51ed76ec +export ORCUS_TARBALL := liborcus-0.16.0.tar.bz2 export OWNCLOUD_ANDROID_LIB_SHA256SUM := b18b3e3ef7fae6a79b62f2bb43cc47a5346b6330f6a383dc4be34439aca5e9fb export OWNCLOUD_ANDROID_LIB_TARBALL := owncloud-android-library-0.9.4-no-binary-deps.tar.gz export PAGEMAKER_SHA256SUM := 66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d diff --git a/external/liborcus/0001-Mark-all-untentionally-unused-variables.patch b/external/liborcus/0001-Mark-all-untentionally-unused-variables.patch new file mode 100644 index ..b0f6a572aff7 --- /dev/null +++ b/external/liborcus/0001-Mark-all-untentionally-unused-variables.patch @@ -0,0 +1,376 @@ +From 6d34c41b661a9e8dddf6d08bf1f3c1fd4f5581da Mon Sep 17 00:00:00 2001 +From: Kohei Yoshida +Date: Fri, 11 Sep 2020 21:39:09 -0400 +Subject: [PATCH] Mark all untentionally unused variables. + +--- + include/orcus/css_parser.hpp | 70 -- + include/orcus/csv_parser.hpp | 5 ++- + include/orcus/json_parser.hpp | 15 +-- + include/orcus/sax_parser.hpp | 35 --- + include/orcus/sax_token_parser.hpp | 20 +++-- + include/orcus/yaml_parser.hpp | 10 - + 6 files changed, 124 insertions(+), 31 deletions(-) + +diff --git a/include/orcus/css_parser.hpp
[Libreoffice-commits] core.git: Branch 'feature/drop-findcmap' - 3 commits - include/vcl vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/win
Rebased ref, commits from common ancestor:
commit f8eff2fb4526e456f56afbfaaf2210f566e0387c
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:34:11 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:19:16 2020 +0200
Qt5 implement GetGlyphWidths
Basically implement it the same way then Windows and MacOS.
Change-Id: I643581af49aeb9274505e90e12acbe5bcf0c98fb
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 39d117b8ca12..26b09b8bdc26 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -297,9 +297,13 @@ const void* Qt5Graphics::GetEmbedFontData(const
PhysicalFontFace*, long* /*pData
void Qt5Graphics::FreeEmbedFontData(const void* /*pData*/, long /*nDataLen*/)
{}
-void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* /*pPFF*/, bool
/*bVertical*/,
- std::vector& /*rWidths*/,
Ucs2UIntMap& /*rUnicodeEnc*/)
+void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* pFontFace, bool
bVertical,
+ std::vector& rWidths, Ucs2UIntMap&
rUnicodeEnc)
{
+const Qt5FontFace* pQt5FontFace = static_cast(pFontFace);
+const QRawFont aRawFont(QRawFont::fromFont(pQt5FontFace->CreateFont()));
+Qt5TrueTypeFont aTTF(*pQt5FontFace, aRawFont);
+SalGraphics::GetGlyphWidths(aTTF, *pFontFace, bVertical, rWidths,
rUnicodeEnc);
}
namespace
commit ba5c0dac4e0318513795310240eb0e530ea88082
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:31:51 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:19:16 2020 +0200
Forward existing FontCharMap from PhysicalFontFace
Since removed code in the previous commit is primary used in
CreateFontSubset and GetGlyphWidths, you have a high chance, that
the CMAP was already used for displaying a font, so it's already
decoded and can be forwarded. Also the lookup should be faster in
general this way.
Change-Id: Icf4d8a1a84ff6ccdaccb7e870abe5df3837f9541
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index bcbf74b07aa1..86cb718809b3 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -470,11 +470,13 @@ class TrueTypeFont;
* @param nLen- size of memory buffer
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum,
+ TrueTypeFont** ttf, const
FontCharMapRef xCharMap = nullptr);
#if !defined(_WIN32)
/**
* TrueTypeFont constructor.
@@ -483,11 +485,13 @@ class TrueTypeFont;
* @param fname - name of TrueType font file
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf,
+const FontCharMapRef xCharMap =
nullptr);
#endif
bool VCL_DLLPUBLIC getTTCoverage(
@@ -728,7 +732,7 @@ protected:
SFErrCodes indexGlyphData();
public:
-AbstractTrueTypeFont(const char* fileName = nullptr);
+AbstractTrueTypeFont(const char* fileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
virtual ~AbstractTrueTypeFont();
const char* fileName() const { return m_pFileName; }
@@ -765,7 +769,7 @@ public:
sal_uInt32 ntables;
-TrueTypeFont(const char* pFileName = nullptr);
+TrueTypeFont(const char* pFileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
~TrueTypeFont() override;
SFErrCodes open(sal_uInt32 facenum);
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 1c137f37bfc4..39d117b8ca12 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -137,14 +137,15 @@ class Qt5TrueTypeFont : public vcl::AbstractTrueTypeFont
mutable QByteArray m_aFontTable[vcl::NUM_TAGS];
public:
-Qt5TrueTypeFont(const QRawFont& aRawFont);
+Qt5TrueTypeFont(const Qt5FontFace& aFontFace, const QRawFont& aRawFont);
bool hasTable(sal_uInt32 ord) const override;
const sal_uInt8* table(sal_uInt32 ord, sal_uInt32& size) const override;
};
[Libreoffice-bugs] [Bug 136637] Firebird: Entering the sql command will cause Libreoffice to hang
https://bugs.documentfoundation.org/show_bug.cgi?id=136637 --- Comment #7 from s...@imail.ru --- I didn't find any information about this in the version change texts. But this is very important. It's a pity that the built-in Firebird is again in question. I considered this a big step and a huge plus for LO Base. But nothing do. I guess I was too hasty. So I urgently need to do a reverse conversion to Hbase and forget about the built-in Firebird. Thank you for the information. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/drop-findcmap' - 5 commits - include/vcl vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win
Rebased ref, commits from common ancestor:
commit ad3f6868edbd7123da3138b956936d980aaecf5d
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:34:11 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:03:14 2020 +0200
Qt5 implement GetGlyphWidths
Basically implement it the same way then Windows and MacOS.
Change-Id: I643581af49aeb9274505e90e12acbe5bcf0c98fb
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 39d117b8ca12..26b09b8bdc26 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -297,9 +297,13 @@ const void* Qt5Graphics::GetEmbedFontData(const
PhysicalFontFace*, long* /*pData
void Qt5Graphics::FreeEmbedFontData(const void* /*pData*/, long /*nDataLen*/)
{}
-void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* /*pPFF*/, bool
/*bVertical*/,
- std::vector& /*rWidths*/,
Ucs2UIntMap& /*rUnicodeEnc*/)
+void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* pFontFace, bool
bVertical,
+ std::vector& rWidths, Ucs2UIntMap&
rUnicodeEnc)
{
+const Qt5FontFace* pQt5FontFace = static_cast(pFontFace);
+const QRawFont aRawFont(QRawFont::fromFont(pQt5FontFace->CreateFont()));
+Qt5TrueTypeFont aTTF(*pQt5FontFace, aRawFont);
+SalGraphics::GetGlyphWidths(aTTF, *pFontFace, bVertical, rWidths,
rUnicodeEnc);
}
namespace
commit ae47bc938572223d87414361356b92445f75df52
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:31:51 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 05:03:14 2020 +0200
Forward existing FontCharMap from PhysicalFontFace
Since removed code in the previous commit is primary used in
CreateFontSubset and GetGlyphWidths, you have a high chance, that
the CMAP was already used for displaying a font, so it's already
decoded and can be forwarded. Also the lookup should be faster in
general this way.
Change-Id: Icf4d8a1a84ff6ccdaccb7e870abe5df3837f9541
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index cdc60f0de722..aa6b8abd2134 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -470,11 +470,13 @@ class TrueTypeFont;
* @param nLen- size of memory buffer
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum,
+ TrueTypeFont** ttf, const
FontCharMapRef xCharMap = nullptr);
#if !defined(_WIN32)
/**
* TrueTypeFont constructor.
@@ -483,11 +485,13 @@ class TrueTypeFont;
* @param fname - name of TrueType font file
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf,
+const FontCharMapRef xCharMap =
nullptr);
#endif
bool VCL_DLLPUBLIC getTTCoverage(
@@ -728,7 +732,7 @@ protected:
SFErrCodes indexGlyphData();
public:
-AbstractTrueTypeFont(const char* fileName = nullptr);
+AbstractTrueTypeFont(const char* fileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
virtual ~AbstractTrueTypeFont();
const char* fileName() const { return m_pFileName; }
@@ -765,7 +769,7 @@ public:
sal_uInt32 ntables;
-TrueTypeFont(const char* pFileName = nullptr);
+TrueTypeFont(const char* pFileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
~TrueTypeFont() override;
SFErrCodes open(sal_uInt32 facenum);
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 1c137f37bfc4..39d117b8ca12 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -137,14 +137,15 @@ class Qt5TrueTypeFont : public vcl::AbstractTrueTypeFont
mutable QByteArray m_aFontTable[vcl::NUM_TAGS];
public:
-Qt5TrueTypeFont(const QRawFont& aRawFont);
+Qt5TrueTypeFont(const Qt5FontFace& aFontFace, const QRawFont& aRawFont);
bool hasTable(sal_uInt32 ord) const override;
const sal_uInt8* table(sal_uInt32 ord, sal_uInt32& size) const override;
};
[Libreoffice-bugs] [Bug 125234] qt5: exported PDf file misses embedded fonts with vcl=qt5
https://bugs.documentfoundation.org/show_bug.cgi?id=125234 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125943] [META] Qt5 VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=125943 Bug 125943 depends on bug 125234, which changed state. Bug 125234 Summary: qt5: exported PDf file misses embedded fonts with vcl=qt5 https://bugs.documentfoundation.org/show_bug.cgi?id=125234 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/drop-findcmap' - 7 commits - configure.ac include/vcl sw/qa vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win
Rebased ref, commits from common ancestor:
commit 6f9840687a9beda9fd38b5aa64a08cb516b7bc09
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:34:11 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 04:04:02 2020 +0200
Qt5 implement GetGlyphWidths
Basically implement it the same way then Windows and MacOS.
Change-Id: I643581af49aeb9274505e90e12acbe5bcf0c98fb
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 39d117b8ca12..26b09b8bdc26 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -297,9 +297,13 @@ const void* Qt5Graphics::GetEmbedFontData(const
PhysicalFontFace*, long* /*pData
void Qt5Graphics::FreeEmbedFontData(const void* /*pData*/, long /*nDataLen*/)
{}
-void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* /*pPFF*/, bool
/*bVertical*/,
- std::vector& /*rWidths*/,
Ucs2UIntMap& /*rUnicodeEnc*/)
+void Qt5Graphics::GetGlyphWidths(const PhysicalFontFace* pFontFace, bool
bVertical,
+ std::vector& rWidths, Ucs2UIntMap&
rUnicodeEnc)
{
+const Qt5FontFace* pQt5FontFace = static_cast(pFontFace);
+const QRawFont aRawFont(QRawFont::fromFont(pQt5FontFace->CreateFont()));
+Qt5TrueTypeFont aTTF(*pQt5FontFace, aRawFont);
+SalGraphics::GetGlyphWidths(aTTF, *pFontFace, bVertical, rWidths,
rUnicodeEnc);
}
namespace
commit 91ac045b940aa893029d949592cbe5f4572d6b4c
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 11 22:31:51 2020 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 12 04:04:01 2020 +0200
Forward existing FontCharMap from PhysicalFontFace
Since removed code in the previous commit is primary used in
CreateFontSubset and GetGlyphWidths, you have a high chance, that
the CMAP was already used for displaying a font, so it's already
decoded and can be forwarded. Also the lookup should be faster in
general this way.
Change-Id: Icf4d8a1a84ff6ccdaccb7e870abe5df3837f9541
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index cdc60f0de722..aa6b8abd2134 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -470,11 +470,13 @@ class TrueTypeFont;
* @param nLen- size of memory buffer
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontBuffer(const void* pBuffer, sal_uInt32
nLen, sal_uInt32 facenum,
+ TrueTypeFont** ttf, const
FontCharMapRef xCharMap = nullptr);
#if !defined(_WIN32)
/**
* TrueTypeFont constructor.
@@ -483,11 +485,13 @@ class TrueTypeFont;
* @param fname - name of TrueType font file
* @param facenum - logical font number within a TTC file. This value is
ignored
* for TrueType fonts
- * @param ttf - array of TrueTypeFonts
+ * @param ttf - returns the opened TrueTypeFont
+ * @param xCharMap - optional parsed character map
* @return value of SFErrCodes enum
* @ingroup sft
*/
-SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf);
+SFErrCodes VCL_DLLPUBLIC OpenTTFontFile(const char *fname, sal_uInt32
facenum, TrueTypeFont** ttf,
+const FontCharMapRef xCharMap =
nullptr);
#endif
bool VCL_DLLPUBLIC getTTCoverage(
@@ -728,7 +732,7 @@ protected:
SFErrCodes indexGlyphData();
public:
-AbstractTrueTypeFont(const char* fileName = nullptr);
+AbstractTrueTypeFont(const char* fileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
virtual ~AbstractTrueTypeFont();
const char* fileName() const { return m_pFileName; }
@@ -765,7 +769,7 @@ public:
sal_uInt32 ntables;
-TrueTypeFont(const char* pFileName = nullptr);
+TrueTypeFont(const char* pFileName = nullptr, const FontCharMapRef
xCharMap = nullptr);
~TrueTypeFont() override;
SFErrCodes open(sal_uInt32 facenum);
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 1c137f37bfc4..39d117b8ca12 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -137,14 +137,15 @@ class Qt5TrueTypeFont : public vcl::AbstractTrueTypeFont
mutable QByteArray m_aFontTable[vcl::NUM_TAGS];
public:
-Qt5TrueTypeFont(const QRawFont& aRawFont);
+Qt5TrueTypeFont(const Qt5FontFace& aFontFace, const QRawFont& aRawFont);
bool hasTable(sal_uInt32 ord) const override;
const sal_uInt8* table(sal_uInt32 ord, sal_uInt32& size) const override;
};
[Libreoffice-commits] core.git: configure.ac
configure.ac |6 ++ 1 file changed, 6 insertions(+) New commits: commit 0c31a0a5178b0ad1e10f55767ef98590f397a5e6 Author: Jan-Marek Glogowski AuthorDate: Sat Sep 12 03:15:35 2020 +0200 Commit: Jan-Marek Glogowski CommitDate: Sat Sep 12 03:28:42 2020 +0200 non-cross: set Java FOR_BUILD variables Seems I never had some JAVA_HOME ponting to some different Java, then my build system. At least that is my guess from the lo_callgrind_linux Jenkins build. Change-Id: I4315ff64064463edf34f0f96006ae72f80f1ffa4 diff --git a/configure.ac b/configure.ac index 7dba20926e8e..8e8d5eb662d9 100644 --- a/configure.ac +++ b/configure.ac @@ -8126,6 +8126,12 @@ if test -n "$ENABLE_JAVA" -a -z "$JAVAINC"; then fi SOLARINC="$SOLARINC $JAVAINC" +if test "$ENABLE_JAVA" != "" -a "$cross_compiling" != "yes"; then +JAVA_HOME_FOR_BUILD=$JAVA_HOME +JAVAIFLAGS_FOR_BUILD=$JAVAIFLAGS +JDK_FOR_BUILD=$JDK +fi + AC_SUBST(JAVACFLAGS) AC_SUBST(JAVACOMPILER) AC_SUBST(JAVAINTERPRETER) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107604] Fileopen PPTX: no table style applied so B instead of colors for header row and banded rows
https://bugs.documentfoundation.org/show_bug.cgi?id=107604 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5843 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135843] FILEOPEN PPTX: vertical lines in table appears in Impress, but not PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=135843 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7604 Keywords|bibisectRequest |bibisected, bisected --- Comment #3 from Aron Budea --- The table style started showing after the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=7f82e6dae98bc5e75ec03885eb955a7a72047bb4 author Gülşah Köse 2019-12-27 21:06:08 +0300 committer Andras Timar2020-01-07 10:19:11 +0100 tdf#107604 Handle predefined table styles. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135953] FILEOPEN PPTX: vertical text in SmartArt appears center-aligned instead of left-aligned
https://bugs.documentfoundation.org/show_bug.cgi?id=135953 Aron Budea changed: What|Removed |Added Attachment #164503|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134209] FILEOPEN PPTX: Image shown as color instead of black
https://bugs.documentfoundation.org/show_bug.cgi?id=134209 Aron Budea changed: What|Removed |Added Attachment #162273|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134209] FILEOPEN PPTX: Image shown as color instead of black
https://bugs.documentfoundation.org/show_bug.cgi?id=134209 Aron Budea changed: What|Removed |Added Blocks||108226 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Aron Budea changed: What|Removed |Added Depends on||134209 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=134209 [Bug 134209] FILEOPEN PPTX: Image shown as color instead of black -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134288] FILEOPEN PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=134288 Aron Budea changed: What|Removed |Added Attachment #162385|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Aron Budea changed: What|Removed |Added Depends on||134288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=134288 [Bug 134288] FILEOPEN PPTX: text box renders vertically instead of horizontally -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134210] FILEOPEN PPTX: Image shown with wider aspect ratio (and different clipping) - cropping not being applied.
https://bugs.documentfoundation.org/show_bug.cgi?id=134210 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Attachment #162277|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134288] FILEOPEN PPTX: text box renders vertically instead of horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=134288 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||108226 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136235] FILEOPEN PPTX: labels of piechart illegible - labels positioned on identically colored pies
https://bugs.documentfoundation.org/show_bug.cgi?id=136235 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Attachment #164818|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136234] FILEOPEN PPTX: Last entry in "diamond" SmartArt renders vertically, all others horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=136234 Aron Budea changed: What|Removed |Added Keywords||bibisectRequest Version|5.2 all versions|5.0.0.5 release --- Comment #5 from Aron Budea --- Actually, it renders horizontally in 4.4.0.3, though in two lines instead of one. Might be worth bibisecting, but I'm not marking regression, it was never good. Still renders horizontally in latest of bibisect-50max, but already vertically in 5.0.0.5 / Ubuntu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136234] FILEOPEN PPTX: Last entry in "diamond" SmartArt renders vertically, all others horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=136234 Aron Budea changed: What|Removed |Added Attachment #164815|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136234] FILEOPEN PPTX: Last entry in "diamond" SmartArt renders vertically, all others horizontally
https://bugs.documentfoundation.org/show_bug.cgi?id=136234 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||106547 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106547 [Bug 106547] [META] OOXML SmartArt bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106547] [META] OOXML SmartArt bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=106547 Aron Budea changed: What|Removed |Added Depends on||136234 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136234 [Bug 136234] FILEOPEN PPTX: Last entry in "diamond" SmartArt renders vertically, all others horizontally -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Aron Budea changed: What|Removed |Added Depends on||134785 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=134785 [Bug 134785] FILEOPEN PPTX: text box and line not shown in presentation mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134785] FILEOPEN PPTX: text box and line not shown in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=134785 Aron Budea changed: What|Removed |Added Version|4.4 all versions|4.1.0.4 release Keywords|regression | Blocks||103610 --- Comment #7 from Aron Budea --- (In reply to Michael Meeks from comment #6) > I'd be surprised if this caused the issue - it is ultimately a revert of a > problematic optimization so the state before > 1d16f59023b1b19d01ca69b8c9735be6d3baf5d9 should be as before. Any chance you > can try it before the oldest of those four mentioned reverted commits to see > if we need to continue bisecting backwards ? =) The situation is quite interesting, let's go in order of oldest to newest of the four reverted commits. The only bibisect repo covering those is bibisect-43all, which doesn't cover individual commits, but we can assume that in the result ranges (one commit in the bibisect repo) including one or more of the reverted commits, only those commits mattered. 1. Before 1d16f59023b1b19d01ca69b8c9735be6d3baf5d9 / 1d77d4eada214e14938336070b248c18705939ff. Bad. These two commits fall in a single commit in the bibisect repo. 2. After 1d16f59023b1b19d01ca69b8c9735be6d3baf5d9 / 1d77d4eada214e14938336070b248c18705939ff, before 67f899e1d2db0dccde4b9587a52b7157fe1fb0be. Good. 3. After 67f899e1d2db0dccde4b9587a52b7157fe1fb0be, before 76350361f386b78e1bc9edb75af89e7ff3afe356. Bad. 4. After 76350361f386b78e1bc9edb75af89e7ff3afe356, before the reverting bb3f2900a867fdcb6df916fff58199b4ce94dd05. Good. 5. After the reverting bb3f2900a867fdcb6df916fff58199b4ce94dd05. Bad. The ranges belonging to the bibisect-43all repo including the later reverted commits: - First two: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=bec62421a45da89d2812bdff30fbbab73291cf91..f260c656da4457c5d87c161bdd43ad3023d07472 - Third: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=683758efb22d08a4cf211a6d985148f513da2a90..a599f5b4b51848e3b397d471c9d12b373caadcef - Fourth: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=4026e1824de8ff9b5d006ae6eba491f91bc4e599..ce90f99a2d66c2b998ad3f9f028e2ea623a757f5 Since it was also bad in 4.0.0.3, 3.6.0.4, ie. no release version included the above commits, let's remove the keyword regression. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103610 [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 3 commits - include/vcl sc/source vcl/Library_vcl.mk vcl/qa vcl/source xmlsecurity/Library_xmlsecurity.mk xmlsecurity/qa xmlsecuri
Rebased ref, commits from common ancestor:
commit 4551f42e67f289482178ecd3a12caaf3d09bcfee
Author: Thorsten Behrens
AuthorDate: Thu Sep 10 00:18:08 2020 +0200
Commit: Thorsten Behrens
CommitDate: Sat Sep 12 00:49:51 2020 +0200
Check range before accessing Calc sort userlist
Change-Id: I74df0bc6db978e06e8014ac1bc0d76a66c7f4fe8
diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 07c4030382c2..487e7eec6626 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -1520,9 +1520,9 @@ short ScTable::CompareCell(
bool bNaturalSort = aSortParam.bNaturalSort;// natural sort
bool bCaseSens= aSortParam.bCaseSens; // case
sensitivity
-if (bUserDef)
+ScUserList* pList = ScGlobal::GetUserList();
+if (bUserDef && pList && pList->size() > aSortParam.nUserIndex)
{
-ScUserList* pList = ScGlobal::GetUserList();
const ScUserListData& rData =
(*pList)[aSortParam.nUserIndex];
if ( bNaturalSort )
commit 1b365b314aabf274983107df0d97de105ff78d2c
Author: Miklos Vajna
AuthorDate: Fri Sep 4 17:17:48 2020 +0200
Commit: Thorsten Behrens
CommitDate: Sat Sep 12 00:49:51 2020 +0200
xmlsecurity: pdf incremental updates that are non-commenting are invalid
I.e. it's OK to add incremental updates for annotation/commenting
purposes and that doesn't invalite existing signatures. Everything else
does.
(cherry picked from commit 61834cd574568613f0b0a2ee099a60fa5a8d9804)
Conflicts:
include/vcl/filter/PDFiumLibrary.hxx
vcl/source/pdf/PDFiumLibrary.cxx
Change-Id: I4607c242b3c6f6b01517b02407e9e7a095e2e069
Conflicts:
xmlsecurity/qa/unit/signing/signing.cxx
diff --git a/include/vcl/filter/PDFiumLibrary.hxx
b/include/vcl/filter/PDFiumLibrary.hxx
index b9bceabb8acf..ffc70874c19b 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -17,11 +17,16 @@
#include
#include
#include
+#include
+
+#include
namespace vcl
{
namespace pdf
{
+class PDFiumDocument;
+
class VCL_DLLPUBLIC PDFium final
{
private:
@@ -33,6 +38,49 @@ public:
~PDFium();
};
+class VCL_DLLPUBLIC PDFiumPage final
+{
+private:
+FPDF_PAGE mpPage;
+
+private:
+PDFiumPage(const PDFiumPage&) = delete;
+PDFiumPage& operator=(const PDFiumPage&) = delete;
+
+public:
+PDFiumPage(FPDF_PAGE pPage)
+: mpPage(pPage)
+{
+}
+
+~PDFiumPage()
+{
+if (mpPage)
+FPDF_ClosePage(mpPage);
+}
+
+/// Get bitmap checksum of the page, without annotations/commenting.
+BitmapChecksum getChecksum();
+};
+
+class VCL_DLLPUBLIC PDFiumDocument final
+{
+private:
+FPDF_DOCUMENT mpPdfDocument;
+
+private:
+PDFiumDocument(const PDFiumDocument&) = delete;
+PDFiumDocument& operator=(const PDFiumDocument&) = delete;
+
+public:
+PDFiumDocument(FPDF_DOCUMENT pPdfDocument);
+~PDFiumDocument();
+
+int getPageCount();
+
+std::unique_ptr openPage(int nIndex);
+};
+
struct PDFiumLibrary : public rtl::StaticWithInit,
PDFiumLibrary>
{
std::shared_ptr operator()() { return std::make_shared(); }
diff --git a/vcl/source/pdf/PDFiumLibrary.cxx b/vcl/source/pdf/PDFiumLibrary.cxx
index 604807524bf9..861b7dda0acb 100644
--- a/vcl/source/pdf/PDFiumLibrary.cxx
+++ b/vcl/source/pdf/PDFiumLibrary.cxx
@@ -15,6 +15,10 @@
#include
#include
+#include
+
+#include
+
namespace vcl::pdf
{
PDFium::PDFium()
@@ -29,6 +33,58 @@ PDFium::PDFium()
PDFium::~PDFium() { FPDF_DestroyLibrary(); }
+PDFiumDocument::PDFiumDocument(FPDF_DOCUMENT pPdfDocument)
+: mpPdfDocument(pPdfDocument)
+{
+}
+
+PDFiumDocument::~PDFiumDocument()
+{
+if (mpPdfDocument)
+FPDF_CloseDocument(mpPdfDocument);
+}
+
+std::unique_ptr PDFiumDocument::openPage(int nIndex)
+{
+std::unique_ptr pPDFiumPage;
+FPDF_PAGE pPage = FPDF_LoadPage(mpPdfDocument, nIndex);
+if (pPage)
+{
+pPDFiumPage = std::make_unique(pPage);
+}
+return pPDFiumPage;
+}
+
+int PDFiumDocument::getPageCount() { return FPDF_GetPageCount(mpPdfDocument); }
+
+BitmapChecksum PDFiumPage::getChecksum()
+{
+size_t nPageWidth = FPDF_GetPageWidth(mpPage);
+size_t nPageHeight = FPDF_GetPageHeight(mpPage);
+FPDF_BITMAP pPdfBitmap = FPDFBitmap_Create(nPageWidth, nPageHeight,
/*alpha=*/1);
+if (!pPdfBitmap)
+{
+return 0;
+}
+
+// Intentionally not using FPDF_ANNOT here, annotations/commenting is OK
to not affect the
+// checksum, signature verification wants this.
+FPDF_RenderPageBitmap(pPdfBitmap, mpPage, /*start_x=*/0, /*start_y=*/0,
nPageWidth, nPageHeight,
+ /*rotate=*/0, /*flags=*/0);
+Bitmap aBitmap(Size(nPageWidth, nPageHeight), 24);
+{
+
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 4 commits - include/sfx2 include/vcl vcl/Library_vcl.mk vcl/qa vcl/source xmlsecurity/Library_xmlsecurity.mk xmlsecurity
include/sfx2/strings.hrc |
4
include/vcl/filter/PDFiumLibrary.hxx |
93 ++
vcl/Library_vcl.mk |
1
vcl/qa/cppunit/pdfexport/pdfexport.cxx |
11 -
vcl/source/filter/ipdf/pdfread.cxx |
18 -
vcl/source/pdf/PDFiumLibrary.cxx |
92 +
xmlsecurity/Library_xmlsecurity.mk |
5
xmlsecurity/qa/unit/signing/data/hide-and-replace-shadow-file-signed-2.pdf
|binary
xmlsecurity/qa/unit/signing/signing.cxx|
19 ++
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |
26 ++
xmlsecurity/source/pdfio/pdfdocument.cxx |
69 +++
xmlsecurity/uiconfig/ui/digitalsignaturesdialog.ui |
4
xmlsecurity/workben/pdfverify.cxx |
5
13 files changed, 313 insertions(+), 34 deletions(-)
New commits:
commit 87d14b79c52b83a92ec4c3e88a902f4cb68884fa
Author: Miklos Vajna
AuthorDate: Fri Sep 4 17:17:48 2020 +0200
Commit: Thorsten Behrens
CommitDate: Sat Sep 12 00:47:05 2020 +0200
xmlsecurity: pdf incremental updates that are non-commenting are invalid
I.e. it's OK to add incremental updates for annotation/commenting
purposes and that doesn't invalite existing signatures. Everything else
does.
(cherry picked from commit 61834cd574568613f0b0a2ee099a60fa5a8d9804)
Conflicts:
include/vcl/filter/PDFiumLibrary.hxx
vcl/source/pdf/PDFiumLibrary.cxx
xmlsecurity/qa/unit/signing/signing.cxx
Change-Id: I4607c242b3c6f6b01517b02407e9e7a095e2e069
diff --git a/include/vcl/filter/PDFiumLibrary.hxx
b/include/vcl/filter/PDFiumLibrary.hxx
index b9bceabb8acf..ffc70874c19b 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -17,11 +17,16 @@
#include
#include
#include
+#include
+
+#include
namespace vcl
{
namespace pdf
{
+class PDFiumDocument;
+
class VCL_DLLPUBLIC PDFium final
{
private:
@@ -33,6 +38,49 @@ public:
~PDFium();
};
+class VCL_DLLPUBLIC PDFiumPage final
+{
+private:
+FPDF_PAGE mpPage;
+
+private:
+PDFiumPage(const PDFiumPage&) = delete;
+PDFiumPage& operator=(const PDFiumPage&) = delete;
+
+public:
+PDFiumPage(FPDF_PAGE pPage)
+: mpPage(pPage)
+{
+}
+
+~PDFiumPage()
+{
+if (mpPage)
+FPDF_ClosePage(mpPage);
+}
+
+/// Get bitmap checksum of the page, without annotations/commenting.
+BitmapChecksum getChecksum();
+};
+
+class VCL_DLLPUBLIC PDFiumDocument final
+{
+private:
+FPDF_DOCUMENT mpPdfDocument;
+
+private:
+PDFiumDocument(const PDFiumDocument&) = delete;
+PDFiumDocument& operator=(const PDFiumDocument&) = delete;
+
+public:
+PDFiumDocument(FPDF_DOCUMENT pPdfDocument);
+~PDFiumDocument();
+
+int getPageCount();
+
+std::unique_ptr openPage(int nIndex);
+};
+
struct PDFiumLibrary : public rtl::StaticWithInit,
PDFiumLibrary>
{
std::shared_ptr operator()() { return std::make_shared(); }
diff --git a/vcl/source/pdf/PDFiumLibrary.cxx b/vcl/source/pdf/PDFiumLibrary.cxx
index 604807524bf9..861b7dda0acb 100644
--- a/vcl/source/pdf/PDFiumLibrary.cxx
+++ b/vcl/source/pdf/PDFiumLibrary.cxx
@@ -15,6 +15,10 @@
#include
#include
+#include
+
+#include
+
namespace vcl::pdf
{
PDFium::PDFium()
@@ -29,6 +33,58 @@ PDFium::PDFium()
PDFium::~PDFium() { FPDF_DestroyLibrary(); }
+PDFiumDocument::PDFiumDocument(FPDF_DOCUMENT pPdfDocument)
+: mpPdfDocument(pPdfDocument)
+{
+}
+
+PDFiumDocument::~PDFiumDocument()
+{
+if (mpPdfDocument)
+FPDF_CloseDocument(mpPdfDocument);
+}
+
+std::unique_ptr PDFiumDocument::openPage(int nIndex)
+{
+std::unique_ptr pPDFiumPage;
+FPDF_PAGE pPage = FPDF_LoadPage(mpPdfDocument, nIndex);
+if (pPage)
+{
+pPDFiumPage = std::make_unique(pPage);
+}
+return pPDFiumPage;
+}
+
+int PDFiumDocument::getPageCount() { return FPDF_GetPageCount(mpPdfDocument); }
+
+BitmapChecksum PDFiumPage::getChecksum()
+{
+size_t nPageWidth = FPDF_GetPageWidth(mpPage);
+size_t nPageHeight = FPDF_GetPageHeight(mpPage);
+FPDF_BITMAP pPdfBitmap = FPDFBitmap_Create(nPageWidth, nPageHeight,
/*alpha=*/1);
+if (!pPdfBitmap)
+{
+return 0;
+}
+
+// Intentionally not using FPDF_ANNOT here, annotations/commenting is OK
to not affect the
+// checksum, signature verification wants this.
+FPDF_RenderPageBitmap(pPdfBitmap, mpPage, /*start_x=*/0, /*start_y=*/0,
nPageWidth, nPageHeight,
+ /*rotate=*/0, /*flags=*/0);
+Bitmap aBitmap(Size(nPageWidth, nPageHeight),
Re: About removing long time deprecated types from public API
Dumb me! I had read the comment for sal_sChar (@deprecated use plain `signed char` instead) instead of sal_Char (@deprecated use plain `char` instead) Sorry for the noise, I'm gonna test with the right replace :-) -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 134785] FILEOPEN PPTX: text box and line not shown in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=134785 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Attachment #162980|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136337] FILEOPEN PPTX: one of three images not shown in presentation mode (but fine in edit mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=136337 Aron Budea changed: What|Removed |Added Attachment #164932|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136674] Incorrect character displayed -- autocorrect single closing quote
https://bugs.documentfoundation.org/show_bug.cgi?id=136674 --- Comment #8 from Dennis Rice --- Go to menu Help - Restart in Safe Mode - Factory Settings and Reset. Why this? Because your LibreOffice 7 installation could have a bad profile, so, wehn restarting in Factory Settings is just like your computer see for the first time a LibreOffice instalation and everything should be fine. I need an info from you if this solved your problem. You are receiving this mail because: You reported the bug. You are on the CC list for the bug. bugzilla-dae...@bugs.documentfoundation.org Sep 10, 2020, 11:00 PM (13 hours ago) to me Comment # 3 on bug 136658 from BogdanB In my test I usd English (USA) as the language of the paragraph, it's the same in your case?... Dennis Rice 12:01 PM (9 minutes ago) to bugzilla-daemon Thank you for your review and direction. I restarted Writer in the safe mode and that apparently worked, but when I then closed down LibreOffice and restarted in normal mode it still had the same problem. I am running build gerrit.libreoffice.org / core / 7cbcfc562f6eb6708b5ff7d7397325de9e764452 after clicking on the document open help and build number. Attempted to do a screenshot: image.png The bold / italic text is where the problem exists. I also found a similar problem in a different section of the text but with the same problem: image.png When I remove the bold / italic setting the problem disappears. image.png Yes, I am using English (USA). I have been using LibreOffice since it first came out, however many years that may be. This was an upgrade as indicated by LibreOffice. I hope this helps. Dennis Rice 12:05 PM (5 minutes ago) to bugzilla-daemon I had to forward this because when I first hit Send, I got an error message saying the address could not be found. [tag] [reply] [−] Comment 1 Dennis Rice 2020-09-11 17:31:08 UTC Attempted to reply to the message sent to me but got back as undeliverable. Hope this helps. [tag] [reply] [−] Comment 2 Telesto 2020-09-11 17:46:28 UTC *** Bug 136658 has been marked as a duplicate of this bug. *** [tag] [reply] [−] Comment 3 Telesto 2020-09-11 17:52:11 UTC Go to Tools -> Options -> View -> Is Force Skia Software Rendering checked? If not, please check it & press OK and restart.. Open the file again, is the issue still present? If this is still the case, please save the relevant part (as shown in screenshot) and add it as attachment. [tag] [reply] [−] Comment 4 Julien Nabet 2020-09-11 18:20:17 UTC Dennis: you must respond on the bugtracker by using https://bugs.documentfoundation.org/show_bug.cgi?id=136674# for this bugtracker, not by trying to respond directly to the author of the comment. [tag] [reply] [−] Comment 5 V Stuart Foote 2020-09-11 18:20:39 UTC Created attachment 165401 [details] clip from attachment 165397 [details] The closing quote U+2019 showing is not from the DejavuSans of the rest of the "Diane's POV:" string. And, since default autocorrect handling is to substituted U+0027 with closing U+2019 unclear what is set for the single quote autocorrect. Have a look at Tools --> AutoCorrect --> AutoCorrect Options on the 'Localized Options' tab. What is set for the Single Quotes? And, if you uncheck the 'Replace' box--what happens on the document canvas? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103610 Aron Budea changed: What|Removed |Added Depends on||136337 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136337 [Bug 136337] FILEOPEN PPTX: one of three images not shown in presentation mode (but fine in edit mode) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136337] FILEOPEN PPTX: one of three images not shown in presentation mode (but fine in edit mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=136337 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu, ||vmik...@collabora.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5094 Blocks||103610 Keywords||bisected --- Comment #4 from Aron Budea --- That is: https://cgit.freedesktop.org/libreoffice/core/commit/?id=78036f74fa74ee2552e79064660634e1342692ff author Miklos Vajna 2020-08-14 16:15:07 +0200 committer Miklos Vajna 2020-08-14 18:39:39 +0200 "tdf#135094 cairo canvas: fix black slide containing a very small image" Adding CC: to Miklos Vajna. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103610 [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136191] FILEOPEN PPTX: pie chart much smaller in Impress than Office 365
https://bugs.documentfoundation.org/show_bug.cgi?id=136191 Aron Budea changed: What|Removed |Added Attachment #164759|application/vnd.ms-powerpoi |application/vnd.openxmlform mime type|nt |ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136191] FILEOPEN PPTX: pie chart much smaller in Impress than Office 365
https://bugs.documentfoundation.org/show_bug.cgi?id=136191 --- Comment #5 from Aron Budea --- (In reply to Aron Budea from comment #4) > that to the See Also field. It's also good to CC the committer. The author, not the committer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136191] FILEOPEN PPTX: pie chart much smaller in Impress than Office 365
https://bugs.documentfoundation.org/show_bug.cgi?id=136191 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4029, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4225 Keywords||bisected Status|NEW |RESOLVED Resolution|--- |FIXED CC||balazs.varga...@gmail.com Whiteboard||target:7.1.0 --- Comment #4 from Aron Budea --- (In reply to BogdanB from comment #3) > Bibisected When a single commit has been identified as the culprit, please add the keyword 'bisected' as well, and if the commit is fixing another bug, add that to the See Also field. It's also good to CC the committer. https://cgit.freedesktop.org/libreoffice/core/commit/?id=2bb5d9624911eb78ce5a3cd0aa122f9307c50a5c author Balazs Varga 2020-06-16 12:07:45 +0200 committer Xisco Fauli 2020-06-25 12:18:50 +0200 "tdf#134029 Chart view: enable to move data label" Bug not reproducible in 7.1.0.0.alpha0+ (63d4d3421fec5a4e9e88dcee2992cda38cc7452a) / Ubuntu. However, label positioning isn't great, that might be worth a follow-up bug report. Reverse-bibisected the fix to the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=57fedb272cfcad3436142dbe9eac2870e3c3e3d2 author Balazs Varga 2020-06-23 15:02:59 +0200 committer László Németh2020-07-09 10:48:55 +0200 "tdf#134225 Chart view: fix moved date label" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/table/tdf135693.py | 37 +++
sw/qa/uitest/writer_tests/data/tdf135693.odt |binary
2 files changed, 37 insertions(+)
New commits:
commit 3ad21220992e348ccfc59ce5ffb67ee9dd0e4b88
Author: Xisco Fauli
AuthorDate: Fri Sep 11 16:49:26 2020 +0200
Commit: Xisco Fauli
CommitDate: Fri Sep 11 23:42:02 2020 +0200
tdf#135693: sw: Add UItest
Change-Id: If38daeb35ae8ba09aac50490a15c66dc0650f784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102485
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/uitest/table/tdf135693.py b/sw/qa/uitest/table/tdf135693.py
new file mode 100644
index ..31a6a176bb00
--- /dev/null
+++ b/sw/qa/uitest/table/tdf135693.py
@@ -0,0 +1,37 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+
+from uitest.framework import UITestCase
+from uitest.path import get_srcdir_url
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.common import get_state_as_dict
+
+def get_url_for_data_file(file_name):
+return get_srcdir_url() + "/sw/qa/uitest/writer_tests/data/" + file_name
+
+class tdf135693(UITestCase):
+
+def test_tdf135693(self):
+writer_doc =
self.ui_test.load_file(get_url_for_data_file("tdf135693.odt"))
+
+self.xUITest.getTopFocusWindow()
+
+self.xUITest.executeCommand(".uno:GoRight")
+self.xUITest.executeCommand(".uno:GoDown")
+
+# Without the fix in place, this would have crashed here
+self.ui_test.execute_dialog_through_command(".uno:TableDialog")
+
+xTableDlg = self.xUITest.getTopFocusWindow()
+
+xTabs = xTableDlg.getChild("tabcontrol")
+select_pos(xTabs, "0")
+
+# Check we are in the right table
+self.assertEqual("Table1",
get_state_as_dict(xTabs.getChild('name'))['Text'])
+
+xok = xTableDlg.getChild("ok")
+self.ui_test.close_dialog_through_button(xok)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sw/qa/uitest/writer_tests/data/tdf135693.odt
b/sw/qa/uitest/writer_tests/data/tdf135693.odt
new file mode 100644
index ..b13ed48e5c95
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf135693.odt differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136686] New: The "Strong" button when added to a toolbar applies "Strong Emphasis" not Strong
https://bugs.documentfoundation.org/show_bug.cgi?id=136686 Bug ID: 136686 Summary: The "Strong" button when added to a toolbar applies "Strong Emphasis" not Strong Product: LibreOffice Version: 7.0.0.3 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: david.s...@agingsafely.com I customized the Formatting(Styles) toolbar and added "Strong" to the toolbar. It applies the "Strong Emphsis" style not the "Strong" style. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136685] New: The "update all" button that can be added to toolbars does not update the Table of contents
https://bugs.documentfoundation.org/show_bug.cgi?id=136685 Bug ID: 136685 Summary: The "update all" button that can be added to toolbars does not update the Table of contents Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: david.s...@agingsafely.com I customized the Formatting(Styles) tollbar and added "Update All" so that I only had to click one place to update all of the TOC-like tables. Afte minimal testing I descovered that the TOC is not update. Cclicking on the TOC and right clicking "Update Index" works file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133049] Libreoffice Writer displays wrong glyph for GFS Didot (Lubuntu & qt5)
https://bugs.documentfoundation.org/show_bug.cgi?id=133049 --- Comment #21 from Jan-Marek Glogowski --- BTW: an alternative fix is to use Cairo rendering, like all unix backends do, by setting SAL_VCL_QT5_USE_CAIRO=1. Today I got the info, that this is the default for LO FreeBSD. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/windows-cross-build' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'feature/drop-findcmap'
New branch 'feature/drop-findcmap' available with the following commits: commit 45ab0cbd14a4f5327fd1b1ff6f8c16381caacb20 Author: Jan-Marek Glogowski Date: Fri Sep 11 22:34:11 2020 +0200 Qt5 implement GetGlyphWidths Basically implement it the same way then Windows and MacOS. Change-Id: I643581af49aeb9274505e90e12acbe5bcf0c98fb commit 0971b2a01783797745d3045dbbd9db39107b2d5e Author: Jan-Marek Glogowski Date: Fri Sep 11 22:31:51 2020 +0200 Forward existing FontCharMap from PhysicalFontFace Since removed code in the previous commit is primary used in CreateFontSubset and GetGlyphWidths, you have a high chance, that the CMAP was already used for displaying a font, so it's already decoded and can be forwarded. Also the lookup should be faster in general this way. Change-Id: Icf4d8a1a84ff6ccdaccb7e870abe5df3837f9541 commit a77525f373492f7b63b42c0d070eabaf3d98adbc Author: Jan-Marek Glogowski Date: Fri Sep 11 22:07:12 2020 +0200 Replace FindCmap with ParseCMAP This introduces a potential performance regression, because FindCmap works on the existing font tables and just sets up a lookup function, while ParseCMAP creates some optimized, unicode-only lookup table, which needs a bit more work, but is faster in it's usage. At least the initial usage is faster this way, as the CMAPs aren't decoded at all. As you can see, the old code is just used on Windows and MacOS / iOS. Deep in the bowels of the PrintFontManager, the CMAP is also decoded using ParseCMAP... so I'm not sure how hard this really hits. Change-Id: I52caac1264cd3ff11a2a3fa6e9c800f67f146a79 commit 22522ba049fede0a5e5bae04e5ce86971a767651 Author: Jan-Marek Glogowski Date: Fri Sep 11 17:24:59 2020 +0200 WIN OSX unify GetGlyphWidths code Now that GetFontChatMap is a member of PhysicalFontFace, we can copy the common part of both architectures into a SalGraphics helper function. Change-Id: Iad379ea690a1c5346b69b5042188506ccf575cc2 commit b8a43d5a7e9200886517efdc074de63b970d291f Author: Jan-Marek Glogowski Date: Mon Sep 7 23:56:20 2020 +0200 VCL register common functions in PhysicalFontFace This makes GetFontCapabilities and GetFontChatMap members of the PhysicalFontFace. These are implemented in all the real font face classes anyway. Also provide dummies for the PDF buildin fonts. Change-Id: Icb8cb14480ce1e020977b8f69892095d787982ce ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: About removing long time deprecated types from public API
sberg wrote
>> ...
> sounds ok at least to me
For replace sal_uChar, I could build and use "make check" for concerned
modules, so I submitted the patch on gerrit.
But replacing sal_Char triggers a lot of errors.
First one is:
In file included from /home/julien/lo/libreoffice/include/rtl/string.hxx:43:
/home/julien/lo/libreoffice/include/rtl/stringconcat.hxx:384:59: error: no
matching function for call to 'rtl_str_valueOfInt32'
OStringNumber(number_t i, sal_Int16 radix) { length =
rtl_str_valueOfInt32(buf, i, radix); }
^~~~
/home/julien/lo/libreoffice/include/rtl/string.h:623:34: note: candidate
function not viable: no known conversion from 'char [33]' to 'signed char *'
for 1st argument
SAL_DLLPUBLIC sal_Int32 SAL_CALL rtl_str_valueOfInt32(
^
So I first tried static_cast buf to "signed char*" but it's incorrect. So I
tried these changes:
diff --git a/include/rtl/stringconcat.hxx b/include/rtl/stringconcat.hxx
index e2cba5d86f0d..eadaae6eb2bb 100644
--- a/include/rtl/stringconcat.hxx
+++ b/include/rtl/stringconcat.hxx
@@ -366,14 +366,14 @@ template
struct OStringNumberBase
// OString::number(value).getStr() is very common (writing xml code,
...),
// so implement that one also here, to avoid having to explicitly to
convert
// to OString in all such places
-const char * getStr() const SAL_RETURNS_NONNULL { return buf; }
+const signed char * getStr() const SAL_RETURNS_NONNULL { return buf; }
OStringNumber&& toAsciiUpperCase()
{
rtl_str_toAsciiUpperCase_WithLength(buf, length);
return std::move(*static_cast*>(this));
}
operator std::string_view() const { return std::string_view(buf,
length); }
-char buf[nBufSize];
+signed char buf[nBufSize];
sal_Int32 length;
};
but not sure if it's ok and I still got plenty errors.
In brief, it seems I won't be able to get rid of sal_Char :-(
Julien
--
Sent from:
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 135565] Fonts preview and libreoffice cover illegible
https://bugs.documentfoundation.org/show_bug.cgi?id=135565 Caolán McNamara changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 135565, which changed state. Bug 135565 Summary: Fonts preview and libreoffice cover illegible https://bugs.documentfoundation.org/show_bug.cgi?id=135565 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118002] Crash in: ntdll.dll saving POTX file
https://bugs.documentfoundation.org/show_bug.cgi?id=118002 Caolán McNamara changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Caolán McNamara --- lets call it fixed then, backport of last two patches to 7-0 in gerrit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 118002, which changed state. Bug 118002 Summary: Crash in: ntdll.dll saving POTX file https://bugs.documentfoundation.org/show_bug.cgi?id=118002 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Bug 108226 depends on bug 118002, which changed state. Bug 118002 Summary: Crash in: ntdll.dll saving POTX file https://bugs.documentfoundation.org/show_bug.cgi?id=118002 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136684] watermark behaves like a virus here (it is not my own watermark !!! - made by a stranger ... )
https://bugs.documentfoundation.org/show_bug.cgi?id=136684 --- Comment #1 from Val --- Created attachment 165410 --> https://bugs.documentfoundation.org/attachment.cgi?id=165410=edit document of writer in *.txt format You please do not copy this document, otherwise you would get this nasty watermark too. I want to know, how I can remove this watermark in libreoffice ?! Or how to remove this at last attempt from command-line ?! It seems that libreoffice here in my desktop is infected with this watermark. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/fillproperties.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 32cdbc9c96898cf8bc2485b3df1be46c3c835ab0 Author: Caolán McNamara AuthorDate: Fri Sep 11 09:15:33 2020 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 11 22:35:52 2020 +0200 log what token was unexpected Change-Id: I192bd691816a044dbca389621730ca7ee3a584e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102453 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/oox/source/drawingml/fillproperties.cxx b/oox/source/drawingml/fillproperties.cxx index b6669210942a..655e177d94f3 100644 --- a/oox/source/drawingml/fillproperties.cxx +++ b/oox/source/drawingml/fillproperties.cxx @@ -1021,7 +1021,7 @@ sal_Int32 ArtisticEffectProperties::getEffectToken( const OUString& sName ) else if( sName == "amount" ) return XML_amount; -SAL_WARN( "oox.drawingml", "ArtisticEffectProperties::getEffectToken - unexpected token name" ); +SAL_WARN( "oox.drawingml", "ArtisticEffectProperties::getEffectToken - unexpected token name: " << sName ); return XML_none; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136684] New: watermark behaves like a virus here (it is not my own watermark !!! - made by a stranger ... )
https://bugs.documentfoundation.org/show_bug.cgi?id=136684 Bug ID: 136684 Summary: watermark behaves like a virus here (it is not my own watermark !!! - made by a stranger ... ) Product: LibreOffice Version: 6.4.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cv.schm...@gmail.com Description: hidden watermark is written in javascript apparently (or in CSS ?) Steps to Reproduce: 1. I create new document (with writer) 2. then watermark copies itself into new document 3. watermark cannot be removed (it is inside all my documents) 4. watermark is written by a lawyer with his bureau, he behaves with watermark like a hidden spy ?! (which cannot be removed ? - Antivirus program does not recognize the watermark) Actual Results: Watermark is nasty and I want to know, how can I remove it ? Expected Results: No results yet. Reproducible: Always User Profile Reset: No Additional Info: Where can I post example of document with nasty watermark ? Should be a protected area, where only Linux-User can watch it, without getting infected by watermark. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136666] Line numbering: setting for "include header/footer" is not saved with document
https://bugs.documentfoundation.org/show_bug.cgi?id=13 --- Comment #1 from Telesto --- And again not present in Version: 7.1.0.0.alpha0+ (x64) Build ID: ed4f610f4a3de12016f8308a17b6ad4f86e9d67a CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134293] Inconsistent double-click AutoFill behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=134293 --- Comment #2 from sora3...@gmail.com --- So I was trying a few situations based on the testcase. I was initially confused what it meant by double-clicking the handle, but I found highlighting the column and dragging it to the other columns worked just as well as manually inputting it in. Turns out the autofill varies depending on context: dragging it in means it works with the B17, but manual does not. Might do some additional testing but anyone can help. Version: 7.1.0.0.alpha0+ Build ID: 52820b52b3bca45e2db527d1cc5f4488b2e0b9d0 CPU threads: 8; OS: Mac OS X 10.15.6; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136683] LibreOffice crashes Windows to bluescreen on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=136683 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #3 from Telesto --- And if not, please check Force Skia Software rendering (in the Safe mode wizard) Looks like a driver issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114287] fo:text-indent and fo:margin-left from paragraph style has to overrule those from list style
https://bugs.documentfoundation.org/show_bug.cgi?id=114287 --- Comment #3 from Regina Henschel --- Still a problem, if fo:margin-left and fo:text-indent not directly in the automatic paragraph style, which has the style:list-style-name attribute, but is inherit from a custom style. Tested with Version: 7.0.0.2 (x64) Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 31231] Documents with charts open with the document set as already modified
https://bugs.documentfoundation.org/show_bug.cgi?id=31231 --- Comment #40 from Pierre C --- Just tested. It works fine LO 7.0, W10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136199] LibreOffice Impress: unable to select cells in Table
https://bugs.documentfoundation.org/show_bug.cgi?id=136199 BogdanB changed: What|Removed |Added Keywords||bibisectRequest, regression Whiteboard| QA:needsComment| --- Comment #3 from BogdanB --- I tried to bibisect this bug with 7.0 (all good) and 7.1 (all bad). I don't understand. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136683] LibreOffice crashes Windows to bluescreen on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=136683 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 CC||serval2...@yahoo.fr Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Julien Nabet --- Do you reproduce this in safe mode? Could you also give a try at https://wiki.documentfoundation.org/QA/FirstSteps? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 31092] Creating 3D smooth lines chart takes several minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=31092 --- Comment #15 from Pierre C --- Yep, still in LO 7.0 Over 20 secondes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/css
loleaflet/css/toolbar.css |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5f999ceacc79a7994d151ce634b29cc73a251536
Author: Andras Timar
AuthorDate: Fri Sep 11 20:55:18 2020 +0200
Commit: Andras Timar
CommitDate: Fri Sep 11 22:10:31 2020 +0200
lc_starshapes.signet.svg is the correct icon for the signet shape
Change-Id: I599a0408fe6eb4fd26a45ce0d80cee89c1edfdc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102427
Tested-by: Jenkins CollaboraOffice
Tested-by: Andras Timar
Reviewed-by: Andras Timar
diff --git a/loleaflet/css/toolbar.css b/loleaflet/css/toolbar.css
index f2d8a1bae..5f3135989 100644
--- a/loleaflet/css/toolbar.css
+++ b/loleaflet/css/toolbar.css
@@ -492,7 +492,7 @@ button.leaflet-control-search-next
.w2ui-icon.starshapes_concave-star6 { background:
url('images/lc_starshapes.concave-star6.svg') no-repeat center !important; }
.w2ui-icon.starshapes_vertical-scroll { background:
url('images/lc_starshapes.vertical-scroll.svg') no-repeat center !important; }
.w2ui-icon.starshapes_horizontal-scroll { background:
url('images/lc_starshapes.horizontal-scroll.svg') no-repeat center !important; }
-.w2ui-icon.starshapes_signet { background: url('images/lc_signature.svg')
no-repeat center !important; }
+.w2ui-icon.starshapes_signet { background:
url('images/lc_starshapes.signet.svg' ) no-repeat center !important; }
.w2ui-icon.starshapes_doorplate { background:
url('images/lc_starshapes.doorplate.svg') no-repeat center !important; }
.w2ui-icon.calloutshapes_rectangular-callout { background:
url('images/lc_calloutshapes.rectangular-callout.svg') no-repeat center
!important; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136199] LibreOffice Impress: unable to select cells in Table
https://bugs.documentfoundation.org/show_bug.cgi?id=136199 BogdanB changed: What|Removed |Added Version|7.0.0.3 release |7.0.1.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/impex.cxx | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
New commits:
commit 2cb743eea3396541e155c24773b54de0663c7475
Author: Eike Rathke
AuthorDate: Fri Sep 11 20:24:22 2020 +0200
Commit: Eike Rathke
CommitDate: Fri Sep 11 22:05:55 2020 +0200
Make arbitrary cell length limit in CSV import a constexpr
... so we could up that in one place if we really wanted.
Usually exceeding that length is due to malformed data opening a
quoted field without closing it. However, there might be valid
reasons to allow more than 64k characters in one cell, but think
about a *reasonable* limit, not 2GB ...
Change-Id: I7f9ea80ab2f7a4eb34d93203286c973ea03f1ce0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102495
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 98b65f929346..fbd30d4234d0 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -66,10 +66,11 @@
// We don't want to end up with 2GB read in one line just because of malformed
// multiline fields, so chop it _somewhere_, which is twice supported columns
-// times maximum cell content length, 2*1024*64K=128M, and because it's
-// sal_Unicode that's 256MB. If it's 2GB of data without LF we're out of luck
-// anyway.
-const sal_Int32 nArbitraryLineLengthLimit = 2 * MAXCOLCOUNT * 65536;
+// times arbitrary maximum cell content length, 2*1024*64K=128M, and because
+// it's sal_Unicode that's 256MB. If it's 2GB of data without LF we're out of
+// luck anyway.
+constexpr sal_Int32 nArbitraryCellLengthLimit = SAL_MAX_UINT16;
+constexpr sal_Int32 nArbitraryLineLengthLimit = 2 * MAXCOLCOUNT *
nArbitraryCellLengthLimit;
namespace
{
@@ -632,15 +633,15 @@ static QuoteType lcl_isEscapedOrFieldEndQuote( sal_Int32
nQuotes, const sal_Unic
*/
static bool lcl_appendLineData( OUString& rField, const sal_Unicode* p1, const
sal_Unicode* p2 )
{
-OSL_ENSURE( rField.getLength() + (p2 - p1) <= SAL_MAX_UINT16,
"lcl_appendLineData: data overflow");
-if (rField.getLength() + (p2 - p1) <= SAL_MAX_UINT16)
+if (rField.getLength() + (p2 - p1) <= nArbitraryCellLengthLimit)
{
rField += OUString( p1, sal::static_int_cast( p2 - p1 ) );
return true;
}
else
{
-rField += OUString( p1, SAL_MAX_UINT16 - rField.getLength() );
+SAL_WARN( "sc", "lcl_appendLineData: data overflow");
+rField += OUString( p1, nArbitraryCellLengthLimit - rField.getLength()
);
return false;
}
}
@@ -1274,26 +1275,26 @@ static OUString lcl_GetFixed( const OUString& rLine,
sal_Int32 nStart, sal_Int32
rbIsQuoted = (pStr[nStart] == '"' && pStr[nSpace-1] == '"');
if (rbIsQuoted)
{
-bool bFits = (nSpace - nStart - 3 <= SAL_MAX_UINT16);
-OSL_ENSURE( bFits, "lcl_GetFixed: line doesn't fit into data");
+bool bFits = (nSpace - nStart - 3 <= nArbitraryCellLengthLimit);
if (bFits)
return rLine.copy(nStart+1, std::max< sal_Int32 >(0,
nSpace-nStart-2));
else
{
+SAL_WARN( "sc", "lcl_GetFixed: line doesn't fit into data");
rbOverflowCell = true;
-return rLine.copy(nStart+1, SAL_MAX_UINT16);
+return rLine.copy(nStart+1, nArbitraryCellLengthLimit);
}
}
else
{
-bool bFits = (nSpace - nStart <= SAL_MAX_UINT16);
-OSL_ENSURE( bFits, "lcl_GetFixed: line doesn't fit into data");
+bool bFits = (nSpace - nStart <= nArbitraryCellLengthLimit);
if (bFits)
return rLine.copy(nStart, nSpace-nStart);
else
{
+SAL_WARN( "sc", "lcl_GetFixed: line doesn't fit into data");
rbOverflowCell = true;
-return rLine.copy(nStart, SAL_MAX_UINT16);
+return rLine.copy(nStart, nArbitraryCellLengthLimit);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136199] LibreOffice Impress: unable to select cells in Table
https://bugs.documentfoundation.org/show_bug.cgi?id=136199 --- Comment #2 from BogdanB --- Works in Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Works in Version: 6.4.4.1 Build ID: b50bc319eca5cd5b66fbfe2ebd0d3bd1eed099b5 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US Calc: threaded Works in Version: 6.3.5.2 Build ID: dd0751754f11728f69b42ee2af66670068624673 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/overlay/overlaymanager.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 0a7752b39884cfb7d4d679683fb216a44a85326a Author: Stephan Bergmann AuthorDate: Fri Sep 11 18:24:32 2020 +0200 Commit: Stephan Bergmann CommitDate: Fri Sep 11 22:05:29 2020 +0200 Handle empty rRange in OverlayManager::RangeToInvalidateRectangle Not sure why it started to happen just now, but my Linux UBSan build now failed CppunitTest_sd_tiledrendering with > svx/source/sdr/overlay/overlaymanager.cxx:290:44: runtime error: 1.79769e+308 is outside the range of representable values of type 'int' > #0 in sdr::overlay::OverlayManager::RangeToInvalidateRectangle(basegfx::B2DRange const&) const at svx/source/sdr/overlay/overlaymanager.cxx:290:44 > #1 in sdr::overlay::OverlayManager::invalidateRange(basegfx::B2DRange const&) at svx/source/sdr/overlay/overlaymanager.cxx:311:55 > #2 in sdr::overlay::OverlayManager::impApplyRemoveActions(sdr::overlay::OverlayObject&) at svx/source/sdr/overlay/overlaymanager.cxx:186:13 > #3 in sdr::overlay::OverlayManager::~OverlayManager() at svx/source/sdr/overlay/overlaymanager.cxx:224:21 > #4 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:377:9 > #5 in sdr::overlay::OverlayManagerBuffered::~OverlayManagerBuffered() at svx/source/sdr/overlay/overlaymanagerbuffered.cxx:368:9 > #6 in salhelper::SimpleReferenceObject::release() at include/salhelper/simplereferenceobject.hxx:72:49 > #7 in rtl::Reference::clear() at include/rtl/ref.hxx:180:19 > #8 in SdrPaintWindow::~SdrPaintWindow() at svx/source/svdraw/sdrpaintwindow.cxx:251:22 [...] > #16 in SdrPaintView::DeletePaintWindow(SdrPaintWindow&) at svx/source/svdraw/svdpntv.cxx:83:24 > #17 in SdrPaintView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdpntv.cxx:417:9 > #18 in SdrObjEditView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/svdraw/svdedxv.cxx:2316:22 > #19 in FmFormView::DeleteWindowFromPaintView(OutputDevice*) at svx/source/form/fmview.cxx:196:14 > #20 in sd::View::~View() at sd/source/ui/view/sdview.cxx:148:9 > #21 in sd::DrawView::~DrawView() at sd/source/ui/view/drawview.cxx:75:1 > #22 in sd::DrawView::~DrawView() at sd/source/ui/view/drawview.cxx:74:1 [...] > #34 in sd::framework::BasicViewFactory::releaseResource(com::sun::star::uno::Reference const&) at sd/source/ui/framework/factories/BasicViewFactory.cxx:229:1 > #35 in sd::framework::ConfigurationControllerResourceManager::DeactivateResource(com::sun::star::uno::Reference const&, com::sun::star::uno::Reference const&) at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:201:48 > #36 in sd::framework::ConfigurationControllerResourceManager::DeactivateResources(std::__debug::vector, std::allocator > > const&, com::sun::star::uno::Reference const&)::$_0::operator()(com::sun::star::uno::Reference const&) const at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:88:20 [...] > #38 in sd::framework::ConfigurationControllerResourceManager::DeactivateResources(std::__debug::vector, std::allocator > > const&, com::sun::star::uno::Reference const&) at sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx:84:5 > #39 in sd::framework::ConfigurationUpdater::UpdateCore(sd::framework::ConfigurationClassifier const&) at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:249:28 > #40 in sd::framework::ConfigurationUpdater::UpdateConfiguration() at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:160:21 > #41 in sd::framework::ConfigurationUpdater::RequestUpdate(com::sun::star::uno::Reference const&) at sd/source/ui/framework/configuration/ConfigurationUpdater.cxx:107:13 > #42 in sd::framework::ChangeRequestQueueProcessor::ProcessOneEvent() at sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx:161:33 > #43 in sd::framework::ChangeRequestQueueProcessor::ProcessUntilEmpty() at sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx:173:9 > #44 in sd::framework::ConfigurationController::disposing() at sd/source/ui/framework/configuration/ConfigurationController.cxx:126:41 > #45 in cppu::WeakComponentImplHelperBase::dispose() at cppuhelper/source/implbase.cxx:104:13 > #46 in cppu::PartialWeakComponentImplHelper::dispose() at include/cppuhelper/compbase.hxx:90:36 > #47 in sd::DrawController::DisposeFrameworkControllers() at sd/source/ui/unoidl/DrawController.cxx:814:21 > #48 in sd::DrawController::dispose() at sd/source/ui/unoidl/DrawController.cxx:162:5 > #49 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference const&, com::sun::star::uno::Reference const&) at
[Libreoffice-commits] online.git: loleaflet/css
loleaflet/css/toolbar.css |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 04e4cab105a7f9295cd0280276d4d4a230e92ad4
Author: Andras Timar
AuthorDate: Fri Sep 11 20:55:18 2020 +0200
Commit: Andras Timar
CommitDate: Fri Sep 11 22:04:07 2020 +0200
lc_starshapes.signet.svg is the correct icon for the signet shape
Change-Id: I599a0408fe6eb4fd26a45ce0d80cee89c1edfdc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102496
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/loleaflet/css/toolbar.css b/loleaflet/css/toolbar.css
index d3a9f733b..343ebd8d6 100644
--- a/loleaflet/css/toolbar.css
+++ b/loleaflet/css/toolbar.css
@@ -525,7 +525,7 @@ button.leaflet-control-search-next
.w2ui-icon.starshapes_concave-star6 { background:
url('images/lc_starshapes.concave-star6.svg') no-repeat center !important; }
.w2ui-icon.starshapes_vertical-scroll { background:
url('images/lc_starshapes.vertical-scroll.svg') no-repeat center !important; }
.w2ui-icon.starshapes_horizontal-scroll { background:
url('images/lc_starshapes.horizontal-scroll.svg') no-repeat center !important; }
-.w2ui-icon.starshapes_signet { background: url('images/lc_signature.svg')
no-repeat center !important; }
+.w2ui-icon.starshapes_signet { background:
url('images/lc_starshapes.signet.svg' ) no-repeat center !important; }
.w2ui-icon.starshapes_doorplate { background:
url('images/lc_starshapes.doorplate.svg') no-repeat center !important; }
.w2ui-icon.calloutshapes_rectangular-callout { background:
url('images/lc_calloutshapes.rectangular-callout.svg') no-repeat center
!important; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136683] LibreOffice crashes Windows to bluescreen on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=136683 --- Comment #1 from BDF --- Created attachment 165409 --> https://bugs.documentfoundation.org/attachment.cgi?id=165409=edit The blue screen I get after opening LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136683] New: LibreOffice crashes Windows to bluescreen on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=136683 Bug ID: 136683 Summary: LibreOffice crashes Windows to bluescreen on startup Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bugs_documentfoundation_org.5.k...@xoxy.net Description: When I startup LibreOffice it crashes my system to a bluescreen (see image). I recently updated from version 6.4.4.2 to 7.0.1. I uninstalled the old release and installed the new release. Now LibreOffice crashes my system everytime on startup. Steps to Reproduce: 1. Start LibreOffice (open a file, start the the component (eg. Calc or Writer) directly, start the LibreOffice app directly) Actual Results: Blue Screen of Death Expected Results: A bit less blue screen and a bit less crash would be nice Reproducible: Always User Profile Reset: No Additional Info: Not sure if that matters: I had my browser open when I uninstalled LibreOffice. The uninstaller told me that I had to close the browser or my restart my PC. I did neither. I installed the new version. The installer told me the same thing. I did not do it again. I wanted to open a file and got a crash right away. I installed new versions of LibreOffice the same way a few times before without any problems. I tried to restart/shutdown the PC to check if that helps when it does not crash for once (it does not). - - - - - - - - - - - - - - - - - - - - - - - - - I installed the new version on a PC with Windows 7 and I used the x64.msi installer for it. I did not try to uninstall and reinstall the programm or reset any config files yet (maybe there is somebody who has an idea for a test before I do that and it works) I obviously can't copy any version information from the programm. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136199] LibreOffice Impress: unable to select cells in Table
https://bugs.documentfoundation.org/show_bug.cgi?id=136199 BogdanB changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||buzea.bog...@libreoffice.or ||g --- Comment #1 from BogdanB --- It works in Version: 7.0.1.2 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (ro_RO.UTF-8); UI: en-US Calc: threaded Doesn't work in Version: 7.1.0.0.alpha0+ Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109305] The column attribute style:rel-column-width is wrongly read
https://bugs.documentfoundation.org/show_bug.cgi?id=109305 --- Comment #5 from Regina Henschel --- The error still exists in Version: 7.0.0.2 (x64) Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - include/svtools svtools/source
include/svtools/valueset.hxx|2 ++
svtools/source/control/valueset.cxx | 36
2 files changed, 22 insertions(+), 16 deletions(-)
New commits:
commit 51c17d2bdb35fdb4ab21a94d3bba40f97dc5c138
Author: Caolán McNamara
AuthorDate: Tue Sep 8 20:24:14 2020 +0100
Commit: Adolfo Jayme Barrientos
CommitDate: Fri Sep 11 21:49:13 2020 +0200
tdf#134413 must add scrollbar width on turning it off to occupy the same
space
when scrollbars have width
Change-Id: I3f9f6951add23f8ac93a03cf3356add5a2b3ddd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102288
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/include/svtools/valueset.hxx b/include/svtools/valueset.hxx
index 6c6055d0d982..b27885d9b72b 100644
--- a/include/svtools/valueset.hxx
+++ b/include/svtools/valueset.hxx
@@ -256,6 +256,8 @@ private:
SVT_DLLPRIVATE void QueueReformat();
SVT_DLLPRIVATE void SetFirstLine(sal_uInt16 nNewFirstLine); // set
mnFirstLine and update scrollbar to match
SVT_DLLPRIVATE void RecalcScrollBar();
+SVT_DLLPRIVATE void TurnOffScrollBar();
+SVT_DLLPRIVATE void TurnOnScrollBar();
DECL_DLLPRIVATE_LINK(ImplScrollHdl, weld::ScrolledWindow&, void);
Size GetLargestItemSize();
diff --git a/svtools/source/control/valueset.cxx
b/svtools/source/control/valueset.cxx
index 00bd7226478a..dde904d2b9a2 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -539,13 +539,29 @@ void ValueSet::RemoveItem( sal_uInt16 nItemId )
QueueReformat();
}
+void ValueSet::TurnOffScrollBar()
+{
+mxScrolledWindow->set_vpolicy(VclPolicyType::NEVER);
+weld::DrawingArea* pDrawingArea = GetDrawingArea();
+Size aPrefSize(pDrawingArea->get_preferred_size());
+pDrawingArea->set_size_request(aPrefSize.Width() + GetScrollWidth(),
aPrefSize.Height());
+}
+
+void ValueSet::TurnOnScrollBar()
+{
+mxScrolledWindow->set_vpolicy(VclPolicyType::ALWAYS);
+weld::DrawingArea* pDrawingArea = GetDrawingArea();
+Size aPrefSize(pDrawingArea->get_preferred_size());
+pDrawingArea->set_size_request(aPrefSize.Width() - GetScrollWidth(),
aPrefSize.Height());
+}
+
void ValueSet::RecalcScrollBar()
{
// reset scrolled window state to initial value
// so it will get configured to the right adjustment
WinBits nStyle = GetStyle();
if (mxScrolledWindow && (nStyle & WB_VSCROLL))
-mxScrolledWindow->set_vpolicy(VclPolicyType::NEVER);
+TurnOffScrollBar();
}
void ValueSet::Clear()
@@ -841,11 +857,7 @@ void ValueSet::Format(vcl::RenderContext const &
rRenderContext)
long nNoneSpace;
if (mxScrolledWindow && !(nStyle & WB_VSCROLL) &&
mxScrolledWindow->get_vpolicy() != VclPolicyType::NEVER)
-{
-mxScrolledWindow->set_vpolicy(VclPolicyType::NEVER);
-Size aPrefSize(GetDrawingArea()->get_preferred_size());
-GetDrawingArea()->set_size_request(aPrefSize.Width() +
GetScrollWidth(), aPrefSize.Height());
-}
+TurnOffScrollBar();
// calculate item offset
if (nStyle & WB_ITEMBORDER)
@@ -995,11 +1007,7 @@ void ValueSet::Format(vcl::RenderContext const &
rRenderContext)
}
if (mxScrolledWindow && mxScrolledWindow->get_vpolicy() !=
VclPolicyType::NEVER)
-{
-mxScrolledWindow->set_vpolicy(VclPolicyType::NEVER);
-Size aPrefSize(GetDrawingArea()->get_preferred_size());
-GetDrawingArea()->set_size_request(aPrefSize.Width() +
GetScrollWidth(), aPrefSize.Height());
-}
+TurnOffScrollBar();
}
else
{
@@ -1151,11 +1159,7 @@ void ValueSet::Format(vcl::RenderContext const &
rRenderContext)
}
if (bTurnScrollbarOn)
-{
-mxScrolledWindow->set_vpolicy(VclPolicyType::ALWAYS);
-Size aPrefSize(GetDrawingArea()->get_preferred_size());
-GetDrawingArea()->set_size_request(aPrefSize.Width() -
GetScrollWidth(), aPrefSize.Height());
-}
+TurnOnScrollBar();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 136674] Incorrect character displayed -- autocorrect single closing quote
https://bugs.documentfoundation.org/show_bug.cgi?id=136674 --- Comment #7 from V Stuart Foote --- (In reply to Dennis Rice from comment #6) DO NOT use email to reply, rather use the Bugzilla interface. BZ then sends the courtesy email copies to subscribed addresses. Everything you need for corresponding is provided in the BZ. Personal messages are discouraged and considered rude (by wasting peoples time). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
