[Libreoffice-bugs] [Bug 135110] ENHANCEMENT: Right Click context menu in the style inspector to modify style

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135110

--- Comment #15 from Mike Kaganski  ---
(In reply to Thomas Lendo from comment #14)
> Without the possibility of changing or deleting single values the Style
> Inspector is only a bloated variant of the Contains section in the Organizer
> tab of the style dialog. And this restriction of this Contains section has
> led to several bug reports here.

The "edit/delete single values" needs consideration. Because there are both DF
and styles there; do you suggest to allow editing both? and the "single"
entries there are sometimes parts of complex ones, so in UI, you modify several
using a single control - are we going to allow really great flexibility of
creating a UI to tweak those values independently - allowing "non-standard"
combinations not possible with current UI, or are we going to create an
involved logic that would limit the possible changes?

I feel that "all or nothing" is the worst attitude possible. We must implement
the first - safe - step, then proceed to consideration/discussion of the next
one, independently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/inc

2020-10-14 Thread Julien Nabet (via logerrit)
 vcl/inc/impdel.hxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit ce98648b85169fa0fb8b5d2de179b280a682bde0
Author: Julien Nabet 
AuthorDate: Sun Oct 11 13:15:38 2020 +0200
Commit: Julien Nabet 
CommitDate: Thu Oct 15 07:16:25 2020 +0200

Replace list by vector in vcl/impdel

Change-Id: I91f5859413ec3265647b8d55225b29ee95a06857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104182
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/vcl/inc/impdel.hxx b/vcl/inc/impdel.hxx
index 308872b9c9eb..62925c24a427 100644
--- a/vcl/inc/impdel.hxx
+++ b/vcl/inc/impdel.hxx
@@ -20,7 +20,8 @@
 #ifndef INCLUDED_VCL_IMPDEL_HXX
 #define INCLUDED_VCL_IMPDEL_HXX
 
-#include 
+#include 
+#include 
 
 namespace vcl
 {
@@ -29,7 +30,7 @@ class DeletionListener;
 
 class DeletionNotifier
 {
-std::list< DeletionListener* > m_aListeners;
+std::vector< DeletionListener* > m_aListeners;
 protected:
 DeletionNotifier() {}
 
@@ -43,7 +44,7 @@ class DeletionNotifier
 { m_aListeners.push_back( pListener ); }
 
 void removeDel( DeletionListener* pListener )
-{ m_aListeners.remove( pListener ); }
+{ m_aListeners.erase(std::remove(m_aListeners.begin(), m_aListeners.end(), 
pListener), m_aListeners.end()); }
 };
 
 class DeletionListener
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137331] MacOS Big Sur Beta 11 Libre Office crashes on print

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137331

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #12 from Julien Nabet  ---
Thank you for your feedback.
Let's put this one to WFM then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137491] Please consider not hiding comments during save operation

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137491

--- Comment #1 from Luke Kendall  ---
I should add, Writer only seems to do this for .odt format files, not .docx
files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Whiteboard||target:7.0.0
 Status|NEW |RESOLVED

--- Comment #22 from Aron Budea  ---
I agree. Reverse bibisected the fix with repo bibisect-linux-64-7.0 to the
following commit. Let's close as FIXED.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b77d17c4f1ca734babf962b45c1aa07bdca14e9
author  Michael Meeks  2020-01-04
18:09:20 +
committer   Michael Meeks  2020-01-06
19:16:28 +0100

sidebar: allow panels to lurk around instead of being disposed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137491] New: Please consider not hiding comments during save operation

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137491

Bug ID: 137491
   Summary: Please consider not hiding comments during save
operation
   Product: LibreOffice
   Version: 6.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: luke.kend...@gmail.com

When you save a document, for some reason one or two seconds into the save
operation, Writer hides any visible comments, redrawing them only when the save
is complete.

If you're reading a long comment while a save completes (which can take a long
time), it means you just have to wait before you can continue reading the
comment.

I don't understand why Writer goes to the trouble of redrawing the window with
comments hidden from display, soon after the start of the save.  It's a small
counterproductive action, in my opinion.

Unless there's a good reason for it, perhaps the hide and redraw could be
removed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108636
Bug 108636 depends on bug 105500, which changed state.

Bug 105500 Summary: Small but noticeable lag when selecting shapes with sidebar 
enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108741
Bug 108741 depends on bug 105500, which changed state.

Bug 105500 Summary: Small but noticeable lag when selecting shapes with sidebar 
enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137158] Notebookbar contextual groups: Style, alignment and text formatting status not visible

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137158

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137157] CENTER ALIGNMENT not working in paragraphs containing line breaks: RESET mysteriously corrects it

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137157

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136582] Styles inspector doesn't show highlighting in header

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136582

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137149] Basic macro: command to Flip a selection

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137149

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137164] CALC: upgrades destroy graph color schemes

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137164

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137420] Pivot Table named range does not list database ranges

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137420

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136711] Direct formatting is partly deleted when replacing paragraph style

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136711

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136569] UI: Style inspector; short list for; most common formatting

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136569

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137473] Copy/Paste function incorrect after cell coping

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137473

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137473] Copy/Paste function incorrect after cell coping

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137473

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137331] MacOS Big Sur Beta 11 Libre Office crashes on print

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137331

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137331] MacOS Big Sur Beta 11 Libre Office crashes on print

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137331

--- Comment #11 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131298] Error message with undo Ctrl+Z

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131298

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137420] Pivot Table named range does not list database ranges

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137420

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132200] Crash if i want to close the print preview by clicking the "Print Preview"-Button again to exit

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132200

--- Comment #3 from QA Administrators  ---
Dear PartialB,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132205] Filters are not working in my excel sheet

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132205

--- Comment #2 from QA Administrators  ---
Dear Rajesh murmu,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132171] Date Format DD/MM/YYYY not working

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132171

--- Comment #2 from QA Administrators  ---
Dear rikster08,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131298] Error message with undo Ctrl+Z

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131298

--- Comment #9 from QA Administrators  ---
Dear Mayan_Tigger,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 126223] Problem with apostrophe key

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126223

--- Comment #6 from QA Administrators  ---
Dear maurigo conchaud,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132047] Crash in: mergedlo.dll

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132047

--- Comment #2 from QA Administrators  ---
Dear Peter Toye,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137483] Document freezes requiring document closure and reboot in order to continue typing

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137483

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Please provide the text copied from the Help -> About LibreOffice

Also, the Graphics card and driver for your system (available from running
msinfo32.exe and copying the Components -> Display content).

Lastly, see if disabling the Skia GPU support, from Tools -> Options -> View
and uncheck the 'Use Skia for all rendering' box and a restart, resolves the
freeze.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137331] MacOS Big Sur Beta 11 Libre Office crashes on print

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137331

--- Comment #10 from jse...@gmail.com ---
FYI - whatever developer beta apple released today (think it's dev beta 10,
October 14, 2020), has made this problem go away. Command-P or file-print
behaves as expected (brings out the print dialogue, no crash).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137490] New: [UI] Groupedbar user interface uses "Header 1/2" menu items for "Heading 1/2" cell styles

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137490

Bug ID: 137490
   Summary: [UI] Groupedbar user interface uses "Header 1/2" menu
items for "Heading 1/2" cell styles
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ming.v@qq.com

The menu items under "Styles" in Groupedbar user interface has "Header 1" and
"Header 2", which corresponds to "Heading 1" and "Heading 2" cell styles.  This
unnecessary term mismatch causes confusion.

Steps to reproduce:
1. Make sure experimental features are enabled from Tools > Options >
LibreOffice > Advanced;
2. Switch to Groupedbar UI via menu View > User Interface > Groupedbar (NOT
Groupedbar Compact);
3. Click on the "Styles" dropdown button from the Groupedbar interface, see
"Header 1" and "Header 2" items;
4. Choose one of them, then check the cell style to see they are actually
applied with "Heading 1/2" style.

Reproduced with both 6.4.6 and 7.0.2 under Windows 10:
Version: 6.4.6.2 (x64)
Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: zh-CN (zh_CN); UI-Language: en-US
Calc: threaded
and
Version: 7.0.2.2 (x64)
Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994
CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); 界面: zh-CN
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137489] Writer doesn't spell check Spanish

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137489

oconcepc...@momatos.com changed:

   What|Removed |Added

Summary|Writer doesn't spell checks |Writer doesn't spell check
   |Spanish |Spanish

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Conference Guide

2020-10-14 Thread Italo Vignoli
We have created a Conference Guide, which can help you to make the best
out of the upcoming event. The PDF is available from the following link:
https://nextcloud.documentfoundation.org/s/pyLtF7jMei5XtcZ.

-- 
Italo Vignoli - LibreOffice Marketing & PR
mobile/signal +39.348.5653829 - email it...@libreoffice.org
hangout/jabber italo.vign...@gmail.com - skype italovignoli
GPG Key ID - 0xAAB8D5C0
DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 137489] Writer doesn't spell checks Spanish

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137489

--- Comment #1 from oconcepc...@momatos.com ---
Created attachment 166374
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166374=edit
Spelling window and About window

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129940] FILEOPEN: Cell content in ODS exported by Excel with Asian phonetic guide ​​is displayed as empty

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129940

--- Comment #11 from Shinji Enoki  ---
Reproduced in the following environment

Version: 7.1.0.0.alpha0+
Build ID: 231a4e024b85aa0ad06a5632d3f514152babea30
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2020-10-14_08:06:21
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137489] New: Writer doesn't spell checks Spanish

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137489

Bug ID: 137489
   Summary: Writer doesn't spell checks Spanish
   Product: LibreOffice
   Version: 7.0.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oconcepc...@momatos.com

Description:
Although the default language in LibreOffice's configuration is Spanish (and it
appears this way in the status bar), the program does not check the spelling.
However, when it comes to documents in English, the spell checker does work.
Automatic Spell Checking is selected in the "Tools" menu.
When I invoke Spell Checking by hitting F7 key the Spelling window shows Text
language as "[None]" and dropdown menu offers English language versions only
(See image).
I re-ran installation and confirmed that Spanish dictionary was originally
selected to install. Ran "Repair" installation and the problem persists.

Actual Results:
Spell Checker doesn't work

Expected Results:
Doesn't work yet


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: Spanish (Dom. Rep.)
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137267] clipboard error on paste into a cell

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137267

neuf...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Severity|normal  |minor
 Status|UNCONFIRMED |NEW

--- Comment #1 from neuf...@gmail.com ---
Thank you for reporting the bug. I can confirm that the bug is present in:
Version: 7.0.1.2 (x64)
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Also in:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: fca525d570f4fada3db1a9bbee2e88a5a02839d9
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Instructions were a little difficult to parse but the bug does exist.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113209] [META] UI bugs and enhancements

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113209

Thomas Lendo  changed:

   What|Removed |Added

 Depends on|130744  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130744
[Bug 130744] [META] Screenshot Issues Meta Bug
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106040] [META] Help bugs and enhancements

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106040

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||130744


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130744
[Bug 130744] [META] Screenshot Issues Meta Bug
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 130744] [META] Screenshot Issues Meta Bug

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130744

Thomas Lendo  changed:

   What|Removed |Added

 Blocks|113209  |106040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106040
[Bug 106040] [META] Help bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113209
[Bug 113209] [META] UI bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sw/qa sw/source

2020-10-14 Thread Attila Bakos (via logerrit)
 sw/qa/extras/layout/data/tdf136588.docx |binary
 sw/qa/extras/layout/layout.cxx  |   11 +++
 sw/source/core/txtnode/fntcache.cxx |7 +++
 3 files changed, 18 insertions(+)

New commits:
commit b16a19330820b3b7d11ca342ac0f26b13afd4f42
Author: Attila Bakos 
AuthorDate: Tue Sep 22 16:37:22 2020 +0200
Commit: Gabor Kelemen 
CommitDate: Wed Oct 14 23:28:30 2020 +0200

tdf#136588 sw: fix line break regression with small caps

Regression from commit 1b03a449161af225302e4b4dd2bb2e69c6d8d170
(tdf#112290 sw: fix missing line break in small capital).

This replaces the previous commit with a better solution.

Change-Id: I7510b78cd6520f260e6a3804ec69e0364b93440f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103178
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit 0d28097fadf44ed58cb5e3e9b9c04a65a7a33fd6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104329
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/sw/qa/extras/layout/data/tdf136588.docx 
b/sw/qa/extras/layout/data/tdf136588.docx
new file mode 100644
index ..606931286470
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf136588.docx differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 3a35e5d8b297..ccab53a7f920 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -204,6 +204,17 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testRedlineFootnotes)
 CheckRedlineFootnotesHidden();
 }
 
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, TestTdf136588)
+{
+load(DATA_DIRECTORY, "tdf136588.docx");
+auto pXMLLayoutDump = parseLayoutDump();
+CPPUNIT_ASSERT(pXMLLayoutDump);
+
+//there was a bad line break before, the correct break layout is this:
+assertXPath(pXMLLayoutDump, "/root/page/body/txt[2]/LineBreak[2]", "Line",
+"effectively by modern-day small to ");
+}
+
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testRedlineFlysInBody)
 {
 loadURL("private:factory/swriter", nullptr);
diff --git a/sw/source/core/txtnode/fntcache.cxx 
b/sw/source/core/txtnode/fntcache.cxx
index 6fa6b159705a..ccd509449048 100644
--- a/sw/source/core/txtnode/fntcache.cxx
+++ b/sw/source/core/txtnode/fntcache.cxx
@@ -2536,6 +2536,13 @@ TextFrameIndex SwFont::GetTextBreak(SwDrawTextInfo const 
& rInf, long nTextWidth
 ? TextFrameIndex(COMPLETE_STRING)
 : nTextBreak;
 
+// tdf112290 tdf136588 Break the line correctly only if there is an image 
inline,
+// and the image wider than the line...
+if (GetCaseMap() == SvxCaseMap::SmallCaps && 
TextFrameIndex(COMPLETE_STRING) == nTextBreak2 &&
+! bCompress && nTextWidth == 0)
+// If nTextWidth == 0 means the line is full, we have to break it
+nTextBreak2 = TextFrameIndex(1);
+
 if ( ! bCompress )
 return nTextBreak2;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137482] Opening csv with semicolon delimiter formats column value wrong sometimes

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137482

--- Comment #5 from Uwe Auer  ---
Created attachment 166373
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166373=edit
Import Filter Setting for Text Fild

Please see the attachment for the import filter setting *Column type: Text* to
import "57,101" as "57,101".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137482] Opening csv with semicolon delimiter formats column value wrong sometimes

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137482

Uwe Auer  changed:

   What|Removed |Added

 Attachment #166373|Import Filter Setting for   |Import Filter Setting for
description|Text Fild   |Text Field

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - chart2/qa oox/source

2020-10-14 Thread Daniel Arato (NISZ) (via logerrit)
 chart2/qa/extras/chart2export.cxx   |   14 ++
 chart2/qa/extras/data/odp/tdf121189.odp |binary
 oox/source/export/shapes.cxx|1 +
 3 files changed, 15 insertions(+)

New commits:
commit 9ca974ddb5ba89b09c1c2cfd7efced5895fbead5
Author: Daniel Arato (NISZ) 
AuthorDate: Mon Aug 24 17:29:08 2020 +0200
Commit: Gabor Kelemen 
CommitDate: Wed Oct 14 23:21:14 2020 +0200

tdf#121189 PPTX export: fix missing chart

Based on Regina Henschel's technical analysis and code pointer.

Change-Id: Ifdea48c09d23dce495fa6bc90a9e1648dbb5ccb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101283
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit 0c5ac9d1cb39eac838a612092a8934a6ca12326f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104328
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index 268e30d46d19..73f335574513 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -147,6 +147,7 @@ public:
 void testTdf119029();
 void testTdf108022();
 void testTdf121744();
+void testTdf121189();
 void testTdf122031();
 void testTdf115012();
 void testTdf134118();
@@ -267,6 +268,7 @@ public:
 CPPUNIT_TEST(testTdf119029);
 CPPUNIT_TEST(testTdf108022);
 CPPUNIT_TEST(testTdf121744);
+CPPUNIT_TEST(testTdf121189);
 CPPUNIT_TEST(testTdf122031);
 CPPUNIT_TEST(testTdf115012);
 CPPUNIT_TEST(testTdf134118);
@@ -2391,6 +2393,18 @@ void Chart2ExportTest::testTdf121744()
 assertXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:lineChart/c:axId[2]", "val", YValueId );
 }
 
+void Chart2ExportTest::testTdf121189()
+{
+load("/chart2/qa/extras/data/odp/", "tdf121189.odp");
+reload("Impress Office Open XML");
+
+uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
+uno::Reference 
xPage(xDoc->getDrawPages()->getByIndex(0), uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xPage->getCount());
+uno::Reference xShape(xPage->getByIndex(0), 
uno::UNO_QUERY_THROW);
+CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.drawing.OLE2Shape"), 
xShape->getShapeType());
+}
+
 void Chart2ExportTest::testTdf122031()
 {
 //Checks pie chart data label format.
diff --git a/chart2/qa/extras/data/odp/tdf121189.odp 
b/chart2/qa/extras/data/odp/tdf121189.odp
new file mode 100644
index ..6f99e0054936
Binary files /dev/null and b/chart2/qa/extras/data/odp/tdf121189.odp differ
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 9f69e316cbec..4aa4522bd596 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -1550,6 +1550,7 @@ static const NameToConvertMapType& lcl_GetConverters()
 
 { "com.sun.star.presentation.GraphicObjectShape"   , 
::WriteGraphicObjectShape },
 { "com.sun.star.presentation.MediaShape"   , 
::WriteGraphicObjectShape },
+{ "com.sun.star.presentation.ChartShape"   , 
::WriteOLE2Shape },
 { "com.sun.star.presentation.OLE2Shape", 
::WriteOLE2Shape },
 { "com.sun.star.presentation.TableShape"   , 
::WriteTableShape },
 { "com.sun.star.presentation.TextShape", 
::WriteTextShape },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137488] Calc: COUNTIF gives an error if the first parameter is a call to BASE

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137488

David Lynch  changed:

   What|Removed |Added

 CC||dlynch1...@googlemail.com

--- Comment #1 from David Lynch  ---
Created attachment 166372
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166372=edit
Demonstates bug 137488

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137488] New: Calc: COUNTIF gives an error if the first parameter is a call to BASE

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137488

Bug ID: 137488
   Summary: Calc: COUNTIF gives an error if the first parameter is
a call to BASE
   Product: LibreOffice
   Version: 7.0.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dlynch1...@googlemail.com

Description:
1   0   Err:504
=BASE(1,14) =COUNTIF(A1,"vv")   =COUNTIF(BASE(1,14),"vv")
See attached spreadsheet

Steps to Reproduce:
See attached spreadsheet

Actual Results:
See attached spreadsheet

Expected Results:
A3 should be 0 not Err:504


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.0.2.2 (x64)
Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136764] Style inspector: No scrollbars and minimum width

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136764

Thomas Lendo  changed:

   What|Removed |Added

 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134554] [META] Styles Inspector

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134554
Bug 134554 depends on bug 136582, which changed state.

Bug 136582 Summary: Styles inspector doesn't show highlighting in header
https://bugs.documentfoundation.org/show_bug.cgi?id=136582

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136582] Styles inspector doesn't show highlighting in header

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136582

Thomas Lendo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID
 CC||thomas.le...@gmail.com

--- Comment #3 from Thomas Lendo  ---
Telesto, there is something wrong with your document. In the header, there is
no Header paragraph style but the Default paragraph style. So, all OK what is
shown in the Style Inspector.

When creating a new test document, then the header contains the Header
paragraph style per default at least in my environment.

And if you mean the Highlight color that should be shown in the Style Inspector
(the bug reports are often misunderstanding and very short): This works as well
for me.

Closing this bug report as INVALID.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136569] UI: Style inspector; short list for; most common formatting

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136569

Thomas Lendo  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org,
   ||thomas.le...@gmail.com

--- Comment #3 from Thomas Lendo  ---
Telesto: I don't understand the bug summary: "UI: Style inspector; short list
for; most common formatting". What does that mean?

To comment 0: The Default Paragraph Style always is collapsed. I assume it's
because a) the list is so long that it would upset the users to scroll every
time so much and b) the Default Paragraph Style shouldn't be the subject of any
change.

It was in one of the endless style bugs here long time ago ;-) but there I
learned that the Default style shouldn't be changed by the user as it's the
basis for all other styles as well (not only text paragraphs but also
Footnotes, Headings etc. and changing Default could have negative side
effects). This is the reason that Text body should be the base paragraph style
that users are using and Default paragraph style is only the internal basis and
shouldn't be used within the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa sw/source

2020-10-14 Thread Serge Krot (via logerrit)
 sw/qa/extras/uiwriter/data/tdf113877_blank_bold_off.odt |binary
 sw/qa/extras/uiwriter/data/tdf113877_blank_bold_on.odt  |binary
 sw/qa/extras/uiwriter/uiwriter.cxx  |   88 +++-
 sw/source/core/txtnode/ndtxt.cxx|4 
 sw/source/filter/xml/xmlimp.cxx |3 
 5 files changed, 48 insertions(+), 47 deletions(-)

New commits:
commit 92c05bd1f8ef695a56718c4b54babbe757ab9b89
Author: Serge Krot 
AuthorDate: Thu Oct 8 09:01:33 2020 +0200
Commit: Thorsten Behrens 
CommitDate: Wed Oct 14 22:59:35 2020 +0200

tdf#132289 missing styles when inserting file with list

Change-Id: I444997a6cc55cfe287f4c610f538f2f54803646c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104085
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104319
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_off.odt 
b/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_off.odt
new file mode 100644
index ..f4d58da53b95
Binary files /dev/null and 
b/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_off.odt differ
diff --git a/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_on.odt 
b/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_on.odt
new file mode 100644
index ..8de77fc6161c
Binary files /dev/null and 
b/sw/qa/extras/uiwriter/data/tdf113877_blank_bold_on.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index be8a972a181a..cd8516d6c29e 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -317,10 +317,15 @@ public:
 void testTdf58604();
 void testTdf112025();
 void testTdf72942();
+
+void testTdf113877_mergeDocs(const char* aDestDoc, const char* aInsertDoc);
 void testTdf113877();
 void testTdf113877NoMerge();
 void testTdf113877_default_style();
 void testTdf113877_Standard_style();
+void testTdf113877_blank_bold_on();
+void testTdf113877_blank_bold_off();
+
 void testMsWordCompTrailingBlanks();
 void testCreateDocxAnnotation();
 void testTdf107976();
@@ -530,6 +535,8 @@ public:
 CPPUNIT_TEST(testTdf113877NoMerge);
 CPPUNIT_TEST(testTdf113877_default_style);
 CPPUNIT_TEST(testTdf113877_Standard_style);
+CPPUNIT_TEST(testTdf113877_blank_bold_on);
+CPPUNIT_TEST(testTdf113877_blank_bold_off);
 CPPUNIT_TEST(testMsWordCompTrailingBlanks);
 CPPUNIT_TEST(testCreateDocxAnnotation);
 CPPUNIT_TEST(testTdf107976);
@@ -6250,12 +6257,9 @@ void SwUiWriterTest::testTdf114306_2()
 CPPUNIT_ASSERT_EQUAL(4, getPages());
 }
 
-
-// During insert of the document with list inside into the main document 
inside the list
-// we should merge both lists into one, when they have the same list properties
-void SwUiWriterTest::testTdf113877()
+void SwUiWriterTest::testTdf113877_mergeDocs(const char* aDestDoc, const char* 
aInsertDoc)
 {
-load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt");
+load(DATA_DIRECTORY, aDestDoc);
 
 // set a page cursor into the end of the document
 uno::Reference xModel(mxComponent, uno::UNO_QUERY);
@@ -6265,10 +6269,17 @@ void SwUiWriterTest::testTdf113877()
 
 // insert the same document at current cursor position
 {
-const OUString insertFileid = 
m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"tdf113877_insert_numbered_list.odt";
+const OUString insertFileid = 
m_directories.getURLFromSrc(DATA_DIRECTORY) + 
OUString::createFromAscii(aInsertDoc);
 uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence({ { "Name", 
uno::makeAny(insertFileid) } }));
 lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues);
 }
+}
+
+// During insert of the document with list inside into the main document 
inside the list
+// we should merge both lists into one, when they have the same list properties
+void SwUiWriterTest::testTdf113877()
+{
+testTdf113877_mergeDocs("tdf113877_insert_numbered_list.odt", 
"tdf113877_insert_numbered_list.odt");
 
 const OUString listId1 = getProperty(getParagraph(1), "ListId");
 const OUString listId4 = getProperty(getParagraph(4), "ListId");
@@ -6288,20 +6299,7 @@ void SwUiWriterTest::testTdf113877()
 // The same test as testTdf113877() but merging of two list should not be 
performed.
 void SwUiWriterTest::testTdf113877NoMerge()
 {
-load(DATA_DIRECTORY, "tdf113877_insert_numbered_list.odt");
-
-// set a page cursor into the end of the document
-uno::Reference xModel(mxComponent, uno::UNO_QUERY);
-uno::Reference 
xTextViewCursorSupplier(xModel->getCurrentController(), uno::UNO_QUERY);
-uno::Reference 
xCursor(xTextViewCursorSupplier->getViewCursor(), uno::UNO_QUERY);
-xCursor->jumpToEndOfPage();
-
-// insert the same document at current cursor position
-{
-const OUString insertFileid = 

[Libreoffice-bugs] [Bug 137322] LibreOffice crashed when insert a Chart in a table

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137322

--- Comment #4 from Alf127  ---
(In reply to Uwe Auer from comment #1)
> Can not reproduce on
> 
> Version: 6.4.6.2, Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
> CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; 
> Locale: en-US (en_US.UTF-8); UI-Language: en-US, Calc: threaded

Hello Uwe Auer,
Here is my version:
Version: 6.4.6.2
Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded

(just in case: if install the language pack (French) it doesn't change
anything).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137322] LibreOffice crashed when insert a Chart in a table

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137322

Alf127  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #3 from Alf127  ---
(In reply to Timur from comment #2)
> Not clear why you report when it works now. 
Hello Timur,
Because the 6.4.6.2 version is the "stable" (lts?) version you get there:
https://www.libreoffice.org/download/download/
(checked on 2020/10/13)
Therefore any end-user (my dad as an example...) will get this (bugged?)
version.

I found the 6.4.7.1 version while searching for older version there:
https://downloadarchive.documentfoundation.org/libreoffice/old/
and I guess standard end-users are not suppose to reach this. ;-) (Well, if dad
would, he would not be able to know what to do with it... :D ).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135186] Improve understanding of hierarchy in Styles Inspector

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135186

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #2 from Thomas Lendo  ---
(In reply to Mike Kaganski from comment #1)
> As an intermediate step, somewhat simpler would be to implement simple
> highlighting of related entries when one clicks on one of them (so clicking
> one of CharColor would highlight all the other CharColor entries).
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135110] ENHANCEMENT: Right Click context menu in the style inspector to modify style

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135110

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #14 from Thomas Lendo  ---
When testing the Style Inspector, I permanently feel the urge to edit the
values or to delete a single value. As other commenters mentioned, a tool that
only shows something isn't that helpful.

I'm no fan of only linking values to the style dialog. Worst would be for me
when the Style Inspector sidebar tab would be changed to another tab (e.g.
Styles sidebar). This would break the workflow and the user has to go back to
the Style Inspector manually.

Without the possibility of changing or deleting single values the Style
Inspector is only a bloated variant of the Contains section in the Organizer
tab of the style dialog. And this restriction of this Contains section has led
to several bug reports here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 118781] UI: Change the 'Contains' section in the Modify Style dialogues to improve the transparency and use of hierarchical styles

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118781

--- Comment #9 from Thomas Lendo  ---
(In reply to Heiko Tietze from comment #8)
> This has been implemented during GSoC20 by Shivam Kumar Singh [1], remaining
> tickets are handled in bug 134554.
Is this really fixed with the Style Inspector in a satisfying way? The bug
opener mentioned that this should be an enhancement to make the style concept
better visible and usable. Not to criticize the Style Inspector, but the
deficiencies of the style dialog window are not gone with this new inspector
tool.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105168] MPEG-2 Video (H.262) wont displayed in Impress on Windows

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105168

--- Comment #29 from skidberna+documentfoundat...@gmail.com ---
https://wiki.documentfoundation.org/Development/GSoC/Successfully_Implemented_Ideas#VLC_integration

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105168] MPEG-2 Video (H.262) wont displayed in Impress on Windows

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105168

skidberna+documentfoundat...@gmail.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|Inherited From OOo  |6.4.6.2 release

--- Comment #28 from skidberna+documentfoundat...@gmail.com ---
Still having the same issue as the other posters in v6.4.6.2. Audio  plays, but
video image does not. I tried insalling k-lite and LAVfilters. Is there a way
to change the setting to enable vlc support on windows? I read about a google
summer of code for that, but I can't seem to find any info on how to use it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa

2020-10-14 Thread Xisco Fauli (via logerrit)
 sw/qa/uitest/findReplace/findReplace.py |   37 
 1 file changed, 33 insertions(+), 4 deletions(-)

New commits:
commit c064766901722082df0d759c95434c1460fcdba5
Author: Xisco Fauli 
AuthorDate: Wed Oct 14 18:40:24 2020 +0200
Commit: Xisco Fauli 
CommitDate: Wed Oct 14 22:21:19 2020 +0200

tdf#136577: sw: Add UItest

Change-Id: I0b03eae6349b712e921f471e1c4dc082a64568df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104320
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/findReplace/findReplace.py 
b/sw/qa/uitest/findReplace/findReplace.py
index 83821ae8662b..1c841c0f0de7 100644
--- a/sw/qa/uitest/findReplace/findReplace.py
+++ b/sw/qa/uitest/findReplace/findReplace.py
@@ -15,13 +15,10 @@ from uitest.debug import sleep
 import org.libreoffice.unotest
 import pathlib
 from uitest.path import get_srcdir_url
+
 def get_url_for_data_file(file_name):
 return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
 
-#tdf116242  ţ ț - DONE
-#Bug 98417 - FIND & REPLACE: Add 'Find Previous' button - DONE
-#Bug 39022 - find-replace->$1, not pattern  - DONE
-
 class findReplace(UITestCase):
 def test_find_writer(self):
 writer_doc = 
self.ui_test.load_file(get_url_for_data_file("findReplace.odt"))
@@ -194,4 +191,36 @@ class findReplace(UITestCase):
 self.ui_test.close_dialog_through_button(xcloseBtn)
 
 self.ui_test.close_doc()
+
+def test_tdf136577(self):
+self.ui_test.create_doc_in_start_center("writer")
+
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+document = self.ui_test.get_component()
+
+type_text(xWriterEdit, "x")
+
+self.assertEqual(document.Text.String, "x")
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:SearchDialog")
+xDialog = self.xUITest.getTopFocusWindow()
+
+searchterm = xDialog.getChild("searchterm")
+searchterm.executeAction("TYPE", mkPropertyValues({"TEXT":"x"}))
+
+
+replaceall = xDialog.getChild("replaceall")
+replaceall.executeAction("CLICK", tuple())
+
+self.assertEqual(document.Text.String, "")
+
+self.xUITest.executeCommand(".uno:Undo")
+
+# Without the fix in place, this test would have failed with 
AssertionError: '' != 'x'
+self.assertEqual(document.Text.String, "x")
+
+self.ui_test.close_doc()
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 88559] Display of inherited attributes from parent styles in Styles dialog

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88559

Thomas Lendo  changed:

   What|Removed |Added

   Hardware|Other   |All

--- Comment #12 from Thomas Lendo  ---
I support Mike's objection in comment 10. Neither single settings can set back
to its inherited value nor inherited values are visible in the Styles dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: scripting/source

2020-10-14 Thread Julien Nabet (via logerrit)
 scripting/source/vbaevents/eventhelper.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit f76f15f02a30d20be1c4816d72f7ad7fb4fa20d3
Author: Julien Nabet 
AuthorDate: Sun Oct 11 12:25:30 2020 +0200
Commit: Julien Nabet 
CommitDate: Wed Oct 14 22:14:59 2020 +0200

Replace list by vector in scripting/eventhelpher

Change-Id: Ia7a24649cc8f204fe412b240df02b3a814ed491c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104180
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/scripting/source/vbaevents/eventhelper.cxx 
b/scripting/source/vbaevents/eventhelper.cxx
index 5fdbe8c078cf..31e7a1bf80d2 100644
--- a/scripting/source/vbaevents/eventhelper.cxx
+++ b/scripting/source/vbaevents/eventhelper.cxx
@@ -67,7 +67,7 @@
 #include 
 #include 
 
-#include 
+#include 
 #include 
 
 using namespace ::com::sun::star;
@@ -172,7 +172,7 @@ struct TranslateInfo
 
 typedef std::unordered_map<
 OUString,
-std::list< TranslateInfo > > EventInfoHash;
+std::vector< TranslateInfo > > EventInfoHash;
 
 namespace {
 
@@ -273,14 +273,14 @@ static EventInfoHash& getEventTransInfo()
 while (i < nCount)
 {
 sEventInfo = pTransProp->sEventInfo;
-std::list< TranslateInfo > infoList;
+std::vector< TranslateInfo > infoList;
 do
 {
 infoList.push_back( pTransProp->aTransInfo );
 pTransProp++;
 i++;
 }while(i < nCount && sEventInfo == pTransProp->sEventInfo);
-tmp[sEventInfo] = infoList;
+tmp[sEventInfo] = std::move(infoList);
 }
 return tmp;
 }();
@@ -382,7 +382,7 @@ ScriptEventHelper::~ScriptEventHelper()
 Sequence< OUString >
 ScriptEventHelper::getEventListeners() const
 {
-std::list< OUString > eventMethods;
+std::vector< OUString > eventMethods;
 
 Reference< beans::XIntrospection > xIntrospection = 
beans::theIntrospection::get( m_xCtx );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: connectivity/source dbaccess/source extensions/source framework/source ucbhelper/source vcl/win xmlsecurity/source

2020-10-14 Thread Stephan Bergmann (via logerrit)
 connectivity/source/drivers/ado/Aolevariant.cxx   |4 
++--
 dbaccess/source/ui/dlg/adodatalinks.cxx   |4 
++--
 extensions/source/config/WinUserInfo/WinUserInfoBe.cxx|4 
++--
 framework/source/uielement/spinfieldtoolbarcontroller.cxx |2 +-
 ucbhelper/source/client/proxydecider.cxx  |2 +-
 vcl/win/gdi/salfont.cxx   |2 +-
 xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx |2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit cf0ed4fb4a610a61332a418f12b547648c3a0130
Author: Stephan Bergmann 
AuthorDate: Wed Oct 14 17:48:36 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Oct 14 22:13:38 2020 +0200

More fixes of uses of now-explicit OUString ctor taking raw sal_Unicode 
pointer

...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c 
"Make
the OUString ctors taking raw sal_Unicode pointer/non-const array explicit".
Interestingly, these occurrences were accepted by MSVC and only cause errors
with clang-cl, so happened to go unnoticed until now.

Change-Id: I33e7653e28a21541ef793b4b0750abb6037752db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104314
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/drivers/ado/Aolevariant.cxx 
b/connectivity/source/drivers/ado/Aolevariant.cxx
index 7f740e81d7c2..f90a4ecc6ef2 100644
--- a/connectivity/source/drivers/ado/Aolevariant.cxx
+++ b/connectivity/source/drivers/ado/Aolevariant.cxx
@@ -378,7 +378,7 @@ void OLEVariant::set(double n)
 OUString OLEVariant::getString() const
 {
 if (V_VT(this) == VT_BSTR)
-return o3tl::toU(LPCOLESTR(V_BSTR(this)));
+return OUString(o3tl::toU(LPCOLESTR(V_BSTR(this;
 
 if(isNull())
 return OUString();
@@ -387,7 +387,7 @@ OUString OLEVariant::getString() const
 
 varDest.ChangeType(VT_BSTR, this);
 
-return o3tl::toU(LPCOLESTR(V_BSTR()));
+return OUString(o3tl::toU(LPCOLESTR(V_BSTR(;
 }
 
 
diff --git a/dbaccess/source/ui/dlg/adodatalinks.cxx 
b/dbaccess/source/ui/dlg/adodatalinks.cxx
index 8ba7610fc854..c8bafabf1088 100644
--- a/dbaccess/source/ui/dlg/adodatalinks.cxx
+++ b/dbaccess/source/ui/dlg/adodatalinks.cxx
@@ -92,7 +92,7 @@ OUString PromptNew(long hWnd)
 piTmpConnection->Release( );
 dlPrompt->Release( );
 // Don't we need SysFreeString(_result)?
-return o3tl::toU(_result);
+return OUString(o3tl::toU(_result));
 }
 
 OUString PromptEdit(long hWnd, OUString const & connstr)
@@ -184,7 +184,7 @@ OUString PromptEdit(long hWnd, OUString const & connstr)
 dlPrompt->Release( );
 CoUninitialize();
 // Don't we need SysFreeString(_result)?
-return o3tl::toU(_result);
+return OUString(o3tl::toU(_result));
 }
 
 }
diff --git a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx 
b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
index 83223d932bb7..7dd5c5463e46 100644
--- a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
+++ b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
@@ -185,7 +185,7 @@ private:
 if (FAILED((pUser->*func)()))
 return "";
 BSTRGuard aBstrGuard(sBstr, SysFreeString);
-return o3tl::toU(sBstr);
+return OUString(o3tl::toU(sBstr));
 }
 static OUString Str(IADsUser* pUser, const wchar_t* property)
 {
@@ -207,7 +207,7 @@ private:
 if (FAILED(SafeArrayGetElement(sa, , )))
 continue;
 if (varItem.vt == VT_BSTR)
-return o3tl::toU(V_BSTR());
+return OUString(o3tl::toU(V_BSTR()));
 VariantClear();
 }
 return "";
diff --git a/framework/source/uielement/spinfieldtoolbarcontroller.cxx 
b/framework/source/uielement/spinfieldtoolbarcontroller.cxx
index 235fb62675f3..428558e6daba 100644
--- a/framework/source/uielement/spinfieldtoolbarcontroller.cxx
+++ b/framework/source/uielement/spinfieldtoolbarcontroller.cxx
@@ -432,7 +432,7 @@ OUString SpinfieldToolbarController::FormatOutputString( 
double fValue )
 else
 _snwprintf( o3tl::toW(aBuffer), SAL_N_ELEMENTS(aBuffer), 
o3tl::toW(m_aOutFormat.getStr()), sal_Int32( fValue ));
 
-return aBuffer;
+return OUString(aBuffer);
 #else
 // Currently we have no support for a format string using sal_Unicode. 
wchar_t
 // is 32 bit on Unix platform!
diff --git a/ucbhelper/source/client/proxydecider.cxx 
b/ucbhelper/source/client/proxydecider.cxx
index fa1befd4be0c..8bb610a64335 100644
--- a/ucbhelper/source/client/proxydecider.cxx
+++ b/ucbhelper/source/client/proxydecider.cxx
@@ -513,7 +513,7 @@ DWORD WINAPI GetPACProxyThread(_In_ LPVOID lpParameter)
 GlobalFree(ProxyInfo.lpszProxyBypass);
 if (ProxyInfo.lpszProxy)
 {
-

[Libreoffice-commits] core.git: compilerplugins/clang

2020-10-14 Thread Stephan Bergmann (via logerrit)
 compilerplugins/clang/commaoperator.cxx  |2 +-
 compilerplugins/clang/comparisonwithconstant.cxx |2 +-
 compilerplugins/clang/consttobool.cxx|4 ++--
 compilerplugins/clang/implicitboolconversion.cxx |4 ++--
 compilerplugins/clang/simplifypointertobool.cxx  |4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit b6d0ca04581eae01817aac18d32a312bc9a2d514
Author: Stephan Bergmann 
AuthorDate: Wed Oct 14 16:22:44 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Oct 14 22:13:08 2020 +0200

The Clang RecursiveASTVisitor change is already in Clang 11

...see 5d546de67b44dec23ecfa5a6378e2968912f8253 "Adapt to Clang 12 trunk
RecursiveASTVisitor change"; no longer sure why I thought 
 "Removed 
a
RecursiveASTVisitor feature to visit operator kinds with different methods"
would not be included in the release/11.x branch

Change-Id: I1e206368c447b74cc6adec4c1d4790c80f0cb744
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104309
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/commaoperator.cxx 
b/compilerplugins/clang/commaoperator.cxx
index 423bd49e5e43..b58fc462dc50 100644
--- a/compilerplugins/clang/commaoperator.cxx
+++ b/compilerplugins/clang/commaoperator.cxx
@@ -84,7 +84,7 @@ public:
 return ret;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinComma(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
 #endif
 
diff --git a/compilerplugins/clang/comparisonwithconstant.cxx 
b/compilerplugins/clang/comparisonwithconstant.cxx
index 284e5567b65f..7fee1175d57e 100644
--- a/compilerplugins/clang/comparisonwithconstant.cxx
+++ b/compilerplugins/clang/comparisonwithconstant.cxx
@@ -51,7 +51,7 @@ public:
 return ret;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinEQ(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
 bool TraverseBinNE(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
 #endif
diff --git a/compilerplugins/clang/consttobool.cxx 
b/compilerplugins/clang/consttobool.cxx
index b8933b231621..ddcbf85a71c9 100644
--- a/compilerplugins/clang/consttobool.cxx
+++ b/compilerplugins/clang/consttobool.cxx
@@ -87,7 +87,7 @@ public:
 return ret;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseUnaryLNot(UnaryOperator* expr) { return 
TraverseUnaryOperator(expr); }
 #endif
 
@@ -121,7 +121,7 @@ public:
 return ret;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinLAnd(BinaryOperator* expr) { return 
TraverseBinaryOperator(expr); }
 #endif
 
diff --git a/compilerplugins/clang/implicitboolconversion.cxx 
b/compilerplugins/clang/implicitboolconversion.cxx
index 14db22788596..74da9756074e 100644
--- a/compilerplugins/clang/implicitboolconversion.cxx
+++ b/compilerplugins/clang/implicitboolconversion.cxx
@@ -253,7 +253,7 @@ public:
 
 bool TraverseBinaryOperator(BinaryOperator * expr);
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinLT(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
 bool TraverseBinLE(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
 bool TraverseBinGT(BinaryOperator * expr) { return 
TraverseBinaryOperator(expr); }
@@ -265,7 +265,7 @@ public:
 
 bool TraverseCompoundAssignOperator(CompoundAssignOperator * expr);
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinAndAssign(CompoundAssignOperator * expr)
 { return TraverseCompoundAssignOperator(expr); }
 bool TraverseBinOrAssign(CompoundAssignOperator * expr)
diff --git a/compilerplugins/clang/simplifypointertobool.cxx 
b/compilerplugins/clang/simplifypointertobool.cxx
index 756985c760fa..110b526c2101 100644
--- a/compilerplugins/clang/simplifypointertobool.cxx
+++ b/compilerplugins/clang/simplifypointertobool.cxx
@@ -78,7 +78,7 @@ public:
 return res;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseUnaryLNot(UnaryOperator* expr) { return 
TraverseUnaryOperator(expr); }
 #endif
 
@@ -114,7 +114,7 @@ public:
 return res;
 }
 
-#if CLANG_VERSION <= 11
+#if CLANG_VERSION <= 10
 bool TraverseBinLAnd(BinaryOperator* expr) { return 
TraverseBinaryOperator(expr); }
 bool TraverseBinLOr(BinaryOperator* expr) { return 
TraverseBinaryOperator(expr); }
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137487] New: [LOCALHELP] Link error in Convert - Table to Text; also seen in [WIKIHELP]

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137487

Bug ID: 137487
   Summary: [LOCALHELP] Link error in Convert - Table to Text;
also seen in [WIKIHELP]
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: iavs.le...@gmail.com
CC: olivier.hal...@libreoffice.org

Description:
file:///C:/Program%20Files/LibreOffice/help/en-US/text/swriter/main0110.html?=WRITER=WIN

https://help.libreoffice.org/latest/en-US/text/swriter/main0110.html?=WRITER=WIN

In this help page, bellow the title "Convert" - "Table to Text" there is an
erroneous link.

Steps to Reproduce:
In the pages (link provided), press the word "dialog" in the paragraph "Opens a
dialog where you can convert the current table to text".

Actual Results:
The link redirects to "Convert Text to Table".

Expected Results:
The link redirects to "Convert Table to Text".


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.6.2 (x86)
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: es-MX (es_MX); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136099] Sidebar: Position and Size align

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136099

--- Comment #6 from andreas_k  ---
(In reply to BogdanB from comment #5)
> Created attachment 166371 [details]
> screenshot
> 
> 
> I can not see Arrange options... 

already reported

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137486] New: Window resize of Libre office products result in massive performance decrease as window attempts full re-draw

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137486

Bug ID: 137486
   Summary: Window resize of Libre office products result in
massive performance decrease as window attempts full
re-draw
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: redeyereco...@gmail.com

Description:
As you grab a UI window to resize the content view from the program border, the
inner contents in LOCalc UI often display a black window and require a full
redraw of the inner UI contents. 

Major machine components affecting results
Gigabyte 1650 Super 4GB,i5-3450S(2.8ghz), 8GB ram

Perceptual Performance in comparison to notepad++ window drag
LibreOffice Calc. 
Perceptual scale: 100% = 60fps, 1%= 1fps or less
All resize operations update on click release or mouse movement stop,
unfortunate.

Top left in-20% / out-20%
left in-20% / out-20%
Bottom left in-20% / out-20%
Top in-20% / out-20%
Top Right in-20% / out-20%
Right in-5% / out-5%
Bottom Right in-5% / out-5%
Bottom in-1% / out-1%

Opinion:
The reason I am submitting this, is the delayed update and black window on
content resize gives the program(LOCalc) the feel that it is going to crash. It
has not, which is great, and more than I can say for Excel. It would be a
welcomed update if resizing became smooth as butter.


Steps to Reproduce:
1. Open LibreOffice Calc
2. Hold left click on any border of LibreOffice Calc
3. Drag border and watch window completely re-draw and display sub-standard
performance

Actual Results:
The window contents refresh and update at a sub-optimal rate.

Expected Results:
The window contents should have resized the contents of the window at the
vertical refresh rate of the monitor.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.4.6.2 (x64)
Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: GL; VCL:
win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2020-10-14 Thread Caolán McNamara (via logerrit)
 vcl/source/window/layout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 860ebbdc4238abe5e996020b0370de7952500526
Author: Caolán McNamara 
AuthorDate: Tue Oct 13 12:51:16 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 21:55:33 2020 +0200

use shadowcolor for bordercolor

this is what the calc inputbar has always done

Change-Id: I17d3dd0b45575e81d6f2e2f109d371cfe366883b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104322
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 39fa631e8bd4..d5379faba384 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -1800,7 +1800,7 @@ VclScrolledWindow::VclScrolledWindow(vcl::Window *pParent)
 
 AllSettings aAllSettings = GetSettings();
 StyleSettings aStyle = aAllSettings.GetStyleSettings();
-aStyle.SetMonoColor(aStyle.GetActiveBorderColor());
+aStyle.SetMonoColor(aStyle.GetShadowColor());
 aAllSettings.SetStyleSettings(aStyle);
 SetSettings(aAllSettings);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/unx

2020-10-14 Thread Caolán McNamara (via logerrit)
 vcl/unx/gtk3/gtk3gtkinst.cxx |   20 +---
 1 file changed, 13 insertions(+), 7 deletions(-)

New commits:
commit a0e1c2e4ff7c89f284442d2e8cb2b1810a1d61f5
Author: Caolán McNamara 
AuthorDate: Wed Oct 14 17:22:38 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 21:55:15 2020 +0200

send ComboBox "changed" on autocomplete suggestion

and put include_mru into its own function

Change-Id: I9e7c669df7c538ae7271b16a0fdc31f102e9333f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104323
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 1db06d1cb1c2..9dcf0645c9d4 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -13726,7 +13726,10 @@ private:
 {
 OUString aText = get_text_including_mru(nPos);
 if (aText != aStartText)
-set_active_text(aText);
+{
+SolarMutexGuard aGuard;
+set_active_including_mru(nPos, true);
+}
 select_entry_region(aText.getLength(), aStartText.getLength());
 }
 enable_notify_events();
@@ -14648,6 +14651,13 @@ private:
 return true;
 }
 
+int include_mru(int pos)
+{
+if (m_nMRUCount && pos != -1)
+pos += (m_nMRUCount + 1);
+return pos;
+}
+
 public:
 GtkInstanceComboBox(GtkBuilder* pComboBuilder, GtkComboBox* pComboBox, 
GtkInstanceBuilder* pBuilder, bool bTakeOwnership)
 : 
GtkInstanceContainer(GTK_CONTAINER(gtk_builder_get_object(pComboBuilder, 
"box")), pBuilder, bTakeOwnership)
@@ -14865,9 +14875,7 @@ public:
 
 virtual void set_active(int pos) override
 {
-if (m_nMRUCount && pos != -1)
-pos += (m_nMRUCount + 1);
-set_active_including_mru(pos, false);
+set_active_including_mru(include_mru(pos), false);
 }
 
 virtual OUString get_active_text() const override
@@ -14940,9 +14948,7 @@ public:
 
 virtual void insert(int pos, const OUString& rText, const OUString* pId, 
const OUString* pIconName, VirtualDevice* pImageSurface) override
 {
-if (m_nMRUCount && pos != -1)
-pos += (m_nMRUCount + 1);
-insert_including_mru(pos, rText, pId, pIconName, pImageSurface);
+insert_including_mru(include_mru(pos), rText, pId, pIconName, 
pImageSurface);
 }
 
 virtual void insert_separator(int pos, const OUString& rId) override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-6-4' - sc/source

2020-10-14 Thread Attila Szűcs (via logerrit)
 sc/source/ui/view/output2.cxx |8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

New commits:
commit 75cafb3b64b3801c84e1c2b0a2b7b1b22b72469c
Author: Attila Szűcs 
AuthorDate: Sat Aug 29 12:33:01 2020 +0200
Commit: Gabor Kelemen 
CommitDate: Wed Oct 14 21:42:00 2020 +0200

tdf#47079 sc layout: fix visibility of Autofilter header

Rotated Autofilter header is shifted under the arrow image, if
there is not enough space for both of them. An exception if the
header is a value, and rotated by 90 or 270 degrees, which resulted
invisible or partially visible cell content in narrow cells. Remove
this exception.

Co-authored-by: Tibor Nagy (NISZ)

Change-Id: Ide8f8ef84a270b9d7ec92da8d3c6ee00ab5ddc2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101638
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit 0bdd533900584f384e2ee4d127fa252e339342c0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104306
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 41a9760cc450..940e08a07989 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -1339,19 +1339,13 @@ void ScOutputData::GetOutputArea( SCCOL nX, SCSIZE 
nArrY, long nPosX, long nPosY
 // filter drop-down width is now independent from row height
 const long nFilter = DROPDOWN_BITMAP_SIZE;
 bool bFit = ( nNeeded + nFilter <= nMergeSizeX );
-if ( bFit || bCellIsValue )
+if ( bFit )
 {
 // content fits even in the remaining area without the filter 
button
 // -> align within that remaining area
 
 rParam.maAlignRect.AdjustRight( -(nFilter * nLayoutSign) );
 rParam.maClipRect.AdjustRight( -(nFilter * nLayoutSign) );
-
-// if a number doesn't fit, don't hide part of the number 
behind the button
-// -> set clip flags, so "###" replacement is used (but also 
within the smaller area)
-
-if ( !bFit )
-rParam.mbLeftClip = rParam.mbRightClip = true;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/source

2020-10-14 Thread Michael Stahl (via logerrit)
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   10 --
 sw/source/uibase/wrtsh/wrtsh1.cxx   |4 
 2 files changed, 4 insertions(+), 10 deletions(-)

New commits:
commit 10c638e520096a0cc282d91ac2a447509f674a6f
Author: Michael Stahl 
AuthorDate: Wed Oct 14 12:42:54 2020 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 21:39:18 2020 +0200

tdf#135260 sw_redlinehide: fix insert-with-delete differently

The problem with the fix for tdf#127635 is that now the cursor doesn't
move left on backspace if change tracking is on.

(regression from 398ba26077f9029bdf6f7378bfc9ce8376b6f02d)

Revert that and fix the autocorrect position in SwWrtShell::Insert()
instead.

Change-Id: I5989a589b654fc6e5ba3dd66922af15eff758ecc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104280
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit be4616d6b49b8c9cf1a90b212b24ead3dabcab6c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104299
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index ecd43d62dbbd..bee95bec1d3c 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2008,11 +2008,6 @@ void DocumentContentOperationsManager::DeleteRange( 
SwPaM & rPam )
 {
 lcl_DoWithBreaks( *this, rPam, 
::DeleteRangeImpl );
 
-if (m_rDoc.getIDocumentRedlineAccess().IsRedlineOn())
-{
-rPam.Normalize(false); // tdf#127635 put point at the end of deletion
-}
-
 if (!m_rDoc.getIDocumentRedlineAccess().IsIgnoreRedline()
 && !m_rDoc.getIDocumentRedlineAccess().GetRedlineTable().empty())
 {
@@ -2189,11 +2184,6 @@ bool DocumentContentOperationsManager::DeleteAndJoin( 
SwPaM & rPam,
 : ::DeleteAndJoinImpl,
 bForceJoinNext );
 
-if (m_rDoc.getIDocumentRedlineAccess().IsRedlineOn())
-{
-rPam.Normalize(false); // tdf#127635 put point at the end of deletion
-}
-
 return ret;
 }
 
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx 
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index 0dbb7aaf0796..da49506b45f4 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -225,7 +225,11 @@ void SwWrtShell::Insert( const OUString  )
 
 StartUndo(SwUndoId::REPLACE, );
 bStarted = true;
+Push();
 bDeleted = DelRight();
+Pop(SwCursorShell::PopMode::DeleteCurrent); // Restore selection (if 
tracking changes)
+NormalizePam(false); // tdf#127635 put point at the end of deletion
+ClearMark();
 }
 
 bCallIns ?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137420] Pivot Table named range does not list database ranges

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137420

--- Comment #6 from mshi...@uzerp.com ---
(In reply to m.a.riosv from comment #5)
> Because named ranges are no part of the Menu/Data/Define range and has
> nothing to do with it (Menu/Sheet/Named Ranges and expressions), to access
> database data, must be selected the option 'Data source registered' and from
> base file select the data.

I understand the registered database option for external data (I use them all
the time).

But (and with respect) if Calc is going to allow an option for 'normal' named
ranges as a source for a Pivot Tables  then surely database ranges must also be
allowed for consistency?

This is especially true if one is trying to use a database range based on a
link to another sheet (say a csv file).

M

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/source

2020-10-14 Thread Michael Stahl (via logerrit)
 sw/source/core/doc/DocumentContentOperationsManager.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba5584a3ce86c2db52e2e4a4b91254741b2616ec
Author: Michael Stahl 
AuthorDate: Wed Oct 14 16:10:29 2020 +0200
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 21:40:00 2020 +0200

tdf#136577 sw: fix Undo of Replace with nothing

The UI doesn't allow to replace an empty selection anyway, but it now
happens on Undo.

(regression from e1629c210ad78310e3d48c0756723134a27b89df)

Change-Id: I468f28335beaeb8c42df8ed4cfc90f2c03129239
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104308
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit d3eca4177a78c3db17b4699ea6e071e52488c46f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104305
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index bee95bec1d3c..17bbd2b562f1 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -4256,7 +4256,7 @@ bool 
DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM & rPam)
 bool DocumentContentOperationsManager::ReplaceRangeImpl( SwPaM& rPam, const 
OUString& rStr,
 const bool bRegExReplace )
 {
-if( !rPam.HasMark() || *rPam.GetPoint() == *rPam.GetMark() )
+if (!rPam.HasMark())
 return false;
 
 bool bJoinText, bJoinPrev;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137454] Wrong reverse object animation order during presentation

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137454

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2020-10-14 Thread Xisco Fauli (via logerrit)
 sc/qa/unit/data/ods/tdf137453.ods  |binary
 sc/qa/unit/subsequent_filters-test.cxx |   17 +
 2 files changed, 17 insertions(+)

New commits:
commit 64d510526ec40d92efdc80438503f2e30467d2c3
Author: Xisco Fauli 
AuthorDate: Wed Oct 14 18:07:27 2020 +0200
Commit: Xisco Fauli 
CommitDate: Wed Oct 14 21:12:33 2020 +0200

tdf#137453: sc_subsequent_filters_test: Add unittest

Change-Id: Ief6559122820c490eebe256535fae5e009b5e2b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104318
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/data/ods/tdf137453.ods 
b/sc/qa/unit/data/ods/tdf137453.ods
new file mode 100644
index ..9feecfb52a14
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf137453.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 3f2b354a4efe..5b61e286915e 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -276,6 +276,7 @@ public:
 void testCharacterSetXLSXML();
 void testTdf137091();
 void testTdf62268();
+void testTdf137453();
 void testTdf35636();
 void testVBAMacroFunctionODS();
 void testAutoheight2Rows();
@@ -449,6 +450,7 @@ public:
 CPPUNIT_TEST(testCondFormatFormulaListenerXLSX);
 CPPUNIT_TEST(testTdf137091);
 CPPUNIT_TEST(testTdf62268);
+CPPUNIT_TEST(testTdf137453);
 CPPUNIT_TEST(testTdf35636);
 CPPUNIT_TEST(testVBAMacroFunctionODS);
 CPPUNIT_TEST(testAutoheight2Rows);
@@ -4802,6 +4804,21 @@ void ScFiltersTest::testTdf62268()
 xDocSh->DoClose();
 }
 
+void ScFiltersTest::testTdf137453()
+{
+ScDocShellRef xDocSh = loadDoc("tdf137453.", FORMAT_ODS);
+CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 33/100
+// - Actual  : -961633963/100
+CPPUNIT_ASSERT_EQUAL(OUString("33/100"), 
rDoc.GetString(ScAddress(0,0,0)));
+
+xDocSh->DoClose();
+}
+
 void ScFiltersTest::testTdf35636()
 {
 ScDocShellRef xDocSh = loadDoc("tdf35636.", FORMAT_ODS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132021] Allow deleting drawing objects in the Navigator (Calc)

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132021

--- Comment #8 from Maarten  ---
Hello,

I can reproduce this bug in LibreOffice Calc version 6.4.6.2 and 7.0.2.2 when
opening an .xlsx file. 

After saving the file the next time opening the file, the white drawing objects
are back (not always).

Can you please fix this bug and not add this workaround?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137354] LibreOffice logo distorted on About Page

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137354

--- Comment #17 from mwtjunkm...@gmail.com ---
(In reply to Xisco Faulí from comment #16)
> (In reply to mwtjunkmail from comment #15)
> > Works for me under
> > 
> > Version: 7.1.0.0.alpha0+ (x64)
> > Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
> > CPU threads: 8; OS: Windows 10.0 Build 20231; UI render: default; VCL: win
> > Locale: en-US (en_US); UI: en-US
> > Calc: threaded
> 
> In the original report you were using skia, now you are not using it

Skia / no Skia, AA / No AA, didn't matter. Logo was screwed it up every way I
looked at it.

I posted the last config that I used when I updated the bug. I tested against
all configs.

In my production work, I must avoid using Skia (and often AA) because using
Skia with AA when exporting to PNG still anti-aliases objects on a draw slide
to white even with a transparent background. Half of what I do has transparent
backgrounds. Result, artifacts on the output everywhere. Hardware with no AA in
these most recent versions of the daily build doesn't have that problem.

Just to confirm for this bug report, the following works for the logo:

AA w/ Skia
AA w/ Hardware acceleration


GOOD NEWS (if off-topic), I *REALLY* like the blurred drop shadow
functionality. Very professional, and rivals other programs. Very nice, and as
long as I'm using a non-transparent background, which encompasses the other
half of what I do, the PNG output is great.

I've gotten to the point when I want to use the PNG output to wrap around 3D
objects, when the object demands transparency anywhere, I use hardware / no AA,
and if a solid background, I can switch to Skia with AA.

And what's nice, I don't have to switch back to Skia at all most of the time,
because hardware with no AA still produces a great PNG output with blurred
shadows as long as the background isn't transparent.

Very much liking that feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qa

2020-10-14 Thread Andrea Gelmini (via logerrit)
 vcl/qa/cppunit/skia/skia.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8f60297719d92bfda71f4fc8b9167a22bca6b844
Author: Andrea Gelmini 
AuthorDate: Wed Oct 14 17:53:48 2020 +0200
Commit: Julien Nabet 
CommitDate: Wed Oct 14 20:53:41 2020 +0200

Fix typo

Change-Id: I6265c482cdc1468516d0e9eff704f2017effd411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104315
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/vcl/qa/cppunit/skia/skia.cxx b/vcl/qa/cppunit/skia/skia.cxx
index 00c99823e986..d13e1530f95e 100644
--- a/vcl/qa/cppunit/skia/skia.cxx
+++ b/vcl/qa/cppunit/skia/skia.cxx
@@ -282,7 +282,7 @@ void SkiaTest::testBitmapCopyOnWrite()
 CPPUNIT_ASSERT(bitmap2.unittestHasAlphaImage());
 CPPUNIT_ASSERT_EQUAL(bitmap.unittestGetImage(), 
bitmap2.unittestGetImage());
 CPPUNIT_ASSERT_EQUAL(bitmap.unittestGetAlphaImage(), 
bitmap2.unittestGetAlphaImage());
-// Reading still should keep the data shrared.
+// Reading still should keep the data shared.
 const SkImage* oldImage = bitmap.unittestGetImage();
 const SkImage* oldAlphaImage = bitmap.unittestGetAlphaImage();
 BitmapBuffer* buffer = bitmap.AcquireBuffer(BitmapAccessMode::Read);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137472] Pasted .jpg does not show up in presentation mode (F5)

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137472

--- Comment #6 from Gerald Pfeifer  ---
(In reply to Timur from comment #5)
> If Gerald reproduced with 7.0 and not with 7.1,that's not New but WFM. 

It does not reproduce in 6.4, specifically

  Version: 6.4.8.0.0+
  Build ID: 99b065ec31d032fc08ab14f66430dac4fef904a5
  CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3; 
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-4, Time: 
2020-10-08_08:57:08

So it's a regression in the current release series, and only fixed in
a future release series.

Should we request finding the regressing commit? It would be good to 
try address this for the current release series, I believe.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137420] Pivot Table named range does not list database ranges

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137420

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from m.a.riosv  ---
Because named ranges are no part of the Menu/Data/Define range and has nothing
to do with it (Menu/Sheet/Named Ranges and expressions), to access database
data, must be selected the option 'Data source registered' and from base file
select the data.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/source sd/source

2020-10-14 Thread Tamás Zolnai (via logerrit)
 sc/source/ui/view/tabvwsh2.cxx |1 -
 sd/source/ui/view/drviewse.cxx |2 --
 2 files changed, 3 deletions(-)

New commits:
commit 4474b0ee642a85adf1d0293ca6c4122c80265d59
Author: Tamás Zolnai 
AuthorDate: Wed Oct 14 20:06:02 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Wed Oct 14 20:28:05 2020 +0200

Revert "lok: text box insertion: default to insert directly for lok."

Breaks a lot of cypress tests.

This reverts commit 1952f042e724f39bf92a52947ef1c59f6e13441b.

Change-Id: I2f11c094082bad7cb8e70350f724a0789318a8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104321
Tested-by: Tamás Zolnai 
Reviewed-by: Tamás Zolnai 

diff --git a/sc/source/ui/view/tabvwsh2.cxx b/sc/source/ui/view/tabvwsh2.cxx
index 7b278dab9269..d2efc23d5559 100644
--- a/sc/source/ui/view/tabvwsh2.cxx
+++ b/sc/source/ui/view/tabvwsh2.cxx
@@ -260,7 +260,6 @@ void ScTabViewShell::ExecDraw(SfxRequest& rReq)
 case SID_DRAW_TEXT_VERTICAL:
 case SID_DRAW_TEXT_MARQUEE:
 case SID_DRAW_NOTEEDIT:
-bCreateDirectly = comphelper::LibreOfficeKit::isActive();
 pTabView->SetDrawFuncPtr(new FuText(*this, pWin, pView, pDoc, 
aNewReq));
 break;
 
diff --git a/sd/source/ui/view/drviewse.cxx b/sd/source/ui/view/drviewse.cxx
index d4b10e1fe8f9..3ae9b37171b0 100644
--- a/sd/source/ui/view/drviewse.cxx
+++ b/sd/source/ui/view/drviewse.cxx
@@ -249,8 +249,6 @@ void DrawViewShell::FuPermanent(SfxRequest& rReq)
 
 rReq.Done();
 
-bCreateDirectly = comphelper::LibreOfficeKit::isActive();
-
 const SfxItemSet* pArgs = rReq.GetArgs();
 if (pArgs && pArgs->HasItem(FN_PARAM_1))
 bCreateDirectly = static_cast(pArgs->Get(FN_PARAM_1)).GetValue();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137457] When opening a csv file with Calc, the decimal point is removed, changing the value of the cell

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137457

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
If I'm not wrong, it's a matter of select in the 'Text import' box a language
using a dot as decimal separator, so you can avoid selecting for every column
the right column type 'US English'. In my case with Spanish, using 'English UK'
works fine with many of the csv files having dot as decimal separator but the
dates DD/MM/YY.

I don't think this is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/source

2020-10-14 Thread Caolán McNamara (via logerrit)
 cui/source/dialogs/cuicharmap.cxx |   13 -
 1 file changed, 8 insertions(+), 5 deletions(-)

New commits:
commit d7ff5df1dc5c7ae0f468e0250c54e9f72035093c
Author: Caolán McNamara 
AuthorDate: Wed Oct 14 16:42:26 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 20:25:42 2020 +0200

tdf#137294 don't change subset sensitivity after setting search mode

Change-Id: Iaa76e2bc8029ac8f8a52b0c45f74b57395090088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104312
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/dialogs/cuicharmap.cxx 
b/cui/source/dialogs/cuicharmap.cxx
index 25b05c68d2b1..f78b70a29662 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -644,11 +644,6 @@ IMPL_LINK_NOARG(SvxCharacterMap, FontSelectHdl, 
weld::ComboBox&, void)
 m_xShowSet->SetFont( aFont );
 m_xSearchSet->SetFont( aFont );
 m_aShowChar.SetFont( aFont );
-if (isSearchMode)
-{
-SearchUpdateHdl(*m_xSearchText);
-SearchCharHighlightHdl(m_xSearchSet.get());
-}
 
 // setup unicode subset listbar with font specific subsets,
 // hide unicode subset listbar for symbol fonts
@@ -676,6 +671,14 @@ IMPL_LINK_NOARG(SvxCharacterMap, FontSelectHdl, 
weld::ComboBox&, void)
 m_xSubsetText->set_sensitive(bNeedSubset);
 m_xSubsetLB->set_sensitive(bNeedSubset);
 
+if (isSearchMode)
+{
+// tdf#137294 do this after modifying m_xSubsetLB sensitivity to
+// restore insensitive for the search case
+SearchUpdateHdl(*m_xSearchText);
+SearchCharHighlightHdl(m_xSearchSet.get());
+}
+
 // tdf#118304 reselect current glyph to see if its still there in new font
 selectCharByCode(Radix::hexadecimal);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137294] Special Character dialog -- Search operation not updated according to the active font name entry

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137294

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137294] Special Character dialog -- Search operation not updated according to the active font name entry

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137294

--- Comment #5 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d7ff5df1dc5c7ae0f468e0250c54e9f72035093c

tdf#137294 don't change subset sensitivity after setting search mode

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/unx

2020-10-14 Thread Caolán McNamara (via logerrit)
 vcl/unx/gtk3/gtk3gtkinst.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b341758a6df28d2c2034fd2335924890ccb2b905
Author: Caolán McNamara 
AuthorDate: Wed Oct 14 16:27:57 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Oct 14 20:24:49 2020 +0200

Related: tdf#137250 need signal-changed for ComboBoxText too

e.g. changing font in format, character with up/down/typeahead

Change-Id: I2aabae8ea4108830bb5a0ca89ad694fe88a7444d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104311
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index acd917d27cf6..1db06d1cb1c2 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -14494,7 +14494,7 @@ private:
 m_bChangedByMenu = false;
 enable_notify_events();
 
-if (bInteractive && !m_bPopupActive && !m_pEntry)
+if (bInteractive && !m_bPopupActive)
 signal_changed();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/qa writerfilter/source

2020-10-14 Thread Justin Luth (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf108944_footnoteSeparator2.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx  |7 +++
 writerfilter/source/dmapper/PropertyMap.cxx|2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 1df6cc318b2559408cf08d7bd43c0298048f9ff7
Author: Justin Luth 
AuthorDate: Wed Oct 14 14:49:55 2020 +0300
Commit: Justin Luth 
CommitDate: Wed Oct 14 20:20:39 2020 +0200

related tdf#108944 writerfilter: fix another missing ftn separator

A comment can also cause a missing footnote separator.
Found by doing a code read.

Change-Id: I42296f2e9406ad144c6e45873fac0f2cb8d11839
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104282
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf108944_footnoteSeparator2.odt 
b/sw/qa/extras/ooxmlexport/data/tdf108944_footnoteSeparator2.odt
new file mode 100644
index ..17e0c6029f5a
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf108944_footnoteSeparator2.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
index ec359b119b58..c56c0739d30b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
@@ -95,6 +95,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf92470_footnoteRestart, 
"tdf92470_footnoteRestart
 CPPUNIT_ASSERT_EQUAL(static_cast(25), 
getProperty(xPageStyle, "FootnoteLineRelativeWidth"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf108944_footnoteSeparator2, 
"tdf108944_footnoteSeparator2.odt")
+{
+uno::Reference 
xPageStyle(getStyles("PageStyles")->getByName("Standard"), uno::UNO_QUERY);
+//This was zero. The comment was causing the bHasFtnSep flag to be reset 
to false, so the separator was missing.
+CPPUNIT_ASSERT_EQUAL(static_cast(25), 
getProperty(xPageStyle, "FootnoteLineRelativeWidth"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testCharacterBorder, "charborder.odt")
 {
 CPPUNIT_ASSERT_EQUAL(1, getPages());
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 60dbe6c4cc4f..21a8593178a1 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1896,7 +1896,7 @@ void SectionPropertyMap::CloseSectionGroup( 
DomainMapper_Impl& rDM_Impl )
 rDM_Impl.SetIsLastSectionGroup( false );
 rDM_Impl.SetIsFirstParagraphInSection( true );
 
-if ( !rDM_Impl.IsInFootOrEndnote() )
+if ( !rDM_Impl.IsInFootOrEndnote() && !rDM_Impl.IsInComments() )
 {
 rDM_Impl.m_bHasFtn = false;
 rDM_Impl.m_bHasFtnSep = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 137484] "Restart Numbering" does not "stick" for first list in a document

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137484

Julien Nabet  changed:

   What|Removed |Added

Summary|"Resart Numbering" does not |"Restart Numbering" does
   |"stick" for first list in a |not "stick" for first list
   |document|in a document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137485] New: Double load with symlinks - missing 'realpath'

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137485

Bug ID: 137485
   Summary: Double load with symlinks - missing 'realpath'
   Product: LibreOffice
   Version: 6.4.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael.me...@collabora.com

I run:

soffice ~/foo.odp

my home is symlinked thus:

/home/michael -> ../crypt-home/michael

If then run:

strace -f -e file -o /tmp/slog loffice ~/foo.odp  /crypt-home/michael/foo.odp 

It can be seen that I load the same file twice - which is a horror - and leads
to data-loss =)

Did someone try to optimize the 'realpath()' code or something ? interestingly
the second load seems to walk back the elements of the path following symlinks
as I would expect to try to detect duplicates.

I believe this is a regression; also data-loss ... on Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137481] Insert "Formula" command in Writer appears twice for different UNO commands in Customize Keyboard

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137481

--- Comment #4 from Rafael Lima  ---
(In reply to Mike Kaganski from comment #3) 
> No objections of course; you might had noticed that I didn't close the
> issue, just added a See Also reference, and commented for the context ;-)

I would volunteer to help with this issue, but I have never submitted a patch
to the LibreOffice code. I downloaded it, but I still don't know how to find
the part of the code where this is located. Are these names and tooltips
located in a separate XML file?

I have good knowledge of Python programming and can get around with C++. Is
there some sort of "mentoring" program to get started developing LibreOffice
patches?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137409] LibreOffice suddenly dies

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137409

Julien Nabet  changed:

   What|Removed |Added

   Keywords||wantBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137481] Insert "Formula" command in Writer appears twice for different UNO commands in Customize Keyboard

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137481

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa

2020-10-14 Thread Andrea Gelmini (via logerrit)
 0 files changed

New commits:
commit 8ed2f358cc2a668600e602cb0515ff6af16c2824
Author: Andrea Gelmini 
AuthorDate: Wed Oct 14 17:54:08 2020 +0200
Commit: Julien Nabet 
CommitDate: Wed Oct 14 20:10:14 2020 +0200

Removed executable bits on docx file

Change-Id: I3cfd9950a97a7a388c34de2d09cbd93bc02cd179
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104316
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/qa/extras/layout/data/tdf137025.docx 
b/sw/qa/extras/layout/data/tdf137025.docx
old mode 100755
new mode 100644
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: llvm/clang static analyzer reports

2020-10-14 Thread Maarten Hoes
Hi,


If there is enough interest, I can create a shell script that automates the
procedure of running the clang static analyzer on the LibreOffice codebase,
so that it can be run on a regular basis in an automated fashion. If so, I
would like to submit that script to gerrit, so that it can be reviewed
there in the usual fashion before it gets submitted. Would there be a
particular preferred git repo to add this to ? 'dev-tools' seems like a
good place to add it to ? Also, would there be any people over here that
might be interested in getting added as a reviewer in gerrit ?


Thanks in advance,


- Maarten Hoes.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 39667] Enable accessible/tagged PDF export options by default

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39667

Heiko Tietze  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com,
   ||t...@libreoffice.org
   Keywords|needsDevEval|difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI

--- Comment #16 from Heiko Tietze  ---
(In reply to Alex ARNAUD from comment #15)
> @Heiko: Do you know who is aware on how to change a default settings in
> LibreOffice? I assume it's trivial for someone aware of this.

The checkbox is on filter/uiconfig/ui/pdfgeneralpage.ui. It is set by const
bool bIsPDFA = (pParent->mnPDFTypeSelection>=1) && (pParent->mnPDFTypeSelection
<= 3); in filter/source/pdf/impdialog.cxx, which is defined in
filter/source/pdf/pdfexport.hxx. The value is read in impdialog.cxx as
mnPDFTypeSelection =  maConfigItem.ReadInt32( "SelectPdfVersion", 0 ); and this
configuration is defined in
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Common.xcs?r=a927e096#5389
as 0. Just set it to one of the other values.

Samuel, Thorsten: What is a sane/save default for this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137478] Last letter disappear

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137478

BogdanB  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #1 from BogdanB  ---
Please provide a sample file in order to test your bug. Please remove any
sensitive data from it.

Thank you in advance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137481] Insert "Formula" command in Writer appears twice for different UNO commands in Customize Keyboard

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137481

--- Comment #3 from Mike Kaganski  ---
(In reply to Rafael Lima from comment #2)

No objections of course; you might had noticed that I didn't close the issue,
just added a See Also reference, and commented for the context ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137472] Pasted .jpg does not show up in presentation mode (F5)

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137472

Timur  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #5 from Timur  ---
If Gerald reproduced with 7.0 and not with 7.1,that's not New but WFM. 
But, to be sure, Axel please test daily master, easiest from
https://libreoffice.soluzioniopen.com/daily-version/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 136099] Sidebar: Position and Size align

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136099

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #5 from BogdanB  ---
Created attachment 166371
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166371=edit
screenshot


I can not see Arrange options... 

See screenshot.

Version: 7.1.0.0.alpha0+
Build ID: f21f3d094cfb495c89dfb0a23ecb061ef1a2178e
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137482] Opening csv with semicolon delimiter formats column value wrong sometimes

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137482

Uwe Auer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from Uwe Auer  ---
This is probably a usage error on import. Data in column D are imported using
*Standard* setting (see attached screenshot
https://bugs.documentfoundation.org/attachment.cgi?id=166369) for the column,
which means that LibreOffice tries to detect numbers as such. 57,101 is English
US format using ',' as thousands separator and LibreOffice recognizes that as a
number. Hence it is imported correctly (as per settings) as '57101' The
intention seems to be to import as text and import needs to be set to *Text* to
achieve the desired result.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137481] Insert "Formula" command in Writer appears twice for different UNO commands in Customize Keyboard

2020-10-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137481

--- Comment #2 from Rafael Lima  ---
Hi Mike!

In the case of the "Formula" commands, the tooltips were not enough for me to
understand what each command meant.

Also, I do not see it as a problem to have a clearer and unambiguous label for
these commands.

Maybe someone could conduct a review of these tooltips, because the tooltips of
most commands are just copies of the command names.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >