[Libreoffice-bugs] [Bug 138294] FILEOPEN DOCX: Formula in cells in all but the first table in document corrupted by saving and reopening document.
https://bugs.documentfoundation.org/show_bug.cgi?id=138294 Dieter changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Dieter --- It seems to be fixed recently, because I can't reproduce it in Version: 7.1.0.0.alpha1+ (x64) Build ID: 10b23330a9655658e6d7ef1d008a3302a15e9629 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded Peter, could you also please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/current.html ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build. Change it to RESOLVED WORKSFORME, if the problem has gone away. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138305] Styles Inspector does not show hierarchical character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=138305 --- Comment #2 from Heiko Tietze --- Is the cursor in the list? There should be at least some direct formatting for the list ID. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108519] [META] Page break bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108519 Heiko Tietze changed: What|Removed |Added Depends on||138642 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138642 [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642 Heiko Tietze changed: What|Removed |Added Blocks||108519 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108519 [Bug 108519] [META] Page break bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Severity|normal |enhancement --- Comment #3 from Heiko Tietze --- Somewhat bikeshedding here as I haven't seen any user complaining about the missing [None] pages style. But anyway, either go with radio buttons as Regina suggests (the text is a bit verbose and better suited for a tooltip) or a checkbox similar to the page number below. ( ) Line break ( ) Column break (o) Page break [x] New style [v] [ ] Change page number [ +-] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Severity|normal |enhancement --- Comment #3 from Heiko Tietze --- Somewhat bikeshedding here as I haven't seen any user complaining about the missing [None] pages style. But anyway, either go with radio buttons as Regina suggests (the text is a bit verbose and better suited for a tooltip) or a checkbox similar to the page number below. ( ) Line break ( ) Column break (o) Page break [x] New style [v] [ ] Change page number [ +-] -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 138305] Styles Inspector does not show hierarchical character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=138305 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Created attachment 167812 --> https://bugs.documentfoundation.org/attachment.cgi?id=167812=edit Screenshot of style inspector and formatted dummy text I used 'Formatted Dummy Text' (thank you for that hint), but style inspector doesn't show any character styles. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138323] File reset when I indent specific numbering list item and Save in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=138323 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #3 from Dieter --- (In reply to Po-Yen Huang from comment #2) > I tested Arch Linux. > > Another user reports he can reproduce on his LibreOffice 6.4.5 on Windows. Please ask that user, if he can reproduce it with LO 7.0.3.1 and ask hi to leave a comment here. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122966] FILESAVE DOCX Shape positioned incorrectly after RT (see comment 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=122966 Dániel Arató (NISZ) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |arato.dan...@nisz.hu |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=51510 Telesto changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135758] Border line disabled for a cell when deleting a row in a ODT/DOC/DOCX/RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=135758 NISZ LibreOffice Team changed: What|Removed |Added Resolution|--- |NOTABUG CC||libreoff...@nisz.hu Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135758] Border line disabled for a cell when deleting a row in a ODT/DOC/DOCX/RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=135758 --- Comment #4 from NISZ LibreOffice Team --- Created attachment 167811 --> https://bugs.documentfoundation.org/attachment.cgi?id=167811=edit Screenshot of the original file and its docx version after deleting the first row Does not seem to be docx-specific, the same happens to the original odt in: Version: 7.2.0.0.alpha0+ (x64) Build ID: 4e63ec27b69fa01ff610c894c9fbf05c377a6179 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: CL But the cells border settings (Table - Select - Cell then Table properties) shows that these particular cells don't have top and right borders, we see the bottom border of the top cell in the original. I think this is NAB. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137458] SVG image appears blurry with 200% scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=137458 --- Comment #12 from Telesto --- (In reply to Frederic Parrenin from comment #10) > @frontrunner_medicophysi...@aleeas.com, yes, the appimage you mentioned work > for me. But this is 6.4, and my problem is with 7.0 and 7.1. https://libreoffice.soluzioniopen.com/pre/7.1/LibreOffice-7.1.0.0.beta1-x86_64.AppImage -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137458] SVG image appears blurry with 200% scaling
https://bugs.documentfoundation.org/show_bug.cgi?id=137458 --- Comment #11 from Telesto --- No issue on macOS Version: 7.1.0.0.alpha1+ Build ID: c784b3da15102caf1022e83371863a86766e69cd CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138125] Slow performance in writer with background image (macOS/ Linux?)
https://bugs.documentfoundation.org/show_bug.cgi?id=138125 Telesto changed: What|Removed |Added Summary|Slow performance in writer |Slow performance in writer |with background image |with background image ||(macOS/ Linux?) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/dlg/sdtreelb.cxx | 24
1 file changed, 16 insertions(+), 8 deletions(-)
New commits:
commit 986952dd52861563006d0ba178e8bdd44247af81
Author: Jim Raykowski
AuthorDate: Thu Dec 3 17:57:18 2020 -0900
Commit: Noel Grandin
CommitDate: Fri Dec 4 08:09:30 2020 +0100
tdf#34828 sd navigator: fix crash when page item entry is selected
Page items in the tree are given user data value 1. Drawing obect items
are given user data value of the object pointer they represent. Need to
check that the user data is not 1 before casting to an object pointer.
Change-Id: I58109e556268e805f62ad2f16b363411e4341d2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107185
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 12ba6be2cf45..ed84546be179 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -702,15 +702,23 @@ void SdPageObjsTLV::Select()
if (m_bSelectionHandlerNavigates)
{
-SdrObject* pObject =
reinterpret_cast(m_xTreeView->get_selected_id().toInt64());
-if (pObject && pObject->GetName().isEmpty())
+// Page items in the tree are given user data value 1.
+// Drawing object items are given user data value of the object
pointer they represent.
+sal_Int64 nUserData = m_xTreeView->get_selected_id().toInt64();
+if (nUserData != 1)
{
-const bool bUndo =
pObject->getSdrModelFromSdrObject().IsUndoEnabled();
-pObject->getSdrModelFromSdrObject().EnableUndo(false);
-pObject->SetName(m_xTreeView->get_selected_text(), false);
-m_aRowActivatedHdl.Call(*m_xTreeView);
-pObject->SetName(OUString(), false);
-pObject->getSdrModelFromSdrObject().EnableUndo(bUndo);
+SdrObject* pObject = reinterpret_cast(nUserData);
+if (pObject && pObject->GetName().isEmpty())
+{
+const bool bUndo =
pObject->getSdrModelFromSdrObject().IsUndoEnabled();
+pObject->getSdrModelFromSdrObject().EnableUndo(false);
+pObject->SetName(m_xTreeView->get_selected_text(), false);
+m_aRowActivatedHdl.Call(*m_xTreeView);
+pObject->SetName(OUString(), false);
+pObject->getSdrModelFromSdrObject().EnableUndo(bUndo);
+}
+else
+m_aRowActivatedHdl.Call(*m_xTreeView);
}
else
m_aRowActivatedHdl.Call(*m_xTreeView);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 --- Comment #69 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/986952dd52861563006d0ba178e8bdd44247af81 tdf#34828 sd navigator: fix crash when page item entry is selected It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135759] Some border lines look grayish like (no border set) after DOCX export (but are actually present)
https://bugs.documentfoundation.org/show_bug.cgi?id=135759 NISZ LibreOffice Team changed: What|Removed |Added Blocks||10 --- Comment #7 from NISZ LibreOffice Team --- (In reply to NISZ LibreOffice Team from comment #6) > Created attachment 167804 [details] > The example file and its docx-version in 7.2alpha > > Seems to be good now in: > False warning: this has to do with the View - Table boundaries setting: - if enabled, the light grey table boundary line is visible - if disabled, the black border line is visible Does not happen with odt. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=10 [Bug 10] [META] DOCX (OOXML) table-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 NISZ LibreOffice Team changed: What|Removed |Added Depends on||135759 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135759 [Bug 135759] Some border lines look grayish like (no border set) after DOCX export (but are actually present) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/mergecells.png |binary icon-themes/colibre/cmd/32/selecttable.png |binary icon-themes/colibre/cmd/32/splitcell.png|binary icon-themes/colibre/cmd/32/togglemergecells.png |binary icon-themes/colibre/cmd/lc_mergecells.png |binary icon-themes/colibre/cmd/lc_selecttable.png |binary icon-themes/colibre/cmd/lc_splitcell.png|binary icon-themes/colibre/cmd/lc_togglemergecells.png |binary icon-themes/colibre/cmd/sc_mergecells.png |binary icon-themes/colibre/cmd/sc_selecttable.png |binary icon-themes/colibre/cmd/sc_splitcell.png|binary icon-themes/colibre/cmd/sc_togglemergecells.png |binary icon-themes/colibre_svg/cmd/32/mergecells.svg |2 +- icon-themes/colibre_svg/cmd/32/selecttable.svg |2 +- icon-themes/colibre_svg/cmd/32/splitcell.svg|2 +- icon-themes/colibre_svg/cmd/32/togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_mergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_selecttable.svg |2 +- icon-themes/colibre_svg/cmd/lc_splitcell.svg|2 +- icon-themes/colibre_svg/cmd/lc_togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/sc_mergecells.svg |4 +--- icon-themes/colibre_svg/cmd/sc_selecttable.svg |3 +-- icon-themes/colibre_svg/cmd/sc_splitcell.svg|4 +--- icon-themes/colibre_svg/cmd/sc_togglemergecells.svg |5 + 24 files changed, 12 insertions(+), 20 deletions(-) New commits: commit 665c9ecfca2150f3e457cb36f336798cbed4d098 Author: Rizal Muttaqin AuthorDate: Thu Dec 3 17:48:07 2020 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Fri Dec 4 07:40:04 2020 +0100 Colibre:Update Merge & Split Cells and Select Table Change-Id: Ibeab169f4430ae269e96e099c113a93279af9a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107155 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin (cherry picked from commit 9e190373f3ea999d15b8d6f84a7d35481e6dc971) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107198 (cherry picked from commit a95f5e24e64948f66d49652e967c55e938800599) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107199 Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/colibre/cmd/32/mergecells.png b/icon-themes/colibre/cmd/32/mergecells.png index 2009968b1565..04fdf6e5ed49 100644 Binary files a/icon-themes/colibre/cmd/32/mergecells.png and b/icon-themes/colibre/cmd/32/mergecells.png differ diff --git a/icon-themes/colibre/cmd/32/selecttable.png b/icon-themes/colibre/cmd/32/selecttable.png index 16422ddb5806..7ca3a3a82a21 100644 Binary files a/icon-themes/colibre/cmd/32/selecttable.png and b/icon-themes/colibre/cmd/32/selecttable.png differ diff --git a/icon-themes/colibre/cmd/32/splitcell.png b/icon-themes/colibre/cmd/32/splitcell.png index 7c4870459705..154dda6e0078 100644 Binary files a/icon-themes/colibre/cmd/32/splitcell.png and b/icon-themes/colibre/cmd/32/splitcell.png differ diff --git a/icon-themes/colibre/cmd/32/togglemergecells.png b/icon-themes/colibre/cmd/32/togglemergecells.png index 13168c1cda59..bf75d7f8da93 100644 Binary files a/icon-themes/colibre/cmd/32/togglemergecells.png and b/icon-themes/colibre/cmd/32/togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_mergecells.png b/icon-themes/colibre/cmd/lc_mergecells.png index 3a1d1c9bb771..540cb967dd82 100644 Binary files a/icon-themes/colibre/cmd/lc_mergecells.png and b/icon-themes/colibre/cmd/lc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_selecttable.png b/icon-themes/colibre/cmd/lc_selecttable.png index 9d503bc3615d..b3967a3550e4 100644 Binary files a/icon-themes/colibre/cmd/lc_selecttable.png and b/icon-themes/colibre/cmd/lc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/lc_splitcell.png b/icon-themes/colibre/cmd/lc_splitcell.png index fc66a5c5dca2..ab16e79fc70b 100644 Binary files a/icon-themes/colibre/cmd/lc_splitcell.png and b/icon-themes/colibre/cmd/lc_splitcell.png differ diff --git a/icon-themes/colibre/cmd/lc_togglemergecells.png b/icon-themes/colibre/cmd/lc_togglemergecells.png index 6c38119ad681..9bb798f9c578 100644 Binary files a/icon-themes/colibre/cmd/lc_togglemergecells.png and b/icon-themes/colibre/cmd/lc_togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_mergecells.png b/icon-themes/colibre/cmd/sc_mergecells.png index 8890afcc61a6..a5bec510fead 100644 Binary files a/icon-themes/colibre/cmd/sc_mergecells.png and b/icon-themes/colibre/cmd/sc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_selecttable.png b/icon-themes/colibre/cmd/sc_selecttable.png index c3518db44221..725a86d56794 100644 Binary files a/icon-themes/colibre/cmd/sc_selecttable.png and b/icon-themes/colibre/cmd/sc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/sc_splitcell.png b/icon-themes/colibre/cmd/sc_splitcell.png
[Libreoffice-bugs] [Bug 138628] ClearDirectFormatting does not remove page break
https://bugs.documentfoundation.org/show_bug.cgi?id=138628 --- Comment #3 from Mike Kaganski --- This obviously *is* direct formatting, and I bet there was some explicit processing for page breaks not removed when clearing the direct formatting from paragraphs. Of course we need to look into the code to be absolutely sure, but it's my gut feeling, that this is a "feature" targeted on inexperienced users coming from MS Office, and who are not used to the idea that page break is a property of paragraphs. Personally I would thing that a configuration would be useful for this, to allow more complete clearing of direct formatting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138628] ClearDirectFormatting does not remove page break
https://bugs.documentfoundation.org/show_bug.cgi?id=138628 --- Comment #3 from Mike Kaganski --- This obviously *is* direct formatting, and I bet there was some explicit processing for page breaks not removed when clearing the direct formatting from paragraphs. Of course we need to look into the code to be absolutely sure, but it's my gut feeling, that this is a "feature" targeted on inexperienced users coming from MS Office, and who are not used to the idea that page break is a property of paragraphs. Personally I would thing that a configuration would be useful for this, to allow more complete clearing of direct formatting. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 134128] caps on dashes are missing in edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=134128 --- Comment #9 from Commit Notification --- Regina Henschel committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/24d770799660d3ec94ee7add435645794426042b tdf#134128 Use Gdiplus::DashCapRound for round dash or dot. It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134128] caps on dashes are missing in edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=134128 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/gdiimpl.cxx | 35 +++
1 file changed, 31 insertions(+), 4 deletions(-)
New commits:
commit 24d770799660d3ec94ee7add435645794426042b
Author: Regina Henschel
AuthorDate: Thu Dec 3 23:53:43 2020 +0100
Commit: Noel Grandin
CommitDate: Fri Dec 4 07:23:10 2020 +0100
tdf#134128 Use Gdiplus::DashCapRound for round dash or dot.
If Skia and OpenGL are disabled, rendering in edit mode shows no round
dashes and dots on Windows. This becomes especially visible, when
importing OOXML documents. In that case it looks as if dots are lost.
The patch uses now Gdiplus::DashCapRound instead of the previously
used Gdiplus::DashCapFlat, and it adds a similar tweak as in OOXML
import and increases the dash length by the cap size for rendering.
Change-Id: I98a258809ef253a2cacb7c5c94f2b26b89ee2488
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107181
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index de022280c4b2..b3b70320dd05 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -2343,12 +2343,39 @@ bool WinSalGraphicsImpl::drawPolyLine(
std::vector aDashArray(pStroke->size());
const double fFactor(fLineWidth == 0 ? 1.0 : 1.0 / fLineWidth);
-for(size_t a(0); a < pStroke->size(); a++)
+// tdf#134128. ODF adds caps to the dashes and dots, but GDI makes
caps from the
+// dash or dot themselve. We tweak aDashArray to look the same in GDI
(e.g. Impress edit mode)
+// and other renderes (e.g. Impress slide show), while keeping the
total length of the
+// pattern.
+// Patterns are always a sequence dash space dash space ...
+if (eLineCap != css::drawing::LineCap_BUTT)
{
-aDashArray[a] = Gdiplus::REAL((*pStroke)[a] * fFactor);
+size_t nSize = pStroke->size();
+// We want to treat dash and space in pairs. There should be no
odd size. If so, we ignore
+// last item.
+nSize /= 2;
+for(size_t a(0); a < nSize; a++)
+{
+double fDashLengthRel = (*pStroke)[2 * a] * fFactor;
+double fSpaceLengthRel = (*pStroke)[2 * a + 1] * fFactor;
+// GDI allows only positive lengths for space, Skia negative
lengths too. Thus the
+// appearance is different, in case space is too small.
+double fCorrect = fSpaceLengthRel - 1.0 <= 0 ? fSpaceLengthRel
- 0.01 : 1.0;
+aDashArray[2 * a] = Gdiplus::REAL(fDashLengthRel + fCorrect);
+aDashArray[2 * a + 1] = Gdiplus::REAL(fSpaceLengthRel -
fCorrect);
+}
}
-
-aPen.SetDashCap(Gdiplus::DashCapFlat);
+else
+{
+for(size_t a(0); a < pStroke->size(); a++)
+{
+aDashArray[a] = Gdiplus::REAL((*pStroke)[a] * fFactor);
+}
+}
+if (eLineCap == css::drawing::LineCap_ROUND)
+aPen.SetDashCap(Gdiplus::DashCapRound);
+else
+aPen.SetDashCap(Gdiplus::DashCapFlat); // "square" doesn't exist
in Gdiplus
aPen.SetDashOffset(Gdiplus::REAL(0.0));
aPen.SetDashPattern(aDashArray.data(), aDashArray.size());
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: build failure on ubuntu 18.04
On 03.12.2020 22:50, chris...@eagle.ca wrote: <-snip-> [CXX] sal/rtl/math.cxx [CXX] workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp [CXX] workdir/UnpackedTarball/skia/third_party/skcms/skcms.cpp /home/ron/libreoffice/workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp:19:10: fatal error: X11/Xlib-xcb.h: No such file or directory #include ^~~~ compilation terminated. /home/ron/libreoffice/solenv/gbuild/LinkTarget.mk:347: recipe for target '/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o' failed make[1]: *** [/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o] Error 1 make[1]: *** Waiting for unfinished jobs Makefile:282: recipe for target 'build' failed make: *** [build] Error 2 My autogen.sh command looks like this: ./autogen.sh --enable-debug --x-includes=/snap/gnome-3-34-1804/36/usr/include/ The file Xlib-xcb.h exists in the directory in the X11 directory which in turn is a child of the one listed in the --x-includes path indicated above. The file permission is 0644 for the .h file, owner is root. On 04.12.2020 1:54, Luke Benes wrote: Try: sudo apt-get install libx11-xcb-dev For some reason, the wiki was just massively paired down with stuff like this removed. https://wiki.documentfoundation.org/index.php?title=Development/Linux_Build_Dependencies In the case of dependencies, less is not more. The problem that Ron sees is clearly related to the rarely-used (and thus not thoroughly tested) --x-includes configuration, which obviously is not passed to the newly added skia external. It is a bug that needs fixing, and has nothing to do with using old or new wiki instructions (where the updated wiki article was discussed and approved on IRC, and is a clear improvement over old build-dep way, which results in actual problems when newbies report that dependencies installed that way don't work with master because of their versions are for older LO versions bundled with the distros). Ron, that looks like a great opportunity for a first contribution to LO! :-) You are welcome to join #libreoffice-dev, and discuss any questions related to how to change the makefiles of skia to pass the correct information there. -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 138542] Make printjob a background process and replace they print dialog with an icon in status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=138542 --- Comment #7 from Michael Weghorn --- (In reply to Telesto from comment #6) > I fear so, sadly :P. I personally preference/ideal as much shared code/ > behavior as possible.. If a PDF is generated under Linux and send to cups, > maybe similar approach could be used under Windows (except the cups part of > course). Yes, shared code is usually preferable. However, from the little knowledge I have about the Windows printing system, I think it just works differently and you can't just pass it a PDF file, and LO has to adhere to the way that the Windows printing system can be interacted with... (i.o.w. the designers of the Windows printing system and of the Linux printing system, CUPS, have made different decisions, and that's nothing LO can easily change.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138651] PDF opened with DRAW from WEBDAV LINKS are not saved back at the remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=138651 --- Comment #1 from Mike Kaganski --- LibreOffice deliberately uses *different* import and export filters for PDF, which makes the format not editable, and PDF appearing only in Export dialog, not in Save As. LibreOffice is not developed as a PDF editor. Its support for PDFs is very limited, in many areas: from major shortcomings (like not supporting different page layouts in a single Draw file, which might improve over time) to things that may not change - such as incompatible document model, which prevents LO from keeping most of original PDF internal structure/metadata when round-tripping. Pretending that LO "supports" PDF editing would result in much user confusion, when people will expect LO to keep the information it can't, and many bug reports for something that is not meant to work anyway. WONTFIX IMO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - cui/uiconfig
cui/uiconfig/ui/toolbarmodedialog.ui | 216 +-- 1 file changed, 108 insertions(+), 108 deletions(-) New commits: commit a6ea4f4b5d34b634f0c1743def507ac248bfc2e9 Author: Heiko Tietze AuthorDate: Thu Dec 3 11:51:11 2020 +0100 Commit: Heiko Tietze CommitDate: Fri Dec 4 06:57:31 2020 +0100 Resolves tdf#138631 - Make 'Apply to All' translatable Change-Id: I89cd1f47eec4b1b0a06e2bd870a910c975d5ea52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107156 Tested-by: Jenkins Reviewed-by: Heiko Tietze (cherry picked from commit b866b0da4007df19a17c42f56ca11e0e277ce4d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107194 diff --git a/cui/uiconfig/ui/toolbarmodedialog.ui b/cui/uiconfig/ui/toolbarmodedialog.ui index 89eb9d62c2a1..dc88d3e18864 100644 --- a/cui/uiconfig/ui/toolbarmodedialog.ui +++ b/cui/uiconfig/ui/toolbarmodedialog.ui @@ -1,39 +1,39 @@ - + True -False +False gtk-apply -False -6 +False +6 Select Your Preferred User Interface False True -center-on-parent -dialog +center-on-parent +dialog -False +False vertical 12 -False +False True -end +end -A_pply to All +A_pply to All True -True -True -True -True -True +True +True +True +True +True False @@ -43,14 +43,14 @@ -A_pply to %MODULE +A_pply to %MODULE True -True -True -True -True +True +True +True +True imgApply -True +True False @@ -62,11 +62,11 @@ gtk-close True -True -True -True -True -True +True +True +True +True +True False @@ -78,44 +78,44 @@ False False -end +end 1 True -False +False True -False -12 -12 -0 -none +False +12 +12 +0 +none True -False -6 -12 +False +6 +12 True -False +False vertical 3 Standard Toolbar True -True -False +True +False start start True -True +True False @@ -124,147 +124,147 @@ - -Single Toolbar + +Tabbed True -True -False +True +False start start True -True +True rbButton1 False True -9 +3 - -Sidebar + +
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 Shravan changed: What|Removed |Added CC|shravan.a...@gmail.com | Assignee|shravan.a...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138652] New: Sorting in Calc by Date
https://bugs.documentfoundation.org/show_bug.cgi?id=138652 Bug ID: 138652 Summary: Sorting in Calc by Date Product: LibreOffice Version: 6.3 all versions Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: salty...@gmail.com Description: Sorting by Date will not sort properly, and results are only partly sorted. I tried all that I could think of. Date format 10/2/20 . Sorted as; 10/19/20 , 10/2/20 , 10/20/20 . Steps to Reproduce: 1.Use date with format 10/1/20 Through 10/31/20 2.Insert dates in single column in random order 3.Sort with column in proper date format, Ascending. Actual Results: Results abbreviated : 10/1, 10/10, 10/11 - 10/19, 10/2, 10/20, 10/21 - 10/29, 10/3, 10/30, 10/31, 10/4, 10/5, 10/6, etc. Expected Results: 10/1/20 ,10/2,10/3,10/4,10/5,10/6,10/7,10/8,10/9, 10/10, 10/11 - 10/19, 10/20, 10/21 - 10/29, 10/30, 10/31, etc. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: LibreOffice 7.0.3.1 (x64) [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information ] OS: Windows 10 OS is 64bit: yes Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 16; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/mergecells.png |binary icon-themes/colibre/cmd/32/selecttable.png |binary icon-themes/colibre/cmd/32/splitcell.png|binary icon-themes/colibre/cmd/32/togglemergecells.png |binary icon-themes/colibre/cmd/lc_mergecells.png |binary icon-themes/colibre/cmd/lc_selecttable.png |binary icon-themes/colibre/cmd/lc_splitcell.png|binary icon-themes/colibre/cmd/lc_togglemergecells.png |binary icon-themes/colibre/cmd/sc_mergecells.png |binary icon-themes/colibre/cmd/sc_selecttable.png |binary icon-themes/colibre/cmd/sc_splitcell.png|binary icon-themes/colibre/cmd/sc_togglemergecells.png |binary icon-themes/colibre_svg/cmd/32/mergecells.svg |2 +- icon-themes/colibre_svg/cmd/32/selecttable.svg |2 +- icon-themes/colibre_svg/cmd/32/splitcell.svg|2 +- icon-themes/colibre_svg/cmd/32/togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_mergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_selecttable.svg |2 +- icon-themes/colibre_svg/cmd/lc_splitcell.svg|2 +- icon-themes/colibre_svg/cmd/lc_togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/sc_mergecells.svg |4 +--- icon-themes/colibre_svg/cmd/sc_selecttable.svg |3 +-- icon-themes/colibre_svg/cmd/sc_splitcell.svg|4 +--- icon-themes/colibre_svg/cmd/sc_togglemergecells.svg |5 + 24 files changed, 12 insertions(+), 20 deletions(-) New commits: commit a95f5e24e64948f66d49652e967c55e938800599 Author: Rizal Muttaqin AuthorDate: Thu Dec 3 17:48:07 2020 +0700 Commit: Rizal Muttaqin CommitDate: Fri Dec 4 05:55:44 2020 +0100 Colibre:Update Merge & Split Cells and Select Table Change-Id: Ibeab169f4430ae269e96e099c113a93279af9a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107155 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin (cherry picked from commit 9e190373f3ea999d15b8d6f84a7d35481e6dc971) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107198 diff --git a/icon-themes/colibre/cmd/32/mergecells.png b/icon-themes/colibre/cmd/32/mergecells.png index 2009968b1565..04fdf6e5ed49 100644 Binary files a/icon-themes/colibre/cmd/32/mergecells.png and b/icon-themes/colibre/cmd/32/mergecells.png differ diff --git a/icon-themes/colibre/cmd/32/selecttable.png b/icon-themes/colibre/cmd/32/selecttable.png index 16422ddb5806..7ca3a3a82a21 100644 Binary files a/icon-themes/colibre/cmd/32/selecttable.png and b/icon-themes/colibre/cmd/32/selecttable.png differ diff --git a/icon-themes/colibre/cmd/32/splitcell.png b/icon-themes/colibre/cmd/32/splitcell.png index 7c4870459705..154dda6e0078 100644 Binary files a/icon-themes/colibre/cmd/32/splitcell.png and b/icon-themes/colibre/cmd/32/splitcell.png differ diff --git a/icon-themes/colibre/cmd/32/togglemergecells.png b/icon-themes/colibre/cmd/32/togglemergecells.png index 13168c1cda59..bf75d7f8da93 100644 Binary files a/icon-themes/colibre/cmd/32/togglemergecells.png and b/icon-themes/colibre/cmd/32/togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_mergecells.png b/icon-themes/colibre/cmd/lc_mergecells.png index 3a1d1c9bb771..540cb967dd82 100644 Binary files a/icon-themes/colibre/cmd/lc_mergecells.png and b/icon-themes/colibre/cmd/lc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_selecttable.png b/icon-themes/colibre/cmd/lc_selecttable.png index 9d503bc3615d..b3967a3550e4 100644 Binary files a/icon-themes/colibre/cmd/lc_selecttable.png and b/icon-themes/colibre/cmd/lc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/lc_splitcell.png b/icon-themes/colibre/cmd/lc_splitcell.png index fc66a5c5dca2..ab16e79fc70b 100644 Binary files a/icon-themes/colibre/cmd/lc_splitcell.png and b/icon-themes/colibre/cmd/lc_splitcell.png differ diff --git a/icon-themes/colibre/cmd/lc_togglemergecells.png b/icon-themes/colibre/cmd/lc_togglemergecells.png index 6c38119ad681..9bb798f9c578 100644 Binary files a/icon-themes/colibre/cmd/lc_togglemergecells.png and b/icon-themes/colibre/cmd/lc_togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_mergecells.png b/icon-themes/colibre/cmd/sc_mergecells.png index 8890afcc61a6..a5bec510fead 100644 Binary files a/icon-themes/colibre/cmd/sc_mergecells.png and b/icon-themes/colibre/cmd/sc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_selecttable.png b/icon-themes/colibre/cmd/sc_selecttable.png index c3518db44221..725a86d56794 100644 Binary files a/icon-themes/colibre/cmd/sc_selecttable.png and b/icon-themes/colibre/cmd/sc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/sc_splitcell.png b/icon-themes/colibre/cmd/sc_splitcell.png index 47bf65e10f95..117735c703ba 100644 Binary files a/icon-themes/colibre/cmd/sc_splitcell.png and b/icon-themes/colibre/cmd/sc_splitcell.png differ diff --git
[Libreoffice-bugs] [Bug 138260] Can't select German language when it is not the default language
https://bugs.documentfoundation.org/show_bug.cgi?id=138260 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138259] Tools>Language>For All Text change default languages for all documents
https://bugs.documentfoundation.org/show_bug.cgi?id=138259 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135732] Cutting image in frame in table saved as DOCX doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=135732 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135621] FILESAVE DOCX: Frame ends up in footer
https://bugs.documentfoundation.org/show_bug.cgi?id=135621 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138014] KDE: Horizontal scrollbar lacks right end button
https://bugs.documentfoundation.org/show_bug.cgi?id=138014 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138323] File reset when I indent specific numbering list item and Save in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=138323 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135714] There are no image boundary's; image frame can be moved outside of page (especially DOCX, but also with ODT)
https://bugs.documentfoundation.org/show_bug.cgi?id=135714 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138320] search-string menu should open with the LAST search, not the first menu item
https://bugs.documentfoundation.org/show_bug.cgi?id=138320 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135707] Shape outside frame figure frame on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=135707 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135692] FILEEXPORT DOCX: Page break for a table on top of the first page on export to DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=135692 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138316] sending email through Mailspring (Linux) provides input/output error
https://bugs.documentfoundation.org/show_bug.cgi?id=138316 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132761] After using Libre Calc for a while, the pull-down menus and the right-click menu have no text. Closing and restarting Libre Calc fixes it for a while, then problem reoc
https://bugs.documentfoundation.org/show_bug.cgi?id=132761 --- Comment #3 from QA Administrators --- Dear Malcolm, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132759] Error in German translation/grammar correction
https://bugs.documentfoundation.org/show_bug.cgi?id=132759 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138347] Link to call Basic script with vnd.sun.star.script: not working in Writer. Same thing working in Calc (also with HYPERLINK()).
https://bugs.documentfoundation.org/show_bug.cgi?id=138347 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138337] Icon Rename does not affect tool tip
https://bugs.documentfoundation.org/show_bug.cgi?id=138337 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80713] Missing string reference keys [KeyID] in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=80713 --- Comment #26 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132761] After using Libre Calc for a while, the pull-down menus and the right-click menu have no text. Closing and restarting Libre Calc fixes it for a while, then problem reoc
https://bugs.documentfoundation.org/show_bug.cgi?id=132761 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114087] Unicode BiDi characters break font rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=114087 --- Comment #11 from QA Administrators --- Dear Volga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132759] Error in German translation/grammar correction
https://bugs.documentfoundation.org/show_bug.cgi?id=132759 --- Comment #3 from QA Administrators --- Dear Otto Haberknecht, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123810] [META] Classification bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=123810 Bug 123810 depends on bug 122586, which changed state. Bug 122586 Summary: Classification: by using the dialog, Watermark text from policy is not placed in the document https://bugs.documentfoundation.org/show_bug.cgi?id=122586 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122586] Classification: by using the dialog, Watermark text from policy is not placed in the document
https://bugs.documentfoundation.org/show_bug.cgi?id=122586 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122586] Classification: by using the dialog, Watermark text from policy is not placed in the document
https://bugs.documentfoundation.org/show_bug.cgi?id=122586 --- Comment #11 from QA Administrators --- Dear Cor Nouws, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133724] Crash in: sal3.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=133724 --- Comment #5 from QA Administrators --- Dear w.c.rees, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104257] FILEOPEN DOCX: Wordart shadow is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=104257 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/mergecells.png |binary icon-themes/colibre/cmd/32/selecttable.png |binary icon-themes/colibre/cmd/32/splitcell.png|binary icon-themes/colibre/cmd/32/togglemergecells.png |binary icon-themes/colibre/cmd/lc_mergecells.png |binary icon-themes/colibre/cmd/lc_selecttable.png |binary icon-themes/colibre/cmd/lc_splitcell.png|binary icon-themes/colibre/cmd/lc_togglemergecells.png |binary icon-themes/colibre/cmd/sc_mergecells.png |binary icon-themes/colibre/cmd/sc_selecttable.png |binary icon-themes/colibre/cmd/sc_splitcell.png|binary icon-themes/colibre/cmd/sc_togglemergecells.png |binary icon-themes/colibre_svg/cmd/32/mergecells.svg |2 +- icon-themes/colibre_svg/cmd/32/selecttable.svg |2 +- icon-themes/colibre_svg/cmd/32/splitcell.svg|2 +- icon-themes/colibre_svg/cmd/32/togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_mergecells.svg |2 +- icon-themes/colibre_svg/cmd/lc_selecttable.svg |2 +- icon-themes/colibre_svg/cmd/lc_splitcell.svg|2 +- icon-themes/colibre_svg/cmd/lc_togglemergecells.svg |2 +- icon-themes/colibre_svg/cmd/sc_mergecells.svg |4 +--- icon-themes/colibre_svg/cmd/sc_selecttable.svg |3 +-- icon-themes/colibre_svg/cmd/sc_splitcell.svg|4 +--- icon-themes/colibre_svg/cmd/sc_togglemergecells.svg |5 + 24 files changed, 12 insertions(+), 20 deletions(-) New commits: commit 9e190373f3ea999d15b8d6f84a7d35481e6dc971 Author: Rizal Muttaqin AuthorDate: Thu Dec 3 17:48:07 2020 +0700 Commit: Rizal Muttaqin CommitDate: Fri Dec 4 04:42:46 2020 +0100 Colibre:Update Merge & Split Cells and Select Table Change-Id: Ibeab169f4430ae269e96e099c113a93279af9a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107155 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/colibre/cmd/32/mergecells.png b/icon-themes/colibre/cmd/32/mergecells.png index 2009968b1565..04fdf6e5ed49 100644 Binary files a/icon-themes/colibre/cmd/32/mergecells.png and b/icon-themes/colibre/cmd/32/mergecells.png differ diff --git a/icon-themes/colibre/cmd/32/selecttable.png b/icon-themes/colibre/cmd/32/selecttable.png index 16422ddb5806..7ca3a3a82a21 100644 Binary files a/icon-themes/colibre/cmd/32/selecttable.png and b/icon-themes/colibre/cmd/32/selecttable.png differ diff --git a/icon-themes/colibre/cmd/32/splitcell.png b/icon-themes/colibre/cmd/32/splitcell.png index 7c4870459705..154dda6e0078 100644 Binary files a/icon-themes/colibre/cmd/32/splitcell.png and b/icon-themes/colibre/cmd/32/splitcell.png differ diff --git a/icon-themes/colibre/cmd/32/togglemergecells.png b/icon-themes/colibre/cmd/32/togglemergecells.png index 13168c1cda59..bf75d7f8da93 100644 Binary files a/icon-themes/colibre/cmd/32/togglemergecells.png and b/icon-themes/colibre/cmd/32/togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_mergecells.png b/icon-themes/colibre/cmd/lc_mergecells.png index 3a1d1c9bb771..540cb967dd82 100644 Binary files a/icon-themes/colibre/cmd/lc_mergecells.png and b/icon-themes/colibre/cmd/lc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/lc_selecttable.png b/icon-themes/colibre/cmd/lc_selecttable.png index 9d503bc3615d..b3967a3550e4 100644 Binary files a/icon-themes/colibre/cmd/lc_selecttable.png and b/icon-themes/colibre/cmd/lc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/lc_splitcell.png b/icon-themes/colibre/cmd/lc_splitcell.png index fc66a5c5dca2..ab16e79fc70b 100644 Binary files a/icon-themes/colibre/cmd/lc_splitcell.png and b/icon-themes/colibre/cmd/lc_splitcell.png differ diff --git a/icon-themes/colibre/cmd/lc_togglemergecells.png b/icon-themes/colibre/cmd/lc_togglemergecells.png index 6c38119ad681..9bb798f9c578 100644 Binary files a/icon-themes/colibre/cmd/lc_togglemergecells.png and b/icon-themes/colibre/cmd/lc_togglemergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_mergecells.png b/icon-themes/colibre/cmd/sc_mergecells.png index 8890afcc61a6..a5bec510fead 100644 Binary files a/icon-themes/colibre/cmd/sc_mergecells.png and b/icon-themes/colibre/cmd/sc_mergecells.png differ diff --git a/icon-themes/colibre/cmd/sc_selecttable.png b/icon-themes/colibre/cmd/sc_selecttable.png index c3518db44221..725a86d56794 100644 Binary files a/icon-themes/colibre/cmd/sc_selecttable.png and b/icon-themes/colibre/cmd/sc_selecttable.png differ diff --git a/icon-themes/colibre/cmd/sc_splitcell.png b/icon-themes/colibre/cmd/sc_splitcell.png index 47bf65e10f95..117735c703ba 100644 Binary files a/icon-themes/colibre/cmd/sc_splitcell.png and b/icon-themes/colibre/cmd/sc_splitcell.png differ diff --git a/icon-themes/colibre/cmd/sc_togglemergecells.png b/icon-themes/colibre/cmd/sc_togglemergecells.png index 5cdbee0608c4..0b168573c2de 100644 Binary files
[Libreoffice-ux-advise] [Bug 138628] ClearDirectFormatting does not remove page break
https://bugs.documentfoundation.org/show_bug.cgi?id=138628 --- Comment #2 from tor...@yahoo.com --- (In reply to Heiko Tietze from comment #1) > Clear _direct_ formatting does nothing but to remove formats like font > weight, size, and color. It's a bit unclear what you mean with "style > TextBody includes no page break" ** In the styles list, right-click TextBody, choose Modify>TextFlow, Breaks: Insert is NOT checked —at least, after a fresh installation of LO. Try the converse with style Heading1: Check TextFlow, Breaks: Insert PageBreak; apply ^1 to any text, make it a Heading1: new page; format it, uncheck Breaks: PageBreak disappears; ^m restores the PageBreak. > Why should one add a page break after/before text body? **before. Because the text contains a frame which does not fit in the current page, and LO has trouble displaying it. The page break moves text and frame to a new page. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 138628] ClearDirectFormatting does not remove page break
https://bugs.documentfoundation.org/show_bug.cgi?id=138628 --- Comment #2 from tor...@yahoo.com --- (In reply to Heiko Tietze from comment #1) > Clear _direct_ formatting does nothing but to remove formats like font > weight, size, and color. It's a bit unclear what you mean with "style > TextBody includes no page break" ** In the styles list, right-click TextBody, choose Modify>TextFlow, Breaks: Insert is NOT checked —at least, after a fresh installation of LO. Try the converse with style Heading1: Check TextFlow, Breaks: Insert PageBreak; apply ^1 to any text, make it a Heading1: new page; format it, uncheck Breaks: PageBreak disappears; ^m restores the PageBreak. > Why should one add a page break after/before text body? **before. Because the text contains a frame which does not fit in the current page, and LO has trouble displaying it. The page break moves text and frame to a new page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
build failure on ubuntu 18.04
Hi all, I'm a newbie on the libreoffice front, and I'm tracking down a bug that I've discovered in writer. Rather than posting a symptom-only bug, I've been trying to build a debug version of libreoffice 7.0.0, but the build keeps failing with the message as follows: <-snip-> [CXX] sal/rtl/math.cxx [CXX] workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp [CXX] workdir/UnpackedTarball/skia/third_party/skcms/skcms.cpp /home/ron/libreoffice/workdir/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.cpp:19:10: fatal error: X11/Xlib-xcb.h: No such file or directory #include ^~~~ compilation terminated. /home/ron/libreoffice/solenv/gbuild/LinkTarget.mk:347: recipe for target '/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o' failed make[1]: *** [/home/ron/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/tools/sk_app/unix/VulkanWindowContext_unix.o] Error 1 make[1]: *** Waiting for unfinished jobs Makefile:282: recipe for target 'build' failed make: *** [build] Error 2 My autogen.sh command looks like this: ./autogen.sh --enable-debug --x-includes=/snap/gnome-3-34-1804/36/usr/include/ The file Xlib-xcb.h exists in the directory in the X11 directory which in turn is a child of the one listed in the --x-includes path indicated above. The file permission is 0644 for the .h file, owner is root. Can anyone give me some guidance on how to proceed? Thanks in advance. Ron___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93846] Localized Emoji Does Not Work (while the original english string works)
https://bugs.documentfoundation.org/show_bug.cgi?id=93846 --- Comment #11 from Ming Hua --- (In reply to Ming Hua from comment #10) > Tested with ":copyright:" and ":版权:" on 7.1.0 Beta1 In 7.1 this has already been changed to ":版权符号:", but still doesn't work. On the other hand, manually added "：版权：" (full-width colons instead of the ascii colons, so the whole string will be recognized as simp. Chinese) replacement rules works. I think my guess was on target. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93846] Localized Emoji Does Not Work (while the original english string works)
https://bugs.documentfoundation.org/show_bug.cgi?id=93846 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com --- Comment #10 from Ming Hua --- I don't use this autocorrect feature (either for Chinese or English), so this is just a wild guess, but it seems to me the problem is that Writer detects the string ":版权:" as mixed language instead of simp. Chinese before applying autocorrect replace rules. Tested with ":copyright:" and ":版权:" on 7.1.0 Beta1, and can reproduce: Version: 7.1.0.0.beta1 (x64) Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53 CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138633] FILEOPEN PPTX: content of formula not shown (sort-of regression from 5.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=138633 --- Comment #3 from yanjing...@gmail.com --- Reproduce in Version: 7.1.0.0.beta1 (x64) Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53 CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Version: 7.0.4.1 (x64) Build ID: e3cebc55238632eae061a3da668963d484a71147 CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: zh-CN (zh_CN); 界面: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sal/rtl
sal/rtl/math.cxx | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) New commits: commit 73d98236ea83296018e6da30d0d7ec0219313776 Author: Eike Rathke AuthorDate: Thu Dec 3 18:18:23 2020 +0100 Commit: Eike Rathke CommitDate: Fri Dec 4 00:52:54 2020 +0100 Better accuracy in rtl_math_approxValue(), tdf#138360 related Similar to commit 5abb1890ffafe5a2212076208a1c6e226f1ffa4e for rtl_math_round() use the reciprocal value in an inverse operation for negative exponents to not use the inexact 1e-1 0.10001 and so on factors. Change-Id: I05b852e06f2c31d6e0ce622b07277a81a5690833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107172 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 520949f17a91c531ea0c8b3856ffcf3c7ac8a3b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107195 diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx index a296927635bf..46a3e925b95b 100644 --- a/sal/rtl/math.cxx +++ b/sal/rtl/math.cxx @@ -1299,16 +1299,24 @@ double SAL_CALL rtl_math_approxValue( double fValue ) SAL_THROW_EXTERN_C() int nExp = static_cast< int >(floor(log10(fValue))); nExp = 14 - nExp; -double fExpValue = getN10Exp(nExp); +double fExpValue = getN10Exp(abs(nExp)); + +if (nExp < 0) +fValue /= fExpValue; +else +fValue *= fExpValue; -fValue *= fExpValue; // If the original value was near DBL_MIN we got an overflow. Restore and // bail out. if (!std::isfinite(fValue)) return fOrigValue; fValue = std::round(fValue); -fValue /= fExpValue; + +if (nExp < 0) +fValue *= fExpValue; +else +fValue /= fExpValue; // If the original value was near DBL_MAX we got an overflow. Restore and // bail out. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138249] PARAGRAPH STYLE DIALOG: Font color style change breaks when reverting to automatic color
https://bugs.documentfoundation.org/show_bug.cgi?id=138249 --- Comment #3 from João Paulo --- (In reply to Dieter from comment #2) > Please open a separate report for this secon problem, since we can't mix two > issues in one bug report. Thanks. I couldn't reproduce it again, so I will leave it for now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138651] New: PDF opened with DRAW from WEBDAV LINKS are not saved back at the remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=138651 Bug ID: 138651 Summary: PDF opened with DRAW from WEBDAV LINKS are not saved back at the remote location Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lionel.v...@adaris.org Description: Hi. I'm developing a free opensource software for lawfirms. I get a very satisfying workflow using the ability of LibreOffice to open webdav links (https://cloud.mydomain.com/files/test.odt). The only anoying thing is with PDF files. They open fine with DRAW. I can easily edit them. But when I want to save, it doesn't save back the PDF on the WEBDAV remote location. It asks to save in ODG format LOCALLY. I also tried to use "EXPORT DIRECTLY AS PDF" but instead of saving back to the WEBDAV, it once again ask to save the PDF LOCALLY. My suggestion : if DRAW opens a PDF, it should save as PDF directly on the WEBDAV. Or at least it should save on the WEBDAV when choosing EXPORT DIRECTLY AS PDF. What do you think about that ? Steps to Reproduce: 1.Open a PDF in DRAW from a webdav link (example : https://cloud.mydomain.com/test.pdf) 2.Edit the PDF, for example move a text box 3.Save the PDF Actual Results: It asks to save locally as ODG format Export Directly to PDF function asks to save a new pdf locally Expected Results: It should save as PDF at the remote location, like WRITER does with ODT files opened from WEBDAV. At least, if that's not possible, the EXPORT DIRECTLY AS PDF function should save remotely and not ask to create a new file locally Reproducible: Always User Profile Reset: No Additional Info: Thanks for the amazing work on Libreoffice ! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642 --- Comment #2 from Telesto --- (In reply to Regina Henschel from comment #1) > Or make a choice > * continue with current page style > * start with other page style from here. Select: > and show drop-down list only in the second case. >From communication perspective I opt for the above: make choice here. Thing is there is always a 'page style'. The question is if you explicitly set one. This an be they same as the previous paragraph.. The difference occur only when changing the page style for a area limited by page breaks.. [The other topic the page break line showing if explicit page style is set or 'inheriting' the previous one.. There bug reporting with a proposal in that direction somewhere]. As part the long list of my complains (in)valid complains regarding accessibility/work-ability with page styles. @Offtopic However i'm also the opinion of 'page breaks' not being a part of paragraph style by definition. I surely get they idea of connecting page break to paragraph style, if this done explicitly on purpose. However as the only way, I'm still not really convinced.. I never had the impression of page breaks being attached to paragraphs in Word with all the quirks it brings.. [But this touches ideology, and maybe even file format specifications] and rather off-topic here -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642 --- Comment #2 from Telesto --- (In reply to Regina Henschel from comment #1) > Or make a choice > * continue with current page style > * start with other page style from here. Select: > and show drop-down list only in the second case. >From communication perspective I opt for the above: make choice here. Thing is there is always a 'page style'. The question is if you explicitly set one. This an be they same as the previous paragraph.. The difference occur only when changing the page style for a area limited by page breaks.. [The other topic the page break line showing if explicit page style is set or 'inheriting' the previous one.. There bug reporting with a proposal in that direction somewhere]. As part the long list of my complains (in)valid complains regarding accessibility/work-ability with page styles. @Offtopic However i'm also the opinion of 'page breaks' not being a part of paragraph style by definition. I surely get they idea of connecting page break to paragraph style, if this done explicitly on purpose. However as the only way, I'm still not really convinced.. I never had the impression of page breaks being attached to paragraphs in Word with all the quirks it brings.. [But this touches ideology, and maybe even file format specifications] and rather off-topic here -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137576] Measure line anchored "To cell (resize with cell)" is distorted after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=137576 --- Comment #7 from Regina Henschel --- The patch had two errors. They are fixed with commits https://git.libreoffice.org/core/+/520a2819fa6030ec11175d82dd42cfcdb2e92634%5E! and https://git.libreoffice.org/core/+/60ae45f5846f69857c46b74d153fea1ef14d3c4d%5E! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: build failure on ubuntu 18.04
Try: sudo apt-get install libx11-xcb-dev For some reason, the wiki was just massively paired down with stuff like this removed. https://wiki.documentfoundation.org/index.php?title=Development/Linux_Build_Dependencies In the case of dependencies, less is not more. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Crash test update
On Wed, 2020-12-02 at 20:46 +, crashtest wrote: > New crashtest update available at > https://dev-builds.libreoffice.org/crashtest/f7e2f5bca938aa916830e07895d2da6820282055/ FWIW the reoccurring SwLayoutCache::CompareLayout assert at sw/source/core/layout/laycache.cxx:352 https://dev- builds.libreoffice.org/crashtest/f7e2f5bca938aa916830e07895d2da68202820 55/backtraces/task141-core.backtrace.txt can be reproduced with e.g. fdo33533-1.odt and bisects to commit c0864f26f3143ea81c65d3826fae32a8fd54c531 Date: Fri Nov 6 21:47:21 2020 +0100 sw_fieldmarkhide: init fieldmark mode from options but I haven't a notion what "!pFrame->GetMergedPara()" might mean ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: how does arithmetic exactly work in Calc?
Hi Regina, by quickly browsing through the code, it seems like there's an "optimization" that returns 0 when subtracting nearby values, so that's at odd with the IEEE 754 spec. Do you know if there's something similar to a spec for Calc, in addition to and complementing the implementation? Or should one consider the implementation as *the* definitive spec? I ask because while most interested people can probably read and understand a spec, not everybody is able to read C++ code. Thanks! Michel On 2020-12-03 17:27, Regina Henschel wrote: Hi Michel, for example look for ScAdd in https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr5.cxx and for the rtl::math things in https://opengrok.libreoffice.org/xref/core/include/rtl/math.hxx Kind regards Regina Michel Onoff schrieb am 03-Dec-20 um 13:48: Hi, I would like to understand how simple arithmetic (+ - * /) works in Calc. I kind of guess that the underlying internal number representation is IEEE 754 double (64 bit). I also guess that when a double is shown on the sheet it is approximated by a decimal with at most 15 significand digits. To reproduce the behavior below, use scientific notation with 20 digits or more. I have two slightly different number x and x'. x is 2^-49 (a formula) while x' is 1.77635683940025E-15 (a literal). Their decimal representation appear equal on the sheet, but they are, indeed, slightly different internally. You can set them apart as follows: y = x - 1.7763568394002E-15 y' = x' - 1.7763568394002E-15 that is, by subtracting the same number from x and x'. y and y' appear differently on the sheet, meaning that x and x' are different internally to start with. However, x - x' is exactly 0. In IEEE 754 arithmetic, two numbers are equal if and only if their difference is 0. That would mean that x and x' are equal, which they are not from the above. So, what is the exact model for Calc's arithmetic? Which calculations are performed exactly on fundamental arithmetic operations? Thanks Michel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 96505] Get rid of cargo cult "long" integer literals
https://bugs.documentfoundation.org/show_bug.cgi?id=96505 --- Comment #74 from Commit Notification --- Gökhan Özeloğlu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/561e5559bb68242c7f785f0ca3bee3eb12b58963 tdf#96505: Get rid of cargo cult long integer literals It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96505] Get rid of cargo cult "long" integer literals
https://bugs.documentfoundation.org/show_bug.cgi?id=96505 Commit Notification changed: What|Removed |Added Whiteboard|target:5.2.0 target:5.3.0 |target:5.2.0 target:5.3.0 |target:5.4.0 target:6.0.0 |target:5.4.0 target:6.0.0 |target:6.1.0 target:6.5.0 |target:6.1.0 target:6.5.0 |target:7.0.0|target:7.0.0 target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source onlineupdate/source sd/source svl/source xmloff/source
filter/source/msfilter/svdfppt.cxx|2 +-
onlineupdate/source/update/updater/progressui_win.cxx |2 +-
sd/source/ui/func/fumorph.cxx |4 ++--
svl/source/svdde/ddesvr.cxx |2 +-
xmloff/source/core/namespacemap.cxx |2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 561e5559bb68242c7f785f0ca3bee3eb12b58963
Author: Gökhan Özeloğlu
AuthorDate: Sun Nov 29 19:09:21 2020 +
Commit: Tor Lillqvist
CommitDate: Thu Dec 3 23:35:48 2020 +0100
tdf#96505: Get rid of cargo cult long integer literals
Change-Id: I7226f93a87e0b31634a3c0942f3f5ec8778161fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106843
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index 09e69e9fcb6a..f877bbc99e09 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -1793,7 +1793,7 @@ static bool SdrPowerPointOLEDecompress( SvStream&
rOutput, SvStream& rInput, sal
aZCodec.BeginCompression();
SvMemoryStream aSource( pBuf.get(), nInputSize, StreamMode::READ );
aZCodec.Decompress( aSource, rOutput );
-const bool bSuccess(0L != aZCodec.EndCompression());
+const bool bSuccess(0 != aZCodec.EndCompression());
rInput.Seek( nOldPos );
return bSuccess;
}
diff --git a/onlineupdate/source/update/updater/progressui_win.cxx
b/onlineupdate/source/update/updater/progressui_win.cxx
index 0b8017823486..7ef23cfabfdf 100644
--- a/onlineupdate/source/update/updater/progressui_win.cxx
+++ b/onlineupdate/source/update/updater/progressui_win.cxx
@@ -67,7 +67,7 @@ UpdateDialog(HWND hDlg)
{
int pos = int(sProgress + 0.5f);
HWND hWndPro = GetDlgItem(hDlg, IDC_PROGRESS);
-SendMessage(hWndPro, PBM_SETPOS, pos, 0L);
+SendMessage(hWndPro, PBM_SETPOS, pos, 0);
}
// The code in this function is from MSDN:
diff --git a/sd/source/ui/func/fumorph.cxx b/sd/source/ui/func/fumorph.cxx
index 9755b7ae3a20..842cd001b85e 100644
--- a/sd/source/ui/func/fumorph.cxx
+++ b/sd/source/ui/func/fumorph.cxx
@@ -188,7 +188,7 @@ static ::basegfx::B2DPolygon ImpGetExpandedPolygon(
double fDestPos(0.0);
double fSrcPos(0.0);
sal_uInt32 nSrcPos(0);
-sal_uInt32 nSrcPosNext((nSrcPos + 1 == rCandidate.count()) ? 0L :
nSrcPos + 1);
+sal_uInt32 nSrcPosNext((nSrcPos + 1 == rCandidate.count()) ? 0 :
nSrcPos + 1);
double
fNextSrcLen(::basegfx::B2DVector(rCandidate.getB2DPoint(nSrcPos) -
rCandidate.getB2DPoint(nSrcPosNext)).getLength());
for(sal_uInt32 b(0); b < nNum; b++)
@@ -198,7 +198,7 @@ static ::basegfx::B2DPolygon ImpGetExpandedPolygon(
{
fSrcPos += fNextSrcLen;
nSrcPos++;
-nSrcPosNext = (nSrcPos + 1 == rCandidate.count()) ? 0L :
nSrcPos + 1;
+nSrcPosNext = (nSrcPos + 1 == rCandidate.count()) ? 0 :
nSrcPos + 1;
fNextSrcLen =
::basegfx::B2DVector(rCandidate.getB2DPoint(nSrcPos) -
rCandidate.getB2DPoint(nSrcPosNext)).getLength();
}
diff --git a/svl/source/svdde/ddesvr.cxx b/svl/source/svdde/ddesvr.cxx
index fe0e5c59f41b..4893fdb53e61 100644
--- a/svl/source/svdde/ddesvr.cxx
+++ b/svl/source/svdde/ddesvr.cxx
@@ -402,7 +402,7 @@ DdeService::DdeService( const OUString& rService )
DdeInternal::SvrCallback,
APPCLASS_STANDARD |
CBF_SKIP_REGISTRATIONS |
-CBF_SKIP_UNREGISTRATIONS, 0L ) );
+CBF_SKIP_UNREGISTRATIONS, 0 ) );
pInst->pServicesSvr = new DdeServices;
}
else
diff --git a/xmloff/source/core/namespacemap.cxx
b/xmloff/source/core/namespacemap.cxx
index 1fd9f9d70cbb..2a0ca441d05a 100644
--- a/xmloff/source/core/namespacemap.cxx
+++ b/xmloff/source/core/namespacemap.cxx
@@ -312,7 +312,7 @@ sal_uInt16 SvXMLNamespaceMap::GetKeyByQName(const OUString&
rQName,
else
{
// normal case: ':' found -> get prefix/suffix
-sEntryPrefix = rQName.copy( 0L, nColonPos );
+sEntryPrefix = rQName.copy( 0, nColonPos );
sEntryName = rQName.copy( nColonPos + 1 );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - 2 commits - sw/source
sw/source/core/doc/textboxhelper.cxx | 17 +++--
sw/source/core/frmedt/fecopy.cxx |5 +
2 files changed, 12 insertions(+), 10 deletions(-)
New commits:
commit dc8b0ef9ddf52aac2e2188925d9273c202086834
Author: Attila Bakos (NISZ)
AuthorDate: Wed Nov 25 14:06:49 2020 +0100
Commit: Xisco Fauli
CommitDate: Thu Dec 3 23:31:56 2020 +0100
tdf#135044 sw: fix Ctrl + drag textbox copy
Text content was missing in the new textbox
after Ctrl + drag and drop copying of a text box
with text content.
Change-Id: Ib93096df0028ee0e02c73804c1518aec4490b57f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106585
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 64819ab91555b5afe360cf25aba6431546c4d905)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107107
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/frmedt/fecopy.cxx b/sw/source/core/frmedt/fecopy.cxx
index bad9f4a671cb..51d21db7e678 100644
--- a/sw/source/core/frmedt/fecopy.cxx
+++ b/sw/source/core/frmedt/fecopy.cxx
@@ -400,6 +400,11 @@ bool SwFEShell::CopyDrawSel( SwFEShell& rDestShell, const
Point& rSttPt,
if (SwDrawFrameFormat *pDrawFormat =
dynamic_cast(pFormat))
pDrawFormat->PosAttrSet();
}
+if (SwTextBoxHelper::getOtherTextBoxFormat(pFormat,
RES_DRAWFRMFMT))
+{
+SwTextBoxHelper::syncFlyFrameAttr(*pFormat,
pFormat->GetAttrSet());
+}
+
if( bSelectInsert )
pDestDrwView->MarkObj( pNew, pDestPgView );
}
commit 12637d0ddecd9c70c7255f76ff5e3b8651ae273e
Author: Attila Bakos (NISZ)
AuthorDate: Tue Nov 24 15:49:41 2020 +0100
Commit: Xisco Fauli
CommitDate: Thu Dec 3 23:31:48 2020 +0100
tdf#137802 sw: fix crash of textbox anchored to page
This is a regression from commit
a7bd634371285dbdceaf775dc31b6b586c7ca02f
(tdf#137802 tdf#84691 sw: sync anchoring of
textbox with UNO), where synching didn't
remove the anchoring setting.
Steps for reproducing:
1. In an empty document add a new paragraph so that you have two.
2. Insert – Shape – Basic Shapes – Rectangle and place it to the
center of page to have it anchored to the second empty paragraph.
3. Right click on the shape – Add Text Box
4. Right click on the shape – Position and Size
5. Set Anchor as To page
6. Delete the second paragraph that the shape was anchored
7. Click on the shape and press Delete
Change-Id: I67f076bb9fc26cf47185aa21a84371dd85c6e3ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106531
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 918608006728cc753dc12a1b1499172dabe15376)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107109
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/doc/textboxhelper.cxx
b/sw/source/core/doc/textboxhelper.cxx
index 14fa5932bf51..fdc5488893d3 100644
--- a/sw/source/core/doc/textboxhelper.cxx
+++ b/sw/source/core/doc/textboxhelper.cxx
@@ -828,17 +828,14 @@ void SwTextBoxHelper::syncFlyFrameAttr(SwFrameFormat&
rShape, SfxItemSet const&
const SfxPoolItem* pItem = aIter.GetCurItem();
const RndStdIds aAnchId = rShape.GetAnchor().GetAnchorId();
-if ((aAnchId == RndStdIds::FLY_AT_PAGE && rShape.GetAnchor().GetPageNum()
!= 0)
-|| ((aAnchId == RndStdIds::FLY_AT_PARA || aAnchId ==
RndStdIds::FLY_AT_CHAR)
-&& rShape.GetAnchor().GetContentAnchor()))
+if (aAnchId == RndStdIds::FLY_AT_PAGE && rShape.GetAnchor().GetPageNum()
!= 0)
{
-SwFormatAnchor aNewAnch = pFormat->GetAnchor();
-if (rShape.GetAnchor().GetContentAnchor())
-aNewAnch.SetAnchor(rShape.GetAnchor().GetContentAnchor());
-if (rShape.GetAnchor().GetPageNum() > 0)
-aNewAnch.SetPageNum(rShape.GetAnchor().GetPageNum());
-aNewAnch.SetType(rShape.GetAnchor().GetAnchorId());
-aTextBoxSet.Put(aNewAnch);
+aTextBoxSet.Put(SwFormatAnchor(RndStdIds::FLY_AT_PAGE,
rShape.GetAnchor().GetPageNum()));
+}
+if ((aAnchId == RndStdIds::FLY_AT_PARA || aAnchId ==
RndStdIds::FLY_AT_CHAR)
+&& rShape.GetAnchor().GetContentAnchor())
+{
+aTextBoxSet.Put(rShape.GetAnchor());
}
do
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - extras/source
extras/source/autocorr/lang/ko/DocumentList.xml | 167 +++- 1 file changed, 161 insertions(+), 6 deletions(-) New commits: commit 8e9882b6d96367329a41e1f84ab1a880465bdf3f Author: DaeHyun Sung AuthorDate: Mon Nov 30 00:18:45 2020 +0900 Commit: Xisco Fauli CommitDate: Thu Dec 3 23:31:26 2020 +0100 tdf#135727 add & sorting Korean Autocorrect list add new Korean Autocorrect assembled Korean autocorrect in descending order Origin from LibreOffice Korean github repo https://github.com/libreoffice-kr/autocorr_kr Change-Id: I1460204cdb594c443598e67d1d9372d73f29e002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106841 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas (cherry picked from commit d23a2ebe43a27ab62d9c5c9c3f23e8939d73689d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107108 Reviewed-by: Xisco Fauli diff --git a/extras/source/autocorr/lang/ko/DocumentList.xml b/extras/source/autocorr/lang/ko/DocumentList.xml index 2215c712fcbe..1cbf7330c36c 100644 --- a/extras/source/autocorr/lang/ko/DocumentList.xml +++ b/extras/source/autocorr/lang/ko/DocumentList.xml @@ -2326,71 +2326,226 @@ - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + "/> + "/> + + + + + + + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642
Regina Henschel changed:
What|Removed |Added
CC||rb.hensc...@t-online.de
--- Comment #1 from Regina Henschel ---
Yes, {None] is not clear. In content it means "continue using current page
style".
So perhaps [current] would be better?
Or make a choice
* continue with current page style
* start with other page style from here. Select:
and show drop-down list only in the second case.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 138642] Manual break dialog says (next) page style set to none. Appears to incorrect, the page layout is always based on a page style
https://bugs.documentfoundation.org/show_bug.cgi?id=138642
Regina Henschel changed:
What|Removed |Added
CC||rb.hensc...@t-online.de
--- Comment #1 from Regina Henschel ---
Yes, {None] is not clear. In content it means "continue using current page
style".
So perhaps [current] would be better?
Or make a choice
* continue with current page style
* start with other page style from here. Select:
and show drop-down list only in the second case.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138650] Columns in multicolumns header lost when DOC/DOCX file is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138650 --- Comment #1 from Angel --- Created attachment 167810 --> https://bugs.documentfoundation.org/attachment.cgi?id=167810=edit Example file of the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138650] New: Columns in multicolumns header lost when DOC/DOCX file is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=138650 Bug ID: 138650 Summary: Columns in multicolumns header lost when DOC/DOCX file is saved Product: LibreOffice Version: 7.0.3.1 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ang...@rumbosur.com.ar Description: If you have a file heather with more than one column and save the file, when you reopen it the heather has lost the multiple column configuration, but it seems the content is not lost. This happen when you save it in DOC or DOCX formal. It seems it doesn´t happen in the ODT format Steps to Reproduce: 1.Open the example file attached 2.There are two logos in the heather of the file. Select both logos 3.Go to format and choose two columns for the heather 4.The heather now should show both logos sode by side in the heather 5.Save the file 6. Close it 7. Reopen it You will find the logos in the original position, one over the other and the heather with only one column Actual Results: The two columns configuration is lost after save the file in DOC7DOCX format. I tested in ODT and it seems there are no problems there Expected Results: It should not happen Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 --- Comment #68 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f0878173e1963cf8db5f60ced6d19da24e18bc41 tdf#34828 sd navigator: make unnamed shape select select shape object It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx sd/source svx/source
include/svx/svdobj.hxx |2 +-
sd/source/ui/dlg/sdtreelb.cxx | 15 ++-
sd/source/ui/view/drviewsd.cxx |2 +-
svx/source/svdraw/svdobj.cxx |9 ++---
4 files changed, 22 insertions(+), 6 deletions(-)
New commits:
commit f0878173e1963cf8db5f60ced6d19da24e18bc41
Author: Jim Raykowski
AuthorDate: Tue Dec 1 00:25:52 2020 -0900
Commit: Jim Raykowski
CommitDate: Thu Dec 3 21:38:48 2020 +0100
tdf#34828 sd navigator: make unnamed shape select select shape object
Change-Id: I4685d7db802767553018d08d23d8b33bca7efff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106958
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 2c9ce6813fba..b7af53864a77 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -373,7 +373,7 @@ public:
// An object may have a user-set Name (Get/SetName()), e.g SdrGrafObj,
SdrObjGroup
// or SdrOle2Obj.
// It may also have a Title and a Description for accessibility purposes.
-void SetName(const OUString& rStr);
+void SetName(const OUString& rStr, const bool bSetChanged = true);
OUString GetName() const;
void MakeNameUnique();
void MakeNameUnique(std::unordered_set& rNameSet);
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index bd9215fcb5b1..12ba6be2cf45 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -701,7 +701,20 @@ void SdPageObjsTLV::Select()
m_aChangeHdl.Call(*m_xTreeView);
if (m_bSelectionHandlerNavigates)
-m_aRowActivatedHdl.Call(*m_xTreeView);
+{
+SdrObject* pObject =
reinterpret_cast(m_xTreeView->get_selected_id().toInt64());
+if (pObject && pObject->GetName().isEmpty())
+{
+const bool bUndo =
pObject->getSdrModelFromSdrObject().IsUndoEnabled();
+pObject->getSdrModelFromSdrObject().EnableUndo(false);
+pObject->SetName(m_xTreeView->get_selected_text(), false);
+m_aRowActivatedHdl.Call(*m_xTreeView);
+pObject->SetName(OUString(), false);
+pObject->getSdrModelFromSdrObject().EnableUndo(bUndo);
+}
+else
+m_aRowActivatedHdl.Call(*m_xTreeView);
+}
if (!m_xNavigator)
{
diff --git a/sd/source/ui/view/drviewsd.cxx b/sd/source/ui/view/drviewsd.cxx
index 8f6e627029d4..6dc4448d32f1 100644
--- a/sd/source/ui/view/drviewsd.cxx
+++ b/sd/source/ui/view/drviewsd.cxx
@@ -137,7 +137,7 @@ void DrawViewShell::ExecNavigatorWin( SfxRequest& rReq )
SfxFrameItem aFrameItem(SID_DOCFRAME, pFrame);
SfxBoolItem aBrowseItem(SID_BROWSE, true);
pFrame->GetDispatcher()->
-ExecuteList(SID_OPENDOC, SfxCallMode::ASYNCHRON |
SfxCallMode::RECORD,
+ExecuteList(SID_OPENDOC, SfxCallMode::SYNCHRON |
SfxCallMode::RECORD,
{ , , , });
}
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 638c590a52cd..260d0b0dd2ac 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -661,7 +661,7 @@ SdrObject* SdrObject::getParentSdrObjectFromSdrObject()
const
return pParent->getSdrObjectFromSdrObjList();
}
-void SdrObject::SetName(const OUString& rStr)
+void SdrObject::SetName(const OUString& rStr, const bool bSetChanged)
{
if (!rStr.isEmpty() && !pPlusData)
{
@@ -691,8 +691,11 @@ void SdrObject::SetName(const OUString& rStr)
{
getSdrModelFromSdrObject().EndUndo();
}
-SetChanged();
-BroadcastObjectChange();
+if (bSetChanged)
+{
+SetChanged();
+BroadcastObjectChange();
+}
}
OUString SdrObject::GetName() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 --- Comment #67 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cbc43bef143f3109bdf3bf981317ae74b73cde5a tdf#34828 sd navigator: enhance automatic shape name It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 --- Comment #66 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/70fd160ea0c2a2afeee520f450f1ed4f81fa88f3 tdf#34828 sd navigator: make 'All shapes' the default It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/dlg/sdtreelb.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit cbc43bef143f3109bdf3bf981317ae74b73cde5a
Author: Jim Raykowski
AuthorDate: Tue Dec 1 00:35:03 2020 -0900
Commit: Jim Raykowski
CommitDate: Thu Dec 3 21:37:19 2020 +0100
tdf#34828 sd navigator: enhance automatic shape name
appends defined singular object name to automatic shape name
Change-Id: Ia49eef8e1448c5973c6bbf451c22de252f9939dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106957
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 68ca6bdbff69..bd9215fcb5b1 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -758,7 +758,7 @@ OUString SdPageObjsTLV::GetObjectName(
&& aRet.isEmpty()
&& pObject!=nullptr)
{
-aRet = SdResId(STR_NAVIGATOR_SHAPE_BASE_NAME);
+aRet = SdResId(STR_NAVIGATOR_SHAPE_BASE_NAME) + " (" +
pObject->TakeObjNameSingul() +")";
aRet = aRet.replaceFirst("%1", OUString::number(pObject->GetOrdNum() +
1));
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/frmview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 70fd160ea0c2a2afeee520f450f1ed4f81fa88f3 Author: Jim Raykowski AuthorDate: Tue Dec 1 00:02:25 2020 -0900 Commit: Jim Raykowski CommitDate: Thu Dec 3 21:36:33 2020 +0100 tdf#34828 sd navigator: make 'All shapes' the default Change-Id: If0b2f3054bcb94f08df2dcfdee87e7c5a7ef2a98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106955 Tested-by: Jenkins Reviewed-by: Jim Raykowski diff --git a/sd/source/ui/view/frmview.cxx b/sd/source/ui/view/frmview.cxx index e78fcbda7a6f..db7065f195df 100644 --- a/sd/source/ui/view/frmview.cxx +++ b/sd/source/ui/view/frmview.cxx @@ -227,7 +227,7 @@ FrameView::FrameView(SdDrawDocument* pDrawDoc, FrameView* pFrameView /* = NULL * bool bUseContrast = Application::GetSettings().GetStyleSettings().GetHighContrastMode(); mnDrawMode = bUseContrast ? OUTPUT_DRAWMODE_CONTRAST : OUTPUT_DRAWMODE_COLOR; } -mbIsNavigatorShowingAllShapes = false; +mbIsNavigatorShowingAllShapes = true; SetPreviousViewShellType (ViewShell::ST_NONE); SetViewShellTypeOnLoad (ViewShell::ST_IMPRESS); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source vcl/unx
include/vcl/button.hxx|4 +++
include/vcl/weld.hxx |9
vcl/inc/salvtables.hxx|2 +
vcl/source/app/salvtables.cxx |9
vcl/source/control/button.cxx | 24 +-
vcl/unx/gtk3/gtk3gtkinst.cxx | 44 ++
6 files changed, 91 insertions(+), 1 deletion(-)
New commits:
commit 9b12f2fe15403ab0a82abd11ba14dae4a70774a6
Author: Caolán McNamara
AuthorDate: Thu Dec 3 17:15:06 2020 +
Commit: Caolán McNamara
CommitDate: Thu Dec 3 21:29:46 2020 +0100
support completely styling a welded button
Change-Id: I6e45c711b406a3836dd230ceaa738c5a250ff846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107173
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index 627c68192acc..58cb4c1f81fd 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -82,6 +82,10 @@ public:
DrawButtonFlags GetButtonState() const;
DrawButtonFlags&GetButtonState();
+/// Set an image to use as the complete render view of a custom button,
+/// instead of the usual contents of a button
+voidSetCustomButtonImage( const Image& rImage );
+Image const & GetCustomButtonImage() const;
boolIsSmallSymbol() const;
voidSetSmallSymbol();
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index a4c07aeebede..98c012378060 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1296,6 +1296,15 @@ public:
// font size is in points, not pixels, e.g. see Window::[G]etPointFont
virtual void set_font(const vcl::Font& rFont) = 0;
+/* Sometimes, a widget should behave like a button (activate on click,
+ accept keyboard focus, etc), but look entirely different.
+
+ pDevice, the custom look to use, or nullptr to unset.
+
+ Typically doing this is ill advised. Consider using
+ set_accessible_name if you do. */
+virtual void set_custom_button(VirtualDevice* pDevice) = 0;
+
void connect_clicked(const Link& rLink) { m_aClickHdl =
rLink; }
};
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index 9fe7a6a5dac5..2fd7198a7b65 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -1007,6 +1007,8 @@ public:
virtual void set_font(const vcl::Font& rFont) override;
+virtual void set_custom_button(VirtualDevice* pDevice) override;
+
virtual ~SalInstanceButton() override;
};
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 0daf586ebb89..ccc3757e6718 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -2488,6 +2488,15 @@ void SalInstanceButton::set_font(const vcl::Font& rFont)
m_xButton->Invalidate();
}
+void SalInstanceButton::set_custom_button(VirtualDevice* pDevice)
+{
+if (pDevice)
+m_xButton->SetCustomButtonImage(createImage(*pDevice));
+else
+m_xButton->SetCustomButtonImage(Image());
+m_xButton->Invalidate();
+}
+
OUString SalInstanceButton::get_label() const { return m_xButton->GetText(); }
SalInstanceButton::~SalInstanceButton() {
m_xButton->SetClickHdl(Link<::Button*, void>()); }
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 66a399c15bbc..38b32d4f54af 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -83,12 +83,14 @@ public:
ImageAlign meImageAlign;
SymbolAlign meSymbolAlign;
+Image maCustomContentImage;
+
/** StatusListener. Updates the button as the slot state changes */
rtl::Reference> mpStatusListener;
};
ImplCommonButtonData::ImplCommonButtonData() : maFocusRect(), mnSeparatorX(0),
mnButtonState(DrawButtonFlags::NONE),
-mbSmallSymbol(false), maImage(), meImageAlign(ImageAlign::Top),
meSymbolAlign(SymbolAlign::LEFT)
+mbSmallSymbol(false), maImage(), meImageAlign(ImageAlign::Top),
meSymbolAlign(SymbolAlign::LEFT), maCustomContentImage()
{
}
@@ -158,6 +160,20 @@ ImageAlign Button::GetImageAlign() const
return mpButtonData->meImageAlign;
}
+void Button::SetCustomButtonImage(const Image& rImage)
+{
+if (rImage != mpButtonData->maCustomContentImage)
+{
+mpButtonData->maCustomContentImage = rImage;
+StateChanged( StateChangedType::Data );
+}
+}
+
+Image const & Button::GetCustomButtonImage() const
+{
+return mpButtonData->maCustomContentImage;
+}
+
tools::Long Button::ImplGetSeparatorX() const
{
return mpButtonData->mnSeparatorX;
@@ -1294,6 +1310,12 @@ void PushButton::FillLayoutData() const
void PushButton::Paint(vcl::RenderContext& rRenderContext, const
tools::Rectangle&)
{
+const Image& rCustomButtonImage = GetCustomButtonImage();
+if (!!rCustomButtonImage)
+{
+rRenderContext.DrawImage(Point(0, 0), rCustomButtonImage);
+return;
+}
[Libreoffice-bugs] [Bug 138627] Repeated data in Tables of File Conversion Filter Names
https://bugs.documentfoundation.org/show_bug.cgi?id=138627 balaharipree...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |balaharipree...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - vcl/inc vcl/source
vcl/inc/sallayout.hxx|2 ++
vcl/source/gdi/sallayout.cxx |5 +
vcl/source/outdev/font.cxx | 19 +--
3 files changed, 20 insertions(+), 6 deletions(-)
New commits:
commit 049b4ad189d78af54dcc93295473a58671f27c5a
Author: Caolán McNamara
AuthorDate: Thu Dec 3 15:38:21 2020 +
Commit: Caolán McNamara
CommitDate: Thu Dec 3 21:23:06 2020 +0100
cid#1468270 Wrapper object use after free
I think this is a better reflection of the original intent here before
commit 1441ab9c75a2f0ac664983db22b681a1b602f8a9
fix possible SIGSEGV
and
commit 8f54136caa786523fd224f6c98fc8e7c45cd805d
use std::unique_ptr for SalLayout
Change-Id: Ib4ab63334e644a8136b9f7da20916715850563ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107112
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index bf93c0f64028..30fd5580b4c5 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -138,6 +138,8 @@ public:
// used only by OutputDevice::ImplLayout, TODO: make friend
explicitMultiSalLayout( std::unique_ptr pBaseLayout );
voidAddFallback(std::unique_ptr pFallbackLayout,
ImplLayoutRuns const &);
+// give up ownership of the initial pBaseLayout taken by the ctor
+std::unique_ptr ReleaseBaseLayout();
boolLayoutText(ImplLayoutArgs&, const SalLayoutGlyphs*)
override;
voidAdjustLayout(ImplLayoutArgs&) override;
voidInitFont() const override;
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 7beea9a01091..eaa03d22e5f0 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -996,6 +996,11 @@ MultiSalLayout::MultiSalLayout( std::unique_ptr
pBaseLayout )
mnUnitsPerPixel = mpLayouts[ 0 ]->GetUnitsPerPixel();
}
+std::unique_ptr MultiSalLayout::ReleaseBaseLayout()
+{
+return std::move(mpLayouts[0]);
+}
+
void MultiSalLayout::SetIncomplete(bool bIncomplete)
{
mbIncomplete = bIncomplete;
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 71dc5e861fcf..d20bbe8ccd44 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -1246,9 +1246,6 @@ std::unique_ptr
OutputDevice::ImplGlyphFallbackLayout( std::unique_pt
return nullptr;
}
-// keep a pointer to the layout because we might move ownership of the
unique_ptr
-const SalLayout* pSalLayoutTmp = pSalLayout.get();
-
// prepare multi level glyph fallback
std::unique_ptr pMultiSalLayout;
ImplLayoutRuns aLayoutRuns = rLayoutArgs.maRuns;
@@ -1306,11 +1303,21 @@ std::unique_ptr
OutputDevice::ImplGlyphFallbackLayout( std::unique_pt
break;
}
-if( pMultiSalLayout && pMultiSalLayout->LayoutText( rLayoutArgs, nullptr )
)
-pSalLayout = std::move(pMultiSalLayout);
+if (pMultiSalLayout) // due to missing glyphs, multilevel layout fallback
attempted
+{
+// if it works, use that Layout
+if (pMultiSalLayout->LayoutText(rLayoutArgs, nullptr))
+pSalLayout = std::move(pMultiSalLayout);
+else
+{
+// if it doesn't, give up and restore ownership of the pSalLayout
+// back to its original state
+pSalLayout = pMultiSalLayout->ReleaseBaseLayout();
+}
+}
// restore orig font settings
-pSalLayoutTmp->InitFont();
+pSalLayout->InitFont();
rLayoutArgs.maRuns = aLayoutRuns;
return pSalLayout;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/sallayout.hxx|2 ++
vcl/source/gdi/sallayout.cxx |5 +
vcl/source/outdev/font.cxx | 19 +--
3 files changed, 20 insertions(+), 6 deletions(-)
New commits:
commit 95ae027d5e331847d6ac695d11c299f2ca0e4ca1
Author: Caolán McNamara
AuthorDate: Thu Dec 3 15:38:21 2020 +
Commit: Caolán McNamara
CommitDate: Thu Dec 3 21:22:45 2020 +0100
cid#1468270 Wrapper object use after free
I think this is a better reflection of the original intent here before
commit 1441ab9c75a2f0ac664983db22b681a1b602f8a9
fix possible SIGSEGV
and
commit 8f54136caa786523fd224f6c98fc8e7c45cd805d
use std::unique_ptr for SalLayout
Change-Id: Ib4ab63334e644a8136b9f7da20916715850563ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107171
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index bf93c0f64028..30fd5580b4c5 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -138,6 +138,8 @@ public:
// used only by OutputDevice::ImplLayout, TODO: make friend
explicitMultiSalLayout( std::unique_ptr pBaseLayout );
voidAddFallback(std::unique_ptr pFallbackLayout,
ImplLayoutRuns const &);
+// give up ownership of the initial pBaseLayout taken by the ctor
+std::unique_ptr ReleaseBaseLayout();
boolLayoutText(ImplLayoutArgs&, const SalLayoutGlyphs*)
override;
voidAdjustLayout(ImplLayoutArgs&) override;
voidInitFont() const override;
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 7beea9a01091..eaa03d22e5f0 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -996,6 +996,11 @@ MultiSalLayout::MultiSalLayout( std::unique_ptr
pBaseLayout )
mnUnitsPerPixel = mpLayouts[ 0 ]->GetUnitsPerPixel();
}
+std::unique_ptr MultiSalLayout::ReleaseBaseLayout()
+{
+return std::move(mpLayouts[0]);
+}
+
void MultiSalLayout::SetIncomplete(bool bIncomplete)
{
mbIncomplete = bIncomplete;
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 6963fd77c3e1..2cd38a58ba11 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -1246,9 +1246,6 @@ std::unique_ptr
OutputDevice::ImplGlyphFallbackLayout( std::unique_pt
return nullptr;
}
-// keep a pointer to the layout because we might move ownership of the
unique_ptr
-const SalLayout* pSalLayoutTmp = pSalLayout.get();
-
// prepare multi level glyph fallback
std::unique_ptr pMultiSalLayout;
ImplLayoutRuns aLayoutRuns = rLayoutArgs.maRuns;
@@ -1306,11 +1303,21 @@ std::unique_ptr
OutputDevice::ImplGlyphFallbackLayout( std::unique_pt
break;
}
-if( pMultiSalLayout && pMultiSalLayout->LayoutText( rLayoutArgs, nullptr )
)
-pSalLayout = std::move(pMultiSalLayout);
+if (pMultiSalLayout) // due to missing glyphs, multilevel layout fallback
attempted
+{
+// if it works, use that Layout
+if (pMultiSalLayout->LayoutText(rLayoutArgs, nullptr))
+pSalLayout = std::move(pMultiSalLayout);
+else
+{
+// if it doesn't, give up and restore ownership of the pSalLayout
+// back to its original state
+pSalLayout = pMultiSalLayout->ReleaseBaseLayout();
+}
+}
// restore orig font settings
-pSalLayoutTmp->InitFont();
+pSalLayout->InitFont();
rLayoutArgs.maRuns = aLayoutRuns;
return pSalLayout;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 12 commits - download.lst external/pdfium RepositoryExternal.mk solenv/flatpak-manifest.in vcl/qa
RepositoryExternal.mk |1
download.lst|4
external/pdfium/Library_pdfium.mk | 173 -
external/pdfium/UnpackedTarball_pdfium.mk | 19
external/pdfium/build.patch.1 | 119
external/pdfium/c++20-comparison.patch | 13
external/pdfium/configs/build_config.h |6
external/pdfium/msvc2015.patch.1| 202 +
external/pdfium/pdfium4137-numerics.patch.3 | 3364
external/pdfium/ubsan.patch | 26
external/pdfium/visibility.patch.1 | 30
external/pdfium/windows7.patch.1| 34
solenv/flatpak-manifest.in |6
vcl/qa/cppunit/pdfexport/pdfexport.cxx |6
14 files changed, 3775 insertions(+), 228 deletions(-)
New commits:
commit fba5806a4c563496fca5dae5e4f347175a8c2403
Author: Michael Stahl
AuthorDate: Thu Dec 3 17:54:08 2020 +0100
Commit: Michael Stahl
CommitDate: Thu Dec 3 21:19:11 2020 +0100
pdfium: MSVC 2015 build
Change-Id: I7e8c4caaeffdaa2a44579da0c26d6bd1320aab1e
diff --git a/external/pdfium/UnpackedTarball_pdfium.mk
b/external/pdfium/UnpackedTarball_pdfium.mk
index f4643376cee0..8b12e494f94b 100644
--- a/external/pdfium/UnpackedTarball_pdfium.mk
+++ b/external/pdfium/UnpackedTarball_pdfium.mk
@@ -14,6 +14,9 @@ pdfium_patches += build.patch.1
# Avoids Windows 8 build dependency.
pdfium_patches += windows7.patch.1
pdfium_patches += c++20-comparison.patch
+ifeq (MSC,$(COM))
+pdfium_patches += pdfium4137-numerics.patch.3 msvc2015.patch.1
+endif
$(eval $(call gb_UnpackedTarball_UnpackedTarball,pdfium))
diff --git a/external/pdfium/msvc2015.patch.1 b/external/pdfium/msvc2015.patch.1
new file mode 100644
index ..36cb5332c7b0
--- /dev/null
+++ b/external/pdfium/msvc2015.patch.1
@@ -0,0 +1,202 @@
+Fix MSVC 2015 build
+
+--- pdfium/third_party/base/optional.h.orig2020-10-26 19:26:04.0
+0100
pdfium/third_party/base/optional.h 2020-12-03 16:00:54.879883100 +0100
+@@ -36,7 +36,7 @@
+ struct OptionalStorageBase {
+ // Provide non-defaulted default ctor to make sure it's not deleted by
+ // non-trivial T::T() in the union.
+- constexpr OptionalStorageBase() : dummy_() {}
++ OptionalStorageBase() : dummy_() {}
+
+ template
+ constexpr explicit OptionalStorageBase(in_place_t, Args&&... args)
+@@ -88,7 +88,7 @@
+ struct OptionalStorageBase {
+ // Provide non-defaulted default ctor to make sure it's not deleted by
+ // non-trivial T::T() in the union.
+- constexpr OptionalStorageBase() : dummy_() {}
++ OptionalStorageBase() : dummy_() {}
+
+ template
+ constexpr explicit OptionalStorageBase(in_place_t, Args&&... args)
+@@ -607,32 +607,32 @@
+ return *this;
+ }
+
+- constexpr const T* operator->() const {
++ const T* operator->() const {
+ CHECK(storage_.is_populated_);
+ return _.value_;
+ }
+
+- constexpr T* operator->() {
++ T* operator->() {
+ CHECK(storage_.is_populated_);
+ return _.value_;
+ }
+
+- constexpr const T& operator*() const & {
++ const T& operator*() const & {
+ CHECK(storage_.is_populated_);
+ return storage_.value_;
+ }
+
+- constexpr T& operator*() & {
++ T& operator*() & {
+ CHECK(storage_.is_populated_);
+ return storage_.value_;
+ }
+
+- constexpr const T&& operator*() const && {
++ const T&& operator*() const && {
+ CHECK(storage_.is_populated_);
+ return std::move(storage_.value_);
+ }
+
+- constexpr T&& operator*() && {
++ T&& operator*() && {
+ CHECK(storage_.is_populated_);
+ return std::move(storage_.value_);
+ }
+@@ -641,22 +641,22 @@
+
+ constexpr bool has_value() const { return storage_.is_populated_; }
+
+- constexpr T& value() & {
++ T& value() & {
+ CHECK(storage_.is_populated_);
+ return storage_.value_;
+ }
+
+- constexpr const T& value() const & {
++ const T& value() const & {
+ CHECK(storage_.is_populated_);
+ return storage_.value_;
+ }
+
+- constexpr T&& value() && {
++ T&& value() && {
+ CHECK(storage_.is_populated_);
+ return std::move(storage_.value_);
+ }
+
+- constexpr const T&& value() const && {
++ const T&& value() const && {
+ CHECK(storage_.is_populated_);
+ return std::move(storage_.value_);
+ }
+--- pdfium/third_party/base/span.h.orig2020-10-26 19:26:04.0
+0100
pdfium/third_party/base/span.h 2020-12-03 16:28:15.642138100 +0100
+@@ -193,7 +193,7 @@
+
+ // TODO(dcheng): Implement construction from a |begin| and |end| pointer.
+ template
+- constexpr span(T ()[N]) noexcept : span(array, N) {}
++ span(T ()[N]) noexcept : span(array, N) {}
+ // TODO(dcheng): Implement construction from std::array.
+ // Conversion from a container that provides |T* data()| and |integral_type
+ // size()|.
+--- pdfium/core/fpdfapi/page/cpdf_colorspace.cpp.orig 2020-12-03
16:54:15.514659400 +0100
[Libreoffice-bugs] [Bug 138633] FILEOPEN PPTX: content of formula not shown (sort-of regression from 5.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=138633 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm in Version: 7.2.0.0.alpha0+ Build ID: 4e63ec27b69fa01ff610c894c9fbf05c377a6179 CPU threads: 4; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138641] Page style should be next page style in the insert page dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=138641 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Severity|normal |enhancement Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Agree -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 138641] Page style should be next page style in the insert page dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=138641 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Severity|normal |enhancement Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Agree -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137663] TOC is wrong when using "Tools | Chapter Numbering"
https://bugs.documentfoundation.org/show_bug.cgi?id=137663 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- You didn't get chapters 2-4 in TOC because you have no any symbols in these headings! As workaround you can enter one space after chapter numbering in these empty headings and then you'll update TOC and it will look fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138472] Calc enhancement: ignore rows when importing CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=138472 --- Comment #10 from j22...@gmail.com --- In the example file above, I would define the character "#" and thus all the rows starting with "#" would be ignored, and the file would contain only the data (eg for plotting, analysis, etc.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138268] Writer: Tab Order is not exported correctly to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=138268 --- Comment #5 from Mike Sapsard --- Try tabbing through the odf and then through the pdf/fdf forms. The cursor will take a different route. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138472] Calc enhancement: ignore rows when importing CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=138472 --- Comment #9 from j22...@gmail.com --- May I mention again that the original point of this is to avoid loading rows with no data. This happens when the beginning (a given amount of rows) have information about how data was stored, collected, calculated, etc. but it is mostly metadata. Here its an example of such file: https://www.ncei.noaa.gov/pub/data/paleo/paleolimnology/northamerica/canada/ellesmere/sawtooth2020.txt So the original idea was to define a character or string which would be encountered at the *beginning* of a row, and thus avoid loading that row. Additionally, if that string is "" (ie empty string), it would be a way to avoid loading empty files. I am not sure (but also not against) about searching that string in anywhere in the row. I can't imagine the usefulness of that, but if it is the same work then why not. Just wanted to reinforce the idea of the original post. Thanks for this wonderful software!! PD. CVS-related support will be increasingly important, as it is the preferred format to work with Python, R, and many others. And Python (and many others) already have libraries to load and save as XLSX, so LibreOffice should not stay behind! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
