[Libreoffice-bugs] [Bug 74702] Remove enum OutDevType from OutputDevice
https://bugs.documentfoundation.org/show_bug.cgi?id=74702 --- Comment #64 from Commit Notification --- Chris Sherlock committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/159d9c30c474c6525643d832a38e640cd442ac7c tdf#74702 - vcl: introduce OutputDevice::CanEnableNativeWidget() It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74702] Remove enum OutDevType from OutputDevice
https://bugs.documentfoundation.org/show_bug.cgi?id=74702 Commit Notification changed: What|Removed |Added Whiteboard|target:4.3.0 target:6.3.0 |target:4.3.0 target:6.3.0 |target:6.4.0 target:6.5.0 |target:6.4.0 target:6.5.0 |target:7.0.0 target:7.1.0 |target:7.0.0 target:7.1.0 ||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/outdev.hxx |4 +++
include/vcl/virdev.hxx |2 +
include/vcl/window.hxx |2 +
vcl/source/gdi/virdev.cxx| 20
vcl/source/outdev/nativecontrols.cxx | 43 +++
5 files changed, 27 insertions(+), 44 deletions(-)
New commits:
commit 159d9c30c474c6525643d832a38e640cd442ac7c
Author: Chris Sherlock
AuthorDate: Tue Dec 22 09:54:25 2020 +1100
Commit: Mike Kaganski
CommitDate: Sat Jan 2 08:48:13 2021 +0100
tdf#74702 - vcl: introduce OutputDevice::CanEnableNativeWidget()
Change-Id: Idb43f57078702f64e9a80a2100b12fa0e6c3e155
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108130
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 052b0afb3086..c0e0c8ec12f8 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1963,6 +1963,10 @@ public:
public:
+/** Determine if native widgets can be enabled
+ */
+virtual boolCanEnableNativeWidget() const { return false; }
+
/** Query the platform layer for control support
*/
boolIsNativeControlSupported( ControlType nType,
ControlPart nPart ) const;
diff --git a/include/vcl/virdev.hxx b/include/vcl/virdev.hxx
index b13a2a0d9ef8..55a4a7f5ddcb 100644
--- a/include/vcl/virdev.hxx
+++ b/include/vcl/virdev.hxx
@@ -156,6 +156,8 @@ public:
virtual ~VirtualDevice() override;
virtual voiddispose() override;
+boolCanEnableNativeWidget() const override;
+
virtual voidEnableRTL( bool bEnable = true ) override;
boolSetOutputSizePixel( const Size& rNewSize, bool bErase
= true );
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 99a1043bb3d3..650503484bc9 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -779,6 +779,8 @@ public:
::OutputDevice const* GetOutDev() const;
::OutputDevice* GetOutDev();
+boolCanEnableNativeWidget() const override
{ return IsNativeWidgetEnabled(); }
+
Color GetBackgroundColor() const override;
size_t GetSyncCount() const override { return
0x00ff; }
diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index 3d63cf90cd41..7a2102b0ad0c 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -17,18 +17,28 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include
+#include
+
+#include
+#include
+
+#include
+#include
#include
#include
#include
-#include
-#include
#include
-#include
-#include
-#include
using namespace ::com::sun::star::uno;
+bool VirtualDevice::CanEnableNativeWidget() const
+{
+const vcl::ExtOutDevData* pOutDevData(GetExtOutDevData());
+const vcl::PDFExtOutDevData* pPDFData(dynamic_cast(pOutDevData));
+return pPDFData == nullptr;
+}
+
bool VirtualDevice::AcquireGraphics() const
{
DBG_TESTSOLARMUTEX();
diff --git a/vcl/source/outdev/nativecontrols.cxx
b/vcl/source/outdev/nativecontrols.cxx
index 85b0b58c45d1..4df8328dc921 100644
--- a/vcl/source/outdev/nativecontrols.cxx
+++ b/vcl/source/outdev/nativecontrols.cxx
@@ -29,41 +29,6 @@
#include
-static bool EnableNativeWidget( const OutputDevice& i_rDevice )
-{
-const OutDevType eType( i_rDevice.GetOutDevType() );
-switch ( eType )
-{
-
-case OUTDEV_WINDOW:
-{
-const vcl::Window* pWindow = dynamic_cast< const vcl::Window* >(
_rDevice );
-if (pWindow)
-{
-return pWindow->IsNativeWidgetEnabled();
-}
-else
-{
-SAL_WARN ("vcl.gdi", "Could not cast i_rDevice to Window");
-assert (pWindow);
-return false;
-}
-}
-
-case OUTDEV_PDF:
-[[fallthrough]];
-case OUTDEV_VIRDEV:
-{
-const vcl::ExtOutDevData* pOutDevData( i_rDevice.GetExtOutDevData() );
-const vcl::PDFExtOutDevData* pPDFData( dynamic_cast< const
vcl::PDFExtOutDevData* >( pOutDevData ) );
-return pPDFData == nullptr;
-}
-
-default:
-return false;
-}
-}
-
ImplControlValue::~ImplControlValue()
{
}
@@ -167,7 +132,7 @@ PushButtonValue* PushButtonValue::clone() const
bool OutputDevice::IsNativeControlSupported( ControlType nType, ControlPart
nPart ) const
{
-if( !EnableNativeWidget( *this ) )
+if( !CanEnableNativeWidget() )
return false;
if ( !mpGraphics && !AcquireGraphics() )
@@ -182,7 +147,7 @@ bool OutputDevice::HitTestNativeScrollbar(
const Point& aPos,
bool& rIsInside ) const
{
-if( !EnableNativeWidget( *this ) )
+if(
[Libreoffice-bugs] [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114159 Telesto changed: What|Removed |Added Depends on||139355 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139355 [Bug 139355] Libre Office not using all CPU cores -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114159 Bug 114159 depends on bug 139355, which changed state. Bug 139355 Summary: Libre Office not using all CPU cores https://bugs.documentfoundation.org/show_bug.cgi?id=139355 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139355] Libre Office not using all CPU cores
https://bugs.documentfoundation.org/show_bug.cgi?id=139355 Telesto changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|DUPLICATE |--- Blocks||114159 --- Comment #2 from Telesto --- bug 65046 is pretty old.. there is multi thread for calc.. so prefer small investigation first Is it possible to recreate a dummy testing dataset with the same formula. It sounds to me like the formula is causing a fall back to single thread Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114159 [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/dialogs/tp_PolarOptions.cxx |8
chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx |5
+++--
chart2/source/view/main/ChartItemPool.cxx |2
+-
3 files changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 152b651cd023b7f411affce49ff160c99826abd5
Author: Noel Grandin
AuthorDate: Thu Dec 31 19:04:37 2020 +0200
Commit: Noel Grandin
CommitDate: Sat Jan 2 08:36:33 2021 +0100
use SdrAngleItem for SCHATTR_STARTING_ANGLE
Change-Id: Ibe6b882806df1b30e38f4461284a7514f4407b3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108554
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/dialogs/tp_PolarOptions.cxx
b/chart2/source/controller/dialogs/tp_PolarOptions.cxx
index f96d9c614450..865736b3b66d 100644
--- a/chart2/source/controller/dialogs/tp_PolarOptions.cxx
+++ b/chart2/source/controller/dialogs/tp_PolarOptions.cxx
@@ -22,6 +22,7 @@
#include
#include
+#include
#include
namespace chart
@@ -55,8 +56,7 @@ bool PolarOptionsTabPage::FillItemSet( SfxItemSet* rOutAttrs )
{
if (m_xAngleDialWin->get_visible())
{
-rOutAttrs->Put(SfxInt32Item(SCHATTR_STARTING_ANGLE,
-static_cast< sal_Int32 >(m_xAngleDial->GetRotation()/100)));
+rOutAttrs->Put(SdrAngleItem(SCHATTR_STARTING_ANGLE,
m_xAngleDial->GetRotation()));
}
if( m_xCB_Clockwise->get_visible() )
@@ -74,8 +74,8 @@ void PolarOptionsTabPage::Reset(const SfxItemSet* rInAttrs)
if (rInAttrs->GetItemState(SCHATTR_STARTING_ANGLE, true, ) ==
SfxItemState::SET)
{
-tools::Long nTmp = static_cast(static_cast(pPoolItem)->GetValue());
-m_xAngleDial->SetRotation( nTmp*100 );
+sal_Int32 nTmp = static_cast(pPoolItem)->GetValue();
+m_xAngleDial->SetRotation( nTmp );
}
else
{
diff --git
a/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
b/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
index d50f39abc3bb..3c8fbcca9990 100644
--- a/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#include
using namespace ::com::sun::star;
@@ -276,7 +277,7 @@ bool SeriesOptionsItemConverter::ApplySpecialItem(
sal_uInt16 nWhichId, const Sf
{
if( m_bSupportingStartingAngle )
{
-m_nStartingAngle = static_cast< const SfxInt32Item & >(
rItemSet.Get( nWhichId )).GetValue();
+m_nStartingAngle = static_cast< const SdrAngleItem & >(
rItemSet.Get( nWhichId )).GetValue() / 100;
uno::Reference< beans::XPropertySet > xDiagramProperties(
ChartModelHelper::findDiagram(m_xChartModel), uno::UNO_QUERY );
if( xDiagramProperties.is() )
{
@@ -398,7 +399,7 @@ void SeriesOptionsItemConverter::FillSpecialItem(
case SCHATTR_STARTING_ANGLE:
{
if( m_bSupportingStartingAngle )
-rOutItemSet.Put( SfxInt32Item(nWhichId,m_nStartingAngle));
+rOutItemSet.Put( SdrAngleItem(nWhichId,m_nStartingAngle*100));
break;
}
case SCHATTR_CLOCKWISE:
diff --git a/chart2/source/view/main/ChartItemPool.cxx
b/chart2/source/view/main/ChartItemPool.cxx
index fbe61098290e..4df7e269a56d 100644
--- a/chart2/source/view/main/ChartItemPool.cxx
+++ b/chart2/source/view/main/ChartItemPool.cxx
@@ -142,7 +142,7 @@ ChartItemPool::ChartItemPool():
rPoolDefaults[SCHATTR_SPLINE_ORDER - SCHATTR_START] = new
SfxInt32Item( SCHATTR_SPLINE_ORDER, 3 );
rPoolDefaults[SCHATTR_SPLINE_RESOLUTION- SCHATTR_START] = new
SfxInt32Item( SCHATTR_SPLINE_RESOLUTION, 20 );
rPoolDefaults[SCHATTR_GROUP_BARS_PER_AXIS - SCHATTR_START] = new
SfxBoolItem(SCHATTR_GROUP_BARS_PER_AXIS, false);
-rPoolDefaults[SCHATTR_STARTING_ANGLE - SCHATTR_START] = new
SfxInt32Item( SCHATTR_STARTING_ANGLE, 90 );
+rPoolDefaults[SCHATTR_STARTING_ANGLE - SCHATTR_START] = new
SdrAngleItem( SCHATTR_STARTING_ANGLE, 9000 );
rPoolDefaults[SCHATTR_CLOCKWISE- SCHATTR_START] = new
SfxBoolItem( SCHATTR_CLOCKWISE, false );
rPoolDefaults[SCHATTR_MISSING_VALUE_TREATMENT- SCHATTR_START] = new
SfxInt32Item(SCHATTR_MISSING_VALUE_TREATMENT, 0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/docfunc.cxx | 71 +-
sc/source/ui/view/viewfunc.cxx|1
2 files changed, 25 insertions(+), 47 deletions(-)
New commits:
commit 05284641e381ec2bb3b72a39b5c7334127f6c7ba
Author: Anshu
AuthorDate: Wed Dec 2 08:51:15 2020 +0530
Commit: Mike Kaganski
CommitDate: Sat Jan 2 07:28:05 2021 +0100
tdf#133257 : Protection icon in front of sheet name
Change-Id: Ifdbe0fad1f8a1d7dd6ac1dfd35c529f9e0c9fd80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107041
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/docshell/docfunc.cxx
b/sc/source/ui/docshell/docfunc.cxx
index e05513039d9e..18171bd5c44b 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -99,6 +99,7 @@
#include
#include
#include
+#include
using namespace com::sun::star;
using ::std::vector;
@@ -3935,22 +3936,29 @@ void ScDocFunc::ProtectSheet( SCTAB nTab, const
ScTableProtection& rProtect )
{
ScDocument& rDoc = rDocShell.GetDocument();
+std::unique_ptr p;
+if (!rProtect.isProtected() && rDoc.IsUndoEnabled())
+{
+// In case of unprotecting, use a copy of passed ScTableProtection
object for undo
+p = std::make_unique(rProtect);
+}
rDoc.SetTabProtection(nTab, );
if (rDoc.IsUndoEnabled())
{
-ScTableProtection* pProtect = rDoc.GetTabProtection(nTab);
-OSL_ENSURE(pProtect, "ScDocFunc::Unprotect: ScTableProtection pointer
is NULL!");
-if (pProtect)
+if (!p)
{
-::std::unique_ptr p(new
ScTableProtection(*pProtect));
-p->setProtected(true); // just in case ...
-rDocShell.GetUndoManager()->AddUndoAction(
-std::make_unique(, nTab,
std::move(p)) );
-
-// ownership of unique_ptr now transferred to ScUndoTabProtect.
+// For protection case, use a copy of resulting ScTableProtection
for undo
+ScTableProtection* pProtect = rDoc.GetTabProtection(nTab);
+p = std::make_unique(*pProtect);
}
+rDocShell.GetUndoManager()->AddUndoAction(
+std::make_unique(, nTab,
std::move(p)));
+// ownership of unique_ptr now transferred to ScUndoTabProtect.
}
-
+for (SfxViewFrame* fr = SfxViewFrame::GetFirst(); fr;
+ fr = SfxViewFrame::GetNext(*fr, ))
+if (ScTabViewShell* pTabViewShell =
dynamic_cast(fr->GetViewShell()))
+pTabViewShell->SetTabProtectionSymbol(nTab,
rProtect.isProtected());
rDocShell.PostPaintGridAll();
ScDocShellModificator aModificator(rDocShell);
aModificator.SetDocumentModified();
@@ -3979,6 +3987,9 @@ bool ScDocFunc::Protect( SCTAB nTab, const OUString&
rPassword )
// ownership of unique_ptr is transferred to ScUndoDocProtect.
}
}
+rDocShell.PostPaintGridAll();
+ScDocShellModificator aModificator(rDocShell);
+aModificator.SetDocumentModified();
}
else
{
@@ -3988,26 +3999,8 @@ bool ScDocFunc::Protect( SCTAB nTab, const OUString&
rPassword )
::std::unique_ptr pNewProtection(pOldProtection ?
new ScTableProtection(*pOldProtection) : new ScTableProtection());
pNewProtection->setProtected(true);
pNewProtection->setPassword(rPassword);
-rDoc.SetTabProtection(nTab, pNewProtection.get());
-if (rDoc.IsUndoEnabled())
-{
-ScTableProtection* pProtect = rDoc.GetTabProtection(nTab);
-OSL_ENSURE(pProtect, "ScDocFunc::Unprotect: ScTableProtection
pointer is NULL!");
-if (pProtect)
-{
-::std::unique_ptr p(new
ScTableProtection(*pProtect));
-p->setProtected(true); // just in case ...
-rDocShell.GetUndoManager()->AddUndoAction(
-std::make_unique(, nTab,
std::move(p)) );
-// ownership of unique_ptr now transferred to ScUndoTabProtect.
-}
-}
+ProtectSheet(nTab, *pNewProtection);
}
-
-rDocShell.PostPaintGridAll();
-ScDocShellModificator aModificator( rDocShell );
-aModificator.SetDocumentModified();
-
return true;
}
@@ -4056,9 +4049,6 @@ bool ScDocFunc::Unprotect( SCTAB nTab, const OUString&
rPassword, bool bApi )
if (!pTabProtect || !pTabProtect->isProtected())
// already unprotected (should not happen)!
return true;
-
-// save the protection state before unprotect (for undo).
-::std::unique_ptr pProtectCopy(new
ScTableProtection(*pTabProtect));
if (!pTabProtect->verifyPassword(rPassword))
{
if (!bApi)
@@ -4071,22 +4061,11 @@ bool ScDocFunc::Unprotect( SCTAB nTab, const OUString&
rPassword, bool bApi )
return false;
}
-::std::unique_ptr pNewProtection(new
ScTableProtection(*pTabProtect));
-
[Libreoffice-commits] core.git: helpcompiler/source
helpcompiler/source/HelpIndexer.cxx | 63 +---
1 file changed, 58 insertions(+), 5 deletions(-)
New commits:
commit 83b2ac77332d484ef2c25e58e71e04cb73031b02
Author: Mike Kaganski
AuthorDate: Tue Dec 29 11:46:12 2020 +0300
Commit: Mike Kaganski
CommitDate: Sat Jan 2 07:25:45 2021 +0100
Use GetShortPathNameW workaround on Windows for help indexer
Lucene does not accept Unicode paths; it uses thread encoding. On
Windows, that makes it fail for any path that contains characters
not representable in ACP. Using short path name tries to workaround
that when first attempt has failed.
Since Windows 10 build 17134, the UCRT supports using a UTF-8 code
page: see
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setlocale-wsetlocale.
This has benefit of using Unicode, but I hesitate using it, since I
am not sure if setting the locale globally to UTF8 is a good idea
(what side effects may it have on other external libraries or our
use of CRT functions, when thread encoding differs from C locale?),
and if only setting it at object creation, it would crash later,
when attempting to access the stored Unicode path with restored old
locale.
Change-Id: I6a3a5a84ba54d8046ec011989289c9c7d5fa5c92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108484
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/helpcompiler/source/HelpIndexer.cxx
b/helpcompiler/source/HelpIndexer.cxx
index b8889a619ee9..ad8bd9f4e6df 100644
--- a/helpcompiler/source/HelpIndexer.cxx
+++ b/helpcompiler/source/HelpIndexer.cxx
@@ -20,6 +20,12 @@
#include
#include
+#if defined _WIN32
+#include
+#include
+#include
+#endif
+
using namespace lucene::document;
HelpIndexer::HelpIndexer(OUString const , OUString const ,
@@ -31,6 +37,38 @@ HelpIndexer::HelpIndexer(OUString const , OUString
const ,
d_contentDir = OUString::Concat(srcDir) + "/content";
}
+#if defined _WIN32
+namespace
+{
+template
+auto TryWithUnicodePathWorkaround(const OUString& ustrPath, const Constructor&
constructor)
+{
+const rtl_TextEncoding eThreadEncoding = osl_getThreadTextEncoding();
+OString sPath = OUStringToOString(ustrPath, eThreadEncoding);
+try
+{
+// First try path in thread encoding (ACP in case of Windows).
+return constructor(sPath);
+}
+catch (const CLuceneError&)
+{
+// Maybe the path contains characters not representable in ACP.
There's no API in lucene
+// that takes Unicode strings (they take 8-bit strings, and pass them
to CRT library
+// functions without conversion).
+
+// For a workaround, try short name, which should only contain ASCII
characters. Would
+// not help (i.e., would return original long name) if short (8.3)
file name creation is
+// disabled in OS or volume settings.
+wchar_t buf[32767];
+if (GetShortPathNameW(o3tl::toW(ustrPath.getStr()), buf,
std::size(buf)) == 0)
+throw;
+sPath = OUStringToOString(o3tl::toU(buf), eThreadEncoding);
+return constructor(sPath);
+}
+}
+}
+#endif
+
bool HelpIndexer::indexDocuments()
{
if (!scanForFiles())
@@ -51,25 +89,34 @@ bool HelpIndexer::indexDocuments()
OUString ustrSystemPath;
osl::File::getSystemPathFromFileURL(d_indexDir, ustrSystemPath);
+#if defined _WIN32
+// Make sure the path exists, or GetShortPathNameW (if attempted) will
fail.
+osl::Directory::createPath(d_indexDir);
+auto writer = TryWithUnicodePathWorkaround(ustrSystemPath,
[](const OString& s) {
+return std::make_unique(s.getStr(),
analyzer.get(), true);
+});
+#else
OString indexDirStr = OUStringToOString(ustrSystemPath,
osl_getThreadTextEncoding());
-lucene::index::IndexWriter writer(indexDirStr.getStr(),
analyzer.get(), true);
+auto writer =
std::make_unique(indexDirStr.getStr(),
+
analyzer.get(), true);
+#endif
+
//Double limit of tokens allowed, otherwise we'll get a too-many-tokens
//exception for ja help. Could alternative ignore the exception and get
//truncated results as per java-Lucene apparently
-
writer.setMaxFieldLength(lucene::index::IndexWriter::DEFAULT_MAX_FIELD_LENGTH*2);
+
writer->setMaxFieldLength(lucene::index::IndexWriter::DEFAULT_MAX_FIELD_LENGTH*2);
// Index the identified help files
Document doc;
for (auto const& elem : d_files)
{
helpDocument(elem, );
-writer.addDocument();
+writer->addDocument();
doc.clear();
}
-writer.optimize();
// Optimize the index
-writer.optimize();
+writer->optimize();
}
catch (CLuceneError )
{
@@ -137,8 +184,14 @@
[Libreoffice-commits] core.git: jvmfwk/source
jvmfwk/source/fwkbase.cxx | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
New commits:
commit 9862820e04ca259b3e15d1aac858cd46ca936a27
Author: Mike Kaganski
AuthorDate: Mon Dec 28 19:27:38 2020 +0300
Commit: Mike Kaganski
CommitDate: Sat Jan 2 07:21:28 2021 +0100
Use Unicode paths on Windows for jvmfwk
Change-Id: I6f2e29d2e7908a40175dc2852e955f0a1bc501e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108481
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/jvmfwk/source/fwkbase.cxx b/jvmfwk/source/fwkbase.cxx
index 501595c6e857..4c4b50725f2c 100644
--- a/jvmfwk/source/fwkbase.cxx
+++ b/jvmfwk/source/fwkbase.cxx
@@ -45,6 +45,13 @@ static bool g_bJavaSet = false;
namespace {
+#if defined _WIN32
+// The paths are used in libxml. On Windows, it takes UTF-8 paths.
+constexpr rtl_TextEncoding PathEncoding() { return RTL_TEXTENCODING_UTF8; }
+#else
+rtl_TextEncoding PathEncoding() { return osl_getThreadTextEncoding(); }
+#endif
+
OString getVendorSettingsPath(OUString const & sURL)
{
if (sURL.isEmpty())
@@ -55,8 +62,7 @@ OString getVendorSettingsPath(OUString const & sURL)
throw FrameworkException(
JFW_E_ERROR,
"[Java framework] Error in function getVendorSettingsPath
(fwkbase.cxx) ");
-OString osSystemPathSettings =
-OUStringToOString(sSystemPathSettings,osl_getThreadTextEncoding());
+OString osSystemPathSettings = OUStringToOString(sSystemPathSettings,
PathEncoding());
return osSystemPathSettings;
}
@@ -239,7 +245,7 @@ OString BootParams::getClasspath()
OUString sCP;
if (Bootstrap::get()->getFrom( UNO_JAVA_JFW_CLASSPATH, sCP ))
{
-sClassPath = OUStringToOString(sCP, osl_getThreadTextEncoding());
+sClassPath = OUStringToOString(sCP, PathEncoding());
SAL_INFO(
"jfw.level2",
"Using bootstrap parameter " UNO_JAVA_JFW_CLASSPATH " = "
@@ -456,8 +462,7 @@ OString makeClassPathOption(OUString const & sUserClassPath)
sBufCP.append(sAppCP);
}
-sPaths = OUStringToOString(
-sBufCP.makeStringAndClear(), osl_getThreadTextEncoding());
+sPaths = OUStringToOString(sBufCP.makeStringAndClear(), PathEncoding());
OString sOptionClassPath = "-Djava.class.path=" + sPaths;
return sOptionClassPath;
@@ -483,7 +488,7 @@ OString getSettingsPath( const OUString & sURL)
throw FrameworkException(
JFW_E_ERROR,
"[Java framework] Error in function ::getSettingsPath
(fwkbase.cxx).");
-return OUStringToOString(sPath,osl_getThreadTextEncoding());
+return OUStringToOString(sPath, PathEncoding());
}
OString getVendorSettingsPath()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116022] Bullets not aligned with indents triangles in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=116022 --- Comment #5 from m...@disroot.org --- The issue still exists in: Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Debian package version: 1:7.0.4_rc2-1~bpo10+2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139366] New: LibreOffice crashes on starting Basic IDE
https://bugs.documentfoundation.org/show_bug.cgi?id=139366 Bug ID: 139366 Summary: LibreOffice crashes on starting Basic IDE Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: himajin100...@gmail.com Description: see steps to reproduce Steps to Reproduce: 1.run LibreOffice 2.[Tools]->[Macros]->[Organize Macros]->[Basic] 3. Select MyMacros/Standard/Module1 or whatever module. 4. Click [Edit] Actual Results: Soon after the IDE appears, LibreOffice crashes Expected Results: no crash Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: c38f638360579036f0d323ea68c5c1db13c7d450 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139250] A document containing picture with a caption cannot be openned by MS Word.
https://bugs.documentfoundation.org/show_bug.cgi?id=139250 Frank Rowe changed: What|Removed |Added CC||asiangi...@outlook.com --- Comment #5 from Frank Rowe --- Created attachment 168629 --> https://bugs.documentfoundation.org/attachment.cgi?id=168629=edit A docx with captioned picture, it was saved from Writer 7.1 RC1. The document was produced from a PC running Windows 7 64-bit, with LibreOffice Writer 7.1 RC1 installed. The document used a chinese template. In the document, a picture was inserted, and the picture was added a caption. With the PC, the document was saved as docx, and the docx couldn't be openned with MS Word 2007. But after be uploaded to MS Office Online，the document was openned successfully. Maybe the problem just happened in MS Word 2007. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97341] Width for document comments cannot be changed manually
https://bugs.documentfoundation.org/show_bug.cgi?id=97341 --- Comment #18 from mestatusvideo --- free fire the goal that you require not spend your time looking like composing crosswise over the https://mestatusvideo.com/free-fire-video-status-download/ Free Fire Video Status download -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Bug 120949 depends on bug 139353, which changed state. Bug 139353 Summary: [UI] elementary: Change Comment/Note/Annotation Appearance to Be Rounded Rectangle Bubble https://bugs.documentfoundation.org/show_bug.cgi?id=139353 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Bug 120949 depends on bug 139174, which changed state. Bug 139174 Summary: [UI] elementary: icons for (work)sheet does not represent actual sheet https://bugs.documentfoundation.org/show_bug.cgi?id=139174 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Bug 120949 depends on bug 139219, which changed state. Bug 139219 Summary: [UI] elementary: Proposal to remove green header row part in table icon https://bugs.documentfoundation.org/show_bug.cgi?id=139219 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
icon-themes/elementary/cmd/32/commentchangetracking.png |binary icon-themes/elementary/cmd/32/deleteallannotation.png |binary icon-themes/elementary/cmd/32/deleteannotation.png |binary icon-themes/elementary/cmd/32/deleteauthor.png |binary icon-themes/elementary/cmd/32/editannotation.png|binary icon-themes/elementary/cmd/32/formatallnotes.png|binary icon-themes/elementary/cmd/32/hideallnotes.png |binary icon-themes/elementary/cmd/32/hidenote.png |binary icon-themes/elementary/cmd/32/insertannotation.png |binary icon-themes/elementary/cmd/32/nextannotation.png|binary icon-themes/elementary/cmd/32/previousannotation.png|binary icon-themes/elementary/cmd/32/replycomment.png |binary icon-themes/elementary/cmd/32/showallnotes.png |binary icon-themes/elementary/cmd/32/shownote.png |binary icon-themes/elementary/cmd/lc_commentchangetracking.png |binary icon-themes/elementary/cmd/lc_deleteallannotation.png |binary icon-themes/elementary/cmd/lc_deleteannotation.png |binary icon-themes/elementary/cmd/lc_deleteauthor.png |binary icon-themes/elementary/cmd/lc_editannotation.png|binary icon-themes/elementary/cmd/lc_formatallnotes.png|binary icon-themes/elementary/cmd/lc_hideallnotes.png |binary icon-themes/elementary/cmd/lc_hidenote.png |binary icon-themes/elementary/cmd/lc_insertannotation.png |binary icon-themes/elementary/cmd/lc_nextannotation.png|binary icon-themes/elementary/cmd/lc_previousannotation.png|binary icon-themes/elementary/cmd/lc_replycomment.png |binary icon-themes/elementary/cmd/lc_showallnotes.png |binary icon-themes/elementary/cmd/lc_shownote.png |binary icon-themes/elementary/cmd/sc_commentchangetracking.png |binary icon-themes/elementary/cmd/sc_deleteallannotation.png |binary icon-themes/elementary/cmd/sc_deleteannotation.png |binary icon-themes/elementary/cmd/sc_deleteauthor.png |binary icon-themes/elementary/cmd/sc_editannotation.png|binary icon-themes/elementary/cmd/sc_formatallnotes.png|binary icon-themes/elementary/cmd/sc_hideallnotes.png |binary icon-themes/elementary/cmd/sc_hidenote.png |binary icon-themes/elementary/cmd/sc_insertannotation.png |binary icon-themes/elementary/cmd/sc_nextannotation.png|binary icon-themes/elementary/cmd/sc_previousannotation.png|binary icon-themes/elementary/cmd/sc_replycomment.png |binary icon-themes/elementary/cmd/sc_showallnotes.png |binary icon-themes/elementary/cmd/sc_shownote.png |binary icon-themes/elementary_svg/cmd/32/commentchangetracking.svg |2 +- icon-themes/elementary_svg/cmd/32/deleteallannotation.svg |2 +- icon-themes/elementary_svg/cmd/32/deleteannotation.svg |2 +- icon-themes/elementary_svg/cmd/32/deleteauthor.svg |1 + icon-themes/elementary_svg/cmd/32/editannotation.svg|2 +- icon-themes/elementary_svg/cmd/32/formatallnotes.svg|2 +- icon-themes/elementary_svg/cmd/32/hideallnotes.svg |2 +- icon-themes/elementary_svg/cmd/32/hidenote.svg |2 +- icon-themes/elementary_svg/cmd/32/insertannotation.svg |2 +- icon-themes/elementary_svg/cmd/32/nextannotation.svg|2 +- icon-themes/elementary_svg/cmd/32/previousannotation.svg|2 +- icon-themes/elementary_svg/cmd/32/replycomment.svg |2 +- icon-themes/elementary_svg/cmd/32/showallnotes.svg |2 +- icon-themes/elementary_svg/cmd/32/shownote.svg |2 +- icon-themes/elementary_svg/cmd/lc_commentchangetracking.svg |2 +- icon-themes/elementary_svg/cmd/lc_deleteallannotation.svg |2 +- icon-themes/elementary_svg/cmd/lc_deleteannotation.svg |2 +- icon-themes/elementary_svg/cmd/lc_deleteauthor.svg |1 + icon-themes/elementary_svg/cmd/lc_editannotation.svg|2 +- icon-themes/elementary_svg/cmd/lc_formatallnotes.svg|2 +- icon-themes/elementary_svg/cmd/lc_hideallnotes.svg |2 +- icon-themes/elementary_svg/cmd/lc_hidenote.svg |2 +- icon-themes/elementary_svg/cmd/lc_insertannotation.svg |2 +- icon-themes/elementary_svg/cmd/lc_nextannotation.svg|2 +- icon-themes/elementary_svg/cmd/lc_previousannotation.svg|2 +- icon-themes/elementary_svg/cmd/lc_replycomment.svg |2 +- icon-themes/elementary_svg/cmd/lc_showallnotes.svg |2 +- icon-themes/elementary_svg/cmd/lc_shownote.svg |2 +- icon-themes/elementary_svg/cmd/sc_commentchangetracking.svg |2 +-
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
dev/null |binary icon-themes/elementary/cmd/32/hide.png |binary icon-themes/elementary/cmd/32/insert.png |binary icon-themes/elementary/cmd/32/jumptonexttablesel.png |binary icon-themes/elementary/cmd/32/jumptoprevtablesel.png |binary icon-themes/elementary/cmd/32/move.png |binary icon-themes/elementary/cmd/32/name.png |binary icon-themes/elementary/cmd/32/remove.png |binary icon-themes/elementary/cmd/32/rename.png |binary icon-themes/elementary/cmd/32/selecttables.png |binary icon-themes/elementary/cmd/32/show.png |binary icon-themes/elementary/cmd/32/tabledeselectall.png |binary icon-themes/elementary/cmd/32/tableselectall.png |binary icon-themes/elementary/cmd/32/togglesheetgrid.png|binary icon-themes/elementary/cmd/lc_hide.png |binary icon-themes/elementary/cmd/lc_insert.png |binary icon-themes/elementary/cmd/lc_jumptonexttablesel.png |binary icon-themes/elementary/cmd/lc_jumptoprevtablesel.png |binary icon-themes/elementary/cmd/lc_move.png |binary icon-themes/elementary/cmd/lc_name.png |binary icon-themes/elementary/cmd/lc_remove.png |binary icon-themes/elementary/cmd/lc_rename.png |binary icon-themes/elementary/cmd/lc_selecttables.png |binary icon-themes/elementary/cmd/lc_show.png |binary icon-themes/elementary/cmd/lc_tabledeselectall.png |binary icon-themes/elementary/cmd/lc_tableselectall.png |binary icon-themes/elementary/cmd/lc_togglesheetgrid.png|binary icon-themes/elementary/cmd/sc_hide.png |binary icon-themes/elementary/cmd/sc_insert.png |binary icon-themes/elementary/cmd/sc_jumptonexttablesel.png |binary icon-themes/elementary/cmd/sc_jumptoprevtablesel.png |binary icon-themes/elementary/cmd/sc_move.png |binary icon-themes/elementary/cmd/sc_name.png |binary icon-themes/elementary/cmd/sc_remove.png |binary icon-themes/elementary/cmd/sc_rename.png |binary icon-themes/elementary/cmd/sc_selectdata.png |binary icon-themes/elementary/cmd/sc_selecttables.png |binary icon-themes/elementary/cmd/sc_show.png |binary icon-themes/elementary/cmd/sc_tabledeselectall.png |binary icon-themes/elementary/cmd/sc_tableselectall.png |binary icon-themes/elementary/cmd/sc_togglesheetgrid.png|binary icon-themes/elementary/links.txt |3 +++ icon-themes/elementary_svg/cmd/32/hide.svg |2 +- icon-themes/elementary_svg/cmd/32/insert.svg |2 +- icon-themes/elementary_svg/cmd/32/jumptonexttablesel.svg |2 +- icon-themes/elementary_svg/cmd/32/jumptoprevtablesel.svg |2 +- icon-themes/elementary_svg/cmd/32/move.svg |2 +- icon-themes/elementary_svg/cmd/32/name.svg |2 +- icon-themes/elementary_svg/cmd/32/remove.svg |2 +- icon-themes/elementary_svg/cmd/32/rename.svg |2 +- icon-themes/elementary_svg/cmd/32/selecttables.svg |2 +- icon-themes/elementary_svg/cmd/32/show.svg |2 +- icon-themes/elementary_svg/cmd/32/tabledeselectall.svg |2 +- icon-themes/elementary_svg/cmd/32/tableselectall.svg |2 +- icon-themes/elementary_svg/cmd/32/togglesheetgrid.svg|2 +- icon-themes/elementary_svg/cmd/lc_hide.svg |2 +- icon-themes/elementary_svg/cmd/lc_insert.svg |2 +- icon-themes/elementary_svg/cmd/lc_jumptonexttablesel.svg |2 +- icon-themes/elementary_svg/cmd/lc_jumptoprevtablesel.svg |2 +- icon-themes/elementary_svg/cmd/lc_move.svg |2 +- icon-themes/elementary_svg/cmd/lc_name.svg |2 +- icon-themes/elementary_svg/cmd/lc_remove.svg |2 +- icon-themes/elementary_svg/cmd/lc_rename.svg |2 +- icon-themes/elementary_svg/cmd/lc_selecttables.svg |2 +- icon-themes/elementary_svg/cmd/lc_show.svg |2 +- icon-themes/elementary_svg/cmd/lc_tabledeselectall.svg |2 +- icon-themes/elementary_svg/cmd/lc_tableselectall.svg |2 +- icon-themes/elementary_svg/cmd/lc_togglesheetgrid.svg|2 +- icon-themes/elementary_svg/cmd/sc_hide.svg |2 +- icon-themes/elementary_svg/cmd/sc_insert.svg |2 +- icon-themes/elementary_svg/cmd/sc_jumptonexttablesel.svg |2 +- icon-themes/elementary_svg/cmd/sc_jumptoprevtablesel.svg |2 +- icon-themes/elementary_svg/cmd/sc_move.svg |2 +- icon-themes/elementary_svg/cmd/sc_name.svg |2 +- icon-themes/elementary_svg/cmd/sc_remove.svg
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
dev/null|binary icon-themes/elementary/cmd/32/autoformat.png|binary icon-themes/elementary/cmd/32/columnmenu.png|binary icon-themes/elementary/cmd/32/dataincolumns.png |binary icon-themes/elementary/cmd/32/datainrows.png|binary icon-themes/elementary/cmd/32/dataprovider.png |binary icon-themes/elementary/cmd/32/dataproviderrefresh.png |binary icon-themes/elementary/cmd/32/dbnewtable.png|binary icon-themes/elementary/cmd/32/dbnewtableautopilot.png |binary icon-themes/elementary/cmd/32/dbtabledelete.png |binary icon-themes/elementary/cmd/32/dbtableedit.png |binary icon-themes/elementary/cmd/32/dbtablerename.png |binary icon-themes/elementary/cmd/32/dbviewtablenames.png |binary icon-themes/elementary/cmd/32/dbviewtables.png |binary icon-themes/elementary/cmd/32/deletecolumns.png |binary icon-themes/elementary/cmd/32/deleterows.png|binary icon-themes/elementary/cmd/32/deletetable.png |binary icon-themes/elementary/cmd/32/entirecell.png|binary icon-themes/elementary/cmd/32/entirecolumn.png |binary icon-themes/elementary/cmd/32/entirerow.png |binary icon-themes/elementary/cmd/32/formatcelldialog.png |binary icon-themes/elementary/cmd/32/freezepanesfirstcolumn.png|binary icon-themes/elementary/cmd/32/freezepanesfirstrow.png |binary icon-themes/elementary/cmd/32/grid.png |binary icon-themes/elementary/cmd/32/hidecolumn.png|binary icon-themes/elementary/cmd/32/hiderow.png |binary icon-themes/elementary/cmd/32/inscellsctrl.png |binary icon-themes/elementary/cmd/32/insertcellsdown.png |binary icon-themes/elementary/cmd/32/insertcellsright.png |binary icon-themes/elementary/cmd/32/insertcolumns.png |binary icon-themes/elementary/cmd/32/insertcolumnsafter.png|binary icon-themes/elementary/cmd/32/insertrows.png|binary icon-themes/elementary/cmd/32/insertrowsafter.png |binary icon-themes/elementary/cmd/32/inserttable.png |binary icon-themes/elementary/cmd/32/mergecells.png|binary icon-themes/elementary/cmd/32/mergetable.png|binary icon-themes/elementary/cmd/32/optimizetable.png |binary icon-themes/elementary/cmd/32/rowmenu.png |binary icon-themes/elementary/cmd/32/selectunprotectedcells.png|binary icon-themes/elementary/cmd/32/showcolumn.png|binary icon-themes/elementary/cmd/32/showrow.png |binary icon-themes/elementary/cmd/32/splitcell.png |binary icon-themes/elementary/cmd/32/splittable.png|binary icon-themes/elementary/cmd/32/tabledesign.png |binary icon-themes/elementary/cmd/32/tabledialog.png |binary icon-themes/elementary/cmd/32/togglemergecells.png |binary icon-themes/elementary/cmd/32/viewformasgrid.png|binary icon-themes/elementary/cmd/32/viewrowcolumnheaders.png |binary icon-themes/elementary/cmd/lc_autoformat.png|binary icon-themes/elementary/cmd/lc_columnmenu.png|binary icon-themes/elementary/cmd/lc_dataincolumns.png |binary icon-themes/elementary/cmd/lc_datainrows.png|binary icon-themes/elementary/cmd/lc_dataprovider.png |binary icon-themes/elementary/cmd/lc_dataproviderrefresh.png |binary icon-themes/elementary/cmd/lc_dbnewtable.png|binary icon-themes/elementary/cmd/lc_dbnewtableautopilot.png |binary icon-themes/elementary/cmd/lc_dbtabledelete.png |binary icon-themes/elementary/cmd/lc_dbtableedit.png |binary icon-themes/elementary/cmd/lc_dbtablerename.png |binary icon-themes/elementary/cmd/lc_dbviewtablenames.png |binary icon-themes/elementary/cmd/lc_dbviewtables.png |binary icon-themes/elementary/cmd/lc_deletecolumns.png |binary icon-themes/elementary/cmd/lc_deleterows.png|binary icon-themes/elementary/cmd/lc_deletetable.png |binary icon-themes/elementary/cmd/lc_entirecell.png
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
dev/null|binary icon-themes/elementary/cmd/32/basicstepinto.png |binary icon-themes/elementary/cmd/32/basicstepout.png |binary icon-themes/elementary/cmd/32/basicstepover.png |binary icon-themes/elementary/cmd/32/bg/sortdescending.png |binary icon-themes/elementary/cmd/32/cleararrowdependents.png |binary icon-themes/elementary/cmd/32/cleararrowprecedents.png |binary icon-themes/elementary/cmd/32/colorscaleformatdialog.png|binary icon-themes/elementary/cmd/32/conddateformatdialog.png |binary icon-themes/elementary/cmd/32/conditionalformatdialog.png |binary icon-themes/elementary/cmd/32/conditionalformatmenu.png |binary icon-themes/elementary/cmd/32/dataarearefresh.png |binary icon-themes/elementary/cmd/32/databarformatdialog.png |binary icon-themes/elementary/cmd/32/datafilterautofilter.png |binary icon-themes/elementary/cmd/32/datafilterspecialfilter.png |binary icon-themes/elementary/cmd/32/datasort.png |binary icon-themes/elementary/cmd/32/dbsortingandgrouping.png |binary icon-themes/elementary/cmd/32/definedbname.png |binary icon-themes/elementary/cmd/32/editframeset.png |binary icon-themes/elementary/cmd/32/entergroup.png|binary icon-themes/elementary/cmd/32/formfilternavigator.png |binary icon-themes/elementary/cmd/32/framedialog.png |binary icon-themes/elementary/cmd/32/iconsetformatdialog.png |binary icon-themes/elementary/cmd/32/insertframe.png |binary icon-themes/elementary/cmd/32/insertobjectfloatingframe.png |binary icon-themes/elementary/cmd/32/ko/sortascending.png |binary icon-themes/elementary/cmd/32/ko/sortdescending.png |binary icon-themes/elementary/cmd/32/leaveallgroups.png|binary icon-themes/elementary/cmd/32/leavegroup.png|binary icon-themes/elementary/cmd/32/matchgroup.png|binary icon-themes/elementary/cmd/32/removefiltersort.png |binary icon-themes/elementary/cmd/32/selectdata.png|binary icon-themes/elementary/cmd/32/selectdb.png |binary icon-themes/elementary/cmd/32/showdependents.png|binary icon-themes/elementary/cmd/32/showprecedents.png|binary icon-themes/elementary/cmd/32/snapframe.png |binary icon-themes/elementary/cmd/32/sortascending.png |binary icon-themes/elementary/cmd/32/sortdescending.png|binary icon-themes/elementary/cmd/32/validation.png|binary icon-themes/elementary/cmd/bg/sc_sortdescending.png |binary icon-themes/elementary/cmd/ko/sc_sortascending.png |binary icon-themes/elementary/cmd/ko/sc_sortdescending.png |binary icon-themes/elementary/cmd/lc_basicstepinto.png |binary icon-themes/elementary/cmd/lc_basicstepout.png |binary icon-themes/elementary/cmd/lc_basicstepover.png |binary icon-themes/elementary/cmd/lc_cleararrowdependents.png |binary icon-themes/elementary/cmd/lc_cleararrowprecedents.png |binary icon-themes/elementary/cmd/lc_colorscaleformatdialog.png|binary icon-themes/elementary/cmd/lc_conddateformatdialog.png |binary icon-themes/elementary/cmd/lc_conditionalformatdialog.png |binary icon-themes/elementary/cmd/lc_conditionalformatmenu.png |binary icon-themes/elementary/cmd/lc_dataarearefresh.png |binary icon-themes/elementary/cmd/lc_databarformatdialog.png |binary icon-themes/elementary/cmd/lc_dbsortingandgrouping.png |binary icon-themes/elementary/cmd/lc_definedbname.png |binary icon-themes/elementary/cmd/lc_editframeset.png |binary icon-themes/elementary/cmd/lc_entergroup.png|binary icon-themes/elementary/cmd/lc_framedialog.png |binary icon-themes/elementary/cmd/lc_iconsetformatdialog.png |binary icon-themes/elementary/cmd/lc_insertframe.png |binary icon-themes/elementary/cmd/lc_insertobjectfloatingframe.png |binary icon-themes/elementary/cmd/lc_insertreferencefield.png |binary icon-themes/elementary/cmd/lc_leaveallgroups.png|binary icon-themes/elementary/cmd/lc_leavegroup.png|binary icon-themes/elementary/cmd/lc_matchgroup.png|binary icon-themes/elementary/cmd/lc_pie_unfilled.png |binary icon-themes/elementary/cmd/lc_selectdata.png|binary icon-themes/elementary/cmd/lc_selectdb.png |binary
[Libreoffice-bugs] [Bug 138989] Even with --disable-mariadb-sdbc, various menus and messages include the MySQL alternative
https://bugs.documentfoundation.org/show_bug.cgi?id=138989 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139051] Feedback: Text align based on numbers positional value instead of just Left, Right or Center alignment. FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=139051 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change
https://bugs.documentfoundation.org/show_bug.cgi?id=139037 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change
https://bugs.documentfoundation.org/show_bug.cgi?id=139037 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139036] UI: visual glitch header line not following page
https://bugs.documentfoundation.org/show_bug.cgi?id=139036 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139025] FILEOPEN. Unable to access file as writeable on local share
https://bugs.documentfoundation.org/show_bug.cgi?id=139025 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139023] LO 7.0.4 cannot be terminated on win2012 in terminal server mode sometimes
https://bugs.documentfoundation.org/show_bug.cgi?id=139023 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138992] Collabora Office (and LO Vanilla) - remove UI components relating to Java functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=138992 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139317] relative link to image doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=139317 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139317] relative link to image doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=139317 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108288 Bug 108288 depends on bug 93890, which changed state. Bug 93890 Summary: FILEOPEN clean-up of bookmark-start and -end breaks references https://bugs.documentfoundation.org/show_bug.cgi?id=93890 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93890] FILEOPEN clean-up of bookmark-start and -end breaks references
https://bugs.documentfoundation.org/show_bug.cgi?id=93890 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93890] FILEOPEN clean-up of bookmark-start and -end breaks references
https://bugs.documentfoundation.org/show_bug.cgi?id=93890 --- Comment #6 from QA Administrators --- Dear Malte, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133654] EDITING:
https://bugs.documentfoundation.org/show_bug.cgi?id=133654 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133654] EDITING:
https://bugs.documentfoundation.org/show_bug.cgi?id=133654 --- Comment #3 from QA Administrators --- Dear Libre User, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133837] The screen font has become blurry after upgrading to 6.3.6.2 for use on OS 10.14.6 with retinal screen.
https://bugs.documentfoundation.org/show_bug.cgi?id=133837 --- Comment #2 from QA Administrators --- Dear Tarchin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88749] Edit>Delete Contents should not allow to delete Pivot Table
https://bugs.documentfoundation.org/show_bug.cgi?id=88749 --- Comment #9 from QA Administrators --- Dear Pedro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122394] changing named ranges content via vba macro will not update cell formula
https://bugs.documentfoundation.org/show_bug.cgi?id=122394 --- Comment #3 from QA Administrators --- Dear Oliver Brinzing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116251] Problem rendering background rectangle in PDF in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=116251 --- Comment #3 from QA Administrators --- Dear Kevin Loughrey, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116022] Bullets not aligned with indents triangles in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=116022 --- Comment #4 from QA Administrators --- Dear meaz, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113687] Wrong cell attributes assumed
https://bugs.documentfoundation.org/show_bug.cgi?id=113687 --- Comment #11 from QA Administrators --- Dear Elmar, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/fly.cxx |7 +--
sw/source/core/layout/pagechg.cxx |9 ++---
sw/source/core/layout/sectfrm.cxx |7 +--
sw/source/core/layout/tabfrm.cxx | 13 -
4 files changed, 24 insertions(+), 12 deletions(-)
New commits:
commit 5cda343212d086b5e1f06e9d4eba16d254a56628
Author: Bjoern Michaelsen
AuthorDate: Thu Dec 31 22:34:00 2020 +0100
Commit: Bjoern Michaelsen
CommitDate: Sat Jan 2 04:21:14 2021 +0100
Fix: Move remaining direct calls to SwLayoutFrame::Modify out of the way
Change-Id: I544cc42845d346eb0901ca86621a563d1173e2b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108550
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index 02b7c724eaef..299932e8fa7c 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -675,7 +675,7 @@ void SwFlyFrame::SwClientNotify(const SwModify& rMod, const
SfxHint& rHint)
pOItem = aOIter.NextItem();
} while(pNItem);
if(aOldSet.Count() || aNewSet.Count())
-SwLayoutFrame::Modify(, );
+SwLayoutFrame::SwClientNotify(rMod,
sw::LegacyModifyHint(, ));
}
else
UpdateAttr_(pLegacy->m_pOld, pLegacy->m_pNew, nInvFlags);
@@ -1057,7 +1057,10 @@ void SwFlyFrame::UpdateAttr_( const SfxPoolItem *pOld,
const SfxPoolItem *pNew,
pNewSet->ClearItem( nWhich );
}
else
-SwLayoutFrame::Modify( pOld, pNew );
+{
+SwModify aMod;
+SwLayoutFrame::SwClientNotify(aMod, sw::LegacyModifyHint(pOld,
pNew));
+}
}
}
diff --git a/sw/source/core/layout/pagechg.cxx
b/sw/source/core/layout/pagechg.cxx
index 611b63753bc1..95321684de87 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -531,7 +531,7 @@ void SwPageFrame::SwClientNotify(const SwModify& rModify,
const SfxHint& rHint)
pNItem = aNIter.NextItem();
} while(pNItem);
if(aOldSet.Count() || aNewSet.Count())
-SwLayoutFrame::Modify(, );
+SwLayoutFrame::SwClientNotify(rModify,
sw::LegacyModifyHint(, ));
}
else
UpdateAttr_(pLegacy->m_pOld, pLegacy->m_pNew, nInvFlags);
@@ -629,7 +629,7 @@ void SwPageFrame::UpdateAttr_( const SfxPoolItem *pOld,
const SfxPoolItem *pNew,
// Calculation of the page is not necessary, because its size
is
// invalidated here and further invalidation is done in the
// calling method and probably by
calling
-// at the end.
+// at the end.
// It can also causes inconsistences, because the lowers are
// adjusted, but not calculated, and a
of
// a next page is called. This is performed on the switch to
the
@@ -708,7 +708,10 @@ void SwPageFrame::UpdateAttr_( const SfxPoolItem *pOld,
const SfxPoolItem *pNew,
pNewSet->ClearItem( nWhich );
}
else
-SwLayoutFrame::Modify( pOld, pNew );
+{
+SwModify aMod;
+SwLayoutFrame::SwClientNotify(aMod, sw::LegacyModifyHint(pOld,
pNew));
+}
}
}
diff --git a/sw/source/core/layout/sectfrm.cxx
b/sw/source/core/layout/sectfrm.cxx
index aab18463fe06..0de0d2a5f296 100644
--- a/sw/source/core/layout/sectfrm.cxx
+++ b/sw/source/core/layout/sectfrm.cxx
@@ -2588,7 +2588,7 @@ void SwSectionFrame::SwClientNotify(const SwModify& rMod,
const SfxHint& rHint)
pOItem = aOIter.NextItem();
} while (pNItem);
if(aOldSet.Count() || aNewSet.Count())
-SwLayoutFrame::Modify(, );
+SwLayoutFrame::SwClientNotify(rMod,
sw::LegacyModifyHint(, ));
}
else
UpdateAttr_(pLegacy->m_pOld, pLegacy->m_pNew, nInvFlags);
@@ -2725,7 +2725,10 @@ void SwSectionFrame::UpdateAttr_( const SfxPoolItem
*pOld, const SfxPoolItem *pN
pNewSet->ClearItem( nWhich );
}
else
-SwLayoutFrame::Modify( pOld, pNew );
+{
+SwModify aMod;
+SwLayoutFrame::SwClientNotify(aMod, sw::LegacyModifyHint(pOld,
pNew));
+}
}
}
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 88033e3ee9b6..6eb3ccfd1627 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -3257,7 +3257,7 @@ SwTwips SwTabFrame::GrowFrame( SwTwips nDist, bool bTst,
bool bInfo )
return nDist;
}
-void SwTabFrame::SwClientNotify(const SwModify&, const SfxHint& rHint)
+void SwTabFrame::SwClientNotify(const SwModify& rMod, const SfxHint& rHint)
{
auto pLegacy = dynamic_cast();
if(!pLegacy)
@@ -3282,7 +3282,7 @@ void SwTabFrame::SwClientNotify(const
[Libreoffice-bugs] [Bug 132901] Tools > Options > LibreOffice > Online update does not handle the situation of "online update" feature not being installed gracefully
https://bugs.documentfoundation.org/show_bug.cgi?id=132901 --- Comment #13 from himajin100...@gmail.com --- just a note ( unrelated to installation stuffs): https://opengrok.libreoffice.org/xref/core/cui/source/options/optupdt.cxx?r=ab6dbb22#71 https://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.cxx?r=d122dbd0#661 https://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.cxx?r=d122dbd0#227 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139363] BASIC: SerialDate() only accept the most obvious month and day values.
https://bugs.documentfoundation.org/show_bug.cgi?id=139363 --- Comment #1 from himajin100...@gmail.com --- I believe there is no function named SerialDate. For DateSerial() in StarBasic, see https://opengrok.libreoffice.org/xref/core/basic/source/runtime/methods.cxx?r=3482f590#4757 for the implementation details. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Problems with OutputDevice
> On 2 Jan 2021, at 9:48 am, Thorsten Behrens wrote: > > Chris Sherlock wrote: >> OutputDevice relies of VirtualDevice for alpha blending >> >> What can I say? It’s an extraordinary hack and has been that way for >> a long time. >> > Rooted in history, too. I did that hack many years ago, as Win32 GDI > had no good way to render into ARGB surfaces - and GDI+ was not > necessarily available on all of our baseline OS versions. > > And yeah, this code has to die. ;) > > Cheers, > > -- Thorsten Haha, yeah I understand - this was not necessarily a negative criticism, as a hack it has done its job :-) I’m assuming that we obviously rely on GDI+ now? What is your opinion of the fallback code being placed in SalGraphics? Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 139357] Calc, Form Controls gone after save and open
https://bugs.documentfoundation.org/show_bug.cgi?id=139357 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #6 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 119046 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119046] FILESAVE XLSX ActiveX Controls created with Excel are lost when saved as XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=119046 m.a.riosv changed: What|Removed |Added CC||reute...@gmail.com --- Comment #9 from m.a.riosv --- *** Bug 139357 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108015] Using Ctrl + Shift + B and Ctrl + Shift + I for Emphasis and Strong Emphasis character styles (and change Super/Subscript keyboard shortcuts)
https://bugs.documentfoundation.org/show_bug.cgi?id=108015 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval Summary|Using Ctrl + Shift + B and |Using Ctrl + Shift + B and |Ctrl + Shift + I for|Ctrl + Shift + I for |Emphasis and Strong |Emphasis and Strong |Emphasis character styles |Emphasis character styles ||(and change Super/Subscript ||keyboard shortcuts) CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #2 from sdc.bla...@youmail.dk --- Counter proposal: Alt+Shift+S - Strong Emphasis Alt+Shift+E - Emphasis Reasons: 1. Strong and Emphasis are supposed to be "semantic" rather than visual. By not using B and I (as proposed here), it does not offer a false and easy confusion between formatting (visual appearance) and character style. 2. S and E are easy mnemonics to remember. 3. Both keys are not currently used in the "default" configuration. 4. Do not require changing existing definitions. 5. (these key combinations may be achievable with one hand on some keyboards.) 6. Ctrl+Shift+E is a problematic combination in gtk. / Ctrl+Shift+S already used. About sub- and superscripts (even though I have learned the existing definitions, it is probably a good thing to seek an easier combination) Proposal: Ctrl+Shift+, - superscript Ctrl+,- subscript Reasons: 1. are available, do not require changing other shortcuts 2. both use comma (do not have to remember which key is sub/superscript) 3. Shift should indicate superscript (mnemonic) 4. comma is probably easily accessible in most keyboard layouts. 5. Ctrl+Shift+ +/- are not offered as possible shortcut keys 6. "equal" requires a shift in some keyboard layouts (added this topic to bug summary) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 108015] Using Ctrl + Shift + B and Ctrl + Shift + I for Emphasis and Strong Emphasis character styles (and change Super/Subscript keyboard shortcuts)
https://bugs.documentfoundation.org/show_bug.cgi?id=108015 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval Summary|Using Ctrl + Shift + B and |Using Ctrl + Shift + B and |Ctrl + Shift + I for|Ctrl + Shift + I for |Emphasis and Strong |Emphasis and Strong |Emphasis character styles |Emphasis character styles ||(and change Super/Subscript ||keyboard shortcuts) CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #2 from sdc.bla...@youmail.dk --- Counter proposal: Alt+Shift+S - Strong Emphasis Alt+Shift+E - Emphasis Reasons: 1. Strong and Emphasis are supposed to be "semantic" rather than visual. By not using B and I (as proposed here), it does not offer a false and easy confusion between formatting (visual appearance) and character style. 2. S and E are easy mnemonics to remember. 3. Both keys are not currently used in the "default" configuration. 4. Do not require changing existing definitions. 5. (these key combinations may be achievable with one hand on some keyboards.) 6. Ctrl+Shift+E is a problematic combination in gtk. / Ctrl+Shift+S already used. About sub- and superscripts (even though I have learned the existing definitions, it is probably a good thing to seek an easier combination) Proposal: Ctrl+Shift+, - superscript Ctrl+,- subscript Reasons: 1. are available, do not require changing other shortcuts 2. both use comma (do not have to remember which key is sub/superscript) 3. Shift should indicate superscript (mnemonic) 4. comma is probably easily accessible in most keyboard layouts. 5. Ctrl+Shift+ +/- are not offered as possible shortcut keys 6. "equal" requires a shift in some keyboard layouts (added this topic to bug summary) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139365] Table>insert Rows should move the cursor to the new row.
https://bugs.documentfoundation.org/show_bug.cgi?id=139365 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Why do you assume it is so?, some survey about? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118693] FILEOPEN: Drawing has incorrect size
https://bugs.documentfoundation.org/show_bug.cgi?id=118693 --- Comment #8 from Dave Gilbert --- I think there's more than one bug going on here; there's certainly an alignment/offset issue that seems to be common to all of them. But there are some others, in my 139297 there's a line that's done a 90deg turn; a bit of debugging gets me to a disagreement with ImpForceLineAngle. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138955] Deleting whitespace when pasting cell
https://bugs.documentfoundation.org/show_bug.cgi?id=138955 raal changed: What|Removed |Added Whiteboard| QA:needsComment| CC||r...@post.cz --- Comment #1 from raal --- Works for me Version: 7.2.0.0.alpha0+ Build ID: 476bc04e6a9cde9b7424f118d6ef9422975be84a CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139364] It is impossible to add a data value label to a mean value line in a libre calc graph
https://bugs.documentfoundation.org/show_bug.cgi?id=139364 Leyan changed: What|Removed |Added Component|Calc|Chart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139206] LibreOffice Calc crashes when I try to delete Y error bars in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=139206 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #5 from raal --- No crash with Version: 7.2.0.0.alpha0+ Build ID: 476bc04e6a9cde9b7424f118d6ef9422975be84a CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139332] UI: Expert Configuration doesn't show Ok/Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=139332 raal changed: What|Removed |Added Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression CC||caol...@redhat.com, ||r...@post.cz Status|UNCONFIRMED |NEW --- Comment #5 from raal --- This seems to have begun at the below commit. Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one? Thanks bibisect-linux-64-6.4$: e16dc96c3336de7513a0bfd7744c5abc214b59e0 is the first bad commit commit e16dc96c3336de7513a0bfd7744c5abc214b59e0 Author: Jenkins Build User Date: Tue Oct 1 03:06:27 2019 +0200 source sha:c6bee0aad804c32a4367adc04878648427b06b5a https://git.libreoffice.org/core/+/c6bee0aad804c32a4367adc04878648427b06b5a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Problems with OutputDevice
Chris Sherlock wrote: > OutputDevice relies of VirtualDevice for alpha blending > > What can I say? It’s an extraordinary hack and has been that way for > a long time. > Rooted in history, too. I did that hack many years ago, as Win32 GDI had no good way to render into ARGB surfaces - and GDI+ was not necessarily available on all of our baseline OS versions. And yeah, this code has to die. ;) Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Problems with OutputDevice
Hi Chris, first off - great to see you tackling OutDev, which I agree is a terrible hairball. Chris Sherlock wrote: > After this we need to start to tackle the issue of having to push > state around. IMO, we seem to have done this because that’s the way > a meta file does things. I do t believe this is necessary. If we > want to use a coloured line, then we tell the function what colour > it should use as a function parameter. If we need a full colour, > then we do the same. If we don’t care we pick sensible defaults. > You'll then have to review every single bit of LibreOffice code that's using OutDev for rendering. The assumption of state is baked into every corner of Writer, Calc and Impress rendering since the dawn of time. (on the historical reasons - I suspects that's this way since also Win16 GDI was stateful..) Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 139354] Software is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=139354 Ming Hua changed: What|Removed |Added Resolution|--- |INVALID Version|1.13|unspecified Component|General |deletionRequest Product|cppunit |LibreOffice Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139358] Software is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=139358 Ming Hua changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Product|Document Liberation Project |LibreOffice Component|libabw |deletionRequest Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139352] Software is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=139352 Ming Hua changed: What|Removed |Added Component|Android Remote App |deletionRequest Version|2.1.3 |unspecified Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID Product|Impress Remote |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139365] New: Table>insert Rows should move the cursor to the new row.
https://bugs.documentfoundation.org/show_bug.cgi?id=139365 Bug ID: 139365 Summary: Table>insert Rows should move the cursor to the new row. Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Description: Table>insert Rows insert a row above or below, but leaves the cursor in the start row. It should move it to the new row, where (most likely) the user wants to enter text. Steps to Reproduce: 1.Table>insert Rows 2. 3. Actual Results: cursor stays put. Expected Results: cursor should move to the the new row Reproducible: Always User Profile Reset: No Additional Info: none -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139364] New: It is impossible to add a data value label to a mean value line in a libre calc graph
https://bugs.documentfoundation.org/show_bug.cgi?id=139364 Bug ID: 139364 Summary: It is impossible to add a data value label to a mean value line in a libre calc graph Product: LibreOffice Version: 7.0.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gd...@yahoo.com Description: When creating a line chart graph, you can right click the line and "insert mean value line". However it is impossible to inser a data label to this line. You can only insert data labels to the chart line. Steps to Reproduce: 1. create some data 2. create a line chart from the above data 3. go to chart and right click the line 4. insert "mean value line" 5. try to insert data label to mean value line It is impossible there is no such option Actual Results: It is not possible to add data label to mean value line Expected Results: There should be an option to insert data values to mean value line Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65046] Threaded calculation of formula groups (multi-threading)
https://bugs.documentfoundation.org/show_bug.cgi?id=65046 raal changed: What|Removed |Added CC||mahajan.dee...@jains.com --- Comment #23 from raal --- *** Bug 139355 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139355] Libre Office not using all CPU cores
https://bugs.documentfoundation.org/show_bug.cgi?id=139355 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #1 from raal --- Hello, Thank you for submitting the bug. The bug has previously been reported, so this bug will be added as a duplicate of it. You will automatically be CCed to updates made to the other bug. *** This bug has been marked as a duplicate of bug 65046 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139363] New: BASIC: SerialDate() only accept the most obvious month and day values.
https://bugs.documentfoundation.org/show_bug.cgi?id=139363
Bug ID: 139363
Summary: BASIC: SerialDate() only accept the most obvious month
and day values.
Product: LibreOffice
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: BASIC
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: guraknu...@gmail.com
The BASIC command SerialDate() doesn't accept months and days out of bounds.
The Calc cell-function DATE() does and so does Excel's DateSerial(), and it
would be very practical if SerialDate() also did.
Example 1:
Print SerialDate(2021,2,29)
Gives an error message.
In a spreadsheet cell: =DATE(2021;2;29)
Result: 2021-03-01 (if cell is formatted properly, as -MM-DD, of course)
Expected result: 2021-03-01
Example 2:
Find the last date in February 2021:
Print SerialDate(2021,3,0)
Error message.
In a spreadsheet cell: =DATE(2021;3;0)
Result: 2021-02-28
Expected result: 2021-02-28
Example 3:
Just about anything, such as:
Print SerialDate(2021,-73,-4500)
Error message.
In a spreadsheet cell: =DATE(2021;-73;-4500)
Result: 2002-07-06
Expected result: 2002-07-06
Example 4:
Loop through months:
Dim dtCurrentDate As Date, dtDate As Date
Dim iYear As Integer, iMonth As Integer, i As Integer
dtCurrentDate=Now()
iYear=Year(dtCurrentDate)
iMonth=Month(dtCurrentDate)
For i=-100 To 100
dtDate=SerialDate(iYear, iMonth+i, 1)
' Print dtDate somewhere or whatever.
Next i
The above only works as long as 1≤(iMonth+i)≤12, otherwise there is an error.
Expected result: It should loop through all months and figure out the dtDate
values without questioning anything.
Workaround:
A custom function for it. Here are mine, I wrote two different global ones:
' This one adjusts the input values before using the built in SerialDate.
Public Function DateSerialA(iYear As Integer, iMonth As Integer, iDay As
Integer) As Date
If iMonth>12 Or iMonth<1 Then
Dim iYearDiff As Integer
iYearDiff=int((iMonth-1)/12)
iYear=iYear+iYearDiff
iMonth=iMonth-12*iYearDiff
End If
DateSerialA=DateSerial(iYear, iMonth, 1)+iDay-1
End Function
' This one simply use Calc's DATE() function.
Public Function DateSerialC(iYear As Integer, iMonth As Integer, iDay As
Integer) As Date
Dim CalcFunction As com.sun.star.uno.XInterface
CalcFunction=createUnoService("com.sun.star.sheet.FunctionAccess")
DateSerialC=CalcFunction.callFunction("DATE", Array(iYear, iMonth,
iDay))
End Function
If not using extended data types, Dim CalcFunction As Object instead, of
course.
Example 3 again:
Print SerialDateA(2021,-73,-4500)
Result: 2002-07-06
Print SerialDateC(2021,-73,-4500)
Result: 2002-07-06
Both match the expected results.
I just find it very strange and inconsistent that SerialDate() is so primitive
compared to the DATE() cell function in Calc. Accepting just about any integer
for month and day is very useful in loops and makes the code more compact and
easier to understand.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139016] LibreOffice Calc background color on input box doesn't change with Application Colors
https://bugs.documentfoundation.org/show_bug.cgi?id=139016 pavlog changed: What|Removed |Added CC||pavlograd...@gmail.com Whiteboard| QA:needsComment| --- Comment #2 from pavlog --- Do you mean Math or Calc? I can repro it in Math in Version: 7.2.0.0.alpha0+ (x64) Build ID: ecb916667b633f8647790e040226b093760e6cfe CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139362] New: PRINTING - Sender address on envelope doesn't print
https://bugs.documentfoundation.org/show_bug.cgi?id=139362 Bug ID: 139362 Summary: PRINTING - Sender address on envelope doesn't print Product: LibreOffice Version: 6.4.7.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: walterr...@yahoo.com Description: I'm using LibreOffice 6.4.7.2 in macOS 11.1. Often when I create an envelope with the Addressee and Sender addresses, the Sender address doesn't appear in the preview and it doesn't print. Steps to Reproduce: 1.Insert > Envelope 2.Fill in Addressee and Sender fields 3.Click New Document 4.Select Print, then click Print Actual Results: Sometimes the Sender address appears in the preview and prints, sometimes not. Expected Results: The Sender address didn't appear in the preview nor did it print. Reproducible: Sometimes User Profile Reset: No Additional Info: Sender address appears in preview and prints. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139360] UI: Style inspector has no scroll bar
https://bugs.documentfoundation.org/show_bug.cgi?id=139360 Ming Hua changed: What|Removed |Added Resolution|--- |DUPLICATE CC||ming.v@qq.com Status|UNCONFIRMED |RESOLVED --- Comment #2 from Ming Hua --- *** This bug has been marked as a duplicate of bug 136764 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136764] Style inspector: No scrollbars and minimum width
https://bugs.documentfoundation.org/show_bug.cgi?id=136764 Ming Hua changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #8 from Ming Hua --- *** Bug 139360 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139340] Crash when opening Table or Query with graphic Editor
https://bugs.documentfoundation.org/show_bug.cgi?id=139340 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Could you upgrade to 7.0.4 and give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/firebird
0 files changed New commits: commit c38f638360579036f0d323ea68c5c1db13c7d450 Author: Andrea Gelmini AuthorDate: Fri Jan 1 16:23:11 2021 +0100 Commit: Julien Nabet CommitDate: Fri Jan 1 22:33:27 2021 +0100 Removed executable bits from patch file Change-Id: I6cbfbfe32fb1d70cd8f73add0c2f6a63117e7f4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108560 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/external/firebird/msvc.patch b/external/firebird/msvc.patch old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: scripting/examples
scripting/examples/python/NamedRanges.py |6 +++---
scripting/examples/python/SetCellColor.py |2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 9c5f2dc85d0af714058ffc84d86ebc7d5c4dd6a7
Author: Andrea Gelmini
AuthorDate: Fri Jan 1 16:23:29 2021 +0100
Commit: Julien Nabet
CommitDate: Fri Jan 1 22:31:36 2021 +0100
Fix typos
Change-Id: I085ff68b4550468eb163d88978c81d8b5335e6ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108561
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/scripting/examples/python/NamedRanges.py
b/scripting/examples/python/NamedRanges.py
index f4d4d32a1e05..5a28e2b5da57 100644
--- a/scripting/examples/python/NamedRanges.py
+++ b/scripting/examples/python/NamedRanges.py
@@ -54,7 +54,7 @@ def NamedRanges():
smgr = ctx.ServiceManager
desktop = smgr.createInstanceWithContext("com.sun.star.frame.Desktop", ctx)
-# Create a blank spreadsheet document, instead of damanging the existing
document.
+# Create a blank spreadsheet document, instead of damaging the existing
document.
doc = desktop.loadComponentFromURL("private:factory/scalc", "_blank", 0,
())
# Create a new sheet to store our output information
@@ -114,11 +114,11 @@ def NamedRanges():
infoSheet.getCellRangeByName("A8").String = "Sum of test_range1:"
infoSheet.getCellRangeByName("B8").Formula = "=SUM(test_range1)"
-# Calcualte sum of test_range2
+# Calculate sum of test_range2
infoSheet.getCellRangeByName("A9").String = "Sum of test_range2:"
infoSheet.getCellRangeByName("B9").Formula = "=SUM(test_range2)"
-# Calcualte the difference between the two ranges
+# Calculate the difference between the two ranges
infoSheet.getCellRangeByName("A10").String = "sum(test_range2) -
sum(test_range1):"
infoSheet.getCellRangeByName("B10").Formula = "=B9-B8"
diff --git a/scripting/examples/python/SetCellColor.py
b/scripting/examples/python/SetCellColor.py
index 22d86edbbeff..7319d621dd1a 100644
--- a/scripting/examples/python/SetCellColor.py
+++ b/scripting/examples/python/SetCellColor.py
@@ -38,7 +38,7 @@ def SetCellColor():
# Call the above helper function to set color (in hex number).
# To get the hex number:
-#1. go to Calc, click toolbar dropdown "Background Color" > Custome
Color;
+#1. go to Calc, click toolbar dropdown "Background Color" > Custom
Color;
#2. Pick a color, copy the hex number and prefix it with "0x".
_SetCellColor(sheet, "C3:C21",0x4021c9)
_SetCellColor(sheet, "D18:E21", 0x4021c9)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 138903] Changing page style to two-column when it contains a TOC causes lockup
https://bugs.documentfoundation.org/show_bug.cgi?id=138903 pavlog changed: What|Removed |Added CC||pavlograd...@gmail.com Status|UNCONFIRMED |NEW Blocks||89606 Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #3 from pavlog --- I can reproduce it in Version: 7.2.0.0.alpha0+ (x64) Build ID: ecb916667b633f8647790e040226b093760e6cfe CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=89606 [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89606] [META] Table of Contents and Indexes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=89606 pavlog changed: What|Removed |Added Depends on||138903 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138903 [Bug 138903] Changing page style to two-column when it contains a TOC causes lockup -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139359] Inserting a symbol does insert lots of direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=139359 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #3 from Telesto --- (In reply to V Stuart Foote from comment #2) > Expect the amount of formatting will depend on if the symbol being inserted > is found in the font assigned to the paragraph. > > A per os/DE font fallback is used when font replacement occurs. If replaced, > the span holding the glyphs picked from the Special Symbol dialog will show > as DF. > > Try it for a symbol that is in the font of the styled paragraph. Also, easy > to see what happens if you look at the document export to ODF as Flat ODF. I'm still kind of confused by this.. * CTRL+M removes all of this information.. (desired/undesired/ makes sense?) * This doesn't happen with 'normal editing.. you get all those special fall back settings for free. If you insert a symbol and go typing again.. the DF will be present all over the place.. And interfering with 'use styles' concept.. It also hits the unwanted (additional) direct formatting topic.. Hope someone having a proposal here :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139359] Inserting a symbol does insert lots of direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=139359 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #3 from Telesto --- (In reply to V Stuart Foote from comment #2) > Expect the amount of formatting will depend on if the symbol being inserted > is found in the font assigned to the paragraph. > > A per os/DE font fallback is used when font replacement occurs. If replaced, > the span holding the glyphs picked from the Special Symbol dialog will show > as DF. > > Try it for a symbol that is in the font of the styled paragraph. Also, easy > to see what happens if you look at the document export to ODF as Flat ODF. I'm still kind of confused by this.. * CTRL+M removes all of this information.. (desired/undesired/ makes sense?) * This doesn't happen with 'normal editing.. you get all those special fall back settings for free. If you insert a symbol and go typing again.. the DF will be present all over the place.. And interfering with 'use styles' concept.. It also hits the unwanted (additional) direct formatting topic.. Hope someone having a proposal here :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139219] [UI] elementary: Proposal to remove green header row part in table icon
https://bugs.documentfoundation.org/show_bug.cgi?id=139219 Rizal Muttaqin changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139353] [UI] elementary: Change Comment/Note/Annotation Appearance to Be Rounded Rectangle Bubble
https://bugs.documentfoundation.org/show_bug.cgi?id=139353 Rizal Muttaqin changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org |desktop.org | Blocks||120949 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120949 [Bug 120949] [META] Elementary icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Rizal Muttaqin changed: What|Removed |Added Depends on||139353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139353 [Bug 139353] [UI] elementary: Change Comment/Note/Annotation Appearance to Be Rounded Rectangle Bubble -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449 Bug 104449 depends on bug 117921, which changed state. Bug 117921 Summary: Fileopen DOCX: Support both Vertical Directions in Text Box https://bugs.documentfoundation.org/show_bug.cgi?id=117921 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111409] [META] Unify text direction functionality for all components
https://bugs.documentfoundation.org/show_bug.cgi?id=111409 Bug 111409 depends on bug 117921, which changed state. Bug 117921 Summary: Fileopen DOCX: Support both Vertical Directions in Text Box https://bugs.documentfoundation.org/show_bug.cgi?id=117921 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117921] Fileopen DOCX: Support both Vertical Directions in Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=117921 Gabor Kelemen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 139361] UI: Retrain manually set collapsed states in style inspector
https://bugs.documentfoundation.org/show_bug.cgi?id=139361 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #2 from Telesto --- Not sure how to implement this in logical way -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139361] UI: Retrain manually set collapsed states in style inspector
https://bugs.documentfoundation.org/show_bug.cgi?id=139361 Telesto changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #2 from Telesto --- Not sure how to implement this in logical way -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139361] UI: Retrain manually set collapsed states in style inspector
https://bugs.documentfoundation.org/show_bug.cgi?id=139361 --- Comment #1 from Telesto --- Created attachment 168628 --> https://bugs.documentfoundation.org/attachment.cgi?id=168628=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139361] New: UI: Retrain manually set collapsed states in style inspector
https://bugs.documentfoundation.org/show_bug.cgi?id=139361 Bug ID: 139361 Summary: UI: Retrain manually set collapsed states in style inspector Product: LibreOffice Version: 7.1.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: Retrain manually set collapsed states in style inspector Steps to Reproduce: 1. Open the attached file 2. Collapse Heading/Heading 1 (to inspect for DF) 3. Click somewhere else.. Actual Results: Constantly expanding Expected Results: Case: hypothetical case: I'm hunting DF.. but this makes it hard Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: 4e3ce9dd6ace0b22f7b3f45cf2338b201f4dc305 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139360] UI: Style inspector has no scroll bar
https://bugs.documentfoundation.org/show_bug.cgi?id=139360 --- Comment #1 from Telesto --- Created attachment 168627 --> https://bugs.documentfoundation.org/attachment.cgi?id=168627=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139360] New: UI: Style inspector has no scroll bar
https://bugs.documentfoundation.org/show_bug.cgi?id=139360 Bug ID: 139360 Summary: UI: Style inspector has no scroll bar Product: LibreOffice Version: 7.1.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: Style inspector has no scroll bar Steps to Reproduce: 1. Open the attached file 2. Open the sidebar -> style inspector Actual Results: No scroll bar Expected Results: Scroll bar -> there are Direct Formattings present Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: 4e3ce9dd6ace0b22f7b3f45cf2338b201f4dc305 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117921] Fileopen DOCX: Support both Vertical Directions in Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=117921 --- Comment #9 from Gabor Kelemen --- Created attachment 168626 --> https://bugs.documentfoundation.org/attachment.cgi?id=168626=edit The second example file opened in LO 7.1 alpha This seems to have gotten better recently in: https://cgit.freedesktop.org/libreoffice/core/commit/?id=712d7a5df188bb20527f1a7533b2e2c1d4377247 author Miklos Vajna 2020-11-16 21:07:48 +0100 committer Miklos Vajna 2020-11-17 09:03:37 +0100 tdf#137980 sw textbox: fix automatic size of shapes with rotated text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source sd/qa
filter/source/msfilter/msdffimp.cxx | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit f400e883044143f999c460375a293647b4a57244
Author: Caolán McNamara
AuthorDate: Fri Jan 1 19:17:30 2021 +
Commit: Caolán McNamara
CommitDate: Fri Jan 1 22:07:04 2021 +0100
ofz#29151 short read
Change-Id: I908d19903ff0b16f5c6a87b8aa989b6a410a7b3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108563
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index bed7bdcc283d..442509617f91 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -4183,9 +4183,11 @@ SdrObject* SvxMSDffManager::ImportShape( const
DffRecordHeader& rHd, SvStream& r
if( maShapeRecords.SeekToContent( rSt,
DFF_msofbtUDefProp ) )
{
-sal_uInt32 nBytesLeft = maShapeRecords.Current()->nRecLen;
+sal_uInt32 nBytesLeft = maShapeRecords.Current()->nRecLen;
while( 5 < nBytesLeft )
{
+if (rSt.remainingSize() < 6)
+break;
sal_uInt16 nPID(0);
rSt.ReadUInt16(nPID);
if (!rSt.good())
@@ -4199,11 +4201,11 @@ SdrObject* SvxMSDffManager::ImportShape( const
DffRecordHeader& rHd, SvStream& r
mbRotateGranientFillWithAngle = nUDData & 0x20;
break;
}
-nBytesLeft -= 6;
+nBytesLeft -= 6;
}
}
aObjData.bShapeType = maShapeRecords.SeekToContent( rSt, DFF_msofbtSp );
-if ( aObjData.bShapeType )
+if (aObjData.bShapeType && rSt.remainingSize() >= 8)
{
sal_uInt32 temp;
rSt.ReadUInt32( aObjData.nShapeId )
@@ -4247,7 +4249,7 @@ SdrObject* SvxMSDffManager::ImportShape( const
DffRecordHeader& rHd, SvStream& r
}
aObjData.bChildAnchor = maShapeRecords.SeekToContent( rSt,
DFF_msofbtChildAnchor, SEEK_FROM_CURRENT_AND_RESTART );
-if ( aObjData.bChildAnchor )
+if (aObjData.bChildAnchor && rSt.remainingSize() >= 16)
{
sal_Int32 l(0), o(0), r(0), u(0);
rSt.ReadInt32( l ).ReadInt32( o ).ReadInt32( r ).ReadInt32( u );
diff --git a/sd/qa/unit/data/ppt/fail/hang-19.ppt
b/sd/qa/unit/data/ppt/pass/hang-19.ppt
similarity index 100%
rename from sd/qa/unit/data/ppt/fail/hang-19.ppt
rename to sd/qa/unit/data/ppt/pass/hang-19.ppt
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 132000] Digit characters saved with different associated language/font when exporting DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=132000 --- Comment #8 from eladh...@gmail.com --- I agree. I think this is pretty bad and looks unprofessional. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139359] Inserting a symbol does insert lots of direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=139359 --- Comment #2 from V Stuart Foote --- Expect the amount of formatting will depend on if the symbol being inserted is found in the font assigned to the paragraph. A per os/DE font fallback is used when font replacement occurs. If replaced, the span holding the glyphs picked from the Special Symbol dialog will show as DF. Try it for a symbol that is in the font of the styled paragraph. Also, easy to see what happens if you look at the document export to ODF as Flat ODF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139325] LO writer hangs/crashes--can't access my large ODT data file
https://bugs.documentfoundation.org/show_bug.cgi?id=139325 --- Comment #13 from Hal --- Here are more facts: 1. I tried opening my large ODT file with LO 6.4.7.2 on my Win7 cpu. Writer still crashes during the attempted ODT open process. 2. I should note sometimes when Writer crashes the screen momentarily blinks totally black several times. Sometimes it remains black until I kill the running LO app. 3. Next, I tried opening the large ODT file on my Windows10 computer. LO also crashes when trying to open the same large ODT file. So it doesn't look like the operating system is the cause. :) NOTE: I didn't disable OpenGL and Skia on either CPU system. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - unotools/source
unotools/source/i18n/resmgr.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit db860f33152e477e2e781869cd9cde18536a6483 Author: Mike Kaganski AuthorDate: Mon Dec 28 19:12:03 2020 +0300 Commit: Caolán McNamara CommitDate: Fri Jan 1 21:08:00 2021 +0100 tdf#119367: use Unicode paths on Windows in unotools Change-Id: I671c42c5dfe5acc8a6dd670694c07ff04f08c3e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108477 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 02eaea1f93b516e35d4583158f87bfdd2640) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108576 Reviewed-by: Caolán McNamara diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx index a1d74ec1b7cd..ef5b83cf06bc 100644 --- a/unotools/source/i18n/resmgr.cxx +++ b/unotools/source/i18n/resmgr.cxx @@ -134,7 +134,14 @@ namespace Translate rtl::Bootstrap::expandMacros(uri); OUString path; osl::File::getSystemPathFromFileURL(uri, path); -OString sPath(OUStringToOString(path, osl_getThreadTextEncoding())); +#if defined _WIN32 +// add_messages_path is documented to treat path string in the *created* locale's encoding +// on Windows; creating an UTF-8 encoding, we're lucky to have Unicode path support here. +constexpr rtl_TextEncoding eEncoding = RTL_TEXTENCODING_UTF8; +#else +const rtl_TextEncoding eEncoding = osl_getThreadTextEncoding(); +#endif +OString sPath(OUStringToOString(path, eEncoding)); #endif gen.add_messages_path(sPath.getStr()); #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - unotools/source
unotools/source/i18n/resmgr.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit d941853f97146ce883db81dd2723f25e9fd75032 Author: Mike Kaganski AuthorDate: Mon Dec 28 19:12:03 2020 +0300 Commit: Caolán McNamara CommitDate: Fri Jan 1 20:54:47 2021 +0100 tdf#119367: use Unicode paths on Windows in unotools Change-Id: I671c42c5dfe5acc8a6dd670694c07ff04f08c3e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108477 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 02eaea1f93b516e35d4583158f87bfdd2640) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108575 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx index a1d74ec1b7cd..ef5b83cf06bc 100644 --- a/unotools/source/i18n/resmgr.cxx +++ b/unotools/source/i18n/resmgr.cxx @@ -134,7 +134,14 @@ namespace Translate rtl::Bootstrap::expandMacros(uri); OUString path; osl::File::getSystemPathFromFileURL(uri, path); -OString sPath(OUStringToOString(path, osl_getThreadTextEncoding())); +#if defined _WIN32 +// add_messages_path is documented to treat path string in the *created* locale's encoding +// on Windows; creating an UTF-8 encoding, we're lucky to have Unicode path support here. +constexpr rtl_TextEncoding eEncoding = RTL_TEXTENCODING_UTF8; +#else +const rtl_TextEncoding eEncoding = osl_getThreadTextEncoding(); +#endif +OString sPath(OUStringToOString(path, eEncoding)); #endif gen.add_messages_path(sPath.getStr()); #if defined UNX && !defined MACOSX && !defined IOS && !defined ANDROID ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139359] Inserting a symbol does insert lots of direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=139359 Telesto changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from Telesto --- @V Stuart.. Not sure if this being your area of expertise. If this being normal/expected or not. It doesn't align well with the people liking favoring styles (and probably also messy at XML level) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139359] New: Inserting a symbol does insert lots of direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=139359 Bug ID: 139359 Summary: Inserting a symbol does insert lots of direct formatting Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Inserting a symbol does insert lots of direct formatting Steps to Reproduce: 1. Open Writer 2. Sidebar -> Style Inspector 2. The the special symbol picker.. Pick say € symbol Actual Results: All sorts of DF Expected Results: Non?.. CTRL+M removes the DF without affecting the content? Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: 4e3ce9dd6ace0b22f7b3f45cf2338b201f4dc305 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/uiconfig
starmath/uiconfig/smath/ui/alignmentdialog.ui | 128 - starmath/uiconfig/smath/ui/fontdialog.ui | 176 +- starmath/uiconfig/smath/ui/fontsizedialog.ui | 375 ++--- starmath/uiconfig/smath/ui/fonttypedialog.ui | 450 +++--- starmath/uiconfig/smath/ui/printeroptions.ui | 212 +-- starmath/uiconfig/smath/ui/smathsettings.ui | 374 ++--- starmath/uiconfig/smath/ui/spacingdialog.ui | 1714 -- 7 files changed, 1634 insertions(+), 1795 deletions(-) New commits: commit 30aacb7826f39601f5729aed929997073ff4e309 Author: Caolán McNamara AuthorDate: Mon Dec 28 19:11:30 2020 + Commit: Caolán McNamara CommitDate: Fri Jan 1 20:41:26 2021 +0100 drop deprecated GtkAlignment, move left/top-padding into child margin-start/top for starmath Change-Id: Ide8aa36cda7a50b4f538dd39955acf51ef308582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108423 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/starmath/uiconfig/smath/ui/alignmentdialog.ui b/starmath/uiconfig/smath/ui/alignmentdialog.ui index 95615b62a4ea..a9555a53920c 100644 --- a/starmath/uiconfig/smath/ui/alignmentdialog.ui +++ b/starmath/uiconfig/smath/ui/alignmentdialog.ui @@ -99,86 +99,80 @@ 0 none - + True False +vertical True True -6 -12 +6 +12 +6 - + +_Left True -False -vertical -6 - - -_Left -True -True -False -True -0 -True -True - - -Aligns the selected elements of a formula to the left. - - +True +False +True +0 +True +True + + +Aligns the selected elements of a formula to the left. - -False -True -0 - - - -_Centered -True -True -False -True -0 -True -left - - -Aligns the elements of a formula to the center. - - + + +False +True +0 + + + + +_Centered +True +True +False +True +0 +True +left + + +Aligns the elements of a formula to the center. - -False -True -1 - - - -_Right -True -True -False -True -0 -True -left - - -Aligns the elements of a formula to the right. - - + + +False +True +1 + + + + +_Right +True +True +False +True +0 +True +left + + +Aligns the elements of a formula to the right. - -False -True -2 -
[Libreoffice-commits] core.git: sd/qa sfx2/source
sfx2/source/doc/oleprops.cxx |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 96ea80a725dfe4ef38993f78917c243f13e3beb5
Author: Caolán McNamara
AuthorDate: Thu Dec 31 16:29:06 2020 +
Commit: Caolán McNamara
CommitDate: Fri Jan 1 20:41:04 2021 +0100
ofz#29129 Abrt on uncaught exception
Change-Id: I249e1f6e2fcc94e5de22d1f7c7d8a0e7cc185ace
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108540
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/qa/unit/data/ppt/fail/crash-1.ppt
b/sd/qa/unit/data/ppt/pass/crash-1.ppt
similarity index 100%
rename from sd/qa/unit/data/ppt/fail/crash-1.ppt
rename to sd/qa/unit/data/ppt/pass/crash-1.ppt
diff --git a/sd/qa/unit/data/ppt/fail/hang-4.ppt
b/sd/qa/unit/data/ppt/pass/hang-4.ppt
similarity index 100%
rename from sd/qa/unit/data/ppt/fail/hang-4.ppt
rename to sd/qa/unit/data/ppt/pass/hang-4.ppt
diff --git a/sd/qa/unit/data/ppt/fail/hang-6.ppt
b/sd/qa/unit/data/ppt/pass/hang-6.ppt
similarity index 100%
rename from sd/qa/unit/data/ppt/fail/hang-6.ppt
rename to sd/qa/unit/data/ppt/pass/hang-6.ppt
diff --git a/sfx2/source/doc/oleprops.cxx b/sfx2/source/doc/oleprops.cxx
index 796ce0d5227a..621a82f6d9a5 100644
--- a/sfx2/source/doc/oleprops.cxx
+++ b/sfx2/source/doc/oleprops.cxx
@@ -941,12 +941,13 @@ void SfxOleSection::ImplLoad( SvStream& rStrm )
mnStartPos = rStrm.Tell();
sal_uInt32 nSize(0);
sal_Int32 nPropCount(0);
-rStrm.ReadUInt32( nSize ).ReadInt32( nPropCount );
+if (rStrm.remainingSize() >= 8)
+rStrm.ReadUInt32( nSize ).ReadInt32( nPropCount );
// read property ID/position pairs
typedef ::std::map< sal_Int32, sal_uInt32 > SfxOlePropPosMap;
SfxOlePropPosMap aPropPosMap;
-for (sal_Int32 nPropIdx = 0; nPropIdx < nPropCount && rStrm.good();
++nPropIdx)
+for (sal_Int32 nPropIdx = 0; nPropIdx < nPropCount && rStrm.good() &&
rStrm.remainingSize() >= 8; ++nPropIdx)
{
sal_Int32 nPropId(0);
sal_uInt32 nPropPos(0);
@@ -956,7 +957,7 @@ void SfxOleSection::ImplLoad( SvStream& rStrm )
// read codepage property
SfxOlePropPosMap::iterator aCodePageIt = aPropPosMap.find( PROPID_CODEPAGE
);
-if( (aCodePageIt != aPropPosMap.end()) && SeekToPropertyPos( rStrm,
aCodePageIt->second ) )
+if( (aCodePageIt != aPropPosMap.end()) && SeekToPropertyPos(rStrm,
aCodePageIt->second) && rStrm.remainingSize() >= 4)
{
// codepage property must be of type signed int-16
sal_Int32 nPropType(0);
@@ -972,7 +973,7 @@ void SfxOleSection::ImplLoad( SvStream& rStrm )
if( (aDictIt != aPropPosMap.end()) && SeekToPropertyPos( rStrm,
aDictIt->second ) )
{
// #i66214# #i66428# applications may write broken dictionary
properties in wrong sections
-if( mbSupportsDict )
+if (mbSupportsDict && rStrm.remainingSize() >= 4)
{
// dictionary property contains number of pairs in property type
field
sal_Int32 nNameCount(0);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
