date:20210302

[Libreoffice-bugs] [Bug 140768] Scaling quality of images degraded since tdf#138068

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140768

--- Comment #2 from Telesto  ---
Bug 138684 (import) might be related.. Some other issues at the export side bug
140465 (export/ bug 125970 (export)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138771] CRASH: importing specific document

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138771

--- Comment #9 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b072e279f5f775a4cd64d9b1275e5ab17d50f05

tdf138771: sw_ooxmlexport16: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138771] CRASH: importing specific document

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138771

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

2021-03-02 Thread Xisco Fauli (via logerrit)

 sw/qa/extras/ooxmlexport/data/tdf138771.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport16.cxx   |6 ++
 2 files changed, 6 insertions(+)

New commits:
commit 0b072e279f5f775a4cd64d9b1275e5ab17d50f05
Author: Xisco Fauli 
AuthorDate: Tue Mar 2 15:26:14 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Mar 3 08:53:06 2021 +0100

tdf138771: sw_ooxmlexport16: Add unittest

Change-Id: Ia1d2020b621233231f63bd5bbaacb5e75b38b48f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111836
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf138771.docx 
b/sw/qa/extras/ooxmlexport/data/tdf138771.docx
new file mode 100644
index ..70b035508bb2
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf138771.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
index f53078d6a332..b7af0c5e69b2 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
@@ -84,6 +84,12 @@ DECLARE_OOXMLEXPORT_TEST(testTdf140668, "tdf140668.docx")
 CPPUNIT_ASSERT_EQUAL(1, getPages());
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf138771, "tdf138771.docx")
+{
+// Don't crash when document is imported
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
 DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf134619_numberingProps, 
"tdf134619_numberingProps.doc")
 {
 // Get the third paragraph's numbering style's 1st level's bullet size
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-0' - sc/qa sc/source

2021-03-02 Thread Tibor Nagy (via logerrit)

 sc/qa/unit/data/xlsx/tdf139021.xlsx   |binary
 sc/qa/unit/subsequent_export-test.cxx |   36 +
 sc/source/filter/excel/xeextlst.cxx   |   89 --
 3 files changed, 120 insertions(+), 5 deletions(-)

New commits:
commit 390adf01b9fe313c73908680ac8b6fa627b91602
Author: Tibor Nagy 
AuthorDate: Sat Dec 19 22:25:08 2020 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 3 08:50:47 2021 +0100

tdf#139021 XLSX export: fix "contains" conditional formatting

when using "Given text" type with cell reference instead of
fixed string.

Note: fix also "notContainsText", and prepare the fix for
"beginsWith", "endsWith" and "expression" type conditions.

Follow-up of commit 0101975f8eac650bb87c4af81157cb33a6309e0e
(tdf#122102 XLSX import: fix "contains" conditional formatting).

Co-authored-by: Attila Szűcs (NISZ)

Change-Id: I46d80946f2b6cfaa2a9fe2438fae20e8aa9d50f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108035
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit 583e2bfba2d72ac8afe7261c23f380daf5486889)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108695
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit 9ffc483be4ca49c436406a93690044459e880a9d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111873
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/sc/qa/unit/data/xlsx/tdf139021.xlsx 
b/sc/qa/unit/data/xlsx/tdf139021.xlsx
new file mode 100644
index ..f420b7c150d2
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf139021.xlsx differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 3010bac88ead..158f1f1a2959 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -93,6 +93,7 @@ public:
 ScDocShellRef saveAndReloadPassword( ScDocShell*, const OUString&, const 
OUString&, const OUString&, SfxFilterFlags );
 
 void test();
+void testExtCondFormatXLSX();
 void testTdf90104();
 void testTdf111876();
 void testPasswordExportODS();
@@ -276,6 +277,7 @@ public:
 
 CPPUNIT_TEST_SUITE(ScExportTest);
 CPPUNIT_TEST(test);
+CPPUNIT_TEST(testExtCondFormatXLSX);
 CPPUNIT_TEST(testTdf90104);
 CPPUNIT_TEST(testTdf111876);
 CPPUNIT_TEST(testPasswordExportODS);
@@ -542,6 +544,40 @@ void ScExportTest::test()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testExtCondFormatXLSX()
+{
+ScDocShellRef xShell = loadDoc("tdf139021.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xShell.is());
+
+ScDocShellRef xDocSh = saveAndReload(&(*xShell), FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+std::shared_ptr pXPathFile = 
ScBootstrapFixture::exportTo(&(*xDocSh), FORMAT_XLSX);
+xmlDocUniquePtr pDoc = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/worksheets/sheet1.xml");
+CPPUNIT_ASSERT(pDoc);
+
+assertXPath(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[1]/"
+"x14:cfRule", "type", "containsText");
+assertXPathContent(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[1]/"
+"x14:cfRule/xm:f[1]", "NOT(ISERROR(SEARCH($B$1,A1)))");
+assertXPathContent(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[1]/"
+"x14:cfRule/xm:f[2]", "$B$1");
+assertXPath(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[2]/"
+"x14:cfRule", "type", "notContainsText");
+assertXPathContent(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[2]/"
+"x14:cfRule/xm:f[1]", "ISERROR(SEARCH($B$2,A2))");
+assertXPathContent(pDoc,
+
"/x:worksheet/x:extLst/x:ext/x14:conditionalFormattings/x14:conditionalFormatting[2]/"
+"x14:cfRule/xm:f[2]", "$B$2");
+
+xDocSh->DoClose();
+}
+
 void ScExportTest::testTdf90104()
 {
 ScDocShellRef xShell = loadDoc("tdf90104.", FORMAT_XLSX);
diff --git a/sc/source/filter/excel/xeextlst.cxx 
b/sc/source/filter/excel/xeextlst.cxx
index 35d2fac152d7..f4a385088d8b 100644
--- a/sc/source/filter/excel/xeextlst.cxx
+++ b/sc/source/filter/excel/xeextlst.cxx
@@ -149,6 +149,48 @@ XclExpExtCF::XclExpExtCF( const XclExpRoot& rRoot, const 
ScCondFormatEntry& rFor
 {
 }
 
+namespace {
+
+bool RequiresFixedFormula(ScConditionMode eMode)
+{
+switch (eMode)
+{
+case ScConditionMode::BeginsWith:
+case ScConditionMode::EndsWith:
+case ScConditionMode::ContainsText:
+case ScConditionMode::NotContainsText:
+return true;
+default:
+break;
+}
+
+return false;
+}
+
+OString GetFixedFormula(ScConditionMode

[Libreoffice-commits] core.git: vcl/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 vcl/source/font/font.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit a9f82c7c6ac645dd9263b435dbc7695951a70098
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 11:16:47 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:50:37 2021 +0100

Remove unused include

...introduced with 16901e4ccad95d55d4ae0fa2d6f6103b4177592e "Simplify static
string generation" for std::iota, which in turn was removed again with
ccb101abd46e1d632d18b30226a6bffed7a66381 "call to consteval function is not 
a
constant expression (HAVE_CPP_CONSTEVAL)"

Change-Id: Id923f32c853f51971fa3f70f003ac1e411cb8a5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111818
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx
index 3996eec947ef..d79658894a5b 100644
--- a/vcl/source/font/font.cxx
+++ b/vcl/source/font/font.cxx
@@ -33,7 +33,6 @@
 #include 
 
 #include 
-#include 
 #include 
 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 connectivity/source/drivers/ado/ADriver.cxx |8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit d203cf7ee45b54bd505704dc798ff04b5dac1592
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 10:52:47 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:50:10 2021 +0100

loplugin:refcounting (clang-cl)

Change-Id: I400ef428921573ae345de15e94695e98f0b02a92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111813
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/drivers/ado/ADriver.cxx 
b/connectivity/source/drivers/ado/ADriver.cxx
index 6940c7ea6ecd..610f7722c697 100644
--- a/connectivity/source/drivers/ado/ADriver.cxx
+++ b/connectivity/source/drivers/ado/ADriver.cxx
@@ -27,13 +27,12 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
 #include 
 
-#include 
-
 using namespace connectivity;
 using namespace connectivity::ado;
 using namespace com::sun::star::uno;
@@ -94,13 +93,12 @@ Reference< XConnection > SAL_CALL ODriver::connect( const 
OUString& url, const S
 return nullptr;
 
 // we need to wrap the connection as the construct call might throw
-std::unique_ptr pCon(new OConnection(this));
+rtl::Reference pCon(new OConnection(this));
 pCon->construct(url,info);
 OConnection* pPtr = pCon.get();
-Reference< XConnection > xCon = pCon.release();
 m_xConnections.push_back(WeakReferenceHelper(*pPtr));
 
-return xCon;
+return pCon;
 }
 
 sal_Bool SAL_CALL ODriver::acceptsURL( const OUString& url )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: embeddedobj/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 embeddedobj/source/inc/oleembobj.hxx  |6 +++---
 embeddedobj/source/msole/olecomponent.cxx |2 +-
 embeddedobj/source/msole/olecomponent.hxx |4 ++--
 embeddedobj/source/msole/olemisc.cxx  |   20 +++-
 embeddedobj/source/msole/olepersist.cxx   |   12 ++--
 5 files changed, 19 insertions(+), 25 deletions(-)

New commits:
commit 097fcd045e99edcf418e8b34ccb6d6b0b8b8de4b
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 10:51:50 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:49:48 2021 +0100

loplugin:refcounting (clang-cl)

Change-Id: Ifa54eed0a772b658d266e9e42be5f5232e7a6b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111812
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/embeddedobj/source/inc/oleembobj.hxx 
b/embeddedobj/source/inc/oleembobj.hxx
index a4cc71c0f8d8..bc75a5af9c4c 100644
--- a/embeddedobj/source/inc/oleembobj.hxx
+++ b/embeddedobj/source/inc/oleembobj.hxx
@@ -120,7 +120,7 @@ class OleEmbeddedObject : public ::cppu::WeakImplHelper
 
 ::osl::Mutexm_aMutex;
 
-OleComponent*   m_pOleComponent;
+rtl::Reference m_pOleComponent;
 
 std::unique_ptr<::cppu::OMultiTypeInterfaceContainerHelper> 
m_pInterfaceContainer;
 
@@ -274,8 +274,8 @@ protected:
 #ifdef _WIN32
 bool SaveObject_Impl();
 bool OnShowWindow_Impl( bool bShow );
-void CreateOleComponent_Impl( OleComponent* pOleComponent = nullptr );
-void CreateOleComponentAndLoad_Impl( OleComponent* pOleComponent = nullptr 
);
+void CreateOleComponent_Impl( rtl::Reference const & 
pOleComponent = {} );
+void CreateOleComponentAndLoad_Impl( rtl::Reference const & 
pOleComponent = {} );
 void CreateOleComponentFromClipboard_Impl( OleComponent* pOleComponent = 
nullptr );
 OUString CreateTempURLEmpty_Impl();
 OUString GetTempURL_Impl();
diff --git a/embeddedobj/source/msole/olecomponent.cxx 
b/embeddedobj/source/msole/olecomponent.cxx
index 4a123d5ca0ab..9fe827bb00d9 100644
--- a/embeddedobj/source/msole/olecomponent.cxx
+++ b/embeddedobj/source/msole/olecomponent.cxx
@@ -881,7 +881,7 @@ void OleComponent::CreateLinkFromFile( const OUString& 
aFileURL )
 }
 
 
-void OleComponent::InitEmbeddedCopyOfLink( OleComponent const * 
pOleLinkComponent )
+void OleComponent::InitEmbeddedCopyOfLink( rtl::Reference const 
& pOleLinkComponent )
 {
 if ( !pOleLinkComponent || !pOleLinkComponent->m_pNativeImpl->m_pObj )
 throw lang::IllegalArgumentException(); // TODO
diff --git a/embeddedobj/source/msole/olecomponent.hxx 
b/embeddedobj/source/msole/olecomponent.hxx
index 3ff53291c01f..63547c321adc 100644
--- a/embeddedobj/source/msole/olecomponent.hxx
+++ b/embeddedobj/source/msole/olecomponent.hxx
@@ -32,7 +32,7 @@
 #include 
 #include 
 #include 
-
+#include 
 
 namespace cppu {
 class OMultiTypeInterfaceContainerHelper;
@@ -103,7 +103,7 @@ public:
 const css::uno::Reference< 
css::datatransfer::XTransferable >& xTransfer );
 void CreateObjectFromFile( const OUString& aFileName );
 void CreateLinkFromFile( const OUString& aFileName );
-void InitEmbeddedCopyOfLink( OleComponent const * pOleLinkComponent );
+void InitEmbeddedCopyOfLink( rtl::Reference const & 
pOleLinkComponent );
 
 
 void RunObject(); // switch OLE object to running state
diff --git a/embeddedobj/source/msole/olemisc.cxx 
b/embeddedobj/source/msole/olemisc.cxx
index 90041729d03d..f85c845e31a8 100644
--- a/embeddedobj/source/msole/olemisc.cxx
+++ b/embeddedobj/source/msole/olemisc.cxx
@@ -36,9 +36,7 @@
 
 #include "ownview.hxx"
 
-#if defined(_WIN32)
 #include "olecomponent.hxx"
-#endif
 
 using namespace ::com::sun::star;
 
@@ -46,8 +44,7 @@ using namespace ::com::sun::star;
 OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< 
uno::XComponentContext >& xContext,
   const uno::Sequence< sal_Int8 >& 
aClassID,
   const OUString& aClassName )
-: m_pOleComponent( nullptr )
-, m_bReadOnly( false )
+: m_bReadOnly( false )
 , m_bDisposed( false )
 , m_nObjectState( -1 )
 , m_nTargetState( -1 )
@@ -78,8 +75,7 @@ OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< 
uno::XComponentConte
 // In case of loading from persistent entry the classID of the object
 // will be retrieved from the entry, during construction it is unknown
 OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< 
uno::XComponentContext >& xContext, bool bLink )
-: m_pOleComponent( nullptr )
-, m_bReadOnly( false )
+: m_bReadOnly( false )
 , m_bDisposed( false )
 , m_nObjectState( -1 )
 , m_nTargetState( -1 )
@@ -107,8 +103,7 @@ OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< 
uno::XComponentConte
 
 // this constructor let object be initialized from clipboard
 OleEmbeddedObject::OleEmbeddedObject( const uno::Reference< 
uno::XComponentContext >& xContext )
-: m_pOleComponent( nullptr )
-, m_bReadOnly( false )
+:

[Libreoffice-bugs] [Bug 138684] Pasting SVG bitmap/GDI paste quality worsened (even more) since 7.0/7.1 (affecting also DOCX export)

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138684

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0768

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140768] Scaling quality of images degraded since tdf#138068

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140768

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||8684

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: canvas/source connectivity/source winaccessibility/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 canvas/source/directx/dx_spritehelper.cxx   |2 +-
 canvas/source/directx/dx_textlayout.cxx |6 +++---
 connectivity/source/drivers/ado/ADriver.cxx |2 +-
 winaccessibility/source/service/AccObjectWinManager.cxx |2 +-
 winaccessibility/source/service/msaaservice_impl.cxx|2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 31693833dc832228c3821f83e045b6869ec22cf2
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 10:48:52 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:48:55 2021 +0100

loplugin:referencecasting (clang-cl)

Change-Id: If32c6f6d3618c134cfb2ac89e827491525c34687
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111811
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/canvas/source/directx/dx_spritehelper.cxx 
b/canvas/source/directx/dx_spritehelper.cxx
index 8f436283387c..135c59e3e1f6 100644
--- a/canvas/source/directx/dx_spritehelper.cxx
+++ b/canvas/source/directx/dx_spritehelper.cxx
@@ -67,7 +67,7 @@ namespace dxcanvas
 
 // also init base class
 CanvasCustomSpriteHelper::init( rSpriteSize,
-rSpriteCanvas.get() );
+rSpriteCanvas );
 }
 
 void SpriteHelper::disposing()
diff --git a/canvas/source/directx/dx_textlayout.cxx 
b/canvas/source/directx/dx_textlayout.cxx
index 5e69f70df624..452b0d48e79c 100644
--- a/canvas/source/directx/dx_textlayout.cxx
+++ b/canvas/source/directx/dx_textlayout.cxx
@@ -105,7 +105,7 @@ namespace dxcanvas
 aDrawHelper.queryTextBounds(
 maText,
 maLogicalAdvancements,
-mpFont.get(),
+mpFont,
 mpFont->getFontMatrix()));
 
 return aBounds;
@@ -176,7 +176,7 @@ namespace dxcanvas
 {
 ::osl::MutexGuard aGuard( m_aMutex );
 
-return mpFont.get();
+return mpFont;
 }
 
 rendering::StringContext SAL_CALL TextLayout::getText(  )
@@ -205,7 +205,7 @@ namespace dxcanvas
 rOutputOffset,
 maText,
 maLogicalAdvancements,
-mpFont.get(),
+mpFont,
 mpFont->getFontMatrix(),
 bAlphaSurface,
 mnTextDirection != 0);
diff --git a/connectivity/source/drivers/ado/ADriver.cxx 
b/connectivity/source/drivers/ado/ADriver.cxx
index ee4ec27b6f05..6940c7ea6ecd 100644
--- a/connectivity/source/drivers/ado/ADriver.cxx
+++ b/connectivity/source/drivers/ado/ADriver.cxx
@@ -180,7 +180,7 @@ Reference< XTablesSupplier > SAL_CALL 
ODriver::getDataDefinitionByConnection( co
 
 auto foundConnection = std::any_of(m_xConnections.begin(), 
m_xConnections.end(),
 [](const css::uno::WeakReferenceHelper& 
rxConnection) {
-return static_cast(Reference< XConnection 
>::query(rxConnection.get().get()).get()) == pSearchConnection; });
+return static_cast(Reference< XConnection 
>::query(rxConnection.get()).get()) == pSearchConnection; });
 if (foundConnection)
 pConnection = pSearchConnection;
 }
diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx 
b/winaccessibility/source/service/AccObjectWinManager.cxx
index 1e74be1d0369..4022a700eca1 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -721,7 +721,7 @@ bool AccObjectWinManager::InsertAccObj( XAccessible* 
pXAcc,XAccessible* pParentX
 Reference broadcaster(xComponent,UNO_QUERY);
 if (broadcaster.is())
 {
-Reference const xListener(pListener.get());
+Reference const xListener(pListener);
 broadcaster->addAccessibleEventListener(xListener);
 }
 else
diff --git a/winaccessibility/source/service/msaaservice_impl.cxx 
b/winaccessibility/source/service/msaaservice_impl.cxx
index be9fd22ba58e..13f10a6d7d74 100644
--- a/winaccessibility/source/service/msaaservice_impl.cxx
+++ b/winaccessibility/source/service/msaaservice_impl.cxx
@@ -235,7 +235,7 @@ MSAAServiceImpl::MSAAServiceImpl()
 if( xToolkit.is() )
 {
 m_pTopWindowListener.set(new AccTopWindowListener());
-Reference const xRef(m_pTopWindowListener.get());
+Reference const xRef(m_pTopWindowListener);
 xToolkit->addTopWindowListener( xRef );
 SAL_INFO( "iacc2", "successfully connected to the toolkit event hose" 
);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 svx/source/tbxctrls/StylesPreviewWindow.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c2d1d20927af6f265080f041a9aba04733be26fb
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 10:41:47 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:48:27 2021 +0100

loplugin:loopvartoosmall (clang-cl)

"loop index type 'unsigned long' is narrower than length type
'std::vector>::size_type' (aka 
'unsigned
long long')"

Change-Id: I715cb27367c957bebe218371d3813758e4988759
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111809
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/svx/source/tbxctrls/StylesPreviewWindow.cxx 
b/svx/source/tbxctrls/StylesPreviewWindow.cxx
index af151d19a139..f392c2fc90de 100644
--- a/svx/source/tbxctrls/StylesPreviewWindow.cxx
+++ b/svx/source/tbxctrls/StylesPreviewWindow.cxx
@@ -398,7 +398,7 @@ void StylesPreviewWindow_Base::Update()
 {
 UpdateStylesList();
 
-for (unsigned long i = 0; i < m_aAllStyles.size(); ++i)
+for (std::vector>::size_type i = 0; i < 
m_aAllStyles.size(); ++i)
 {
 if (m_aAllStyles[i].first == m_sSelectedStyle || 
m_aAllStyles[i].second == m_sSelectedStyle)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qa

2021-03-02 Thread Stephan Bergmann (via logerrit)

 vcl/qa/cppunit/BackendTest.cxx   |   15 +--
 vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx |   11 +++
 vcl/qa/cppunit/outdev.cxx|6 +++---
 3 files changed, 19 insertions(+), 13 deletions(-)

New commits:
commit 06d918dcc47ae3f1c511cbdccfeacc8adb123f28
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 13:39:00 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:47:56 2021 +0100

loplugin:unreffun (macOS)

...after 0c36f364b14aacd0eeb53087ae2fce54402dc741 "tdf#138122 Detect window
scaling for multi display configurations on macOS"

Change-Id: I89daad37f5911c18c5424ab3d0e0f484ebc3bb58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111829
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/qa/cppunit/BackendTest.cxx b/vcl/qa/cppunit/BackendTest.cxx
index 018541aa40ab..734d255272c2 100644
--- a/vcl/qa/cppunit/BackendTest.cxx
+++ b/vcl/qa/cppunit/BackendTest.cxx
@@ -708,6 +708,8 @@ public:
 // Test SalGraphics::blendBitmap() and blendAlphaBitmap() calls.
 void testDrawBlendExtended()
 {
+// TODO: This unit test is not executed for macOS unless bitmap scaling is 
implemented
+#ifndef MACOSX
 // Create virtual device with alpha.
 ScopedVclPtr device
 = VclPtr::Create(DeviceFormat::DEFAULT, 
DeviceFormat::DEFAULT);
@@ -753,10 +755,13 @@ public:
 exportDevice("/tmp/blend_extended_04.png", device);
 CPPUNIT_ASSERT_EQUAL(COL_BLUE, device->GetPixel(Point(2, 2)));
 CPPUNIT_ASSERT_EQUAL(COL_WHITE, device->GetPixel(Point(6, 6)));
+#endif
 }
 
 void testDrawAlphaBitmapMirrored()
 {
+// TODO: This unit test is not executed for macOS unless bitmap scaling is 
implemented
+#ifndef MACOSX
 // Normal virtual device.
 ScopedVclPtr device = 
VclPtr::Create(DeviceFormat::DEFAULT);
 // Virtual device with alpha.
@@ -811,10 +816,13 @@ public:
 CPPUNIT_ASSERT_EQUAL(COL_RED, alphaDevice->GetPixel(Point(2, 2)));
 CPPUNIT_ASSERT_EQUAL(COL_BLUE, alphaDevice->GetPixel(Point(3, 2)));
 alphaDevice->Erase();
+#endif
 }
 
 void testTdf124848()
 {
+// TODO: This unit test is not executed for macOS unless bitmap scaling is 
implemented
+#ifndef MACOSX
 ScopedVclPtr device = 
VclPtr::Create(DeviceFormat::DEFAULT);
 device->SetOutputSizePixel(Size(100, 100));
 device->SetBackground(Wallpaper(COL_WHITE));
@@ -843,6 +851,7 @@ public:
 CPPUNIT_ASSERT_EQUAL(COL_BLACK, device->GetPixel(Point(50, 20)));
 CPPUNIT_ASSERT_EQUAL(COL_WHITE, device->GetPixel(Point(49, 20)));
 CPPUNIT_ASSERT_EQUAL(COL_WHITE, device->GetPixel(Point(51, 20)));
+#endif
 }
 
 void testTdf136171()
@@ -934,16 +943,10 @@ public:
 CPPUNIT_TEST(testRadialGradient);
 CPPUNIT_TEST(testRadialGradientOfs);
 
-// TODO: Following unit tests are not executed for macOS unless bitmap scaling 
is implemented
-#ifndef MACOSX
 CPPUNIT_TEST(testDrawBlendExtended);
 CPPUNIT_TEST(testDrawAlphaBitmapMirrored);
-#endif
 
-// TODO: Following unit test is not executed for macOS unless bitmap scaling 
is implemented
-#ifndef MACOSX
 CPPUNIT_TEST(testTdf124848);
-#endif
 CPPUNIT_TEST(testTdf136171);
 
 CPPUNIT_TEST_SUITE_END();
diff --git a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx 
b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
index 127c0201bd78..cdb8e4c39fd7 100644
--- a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
+++ b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
@@ -50,11 +50,8 @@ public:
 CPPUNIT_TEST(testTdf104141);
 CPPUNIT_TEST(testTdf113918);
 
-// TODO: Following unit tests are not executed for macOS unless bitmap scaling 
is implemented
-#ifndef MACOSX
 CPPUNIT_TEST(testDrawAlphaBitmapEx);
 CPPUNIT_TEST(testAlphaVirtualDevice);
-#endif
 CPPUNIT_TEST(testTdf116888);
 
 CPPUNIT_TEST_SUITE_END();
@@ -110,7 +107,7 @@ void BitmapRenderTest::testTdf113918()
 CPPUNIT_ASSERT(aColor.GetGreen() > 100);
 }
 
-#if defined(_WIN32) || defined(MACOSX) || defined(IOS)
+#if defined(_WIN32) || defined(IOS)
 
 namespace
 {
@@ -128,6 +125,8 @@ int deltaColor(BitmapColor aColor1, BitmapColor aColor2)
 
 void BitmapRenderTest::testDrawAlphaBitmapEx()
 {
+// TODO: This unit test is not executed for macOS unless bitmap scaling is 
implemented
+#ifndef MACOSX
 ScopedVclPtrInstance pVDev;
 pVDev->SetOutputSizePixel(Size(8, 8));
 pVDev->SetBackground(Wallpaper(COL_WHITE));
@@ -175,10 +174,13 @@ void BitmapRenderTest::testDrawAlphaBitmapEx()
 #else
 CPPUNIT_ASSERT_EQUAL(Color(0x7F, 0xFF, 0x7F), pVDev->GetPixel(Point(2, 
2)));
 #endif
+#endif
 }
 
 void BitmapRenderTest::testAlphaVirtualDevice()
 {
+// TODO: This unit test is not executed for macOS unless bitmap scaling is 
implemented
+#ifndef MACOSX
 // Create an alpha virtual device
 ScopedVclPtr 
pAlphaVirtualDevice(VclPtr::Create(

[Libreoffice-commits] core.git: lingucomponent/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 670df8db5cbb2a9cac46a8602b95192a02fa3e2c
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 13:42:21 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Mar 3 08:47:37 2021 +0100

loplugin:refcounting (macOS)

Change-Id: Id68d9c9733738595aeb4bad24d77f77da2878e83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111830
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm 
b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
index 74b365c71746..cba8dae08094 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 using namespace utl;
@@ -486,7 +487,7 @@ Reference< XSpellAlternatives >
 }
 
 // now return an empty alternative for no suggestions or the list of 
alternatives if some found
-SpellAlternatives *pAlt = new SpellAlternatives;
+rtl::Reference pAlt = new SpellAlternatives;
 pAlt->SetWordLanguage( rWord, nLang );
 pAlt->SetFailureType( SpellFailure::SPELLING_ERROR );
 pAlt->SetAlternatives( aStr );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 140768] Scaling quality of images degraded since tdf#138068

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140768

--- Comment #1 from Tomaz Vajngerl  ---
Created attachment 170191
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170191=edit
Scaling in LO 7.0 and now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

2021-03-02 Thread mert (via logerrit)

 svx/source/svdraw/svdmrkv.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit b4adac8edd0f89a83905a567ba6c13e3ba18838b
Author: mert 
AuthorDate: Wed Feb 24 06:22:49 2021 +0300
Commit: Mert Tumer 
CommitDate: Wed Mar 3 08:42:38 2021 +0100

Fix chart sub element rectangle and handle positions

Change-Id: I486b542ae0bb4a987c98d92c1866895eafcf620c
Signed-off-by: mert 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111440
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111516
Tested-by: Jenkins

diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 8c1ec40dce92..216d2c043709 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -689,7 +689,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 
 tools::Rectangle aSelection(rRect);
 bool bIsChart = false;
-
+Point addLogicOffset(0, 0);
 if (!rRect.IsEmpty())
 {
 sal_uInt32 nTotalPaintWindows = this->PaintWindowCount();
@@ -704,6 +704,7 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 {
 Point aOffsetPx = 
pWin->GetOffsetPixelFrom(*pViewShellWindow);
 Point aLogicOffset = pWin->PixelToLogic(aOffsetPx);
+addLogicOffset = aLogicOffset;
 aSelection.Move(aLogicOffset.getX(), aLogicOffset.getY());
 }
 }
@@ -858,8 +859,6 @@ void SdrMarkView::SetMarkHandlesForLOKit(tools::Rectangle 
const & rRect, const S
 }
 sPolygonElem += R"elem(\" 
style=\"stroke: none; fill: rgb(114,159,207); fill-opacity: 0.8\"/>)elem";
 
-aSelection = 
OutputDevice::LogicToLogic(aSelection, MapMode(MapUnit::MapTwip), 
MapMode(MapUnit::Map100thMM));
-
 OString sSVGElem = R"elem((pHdl->GetPointer()));
 Point pHdlPos = pHdl->GetPos();
+pHdlPos.Move(addLogicOffset.getX(), addLogicOffset.getY());
 if (convertMapMode)
 pHdlPos = OutputDevice::LogicToLogic(pHdlPos, 
MapMode(MapUnit::Map100thMM), MapMode(MapUnit::MapTwip));
 point.put("x", pHdlPos.getX());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

2021-03-02 Thread mert (via logerrit)

 sfx2/source/view/lokhelper.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit a434f5d2d4ff4991937b57e521782ad3594aa370
Author: mert 
AuthorDate: Mon Feb 22 11:17:27 2021 +0300
Commit: Mert Tumer 
CommitDate: Wed Mar 3 08:42:09 2021 +0100

Fix non-valid json generation on NotifyOtherViews

Change-Id: I82aa0aefcd1de14b4c1bb2bbe3f087b60d691beb
Signed-off-by: mert 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111299
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111515
Tested-by: Jenkins

diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index cdd6030a7c8f..2a5ea882d92d 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -308,7 +308,11 @@ void SfxLokHelper::setDeviceFormFactor(std::u16string_view 
rDeviceFormFactor)
 g_deviceFormFactor = LOKDeviceFormFactor::UNKNOWN;
 }
 
-static OString lcl_escapeQuotes(const OString )
+/*
+* Used for putting a whole JSON string into a string value
+* e.g { key: "{JSON}" }
+*/
+static OString lcl_sanitizeJSONAsValue(const OString )
 {
 if (rStr.getLength() < 1)
 return rStr;
@@ -318,7 +322,9 @@ static OString lcl_escapeQuotes(const OString )
 {
 if (rStr[i] == '"' || rStr[i] == '\\')
 aBuf.append('\\');
-aBuf.append(rStr[i]);
+
+if (rStr[i] != '\n')
+aBuf.append(rStr[i]);
 }
 return aBuf.makeStringAndClear();
 }
@@ -341,7 +347,7 @@ static inline OString lcl_generateJSON(const SfxViewShell* 
pView, std::string_vi
 assert(pView != nullptr && "pView must be valid");
 return OStringLiteral("{ \"viewId\": \"") + 
OString::number(SfxLokHelper::getView(pView))
+ "\", \"part\": \"" + OString::number(pView->getPart()) + "\", \"" 
+ rKey + "\": \""
-   + lcl_escapeQuotes(rPayload) + "\" }";
+   + lcl_sanitizeJSONAsValue(rPayload) + "\" }";
 }
 
 void SfxLokHelper::notifyOtherView(const SfxViewShell* pThisView, SfxViewShell 
const* pOtherView,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-0' - sc/qa sc/source

2021-03-02 Thread Tibor Nagy (via logerrit)

 sc/qa/unit/data/xlsx/tdf120749.xlsx|binary
 sc/qa/unit/subsequent_filters-test.cxx |   38 +
 sc/source/filter/inc/extlstcontext.hxx |1 
 sc/source/filter/oox/extlstcontext.cxx |   33 +++-
 4 files changed, 71 insertions(+), 1 deletion(-)

New commits:
commit dfe64f1a4cafb5afa8fa00e4901a65f1fa92c77c
Author: Tibor Nagy 
AuthorDate: Sun Dec 20 19:45:50 2020 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 3 08:38:39 2021 +0100

tdf#120749 XLSX: fix "begins/ends with" conditional

formatting when using "Given text" type and cell reference.

Follow-up of commit 583e2bfba2d72ac8afe7261c23f380daf5486889
(tdf#139021 XLSX export: fix "contains" conditional formatting).

Co-authored-by: Attila Szűcs (NISZ)

Change-Id: Idf5d46469765454a11311bd6ec1d85c85b89e26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108058
Tested-by: László Németh 
Reviewed-by: László Németh 
(cherry picked from commit 879ea123514ce6808212dfbef7e1d226e9d5fd9b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108592
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit 75596e1254f284fca22efc8e6cba158bd6c50b15)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111872
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/sc/qa/unit/data/xlsx/tdf120749.xlsx 
b/sc/qa/unit/data/xlsx/tdf120749.xlsx
new file mode 100644
index ..de601234d3be
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf120749.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 66c092276e3d..5f7dcf412d9e 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -106,6 +106,7 @@ public:
 virtual void tearDown() override;
 
 //ods, xls, xlsx filter tests
+void testCondFormatBeginsAndEndsWithXLSX();
 void testExtCondFormatXLSX();
 void testUpdateCircleInMergedCellODS();
 void testDeleteCircleInMergedCellODS();
@@ -276,6 +277,7 @@ public:
 void testDeleteCirclesInRowAndCol();
 
 CPPUNIT_TEST_SUITE(ScFiltersTest);
+CPPUNIT_TEST(testCondFormatBeginsAndEndsWithXLSX);
 CPPUNIT_TEST(testExtCondFormatXLSX);
 CPPUNIT_TEST(testUpdateCircleInMergedCellODS);
 CPPUNIT_TEST(testDeleteCircleInMergedCellODS);
@@ -490,6 +492,42 @@ void testRangeNameImpl(const ScDocument& rDoc)
 
 }
 
+void ScFiltersTest::testCondFormatBeginsAndEndsWithXLSX()
+{
+ScDocShellRef xDocSh = loadDoc("tdf120749.", FORMAT_XLSX);
+CPPUNIT_ASSERT_MESSAGE("Failed to load tdf120749.xlsx", xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// begins with and ends with conditions
+ScConditionalFormat* pFormatA1 = rDoc.GetCondFormat(0, 0, 0);
+CPPUNIT_ASSERT(pFormatA1);
+ScConditionalFormat* pFormatA2 = rDoc.GetCondFormat(0, 1, 0);
+CPPUNIT_ASSERT(pFormatA2);
+ScConditionalFormat* pFormatA3 = rDoc.GetCondFormat(0, 2, 0);
+CPPUNIT_ASSERT(pFormatA3);
+ScConditionalFormat* pFormatA4 = rDoc.GetCondFormat(0, 3, 0);
+CPPUNIT_ASSERT(pFormatA4);
+
+ScRefCellValue aCellA1(rDoc, ScAddress(0, 0, 0));
+OUString aCellStyleA1 = pFormatA1->GetCellStyle(aCellA1, ScAddress(0, 0, 
0));
+CPPUNIT_ASSERT(!aCellStyleA1.isEmpty());
+
+ScRefCellValue aCellA2(rDoc, ScAddress(0, 1, 0));
+OUString aCellStyleA2 = pFormatA2->GetCellStyle(aCellA2, ScAddress(0, 1, 
0));
+CPPUNIT_ASSERT(!aCellStyleA2.isEmpty());
+
+ScRefCellValue aCellA3(rDoc, ScAddress(0, 2, 0));
+OUString aCellStyleA3 = pFormatA3->GetCellStyle(aCellA3, ScAddress(0, 2, 
0));
+CPPUNIT_ASSERT(!aCellStyleA3.isEmpty());
+
+ScRefCellValue aCellA4(rDoc, ScAddress(0, 3, 0));
+OUString aCellStyleA4 = pFormatA4->GetCellStyle(aCellA4, ScAddress(0, 3, 
0));
+CPPUNIT_ASSERT(!aCellStyleA4.isEmpty());
+
+xDocSh->DoClose();
+}
+
 void ScFiltersTest::testExtCondFormatXLSX()
 {
 ScDocShellRef xDocSh = loadDoc("tdf122102.", FORMAT_XLSX);
diff --git a/sc/source/filter/inc/extlstcontext.hxx 
b/sc/source/filter/inc/extlstcontext.hxx
index 4c7b697299e8..8e4f3e5278b8 100644
--- a/sc/source/filter/inc/extlstcontext.hxx
+++ b/sc/source/filter/inc/extlstcontext.hxx
@@ -52,6 +52,7 @@ public:
 virtual void onEndElement() override;
 
 private:
+sal_Int32 nFormulaCount;
 OUString aChars; // Characters of between xml elements.
 OUString rStyle; // Style of the corresponding condition
 sal_Int32 nPriority; // Priority of last cfRule element.
diff --git a/sc/source/filter/oox/extlstcontext.cxx 
b/sc/source/filter/oox/extlstcontext.cxx
index 0a694e00fd2d..2f0c6c475c9a 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -80,8 +80,26 @@ void ExtCfRuleContext::onStartElement( const AttributeList& 
rAttribs )
 }
 }
 
+namespace {
+bool IsSpecificTextCondMode(ScConditionMode eMode)
+

[Libreoffice-bugs] [Bug 138068] When there are a lot of pictures, typing the text is very slow (macOS/GTK3/GDI)

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138068

--- Comment #45 from Tomaz Vajngerl  ---
The scaling quality in gtk3+cairo has gotten worse since this change was added.
I opened a new bug [1] tdf#140768 with the issue.

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=140768

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138068] When there are a lot of pictures, typing the text is very slow (macOS/GTK3/GDI)

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138068

Tomaz Vajngerl  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0768

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140768] Scaling quality of images degraded since tdf#138068

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140768

Tomaz Vajngerl  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||8068

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140768] New: Scaling quality of images degraded since tdf#138068

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140768

Bug ID: 140768
   Summary: Scaling quality of images degraded since tdf#138068
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: qui...@gmail.com

Created attachment 170190
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170190=edit
Document whcih demonstrates bad scaling

I noticed that scaling of my PNG images is quite bad in master when I was
writing my blog. I confirmed by reverting the patches that since tdf#138068 [1]
the quality of scaling got worse - at least with the GTK3 + cairo backend
(didn't try others backends). Looks like it does just a simple bi-linear
interpolation even when scaling down more than a factor of 0.5. 


[1] https://bugs.documentfoundation.org/show_bug.cgi?id=138068

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source include/vcl vcl/osx vcl/source vcl/unx

2021-03-02 Thread Noel Grandin (via logerrit)

 drawinglayer/source/texture/texture3d.cxx |   11 -
 include/vcl/bitmapex.hxx  |9 +---
 vcl/osx/salinst.cxx   |6 --
 vcl/source/bitmap/BitmapEx.cxx|   61 ++
 vcl/source/bitmap/BitmapTools.cxx |   13 --
 vcl/source/bitmap/dibtools.cxx|   13 +-
 vcl/source/gdi/mtfxmldump.cxx |1 
 vcl/source/gdi/pdfwriter_impl.cxx |   30 --
 vcl/source/outdev/outdevstate.cxx |6 --
 vcl/unx/generic/window/salframe.cxx   |3 -
 10 files changed, 21 insertions(+), 132 deletions(-)

New commits:
commit 63dd594d535b1272a29a3f4217212b6063a08af6
Author: Noel Grandin 
AuthorDate: Sat Feb 27 18:35:14 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 3 08:26:47 2021 +0100

drop TransparentType::Color usage

which is dead code, since we convert to TransparentType::Bitmask
in the constructor of BitmapEx

Change-Id: I047b7d25317c4be4d17a8b0db9a90ec101875c9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111683
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/drawinglayer/source/texture/texture3d.cxx 
b/drawinglayer/source/texture/texture3d.cxx
index b4154f1e1bd6..ef53c94d0d10 100644
--- a/drawinglayer/source/texture/texture3d.cxx
+++ b/drawinglayer/source/texture/texture3d.cxx
@@ -121,17 +121,6 @@ namespace drawinglayer::texture
 {
 break;
 }
-case TransparentType::Color:
-{
-const BitmapColor aBitmapColor(mpReadBitmap->GetColor(rY, 
rX));
-
-if(maBitmapEx.GetTransparentColor() == aBitmapColor)
-{
-return 255;
-}
-
-break;
-}
 case TransparentType::Bitmap:
 {
 OSL_ENSURE(mpReadTransparence, "OOps, transparence type 
Bitmap, but no read access created in the constructor (?)");
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index 75e605cb96a9..506901134719 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -36,9 +36,9 @@ namespace basegfx { class BColorModifierStack; }
 
 enum class TransparentType
 {
-NONE,
-Color,
-Bitmap
+NONE = 0,
+// Color = 1, Never actually used in BitmapEx, only present for backwards 
compat with existing SVM files
+Bitmap = 2
 };
 
 class SAL_WARN_UNUSED VCL_DLLPUBLIC BitmapEx
@@ -90,8 +90,6 @@ public:
 const MapMode&  GetPrefMapMode() const { return 
maBitmap.GetPrefMapMode(); }
 voidSetPrefMapMode( const MapMode& rPrefMapMode ) { 
maBitmap.SetPrefMapMode( rPrefMapMode ); }
 
-const Color&GetTransparentColor() const { return 
maTransparentColor; }
-
 sal_uInt16  GetBitCount() const { return maBitmap.GetBitCount(); }
 sal_uLong   GetSizeBytes() const;
 BitmapChecksum  GetChecksum() const;
@@ -475,7 +473,6 @@ private:
 Bitmap  maBitmap;
 Bitmap  maMask;
 SizemaBitmapSize;
-Color   maTransparentColor;
 TransparentType meTransparent;
 boolmbAlpha;
 
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 748655c86641..b090957fc922 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -932,12 +932,6 @@ CGImageRef CreateCGImage( const Image& rImage )
 else
 xImage = pSalBmp->CreateCroppedImage( 0, 0, pSalBmp->mnWidth, 
pSalBmp->mnHeight );
 }
-else if( aBmpEx.GetTransparentType() == TransparentType::Color )
-{
-Color aTransColor( aBmpEx.GetTransparentColor() );
-Color nTransColor( aTransColor.GetRed(), aTransColor.GetGreen(), 
aTransColor.GetBlue() );
-xImage = pSalBmp->CreateColorMask( 0, 0, pSalBmp->mnWidth, 
pSalBmp->mnHeight, nTransColor );
-}
 
 return xImage;
 }
diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx
index c75aa12ed27b..db889e8c6a98 100644
--- a/vcl/source/bitmap/BitmapEx.cxx
+++ b/vcl/source/bitmap/BitmapEx.cxx
@@ -156,19 +156,20 @@ BitmapEx::BitmapEx( const Bitmap& rBmp, const AlphaMask& 
rAlphaMask ) :
 }
 }
 
+
 BitmapEx::BitmapEx( const Bitmap& rBmp, const Color& rTransparentColor ) :
 maBitmap ( rBmp ),
 maBitmapSize ( maBitmap.GetSizePixel() ),
-maTransparentColor   ( rTransparentColor ),
 meTransparent( TransparentType::Bitmap ),
 mbAlpha  ( false )
 {
-maMask = maBitmap.CreateMask( maTransparentColor );
+maMask = maBitmap.CreateMask( rTransparentColor );
 
 SAL_WARN_IF(rBmp.GetSizePixel() != maMask.GetSizePixel(), "vcl",
 "BitmapEx::BitmapEx(): size mismatch for bitmap and alpha 
mask.");
 }
 
+
 BitmapEx& BitmapEx::operator=( const BitmapEx& ) =

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-0' - vcl/CppunitTest_vcl_filter_igif.mk vcl/Module_vcl.mk vcl/qa vcl/source

2021-03-02 Thread Miklos Vajna (via logerrit)

 vcl/CppunitTest_vcl_filter_igif.mk  |   46 +++
 vcl/Module_vcl.mk   |1 
 vcl/qa/cppunit/filter/igif/data/logic-lazy-read.gif |binary
 vcl/qa/cppunit/filter/igif/igif.cxx |   47 
 vcl/source/filter/graphicfilter.cxx |7 ++
 vcl/source/filter/igif/gifread.cxx  |   10 +++-
 vcl/source/filter/igif/gifread.hxx  |2 
 7 files changed, 110 insertions(+), 3 deletions(-)

New commits:
commit 1248e84a49d777ae93be5dae96583a4f8df9
Author: Miklos Vajna 
AuthorDate: Mon Dec 21 21:03:36 2020 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 3 08:26:17 2021 +0100

tdf#138801 vcl: fix lazy-loading of GIF images with logic size

Regression from commit edda1e5fc8113aa4744e32f97c96a3cc311485ca (DOCX
import: lazy-read images without external headers, 2018-04-20), the
immediate problem is that GIF images from docx are now lazy-loaded.

The deeper problem is that GIF images normally only have pixel size and
can have an optional logic size as well (LO-specific extension).

The bugdoc in question is a DOCX file, which contains a .png stream,
which is in fact a GIF image, with that STARDIV extension in it.

Now the initial parsing (that only extracts the metadata) didn't read
the logic size, so the preferred map mode was pixels, but later when the
actual read happened, the preferred map mode changed to mm100.

Thid does not play nicely with writerfilter/ code that sets a different
wrap polygon depending on if the (assumed to be final) map mode is
pixels or not.

Fix the problem by reusing the "is this an animation" GIF parser to also
extract the logic size of the GIF image, if it has one. This way we
still lazy-load the GIF image, but the preferred map mode won't hange
from pixels to mm100 during the real read.

Change-Id: Ia6c66e1c4fa0cb23a1daf537e7179b081ef90def
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108125
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit c24d9447b809416575972585a5ad48e14f8d9ad9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108182
Reviewed-by: Xisco Fauli 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108664
(cherry picked from commit bc8fa345ff2a20d9f39c22afa67cf158e6368efd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111791
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/vcl/CppunitTest_vcl_filter_igif.mk 
b/vcl/CppunitTest_vcl_filter_igif.mk
new file mode 100644
index ..c6b6759899b0
--- /dev/null
+++ b/vcl/CppunitTest_vcl_filter_igif.mk
@@ -0,0 +1,46 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,vcl_filter_igif))
+
+$(eval $(call gb_CppunitTest_use_externals,vcl_filter_igif,\
+   boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,vcl_filter_igif, \
+vcl/qa/cppunit/filter/igif/igif \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,vcl_filter_igif, \
+comphelper \
+cppu \
+sal \
+test \
+tl \
+unotest \
+utl \
+vcl \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,vcl_filter_igif))
+
+$(eval $(call gb_CppunitTest_use_ure,vcl_filter_igif))
+$(eval $(call gb_CppunitTest_use_vcl,vcl_filter_igif))
+
+$(eval $(call gb_CppunitTest_use_rdb,vcl_filter_igif,services))
+
+$(eval $(call gb_CppunitTest_use_custom_headers,vcl_filter_igif,\
+   officecfg/registry \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,vcl_filter_igif))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 938cd32014bd..8c7213938795 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -207,6 +207,7 @@ $(eval $(call gb_Module_add_check_targets,vcl,\
 CppunitTest_vcl_backend_test \
 CppunitTest_vcl_blocklistparser_test \
 CppunitTest_vcl_type_serializer_test \
+CppunitTest_vcl_filter_igif \
 ))
 
 ifeq ($(USING_X11),TRUE)
diff --git a/vcl/qa/cppunit/filter/igif/data/logic-lazy-read.gif 
b/vcl/qa/cppunit/filter/igif/data/logic-lazy-read.gif
new file mode 100644
index ..3d18891f7b6a
Binary files /dev/null and 
b/vcl/qa/cppunit/filter/igif/data/logic-lazy-read.gif differ
diff --git a/vcl/qa/cppunit/filter/igif/igif.cxx 
b/vcl/qa/cppunit/filter/igif/igif.cxx
new file mode 100644
index

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-0' - vcl/qa

2021-03-02 Thread Gabor Kelemen (via logerrit)

 vcl/qa/cppunit/pdfexport/pdfexport.cxx |   46 -
 1 file changed, 46 deletions(-)

New commits:
commit 905117465025820762be08db9ce7224b90a15de4
Author: Gabor Kelemen 
AuthorDate: Wed Mar 3 08:22:30 2021 +0100
Commit: Gabor Kelemen 
CommitDate: Wed Mar 3 08:24:12 2021 +0100

Revert failing unit test backported in 2a4dc079

Change-Id: I334ac2128a62957ee0e2a5063e3b91948d5fe661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111866
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 33683ee75a7a..fe402b4ed8b8 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -151,7 +151,6 @@ public:
 void testVersion15();
 void testDefaultVersion();
 void testMultiPagePDF();
-void testFormFontName();
 
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
@@ -197,7 +196,6 @@ public:
 CPPUNIT_TEST(testVersion15);
 CPPUNIT_TEST(testDefaultVersion);
 CPPUNIT_TEST(testMultiPagePDF);
-CPPUNIT_TEST(testFormFontName);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -2288,50 +2286,6 @@ void PdfExportTest::testMultiPagePDF()
 #endif
 }
 
-void PdfExportTest::testFormFontName()
-{
-// Import the bugdoc and export as PDF.
-OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"form-font-name.odt";
-mxComponent = loadFromDesktop(aURL);
-
-uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
-utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
-xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
-
-// Parse the export result with pdfium.
-SvFileStream aFile(maTempFile.GetURL(), StreamMode::READ);
-SvMemoryStream aMemory;
-aMemory.WriteStream(aFile);
-ScopedFPDFDocument pPdfDocument(
-FPDF_LoadMemDocument(aMemory.GetData(), aMemory.GetSize(), 
/*password=*/nullptr));
-CPPUNIT_ASSERT(pPdfDocument);
-
-// The document has one page.
-CPPUNIT_ASSERT_EQUAL(1, FPDF_GetPageCount(pPdfDocument.get()));
-ScopedFPDFPage pPdfPage(FPDF_LoadPage(pPdfDocument.get(), 
/*page_index=*/0));
-CPPUNIT_ASSERT(pPdfPage);
-
-// The page has one annotation.
-CPPUNIT_ASSERT_EQUAL(1, FPDFPage_GetAnnotCount(pPdfPage.get()));
-ScopedFPDFAnnotation pAnnot(FPDFPage_GetAnnot(pPdfPage.get(), 0));
-
-// Examine the default appearance.
-CPPUNIT_ASSERT(FPDFAnnot_HasKey(pAnnot.get(), "DA"));
-CPPUNIT_ASSERT_EQUAL(FPDF_OBJECT_STRING, 
FPDFAnnot_GetValueType(pAnnot.get(), "DA"));
-size_t nDALength = FPDFAnnot_GetStringValue(pAnnot.get(), "DA", nullptr, 
0);
-std::vector aDABuf(nDALength);
-FPDFAnnot_GetStringValue(pAnnot.get(), "DA", aDABuf.data(), nDALength);
-OUString aDA(reinterpret_cast(aDABuf.data()));
-
-// Without the accompanying fix in place, this test would have failed with:
-// - Expected: 0 0 0 rg /TiRo 12 Tf
-// - Actual  : 0 0 0 rg /F2 12 Tf
-// i.e. Liberation Serif was exposed as a form font as-is, without picking 
the closest built-in
-// font.
-CPPUNIT_ASSERT_EQUAL(OUString("0 0 0 rg /TiRo 12 Tf"), aDA);
-}
-
 CPPUNIT_TEST_SUITE_REGISTRATION(PdfExportTest);
 
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 128529] Some keyboard shortcuts don't work when caps lock is used as ctrl key

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128529

Jacobo Aragunde Pérez  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #6 from Jacobo Aragunde Pérez  ---
I only recently learned there are limitations to the amount of simultaneous key
presses, and that they depend on the actual keys. I tried this online key test:
http://en.key-test.ru/ and I cannot trigger the caps+shift+s triplet of keys
there either.

Oddly, I have tried different keyboards and they all behave the same. It might
be not hardware but software related... Even more oddly, it apparently worked
for me with a different VCL implementation some time ago, but not now. Anyway,
chances are that LibreOffice is not receiving that key combination at all so
it's not a bug for us.

Sorry for the noise!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113084] FILEOPEN: RTF - Font table not imported/applied correctly

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113084

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||102985
   Keywords|notBibisectable |preBibisect
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=86
   ||182
Version|4.0.6.2 release |3.5.0 release

--- Comment #5 from Aron Budea  ---
(In reply to Buovjaga from comment #2)
> So the target of the bibisectRequest was apparently about the Helvetica
> change. In 43all repo with Ubuntu 14.04, the font just stays Helvetica
> everywhere.

I thought it was the main, RTL font name change.
The text disappeared in 3.5.0 (already incorrect in earliest of bibisect-43all,
thus setting preBibisect), and came back in 4.1, with the following commit,
found using bibisect-41max:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4a816a816e8b4e213394898bd0e307dd90fcbb64
author  Miklos Vajna   2013-05-15 09:59:18 +0200
committer   Miklos Vajna   2013-05-15 10:30:37 +0200

"fdo#62977 allow SAL_MAX_INT16..SAL_MAX_UINT16 when importing RTF_U"

The name of the Helvetica font for the LTR parts of the text (numbering,
colons) changes to the default CTL font name with the following commit. An
issue this commit corrected is that previously the numbering that should've
been on the right was on the left (this had also been fine before 3.5.0, and
regressed in that version).

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ee2a882dddb395a816cd54004b634d57cfb2446
author  Miklos Vajna   2015-04-17 10:44:47
+0200
committer   Miklos Vajna   2015-04-17 11:35:27
+0200

"tdf#86182 RTF import: fix handling of \rtlpar"


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102985
[Bug 102985] [META] Font bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102985

Aron Budea  changed:

   What|Removed |Added

 Depends on||113084


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113084
[Bug 113084] FILEOPEN: RTF - Font table not imported/applied correctly
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140145] Calc stops responding to keyboard

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140145

Aleksandar Kondic  changed:

   What|Removed |Added

 CC||aleksandar.kondic@protonmai
   ||l.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #6 from Aleksandar Kondic  ---
Hi clearstar,

I could not replicate in: 

Version: 7.0.4.2
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


Did you try to install the new LibreOffice version 7.1 and see if the problem
still persists?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140754] LibreOffice Calc crash when selecting filters

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140754

--- Comment #9 from Alexander  ---
Don't know if it help, but it also crashes with version 6.4.7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140427] Writer crashes when scrolling using Bluetooth trackpad.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140427

--- Comment #3 from ballardm...@gmail.com ---
(In reply to Dieter from comment #2)
> So let's close as RESOLVED WORKSFORME. Feel free to change it back to
> UNCONFIRMED, if it happens again. If possible add link to crash report.

Will do -- thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

2021-03-02 Thread Noel (via logerrit)

 sc/inc/afmtuno.hxx  |6 +++---
 sc/inc/cellsuno.hxx |2 +-
 sc/inc/chartuno.hxx |4 ++--
 sc/inc/dapiuno.hxx  |8 
 sc/inc/datauno.hxx  |6 +++---
 sc/inc/docuno.hxx   |   16 
 sc/inc/linkuno.hxx  |   10 +-
 sc/inc/nameuno.hxx  |   14 +++---
 sc/inc/styleuno.hxx |   10 +-
 sc/inc/viewuno.hxx  |2 +-
 sc/source/ui/Accessibility/AccessibleCsvControl.cxx |2 +-
 sc/source/ui/inc/AccessibleCsvControl.hxx   |2 +-
 sc/source/ui/unoobj/afmtuno.cxx |6 +++---
 sc/source/ui/unoobj/cellsuno.cxx|2 +-
 sc/source/ui/unoobj/chartuno.cxx|4 ++--
 sc/source/ui/unoobj/dapiuno.cxx |8 
 sc/source/ui/unoobj/datauno.cxx |6 +++---
 sc/source/ui/unoobj/docuno.cxx  |   20 ++--
 sc/source/ui/unoobj/linkuno.cxx |   10 +-
 sc/source/ui/unoobj/nameuno.cxx |   10 +-
 sc/source/ui/unoobj/styleuno.cxx|   10 +-
 sc/source/ui/unoobj/viewuno.cxx |2 +-
 sc/source/ui/vba/vbarange.cxx   |2 +-
 sc/source/ui/vba/vbasheetobjects.cxx|6 +++---
 24 files changed, 84 insertions(+), 84 deletions(-)

New commits:
commit 4adfd75021d50e8e91c71bbe1526a1c752343059
Author: Noel 
AuthorDate: Tue Mar 2 09:20:47 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 3 07:36:59 2021 +0100

loplugin:refcounting in sc

Change-Id: I0b808785e54bf1dfc9387a649aacf731b2f34d12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111801
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/afmtuno.hxx b/sc/inc/afmtuno.hxx
index f3d9ba2a3d20..f005773d9c91 100644
--- a/sc/inc/afmtuno.hxx
+++ b/sc/inc/afmtuno.hxx
@@ -45,8 +45,8 @@ class ScAutoFormatsObj final : public ::cppu::WeakImplHelper<
 css::lang::XServiceInfo >
 {
 private:
-static ScAutoFormatObj* GetObjectByIndex_Impl(sal_uInt16 nIndex);
-static ScAutoFormatObj* GetObjectByName_Impl(std::u16string_view aName);
+static rtl::Reference GetObjectByIndex_Impl(sal_uInt16 
nIndex);
+static rtl::Reference 
GetObjectByName_Impl(std::u16string_view aName);
 
 public:
 ScAutoFormatsObj();
@@ -96,7 +96,7 @@ private:
 SfxItemPropertySet  aPropSet;
 sal_uInt16  nFormatIndex;
 
-ScAutoFormatFieldObj*   GetObjectByIndex_Impl(sal_uInt16 nIndex);
+rtl::Reference GetObjectByIndex_Impl(sal_uInt16 
nIndex);
 
 public:
 ScAutoFormatObj(sal_uInt16 nIndex);
diff --git a/sc/inc/cellsuno.hxx b/sc/inc/cellsuno.hxx
index 3c19e9ff88de..87bca6b02a29 100644
--- a/sc/inc/cellsuno.hxx
+++ b/sc/inc/cellsuno.hxx
@@ -387,7 +387,7 @@ private:
 struct Impl;
 std::unique_ptr m_pImpl;
 
-ScCellRangeObj* GetObjectByIndex_Impl(sal_Int32 nIndex) const;
+rtl::Reference GetObjectByIndex_Impl(sal_Int32 nIndex) 
const;
 
 public:
 ScCellRangesObj(ScDocShell* pDocSh, const 
ScRangeList& rR);
diff --git a/sc/inc/chartuno.hxx b/sc/inc/chartuno.hxx
index aac210fb1314..5a3ed1f1e2ac 100644
--- a/sc/inc/chartuno.hxx
+++ b/sc/inc/chartuno.hxx
@@ -50,8 +50,8 @@ private:
 ScDocShell* pDocShell;
 SCTAB   nTab;   // Charts are per sheet
 
-ScChartObj* GetObjectByIndex_Impl(tools::Long nIndex) const;
-ScChartObj* GetObjectByName_Impl(const OUString& aName) const;
+rtl::Reference GetObjectByIndex_Impl(tools::Long nIndex) const;
+rtl::Reference GetObjectByName_Impl(const OUString& aName) 
const;
 
 public:
 ScChartsObj(ScDocShell* pDocSh, SCTAB nT);
diff --git a/sc/inc/dapiuno.hxx b/sc/inc/dapiuno.hxx
index c32c2d6bf01e..613d114128ff 100644
--- a/sc/inc/dapiuno.hxx
+++ b/sc/inc/dapiuno.hxx
@@ -87,8 +87,8 @@ private:
 ScDocShell* pDocShell;
 SCTAB   nTab;
 
-ScDataPilotTableObj*GetObjectByIndex_Impl( sal_Int32 nIndex );
-ScDataPilotTableObj*GetObjectByName_Impl(const OUString& aName);
+rtl::Reference GetObjectByIndex_Impl( sal_Int32 
nIndex );
+rtl::Reference GetObjectByName_Impl(const OUString& 
aName);
 
 public:
 ScDataPilotTablesObj(ScDocShell* pDocSh, SCTAB nT);
@@ -374,8 +374,8 @@ public:
 virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() 
override;
 
 private:
-ScDataPilotFieldObj*GetObjectByIndex_Impl(

[Libreoffice-bugs] [Bug 121133] Adobe Reader DC claims that the PDF has been modified after signing

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121133

--- Comment #27 from Michel Van den Bergh  ---
This bug still persists in Ubuntu 20.04  (version: LibreOffice 6.4.6.2
40(Build:2) ).

At least for me this is an important issue since it makes it essentially
impossible to directly use the amazing digital signing support in LibreOffice.

As far as I can tell there are no issues with signing an existing pdf so as a
work around one can first export and then sign. But of course this is somewhat
less flexible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91764] RTL: Arabic, Hebrew diacritics cant be found using search dialog

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91764

--- Comment #27 from Safeer Pasha  ---
(In reply to Xisco Faulí from comment #25)

the testing is done on the document that is in the attachments,

open the S dialog and type "کُ" the letter KAF with DAMMA in the "Search BOX"
type KAF with FATHA "کَ" in the "Replace BOX" 
press "Find" or "Find all" or "Replace" or "Replace All" 

you can even search & replace for FATHA or DAMMA alone, without it being
attached to another letter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140767] Support for Syriac justification ("Kashida") by stretching the word-line instead of growing spaces between words (just like Arabic)

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140767

--- Comment #1 from maronitetreas...@gmail.com ---
Created attachment 170189
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170189=edit
sample image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140767] New: Support for Syriac justification ("Kashida") by stretching the word-line instead of growing spaces between words (just like Arabic)

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140767

Bug ID: 140767
   Summary: Support for Syriac justification ("Kashida") by
stretching the word-line instead of growing spaces
between words (just like Arabic)
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: maronitetreas...@gmail.com

Description:
Requesting that text justification be done by stretching the word-line (called
"Kashida" or "tatweel") rather than the spaces between the words. This was
fixed in arabic, and it's essentially the same feature with similar rules to
arabic.

(This type of feature is essential for many use cases of Syriac: virtually all
Syriac texts are justified.)

Steps to Reproduce:
1. Paste in or type in a Syriac text.
2. Justify the text.
3. Set Right-to-Left (need complex layouts enabled).
4. Put line-breaks to test the justification.
5. Pick a font like "Noto Sans Syriac Western"

Actual Results:
There are wide spaces between words.

Expected Results:
The connecting line of the words should stretch so that there is minimal white
space, very similar to Arabic.


Reproducible: Always


User Profile Reset: No



Additional Info:
sample text for convenience:

ܐܰܒܓܰܕ ܗܰܘܰܙ ܚܰܛܺܝ ܟܰܠܡܰܢ ܣܰܥܦܰܨ ܩܰܪܫܰܬ
ܐܲܒܓܲܕ ܗܲܘܲܙ ܚܲܛܲܝ ܟܲܠܡܲܢ ܣܲܥܦܲܨ ܩܲܪܫܲܬ
ܐܒܓܕ ܗܘܙ ܚܛܝ ܟܠܡܢ ܣܥܦܨ ܩܪܫܬ


Help - About LibreOffice:
Version: 7.0.3.1
Build ID: 00(Build:1)
CPU threads: 6; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-CA (en_CA.UTF-8); UI: en-US
Ubuntu package version: 1:7.0.3-0ubuntu0.20.10.1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140427] Writer crashes when scrolling using Bluetooth trackpad.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140427

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139951] Some "replace dashes" options do not work with Tools -AutoCorrect - Apply

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139951

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135322] FILEOPEN DOC: Text layout after image moving off

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135322

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140452] Image anchored to Page misplaced after PDF export

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140452

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140448] Make "Navigate By" Page up & down toolbar buttons accessible as keyboard shortcuts

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140448

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140443] FILEOPEN DOCX Opening file with many tracked changes is slow

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140443

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140442] Make non-breaking hyphen the default hyphen character in LibreOffice Writer

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140442

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140700] calc crash at exit in ScSelectionTransferObj::~ScSelectionTransferObj

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140700

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140700] calc crash at exit in ScSelectionTransferObj::~ScSelectionTransferObj

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140700

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136649] Choice of multiple columns is ignored when inserting an alphabetical index

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=136649

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 136649] Choice of multiple columns is ignored when inserting an alphabetical index

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=136649

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135404] LibreOffice_6.4.5_Win_x64 failed to open

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135404

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135404] LibreOffice_6.4.5_Win_x64 failed to open

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135404

--- Comment #4 from QA Administrators  ---
Dear Don,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135399] Cierre inesperado en LO Writer

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135399

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135399] Cierre inesperado en LO Writer

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135399

--- Comment #3 from QA Administrators  ---
Dear Gersan,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135397] Perpetual saving of document after opening– writer, 6.4.2.2

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135397

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135397] Perpetual saving of document after opening– writer, 6.4.2.2

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135397

--- Comment #3 from QA Administrators  ---
Dear JohnRick,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135396] EDITING Crash when cutting a newly created chart

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135396

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135396] EDITING Crash when cutting a newly created chart

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135396

--- Comment #3 from QA Administrators  ---
Dear Dave Youngman,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135363] Crash in: svx::DocRecovery::PluginProgress::start::REPORTBUILDER::FILESAVE

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135363

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135363] Crash in: svx::DocRecovery::PluginProgress::start::REPORTBUILDER::FILESAVE

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135363

--- Comment #3 from QA Administrators  ---
Dear Ernesto Bosch,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135361] Crash in: svx::DocRecovery::PluginProgress::start::FILESAVE

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135361

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135361] Crash in: svx::DocRecovery::PluginProgress::start::FILESAVE

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=135361

--- Comment #4 from QA Administrators  ---
Dear Ernesto Bosch,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133591] Invisible caracter generate when export in .txt

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133591

--- Comment #5 from QA Administrators  ---
Dear fg,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114392] MacOS: Increased CPU usage while typing

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114392

--- Comment #3 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140711] Adjusting Zorder of images causes changes to image index

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140711

John  changed:

   What|Removed |Added

 CC||j...@gmx.us

--- Comment #2 from John  ---
Created attachment 170188
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170188=edit
A smaller example

Click the form button and some Zorder properties will change pseudorandomly,
each time filling out a cell with an indication of which image is in that index
(text based on where it used to be)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140711] Adjusting Zorder of images causes changes to image index

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140711

John  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from John  ---
I believe I've confirmed this behavior with a smaller example, will attach. The
results of GetByIndex() are intimately related to the Zorder.

I'm having a hard time figuring out the intended ordering by reading here:

https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1drawing_1_1DrawPage.html

Perhaps there is a better documentation to look at.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112125] [META] Hyperlink dialog bugs and enhancements

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112125
Bug 112125 depends on bug 114567, which changed state.

Bug 114567 Summary: HYPERLINK DIALOG: "Target in document" dialog should 
display the level of headings
https://bugs.documentfoundation.org/show_bug.cgi?id=114567

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114567] HYPERLINK DIALOG: "Target in document" dialog should display the level of headings

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114567

Jim Raykowski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112125] [META] Hyperlink dialog bugs and enhancements

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112125
Bug 112125 depends on bug 138934, which changed state.

Bug 138934 Summary: Hyperlink: Headings in "Target in document" window show 
numbered sublevels, regardless of settings in "Chapter Numbering"
https://bugs.documentfoundation.org/show_bug.cgi?id=138934

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138934] Hyperlink: Headings in "Target in document" window show numbered sublevels, regardless of settings in "Chapter Numbering"

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138934

Jim Raykowski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140705] Some buttons has 'gtk-' before the text. Like 'gtk-cancel' instead of 'Cancel'

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140705

--- Comment #6 from m.a.riosv  ---
Still
Version: 7.1.2.0.0+ (x64) / LibreOffice Community
Build ID: 662649d953c1f0f461d8df019731bb8854b5922b
CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140766] escortsandfun

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140766

himajin100...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140766] escortsandfun

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140766

himajin100...@gmail.com changed:

   What|Removed |Added

Version|1.0.3   |unspecified
  Component|General |deletionRequest
Product|Impress Remote  |LibreOffice
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/qa vcl/source

2021-03-02 Thread Tomaž Vajngerl (via logerrit)

 vcl/inc/pdf/ExternalPDFStreams.hxx   |   12 
 vcl/qa/cppunit/PDFDocumentTest.cxx   |   12 
 vcl/qa/cppunit/data/DocumentWithNull.pdf |binary
 vcl/source/filter/ipdf/pdfdocument.cxx   |   12 +---
 vcl/source/gdi/pdfwriter_impl.cxx|   12 +---
 5 files changed, 38 insertions(+), 10 deletions(-)

New commits:
commit 2c1ed5a5dad827cde032f27a4348e81be15889bc
Author: Tomaž Vajngerl 
AuthorDate: Tue Mar 2 18:57:46 2021 +0900
Commit: Tomaž Vajngerl 
CommitDate: Wed Mar 3 02:00:16 2021 +0100

tdf#140606 make PDF parsing more lenient and prevent a crash

If the external document can't be opened, it tried to continue
with the export anyway, which eventually lead to a crash. This
is fixed by handling this situation and prevent a crash, however
the part of the document in this case isn't exported.

The document couldn't be opened because of a parsing error - there
was a unexpected null character instead of a whitespace, which
made the parser panic. Fix this by making the parser more lenient
in such a situation when there is an unexpected null and try to
continue parsing.

Bug document seems to be created with a buggy PDF writer, but other
PDF readers don't complain when parsing the document so it looks to
be a valid. qpdf --check doesn't complain either.

Added a test that checks a document with a null parses.

Change-Id: I61eb281e821ccd195ef006d778556e25d1c7f5e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111820
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/inc/pdf/ExternalPDFStreams.hxx 
b/vcl/inc/pdf/ExternalPDFStreams.hxx
index dc484e1dd15b..7840217630c8 100644
--- a/vcl/inc/pdf/ExternalPDFStreams.hxx
+++ b/vcl/inc/pdf/ExternalPDFStreams.hxx
@@ -34,21 +34,25 @@ struct VCL_DLLPUBLIC ExternalPDFStream
 
 std::map& getCopiedResources() { return 
maCopiedResources; }
 
-filter::PDFDocument& getPDFDocument()
+std::shared_ptr& getPDFDocument()
 {
 if (!mpPDFDocument)
 {
 SvMemoryStream aPDFStream;
 aPDFStream.WriteBytes(maDataContainer.getData(), 
maDataContainer.getSize());
 aPDFStream.Seek(0);
-mpPDFDocument = std::make_shared();
-if (!mpPDFDocument->Read(aPDFStream))
+auto pPDFDocument = std::make_shared();
+if (!pPDFDocument->Read(aPDFStream))
 {
 SAL_WARN("vcl.pdfwriter",
  "PDFWriterImpl::writeReferenceXObject: reading the 
PDF document failed");
 }
+else
+{
+mpPDFDocument = pPDFDocument;
+}
 }
-return *mpPDFDocument;
+return mpPDFDocument;
 }
 };
 
diff --git a/vcl/qa/cppunit/PDFDocumentTest.cxx 
b/vcl/qa/cppunit/PDFDocumentTest.cxx
index 2246f8e38924..35af8e66cd58 100644
--- a/vcl/qa/cppunit/PDFDocumentTest.cxx
+++ b/vcl/qa/cppunit/PDFDocumentTest.cxx
@@ -156,6 +156,18 @@ CPPUNIT_TEST_FIXTURE(PDFDocumentTest, testParseBasicPDF)
 }
 }
 
+CPPUNIT_TEST_FIXTURE(PDFDocumentTest, testParseDocumentWithNullAsWhitespace)
+{
+// tdf#140606
+// Bug document contained a null, which cause the parser to panic,
+// but other PDF readers can handle the file well.
+
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"DocumentWithNull.pdf";
+vcl::filter::PDFDocument aDocument;
+SvFileStream aStream(aURL, StreamMode::READ);
+CPPUNIT_ASSERT(aDocument.Read(aStream));
+}
+
 namespace
 {
 vcl::filter::PDFObjectElement*
diff --git a/vcl/qa/cppunit/data/DocumentWithNull.pdf 
b/vcl/qa/cppunit/data/DocumentWithNull.pdf
new file mode 100644
index ..f6d926957366
Binary files /dev/null and b/vcl/qa/cppunit/data/DocumentWithNull.pdf differ
diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx 
b/vcl/source/filter/ipdf/pdfdocument.cxx
index acf584949a70..5ebe05e6115a 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -1324,12 +1324,18 @@ bool PDFDocument::Tokenize(SvStream& rStream, 
TokenizeMode eMode,
 }
 else
 {
-if (!rtl::isAsciiWhiteSpace(static_cast(ch)))
+auto uChar = static_cast(ch);
+// Be more lenient and allow unexpected null char
+if (!rtl::isAsciiWhiteSpace(uChar) && uChar != 0)
 {
-SAL_WARN("vcl.filter", "PDFDocument::Tokenize: 
unexpected character: "
-   << ch << " at byte position 
" << rStream.Tell());
+SAL_WARN("vcl.filter",
+ "PDFDocument::Tokenize: unexpected character 
with code "
+ << sal_Int32(ch) << " at byte position " 
<< rStream.Tell());
 return

[Libreoffice-bugs] [Bug 140606] PDF: EXPORT: Crash in: mergedlo.dll

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140606

--- Comment #5 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c1ed5a5dad827cde032f27a4348e81be15889bc

tdf#140606 make PDF parsing more lenient and prevent a crash

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140606] PDF: EXPORT: Crash in: mergedlo.dll

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140606

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

License statement

2021-03-02 Thread John


All of my past & future contributions to LibreOffice may be licensed
under the MPLv2/LGPLv3+ dual license, or any other licensing The
Document Foundation may later deem fit.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 140761] LO 7.1.0.3 issues with Writer on Mac OS X Big Sur with External display - Display has rendering issues it seems

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140761

--- Comment #2 from Thorsten Wagner  ---
Issue should be fixed, but patch is on master branch only and has not been
merged to release branch unitl now (see tdf#138122).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140669] Clarification about which toolbars should have "No List" icon

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140669

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140766] New: escortsandfun

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140766

Bug ID: 140766
   Summary: escortsandfun
   Product: Impress Remote
   Version: 1.0.3
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: z400b...@bestlistbase.com

Description:
You need to log in before you can comment on or make changes to this bug.
https://www.escortsandfun.com

Actual Results:
You need to log in before you can comment on or make changes to this bug.

Expected Results:
You need to log in before you can comment on or make changes to this bug.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
You need to log in before you can comment on or make changes to this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140735] Editing: The Find operation does not recognize national characters.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140735

--- Comment #10 from sdc.bla...@youmail.dk ---
(In reply to Jerzy Moruś from comment #9)
> I would love to add a Polish translation to help, but I don't know how to do
> it.
Let me answer in 3 different ways.

1.  It is possible to make a suggestion for how to translate the current
English text.

This link should place you in the right place. You can make a suggestion about
how it should be translated.  And I think, sometimes, local adjustments are
made. That is, you could add a Polish example in your suggestion.

https://translations.documentfoundation.org/translate/libo_help-master/textshared01/pl/?checksum=e7c1f513ee180d09_by=-priority,position

2.  Or maybe you want to get an account in that system, and contribute to some
more translating. 

Look on this page to find the Polish team (and some email addresses). They
should be able to give advice about how to get started with translating.

https://wiki.documentfoundation.org/Language_Teams

(You can see here that about 25% of the help is still not translated to
Polish).
https://translations.documentfoundation.org/languages/pl/

3. If you give me an example of what might stand on the English page, then I
can add it to the English help -- and then -- at some point -- it would be
translated in the Polish help.  But probably better to try 1 or 2 first.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45735] Automatic check at start-up whether LO is default program for ODF-file formats

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45735

Matt K  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |matt...@gmail.com
   |desktop.org |

--- Comment #40 from Matt K  ---
Assigning to myself.  Looks like the defaults to ask the user about are .ods,
.odp, and .odt, so will check those.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140759

--- Comment #6 from Jan-Åke Larsson  ---
(I know Julien won't read this but...)

I find it strange that you don't think the docs can be improved. 

Plus, if LibreOffice did aim for PDF/A-1b, it would not generate PDF/A-1a even
for simple documents. It seems it does try to generate PDF/A-1a but can only
guarantee PDF/A-1b.

That should be visible in the docs, and in the dialog, IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: connectivity/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 connectivity/source/drivers/macab/MacabColumns.cxx  |3 -
 connectivity/source/drivers/macab/MacabConnection.cxx   |8 +--
 connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx |   28 +---
 connectivity/source/drivers/macab/MacabStatement.cxx|   12 ++---
 connectivity/source/drivers/macab/MacabTables.cxx   |3 -
 5 files changed, 23 insertions(+), 31 deletions(-)

New commits:
commit abba6e22610ceff3d0e439b0ebd6137d064859a9
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 13:44:05 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 2 23:12:31 2021 +0100

loplugin:refcounting (macOS)

Change-Id: Ia68887778e6779cfaee58c88344c748a2b3d4579
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111831
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/drivers/macab/MacabColumns.cxx 
b/connectivity/source/drivers/macab/MacabColumns.cxx
index 6eaa51aa7906..6a49ad1d066c 100644
--- a/connectivity/source/drivers/macab/MacabColumns.cxx
+++ b/connectivity/source/drivers/macab/MacabColumns.cxx
@@ -54,7 +54,7 @@ sdbcx::ObjectType MacabColumns::createObject(const OUString& 
_rName)
 {
 if (xRow->getString(4) == _rName)
 {
-OColumn* pRet = new OColumn(
+xRet = new OColumn(
 _rName,
 xRow->getString(6),
 xRow->getString(13),
@@ -70,7 +70,6 @@ sdbcx::ObjectType MacabColumns::createObject(const OUString& 
_rName)
 sCatalogName,
 sSchemaName,
 sTableName);
-xRet = pRet;
 break;
 }
 }
diff --git a/connectivity/source/drivers/macab/MacabConnection.cxx 
b/connectivity/source/drivers/macab/MacabConnection.cxx
index 4e5a27354e54..eaa6cf523222 100644
--- a/connectivity/source/drivers/macab/MacabConnection.cxx
+++ b/connectivity/source/drivers/macab/MacabConnection.cxx
@@ -27,6 +27,7 @@
 #include "MacabCatalog.hxx"
 #include 
 #include 
+#include 
 
 using namespace connectivity::macab;
 using namespace com::sun::star::uno;
@@ -295,8 +296,7 @@ Reference< XTablesSupplier > 
MacabConnection::createCatalog()
 Reference< XTablesSupplier > xTab = m_xCatalog;
 if (!m_xCatalog.is())
 {
-MacabCatalog *pCat = new MacabCatalog(this);
-xTab = pCat;
+xTab = new MacabCatalog(this);
 m_xCatalog = xTab;
 }
 return xTab;
@@ -309,10 +309,8 @@ MacabAddressBook* MacabConnection::getAddressBook() const
 
 extern "C" SAL_DLLPUBLIC_EXPORT void* createMacabConnection( void* _pDriver )
 {
-MacabConnection* pConnection = new MacabConnection( static_cast< 
MacabDriver* >( _pDriver ) );
 // by definition, the pointer crossing library boundaries as void ptr is 
acquired once
-pConnection->acquire();
-return pConnection;
+return cppu::acquire(new MacabConnection( static_cast< MacabDriver* >( 
_pDriver ) ));
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx 
b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
index 9b3aed095039..807cd8583e42 100644
--- a/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
+++ b/connectivity/source/drivers/macab/MacabDatabaseMetaData.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -734,8 +735,7 @@ Reference< XConnection > SAL_CALL 
MacabDatabaseMetaData::getConnection(  )
 
 Reference< XResultSet > SAL_CALL MacabDatabaseMetaData::getTableTypes(  )
 {
-::connectivity::ODatabaseMetaDataResultSet* pResult = new 
::connectivity::ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eTableTypes);
-Reference< XResultSet > xRef = pResult;
+rtl::Reference<::connectivity::ODatabaseMetaDataResultSet> pResult = new 
::connectivity::ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eTableTypes);
 
 static ODatabaseMetaDataResultSet::ORows aRows = [&]
 {
@@ -748,13 +748,12 @@ Reference< XResultSet > SAL_CALL 
MacabDatabaseMetaData::getTableTypes(  )
 return tmp;
 }();
 pResult->setRows(aRows);
-return xRef;
+return pResult;
 }
 
 Reference< XResultSet > SAL_CALL MacabDatabaseMetaData::getTypeInfo(  )
 {
-ODatabaseMetaDataResultSet* pResult = new 
ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eTypeInfo);
-Reference< XResultSet > xRef = pResult;
+rtl::Reference pResult = new 
ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eTypeInfo);
 
 static ODatabaseMetaDataResultSet::ORows aRows = [&]()
 {
@@ -806,7 +805,7 @@ Reference< XResultSet > SAL_CALL 
MacabDatabaseMetaData::getTypeInfo(  )
 return tmp;
 }();
 pResult->setRows(aRows);
-return xRef;
+return pResult;
 }
 
 Reference< XResultSet > SAL_CALL MacabDatabaseMetaData::getCatalogs(  )
@@ -832,8 +831,7 @@

[Libreoffice-bugs] [Bug 140765] New: Writer freezes with odt or ooxml file and Java enable.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140765

Bug ID: 140765
   Summary: Writer freezes with odt or ooxml file and Java enable.
   Product: LibreOffice
   Version: 7.1.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: caralu1...@yahoo.es

Created attachment 170187
  --> https://bugs.documentfoundation.org/attachment.cgi?id=170187=edit
just a text for an exam, with some links inside.

I have a file a docx and odf that freezes LO, so I re-start it in safe mode and
all works fine, so I have disabled java environment and test again, and I can
edit the file, even thought LO ask for enable java.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140759

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #5 from Julien Nabet  ---
Since I disagree here, I prefer to uncc myself and let other people decide.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/source

2021-03-02 Thread Jim Raykowski (via logerrit)

 framework/source/uielement/langselectionstatusbarcontroller.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 098f4e84f0fd605eff243c0c494c24dbec95374c
Author: Jim Raykowski 
AuthorDate: Fri Feb 26 13:49:20 2021 -0900
Commit: Jim Raykowski 
CommitDate: Tue Mar 2 22:52:06 2021 +0100

tdf#116136 don't show status bar LangSelection control tool tip

in print preview

Change-Id: I85bcb547a71b2a5666310e184d8ba1da16acc97c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111671
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/framework/source/uielement/langselectionstatusbarcontroller.cxx 
b/framework/source/uielement/langselectionstatusbarcontroller.cxx
index 2e12c12fee26..deccb5d77bcc 100644
--- a/framework/source/uielement/langselectionstatusbarcontroller.cxx
+++ b/framework/source/uielement/langselectionstatusbarcontroller.cxx
@@ -315,6 +315,7 @@ void SAL_CALL 
LangSelectionStatusbarController::statusChanged( const FeatureStat
 if ( Event.State >>= aStrValue )
 {
 m_xStatusbarItem->setText( aStrValue );
+m_xStatusbarItem->setQuickHelpText(FwkResId(STR_LANGSTATUS_HINT));
 m_aCurLang = aStrValue;
 }
 else if ( Event.State >>= aSeq )
@@ -327,6 +328,7 @@ void SAL_CALL 
LangSelectionStatusbarController::statusChanged( const FeatureStat
 aStatusText = FwkResId(STR_LANGSTATUS_MULTIPLE_LANGUAGES);
 }
 m_xStatusbarItem->setText( aStatusText );
+m_xStatusbarItem->setQuickHelpText(FwkResId(STR_LANGSTATUS_HINT));
 
 // Retrieve all other values from the sequence and
 // store it members!
@@ -339,6 +341,7 @@ void SAL_CALL 
LangSelectionStatusbarController::statusChanged( const FeatureStat
 else if ( !Event.State.hasValue() )
 {
 m_xStatusbarItem->setText( OUString() );
+m_xStatusbarItem->setQuickHelpText(u"");
 m_bShowMenu = false;// no language -> no menu
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116136] STATUSBAR: Superfluous tool tips in print preview

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116136

--- Comment #14 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/098f4e84f0fd605eff243c0c494c24dbec95374c

tdf#116136 don't show status bar LangSelection control tool tip

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138934] Hyperlink: Headings in "Target in document" window show numbered sublevels, regardless of settings in "Chapter Numbering"

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138934

--- Comment #7 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5480d9237af1cf25ac464bf49ba364a757fcf6f5

tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138934] Hyperlink: Headings in "Target in document" window show numbered sublevels, regardless of settings in "Chapter Numbering"

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138934

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114567] HYPERLINK DIALOG: "Target in document" dialog should display the level of headings

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114567

--- Comment #4 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5480d9237af1cf25ac464bf49ba364a757fcf6f5

tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114567] HYPERLINK DIALOG: "Target in document" dialog should display the level of headings

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114567

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source sw/inc sw/source

2021-03-02 Thread Jim Raykowski (via logerrit)

 cui/source/dialogs/hlmarkwn.cxx   |   48 +-
 cui/source/inc/hlmarkwn.hxx   |2 -
 sw/inc/unotxdoc.hxx   |5 +++
 sw/source/uibase/uno/unotxdoc.cxx |   47 +++--
 4 files changed, 81 insertions(+), 21 deletions(-)

New commits:
commit 5480d9237af1cf25ac464bf49ba364a757fcf6f5
Author: Jim Raykowski 
AuthorDate: Sun Jan 24 22:17:49 2021 -0900
Commit: Jim Raykowski 
CommitDate: Tue Mar 2 22:49:03 2021 +0100

tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse

Provides parent child expand/collapse for Headings in the Hyperlink-
Target in Document dialog target treeview

Change-Id: I8cc57b4cbf3830cec76d64a0ef587e199c39e360
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109930
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/cui/source/dialogs/hlmarkwn.cxx b/cui/source/dialogs/hlmarkwn.cxx
index 8996c0e6790c..cdc1039cab18 100644
--- a/cui/source/dialogs/hlmarkwn.cxx
+++ b/cui/source/dialogs/hlmarkwn.cxx
@@ -283,6 +283,9 @@ bool SvxHlinkDlgMarkWnd::RefreshFromDoc(const OUString& 
aURL)
 // Fill Tree-Control
 int SvxHlinkDlgMarkWnd::FillTree( const uno::Reference< container::XNameAccess 
>& xLinks, const weld::TreeIter* pParentEntry )
 {
+// used to create the Headings outline parent children tree view relation
+std::stack, const sal_Int32>> 
aHeadingsParentEntryStack;
+
 int nEntries=0;
 const uno::Sequence< OUString > aNames( xLinks->getElementNames() );
 const sal_Int32 nLinks = aNames.getLength();
@@ -331,7 +334,50 @@ int SvxHlinkDlgMarkWnd::FillTree( const uno::Reference< 
container::XNameAccess >
 OUString 
sId(OUString::number(reinterpret_cast(pData)));
 
 std::unique_ptr 
xEntry(mxLbTree->make_iterator());
-mxLbTree->insert(pParentEntry, -1, , , 
nullptr, nullptr, false, xEntry.get());
+if (pParentEntry)
+{
+OUString sContentType = mxLbTree->get_text(*pParentEntry);
+if (sContentType == "Headings")
+{
+if (aHeadingsParentEntryStack.empty())
+aHeadingsParentEntryStack.push(
+
std::pair(mxLbTree->make_iterator(pParentEntry), -1));
+
+// get the headings name to display
+aAny = xTarget->getPropertyValue("ActualOutlineName");
+OUString sActualOutlineName;
+aAny >>= sActualOutlineName;
+
+// get the headings outline level
+aAny = xTarget->getPropertyValue("OutlineLevel");
+sal_Int32 nOutlineLevel;
+aAny >>= nOutlineLevel;
+
+// pop until the top of stack entry has an outline 
level less than
+// the to be inserted heading outline level
+while (nOutlineLevel <= 
aHeadingsParentEntryStack.top().second)
+aHeadingsParentEntryStack.pop();
+
+
mxLbTree->insert(aHeadingsParentEntryStack.top().first.get(), -1,
+ , , nullptr, 
nullptr, false,
+ xEntry.get());
+
+// push if the inserted entry is a child
+if (nOutlineLevel > 
aHeadingsParentEntryStack.top().second)
+aHeadingsParentEntryStack.push(
+std::pair(std::move(xEntry), 
nOutlineLevel));
+}
+else
+{
+mxLbTree->insert(pParentEntry, -1, , 
, nullptr,
+ nullptr, false, xEntry.get());
+}
+}
+else
+{
+mxLbTree->insert(pParentEntry, -1, , , 
nullptr, nullptr,
+ false, xEntry.get());
+}
 
 try
 {
diff --git a/cui/source/inc/hlmarkwn.hxx b/cui/source/inc/hlmarkwn.hxx
index 9552bc10097c..d88dddab208d 100644
--- a/cui/source/inc/hlmarkwn.hxx
+++ b/cui/source/inc/hlmarkwn.hxx
@@ -30,8 +30,6 @@ class SvxHyperlinkTabPageBase;
 class SvxHlinkDlgMarkWnd : public weld::GenericDialogController
 {
 private:
-friend class SvxHlmarkTreeLBox;
-
 SvxHyperlinkTabPageBase* mpParent;
 
 sal_uInt16  mnError;
diff --git a/sw/inc/unotxdoc.hxx b/sw/inc/unotxdoc.hxx
index df6309d7125e..4dbb35b01ec8 100644
--- a/sw/inc/unotxdoc.hxx
+++ b/sw/inc/unotxdoc.hxx
@@ -558,9 +558,12 @@ class SwXOutlineTarget final : public cppu::WeakImplHelper
 {
 const SfxItemPropertySet*   m_pPropSet;
 OUStringm_sOutlineText;
+OUString

[Libreoffice-bugs] [Bug 136649] Choice of multiple columns is ignored when inserting an alphabetical index

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=136649

--- Comment #3 from David Burleigh  ---
Just tried it in version 7.1.1.1. It let me choose 2 columns and specify a 0.1
inch gap between them, and then it created the index with only one column.
(This is an Alphabetical index, by the way, using a concordance file.)
So then I edited the resulting single-column index and again specified 2
columns with a 0.1 inch gap, and this time it generated the index with two
columns.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91764] RTL: Arabic, Hebrew diacritics cant be found using search dialog

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91764

--- Comment #26 from Eyal Rozenberg  ---
(In reply to Xisco Faulí from comment #25)
> Could you please explain the steps that are fixed ? I can investigate when
> it got fixed and maybe it helps with the hebrew problem

Oh, I'm sorry, I misspoke. Current behavior is exactly the same as what I
described in my reproduction instructions for Hebrew. There is no change.

However, if you make your search diacritics-sensitive, then searching for
either BET or BET+DAGESH will find just one occurrence.


Now, on to Arabic.

First, if I follow Yousef Phillips's instructions - I get the exact same
problematic behavior: Finding a DAMMA fails, finding a KAF + DAMMA finds two
results. This is true whether your search is marked  "diacritics-sensitive" or
not (which can only be done with the dialog BTW).

If on that same document, you you type a third KAF letter, without a DAMMA - it
will be found when searching for KAF + DAMMA in non-diacritic-sensitive mode,
and will not be found when searching for KAF + DAMMA, in diacritic-sensitive
mode (which is a good thing). So, the behavior for Arabic and Hebrew seems to
be exactly the same. Marking my earlier comment obsolete.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107237

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||140764


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140764
[Bug 140764] Image Mode do not exist on TABs writer/impress/calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140764] Image Mode do not exist on TABs writer/impress/calc

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140764

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||107237
 Status|UNCONFIRMED |NEW
 CC||kain...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Confirmed.

The "Image Mode" control is absent from the MUFFIN NB 'Tabbed' UI, and is not
present to Customize.

@Andreas, intentional or an oversite?

=-testing-=

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: af64bc49d872d8a040d66387303def98eae5cd51
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140743] LibreOffice Impress can't save some transitions.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140743

Patrick  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/source

2021-03-02 Thread Stephan Bergmann (via logerrit)

 framework/source/services/frame.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9ccbf716ba16effb356c97c992d2cd738c44f767
Author: Stephan Bergmann 
AuthorDate: Tue Mar 2 16:13:16 2021 +0100
Commit: Caolán McNamara 
CommitDate: Tue Mar 2 21:42:46 2021 +0100

Fix null-pointer-use

Since df33714f0ecaf4d35011f2d2116e5e1a4ec75f1a "tdf#131000: sc: Add UItest"
introduced that test, UITest_calc_tests9
UITEST_TEST_NAME=forms.Forms.test_tdf131000 fails with

> /framework/source/services/frame.cxx:1451:34: runtime error: member call 
on null pointer of type 'vcl::Window'
> #0 0x2b0f4825f68f in (anonymous 
namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference
 const&, com::sun::star::uno::Reference 
const&) /framework/source/services/frame.cxx:1451:34
> #1 0x2b0f59361178 in 
FmPropBrw::impl_ensurePropertyBrowser_nothrow(FmFormShell*) 
/svx/source/form/fmPropBrw.cxx:508:27
> #2 0x2b0f5936236e in FmPropBrw::StateChanged(unsigned short, 
SfxItemState, SfxPoolItem const*) /svx/source/form/fmPropBrw.cxx:539:13
> #3 0x2b0f4fb3a8f0 in SfxStateCache::SetState_Impl(SfxItemState, 
SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:423:24
> #4 0x2b0f4fb39a28 in SfxStateCache::SetState(SfxItemState, 
SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:324:5
> #5 0x2b0f4f868e30 in 
SfxBindings::UpdateControllers_Impl(SfxFoundCache_Impl const&, SfxPoolItem 
const*, SfxItemState) /sfx2/source/control/bindings.cxx:1218:16
> #6 0x2b0f4f865d34 in SfxBindings::Update_Impl(SfxStateCache&) 
/sfx2/source/control/bindings.cxx:271:17
> #7 0x2b0f4f86d30c in SfxBindings::Update(unsigned short) 
/sfx2/source/control/bindings.cxx:350:13
> #8 0x2b0f4f900fc6 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot 
const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:279:24
> #9 0x2b0f4f91693f in SfxDispatcher::Execute_(SfxShell&, SfxSlot 
const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
> #10 0x2b0f4f88e55f in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot 
const*, SfxShell*) /sfx2/source/control/bindings.cxx:1060:22
> #11 0x2b0f4fd7a482 in 
SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, 
com::sun::star::uno::Sequence const&, 
com::sun::star::uno::Reference 
const&) /sfx2/source/control/unoctitm.cxx:758:53
> #12 0x2b0f4fd753c1 in 
SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, 
com::sun::star::uno::Sequence const&) 
/sfx2/source/control/unoctitm.cxx:229:16
> #13 0x2b0f3ff4de92 in comphelper::dispatchCommand(rtl::OUString 
const&, com::sun::star::uno::Reference const&, 
com::sun::star::uno::Sequence const&, 
com::sun::star::uno::Reference 
const&) /comphelper/source/misc/dispatchcommand.cxx:61:12
> #14 0x2b0f3ff4e605 in comphelper::dispatchCommand(rtl::OUString 
const&, com::sun::star::uno::Sequence 
const&, 
com::sun::star::uno::Reference 
const&) /comphelper/source/misc/dispatchcommand.cxx:76:12
> #15 0x2b0f75905186 in UITest::executeCommand(rtl::OUString const&) 
/vcl/source/uitest/uitest.cxx:24:12
> #16 0x2b0f75917a20 in (anonymous 
namespace)::UITestUnoObj::executeCommand(rtl::OUString const&) 
/vcl/source/uitest/uno/uitest_uno.cxx:69:12
> #17 0x2b0fb07ea8db in gcc3::callVirtualMethod(void*, unsigned int, 
void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, 
unsigned long*, double*) 
/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
> #18 0x2b0fb07e4bf2 in 
cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, 
bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, 
_typelib_MethodParameter*, void*, void**, _uno_Any**) 
/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
> #19 0x2b0fb07e173d in unoInterfaceProxyDispatch 
/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
> #20 0x2b0fb5c1835a in 
binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, 
std::__debug::vector 
>*) const /binaryurp/source/incomingrequest.cxx:235:13
> #21 0x2b0fb5c11f7a in binaryurp::IncomingRequest::execute() const 
/binaryurp/source/incomingrequest.cxx:78:26
> #22 0x2b0fb5ceecc7 in request /binaryurp/source/reader.cxx:85:9
> #23 0x2b0f4145fac4 in cppu_threadpool::JobQueue::enter(void const*, 
bool) /cppu/source/threadpool/jobqueue.cxx:100:17
> #24 0x2b0f414838eb in cppu_threadpool::ORequestThread::run() 
/cppu/source/threadpool/thread.cxx:165:31
> #25 0x2b0f4148f62f in threadFunc /include/osl/thread.hxx:189:15
> #26 0x2b0f37f38da8 in osl_thread_start_Impl(void*) 
/sal/osl/unx/thread.cxx:264:9
> #27 0x2b0f39ddaea4 in start_thread (/lib64/libpthread.so.0+0x7ea4)
> #28 0x2b0f3a71096c in clone (/lib64/libc.so.6+0xfe96c)

().

[Libreoffice-bugs] [Bug 140743] LibreOffice Impress can't save some transitions.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140743

Patrick  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140743] LibreOffice Impress can't save some transitions.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140743

--- Comment #2 from Patrick  ---
(In reply to Patrick from comment #0)
> Description:
> I can't save the transitions ''fine dissolution'' nor ''circles'' when I 
> sellect the trainsition .pptx 
> 
> Steps to Reproduce:
> When you want to change from one slide to another one:
> 1.Sellect the transition ''fine dissolution'' nor ''circles''.
> 2.Save the document and close it.
> 3.Open the document. The trainsition isn't there.
> 
> 
> 
> Actual Results:
> The trainsition isn't there. It has not been saved correctly.
> 
> Expected Results:
> ---
> 
> 
> Reproducible: Always
> 
> 
> User Profile Reset: No
> 
> 
> 
> Additional Info:
> ---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140743] LibreOffice Impress can't save some transitions.

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140743

--- Comment #1 from Patrick  ---
The bug only works with the extension .pptx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140753] Image tearing while scrolling GDI/SKIA with high zoom level

2021-03-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140753

--- Comment #7 from V Stuart Foote  ---
By zoom you mean the LibreOffice canvas zoom--and not the os/DE GUI scaling,
correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 4 >

1 - 100 of 357 matches

Mail list logo