[Libreoffice-bugs] [Bug 125492] Memory usage is heavily increasing on every table formatting style switch (large table)
https://bugs.documentfoundation.org/show_bug.cgi?id=125492 --- Comment #7 from Dieter --- Tested with Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Actual result LO becones unresponsive for almost 30 seconds with the first change, but works as expected with further changes. Memory usage still increases (+50MB after each change) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103304] [META] Page style dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103304 Dieter changed: What|Removed |Added Depends on||140559 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140559 [Bug 140559] FILEOPEN DOCX page layout "Bookfold" needs "mirrored" in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140559] FILEOPEN DOCX page layout "Bookfold" needs "mirrored" in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=140559 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||dgp-m...@gmx.de Blocks||103304 --- Comment #1 from Dieter --- I confirm ith with Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Actual result: Page layout setting in page style dialog is "Right and Left" Expected result: Page layout setting in page style dialog should be "Mirrored" Additional information I also don't understand, why page orientation is landscape (I assume this is taken from the DIN A4 settings in Word) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103304 [Bug 103304] [META] Page style dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141210] SELECTION: Make it more visible, if a shape is not included into a selection (because its anchor is not included)
https://bugs.documentfoundation.org/show_bug.cgi?id=141210 Dieter changed: What|Removed |Added Depends on||139668 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139668 [Bug 139668] Anchor to paragraph no included in selection when selecting a full paragraph -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139668] Anchor to paragraph no included in selection when selecting a full paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=139668 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Blocks||141210 Whiteboard| QA:needsComment| --- Comment #5 from Dieter --- I can't confirm it with Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141210 [Bug 141210] SELECTION: Make it more visible, if a shape is not included into a selection (because its anchor is not included) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=141717 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Please retest with a 7.1.3.2 build just released, x-scale of glyphs got some attention, may improve things here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Dieter changed: What|Removed |Added Depends on||141717 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141717 [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=141717 Dieter changed: What|Removed |Added Blocks||71732 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71732 [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141940] ODS File Corrupted. Error found in content.xml.
https://bugs.documentfoundation.org/show_bug.cgi?id=141940 --- Comment #4 from matchstickman --- Thanks for your help and quick responses Aron. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141718] Windows window-manager relocates open calc windows on exit from screen-saver
https://bugs.documentfoundation.org/show_bug.cgi?id=141718 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=141717 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141714] FORMATTING: Borders
https://bugs.documentfoundation.org/show_bug.cgi?id=141714 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141465] Notebookbar items aren't shown by default even if they'd fit
https://bugs.documentfoundation.org/show_bug.cgi?id=141465 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96422] LOKView No signal when search was successful
https://bugs.documentfoundation.org/show_bug.cgi?id=96422 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96422] LOKView No signal when search was successful
https://bugs.documentfoundation.org/show_bug.cgi?id=96422 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141937] Calc takes 60+ seconds to open .ODS files
https://bugs.documentfoundation.org/show_bug.cgi?id=141937 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141937] Calc takes 60+ seconds to open .ODS files
https://bugs.documentfoundation.org/show_bug.cgi?id=141937 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141831] LibreOffice becomes laggy after typing some Japanese on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=141831 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141831] LibreOffice becomes laggy after typing some Japanese on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=141831 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128264] [EDITING][FILESAVE]Formulas are shuffled maybe after saving the writer document
https://bugs.documentfoundation.org/show_bug.cgi?id=128264 --- Comment #11 from QA Administrators --- Dear schluppz, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72912] VIEWING: Snap grid and cell grid misalignment
https://bugs.documentfoundation.org/show_bug.cgi?id=72912 --- Comment #12 from QA Administrators --- Dear lujomu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108417] FILEOPEN DOCX Some embedded Arabic fonts are substituted
https://bugs.documentfoundation.org/show_bug.cgi?id=108417 --- Comment #9 from QA Administrators --- Dear kavalec74, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100757] Linear solver says 'model is infeasible', when real problem is non-linearity
https://bugs.documentfoundation.org/show_bug.cgi?id=100757 --- Comment #9 from QA Administrators --- Dear Jan Egil Kristiansen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svgio/inc svgio/source
svgio/inc/svgnode.hxx | 46 +++
svgio/source/svgreader/svganode.cxx |2 -
svgio/source/svgreader/svgcharacternode.cxx |2 -
svgio/source/svgreader/svgclippathnode.cxx |2 -
svgio/source/svgreader/svggnode.cxx |2 -
svgio/source/svgreader/svgimagenode.cxx |2 -
svgio/source/svgreader/svgmarkernode.cxx|2 -
svgio/source/svgreader/svgmasknode.cxx |2 -
svgio/source/svgreader/svgnode.cxx | 56 ++--
svgio/source/svgreader/svgpatternnode.cxx |2 -
svgio/source/svgreader/svgusenode.cxx |2 -
svgio/source/svguno/xsvgparser.cxx |4 +-
12 files changed, 62 insertions(+), 62 deletions(-)
New commits:
commit 83ff99bae3034e6ae029475dd0cf0ecc64756f6a
Author: Tomaž Vajngerl
AuthorDate: Fri Apr 30 23:01:57 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat May 1 05:05:27 2021 +0200
convert enums to enum classes in svgnode.hxx
converted XmlSpace, Display
Change-Id: I4aced2d7c2f6fcb4adc59949a6ac22d4ddd375a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114953
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svgio/inc/svgnode.hxx b/svgio/inc/svgnode.hxx
index 95d3a03be1d1..fcf31f296ba7 100644
--- a/svgio/inc/svgnode.hxx
+++ b/svgio/inc/svgnode.hxx
@@ -40,34 +40,34 @@ namespace svgio::svgreader
namespace svgio::svgreader
{
-enum XmlSpace
+enum class XmlSpace
{
-XmlSpace_notset,
-XmlSpace_default,
-XmlSpace_preserve
+NotSet,
+Default,
+Preserve
};
// display property (see SVG 1.1. 11.5), not inheritable
-enum Display // #i121656#
+enum class Display // #i121656#
{
-Display_inline, // the default
-Display_block,
-Display_list_item,
-Display_run_in,
-Display_compact,
-Display_marker,
-Display_table,
-Display_inline_table,
-Display_table_row_group,
-Display_table_header_group,
-Display_table_footer_group,
-Display_table_row,
-Display_table_column_group,
-Display_table_column,
-Display_table_cell,
-Display_table_caption,
-Display_none,
-Display_inherit
+Inline, // the default
+Block,
+ListItem,
+RunIn,
+Compact,
+Marker,
+Table,
+InlineTable,
+TableRowGroup,
+TableHeaderGroup,
+TableFooterGroup,
+TableRow,
+TableColumnGroup,
+TableColumn,
+TableCell,
+TableCaption,
+None,
+Inherit
};
// helper to convert a string associated with a token of type
SVGTokenDisplay
diff --git a/svgio/source/svgreader/svganode.cxx
b/svgio/source/svgreader/svganode.cxx
index ad4483423100..6065ed498e42 100644
--- a/svgio/source/svgreader/svganode.cxx
+++ b/svgio/source/svgreader/svganode.cxx
@@ -84,7 +84,7 @@ namespace svgio::svgreader
const double fOpacity(pStyle->getOpacity().getNumber());
-if(fOpacity > 0.0 && Display_none != getDisplay())
+if (fOpacity > 0.0 && Display::None != getDisplay())
{
drawinglayer::primitive2d::Primitive2DContainer aContent;
diff --git a/svgio/source/svgreader/svgcharacternode.cxx
b/svgio/source/svgreader/svgcharacternode.cxx
index ff30730cf1eb..e0b66c6f8ee2 100644
--- a/svgio/source/svgreader/svgcharacternode.cxx
+++ b/svgio/source/svgreader/svgcharacternode.cxx
@@ -524,7 +524,7 @@ namespace svgio::svgreader
void SvgCharacterNode::whiteSpaceHandling()
{
-if(XmlSpace_default == getXmlSpace())
+if (XmlSpace::Default == getXmlSpace())
{
maText = whiteSpaceHandlingDefault(maText);
}
diff --git a/svgio/source/svgreader/svgclippathnode.cxx
b/svgio/source/svgreader/svgclippathnode.cxx
index a90d6adb8c2b..1a8269684095 100644
--- a/svgio/source/svgreader/svgclippathnode.cxx
+++ b/svgio/source/svgreader/svgclippathnode.cxx
@@ -125,7 +125,7 @@ namespace svgio::svgreader
drawinglayer::primitive2d::Primitive2DContainer& rContent,
const basegfx::B2DHomMatrix* pTransform) const
{
-if(rContent.empty() || Display_none == getDisplay())
+if (rContent.empty() || Display::None == getDisplay())
return;
const drawinglayer::geometry::ViewInformation2D aViewInformation2D;
diff --git a/svgio/source/svgreader/svggnode.cxx
b/svgio/source/svgreader/svggnode.cxx
index 1d32de448517..e186387a80ba 100644
--- a/svgio/source/svgreader/svggnode.cxx
+++ b/svgio/source/svgreader/svggnode.cxx
[Libreoffice-commits] core.git: svgio/inc svgio/source
svgio/inc/svgtools.hxx| 62 +--
svgio/source/svgreader/svgcharacternode.cxx | 16 +--
svgio/source/svgreader/svgcirclenode.cxx |4
svgio/source/svgreader/svgclippathnode.cxx|8 -
svgio/source/svgreader/svgellipsenode.cxx |8 -
svgio/source/svgreader/svggradientnode.cxx| 22 ++--
svgio/source/svgreader/svgimagenode.cxx |8 -
svgio/source/svgreader/svglinenode.cxx|8 -
svgio/source/svgreader/svgmasknode.cxx| 40 +++
svgio/source/svgreader/svgnode.cxx|4
svgio/source/svgreader/svgpatternnode.cxx | 30 ++---
svgio/source/svgreader/svgrectnode.cxx| 12 +-
svgio/source/svgreader/svgstyleattributes.cxx | 80 +++
svgio/source/svgreader/svgsvgnode.cxx | 36 +++---
svgio/source/svgreader/svgtextpathnode.cxx|2
svgio/source/svgreader/svgtools.cxx | 138 +-
svgio/source/svgreader/svgusenode.cxx |4
17 files changed, 241 insertions(+), 241 deletions(-)
New commits:
commit bd0c965b1ba9a15497f92102d5d11c84df091b2f
Author: Tomaž Vajngerl
AuthorDate: Fri Apr 30 22:47:30 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat May 1 04:29:31 2021 +0200
convert enums to enum classes in svgtools.hxx
converted SvgUnits, NumberType, SvgUnit, SvgAlign
Change-Id: I703b1d9396f42b3af1a36c683628e90161f2717d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114952
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svgio/inc/svgtools.hxx b/svgio/inc/svgtools.hxx
index 82d58cc2e472..c4a88d89d05f 100644
--- a/svgio/inc/svgtools.hxx
+++ b/svgio/inc/svgtools.hxx
@@ -44,13 +44,13 @@ namespace svgio::svgreader
static constexpr OUStringLiteral aStrEvenOdd = u"evenodd";
};
-enum SvgUnits
+enum class SvgUnits
{
userSpaceOnUse,
objectBoundingBox
};
-enum NumberType
+enum class NumberType
{
xcoordinate,
ycoordinate,
@@ -68,20 +68,20 @@ namespace svgio::svgreader
virtual double getCurrentXHeightInherited() const = 0;
};
-enum SvgUnit
+enum class SvgUnit
{
-Unit_em = 0,// relative to current font size
-Unit_ex,// relative to current x-height
-
-Unit_px,// 'user unit'
-Unit_pt,// points, 1.25 px
-Unit_pc,// 15.0 px
-Unit_cm,// 35.43307 px
-Unit_mm,// 3.543307 px
-Unit_in,// 90 px
-
-Unit_percent, // relative to range
-Unit_none // for stroke-miterlimit, which has no unit
+em = 0,// relative to current font size
+ex,// relative to current x-height
+
+px,// 'user unit'
+pt,// points, 1.25 px
+pc,// 15.0 px
+cm,// 35.43307 px
+mm,// 3.543307 px
+in,// 90 px
+
+percent, // relative to range
+none // for stroke-miterlimit, which has no unit
};
class SvgNumber
@@ -95,12 +95,12 @@ namespace svgio::svgreader
public:
SvgNumber()
: mfNumber(0.0),
-meUnit(Unit_px),
+meUnit(SvgUnit::px),
mbSet(false)
{
}
-SvgNumber(double fNum, SvgUnit aSvgUnit = Unit_px, bool bSet =
true)
+SvgNumber(double fNum, SvgUnit aSvgUnit = SvgUnit::px, bool bSet =
true)
: mfNumber(fNum),
meUnit(aSvgUnit),
mbSet(bSet)
@@ -124,28 +124,28 @@ namespace svgio::svgreader
bool isPositive() const;
-// Only usable in cases, when the unit is not Unit_percent,
otherwise use method solve
+// Only usable in cases, when the unit is not SvgUnit::percent,
otherwise use method solve
double solveNonPercentage(const InfoProvider& rInfoProvider) const;
-double solve(const InfoProvider& rInfoProvider, NumberType
aNumberType = length) const;
+double solve(const InfoProvider& rInfoProvider, NumberType
aNumberType = NumberType::length) const;
};
typedef ::std::vector< SvgNumber > SvgNumberVector;
-enum SvgAlign
+enum class SvgAlign
{
-Align_none,
-Align_xMinYMin,
-Align_xMidYMin,
-Align_xMaxYMin,
-Align_xMinYMid,
-Align_xMidYMid, // default
-Align_xMaxYMid,
-Align_xMinYMax,
-Align_xMidYMax,
-Align_xMaxYMax
+none,
+xMinYMin,
+xMidYMin,
+xMaxYMin,
+xMinYMid,
+
[Libreoffice-bugs] [Bug 142007] [EMF] AngleArc is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=142007 --- Comment #2 from Valek Filippov --- Created attachment 171550 --> https://bugs.documentfoundation.org/attachment.cgi?id=171550=edit Screenshot for the attached sample opened in MSO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142007] [EMF] AngleArc is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=142007 --- Comment #1 from Valek Filippov --- Created attachment 171549 --> https://bugs.documentfoundation.org/attachment.cgi?id=171549=edit EMF sample with AngleArc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142007] [EMF] AngleArc is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=142007 Valek Filippov changed: What|Removed |Added Blocks||103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Valek Filippov changed: What|Removed |Added Depends on||142007 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142007 [Bug 142007] [EMF] AngleArc is not supported -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142007] New: [EMF] AngleArc is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=142007 Bug ID: 142007 Summary: [EMF] AngleArc is not supported Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@df.ru Description: LO seems to ignore AngelArc record in EMF. File is loaded as an empty picture. Steps to Reproduce: Load attached EMF sample. Actual Results: LO shows an empty picture. Expected Results: Line from 0,0 to 50,30 and 120 degrees CCW arc w center at 30,30 and radius 20 started from 50,30 Reproducible: Always User Profile Reset: No Additional Info: That also doesn't work if wrapped in PathBegin/PathEnd. Sample will be provided on request. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142006] [EMF] Path with MoveTo and two LineTo
https://bugs.documentfoundation.org/show_bug.cgi?id=142006 --- Comment #2 from Valek Filippov --- Created attachment 171548 --> https://bugs.documentfoundation.org/attachment.cgi?id=171548=edit EMF sample with path/move/line/line/end/stroke -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142006] [EMF] Path with MoveTo and two LineTo
https://bugs.documentfoundation.org/show_bug.cgi?id=142006 --- Comment #1 from Valek Filippov --- Created attachment 171547 --> https://bugs.documentfoundation.org/attachment.cgi?id=171547=edit Screenshot for the attached sample opened in MSO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Valek Filippov changed: What|Removed |Added Depends on||142006 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142006 [Bug 142006] [EMF] Path with MoveTo and two LineTo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142006] [EMF] Path with MoveTo and two LineTo
https://bugs.documentfoundation.org/show_bug.cgi?id=142006 Valek Filippov changed: What|Removed |Added Blocks||103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142006] New: [EMF] Path with MoveTo and two LineTo
https://bugs.documentfoundation.org/show_bug.cgi?id=142006 Bug ID: 142006 Summary: [EMF] Path with MoveTo and two LineTo Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@df.ru Description: LO rendered a EMF file with PathBegin/MoveToEx/LineTo/PathEnd/Stroke/Path, but failed to draw anything with one more LineTo added. Steps to Reproduce: Open attached EMF sample in LO. Actual Results: LO shows nothing (probably fails to load at all -- not even empty object is shown.) Expected Results: Should show a polyline going from 10,10 to 50,20 to 0,0 Reproducible: Always User Profile Reset: No Additional Info: Additional samples available (No raincheck). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122206] FILEOPEN: Opening XML file with XSLT filter opens with plain text import dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=122206 --- Comment #24 from Jean-Christophe Helary --- In fact, when I "Test XSLT" on the test file I get a "General Error General input/output error"... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/native-code.py | 41 ++---
1 file changed, 38 insertions(+), 3 deletions(-)
New commits:
commit a52590d76b89dc75be2aa87f4287624c89f1e82f
Author: Tomaž Vajngerl
AuthorDate: Fri Apr 30 22:01:24 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat May 1 03:03:16 2021 +0200
update native-code.py with services for vba scripts in Calc
Change-Id: I54eb60d3be2717c17daa6b7634ccee3e099cbb7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114932
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 7238055883dd..0cbb5cc9cc8d 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -26,6 +26,9 @@ core_factory_list = [
]
core_constructor_list = [
+# basic/util/sb.component
+("com_sun_star_comp_sfx2_DialogLibraryContainer_get_implementation","#if
HAVE_FEATURE_SCRIPTING"),
+("com_sun_star_comp_sfx2_ScriptLibraryContainer_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
# UnoControls/util/ctl.component
"stardiv_UnoControls_FrameControl_get_implementation",
"stardiv_UnoControls_ProgressBar_get_implementation",
@@ -272,6 +275,19 @@ core_constructor_list = [
("i18npool_NumToTextUpper_zh_TW_get_implementation", "#if WITH_LOCALE_ALL
|| WITH_LOCALE_zh"),
# i18nsearch/sourceh/search/i18nsearch.component
"i18npool_TextSearch_get_implementation",
+# io/source/io.component
+"io_Pump_get_implementation",
+"io_ODataInputStream_get_implementation",
+"io_ODataOutputStream_get_implementation",
+"io_OMarkableInputStream_get_implementation",
+"io_OMarkableOutputStream_get_implementation",
+"io_OObjectInputStream_get_implementation",
+"io_OObjectOutputStream_get_implementation",
+"io_OPipeImpl_get_implementation",
+"io_OAcceptor_get_implementation",
+"io_OConnector_get_implementation",
+"io_OTextInputStream_get_implementation",
+"io_OTextOutputStream_get_implementation",
# linguistic/source/lng.component
"linguistic_ConvDicList_get_implementation",
"linguistic_DicList_get_implementation",
@@ -296,6 +312,13 @@ core_constructor_list = [
"com_sun_star_comp_extensions_xml_sax_FastParser_get_implementation",
"com_sun_star_comp_extensions_xml_sax_ParserExpat_get_implementation",
"com_sun_star_extensions_xml_sax_Writer_get_implementation",
+# scripting/util/scriptframe.component
+("scripting_BrowseNodeFactoryImpl_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
+("scripting_MasterScriptProvider_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
+("scripting_MasterScriptProviderFactory_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
+("scripting_ScriptingFrameworkURIHelper_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
+# scripting/source/basprov/basprov.component
+("scripting_BasicProviderImpl_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
# sfx2/util/sfx.component
"SfxDocumentMetaData_get_implementation",
"com_sun_star_comp_office_FrameLoader_get_implementation",
@@ -406,6 +429,8 @@ core_constructor_list = [
# ucb/source/ucp/ucphier1.component
"ucb_HierarchyContentProvider_get_implementation",
"ucb_HierarchyDataSource_get_implementation",
+# ucb/source/ucp/package/ucppkg1
+"ucb_package_ContentProvider_get_implementation",
# unotools/util/utl.component
"unotools_ServiceDocument_get_implementation",
"unotools_OTempFileService_get_implementation",
@@ -590,6 +615,16 @@ calc_constructor_list = [
# sc/util/scfilt.component
"com_sun_star_comp_oox_xls_ExcelFilter_get_implementation",
"com_sun_star_comp_oox_xls_FormulaParser_get_implementation",
+# sc/util/vbaobj.component
+("Calc_ScVbaApplication_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("ScVbaEventsHelper_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("ScVbaGlobals_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("Calc_ScVbaHyperlink_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("ScVbaTextFrame_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("Calc_ScVbaWindow_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("Calc_ScVbaWorkbook_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("Calc_ScVbaWorksheet_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
+("Calc_ScVbaRange_get_implementation", "#if HAVE_FEATURE_SCRIPTING"),
# scaddins/source/analysis/analysis.component
"scaddins_AnalysisAddIn_get_implementation",
# scaddins/source/datefunc/date.component
@@ -601,6 +636,9 @@ calc_constructor_list = [
# svl/util/svl.component
"com_sun_star_uno_util_numbers_SvNumberFormatsSupplierServiceObject_get_implementation",
"com_sun_star_uno_util_numbers_SvNumberFormatterServiceObject_get_implementation",
+# scripting/source/vbaevents/vbaevents.component
+("ooo_vba_VBAToOOEventDesc_get_implementation", "#if
HAVE_FEATURE_SCRIPTING"),
+
[Libreoffice-bugs] [Bug 122206] FILEOPEN: Opening XML file with XSLT filter opens with plain text import dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=122206 Jean-Christophe Helary changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #23 from Jean-Christophe Helary --- Steven, can you give item by item directions for installing the filter and opening the file because it looks like the procedure I'm following (seemingly the one you describe in your first comment) does not show improvement. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142005] New: Spreadsheet doesn't display properly
https://bugs.documentfoundation.org/show_bug.cgi?id=142005 Bug ID: 142005 Summary: Spreadsheet doesn't display properly Product: LibreOffice Version: 7.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mclemore...@gmail.com Description: I was directed to this site to report documents not displaying correctly, if this is not the right place please let me know so I can report it properly. I have a Microsoft excel spreadsheet that doesn't display properly in Libre Office. The second page of the spreadsheet is suppose to display a plot with confidence intervals, however it is slightly messed up in Libre Office. The problem is purely with how libre office is displaying the dot in the center of each confidence interval. Libre office has a line instead of a dot, and the line is even in the wrong place. I don't want to reupload this users spreadsheet without permission, so I am linking to their site. http://kurtosis.co.uk/technique/confidence/confidence.htm The spreadhseet they have linked on the site " Confidence Interval Data.xls" is the one in question. Steps to Reproduce: 1. Visit http://kurtosis.co.uk/technique/confidence/confidence.ht 2. Download "Confidence Interval Data.xls" 3. Open the file using Libre office 4. Go to the second page Actual Results: Libre office displays a mostly correct graphic with the, but with the dot in the wrong place, and it showing up as a line. Expected Results: I expect Libre office to (preferably) show exactly what I see in excel, or at least something comparable. I can deal with the graph showing a dot instead of a line, but it needs to at least be in the right place. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142004] [EMF] SelectClipPath support
https://bugs.documentfoundation.org/show_bug.cgi?id=142004 --- Comment #3 from Valek Filippov --- Created attachment 171546 --> https://bugs.documentfoundation.org/attachment.cgi?id=171546=edit EMF sample with ellipse as part of the path w/o any Stroke or Fill The first sample probably contains at least two problems. LO should not do any drawing with a path if there is no Stroke, Fill or StrokeAndFill command. Simplified sample is just an ellipse inside the path brackets. MSO shows it empty. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Valek Filippov changed: What|Removed |Added Depends on||142004 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142004 [Bug 142004] [EMF] SelectClipPath support -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142004] [EMF] SelectClipPath support
https://bugs.documentfoundation.org/show_bug.cgi?id=142004 Valek Filippov changed: What|Removed |Added Blocks||103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142004] [EMF] SelectClipPath support
https://bugs.documentfoundation.org/show_bug.cgi?id=142004 --- Comment #2 from Valek Filippov --- Created attachment 171545 --> https://bugs.documentfoundation.org/attachment.cgi?id=171545=edit Screenshot for the attached sample opened in MSO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142004] [EMF] SelectClipPath support
https://bugs.documentfoundation.org/show_bug.cgi?id=142004 --- Comment #1 from Valek Filippov --- Created attachment 171544 --> https://bugs.documentfoundation.org/attachment.cgi?id=171544=edit EMF sample with elliptical clip path and rectanlge -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142004] New: [EMF] SelectClipPath support
https://bugs.documentfoundation.org/show_bug.cgi?id=142004 Bug ID: 142004 Summary: [EMF] SelectClipPath support Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@df.ru Description: LO ignores SelectClipPath and draws the path instead. Steps to Reproduce: Open attached EMF sample. Actual Results: LO draws rectangle on top of the ellipse. Expected Results: To draw part of the rectangle that overlaps with the ellipse. Reproducible: Always User Profile Reset: No Additional Info: Other samples available on request. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94657] borders not visible on loading docx
https://bugs.documentfoundation.org/show_bug.cgi?id=94657 --- Comment #12 from Asif Ali Rizvan --- Yes, bug still exists in 7.0.4.2 on Debian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Michael Warner changed: What|Removed |Added Depends on||92752 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=92752 [Bug 92752] Name changes in Finder not recognized by LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92752] Name changes in Finder not recognized by LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=92752 Michael Warner changed: What|Removed |Added Blocks||42082 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92752] Name changes in Finder not recognized by LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=92752 Michael Warner changed: What|Removed |Added CC||birnb...@posteo.de --- Comment #6 from Michael Warner --- *** Bug 141855 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141855] Saving document under new title does not change displayed document location
https://bugs.documentfoundation.org/show_bug.cgi?id=141855 Michael Warner changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Michael Warner --- *** This bug has been marked as a duplicate of bug 92752 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: drawinglayer/source
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx | 91 -
1 file changed, 59 insertions(+), 32 deletions(-)
New commits:
commit 565824df07913f47851804daed9efa28a4a95e9d
Author: Luboš Luňák
AuthorDate: Fri Apr 30 16:41:19 2021 +0200
Commit: Luboš Luňák
CommitDate: Sat May 1 00:17:46 2021 +0200
fix dashed line info conversion for metafile (tdf#136957)
My previous change had two problems:
- It didn't handle correctly the case when something repeated,
such as dash-dot-dot.
- The rounding when setting lengths was a left-over from my first
attempt when LineInfo used integers and not floats.
Change-Id: I914241590b1ddec22df04c05dfe65e76e921ee52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114940
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
index 0dc0904015f0..8837354fc706 100644
--- a/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
@@ -1591,40 +1591,67 @@ void
VclMetafileProcessor2D::processPolygonStrokePrimitive2D(
{
aHairLinePolyPolygon.append(rBasePolygon);
}
-else if (rStroke.getDotDashArray().size() == 2)
-{
-aHairLinePolyPolygon.append(rBasePolygon);
-// This will be used by setupStrokeAttributes() in cppcanvas.
-aLineInfo.SetStyle(LineStyle::Dash);
-aLineInfo.SetDashCount(1);
-aLineInfo.SetDashLen(
-
basegfx::fround(getTransformedLineWidth(rStroke.getDotDashArray()[0])));
-aLineInfo.SetDistance(
-
basegfx::fround(getTransformedLineWidth(rStroke.getDotDashArray()[1])));
-}
-else if (rStroke.getDotDashArray().size() == 4
- && rStroke.getDotDashArray()[1] ==
rStroke.getDotDashArray()[3])
-{
-aHairLinePolyPolygon.append(rBasePolygon);
-// This will be used by setupStrokeAttributes() in cppcanvas.
-aLineInfo.SetStyle(LineStyle::Dash);
-aLineInfo.SetDashCount(1);
-aLineInfo.SetDashLen(
-
basegfx::fround(getTransformedLineWidth(rStroke.getDotDashArray()[0])));
-aLineInfo.SetDistance(
-
basegfx::fround(getTransformedLineWidth(rStroke.getDotDashArray()[1])));
-aLineInfo.SetDotCount(1);
-aLineInfo.SetDotLen(
-
basegfx::fround(getTransformedLineWidth(rStroke.getDotDashArray()[2])));
-}
else
{
-// LineInfo can hold only limited info about dashing, apply
dashing manually
-// if LineInfo cannot describe it. That should not happen
though.
-SAL_WARN("drawinglayer", "dotdash array cannot be converted to
LineInfo");
-basegfx::utils::applyLineDashing(rBasePolygon,
rStroke.getDotDashArray(),
- ,
nullptr,
- rStroke.getFullDotDashLen());
+bool done = false;
+const std::vector& array = rStroke.getDotDashArray();
+// The dotdash array should generally have the form
+// ( )+ ( )*
+// (where (,),+ and * have their regex meaning).
+// Find out what the lengths and their counts are.
+if (!array.empty() && array.size() % 2 == 0)
+{
+double dashLen = array[0];
+double distance = array[1];
+int dashCount = 1;
+double dotLen = 0;
+int dotCount = 0;
+size_t pos = 2;
+while (pos + 2 <= array.size())
+{
+if (array[pos] != dashLen || array[pos + 1] !=
distance)
+break;
+++dashCount;
+pos += 2;
+}
+if (pos + 2 <= array.size() && array[pos + 1] == distance)
+{
+dotLen = array[pos];
+++dotCount;
+pos += 2;
+while (pos + 2 <= array.size())
+{
+if (array[pos] != dotLen || array[pos + 1] !=
distance)
+break;
+++dotCount;
+pos += 2;
+}
+}
+if (array.size() == pos)
+{
+aHairLinePolyPolygon.append(rBasePolygon);
+
[Libreoffice-bugs] [Bug 75059] FILTER: Drop down menu does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=75059 --- Comment #15 from Vasco Alves --- Still broken -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141949] hidden section reappear only at the next file opening
https://bugs.documentfoundation.org/show_bug.cgi?id=141949 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Olivier Hallot --- Confirmed. On changing the variable to unhide, the section stays hidden, no matter how you update all. To view the hidden section, save and reload the file. Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: pt-BR (pt_BR.UTF-8); UI: pt-BR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/inc/interpre.hxx |2 -
sc/source/core/tool/interpr3.cxx | 41 +++
2 files changed, 21 insertions(+), 22 deletions(-)
New commits:
commit 4283fb9d4a6152643364bfe1f98ee1f36aabbb78
Author: dante
AuthorDate: Wed Apr 28 19:37:21 2021 +0200
Commit: Mike Kaganski
CommitDate: Fri Apr 30 23:29:59 2021 +0200
tdf#137679 Use kahan summation for ScInterpreter::CalculateSkew
Change-Id: Ib9e34fd14d9968a5a8c79805da4f12d9a3422de8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114818
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index bdde25a12c24..c7b93798bc58 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -835,7 +835,7 @@ private:
void ScSumX2DY2();
void ScSumXMY2();
void ScGrowth();
-bool CalculateSkew(double& fSum,double& fCount,double&
vSum,std::vector& values);
+bool CalculateSkew(KahanSum& fSum, double& fCount, std::vector&
values);
void CalculateSkewOrSkewp( bool bSkewp );
void CalculateSlopeIntercept(bool bSlope);
void CalculateSmallLarge(bool bSmall);
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index 7adee328c37a..d41f4f98b475 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -2872,9 +2872,10 @@ void ScInterpreter::ScChiTest()
void ScInterpreter::ScKurt()
{
-double fSum,fCount,vSum;
+KahanSum fSum;
+double fCount;
std::vector values;
-if ( !CalculateSkew(fSum,fCount,vSum,values) )
+if ( !CalculateSkew(fSum, fCount, values) )
return;
// ODF 1.2 constraints: # of numbers >= 4
@@ -2885,31 +2886,30 @@ void ScInterpreter::ScKurt()
return;
}
-double fMean = fSum / fCount;
-
+KahanSum vSum;
+double fMean = fSum.get() / fCount;
for (double v : values)
vSum += (v - fMean) * (v - fMean);
-double fStdDev = sqrt(vSum / (fCount - 1.0));
-double xpower4 = 0.0;
-
+double fStdDev = sqrt(vSum.get() / (fCount - 1.0));
if (fStdDev == 0.0)
{
PushError( FormulaError::DivisionByZero);
return;
}
+KahanSum xpower4 = 0.0;
for (double v : values)
{
double dx = (v - fMean) / fStdDev;
-xpower4 = xpower4 + (dx * dx * dx * dx);
+xpower4 += (dx * dx) * (dx * dx);
}
double k_d = (fCount - 2.0) * (fCount - 3.0);
double k_l = fCount * (fCount + 1.0) / ((fCount - 1.0) * k_d);
double k_t = 3.0 * (fCount - 1.0) * (fCount - 1.0) / k_d;
-PushDouble(xpower4 * k_l - k_t);
+PushDouble(xpower4.get() * k_l - k_t);
}
void ScInterpreter::ScHarMean()
@@ -3220,7 +3220,7 @@ void ScInterpreter::ScStandard()
PushDouble((x-mue)/sigma);
}
}
-bool ScInterpreter::CalculateSkew(double& fSum,double& fCount,double&
vSum,std::vector& values)
+bool ScInterpreter::CalculateSkew(KahanSum& fSum, double& fCount,
std::vector& values)
{
short nParamCount = GetByte();
if ( !MustHaveParamCountMin( nParamCount, 1 ) )
@@ -3228,7 +3228,6 @@ bool ScInterpreter::CalculateSkew(double& fSum,double&
fCount,double& vSum,std::
fSum = 0.0;
fCount = 0.0;
-vSum = 0.0;
double fVal = 0.0;
ScAddress aAdr;
ScRange aRange;
@@ -3328,9 +3327,10 @@ bool ScInterpreter::CalculateSkew(double& fSum,double&
fCount,double& vSum,std::
void ScInterpreter::CalculateSkewOrSkewp( bool bSkewp )
{
-double fSum, fCount, vSum;
+KahanSum fSum;
+double fCount;
std::vector values;
-if (!CalculateSkew( fSum, fCount, vSum, values))
+if (!CalculateSkew( fSum, fCount, values))
return;
// SKEW/SKEWP's constraints: they require at least three numbers
if (fCount < 3.0)
@@ -3340,30 +3340,29 @@ void ScInterpreter::CalculateSkewOrSkewp( bool bSkewp )
return;
}
-double fMean = fSum / fCount;
-
+KahanSum vSum;
+double fMean = fSum.get() / fCount;
for (double v : values)
vSum += (v - fMean) * (v - fMean);
-double fStdDev = sqrt( vSum / (bSkewp ? fCount : (fCount - 1.0)));
-double xcube = 0.0;
-
+double fStdDev = sqrt( vSum.get() / (bSkewp ? fCount : (fCount - 1.0)));
if (fStdDev == 0)
{
PushIllegalArgument();
return;
}
+KahanSum xcube = 0.0;
for (double v : values)
{
double dx = (v - fMean) / fStdDev;
-xcube = xcube + (dx * dx * dx);
+xcube += dx * dx * dx;
}
if (bSkewp)
-PushDouble( xcube / fCount );
+PushDouble( xcube.get() / fCount );
else
-PushDouble( ((xcube * fCount) / (fCount - 1.0)) / (fCount - 2.0) );
+PushDouble( ((xcube.get() * fCount) / (fCount - 1.0)) / (fCount - 2.0)
);
}
void ScInterpreter::ScSkew()
___
Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 142003] Tracked changes in .doc file footnotes shift to the right
https://bugs.documentfoundation.org/show_bug.cgi?id=142003 --- Comment #1 from tevery.best...@gmail.com --- Created attachment 171543 --> https://bugs.documentfoundation.org/attachment.cgi?id=171543=edit Example file with the problem clearly visible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90278] VBA Compatibility - Regression on Range().Borders().Weight()
https://bugs.documentfoundation.org/show_bug.cgi?id=90278 Andreas Heinisch changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142003] New: Tracked changes in .doc file footnotes shift to the right
https://bugs.documentfoundation.org/show_bug.cgi?id=142003 Bug ID: 142003 Summary: Tracked changes in .doc file footnotes shift to the right Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tevery.best...@gmail.com Description: Whenever I save or open a .doc file, any tracked changes in footnotes shift two characters to the right: the first two characters of any deleted string are restored and the following two characters (whether new additions or present before) are removed; the first two characters of any added string are marked as accepted and the first two characters after the new string ends are marked as new additions. If the change is restricted to one character, the change markers are still shifted two characters to the right. This seriously hinders tracking changes Keywords: EDITING, FILESAVE Steps to Reproduce: 1. Create a new file. 2. Add a footnote containing any amount of text. 3. Enable Track Changes. Introduce any changes to the footnote. DO NOT accept the changes. 4. Save the file as .doc. 5. Close the file. 6. Open the file again. Actual Results: Both the beginning and the ending of every change in the footnote was shifted two characters to the right. Expected Results: The changes stay where they were. Reproducible: Always User Profile Reset: Yes Additional Info: I do not have an option to enable/disable OpenGL, but Skia is enabled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141979] Absturz in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=141979 wteuschel changed: What|Removed |Added Status|NEEDINFO|REOPENED --- Comment #3 from wteuschel --- UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122206] FILEOPEN: Opening XML file with XSLT filter opens with plain text import dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=122206 Steve Edmonds changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #22 from Steve Edmonds --- Just checked with 7.1.2.2 and the bug no longer presents. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: codemaker/source include/sal
codemaker/source/cppumaker/cpputype.cxx |2 +-
include/sal/types.h | 16
2 files changed, 17 insertions(+), 1 deletion(-)
New commits:
commit 6a113a4f14808ac7f4bbdb4a5baff9383541d49a
Author: Stephan Bergmann
AuthorDate: Fri Apr 30 13:23:07 2021 +0200
Commit: Stephan Bergmann
CommitDate: Fri Apr 30 22:46:39 2021 +0200
throw() -> noexcept, part 1/3: Manual scaffolding
The legacy `throw()` dynamic exception specification is gone for good from
C++20
(even if compilers typically still accept it, but e.g. Clang has
-Wdeprecated-dynamic-exception-spec to at least warn about it).
Introduce SAL_NOEXCEPT for use in URE interface include files. (For both
the
existing SAL_THROW_EXTERN_C and the new SAL_NOEXCEPT, base usage of
`noexept`
not on LIBO_INTERNAL_ONLY, but on the actual compiler C++ version, so that
e.g.
building CppunitTest_cppu_any-external, which uses
gb_CppunitTest_set_external_code but not gb_CXX03FLAGS, will not potentially
complain about those macros expanding to the legacy `throw()`, like when
building with Clang -Wdeprecated-dynamic-exception-spec manually enabled.)
Change-Id: I7e5c7f8d5f0fd622cfc9987d656b1f68541375aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114908
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/codemaker/source/cppumaker/cpputype.cxx
b/codemaker/source/cppumaker/cpputype.cxx
index 1ab587040b82..be1b2c2b5cc2 100644
--- a/codemaker/source/cppumaker/cpputype.cxx
+++ b/codemaker/source/cppumaker/cpputype.cxx
@@ -1173,7 +1173,7 @@ void InterfaceType::dumpDeclaration(FileStream & out)
out << "protected:\n";
inc();
out << indent() << "~" << id_
-<< ("() throw () {} // avoid warnings about virtual members and"
+<< ("() SAL_NOEXCEPT {} // avoid warnings about virtual members and"
" non-virtual dtor\n");
dec();
out << "};\n\n";
diff --git a/include/sal/types.h b/include/sal/types.h
index 7733920f20be..5fac8e8f9d3b 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -328,7 +328,11 @@ typedef struct _sal_Sequence
This is a macro so it can expand to nothing in C code.
*/
#if defined __cplusplus
+#if __cplusplus >= 201103L
+#define SAL_THROW_EXTERN_C() noexcept
+#else
#define SAL_THROW_EXTERN_C() throw ()
+#endif
#else
#define SAL_THROW_EXTERN_C()
#endif
@@ -400,6 +404,18 @@ namespace css = ::com::sun::star;
#define SAL_CONSTEXPR
#endif
+/** Macro for C++11 "noexcept" vs. "throw ()" exception specification.
+
+The latter has has been removed completely from C++20.
+
+@since LibreOffice 7.2
+ */
+#if __cplusplus >= 201103L
+#define SAL_NOEXCEPT noexcept
+#else
+#define SAL_NOEXCEPT throw ()
+#endif
+
#endif /* __cplusplus */
#ifdef __cplusplus
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1478001: Null pointer dereferences (REVERSE_INULL)
/vcl/unx/generic/gdi/salvd.cxx: 130 in
X11SalVirtualDevice::X11SalVirtualDevice(const SalGraphics *, long &, long &,
DeviceFormat, const SystemGraphicsData *, std::unique_ptr>)()
*** CID 1478001: Null pointer dereferences (REVERSE_INULL)
/vcl/unx/generic/gdi/salvd.cxx: 130 in
X11SalVirtualDevice::X11SalVirtualDevice(const SalGraphics *, long &, long &,
DeviceFormat, const SystemGraphicsData *, std::unique_ptr>)()
124 bExternPixmap_ = true;
125 }
126 else
127 {
128 nDX_ = nDX;
129 nDY_ = nDY;
>>> CID 1478001: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pGraphics" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
130 m_nXScreen = pGraphics ? static_cast(pGraphics)->GetScreenNumber() :
131
vcl_sal::getSalDisplay(GetGenericUnixSalData())->GetDefaultXScreen();
132 hDrawable_ = limitXCreatePixmap( GetXDisplay(),
133 pDisplay_->GetDrawable(
m_nXScreen ),
134 nDX_, nDY_,
135 GetDepth() );
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dv0j9_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiR9y3GSOtackX7-2FbTMWD53A1TjnpzgoighLs7brjfqYXwDAz8HCw7-2BObBObXVrXvvMVALA1qzXXBJ-2FcCzQZ-2FkTx9Cohnbie4C5Z5NmGiLT6u01pSdpvDP2B3a1lZZbHpgQjEmQ21iB55owHL5tusebfQ0fZFXUOJfiJJVGz-2Bx0XQ-3D
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f4880d0804478ba1edcb9f676278b77bd2bd7343 Author: Alain Romedenne AuthorDate: Fri Apr 30 22:14:29 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Apr 30 22:14:29 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 6b24e1b46b633ccbbf65159f858c9a496479e426 - sf_basic.xhp pt. 2 Change-Id: Icb81fca7bdea283d3da6c113d1305d47c5bc6ff3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114867 Tested-by: Jenkins Reviewed-by: Rafael Lima diff --git a/helpcontent2 b/helpcontent2 index 4ee2f0f82f99..6b24e1b46b63 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4ee2f0f82f99a865e765309eda367d5fc016674b +Subproject commit 6b24e1b46b633ccbbf65159f858c9a496479e426 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text
AllLangHelp_sbasic.mk|1
source/text/sbasic/shared/03/lib_ScriptForge.xhp | 31 ++-
2 files changed, 21 insertions(+), 11 deletions(-)
New commits:
commit 6b24e1b46b633ccbbf65159f858c9a496479e426
Author: Alain Romedenne
AuthorDate: Thu Apr 29 18:17:27 2021 +0200
Commit: Rafael Lima
CommitDate: Fri Apr 30 22:14:29 2021 +0200
sf_basic.xhp pt. 2
Change-Id: Icb81fca7bdea283d3da6c113d1305d47c5bc6ff3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114867
Tested-by: Jenkins
Reviewed-by: Rafael Lima
diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index 84f2b3859..0f7e60542 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -80,6 +80,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
helpcontent2/source/text/sbasic/shared/03/lib_ScriptForge \
helpcontent2/source/text/sbasic/shared/03/sf_array \
helpcontent2/source/text/sbasic/shared/03/sf_base \
+helpcontent2/source/text/sbasic/shared/03/sf_basic \
helpcontent2/source/text/sbasic/shared/03/sf_calc \
helpcontent2/source/text/sbasic/shared/03/sf_database \
helpcontent2/source/text/sbasic/shared/03/sf_dialog \
diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
index dc3c9674f..f3aa899f2 100644
--- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
+++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
@@ -15,22 +15,28 @@
-The ScriptForge
Library
+The ScriptForge
Library
BASIC ScriptForge library
-
-GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
-The described
modules and classes are invoked from user scripts as "Services". A generic
constructor of those services has been designed for that purpose:
+ScriptForge
libraries build up an extensible collection of macro scripting resources for
%PRODUCTNAME to be invoked from Basic macros or Python scripts.
+ Basic macros
require to load ScriptForge library using the following
statement:
GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
Python scripts require an import from scriptforge
module:
+ from scriptforge import CreateScriptService
+
+The described
modules and classes are invoked from user scripts as "Services". A generic
constructor of those services has been designed for that purpose for each
language:
- CreateScriptService("servicename"[, arg0, Arg1,
...])
+ GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
+ Set oSvc = CreateScriptService("servicename"[, arg0,
arg1, ...])
-Services from
external libraries can be registered with the
RegisterScriptServices(...) method in order to extend the
set of available services.
-The ScriptForge Basic
library is available from %PRODUCTNAME 7.1 onwards.
-
+
+ from scriptforge import CreateScriptService
+ svc
= CreateScriptService('servicename'[, arg0, arg1, ...])
+
+
+The ScriptForge Basic
library is available from %PRODUCTNAME 7.1 onwards.Python
scriptforge module is available from %PRODUCTNAME 7.2
onwards.
Services provided by the ScriptForge
library
@@ -70,13 +76,14 @@
Base
+ Basic
Calc
Database
- Document
+ Document
Form
FormControl
@@ -116,13 +123,15 @@
-
+
+
+
@@ -183,4 +192,4 @@
All ScriptForge
Basic routines or identifiers that are prefixed with an underscore character
"_" are reserved for internal use. They are not meant be used in Basic
macros.
-
+
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/uitest/statistics/anova.py |4 +--
sc/source/core/tool/interpr5.cxx | 48 ---
2 files changed, 17 insertions(+), 35 deletions(-)
New commits:
commit 296367e0a91d0e6169da280d6a5efa83ae56de5d
Author: dante
AuthorDate: Thu Apr 29 16:56:41 2021 +0200
Commit: Mike Kaganski
CommitDate: Fri Apr 30 22:10:51 2021 +0200
tdf#137679 Use kahan summation for ScInterpreter::SumProduct
Change-Id: Id0ef5b30a01054337f0ad3afd8c71311e6b2b469
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114888
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/qa/uitest/statistics/anova.py b/sc/qa/uitest/statistics/anova.py
index 50237ef928f9..579b9d29014d 100644
--- a/sc/qa/uitest/statistics/anova.py
+++ b/sc/qa/uitest/statistics/anova.py
@@ -98,7 +98,7 @@ class anova(UITestCase):
self.assertEqual(get_cell_by_position(document, 0, 6, 5).getValue(),
10)
self.assertEqual(get_cell_by_position(document, 0, 6, 6).getValue(),
10)
self.assertEqual(get_cell_by_position(document, 0, 6, 8).getString(),
"SS")
-self.assertEqual(round(get_cell_by_position(document, 0, 6,
9).getValue(),11), 1876.56832844573)
+self.assertEqual(round(get_cell_by_position(document, 0, 6,
9).getValue(),11), 1876.56832844575)
self.assertEqual(round(get_cell_by_position(document, 0, 6,
10).getValue(),10), 6025.1090909091)
#bug 80583
self.assertEqual(round(get_cell_by_position(document, 0, 6,
11).getValue(),11), 7901.67741935484)
@@ -128,7 +128,7 @@ class anova(UITestCase):
self.assertEqual(round(get_cell_by_position(document, 0, 9,
9).getValue(),13), 4.3604117704492)
self.assertEqual(get_cell_by_position(document, 0, 10, 8).getString(),
"P-value")
-self.assertEqual(round(get_cell_by_position(document, 0, 10,
9).getValue(),14), 0.02246149518799)
+self.assertEqual(round(get_cell_by_position(document, 0, 10,
9).getValue(),14), 0.02246149518798)
self.assertEqual(get_cell_by_position(document, 0, 11, 8).getString(),
"F critical")
self.assertEqual(round(get_cell_by_position(document, 0, 11,
9).getValue(),13), 3.3403855582378)
diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx
index 0fe64d647bfe..4f10bb8961d2 100644
--- a/sc/source/core/tool/interpr5.cxx
+++ b/sc/source/core/tool/interpr5.cxx
@@ -1715,37 +1715,6 @@ void ScInterpreter::ScPow()
}
}
-namespace {
-
-class SumValues
-{
-double mfSum;
-bool mbError;
-public:
-SumValues() : mfSum(0.0), mbError(false) {}
-
-void operator() (double f)
-{
-if (mbError)
-return;
-
-FormulaError nErr = GetDoubleErrorValue(f);
-if (nErr == FormulaError::NONE)
-mfSum += f;
-else if (nErr != FormulaError::ElementNaN)
-{
-// Propagate the first error encountered, ignore "this is not a
-// number" elements.
-mfSum = f;
-mbError = true;
-}
-}
-
-double getValue() const { return mfSum; }
-};
-
-}
-
void ScInterpreter::ScSumProduct()
{
short nParamCount = GetByte();
@@ -1790,8 +1759,21 @@ void ScInterpreter::ScSumProduct()
pMat->MergeDoubleArrayMultiply(aResArray);
}
-double fSum = std::for_each(aResArray.begin(), aResArray.end(),
SumValues()).getValue();
-PushDouble(fSum);
+KahanSum fSum = 0.0;
+for( double fPosArray : aResArray )
+{
+FormulaError nErr = GetDoubleErrorValue(fPosArray);
+if (nErr == FormulaError::NONE)
+fSum += fPosArray;
+else if (nErr != FormulaError::ElementNaN)
+{
+// Propagate the first error encountered, ignore "this is not a
number" elements.
+PushDouble(fPosArray);
+return;
+}
+}
+
+PushDouble(fSum.get());
}
void ScInterpreter::ScSumX2MY2()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 0527539a8d228daadcd30428553bff7d96bf8434
Author: Caolán McNamara
AuthorDate: Fri Apr 30 16:15:33 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Apr 30 21:52:50 2021 +0200
don't grab focus if we already have focus
for cases like the combobox of tdf#138281 so we don't end up
selecting the content if we already had focus
Change-Id: I2294b2d17d56e5282d7d84859eb9002ebb3b9ada
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114938
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index f482d4ee7145..e3541057da60 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -271,7 +271,12 @@ void SalInstanceWidget::set_can_focus(bool bCanFocus)
m_xWidget->SetStyle(nStyle);
}
-void SalInstanceWidget::grab_focus() { m_xWidget->GrabFocus(); }
+void SalInstanceWidget::grab_focus()
+{
+if (has_focus())
+return;
+m_xWidget->GrabFocus();
+}
bool SalInstanceWidget::has_focus() const { return m_xWidget->HasFocus(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/wall.hxx| 25 ++--
vcl/inc/wall2.hxx | 50 -
vcl/source/control/combobox.cxx |2
vcl/source/gdi/wall.cxx | 204 +++-
4 files changed, 73 insertions(+), 208 deletions(-)
New commits:
commit 25b0f8787946b1627ea6ac0324d871a70cc5d9dd
Author: Noel Grandin
AuthorDate: Fri Apr 30 15:32:32 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 30 21:42:31 2021 +0200
simplify Wallpaper
All of it's member fields are already COW types, so it doesn't need the
complication
Change-Id: I44e402e8e80fe96462fc4e1aa06b9ec6815e3cd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114933
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/wall.hxx b/include/vcl/wall.hxx
index 6a8c179d2e01..53c8efb7080c 100644
--- a/include/vcl/wall.hxx
+++ b/include/vcl/wall.hxx
@@ -22,8 +22,10 @@
#include
#include
+#include
+#include
#include
-#include
+#include
class Gradient;
class BitmapEx;
@@ -50,15 +52,11 @@ enum class WallpaperStyle
class VCL_DLLPUBLIC Wallpaper
{
public:
-typedef o3tl::cow_wrapper ImplType;
-
SAL_DLLPRIVATE void ImplSetCachedBitmap( BitmapEx& rBmp )
const;
SAL_DLLPRIVATE const BitmapEx* ImplGetCachedBitmap() const;
SAL_DLLPRIVATE void ImplReleaseCachedBitmap() const;
private:
-ImplType mpImplWallpaper;
-
SAL_DLLPRIVATE static Gradient ImplGetApplicationGradient();
public:
@@ -70,21 +68,21 @@ public:
~Wallpaper();
voidSetColor( const Color& rColor );
-const Color&GetColor() const;
+const Color&GetColor() const { return maColor; }
voidSetStyle( WallpaperStyle eStyle );
-WallpaperStyle GetStyle() const;
+WallpaperStyle GetStyle() const { return meStyle; }
voidSetBitmap( const BitmapEx& rBitmap );
-BitmapExGetBitmap() const;
+const BitmapEx & GetBitmap() const;
boolIsBitmap() const;
voidSetGradient( const Gradient& rGradient );
GradientGetGradient() const;
boolIsGradient() const;
-voidSetRect( const tools::Rectangle& rRect );
-tools::Rectangle GetRect() const;
+voidSetRect( const tools::Rectangle& rRect ) { maRect = rRect;
}
+const tools::Rectangle & GetRect() const { return maRect; }
boolIsRect() const;
boolIsFixed() const;
@@ -105,6 +103,13 @@ public:
friend SvStream& ReadWallpaper( SvStream& rIStm, Wallpaper& rWallpaper );
friend SvStream& WriteWallpaper( SvStream& rOStm, const Wallpaper&
rWallpaper );
+private:
+tools::RectanglemaRect;
+BitmapExmaBitmap;
+mutable BitmapExmaCache;
+std::optional mpGradient;
+Color maColor;
+WallpaperStyle meStyle;
};
#endif // INCLUDED_VCL_WALL_HXX
diff --git a/vcl/inc/wall2.hxx b/vcl/inc/wall2.hxx
deleted file mode 100644
index 401593b3ff8b..
--- a/vcl/inc/wall2.hxx
+++ /dev/null
@@ -1,50 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_VCL_INC_WALL2_HXX
-#define INCLUDED_VCL_INC_WALL2_HXX
-
-#include
-
-class ImplWallpaper
-{
-friend class Wallpaper;
-
-private:
-std::optional mpRect;
-std::unique_ptr mpBitmap;
-std::unique_ptr mpGradient;
-std::unique_ptr mpCache;
-Color maColor;
-WallpaperStyle meStyle;
-
-public:
-ImplWallpaper();
-ImplWallpaper( const ImplWallpaper& rImplWallpaper );
-~ImplWallpaper();
-
-bool operator==( const ImplWallpaper& rImplWallpaper ) const = delete;
-
-friend SvStream& ReadImplWallpaper( SvStream& rIStm, ImplWallpaper&
rImplWallpaper );
-friend SvStream& WriteImplWallpaper( SvStream& rOStm, const ImplWallpaper&
rImplWallpaper );
-};
-
-#endif // INCLUDED_VCL_INC_WALL2_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff
[Libreoffice-bugs] [Bug 79049] FILEOPEN: OOXML Workbook file hangs when opening
https://bugs.documentfoundation.org/show_bug.cgi?id=79049 --- Comment #24 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/61386aa03cd166473a58dbb4be0dd5e0ce82195c tdf#79049 speed up OOXML workbook load (3) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/attarray.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit 61386aa03cd166473a58dbb4be0dd5e0ce82195c
Author: Noel Grandin
AuthorDate: Fri Apr 30 18:27:31 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 30 21:41:13 2021 +0200
tdf#79049 speed up OOXML workbook load (3)
Exit this loop early if we aren't going to make progress
anyhow.
This takes the load time from 40s to 34s for me.
Change-Id: I31887442cde6e3fc05f1fce10bb3dde9c2b88bf2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114942
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index da8490b72f99..d7683b601435 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -1959,17 +1959,21 @@ bool ScAttrArray::GetLastVisibleAttr( SCROW& rLastRow,
SCROW nLastData ) const
Search( nLastData, nPos );
while ( nPos < mvData.size() )
{
+SCROW nAttrStartRow = ( nPos > 0 ) ? ( mvData[nPos-1].nEndRow + 1 ) :
0;
+if ( nAttrStartRow <= nLastData )
+nAttrStartRow = nLastData + 1;
// find range of visually equal formats
SCSIZE nEndPos = nPos;
while ( nEndPos < mvData.size()-1 &&
mvData[nEndPos].pPattern->IsVisibleEqual(
*mvData[nEndPos+1].pPattern))
+{
+if ( (mvData[nEndPos].nEndRow + 1 - nAttrStartRow) >=
SC_VISATTR_STOP )
+return false; // ignore this range and below
++nEndPos;
-SCROW nAttrStartRow = ( nPos > 0 ) ? ( mvData[nPos-1].nEndRow + 1 ) :
0;
-if ( nAttrStartRow <= nLastData )
-nAttrStartRow = nLastData + 1;
+}
SCROW nAttrSize = mvData[nEndPos].nEndRow + 1 - nAttrStartRow;
if ( nAttrSize >= SC_VISATTR_STOP )
-break; // while, ignore this range and below
+return false; // ignore this range and below
else if ( mvData[nEndPos].pPattern->IsVisible() )
{
rLastRow = mvData[nEndPos].nEndRow;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 79049] FILEOPEN: OOXML Workbook file hangs when opening
https://bugs.documentfoundation.org/show_bug.cgi?id=79049 --- Comment #23 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/deac5c84732c3491a0ef5bf7f8c1552e6def4fc0 tdf#79049 speed up OOXML workbook load (2) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/sheetdatabuffer.hxx |6 -
sc/source/filter/oox/sheetdatabuffer.cxx | 153 +--
2 files changed, 90 insertions(+), 69 deletions(-)
New commits:
commit deac5c84732c3491a0ef5bf7f8c1552e6def4fc0
Author: Noel Grandin
AuthorDate: Fri Apr 30 18:24:12 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Apr 30 21:39:51 2021 +0200
tdf#79049 speed up OOXML workbook load (2)
the allocation of memory and pointer chasing was
slowing things down in the styles conversion.
So switch to more cache-dense data structure,
and re-arrange the loops to be more cache friendly.
The takes the time from 1m9 to 40s for me.
Change-Id: I876580adc7823313b0cdb067f2f6b3e61c39ecf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114941
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/filter/inc/sheetdatabuffer.hxx
b/sc/source/filter/inc/sheetdatabuffer.hxx
index c49e33280a10..17add16e6234 100644
--- a/sc/source/filter/inc/sheetdatabuffer.hxx
+++ b/sc/source/filter/inc/sheetdatabuffer.hxx
@@ -22,6 +22,7 @@
#include
#include
#include
+#include
#include "richstring.hxx"
#include "worksheethelper.hxx"
@@ -165,7 +166,8 @@ private:
/** Writes all cell formatting attributes to the passed cell range list.
(depreciates writeXfIdRangeProperties) */
voidapplyCellMerging( const ScRange& rRange );
-voidaddColXfStyle( sal_Int32 nXfId, sal_Int32 nFormatId,
const ScRange& rAddress, bool bProcessRowRange = false );
+voidaddColXfStyles();
+voidaddColXfStyleProcessRowRanges();
private:
/** Stores cell range address and formula token array of an array formula.
*/
typedef std::pair< ScRange, ApiTokenSequence > ArrayFormula;
@@ -200,7 +202,7 @@ private:
return lhs.mnEndRow RowStyles;
+typedef ::o3tl::sorted_vector< RowRangeStyle, StyleRowRangeComp >
RowStyles;
typedef ::std::map< sal_Int32, RowStyles > ColStyles;
/** Stores information about a merged cell range. */
struct MergedRange
diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx
b/sc/source/filter/oox/sheetdatabuffer.cxx
index de1d2c76f3c9..c9c688c2ca17 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -346,57 +346,99 @@ static void addIfNotInMyMap( const StylesBuffer& rStyles,
std::map< FormatKeyPai
rMap[ FormatKeyPair( nXfId, nFormatId ) ] = rRangeList;
}
-void SheetDataBuffer::addColXfStyle( sal_Int32 nXfId, sal_Int32 nFormatId,
const ScRange& rAddress, bool bProcessRowRange )
-{
-RowRangeStyle aStyleRows;
-aStyleRows.mnNumFmt.first = nXfId;
-aStyleRows.mnNumFmt.second = nFormatId;
-aStyleRows.mnStartRow = rAddress.aStart.Row();
-aStyleRows.mnEndRow = rAddress.aEnd.Row();
-for ( sal_Int32 nCol = rAddress.aStart.Col(); nCol <= rAddress.aEnd.Col();
++nCol )
+void SheetDataBuffer::addColXfStyles()
+{
+std::map< FormatKeyPair, ScRangeList > rangeStyleListMap;
+for( const auto& [rFormatKeyPair, rRangeList] : maXfIdRangeLists )
+{
+addIfNotInMyMap( getStyles(), rangeStyleListMap, rFormatKeyPair.first,
rFormatKeyPair.second, rRangeList );
+}
+// gather all ranges that have the same style and apply them in bulk
+for ( const auto& [rFormatKeyPair, rRanges] : rangeStyleListMap )
{
-if ( !bProcessRowRange )
-maStylesPerColumn[ nCol ].insert( aStyleRows );
-else
+for (const ScRange & rAddress : rRanges)
{
-RowStyles& rRowStyles = maStylesPerColumn[ nCol ];
-// Reset row range for each column
+RowRangeStyle aStyleRows;
+aStyleRows.mnNumFmt.first = rFormatKeyPair.first;
+aStyleRows.mnNumFmt.second = rFormatKeyPair.second;
aStyleRows.mnStartRow = rAddress.aStart.Row();
aStyleRows.mnEndRow = rAddress.aEnd.Row();
+for ( sal_Int32 nCol = rAddress.aStart.Col(); nCol <=
rAddress.aEnd.Col(); ++nCol )
+ maStylesPerColumn[ nCol ].insert( aStyleRows );
+}
+}
+}
-// If aStyleRows includes rows already allocated to a style
-// in rRowStyles, then we need to split it into parts.
-// ( to occupy only rows that have no style definition)
-
-// Start iterating at the first element that is not completely
before aStyleRows
-RowStyles::iterator rows_it = rRowStyles.lower_bound(aStyleRows);
-RowStyles::iterator rows_end = rRowStyles.end();
-bool bAddRange = true;
-for ( ; rows_it != rows_end; ++rows_it )
+void SheetDataBuffer::addColXfStyleProcessRowRanges()
+{
+// count the number of row-range-styles we have
+AddressConverter& rAddrConv = getAddressConverter();
+int cnt = 0;
+for ( const auto& [nXfId, rRowRangeList] : maXfIdRowRangeList )
+{
[Libreoffice-bugs] [Bug 141375] equation change at the opening of the editor
https://bugs.documentfoundation.org/show_bug.cgi?id=141375 --- Comment #5 from Alessia --- Hello, I confirm that I can reproduce the bug from the attached file with Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL and Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f616d96bd8ce8986e4cc204953db0467e6060b5c CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - external/liborcus
external/liborcus/UnpackedTarball_liborcus.mk|4
external/liborcus/allow-utf-8-in-xml-names.patch | 301 +++
2 files changed, 305 insertions(+)
New commits:
commit 54c54fc1eb1a14e513fcbc59f122a3e15bd2f3a3
Author: Luboš Luňák
AuthorDate: Thu Apr 29 20:10:34 2021 +0200
Commit: Andras Timar
CommitDate: Fri Apr 30 20:51:41 2021 +0200
allow utf-8 in xml names (liborcus) (tdf#141672)
Change-Id: Ib150d55b588a572e4352396f18de2331983b2aae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114892
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
(cherry picked from commit 6b7c2fa65eb68be520ed4135cc245e33fa22e8bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114916
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 113e8e25818d..3b54db0e49ce 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -23,6 +23,10 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/include.patch.0 \
))
+$(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
+ external/liborcus/allow-utf-8-in-xml-names.patch \
+))
+
ifeq ($(OS),WNT)
$(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/windows-constants-hack.patch \
diff --git a/external/liborcus/allow-utf-8-in-xml-names.patch
b/external/liborcus/allow-utf-8-in-xml-names.patch
new file mode 100644
index ..e3430881053d
--- /dev/null
+++ b/external/liborcus/allow-utf-8-in-xml-names.patch
@@ -0,0 +1,301 @@
+From fa9b6845ed583f5486372c6ffbc59e02a140d303 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?=
+Date: Thu, 29 Apr 2021 19:12:20 +0200
+Subject: [PATCH] allow utf-8 in xml names (#137)
+
+https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-NameStartChar
+has a list of all allowed characters.
+---
+ include/orcus/sax_parser_base.hpp | 3 +
+ src/orcus_test_xml.cpp| 1 +
+ src/parser/sax_parser_base.cpp| 201 --
+ test/xml/non-ascii/check.txt | 4 +
+ test/xml/non-ascii/input.xml | 4 +
+ 5 files changed, 201 insertions(+), 12 deletions(-)
+ create mode 100644 test/xml/non-ascii/check.txt
+ create mode 100644 test/xml/non-ascii/input.xml
+
+diff --git a/include/orcus/sax_parser_base.hpp
b/include/orcus/sax_parser_base.hpp
+index 9939e133..8394c07b 100644
+--- a/include/orcus/sax_parser_base.hpp
b/include/orcus/sax_parser_base.hpp
+@@ -218,6 +218,9 @@ protected:
+ void element_name(parser_element& elem, std::ptrdiff_t begin_pos);
+ void attribute_name(pstring& attr_ns, pstring& attr_name);
+ void characters_with_encoded_char(cell_buffer& buf);
++
++int is_name_char();
++int is_name_start_char();
+ };
+
+ }}
+diff --git a/src/orcus_test_xml.cpp b/src/orcus_test_xml.cpp
+index 8a864d68..35f3dea7 100644
+--- a/src/orcus_test_xml.cpp
b/src/orcus_test_xml.cpp
+@@ -77,6 +77,7 @@ const char* sax_parser_test_dirs[] = {
+ SRCDIR"/test/xml/no-decl-1/",
+ SRCDIR"/test/xml/underscore-identifier/",
+ SRCDIR"/test/xml/self-closing-root/",
++SRCDIR"/test/xml/non-ascii/",
+ };
+
+ const char* sax_parser_parse_only_test_dirs[] = {
+diff --git a/src/parser/sax_parser_base.cpp b/src/parser/sax_parser_base.cpp
+index 97aa34ec..db51ff94 100644
+--- a/src/parser/sax_parser_base.cpp
b/src/parser/sax_parser_base.cpp
+@@ -328,20 +328,182 @@ bool parser_base::value(pstring& str, bool decode)
+ return transient_stream();
+ }
+
++// https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-NameStartChar
++// Return length of the character in bytes, otherwise 0.
++template< bool only_start_name >
++static
++int is_name_char_helper(const char* mp_char, const char* mp_end)
++{
++const unsigned char first = mp_char[0];
++// Note that ':' technically is an allowed name character, but it is
handled separately
++// e.g. in element_name(), so here pretend it isn't.
++if (/*first == ':' ||*/ first == '_' || (first >= 'A' && first <= 'Z') ||
(first >= 'a' && first <= 'z'))
++return 1;
++if (!only_start_name && (first == '-' || first == '.' || (first >= '0' &&
first <= '9')))
++return 1;
++
++if (first < 0x7f) // other ascii characters are not allowed
++return 0;
++if (mp_end < mp_char + 1)
++return 0;
++const unsigned char second = mp_char[1];
++
++// 0xb7 = 0xc2 0xb7 utf-8
++if (!only_start_name && first == 0xc2 && second == 0xb7)
++return 2;
++
++// [#xC0-#xD6] | [#xD8-#xF6] | [#xF8-#x2FF]
++// 0xc0 = 0xc3 0x80 utf-8
++if (first < 0xc3)
++return 0;
++// xd7 = 0xc3 0x97 utf-8, 0xf7 = 0xc3 0xb7 utf-8
++if (first == 0xc3)
++return second >= 0x80 && second <= 0xff && second != 0x97 && second
!= 0xb7 ? 2 : 0;
++// 0x2ff = 0xcb
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - external/liborcus
external/liborcus/UnpackedTarball_liborcus.mk|4
external/liborcus/allow-utf-8-in-xml-names.patch | 301 +++
2 files changed, 305 insertions(+)
New commits:
commit cd7160420a1a73ff72c8995b425ec336778dfe47
Author: Luboš Luňák
AuthorDate: Thu Apr 29 20:10:34 2021 +0200
Commit: Andras Timar
CommitDate: Fri Apr 30 20:51:22 2021 +0200
allow utf-8 in xml names (liborcus) (tdf#141672)
Change-Id: Ib150d55b588a572e4352396f18de2331983b2aae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114892
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
(cherry picked from commit 6b7c2fa65eb68be520ed4135cc245e33fa22e8bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114915
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 113e8e25818d..3b54db0e49ce 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -23,6 +23,10 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/include.patch.0 \
))
+$(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
+ external/liborcus/allow-utf-8-in-xml-names.patch \
+))
+
ifeq ($(OS),WNT)
$(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/windows-constants-hack.patch \
diff --git a/external/liborcus/allow-utf-8-in-xml-names.patch
b/external/liborcus/allow-utf-8-in-xml-names.patch
new file mode 100644
index ..e3430881053d
--- /dev/null
+++ b/external/liborcus/allow-utf-8-in-xml-names.patch
@@ -0,0 +1,301 @@
+From fa9b6845ed583f5486372c6ffbc59e02a140d303 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?=
+Date: Thu, 29 Apr 2021 19:12:20 +0200
+Subject: [PATCH] allow utf-8 in xml names (#137)
+
+https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-NameStartChar
+has a list of all allowed characters.
+---
+ include/orcus/sax_parser_base.hpp | 3 +
+ src/orcus_test_xml.cpp| 1 +
+ src/parser/sax_parser_base.cpp| 201 --
+ test/xml/non-ascii/check.txt | 4 +
+ test/xml/non-ascii/input.xml | 4 +
+ 5 files changed, 201 insertions(+), 12 deletions(-)
+ create mode 100644 test/xml/non-ascii/check.txt
+ create mode 100644 test/xml/non-ascii/input.xml
+
+diff --git a/include/orcus/sax_parser_base.hpp
b/include/orcus/sax_parser_base.hpp
+index 9939e133..8394c07b 100644
+--- a/include/orcus/sax_parser_base.hpp
b/include/orcus/sax_parser_base.hpp
+@@ -218,6 +218,9 @@ protected:
+ void element_name(parser_element& elem, std::ptrdiff_t begin_pos);
+ void attribute_name(pstring& attr_ns, pstring& attr_name);
+ void characters_with_encoded_char(cell_buffer& buf);
++
++int is_name_char();
++int is_name_start_char();
+ };
+
+ }}
+diff --git a/src/orcus_test_xml.cpp b/src/orcus_test_xml.cpp
+index 8a864d68..35f3dea7 100644
+--- a/src/orcus_test_xml.cpp
b/src/orcus_test_xml.cpp
+@@ -77,6 +77,7 @@ const char* sax_parser_test_dirs[] = {
+ SRCDIR"/test/xml/no-decl-1/",
+ SRCDIR"/test/xml/underscore-identifier/",
+ SRCDIR"/test/xml/self-closing-root/",
++SRCDIR"/test/xml/non-ascii/",
+ };
+
+ const char* sax_parser_parse_only_test_dirs[] = {
+diff --git a/src/parser/sax_parser_base.cpp b/src/parser/sax_parser_base.cpp
+index 97aa34ec..db51ff94 100644
+--- a/src/parser/sax_parser_base.cpp
b/src/parser/sax_parser_base.cpp
+@@ -328,20 +328,182 @@ bool parser_base::value(pstring& str, bool decode)
+ return transient_stream();
+ }
+
++// https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-NameStartChar
++// Return length of the character in bytes, otherwise 0.
++template< bool only_start_name >
++static
++int is_name_char_helper(const char* mp_char, const char* mp_end)
++{
++const unsigned char first = mp_char[0];
++// Note that ':' technically is an allowed name character, but it is
handled separately
++// e.g. in element_name(), so here pretend it isn't.
++if (/*first == ':' ||*/ first == '_' || (first >= 'A' && first <= 'Z') ||
(first >= 'a' && first <= 'z'))
++return 1;
++if (!only_start_name && (first == '-' || first == '.' || (first >= '0' &&
first <= '9')))
++return 1;
++
++if (first < 0x7f) // other ascii characters are not allowed
++return 0;
++if (mp_end < mp_char + 1)
++return 0;
++const unsigned char second = mp_char[1];
++
++// 0xb7 = 0xc2 0xb7 utf-8
++if (!only_start_name && first == 0xc2 && second == 0xb7)
++return 2;
++
++// [#xC0-#xD6] | [#xD8-#xF6] | [#xF8-#x2FF]
++// 0xc0 = 0xc3 0x80 utf-8
++if (first < 0xc3)
++return 0;
++// xd7 = 0xc3 0x97 utf-8, 0xf7 = 0xc3 0xb7 utf-8
++if (first == 0xc3)
++return second >= 0x80 && second <= 0xff && second != 0x97 && second
!= 0xb7 ? 2 : 0;
++// 0x2ff = 0xcb
[Libreoffice-bugs] [Bug 108569] [META] Page margin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108569 --- Comment #3 from Regina Henschel --- (In reply to Heiko Tietze from comment #2) > Regina, what do you think about Eyal's comment 1? I agree with Eyal, that the current wording in the UI in page style and in print dialog is already inconsistent and confusing and it becomes worse with introducing gutter. In addition to Eyal's remarks on print processing and writing direction, there exists the problem of import/export with docx and rtf formats. It might help to try to write an extensive guide about the features currently available in LO 7.2 for page layout and printing. That would uncover all the wording problems and usability shortcomings. But is there someone interested to investigate and fix all the problems? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140803] Empty page because of anchoring attaching itself at different spot
https://bugs.documentfoundation.org/show_bug.cgi?id=140803 Telesto changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #9 from Telesto --- (In reply to Buovjaga from comment #7) > > 1. Open attachment 170234 > > 2. Select the right image behind the china town (image 2) > > 3. Press arrow right I do reproduce this, and feels off.. B moves down for some reason? But not totally getting why.. Image wrap? But again why? Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f616d96bd8ce8986e4cc204953db0467e6060b5c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141995] Removed command flash in customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=141995 Gabor Kelemen changed: What|Removed |Added Ever confirmed|0 |1 CC||kelem...@ubuntu.com Status|UNCONFIRMED |NEW --- Comment #1 from Gabor Kelemen --- Confirming with Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 41ff704cc49b7097b717882616011962ecd7198f CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141981] Redraw fails in Windows LO Draw moving shapes with multiple formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=141981 --- Comment #6 from Telesto --- To clear, also reproducible with GDI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141981] Redraw fails in Windows LO Draw moving shapes with multiple formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=141981 --- Comment #5 from Telesto --- Not related to Skia Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f616d96bd8ce8986e4cc204953db0467e6060b5c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142002] New: Assigned keyboard shortcut view->normal does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=142002 Bug ID: 142002 Summary: Assigned keyboard shortcut view->normal does not work Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: simon.stua...@gmail.com When I assign a shortcut to the action view->normal (tooltip ".uno:pagemode"), it does not work as expected. Tried asigning different keyboard shortcuts with the same result. This bug is similar to 125230 but not the same Behavior depends on current view. I resume in the following table: (I'm actually guessing english name of the views, as I have LO configured in spanish. I've added original spanish name in parentheses) ** When current view is -> What happens ** slide organizer (organizador de diapositivas) -> nothing happens... Notes (notas) -> nothing happens... scheme (esquema) -> nothing happens... slide pattern (patrón de diapositivas) -> returns to normal view notes pattern (patrón de notas) -> returns to notes brochure pattern (patrón de folleto) -> nothing happens... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141813] Menu item File response delayed
https://bugs.documentfoundation.org/show_bug.cgi?id=141813 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #3 from Telesto --- Solved, profile corruption Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f616d96bd8ce8986e4cc204953db0467e6060b5c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141981] Redraw fails in Windows LO Draw moving shapes with multiple formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=141981 Telesto changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest, regression --- Comment #4 from Telesto --- Confirm Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f616d96bd8ce8986e4cc204953db0467e6060b5c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108569] [META] Page margin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108569 Heiko Tietze changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||rb.hensc...@t-online.de --- Comment #2 from Heiko Tietze --- Regina, what do you think about Eyal's comment 1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/convwatch.py sw/source
bin/convwatch.py |2 ++
sw/source/core/layout/layact.cxx |6 ++
2 files changed, 8 insertions(+)
New commits:
commit c926974ec1a4dbb72f273927fed0bc2f5e19c374
Author: Michael Stahl
AuthorDate: Fri Apr 30 17:06:59 2021 +0200
Commit: Michael Stahl
CommitDate: Fri Apr 30 19:29:30 2021 +0200
sw: add some SAL_INFO on DoIdleJob interrupt
Change-Id: I44df06ab4bad1a5e0aaf5409590f5d7869f33482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114937
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/bin/convwatch.py b/bin/convwatch.py
index d88d43d64a6f..93082186f319 100644
--- a/bin/convwatch.py
+++ b/bin/convwatch.py
@@ -280,6 +280,7 @@ def loadFromURL(xContext, url):
xDoc = None
try:
xDoc = xDesktop.loadComponentFromURL(url, "_blank", 0, loadProps)
+log("...loadComponentFromURL done")
if xDoc is None:
raise Exception("No document loaded?")
time_ = 0
@@ -328,6 +329,7 @@ class LoadPrintFileTest:
else:
url = "file://" + quote(self.file)
xDoc = loadFromURL(xContext, url)
+log("loadFromURL in: " + str(datetime.datetime.now() - start))
printDoc(xContext, xDoc, url + self.prtsuffix)
finally:
if xDoc:
diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index 422b8aee0c46..4a811e171ddc 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -2088,7 +2088,10 @@ bool SwLayIdle::DoIdleJob( IdleJobType eJob, bool
bVisAreaOnly )
while( pCnt && pPage->IsAnLower( pCnt ) )
{
if ( DoIdleJob_( pCnt, eJob ) )
+{
+SAL_INFO("sw.idle", "DoIdleJob " << eJob << " interrupted on
page " << pPage->GetPhyPageNum());
return true;
+}
pCnt = pCnt->GetNextContentFrame();
}
if ( pPage->GetSortedObjs() )
@@ -2105,7 +2108,10 @@ bool SwLayIdle::DoIdleJob( IdleJobType eJob, bool
bVisAreaOnly )
if ( pC->IsTextFrame() )
{
if ( DoIdleJob_( pC, eJob ) )
+{
+SAL_INFO("sw.idle", "DoIdleJob " << eJob << "
interrupted on page " << pPage->GetPhyPageNum());
return true;
+}
}
pC = pC->GetNextContentFrame();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142001] New: Crash in: igc64.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=142001 Bug ID: 142001 Summary: Crash in: igc64.dll Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ernestbarb...@gmail.com This bug was filed from the crash reporting server and is br-8d355adf-7f4f-408d-9f73-559c9229b34a. = Had I known that I could do this, I'd have noted the message in detail that I got during installation of newer LO version. That message was something to the effect that a reboot would be required if I chose to not let the LO installation process close a Windows process/file that it said was currently in use. After rebooting, I then installed the Help module, and only then began the opening/testing of LO by loading the UI first. After about 7 seconds, the crash ensued upon seemingly its trying to present to me a Document-Recovery UI which never fully materialized. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132145] "com.sun.star.sheet.GlobalSheetSettings" properties, "org.openoffice.Office.Math" and "org.openoffice.Office.Calc/Input/" entries are not synchronized
https://bugs.documentfoundation.org/show_bug.cgi?id=132145 Mike Kaganski changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #2 from Mike Kaganski --- Stephan: what is the proper way to listen to registry changes? To automatically synchronize the cached settings when the data is set using low-level mechanism. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/txtnode/txtedt.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 4184569b963877c2a488ff05766654b9db194798
Author: Michael Stahl
AuthorDate: Fri Apr 30 15:31:54 2021 +0200
Commit: Michael Stahl
CommitDate: Fri Apr 30 19:09:29 2021 +0200
sw: speed up DoIdleJobs(WORD_COUNT)
SwTextNode::CountWords() has early returns that don't clear the
WordCountDirty flag, for nodes that don't contain any plain text.
This speeds things up considerably for tdf135116-1.odt, which didn't
finish the idle jobs after 5 minutes in an optimized 7.1 build, because
the time slice tends to expire iterating nodes in word-count before it
can make progress.
With this it does ~25 WORD_COUNT pages and then ~90 AUTOCOMPLETE_WORDS
pages per idle, sending OnLayoutFinished after 13-14 seconds.
jmux just pointed me to commit 0fedac18214a6025401c4c426466a5166553e8ec
which is not in 7.1 today and may have improved the performance here.
Change-Id: I5e9651da3a173649c49fc36edefb23298dfd6bc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114936
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/txtnode/txtedt.cxx
b/sw/source/core/txtnode/txtedt.cxx
index e734e471060b..853632d30771 100644
--- a/sw/source/core/txtnode/txtedt.cxx
+++ b/sw/source/core/txtnode/txtedt.cxx
@@ -2023,6 +2023,10 @@ bool SwTextNode::CountWords( SwDocStat& rStat,
if( nStt == nEnd && !bCountNumbering)
{ // unnumbered empty node or empty selection
+if (bCountAll)
+{
+SetWordCountDirty( false ); // reset flag to speed up DoIdleJob
+}
return false;
}
@@ -2051,6 +2055,10 @@ bool SwTextNode::CountWords( SwDocStat& rStat,
if (aExpandText.isEmpty() && !bCountNumbering)
{
+if (bCountAll)
+{
+SetWordCountDirty( false ); // reset flag to speed up DoIdleJob
+}
return false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141937] Calc takes 60+ seconds to open .ODS files
https://bugs.documentfoundation.org/show_bug.cgi?id=141937 --- Comment #7 from John Kale --- Thank you all for your attention and suggestions. Setting "Proxy Server" to "None" hasn't changed anything. Very curious what network traffic would be triggered by opening a local .ods file, but not by opening the .xlsx version. Although I do have a cloud sync service (MS OneDrive) active, the .ods files in question here aren't in a synced directory. To be absolutely sure, I tried 1) Moving some .ods files to a different volume with no synced directories and 2) Completely shutting down OneDrive before loading an .ods file. Neither made any difference. I tried doing a WireShark capture while LibreOffice started up slowly, but I don't know what to look for in the result. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137127] RTF: Control word \up14 in blank table cell leaks into adjacent cell
https://bugs.documentfoundation.org/show_bug.cgi?id=137127 MikeM changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from MikeM --- Dieter, thank you for responding. The issue is still present in LibreOffice version 7.0.5.2. Please observe the difference in the way Broken.rtf and Fixed.rtf are displayed, around the "Standardpreis AZV" text. For now I cannot test version 7.1.2.2 because the Writer application crashes on my Windows Server 2008 R2 machine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103304] [META] Page style dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103304 --- Comment #1 from Eyal Rozenberg --- Please note bug 108569 comment 1 ; it might have been a good fit here as well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108569] [META] Page margin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108569 --- Comment #1 from Eyal Rozenberg --- With the introduction of the Gutter option, LO has taken another step into the complex space of catering to the preparation of printed products. I believe we are currently having a bit of a fractured discussion on and off of Bugzilla on this configuration/setting space, and in more than one: 140568 and 140561 at least. So as not to further fracture the discussion, I'm making a somewhat general comment here. I'll use the terms "LO page" for the pages we see and edit within LO Writer; "leaf" (a.k.a. "folium") for a sheet of physical paper onto which matter is printed; and "final page" as what the reader of the folded and bound physical document thinks of as a page (e.g. a page in a bound book). So, we're talking about what we do with multiple pages we print. Relevant factors/considerations: * Will the printed leaves be attached to each other somehow, or kept loose? * Do printed leaves get folded before use (binding or no binding)? And in which pattern? And do all leaves get folded together, on in bunches? (if you're wondering why we might fold bunches of pages separately - see this video: https://www.youtube.com/watch?v=DiCRx1_Ovok)? * Will the leaves (after any potential folding) be bound at: A corner (e.g. with a stapler), or along one of the axes? * Will content be printed onto both sides of each leaf? * Do we intend to have multiple LO pages be contained in each final page? (For no folding and no binding, this reduces to "do we print multiple LO pages onto each side of a leaf") * How do we call the two axes of an LO page? A leaf? A final page? What do they signify? Is it "short" vs "long"? "Left/Right" vs "Top/Bottom"? "Along-line progression" vs "perpendicular-to-line progression"? "printer head moves across" vs "printer scrolls along"? This is a particularly sticky point, because depending on our conceptual choice, the axes may be flipped by one or more of the following changes: * Increasing page "width" beyond page "height" * Switching between portrait and landscape (terms which relate to the printer's axes) * Switching document/section direction LTR/RTL * Switching page direction LTR/RTL * Using a LTR vs RTL language * Using a language in which glyphs are "naturally" inserted top-to-bottom, then RTL or LTR as the case may be * Maybe other actions * For axis-bound final pages - which axis has the binding (considering the reference conundrum mentioned above)? And which "side" is the bound one? * If document pages have different roles/placement on final pages (e.g. front and back side with binding and no folding) - what role does the first document page have? In what order do consecutive pages cycle through the roles (in the example Now, you might be saying: "What's with all that complex nitpicking? LO Writer is not a print-publishing/typesetting application, it's just a word processor! Let's keep this simple!" - well, the thing is, once you have the features we already have - we can't quite keep it simple; we have take more things into consideration to avoid inconsistencies. Otherwise, we will be in a constant state of buginess - for some of our users, some of the time. Thus, for example, you can't say "Put the gutter on Left". Left of what? And if I'm switching from, say, writing English to Arabic - what will the "Left" now mean? Careful with your answer... remember that RTL language documents start with a final-page that's to the left of the axis; are you sure you want the Gutter on the left of that page? And what if I want 4 LO-pages per sheet for a book fold; where is "Left" now? Or the request in bug 140561: "Call it Inner gutter, not Left gutter" - If we print one LO page per leaf, and only print on one side of the leaves, and with the leaves facing up we bind on the left of the page, then - the gutter can legitimately be said to be "Left". If we do the same, except that we print on both sides of each leaf, then the Gutter is sometimes on the left, sometimes on the right; so we can't just call it a "Left" gutter. And what about "inner", then? Well, actually, a gutter is _always_ inner - since the gutter is near the binding, and a book opens around the binding axis. There are _only_ inner gutters. These issues regard not only gutters, but other items on the Page dialog. For example: "Right" and "Left" margins are not really on the right and on the left when we have leaf folding. Thus, Microsoft Word changes the margin field labels when the user chooses "Mirrored Pages" or "Book Fold". Having said all that - I'm not suggesting that we necessarily support complex fold-patterns or otherwise go overboard with features. Just that we keep the physical process in mind, and also be mindful of every situation that legitimately comes up when using existing LO features. The UI needs to cater to all of those consistently. PS - Some explanations-with-screenshots of parts of MS
[Libreoffice-bugs] [Bug 57351] Calc: "Insert columns" is not available in the context menu if an autofilter to hide rows is applied
https://bugs.documentfoundation.org/show_bug.cgi?id=57351 Gunter Ohrner changed: What|Removed |Added CC||newbie...@gmx.de --- Comment #29 from Gunter Ohrner --- *** Bug 135914 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135914] ui: 'insert column' is not offered on right-click on column header after deleting a column from a filtered range
https://bugs.documentfoundation.org/show_bug.cgi?id=135914 Gunter Ohrner changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Gunter Ohrner --- That's a duplicate of Bug #57351. *** This bug has been marked as a duplicate of bug 57351 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sc/qa
sc/qa/uitest/calc_tests/data/tdf137945.ods |binary
sc/qa/uitest/validity/tdf137945.py | 38 +
2 files changed, 38 insertions(+)
New commits:
commit c976a18758b77ab989f3cc1a34623ff403651801
Author: Xisco Fauli
AuthorDate: Fri Apr 30 10:49:28 2021 +0200
Commit: Xisco Fauli
CommitDate: Fri Apr 30 17:58:49 2021 +0200
tdf#137945: sc: Add UItest
Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114871
Tested-by: Xisco Fauli
Reviewed-by: Xisco Fauli
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114935
Tested-by: Jenkins
diff --git a/sc/qa/uitest/calc_tests/data/tdf137945.ods
b/sc/qa/uitest/calc_tests/data/tdf137945.ods
new file mode 100644
index ..ddda28140b1a
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf137945.ods differ
diff --git a/sc/qa/uitest/validity/tdf137945.py
b/sc/qa/uitest/validity/tdf137945.py
new file mode 100644
index ..1feb12cd7ebe
--- /dev/null
+++ b/sc/qa/uitest/validity/tdf137945.py
@@ -0,0 +1,38 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.common import get_state_as_dict
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+class Tdf137945(UITestCase):
+
+def test_tdf137945(self):
+calc_doc =
self.ui_test.load_file(get_url_for_data_file("tdf137945.ods"))
+
+self.ui_test.execute_dialog_through_command(".uno:Validation")
+xDialog = self.xUITest.getTopFocusWindow()
+xTabs = xDialog.getChild("tabcontrol")
+select_pos(xTabs, "1")
+xInput = xDialog.getChild("inputhelp")
+xTitle = xDialog.getChild("title")
+
+self.assertEqual("test", get_state_as_dict(xTitle)['Text'])
+# Without the fix in place, this test would have failed with
+# '1 2 3 4510 end' != '1 2 3 4 5
10 end'
+self.assertEqual("1 2 3 4510 end",
get_state_as_dict(xInput)['Text'])
+
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137945] Every time after spreadsheet saved and reopened, spaces are multiplied in content validation help messages
https://bugs.documentfoundation.org/show_bug.cgi?id=137945 --- Comment #9 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/c976a18758b77ab989f3cc1a34623ff403651801 tdf#137945: sc: Add UItest It will be available in 7.0.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125543] Calc window width and height resize to zero when unmaximizing
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 Jean-François Fortin Tam changed: What|Removed |Added Summary|Calc resizes to zero|Calc window width and ||height resize to zero when ||unmaximizing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125543] Calc resizes to zero
https://bugs.documentfoundation.org/show_bug.cgi?id=125543 --- Comment #11 from Jean-François Fortin Tam --- This bites me almost daily because whenever I open Calc by opening a document, and it opens maximized, and I un-maximize the window (Super+downarrow key in GNOME), it ends up becoming a 1x1 pixels (or something like that) micro window that is barely noticeable. Non-technical users (like many people in my extended family, who don't know the keyboard shortcuts to un/maximimize) would be pretty flustered by that and will end up with a "broken" app practically speaking. > SetMinOutputSizePixel sets the minimum size below which a window cannot be > shrunk, which is probably not whats wanted. Actually that's exactly what I would want, at least as the fallback for undefined states where the app can't figure out what the appropriate default size would be. Make it enforce a hard minimum of 600x400 at the very least. Why would anyone ever want to have a LibreOffice Calc/Writer/etc. main window sized anywhere smaller than 640x480 pixels? It seems to me that it could safely be assumed to be the absolute minimum to which a main app window can no longer be shrunk, because it's no longer usable below that size (even the toolbars would eat half of the height). Even phones these days have at least 720px in one dimension or the other, and no VGA output that I know shrinks below 640x480 even in disaster scenarios. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141855] Saving document under new title does not change displayed document location
https://bugs.documentfoundation.org/show_bug.cgi?id=141855 Michael Warner changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|NEW Ever confirmed|0 |1 --- Comment #2 from Michael Warner --- (In reply to psidiumcode from comment #1) > > *** This bug has been marked as a duplicate of bug 125182 *** I don't think this is a duplicate. In Bug 125182, the user moves or renames the document in the Mac OS Finder, outside of LibreOffice, and then expects the LO titlebar path to automatically change to the new location. (I think a discussion can be had as to whether this expectation is reasonable or correct.) But in this bug 141855, the user uses Save As... from inside LO to save to a new location. In this case, it seems much clearer that the title bar should change to the new location. In any case, these are two different scenarios, and two different bugs. So, I am putting this one back to NEW. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141831] LibreOffice becomes laggy after typing some Japanese on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=141831 --- Comment #8 from pei...@andrew.cmu.edu --- Version: 7.1.2.2 / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: en-US (en_JP.UTF-8); UI: en-US Calc: threaded The recognition is due to me setting Chinese as the default Asian language, so it's not a bug. I am just not sure if it is expected that incorrectly detected text language would cause so much lag. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79049] FILEOPEN: OOXML Workbook file hangs when opening
https://bugs.documentfoundation.org/show_bug.cgi?id=79049 Julien Nabet changed: What|Removed |Added Attachment #171169|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79049] FILEOPEN: OOXML Workbook file hangs when opening
https://bugs.documentfoundation.org/show_bug.cgi?id=79049 --- Comment #22 from Julien Nabet --- Created attachment 171542 --> https://bugs.documentfoundation.org/attachment.cgi?id=171542=edit perf flamegraph Here's an updated Flamegraph with master sources updated today (c90792cf4309557981d1f89febeff9157fd93b0c) still on the simplified example with gen rendering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
