[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/source
vcl/source/window/mouse.cxx | 19 ++--
vcl/source/window/toolbox.cxx |4 +--
vcl/source/window/winproc.cxx | 47 +-
3 files changed, 43 insertions(+), 27 deletions(-)
New commits:
commit 5a1c5c9495f31820d55ba77b0cf5dfe10ab0e6f7
Author: Gabriel Masei
AuthorDate: Fri May 28 14:37:52 2021 +0300
Commit: Dennis Francis
CommitDate: Sat Jun 12 07:30:30 2021 +0200
vcl: check mpWindowImpl before referencing it.
Fixed some cases generating crashes because mpWindowImpl was not checked
for nullptr.
Change-Id: I5540f9f21a870b02655b5bf2afdbf3a8153c1519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116466
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Dennis Francis
diff --git a/vcl/source/window/mouse.cxx b/vcl/source/window/mouse.cxx
index 16993d199987..e2f0458bf0fe 100644
--- a/vcl/source/window/mouse.cxx
+++ b/vcl/source/window/mouse.cxx
@@ -252,7 +252,7 @@ void Window::ImplGrabFocus( GetFocusFlags nFlags )
bool bAsyncFocusWaiting = false;
vcl::Window *pFrame = pSVData->maFrameData.mpFirstFrame;
-while( pFrame )
+while( pFrame && pFrame->mpWindowImpl && pFrame->mpWindowImpl->mpFrameData
)
{
if( pFrame != mpWindowImpl->mpFrameWindow.get() &&
pFrame->mpWindowImpl->mpFrameData->mnFocusId )
{
@@ -275,6 +275,8 @@ void Window::ImplGrabFocus( GetFocusFlags nFlags )
bMustNotGrabFocus = true;
break;
}
+if (!pParent->mpWindowImpl)
+break;
pParent = pParent->mpWindowImpl->mpParent;
}
@@ -332,13 +334,16 @@ void Window::ImplGrabFocus( GetFocusFlags nFlags )
else
{
vcl::Window* pNewOverlapWindow = ImplGetFirstOverlapWindow();
-vcl::Window* pNewRealWindow = pNewOverlapWindow->ImplGetWindow();
-pNewOverlapWindow->mpWindowImpl->mbActive = true;
-pNewOverlapWindow->Activate();
-if ( pNewRealWindow != pNewOverlapWindow )
+if ( pNewOverlapWindow && pNewOverlapWindow->mpWindowImpl )
{
-pNewRealWindow->mpWindowImpl->mbActive = true;
-pNewRealWindow->Activate();
+vcl::Window* pNewRealWindow = pNewOverlapWindow->ImplGetWindow();
+pNewOverlapWindow->mpWindowImpl->mbActive = true;
+pNewOverlapWindow->Activate();
+if ( pNewRealWindow != pNewOverlapWindow && pNewRealWindow &&
pNewRealWindow->mpWindowImpl )
+{
+pNewRealWindow->mpWindowImpl->mbActive = true;
+pNewRealWindow->Activate();
+}
}
}
diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index e7a15643f111..0a255688dd46 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -3077,7 +3077,7 @@ void ToolBox::MouseMove( const MouseEvent& rMEvt )
vcl::Window *pWin = pFocusWin->GetParent();
while (pWin)
{
-if(pWin->ImplGetWindowImpl()->mbToolBox)
+if(pWin->ImplGetWindowImpl() &&
pWin->ImplGetWindowImpl()->mbToolBox)
{
bFocusWindowIsAToolBoxChild = true;
break;
@@ -3086,7 +3086,7 @@ void ToolBox::MouseMove( const MouseEvent& rMEvt )
}
}
-if( bFocusWindowIsAToolBoxChild || (pFocusWin &&
pFocusWin->ImplGetWindowImpl()->mbToolBox && pFocusWin != this) )
+if( bFocusWindowIsAToolBoxChild || (pFocusWin &&
pFocusWin->ImplGetWindowImpl() && pFocusWin->ImplGetWindowImpl()->mbToolBox &&
pFocusWin != this) )
bDrawHotSpot = false;
if ( mbSelection && bDrawHotSpot )
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index cd6e91b21f7e..fe3b8bee916d 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -810,17 +810,20 @@ static vcl::Window* ImplGetKeyInputWindow( vcl::Window*
pWindow )
vcl::Window* pChild = pSVData->mpWinData->mpFirstFloat;
while (pChild)
{
-if (pChild->ImplGetWindowImpl()->mbFloatWin)
+if (pChild->ImplGetWindowImpl())
{
-if (static_cast(pChild)->GrabsFocus())
-break;
-}
-else if (pChild->ImplGetWindowImpl()->mbDockWin)
-{
-vcl::Window* pParent =
pChild->GetWindow(GetWindowType::RealParent);
-if (pParent && pParent->ImplGetWindowImpl()->mbFloatWin &&
-static_cast(pParent)->GrabsFocus())
-break;
+if (pChild->ImplGetWindowImpl()->mbFloatWin)
+{
+if (static_cast(pChild)->GrabsFocus())
+break;
+}
+else if (pChild->ImplGetWindowImpl()->mbDockWin)
+{
+vcl::Window* pParent =
pChild->GetWindow(GetWindowType::RealParent);
+if (pParent && pParent->ImplGetWindowImpl()->mbFloatWin &&
+static_cast(pParent)->GrabsFocus())
+
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Dieter changed: What|Removed |Added Depends on||126513 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126513 [Bug 126513] SHAPES: Conflict between shape in background and paragraph with background color (steps in comment 5) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67272] VIEWING Paragraph border on front of image but paragraph background color is at the back
https://bugs.documentfoundation.org/show_bug.cgi?id=67272 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6513 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107831] [META] Paragraph-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107831 Dieter changed: What|Removed |Added Depends on||126513 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126513 [Bug 126513] SHAPES: Conflict between shape in background and paragraph with background color (steps in comment 5) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126513] SHAPES: Conflict between shape in background and paragraph with background color (steps in comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=126513 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|FORMATTING: Colored |SHAPES: Conflict between |Form-Element in Background |shape in background and |overlaps Heading paragraph |paragraph with background |with colored area |color (steps in comment 5) Keywords||needsUXEval See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||272 Blocks||108741, 107831 --- Comment #5 from Dieter --- Still present in Version: 7.1.4.2 (x64) / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps to reproduce 1. Open a new document 3. Write some text 2. Insert a shape and drag it over the text 3. Choose "In Background" for wrap settings => shape is now in background of the text => O. K. 4. Add a background color to the paragraph Actual result: Background color of the paragraph is in the background of the shape Expected result: Should be a possibility to make paragraph background visible Additional information: If you add a border to the paragraph, border is visible Not sure for 100% about the expected result => cc: Design Team Bug 67272 describes the same behaviour with images in background. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107831 [Bug 107831] [META] Paragraph-level bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126513] SHAPES: Conflict between shape in background and paragraph with background color (steps in comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=126513 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|FORMATTING: Colored |SHAPES: Conflict between |Form-Element in Background |shape in background and |overlaps Heading paragraph |paragraph with background |with colored area |color (steps in comment 5) Keywords||needsUXEval See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||272 Blocks||108741, 107831 --- Comment #5 from Dieter --- Still present in Version: 7.1.4.2 (x64) / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Steps to reproduce 1. Open a new document 3. Write some text 2. Insert a shape and drag it over the text 3. Choose "In Background" for wrap settings => shape is now in background of the text => O. K. 4. Add a background color to the paragraph Actual result: Background color of the paragraph is in the background of the shape Expected result: Should be a possibility to make paragraph background visible Additional information: If you add a border to the paragraph, border is visible Not sure for 100% about the expected result => cc: Design Team Bug 67272 describes the same behaviour with images in background. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107831 [Bug 107831] [META] Paragraph-level bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 142527] Add caption category "LibreOffice Writer Listing"
https://bugs.documentfoundation.org/show_bug.cgi?id=142527 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142527] Add caption category "LibreOffice Writer Listing"
https://bugs.documentfoundation.org/show_bug.cgi?id=142527 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142385] FILEOPEN XLSX Chart Axis labels with many data points are not skipped
https://bugs.documentfoundation.org/show_bug.cgi?id=142385 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141791] Collabora Office - About screen has a link to website that throws an error message
https://bugs.documentfoundation.org/show_bug.cgi?id=141791 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142545] Unreadable animation sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=142545 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142541] Border formatting in Impress and Writer Tables does not consider the selected Border Color
https://bugs.documentfoundation.org/show_bug.cgi?id=142541 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 133783] FILEOPEN dialog does not show current working directory
https://bugs.documentfoundation.org/show_bug.cgi?id=133783 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 133783] FILEOPEN dialog does not show current working directory
https://bugs.documentfoundation.org/show_bug.cgi?id=133783 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133783] FILEOPEN dialog does not show current working directory
https://bugs.documentfoundation.org/show_bug.cgi?id=133783 --- Comment #15 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 133783] FILEOPEN dialog does not show current working directory
https://bugs.documentfoundation.org/show_bug.cgi?id=133783 --- Comment #15 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137792] FILEOPEN DOCX: Text distribution between pages different mostly because header being smaller
https://bugs.documentfoundation.org/show_bug.cgi?id=137792 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137792] FILEOPEN DOCX: Text distribution between pages different mostly because header being smaller
https://bugs.documentfoundation.org/show_bug.cgi?id=137792 --- Comment #6 from QA Administrators --- Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 135865, which changed state. Bug 135865 Summary: LibreOffice crashed https://bugs.documentfoundation.org/show_bug.cgi?id=135865 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135865] LibreOffice crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=135865 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135865] LibreOffice crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=135865 --- Comment #10 from QA Administrators --- Dear jpopelka, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135473] Impress "loading document" is SLOW
https://bugs.documentfoundation.org/show_bug.cgi?id=135473 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135473] Impress "loading document" is SLOW
https://bugs.documentfoundation.org/show_bug.cgi?id=135473 --- Comment #4 from QA Administrators --- Dear Aldo Díaz, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138852] Polices de caractères
https://bugs.documentfoundation.org/show_bug.cgi?id=138852 --- Comment #3 from QA Administrators --- Dear Jacques Breuneval, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79544] Impress not yet able to import and render faithfully Office 2007 “WordArt Effects” text styles
https://bugs.documentfoundation.org/show_bug.cgi?id=79544 --- Comment #9 from QA Administrators --- Dear Daniel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65260] FILEOPEN: DOCX imports Wordart "Effects" as simple text box
https://bugs.documentfoundation.org/show_bug.cgi?id=65260 --- Comment #11 from QA Administrators --- Dear Adam CloudOn, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34850] incorrect positioning when dragging newly-created frame (editing formatting ui)
https://bugs.documentfoundation.org/show_bug.cgi?id=34850 --- Comment #14 from QA Administrators --- Dear Lawrence D'Oliveiro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123567] Unable to add certain shapes in Customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=123567 --- Comment #4 from QA Administrators --- Dear thinkedsfoxe, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117783] UI: changing icon set via options does not trigger change of some icons in open Base window
https://bugs.documentfoundation.org/show_bug.cgi?id=117783 --- Comment #9 from QA Administrators --- Dear Drew Jensen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117512] The loading of the properties dialog form settings is a little slow when opening it with double click
https://bugs.documentfoundation.org/show_bug.cgi?id=117512 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117462] FORMATING: Rendering of svg file (LO-Logo) is incorrect and corrupt after rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=117462 --- Comment #12 from QA Administrators --- Dear Micha, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108376] EDITING: Formatting (partially) lost if content is copied from a inside a cell and pasted into a new one
https://bugs.documentfoundation.org/show_bug.cgi?id=108376 --- Comment #9 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131138] Cannot export a master document to EPUB.
https://bugs.documentfoundation.org/show_bug.cgi?id=131138 --- Comment #7 from Errol --- I found the same bug. Can not export EPUB from .odm, but exporting to .odt then exporting to epub work-around works. Error message is the same (except for the file name). LibreOffice Version: 6.4.7.2 Build ID: 1:6.4.7-0ubuntu0.20.04.1 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Build Failure on OpenSUSE Tumbleweed after distro upgrade: `NSSUTIL_3.59' not found
Builds are now failing on the rolling distro OpenSUSE Tumbleweed After the latest update, both gcc and clang builds and both both x86-64 and i686 architectures fail. Seems to be caused by caused by: java.io.IOException: /core/instdir/program/libnssutil3.so: version `NSSUTIL_3.59' not found (required by /usr/lib64/libnss3.so) mozilla-nss should provide libnss3.so(NSS_3.59) https://opensuse.pkgs.org/tumbleweed/mozilla-x86_64/mozilla-nss-32bit-3.64-1.6.x86_64.rpm.html Here is my upgrade log: https://controlc.com/79ec2502 Below is my build log. If I add, "--with-system-nss" to my autogen.input file, the build succeeds without any issue. Any thoughts has to how to fix this or ideas on the root cause? -Luke [CUT] sd_uimpress [DEP] LNK:CppunitTest/libtest_sd_import_tests.so [LNK] CppunitTest/libtest_sd_import_tests.so ... [_RUN_] SdImportTest::testDocumentLayout Exception in thread "main" java.lang.ExceptionInInitializerError at java.base/java.util.UUID.randomUUID(UUID.java:147) at org.probatron.officeotron.sessionstorage.Store.putZippedResource(Unknown Source) at org.probatron.officeotron.CommandLineSubmission.(Unknown Source) at org.probatron.officeotron.Driver.main(Unknown Source) Caused by: java.security.ProviderException: Could not initialize NSS at jdk.crypto.cryptoki/sun.security.pkcs11.SunPKCS11.(SunPKCS11.java:228) at jdk.crypto.cryptoki/sun.security.pkcs11.SunPKCS11$1.run(SunPKCS11.java:112) at jdk.crypto.cryptoki/sun.security.pkcs11.SunPKCS11$1.run(SunPKCS11.java:109) at java.base/java.security.AccessController.doPrivileged(Native Method) at jdk.crypto.cryptoki/sun.security.pkcs11.SunPKCS11.configure(SunPKCS11.java:109) at java.base/sun.security.jca.ProviderConfig$3.run(ProviderConfig.java:251) at java.base/sun.security.jca.ProviderConfig$3.run(ProviderConfig.java:242) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/sun.security.jca.ProviderConfig.doLoadProvider(ProviderConfig.java:242) at java.base/sun.security.jca.ProviderConfig.getProvider(ProviderConfig.java:222) at java.base/sun.security.jca.ProviderList.getProvider(ProviderList.java:266) at java.base/sun.security.jca.ProviderList$3.get(ProviderList.java:156) at java.base/sun.security.jca.ProviderList$3.get(ProviderList.java:151) at java.base/java.util.AbstractList$Itr.next(AbstractList.java:371) at java.base/java.security.SecureRandom.getDefaultPRNG(SecureRandom.java:264) at java.base/java.security.SecureRandom.(SecureRandom.java:219) at java.base/java.util.UUID$Holder.(UUID.java:101) ... 4 more Caused by: java.io.IOException: /core/instdir/program/libnssutil3.so: version `NSSUTIL_3.59' not found (required by /usr/lib64/libnss3.so) at jdk.crypto.cryptoki/sun.security.pkcs11.Secmod.nssLoadLibrary(Native Method) at jdk.crypto.cryptoki/sun.security.pkcs11.Secmod.initialize(Secmod.java:220) at jdk.crypto.cryptoki/sun.security.pkcs11.SunPKCS11.(SunPKCS11.java:223) ... 20 more /core/test/source/bootstrapfixture.cxx:232:SdImportTest::testDocumentLayout equality assertion failed - Expected: 0 - Actual : 256 - failed to execute: sh /core/bin/officeotron.sh /tmp/lu29374sgbpuh.tmp > /tmp/lu29374sgbpuj.tmp SdImportTest::testDocumentLayout finished in: 2754ms [_RUN_] SdImportTest::testCustomSlideShow SdImportTest::testCustomSlideShow finished in ... [_RUN_] SdImportTest::testTdf103347 SdImportTest::testTdf103347 finished in: 68ms bootstrapfixture.cxx:232:Assertion Test name: SdImportTest::testDocumentLayout equality assertion failed - Expected: 0 - Actual : 256 - failed to execute: sh /core/bin/officeotron.sh /tmp/lu29374sgbpuh.tmp > /tmp/lu29374sgbpuj.tmp Failures !!! Run: 108 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: make CppunitTest_sd_import_tests CPPUNITTRACE="gdb --args" ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 --- Comment #22 from mrkal...@gmail.com --- See the example video of the bug happening. The 'C' column should be the last visible column. But after reopening the edited file, the columns from BM onwards became visible. These columns were expected to be hidden. https://sendvid.com/kf3tqdzn or https://www.mediafire.com/file/al5ijvcmaern6jr/bug.mp4/file -- Version: 7.1.4.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Ubuntu package version: 1:7.1.4~rc2-0ubuntu0.20.04.1~lo1 Linux Mint Cinnamon x64 20.1 X11 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: LibreOfficeAndroid APK compilation issues
Hi, On 2021-06-01 04:22, 猫咪 wrote: Hello!I am a developer compiling LibreOffice. I would like to ask you a question. Why does the Android APK compiled according to the official requirements flash back when opening the Office document? Opening documents with Android Viewer works for me in an own master build and with the daily build available from TDF (tested also on real arm32 and arm64 devices). Can you be more specific what "flash back" means? Does the app crash? Is there possibly any relevant information in the ADB log? Does it work when you install the APK from TDF's daily build instead? It's available here: https://dev-builds.libreoffice.org/daily/master/current.html My compile environment: Ubuntu20.04 The NDK: r19c or NDK22.1 Android4.0 or Android5.0 or Android11.0 JDK11 What options are you passing to 'autogen.sh' (e.g. via autogen.input)? What Android device are you using? FYI, I'm mostly using an x86 AVD (Android Virtual Device) and use this autogen.input (with '...' being the path to my home dir) for development purposes: --build=x86_64-unknown-linux-gnu --with-android-ndk=.../Android/Sdk/ndk/20.0.5594570/ --with-android-sdk=.../Android/Sdk --with-distro=LibreOfficeAndroidX86 --enable-sal-log --enable-ccache --enable-dbgutil --with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 142771] LibreOffice change MS Word fields
https://bugs.documentfoundation.org/show_bug.cgi?id=142771
--- Comment #3 from Mohammadreza ---
(In reply to m.a.riosv from comment #1)
> Please attach a sample file to test.
Hi,
I attached a file. in MS Word, if you right click on the reference [1] in the
text and select "Toggle Field Codes", you can see the field codes. Then Open
this file in LibreOffice Writer and just save it without any change. Again open
the file in MS Word and check the field codes.
You will see that a space after { is omitted by LibreOffice.
Best,
Mohammadreza
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142771] LibreOffice change MS Word fields
https://bugs.documentfoundation.org/show_bug.cgi?id=142771 --- Comment #2 from Mohammadreza --- Created attachment 172831 --> https://bugs.documentfoundation.org/attachment.cgi?id=172831=edit MS Word file with EndNote fields (as references) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142811] New: UI: Ruler grid inaccurate for tabstops in metric units
https://bugs.documentfoundation.org/show_bug.cgi?id=142811 Bug ID: 142811 Summary: UI: Ruler grid inaccurate for tabstops in metric units Product: LibreOffice Version: 7.1.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mail...@gmx.de Description: When placing a tabstop on the ruler with the mouse, it snaps into the nearest grid point. However, using Centimeter as measuring unit causes unexpected deviations of +- 0,01 cm from the regular grid positions, which can be detected in the Paragraph > Tabs dialog view. Steps to Reproduce: 1. Open a new text-document 2. Make sure to use Centimeter as Measurement Unit in Tools > Options > LibreOffice Writer > General 3. Also use Centimeters with the ruler: right-click on the ruler and select "Centimeter" from the context menu 4. Choose Paper Format "A4" in Format > Page Style... 5. Set View > Zoom > 100% (only full- and half- cm tick marks should be visible on the ruler) 6. By clicking and dragging the mouse on the ruler, place a tabstop at the 16 cm tick mark 7. Check the location of tabstops in the Format > Paragraph > Tabs dialog. Actual Results: Position of the tabstop is shown to be 16,01 cm Expected Results: Tabstop should be placed at exactly 16,00 cm Reproducible: Always User Profile Reset: No Additional Info: Workaround: Zoom in more or use the Paragraph > Tabs dialog. The behaviour was also observed in different units (e.g. milimeters), at various zoom-levels and with other tabstop positions (not too small). Suspecting a unit-conversion/rounding/floating point error. Tested on monitor with DPI scaling 100% (72 DPI). Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/GraphicTest.cxx | 79 +++
vcl/qa/cppunit/data/wmf-embedded-emfplus.wmf |binary
vcl/source/filter/wmf/wmf.cxx| 11 ++-
3 files changed, 85 insertions(+), 5 deletions(-)
New commits:
commit 6b349bcc32336664a31deed3f4463e40dd028f63
Author: Luboš Luňák
AuthorDate: Fri Jun 11 15:51:32 2021 +0200
Commit: Luboš Luňák
CommitDate: Fri Jun 11 23:59:46 2021 +0200
when converting WMF to WMF, simply do a direct copy
Actually, if we have the graphics data, just copy the graphics data,
that'll keep both the EMF+ and non-EMF+ content.
Change-Id: Ia14df0ba2a94d4310ee745b49de1d2190e425f05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117063
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/qa/cppunit/GraphicTest.cxx b/vcl/qa/cppunit/GraphicTest.cxx
index 608c5f4de85d..e9af574aa5a4 100644
--- a/vcl/qa/cppunit/GraphicTest.cxx
+++ b/vcl/qa/cppunit/GraphicTest.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
@@ -53,6 +54,7 @@ private:
void testUnloadedGraphicSizeUnit();
void testWMFRoundtrip();
+void testWMFWithEmfPlusRoundtrip();
void testEmfToWmfConversion();
void testSwappingGraphic_PNG_WithGfxLink();
@@ -89,6 +91,7 @@ private:
CPPUNIT_TEST(testUnloadedGraphicAlpha);
CPPUNIT_TEST(testUnloadedGraphicSizeUnit);
CPPUNIT_TEST(testWMFRoundtrip);
+CPPUNIT_TEST(testWMFWithEmfPlusRoundtrip);
CPPUNIT_TEST(testEmfToWmfConversion);
CPPUNIT_TEST(testSwappingGraphic_PNG_WithGfxLink);
@@ -411,6 +414,82 @@ void GraphicTest::testWMFRoundtrip()
CPPUNIT_ASSERT_EQUAL(nExpectedSize, nActualSize);
}
+int getEmfPlusActionsCount(const Graphic& graphic)
+{
+const GDIMetaFile& metafile = graphic.GetGDIMetaFile();
+int emfPlusCount = 0;
+for (size_t i = 0; i < metafile.GetActionSize(); ++i)
+{
+MetaAction* action = metafile.GetAction(i);
+if (action->GetType() == MetaActionType::COMMENT)
+{
+const MetaCommentAction* commentAction = static_cast(action);
+if (commentAction->GetComment() == "EMF_PLUS")
+++emfPlusCount;
+}
+}
+return emfPlusCount;
+}
+
+int getPolygonActionsCount(const Graphic& graphic)
+{
+const GDIMetaFile& metafile = graphic.GetGDIMetaFile();
+int polygonCount = 0;
+for (size_t i = 0; i < metafile.GetActionSize(); ++i)
+{
+MetaAction* action = metafile.GetAction(i);
+if (action->GetType() == MetaActionType::POLYGON)
+++polygonCount;
+}
+return polygonCount;
+}
+
+void GraphicTest::testWMFWithEmfPlusRoundtrip()
+{
+// Load a WMF file.
+test::Directories aDirectories;
+OUString aURL =
aDirectories.getURLFromSrc(u"vcl/qa/cppunit/data/wmf-embedded-emfplus.wmf");
+SvFileStream aStream(aURL, StreamMode::READ);
+sal_uInt64 nExpectedSize = aStream.TellEnd();
+GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter();
+Graphic aGraphic = rGraphicFilter.ImportUnloadedGraphic(aStream);
+
+CPPUNIT_ASSERT_GREATER(0, getEmfPlusActionsCount(aGraphic));
+CPPUNIT_ASSERT_EQUAL(0, getPolygonActionsCount(aGraphic));
+
+for (bool useConvertMetafile : { false, true })
+{
+// Save as WMF.
+utl::TempFile aTempFile;
+aTempFile.EnableKillingFile();
+SvStream& rOutStream = *aTempFile.GetStream(StreamMode::READWRITE);
+if (useConvertMetafile)
+ConvertGraphicToWMF(aGraphic, rOutStream, nullptr);
+else
+{
+sal_uInt16 nFormat =
rGraphicFilter.GetExportFormatNumberForShortName(u"WMF");
+rGraphicFilter.ExportGraphic(aGraphic, OUString(), rOutStream,
nFormat);
+}
+CPPUNIT_ASSERT_EQUAL(nExpectedSize, rOutStream.TellEnd());
+
+rOutStream.Seek(0);
+Graphic aNewGraphic = rGraphicFilter.ImportUnloadedGraphic(rOutStream);
+// Check that reading the WMF back preserves the EMF+ actions in it.
+CPPUNIT_ASSERT_GREATER(0, getEmfPlusActionsCount(aNewGraphic));
+// EmfReader::ReadEnhWMF() drops non-EMF+ drawing actions if EMF+ is
found.
+CPPUNIT_ASSERT_EQUAL(0, getPolygonActionsCount(aNewGraphic));
+
+// With EMF+ disabled there should be no EMF+ actions.
+auto& rDataContainer = aNewGraphic.GetGfxLink().getDataContainer();
+auto aVectorGraphicData
+= std::make_shared(rDataContainer,
VectorGraphicDataType::Wmf);
+aVectorGraphicData->setEnableEMFPlus(false);
+Graphic aNoEmfPlusGraphic(aVectorGraphicData);
+CPPUNIT_ASSERT_EQUAL(0, getEmfPlusActionsCount(aNoEmfPlusGraphic));
+CPPUNIT_ASSERT_GREATER(0, getPolygonActionsCount(aNoEmfPlusGraphic));
+}
+}
+
void GraphicTest::testEmfToWmfConversion()
{
// Load EMF data.
diff --git a/vcl/qa/cppunit/data/wmf-embedded-emfplus.wmf
[Libreoffice-commits] core.git: emfio/inc emfio/source vcl/source
emfio/inc/wmfreader.hxx|5 +
emfio/source/emfuno/xemfparser.cxx |5 -
emfio/source/reader/emfreader.cxx |2 +-
emfio/source/reader/wmfreader.cxx |1 +
vcl/source/filter/wmf/wmf.cxx | 10 ++
5 files changed, 17 insertions(+), 6 deletions(-)
New commits:
commit b342a445cd8b115e76d261860088b012b74c0b0e
Author: Luboš Luňák
AuthorDate: Fri Jun 11 15:48:32 2021 +0200
Commit: Luboš Luňák
CommitDate: Fri Jun 11 23:59:32 2021 +0200
drop EMF+ also when converting WMF, not just EMF
A WMF may have EMF with EMF+ actions embedded. When we read that,
we drop drawing non-EMF+ actions if we use EMF+. But EMF+ actions
are stored as MetaCommentAction in the metafile, and WMF writer
(unlike EMF) writer simply ignores comments. So when writing WMF,
make sure to read non-EMF actions so that something is written.
This is an extension of 295626a0bd39540544b774094a63df23e5376839.
Change-Id: I37355f694fe656b661abe54274ea203934e68151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117062
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/emfio/inc/wmfreader.hxx b/emfio/inc/wmfreader.hxx
index 279f3e4caeee..a7dff2b94d85 100644
--- a/emfio/inc/wmfreader.hxx
+++ b/emfio/inc/wmfreader.hxx
@@ -51,6 +51,8 @@ namespace emfio
// eventually handed over external header
const WmfExternal* mpExternalHeader;
+bool mbEnableEMFPlus = true;
+
// reads header of the WMF-Datei
boolReadHeader();
@@ -68,6 +70,9 @@ namespace emfio
// read WMF file from stream and fill the GDIMetaFile
void ReadWMF();
+
+// Allows disabling EMF+ if EMF is embedded in this WMF.
+void SetEnableEMFPlus(bool bEnableEMFPlus) { mbEnableEMFPlus =
bEnableEMFPlus; }
};
}
diff --git a/emfio/source/emfuno/xemfparser.cxx
b/emfio/source/emfuno/xemfparser.cxx
index 7788802c4e1c..e5d27056332d 100644
--- a/emfio/source/emfuno/xemfparser.cxx
+++ b/emfio/source/emfuno/xemfparser.cxx
@@ -130,7 +130,10 @@ namespace emfio::emfreader
}
else
{
-emfio::WmfReader(*pStream, aMtf, bExternalHeaderUsed ?
: nullptr).ReadWMF();
+emfio::WmfReader aReader(*pStream, aMtf,
bExternalHeaderUsed ? : nullptr);
+if (!bEnableEMFPlus)
+aReader.SetEnableEMFPlus(bEnableEMFPlus);
+aReader.ReadWMF();
// Need to check for ErrCode at stream to not lose
former work.
// This may contain important information and will
behave the
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index 04f591a7eb9a..4ad77dd3fb32 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -817,7 +817,7 @@ namespace emfio
bEnableEMFPlus = mbEnableEMFPlus;
}
-SAL_INFO("emfio", "EMF_PLUS_DISABLE is " << (bEnableEMFPlus ?
"enabled" : "disabled"));
+SAL_INFO("emfio", "EMF+ reading is " << (bEnableEMFPlus ? "enabled" :
"disabled"));
while (bStatus && mnRecordCount-- && mpInputStream->good() &&
!mbReadOtherGraphicFormat)
{
diff --git a/emfio/source/reader/wmfreader.cxx
b/emfio/source/reader/wmfreader.cxx
index 93908503d9bf..9ddb674b7c05 100644
--- a/emfio/source/reader/wmfreader.cxx
+++ b/emfio/source/reader/wmfreader.cxx
@@ -1596,6 +1596,7 @@ namespace emfio
GDIMetaFile aMeta;
mpEMFStream->Seek( 0 );
std::unique_ptr
pEMFReader(std::make_unique( *mpEMFStream, aMeta ));
+pEMFReader->SetEnableEMFPlus(mbEnableEMFPlus);
bEMFAvailable = pEMFReader->ReadEnhWMF();
pEMFReader.reset(); // destroy first!!!
diff --git a/vcl/source/filter/wmf/wmf.cxx b/vcl/source/filter/wmf/wmf.cxx
index ccff80c20339..ee1ce77e4185 100644
--- a/vcl/source/filter/wmf/wmf.cxx
+++ b/vcl/source/filter/wmf/wmf.cxx
@@ -88,13 +88,15 @@ bool ConvertGraphicToWMF(const Graphic& rGraphic, SvStream&
rTargetStream,
FilterConfigItem const* pConfigItem, bool bPlaceable)
{
GfxLink aLink = rGraphic.GetGfxLink();
-if (aLink.IsEMF() && aLink.GetData() && aLink.GetDataSize())
+if (aLink.GetType() == GfxLinkType::NativeWmf && aLink.GetData() &&
aLink.GetDataSize())
{
-// This may be an EMF+ file, converting that to WMF is better done by
re-parsing EMF+ as EMF
-// and converting that to WMF.
+// This may be an EMF+ file or WMF file with EMF+ embedded. In
EmfReader::ReadEnhWMF()
+// we normally drop non-EMF commands when reading EMF+, so converting
that to WMF
+// is better done by re-parsing with EMF+ disabled.
auto &
[Libreoffice-bugs] [Bug 142810] New: Add "Apply this animation effect to currently focused slide object" to context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=142810 Bug ID: 142810 Summary: Add "Apply this animation effect to currently focused slide object" to context menu Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Adding custom animations is a hassle. Some if it is inherent - some of it is due to various bugs. Features to make it more convenient, and specifically more speedy, are welcome. Specifically, if I've configured a custom effect, I might want to apply the exact same effect to another object. If I have that object selected, I would like to be able, when right-clicking an existing effect, to have a menu option for applying the same animation effect to my focused object. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88938] SIDEBAR: Copy and paste custom animation style
https://bugs.documentfoundation.org/show_bug.cgi?id=88938 Eyal Rozenberg changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2810 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/optdlg/tpformula.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 381bc9d9acd461415cf81eef71ec3dd935a07b62
Author: Eike Rathke
AuthorDate: Fri Jun 11 22:22:13 2021 +0200
Commit: Eike Rathke
CommitDate: Fri Jun 11 23:50:44 2021 +0200
Related: tdf#127013 Check loaded separators for validity
... not only if something is present at all.
That way future restrictions can reset separators.
Change-Id: I738bcb9e052e8dbecb0a6cd07bbae8f4a8ea1c35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117072
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/ui/optdlg/tpformula.cxx
b/sc/source/ui/optdlg/tpformula.cxx
index 2f24e0714e71..c7d29e03dbc6 100644
--- a/sc/source/ui/optdlg/tpformula.cxx
+++ b/sc/source/ui/optdlg/tpformula.cxx
@@ -372,9 +372,9 @@ void ScTpFormulaOptions::Reset(const SfxItemSet* rCoreSet)
OUString aSepArrayRow = aOpt.GetFormulaSepArrayRow();
OUString aSepArrayCol = aOpt.GetFormulaSepArrayCol();
-if (aSep.getLength() == 1 && aSepArrayRow.getLength() == 1 &&
aSepArrayCol.getLength() == 1)
+if (IsValidSeparator(aSep, false) && IsValidSeparator(aSepArrayRow, true)
&& IsValidSeparator(aSepArrayCol, true))
{
-// Each separator must be one character long.
+// Each and all separators must be valid.
mxEdSepFuncArg->set_text(aSep);
mxEdSepArrayCol->set_text(aSepArrayCol);
mxEdSepArrayRow->set_text(aSepArrayRow);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88938] SIDEBAR: Copy and paste custom animation style
https://bugs.documentfoundation.org/show_bug.cgi?id=88938 Eyal Rozenberg changed: What|Removed |Added CC||eyalr...@gmx.com --- Comment #6 from Eyal Rozenberg --- This would definitely be useful - especially when every second thing you do with custom animations causes de-selection/change of focus. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Valek Filippov changed: What|Removed |Added Depends on||142809 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142809 [Bug 142809] [EMF] SetDIBitsToDevice EMR is not implemented -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142809] [EMF] SetDIBitsToDevice EMR is not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=142809 Valek Filippov changed: What|Removed |Added Blocks||103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142809] [EMF] SetDIBitsToDevice EMR is not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=142809 --- Comment #2 from Valek Filippov --- Created attachment 172830 --> https://bugs.documentfoundation.org/attachment.cgi?id=172830=edit How it should look like -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142809] [EMF] SetDIBitsToDevice EMR is not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=142809 --- Comment #1 from Valek Filippov --- Created attachment 172829 --> https://bugs.documentfoundation.org/attachment.cgi?id=172829=edit EMF sample with SetDIBitsToDevice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142809] New: [EMF] SetDIBitsToDevice EMR is not implemented
https://bugs.documentfoundation.org/show_bug.cgi?id=142809 Bug ID: 142809 Summary: [EMF] SetDIBitsToDevice EMR is not implemented Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: f...@df.ru Description: LO doesn't support SetDIBitsToDevice EMR. [MS-EMF] 2.3.1.5 https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-emf/e8816cc6-35d2-43e6-8d88-d69cd342372e Steps to Reproduce: Open attached EMF sample. Actual Results: LO shows empty object. Expected Results: It should show small rectangle filled with different shades of blue. Reproducible: Always User Profile Reset: No Additional Info: Similar bug exists for AOO: bz67905. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142808] New: UI: Tabstop jumps on ruler when placed on right triangle
https://bugs.documentfoundation.org/show_bug.cgi?id=142808 Bug ID: 142808 Summary: UI: Tabstop jumps on ruler when placed on right triangle Product: LibreOffice Version: 7.1.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mail...@gmx.de Description: In a paragraph with hanging (negative first line) indent, a tabstop that is moved exactly to the position of the right lower triangle on the ruler (by mouse-click & drag) is immediately shifted to the right (by the amount of hanging indent) upon release of the mouse button. Steps to Reproduce: 1. Open a new text-document 2. On the ruler, use the mouse to drag the position of both the right page margin, as well as the right lower triangle (indent after text), just a little bit as to make sure they are snapped into a ruler-grid position 3. Move the upper left triangle to a position on the left of the lower left triangle 4. Insert a tab-stop by clicking into the ruler without releasing the mouse; then move the mouse directly on top of the right lower triangle and release Actual Results: The newly created tab-stop jumps to the right by the distance between the left upper- and the left lower triangle Expected Results: The newly created tab-stop should stay in the (cursor-) position where it was located when the mouse was released. Reproducible: Always User Profile Reset: No Additional Info: Note: Step (2.) is only necessary when the ruler grid is not yet aligned with the page margins, which often is the case. This bug may cause the tabstop to disappear entirely from the ruler (namely, when the hanging indent happens to exceed the right page margin). Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142807] New: Libreoffice don't insert nor playback videos from ver 7 and later
https://bugs.documentfoundation.org/show_bug.cgi?id=142807 Bug ID: 142807 Summary: Libreoffice don't insert nor playback videos from ver 7 and later Product: LibreOffice Version: 7.1.0.0.alpha0+ Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alej@gmail.com Description: >From ver 7.1 and later Libreoffice Impress for linux (both deb and Appimage packages) can't insert videos (tested with mp4,avi,mkv containers and x264, divx codecs). Also, odp files with videos inserted in LO 6.4 (that works ok) don't playback them and hangs in LO 7.1 and later. My system is KDE Neon (Ubuntu 20.04 focal fossa) with full gstreamer install (all plugins). Error showed in terminal: (libreoffice:16194): GLib-GObject-CRITICAL **: 18:01:30.112: g_object_set: assertion 'G_IS_OBJECT (object)' failed (libreoffice:16194): GLib-GObject-CRITICAL **: 18:01:30.112: g_object_set: assertion 'G_IS_OBJECT (object)' failed (libreoffice:16194): GStreamer-CRITICAL **: 18:01:30.112: gst_element_get_bus: assertion 'GST_IS_ELEMENT (element)' failed (libreoffice:16194): GStreamer-CRITICAL **: 18:01:30.112: gst_bus_add_watch_full: assertion 'GST_IS_BUS (bus)' failed (libreoffice:16194): GStreamer-CRITICAL **: 18:01:30.112: gst_bus_set_sync_handler: assertion 'GST_IS_BUS (bus)' failed (libreoffice:16194): GLib-GObject-CRITICAL **: 18:01:30.112: g_object_unref: assertion 'G_IS_OBJECT (object)' failed (libreoffice:16194): GStreamer-CRITICAL **: 18:01:30.112: gst_element_set_state: assertion 'GST_IS_ELEMENT (element)' failed Steps to Reproduce: 1. Open Libreoffice Impress 7.1+ 2. Insert video 3. Try to playback Actual Results: After following the steps above, the system freeze for some time with no playback Expected Results: View the inserted video in the slide and be able to playback Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Hangs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 --- Comment #3 from Bogdan Stăncescu --- To be honest, I'm not sure if I can install 7.1.x while still retaining 7.0.x; I'm actually using LibreOffice for business purposes, I don't have an isolated Windows VM to test on, and I'm a bit concerned installing a version not deemed stable. I'm open to suggestions, however. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6804eb2c740d2b2310399ae14bfa0bb2e6e24a91 Author: Rafael Lima AuthorDate: Fri Jun 11 22:42:55 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Jun 11 22:42:55 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 38ce99f8010aed59242b817b866055407f22cefb - Create introductory ScriptForge help page Change-Id: I5fd00cc05b0c28b600974c005a81804c1c6d5e74 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116906 Tested-by: Jenkins Reviewed-by: Rafael Lima diff --git a/helpcontent2 b/helpcontent2 index ab81b6bfa02c..38ce99f8010a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ab81b6bfa02cd89c244bc55148486324863844f8 +Subproject commit 38ce99f8010aed59242b817b866055407f22cefb ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text
AllLangHelp_sbasic.mk|1
source/text/sbasic/python/main.xhp |1
source/text/sbasic/shared/03/lib_ScriptForge.xhp |1
source/text/sbasic/shared/03/sf_intro.xhp| 181 +++
source/text/shared/guide/start_parameters.xhp|2
5 files changed, 185 insertions(+), 1 deletion(-)
New commits:
commit 38ce99f8010aed59242b817b866055407f22cefb
Author: Rafael Lima
AuthorDate: Fri Jun 11 03:16:26 2021 +0200
Commit: Rafael Lima
CommitDate: Fri Jun 11 22:42:55 2021 +0200
Create introductory ScriptForge help page
Change-Id: I5fd00cc05b0c28b600974c005a81804c1c6d5e74
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116906
Tested-by: Jenkins
Reviewed-by: Rafael Lima
diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index c2d750049..b1e748258 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -91,6 +91,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
helpcontent2/source/text/sbasic/shared/03/sf_filesystem \
helpcontent2/source/text/sbasic/shared/03/sf_form \
helpcontent2/source/text/sbasic/shared/03/sf_formcontrol \
+helpcontent2/source/text/sbasic/shared/03/sf_intro \
helpcontent2/source/text/sbasic/shared/03/sf_l10n \
helpcontent2/source/text/sbasic/shared/03/sf_platform \
helpcontent2/source/text/sbasic/shared/03/sf_session \
diff --git a/source/text/sbasic/python/main.xhp
b/source/text/sbasic/python/main.xhp
index f90781ba0..76a4e2589 100644
--- a/source/text/sbasic/python/main.xhp
+++ b/source/text/sbasic/python/main.xhp
@@ -39,6 +39,7 @@
+
diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
index 15eb73a56..86f12534c 100644
--- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
+++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
@@ -27,6 +27,7 @@
Basic macros
require to load ScriptForge library using the following
statement:
GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
Python scripts require an import from scriptforge
module:
from scriptforge import CreateScriptService
+To learn more about how to create and
execute Python scripts using the ScriptForge library, read
the help page.
The described
modules and classes are invoked from user scripts as "Services". A generic
constructor of those services has been designed for that purpose for each
language:
GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
diff --git a/source/text/sbasic/shared/03/sf_intro.xhp
b/source/text/sbasic/shared/03/sf_intro.xhp
new file mode 100644
index 0..525e2680d
--- /dev/null
+++ b/source/text/sbasic/shared/03/sf_intro.xhp
@@ -0,0 +1,181 @@
+
+
+
+
+
+
+Creating Python Scripts with
ScriptForge
+/text/sbasic/shared/03/sf_intro.xhp
+
+
+
+
+
+Python scripts with ScriptForge
+
+ Creating Python
Scripts with ScriptForge
+ Differences between Basic and Python
+ The ScriptForge
library is available both for Basic and Python. Most services, methods
and properties work identically in both programming languages. However, due to
differences in how each language works, ScriptForge users
must be aware of some characteristics of the library when using
Python:
+
+
+ Methods and
Property names: In Python, all methods and properties can be used in
lowercased, ProperCased or camelCased formats.
+
+
+Arguments: All keyword arguments passed on to
methods are lowercased.
+
+
+Dates: All date objects are passed and returned as
datetime.datetime native Python objects.
+
+
+ Arrays: One-dimensional arrays are passed and
returned as tuples (which is an immutable object). Two-dimensional arrays are
passed and returned as tuples of tuples.
+
+
+ None:
Python's None keyword is equivalent to Basic's
Null, Empty or
Nothing.
+
+
+ UNO
objects: All UNO structures are exchanged between Basic and Python
without any changes.
+
+
+ Debugging: Whenever an error occurs in Python
scripts that use ScriptForge, the error message provided by
the Python execution stack displays the line of code that triggered the error.
In Basic error messages do not display this information.
+
+
+ Visit for more information
on Python scripting using %PRODUCTNAME.
+ Running Python scripts on %PRODUCTNAME
+ Depending on what you
intend to achieve, you may choose one of the following approaches to running
Python scripts in %PRODUCTNAME:
+
+
+ Run Scripts
inside the current %PRODUCTNAME process: Python scripts are executed
from within the %PRODUCTNAME process by using the Tools - Macros -
Run Macro menu or the APSO extension to call user scripts stored in
the Python scripts folder. You can also use the APSO Python shell to
interactively run Python scripts.
[Libreoffice-bugs] [Bug 142805] DOCX image lost on roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=142805 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression Version|7.2.0.0 alpha1+ Master |6.3.0.4 release --- Comment #3 from Telesto --- broken bit differently Version: 6.4.0.0.beta1+ (x64) Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL again differently positioned and wrong image (but export functioning) Version: 6.3.7.0.0+ (x86) Build ID: 726535ec30f12697ceccd2f0640d9371a64dc5bd CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL everything as expected (opening & export) Version: 6.2.0.0.alpha0+ Build ID: b1d1edff4e81a8299e2a17c7e562d144329549ab CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: nl-NL (nl_NL); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142805] DOCX image lost on roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=142805 --- Comment #2 from Telesto --- And with Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 239b4bb27fd8db26e8416045b3015688a8b1b0ae CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142805] DOCX image lost on roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=142805 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Telesto --- Repro Version: 7.1.0.0.beta1+ (x64) Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142802] Page count in status bar changes from 69 to 91 after PDF export (PDF exported 69)
https://bugs.documentfoundation.org/show_bug.cgi?id=142802 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Telesto --- Marking invalid.. as this being based on 7.0 by accident -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142806] Freeze/hang when exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=142806 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #1 from Telesto --- Smooth in Version: 7.1.0.0.beta1+ (x64) Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142806] New: Freeze/hang when exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=142806 Bug ID: 142806 Summary: Freeze/hang when exporting to PDF Product: LibreOffice Version: 7.2.0.0 alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Freeze/hang when exporting to PDF Steps to Reproduce: 1. Open attachment 150827 [details] (bug 124798) 2. PDF export (at default settings) (in GUI) Actual Results: Waited 90 seconds.. Expected Results: 15 seconds like 7.0 Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 239b4bb27fd8db26e8416045b3015688a8b1b0ae CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this. However, I can reproduce this with LO Debian package 7.0.4.2. Could you give a try to brand new 7.1.4? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116640] CRASH/Assertion when undoing columns
https://bugs.documentfoundation.org/show_bug.cgi?id=116640 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2719 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142719] Undo after autocorrect two initial capitals disables auto-correction two initial capitals at profile level
https://bugs.documentfoundation.org/show_bug.cgi?id=142719 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||6640 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142719] Undo after autocorrect two initial capitals disables auto-correction two initial capitals at profile level
https://bugs.documentfoundation.org/show_bug.cgi?id=142719 Telesto changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134339] Export to pdf creates big bloated file
https://bugs.documentfoundation.org/show_bug.cgi?id=134339 --- Comment #17 from Hugh Craddock --- Hi Telesto, what happened when you repeated the export a second time? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142719] Undo after autocorrect two initial capitals disables auto-correction two initial capitals at profile level
https://bugs.documentfoundation.org/show_bug.cgi?id=142719 --- Comment #3 from Telesto --- Created attachment 172828 --> https://bugs.documentfoundation.org/attachment.cgi?id=172828=edit Bibisect log Bisected to: author Michael Stahl2015-09-07 21:52:49 +0200 committer Michael Stahl2015-09-07 22:00:27 +0200 commit 5adc8ee343e5c32d30095bc4005b7b022016b745 (patch) tree8148a23a2b68e26b43a308c71fac3feb43319814 parent 4ff0032528d7aebb0de5cf045a39972a2769029f (diff) sw: fix newly created document being modified After the document is created, an event is dispatched on the main loop that calls SfxPickList::Notify(), which modifies document properties. It tries to prevent setting the document to modified by calling SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits it by simply having its own independent(?) modified flag that is set unconditionally in DocumentStatisticsManager::DocInfoChgd(). Let's assume that if the modified flag shouldn't be modified in SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager. Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot easily bisect why that changed due to tdf#91383. https://cgit.freedesktop.org/libreoffice/core/commit/?id=5adc8ee343e5c32d30095bc4005b7b022016b745 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142805] New: DOCX image lost on roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=142805 Bug ID: 142805 Summary: DOCX image lost on roundtrip Product: LibreOffice Version: 7.2.0.0 alpha1+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 172827 --> https://bugs.documentfoundation.org/attachment.cgi?id=172827=edit testdocument Open attached file. It belongs to test testEffectExtent in ooxmlexport.cxx in sw. The document should show an image with reflection effect. Instead there is a default custom shape. Save the file to docx and reopen again. The custom shape is not visible. Expected: LibreOffice shows an image, currently without reflection, because that is not yet implemented. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/tpformula.hxx|2
sc/source/ui/optdlg/tpformula.cxx | 83 ++
2 files changed, 59 insertions(+), 26 deletions(-)
New commits:
commit bb54d6d8241a06a6772052b77b67d6a4f686426c
Author: Eike Rathke
AuthorDate: Fri Jun 11 19:02:24 2021 +0200
Commit: Eike Rathke
CommitDate: Fri Jun 11 22:09:23 2021 +0200
Resolves: tdf#127013 differentiate non-/array separators and restrict
Change-Id: I9ff6b816b0c7af9081954fa407a4d516a576a338
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117068
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/ui/inc/tpformula.hxx b/sc/source/ui/inc/tpformula.hxx
index 6f8a4c601cdf..abc14f4fde58 100644
--- a/sc/source/ui/inc/tpformula.hxx
+++ b/sc/source/ui/inc/tpformula.hxx
@@ -43,7 +43,7 @@ private:
void UpdateCustomCalcRadioButtons(bool bDefault);
void LaunchCustomCalcSettings();
-bool IsValidSeparator(const OUString& rSep) const;
+bool IsValidSeparator(const OUString& rSep, bool bArray) const;
DECL_LINK(ButtonHdl, weld::Button&, void);
DECL_LINK(ToggleHdl, weld::Toggleable&, void);
diff --git a/sc/source/ui/optdlg/tpformula.cxx
b/sc/source/ui/optdlg/tpformula.cxx
index 24d91000867f..2f24e0714e71 100644
--- a/sc/source/ui/optdlg/tpformula.cxx
+++ b/sc/source/ui/optdlg/tpformula.cxx
@@ -131,40 +131,73 @@ void ScTpFormulaOptions::LaunchCustomCalcSettings()
}
}
-bool ScTpFormulaOptions::IsValidSeparator(const OUString& rSep) const
+bool ScTpFormulaOptions::IsValidSeparator(const OUString& rSep, bool bArray)
const
{
if (rSep.getLength() != 1)
// Must be one-character long.
return false;
-if (rSep.compareToAscii("a") >= 0 && rSep.compareToAscii("z") <= 0)
+const sal_Unicode c = rSep[0];
+
+if (c == mnDecSep)
+// decimal separator is not allowed.
+return false;
+
+if (c <= 0x20 || c == 0x7f)
+// Disallow non-printables including space and DEL.
return false;
-if (rSep.compareToAscii("A") >= 0 && rSep.compareToAscii("Z") <= 0)
+if (('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z') || ('0' <= c && c <=
'9'))
+// Disallow alphanumeric.
return false;
-sal_Unicode c = rSep[0];
-switch (c)
+if (bArray)
{
-case '+':
-case '-':
-case '/':
-case '*':
-case '<':
-case '>':
-case '[':
-case ']':
-case '(':
-case ')':
-case '"':
-case '\'':
-// Disallowed characters. Anything else we want to disallow ?
-return false;
+switch (c)
+{
+case '+':
+case '-':
+case '{':
+case '}':
+case '"':
+// All following just to prevent confusion, they are not
+// evaluated in inline arrays and theoretically would be
+// possible.
+case '%':
+case '/':
+case '*':
+case '=':
+case '<':
+case '>':
+case '[':
+case ']':
+case '(':
+case ')':
+case '\'':
+// Disallowed characters. Anything else we want to disallow ?
+return false;
+}
}
-
-if (c == mnDecSep)
-// decimal separator is not allowed.
+else if (c <= 0x7f)
+{
+switch (c)
+{
+default:
+// Anything bad except the knowns.
+return false;
+case ';':
+case ',':
+; // nothing
+}
+}
+else
+{
+// Any Unicode character, would have to ask the compiler's localized
+// symbol map whether it's a known symbol but not a separator
+// (ocSep,ocArrayRowSep,ocArrayColSep), which we're about to set here.
+// But really..
return false;
+}
return true;
}
@@ -189,7 +222,7 @@ IMPL_LINK( ScTpFormulaOptions, ToggleHdl,
weld::Toggleable&, rBtn, void )
IMPL_LINK(ScTpFormulaOptions, SepInsertTextHdl, OUString&, rTest, bool)
{
-if (!IsValidSeparator(rTest) && !maOldSepValue.isEmpty())
+if (!IsValidSeparator(rTest, false) && !maOldSepValue.isEmpty())
// Invalid separator. Restore the old value.
rTest = maOldSepValue;
return true;
@@ -198,7 +231,7 @@ IMPL_LINK(ScTpFormulaOptions, SepInsertTextHdl, OUString&,
rTest, bool)
IMPL_LINK(ScTpFormulaOptions, RowSepInsertTextHdl, OUString&, rTest, bool)
{
// Invalid separator or same as ColStr - Restore the old value.
-if ((!IsValidSeparator(rTest) || rTest == mxEdSepArrayCol->get_text()) &&
!maOldSepValue.isEmpty())
+if ((!IsValidSeparator(rTest, true) || rTest ==
mxEdSepArrayCol->get_text()) && !maOldSepValue.isEmpty())
rTest = maOldSepValue;
return true;
}
@@ -206,7 +239,7 @@ IMPL_LINK(ScTpFormulaOptions,
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 71 +++
1 file changed, 66 insertions(+), 5 deletions(-)
New commits:
commit 37ddff25a67aa0b858da0e56fe7263a537002f7b
Author: Caolán McNamara
AuthorDate: Fri Jun 11 17:10:37 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jun 11 22:05:33 2021 +0200
gtk4: starting point for welded menus
submenus will need a rethink I guess
Change-Id: I6d2a645267146c537fe7ba62d8be2501855e7f62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index dbdd56994b71..98eea7cadcbe 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -10192,15 +10192,27 @@ public:
assert(false && "not implemented");
}
};
+#endif
+#if !GTK_CHECK_VERSION(4, 0, 0)
class GtkInstanceMenu : public MenuHelper, public virtual weld::Menu
+#else
+class GtkInstanceMenu : public virtual weld::Menu
+#endif
{
protected:
+#if !GTK_CHECK_VERSION(4, 0, 0)
std::vector m_aExtraItems;
+#endif
OString m_sActivated;
+#if !GTK_CHECK_VERSION(4, 0, 0)
MenuHelper* m_pTopLevelMenuHelper;
+#else
+GtkPopoverMenu* m_pMenu;
+#endif
private:
+#if !GTK_CHECK_VERSION(4, 0, 0)
virtual void signal_activate(GtkMenuItem* pItem) override
{
m_sActivated = ::get_buildable_id(GTK_BUILDABLE(pItem));
@@ -10218,13 +10230,20 @@ private:
}
m_aExtraItems.clear();
}
+#endif
public:
+#if !GTK_CHECK_VERSION(4, 0, 0)
GtkInstanceMenu(GtkMenu* pMenu, bool bTakeOwnership)
: MenuHelper(pMenu, bTakeOwnership)
, m_pTopLevelMenuHelper(nullptr)
+#else
+GtkInstanceMenu(GtkPopoverMenu* pMenu, bool /*bTakeOwnership*/)
+: m_pMenu(pMenu)
+#endif
{
g_object_set_data(G_OBJECT(m_pMenu), "g-lo-GtkInstanceMenu", this);
+#if !GTK_CHECK_VERSION(4, 0, 0)
// tdf#122527 if we're welding a submenu of a menu of a MenuButton,
// then find that MenuButton parent so that when adding items to this
// menu we can inform the MenuButton of their addition
@@ -10255,6 +10274,7 @@ public:
void* pData = g_object_get_data(G_OBJECT(pTopLevelMenu),
"g-lo-GtkInstanceMenu");
m_pTopLevelMenuHelper = static_cast(pData);
}
+#endif
}
virtual OString popup_at_rect(weld::Widget* pParent, const
tools::Rectangle ) override
@@ -10264,6 +10284,7 @@ public:
GtkInstanceWidget* pGtkWidget =
dynamic_cast(pParent);
assert(pGtkWidget);
+#if !GTK_CHECK_VERSION(4, 0, 0)
GtkWidget* pWidget = pGtkWidget->getWidget();
gtk_menu_attach_to_widget(m_pMenu, pWidget, nullptr);
@@ -10327,54 +10348,79 @@ public:
g_main_loop_unref(pLoop);
g_signal_handler_disconnect(m_pMenu, nSignalId);
gtk_menu_detach(m_pMenu);
+#endif
return m_sActivated;
}
virtual void set_sensitive(const OString& rIdent, bool bSensitive) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
set_item_sensitive(rIdent, bSensitive);
+#endif
}
virtual bool get_sensitive(const OString& rIdent) const override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
return get_item_sensitive(rIdent);
+#else
+return false;
+#endif
}
virtual void set_active(const OString& rIdent, bool bActive) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
set_item_active(rIdent, bActive);
+#endif
}
virtual bool get_active(const OString& rIdent) const override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
return get_item_active(rIdent);
+#else
+return false;
+#endif
}
virtual void set_visible(const OString& rIdent, bool bShow) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
set_item_visible(rIdent, bShow);
+#endif
}
virtual void set_label(const OString& rIdent, const OUString& rLabel)
override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
set_item_label(rIdent, rLabel);
+#endif
}
virtual OUString get_label(const OString& rIdent) const override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
return get_item_label(rIdent);
+#else
+return OUString();
+#endif
}
virtual void insert_separator(int pos, const OUString& rId) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
MenuHelper::insert_separator(pos, rId);
+#endif
}
virtual void clear() override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
clear_extras();
clear_items();
+#endif
}
virtual void insert(int pos, const OUString& rId, const OUString& rStr,
@@ -10382,6 +10428,7 @@ public:
const css::uno::Reference&
rGraphic,
TriState eCheckRadioFalse) override
{
+#if !GTK_CHECK_VERSION(4, 0, 0)
GtkWidget* pImage = nullptr;
if (pIconName)
{
@@ -10435,27 +10482,37 @@
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk4/convert3to4.cxx | 128 +--
1 file changed, 89 insertions(+), 39 deletions(-)
New commits:
commit 0df9c8c3cd16d6485c4486d9c983715b647e7090
Author: Caolán McNamara
AuthorDate: Fri Jun 11 17:08:05 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jun 11 22:05:19 2021 +0200
gtk4: build deeper levels of GMenuModel
Change-Id: Ia2cbe4fdc583d272152b4eaa9da9f9d2ff4af550
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117066
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk4/convert3to4.cxx b/vcl/unx/gtk4/convert3to4.cxx
index 04f803fc5b61..1a985877d32f 100644
--- a/vcl/unx/gtk4/convert3to4.cxx
+++ b/vcl/unx/gtk4/convert3to4.cxx
@@ -136,9 +136,11 @@ struct MenuEntry
}
};
-MenuEntry ConvertMenu(const css::uno::Reference& xMenu,
+MenuEntry ConvertMenu(const css::uno::Reference&
xOutMenu,
const css::uno::Reference& xNode)
{
+css::uno::Reference xMenu(xOutMenu);
+
bool bDrawAsRadio = false;
css::uno::Reference xPropertyLabel;
@@ -163,6 +165,45 @@ MenuEntry ConvertMenu(const
css::uno::Reference& xMenu,
auto xNextChild = xChild->getNextSibling();
+auto xCurrentMenu = xMenu;
+
+if (xChild->getNodeName() == "object")
+{
+auto xDoc = xChild->getOwnerDocument();
+
+css::uno::Reference xMap =
xChild->getAttributes();
+css::uno::Reference xClass =
xMap->getNamedItem("class");
+OUString sClass(xClass->getNodeValue());
+
+if (sClass == "GtkMenuItem" || sClass == "GtkRadioMenuItem")
+{
+/* */
+css::uno::Reference xItem =
xDoc->createElement("item");
+xMenu->appendChild(xItem);
+}
+else if (sClass == "GtkMenu")
+{
+xMenu->removeChild(xMenu->getLastChild()); // remove preceding
+
+css::uno::Reference xSubMenu
+= xDoc->createElement("submenu");
+css::uno::Reference xIdAttr =
xDoc->createAttribute("id");
+
+css::uno::Reference xId =
xMap->getNamedItem("id");
+OUString sId(xId->getNodeValue());
+
+xIdAttr->setValue(sId);
+xSubMenu->setAttributeNode(xIdAttr);
+xMenu->appendChild(xSubMenu);
+
+css::uno::Reference xSection
+= xDoc->createElement("section");
+xSubMenu->appendChild(xSection);
+
+xMenu = xSubMenu;
+}
+}
+
bool bChildDrawAsRadio = false;
css::uno::Reference xChildPropertyLabel;
if (xChild->hasChildNodes())
@@ -174,6 +215,8 @@ MenuEntry ConvertMenu(const
css::uno::Reference& xMenu,
if (xChild->getNodeName() == "object")
{
+xMenu = xCurrentMenu;
+
auto xDoc = xChild->getOwnerDocument();
css::uno::Reference xMap =
xChild->getAttributes();
@@ -186,14 +229,11 @@ MenuEntry ConvertMenu(const
css::uno::Reference& xMenu,
OUString sId = xId->getNodeValue();
/*
-
whatever
menu.action
id
-
*/
-css::uno::Reference xItem =
xDoc->createElement("item");
-xMenu->appendChild(xItem);
+auto xItem = xMenu->getLastChild();
if (xChildPropertyLabel)
{
@@ -801,6 +841,50 @@ ConvertResult Convert3To4(const
css::uno::Reference& xNode
auto xNextChild = xChild->getNextSibling();
+if (xChild->getNodeName() == "object")
+{
+auto xDoc = xChild->getOwnerDocument();
+
+css::uno::Reference xMap =
xChild->getAttributes();
+css::uno::Reference xClass =
xMap->getNamedItem("class");
+OUString sClass(xClass->getNodeValue());
+
+if (sClass == "GtkMenu")
+{
+css::uno::Reference xId =
xMap->getNamedItem("id");
+OUString sId(xId->getNodeValue() + "-menu-model");
+
+//
+css::uno::Reference xMenu =
xDoc->createElement("menu");
+css::uno::Reference xIdAttr =
xDoc->createAttribute("id");
+xIdAttr->setValue(sId);
+xMenu->setAttributeNode(xIdAttr);
+xChild->getParentNode()->insertBefore(xMenu, xChild);
+
+css::uno::Reference xSection
+= xDoc->createElement("section");
+xMenu->appendChild(xSection);
+
+ConvertMenu(xSection, xChild);
+
+// now remove GtkMenu contents
+while (true)
+{
+auto xFirstChild = xChild->getFirstChild();
+if (!xFirstChild.is())
+
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/metaact.hxx| 108 ++---
vcl/source/gdi/metaact.cxx | 108 ++---
2 files changed, 108 insertions(+), 108 deletions(-)
New commits:
commit 2020fc9c7d2c778e8206dcc891d5a77f92ac951c
Author: Luboš Luňák
AuthorDate: Fri Jun 11 11:02:48 2021 +0200
Commit: Luboš Luňák
CommitDate: Fri Jun 11 22:01:49 2021 +0200
MetaAction::Clone() -> const
Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index ef99f7f82ae1..c37b7ab98aa2 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -79,7 +79,7 @@ public:
oslInterlockedCount GetRefCount() const { return m_nCount; }
-virtual rtl::Reference Clone();
+virtual rtl::Reference Clone() const;
virtual voidMove( tools::Long nHorzMove, tools::Long nVertMove );
virtual voidScale( double fScaleX, double fScaleY );
@@ -116,7 +116,7 @@ private:
virtual ~MetaPixelAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -144,7 +144,7 @@ private:
virtual ~MetaPointAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -174,7 +174,7 @@ private:
virtual ~MetaLineAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -206,7 +206,7 @@ private:
virtual ~MetaRectAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -236,7 +236,7 @@ private:
virtual ~MetaRoundRectAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -267,7 +267,7 @@ private:
virtual ~MetaEllipseAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -297,7 +297,7 @@ private:
virtual ~MetaArcAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -330,7 +330,7 @@ private:
virtual ~MetaPieAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -363,7 +363,7 @@ private:
virtual ~MetaChordAction() override;
public:
virtual voidExecute( OutputDevice* pOut ) override;
-virtual rtl::Reference Clone() override;
+virtual rtl::Reference Clone() const override;
virtual voidWrite( SvStream& rOStm, ImplMetaWriteData* pData )
override;
virtual voidRead( SvStream& rIStm, ImplMetaReadData* pData )
override;
@@ -395,7 +395,7 @@
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 --- Comment #1 from Bogdan Stăncescu --- Created attachment 172826 --> https://bugs.documentfoundation.org/attachment.cgi?id=172826=edit Silly sample (it's just a default rectangle) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142804] New: General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 Bug ID: 142804 Summary: General I/O error when attempting to export soft edge rectangles to SVG Product: LibreOffice Version: 7.0.6.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gut...@moongate.ro Description: Blocking error when attempting to export an ODG as SVG if the drawing contains any rectangles with non-zero setting for Soft Edge. Steps to Reproduce: 1. Create a rectangle shape 2. Increase its Radius property in the Soft Edge section 3. Attempt to export the file as SVG Actual Results: Error message. Expected Results: SVG file exported successfully (good), SVG file exported without rounded rectangles (bad), or error message explaining why the export failed (ugly). Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: DrawingDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142803] Calc 'Print Preview' Toolbar Zoom in/Out icons swapped functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=142803 Julien Nabet changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Julien Nabet --- Fixed on master sources (future 7.2.0) Backport for 7.1 branch waiting for review here: https://gerrit.libreoffice.org/c/core/+/116702 *** This bug has been marked as a duplicate of bug 142513 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142788] LO should fully expose the character style implicit in every paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=142788 --- Comment #12 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #11) > When you have a paragraph style, you have every property defined (not > necessarily set in this style, but completely defined). This is completely > different for character style. That does not contradict what I said. > Trying to unify here I didn't suggest a unification of Character and Paragraph styles. I suggest a distinction between the Character Style aspect of a Paragraph style, and the rest of the Paragraph style properties + the inheritance from the parent style. > See also current GSoC project of making both character and paragraph styles > to show in different lists *on a single sidebar panel* - implementing this > confusing proposal would produce even greater confusion to users. Implementing this proposal would have no immediate effect on the Style pane; only on the UI for setting Character properties of Paragraph styles. But even regardless of this fact: Suggesting to users that a Paragraph style contains an implicit Character style is already the case in MS Word. Have a look at the style sidebar there: https://winfix.net/wp-content/uploads/2020/02/02_clicking_options_on_styles_pane.png The PS icon for some paragraph styles _contains_ the icon for a Character style (an 'a' letter), plus elements alluding at paragraphs (multiple lines and a ¶ pilcrow). IIANM, the distinction between when the Character properties are completely inherited, or whether there really is a "non-empty"/"non-trivial" inherent character style modifying the inherited properties. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142788] LO should fully expose the character style implicit in every paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=142788 --- Comment #12 from Eyal Rozenberg --- (In reply to Mike Kaganski from comment #11) > When you have a paragraph style, you have every property defined (not > necessarily set in this style, but completely defined). This is completely > different for character style. That does not contradict what I said. > Trying to unify here I didn't suggest a unification of Character and Paragraph styles. I suggest a distinction between the Character Style aspect of a Paragraph style, and the rest of the Paragraph style properties + the inheritance from the parent style. > See also current GSoC project of making both character and paragraph styles > to show in different lists *on a single sidebar panel* - implementing this > confusing proposal would produce even greater confusion to users. Implementing this proposal would have no immediate effect on the Style pane; only on the UI for setting Character properties of Paragraph styles. But even regardless of this fact: Suggesting to users that a Paragraph style contains an implicit Character style is already the case in MS Word. Have a look at the style sidebar there: https://winfix.net/wp-content/uploads/2020/02/02_clicking_options_on_styles_pane.png The PS icon for some paragraph styles _contains_ the icon for a Character style (an 'a' letter), plus elements alluding at paragraphs (multiple lines and a ¶ pilcrow). IIANM, the distinction between when the Character properties are completely inherited, or whether there really is a "non-empty"/"non-trivial" inherent character style modifying the inherited properties. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 Bug 103512 depends on bug 142389, which changed state. Bug 142389 Summary: Help for AutoFilter https://bugs.documentfoundation.org/show_bug.cgi?id=142389 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142389] Help for AutoFilter
https://bugs.documentfoundation.org/show_bug.cgi?id=142389 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130744] [META] Screenshot Issues Meta Bug
https://bugs.documentfoundation.org/show_bug.cgi?id=130744 Bug 130744 depends on bug 129505, which changed state. Bug 129505 Summary: Adding "translated" image for impress remote https://bugs.documentfoundation.org/show_bug.cgi?id=129505 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129505] Adding "translated" image for impress remote
https://bugs.documentfoundation.org/show_bug.cgi?id=129505 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - vcl/inc
vcl/inc/jsdialog/jsdialogbuilder.hxx | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
New commits:
commit af9c4818e14391536dddbb462f4ce4d4ee527a7e
Author: Szymon Kłos
AuthorDate: Fri Jun 11 19:59:07 2021 +0200
Commit: Szymon Kłos
CommitDate: Fri Jun 11 20:41:45 2021 +0200
jsdialog: don't send unnecessary show/hide messages
Change-Id: Ie37503b5964606a2b3e5b305c949f570616dc1cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117070
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index cbdd4669cab3..70eb489f42ba 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -313,18 +313,26 @@ public:
virtual void show() override
{
+bool bWasVisible = BaseInstanceClass::get_visible();
BaseInstanceClass::show();
-std::unique_ptr pMap =
std::make_unique();
-(*pMap)[ACTION_TYPE] = "show";
-sendAction(std::move(pMap));
+if (!bWasVisible)
+{
+std::unique_ptr pMap =
std::make_unique();
+(*pMap)[ACTION_TYPE] = "show";
+sendAction(std::move(pMap));
+}
}
virtual void hide() override
{
+bool bWasVisible = BaseInstanceClass::get_visible();
BaseInstanceClass::hide();
-std::unique_ptr pMap =
std::make_unique();
-(*pMap)[ACTION_TYPE] = "hide";
-sendAction(std::move(pMap));
+if (bWasVisible)
+{
+std::unique_ptr pMap =
std::make_unique();
+(*pMap)[ACTION_TYPE] = "hide";
+sendAction(std::move(pMap));
+}
}
using BaseInstanceClass::set_sensitive;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120201 Bug 120201 depends on bug 112685, which changed state. Bug 112685 Summary: HELP: Document Advanced TSCP Classification dialog https://bugs.documentfoundation.org/show_bug.cgi?id=112685 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Bug 80430 depends on bug 112685, which changed state. Bug 112685 Summary: HELP: Document Advanced TSCP Classification dialog https://bugs.documentfoundation.org/show_bug.cgi?id=112685 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112685] HELP: Document Advanced TSCP Classification dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=112685 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/bulletandposition.ui | 676 +++ 1 file changed, 386 insertions(+), 290 deletions(-) New commits: commit b682c8c62b2bd6bd66b22c872a2b65b67892c1fa Author: Olivier Hallot AuthorDate: Fri Jun 11 10:43:41 2021 -0300 Commit: Olivier Hallot CommitDate: Fri Jun 11 20:34:27 2021 +0200 Add extended tips to bulletandposition.ui dialog Change-Id: Ibb6c4013c587cc89b1438c264554d9e356467680 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117060 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/cui/uiconfig/ui/bulletandposition.ui b/cui/uiconfig/ui/bulletandposition.ui index bffad57cc9ad..74a584b2372c 100644 --- a/cui/uiconfig/ui/bulletandposition.ui +++ b/cui/uiconfig/ui/bulletandposition.ui @@ -1,60 +1,60 @@ - + 19.988 -0.050003 -1 +0.05 +1 65535 -1 -10 +1 +10 1 400 -1 -10 +1 +10 19.988 -0.050003 -1 +0.05 +1 -19.988 19.988 -0.050003 -10 +0.05 +10 19.988 -0.050003 -10 +0.05 +10 True -False +False True -False +False From file... -True +True True -False +False Gallery -True +True True -False +False @@ -62,18 +62,18 @@ True -False -cmd/sc_alignleft.png +False +cmd/sc_alignleft.png True -False -cmd/sc_alignhorizontalcenter.png +False +cmd/sc_alignhorizontalcenter.png True -False -cmd/sc_alignright.png +False +cmd/sc_alignright.png @@ -84,31 +84,28 @@ -False -6 +False +6 Bullets and Numbering True -0 -0 -dialog - - - +0 +0 +dialog -False +False vertical 12 -False -end +False +end Reset True -True -True +True +True False @@ -120,10 +117,10 @@ _OK True -True -True -True -True +True +True +True +True True @@ -136,8 +133,8 @@ _Cancel True -True -True +True +True True @@ -150,8 +147,8 @@ _Help True -True -True +True +True True @@ -165,40 +162,40 @@ False True -end +end 0 -490 +490 True -False +False 12 True -False -0 -none +False +0 +none -78 +78 True -True -never -never -in +True 6 +never +never +in True -True +True liststore1 -False -False -0 -False +False +False +0 +False @@ -219,7 +216,7 @@ True -False +False Level @@ -236,156 +233,180 @@ True -False +False vertical 6
[Libreoffice-bugs] [Bug 142733] Crash when deleting text with Outline folding
https://bugs.documentfoundation.org/show_bug.cgi?id=142733 Timur changed: What|Removed |Added CC||rayk...@gmail.com --- Comment #3 from Timur --- Hi Jim. Please see this, crash with Outline. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142803] Calc 'Print Preview' Toolbar Zoom in/Out icons swapped functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=142803 --- Comment #1 from Michal Fajta --- Created attachment 172825 --> https://bugs.documentfoundation.org/attachment.cgi?id=172825=edit Screnshot of toolbar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142803] New: Calc 'Print Preview' Toolbar Zoom in/Out icons swapped functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=142803 Bug ID: 142803 Summary: Calc 'Print Preview' Toolbar Zoom in/Out icons swapped functionality Product: LibreOffice Version: 7.1.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: michal.fa...@gmail.com Description: Toolbar icons Zoom in /Zoom Out are switched. I tried only Libre Calc app 7.1.2-7.1.4. (W10) If i press Zoom in it will make print preview smaller and zoom out will magnify view. :) But maybe I am doing something wrong :D Steps to Reproduce: 1.Open document 2.select Print preview Ctrl+ shift + O 3. Use icons on tool bar (+)/(-) Actual Results: (+) zoom out (-) zoom in Expected Results: (+) Zoom in (-) Zoom Out Reproducible: Always User Profile Reset: No Additional Info: Maybe there is a problem somewhere between chair and a monitor :D Version: 7.1.4.2 (x64) / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142801] Support partial transparency in table cell backgrounds
https://bugs.documentfoundation.org/show_bug.cgi?id=142801 --- Comment #2 from Eyal Rozenberg --- I mean, I expect to have at least a transparency fraction, and at most as much transparency control as in Format | Obect | Area 's transparency pane. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142801] Support partial transparency in table cell backgrounds
https://bugs.documentfoundation.org/show_bug.cgi?id=142801 Eyal Rozenberg changed: What|Removed |Added Summary|Support transparency in |Support partial |table cell backgrounds |transparency in table cell ||backgrounds -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136154] valor de célula duplicado no libre office calc
https://bugs.documentfoundation.org/show_bug.cgi?id=136154 --- Comment #3 from Jorge C --- Tengo una situación que parece similar. Al escribir en la celda B93 el número 7363. En la parte superior en la barra de fórmula, se ve el valor correcto de 7363, pero en la celda se ve 7363736373637363736373637363 y sigue repitiendo 7363 si hago la celda más ancha. Se llena la celda con el número que se capture. Si no tiene número y es texto, se ve correctamente. Si cambio el numero a 1234 se repite el número 123412341234123412341234 En esa y otras celdas de la misma columna se repite el número que escriba. La celda tiene text aligment horizontal: filled y vertical default. Y en Properties activado Wrap text automatically. En otras celdas no sucede eso. Al copiar el formato de otra celda en la que si se ve el 7363 correctamente, se arregla y ya no muestra lo duplicado. En Format Cells, Alignment, al cambiar Text Aligment, Horizontal de Filled a Default se soluciona el problema o bien si copio el formato de otra celda que no tiene ese problema. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source filter/source fpicker/source sfx2/source sot/source svtools/source
dbaccess/source/core/dataaccess/datasource.cxx |4 +---
filter/source/t602/t602filter.cxx | 12 +++-
fpicker/source/win32/VistaFilePicker.cxx |4 +---
sfx2/source/appl/appopen.cxx |5 +
sfx2/source/doc/sfxbasemodel.cxx |4 +---
sot/source/sdstor/ucbstorage.cxx |6 +-
svtools/source/config/extcolorcfg.cxx |4 +---
7 files changed, 13 insertions(+), 26 deletions(-)
New commits:
commit c384c7d7ae39495a9cfd55c3d610133f97db1304
Author: Julien Nabet
AuthorDate: Fri Jun 11 16:02:26 2021 +0200
Commit: Julien Nabet
CommitDate: Fri Jun 11 18:55:00 2021 +0200
Simplify Sequence/vector initializations
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/dbaccess/source/core/dataaccess/datasource.cxx
b/dbaccess/source/core/dataaccess/datasource.cxx
index 9ce895bae875..83a45afa3e2d 100644
--- a/dbaccess/source/core/dataaccess/datasource.cxx
+++ b/dbaccess/source/core/dataaccess/datasource.cxx
@@ -240,10 +240,8 @@ void SAL_CALL OAuthenticationContinuation::setAccount(
const OUString& )
Sequence< RememberAuthentication > SAL_CALL
OAuthenticationContinuation::getRememberAccountModes( RememberAuthentication&
_reDefault )
{
-Sequence < RememberAuthentication > aReturn(1);
-aReturn[0] = RememberAuthentication_NO;
_reDefault = RememberAuthentication_NO;
-return aReturn;
+return { RememberAuthentication_NO };
}
void SAL_CALL OAuthenticationContinuation::setRememberAccount(
RememberAuthentication /*Remember*/ )
diff --git a/filter/source/t602/t602filter.cxx
b/filter/source/t602/t602filter.cxx
index 9f96f18c1a96..f71d1c681af6 100644
--- a/filter/source/t602/t602filter.cxx
+++ b/filter/source/t602/t602filter.cxx
@@ -950,11 +950,13 @@ bool T602ImportFilterDialog::OptionsDlg()
propBool_(xPSetCodeLB,"Dropdown",true);
propBool_(xPSetCodeLB,"MultiSelection",false);
-Sequence< OUString > ous(4);
-ous[0] = getResStr(T602FILTER_STR_ENCODING_AUTO);
-ous[1] = getResStr(T602FILTER_STR_ENCODING_CP852);
-ous[2] = getResStr(T602FILTER_STR_ENCODING_CP895);
-ous[3] = getResStr(T602FILTER_STR_ENCODING_KOI8CS2);
+Sequence< OUString > ous
+{
+getResStr(T602FILTER_STR_ENCODING_AUTO),
+getResStr(T602FILTER_STR_ENCODING_CP852),
+getResStr(T602FILTER_STR_ENCODING_CP895),
+getResStr(T602FILTER_STR_ENCODING_KOI8CS2)
+};
any <<= ous;
xPSetCodeLB->setPropertyValue("StringItemList", any);
diff --git a/fpicker/source/win32/VistaFilePicker.cxx
b/fpicker/source/win32/VistaFilePicker.cxx
index 367f938dd3a6..0c360f1bc33d 100644
--- a/fpicker/source/win32/VistaFilePicker.cxx
+++ b/fpicker/source/win32/VistaFilePicker.cxx
@@ -210,9 +210,7 @@ void VistaFilePicker::ensureInit()
}
else
{
-css::uno::Sequence < css::uno::Any > aInitArguments(1);
-aInitArguments[0] <<=
css::ui::dialogs::TemplateDescription::FILEOPEN_SIMPLE;
-initialize(aInitArguments);
+initialize( {
css::uno::Any(css::ui::dialogs::TemplateDescription::FILEOPEN_SIMPLE) });
}
}
}
diff --git a/sfx2/source/appl/appopen.cxx b/sfx2/source/appl/appopen.cxx
index 03a94e0811b1..08431c29eaaa 100644
--- a/sfx2/source/appl/appopen.cxx
+++ b/sfx2/source/appl/appopen.cxx
@@ -866,11 +866,8 @@ void SfxApplication::OpenDocExec_Impl( SfxRequest& rReq )
else
{
// check for "internal" protocols that should not be
forwarded to the system
-std::vector < OUString > aProtocols(2);
-
// add special protocols that always should be treated as
internal
-aProtocols[0] = "private:*";
-aProtocols[1] = "vnd.sun.star.*";
+std::vector < OUString > aProtocols { "private:*",
"vnd.sun.star.*" };
// get registered protocol handlers from configuration
Reference < XNameAccess >
xAccess(officecfg::Office::ProtocolHandler::HandlerSet::get());
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 35e4bd106635..c95c068463cd 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3876,9 +3876,7 @@ void SfxBaseModel::impl_getPrintHelper()
return;
m_pData->m_xPrintable = new SfxPrintHelper();
Reference < lang::XInitialization > xInit( m_pData->m_xPrintable,
UNO_QUERY );
-Sequence < Any > aValues(1);
-aValues[0] <<= Reference < frame::XModel > (static_cast< frame::XModel*
>(this), UNO_QUERY );
-xInit->initialize( aValues );
+xInit->initialize( { Any(Reference < frame::XModel > (static_cast<
frame::XModel* >(this), UNO_QUERY )) } );
Reference <
[Libreoffice-bugs] [Bug 133619] [META] Regressions from increasing column limit in Calc (mainly bug 50916)
https://bugs.documentfoundation.org/show_bug.cgi?id=133619 Bug 133619 depends on bug 128895, which changed state. Bug 128895 Summary: Hidden Columns but keep reappearing! Unlike Rows which will stay hidden https://bugs.documentfoundation.org/show_bug.cgi?id=128895 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128895] Hidden Columns but keep reappearing! Unlike Rows which will stay hidden
https://bugs.documentfoundation.org/show_bug.cgi?id=128895 Timur changed: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- --- Comment #21 from Timur --- Miguel, you need to repro with some version to say WFM of bio repro with current. I did repro with 7.2+ so I set New again. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65509] FILESAVE "Automatically save" (Found in Options > LO > Advanced > Expert Configuration ) not running
https://bugs.documentfoundation.org/show_bug.cgi?id=65509 --- Comment #39 from Aron Budea --- (In reply to Dieter from comment #38) > Can't find that option. I've searched in expert configuration and with > enabling experimental features. It should be there as shown in attachment 119311. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/emfreader.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 8d3e7b2f5836106eac5172d8f4868bb540d652e6 Author: Bartosz Kosiorek AuthorDate: Fri Jun 11 13:50:29 2021 +0200 Commit: Bartosz Kosiorek CommitDate: Fri Jun 11 18:41:02 2021 +0200 EMF tdf#59814 tdf#142567 Align RestoreDC record with MSO implementation Some of WMF and EMF behaviours are undocumented. In that case, we are implementing the behaviour, observed in MS Office or MS Paint. With this commit the behaviour of import EMF RestoreDC records, will be the same as for MS Paint and MS Office. Change-Id: I73b65d14018f2667ffd59daf16ecc6d7ce9c1870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117052 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek diff --git a/emfio/source/reader/emfreader.cxx b/emfio/source/reader/emfreader.cxx index ac56c64db026..04f591a7eb9a 100644 --- a/emfio/source/reader/emfreader.cxx +++ b/emfio/source/reader/emfreader.cxx @@ -1101,8 +1101,10 @@ namespace emfio sal_Int32 nSavedDC; mpInputStream->ReadInt32( nSavedDC ); SAL_INFO( "emfio", "\t\t SavedDC Index: " << nSavedDC ); -if ( nSavedDC < 0 ) // For EMF values above -1 is ignored +if ( nSavedDC < 0 ) Pop( nSavedDC ); +else +Pop( -1 ); // For RestoreDC values above -1, treat as get last element } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130693] PRINTING: font or style selectively changed from Writer in PDF printout
https://bugs.documentfoundation.org/show_bug.cgi?id=130693 --- Comment #29 from Tom --- Just following up on my request for advice as to where else I should report this. Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
