[Libreoffice-bugs] [Bug 118059] new entries in the toolbar appear without the icon just the name
https://bugs.documentfoundation.org/show_bug.cgi?id=118059 Buovjaga changed: What|Removed |Added URL|https://www.onlinemastersco | |lleges.com/one-year-masters | |-programs-online| Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source include/unotools include/vcl sfx2/source vcl/backendtest vcl/inc vcl/Library_vcl.mk
desktop/source/app/app.cxx | 15
include/unotools/VersionConfig.hxx | 45 +
include/vcl/test/GraphicsRenderTests.hxx | 92 +++
include/vcl/test/TestResult.hxx | 26
sfx2/source/view/viewfrm.cxx | 12
vcl/Library_vcl.mk |1
vcl/backendtest/GraphicsRenderTests.cxx | 914 +++
vcl/inc/test/outputdevice.hxx| 13
8 files changed, 1096 insertions(+), 22 deletions(-)
New commits:
commit 07e269f2596756bf841bbc380929bcffc3ca6bc6
Author: homeboy445
AuthorDate: Mon Jun 7 15:52:34 2021 +0530
Commit: Tomaž Vajngerl
CommitDate: Fri Jun 18 07:22:49 2021 +0200
VCL graphics rendering tests that a run on LO version change
This commit includes the implementation of graphics rendering tests
which would be automatically triggered at first installation or upgrades
of LibreOffice.
These tests check the graphic rendering interface of LibreOffice
by drawing and checking various graphical rendering tools (eg:. by
drawing lines, polygons etc.). After the successful completion of
tests, their results are stored in the user folder for future
reference.
Change-Id: I59c94b57a1f3f3a9cba55af1067a9702b6da98d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116779
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index b0c4fac53e10..42a687b69088 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -99,8 +99,10 @@
#include
#include
#include
+#include
#include
#include
+#include
#include
#include
#include
@@ -336,6 +338,16 @@ void RemoveIconCacheDirectory()
namespace {
+void runGraphicsRenderTests()
+{
+if (!utl::isProductVersionUpgraded(false))
+{
+return;
+}
+GraphicsRenderTests TestObject;
+TestObject.run();
+}
+
OUString MakeStartupErrorMessage(std::u16string_view aErrorMessage)
{
@@ -1550,6 +1562,9 @@ int Desktop::Main()
CheckOpenCLCompute(xDesktop);
#endif
+//Running the VCL graphics rendering tests
+runGraphicsRenderTests();
+
// Reap the process started by fire_glxtest_process().
reap_glxtest_process();
diff --git a/include/unotools/VersionConfig.hxx
b/include/unotools/VersionConfig.hxx
new file mode 100644
index ..60b3a36c51e0
--- /dev/null
+++ b/include/unotools/VersionConfig.hxx
@@ -0,0 +1,45 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+#pragma once
+
+#include
+#include
+#include
+
+namespace utl
+{
+/** This method is called when there's a need to determine if the
+ * current version of LibreOffice has been upgraded to a newer one.
+
+@param aUpdateVersion This variable is used to determine if
+LibreOffice's previous version should be updated.
+ */
+static bool isProductVersionUpgraded(bool aUpdateVersion)
+{
+OUString sSetupVersion = utl::ConfigManager::getProductVersion();
+sal_Int32 iCurrent
+= sSetupVersion.getToken(0, '.').toInt32() * 10 +
sSetupVersion.getToken(1, '.').toInt32();
+OUString sLastVersion =
officecfg::Setup::Product::ooSetupLastVersion::get().value_or("0.0");
+sal_Int32 iLast
+= sLastVersion.getToken(0, '.').toInt32() * 10 +
sLastVersion.getToken(1, '.').toInt32();
+if (iCurrent > iLast)
+{
+if (aUpdateVersion)
+{ //update lastversion
+std::shared_ptr batch(
+comphelper::ConfigurationChanges::create());
+officecfg::Setup::Product::ooSetupLastVersion::set(sSetupVersion,
batch);
+batch->commit();
+}
+return true;
+}
+return false;
+}
+}
diff --git a/include/vcl/test/GraphicsRenderTests.hxx
b/include/vcl/test/GraphicsRenderTests.hxx
new file mode 100644
index ..9ff5b7c33d90
--- /dev/null
+++ b/include/vcl/test/GraphicsRenderTests.hxx
@@ -0,0 +1,92 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+class VCL_PLUGIN_PUBLIC GraphicsRenderTests
+{
+//For storing the results correspondingly to the tests.
+std::vector m_aPassed;
+std::vector m_aQuirky;
+std::vector m_aFailed;
+//For storing Skipped tests.
+std::vector m_aSkipped;
[Libreoffice-bugs] [Bug 118059] new entries in the toolbar appear without the icon just the name
https://bugs.documentfoundation.org/show_bug.cgi?id=118059 John Lee changed: What|Removed |Added URL||https://www.onlinemastersco ||lleges.com/one-year-masters ||-programs-online -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/math.cxx | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
New commits:
commit 3fc41a91ce3bd9d6756905809e261499a51d9774
Author: Mike Kaganski
AuthorDate: Thu Jun 17 22:49:30 2021 +0200
Commit: Mike Kaganski
CommitDate: Fri Jun 18 06:24:33 2021 +0200
Use std::fesetround / std::nearbyint for half-to-even rounding
C++ floating-point environment has thread storage duration, so
std::fesetround call is thread-safe.
std::nearbyint uses half-to-even rounding with FE_TONEAREST,
as specified in ISO/IEC 9899:1999 F.3, and in Appendix to
ANSI/IEEE 854.
Change-Id: I26995842c30e2663b40af5b5314791c1328037d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117307
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 698e158df072..7db362f35cfe 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -33,6 +33,8 @@
#include
#include
+#include
+#include
#include
#include
#include
@@ -1137,8 +1139,24 @@ double SAL_CALL rtl_math_round(double fValue, int
nDecPlaces,
if (fValue == 0.0)
return fValue;
-if ( nDecPlaces == 0 && eMode == rtl_math_RoundingMode_Corrected )
-return std::round( fValue );
+if (nDecPlaces == 0)
+{
+switch (eMode)
+{
+case rtl_math_RoundingMode_Corrected:
+return std::round(fValue);
+case rtl_math_RoundingMode_HalfEven:
+if (const int oldMode = std::fegetround();
std::fesetround(FE_TONEAREST) == 0)
+{
+fValue = std::nearbyint(fValue);
+std::fesetround(oldMode);
+return fValue;
+}
+break;
+default:
+break;
+}
+}
const double fOrigValue = fValue;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142926] On F1 / Help failure - No resolution path is identified for resolving errormesssage
https://bugs.documentfoundation.org/show_bug.cgi?id=142926 Paul Norman NZ changed: What|Removed |Added CC||p...@paulanorman.info Keywords||difficultyMedium, ||needsDevEval, skillHIG, ||skillUI, topicDoc, topicUI, ||topicWeb -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142926] New: On F1 / Help failure - No resolution path is identified for resolving errormesssage
https://bugs.documentfoundation.org/show_bug.cgi?id=142926 Bug ID: 142926 Summary: On F1 / Help failure - No resolution path is identified for resolving errormesssage Product: LibreOffice Version: 7.1.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@paulanorman.info Created attachment 172994 --> https://bugs.documentfoundation.org/attachment.cgi?id=172994=edit Web page gives no obvius hint of how to resolve missing help files error message In Writer (and presumably elsewhere) when the User taps the F1 key, or uses the Menu item: Help >> LibreOffice Help F1, desiring (or necessitating) to use a local version of Help, and where for whatever reason the necessary files are not yet locally available, A dialogue box then appears which states.. ``The LibreOffice built-in help for current UI language <<(English (UK))>> is not installed on your computer. ``You may either install it from our website or your system’s repositories, or read an online version. However even electing to use the online help, does not present any obvious option for resolving the obtaining the offline files. Neither the presented error alert message-box nor the Website offers any solution on how to resolve the missing help files. Recommend that :— Either: the dialogue option: "Read Online Help" lead to both that, and a top option on that web page linking to, or explaining where to, obtain and how to install the offline files. Or: A third option button be added which facilitates the installation of the offline help files with available language selection options if necessary. Whatever: That the User not be left hanging without knowledge of how to resolve the problem (seems very <> in nature otherwise :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142605] FILESAVE DOCX Writer curved lines resize incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=142605 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142633] UI: Disabled Textfield flickers
https://bugs.documentfoundation.org/show_bug.cgi?id=142633 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142634] Animation-Object gets unselected upon change.
https://bugs.documentfoundation.org/show_bug.cgi?id=142634 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142910] Standard filters involving "greater than" or "smaller than" (>, <, >=, <=) fail and hide everything
https://bugs.documentfoundation.org/show_bug.cgi?id=142910 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142628] Wrong Icons for "Field", "Field by type" and "Recency" in Navigator's Navigate By Drop Down Menu
https://bugs.documentfoundation.org/show_bug.cgi?id=142628 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142632] Textinput in sidebar doesn't work.
https://bugs.documentfoundation.org/show_bug.cgi?id=142632 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142631] Poor contrast on spellcheck in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142631 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142885] FILESAVE: Cursor jumps to beginning of "File name" field in "Save As" dialog box after selecting text with mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=142885 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142885] FILESAVE: Cursor jumps to beginning of "File name" field in "Save As" dialog box after selecting text with mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=142885 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132511] copy unreliable in Office post install with ubuntu 20.04LTS
https://bugs.documentfoundation.org/show_bug.cgi?id=132511 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132511] copy unreliable in Office post install with ubuntu 20.04LTS
https://bugs.documentfoundation.org/show_bug.cgi?id=132511 --- Comment #24 from QA Administrators --- Dear alignedtraining, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113731] [META] Highlight bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113731 Bug 113731 depends on bug 132363, which changed state. Bug 132363 Summary: font descenders are clipped when highlighting text, but not with a fill https://bugs.documentfoundation.org/show_bug.cgi?id=132363 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132363] font descenders are clipped when highlighting text, but not with a fill
https://bugs.documentfoundation.org/show_bug.cgi?id=132363 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132363] font descenders are clipped when highlighting text, but not with a fill
https://bugs.documentfoundation.org/show_bug.cgi?id=132363 --- Comment #9 from QA Administrators --- Dear Patrick B., Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113117 Bug 113117 depends on bug 125599, which changed state. Bug 125599 Summary: Installing most recent version ended up removing the program and reported an error that installation couldn't complete this is under Windows 7 professional 64k https://bugs.documentfoundation.org/show_bug.cgi?id=125599 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125599] Installing most recent version ended up removing the program and reported an error that installation couldn't complete this is under Windows 7 professional 64k
https://bugs.documentfoundation.org/show_bug.cgi?id=125599 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125599] Installing most recent version ended up removing the program and reported an error that installation couldn't complete this is under Windows 7 professional 64k
https://bugs.documentfoundation.org/show_bug.cgi?id=125599 --- Comment #5 from QA Administrators --- Dear Alastair McIntyre, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125399] Can't open file from an MTP device, such as a phone
https://bugs.documentfoundation.org/show_bug.cgi?id=125399 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125399] Can't open file from an MTP device, such as a phone
https://bugs.documentfoundation.org/show_bug.cgi?id=125399 --- Comment #9 from QA Administrators --- Dear Bill Dietrich, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139053] lODEv 7.2 crashes when opening am ods created by Office365
https://bugs.documentfoundation.org/show_bug.cgi?id=139053 --- Comment #5 from QA Administrators --- Dear Elmar, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139015] Pivot table refresh does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=139015 --- Comment #4 from QA Administrators --- Dear Stephen Zvacek, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133063] Libre keeps the copy. Even if we copy a new one.
https://bugs.documentfoundation.org/show_bug.cgi?id=133063 --- Comment #12 from QA Administrators --- Dear MARINA-SODA, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97982] DejaVu, Liberation, Linux, PT, Source Code fonts damaged after an upgrade (ttf already in use?)
https://bugs.documentfoundation.org/show_bug.cgi?id=97982 --- Comment #16 from QA Administrators --- Dear Timur, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86584] Chart is hidden, if data separated by split/freeze limit of the window
https://bugs.documentfoundation.org/show_bug.cgi?id=86584 --- Comment #10 from QA Administrators --- Dear Laurent BP, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60313] Opening files with tables makes progressbar loop from 0% to 100% many times
https://bugs.documentfoundation.org/show_bug.cgi?id=60313 --- Comment #14 from QA Administrators --- Dear Ruslan Kabatsayev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46626] UI: Navigator: heading with footnote displays footnote number full size
https://bugs.documentfoundation.org/show_bug.cgi?id=46626 --- Comment #13 from QA Administrators --- Dear clemty, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49328] EDITING: Relations form-subform, suggested when editing forms, won't work right
https://bugs.documentfoundation.org/show_bug.cgi?id=49328 --- Comment #20 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125884] FILEOPEN: DOCX WordArt "Transform" (Fontwork, TextWarp) is not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=125884 --- Comment #2 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123879] Nested Queries fail using mariadb JDBC connector (libmariadb-java) and mariadb server
https://bugs.documentfoundation.org/show_bug.cgi?id=123879 --- Comment #31 from QA Administrators --- Dear tim, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119221] FILESAVE: Fill and outline of Fontwork characters are badly exported from Impress and Calc to MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=119221 --- Comment #5 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117436] Export to Calc: Line break isn't exported through copy and paste from Base to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=117436 --- Comment #19 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107702] Metadata lost when compressing images
https://bugs.documentfoundation.org/show_bug.cgi?id=107702 --- Comment #5 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99191] [Feature request] Ability to print with spell checker underlining
https://bugs.documentfoundation.org/show_bug.cgi?id=99191 --- Comment #2 from Shantanu --- You can write a macro as explained on this page... https://stackoverflow.com/questions/67947672/can-you-print-the-wavy-lines-generated-by-spell-check-in-writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Aron Budea changed: What|Removed |Added Depends on||142925 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142925 [Bug 142925] Comment popup menu button's arrowhead is larger (and uglier) than before -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142925] New: Comment popup menu button's arrowhead is larger (and uglier) than before
https://bugs.documentfoundation.org/show_bug.cgi?id=142925 Bug ID: 142925 Summary: Comment popup menu button's arrowhead is larger (and uglier) than before Product: LibreOffice Version: 7.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, needsUXEval, regression Severity: trivial Priority: low Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: caol...@redhat.com, libreoffice-ux-adv...@lists.freedesktop.org Blocks: 106179 Created attachment 172993 --> https://bugs.documentfoundation.org/attachment.cgi?id=172993=edit Screenshot This is a regression from the following two commit. Caolán, I'm not sure about the intention, was the default size supposed to change, or only that the size should be affected by zooming in/out? Personally I preferred the older default size, but perhaps others think differently (added the UX team for input). https://cgit.freedesktop.org/libreoffice/core/commit/?id=d3765ec240eca85a72c6940a5e19bb82d65cad03 author Caolán McNamara 2021-02-19 10:52:49 + committer Caolán McNamara 2021-02-19 15:55:33 +0100 Related: tdf#140409 scale the menubutton like the other widgets Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142925] New: Comment popup menu button's arrowhead is larger (and uglier) than before
https://bugs.documentfoundation.org/show_bug.cgi?id=142925 Bug ID: 142925 Summary: Comment popup menu button's arrowhead is larger (and uglier) than before Product: LibreOffice Version: 7.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, needsUXEval, regression Severity: trivial Priority: low Component: Writer Assignee: libreoffice-b...@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: caol...@redhat.com, libreoffice-ux-advise@lists.freedesktop.org Blocks: 106179 Created attachment 172993 --> https://bugs.documentfoundation.org/attachment.cgi?id=172993=edit Screenshot This is a regression from the following two commit. Caolán, I'm not sure about the intention, was the default size supposed to change, or only that the size should be affected by zooming in/out? Personally I preferred the older default size, but perhaps others think differently (added the UX team for input). https://cgit.freedesktop.org/libreoffice/core/commit/?id=d3765ec240eca85a72c6940a5e19bb82d65cad03 author Caolán McNamara 2021-02-19 10:52:49 + committer Caolán McNamara 2021-02-19 15:55:33 +0100 Related: tdf#140409 scale the menubutton like the other widgets Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142605] FILESAVE DOCX Writer curved lines resize incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=142605 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- MS Office includes the control points in the size, whereas size in LibreOffice is the bounding box without considering the control points. The problem is not only in Word but in PowerPoint the same. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dc7bc263d05f74cd0e73ed99e71809bbfc75 Author: Olivier Hallot AuthorDate: Thu Jun 17 21:05:46 2021 -0300 Commit: Gerrit Code Review CommitDate: Fri Jun 18 02:05:46 2021 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-1' to 0ef840bfd6928f312b3ece83c5a8bbd225767646 - Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 0849d16f3b86339a8906c496f89db64d2995fa6f) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117311 diff --git a/helpcontent2 b/helpcontent2 index 2d3110210c94..0ef840bfd692 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2d3110210c9481b9978cfac3bbe1f036822f8bcc +Subproject commit 0ef840bfd6928f312b3ece83c5a8bbd225767646 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-7-1' - source/text
source/text/swriter/01/04090200.xhp | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) New commits: commit 0ef840bfd6928f312b3ece83c5a8bbd225767646 Author: Olivier Hallot AuthorDate: Thu Jun 17 20:15:48 2021 -0300 Commit: Adolfo Jayme Barrientos CommitDate: Fri Jun 18 02:05:46 2021 +0200 Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos (cherry picked from commit 0849d16f3b86339a8906c496f89db64d2995fa6f) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117311 diff --git a/source/text/swriter/01/04090200.xhp b/source/text/swriter/01/04090200.xhp index c5b2343b9..8ff2a5a16 100644 --- a/source/text/swriter/01/04090200.xhp +++ b/source/text/swriter/01/04090200.xhp @@ -37,8 +37,8 @@ databases;in conditions hiding; database fields -Defining Conditions - +Defining Conditions + Conditions are logical expressions that you can use to control the display of fields and sections in your document. Although the following examples apply to fields, they also apply to sections. You can define conditions for the following field types: @@ -75,7 +75,7 @@ - If you leave the Condition box empty, the condition is interpreted as not being met. + If you leave the Condition box empty, the condition is interpreted as not being met. When you define a condition, use the same elements for defining a formula, namely comparative operators, mathematical and statistical functions, number formats, variables and constants. You can use the following types of variables when you define a condition: @@ -93,7 +93,7 @@ You cannot use internal variables, such as page and chapter numbers, in condition expression. - Conditions and Variables + Conditions and Variables The following examples use a variable called "x": @@ -144,8 +144,8 @@ - The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. - User Data + The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. + User Data You can include user data when you define conditions. To change your user data, choose %PRODUCTNAME - PreferencesTools - Options - $[officename] - User data. User data must be entered in the form of strings. You can query the user data with "==" (EQ), "!=" (NEQ), or "!"(NOT). The following table lists user data variables and their meanings: @@ -159,7 +159,7 @@ - user_firstname + user_firstname First name @@ -167,7 +167,7 @@ - user_lastname + user_lastname Last name @@ -175,7 +175,7 @@ - user_initials + user_initials Initials @@ -183,7 +183,7 @@ - user_company + user_company Company @@ -191,7 +191,7 @@ - user_street + user_street Street @@ -199,7 +199,7 @@ - user_country + user_country Country @@ -207,7 +207,7 @@ - user_zipcode + user_zipcode Zip code @@ -215,7 +215,7 @@ - user_city + user_city City @@ -223,7 +223,7 @@ - user_title + user_title Title @@ -231,7 +231,7 @@ - user_position + user_position Position @@ -239,7 +239,7 @@ - user_tel_work + user_tel_work Business telephone number @@ -247,7 +247,7 @@ - user_tel_home + user_tel_home Home telephone
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 526ff0d1d68164856d0dd6748ea4ddf25923f04e Author: Olivier Hallot AuthorDate: Thu Jun 17 21:03:16 2021 -0300 Commit: Gerrit Code Review CommitDate: Fri Jun 18 02:03:16 2021 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-2' to 0849d16f3b86339a8906c496f89db64d2995fa6f - Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index a1dd86cc..0849d16f3b86 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a1dd86cc9af0e247918660831c73fb0597fc +Subproject commit 0849d16f3b86339a8906c496f89db64d2995fa6f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-7-2' - source/text
source/text/swriter/01/04090200.xhp | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) New commits: commit 0849d16f3b86339a8906c496f89db64d2995fa6f Author: Olivier Hallot AuthorDate: Thu Jun 17 20:15:48 2021 -0300 Commit: Adolfo Jayme Barrientos CommitDate: Fri Jun 18 02:03:16 2021 +0200 Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/swriter/01/04090200.xhp b/source/text/swriter/01/04090200.xhp index c5b2343b9..8ff2a5a16 100644 --- a/source/text/swriter/01/04090200.xhp +++ b/source/text/swriter/01/04090200.xhp @@ -37,8 +37,8 @@ databases;in conditions hiding; database fields -Defining Conditions - +Defining Conditions + Conditions are logical expressions that you can use to control the display of fields and sections in your document. Although the following examples apply to fields, they also apply to sections. You can define conditions for the following field types: @@ -75,7 +75,7 @@ - If you leave the Condition box empty, the condition is interpreted as not being met. + If you leave the Condition box empty, the condition is interpreted as not being met. When you define a condition, use the same elements for defining a formula, namely comparative operators, mathematical and statistical functions, number formats, variables and constants. You can use the following types of variables when you define a condition: @@ -93,7 +93,7 @@ You cannot use internal variables, such as page and chapter numbers, in condition expression. - Conditions and Variables + Conditions and Variables The following examples use a variable called "x": @@ -144,8 +144,8 @@ - The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. - User Data + The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. + User Data You can include user data when you define conditions. To change your user data, choose %PRODUCTNAME - PreferencesTools - Options - $[officename] - User data. User data must be entered in the form of strings. You can query the user data with "==" (EQ), "!=" (NEQ), or "!"(NOT). The following table lists user data variables and their meanings: @@ -159,7 +159,7 @@ - user_firstname + user_firstname First name @@ -167,7 +167,7 @@ - user_lastname + user_lastname Last name @@ -175,7 +175,7 @@ - user_initials + user_initials Initials @@ -183,7 +183,7 @@ - user_company + user_company Company @@ -191,7 +191,7 @@ - user_street + user_street Street @@ -199,7 +199,7 @@ - user_country + user_country Country @@ -207,7 +207,7 @@ - user_zipcode + user_zipcode Zip code @@ -215,7 +215,7 @@ - user_city + user_city City @@ -223,7 +223,7 @@ - user_title + user_title Title @@ -231,7 +231,7 @@ - user_position + user_position Position @@ -239,7 +239,7 @@ - user_tel_work + user_tel_work Business telephone number @@ -247,7 +247,7 @@ - user_tel_home + user_tel_home Home telephone number @@ -255,7 +255,7 @@ - user_fax + user_fax
[Libreoffice-bugs] [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Aron Budea changed: What|Removed |Added Depends on||142922 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142922 [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 Aron Budea changed: What|Removed |Added Blocks||108908 CC||ba...@caesar.elte.hu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108908 [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136327] [META] XLSX shape related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136327 Regina Henschel changed: What|Removed |Added Depends on||142914 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142914 [Bug 142914] FILE SAVE(xlsx): The Shape line display is incorrect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142914] FILE SAVE(xlsx): The Shape line display is incorrect.
https://bugs.documentfoundation.org/show_bug.cgi?id=142914 Regina Henschel changed: What|Removed |Added Blocks||136327 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136327 [Bug 136327] [META] XLSX shape related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142881] FILESAVE XLSX Some rotated shapes are vertically flipped
https://bugs.documentfoundation.org/show_bug.cgi?id=142881 --- Comment #10 from Regina Henschel --- This should be fixed together with bug 142914, because the same code part is affected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142881] FILESAVE XLSX Some rotated shapes are vertically flipped
https://bugs.documentfoundation.org/show_bug.cgi?id=142881 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2914 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142914] FILE SAVE(xlsx): The Shape line display is incorrect.
https://bugs.documentfoundation.org/show_bug.cgi?id=142914 Regina Henschel changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2881 CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- I can reproduce the problem. The error is in XclObjAny::WriteFromTo() The left, green line has a rotation angle of -9000 and therefore skips the part "swap(width,height)". The right, red line has a rotation angle of 9000 and therefore performs the swap. The error is not only with exactly horizontal or vertical lines. It is necessary to check whether lines must generally be excluded from the "swap" part. This should be fixed together with bug 142881, because the same code part is affected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a78510ab673dd0d827efeb00873d5d9137813be7 Author: Olivier Hallot AuthorDate: Thu Jun 17 20:19:09 2021 -0300 Commit: Gerrit Code Review CommitDate: Fri Jun 18 01:19:09 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to f46ebea0276ae94bc299cb4c2bbf4a5b3d69173b - Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117403 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 21d0197b3705..f46ebea0276a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 21d0197b3705212a22b9e221ac1f624049516d9a +Subproject commit f46ebea0276ae94bc299cb4c2bbf4a5b3d69173b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/04090200.xhp | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) New commits: commit f46ebea0276ae94bc299cb4c2bbf4a5b3d69173b Author: Olivier Hallot AuthorDate: Thu Jun 17 20:15:48 2021 -0300 Commit: Olivier Hallot CommitDate: Fri Jun 18 01:19:09 2021 +0200 Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117403 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/01/04090200.xhp b/source/text/swriter/01/04090200.xhp index c5b2343b9..8ff2a5a16 100644 --- a/source/text/swriter/01/04090200.xhp +++ b/source/text/swriter/01/04090200.xhp @@ -37,8 +37,8 @@ databases;in conditions hiding; database fields -Defining Conditions - +Defining Conditions + Conditions are logical expressions that you can use to control the display of fields and sections in your document. Although the following examples apply to fields, they also apply to sections. You can define conditions for the following field types: @@ -75,7 +75,7 @@ - If you leave the Condition box empty, the condition is interpreted as not being met. + If you leave the Condition box empty, the condition is interpreted as not being met. When you define a condition, use the same elements for defining a formula, namely comparative operators, mathematical and statistical functions, number formats, variables and constants. You can use the following types of variables when you define a condition: @@ -93,7 +93,7 @@ You cannot use internal variables, such as page and chapter numbers, in condition expression. - Conditions and Variables + Conditions and Variables The following examples use a variable called "x": @@ -144,8 +144,8 @@ - The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. - User Data + The "equal" comparative operator must be represented by two equal signs (==) in a condition. For example, if you define a variable "x" with the value of 1, you can enter the condition as x==1. + User Data You can include user data when you define conditions. To change your user data, choose %PRODUCTNAME - PreferencesTools - Options - $[officename] - User data. User data must be entered in the form of strings. You can query the user data with "==" (EQ), "!=" (NEQ), or "!"(NOT). The following table lists user data variables and their meanings: @@ -159,7 +159,7 @@ - user_firstname + user_firstname First name @@ -167,7 +167,7 @@ - user_lastname + user_lastname Last name @@ -175,7 +175,7 @@ - user_initials + user_initials Initials @@ -183,7 +183,7 @@ - user_company + user_company Company @@ -191,7 +191,7 @@ - user_street + user_street Street @@ -199,7 +199,7 @@ - user_country + user_country Country @@ -207,7 +207,7 @@ - user_zipcode + user_zipcode Zip code @@ -215,7 +215,7 @@ - user_city + user_city City @@ -223,7 +223,7 @@ - user_title + user_title Title @@ -231,7 +231,7 @@ - user_position + user_position Position @@ -239,7 +239,7 @@ - user_tel_work + user_tel_work Business telephone number @@ -247,7 +247,7 @@ - user_tel_home + user_tel_home Home telephone number @@ -255,7 +255,7 @@ - user_fax + user_fax
[Libreoffice-bugs] [Bug 142827] Want character width scale button+mini-dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=142827 --- Comment #10 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #9) Well, width scaling characters is more frequent than you might expect... when you play with the font-family, you sometimes want to play with the width as well. > So provided we can scale in percentage (@Regina?), let's do it. Can you explain this last question? I mean, the dialog scaling control shows a percentage; I suggest exposing the same thing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[SOLVED] Re: Build fails on Linux in include/basegfx/numeric/ftools.hxx
With master sources updated today, it builds now. I suppose it's due to https://cgit.freedesktop.org/libreoffice/core/commit/?id=e337b9d92c6d5184e160df66885f53ebc4835218 author Tomaž Vajngerl 2021-06-16 20:46:27 +0900 committer Tomaž Vajngerl2021-06-17 01:55:32 +0200 commit e337b9d92c6d5184e160df66885f53ebc4835218 (patch) tree6eac329b19d19a0fb7b06688bea1e827743d09df parent 433ab39b2175bdadb4916373cd2dc8e1aabc08a5 (diff) basegfx: change template param to use int instead bool Thank you Tomaž! Regards, Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Aron Budea changed: What|Removed |Added Depends on||142924 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142924 [Bug 142924] Empty area when opening comment popup menu in Writer for the first time -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142924] Empty area when opening comment popup menu in Writer for the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=142924 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142924] New: Empty area when opening comment popup menu in Writer for the first time
https://bugs.documentfoundation.org/show_bug.cgi?id=142924 Bug ID: 142924 Summary: Empty area when opening comment popup menu in Writer for the first time Product: LibreOffice Version: 7.2.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: caol...@redhat.com Blocks: 103182, 106179 In a document, add a comment, and open its popup menu in the bottom right corner. => Note how the popup menu is longer than the items, and have some empty space at the end. When opening the popup a second time, it looks fine. Also fine with gen VCL plugin, so I'm assuming it only affects GTK3. Observed in LO Version: 7.2.0.0.beta1+ (d376297c643785564e7bda1a74b573c35ade6cb8) / Ubuntu. Fine in 7.1.0.3. Regression is from the following commit. Adding CC: to Caolán McNamara. https://cgit.freedesktop.org/libreoffice/core/commit/?id=69c546e1e7a697217f273baa7c1729ff823efd76 author Caolán McNamara 2020-12-04 16:30:31 + committer Caolán McNamara 2021-02-06 12:16:04 +0100 weld annotation window Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Aron Budea changed: What|Removed |Added Depends on||142924 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142924 [Bug 142924] Empty area when opening comment popup menu in Writer for the first time -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142733] Crash when deleting text with Outline folding
https://bugs.documentfoundation.org/show_bug.cgi?id=142733 --- Comment #4 from Jim Raykowski --- Hi Timur, For me the document doesn't behave well when experimental features are enabled or not. Initially the total page count shows 54 but as I move the cursor down the document the page count increases and eventually a lockup occurs. Testing with a build previous to the recent changes made to the outline folding feature also results in same lockup. This may be related to Bug 142718. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142923] Deleting comment in Writer leaves visual artifact behind
https://bugs.documentfoundation.org/show_bug.cgi?id=142923 Aron Budea changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Aron Budea changed: What|Removed |Added Depends on||142923 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142923 [Bug 142923] Deleting comment in Writer leaves visual artifact behind -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142923] New: Deleting comment in Writer leaves visual artifact behind
https://bugs.documentfoundation.org/show_bug.cgi?id=142923 Bug ID: 142923 Summary: Deleting comment in Writer leaves visual artifact behind Product: LibreOffice Version: 7.2.0.0 alpha1+ Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: normal Priority: high Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: noelgran...@gmail.com, xiscofa...@libreoffice.org Blocks: 106179 Created attachment 172992 --> https://bugs.documentfoundation.org/attachment.cgi?id=172992=edit Screenshot In Writer, add a comment to an empty document, and delete it. => It leaves visual artifacts behind. Observed in LO Version: 7.2.0.0.beta1+ (d376297c643785564e7bda1a74b573c35ade6cb8) / Ubuntu, and also on Windows. Fine in 7.1.0.3. Regression is from the following commit. Adding CC: to Noel Grandin. https://cgit.freedesktop.org/libreoffice/core/commit/?id=9abedad72c73ad83b66f3f8d261efdc5ce889683 author Noel 2021-03-28 10:28:45 +0200 committer Noel Grandin 2021-05-31 15:19:31 +0200 Drop Window::IsDisposed Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142639] [EMF] ExtSelectClipRng region data coords should be converted between Window and Viewport
https://bugs.documentfoundation.org/show_bug.cgi?id=142639 --- Comment #6 from Valek Filippov --- Created attachment 172991 --> https://bugs.documentfoundation.org/attachment.cgi?id=172991=edit One more sample with RGN_COPY This one is minified version of the sample from AOO bz120195. Blue square sides should be the same size as red line. Red line should be on the top of the square. The root cause of the problem is that LO ignores ClipRegion data because it has RGN_COPY mode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/CppunitTest_svx_removewhichrange.mk svx/Module_svx.mk svx/qa
svx/CppunitTest_svx_removewhichrange.mk | 61 ++
svx/Module_svx.mk |1
svx/qa/unit/removewhichrange.cxx| 132
3 files changed, 194 insertions(+)
New commits:
commit a07339b108275dde1769f86404515b0f19e98f2d
Author: Stephan Bergmann
AuthorDate: Thu Jun 17 14:20:00 2021 +0200
Commit: Stephan Bergmann
CommitDate: Thu Jun 17 23:00:34 2021 +0200
Add RemoveWhichRange unit test
...following up on the TODO in the commit message of
541f94df85756d3a383b1f9ba49841ca0011b52e "memcpy-param-overlap"
Change-Id: Ib1f73b867eb3625e66a5040122e53a4a6e486802
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117385
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/svx/CppunitTest_svx_removewhichrange.mk
b/svx/CppunitTest_svx_removewhichrange.mk
new file mode 100644
index ..95f958a39e5f
--- /dev/null
+++ b/svx/CppunitTest_svx_removewhichrange.mk
@@ -0,0 +1,61 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t; fill-column:
100 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,svx_removewhichrange))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,svx_removewhichrange, \
+svx/qa/unit/removewhichrange \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,svx_removewhichrange, \
+boost_headers \
+libxml2 \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,svx_removewhichrange, \
+basegfx \
+comphelper \
+cppu \
+cppuhelper \
+drawinglayer \
+editeng \
+fwk \
+i18nlangtag \
+i18nutil \
+sal \
+salhelper \
+sax \
+sb \
+sfx \
+sot \
+svl \
+svt \
+tk \
+tl \
+ucbhelper \
+utl \
+vcl \
+xo \
+$(call gb_Helper_optional,AVMEDIA,avmedia) \
+$(call gb_Helper_optional,DBCONNECTIVITY,dbtools) \
+))
+
+$(eval $(call gb_CppunitTest_use_library_objects,svx_removewhichrange, \
+svxcore \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,svx_removewhichrange))
+
+ifeq ($(OS),MACOSX)
+$(eval $(call
gb_CppunitTest_use_system_darwin_frameworks,svx_removewhichrange, \
+Foundation \
+))
+endif
+
+# vim: set noet sw=4 ts=4:
diff --git a/svx/Module_svx.mk b/svx/Module_svx.mk
index 9a45df4943c1..3891829c8108 100644
--- a/svx/Module_svx.mk
+++ b/svx/Module_svx.mk
@@ -38,6 +38,7 @@ $(eval $(call gb_Module_add_l10n_targets,svx,\
$(eval $(call gb_Module_add_check_targets,svx,\
CppunitTest_svx_unit \
CppunitTest_svx_gallery_test \
+ CppunitTest_svx_removewhichrange \
))
# screenshots
diff --git a/svx/qa/unit/removewhichrange.cxx b/svx/qa/unit/removewhichrange.cxx
new file mode 100644
index ..fc2b0a038931
--- /dev/null
+++ b/svx/qa/unit/removewhichrange.cxx
@@ -0,0 +1,132 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+
+namespace
+{
+class TestRemoveWhichRange : public CppUnit::TestFixture
+{
+CPPUNIT_TEST_SUITE(TestRemoveWhichRange);
+CPPUNIT_TEST(testRemoveWhichRange);
+CPPUNIT_TEST_SUITE_END();
+
+void testRemoveWhichRange()
+{
+{
+sal_uInt16 const in[] = { 0 };
+auto const out = RemoveWhichRange(in, 10, 20);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), out[0]);
+}
+{
+sal_uInt16 const in[] = { 10, 20, 30, 40, 0 };
+auto const out = RemoveWhichRange(in, 0, 20);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(30), out[0]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(40), out[1]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), out[2]);
+}
+{
+sal_uInt16 const in[] = { 10, 20, 30, 40, 0 };
+auto const out = RemoveWhichRange(in, 10, 20);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(30), out[0]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(40), out[1]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), out[2]);
+}
+{
+sal_uInt16 const in[] = { 10, 20, 30, 40, 0 };
+auto const out = RemoveWhichRange(in, 15, 20);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(10), out[0]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(14), out[1]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(30), out[2]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(40), out[3]);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), out[4]);
+
[Libreoffice-commits] core.git: bin/symbolstore.py Makefile.in
Makefile.in|2 +-
bin/symbolstore.py | 38 +++---
2 files changed, 32 insertions(+), 8 deletions(-)
New commits:
commit 960b2878cb504f10a27b24714d3c81bba6f48634
Author: Christian Lohmaier
AuthorDate: Thu Jun 17 14:46:03 2021 +0200
Commit: Christian Lohmaier
CommitDate: Thu Jun 17 22:48:02 2021 +0200
don't ignore dump_syms errors during symbol extraction
also fix the file filtering in case directories are passed for recursive
traversal (pdb files are not created in instdir, so that never really
matched our build-env)
Pass a directory to the invocation to make use of that filtering, and
also add a retry in case dump_syms segfaults during processing
(see also 73299faa75a4974eb49c93ffdfb2d6329cb4e519)
Change-Id: I8989c3fd72de0b18eecce490fac81db956f87515
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117386
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
diff --git a/Makefile.in b/Makefile.in
index b6a93cdeb8c6..f9a2644e569a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -430,7 +430,7 @@ symbols:
rm -fr $(WORKDIR)/symbols/
mkdir -p $(WORKDIR)/symbols/
ifeq ($(OS),WNT)
- $(SRCDIR)/bin/symbolstore.py
$(WORKDIR)/UnpackedTarball/breakpad/src/tools/windows/dump_syms/Release/dump_syms.exe
$(WORKDIR)/symbols/ $(INSTDIR)/program/*
+ $(SRCDIR)/bin/symbolstore.py
$(WORKDIR)/UnpackedTarball/breakpad/src/tools/windows/dump_syms/Release/dump_syms.exe
$(WORKDIR)/symbols/ $(INSTDIR)/program/
$(SRCDIR)/bin/symstore.sh
else
$(SRCDIR)/bin/symbolstore.py
$(WORKDIR)/UnpackedTarball/breakpad/src/tools/linux/dump_syms/dump_syms
$(WORKDIR)/symbols/ $(INSTDIR)/program/*
diff --git a/bin/symbolstore.py b/bin/symbolstore.py
index 1f80e2f69e99..2101e396153b 100755
--- a/bin/symbolstore.py
+++ b/bin/symbolstore.py
@@ -452,12 +452,17 @@ class Dumper:
if filename.startswith("cvs"):
(ver, checkout, source_file, revision) =
filename.split(":", 3)
sourceFileStream += sourcepath + "*MYSERVER*"
+ source_file + '*' + revision + "\r\n"
-f.write("FILE %s %s\n" % (index, filename))
+f.write("FILE %s %s\r\n" % (index, filename))
else:
# pass through all other lines unchanged
f.write(line)
f.close()
-cmd.close()
+command_exit = cmd.close()
+if command_exit:
+if command_exit == 11:
+print >> sys.stderr, "INFO: dump_syms segfault
while processing {}, retrying".format(file)
+return self.ProcessFile(file)
+raise Exception("ERROR - dump_syms error while
processing {} (exit code {})".format(file, command_exit))
# we output relative paths so callers can get a list of
what
# was generated
print rel_path
@@ -468,6 +473,7 @@ class Dumper:
result = self.SourceServerIndexing(debug_file, guid,
sourceFileStream, cvs_root)
result = True
except StopIteration:
+print >> sys.stderr, "WARN: dump_syms - no debug info
extracted for {}".format(file)
pass
except:
print >> sys.stderr, "Unexpected error: ", sys.exc_info()[0]
@@ -483,11 +489,29 @@ class Dumper_Win32(Dumper):
def ShouldProcess(self, file):
"""This function will allow processing of pdb files that have dll
or exe files with the same base name next to them."""
-if file.endswith(".pdb"):
-(path,ext) = os.path.splitext(file)
-if os.path.isfile(path + ".exe") or os.path.isfile(path + ".dll")
or os.path.isfile(path + ".bin"):
-return True
-return False
+
+skip_extensions = [
+ ".bat", ".class", ".config", ".css", ".glsl", ".hrc", ".ini",
".jar", ".mo", ".msu",
+ ".ods", ".png", ".py", ".pyc", ".rdb", ".rst", ".sh", ".svg",
".ttf", ".txt", ".xml",
+]
+(path,ext) = os.path.splitext(file)
+basename = os.path.basename(file)
+if ext in skip_extensions:
+ return False
+elif os.path.getsize(file) == 21:
+ # content is the "invalid - merged lib" stub
+ return False
+elif basename.startswith("LICENSE") or basename.startswith("README"):
+ return False
+elif basename == "msvcp140.dll" or basename == "vcruntime140.dll":
+ return False
+elif basename.startswith("wininst-") or basename == "fetch_macholib"
or basename == "command_template":
+ # ignore python distutils stubs and scripts
+ return False
+elif ext ==
[Libreoffice-ux-advise] [Bug 142499] Make 'fat cross' cursor optional
https://bugs.documentfoundation.org/show_bug.cgi?id=142499 --- Comment #7 from Martin Srebotnjak --- Beta2 should not introduce any new features, beta1 should lock the features. Who decided this can be added later? Did you discuss this with l10n teams? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142910] Standard filters involving "greater than" or "smaller than" (>, <, >=, <=) fail and hide everything
https://bugs.documentfoundation.org/show_bug.cgi?id=142910 m.a.riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|normal |major OS|Linux (All) |All CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Repro Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: aa9cb8e14749e7fb7a83b55a2bb095501f731a18 CPU threads: 4; OS: Windows 10.0 Build 21387; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 Mike Kaganski changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillCpp --- Comment #1 from Mike Kaganski --- The fix to this easyhack must include a unit test. Please CC me to the respective gerrit change, so that I could review and assist. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142922] New: Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 Bug ID: 142922 Summary: Basic: Round VBA compatibility function implements wrong rounding mode Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: implementationError Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com As explained in VBA documentation for Round [1]: > This VBA function returns something commonly referred to as bankers rounding. [MS-VBAL] [2] defined Banker's rounding as alternative name for "round-to-even"; it is one of rounding modes defined in IEEE 754, its recommended rounding mode for decimal [3]. [1] also provides some examples demonstrating the values returned bu VBA's Round: > ?Round(0.12335,4) > 0,1234 > ?Round(0.12345,4) > 0,1234 > ?Round(0.12355,4) > 0,1236 > ?Round(0.12365,4) > 0,1236 However, LibreOffice's Round function [4] implementation [5] does not implement the required rounding mode. Executing the example calculations mentioned above gives 0.1234, 0.1235, 0.1236, 0.1237. FTR: we have a rtl_math_round function, that accepts a flag defining rounding mode, rtl_math_RoundingMode_HalfEven among the possible values, which may be used in the VBA function implementation. [1] https://docs.microsoft.com/en-us/office/vba/language/reference/user-interface-help/round-function [2] https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/ms-vbal/98152b5a-4d86-4acb-b875-66cb1f49433e [3] https://en.wikipedia.org/wiki/IEEE_754#Rounding_rules [4] https://help.libreoffice.org/7.2/en-US/text/sbasic/shared/0317.html?DbPAR=BASIC [5] https://opengrok.libreoffice.org/xref/core/basic/source/runtime/methods1.cxx?r=86d298f8=63707=2377#2377 [6] https://opengrok.libreoffice.org/xref/core/sal/rtl/math.cxx?r=49af7e22=38462=1130#1130 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx |8 1 file changed, 8 insertions(+) New commits: commit b5eb15a21d89d5c4bb45122f68e68944ab8ffe42 Author: Caolán McNamara AuthorDate: Thu Jun 17 17:12:02 2021 +0100 Commit: Caolán McNamara CommitDate: Thu Jun 17 21:27:12 2021 +0200 gtk4: reenable a cluster of working dialogs Change-Id: Ida6e77c17681d9b1b5c0b7d6f6641974e097edbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117395 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index 5f28cb4d81c7..b98e3e7459c6 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -22298,6 +22298,7 @@ weld::Builder* GtkInstance::CreateBuilder(weld::Widget* pParent, const OUString& rUIFile != "cui/ui/similaritysearchdialog.ui" && rUIFile != "cui/ui/specialcharacters.ui" && rUIFile != "cui/ui/spelloptionsdialog.ui" && +rUIFile != "cui/ui/spinbox.ui" && rUIFile != "cui/ui/textflowpage.ui" && rUIFile != "cui/ui/thesaurus.ui" && rUIFile != "cui/ui/tipofthedaydialog.ui" && @@ -22422,6 +22423,8 @@ weld::Builder* GtkInstance::CreateBuilder(weld::Widget* pParent, const OUString& rUIFile != "modules/swriter/ui/autotext.ui" && rUIFile != "modules/swriter/ui/bibliographyentry.ui" && rUIFile != "modules/swriter/ui/bulletsandnumbering.ui" && +rUIFile != "modules/swriter/ui/businessdatapage.ui" && +rUIFile != "modules/swriter/ui/cardmediumpage.ui" && rUIFile != "modules/swriter/ui/characterproperties.ui" && rUIFile != "modules/swriter/ui/charurlpage.ui" && rUIFile != "modules/swriter/ui/columndialog.ui" && @@ -22446,6 +22449,9 @@ weld::Builder* GtkInstance::CreateBuilder(weld::Widget* pParent, const OUString& rUIFile != "modules/swriter/ui/insertfootnote.ui" && rUIFile != "modules/swriter/ui/insertsectiondialog.ui" && rUIFile != "modules/swriter/ui/inserttable.ui" && +rUIFile != "modules/swriter/ui/labeldialog.ui" && +rUIFile != "modules/swriter/ui/labelformatpage.ui" && +rUIFile != "modules/swriter/ui/labeloptionspage.ui" && rUIFile != "modules/swriter/ui/linenumbering.ui" && rUIFile != "modules/swriter/ui/newuserindexdialog.ui" && rUIFile != "modules/swriter/ui/numberingnamedialog.ui" && @@ -22456,8 +22462,10 @@ weld::Builder* GtkInstance::CreateBuilder(weld::Widget* pParent, const OUString& rUIFile != "modules/swriter/ui/paradialog.ui" && rUIFile != "modules/swriter/ui/printeroptions.ui" && rUIFile != "modules/swriter/ui/printoptionspage.ui" && +rUIFile != "modules/swriter/ui/privateuserpage.ui" && rUIFile != "modules/swriter/ui/renameautotextdialog.ui" && rUIFile != "modules/swriter/ui/renameobjectdialog.ui" && +rUIFile != "modules/swriter/ui/savelabeldialog.ui" && rUIFile != "modules/swriter/ui/sectionpage.ui" && rUIFile != "modules/swriter/ui/statisticsinfopage.ui" && rUIFile != "modules/swriter/ui/templatedialog8.ui" && ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/envelp/label1.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit c88e44e5c2d6a3cfc8752295c48809c97ad5c53f
Author: Caolán McNamara
AuthorDate: Thu Jun 17 17:04:03 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu Jun 17 21:26:42 2021 +0200
drop the bare set_busy_cursor, the scoped WaitObject is enough
to set it back to its default on leaving the scope
Change-Id: I303c201a1830ef24955fe35ad1058d6d88067f4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx
index 31d2ffddd6be..6d34ea2132de 100644
--- a/sw/source/ui/envelp/label1.cxx
+++ b/sw/source/ui/envelp/label1.cxx
@@ -154,8 +154,6 @@ SwLabDlg::SwLabDlg(weld::Window* pParent, const SfxItemSet&
rSet,
AddTabPage("private", SwPrivateDataPage::Create, nullptr);
m_xDialog->set_title(m_sBusinessCardDlg);
}
-
-pParent->set_busy_cursor(false);
}
SwLabDlg::~SwLabDlg()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |3 +++
vcl/unx/gtk3/gtkframe.cxx| 28 ++--
vcl/unx/gtk3/gtkinst.cxx | 11 ---
3 files changed, 29 insertions(+), 13 deletions(-)
New commits:
commit 560492cf578182df083fb8906a20994b3182a980
Author: Caolán McNamara
AuthorDate: Thu Jun 17 15:59:30 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu Jun 17 21:26:15 2021 +0200
gtk4: get the cairo_font_options from widget pango_context
in the absence of gdk_screen_get_font_options
SalEvent::FontChanged is successfully firing for me on changing hinting
in gnome-tweaks font section.
Change-Id: I035a07d585b59822b08c801283321ab2582649aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117393
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 6fd9592c083e..248b841dc07e 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -181,6 +181,7 @@ class GtkSalFrame final : public SalFrame
GtkFixed* m_pFixedContainer;
GtkDrawingArea* m_pDrawingArea;
GtkEventControllerKey* m_pKeyController;
+gulong m_nSettingChangedSignalId;
#endif
#if !GTK_CHECK_VERSION(4, 0, 0)
GdkWindow* m_pForeignParent;
@@ -613,6 +614,8 @@ public:
static OUString GetPreeditDetails(GtkIMContext* pIMContext,
std::vector& rInputFlags, sal_Int32& rCursorPos, sal_uInt8&
rCursorFlags);
static SelectionCalcDeleteSurroundingSelection(const OUString&
rSurroundingText, sal_Int32 nCursorIndex, int nOffset, int nChars);
+const cairo_font_options_t* get_font_options();
+
void DisallowCycleFocusOut();
bool IsCycleFocusOutDisallowed() const;
void AllowCycleFocusOut();
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 7dcfade40a59..b32eb14ad5e7 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -705,6 +705,8 @@ GtkSalFrame::~GtkSalFrame()
gtk_widget_destroy( GTK_WIDGET(m_pEventBox) );
if( m_pTopLevelGrid )
gtk_widget_destroy( GTK_WIDGET(m_pTopLevelGrid) );
+#else
+
g_signal_handler_disconnect(G_OBJECT(gtk_widget_get_display(pEventWidget)),
m_nSettingChangedSignalId);
#endif
{
SolarMutexGuard aGuard;
@@ -940,7 +942,7 @@ void GtkSalFrame::InitCommon()
#endif
#if GTK_CHECK_VERSION(4,0,0)
-g_signal_connect(G_OBJECT(gtk_widget_get_display(pEventWidget)),
"setting-changed", G_CALLBACK(signalStyleUpdated), this);
+m_nSettingChangedSignalId =
g_signal_connect(G_OBJECT(gtk_widget_get_display(pEventWidget)),
"setting-changed", G_CALLBACK(signalStyleUpdated), this);
#else
// use pEventWidget instead of m_pWindow to avoid infinite event loop
under Linux Mint Mate 18.3
g_signal_connect(G_OBJECT(pEventWidget), "style-updated",
G_CALLBACK(signalStyleUpdated), this);
@@ -4076,8 +4078,20 @@ gboolean GtkSalFrame::signalDelete(GtkWidget*,
GdkEvent*, gpointer frame)
}
#endif
+const cairo_font_options_t* GtkSalFrame::get_font_options()
+{
+GtkWidget* pWidget = getMouseEventWidget();
+#if GTK_CHECK_VERSION(4, 0, 0)
+PangoContext* pContext = gtk_widget_get_pango_context(pWidget);
+assert(pContext);
+return pango_cairo_context_get_font_options(pContext);
+#else
+return gdk_screen_get_font_options(gtk_widget_get_screen(pWidget));
+#endif
+}
+
#if GTK_CHECK_VERSION(4, 0, 0)
-void GtkSalFrame::signalStyleUpdated(GtkWidget*, const gchar* pSetting,
gpointer frame)
+void GtkSalFrame::signalStyleUpdated(GtkWidget*, const gchar* /*pSetting*/,
gpointer frame)
#else
void GtkSalFrame::signalStyleUpdated(GtkWidget*, gpointer frame)
#endif
@@ -4087,17 +4101,12 @@ void GtkSalFrame::signalStyleUpdated(GtkWidget*,
gpointer frame)
// note: settings changed for multiple frames is avoided in winproc.cxx
ImplHandleSettings
GtkSalFrame::getDisplay()->SendInternalEvent( pThis, nullptr,
SalEvent::SettingsChanged );
-#if GTK_CHECK_VERSION(4, 0, 0)
-OString sSetting(pSetting);
-if (sSetting.startsWith("gtk-xft"))
-GtkSalFrame::getDisplay()->SendInternalEvent( pThis, nullptr,
SalEvent::FontChanged );
-#endif
+// a plausible alternative might be to send SalEvent::FontChanged if
pSetting starts with "gtk-xft"
-#if !GTK_CHECK_VERSION(4, 0, 0)
// fire off font-changed when the system cairo font hints change
GtkInstance *pInstance =
static_cast(GetSalData()->m_pInstance);
const cairo_font_options_t* pLastCairoFontOptions =
pInstance->GetLastSeenCairoFontOptions();
-const cairo_font_options_t* pCurrentCairoFontOptions =
gdk_screen_get_font_options(gdk_screen_get_default());
+const cairo_font_options_t* pCurrentCairoFontOptions =
pThis->get_font_options();
bool bFontSettingsChanged = true;
if (pLastCairoFontOptions &&
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |4 +++-
vcl/unx/gtk3/gtkframe.cxx| 22 ++
2 files changed, 21 insertions(+), 5 deletions(-)
New commits:
commit 3a2d142b99cbd57bacda8746541d4cdb4216adeb
Author: Caolán McNamara
AuthorDate: Thu Jun 17 15:33:51 2021 +0100
Commit: Caolán McNamara
CommitDate: Thu Jun 17 21:25:42 2021 +0200
gtk4: listen to display's setting-changed
in the absence of style-updated
e.g. changing theme to a dark/light should change the brand image
in the start center
Change-Id: I7242019069b13093fee1430ade816a48fc0687f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117390
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index b1ddd52913b8..6fd9592c083e 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -239,10 +239,12 @@ class GtkSalFrame final : public SalFrame
void InitCommon();
void InvalidateGraphics();
-#if !GTK_CHECK_VERSION(4, 0, 0)
// signals
+#if !GTK_CHECK_VERSION(4, 0, 0)
static gboolean signalButton( GtkWidget*, GdkEventButton*, gpointer );
static void signalStyleUpdated(GtkWidget*, gpointer);
+#else
+static void signalStyleUpdated(GtkWidget*, const gchar* pSetting,
pointer);
#endif
void DrawingAreaResized(GtkWidget* pWidget, int nWidth, int nHeight);
void DrawingAreaDraw(cairo_t *cr);
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 14f2a2e76c59..7dcfade40a59 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -939,12 +939,14 @@ void GtkSalFrame::InitCommon()
gtk_widget_set_redraw_on_allocate(GTK_WIDGET(m_pDrawingArea), false);
#endif
-#if !GTK_CHECK_VERSION(4,0,0)
-// connect signals
+#if GTK_CHECK_VERSION(4,0,0)
+g_signal_connect(G_OBJECT(gtk_widget_get_display(pEventWidget)),
"setting-changed", G_CALLBACK(signalStyleUpdated), this);
+#else
// use pEventWidget instead of m_pWindow to avoid infinite event loop
under Linux Mint Mate 18.3
-g_signal_connect( G_OBJECT(pEventWidget), "style-updated",
G_CALLBACK(signalStyleUpdated), this );
+g_signal_connect(G_OBJECT(pEventWidget), "style-updated",
G_CALLBACK(signalStyleUpdated), this);
#endif
gtk_widget_set_has_tooltip(pEventWidget, true);
+// connect signals
m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget),
"query-tooltip", G_CALLBACK(signalTooltipQuery), this ));
#if !GTK_CHECK_VERSION(4,0,0)
m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget),
"button-press-event", G_CALLBACK(signalButton), this ));
@@ -4074,14 +4076,24 @@ gboolean GtkSalFrame::signalDelete(GtkWidget*,
GdkEvent*, gpointer frame)
}
#endif
-#if !GTK_CHECK_VERSION(4, 0, 0)
+#if GTK_CHECK_VERSION(4, 0, 0)
+void GtkSalFrame::signalStyleUpdated(GtkWidget*, const gchar* pSetting,
gpointer frame)
+#else
void GtkSalFrame::signalStyleUpdated(GtkWidget*, gpointer frame)
+#endif
{
GtkSalFrame* pThis = static_cast(frame);
// note: settings changed for multiple frames is avoided in winproc.cxx
ImplHandleSettings
GtkSalFrame::getDisplay()->SendInternalEvent( pThis, nullptr,
SalEvent::SettingsChanged );
+#if GTK_CHECK_VERSION(4, 0, 0)
+OString sSetting(pSetting);
+if (sSetting.startsWith("gtk-xft"))
+GtkSalFrame::getDisplay()->SendInternalEvent( pThis, nullptr,
SalEvent::FontChanged );
+#endif
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
// fire off font-changed when the system cairo font hints change
GtkInstance *pInstance =
static_cast(GetSalData()->m_pInstance);
const cairo_font_options_t* pLastCairoFontOptions =
pInstance->GetLastSeenCairoFontOptions();
@@ -4096,8 +4108,10 @@ void GtkSalFrame::signalStyleUpdated(GtkWidget*,
gpointer frame)
pInstance->ResetLastSeenCairoFontOptions(pCurrentCairoFontOptions);
GtkSalFrame::getDisplay()->SendInternalEvent( pThis, nullptr,
SalEvent::FontChanged );
}
+#endif
}
+#if !GTK_CHECK_VERSION(4, 0, 0)
gboolean GtkSalFrame::signalWindowState( GtkWidget*, GdkEvent* pEvent,
gpointer frame )
{
GtkSalFrame* pThis = static_cast(frame);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - editeng/source
editeng/source/editeng/impedit2.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 0c595221d2b87a102763da4582574c269d154f8d
Author: Mike Kaganski
AuthorDate: Thu Jun 17 17:22:36 2021 +0300
Commit: Mike Kaganski
CommitDate: Thu Jun 17 21:22:18 2021 +0200
tdf#142839: do not forget to initialize *pHeightNTP
Regression after commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5
Change-Id: Iaa8f67e0c7e3d99b057294717d24ffac4ad3534c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117389
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 59611f7b6acbf643bde0e0121ee51e2df53e7d50)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117304
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 14685e7e1314..4bc8a570b9c3 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -3410,6 +3410,8 @@ sal_uInt32 ImpEditEngine::GetTextHeightNTP() const
tools::Long ImpEditEngine::Calc1ColumnTextHeight(tools::Long* pHeightNTP)
{
tools::Long nHeight = 0;
+if (pHeightNTP)
+*pHeightNTP = 0;
// Pretend that we have ~infinite height to get total height
comphelper::ValueRestorationGuard aGuard(nCurTextHeight,
std::numeric_limits::max());
@@ -3440,6 +3442,8 @@ tools::Long ImpEditEngine::CalcTextHeight(tools::Long*
pHeightNTP)
tools::Long nTentativeColHeight = mnMinColumnWrapHeight;
tools::Long nWantedIncrease = 0;
tools::Long nCurrentTextHeight;
+if (pHeightNTP)
+*pHeightNTP = 0;
// This does the necessary column balancing for the case when the text
does not fit min height.
// When the height of column (taken from nCurTextHeight) is too small, the
last column will
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docnum.cxx | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
New commits:
commit 7d186c0510b18d12267fc9d930298eadd1cadb8e
Author: Justin Luth
AuthorDate: Thu May 13 07:47:09 2021 +0200
Commit: Justin Luth
CommitDate: Thu Jun 17 21:01:30 2021 +0200
NFC sw PropagateOutlineRule: early exit if no outlineRule
There is only one outline rule, and we are just getting
a pointer to it, so there should be no reason why
this is retrieved for every style defined on the system.
Just get it right at the beginning, and exit if there is none.
Change-Id: I09d122481623dd4667e3f67c5de98164ff106a27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115615
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index 95461208e954..9a7740a735e4 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -163,6 +163,10 @@ void SwDoc::SetOutlineNumRule( const SwNumRule& rRule )
void SwDoc::PropagateOutlineRule()
{
+SwNumRule* pMyOutlineRule = GetOutlineNumRule();
+if (!pMyOutlineRule)
+return;
+
for (auto pColl : *mpTextFormatCollTable)
{
if(pColl->IsAssignedToListLevelOfOutlineStyle())
@@ -172,14 +176,8 @@ void SwDoc::PropagateOutlineRule()
if ( rCollRuleItem.GetValue().isEmpty() )
{
-SwNumRule * pMyOutlineRule = GetOutlineNumRule();
-
-if (pMyOutlineRule)
-{
-SwNumRuleItem aNumItem( pMyOutlineRule->GetName() );
-
-pColl->SetFormatAttr(aNumItem);
-}
+SwNumRuleItem aNumItem( pMyOutlineRule->GetName() );
+pColl->SetFormatAttr(aNumItem);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/inc
oox/inc/drawingml/textliststyle.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2fad86dea0075a98d2d34bf43780611dd986dc68
Author: Andrea Gelmini
AuthorDate: Thu Jun 17 09:17:56 2021 +0200
Commit: Andrea Gelmini
CommitDate: Thu Jun 17 20:58:31 2021 +0200
Fix typo
Change-Id: Ia84c47ea309734f27fd492ba791d88200408f105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117361
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/oox/inc/drawingml/textliststyle.hxx
b/oox/inc/drawingml/textliststyle.hxx
index 7fe071af669b..5f986ff45afa 100644
--- a/oox/inc/drawingml/textliststyle.hxx
+++ b/oox/inc/drawingml/textliststyle.hxx
@@ -54,7 +54,7 @@ public:
void setHasListStyleOnImport() { mbHasListStyleOnImport = true; }
/** Returns whether the lstStyle tag was non-empty on import
*
- * @return true if list style has it's own noninherited properties.
+ * @return true if list style has its own noninherited properties.
*/
bool hasListStyleOnImport() const { return mbHasListStyleOnImport; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/qa
0 files changed New commits: commit 73db169bf3ce6596ce9eaff4ee99e90dbfc3010a Author: Andrea Gelmini AuthorDate: Thu Jun 17 09:17:31 2021 +0200 Commit: Andrea Gelmini CommitDate: Thu Jun 17 20:57:58 2021 +0200 Removed executable bits on pptx file Change-Id: Icd927660130f72a077c12a38914b3fe8d0ab7d28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117360 Tested-by: Jenkins Reviewed-by: Andrea Gelmini diff --git a/sd/qa/unit/data/pptx/tdf59323.pptx b/sd/qa/unit/data/pptx/tdf59323.pptx old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - editeng/source
editeng/source/editeng/impedit2.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 4a2894a2b9c973b275788190220d205e41eb92db
Author: Mike Kaganski
AuthorDate: Thu Jun 17 17:22:36 2021 +0300
Commit: Mike Kaganski
CommitDate: Thu Jun 17 20:56:04 2021 +0200
tdf#142839: do not forget to initialize *pHeightNTP
Regression after commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5
Change-Id: Iaa8f67e0c7e3d99b057294717d24ffac4ad3534c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117389
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 59611f7b6acbf643bde0e0121ee51e2df53e7d50)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117305
Tested-by: Jenkins CollaboraOffice
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 4980c5730de8..ff080b1444dd 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -3437,6 +3437,8 @@ sal_uInt32 ImpEditEngine::GetTextHeightNTP() const
tools::Long ImpEditEngine::Calc1ColumnTextHeight(tools::Long* pHeightNTP)
{
tools::Long nHeight = 0;
+if (pHeightNTP)
+*pHeightNTP = 0;
// Pretend that we have ~infinite height to get total height
comphelper::ValueRestorationGuard aGuard(nCurTextHeight,
std::numeric_limits::max());
@@ -3467,6 +3469,8 @@ tools::Long ImpEditEngine::CalcTextHeight(tools::Long*
pHeightNTP)
tools::Long nTentativeColHeight = mnMinColumnWrapHeight;
tools::Long nWantedIncrease = 0;
tools::Long nCurrentTextHeight;
+if (pHeightNTP)
+*pHeightNTP = 0;
// This does the necessary column balancing for the case when the text
does not fit min height.
// When the height of column (taken from nCurTextHeight) is too small, the
last column will
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142872] Captioned image doubled in HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=142872 psidiumcode changed: What|Removed |Added Keywords|bibisectRequest, regression |bibisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142872] Captioned image doubled in HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=142872 --- Comment #5 from psidiumcode --- bisect log: # bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source sha:3d311c6d63eafbe2f76d6f1768dc3f675970a55a # good: [25b063cc33a4d47d0c559132b4460218fd6168fe] source sha:5c682a5e24337ac022fb3eba585583b16718d246 git bisect start 'master' '25b063cc33a4d47d0c559132b4460218fd6168fe' # good: [1a943bbc388d5c1cca596e35a53d54740d163d85] source sha:447d13023dcba333d34aba315e9093d1c82b8912 git bisect good 1a943bbc388d5c1cca596e35a53d54740d163d85 # bad: [d03ccb025ebef11f020240245008bb3be8e34611] source sha:c617b11ff37a18225f9666b7d028a734d12b360a git bisect bad d03ccb025ebef11f020240245008bb3be8e34611 # bad: [5882c66a180fd129fe5863cee664d311876fa8de] source sha:6a8e7beef4f75e348536f971254fd4fd23c1806e git bisect bad 5882c66a180fd129fe5863cee664d311876fa8de # good: [dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0] source sha:e7afd6407401014f9eee6cbce0f80da7c0491a4e git bisect good dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0 # good: [c1d41723a0d47b325e8a2f44806aa34959f26eb2] source sha:8771f48512ed19197c17506f522578f43b092b21 git bisect good c1d41723a0d47b325e8a2f44806aa34959f26eb2 # bad: [4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a] source sha:ef0d150675687469ca85de62b67e34c1e3daa176 git bisect bad 4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a # good: [e82b51b1c666f14a6b9175731f297365f211e553] source sha:08b7529f628eda1d209cf27f9bbe52ee336fef62 git bisect good e82b51b1c666f14a6b9175731f297365f211e553 # bad: [904778bcbc32eeaaea0330a6dc9b7d288976729a] source sha:f1be88688cf1ca4ab14f93ae1a75e0331a6577cb git bisect bad 904778bcbc32eeaaea0330a6dc9b7d288976729a # bad: [2c54e1bdeb4512807991cc983c0f69b88f22daca] source sha:e4e24a2f996989c3e7969aab71a9db78f1b41889 git bisect bad 2c54e1bdeb4512807991cc983c0f69b88f22daca # bad: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 git bisect bad be872312b348a55f7f07f6fbb1e08cb55b71f53a # first bad commit: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 momoko@Tocte mac64-7.2 % git bisect log # bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source sha:3d311c6d63eafbe2f76d6f1768dc3f675970a55a # good: [25b063cc33a4d47d0c559132b4460218fd6168fe] source sha:5c682a5e24337ac022fb3eba585583b16718d246 git bisect start 'master' '25b063cc33a4d47d0c559132b4460218fd6168fe' # good: [1a943bbc388d5c1cca596e35a53d54740d163d85] source sha:447d13023dcba333d34aba315e9093d1c82b8912 git bisect good 1a943bbc388d5c1cca596e35a53d54740d163d85 # bad: [d03ccb025ebef11f020240245008bb3be8e34611] source sha:c617b11ff37a18225f9666b7d028a734d12b360a git bisect bad d03ccb025ebef11f020240245008bb3be8e34611 # bad: [5882c66a180fd129fe5863cee664d311876fa8de] source sha:6a8e7beef4f75e348536f971254fd4fd23c1806e git bisect bad 5882c66a180fd129fe5863cee664d311876fa8de # good: [dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0] source sha:e7afd6407401014f9eee6cbce0f80da7c0491a4e git bisect good dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0 # good: [c1d41723a0d47b325e8a2f44806aa34959f26eb2] source sha:8771f48512ed19197c17506f522578f43b092b21 git bisect good c1d41723a0d47b325e8a2f44806aa34959f26eb2 # bad: [4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a] source sha:ef0d150675687469ca85de62b67e34c1e3daa176 git bisect bad 4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a # good: [e82b51b1c666f14a6b9175731f297365f211e553] source sha:08b7529f628eda1d209cf27f9bbe52ee336fef62 git bisect good e82b51b1c666f14a6b9175731f297365f211e553 # bad: [904778bcbc32eeaaea0330a6dc9b7d288976729a] source sha:f1be88688cf1ca4ab14f93ae1a75e0331a6577cb git bisect bad 904778bcbc32eeaaea0330a6dc9b7d288976729a # bad: [2c54e1bdeb4512807991cc983c0f69b88f22daca] source sha:e4e24a2f996989c3e7969aab71a9db78f1b41889 git bisect bad 2c54e1bdeb4512807991cc983c0f69b88f22daca # bad: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 git bisect bad be872312b348a55f7f07f6fbb1e08cb55b71f53a # first bad commit: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142872] Captioned image doubled in HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=142872 --- Comment #4 from psidiumcode --- bisect information: be872312b348a55f7f07f6fbb1e08cb55b71f53a is the first bad commit commit be872312b348a55f7f07f6fbb1e08cb55b71f53a Author: libreoffice Date: Mon Jun 14 17:58:16 2021 +0200 source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 source sha:e76471c5ce725dae9abb6f78b7674c6f77df34f4 LibreOffice.app/Contents/Frameworks/libswlo.dylib | Bin 18590944 -> 18591040 bytes .../Contents/Resources/config/images_breeze.zip| Bin 1893222 -> 1893222 bytes .../Resources/config/images_breeze_dark.zip| Bin 188 -> 188 bytes .../Resources/config/images_breeze_dark_svg.zip| Bin 1571133 -> 1571133 bytes .../Resources/config/images_breeze_svg.zip | Bin 1568649 -> 1568649 bytes .../Contents/Resources/config/images_colibre.zip | Bin 2785191 -> 2785191 bytes .../Resources/config/images_colibre_svg.zip| Bin 2899838 -> 2899838 bytes .../Resources/config/images_elementary.zip | Bin 4198427 -> 4198427 bytes .../Resources/config/images_elementary_svg.zip | Bin 5520392 -> 5520392 bytes .../Resources/config/images_karasa_jaga.zip| Bin 4887661 -> 4887661 bytes .../Resources/config/images_karasa_jaga_svg.zip| Bin 19328964 -> 19328964 bytes .../Contents/Resources/config/images_sifr.zip | Bin 2109031 -> 2109031 bytes .../Contents/Resources/config/images_sifr_dark.zip | Bin 2110980 -> 2110980 bytes .../Resources/config/images_sifr_dark_svg.zip | Bin 1760991 -> 1760991 bytes .../Contents/Resources/config/images_sifr_svg.zip | Bin 1757096 -> 1757096 bytes .../Contents/Resources/config/images_sukapura.zip | Bin 3046042 -> 3046042 bytes .../Resources/config/images_sukapura_svg.zip | Bin 4356159 -> 4356159 bytes LibreOffice.app/Contents/Resources/setuprc | 2 +- LibreOffice.app/Contents/Resources/versionrc | 2 +- 19 files changed, 2 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/tools
include/tools/color.hxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 3620fda235e8b02dea8e225215d53f4c64d1348e
Author: Noel Grandin
AuthorDate: Thu Jun 17 13:54:37 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 17 20:44:53 2021 +0200
tweak tools::Color::IsDark so it triggers on Ubuntu
in dark mode, otherwise some of the UI elements e.g. the start centre
brand image, do not display the right version
Change-Id: I3bfdc597324b564a9dbd47174332bb5f21b6a052
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117383
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/tools/color.hxx b/include/tools/color.hxx
index ac361474c228..4c75f5852aab 100644
--- a/include/tools/color.hxx
+++ b/include/tools/color.hxx
@@ -311,7 +311,8 @@ public:
*/
bool IsDark() const
{
-return GetLuminance() <= 60;
+// 62 is the number that means it also triggers on Ubuntu in dark mode
+return GetLuminance() <= 62;
}
/** Comparison with luminance thresholds.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #21 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ecbdb403d16f6b0aeb8b543e069e9d82adf10437 tdf#135316 docx open performance, cache next character style name It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - nlpsolver/ThirdParty writerfilter/source
nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/DEGTBehavior.java
|2
nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/knowledge/Library.java
|4 +
writerfilter/source/dmapper/DomainMapper.cxx
| 10 ++
writerfilter/source/dmapper/DomainMapper.hxx
|3
writerfilter/source/dmapper/DomainMapper_Impl.cxx
| 37 ++
writerfilter/source/dmapper/DomainMapper_Impl.hxx
|5 +
writerfilter/source/dmapper/StyleSheetTable.cxx
| 22 -
7 files changed, 63 insertions(+), 20 deletions(-)
New commits:
commit ecbdb403d16f6b0aeb8b543e069e9d82adf10437
Author: Noel Grandin
AuthorDate: Thu Jun 17 18:44:01 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 17 20:44:22 2021 +0200
tdf#135316 docx open performance, cache next character style name
so we don't have to scan the list repeatedly, which is O(n^2)
This takes my load time from 37s to 22s
Change-Id: I0df2f2ace82f5cd6287c7ded796b02c5242269ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117396
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index fd341dd4d765..39b118e108f0 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -4127,6 +4127,16 @@ void DomainMapper::commentProps(const OUString& sId,
const CommentProperties& rP
m_pImpl->commentProps(sId, rProps);
}
+css::uno::Reference const &
DomainMapper::GetCharacterStyles()
+{
+return m_pImpl->GetCharacterStyles();
+}
+
+OUString DomainMapper::GetUnusedCharacterStyleName()
+{
+return m_pImpl->GetUnusedCharacterStyleName();
+}
+
} //namespace writerfilter
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper.hxx
b/writerfilter/source/dmapper/DomainMapper.hxx
index 086e7f695db2..e76014737cf3 100644
--- a/writerfilter/source/dmapper/DomainMapper.hxx
+++ b/writerfilter/source/dmapper/DomainMapper.hxx
@@ -133,6 +133,9 @@ public:
virtual void commentProps(const OUString& sId, const CommentProperties&
rProps) override;
+css::uno::Reference const &
GetCharacterStyles();
+OUString GetUnusedCharacterStyleName();
+
private:
// Stream
virtual void lcl_startSectionGroup() override;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 7b2903f9f4b2..e02549daf430 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -442,6 +442,43 @@ OUString DomainMapper_Impl::GetUnusedPageStyleName()
return sPageStyleName;
}
+uno::Reference< container::XNameContainer > const &
DomainMapper_Impl::GetCharacterStyles()
+{
+if(!m_xCharacterStyles.is())
+{
+uno::Reference< style::XStyleFamiliesSupplier > xSupplier(
m_xTextDocument, uno::UNO_QUERY );
+if (xSupplier.is())
+xSupplier->getStyleFamilies()->getByName("CharacterStyles") >>=
m_xCharacterStyles;
+}
+return m_xCharacterStyles;
+}
+
+OUString DomainMapper_Impl::GetUnusedCharacterStyleName()
+{
+static const char cListLabel[] = "ListLabel ";
+if (!m_xNextUnusedCharacterStyleNo)
+{
+//search for all character styles with the name sListLabel +
+const uno::Sequence< OUString > aCharacterStyleNames =
GetCharacterStyles()->getElementNames();
+sal_Int32 nMaxIndex = 0;
+for ( const auto& rStyleName : aCharacterStyleNames )
+{
+OUString sSuffix;
+if ( rStyleName.startsWith( cListLabel, ) )
+{
+sal_Int32 nSuffix = sSuffix.toInt32();
+if( nSuffix > 0 && nSuffix > nMaxIndex )
+nMaxIndex = nSuffix;
+}
+}
+m_xNextUnusedCharacterStyleNo = nMaxIndex + 1;
+}
+
+OUString sPageStyleName = cListLabel + OUString::number(
*m_xNextUnusedCharacterStyleNo );
+*m_xNextUnusedCharacterStyleNo = *m_xNextUnusedCharacterStyleNo + 1;
+return sPageStyleName;
+}
+
uno::Reference< text::XText > const & DomainMapper_Impl::GetBodyText()
{
if(!m_xBodyText.is())
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 99d266968c72..5212653dcd47 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -458,6 +458,9 @@ private:
css::uno::Reference m_xPageStyles1;
// cache next available number, expensive to repeatedly compute
std::optional m_xNextUnusedPageStyleNo;
+
[Libreoffice-bugs] [Bug 142729] [META] Text box's column bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=142729 Bug 142729 depends on bug 142839, which changed state. Bug 142839 Summary: Impress: Bullet mode has lost while typing and text is not visible. https://bugs.documentfoundation.org/show_bug.cgi?id=142839 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit2.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 59611f7b6acbf643bde0e0121ee51e2df53e7d50
Author: Mike Kaganski
AuthorDate: Thu Jun 17 17:22:36 2021 +0300
Commit: Mike Kaganski
CommitDate: Thu Jun 17 20:31:03 2021 +0200
tdf#142839: do not forget to initialize *pHeightNTP
Regression after commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5
Change-Id: Iaa8f67e0c7e3d99b057294717d24ffac4ad3534c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117389
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 14685e7e1314..4bc8a570b9c3 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -3410,6 +3410,8 @@ sal_uInt32 ImpEditEngine::GetTextHeightNTP() const
tools::Long ImpEditEngine::Calc1ColumnTextHeight(tools::Long* pHeightNTP)
{
tools::Long nHeight = 0;
+if (pHeightNTP)
+*pHeightNTP = 0;
// Pretend that we have ~infinite height to get total height
comphelper::ValueRestorationGuard aGuard(nCurTextHeight,
std::numeric_limits::max());
@@ -3440,6 +3442,8 @@ tools::Long ImpEditEngine::CalcTextHeight(tools::Long*
pHeightNTP)
tools::Long nTentativeColHeight = mnMinColumnWrapHeight;
tools::Long nWantedIncrease = 0;
tools::Long nCurrentTextHeight;
+if (pHeightNTP)
+*pHeightNTP = 0;
// This does the necessary column balancing for the case when the text
does not fit min height.
// When the height of column (taken from nCurTextHeight) is too small, the
last column will
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142888] UI - View menu - the same hotkeys for two items ("Toolbars" and "Show Tracked Changes")
https://bugs.documentfoundation.org/show_bug.cgi?id=142888 --- Comment #13 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, 1) with gen or kf5 rendering Alt-V opens View menu typing T opens "Toolbars" submenu (so with the pb already described) If close the submenu and menu and try again, I got the same. 2) with gtk3 rendering Alt-V opens View menu typing T opens "Show Tracked Changes" If I close the submenu and menu and try again, I got this time "Toolbars" If I close the submenu and menu and try again, I got this time "Show Tracked Changes" and so on. Interestingly, with gtk3, when LO "chooses" "Toolbars", it doesn't open submenu and so we can type again "T" to select "Show Tracked Changes" For the rest, I can't tell. Knowing that even if we solve the pb for en-US, each language can have this pb too since we must choose a letter present in the translated command ; I wonder how MsOffice deals with this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90401] Allow resetting or removing personal information (author, date/time) on comments and changes
https://bugs.documentfoundation.org/show_bug.cgi?id=90401 --- Comment #15 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/658e947b699ad1e08810f0fefd5c901e750ad919 tdf#90401 xmloff: remove personal info of comments and changes It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90401] Allow resetting or removing personal information (author, date/time) on comments and changes
https://bugs.documentfoundation.org/show_bug.cgi?id=90401 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 ||target:7.2.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - include/unotools include/xmloff sw/qa unotools/source xmloff/source
include/unotools/securityoptions.hxx | 12 +++
include/xmloff/xmlexp.hxx |6 +
sw/qa/uitest/data/redline-autocorrect.fodt | 24 ++
sw/qa/uitest/writer_tests7/tdf90401.py | 103 +
unotools/source/config/securityoptions.cxx | 14 +++
xmloff/source/core/xmlexp.cxx |3
xmloff/source/draw/sdxmlexp.cxx| 16 +++-
xmloff/source/text/XMLRedlineExport.cxx| 24 +-
xmloff/source/text/txtflde.cxx | 13 +++
9 files changed, 205 insertions(+), 10 deletions(-)
New commits:
commit 658e947b699ad1e08810f0fefd5c901e750ad919
Author: László Németh
AuthorDate: Mon Jun 14 20:46:17 2021 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Jun 17 19:46:23 2021 +0200
tdf#90401 xmloff: remove personal info of comments and changes
If Options → LibreOffice → Security → Security Options
and Warnings → Options... → Security Options → Remove personal
information on saving" is enabled.
Use the same time (1970-01-01T00:00:00) for mandatory
time stamps, and replace authors and creator-initials with
"1", "2", "3" etc., also to avoid of joining adjacent
redline ranges.
Note: to see the work of the unit test in Linux command line:
(cd sw && make UITest_writer_tests7
UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info"
SAL_USE_VCLPLUGIN=gen)
Change-Id: I3b4d710db12177aff378597cd2b683ca6c25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319
Tested-by: Jenkins
Reviewed-by: László Németh
(cherry picked from commit 12da70f88517bf3c053afe1c504bb70bd27573f2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117301
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/include/unotools/securityoptions.hxx
b/include/unotools/securityoptions.hxx
index 7a339a90bcf8..944e6fba5a34 100644
--- a/include/unotools/securityoptions.hxx
+++ b/include/unotools/securityoptions.hxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
namespace osl { class Mutex; }
@@ -184,6 +185,17 @@ class SAL_WARN_UNUSED UNOTOOLS_DLLPUBLIC
SvtSecurityOptions final : public utl::
}; // class SvtSecurityOptions
+// map personal info strings, e.g. authors to 1, 2, 3... for removing personal
info
+typedef ::std::unordered_map< OUString, size_t >
SvtSecurityMapPersonalInfoType;
+
+class UNOTOOLS_DLLPUBLIC SvtSecurityMapPersonalInfo final
+{
+SvtSecurityMapPersonalInfoType aInfoIDs;
+
+public:
+size_t GetInfoID( const OUString sPersonalInfo );
+};
+
#endif // INCLUDED_UNOTOOLS_SECURITYOPTIONS_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx
index adba9e653077..5b72788313ef 100644
--- a/include/xmloff/xmlexp.hxx
+++ b/include/xmloff/xmlexp.hxx
@@ -43,6 +43,7 @@
#include
#include
+#include
#include
#include
@@ -69,6 +70,7 @@ namespace com::sun::star::xml::sax { class
XExtendedDocumentHandler; }
namespace com::sun::star::xml::sax { class XLocator; }
class SvXMLNamespaceMap;
+class SvtSecurityMapPersonalInfo;
class SvXMLExport_Impl;
class ProgressBarHelper;
class XMLEventExport;
@@ -135,6 +137,7 @@ class XMLOFF_DLLPUBLIC SvXMLExport : public
cppu::WeakImplHelper<
OUString msFilterName;
OUString msImgFilterName;
std::unique_ptr mpNamespaceMap;// the namespace map
+std::unique_ptr mpAuthorIDs; // map authors to
remove personal info
SvXMLUnitConverter maUnitConv;// the unit converter
std::unique_ptr mpNumExport;
std::unique_ptr mpProgressBarHelper;
@@ -390,6 +393,9 @@ public:
// Get (const) namespace map.
const SvXMLNamespaceMap& GetNamespaceMap() const { return *mpNamespaceMap;
}
+// Get author id to remove personal info
+size_t GetInfoID( const OUString sPersonalInfo ) const { return
mpAuthorIDs->GetInfoID(sPersonalInfo); }
+
// Get unit converter
const SvXMLUnitConverter& GetMM100UnitConverter() const { return
maUnitConv; }
diff --git a/sw/qa/uitest/data/redline-autocorrect.fodt
b/sw/qa/uitest/data/redline-autocorrect.fodt
new file mode 100644
index ..ce874d299a8f
--- /dev/null
+++ b/sw/qa/uitest/data/redline-autocorrect.fodt
@@ -0,0 +1,24 @@
+
+http://openoffice.org/2009/office; office:version="1.2"
office:mimetype="application/vnd.oasis.opendocument.text"
xmlns:dc="http://purl.org/dc/elements/1.1/;>
+
+
+
+
+
+
+
+
+
+
+
+
+ NL
+ 2020-11-03T19:19:05
+
+
+
+
+ ts
+
+
+
diff --git a/sw/qa/uitest/writer_tests7/tdf90401.py
b/sw/qa/uitest/writer_tests7/tdf90401.py
new file mode 100644
index ..7260ae914268
--- /dev/null
+++ b/sw/qa/uitest/writer_tests7/tdf90401.py
@@ -0,0 +1,103 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the
[Libreoffice-bugs] [Bug 142885] FILESAVE: Cursor jumps to beginning of "File name" field in "Save As" dialog box after selecting text with mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=142885 --- Comment #2 from pidkam...@gmail.com --- Hi there, sorry for not being clear. The expected behavior is: 1) Use mouse cursor to select some text in the "Save as:" field 2) User begins typing 3) Selected text is deleted and replaced by text entry The unwanted behavior I am experiencing is: 1) Use mouse cursor to select some text in the "Save as:" field 2) User begins typing 3) Text is de-selected and typed entry is inserted at the beginning of "Save as:" field, before the existing text in the field. Does that help clarify? Thank you! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142917] FileExists returns False for hidden files.
https://bugs.documentfoundation.org/show_bug.cgi?id=142917
--- Comment #2 from Andreas Säger ---
Indeed, it works with a regular dummy file URL file:///tmp/test/.foo and I must
have made some mistake when testing that URL.
However, my original intention was this:
print fileExists("file:///tmp/test/.~lock.test.ods#")
which detects a lock file for /tmp/test/test,ods when used with AOO but not LO.
print fileExists("/tmp/test/.~lock.test.ods#") works with LO too. So it has
something to do with URL notation vs system notation.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142909] How to switch off the Filter Navigator in LO Base
https://bugs.documentfoundation.org/show_bug.cgi?id=142909 --- Comment #3 from Robert Großkopf --- The only possibility is to set the width and the height of the dialog in LO. Here, on Linux with KDE, I could set special features (like the position for opening a dialog) by clicking with right mousebutton on the title bar of the dialog. It isn't implemented in LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/inc sfx2/source
sfx2/inc/recentdocsview.hxx|4 +++-
sfx2/source/control/recentdocsview.cxx |8 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 2176084192dc46a1ef5d6dd79effa5cd5d1dcca2
Author: Noel Grandin
AuthorDate: Thu Jun 17 13:38:07 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 17 19:07:17 2021 +0200
fix potential write-after-free in RecentDocsView
spotted while running a valgrind session
Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/inc/recentdocsview.hxx b/sfx2/inc/recentdocsview.hxx
index 77c350d40b83..b87a0cce679c 100644
--- a/sfx2/inc/recentdocsview.hxx
+++ b/sfx2/inc/recentdocsview.hxx
@@ -17,6 +17,7 @@
#include
#include
+struct ImplSVEvent;
namespace com::sun::star::frame { class XDispatch; }
namespace sfx2
@@ -92,7 +93,7 @@ private:
bool isAcceptedFile(const OUString ) const;
-DECL_STATIC_LINK( RecentDocsView, ExecuteHdl_Impl, void*, void );
+DECL_LINK( ExecuteHdl_Impl, void*, void );
tools::Long mnItemMaxSize;
size_t mnLastMouseDownItem;
@@ -103,6 +104,7 @@ private:
OUString maWelcomeLine2;
sfx2::LoadRecentFile* mpLoadRecentFile;
+ImplSVEvent* m_nExecuteHdlId;
};
} // namespace sfx2
diff --git a/sfx2/source/control/recentdocsview.cxx
b/sfx2/source/control/recentdocsview.cxx
index 137591a43991..0b01603d3914 100644
--- a/sfx2/source/control/recentdocsview.cxx
+++ b/sfx2/source/control/recentdocsview.cxx
@@ -130,6 +130,7 @@
RecentDocsView::RecentDocsView(std::unique_ptr xWindow, st
, maWelcomeLine1(SfxResId(STR_WELCOME_LINE1))
, maWelcomeLine2(SfxResId(STR_WELCOME_LINE2))
, mpLoadRecentFile(nullptr)
+, m_nExecuteHdlId(nullptr)
{
tools::Rectangle aScreen =
Application::GetScreenPosSizePixel(Application::GetDisplayBuiltInScreen());
mnItemMaxSize = std::min(aScreen.GetWidth(),aScreen.GetHeight()) > 800 ?
256 : 192;
@@ -148,6 +149,8 @@
RecentDocsView::RecentDocsView(std::unique_ptr xWindow, st
RecentDocsView::~RecentDocsView()
{
+Application::RemoveUserEvent(m_nExecuteHdlId);
+m_nExecuteHdlId = nullptr;
if (mpLoadRecentFile)
{
mpLoadRecentFile->pView = nullptr;
@@ -408,7 +411,7 @@ void RecentDocsView::PostLoadRecentUsedFile(LoadRecentFile*
pLoadRecentFile)
{
assert(!mpLoadRecentFile);
mpLoadRecentFile = pLoadRecentFile;
-Application::PostUserEvent(LINK(nullptr, RecentDocsView, ExecuteHdl_Impl),
pLoadRecentFile);
+m_nExecuteHdlId = Application::PostUserEvent(LINK(this, RecentDocsView,
ExecuteHdl_Impl), pLoadRecentFile);
}
void RecentDocsView::DispatchedLoadRecentUsedFile()
@@ -416,8 +419,9 @@ void RecentDocsView::DispatchedLoadRecentUsedFile()
mpLoadRecentFile = nullptr;
}
-IMPL_STATIC_LINK( RecentDocsView, ExecuteHdl_Impl, void*, p, void )
+IMPL_LINK( RecentDocsView, ExecuteHdl_Impl, void*, p, void )
{
+m_nExecuteHdlId = nullptr;
LoadRecentFile* pLoadRecentFile = static_cast(p);
try
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142921] New: Omitting spell check for a word should set its language as none
https://bugs.documentfoundation.org/show_bug.cgi?id=142921 Bug ID: 142921 Summary: Omitting spell check for a word should set its language as none Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: es204904...@gmail.com CC: so...@libreoffice.org Description: Because otherwise spellcheck omissions aren't preserved between sessions. Steps to Reproduce: 1. Launch the spelling corrector (F7) 2. Ignore some misspelled words 3. Save the document and exit 4. Repeat Actual Results: The words marked as ignored are again set as misspelled. Expected Results: Those words to be marked as not using any language, so the omission survives sessions. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Approved by John Wick -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
