[Libreoffice-bugs] [Bug 143142] Writer: Table properties under columns only shows max of 5 columns
https://bugs.documentfoundation.org/show_bug.cgi?id=143142 --- Comment #3 from Kieran Grant --- Workaround for now is to create a table with 1 extra column and set the sizes of all columns as you would like, with the size of the last column shared with the extra column. Then delete the extra column and the last column will resize to fill in the remaining space, resulting in desired size for all columns. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143142] Writer: Table properties under columns only shows max of 5 columns
https://bugs.documentfoundation.org/show_bug.cgi?id=143142 --- Comment #2 from Kieran Grant --- Testing seems to show it only happens if number of columns is 6. With 7 or more columns it works as expected. My guess is an off-by-one bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143142] Writer: Table properties under columns only shows max of 5 columns
https://bugs.documentfoundation.org/show_bug.cgi?id=143142 --- Comment #1 from Kieran Grant --- Created attachment 173299 --> https://bugs.documentfoundation.org/attachment.cgi?id=173299=edit Screenshot showing limit of only 5 columns resizeable with 6 columns visible in table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143142] New: Writer: Table properties under columns only shows max of 5 columns
https://bugs.documentfoundation.org/show_bug.cgi?id=143142 Bug ID: 143142 Summary: Writer: Table properties under columns only shows max of 5 columns Product: LibreOffice Version: 7.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kierangr...@linux.com Description: When trying to edit the column sizes of a table in writer, only 5 column sizes are visible, right arrow to show more is disabled. Steps to Reproduce: 1. Create new document in writer. 2. Press Ctrl-F12 to add new table or Go to Table and Insert Table 3. Set number of columns to 6 4. Add table. 5. Right-click table and select columns. 6. Only 5 columns visible. Actual Results: Can only change size of first 5 columns Expected Results: Allow to change all column sizes Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.1.4.2 / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47628] VIEWING no background color on protected sheet with enabled 'Value Highlighting'
https://bugs.documentfoundation.org/show_bug.cgi?id=47628 --- Comment #14 from tomber --- Technology becomes part of our life. Most people are interested to know the details of the latest updates. Here you can check this https://cracko.org for more details about the updates. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142595] Impress: Custom slide show doesn't run for a first time
https://bugs.documentfoundation.org/show_bug.cgi?id=142595 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142887] EXPORT HTML: exported shape (gif) is slightly cropped on the bottom and right side (round becomes flat)
https://bugs.documentfoundation.org/show_bug.cgi?id=142887 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142617] FILEOPEN PPTX First line indent and hanging indent incorrectly imported in bulleted paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=142617 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142090] Font antialiasing in libreoffice does not work under wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=142090 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142090] Font antialiasing in libreoffice does not work under wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=142090 --- Comment #10 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138269] Freezes on the screen
https://bugs.documentfoundation.org/show_bug.cgi?id=138269 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138269] Freezes on the screen
https://bugs.documentfoundation.org/show_bug.cgi?id=138269 --- Comment #3 from QA Administrators --- Dear fxgwendo, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138207] Crash in: sclo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138207 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138207] Crash in: sclo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=138207 --- Comment #4 from QA Administrators --- Dear jnifong25, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 135718, which changed state. Bug 135718 Summary: LOOKUP function stopped working https://bugs.documentfoundation.org/show_bug.cgi?id=135718 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135718] LOOKUP function stopped working
https://bugs.documentfoundation.org/show_bug.cgi?id=135718 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135718] LOOKUP function stopped working
https://bugs.documentfoundation.org/show_bug.cgi?id=135718 --- Comment #6 from QA Administrators --- Dear lkp1957, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132573] PARAGRAPH STYLES: Writer process sleeping, won't save or exit
https://bugs.documentfoundation.org/show_bug.cgi?id=132573 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107833] [META] Writer paragraph style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107833 Bug 107833 depends on bug 132573, which changed state. Bug 132573 Summary: PARAGRAPH STYLES: Writer process sleeping, won't save or exit https://bugs.documentfoundation.org/show_bug.cgi?id=132573 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132573] PARAGRAPH STYLES: Writer process sleeping, won't save or exit
https://bugs.documentfoundation.org/show_bug.cgi?id=132573 --- Comment #6 from QA Administrators --- Dear Luke Kendall, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96176] DRAW: Slow performance zooming an SVG after opening
https://bugs.documentfoundation.org/show_bug.cgi?id=96176 --- Comment #15 from QA Administrators --- Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95150] Border of tablecontrol doesn't show color
https://bugs.documentfoundation.org/show_bug.cgi?id=95150 --- Comment #10 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65200] FORMATTING: Autofit width not behave properly if cell(s) contain text wrapping
https://bugs.documentfoundation.org/show_bug.cgi?id=65200 --- Comment #10 from QA Administrators --- Dear ign_christian, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108372] Inserting references using Zotero and Writer results in single line spacing
https://bugs.documentfoundation.org/show_bug.cgi?id=108372 --- Comment #5 from QA Administrators --- Dear Andreas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107913] Text animation order wrong for hyperlinked text
https://bugs.documentfoundation.org/show_bug.cgi?id=107913 --- Comment #7 from QA Administrators --- Dear Timur, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/themesupport2' - 504 commits - accessibility/inc accessibility/source avmedia/source basctl/source basegfx/CppunitTest_basegfx.mk basegfx/source basegfx
Rebased ref, commits from common ancestor:
commit 6546856703cf1cec4493e8c357fa89fa7f53f8ca
Author: Jan Holesovsky
AuthorDate: Fri Apr 2 00:21:34 2021 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jul 1 09:53:47 2021 +0900
Unit test (with the content disabled so far) for the theming.
Change-Id: Ie9e003df38e1bc766fb5323936138d3e0e664321
diff --git a/sw/qa/extras/ooxmlexport/data/themeOrange.docx
b/sw/qa/extras/ooxmlexport/data/themeOrange.docx
new file mode 100644
index ..e350c2676d41
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/themeOrange.docx
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
index bafe3b511730..f29b156d171e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
@@ -587,6 +587,12 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(Test_ShadowDirection,
"tdf142361ShadowDirect
"rotWithShape", "0");
}
+DECLARE_OOXMLEXPORT_TEST(testThemeOrange, "themeOrange.docx")
+{
+// Assert that the theme color of the 1st paragraph is "accent1"
+//CPPUNIT_ASSERT_EQUAL(getProperty(getParagraph(1),
"CharColorTheme"), static_cast(4));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit f02d56dca274961ad9ecc6b1eaeb2acc4dea25b3
Author: Tomaž Vajngerl
AuthorDate: Wed Sep 23 13:38:38 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jul 1 09:53:30 2021 +0900
adjust the conversion from theme color type to the color set index
Change-Id: I8c54c8935de8acc3e2b302e10327aa2488f9ac85
diff --git a/writerfilter/source/dmapper/TDefTableHandler.cxx
b/writerfilter/source/dmapper/TDefTableHandler.cxx
index 42ab0d61bd83..4bc8faf7e3d5 100644
--- a/writerfilter/source/dmapper/TDefTableHandler.cxx
+++ b/writerfilter/source/dmapper/TDefTableHandler.cxx
@@ -298,15 +298,15 @@ sal_Int16
TDefTableHandler::getThemeColorTypeIndex(sal_Int32 nType)
case NS_ooxml::LN_Value_St_ThemeColor_followedHyperlink:
return 11;
case NS_ooxml::LN_Value_St_ThemeColor_none:
-return 12;
+return -1;
case NS_ooxml::LN_Value_St_ThemeColor_background1:
-return 13;
+return 0;
case NS_ooxml::LN_Value_St_ThemeColor_text1:
-return 14;
+return 1;
case NS_ooxml::LN_Value_St_ThemeColor_background2:
-return 15;
+return 2;
case NS_ooxml::LN_Value_St_ThemeColor_text2:
-return 16;
+return 3;
default:
break;
}
commit d480eea0e754d0849ff59b391bd37abf043d47cc
Author: Tomaž Vajngerl
AuthorDate: Wed Sep 23 13:37:43 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jul 1 09:53:29 2021 +0900
convert tint value from ooxml to the value we support
Change-Id: I5a79ca434be16f9dccc5aa6118a7efbf4544f0b1
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index a28e3dae2838..8ba4881c4e13 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -999,7 +999,7 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
case NS_ooxml::LN_CT_Color_themeTint:
if (m_pImpl->GetTopContext())
{
-
m_pImpl->GetTopContext()->Insert(PROP_CHAR_COLOR_TINT_OR_SHADE,
uno::makeAny(sal_Int16(nIntValue * 1 / 256)));
+
m_pImpl->GetTopContext()->Insert(PROP_CHAR_COLOR_TINT_OR_SHADE,
uno::makeAny(sal_Int16((256 - nIntValue) * 1 / 256)));
}
m_pImpl->appendGrabBag(m_pImpl->m_aSubInteropGrabBag, "themeTint",
OUString::number(nIntValue, 16));
break;
commit 4e553ab0e53feb30e17048da065921ad9cb78054
Author: Tomaž Vajngerl
AuthorDate: Wed Sep 23 13:35:56 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jul 1 09:53:29 2021 +0900
check that the color index is valid
Change-Id: Id5c7c83f50e1611af12f3b25e6c9a335a8353ba0
diff --git a/sw/source/uibase/sidebar/ThemePanel.cxx
b/sw/source/uibase/sidebar/ThemePanel.cxx
index 9117f20a7013..ce42983879ce 100644
--- a/sw/source/uibase/sidebar/ThemePanel.cxx
+++ b/sw/source/uibase/sidebar/ThemePanel.cxx
@@ -232,9 +232,9 @@ void changeFont(SwFormat* pFormat, SwDocStyleSheet const *
pStyle, FontSet const
void changeColor(SwTextFormatColl* pCollection, svx::ColorSet const&
rColorSet, StyleRedefinition* /*pRedefinition*/)
{
SvxColorItem aColorItem(pCollection->GetColor());
-if (aColorItem.GetThemeIndex() >= 0)
+sal_Int16 nIndex = aColorItem.GetThemeIndex();
+if (nIndex >= 0 && nIndex < 12)
{
-sal_Int16 nIndex = aColorItem.GetThemeIndex();
Color aColor = Color(rColorSet.getColor(nIndex));
aColor.ApplyTintOrShade(aColorItem.GetTintOrShade());
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/sidebar/ThemePanel.cxx | 34
1 file changed, 30 insertions(+), 4 deletions(-)
New commits:
commit 4f42bcc9dc825cf50a40a00bb992137b6b8906b6
Author: Tomaž Vajngerl
AuthorDate: Thu Sep 24 12:32:14 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jul 1 02:50:48 2021 +0200
Improve preview of theme color sets - add color set name
Change-Id: I1f7b3668ba9dfbab1da283741e99754de2d6be47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118151
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sw/source/uibase/sidebar/ThemePanel.cxx
b/sw/source/uibase/sidebar/ThemePanel.cxx
index 3ff74fcdb016..68c24eb08571 100644
--- a/sw/source/uibase/sidebar/ThemePanel.cxx
+++ b/sw/source/uibase/sidebar/ThemePanel.cxx
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -367,17 +368,39 @@ BitmapEx GenerateColorPreview(const svx::ColorSet&
rColorSet)
{
ScopedVclPtrInstance
pVirtualDev(*Application::GetDefaultDevice());
float fScaleFactor = pVirtualDev->GetDPIScaleFactor();
-tools::Long BORDER = 2 * fScaleFactor;
-tools::Long SIZE = 12 * fScaleFactor;
+tools::Long BORDER = 3 * fScaleFactor;
+tools::Long SIZE = 14 * fScaleFactor;
+tools::Long LABEL_HEIGHT = 16 * fScaleFactor;
+tools::Long LABEL_TEXT_HEIGHT = 14 * fScaleFactor;
-Size aSize(BORDER * 7 + SIZE * 6, BORDER * 3 + SIZE * 2);
+Size aSize(BORDER * 7 + SIZE * 6 + BORDER * 2, BORDER * 3 + SIZE * 2 +
LABEL_HEIGHT);
pVirtualDev->SetOutputSizePixel(aSize);
+
pVirtualDev->SetBackground(Wallpaper(Application::GetSettings().GetStyleSettings().GetFaceColor()));
+pVirtualDev->Erase();
tools::Long x = BORDER;
-tools::Long y1 = BORDER;
+tools::Long y1 = BORDER + LABEL_HEIGHT;
tools::Long y2 = y1 + SIZE + BORDER;
pVirtualDev->SetLineColor(COL_LIGHTGRAY);
+pVirtualDev->SetFillColor(COL_LIGHTGRAY);
+tools::Rectangle aNameRect(Point(0, 0), Size(aSize.Width(), LABEL_HEIGHT));
+pVirtualDev->DrawRect(aNameRect);
+
+vcl::Font aFont;
+OUString aName = rColorSet.getName();
+aFont.SetFontHeight(LABEL_TEXT_HEIGHT);
+pVirtualDev->SetFont(aFont);
+
+Size aTextSize(pVirtualDev->GetTextWidth(aName),
pVirtualDev->GetTextHeight());
+
+Point aPoint((aNameRect.GetWidth() / 2.0) - (aTextSize.Width() / 2.0),
+ (aNameRect.GetHeight() / 2.0) - (aTextSize.Height() / 2.0));
+
+pVirtualDev->DrawText(aPoint, aName);
+
+pVirtualDev->SetLineColor(COL_LIGHTGRAY);
+pVirtualDev->SetFillColor();
for (sal_uInt32 i = 0; i < 12; i += 2)
{
@@ -388,6 +411,8 @@ BitmapEx GenerateColorPreview(const svx::ColorSet&
rColorSet)
pVirtualDev->DrawRect(tools::Rectangle(x, y2, x + SIZE, y2 + SIZE));
x += SIZE + BORDER;
+if (i == 2 || i == 8)
+x += BORDER;
}
return pVirtualDev->GetBitmapEx(Point(), aSize);
@@ -415,6 +440,7 @@ ThemePanel::ThemePanel(weld::Widget* pParent)
{
mxValueSetColors->SetColCount(2);
mxValueSetColors->SetLineCount(3);
+
mxValueSetColors->SetColor(Application::GetSettings().GetStyleSettings().GetFaceColor());
mxApplyButton->connect_clicked(LINK(this, ThemePanel, ClickHdl));
mxListBoxFonts->connect_row_activated(LINK(this, ThemePanel,
DoubleClickHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143076] [EMF+] StringFormat Lead/Trail margins and StringAlign Center
https://bugs.documentfoundation.org/show_bug.cgi?id=143076 Bartosz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142997] [EMF+] stringAlignmentHorizontalOffset is incorrect for StringFormat StringAlign set to 'center' or 'far'
https://bugs.documentfoundation.org/show_bug.cgi?id=142997 Bartosz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | Status|NEW |ASSIGNED CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/qa chart2/source sc/inc sc/source
basic/qa/cppunit/test_scanner.cxx |6 +--
chart2/source/view/axes/MinimumAndMaximumSupplier.cxx | 21 +++
chart2/source/view/axes/VCoordinateSystem.cxx |9 ++--
chart2/source/view/charttypes/Splines.cxx | 15 +++-
chart2/source/view/charttypes/VSeriesPlotter.cxx | 33 --
chart2/source/view/main/VDataSeries.cxx |7 +--
sc/inc/math.hxx | 12 +-
sc/source/core/data/dpitemdata.cxx|4 +-
sc/source/core/data/dputil.cxx| 10 +
9 files changed, 43 insertions(+), 74 deletions(-)
New commits:
commit 3964e0854507b2696ae0fbe48a4fb005c779947e
Author: BaiXiaochun
AuthorDate: Tue Jun 29 20:31:30 2021 +0200
Commit: Mike Kaganski
CommitDate: Thu Jul 1 00:39:17 2021 +0200
Purge out rtl::math::setInf
Change-Id: I71af8273c672a4cbcbfefafffd0003ab266dcce6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118132
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/basic/qa/cppunit/test_scanner.cxx
b/basic/qa/cppunit/test_scanner.cxx
index 5663c44d027e..6459ab45f6b1 100644
--- a/basic/qa/cppunit/test_scanner.cxx
+++ b/basic/qa/cppunit/test_scanner.cxx
@@ -13,7 +13,7 @@
#include
#include
-#include
+#include
#include
@@ -654,11 +654,9 @@ void ScannerTest::testNumbers()
// the buffer is artificially constrained by the scanner.
CPPUNIT_ASSERT_EQUAL(1u, static_cast(errors)); // HACK
-double fInf = 0.0;
-rtl::math::setInf(, false);
symbols = getSymbols("10e308", errors);
CPPUNIT_ASSERT_EQUAL(size_t(2), symbols.size());
-CPPUNIT_ASSERT_EQUAL(fInf, symbols[0].number);
+CPPUNIT_ASSERT_EQUAL(std::numeric_limits::infinity(),
symbols[0].number);
CPPUNIT_ASSERT_EQUAL(SbxDOUBLE, symbols[0].type);
CPPUNIT_ASSERT_EQUAL(cr, symbols[1].text);
CPPUNIT_ASSERT_EQUAL(1u, static_cast(errors)); // math
error, overflow
diff --git a/chart2/source/view/axes/MinimumAndMaximumSupplier.cxx
b/chart2/source/view/axes/MinimumAndMaximumSupplier.cxx
index 422d08e64029..eaf5c4347379 100644
--- a/chart2/source/view/axes/MinimumAndMaximumSupplier.cxx
+++ b/chart2/source/view/axes/MinimumAndMaximumSupplier.cxx
@@ -21,8 +21,7 @@
#include
-#include
-
+#include
#include
namespace chart
@@ -49,8 +48,7 @@ bool
MergedMinimumAndMaximumSupplier::hasMinimumAndMaximumSupplier( MinimumAndMa
double MergedMinimumAndMaximumSupplier::getMinimumX()
{
-double fGlobalExtremum;
-::rtl::math::setInf(, false);
+double fGlobalExtremum = std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum = elem->getMinimumX();
@@ -64,8 +62,7 @@ double MergedMinimumAndMaximumSupplier::getMinimumX()
double MergedMinimumAndMaximumSupplier::getMaximumX()
{
-double fGlobalExtremum;
-::rtl::math::setInf(, true);
+double fGlobalExtremum = -std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum = elem->getMaximumX();
@@ -79,8 +76,7 @@ double MergedMinimumAndMaximumSupplier::getMaximumX()
double MergedMinimumAndMaximumSupplier::getMinimumYInRange( double fMinimumX,
double fMaximumX, sal_Int32 nAxisIndex )
{
-double fGlobalExtremum;
-::rtl::math::setInf(, false);
+double fGlobalExtremum = std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum = elem->getMinimumYInRange( fMinimumX,
fMaximumX, nAxisIndex );
@@ -94,8 +90,7 @@ double MergedMinimumAndMaximumSupplier::getMinimumYInRange(
double fMinimumX, do
double MergedMinimumAndMaximumSupplier::getMaximumYInRange( double fMinimumX,
double fMaximumX, sal_Int32 nAxisIndex )
{
-double fGlobalExtremum;
-::rtl::math::setInf(, true);
+double fGlobalExtremum = -std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum = elem->getMaximumYInRange( fMinimumX,
fMaximumX, nAxisIndex );
@@ -109,8 +104,7 @@ double MergedMinimumAndMaximumSupplier::getMaximumYInRange(
double fMinimumX, do
double MergedMinimumAndMaximumSupplier::getMinimumZ()
{
-double fGlobalExtremum;
-::rtl::math::setInf(, false);
+double fGlobalExtremum = std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum = elem->getMinimumZ();
@@ -124,8 +118,7 @@ double MergedMinimumAndMaximumSupplier::getMinimumZ()
double MergedMinimumAndMaximumSupplier::getMaximumZ()
{
-double fGlobalExtremum;
-::rtl::math::setInf(, true);
+double fGlobalExtremum = -std::numeric_limits::infinity();
for (auto const& elem : m_aMinimumAndMaximumSupplierList)
{
double fLocalExtremum =
[Libreoffice-bugs] [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 --- Comment #3 from Mike Kaganski --- Please ignore the above spam comment by a person who doesn't understand that VBA compatibility functions are created for compatibility with, and must follow the specifications of, VBA. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142922] Basic: Round VBA compatibility function implements wrong rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=142922 --- Comment #2 from b. --- ... Σκύλλα και Χάρυβδις (Skylla and Charybdis) ... Excel round(x,n) in a sheet: '=round(0.12335,4)' -> 0.1234 '=round(0.12345,4)' -> 0.123*5* '=round(0.12355,4)' -> 0.1236 '=round(0.12365,4)' -> 0.123*7* Excel round(x,n) in VBA macros: '=round(0.12335,4)' -> 0.1234 '=round(0.12345,4)' -> 0.123*4* '=round(0.12355,4)' -> 0.1236 '=round(0.12365,4)' -> 0.123*6* in one! program and its associated macro language ... mentally healthy people might call things like this unhealthy, either we copy this ambiguity -> discrepancies between sheet and macro -> irritated users, or we do something with less internal contradictions -> compromises Excel compatibility -> irritated users, any idea for a third way? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143141] Zoom buttons in Calc print preview do the opposite of what they indicate they do
https://bugs.documentfoundation.org/show_bug.cgi?id=143141 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Works fine form me. Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3618d847a44bb485a3564c600d5005797934b9bb CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143081] Basic Replace() function crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=143081 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #24 from Julien Nabet --- I gave a try with https://bugs.documentfoundation.org/show_bug.cgi?id=143081 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/headless vcl/inc
vcl/headless/svpframe.cxx |3 ++-
vcl/inc/headless/svpframe.hxx | 20
2 files changed, 22 insertions(+), 1 deletion(-)
New commits:
commit 54d7fc9ea9d56ec16ec4f641a3dbf01f64233297
Author: Jan-Marek Glogowski
AuthorDate: Tue Jun 29 16:13:42 2021 +
Commit: Jan-Marek Glogowski
CommitDate: Wed Jun 30 22:34:41 2021 +0200
svp: add ostream<< for SvpSalFrame
... and also store the window title.
Change-Id: I20d8b30f6e8e5c48740fe569d9689a117db11e6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118129
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx
index ab82a90a4faa..c7a1d8f50845 100644
--- a/vcl/headless/svpframe.cxx
+++ b/vcl/headless/svpframe.cxx
@@ -187,8 +187,9 @@ void SvpSalFrame::PostPaint() const
}
}
-void SvpSalFrame::SetTitle( const OUString& )
+void SvpSalFrame::SetTitle(const OUString& sTitle)
{
+m_sTitle = sTitle;
}
void SvpSalFrame::SetIcon( sal_uInt16 )
diff --git a/vcl/inc/headless/svpframe.hxx b/vcl/inc/headless/svpframe.hxx
index 145ccf5b3655..4c6dd98e2ca9 100644
--- a/vcl/inc/headless/svpframe.hxx
+++ b/vcl/inc/headless/svpframe.hxx
@@ -54,6 +54,8 @@ class SvpSalFrame : public SalFrame
std::vector< SvpSalGraphics* > m_aGraphics;
static SvpSalFrame* s_pFocusFrame;
+OUString m_sTitle;
+
public:
SvpSalFrame( SvpSalInstance* pInstance,
SalFrame* pParent,
@@ -64,6 +66,11 @@ public:
void LoseFocus();
void PostPaint() const;
+OUString title() const { return m_sTitle; }
+SalFrameStyleFlags style() const { return m_nStyle; }
+bool isVisible() const { return m_bVisible; }
+bool hasFocus() const { return s_pFocusFrame == this; }
+
// SalFrame
virtual SalGraphics*AcquireGraphics() override;
virtual voidReleaseGraphics( SalGraphics* pGraphics )
override;
@@ -120,6 +127,19 @@ private:
basegfx::B2IVector GetSurfaceFrameSize() const;
};
+template
+inline std::basic_ostream& operator<<(std::basic_ostream& stream,
+ const SvpSalFrame& frame)
+{
+stream << << " (vis " << frame.isVisible() << " focus " <<
frame.hasFocus();
+stream << " style " << std::hex << std::setfill('0') << std::setw(8) <<
static_cast(frame.style());
+OUString sTitle = frame.title();
+if (!sTitle.isEmpty())
+stream << " '" << sTitle << "'";
+stream << ")";
+return stream;
+}
+
#endif // INCLUDED_VCL_INC_HEADLESS_SVPFRAME_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143081] Basic Replace() function crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=143081 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143081] Basic Replace() function crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=143081 --- Comment #23 from Julien Nabet --- Created attachment 173298 --> https://bugs.documentfoundation.org/attachment.cgi?id=173298=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assertion by following Jean-Pierre's example in comment 21. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70633] Writer EDITING: Some IME unable to use AltGr to produce supplementary plane chars
https://bugs.documentfoundation.org/show_bug.cgi?id=70633 --- Comment #25 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ce9e6972148c657994beb74f671e51bec5be6689 tdf#70633 unset Alt if detected as AltGr in both KeyInput branches It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/window/salframe.cxx | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
New commits:
commit ce9e6972148c657994beb74f671e51bec5be6689
Author: Caolán McNamara
AuthorDate: Wed Jun 30 15:58:57 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Jun 30 21:48:05 2021 +0200
tdf#70633 unset Alt if detected as AltGr in both KeyInput branches
we are unsetting Alt if the modifier is AltGr in one SalEvent::KeyInput
case but not in another. If I replicate the unset of Alt if AlrGr in
the other place then both UTF-16 parts of the codepoint get accepted
and the described input case works
Change-Id: Ifa8a5afbb1853ef3d5f388fd5e7bd3bbc048e260
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 8e4abcdbd66e..45361d8baef0 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -3353,6 +3353,16 @@ bool WinSalFrame::MapUnicodeToKeyCode( sal_Unicode
aUnicode, LanguageType aLangT
return bRet;
}
+static void UnsetAltIfAltGr(SalKeyEvent& rKeyEvt, sal_uInt16 nModCode)
+{
+if ((nModCode & (KEY_MOD1 | KEY_MOD2)) == (KEY_MOD1 | KEY_MOD2) &&
+rKeyEvt.mnCharCode)
+{
+// this is actually AltGr and should not be handled as Alt
+rKeyEvt.mnCode &= ~(KEY_MOD1 | KEY_MOD2);
+}
+}
+
static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
WPARAM wParam, LPARAM lParam, LRESULT& rResult )
{
@@ -3441,8 +3451,12 @@ static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
aKeyEvt.mnCode |= nModCode;
aKeyEvt.mnCharCode = ImplGetCharCode( pFrame, wParam );
aKeyEvt.mnRepeat= nRepeat;
+
+UnsetAltIfAltGr(aKeyEvt, nModCode);
+
nLastChar = 0;
nLastVKChar = 0;
+
bool nRet = pFrame->CallCallback( SalEvent::KeyInput, );
pFrame->CallCallback( SalEvent::KeyUp, );
return nRet;
@@ -3593,12 +3607,7 @@ static bool ImplHandleKeyMsg( HWND hWnd, UINT nMsg,
aKeyEvt.mnCode |= nModCode;
aKeyEvt.mnRepeat= nRepeat;
-if ((nModCode & (KEY_MOD1 | KEY_MOD2)) == (KEY_MOD1 |
KEY_MOD2) &&
-aKeyEvt.mnCharCode)
-{
-// this is actually AltGr and should not be handled as Alt
-aKeyEvt.mnCode &= ~(KEY_MOD1 | KEY_MOD2);
-}
+UnsetAltIfAltGr(aKeyEvt, nModCode);
bIgnoreCharMsg = bCharPeek;
bool nRet = pFrame->CallCallback( nEvent, );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 70633] Writer EDITING: Some IME unable to use AltGr to produce supplementary plane chars
https://bugs.documentfoundation.org/show_bug.cgi?id=70633 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkinst.hxx |2 +-
vcl/unx/gtk3/gtkframe.cxx | 16 +---
vcl/unx/gtk3/gtkinst.cxx|4 ++--
3 files changed, 12 insertions(+), 10 deletions(-)
New commits:
commit 86372bf5f62aea48cb3b68d30e81597a0dac9cc2
Author: Caolán McNamara
AuthorDate: Wed Jun 30 14:28:21 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Jun 30 21:46:02 2021 +0200
tdf#143113 fix crash in dnd
Change-Id: Ifab741494e4cc6e51ca4cd89b57c3600d80dca44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118163
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/unx/gtk/gtkinst.hxx b/vcl/inc/unx/gtk/gtkinst.hxx
index a293662791ae..5fb0b67b2b8f 100644
--- a/vcl/inc/unx/gtk/gtkinst.hxx
+++ b/vcl/inc/unx/gtk/gtkinst.hxx
@@ -176,7 +176,7 @@ public:
gboolean signalDragDrop(GtkDropTargetAsync *context, GdkDrop *drop, double
x, double y);
#endif
-void signalDragLeave();
+void signalDragLeave(GtkWidget* pWidget);
#if !GTK_CHECK_VERSION(4, 0, 0)
void signalDragDropReceived(GtkWidget* pWidget, GdkDragContext* context,
gint x, gint y, GtkSelectionData* data, guint ttype, guint time);
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 2b133e0868e3..b3647b6a8296 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -4643,10 +4643,12 @@ GdkDragAction
GtkInstDropTarget::signalDragMotion(GtkDropTargetAsync *context, G
{
if (!m_bInDrag)
{
-GtkWidget* pHighlightWidget =
GTK_WIDGET(m_pFrame->getFixedContainer());
#if !GTK_CHECK_VERSION(4,0,0)
+GtkWidget* pHighlightWidget = m_pFrame ?
GTK_WIDGET(m_pFrame->getFixedContainer()) : pWidget;
gtk_drag_highlight(pHighlightWidget);
#else
+GtkWidget* pHighlightWidget = m_pFrame ?
GTK_WIDGET(m_pFrame->getFixedContainer()) :
+gtk_event_controller_get_widget(GTK_EVENT_CONTROLLER(context));
gtk_widget_set_state_flags(pHighlightWidget,
GTK_STATE_FLAG_DROP_ACTIVE, false);
#endif
}
@@ -4744,20 +4746,20 @@ GdkDragAction
GtkInstDropTarget::signalDragMotion(GtkDropTargetAsync *context, G
}
#if GTK_CHECK_VERSION(4,0,0)
-void GtkSalFrame::signalDragLeave(GtkDropTargetAsync* /*dest*/, GdkDrop*
/*drop*/, gpointer frame)
+void GtkSalFrame::signalDragLeave(GtkDropTargetAsync* pDest, GdkDrop*
/*drop*/, gpointer frame)
{
GtkSalFrame* pThis = static_cast(frame);
if (!pThis->m_pDropTarget)
return;
-pThis->m_pDropTarget->signalDragLeave();
+
pThis->m_pDropTarget->signalDragLeave(gtk_event_controller_get_widget(GTK_EVENT_CONTROLLER(pDest)));
}
#else
-void GtkSalFrame::signalDragLeave(GtkWidget*, GdkDragContext* /*context*/,
guint /*time*/, gpointer frame)
+void GtkSalFrame::signalDragLeave(GtkWidget* pWidget, GdkDragContext*
/*context*/, guint /*time*/, gpointer frame)
{
GtkSalFrame* pThis = static_cast(frame);
if (!pThis->m_pDropTarget)
return;
-pThis->m_pDropTarget->signalDragLeave();
+pThis->m_pDropTarget->signalDragLeave(pWidget);
}
#endif
@@ -4770,11 +4772,11 @@ static gboolean lcl_deferred_dragExit(gpointer
user_data)
return false;
}
-void GtkInstDropTarget::signalDragLeave()
+void GtkInstDropTarget::signalDragLeave(GtkWidget *pWidget)
{
m_bInDrag = false;
-GtkWidget* pHighlightWidget = GTK_WIDGET(m_pFrame->getFixedContainer());
+GtkWidget* pHighlightWidget = m_pFrame ?
GTK_WIDGET(m_pFrame->getFixedContainer()) : pWidget;
#if !GTK_CHECK_VERSION(4,0,0)
gtk_drag_unhighlight(pHighlightWidget);
#else
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 0a0cb24724d7..80e2fc7983a5 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3077,10 +3077,10 @@ private:
}
#if !GTK_CHECK_VERSION(4, 0, 0)
-static void signalDragLeave(GtkWidget*, GdkDragContext*, guint /*time*/,
gpointer widget)
+static void signalDragLeave(GtkWidget* pWidget, GdkDragContext*, guint
/*time*/, gpointer widget)
{
GtkInstanceWidget* pThis = static_cast(widget);
-pThis->m_xDropTarget->signalDragLeave();
+pThis->m_xDropTarget->signalDragLeave(pWidget);
if (pThis->m_bDraggedOver)
{
pThis->m_bDraggedOver = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source sd/qa
filter/source/graphicfilter/icgm/class4.cxx |7 ++-
sd/qa/unit/data/cgm/fail/ofz35504-ubsan-1.cgm |binary
2 files changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 5e865370530a71eb966d2fbfc2fdfffc34d2e1b9
Author: Caolán McNamara
AuthorDate: Tue Jun 29 21:27:18 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Jun 30 21:45:35 2021 +0200
ofz#35504 clamp input values in cgm filter
Change-Id: I96712b8dc8f8eaad3fb8fa6710d0f07fff61b592
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118137
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/filter/source/graphicfilter/icgm/class4.cxx
b/filter/source/graphicfilter/icgm/class4.cxx
index 0a498426b3bc..697a466793bc 100644
--- a/filter/source/graphicfilter/icgm/class4.cxx
+++ b/filter/source/graphicfilter/icgm/class4.cxx
@@ -109,7 +109,12 @@ bool CGM::ImplGetEllipse( FloatPoint& rCenter, FloatPoint&
rRadius, double& rAng
static bool useless(double value)
{
-return std::isnan(value) || std::isinf(value);
+if (!std::isfinite(value))
+return true;
+int exp;
+std::frexp(value, );
+const int maxbits = sizeof(tools::Long) * 8;
+return exp > maxbits;
}
void CGM::ImplDoClass4()
diff --git a/sd/qa/unit/data/cgm/fail/ofz35504-ubsan-1.cgm
b/sd/qa/unit/data/cgm/fail/ofz35504-ubsan-1.cgm
new file mode 100644
index ..07aa3db00776
Binary files /dev/null and b/sd/qa/unit/data/cgm/fail/ofz35504-ubsan-1.cgm
differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143141] New: Zoom buttons in Calc print preview do the opposite of what they indicate they do
https://bugs.documentfoundation.org/show_bug.cgi?id=143141 Bug ID: 143141 Summary: Zoom buttons in Calc print preview do the opposite of what they indicate they do Product: LibreOffice Version: 7.1.3.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: winghongc...@vivaldi.net Description: The "Zoom Out" and "Zoom In" buttons in the toolbar that appears while using the Print Preview in LibreOffice Calc do the opposite of what their icon and tooltip indicate. So, clicking on "Zoom Out" enlarges the preview, and clicking on "Zoom In" makes the preview smaller. As a workaround I changed the icons to reflect what the buttons do, but renaming the commands did not change the button's tooltips. So, after customizing the toolbar, the icons were correct but the tooltips were not (which can be more confusing). Steps to Reproduce: 1. Open a spreadsheet using LibreOffice, or make a new one and put in some data. 2. Go to the Print Preview (using any obvious method, for example, File → Print Preview) 3. Press the Zoom Out / Zoom In buttons in the Print Preview toolbar. Actual Results: Pressing "Zoom Out" enlarges the preview (so, zooming in). Pressing "Zoom In" makes the preview smaller (so, zooming out). Expected Results: Pressing "Zoom Out" should make the preview smaller. Pressing "Zoom In" should enlarge the preview. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: I have tested this in LibreOffice Calc 7.1.3.2 on Linux from the .deb packages from libreoffice.org and from the software center in Fedora. I have also tested this in LibreOffice Calc 7.1.4.2 on Windows 10 from the installer from libreoffice.org. On all systems I have tested this bug in and out of Safe Mode. The problem was recreated in all tests. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143138] Can't paste unformatted text as table cells in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=143138 --- Comment #3 from Mike Kaganski --- (In reply to Mike Kaganski from comment #2) > Oh? I tried this right now with Word 2016, and couldn't get such a result - > either using text from terminal (cmd.exe or cygwin), nor from plain-text > editors like notepad. I see now: that works when the table is pre-selected only, not when the cursor is in the first cell of a range (as was my intuitive expectation). Maybe that could be the good option: repeat not the whole clipboard content into every selected cell, but iterate element by element - which, for a single copied line, would be equivalent to what happens now, and for multiple cells, would be what Jakub asks for. Only do that for plain text ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/source
sc/source/ui/unoobj/filtuno.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 8b496beb74255d619a8de72a07860d1a77c4f79a Author: Andreas Heinisch AuthorDate: Wed Jun 30 10:37:08 2021 +0200 Commit: Xisco Fauli CommitDate: Wed Jun 30 20:58:42 2021 +0200 tdf#132421 - don't URL encode filename for the import ASCII dialog title Change-Id: Ia2cb7b6b355f640a525c41606da25ba35771499b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118148 Tested-by: Jenkins Reviewed-by: Andreas Heinisch (cherry picked from commit 6e8c9047f4bf6194bd1423422bd2dc9f92c50725) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118109 Reviewed-by: Xisco Fauli diff --git a/sc/source/ui/unoobj/filtuno.cxx b/sc/source/ui/unoobj/filtuno.cxx index 1e6119ecb36d..fbea6e78aa19 100644 --- a/sc/source/ui/unoobj/filtuno.cxx +++ b/sc/source/ui/unoobj/filtuno.cxx @@ -182,7 +182,8 @@ sal_Int16 SAL_CALL ScFilterOptionsObj::execute() // ascii import is special... INetURLObject aURL( aFileName ); -OUString aPrivDatName(aURL.getName()); +// tdf#132421 - don't URL encode filename for the import ASCII dialog title +OUString aPrivDatName(aURL.GetLastName(INetURLObject::DecodeMechanism::Unambiguous)); std::unique_ptr pInStream; if ( xInputStream.is() ) pInStream = utl::UcbStreamHelper::CreateStream( xInputStream ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #43 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/a9920e1fb8e7a1eb8158c8c699c2bf973d95bb32 tdf#135316 store stylesheets in a map It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #42 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/2577db3d6b1e59e14441704dc408200d7ce3e256 tdf#135316 make regex object static const It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #41 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/e2173d675b55b14081e9ae3d5b188cde65ad1fae tdf#135316 cache propertysetinfo in SwXShape It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - writerfilter/source
writerfilter/source/dmapper/StyleSheetTable.cxx | 43 +---
writerfilter/source/dmapper/StyleSheetTable.hxx |2 -
2 files changed, 18 insertions(+), 27 deletions(-)
New commits:
commit a9920e1fb8e7a1eb8158c8c699c2bf973d95bb32
Author: Noel Grandin
AuthorDate: Thu Jun 24 15:01:02 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Jun 30 20:57:16 2021 +0200
tdf#135316 store stylesheets in a map
for faster lookup.
Shaves 3% off my loading time
Change-Id: I075b42db52914988be4adef303825c211b02353f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117848
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit ab5ac64bdd3205ba2ba9ac038719826f703a09a3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118110
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 361914a60aea..af4eefc0d54f 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -270,6 +270,7 @@ struct StyleSheetTable_Impl
uno::Reference< text::XTextDocument>m_xTextDocument;
uno::Reference< beans::XPropertySet>m_xTextDefaults;
std::vector< StyleSheetEntryPtr > m_aStyleSheetEntries;
+std::map< OUString, StyleSheetEntryPtr > m_aStyleSheetEntriesMap;
StyleSheetEntryPtr m_pCurrentEntry;
PropertyMapPtr m_pDefaultParaProps,
m_pDefaultCharProps;
OUStringm_sDefaultParaStyleName; //WW8 name
@@ -809,6 +810,7 @@ void
StyleSheetTable::lcl_entry(writerfilter::Reference::Pointer_t r
{
m_pImpl->m_pCurrentEntry->sConvertedStyleName = ConvertStyleName(
m_pImpl->m_pCurrentEntry->sStyleName );
m_pImpl->m_aStyleSheetEntries.push_back( m_pImpl->m_pCurrentEntry );
+m_pImpl->m_aStyleSheetEntriesMap.emplace(
m_pImpl->m_pCurrentEntry->sStyleIdentifierD, m_pImpl->m_pCurrentEntry );
}
else
{
@@ -,16 +1113,14 @@ void StyleSheetTable::ApplyStyleSheets( const
FontTablePtr& rFontTable )
if (rVal.Name == "customStyle" &&
rVal.Value == true)
{
OUString sBaseId =
pEntry->sBaseStyleIdentifier;
-for (const auto& aSheetProps :
m_pImpl->m_aStyleSheetEntries)
+auto findIt =
m_pImpl->m_aStyleSheetEntriesMap.find(sBaseId);
+if (findIt !=
m_pImpl->m_aStyleSheetEntriesMap.end())
{
-if (aSheetProps->sStyleIdentifierD
== sBaseId)
-{
-StyleSheetPropertyMap&
rStyleSheetProps
-=
dynamic_cast(*aSheetProps->pProperties);
-
pStyleSheetProperties->SetListLevel(rStyleSheetProps.GetListLevel());
-
pStyleSheetProperties->SetOutlineLevel(rStyleSheetProps.GetOutlineLevel());
-break;
-}
+const auto& aSheetProps =
findIt->second;
+StyleSheetPropertyMap&
rStyleSheetProps
+=
dynamic_cast(*aSheetProps->pProperties);
+
pStyleSheetProperties->SetListLevel(rStyleSheetProps.GetListLevel());
+
pStyleSheetProperties->SetOutlineLevel(rStyleSheetProps.GetOutlineLevel());
}
}
}
@@ -1300,18 +1300,12 @@ void StyleSheetTable::ApplyStyleSheets( const
FontTablePtr& rFontTable )
}
-StyleSheetEntryPtr StyleSheetTable::FindStyleSheetByISTD(std::u16string_view
sIndex)
+StyleSheetEntryPtr StyleSheetTable::FindStyleSheetByISTD(const OUString&
sIndex)
{
-StyleSheetEntryPtr pRet;
-for(const StyleSheetEntryPtr & rpEntry : m_pImpl->m_aStyleSheetEntries)
-{
-if( rpEntry->sStyleIdentifierD == sIndex)
-{
-pRet = rpEntry;
-break;
-}
-}
-return pRet;
+auto findIt = m_pImpl->m_aStyleSheetEntriesMap.find(sIndex);
+if (findIt != m_pImpl->m_aStyleSheetEntriesMap.end())
+return findIt->second;
+return StyleSheetEntryPtr();
}
@@ -1346,12 +1340,9 @@ OUString StyleSheetTable::ConvertStyleName( const
OUString& rWWName, bool bExten
if( bExtendedSearch )
{
//search for the rWWName in the IdentifierD of the existing styles and
convert the
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - 2 commits - sw/inc sw/source writerfilter/source
sw/inc/unodraw.hxx |1
sw/source/core/unocore/unodraw.cxx | 29 ---
writerfilter/source/dmapper/NumberingManager.cxx |2 -
3 files changed, 18 insertions(+), 14 deletions(-)
New commits:
commit 2577db3d6b1e59e14441704dc408200d7ce3e256
Author: Noel Grandin
AuthorDate: Tue Jun 29 11:28:53 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Jun 30 20:57:07 2021 +0200
tdf#135316 make regex object static const
so we only compile it once, shaves 1% off load time
Change-Id: I8e6e20205659582901ffb8d4496ce44906146204
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118157
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 5ba64bba76ca1d23191300d1b5080cc091d432de)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118174
diff --git a/writerfilter/source/dmapper/NumberingManager.cxx
b/writerfilter/source/dmapper/NumberingManager.cxx
index 62706d1a5614..764aace41808 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -687,7 +687,7 @@ void ListsManager::lcl_attribute( Id nName, Value& rVal )
// DOCX level-text contains levels definition in format
"%1.%2.%3"
// we need to convert it to LO internal representation:
"%1%.%2%.%3%"
-std::regex aTokenRegex("(%\\d)");
+static const std::regex aTokenRegex("(%\\d)");
sLevelText = std::regex_replace(sLevelText, aTokenRegex,
"$1%");
pCurrentLvl->SetBulletChar( OUString::fromUtf8(sLevelText) );
}
commit e2173d675b55b14081e9ae3d5b188cde65ad1fae
Author: Noel Grandin
AuthorDate: Tue Jun 29 11:29:18 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Jun 30 20:56:56 2021 +0200
tdf#135316 cache propertysetinfo in SwXShape
shaves 3% off loaad time
Change-Id: I6541f94553d862787566672d91e2a87902835664
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118158
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 05992ce5d03aeb2db8d4fc7a68053ebd9a9aa511)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118175
diff --git a/sw/inc/unodraw.hxx b/sw/inc/unodraw.hxx
index e4e5f3a40272..f68e90fe4bbe 100644
--- a/sw/inc/unodraw.hxx
+++ b/sw/inc/unodraw.hxx
@@ -144,6 +144,7 @@ class SwXShape : public SwXShapeBaseClass, public
SvtListener
const SfxItemPropertySet* m_pPropSet;
const SfxItemPropertyMapEntry* m_pPropertyMapEntries;
+css::uno::Reference< css::beans::XPropertySetInfo > mxPropertySetInfo;
std::unique_ptr m_pImpl;
diff --git a/sw/source/core/unocore/unodraw.cxx
b/sw/source/core/unocore/unodraw.cxx
index 3348abee8fe1..8c5bf6c890bd 100644
--- a/sw/source/core/unocore/unodraw.cxx
+++ b/sw/source/core/unocore/unodraw.cxx
@@ -1016,23 +1016,26 @@ uno::Sequence< sal_Int8 >
SwXShape::getImplementationId( )
uno::Reference< beans::XPropertySetInfo > SwXShape::getPropertySetInfo()
{
SolarMutexGuard aGuard;
-uno::Reference< beans::XPropertySetInfo > aRet;
-if(m_xShapeAgg.is())
+if (!mxPropertySetInfo)
{
-const uno::Type& rPropSetType =
cppu::UnoType::get();
-uno::Any aPSet = m_xShapeAgg->queryAggregation( rPropSetType );
-if(auto xPrSet = o3tl::tryAccess>(
- aPSet))
+uno::Reference< beans::XPropertySetInfo > aRet;
+if(m_xShapeAgg.is())
{
-uno::Reference< beans::XPropertySetInfo > xInfo =
(*xPrSet)->getPropertySetInfo();
-// Expand PropertySetInfo!
-const uno::Sequence aPropSeq =
xInfo->getProperties();
-aRet = new SfxExtItemPropertySetInfo( m_pPropertyMapEntries,
aPropSeq );
+const uno::Type& rPropSetType =
cppu::UnoType::get();
+uno::Any aPSet = m_xShapeAgg->queryAggregation( rPropSetType );
+if(auto xPrSet =
o3tl::tryAccess>(
+ aPSet))
+{
+uno::Reference< beans::XPropertySetInfo > xInfo =
(*xPrSet)->getPropertySetInfo();
+// Expand PropertySetInfo!
+const uno::Sequence aPropSeq =
xInfo->getProperties();
+mxPropertySetInfo = new SfxExtItemPropertySetInfo(
m_pPropertyMapEntries, aPropSeq );
+}
}
+if(!mxPropertySetInfo)
+mxPropertySetInfo = m_pPropSet->getPropertySetInfo();
}
-if(!aRet.is())
-aRet = m_pPropSet->getPropertySetInfo();
-return aRet;
+return mxPropertySetInfo;
}
void SwXShape::setPropertyValue(const OUString& rPropertyName, const uno::Any&
aValue)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source sw/source
svx/source/sidebar/nbdtmg.cxx |2 +- sw/source/filter/html/htmlflywriter.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 8ed2142789b3db66c5ab28087040dee7c0ca6341 Author: Luboš Luňák AuthorDate: Tue Jun 15 15:24:15 2021 +0200 Commit: Noel Grandin CommitDate: Wed Jun 30 20:56:39 2021 +0200 fix a size warning d7855213ae60d79f converted this incorrectly, the code right above may set the size as (0,0), and before the commit the invalid size was only negative. Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376 Tested-by: Jenkins Reviewed-by: Noel Grandin Reviewed-by: Luboš Luňák diff --git a/svx/source/sidebar/nbdtmg.cxx b/svx/source/sidebar/nbdtmg.cxx index 76d1004e61dc..3c744fbf97b4 100644 --- a/svx/source/sidebar/nbdtmg.cxx +++ b/svx/source/sidebar/nbdtmg.cxx @@ -852,7 +852,7 @@ void OutlineTypeMgr::ApplyNumRule(SvxNumRule& aNum, sal_uInt16 nIndex, sal_uInt1 const Graphic* pGrf = pLevelSettings->pBrushItem->GetGraphic(); Size aSize = pLevelSettings->aSize; sal_Int16 eOrient = text::VertOrientation::LINE_CENTER; -if (!isResetSize && aFmt.GetGraphicSize()!=Size(0,0))\ +if (!isResetSize && aFmt.GetGraphicSize()!=Size(0,0)) aSize = aFmt.GetGraphicSize(); else if (aSize.IsEmpty() && pGrf) aSize = SvxNumberFormat::GetGraphicSizeMM100( pGrf ); diff --git a/sw/source/filter/html/htmlflywriter.cxx b/sw/source/filter/html/htmlflywriter.cxx index 472f406c28c6..bc065a7d64c0 100644 --- a/sw/source/filter/html/htmlflywriter.cxx +++ b/sw/source/filter/html/htmlflywriter.cxx @@ -685,7 +685,7 @@ OString SwHTMLWriter::OutFrameFormatOptions( const SwFrameFormat , (nPercentHeight ? 0 : pFSItem->GetHeight()-aTwipSpc.Height()) ); -OSL_ENSURE( !aTwipSz.IsEmpty(), "Frame size minus spacing < 0!!!???" ); +OSL_ENSURE( aTwipSz.Width() >= 0 && aTwipSz.Height() >= 0, "Frame size minus spacing < 0!!!???" ); if( aTwipSz.Width() < 0 ) aTwipSz.setWidth( 0 ); if( aTwipSz.Height() < 0 ) @@ -964,7 +964,7 @@ void SwHTMLWriter::writeFrameFormatOptions(HtmlWriter& aHtml, const SwFrameForma (nPercentHeight ? 0 : pFSItem->GetHeight()-aTwipSpc.Height()) ); -OSL_ENSURE( !aTwipSz.IsEmpty(), "Frame size minus spacing < 0!!!???" ); +OSL_ENSURE( aTwipSz.Width() >= 0 && aTwipSz.Height() >= 0, "Frame size minus spacing < 0!!!???" ); if( aTwipSz.Width() < 0 ) aTwipSz.setWidth( 0 ); if( aTwipSz.Height() < 0 ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/qa sc/source
sc/qa/unit/data/xlsx/129969-min.xlsx |binary
sc/qa/unit/subsequent_export-test2.cxx | 19 +++
sc/source/filter/excel/xecontent.cxx |4 ++--
3 files changed, 21 insertions(+), 2 deletions(-)
New commits:
commit 900ec0ac2b5fa0eb3bf42220077dc391e1aa4522
Author: Tünde Tóth
AuthorDate: Tue Jun 29 13:58:59 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Jun 30 20:56:40 2021 +0200
tdf#140431 XLSX export: fix double file:// prefix
Regression from commit: fc58d7d65b9683db7b7632137126680b8483f6c5
(tdf#129969 XLSX export: file URLs need IURI encoding)
Change-Id: I5bfb0ef9ba7fe82cd3f4d0e0b3fdcf8f705cba64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118090
Tested-by: Jenkins
Tested-by: László Németh
Reviewed-by: László Németh
(cherry picked from commit 67e2cc17bad3fd7aacb94da47f9024b731434a84)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118173
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/data/xlsx/129969-min.xlsx
b/sc/qa/unit/data/xlsx/129969-min.xlsx
new file mode 100644
index ..b6fd8e9e2069
Binary files /dev/null and b/sc/qa/unit/data/xlsx/129969-min.xlsx differ
diff --git a/sc/qa/unit/subsequent_export-test2.cxx
b/sc/qa/unit/subsequent_export-test2.cxx
index 8e4f77ebbd79..1c088c813f21 100644
--- a/sc/qa/unit/subsequent_export-test2.cxx
+++ b/sc/qa/unit/subsequent_export-test2.cxx
@@ -186,6 +186,7 @@ public:
void testTdf136721_paper_size();
void testTdf139258_rotated_image();
void testTdf126541_SheetVisibilityImportXlsx();
+void testTdf140431();
CPPUNIT_TEST_SUITE(ScExportTest2);
@@ -280,6 +281,7 @@ public:
CPPUNIT_TEST(testTdf136721_paper_size);
CPPUNIT_TEST(testTdf139258_rotated_image);
CPPUNIT_TEST(testTdf126541_SheetVisibilityImportXlsx);
+CPPUNIT_TEST(testTdf140431);
CPPUNIT_TEST_SUITE_END();
@@ -2282,6 +2284,23 @@ void
ScExportTest2::testTdf126541_SheetVisibilityImportXlsx()
CPPUNIT_ASSERT(xShell->GetDocument().GetViewOptions().GetOption(VOPT_GRID));
}
+void ScExportTest2::testTdf140431()
+{
+ScDocShellRef xShell = loadDoc(u"129969-min.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xShell.is());
+
+ScDocShellRef xDocSh = saveAndReload(&(*xShell), FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+ScDocument& rDoc = xDocSh->GetDocument();
+ScAddress aPos(0, 2, 0);
+const EditTextObject* pEditText = rDoc.GetEditText(aPos);
+const SvxFieldData* pData = pEditText->GetFieldData(0, 0,
text::textfield::Type::URL);
+const SvxURLField* pURLData = static_cast(pData);
+CPPUNIT_ASSERT(pURLData->GetURL().startsWith("file://ndhlis"));
+
+xDocSh->DoClose();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest2);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xecontent.cxx
b/sc/source/filter/excel/xecontent.cxx
index cf0c3777f39f..0848745b8d4a 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -394,9 +394,9 @@ XclExpHyperlink::XclExpHyperlink( const XclExpRoot& rRoot,
const SvxURLField& rU
for( int i = 0; i < nLevel; ++i )
msTarget = "../" + msTarget;
}
-else
+else if (rRoot.GetOutput() != EXC_OUTPUT_XML_2007)
{
-// ooxml expects the file:/// part appended ( or at least
+// xls expects the file:/// part appended ( or at least
// ms2007 does, ms2010 is more tolerant )
msTarget = "file:///" + msTarget;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143138] Can't paste unformatted text as table cells in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=143138 Mike Kaganski changed: What|Removed |Added Keywords||needsUXEval --- Comment #2 from Mike Kaganski --- (In reply to Jakub from comment #0) > When I tried that in > MS Word with the same unformatted text, I got the desired result. Oh? I tried this right now with Word 2016, and couldn't get such a result - either using text from terminal (cmd.exe or cygwin), nor from plain-text editors like notepad. Note that Writer includes a method to *convert text to table* (under menu Table->Convert), which is the intended workflow in such a case: you paste not into existing table, but into main text flow, then select and convert to table. I have no idea how to implement the *option* to split text to rows - and then, what about columns? Do we need a full CSV import dialog like in Calc? My take would be WONTFIX, because it is a rarely-needed function that has a reasonable substitution. Asking UX for opinions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/xlsx/checkbox-form-control.xlsx |binary
sc/qa/unit/subsequent_export-test2.cxx | 20
sc/source/filter/excel/xeescher.cxx | 98 +++-
sc/source/filter/inc/xeescher.hxx |3
sc/source/filter/xcl97/xcl97rec.cxx | 12 ++
5 files changed, 131 insertions(+), 2 deletions(-)
New commits:
commit 94678a7b9c6b7e577c15adacc885e03551bcf17b
Author: Miklos Vajna
AuthorDate: Wed Jun 30 16:22:42 2021 +0200
Commit: Miklos Vajna
CommitDate: Wed Jun 30 20:33:39 2021 +0200
XLSX export: improve handling of checkbox (form controls)
This builds on top of commit fd238380ae7820f12ac1f7c52d0f7180a93f3ba3
(tdf#106181 XLSX export: output form controls, 2020-05-13) and adds the
missing VML version which seems to be mandated by Excel 2019.
It is not perfect (e.g. there is still an unwanted border around the
checkbox), but the checkbox has a correct position and its label is
readable, while it was just lost previously.
Change-Id: I08198d068a0eb85061d138719cfc60d73c46398e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118168
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sc/qa/unit/data/xlsx/checkbox-form-control.xlsx
b/sc/qa/unit/data/xlsx/checkbox-form-control.xlsx
new file mode 100644
index ..ad761a573aae
Binary files /dev/null and b/sc/qa/unit/data/xlsx/checkbox-form-control.xlsx
differ
diff --git a/sc/qa/unit/subsequent_export-test2.cxx
b/sc/qa/unit/subsequent_export-test2.cxx
index 1c088c813f21..eb6db21167d3 100644
--- a/sc/qa/unit/subsequent_export-test2.cxx
+++ b/sc/qa/unit/subsequent_export-test2.cxx
@@ -187,6 +187,7 @@ public:
void testTdf139258_rotated_image();
void testTdf126541_SheetVisibilityImportXlsx();
void testTdf140431();
+void testCheckboxFormControlXlsxExport();
CPPUNIT_TEST_SUITE(ScExportTest2);
@@ -282,6 +283,7 @@ public:
CPPUNIT_TEST(testTdf139258_rotated_image);
CPPUNIT_TEST(testTdf126541_SheetVisibilityImportXlsx);
CPPUNIT_TEST(testTdf140431);
+CPPUNIT_TEST(testCheckboxFormControlXlsxExport);
CPPUNIT_TEST_SUITE_END();
@@ -2301,6 +2303,24 @@ void ScExportTest2::testTdf140431()
xDocSh->DoClose();
}
+void ScExportTest2::testCheckboxFormControlXlsxExport()
+{
+// Given a document that has a checkbox form control:
+ScDocShellRef xShell = loadDoc(u"checkbox-form-control.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xShell.is());
+
+// When exporting to XLSX:
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(&(*xShell), FORMAT_XLSX);
+
+// Then make sure its VML markup is written and it has a correct position
+ size:
+xmlDocUniquePtr pDoc
+= XPathHelper::parseExport(pXPathFile, m_xSFactory,
"xl/drawings/vmlDrawing1.vml");
+// Without the fix in place, this test would have failed as there was no
such stream.
+CPPUNIT_ASSERT(pDoc);
+assertXPathContent(pDoc, "/xml/v:shape/xx:ClientData/xx:Anchor", "1, 22,
3, 3, 3, 30, 6, 1");
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest2);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xeescher.cxx
b/sc/source/filter/excel/xeescher.cxx
index 1bc1a753acad..2f1253c0a16e 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -70,6 +70,7 @@
#include
#include
#include
+#include
#include
using namespace com::sun::star;
@@ -651,7 +652,8 @@ XclExpTbxControlObj::XclExpTbxControlObj(
XclExpObjectManager& rRoot, Reference<
mbScrollHor( false ),
mbPrint( false ),
mbVisible( false ),
-mnShapeId( 0 )
+mnShapeId( 0 ),
+mrRoot(rRoot)
{
namespace FormCompType = css::form::FormComponentType;
namespace AwtVisualEffect = css::awt::VisualEffect;
@@ -1084,6 +1086,100 @@ void XclExpTbxControlObj::setShapeId(sal_Int32 aShapeId)
mnShapeId = aShapeId;
}
+namespace
+{
+/// Handles the VML export of form controls (e.g. checkboxes).
+class VmlFormControlExporter : public oox::vml::VMLExport
+{
+sal_uInt16 m_nObjType;
+tools::Rectangle m_aAreaFrom;
+tools::Rectangle m_aAreaTo;
+OUString m_aLabel;
+
+public:
+VmlFormControlExporter(const sax_fastparser::FSHelperPtr& p, sal_uInt16
nObjType,
+ const tools::Rectangle& rAreaFrom, const
tools::Rectangle& rAreaTo,
+ const OUString& rLabel);
+
+protected:
+using VMLExport::StartShape;
+sal_Int32 StartShape() override;
+using VMLExport::EndShape;
+void EndShape(sal_Int32 nShapeElement) override;
+};
+
+VmlFormControlExporter::VmlFormControlExporter(const
sax_fastparser::FSHelperPtr& p,
+ sal_uInt16 nObjType,
+ const tools::Rectangle&
rAreaFrom,
+ const tools::Rectangle& rAreaTo,
+
[Libreoffice-bugs] [Bug 142945] LO72a1/b1 on macOS: closing all open documents - a "phantom" last-opened-document window remains visible
https://bugs.documentfoundation.org/show_bug.cgi?id=142945 --- Comment #5 from Martin Srebotnjak --- I can confirm I also cannot confirm this with newer b1 builds (from daily). So I guess this (whatever it was) was already fixed in the meantime. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143140] ODT: Bibliography index duplicated
https://bugs.documentfoundation.org/show_bug.cgi?id=143140 --- Comment #1 from Mihai Vasiliu --- Created attachment 173297 --> https://bugs.documentfoundation.org/attachment.cgi?id=173297=edit Insert a new index in this document and observe index duplication The index is duplicated and even if I select Update Index, the index does not get correct. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143140] New: ODT: Bibliography index duplicated
https://bugs.documentfoundation.org/show_bug.cgi?id=143140 Bug ID: 143140 Summary: ODT: Bibliography index duplicated Product: LibreOffice Version: 7.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mihai.vasiliu...@gmail.com Description: When inserting a new bibliography entry in the document, if the new entry is inserted between two existing entries, the index gets duplicated in both the reference and in the bibliography index Steps to Reproduce: 1. Create a new LO Writer document 2. Insert some Lorem Ipsum paragraphs 3. Create a few new bibliography entries with the source being Document content and insert them into the document. 4. Create a Bibliography Index at the end. The index should be populated fine. Edit the index and change the entries to 'Number entries' instead of short name display. 5. Save the document as ODT, close and reopen. 6. Between any two existing bibliography references from the text, enther a new one. Let's say between [1] and [2], create and insert a new reference. 7. Observe that the new index is duplicated: now the indexes are [1], [2] and [2]. 7. Update the bibliography index. 8. Notice that the bibliography index now contains duplicate entries: 1, 2, 2. Actual Results: The new bibliography index takes the same index as the next one, without renumbering them accordingly. Expected Results: A new index should be created and all the next indices should be renumbered: [1], [2], [3]. The Bibliography index should reflect this change and renumber the entries, without creating duplicates. Reproducible: Always User Profile Reset: No Additional Info: After saving and reopening the ODT document, sometimes the numbering is updated in the docuemnt, but the Bibliography index still shows duplicate numbers. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141421] Spreadsheet crashes when exported to MS Excel 2003 XML
https://bugs.documentfoundation.org/show_bug.cgi?id=141421 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- no repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 9c15dea0b2192d231b65175291a7655122c2e24c CPU threads: 4; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded can you attach your file that you tried to export? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143139] DOCX: Broken bibliography
https://bugs.documentfoundation.org/show_bug.cgi?id=143139 --- Comment #1 from Mihai Vasiliu --- Created attachment 173296 --> https://bugs.documentfoundation.org/attachment.cgi?id=173296=edit Open the document and see that the bibliography index shows !!br0ken!! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143139] New: DOCX: Broken bibliography
https://bugs.documentfoundation.org/show_bug.cgi?id=143139 Bug ID: 143139 Summary: DOCX: Broken bibliography Product: LibreOffice Version: 7.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mihai.vasiliu...@gmail.com Description: When saving document to DOCX, bibliography links are broken and cannot be restored. They are lost. Steps to Reproduce: 1. Create a new LO Writer document 2. Insert some Lorem Ipsum paragraphs 3. Create a few new bibliography entries with the source being Document content and insert them into the document. 4. Create a Bibliography Index at the end. The index should be populated fine. Edit the index and change the entries to 'Number entries' instead of short name display. 5. Save the document as DOCX and close LO Writer. 6. Open the document again. Notice that the bibliography references are missing the [ ] brackets. 7. Update the bibliography index. 8. Notice that all links are now broken: !!br0ken!! 4. Actual Results: The bibliography index is now broken. All indexes are lost and the references are no longer in the document content. You must insert them manually again. All the indexes in the Bibliography index show !!br0ken!! Expected Results: The bibliography index should remain the same. Nothing should be lost. The [ ] parantheses should remain in place. Reproducible: Always User Profile Reset: No Additional Info: This reproduces every time and seems to reproduce regardless number entries is checked or not. So short name entries will be affected too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140923] Calc and Macro IDE UI Scaling Issues On Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=140923 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140923] Calc and Macro IDE UI Scaling Issues On Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=140923 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please update your LibreOffice to 7.1.4 and try repeat your problem -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143138] Can't paste unformatted text as table cells in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=143138 Jakub changed: What|Removed |Added Summary|Can't paste unformatted |Can't paste unformatted |text into table cells in|text as table cells in |Writer |Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143138] Can't paste unformatted text into table cells in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=143138 --- Comment #1 from kuba23031...@gmail.com --- Created attachment 173295 --> https://bugs.documentfoundation.org/attachment.cgi?id=173295=edit Comparison between what I want to get (left) and what I get (right) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143138] New: Can't paste unformatted text into table cells in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=143138 Bug ID: 143138 Summary: Can't paste unformatted text into table cells in Writer Product: LibreOffice Version: 7.1.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kuba23031...@gmail.com Description: After creating a table in LibreOffice Writer, I tried to paste some data copied from STDOUT (unformatted text, it was a set dates, every date in a new line). If the cursor was in a particular cell, the text was pasted into the cell (which is OK), but when I highlight the whole column and paste, every cell gets the whole set instead of just one line. When I tried that in MS Word with the same unformatted text, I got the desired result. It also works if I paste the text into Calc, then copy from Calc and paste into Writer. Steps to Reproduce: 1. Copy some unformatted text with more than one line. 2. Create a table in LibreOffice Writer. 3. Highlight one column and paste. Actual Results: Every cell gets all the text from clipboard. Expected Results: Every cell should get just one line. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.1.3.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: pl-PL (pl_PL.UTF-8); UI: pl-PL 7.1.3-2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143137] FORMNAVIGATION: When switching from Form to "Data source as Table" last changes won't be saved
https://bugs.documentfoundation.org/show_bug.cgi?id=143137 Robert Großkopf changed: What|Removed |Added Hardware|All |x86-64 (AMD64) OS|All |Linux (All) Version|7.1.4.2 release |6.1.5.2 release --- Comment #1 from Robert Großkopf --- This bug also appears in LO 7.1.4.2 and also appears in LO 6.1.5.2 on OpenSUSE 15.2 64bit rpm Linux. Could be it is a very old bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143137] New: FORMNAVIGATION: When switching from Form to "Data source as Table" last changes won't be saved
https://bugs.documentfoundation.org/show_bug.cgi?id=143137 Bug ID: 143137 Summary: FORMNAVIGATION: When switching from Form to "Data source as Table" last changes won't be saved Product: LibreOffice Version: 7.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 173294 --> https://bugs.documentfoundation.org/attachment.cgi?id=173294=edit Open the form, open "Data source as Table", change content in one field and switch directly by mouse to data source. Open the attached database. Open the form. Set "Data source as Table" (last button in navigation bar). Go to field "Nachname" and change the "Nachname". Switch directly to "Data source as Table", which is shown at the top of the form. The changed content wont be saved. The content will only be saved when switching to another file of the form before you change to "Data source as Table". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143136] ODT: Picture frames are left aligned after DOCX to ODT conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=143136 --- Comment #1 from Mihai Vasiliu --- Created attachment 173293 --> https://bugs.documentfoundation.org/attachment.cgi?id=173293=edit Convert this document to ODT to observe the frame behaviour -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143136] New: ODT: Picture frames are left aligned after DOCX to ODT conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=143136 Bug ID: 143136 Summary: ODT: Picture frames are left aligned after DOCX to ODT conversion Product: LibreOffice Version: 7.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mihai.vasiliu...@gmail.com Description: The picture frame content is moved on the left of the page if the document is converted from DOCX to ODT. Steps to Reproduce: 1. Create a new LO Writer document 2. Insert a picture and change the anchor point to be 'As Character' 3. Add a caption to the picture (this will create a frame). Make sure the anchor point is still 'As Character' 4. Save the document as DOCX and reopen. 5. Re-save the document as ODT. 6. Close and reopen the ODT. 7. Notice that the picture frame remains in its position, but the contents of the frame is moved at the left side of the page. Actual Results: The picture frame remains in its position (just as a placeholder), but the contents of the frame is moved at the left side of the page, and it is misaligned. Expected Results: The frame should remain in place. The contents should remain in the frame. Reproducible: Always User Profile Reset: No Additional Info: If you move the frame just a bit, the contents moves back to the frame, but this is just temporary. On the next reopen the contents moves back to the left. This does not reproduce if anchor point is As Paragraph. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142945] LO72a1/b1 on macOS: closing all open documents - a "phantom" last-opened-document window remains visible
https://bugs.documentfoundation.org/show_bug.cgi?id=142945 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- no repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 9c15dea0b2192d231b65175291a7655122c2e24c CPU threads: 4; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143073] Draw 'Page Pane' is unstable on duplicating and rearranege -- REGRESSION, worked in 6.4.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=143073 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- no repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 9c15dea0b2192d231b65175291a7655122c2e24c CPU threads: 4; OS: Mac OS X 10.16; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded please try reset your User profile using menu Help->Restart in Safe mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143135] New: Impress crashes when switching to another application then back
https://bugs.documentfoundation.org/show_bug.cgi?id=143135 Bug ID: 143135 Summary: Impress crashes when switching to another application then back Product: LibreOffice Version: 7.1.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bugzi...@oneyv.org Description: Desktop is Fedora 34 KDE spin, running Wayland. All patches are up to date. While I am editing an Impress presentation, if I select another application from the panel, then select Impress from the panel, it crashes the Impress session completely. Steps to Reproduce: 1.Start any desktop application such as KCalc 2.STart Impress and edit a presentation 3.Click on panel Kcalc to switch to that application 4.Click on panel Impress to switch back to presentation Actual Results: Impress crashes completely Expected Results: Impress should continue operating, allowing presentation to be edited. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.1.4.2 Build ID: 10(Build:2) CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127978] Navigator's tooltip shows URI-encoded URL (with %%%) instead cyrillic path to file
https://bugs.documentfoundation.org/show_bug.cgi?id=127978 Andreas Heinisch changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - include/svx officecfg/registry sc/sdi sc/source sd/sdi sd/source svx/Library_svx.mk svx/sdi svx/source svx/uiconfig svx/UIConfig_svx.mk sw/sd
include/svx/svxids.hrc |3 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu | 33 +++ sc/sdi/drawsh.sdi|2 sc/source/ui/drawfunc/drawsh.cxx |2 sc/source/ui/drawfunc/drawsh2.cxx| 15 + sd/sdi/_drvwsh.sdi | 11 + sd/source/ui/view/drviews2.cxx |2 sd/source/ui/view/drviewsf.cxx | 12 + svx/Library_svx.mk |1 svx/UIConfig_svx.mk |1 svx/sdi/svx.sdi | 34 +++ svx/source/sidebar/PanelFactory.cxx |5 svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.cxx | 119 +++ svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.hxx | 48 svx/uiconfig/ui/sidebartextcolumnspanel.ui | 107 + sw/sdi/drawsh.sdi| 14 + sw/source/uibase/shells/drawdlg.cxx | 19 + 17 files changed, 426 insertions(+), 2 deletions(-) New commits: commit f03f66498d218996af358cd4ad764248410a2a1f Author: Mike Kaganski AuthorDate: Mon Jun 14 09:51:44 2021 +0300 Commit: Mike Kaganski CommitDate: Wed Jun 30 18:53:21 2021 +0200 editengine-columns: add sidebar property panel Change-Id: I90aefc10f9eb64a65799480777bc4287abae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit dd5bf12193471f064bf7f581dd1b21783390e735) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117217 diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc index 0627c29e1500..6b23b3176f17 100644 --- a/include/svx/svxids.hrc +++ b/include/svx/svxids.hrc @@ -438,6 +438,9 @@ class SdrAngleItem; //#define SID_SIDEBAR ( SID_SVX_START + 336 ) -> sfxsids.hrc +#define SID_ATTR_TEXTCOLUMNS_NUMBER ( SID_SVX_START + 337 ) +#define SID_ATTR_TEXTCOLUMNS_SPACING( SID_SVX_START + 338 ) + #define SID_SB_CONNECTIONPOOLING( SID_SVX_START + 348 ) #define SID_SB_DBREGISTEROPTIONS( SID_SVX_START + 349 ) #define SID_BMPMASK ( SID_SVX_START + 350 ) diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu index daeecf5bbaed..6876d922072d 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu @@ -1843,6 +1843,39 @@ + + + Columns + + + TextColumnsPropertyPanel + + + PropertyDeck + + + +Calc, Draw, hidden ; +Calc, Graphic,hidden ; +Calc, Media, hidden ; +DrawImpress,Draw, hidden ; +DrawImpress,Graphic,hidden ; +DrawImpress,TextObject, hidden ; +WriterVariants, Draw, hidden ; +WriterVariants, Graphic,hidden ; + + + + private:resource/toolpanel/SvxPanelFactory/TextColumnsPropertyPanel + + + 800 + + + false + + + diff --git a/sc/sdi/drawsh.sdi b/sc/sdi/drawsh.sdi index b1d5ecec44a8..e097df04036a 100644 --- a/sc/sdi/drawsh.sdi +++ b/sc/sdi/drawsh.sdi @@ -231,6 +231,8 @@ interface TableDraw SID_ATTR_SOFTEDGE_RADIUS[ ExecMethod = ExecDrawAttr; StateMethod = GetDrawAttrState; ] SID_MOVE_SHAPE_HANDLE [ ExecMethod = ExecDrawAttr; ] +SID_ATTR_TEXTCOLUMNS_NUMBER [ ExecMethod = ExecDrawAttr; StateMethod = GetDrawAttrState; ] +SID_ATTR_TEXTCOLUMNS_SPACING[ ExecMethod = ExecDrawAttr; StateMethod = GetDrawAttrState; ] } diff --git a/sc/source/ui/drawfunc/drawsh.cxx b/sc/source/ui/drawfunc/drawsh.cxx index f60fba27b4d2..2be55f8100ab 100644 --- a/sc/source/ui/drawfunc/drawsh.cxx +++ b/sc/source/ui/drawfunc/drawsh.cxx @@ -417,6 +417,8 @@ void ScDrawShell::ExecDrawAttr( SfxRequest& rReq ) case SID_ATTR_GLOW_RADIUS: case SID_ATTR_GLOW_TRANSPARENCY: case SID_ATTR_SOFTEDGE_RADIUS: +case SID_ATTR_TEXTCOLUMNS_NUMBER: +case SID_ATTR_TEXTCOLUMNS_SPACING: if (const SfxItemSet* pNewArgs = rReq.GetArgs()) pView->SetAttrToMarked(*pNewArgs, false); rReq.Done(); diff --git a/sc/source/ui/drawfunc/drawsh2.cxx b/sc/source/ui/drawfunc/drawsh2.cxx index 22f28e52efe8..82609b657959
[Libreoffice-commits] core.git: framework/qa sfx2/inc sfx2/source
framework/qa/cppunit/data/empty.fodp |2 ++
framework/qa/cppunit/dispatchtest.cxx | 32
sfx2/inc/unoctitm.hxx |7 ++-
sfx2/source/control/unoctitm.cxx | 21 +
4 files changed, 61 insertions(+), 1 deletion(-)
New commits:
commit 7cbd6d768d282077053c354254315f3dc89bf254
Author: Michael Stahl
AuthorDate: Wed Jun 30 13:26:59 2021 +0200
Commit: Michael Stahl
CommitDate: Wed Jun 30 18:40:27 2021 +0200
sfx2: try to fix lifecycle of SfxOfficeDispatch
This can be created either from the global SfxApplication, or from a
SfxViewFrame.
Particularly in the latter case, the SfxDispatcher and SfxBindings
members are owned by SfxViewFrame, so in case that is destroyed, the
SfxOfficeDispatch must clear its pointers.
It looks like the member pointers are checked before access already
everywhere, so just listen at the SfxViewFrame.
Change-Id: If08825734e94dd54e32cb77546684fd583c336ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/framework/qa/cppunit/data/empty.fodp
b/framework/qa/cppunit/data/empty.fodp
new file mode 100644
index ..3c2a4cf2cda5
--- /dev/null
+++ b/framework/qa/cppunit/data/empty.fodp
@@ -0,0 +1,2 @@
+
+
diff --git a/framework/qa/cppunit/dispatchtest.cxx
b/framework/qa/cppunit/dispatchtest.cxx
index 586c4af3b9b0..2f21a71b005e 100644
--- a/framework/qa/cppunit/dispatchtest.cxx
+++ b/framework/qa/cppunit/dispatchtest.cxx
@@ -15,6 +15,7 @@
#include
#include
#include
+#include
#include
#include
@@ -199,6 +200,37 @@ CPPUNIT_TEST_FIXTURE(DispatchTest, testInterception)
// This was 1: MyInterceptor::queryDispatch() was called for .uno:Italic.
CPPUNIT_ASSERT_EQUAL(0, pInterceptor->getUnexpected());
}
+
+constexpr OUStringLiteral DATA_DIRECTORY = u"/framework/qa/cppunit/data/";
+
+CPPUNIT_TEST_FIXTURE(DispatchTest, testSfxOfficeDispatchDispose)
+{
+// this test doesn't work with a new document because of aURL.Main check
in SfxBaseController::dispatch()
+mxComponent = loadFromDesktop(m_directories.getURLFromSrc(DATA_DIRECTORY)
+ "empty.fodp",
+
"com.sun.star.presentation.PresentationDocument");
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+CPPUNIT_ASSERT(xModel.is());
+uno::Reference
xController(xModel->getCurrentController());
+CPPUNIT_ASSERT(xController.is());
+uno::Reference xFrame(xController->getFrame(),
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xFrame.is());
+
+uno::Reference
xParser(util::URLTransformer::create(mxComponentContext));
+util::URL url;
+url.Complete = xModel->getURL() + "#dummy";
+xParser->parseStrict(url);
+
+uno::Reference xDisp(xFrame->queryDispatch(url, "", 0));
+CPPUNIT_ASSERT(xDisp.is());
+
+mxComponent->dispose();
+
+util::URL urlSlot;
+urlSlot.Complete = "slot:5598";
+xParser->parseStrict(urlSlot);
+// crashed with UAF
+xDisp->dispatch(urlSlot, {});
+}
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sfx2/inc/unoctitm.hxx b/sfx2/inc/unoctitm.hxx
index 805ff22b3124..9e6bc19da488 100644
--- a/sfx2/inc/unoctitm.hxx
+++ b/sfx2/inc/unoctitm.hxx
@@ -25,6 +25,7 @@
#include
#include
+#include
#include
#include
@@ -101,7 +102,9 @@ public:
SfxDispatcher* GetDispatcher_Impl();
};
-class SfxDispatchController_Impl final : public SfxControllerItem
+class SfxDispatchController_Impl final
+: public SfxControllerItem
+, public SfxListener
{
css::util::URL aDispatchURL;
SfxDispatcher* pDispatcher;
@@ -126,6 +129,8 @@ public:
const css::util::URL& rURL
);
virtual ~SfxDispatchController_Impl() override;
+virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;
+
static OUString getSlaveCommand( const css::util::URL& rURL );
voidStateChanged( sal_uInt16 nSID, SfxItemState eState,
const SfxPoolItem* pState, SfxSlotServer const * pServ );
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 50034333bcd5..58bdc6179008 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -323,6 +323,27 @@ SfxDispatchController_Impl::SfxDispatchController_Impl(
BindInternal_Impl( nSlot, pBindings );
pBindings->LEAVEREGISTRATIONS();
}
+assert(pDispatcher);
+assert(SfxApplication::Get()->GetAppDispatcher_Impl() == pDispatcher
+|| pDispatcher->GetFrame() != nullptr);
+if (pDispatcher->GetFrame())
+{
+StartListening(*pDispatcher->GetFrame());
+}
+else
+{
+StartListening(*SfxApplication::Get());
+}
+}
+
+void SfxDispatchController_Impl::Notify(SfxBroadcaster& rBC, SfxHint const&
rHint)
+{
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #40 from Telesto --- (In reply to Noel Grandin from comment #39) > I am considering this done, and won't be doing any more work on this FIXED seems appropriate here.. Note: I wondered already if the flow of commits would ever stop ;-) Thanks for all the work! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source filter/source include/editeng sd/source sw/source
editeng/source/items/numitem.cxx | 12
editeng/source/outliner/outlvw.cxx |4 ++--
filter/source/msfilter/svdfppt.cxx |2 +-
include/editeng/numitem.hxx|2 ++
sd/source/core/drawdoc4.cxx|2 +-
sd/source/core/stlpool.cxx |6 +++---
sd/source/ui/dlg/dlgolbul.cxx |2 +-
sd/source/ui/func/fuolbull.cxx |2 +-
sd/source/ui/view/drtxtob1.cxx |2 +-
sd/source/ui/view/drviews2.cxx |2 +-
sd/source/ui/view/viewshel.cxx |2 +-
sw/source/uibase/app/docstyle.cxx |2 +-
sw/source/uibase/shells/txtnum.cxx |2 +-
13 files changed, 28 insertions(+), 14 deletions(-)
New commits:
commit 738f7a8cb971a884f74766da0cbf7e59ef8b90e7
Author: Noel Grandin
AuthorDate: Wed Jun 30 15:10:44 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Jun 30 18:03:06 2021 +0200
reduce cost of allocating and copying SvxNumRule
by using std::move to avoid copying unnecessarily
Change-Id: I940b57c9a05c8d75b9a16291fc4f05756fdeea12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118164
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 54bec9d892ea..41ee6e4cf952 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -1013,12 +1013,24 @@ SvxNumBulletItem::SvxNumBulletItem(SvxNumRule const &
rRule) :
{
}
+SvxNumBulletItem::SvxNumBulletItem(SvxNumRule && rRule) :
+SfxPoolItem(SID_ATTR_NUMBERING_RULE),
+maNumRule(std::move(rRule))
+{
+}
+
SvxNumBulletItem::SvxNumBulletItem(SvxNumRule const & rRule, sal_uInt16
_nWhich ) :
SfxPoolItem(_nWhich),
maNumRule(rRule)
{
}
+SvxNumBulletItem::SvxNumBulletItem(SvxNumRule && rRule, sal_uInt16 _nWhich ) :
+SfxPoolItem(_nWhich),
+maNumRule(std::move(rRule))
+{
+}
+
SvxNumBulletItem::SvxNumBulletItem(const SvxNumBulletItem& rCopy) :
SfxPoolItem(rCopy),
maNumRule(rCopy.maNumRule)
diff --git a/editeng/source/outliner/outlvw.cxx
b/editeng/source/outliner/outlvw.cxx
index aabe51c9efd8..6cd2f6d7515e 100644
--- a/editeng/source/outliner/outlvw.cxx
+++ b/editeng/source/outliner/outlvw.cxx
@@ -878,7 +878,7 @@ void OutlinerView::ToggleBullets()
{
SfxItemSet aAttrs( pOwner->GetParaAttribs( nPara ) );
SvxNumRule aNewNumRule( *pDefaultBulletNumRule );
-aAttrs.Put( SvxNumBulletItem( aNewNumRule,
EE_PARA_NUMBULLET ) );
+aAttrs.Put( SvxNumBulletItem( std::move(aNewNumRule),
EE_PARA_NUMBULLET ) );
pOwner->SetParaAttribs( nPara, aAttrs );
}
}
@@ -1050,7 +1050,7 @@ void OutlinerView::ApplyBulletsNumbering(
}
}
-aAttrs.Put(SvxNumBulletItem(aNewRule, EE_PARA_NUMBULLET));
+aAttrs.Put(SvxNumBulletItem(std::move(aNewRule),
EE_PARA_NUMBULLET));
}
}
pOwner->SetParaAttribs(nPara, aAttrs);
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index 1b5a30110a94..f7ef3675a03d 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4411,7 +4411,7 @@ PPTStyleSheet::PPTStyleSheet( const DffRecordHeader&
rSlideHd, SvStream& rIn, Sd
aRule.SetLevel( nDepth, aNumberFormat );
}
}
-mpNumBulletItem[ i ] = std::make_unique( aRule,
EE_PARA_NUMBULLET );
+mpNumBulletItem[ i ] = std::make_unique(
std::move(aRule), EE_PARA_NUMBULLET );
}
}
diff --git a/include/editeng/numitem.hxx b/include/editeng/numitem.hxx
index 2e2e660267e8..bbcbecdf4c79 100644
--- a/include/editeng/numitem.hxx
+++ b/include/editeng/numitem.hxx
@@ -308,7 +308,9 @@ class EDITENG_DLLPUBLIC SvxNumBulletItem final : public
SfxPoolItem
SvxNumRule maNumRule;
public:
explicit SvxNumBulletItem(SvxNumRule const & rRule);
+explicit SvxNumBulletItem(SvxNumRule && rRule);
SvxNumBulletItem(SvxNumRule const & rRule, sal_uInt16 nWhich );
+SvxNumBulletItem(SvxNumRule && rRule, sal_uInt16 nWhich );
SvxNumBulletItem(const SvxNumBulletItem& rCopy);
virtual ~SvxNumBulletItem() override;
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index e3d7080f953b..e078afc58b54 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -1268,7 +1268,7 @@ void SdDrawDocument::SetTextDefaults() const
aNumRule.SetLevel( i, aNumberFormat );
}
-SvxNumBulletItem aNumBulletItem( aNumRule, EE_PARA_NUMBULLET );
+SvxNumBulletItem aNumBulletItem( std::move(aNumRule), EE_PARA_NUMBULLET );
m_pItemPool->SetPoolDefaultItem( aNumBulletItem );
}
diff --git a/sd/source/core/stlpool.cxx b/sd/source/core/stlpool.cxx
index d6256bd6f9ae..d15aaf632b04 100644
---
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #39 from Noel Grandin --- I am considering this done, and won't be doing any more work on this -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143115] FILEOPEN DOCX marked as change and asks for a save on close
https://bugs.documentfoundation.org/show_bug.cgi?id=143115 --- Comment #7 from Telesto --- Can't tell if this a import/or export issue.. export in 3.5.7.2 and opening again causing the problem already -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135316] FILEOPEN DOCX: Time to open from 18 to 30-45 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=135316 --- Comment #38 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf15c4dad74e31a035c0d1ca899dfbef4da90ad2 tdf#135316 optimise SwCharFormats::FindFormatByName It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/charformats.hxx | 114
sw/inc/doc.hxx |1
sw/inc/docary.hxx |6 -
sw/source/core/doc/docfmt.cxx |8 +-
sw/source/core/doc/docnew.cxx |9 +-
sw/source/core/doc/number.cxx |2
sw/source/core/txtnode/chrfmt.cxx | 77
sw/source/core/undo/rolbck.cxx |2
sw/source/core/unocore/unosett.cxx | 13
sw/source/core/unocore/unostyle.cxx |2
10 files changed, 206 insertions(+), 28 deletions(-)
New commits:
commit cf15c4dad74e31a035c0d1ca899dfbef4da90ad2
Author: Noel Grandin
AuthorDate: Wed Jun 23 08:51:05 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Jun 30 17:53:36 2021 +0200
tdf#135316 optimise SwCharFormats::FindFormatByName
reduces load time by 10%
Change-Id: Ic5c90588825592245d09f8ebe03b13e34676496a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117699
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/charformats.hxx b/sw/inc/charformats.hxx
new file mode 100644
index ..f72958298ea8
--- /dev/null
+++ b/sw/inc/charformats.hxx
@@ -0,0 +1,114 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+#pragma once
+
+#include "docary.hxx"
+#include
+#include
+#include
+#include
+#include
+#include
+
+// Like o3tl::find_partialorder_ptrequals
+// We don't allow duplicated object entries!
+struct char_formats_name_key
+: boost::multi_index::composite_key<
+ SwCharFormat*,
+ boost::multi_index::const_mem_fun,
+ boost::multi_index::identity // the actual object
pointer
+ >
+{
+};
+
+typedef boost::multi_index_container<
+SwCharFormat*,
+boost::multi_index::indexed_by,
+
boost::multi_index::ordered_unique>>
+SwCharFormatsBase;
+
+class SW_DLLPUBLIC SwCharFormats final : public SwFormatsBase
+{
+// function updating ByName index via modify
+friend void SwFormat::SetName(const OUString&, bool);
+
+public:
+typedef SwCharFormatsBase::nth_index<0>::type ByPos;
+typedef SwCharFormatsBase::nth_index<1>::type ByName;
+typedef ByPos::iterator iterator;
+
+private:
+SwCharFormatsBase m_Array;
+ByPos& m_PosIndex;
+ByName& m_NameIndex;
+
+public:
+typedef ByPos::const_iterator const_iterator;
+typedef SwCharFormatsBase::size_type size_type;
+typedef SwCharFormatsBase::value_type value_type;
+
+SwCharFormats();
+// frees all SwCharFormat!
+virtual ~SwCharFormats() override;
+
+bool empty() const { return m_Array.empty(); }
+size_t size() const { return m_Array.size(); }
+
+// Only fails, if you try to insert the same object twice
+void insert(SwCharFormat* x);
+
+// This will try to remove the exact object!
+void erase(const_iterator const& position);
+
+// Get the iterator of the exact object (includes pointer!),
+// e.g for position with std::distance.
+// There is also ContainsFormat, if you don't need the position.
+const_iterator find(const SwCharFormat* x) const;
+size_t GetPos(const SwCharFormat* p) const;
+
+// search for formats by name
+ByName::const_iterator findByName(const OUString& name) const;
+// So we can actually check for end()
+ByName::const_iterator byNameEnd() const { return m_NameIndex.end(); }
+
+SwCharFormat* operator[](size_t index_) const { return
m_PosIndex.operator[](index_); }
+const_iterator begin() const { return m_PosIndex.begin(); }
+const_iterator end() const { return m_PosIndex.end(); }
+
+void dumpAsXml(xmlTextWriterPtr pWriter) const;
+
+virtual size_t GetFormatCount() const override { return m_Array.size(); }
+virtual SwCharFormat* GetFormat(size_t idx) const override { return
operator[](idx); }
+
+/// fast check if given format is contained here
+/// @precond pFormat must not have been deleted
+bool ContainsFormat(SwCharFormat* pFormat) const;
+/// not so fast check that given format is still alive (i.e. contained
here)
+bool
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - external/gpgmepp external/libassuan external/libgpg-error
Rebased ref, commits from common ancestor: commit 731010a3124c92458be5c7c4839e8804d1c32463 Author: Christian Lohmaier AuthorDate: Sat May 1 10:40:58 2021 +0200 Commit: Michael Stahl CommitDate: Wed Jun 30 17:52:46 2021 +0200 avoid windres preprocessor quoting-messups with current cygwin apparently fresh installs of cygwin behave differently with the windres command's quoting and treats --preprocessor='cpp foo bar' as a single file "cpp foo bar" to run instead of running "cpp" with the arguments "foo" and "bar". (-D and -I options are passed to the preprocessor automatically, so no need to prefix those with --preprocessor-arg) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114965 Tested-by: Jenkins Reviewed-by: Georgy Litvinov Reviewed-by: Christian Lohmaier (cherry picked from commit 07f1ec0af02a9ab6c1bf6e6478092ee50495afa7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114971 Reviewed-by: Michael Stahl (cherry picked from commit 3589180bfa67bc2ef411a56c9e8bb161f6c59902) Change-Id: I711e968206f0769ff07152ebb9572e8b71c30cec diff --git a/external/gpgmepp/ExternalProject_gpgmepp.mk b/external/gpgmepp/ExternalProject_gpgmepp.mk index 8ecdf60e6f87..e190f44eda63 100644 --- a/external/gpgmepp/ExternalProject_gpgmepp.mk +++ b/external/gpgmepp/ExternalProject_gpgmepp.mk @@ -39,7 +39,7 @@ $(call gb_ExternalProject_get_state_target,gpgmepp,build): $(call gb_Executable_ $(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS)) \ $(if $(call gb_Module__symbols_enabled,gpgmepp),$(gb_DEBUGINFO_FLAGS))' \ --host=$(gb_ExternalProject_gpgmepp_host) \ - RC='windres -O COFF --target=$(gb_ExternalProject_gpgmepp_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ + RC='windres -O COFF --target=$(gb_ExternalProject_gpgmepp_target) --preprocessor=$(call gb_Executable_get_target_for_build,cpp) --preprocessor-arg=-+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)' \ MAKE=$(MAKE) \ && $(MAKE) \ ) diff --git a/external/libassuan/ExternalProject_libassuan.mk b/external/libassuan/ExternalProject_libassuan.mk index 83d79a520988..381632cc3215 100644 --- a/external/libassuan/ExternalProject_libassuan.mk +++ b/external/libassuan/ExternalProject_libassuan.mk @@ -34,7 +34,7 @@ $(call gb_ExternalProject_get_state_target,libassuan,build): $(call gb_Executabl GPG_ERROR_CFLAGS="$(GPG_ERROR_CFLAGS)" \ GPG_ERROR_LIBS="$(GPG_ERROR_LIBS)" \ --host=$(gb_ExternalProject_libassuan_host) \ - RC='windres -O COFF --target=$(gb_ExternalProject_libassuan_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ + RC='windres -O COFF --target=$(gb_ExternalProject_libassuan_target) --preprocessor=$(call gb_Executable_get_target_for_build,cpp) --preprocessor-arg=-+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)' \ MAKE=$(MAKE) \ && $(MAKE) \ ) diff --git a/external/libgpg-error/ExternalProject_libgpg-error.mk b/external/libgpg-error/ExternalProject_libgpg-error.mk index 1fcd63180e20..6b7b0ac8e6a2 100644 --- a/external/libgpg-error/ExternalProject_libgpg-error.mk +++ b/external/libgpg-error/ExternalProject_libgpg-error.mk @@ -28,7 +28,7 @@ $(call gb_ExternalProject_get_state_target,libgpg-error,build): $(call gb_Execut --disable-doc \ --disable-tests \ --host=$(gb_ExternalProject_libgpg-error_host) \ - RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ + RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor=$(call gb_Executable_get_target_for_build,cpp) --preprocessor-arg=-+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)' \ && $(MAKE) \ ) else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - external/libgpg-error
Rebased ref, commits from common ancestor: commit 35e7eaff44da47278eae41d6fec6507c5911dee2 Author: Christian Lohmaier AuthorDate: Sat May 1 10:40:58 2021 +0200 Commit: Michael Stahl CommitDate: Wed Jun 30 17:44:45 2021 +0200 avoid windres preprocessor quoting-messups with current cygwin apparently fresh installs of cygwin behave differently with the windres command's quoting and treats --preprocessor='cpp foo bar' as a single file "cpp foo bar" to run instead of running "cpp" with the arguments "foo" and "bar". (-D and -I options are passed to the preprocessor automatically, so no need to prefix those with --preprocessor-arg) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114965 Tested-by: Jenkins Reviewed-by: Georgy Litvinov Reviewed-by: Christian Lohmaier (cherry picked from commit 07f1ec0af02a9ab6c1bf6e6478092ee50495afa7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114971 Reviewed-by: Michael Stahl (cherry picked from commit 3589180bfa67bc2ef411a56c9e8bb161f6c59902) Change-Id: I711e968206f0769ff07152ebb9572e8b71c30cec diff --git a/external/libgpg-error/ExternalProject_libgpg-error.mk b/external/libgpg-error/ExternalProject_libgpg-error.mk index 1fcd63180e20..6b7b0ac8e6a2 100644 --- a/external/libgpg-error/ExternalProject_libgpg-error.mk +++ b/external/libgpg-error/ExternalProject_libgpg-error.mk @@ -28,7 +28,7 @@ $(call gb_ExternalProject_get_state_target,libgpg-error,build): $(call gb_Execut --disable-doc \ --disable-tests \ --host=$(gb_ExternalProject_libgpg-error_host) \ - RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ + RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor=$(call gb_Executable_get_target_for_build,cpp) --preprocessor-arg=-+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)' \ && $(MAKE) \ ) else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143081] Basic Replace() function crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=143081 Robert Großkopf changed: What|Removed |Added Component|Extensions |BASIC --- Comment #22 from Robert Großkopf --- (In reply to Jean-Pierre Ledure from comment #21) > I could reproduce the crash with a minimalist scenario. > > It has nothing to do with Base or BaseDocumenter. > > Run simply next Basic statements in any empty document: > > Sub Main > Dim a As String, b As String > a = """Straße""" > b = Replace(a, , "") > End Sub > > LO crashes instantly. > > I presume it has to do with the fact that > - the replacement is by default case-insensitive > - the upper case of character "ß" is 2 characters long, and not only 1 > > I change the title of the bug to "Basic Replace() function crashes LO" Following this comment I change the component to BASIC. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - external/libgpg-error
external/libgpg-error/ExternalProject_libgpg-error.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6825c3bab0392a4cbdb149b9c3ae0e7a9d7d0200 Author: Christian Lohmaier AuthorDate: Sat May 1 10:40:58 2021 +0200 Commit: Michael Stahl CommitDate: Wed Jun 30 17:35:19 2021 +0200 avoid windres preprocessor quoting-messups with current cygwin apparently fresh installs of cygwin behave differently with the windres command's quoting and treats --preprocessor='cpp foo bar' as a single file "cpp foo bar" to run instead of running "cpp" with the arguments "foo" and "bar". (-D and -I options are passed to the preprocessor automatically, so no need to prefix those with --preprocessor-arg) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114965 Tested-by: Jenkins Reviewed-by: Georgy Litvinov Reviewed-by: Christian Lohmaier (cherry picked from commit 07f1ec0af02a9ab6c1bf6e6478092ee50495afa7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114971 Reviewed-by: Michael Stahl (cherry picked from commit 3589180bfa67bc2ef411a56c9e8bb161f6c59902) Change-Id: I711e968206f0769ff07152ebb9572e8b71c30cec diff --git a/external/libgpg-error/ExternalProject_libgpg-error.mk b/external/libgpg-error/ExternalProject_libgpg-error.mk index 1fcd63180e20..ed9b6f716525 100644 --- a/external/libgpg-error/ExternalProject_libgpg-error.mk +++ b/external/libgpg-error/ExternalProject_libgpg-error.mk @@ -28,7 +28,7 @@ $(call gb_ExternalProject_get_state_target,libgpg-error,build): $(call gb_Execut --disable-doc \ --disable-tests \ --host=$(gb_ExternalProject_libgpg-error_host) \ - RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ + RC='windres -O COFF --target=$(gb_ExternalProject_libgpg-error_target) --preprocessor=$(call gb_Executable_get_target_for_build,cpp) --preprocessor-arg=-+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ && $(MAKE) \ ) else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143134] New: PDF restrictions in signed PDF documents
https://bugs.documentfoundation.org/show_bug.cgi?id=143134 Bug ID: 143134 Summary: PDF restrictions in signed PDF documents Product: LibreOffice Version: 7.1.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: renato...@gmail.com Description: This is an inquire about digital signatures on PDF files. First, I would like to congratulate about the well done job which delivers digital signature to PDF at LibreOffice. The process has been implemented by a very good functionality; however, The departament of my city is not accepting the signed PDF once they intend to add notes and new signatures to the same PDF. Retrieving permissions of the signed PDF in another PDF reader, I realized that new comments and signatures are not allowed in their software. Some permissions that had been allowed before the signature process became restricted after the signature at LibreOffice. I also realized that their software are opening PDF in read-only status. To sum up, the signed PDF generated have been flagged with no comments, no new signatures and no editable permissions. Therefore, I would request you to provide new flags available through checkbox selection in PDF exportation or PDG signing process. PS.: a ICP Brasil token was used in the process. Steps to Reproduce: Steps to Reproduce: 1. Export PDF; 2. Sign PDF; 3. Open PDF in Third-part software. Actual Results: Actual Results: Third-party are not allowed to add comments or new digital signatures. Comments are not allowed; and the following message in Third-party software "The document was opened in read-only mode" Expected Results: Expected Results: It is expected that the Third-party could add new signatures and comments after PDF signing at LibreOffice. Reproducible: Always User Profile Reset: No Additional Info: Other Information: It would be great if we could deal with PDF restrictions/permissions flags. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142090] Font antialiasing in libreoffice does not work under wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=142090 --- Comment #9 from Martin Tlustos --- xdg-desktop-portal-kde and xdg-desktop-portal-gtk are both installed. I don't know of any specific gtk or font setting I changed other than changing the default font size to 10, and using breeze-dark as desktop theme (and a corresponding desktop theme for gnome). But reversing those settings to default doesn't help either. I also installed gnome-settings-daemon as suggested in the thread you posted, but to no avail so far (I'll try again after restarting). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143115] FILEOPEN DOCX marked as change and asks for a save on close
https://bugs.documentfoundation.org/show_bug.cgi?id=143115 --- Comment #6 from Telesto --- 1. Open attachment 164149 (and/or attachment 163771 ;source for attachment 163770 , comment 0) 2. Save to DOCX 3. File - Reload 4. Gray cross -> Asks for save -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70633] Writer EDITING: Some IME unable to use AltGr to produce supplementary plane chars
https://bugs.documentfoundation.org/show_bug.cgi?id=70633 Caolán McNamara changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=85850 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133919] FILEOPEN XLS Time values rounded incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=133919 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |3132| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143132] FILEOPEN XLSX Second values are incorrectly not rounded
https://bugs.documentfoundation.org/show_bug.cgi?id=143132 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |3919| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70633] Writer EDITING: Some IME unable to use AltGr to produce supplementary plane chars
https://bugs.documentfoundation.org/show_bug.cgi?id=70633 --- Comment #24 from Caolán McNamara --- My effort at https://gerrit.libreoffice.org/c/core/+/118170 appears to make the described initial case in comment #1 work. Whether there are unintended consequences though is an currently unknown. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103309 Bug 103309 depends on bug 134640, which changed state. Bug 134640 Summary: Print dialog: dialog size is not remembered after reopening (GEN) https://bugs.documentfoundation.org/show_bug.cgi?id=134640 What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134640] Print dialog: dialog size is not remembered after reopening (GEN)
https://bugs.documentfoundation.org/show_bug.cgi?id=134640 Telesto changed: What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- --- Comment #36 from Telesto --- (In reply to Heiko Tietze from comment #34) > Caolan removed the broken code completely in > https://gerrit.libreoffice.org/c/core/+/114874 > > He argues that size depends on content and screen settings (font size, > scaling etc.). If we change the dialog it wont fit user settings anymore. I don't follow the reasoning? A commit is pushed doesn't make anything final. The issue - the bug - is still there. The solution for bug 127782 makes the dialog less productive for the rest (and being rather pain in the ass to work with) Is it not possible to simply set both "more expanders" to 'true' on dialog creation if certain screen resolution is detected? This should make the window to fit the full content; as size of dialog matches the content. This would mean: exposing all settings & preventing the scrollbar in dialog effect Putting the bug back to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143128] Searching for german special characters (ä, ö, ü, ß) provides wrong results
https://bugs.documentfoundation.org/show_bug.cgi?id=143128 --- Comment #2 from Stephan <8...@gmx.net> --- ä, ö, ü "Check the "Diaktritisch-sensitiv" option in the search dialog to only find ä / ö." This works, thank you. but: ß "ß also matching for ss is intentional/if you don't want that you need to enable case-sensitive matching" This is not good. When I have to activate case-sensitive matching to get only the real "ß", I miss all hits of a word at the beginning of a sentence: "daß" will be found, "Daß" will not. It is not practicable to search for the letter "ß" isolated, especially in longer text, since in many words it is correct. Why not activate matching for "ß" with the button "diakritisch-sensitiv", too? Since there is no capital ß in typography, the letter ß is never case-sensitive... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source sc/uiconfig
sc/source/ui/dbgui/scuiasciiopt.cxx | 24 ++--
sc/source/ui/inc/scuiasciiopt.hxx |4 --
sc/uiconfig/scalc/ui/textimportcsv.ui | 50 +++---
3 files changed, 16 insertions(+), 62 deletions(-)
New commits:
commit dba4f1031ef5b308f60f354c160187321cba6bbe
Author: Pedro Pinto Silva
AuthorDate: Thu May 27 16:01:49 2021 +0200
Commit: Pedro Silva
CommitDate: Wed Jun 30 16:47:12 2021 +0200
Dialog: Import CSV: Improve layout
Remove extra padding from headers, they are already in bold no need
to add extra padding to emphasis hierarchy.
Do not use the first header to repeat what the dialog title already says
"Import", use instead "Character encoding" as the first header of the
first group (advantage: 1st dropdown does not need extra labeling)
The 2 radio buttons for Use/not use separators appear to be
grouping the elements underneath them. This is wrong, all those options
are actually related only to the user chooses to use separators.
- Convert those two radio buttons in one check button labeled "Use
separators"
- Fixes the confusion above mentioned
- Reduced the amount of items
- It does force the user to do trial and error in order to
understand
what is what
Change-Id: Iee63a6dd336d7c5a4e6f5ce8c845b32902e49a73
Signed-off-by: Pedro Pinto Silva
Signed-off-by: Mert Tumer
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116265
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118091
diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index 2d8efaefa3f3..af0c601c6010 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -295,14 +295,12 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent,
const OUString& aDatNa
, mcTextSep(ScAsciiOptions::cDefaultTextSep)
, meCall(eCall)
, mbDetectSpaceSep(eCall != SC_TEXTTOCOLUMNS)
-, mxFtCharSet(m_xBuilder->weld_label("textcharset"))
, mxLbCharSet(new
SvxTextEncodingBox(m_xBuilder->weld_combo_box("charset")))
, mxFtCustomLang(m_xBuilder->weld_label("textlanguage"))
, mxLbCustomLang(new
SvxLanguageBox(m_xBuilder->weld_combo_box("language")))
, mxFtRow(m_xBuilder->weld_label("textfromrow"))
, mxNfRow(m_xBuilder->weld_spin_button("fromrow"))
-, mxRbFixed(m_xBuilder->weld_radio_button("tofixedwidth"))
-, mxRbSeparated(m_xBuilder->weld_radio_button("toseparatedby"))
+, mxRbSeparated(m_xBuilder->weld_check_button("toseparatedby"))
, mxCkbTab(m_xBuilder->weld_check_button("tab"))
, mxCkbSemicolon(m_xBuilder->weld_check_button("semicolon"))
, mxCkbComma(m_xBuilder->weld_check_button("comma"))
@@ -370,7 +368,7 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent,
const OUString& aDatNa
if (bSkipEmptyCells)
mxCkbSkipEmptyCells->set_active(true);
if (bFixedWidth && !bIsTSV)
-mxRbFixed->set_active(true);
+mxRbSeparated->set_active(false);
if (nFromRow != 1)
mxNfRow->set_value(nFromRow);
@@ -500,10 +498,9 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent,
const OUString& aDatNa
mxTableBox->SetColTypeHdl( LINK( this, ScImportAsciiDlg, ColTypeHdl ) );
mxRbSeparated->connect_clicked( LINK( this, ScImportAsciiDlg, RbSepFixHdl
) );
-mxRbFixed->connect_clicked( LINK( this, ScImportAsciiDlg, RbSepFixHdl ) );
SetupSeparatorCtrls();
-RbSepFixHdl(*mxRbFixed);
+RbSepFixHdl( *mxRbSeparated );
UpdateVertical();
@@ -511,7 +508,6 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent,
const OUString& aDatNa
if (meCall == SC_TEXTTOCOLUMNS)
{
-mxFtCharSet->set_sensitive(false);
mxLbCharSet->set_sensitive(false);
mxFtCustomLang->set_sensitive(false);
mxLbCustomLang->set_active_id(LANGUAGE_SYSTEM);
@@ -551,7 +547,7 @@ bool ScImportAsciiDlg::GetLine( sal_uLong nLine, OUString
, sal_Unicode& r
return false;
bool bRet = true;
-bool bFixed = mxRbFixed->get_active();
+bool bFixed = !mxRbSeparated->get_active();
if (!mpRowPosArray)
mpRowPosArray.reset( new sal_uLong[ASCIIDLG_MAXROWS + 2] );
@@ -614,7 +610,7 @@ void ScImportAsciiDlg::GetOptions( ScAsciiOptions& rOpt )
rOpt.SetCharSet( meCharSet );
rOpt.SetCharSetSystem( mbCharSetSystem );
rOpt.SetLanguage(mxLbCustomLang->get_active_id());
-rOpt.SetFixedLen( mxRbFixed->get_active() );
+rOpt.SetFixedLen( !mxRbSeparated->get_active() );
rOpt.SetStartRow( mxNfRow->get_value() );
mxTableBox->FillColumnData( rOpt );
if( mxRbSeparated->get_active() )
@@ -634,7 +630,7 @@ void ScImportAsciiDlg::SaveParameters()
{
lcl_SaveSeparators( maFieldSeparators, mxCbTextSep->get_active_text(),
mxCkbAsOnce->get_active(),
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/sidebar/StylePresetsPanel.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit d2cbf5d1aba6a2a74b0e6ca99cb27242f9582a94
Author: Tomaž Vajngerl
AuthorDate: Thu Sep 24 12:30:10 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Wed Jun 30 16:23:25 2021 +0200
StylePresets: set bacground color for ValueSet
Change-Id: Ifbaab139235dbe2fdcebf278bce2c91c2b744aa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118150
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sw/source/uibase/sidebar/StylePresetsPanel.cxx
b/sw/source/uibase/sidebar/StylePresetsPanel.cxx
index 79b1b93ed34c..981f26b3e839 100644
--- a/sw/source/uibase/sidebar/StylePresetsPanel.cxx
+++ b/sw/source/uibase/sidebar/StylePresetsPanel.cxx
@@ -13,8 +13,9 @@
#include "StylePresetsPanel.hxx"
#include
-#include
+#include
#include
+#include
#include
#include
@@ -145,6 +146,7 @@ StylePresetsPanel::StylePresetsPanel(weld::Widget* pParent)
{
mxValueSet->SetColCount(2);
+
mxValueSet->SetColor(Application::GetSettings().GetStyleSettings().GetFaceColor());
mxValueSet->SetDoubleClickHdl(LINK(this, StylePresetsPanel,
DoubleClickHdl));
RefreshList();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/styles/ColorSets.cxx | 32
1 file changed, 16 insertions(+), 16 deletions(-)
New commits:
commit 4a68396d3fe055cde57d7122d6f2618b87a81e9e
Author: Tomaž Vajngerl
AuthorDate: Wed Sep 23 13:33:59 2015 +0200
Commit: Tomaž Vajngerl
CommitDate: Wed Jun 30 16:22:57 2021 +0200
swap text and background colors in colorsets
Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118149
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx
index 0c68d726a017..7a04eb4e6314 100644
--- a/svx/source/styles/ColorSets.cxx
+++ b/svx/source/styles/ColorSets.cxx
@@ -28,10 +28,10 @@ void ColorSets::init()
{
{
ColorSet aColorSet("Breeze");
-aColorSet.add(0, 0x232629);
-aColorSet.add(1, 0xFCFCFC);
-aColorSet.add(2, 0x31363B);
-aColorSet.add(3, 0xEFF0F1);
+aColorSet.add(0, 0xFCFCFC);
+aColorSet.add(1, 0x232629);
+aColorSet.add(2, 0xEFF0F1);
+aColorSet.add(3, 0x31363B);
aColorSet.add(4, 0xDA4453);
aColorSet.add(5, 0xF47750);
aColorSet.add(6, 0xFDBC4B);
@@ -44,10 +44,10 @@ void ColorSets::init()
}
{
ColorSet aColorSet("Material Blue");
-aColorSet.add(0, 0x212121);
-aColorSet.add(1, 0xFF);
-aColorSet.add(2, 0x37474F);
-aColorSet.add(3, 0xECEFF1);
+aColorSet.add(0, 0xFF);
+aColorSet.add(1, 0x212121);
+aColorSet.add(2, 0xECEFF1);
+aColorSet.add(3, 0x37474F);
aColorSet.add(4, 0x7986CB);
aColorSet.add(5, 0x303F9F);
aColorSet.add(6, 0x64B5F6);
@@ -60,10 +60,10 @@ void ColorSets::init()
}
{
ColorSet aColorSet("Material Red");
-aColorSet.add(0, 0x212121);
-aColorSet.add(1, 0xFF);
-aColorSet.add(2, 0x424242);
-aColorSet.add(3, 0xF5F5F5);
+aColorSet.add(0, 0xFF);
+aColorSet.add(1, 0x212121);
+aColorSet.add(2, 0xF5F5F5);
+aColorSet.add(3, 0x424242);
aColorSet.add(4, 0xFF9800);
aColorSet.add(5, 0xFF6D00);
aColorSet.add(6, 0xFF5722);
@@ -76,10 +76,10 @@ void ColorSets::init()
}
{
ColorSet aColorSet("Material Green");
-aColorSet.add(0, 0x212121);
-aColorSet.add(1, 0xFF);
-aColorSet.add(2, 0x424242);
-aColorSet.add(3, 0xF5F5F5);
+aColorSet.add(0, 0xFF);
+aColorSet.add(1, 0x212121);
+aColorSet.add(2, 0xF5F5F5);
+aColorSet.add(3, 0x424242);
aColorSet.add(4, 0x009688);
aColorSet.add(5, 0x00bfa5);
aColorSet.add(6, 0x4caf50);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142391] Use binary image format 0x13 only when necessary, to allow compatibility with other suites
https://bugs.documentfoundation.org/show_bug.cgi?id=142391 --- Comment #4 from Mike Kaganski --- (In reply to Tarun Sharma from comment #3) > But i didn't got this error message on saving the document. Which would mean that you didn't set the password, as mentioned in step 4 of comment 1. If you are sure you have followed all steps carefully, then please attach the resulting file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89964] Requesting a native 'Preview Handler' for Windows explorer shell
https://bugs.documentfoundation.org/show_bug.cgi?id=89964 --- Comment #8 from Metis IT --- +1 for this, many people use the preview pane in the windows explorer, it would greatly improve usability / alternative to MS office. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
