[Libreoffice-commits] core.git: idl/source
idl/source/objects/types.cxx | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
New commits:
commit 7a6fb939053f0c4f5c3e653fe4b21bc2d904d7dc
Author: Arnaud VERSINI
AuthorDate: Fri Dec 24 20:23:28 2021 +0100
Commit: Mike Kaganski
CommitDate: Sat Dec 25 08:32:26 2021 +0100
idl : remove useless define and copy the code directly !
Change-Id: I92d53beb110a44624b72f7ec76ab8d1089f9caf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127438
Reviewed-by: Noel Grandin
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/idl/source/objects/types.cxx b/idl/source/objects/types.cxx
index 46262e7b98d9..a3dde07d96a7 100644
--- a/idl/source/objects/types.cxx
+++ b/idl/source/objects/types.cxx
@@ -119,17 +119,15 @@ void SvMetaAttribute::Insert(SvSlotElementList&)
{
}
-#define CTOR\
-: nType( MetaTypeType::Base ) \
-, bIsItem( false ) \
-
SvMetaType::SvMetaType()
-CTOR
+: nType( MetaTypeType::Base )
+, bIsItem( false )
{
}
SvMetaType::SvMetaType( const OString& rName )
-CTOR
+: nType( MetaTypeType::Base )
+, bIsItem( false )
{
SetName( rName );
}
[Libreoffice-bugs] [Bug 146410] Colibre: The Clone Formatting icons does not look like a paint brush
https://bugs.documentfoundation.org/show_bug.cgi?id=146410 Rizal Muttaqin changed: What|Removed |Added Blocks||117497 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117497 [Bug 117497] [META] Colibre icons -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Rizal Muttaqin changed: What|Removed |Added Depends on||146410 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146410 [Bug 146410] Colibre: The Clone Formatting icons does not look like a paint brush -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146410] Colibre: The Clone Formatting icons does not look like a paint brush
https://bugs.documentfoundation.org/show_bug.cgi?id=146410 --- Comment #1 from Rizal Muttaqin --- The patch is here https://gerrit.libreoffice.org/c/core/+/127448 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/changepicture.png |binary icon-themes/colibre/cmd/32/compressgraphic.png|binary icon-themes/colibre/cmd/32/crop.png |binary icon-themes/colibre/cmd/32/gallery.png|binary icon-themes/colibre/cmd/32/graphicdialog.png |binary icon-themes/colibre/cmd/32/graphicfiltersepia.png |binary icon-themes/colibre/cmd/32/imagebutton.png|binary icon-themes/colibre/cmd/32/imagecontrol.png |binary icon-themes/colibre/cmd/32/imagemapdialog.png |binary icon-themes/colibre/cmd/32/insertgraphic.png |binary icon-themes/colibre/cmd/32/photoalbumdialog.png |binary icon-themes/colibre/cmd/lc_changepicture.png |binary icon-themes/colibre/cmd/lc_compressgraphic.png|binary icon-themes/colibre/cmd/lc_crop.png |binary icon-themes/colibre/cmd/lc_gallery.png|binary icon-themes/colibre/cmd/lc_graphicdialog.png |binary icon-themes/colibre/cmd/lc_graphicfiltersepia.png |binary icon-themes/colibre/cmd/lc_imagebutton.png|binary icon-themes/colibre/cmd/lc_imagecontrol.png |binary icon-themes/colibre/cmd/lc_imagemapdialog.png |binary icon-themes/colibre/cmd/lc_insertgraphic.png |binary icon-themes/colibre/cmd/lc_photoalbumdialog.png |binary icon-themes/colibre/cmd/sc_changepicture.png |binary icon-themes/colibre/cmd/sc_compressgraphic.png|binary icon-themes/colibre/cmd/sc_gallery.png|binary icon-themes/colibre/cmd/sc_graphicdialog.png |binary icon-themes/colibre/cmd/sc_graphicfiltersepia.png |binary icon-themes/colibre/cmd/sc_imagebutton.png|binary icon-themes/colibre/cmd/sc_imagecontrol.png |binary icon-themes/colibre/cmd/sc_imagemapdialog.png |binary icon-themes/colibre/cmd/sc_insertgraphic.png |binary icon-themes/colibre/cmd/sc_photoalbumdialog.png |binary icon-themes/colibre/res/grafikde.png |binary icon-themes/colibre/res/grafikei.png |binary icon-themes/colibre/res/lx03125.png |binary icon-themes/colibre/res/sx03125.png |binary icon-themes/colibre/sd/res/image.png |binary icon-themes/colibre/sd/res/placeholder_image_large.png|binary icon-themes/colibre/sd/res/placeholder_image_large_hover.png |binary icon-themes/colibre/sd/res/placeholder_image_small.png|binary icon-themes/colibre/sd/res/placeholder_image_small_hover.png |binary icon-themes/colibre/svx/res/cd02.png |binary icon-themes/colibre/svx/res/galdefl.png |binary icon-themes/colibre/svx/res/galdefs.png |binary icon-themes/colibre/svx/res/galnorl.png |binary icon-themes/colibre/svx/res/galnors.png |binary icon-themes/colibre/svx/res/galrdol.png |binary icon-themes/colibre/svx/res/galrdos.png |binary icon-themes/colibre/svx/res/symphony/ColorModeNormal_16x16.png|binary icon-themes/colibre/svx/res/symphony/ColorModeWaterMark_16x16.png |binary icon-themes/colibre_svg/cmd/32/changepicture.svg |2 +- icon-themes/colibre_svg/cmd/32/compressgraphic.svg|2 +- icon-themes/colibre_svg/cmd/32/crop.svg |2 +- icon-themes/colibre_svg/cmd/32/gallery.svg|2 +- icon-themes/colibre_svg/cmd/32/graphicdialog.svg |2 +- icon-themes/colibre_svg/cmd/32/graphicfiltersepia.svg |2 +- icon-themes/colibre_svg/cmd/32/imagebutton.svg|2 +- icon-themes/colibre_svg/cmd/32/imagecontrol.svg |2 +- icon-themes/colibre_svg/cmd/32/imagemapdialog.svg |2 +- icon-themes/colibre_svg/cmd/32/insertgraphic.svg |2 +- icon-themes/colibre_svg/cmd/32/photoalbumdialog.svg |2 +- icon-themes/colibre_svg/cmd/lc_changepicture.svg |2 +- icon-themes/colibre_svg/cmd/lc_compressgraphic.svg|
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/changepicture.png |binary icon-themes/colibre/cmd/32/compressgraphic.png|binary icon-themes/colibre/cmd/32/crop.png |binary icon-themes/colibre/cmd/32/gallery.png|binary icon-themes/colibre/cmd/32/graphicdialog.png |binary icon-themes/colibre/cmd/32/graphicfiltersepia.png |binary icon-themes/colibre/cmd/32/imagebutton.png|binary icon-themes/colibre/cmd/32/imagecontrol.png |binary icon-themes/colibre/cmd/32/imagemapdialog.png |binary icon-themes/colibre/cmd/32/insertgraphic.png |binary icon-themes/colibre/cmd/32/photoalbumdialog.png |binary icon-themes/colibre/cmd/lc_changepicture.png |binary icon-themes/colibre/cmd/lc_compressgraphic.png|binary icon-themes/colibre/cmd/lc_crop.png |binary icon-themes/colibre/cmd/lc_gallery.png|binary icon-themes/colibre/cmd/lc_graphicdialog.png |binary icon-themes/colibre/cmd/lc_graphicfiltersepia.png |binary icon-themes/colibre/cmd/lc_imagebutton.png|binary icon-themes/colibre/cmd/lc_imagecontrol.png |binary icon-themes/colibre/cmd/lc_imagemapdialog.png |binary icon-themes/colibre/cmd/lc_insertgraphic.png |binary icon-themes/colibre/cmd/lc_photoalbumdialog.png |binary icon-themes/colibre/cmd/sc_changepicture.png |binary icon-themes/colibre/cmd/sc_compressgraphic.png|binary icon-themes/colibre/cmd/sc_gallery.png|binary icon-themes/colibre/cmd/sc_graphicdialog.png |binary icon-themes/colibre/cmd/sc_graphicfiltersepia.png |binary icon-themes/colibre/cmd/sc_imagebutton.png|binary icon-themes/colibre/cmd/sc_imagecontrol.png |binary icon-themes/colibre/cmd/sc_imagemapdialog.png |binary icon-themes/colibre/cmd/sc_insertgraphic.png |binary icon-themes/colibre/cmd/sc_photoalbumdialog.png |binary icon-themes/colibre/res/grafikde.png |binary icon-themes/colibre/res/grafikei.png |binary icon-themes/colibre/res/lx03125.png |binary icon-themes/colibre/res/sx03125.png |binary icon-themes/colibre/sd/res/image.png |binary icon-themes/colibre/sd/res/placeholder_image_large.png|binary icon-themes/colibre/sd/res/placeholder_image_large_hover.png |binary icon-themes/colibre/sd/res/placeholder_image_small.png|binary icon-themes/colibre/sd/res/placeholder_image_small_hover.png |binary icon-themes/colibre/svx/res/cd02.png |binary icon-themes/colibre/svx/res/galdefl.png |binary icon-themes/colibre/svx/res/galdefs.png |binary icon-themes/colibre/svx/res/galnorl.png |binary icon-themes/colibre/svx/res/galnors.png |binary icon-themes/colibre/svx/res/galrdol.png |binary icon-themes/colibre/svx/res/galrdos.png |binary icon-themes/colibre/svx/res/symphony/ColorModeNormal_16x16.png|binary icon-themes/colibre/svx/res/symphony/ColorModeWaterMark_16x16.png |binary icon-themes/colibre_svg/cmd/32/changepicture.svg |2 +- icon-themes/colibre_svg/cmd/32/compressgraphic.svg|2 +- icon-themes/colibre_svg/cmd/32/crop.svg |2 +- icon-themes/colibre_svg/cmd/32/gallery.svg|2 +- icon-themes/colibre_svg/cmd/32/graphicdialog.svg |2 +- icon-themes/colibre_svg/cmd/32/graphicfiltersepia.svg |2 +- icon-themes/colibre_svg/cmd/32/imagebutton.svg|2 +- icon-themes/colibre_svg/cmd/32/imagecontrol.svg |2 +- icon-themes/colibre_svg/cmd/32/imagemapdialog.svg |2 +- icon-themes/colibre_svg/cmd/32/insertgraphic.svg |2 +- icon-themes/colibre_svg/cmd/32/photoalbumdialog.svg |2 +- icon-themes/colibre_svg/cmd/lc_changepicture.svg |2 +- icon-themes/colibre_svg/cmd/lc_compressgraphic.svg|
[Libreoffice-bugs] [Bug 146410] New: Colibre: The Clone Formatting icons does not look like a paint brush
https://bugs.documentfoundation.org/show_bug.cgi?id=146410 Bug ID: 146410 Summary: Colibre: The Clone Formatting icons does not look like a paint brush Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org Created attachment 177133 --> https://bugs.documentfoundation.org/attachment.cgi?id=177133=edit Clone Formatting looks a flimsy brush While it's not quite necessary, the icon for "Clone Formatting" in current Colibre theme does not look like a paint brush at all. The suggestion is to update it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - unotools/source unoxml/inc unoxml/source
unotools/source/ucbhelper/XTempFile.hxx |4 +-
unotools/source/ucbhelper/xtempfile.cxx | 61
unoxml/inc/event.hxx|3 +
unoxml/source/events/event.cxx | 18 -
unoxml/source/events/mouseevent.cxx | 21 +--
unoxml/source/events/mutationevent.cxx | 15 ---
unoxml/source/events/uievent.cxx|7 +--
7 files changed, 66 insertions(+), 63 deletions(-)
New commits:
commit 870a3b5bc34d5d4082b46940822d871106cac2d9
Author: Noel Grandin
AuthorDate: Thu Dec 23 21:38:41 2021 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 25 07:15:33 2021 +0100
osl::Mutex->std::mutex in CEvent
Change-Id: I644ebf86803448e824818f571d6612741408d02c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127402
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unoxml/inc/event.hxx b/unoxml/inc/event.hxx
index c33d8f9d3b3c..216bf2775ed4 100644
--- a/unoxml/inc/event.hxx
+++ b/unoxml/inc/event.hxx
@@ -27,6 +27,7 @@
#include
#include
+#include
namespace DOM::events
{
@@ -35,7 +36,7 @@ class CEvent : public cppu::WeakImplHelper<
css::xml::dom::events::XEvent >
friend class CEventDispatcher;
protected:
-::osl::Mutex m_Mutex;
+std::mutex m_Mutex;
bool m_canceled;
OUString m_eventType;
css::uno::Reference< css::xml::dom::events::XEventTarget > m_target;
diff --git a/unoxml/source/events/event.cxx b/unoxml/source/events/event.cxx
index bc12bb5f83c1..e3b092ff3831 100644
--- a/unoxml/source/events/event.cxx
+++ b/unoxml/source/events/event.cxx
@@ -39,52 +39,52 @@ namespace DOM::events
OUString SAL_CALL CEvent::getType()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_eventType;
}
Reference< XEventTarget > SAL_CALL
CEvent::getTarget()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_target;
}
Reference< XEventTarget > SAL_CALL
CEvent::getCurrentTarget()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_currentTarget;
}
PhaseType SAL_CALL CEvent::getEventPhase()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_phase;
}
sal_Bool SAL_CALL CEvent::getBubbles()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_bubbles;
}
sal_Bool SAL_CALL CEvent::getCancelable()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_cancelable;
}
css::util::Time SAL_CALL
CEvent::getTimeStamp()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_time;
}
void SAL_CALL CEvent::stopPropagation()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
if (m_cancelable) { m_canceled = true; }
}
@@ -96,7 +96,7 @@ namespace DOM::events
CEvent::initEvent(OUString const& eventTypeArg, sal_Bool canBubbleArg,
sal_Bool cancelableArg)
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
m_eventType = eventTypeArg;
m_bubbles = canBubbleArg;
diff --git a/unoxml/source/events/mouseevent.cxx
b/unoxml/source/events/mouseevent.cxx
index ee22b8905c70..4ae8a1b55741 100644
--- a/unoxml/source/events/mouseevent.cxx
+++ b/unoxml/source/events/mouseevent.cxx
@@ -40,47 +40,47 @@ namespace DOM::events
sal_Int32 SAL_CALL CMouseEvent::getScreenX()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_screenX;
}
sal_Int32 SAL_CALL CMouseEvent::getScreenY()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_screenY;
}
sal_Int32 SAL_CALL CMouseEvent::getClientX()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_clientX;
}
sal_Int32 SAL_CALL CMouseEvent::getClientY()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_clientY;
}
sal_Bool SAL_CALL CMouseEvent::getCtrlKey()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_ctrlKey;
}
sal_Bool SAL_CALL CMouseEvent::getShiftKey()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_shiftKey;
}
sal_Bool SAL_CALL CMouseEvent::getAltKey()
{
-::osl::MutexGuard const g(m_Mutex);
+std::unique_lock const g(m_Mutex);
return m_altKey;
}
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - filter/qa filter/source sfx2/source
filter/qa/unit/textfilterdetect.cxx | 20
filter/source/textfilterdetect/filterdetect.cxx |6 +-
sfx2/source/doc/objstor.cxx | 10 +-
3 files changed, 34 insertions(+), 2 deletions(-)
New commits:
commit da88d0e570493cc6b0f56744bfbc00d829b26ee7
Author: Miklos Vajna
AuthorDate: Tue Dec 21 14:31:34 2021 +0100
Commit: Mike Kaganski
CommitDate: Sat Dec 25 06:48:11 2021 +0100
filter: try to detect 0-byte DOC files based on extension
Commit ae1f51b4888a3aa14837ac6e4083f33b2176ca45 (tdf#123476 filter: try
to detect 0-byte files based on extension, 2020-10-28), already
implemented this UNO-based import filters, do the same for built-in
filters as well.
Another problem in filter/ was to pick the WW6 filter for .doc --
require export+preferred support in the filter to get WW8 instead.
An additional filter that may kick in is MS Word 2003 XML: this is
avoided by requiring "preferred".
(cherry picked from commit e519d7465f38367205b37bc80f0244029e352306)
Conflicts:
filter/qa/unit/textfilterdetect.cxx
Change-Id: I46e280beb5341213b0fe7a09a549b52c0c1ea3f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127296
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127432
diff --git a/filter/qa/unit/data/empty.doc b/filter/qa/unit/data/empty.doc
new file mode 100644
index ..e69de29bb2d1
diff --git a/filter/qa/unit/textfilterdetect.cxx
b/filter/qa/unit/textfilterdetect.cxx
index 74d967490ffe..4083610b0736 100644
--- a/filter/qa/unit/textfilterdetect.cxx
+++ b/filter/qa/unit/textfilterdetect.cxx
@@ -116,6 +116,26 @@ CPPUNIT_TEST_FIXTURE(TextFilterDetectTest, testEmptyFile)
// Without the accompanying fix in place, this test would have failed, as
it was opened in
// Writer instead.
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.presentation.PresentationDocument"));
+getComponent()->dispose();
+
+// ... and DOC
+aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "empty.doc";
+// Without the accompanying fix in place, this test would have failed, the
import filter aborted
+// loading.
+getComponent() = loadFromDesktop(aURL);
+xServiceInfo.set(getComponent(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xServiceInfo.is());
+
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextDocument"));
+uno::Reference xModel(getComponent(), uno::UNO_QUERY);
+uno::Sequence aArgs = xModel->getArgs();
+comphelper::SequenceAsHashMap aMap(aArgs);
+OUString aFilterName;
+aMap["FilterName"] >>= aFilterName;
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: MS Word 97
+// - Actual : MS WinWord 6.0
+// i.e. opening worked, but saving back failed instead of producing a WW8
binary file.
+CPPUNIT_ASSERT_EQUAL(OUString("MS Word 97"), aFilterName);
}
}
diff --git a/filter/source/textfilterdetect/filterdetect.cxx
b/filter/source/textfilterdetect/filterdetect.cxx
index 1f5080ad0951..4a6314c9224a 100644
--- a/filter/source/textfilterdetect/filterdetect.cxx
+++ b/filter/source/textfilterdetect/filterdetect.cxx
@@ -149,7 +149,11 @@ bool HandleEmptyFileUrlByExtension(MediaDescriptor&
rMediaDesc, const OUString&
return false;
}
-std::shared_ptr
pFilter(SfxFilterMatcher().GetFilter4Extension(rExt));
+// Requiring the export+preferred flags helps to find the relevant filter,
e.g. .doc -> WW8 (and
+// not WW6 or Mac_Word).
+SfxFilterFlags nMust
+= SfxFilterFlags::IMPORT | SfxFilterFlags::EXPORT |
SfxFilterFlags::PREFERED;
+std::shared_ptr
pFilter(SfxFilterMatcher().GetFilter4Extension(rExt, nMust));
if (!pFilter)
{
return false;
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 49d90e54c599..abdb402e507e 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -774,7 +774,15 @@ bool SfxObjectShell::DoLoad( SfxMedium *pMed )
}
else
{
-bOk = ConvertFrom(*pMedium);
+if (tools::isEmptyFileUrl(pMedium->GetName()))
+{
+// The import filter would fail with empty input.
+bOk = true;
+}
+else
+{
+bOk = ConvertFrom(*pMedium);
+}
InitOwnModel_Impl();
}
}
[Libreoffice-bugs] [Bug 146409] New: customize keyboard simpler
https://bugs.documentfoundation.org/show_bug.cgi?id=146409 Bug ID: 146409 Summary: customize keyboard simpler Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: solot...@gmail.com as a user it would be cool that customize keyboard would be simpler in the following aspects: search for a function, and display what keys do. two suggestions which would make the access quicker: first: have 3 instead of 2 columnfs for shortcut keys, instead of key + function have key + writer, key + libreoffice. the radio butteon "libreoffcie" "writer" could then go away. instead have 2 modify buttons, modify writer, modify libreoffice. second: make the search for all commands work. currently typing "inden" does not retrieve style Text body indent, one needs to click on styles to find it. in version 7.2.4.1 this is, linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146172] Window "Table of Contents, Index or Bibliography." out screen
https://bugs.documentfoundation.org/show_bug.cgi?id=146172 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146171] Tracked changes with no date (0000-00-00) in .doc(x) documents are no longer tracked when converted to ODF format.
https://bugs.documentfoundation.org/show_bug.cgi?id=146171 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146169] LibreOffice Writer prints one copy when I requested 20
https://bugs.documentfoundation.org/show_bug.cgi?id=146169 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146168] Font attributes of certain list numbers have changed after 7.2, and I can't change them back
https://bugs.documentfoundation.org/show_bug.cgi?id=146168 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146162] JUMBO SHEETS: cannot hide all columns
https://bugs.documentfoundation.org/show_bug.cgi?id=146162 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146161] Consider renaming button "open" in templates dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=146161 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146157] Please make the inverted question marks after trailing equality signs optional
https://bugs.documentfoundation.org/show_bug.cgi?id=146157 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146154] Wrong amount of selected text is highlighted in mixed LTR/RTL text
https://bugs.documentfoundation.org/show_bug.cgi?id=146154 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146391] hlookup: when the search criteria contains a number, the search result will be NV
https://bugs.documentfoundation.org/show_bug.cgi?id=146391 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146391] hlookup: when the search criteria contains a number, the search result will be NV
https://bugs.documentfoundation.org/show_bug.cgi?id=146391 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90380] VIEWING: Navigator causes constant cpu usage when it does not have focus in documents with lots of text frames and images
https://bugs.documentfoundation.org/show_bug.cgi?id=90380 --- Comment #9 from QA Administrators --- Dear Gordo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142493] Footnote Anchor and Footnote characters don't save the styles when I save as doc or docx end reopen the saved document
https://bugs.documentfoundation.org/show_bug.cgi?id=142493 --- Comment #4 from QA Administrators --- Dear Antonio, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131063] Navigate document content when selection is made by single click in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=131063 --- Comment #19 from Jim Raykowski --- (In reply to golemus from comment #18) > ok. Would it be difficult to implement it so that in future you could change > context menu of navigator through Tools -- Customize -- Context menus? Or > perhaps even the navigator toolbar (although I don't use the toolbar but I > guess somebody does as it is there). Best to open an enhancement request for adding a way to customizing the navigator context menu directly in Writer. You can already customize the navigator context menu by manually editing the 'navigatorcontextmenu.ui' file. usr/lib/libreoffice/share/config/soffice.cfg/modules/swriter/ui/navigatorcontextmenu.ui ALWAYS GOOD TO MAKE A BACKUP COPY BEFORE MODIFYING :-) To make the promote/demote menu items not appear in the context menu either remove the following lines or set to False as I have done. False False Promote Chapter True False False Demote Chapter True False False Promote Level True False False Demote Level True -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145700] FiLEOPEN DOC lighting direction has inverted z-direction for extruded custom shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=145700 --- Comment #8 from Regina Henschel --- Created attachment 177132 --> https://bugs.documentfoundation.org/attachment.cgi?id=177132=edit Test file in doc format, so that you can open it directly in LO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145700] FiLEOPEN DOC lighting direction has inverted z-direction for extruded custom shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=145700 --- Comment #7 from Regina Henschel --- Created attachment 177131 --> https://bugs.documentfoundation.org/attachment.cgi?id=177131=edit Test file with non-default settings as mentioned in previous attachment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145700] FiLEOPEN DOC lighting direction has inverted z-direction for extruded custom shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=145700 --- Comment #6 from Regina Henschel --- Created attachment 177130 --> https://bugs.documentfoundation.org/attachment.cgi?id=177130=edit Proof, that z-axis points towards observer I'm sure now, that in MS Office the z-axis points towards observer. For screenshots and calculations see the attached files. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106613] UI: Sidebar navigator in Impress/Draw not updated immediately when page/slide is renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=106613 --- Comment #13 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9bfc42015acd6ae3475ab7927ccc006507cc38a2 tdf#146003 tdf#106613 Draw: fix slide rename not updated in Navigator It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106613] UI: Sidebar navigator in Impress/Draw not updated immediately when page/slide is renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=106613 Commit Notification changed: What|Removed |Added Whiteboard|target:7.1.0 target:7.0.4 |target:7.1.0 target:7.0.4 ||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/source
sd/source/ui/slidesorter/controller/SlsSlotManager.cxx |9 +++--
sd/source/ui/view/drviewsb.cxx |8 +---
sd/source/ui/view/drviewsd.cxx |3 ---
3 files changed, 8 insertions(+), 12 deletions(-)
New commits:
commit 9bfc42015acd6ae3475ab7927ccc006507cc38a2
Author: Jim Raykowski
AuthorDate: Thu Dec 23 20:46:59 2021 -0900
Commit: Jim Raykowski
CommitDate: Fri Dec 24 23:21:24 2021 +0100
tdf#146003 tdf#106613 Draw: fix slide rename not updated in Navigator
Change-Id: Iee2d34e3192e3f7875ab10f3e79e9dc1a2fb20b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127397
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx
b/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx
index 89d10e310725..8ade9b296462 100644
--- a/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx
@@ -1029,12 +1029,9 @@ bool SlotManager::RenameSlideFromDrawViewShell(
sal_uInt16 nPageId, const OUStri
pDocument->SetChanged();
// inform navigator about change
-SfxBoolItem aItem( SID_NAVIGATOR_INIT, true );
-if (mrSlideSorter.GetViewShell() != nullptr)
-mrSlideSorter.GetViewShell()->GetDispatcher()->ExecuteList(
-SID_NAVIGATOR_INIT,
-SfxCallMode::ASYNCHRON | SfxCallMode::RECORD,
-{ });
+if (mrSlideSorter.GetViewShell() &&
mrSlideSorter.GetViewShell()->GetViewFrame())
+
mrSlideSorter.GetViewShell()->GetViewFrame()->GetBindings().Invalidate(
+SID_NAVIGATOR_STATE, true);
}
return bSuccess;
diff --git a/sd/source/ui/view/drviewsb.cxx b/sd/source/ui/view/drviewsb.cxx
index 5bc741c91269..6f6bba8555d5 100644
--- a/sd/source/ui/view/drviewsb.cxx
+++ b/sd/source/ui/view/drviewsb.cxx
@@ -97,9 +97,11 @@ bool DrawViewShell::RenameSlide( sal_uInt16 nPageId, const
OUString & rName )
GetDoc()->SetChanged();
// inform navigator about change
-SfxBoolItem aItem( SID_NAVIGATOR_INIT, true );
-GetViewFrame()->GetDispatcher()->ExecuteList(SID_NAVIGATOR_INIT,
-SfxCallMode::ASYNCHRON | SfxCallMode::RECORD, { });
+if (GetViewFrame())
+{
+SfxBindings& rBindings = GetViewFrame()->GetBindings();
+rBindings.Invalidate(SID_NAVIGATOR_STATE, true);
+}
// Tell the slide sorter about the name change (necessary for
// accessibility.)
diff --git a/sd/source/ui/view/drviewsd.cxx b/sd/source/ui/view/drviewsd.cxx
index 763ae13eac91..0926e02990e5 100644
--- a/sd/source/ui/view/drviewsd.cxx
+++ b/sd/source/ui/view/drviewsd.cxx
@@ -61,9 +61,6 @@ void DrawViewShell::ExecNavigatorWin( SfxRequest& rReq )
if( pNavWin )
pNavWin->InitTreeLB( GetDoc() );
}
-SfxBindings& rBindings = GetViewFrame()->GetBindings();
-rBindings.Invalidate(SID_NAVIGATOR_STATE, true);
-rBindings.Invalidate(SID_NAVIGATOR_PAGENAME, true);
}
break;
[Libreoffice-commits] core.git: tools/source
tools/source/fsys/urlobj.cxx | 91 +--
1 file changed, 37 insertions(+), 54 deletions(-)
New commits:
commit 132d652ad1af4ec067fe08e388e8ddba963ddc2b
Author: Mike Kaganski
AuthorDate: Fri Dec 24 21:37:17 2021 +0100
Commit: Mike Kaganski
CommitDate: Fri Dec 24 23:09:14 2021 +0100
Simplify INetURLObject::parseHostOrNetBiosName
Change-Id: I18818e89b2e6f0ef203caa51ba554c281753d3f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127383
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 7b86fe0f5261..67cb1f1cd024 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -2831,67 +2831,50 @@ bool INetURLObject::parseHostOrNetBiosName(
EncodeMechanism eMechanism, rtl_TextEncoding eCharset, bool bNetBiosName,
OUStringBuffer* pCanonic)
{
+if (pBegin >= pEnd)
+return true;
sal_Int32 nOriginalCanonicLength = pCanonic ? pCanonic->getLength() : 0;
-if (pBegin < pEnd)
+if (sal_Unicode const* p = pBegin; parseHost(p, pEnd, pCanonic) && p ==
pEnd)
+return true;
+if (pCanonic)
+pCanonic->setLength(nOriginalCanonicLength); // discard parseHost
results
+if (!bNetBiosName)
+return false;
+while (pBegin < pEnd)
{
-sal_Unicode const * p = pBegin;
-if (!parseHost(p, pEnd, pCanonic) || p != pEnd)
+EscapeType eEscapeType;
+sal_uInt32 nUTF32 = getUTF32(pBegin, pEnd, eMechanism, eCharset,
eEscapeType);
+switch (nUTF32)
{
-if (bNetBiosName)
-{
-OUStringBuffer buf;
-while (pBegin < pEnd)
-{
-EscapeType eEscapeType;
-sal_uInt32 nUTF32 = getUTF32(pBegin, pEnd,
- eMechanism, eCharset,
- eEscapeType);
-if (!INetMIME::isVisible(nUTF32))
-{
-if (pCanonic)
-pCanonic->setLength(nOriginalCanonicLength);
-return false;
-}
-if (!rtl::isAsciiAlphanumeric(nUTF32))
-switch (nUTF32)
-{
-case '"':
-case '*':
-case '+':
-case ',':
-case '/':
-case ':':
-case ';':
-case '<':
-case '=':
-case '>':
-case '?':
-case '[':
-case '\\':
-case ']':
-case '`':
-case '|':
-return false;
-}
-if (pCanonic != nullptr) {
-appendUCS4(
-buf, nUTF32, eEscapeType, PART_URIC,
-eCharset, true);
-}
-}
-if (pCanonic)
-{
-pCanonic->setLength(nOriginalCanonicLength);
-pCanonic->append(buf);
-}
-}
-else
-{
+case '"':
+case '*':
+case '+':
+case ',':
+case '/':
+case ':':
+case ';':
+case '<':
+case '=':
+case '>':
+case '?':
+case '[':
+case '\\':
+case ']':
+case '`':
+case '|':
if (pCanonic)
pCanonic->setLength(nOriginalCanonicLength);
return false;
-}
+default:
+if (!INetMIME::isVisible(nUTF32))
+{
+if (pCanonic)
+pCanonic->setLength(nOriginalCanonicLength);
+return false;
+}
}
+if (pCanonic)
+appendUCS4(*pCanonic, nUTF32, eEscapeType, PART_URIC, eCharset,
true);
}
return true;
}
[Libreoffice-bugs] [Bug 146408] Неверное получение сохраненной записи при её открытии
https://bugs.documentfoundation.org/show_bug.cgi?id=146408 aleksandrakorobov...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146408] New: Неверное получение сохраненной записи при её открытии
https://bugs.documentfoundation.org/show_bug.cgi?id=146408 Bug ID: 146408 Summary: Неверное получение сохраненной записи при её открытии Product: cppunit Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aleksandrakorobov...@gmail.com CC: markus.mohrh...@googlemail.com Created attachment 177129 --> https://bugs.documentfoundation.org/attachment.cgi?id=177129=edit Неверное получение сохраненной записи "Выполнение лабораторной работы" После открытия созданной записи, вместо требуемой информации выводится сообщение «System error». -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146406] Неверное получение сохраненной записи
https://bugs.documentfoundation.org/show_bug.cgi?id=146406 aleksandrakorobov...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146406] Неверное получение сохраненной записи
https://bugs.documentfoundation.org/show_bug.cgi?id=146406 aleksandrakorobov...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/tools sal/rtl sal/textenc sax/source stoc/source tools/source vcl/source vcl/win
include/tools/inetmime.hxx| 14 +--
sal/rtl/uri.cxx | 31
---
sal/rtl/ustrbuf.cxx | 12 ---
sal/textenc/convertbig5hkscs.cxx | 14 +--
sal/textenc/converteuctw.cxx | 10 +-
sal/textenc/convertgb18030.cxx| 13 +--
sal/textenc/convertisciidevangari.cxx |8 +-
sal/textenc/convertiso2022cn.cxx | 10 +-
sal/textenc/convertiso2022jp.cxx |8 +-
sal/textenc/convertiso2022kr.cxx |8 +-
sal/textenc/convertsinglebytetobmpunicode.cxx |8 +-
sal/textenc/handleundefinedunicodetotextchar.cxx |4 -
sal/textenc/tcvtutf8.cxx | 13 +--
sal/textenc/unichars.hxx | 24 --
sax/source/expatwrap/saxwriter.cxx| 40
+-
stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx |9 --
tools/source/inet/inetmime.cxx| 28
---
vcl/source/gdi/scrptrun.cxx | 10 +-
vcl/win/window/salframe.cxx |5 -
19 files changed, 87 insertions(+), 182 deletions(-)
New commits:
commit 8b333c76945960fc62a01829666ba234f59a6d94
Author: Mike Kaganski
AuthorDate: Fri Dec 24 15:25:52 2021 +0300
Commit: Mike Kaganski
CommitDate: Fri Dec 24 21:42:08 2021 +0100
Use rtl functions instead of own surrogate checking/combining
Change-Id: I3eb05d8f5b0761bc3b672d4c855eb469f8cc1a29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127375
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/tools/inetmime.hxx b/include/tools/inetmime.hxx
index ce0469fa131a..a3c7de49690c 100644
--- a/include/tools/inetmime.hxx
+++ b/include/tools/inetmime.hxx
@@ -227,16 +227,12 @@ inline int INetMIME::getHexWeight(sal_uInt32 nChar)
inline sal_uInt32 INetMIME::getUTF32Character(const sal_Unicode *& rBegin,
const sal_Unicode * pEnd)
{
-DBG_ASSERT(rBegin && rBegin < pEnd,
+assert(rBegin && rBegin < pEnd &&
"INetMIME::getUTF32Character(): Bad sequence");
-if (rBegin + 1 < pEnd && rBegin[0] >= 0xD800 && rBegin[0] <= 0xDBFF
-&& rBegin[1] >= 0xDC00 && rBegin[1] <= 0xDFFF)
-{
-sal_uInt32 nUTF32 = sal_uInt32(*rBegin++ & 0x3FF) << 10;
-return (nUTF32 | (*rBegin++ & 0x3FF)) + 0x1;
-}
-else
-return *rBegin++;
+sal_uInt32 nUTF32 = *rBegin++;
+if (rBegin < pEnd && rtl::isHighSurrogate(nUTF32) &&
rtl::isLowSurrogate(rBegin[0]))
+nUTF32 = rtl::combineSurrogates(nUTF32, *rBegin++);
+return nUTF32;
}
diff --git a/sal/rtl/uri.cxx b/sal/rtl/uri.cxx
index 441a6c69f1e8..0c5479563405 100644
--- a/sal/rtl/uri.cxx
+++ b/sal/rtl/uri.cxx
@@ -219,21 +219,7 @@ namespace {
void writeUcs4(rtl_uString ** pBuffer, sal_Int32 * pCapacity, sal_uInt32
nUtf32)
{
-assert(rtl::isUnicodeCodePoint(nUtf32));
-if (nUtf32 <= 0x)
-{
-writeUnicode(pBuffer, pCapacity, static_cast< sal_Unicode >(nUtf32));
-}
-else
-{
-nUtf32 -= 0x1;
-writeUnicode(
-pBuffer, pCapacity,
-static_cast< sal_Unicode >(nUtf32 >> 10 | 0xD800));
-writeUnicode(
-pBuffer, pCapacity,
-static_cast< sal_Unicode >((nUtf32 & 0x3FF) | 0xDC00));
-}
+rtl_uStringbuffer_insertUtf32(pBuffer, pCapacity, (*pBuffer)->length,
nUtf32);
}
void writeEscapeOctet(rtl_uString ** pBuffer, sal_Int32 * pCapacity,
@@ -284,20 +270,7 @@ bool writeEscapeChar(rtl_uString ** pBuffer, sal_Int32 *
pCapacity,
rtl_UnicodeToTextConverter aConverter
= rtl_createUnicodeToTextConverter(eCharset);
sal_Unicode aSrc[2];
-sal_Size nSrcSize;
-if (nUtf32 <= 0x)
-{
-aSrc[0] = static_cast< sal_Unicode >(nUtf32);
-nSrcSize = 1;
-}
-else
-{
-aSrc[0] = static_cast< sal_Unicode >(
-((nUtf32 - 0x1) >> 10) | 0xD800);
-aSrc[1] = static_cast< sal_Unicode >(
-((nUtf32 - 0x1) & 0x3FF) | 0xDC00);
-nSrcSize = 2;
-}
+sal_Size nSrcSize = rtl::splitSurrogates(nUtf32, aSrc);
char aDst[32]; // FIXME random value
sal_uInt32 nInfo;
diff --git a/sal/rtl/ustrbuf.cxx b/sal/rtl/ustrbuf.cxx
index 53e178e5881a..7c5b187edbcb 100644
--- a/sal/rtl/ustrbuf.cxx
+++ b/sal/rtl/ustrbuf.cxx
@@ -174,17 +174,7 @@ void rtl_uStringbuffer_insertUtf32(
SAL_THROW_EXTERN_C()
{
sal_Unicode
[Libreoffice-bugs] [Bug 146406] Неверное получение сохраненной записи
https://bugs.documentfoundation.org/show_bug.cgi?id=146406 Michael Warner changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Michael Warner --- Machine translation - Failed Retrieval of Stored Lab Progress Record After opening the created record, instead of the required information, the message “System error” is displayed. —- How is this related to LibreOffice? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/moduleoptions.cxx | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
New commits:
commit fd4acfaca9fc012313f03f46e927add6feb6a553
Author: Noel Grandin
AuthorDate: Thu Dec 23 19:37:42 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 20:19:22 2021 +0100
osl::Mutex->std::mutex in SvtModuleOptions
Change-Id: I6882b30c823d06aa04c04c8a17bfe33cc45d7307
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127415
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unotools/source/config/moduleoptions.cxx
b/unotools/source/config/moduleoptions.cxx
index 324736359b6e..967191c06e1f 100644
--- a/unotools/source/config/moduleoptions.cxx
+++ b/unotools/source/config/moduleoptions.cxx
@@ -762,9 +762,9 @@ namespace {
//global
std::weak_ptr g_pModuleOptions;
-osl::Mutex& impl_GetOwnStaticMutex()
+std::mutex& impl_GetOwnStaticMutex()
{
-static osl::Mutex s_Mutex;
+static std::mutex s_Mutex;
return s_Mutex;
}
}
@@ -785,13 +785,14 @@ SvtModuleOptions::SvtModuleOptions()
return;
// take the mutex, so we don't accidentally create more than one
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
m_pImpl = g_pModuleOptions.lock();
if( !m_pImpl )
{
m_pImpl = std::make_shared();
g_pModuleOptions = m_pImpl;
+aGuard.unlock(); // because holdConfigItem will call this constructor
ItemHolder1::holdConfigItem(EItem::ModuleOptions);
}
}
@@ -823,32 +824,32 @@ const OUString & SvtModuleOptions::GetFactoryName(
EFactory eFactory ) const
OUString SvtModuleOptions::GetFactoryStandardTemplate( EFactory eFactory )
const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return m_pImpl->GetFactoryStandardTemplate( eFactory );
}
OUString SvtModuleOptions::GetFactoryEmptyDocumentURL( EFactory eFactory )
const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return SvtModuleOptions_Impl::GetFactoryEmptyDocumentURL( eFactory );
}
OUString SvtModuleOptions::GetFactoryDefaultFilter( EFactory eFactory ) const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return m_pImpl->GetFactoryDefaultFilter( eFactory );
}
bool SvtModuleOptions::IsDefaultFilterReadonly( EFactory eFactory ) const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
m_pImpl->MakeReadonlyStatesAvailable();
return m_pImpl->IsDefaultFilterReadonly( eFactory );
}
sal_Int32 SvtModuleOptions::GetFactoryIcon( EFactory eFactory ) const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return m_pImpl->GetFactoryIcon( eFactory );
}
@@ -862,14 +863,14 @@ bool SvtModuleOptions::ClassifyFactoryByName(
std::u16string_view sName,
void SvtModuleOptions::SetFactoryStandardTemplate( EFactory
eFactory ,
const OUString& sTemplate )
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
m_pImpl->SetFactoryStandardTemplate( eFactory, sTemplate );
}
void SvtModuleOptions::SetFactoryDefaultFilter( EFactory
eFactory,
const OUString& sFilter )
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
m_pImpl->SetFactoryDefaultFilter( eFactory, sFilter );
}
@@ -899,7 +900,7 @@ bool SvtModuleOptions::IsDraw() const
bool SvtModuleOptions::IsWriter() const
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return m_pImpl->IsModuleInstalled( EModule::WRITER );
}
@@ -1086,7 +1087,7 @@ SvtModuleOptions::EFactory
SvtModuleOptions::ClassifyFactoryByModel(const css::u
css::uno::Sequence < OUString > SvtModuleOptions::GetAllServiceNames()
{
-::osl::MutexGuard aGuard( impl_GetOwnStaticMutex() );
+std::unique_lock aGuard( impl_GetOwnStaticMutex() );
return m_pImpl->GetAllServiceNames();
}
[Libreoffice-commits] core.git: svx/source
svx/source/xml/xmlgrhlp.cxx | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
New commits:
commit addd00fefe246e3045380e97e9a66a39a23ecb4a
Author: Noel Grandin
AuthorDate: Fri Dec 24 14:20:44 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 20:17:15 2021 +0100
use comphelper::WeakComponentImplHelper in SvXMLGraphicImportExportHelper
Change-Id: Ieb76e57ac8c9e2f456e5d7d2c127668d5f2b8490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127418
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index 96be71b78769..a20db0d073d2 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -31,8 +31,7 @@
#include
#include
#include
-#include
-#include
+#include
#include
#include
@@ -930,7 +929,7 @@ namespace {
namespace impl
{
-typedef cppu::WeakComponentImplHelper xComp( m_xGraphicObjectResolver, UNO_QUERY );
OSL_ASSERT( xComp.is());
[Libreoffice-commits] core.git: canvas/inc canvas/source
canvas/inc/parametricpolypolygon.hxx | 10 --
canvas/source/tools/parametricpolypolygon.cxx | 10 +++---
2 files changed, 7 insertions(+), 13 deletions(-)
New commits:
commit 439cb9d60d853b9521def7931a68226b95de48a8
Author: Noel Grandin
AuthorDate: Fri Dec 24 09:58:44 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 20:16:38 2021 +0100
use comphelper::WeakComponentImplHelper in ParametricPolyPolygon
Change-Id: I923970389870ced5e8e310c0f73859117b1cedb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127405
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/inc/parametricpolypolygon.hxx
b/canvas/inc/parametricpolypolygon.hxx
index 089c42e76f57..0d39700ff488 100644
--- a/canvas/inc/parametricpolypolygon.hxx
+++ b/canvas/inc/parametricpolypolygon.hxx
@@ -21,8 +21,7 @@
#include
#include
-#include
-#include
+#include
#include
#include
@@ -35,11 +34,10 @@ namespace com::sun::star::rendering { class XGraphicDevice;
}
namespace canvas
{
-typedef cppu::WeakComponentImplHelper<
css::rendering::XParametricPolyPolygon2D,
+typedef comphelper::WeakComponentImplHelper<
css::rendering::XParametricPolyPolygon2D,
css::lang::XServiceInfo >
ParametricPolyPolygon_Base;
-class CANVASTOOLS_DLLPUBLIC ParametricPolyPolygon final : public
::cppu::BaseMutex,
- public ParametricPolyPolygon_Base
+class CANVASTOOLS_DLLPUBLIC ParametricPolyPolygon final : public
ParametricPolyPolygon_Base
{
public:
enum class GradientType
@@ -92,7 +90,7 @@ namespace canvas
const css::uno::Sequence< css::uno::Any >& rArgs );
/// Dispose all internal references
-virtual void SAL_CALL disposing() override;
+virtual void disposing() override;
// XParametricPolyPolygon2D
virtual css::uno::Reference< css::rendering::XPolyPolygon2D > SAL_CALL
getOutline( double t ) override;
diff --git a/canvas/source/tools/parametricpolypolygon.cxx
b/canvas/source/tools/parametricpolypolygon.cxx
index 331b4e47535b..870f25f2ddbf 100644
--- a/canvas/source/tools/parametricpolypolygon.cxx
+++ b/canvas/source/tools/parametricpolypolygon.cxx
@@ -147,10 +147,8 @@ namespace canvas
colors, stops, fAspectRatio );
}
-void SAL_CALL ParametricPolyPolygon::disposing()
+void ParametricPolyPolygon::disposing()
{
-::osl::MutexGuard aGuard( m_aMutex );
-
mxDevice.clear();
}
@@ -174,7 +172,7 @@ namespace canvas
uno::Reference< rendering::XColorSpace > SAL_CALL
ParametricPolyPolygon::getColorSpace()
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
return mxDevice.is() ? mxDevice->getDeviceColorSpace() :
uno::Reference< rendering::XColorSpace >();
}
@@ -205,7 +203,6 @@ namespace canvas
const uno::Sequence<
uno::Sequence< double > >& rColors,
const uno::Sequence< double
>&rStops,
double
nAspectRatio ) :
-ParametricPolyPolygon_Base( m_aMutex ),
mxDevice( rDevice ),
maValues( rGradientPoly,
rColors,
@@ -219,7 +216,6 @@ namespace canvas
GradientType
eType,
const uno::Sequence<
uno::Sequence< double > >& rColors,
const uno::Sequence< double
>&rStops ) :
-ParametricPolyPolygon_Base( m_aMutex ),
mxDevice( rDevice ),
maValues( ::basegfx::B2DPolygon(),
rColors,
@@ -231,7 +227,7 @@ namespace canvas
ParametricPolyPolygon::Values ParametricPolyPolygon::getValues() const
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
return maValues;
}
[Libreoffice-commits] core.git: include/unotools unotools/source
include/unotools/cmdoptions.hxx | 11 ---
unotools/source/config/cmdoptions.cxx | 27 +--
2 files changed, 13 insertions(+), 25 deletions(-)
New commits:
commit 1576ef8532cf2cea2da361db9c5707f1994e65e2
Author: Noel Grandin
AuthorDate: Thu Dec 23 18:40:44 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 19:50:02 2021 +0100
osl::Mutex->std::mutex in SvtCommandOptions
Change-Id: I80eaba645351e2f3a3c67586fdced3325608633e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127413
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/unotools/cmdoptions.hxx b/include/unotools/cmdoptions.hxx
index d0e6792ba8b9..bb3414f8ff41 100644
--- a/include/unotools/cmdoptions.hxx
+++ b/include/unotools/cmdoptions.hxx
@@ -109,17 +109,6 @@ public:
void EstablishFrameCallback(const css::uno::Reference&
xFrame);
-private:
-
/*-
-@short return a reference to a static mutex
-@descr These class is partially threadsafe (for
de-/initialization only).
-All access methods aren't safe!
-We create a static mutex only for one ime and use at
different times.
-@return A reference to a static mutex member.
-
**-***/
-
-UNOTOOLS_DLLPRIVATE static ::osl::Mutex& GetOwnStaticMutex();
-
private:
std::shared_ptr m_pImpl;
diff --git a/unotools/source/config/cmdoptions.cxx
b/unotools/source/config/cmdoptions.cxx
index d9e061224a4a..1408f22c2480 100644
--- a/unotools/source/config/cmdoptions.cxx
+++ b/unotools/source/config/cmdoptions.cxx
@@ -84,6 +84,12 @@ class SvtCmdOptions
CommandHashMap m_aCommandHashMap;
};
+std::mutex& GetOwnStaticMutex()
+{
+static std::mutex theCommandOptionsMutex;
+return theCommandOptionsMutex;
+}
+
}
typedef ::std::vector< css::uno::WeakReference< css::frame::XFrame > >
SvtFrameVector;
@@ -185,7 +191,7 @@ SvtCommandOptions_Impl::~SvtCommandOptions_Impl()
void SvtCommandOptions_Impl::Notify( const Sequence< OUString >& )
{
-MutexGuard aGuard( SvtCommandOptions::GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
Sequence< OUString >lNames = impl_GetPropertyNames ();
Sequence< Any > lValues = GetProperties ( lNames
);
@@ -296,13 +302,14 @@ std::weak_ptr g_pCommandOptions;
SvtCommandOptions::SvtCommandOptions()
{
// Global access, must be guarded (multithreading!).
-MutexGuard aGuard( GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
m_pImpl = g_pCommandOptions.lock();
if( !m_pImpl )
{
m_pImpl = std::make_shared();
g_pCommandOptions = m_pImpl;
+aGuard.unlock(); // because holdConfigItem will call this constructor
ItemHolder1::holdConfigItem(EItem::CmdOptions);
}
}
@@ -310,7 +317,7 @@ SvtCommandOptions::SvtCommandOptions()
SvtCommandOptions::~SvtCommandOptions()
{
// Global access, must be guarded (multithreading!)
-MutexGuard aGuard( GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
m_pImpl.reset();
}
@@ -319,7 +326,7 @@ SvtCommandOptions::~SvtCommandOptions()
bool SvtCommandOptions::HasEntries( CmdOption eOption ) const
{
-MutexGuard aGuard( GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
return m_pImpl->HasEntries( eOption );
}
@@ -327,7 +334,7 @@ bool SvtCommandOptions::HasEntries( CmdOption eOption )
const
bool SvtCommandOptions::Lookup( CmdOption eCmdOption, const OUString&
aCommandURL ) const
{
-MutexGuard aGuard( GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
return m_pImpl->Lookup( eCmdOption, aCommandURL );
}
@@ -335,16 +342,8 @@ bool SvtCommandOptions::Lookup( CmdOption eCmdOption,
const OUString& aCommandUR
void SvtCommandOptions::EstablishFrameCallback(const css::uno::Reference<
css::frame::XFrame >& xFrame)
{
-MutexGuard aGuard( GetOwnStaticMutex() );
+std::unique_lock aGuard( GetOwnStaticMutex() );
m_pImpl->EstablishFrameCallback(xFrame);
}
-// private method
-
-Mutex& SvtCommandOptions::GetOwnStaticMutex()
-{
-static osl::Mutex theCommandOptionsMutex;
-return theCommandOptionsMutex;
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/pathoptions.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit d94db4056a49fc4fee73173e1ef1c943f8ecc21f
Author: Noel Grandin
AuthorDate: Thu Dec 23 19:39:05 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 19:45:55 2021 +0100
osl::Mutex->std::mutex in SvtPathOptions_Impl
Change-Id: I04d0bf2a6b00ab0da24735158ad267632356128f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127416
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unotools/source/config/pathoptions.cxx
b/unotools/source/config/pathoptions.cxx
index 60335e00dfb9..e7793d07321c 100644
--- a/unotools/source/config/pathoptions.cxx
+++ b/unotools/source/config/pathoptions.cxx
@@ -82,7 +82,7 @@ class SvtPathOptions_Impl
VarNameSet m_aSystemPathVarNames;
OUStringm_aEmptyString;
-mutable ::osl::Mutexm_aMutex;
+mutable std::mutex m_aMutex;
public:
SvtPathOptions_Impl();
@@ -210,7 +210,7 @@ const VarNameAttribute aVarNameAttribute[] =
const OUString& SvtPathOptions_Impl::GetPath( SvtPathOptions::Paths ePath )
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
try
{
@@ -263,7 +263,7 @@ const OUString& SvtPathOptions_Impl::GetPath(
SvtPathOptions::Paths ePath )
void SvtPathOptions_Impl::SetPath( SvtPathOptions::Paths ePath, const
OUString& rNewPath )
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
OUStringaResult;
OUStringaNewValue;
[Libreoffice-bugs] [Bug 97663] SVG line spacing not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=97663 --- Comment #10 from Commit Notification --- Hossein committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/8e1aea537ffe35311cc6d43d4b0cef3f4ec82367 tdf#97663 SVGIO: Fix line spacing for It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97663] SVG line spacing not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=97663 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svgio/inc svgio/qa svgio/source
svgio/inc/svgnode.hxx |2 +-
svgio/inc/svgtextnode.hxx |2 --
svgio/inc/svgtspannode.hxx |2 +-
svgio/qa/cppunit/SvgImportTest.cxx | 20
svgio/qa/cppunit/data/em_units.svg | 14 ++
svgio/source/svgreader/svgtextnode.cxx |4
6 files changed, 36 insertions(+), 8 deletions(-)
New commits:
commit 8e1aea537ffe35311cc6d43d4b0cef3f4ec82367
Author: Hossein
AuthorDate: Mon Dec 20 05:44:23 2021 +0100
Commit: Xisco Fauli
CommitDate: Fri Dec 24 19:35:15 2021 +0100
tdf#97663 SVGIO: Fix line spacing for
tdf#97663 is a regression caused by the commit
701324a1e1f7e0c181ff1a50956ced686785ea53. The previous patch caused
LO to forget the size of the font which was needed to calculate line
height based on em units.
em, px, pt, cm, in...
https://www.w3.org/Style/Examples/007/units.en.html
Accompanied with this fix is a unit test provided to avoid this
issue in the future.
The fix can be tested with:
make CPPUNIT_TEST_NAME="testTdf97663" -sr \
CppunitTest_svgio
The em_units.svg is opened with Firefox, Chrome and Inkscape and the
rendering in LibreOffice is compatible with the rendering in these
applications.
Change-Id: Idaecd9fb18101f7925fe2a917f7fc3fe7257ebc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127130
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 4e2e57b530544736804ab663f832173ba1d78559)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127376
Reviewed-by: Xisco Fauli
diff --git a/svgio/inc/svgnode.hxx b/svgio/inc/svgnode.hxx
index 63c6b2318406..58b1682506f2 100644
--- a/svgio/inc/svgnode.hxx
+++ b/svgio/inc/svgnode.hxx
@@ -159,7 +159,7 @@ namespace svgio::svgreader
virtual double getCurrentFontSizeInherited() const override;
virtual double getCurrentXHeightInherited() const override;
-virtual double getCurrentFontSize() const;
+double getCurrentFontSize() const;
double getCurrentXHeight() const;
/// Id access
diff --git a/svgio/inc/svgtextnode.hxx b/svgio/inc/svgtextnode.hxx
index b72d1043b8c0..37983ad31531 100644
--- a/svgio/inc/svgtextnode.hxx
+++ b/svgio/inc/svgtextnode.hxx
@@ -58,8 +58,6 @@ namespace svgio::svgreader
virtual void parseAttribute(const OUString& rTokenName, SVGToken
aSVGToken, const OUString& aContent) override;
virtual void
decomposeSvgNode(drawinglayer::primitive2d::Primitive2DContainer& rTarget, bool
bReferenced) const override;
-virtual double getCurrentFontSize() const override;
-
/// transform content, set if found in current context
const std::optional& getTransform() const {
return mpaTransform; }
void setTransform(const std::optional&
pMatrix) { mpaTransform = pMatrix; }
diff --git a/svgio/inc/svgtspannode.hxx b/svgio/inc/svgtspannode.hxx
index af4ae8268b5c..10a7b7ee16a9 100644
--- a/svgio/inc/svgtspannode.hxx
+++ b/svgio/inc/svgtspannode.hxx
@@ -42,7 +42,7 @@ namespace svgio::svgreader
virtual const SvgStyleAttributes* getSvgStyleAttributes() const
override;
virtual void parseAttribute(const OUString& rTokenName, SVGToken
aSVGToken, const OUString& aContent) override;
-virtual double getCurrentFontSize() const override;
+double getCurrentFontSize() const;
/// access to SvgTextPositions
const SvgTextPositions& getSvgTextPositions() const { return
maSvgTextPositions; }
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index 25baf76fdad8..3034c997015e 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -69,6 +69,7 @@ class Test : public test::BootstrapFixture, public
XmlTestTools
void testTdf101237();
void testTdf94765();
void testBehaviourWhenWidthAndHeightIsOrIsNotSet();
+void testTdf97663();
Primitive2DSequence parseSvg(std::u16string_view aSource);
@@ -104,6 +105,7 @@ public:
CPPUNIT_TEST(testTdf101237);
CPPUNIT_TEST(testTdf94765);
CPPUNIT_TEST(testBehaviourWhenWidthAndHeightIsOrIsNotSet);
+CPPUNIT_TEST(testTdf97663);
CPPUNIT_TEST_SUITE_END();
};
@@ -804,6 +806,24 @@ void Test::testBehaviourWhenWidthAndHeightIsOrIsNotSet()
}
}
+void Test::testTdf97663()
+{
+Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/em_units.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+// This can be dumped to a file using dumper.dump(container, file_url)
+Primitive2DContainer container =
comphelper::sequenceToContainer(aSequence);
+xmlDocUniquePtr pDocument = dumper.dumpAndParse(container);
+
+CPPUNIT_ASSERT (pDocument);
+
+
[Libreoffice-commits] core.git: idl/source
idl/source/objects/types.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 03faef951a0dd4352a371ead89ca79040359234b
Author: Jan-Marek Glogowski
AuthorDate: Fri Dec 24 14:42:00 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Fri Dec 24 19:21:29 2021 +0100
mergelibs: fix duplicate aSfxInt16Item_Impl
The callgrind / mergelibs build fails with:
/svx/source/form/typemap.o: in function `aSvxColorItem_Impl´: \
multiple definition of `aSfxInt16Item_Impl´; \
/sfx2/source/appl/appbas.o: first defined here
Regression from commit 60d7796624f1c56eb036d3e73d7f8a8216cce2a4
("sd theme: allow setting color effects in the sidebar").
Change-Id: Ibe382e2e12d3359caa3e853e264de0ede6a5e601
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127429
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/idl/source/objects/types.cxx b/idl/source/objects/types.cxx
index 57d62c49c24c..46262e7b98d9 100644
--- a/idl/source/objects/types.cxx
+++ b/idl/source/objects/types.cxx
@@ -231,6 +231,7 @@ void SvMetaType::WriteSfxItem(
bool bExport = false, bReturn = false;
// these are exported from sfx library
if (rItemName == "SfxBoolItem" ||
+rItemName == "SfxInt16Item" ||
rItemName == "SfxStringItem" ||
rItemName == "SfxUInt16Item" ||
rItemName == "SfxUInt32Item" ||
[Libreoffice-bugs] [Bug 136845] clicking on libreoffice help or typing F1 opens a white page NewHelp0.html in write/web
https://bugs.documentfoundation.org/show_bug.cgi?id=136845 himajin100...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6403 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146403] Help or F1 does not open my default browser
https://bugs.documentfoundation.org/show_bug.cgi?id=146403 himajin100...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||6845 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146405] SPAM (deletion request)
https://bugs.documentfoundation.org/show_bug.cgi?id=146405 V Stuart Foote changed: What|Removed |Added Resolution|FIXED |INVALID Summary|Ok |SPAM (deletion request) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/unotools unotools/source
include/unotools/useroptions.hxx |2 -
unotools/source/config/useroptions.cxx | 34 +
2 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit ac511d90cdf9d28eb8809c30be9fa08b42ea0bd3
Author: Noel Grandin
AuthorDate: Thu Dec 23 19:42:19 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 19:10:25 2021 +0100
osl::Mutex->std::mutex in SvtUserOptions
Change-Id: Ib16cc05a8d9c3e7ef828223e8b1067eeb7faf809
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127399
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/unotools/useroptions.hxx b/include/unotools/useroptions.hxx
index adc5f5055d5b..d21482dcca2d 100644
--- a/include/unotools/useroptions.hxx
+++ b/include/unotools/useroptions.hxx
@@ -60,8 +60,6 @@ public:
SvtUserOptions ();
virtual ~SvtUserOptions () override;
-static osl::Mutex& GetInitMutex ();
-
// get the address token
OUString GetCompany() const;
OUString GetFirstName () const;
diff --git a/unotools/source/config/useroptions.cxx
b/unotools/source/config/useroptions.cxx
index ffe01cca497c..448850fb84fc 100644
--- a/unotools/source/config/useroptions.cxx
+++ b/unotools/source/config/useroptions.cxx
@@ -259,34 +259,36 @@ bool SvtUserOptions::Impl::IsTokenReadonly (UserOptToken
nToken) const
beans::PropertyAttribute::READONLY);
}
+static std::mutex& GetInitMutex()
+{
+static std::mutex gMutex;
+return gMutex;
+}
+
+
SvtUserOptions::SvtUserOptions ()
{
// Global access, must be guarded (multithreading)
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
-if (xSharedImpl.expired())
+xImpl = xSharedImpl.lock();
+if (!xImpl)
{
xImpl = std::make_shared();
xSharedImpl = xImpl;
+aGuard.unlock(); // because holdConfigItem will call this constructor
ItemHolder1::holdConfigItem(EItem::UserOptions);
}
-xImpl = xSharedImpl.lock();
xImpl->AddListener(this);
}
SvtUserOptions::~SvtUserOptions()
{
// Global access, must be guarded (multithreading)
-osl::MutexGuard aGuard( GetInitMutex() );
+std::unique_lock aGuard( GetInitMutex() );
xImpl->RemoveListener(this);
}
-osl::Mutex& SvtUserOptions::GetInitMutex()
-{
-static osl::Mutex gMutex;
-return gMutex;
-}
-
OUString SvtUserOptions::GetCompany() const { return
GetToken(UserOptToken::Company); }
OUString SvtUserOptions::GetFirstName () const { return
GetToken(UserOptToken::FirstName); }
OUString SvtUserOptions::GetLastName () const { return
GetToken(UserOptToken::LastName); }
@@ -307,37 +309,37 @@ OUString SvtUserOptions::GetEncryptionKey () const {
return GetToken(UserOptTok
bool SvtUserOptions::IsTokenReadonly (UserOptToken nToken) const
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
return xImpl->IsTokenReadonly(nToken);
}
OUString SvtUserOptions::GetToken (UserOptToken nToken) const
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
return xImpl->GetToken(nToken);
}
void SvtUserOptions::SetToken (UserOptToken nToken, OUString const& rNewToken)
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
xImpl->SetToken(nToken, rNewToken);
}
void SvtUserOptions::SetBoolValue (UserOptToken nToken, bool bNewValue)
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
xImpl->SetBoolValue(nToken, bNewValue);
}
bool SvtUserOptions::GetEncryptToSelf() const
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
return xImpl->GetBoolValue(UserOptToken::EncryptToSelf);
}
OUString SvtUserOptions::GetFullName () const
{
-osl::MutexGuard aGuard(GetInitMutex());
+std::unique_lock aGuard(GetInitMutex());
return xImpl->GetFullName();
}
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/xmlgrhlp.hxx|8 ++--
svx/source/xml/xmlgrhlp.cxx | 16 +++-
2 files changed, 5 insertions(+), 19 deletions(-)
New commits:
commit 4621e719c283cb24ec6b884b55a6719a321336f3
Author: Noel Grandin
AuthorDate: Fri Dec 24 10:06:17 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 18:42:25 2021 +0100
use comphelper::WeakComponentImplHelper in SvXMLGraphicHelper
and remove unused disposing() override
Change-Id: I6423d9c3c418bb07f84e1622c8df6eac8ad762c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127406
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/include/svx/xmlgrhlp.hxx b/include/svx/xmlgrhlp.hxx
index 8a72664a5b55..0e54e1cb102b 100644
--- a/include/svx/xmlgrhlp.hxx
+++ b/include/svx/xmlgrhlp.hxx
@@ -20,8 +20,7 @@
#ifndef INCLUDED_SVX_XMLGRHLP_HXX
#define INCLUDED_SVX_XMLGRHLP_HXX
-#include
-#include
+#include
#include
#include
@@ -47,8 +46,7 @@ struct SvxGraphicHelperStream_Impl
};
class SVXCORE_DLLPUBLIC SvXMLGraphicHelper final :
-public cppu::BaseMutex,
-public
cppu::WeakComponentImplHelper
{
@@ -82,8 +80,6 @@ private:
SvXMLGraphicHelperMode eCreateMode,
const OUString& rGraphicMimeType =
OUString() );
-virtual void SAL_CALL disposing() override;
-
SVX_DLLPRIVATE OUString
implSaveGraphic(css::uno::Reference const & rxGraphic,
OUString & rOutMimeType,
std::u16string_view rRequestName);
diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index 35d3a247c56a..96be71b78769 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -367,18 +367,12 @@ const GraphicObject&
SvXMLGraphicOutputStream::GetGraphicObject()
}
SvXMLGraphicHelper::SvXMLGraphicHelper(SvXMLGraphicHelperMode eCreateMode)
-: cppu::WeakComponentImplHelper(m_aMutex)
{
Init( nullptr, eCreateMode );
}
SvXMLGraphicHelper::SvXMLGraphicHelper()
-: cppu::WeakComponentImplHelper(m_aMutex)
-, meCreateMode(SvXMLGraphicHelperMode::Read)
+: meCreateMode(SvXMLGraphicHelperMode::Read)
{
}
@@ -386,10 +380,6 @@ SvXMLGraphicHelper::~SvXMLGraphicHelper()
{
}
-void SAL_CALL SvXMLGraphicHelper::disposing()
-{
-}
-
bool SvXMLGraphicHelper::ImplGetStreamNames( const OUString& rURLStr,
OUString& rPictureStorageName,
OUString& rPictureStreamName )
@@ -580,7 +570,7 @@ OUString SAL_CALL
SvXMLGraphicHelper::resolveGraphicObjectURL( const OUString& /
// XGraphicStorageHandler
uno::Reference SAL_CALL
SvXMLGraphicHelper::loadGraphic(OUString const & rURL)
{
-osl::MutexGuard aGuard(m_aMutex);
+std::unique_lock aGuard(m_aMutex);
uno::Reference xGraphic;
@@ -612,7 +602,7 @@ uno::Reference SAL_CALL
SvXMLGraphicHelper::loadGraphic(OUStr
uno::Reference SAL_CALL
SvXMLGraphicHelper::loadGraphicFromOutputStream(uno::Reference
const & rxOutputStream)
{
-osl::MutexGuard aGuard(m_aMutex);
+std::unique_lock aGuard(m_aMutex);
uno::Reference xGraphic;
[Libreoffice-bugs] [Bug 146382] Can’t open file from Explorer-attached remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=146382 --- Comment #5 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/efa20d38fa51675e738ce50d6894b5df75debea0 tdf#146382 cant open file from Explorer-attached remote location It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146382] Can’t open file from Explorer-attached remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=146382 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - tools/qa tools/source
tools/qa/cppunit/test_urlobj.cxx |9 +
tools/source/fsys/urlobj.cxx |3 +++
2 files changed, 12 insertions(+)
New commits:
commit efa20d38fa51675e738ce50d6894b5df75debea0
Author: Noel Grandin
AuthorDate: Fri Dec 24 09:35:44 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 18:21:34 2021 +0100
tdf#146382 cant open file from Explorer-attached remote location
problem spotted by mikekaganski
regression from
commit 0b46361ef84a61100a0274a007062317607d097a
Author: Noel Grandin
Date: Sat Nov 20 08:03:49 2021 +0200
tdf#133835 speedup calc autofilter (4)
where I changed the behaviour of parseHostOrNetBiosName from overwriting
the destination buffer to appending to it.
Change-Id: I1bd3c7eade035a867c026364f5e114c1e652ca32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127352
Tested-by: Gabor Kelemen
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 15bc49228997a5da556961b923bb607642b6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127381
diff --git a/tools/qa/cppunit/test_urlobj.cxx b/tools/qa/cppunit/test_urlobj.cxx
index a335701c5cab..ec64b5d66777 100644
--- a/tools/qa/cppunit/test_urlobj.cxx
+++ b/tools/qa/cppunit/test_urlobj.cxx
@@ -311,6 +311,14 @@ namespace tools_urlobj
obj.GetMainURL(INetURLObject::DecodeMechanism::NONE));
}
+void testTd146382() {
+INetURLObject
obj("file://share.allotropia.de@SSL/DavWWWRoot/remote.php");
+CPPUNIT_ASSERT(!obj.HasError());
+CPPUNIT_ASSERT_EQUAL(
+
OUString("file://share.allotropia.de@SSL/DavWWWRoot/remote.php"),
+obj.GetMainURL(INetURLObject::DecodeMechanism::NONE));
+}
+
// Change the following lines only, if you add, remove or rename
// member functions of the current class,
// because these macros are need by auto register mechanism.
@@ -326,6 +334,7 @@ namespace tools_urlobj
CPPUNIT_TEST( testSetName );
CPPUNIT_TEST( testSetExtension );
CPPUNIT_TEST( testChangeScheme );
+CPPUNIT_TEST( testTd146382 );
CPPUNIT_TEST_SUITE_END( );
}; // class createPool
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 8c3d2845eab2..7b86fe0f5261 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -2880,7 +2880,10 @@ bool INetURLObject::parseHostOrNetBiosName(
}
}
if (pCanonic)
+{
+pCanonic->setLength(nOriginalCanonicLength);
pCanonic->append(buf);
+}
}
else
{
[Libreoffice-commits] core.git: Makefile.in
Makefile.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 69b6c87eca7d7fa1e83653750e79e04ae1d5d384
Author: Jan-Marek Glogowski
AuthorDate: Fri Dec 24 13:47:46 2021 +0100
Commit: Jan-Marek Glogowski
CommitDate: Fri Dec 24 18:20:46 2021 +0100
autogen.sh is actually in $(SRCDIR)
Change-Id: I9c58294fb607683929d370a5f2707901e2a88548
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127421
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/Makefile.in b/Makefile.in
index 92ff372429b2..3ac9ce6d3c22 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -39,6 +39,7 @@ Makefile $(BUILDDIR)/Makefile: $(BUILDDIR)/config_host.mk
$(BUILDDIR)/config_hos
# run configure in an environment not polluted by config_host.mk
$(BUILDDIR)/config_host.mk : $(wildcard \
+ $(SRCDIR)/autogen.sh \
$(SRCDIR)/config_host.mk.in \
$(SRCDIR)/config_host_lang.mk.in \
$(SRCDIR)/Makefile.in \
@@ -49,7 +50,6 @@ $(BUILDDIR)/config_host.mk : $(wildcard \
$(SRCDIR)/m4/*.m4 \
$(BUILDDIR)/autogen.input \
$(BUILDDIR)/autogen.lastrun \
- $(BUILDDIR)/autogen.sh \
) \
$(shell . $(SRCDIR)/bin/get_config_variables JAVA_HOME && \
if test -n "$${JAVA_HOME}" -a ! -d "$${JAVA_HOME}/bin";
then echo force-restart; fi)
[Libreoffice-commits] core.git: Makefile.in
Makefile.in |1 + 1 file changed, 1 insertion(+) New commits: commit 6bed8aa4462ac553921392533be646ef26f7b9e7 Author: Jan-Marek Glogowski AuthorDate: Fri Dec 24 13:45:47 2021 +0100 Commit: Jan-Marek Glogowski CommitDate: Fri Dec 24 18:20:01 2021 +0100 Re-run autogen.sh on m4 macro change Change-Id: I8cd1203bcdf1b98bb34c0fd1ec38ad3f6af0eaed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127422 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/Makefile.in b/Makefile.in index bf756f205915..92ff372429b2 100644 --- a/Makefile.in +++ b/Makefile.in @@ -46,6 +46,7 @@ $(BUILDDIR)/config_host.mk : $(wildcard \ $(SRCDIR)/configure.ac \ $(SRCDIR)/config_host/*.h.in \ $(SRCDIR)/download.lst \ + $(SRCDIR)/m4/*.m4 \ $(BUILDDIR)/autogen.input \ $(BUILDDIR)/autogen.lastrun \ $(BUILDDIR)/autogen.sh \
[Libreoffice-commits] help.git: AllLangHelp_sdatabase.mk AllLangHelp_shared.mk source/text
AllLangHelp_sdatabase.mk |9 + AllLangHelp_shared.mk |9 - source/text/sdatabase/querywizard00.xhp| 28 ++-- source/text/sdatabase/querywizard01.xhp| 16 source/text/sdatabase/querywizard02.xhp| 17 +++-- source/text/sdatabase/querywizard03.xhp| 19 --- source/text/sdatabase/querywizard04.xhp| 21 + source/text/sdatabase/querywizard05.xhp| 14 +++--- source/text/sdatabase/querywizard06.xhp| 19 --- source/text/sdatabase/querywizard07.xhp| 11 --- source/text/sdatabase/querywizard08.xhp| 17 +++-- source/text/shared/guide/data_queries.xhp |2 +- source/text/shared/guide/database_main.xhp |2 +- source/text/shared/guide/main.xhp |2 +- 14 files changed, 84 insertions(+), 102 deletions(-) New commits: commit 215707177c272f9fcf73a79b9150fe677b991716 Author: Olivier Hallot AuthorDate: Fri Dec 24 11:32:32 2021 -0300 Commit: Olivier Hallot CommitDate: Fri Dec 24 17:57:56 2021 +0100 Refactor database files Change-Id: If6acf26ea094234d06522c26c8bb8274c0abdaa5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127430 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/AllLangHelp_sdatabase.mk b/AllLangHelp_sdatabase.mk index 736b1abb4..6d607cb60 100644 --- a/AllLangHelp_sdatabase.mk +++ b/AllLangHelp_sdatabase.mk @@ -75,6 +75,15 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sdatabase,\ helpcontent2/source/text/sdatabase/menuview \ helpcontent2/source/text/sdatabase/migrate_macros \ helpcontent2/source/text/sdatabase/password \ +helpcontent2/source/text/sdatabase/querywizard00 \ +helpcontent2/source/text/sdatabase/querywizard01 \ +helpcontent2/source/text/sdatabase/querywizard02 \ +helpcontent2/source/text/sdatabase/querywizard03 \ +helpcontent2/source/text/sdatabase/querywizard04 \ +helpcontent2/source/text/sdatabase/querywizard05 \ +helpcontent2/source/text/sdatabase/querywizard06 \ +helpcontent2/source/text/sdatabase/querywizard07 \ +helpcontent2/source/text/sdatabase/querywizard08 \ helpcontent2/source/text/sdatabase/tablewizard00 \ helpcontent2/source/text/sdatabase/tablewizard01 \ helpcontent2/source/text/sdatabase/tablewizard02 \ diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk index 6e19148d1..03f5e3d5b 100644 --- a/AllLangHelp_shared.mk +++ b/AllLangHelp_shared.mk @@ -870,15 +870,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\ )) $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\ -helpcontent2/source/text/shared/explorer/database/querywizard00 \ -helpcontent2/source/text/shared/explorer/database/querywizard01 \ -helpcontent2/source/text/shared/explorer/database/querywizard02 \ -helpcontent2/source/text/shared/explorer/database/querywizard03 \ -helpcontent2/source/text/shared/explorer/database/querywizard04 \ -helpcontent2/source/text/shared/explorer/database/querywizard05 \ -helpcontent2/source/text/shared/explorer/database/querywizard06 \ -helpcontent2/source/text/shared/explorer/database/querywizard07 \ -helpcontent2/source/text/shared/explorer/database/querywizard08 \ helpcontent2/source/text/shared/explorer/database/rep_datetime \ helpcontent2/source/text/shared/explorer/database/rep_insertfield \ helpcontent2/source/text/shared/explorer/database/rep_main \ diff --git a/source/text/shared/explorer/database/querywizard00.xhp b/source/text/sdatabase/querywizard00.xhp similarity index 64% rename from source/text/shared/explorer/database/querywizard00.xhp rename to source/text/sdatabase/querywizard00.xhp index ffe747400..314f14c93 100644 --- a/source/text/shared/explorer/database/querywizard00.xhp +++ b/source/text/sdatabase/querywizard00.xhp @@ -1,6 +1,6 @@ - + - - + + Query Wizard -/text/shared/explorer/database/querywizard00.xhp +/text/sdatabase/querywizard00.xhp mw deleted 2 index entries -Query Wizard +Query Wizard The Query Wizard helps you to design a database query. The saved query can be called later, either from the graphical user interface, or using the automatically created SQL language command. - - - - - - - - + + + + + + + + -Query Wizard - Field selection +Query Wizard - Field selection diff --git a/source/text/shared/explorer/database/querywizard01.xhp b/source/text/sdatabase/querywizard01.xhp similarity index 79% rename from source/text/shared/explorer/database/querywizard01.xhp rename to source/text/sdatabase/querywizard01.xhp index 16eb42baa..7570c3daa 100644 --- a/source/text/shared/explorer/database/querywizard01.xhp +++ b/source/text/sdatabase/querywizard01.xhp @@ -1,6 +1,6 @@ - + - - + + Query Wizard - Field Selection
[Libreoffice-commits] core.git: 2 commits - helpcontent2 svx/source
helpcontent2 |2 +-
svx/source/accessibility/ChildrenManagerImpl.cxx | 10 +++---
svx/source/accessibility/ChildrenManagerImpl.hxx |7 +++
3 files changed, 7 insertions(+), 12 deletions(-)
New commits:
commit cf6976280f5371c01251c0ffce206535433207a3
Author: Olivier Hallot
AuthorDate: Fri Dec 24 13:57:59 2021 -0300
Commit: Gerrit Code Review
CommitDate: Fri Dec 24 17:57:59 2021 +0100
Update git submodules
* Update helpcontent2 from branch 'master'
to 215707177c272f9fcf73a79b9150fe677b991716
- Refactor database files
Change-Id: If6acf26ea094234d06522c26c8bb8274c0abdaa5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127430
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/helpcontent2 b/helpcontent2
index a35f8b648fd4..215707177c27 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a35f8b648fd4bac70bbde0554a2d4051c7633cde
+Subproject commit 215707177c272f9fcf73a79b9150fe677b991716
commit a3af03ec84ff5e8a89ccfa6fb2350eec6f09883c
Author: Noel Grandin
AuthorDate: Fri Dec 24 12:00:57 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 17:57:41 2021 +0100
use comphelper::WeakComponentImplHelper in ChildrenManagerImpl
Change-Id: I24b1f497a77b7ff896060a8f7dacc5d3a5e27ea2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127411
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx
b/svx/source/accessibility/ChildrenManagerImpl.cxx
index 2b8f5674b0d9..080d2a204b9d 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.cxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.cxx
@@ -69,10 +69,7 @@ ChildrenManagerImpl::ChildrenManagerImpl (
const uno::Reference& rxShapeList,
const AccessibleShapeTreeInfo& rShapeTreeInfo,
AccessibleContextBase& rContext)
-: ::cppu::WeakComponentImplHelper<
- css::document::XEventListener,
- css::view::XSelectionChangeListener>(m_aMutex),
- mxShapeList (rxShapeList),
+: mxShapeList (rxShapeList),
mxParent (rxParent),
maShapeTreeInfo (rShapeTreeInfo),
mrContext (rContext),
@@ -83,8 +80,7 @@ ChildrenManagerImpl::ChildrenManagerImpl (
ChildrenManagerImpl::~ChildrenManagerImpl()
{
-DBG_ASSERT (rBHelper.bDisposed || rBHelper.bInDispose,
-"~AccessibleDrawDocumentView: object has not been disposed");
+DBG_ASSERT (m_bDisposed, "~AccessibleDrawDocumentView: object has not been
disposed");
}
@@ -694,7 +690,7 @@ void ChildrenManagerImpl::impl_dispose()
}
-void SAL_CALL ChildrenManagerImpl::disposing()
+void ChildrenManagerImpl::disposing()
{
impl_dispose();
}
diff --git a/svx/source/accessibility/ChildrenManagerImpl.hxx
b/svx/source/accessibility/ChildrenManagerImpl.hxx
index 1956a7650fc4..6cd9a76305b5 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.hxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.hxx
@@ -24,7 +24,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
@@ -72,8 +72,7 @@ typedef ::std::vector
ChildDescriptorListType;
@see ChildrenManager
*/
class ChildrenManagerImpl final
-: public cppu::BaseMutex,
-public cppu::WeakComponentImplHelper<
+: public comphelper::WeakComponentImplHelper<
css::document::XEventListener,
css::view::XSelectionChangeListener>,
public IAccessibleViewForwarderListener,
@@ -316,7 +315,7 @@ private:
/** This method is called from the component helper base class while
disposing.
*/
-virtual void SAL_CALL disposing() override;
+virtual void disposing() override;
void impl_dispose();
[Libreoffice-commits] core.git: svx/source
svx/source/sidebar/PanelFactory.cxx |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
New commits:
commit c55d1affc6299feed36145a01279b641bb60ac57
Author: Noel Grandin
AuthorDate: Fri Dec 24 13:04:32 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 17:57:10 2021 +0100
use comphelper::WeakComponentImplHelper in PanelFactory
Change-Id: I936fd58fdb626d6707cf672f188cd8570269bc44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127412
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/sidebar/PanelFactory.cxx
b/svx/source/sidebar/PanelFactory.cxx
index b839100fbcf6..f55575d1ab97 100644
--- a/svx/source/sidebar/PanelFactory.cxx
+++ b/svx/source/sidebar/PanelFactory.cxx
@@ -41,8 +41,7 @@
#include
#include
#include
-#include
-#include
+#include
#include
#include
#include
@@ -61,12 +60,11 @@ constexpr OUStringLiteral IMPLEMENTATION_NAME =
u"org.apache.openoffice.comp.svx
constexpr OUStringLiteral SERVICE_NAME = u"com.sun.star.ui.UIElementFactory";
*/
-typedef ::cppu::WeakComponentImplHelper< css::ui::XUIElementFactory,
css::lang::XServiceInfo >
+typedef comphelper::WeakComponentImplHelper< css::ui::XUIElementFactory,
css::lang::XServiceInfo >
PanelFactoryInterfaceBase;
class PanelFactory
-: private ::cppu::BaseMutex,
- public PanelFactoryInterfaceBase
+: public PanelFactoryInterfaceBase
{
public:
PanelFactory();
@@ -89,7 +87,6 @@ public:
};
PanelFactory::PanelFactory()
-: PanelFactoryInterfaceBase(m_aMutex)
{
}
[Libreoffice-bugs] [Bug 146407] New: Writer - Dysfunction of Diagonal & Criss-Cross Border.
https://bugs.documentfoundation.org/show_bug.cgi?id=146407 Bug ID: 146407 Summary: Writer - Dysfunction of Diagonal & Criss-Cross Border. Product: LibreOffice Version: 7.3.0.0 beta1+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jo3...@jarl.com Description: Toolbar icons about Diagonal & Criss-Cross Border seem not to work. Steps to Reproduce: 1. Make table in Writer. 2. Select some cells. 3. Select "Borders" icon in "Table" toolbar. 4. Select icon of "Diagonal Down Border" or "Diagonal Up Border" or "Criss-Cross Border". Actual Results: Nothing happens. Expected Results: Diagonal lines expected to be drawn. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.3.0.0.beta1 (x64) / LibreOffice Community Build ID: 436f14c25ec1847646b953cf13d0db4f7ca3be57 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL Version: 7.3.0.0.beta1+ (x64) / LibreOffice Community Build ID: c25067e46d7d849a584295de365e32c6c7af11bf CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: ja-JP (ja_JP); UI: ja-JP Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146397] Writer: the text cursor is barely visible
https://bugs.documentfoundation.org/show_bug.cgi?id=146397 --- Comment #5 from Paolo Benvenuto --- Version: 7.2.2.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: es-DO (it_IT.UTF-8); UI: it-IT Ubuntu package version: 1:7.2.2~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105581] [META] Help viewer dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105581 V Stuart Foote changed: What|Removed |Added Depends on||146403 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146403 [Bug 146403] Help or F1 does not open my default browser -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146403] Help or F1 does not open my default browser
https://bugs.documentfoundation.org/show_bug.cgi?id=146403 V Stuart Foote changed: What|Removed |Added Component|LibreOffice |Documentation CC||olivier.hallot@libreoffice. ||org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120248] Add an option to choose the application, which is used to show the local help
https://bugs.documentfoundation.org/show_bug.cgi?id=120248 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6403 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146403] Help or F1 does not open my default browser
https://bugs.documentfoundation.org/show_bug.cgi?id=146403 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0248 Blocks||105581 CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- There is no Java in the on-line or locally installed Help system. It is javascript and the JRE is not in anyway related. Since you remain on Windows 8.1, assistance may be limited but you need to configure your default programs correctly. LibreOffice help system does not set its browser and follows the os/DE settings. There is enhancement bug 120248 to provide that capability, but the issue probably lays with your system. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105581 [Bug 105581] [META] Help viewer dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146405] Ok
https://bugs.documentfoundation.org/show_bug.cgi?id=146405 aleksandrakorobov...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146406] Неверное получение сохраненной записи
https://bugs.documentfoundation.org/show_bug.cgi?id=146406 aleksandrakorobov...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146406] New: Неверное получение сохраненной записи
https://bugs.documentfoundation.org/show_bug.cgi?id=146406 Bug ID: 146406 Summary: Неверное получение сохраненной записи Product: cppunit Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aleksandrakorobov...@gmail.com CC: markus.mohrh...@googlemail.com Created attachment 177128 --> https://bugs.documentfoundation.org/attachment.cgi?id=177128=edit Неверное получение сохраненной записи "Выполнение лабораторной работы" После открытия созданной записи, вместо требуемой информации выводится сообщение «System error». -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146405] New: Ok
https://bugs.documentfoundation.org/show_bug.cgi?id=146405 Bug ID: 146405 Summary: Ok Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aleksandrakorobov...@gmail.com Created attachment 177127 --> https://bugs.documentfoundation.org/attachment.cgi?id=177127=edit NoteBook -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146402] LibreOffice aborts when starting with an empty profile (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=146402 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #3 from V Stuart Foote --- Can not reproduce on Windows 10 (21H2) with Intel Iris GPU Vendor: 0x8086 Device: 0x8a52 API: 1.2.195 Driver: 0.404.1069 DeviceType: integrated DeviceName: Intel(R) Iris(R) Plus Graphics Denylisted: no @Aaron, maybe figure out what AMD GPU details you have (the Skia.log from release build) and manually add an appropriate stanza to the "skia_denylist_vulkan.xml" in the <$ORIGIN>\share\skia folder? Having the deny list may bypass the SkiaHelper util? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146392] LO build broken due to x509.h
https://bugs.documentfoundation.org/show_bug.cgi?id=146392 --- Comment #5 from Caolán McNamara --- At the top of each file in xmlsecurity/inc/pch/precompiled_x*hxx there is a line to update the pch e.g. ./bin/update_pch ... If you run each of the update_pch suggestions and retry with --enable-pch=full does it make a difference. If it does you can commit and submit the change as a fix for this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146233] Wiggling letter when typing certain letter on certain spot. Independent of sidebar. Zoom matters
https://bugs.documentfoundation.org/show_bug.cgi?id=146233 --- Comment #7 from Caolán McNamara --- its very new, yesterday or the day before: https://gerrit.libreoffice.org/c/core/+/127089 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/source
sw/source/uibase/docvw/edtwin.cxx | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
New commits:
commit df77dcbbb2ecd3a272a3ea55877a1b1c9fd8ef03
Author: Jim Raykowski
AuthorDate: Wed Dec 22 23:58:09 2021 -0900
Commit: Xisco Fauli
CommitDate: Fri Dec 24 15:56:12 2021 +0100
Outline folding: check pointer before use
Change-Id: Ifa79ef5f286da77fdac9464b4e271021107bf34e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127348
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
(cherry picked from commit 1609bb6ab5e34fc8fff67240e3c49dde93f2d2d7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127379
Reviewed-by: Xisco Fauli
diff --git a/sw/source/uibase/docvw/edtwin.cxx
b/sw/source/uibase/docvw/edtwin.cxx
index 5fea06590626..0fc6e91b594d 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -3908,10 +3908,15 @@ void SwEditWin::MouseMove(const MouseEvent& _rMEvt)
SwContentFrame* pContentFrame =
aSwContentAtPos.aFnd.pNode->GetTextNode()->getLayoutFrame(nullptr);
if (pContentFrame != m_pSavedOutlineFrame)
{
-if (m_pSavedOutlineFrame &&
!m_pSavedOutlineFrame->IsInDtor() &&
-
rNds.GetOutLineNds().Seek_Entry(static_cast(m_pSavedOutlineFrame)->GetTextNodeFirst(),
) &&
-rSh.GetAttrOutlineContentVisible(nPos))
-
GetFrameControlsManager().RemoveControlsByType(FrameControlType::Outline,
m_pSavedOutlineFrame);
+if (m_pSavedOutlineFrame &&
!m_pSavedOutlineFrame->IsInDtor())
+{
+SwTextNode* pTextNode =
+
static_cast(m_pSavedOutlineFrame)->GetTextNodeFirst();
+if (pTextNode &&
rNds.GetOutLineNds().Seek_Entry(pTextNode, ) &&
+rSh.GetAttrOutlineContentVisible(nPos))
+GetFrameControlsManager().RemoveControlsByType(
+FrameControlType::Outline,
m_pSavedOutlineFrame);
+}
m_pSavedOutlineFrame = pContentFrame;
}
// show button
[Libreoffice-bugs] [Bug 106613] UI: Sidebar navigator in Impress/Draw not updated immediately when page/slide is renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=106613 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6003 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85905] Allow undocking of Sidebar decks
https://bugs.documentfoundation.org/show_bug.cgi?id=85905 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |6003| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146116] sticky points move inwards when shape is roated
https://bugs.documentfoundation.org/show_bug.cgi?id=146116 Regina Henschel changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #6 from Regina Henschel --- (In reply to birnb...@posteo.de from comment #5) > I just noticed that the error is only observable if rotation is done via the > properties palette "position and size". > > No problem if the shape is rotated directly i.e. by selecting it on the > drawing canvas. I can still not reproduce the error, neither with the rotation section in the side bar nor with the rotation tab in the 'Position and Size' dialog. A problem only on Mac? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146402] LibreOffice aborts when starting with an empty profile (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=146402 Aron Budea changed: What|Removed |Added Attachment #177126|text/x-log |text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146402] LibreOffice aborts when starting with an empty profile (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=146402 Aron Budea changed: What|Removed |Added Priority|medium |high Summary|LibreOffice aborts when |LibreOffice aborts when |starting with an empty |starting with an empty |profile (debug build, |profile (Windows) |Windows)| Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146402] LibreOffice aborts when starting with an empty profile (debug build, Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=146402 --- Comment #2 from Aron Budea --- Created attachment 177126 --> https://bugs.documentfoundation.org/attachment.cgi?id=177126=edit Skia log Daily (release) build from 12-22 doesn't start at all. So this isn't debug-only. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bridges/source
bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 82807f810b3300111820e9b2fa9a82e3e35a313a
Author: Arnaud VERSINI
AuthorDate: Sun Dec 19 12:34:40 2021 +0100
Commit: Noel Grandin
CommitDate: Fri Dec 24 14:53:13 2021 +0100
bridges : remove redundant public
Change-Id: I836412674448acb2a047d3d8b4711fa8d0b67257
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127410
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx
b/bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx
index 242e2a476e23..206446a81d0c 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx
@@ -57,7 +57,6 @@ private:
};
class GeneratedPad: public Generated {
-public:
public:
GeneratedPad(std::unique_ptr && pad): pad_(std::move(pad)) {};
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/ciphercontext.cxx |6 ++
xmlsecurity/source/xmlsec/nss/ciphercontext.hxx |4 ++--
2 files changed, 4 insertions(+), 6 deletions(-)
New commits:
commit b0163975efc6924c154793590a759784ffa77d08
Author: Noel Grandin
AuthorDate: Thu Dec 23 22:24:27 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 14:45:11 2021 +0100
osl::Mutex->std::mutex in OCipherContext
Change-Id: I0a457dc8ddccc0fce42032956aff6d661d1ae80a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127403
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
b/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
index c4d1c6113bf6..ff3441249435 100644
--- a/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
+++ b/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx
@@ -63,8 +63,6 @@ uno::Reference< xml::crypto::XCipherContext >
OCipherContext::Create( CK_MECHANI
void OCipherContext::Dispose()
{
-::osl::MutexGuard aGuard( m_aMutex );
-
if ( m_pContext )
{
PK11_DestroyContext( m_pContext, PR_TRUE );
@@ -94,7 +92,7 @@ void OCipherContext::Dispose()
uno::Sequence< ::sal_Int8 > SAL_CALL OCipherContext::convertWithCipherContext(
const uno::Sequence< ::sal_Int8 >& aData )
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
if ( m_bBroken )
throw uno::RuntimeException();
@@ -174,7 +172,7 @@ uno::Sequence< ::sal_Int8 > SAL_CALL
OCipherContext::convertWithCipherContext( c
uno::Sequence< ::sal_Int8 > SAL_CALL
OCipherContext::finalizeCipherContextAndDispose()
{
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
if ( m_bBroken )
throw uno::RuntimeException();
diff --git a/xmlsecurity/source/xmlsec/nss/ciphercontext.hxx
b/xmlsecurity/source/xmlsec/nss/ciphercontext.hxx
index 3ac5df6c7fd0..40b610ef512e 100644
--- a/xmlsecurity/source/xmlsec/nss/ciphercontext.hxx
+++ b/xmlsecurity/source/xmlsec/nss/ciphercontext.hxx
@@ -22,14 +22,14 @@
#include
#include
-#include
+#include
#include
#include
class OCipherContext : public cppu::WeakImplHelper<
css::xml::crypto::XCipherContext >
{
private:
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
PK11SlotInfo* m_pSlot;
PK11SymKey* m_pSymKey;
[Libreoffice-commits] core.git: accessibility/inc accessibility/source
accessibility/inc/extended/accessibleeditbrowseboxcell.hxx|9 -
accessibility/source/extended/accessibleeditbrowseboxcell.cxx |5 ++---
2 files changed, 6 insertions(+), 8 deletions(-)
New commits:
commit c5a0bcf94403a29490d707ae1878fba3e0423d13
Author: Noel Grandin
AuthorDate: Fri Dec 24 09:44:18 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 14:44:52 2021 +0100
use comphelper::WeakComponentImplHelper in EditBrowseBoxTableCellAccess
Change-Id: I36a1dd4fa488517a1e69d3a1c4b03c850d1a933e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127404
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
b/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
index 6d827ac13a05..ab45db70af77 100644
--- a/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
+++ b/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
@@ -20,7 +20,7 @@
#include
#include
-#include
+#include
#include
namespace accessibility
@@ -89,8 +89,7 @@ namespace accessibility
// XAccessible providing an EditBrowseBoxTableCell
class EditBrowseBoxTableCellAccess final :
-public cppu::BaseMutex,
-public cppu::WeakComponentImplHelper
+public
comphelper::WeakComponentImplHelper
{
css::uno::WeakReference< css::accessibility::XAccessibleContext >
m_aContext;
@@ -120,8 +119,8 @@ namespace accessibility
// XAccessible
virtual css::uno::Reference< css::accessibility::XAccessibleContext >
SAL_CALL getAccessibleContext( ) override;
-// XComponent/OComponentHelper
-virtual void SAL_CALL disposing() override;
+// XComponent/WeakComponentImplHelper
+virtual void disposing() override;
EditBrowseBoxTableCellAccess( const EditBrowseBoxTableCellAccess& ) =
delete;
EditBrowseBoxTableCellAccess& operator=( const
EditBrowseBoxTableCellAccess& ) = delete;
diff --git a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
index 06165071b621..f9985e48a268 100644
--- a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
+++ b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
@@ -183,8 +183,7 @@ namespace accessibility
const css::uno::Reference< css::accessibility::XAccessible >&
_rxParent, const css::uno::Reference< css::accessibility::XAccessible >&
_rxControlAccessible,
const css::uno::Reference< css::awt::XWindow >& _rxFocusWindow,
::vcl::IAccessibleTableProvider& _rBrowseBox, sal_Int32 _nRowPos,
sal_uInt16 _nColPos )
-:WeakComponentImplHelper( m_aMutex )
-,m_xParent( _rxParent )
+:m_xParent( _rxParent )
,m_xControlAccessible( _rxControlAccessible )
,m_xFocusWindow( _rxFocusWindow )
,m_pBrowseBox( &_rBrowseBox )
@@ -213,7 +212,7 @@ namespace accessibility
return xMyContext;
}
-void SAL_CALL EditBrowseBoxTableCellAccess::disposing()
+void EditBrowseBoxTableCellAccess::disposing()
{
// dispose our context, if it still alive
css::uno::Reference< XComponent > xMyContext( m_aContext.get(),
UNO_QUERY );
[Libreoffice-bugs] [Bug 146376] Calc: Wrong font when I open a new csv file
https://bugs.documentfoundation.org/show_bug.cgi?id=146376 --- Comment #7 from Pat War --- I tried to use the Menu/Help but the Restart in Safe Mode option was not enabled so eventually I had to use Mac OS Terminal with this code: /Applications/LibreOffice.app/Contents/MacOS/soffice --safe-mode and reverted to Normal that way. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146404] New: Number Format Code: Not all color codes are saved
https://bugs.documentfoundation.org/show_bug.cgi?id=146404
Bug ID: 146404
Summary: Number Format Code: Not all color codes are saved
Product: LibreOffice
Version: 7.1.6.2 release
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
Severity: minor
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: mmuel...@datastreamsolutions.com
1 Description
When using special color codes in number format codes, e.g.
COLOR23¹
that aren't 1 of the 8 documented² color codes, i.e.
CYAN, GREEN, BLACK, BLUE, MAGENTA, RED, WHITE, YELLOW
the application will correctly display the color, but after saving and
reloading the document, the color code will no longer be part of the number
format, and no color will be displayed.
2 Steps to reproduce
2.1 Enter "-1234" into a cell.
2.2 Open cell formatting for that cell, and change the number format to
[COLOR23]0.0
2.3 The number in the cell will now appear green-ish.
2.4 Save the document. Close the document. Re-open the document.
2.5 The number in the cell will appear with the default font color. (NOT
green-ish) If you open the cell formatting, you will see the color code
vanished from the number format code.
3 Is this a bug?
While it is documented that there are only 8 number format code colors², the
application still reacts to input such as COLOR23. This indicates to the user
that this is an undocumented feature. The loss of these settings after
reloading the document is highly unintuitive. So either:
a) (Documentation okay, Application bug)
The bug is that the application allows undocumented color codes.
b) (Documentation bug, Application bug)
The documentation forgot to mention the COLOR{NN} codes and the
application doesn't properly save them.
4 System parameters
Operating system: Gentoo
Package manager: Portage
Package: app-office/libreoffice 7.1.7.2
- Note: Compiled from source, as opposed to the app-office/libreoffice-bin
package.
Portage flags:
- USE: bluetooth branding cups dbus gtk mariadb -accessibility -base -clang
-coinmp -custom-cflags -debug -eds -firebird -googledrive -gstreamer -java -kde
-ldap -odk -pdfimport -postgres -test -vulkan
- ELIBC: -FreeBSD
- LIBREOFFICE_EXTENSIONS: -nlpsolver -scripting-beanshell -scripting-javascript
-wiki-publisher
- PYTHON_SINGLE_TARGET: "python3_9 -python3_8 -python3_10
5 Footnotes
¹ COLOR23 is a valid Excel number format code color.
²
https://help.libreoffice.org/7.2/en-US/text/shared/01/05020301.html#hd_id3155994
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/inc
svx/inc/sdr/primitive2d/primitivefactory2d.hxx | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
New commits:
commit d1e270557a62bfe81f63a72b6802a11eff9e047d
Author: Noel Grandin
AuthorDate: Fri Dec 24 11:54:21 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 13:52:13 2021 +0100
use comphelper::WeakComponentImplHelper in PrimitiveFactory2D
Change-Id: Iead37062710d64705fca2d00404922b3ad3b6f17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127409
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/inc/sdr/primitive2d/primitivefactory2d.hxx
b/svx/inc/sdr/primitive2d/primitivefactory2d.hxx
index fd6ded05ab18..1fa65d52e01a 100644
--- a/svx/inc/sdr/primitive2d/primitivefactory2d.hxx
+++ b/svx/inc/sdr/primitive2d/primitivefactory2d.hxx
@@ -21,8 +21,7 @@
#include
#include
#include
-#include
-#include
+#include
#include
#include
#include
@@ -30,17 +29,15 @@
#include
#include
-typedef cppu::WeakComponentImplHelper
+typedef comphelper::WeakComponentImplHelper
PrimitiveFactory2DImplBase;
// base class for C++ implementation of css::graphic::XPrimitiveFactory2D
-class PrimitiveFactory2D : protected cppu::BaseMutex, public
PrimitiveFactory2DImplBase
+class PrimitiveFactory2D final : public PrimitiveFactory2DImplBase
{
public:
-PrimitiveFactory2D()
-: PrimitiveFactory2DImplBase(m_aMutex)
-{
-}
+PrimitiveFactory2D() {}
// Methods from XPrimitiveFactory2D
virtual css::uno::Sequence>
[Libreoffice-bugs] [Bug 146116] sticky points move inwards when shape is roated
https://bugs.documentfoundation.org/show_bug.cgi?id=146116 --- Comment #5 from birnb...@posteo.de --- I just noticed that the error is only observable if rotation is done via the properties palette "position and size". No problem if the shape is rotated directly i.e. by selecting it on the drawing canvas. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146116] sticky points move inwards when shape is roated
https://bugs.documentfoundation.org/show_bug.cgi?id=146116 --- Comment #4 from birnb...@posteo.de --- Created attachment 177125 --> https://bugs.documentfoundation.org/attachment.cgi?id=177125=edit shape after 10 rotations and 10 rotations back The right shape was rotated 10 times clockwise and then 10 times counter clockwise. It can be seen that the positioning error of the sticky point adds up regardless of the sense of rotation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146116] sticky points move inwards when shape is roated
https://bugs.documentfoundation.org/show_bug.cgi?id=146116 --- Comment #3 from birnb...@posteo.de --- Created attachment 177124 --> https://bugs.documentfoundation.org/attachment.cgi?id=177124=edit shape after 10 rotations I rotated the right shape clockwise 10 times, here is the result. My test machine is a Retina Mac but the same behaviour was observed on a non-Retina (MacBook Air 2011, OSX 10.13.4) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136187] TOC counts extra page in some cases
https://bugs.documentfoundation.org/show_bug.cgi?id=136187 --- Comment #4 from Alexander Polkhovskiy --- (In reply to BogdanB from comment #3) > I think is NOT about TOC. > I have simplified the document. And this simple document it is showing in > the bottom Page 1 of 3 (Page 1 of 2 to print). Somewhere there is a page 3. > I think this is the problem and not the TOC. > > Or maybe the problem is that the Page break is inserted with Page Position > "Before". After you have wrote it, I noticed, that "somewhere there is a page" 2, not 3. And it is the page after 1 and before 3 - even page 2, that isn't visible. If you change Page break's start Page number to any even number, everything works fine. And there is a bug about even virtual page automatically added and counted by "Show page number" variable if you break an odd page. But this time "Page" field and TOC count pages differently - and this happens only in particular case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72043] FORMATTING: Extra page breaks in docx from iOS Pages
https://bugs.documentfoundation.org/show_bug.cgi?id=72043 --- Comment #37 from jasoneck --- When creating your PPT poster, you will need to pay close attention to its format. By failing to arrange the format in an appropriate way, all the efforts you have put into writing your paper were just a waste of time https://gold-essays.com/pay-someone-to-make-my-ppt-poster.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146391] hlookup: when the search criteria contains a number, the search result will be NV
https://bugs.documentfoundation.org/show_bug.cgi?id=146391 --- Comment #2 from rupert.graspeunt...@gmail.com --- Created attachment 177123 --> https://bugs.documentfoundation.org/attachment.cgi?id=177123=edit the error can be reproduced on tables "bezeichnung" and "Budget" to vary the occurrence of the error, in Table "Bezeichnung" modify Cells A23, A24, A25 you can see the result in Table "Budget",Cells e.g. e23, e24, e25 If you add in Table "Bezeichnung", Cell A21 a space as the first character, Table "Budget",Cells e.g. e23, e24, e25 show correct results -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: unotools/source
unotools/source/ucbhelper/ucblockbytes.cxx| 56 +-
unotools/source/ucbhelper/ucblockbytes.hxx| 16 +++
unotools/source/ucbhelper/ucbstreamhelper.cxx |4 -
3 files changed, 38 insertions(+), 38 deletions(-)
New commits:
commit 166e2a09052b8adb0525cc3a50b8b7cac0bbe6f1
Author: Noel Grandin
AuthorDate: Thu Dec 23 19:56:21 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 12:45:37 2021 +0100
rename some methods on UcbLockBytes
The Impl suffix means internal methods, but these are part
of the public API of the class
Change-Id: I9c969f3464e0ae78d52f997643f7fb8489b7bd61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127401
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx
b/unotools/source/ucbhelper/ucblockbytes.cxx
index da0118a6d60d..2d716f571586 100644
--- a/unotools/source/ucbhelper/ucblockbytes.cxx
+++ b/unotools/source/ucbhelper/ucblockbytes.cxx
@@ -88,13 +88,13 @@ public:
virtual void SAL_CALL removeListener ( const Reference
&/*rxListener*/) override {}
virtual void SAL_CALL start() override {}
virtual void SAL_CALL terminate() override
-{ m_xLockBytes->terminate_Impl(); }
+{ m_xLockBytes->terminate(); }
// XActiveDataSink.
virtual void SAL_CALL setInputStream ( const Reference
) override
-{ m_xLockBytes->setInputStream_Impl
(rxInputStream); }
+{ m_xLockBytes->setInputStream(rxInputStream); }
virtual Reference SAL_CALL getInputStream() override
-{ return m_xLockBytes->getInputStream_Impl(); }
+{ return m_xLockBytes->getInputStream(); }
};
/**
@@ -115,11 +115,11 @@ public:
virtual void SAL_CALL removeListener ( const Reference
&/*rxListener*/) override {}
virtual void SAL_CALL start() override {}
virtual void SAL_CALL terminate() override
-{ m_xLockBytes->terminate_Impl(); }
+{ m_xLockBytes->terminate(); }
// XActiveDataStreamer
virtual void SAL_CALL setStream( const Reference< XStream >& aStream )
override
-{ m_xStream = aStream;
m_xLockBytes->setStream_Impl( aStream ); }
+{ m_xStream = aStream; m_xLockBytes->setStream(
aStream ); }
virtual Reference< XStream > SAL_CALL getStream() override
{ return m_xStream; }
};
@@ -170,7 +170,7 @@ void SAL_CALL
UcbPropertiesChangeListener_Impl::propertiesChange ( const Sequenc
{
if (rPropChangeEvent.PropertyName == "DocumentHeader")
{
-m_xLockBytes->SetStreamValid_Impl();
+m_xLockBytes->SetStreamValid();
}
}
}
@@ -655,7 +655,7 @@ static bool UCBOpenContentSync(
if ( !aScheme.equalsIgnoreAsciiCase( "http" ) &&
!aScheme.equalsIgnoreAsciiCase( "https" ) )
-xLockBytes->SetStreamValid_Impl();
+xLockBytes->SetStreamValid();
Reference< XPropertiesChangeListener > xListener;
Reference< XPropertiesChangeNotifier > xProps(xContent,UNO_QUERY);
@@ -861,7 +861,7 @@ static bool UCBOpenContentSync_(
// http protocol must be handled in a special way: during the opening
process the input stream may change
// only the last inputstream after notifying the document headers is valid
if ( !aScheme.equalsIgnoreAsciiCase("http") )
-xLockBytes->SetStreamValid_Impl();
+xLockBytes->SetStreamValid();
Reference< XPropertiesChangeListener > xListener = new
UcbPropertiesChangeListener_Impl( xLockBytes );
Reference< XPropertiesChangeNotifier > xProps ( xContent, UNO_QUERY );
@@ -979,23 +979,23 @@ Reference < XInputStream > UcbLockBytes::getInputStream()
return m_xInputStream;
}
-void UcbLockBytes::setStream_Impl( const Reference& aStream )
+void UcbLockBytes::setStream( const Reference& aStream )
{
osl::MutexGuard aGuard( m_aMutex );
if ( aStream.is() )
{
m_xOutputStream = aStream->getOutputStream();
-setInputStream_Impl( aStream->getInputStream(), false );
+setInputStream( aStream->getInputStream(), false );
m_xSeekable.set( aStream, UNO_QUERY );
}
else
{
m_xOutputStream.clear();
-setInputStream_Impl( Reference < XInputStream >() );
+setInputStream( Reference < XInputStream >() );
}
}
-bool UcbLockBytes::setInputStream_Impl( const Reference
, bool bSetXSeekable )
+bool UcbLockBytes::setInputStream( const Reference
, bool bSetXSeekable )
{
bool bRet = false;
@@ -1034,14 +1034,14 @@ bool UcbLockBytes::setInputStream_Impl( const
Reference
return bRet;
}
-void UcbLockBytes::SetStreamValid_Impl()
+void UcbLockBytes::SetStreamValid()
{
m_bStreamValid = true;
if (
LibreOffice Tree with columns
Hello! Please, help me find information, if you can. I am writing an extension for LibreOffifce. A tree with columns on my sidebar is needed. (example - https://doc.qt.io/qt-5/qtwidgets-itemviews-simpletreemodel-example.html) I found information about Tree Controls and module "tree", e.g. here https://wiki.openoffice.org/wiki/Treecontrol https://www.openoffice.org/api/docs/common/ref/com/sun/star/awt/tree/module-ix.html But I couldn't find anything about writing a *tree with columns*. There is a quote "You can provide your *own model* which must at least support the interface com.sun.star.awt.XTreeModel." in the article "Tree control", but I also couldn't find any information about providing of my own models...
[Libreoffice-bugs] [Bug 146382] Can’t open file from Explorer-attached remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=146382 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117073] [META] WebDAV bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=117073 Bug 117073 depends on bug 146382, which changed state. Bug 146382 Summary: Can’t open file from Explorer-attached remote location https://bugs.documentfoundation.org/show_bug.cgi?id=146382 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146392] LO build broken due to x509.h
https://bugs.documentfoundation.org/show_bug.cgi?id=146392 --- Comment #4 from Roland Kurmann --- Building with only --enable-pch is successful. My commands: make clean ./autogen.sh CC=clang CXX=clang++ --enable-pch --without-doxygen --without-system-libxml --without-krb5 --disable-randr --disable-gtk3 --disable-gstreamer-1-0 --without-gssapi --with-theme=breeze --enable-dbgutil make -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146078] Text starts wiggling/ changing kerning after auto-hyperlink creation (RSID)
https://bugs.documentfoundation.org/show_bug.cgi?id=146078 Telesto changed: What|Removed |Added CC||caol...@redhat.com --- Comment #13 from Telesto --- @Caolan You're currently in the possession of active in depth knowledge of glyph positioning (bug 144862). So you might have some clue what's going on here. The wiggle is visually exactly the same as bug 144862, but well a different trigger. I can't tell if commit 6db39dbd7378351f6476f6db25eb7110c9cfb291 being incomplete/broken (so shifting being caused by multiple text portions) or something else is intervening (like 6db39dbd7378351f6476f6db25eb7110c9cfb291) To get things straight: no expectations for a fix nor an implicit requesting to spend lots of time this. My primarily intension to get to the bottom of the problem. Is the primarily problem in the glyph positioning code or RSID creating text portions (or combo of both) I obviously have to admit this topic being one of my pets. I dislike dancing/wiggling glyphs /unstable kerning (and there are more people likely me: bug 103322). And skeptical about floating point being the silver bullet -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146382] Can’t open file from Explorer-attached remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=146382 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/15bc49228997a5da556961b923bb607642b6 tdf#146382 cant open file from Explorer-attached remote location It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146382] Can’t open file from Explorer-attached remote location
https://bugs.documentfoundation.org/show_bug.cgi?id=146382 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: tools/qa tools/source
tools/qa/cppunit/test_urlobj.cxx |9 +
tools/source/fsys/urlobj.cxx |3 +++
2 files changed, 12 insertions(+)
New commits:
commit 15bc49228997a5da556961b923bb607642b6
Author: Noel Grandin
AuthorDate: Fri Dec 24 09:35:44 2021 +0200
Commit: Noel Grandin
CommitDate: Fri Dec 24 11:27:39 2021 +0100
tdf#146382 cant open file from Explorer-attached remote location
problem spotted by mikekaganski
regression from
commit 0b46361ef84a61100a0274a007062317607d097a
Author: Noel Grandin
Date: Sat Nov 20 08:03:49 2021 +0200
tdf#133835 speedup calc autofilter (4)
where I changed the behaviour of parseHostOrNetBiosName from overwriting
the destination buffer to appending to it.
Change-Id: I1bd3c7eade035a867c026364f5e114c1e652ca32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127352
Tested-by: Gabor Kelemen
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/tools/qa/cppunit/test_urlobj.cxx b/tools/qa/cppunit/test_urlobj.cxx
index a335701c5cab..ec64b5d66777 100644
--- a/tools/qa/cppunit/test_urlobj.cxx
+++ b/tools/qa/cppunit/test_urlobj.cxx
@@ -311,6 +311,14 @@ namespace tools_urlobj
obj.GetMainURL(INetURLObject::DecodeMechanism::NONE));
}
+void testTd146382() {
+INetURLObject
obj("file://share.allotropia.de@SSL/DavWWWRoot/remote.php");
+CPPUNIT_ASSERT(!obj.HasError());
+CPPUNIT_ASSERT_EQUAL(
+
OUString("file://share.allotropia.de@SSL/DavWWWRoot/remote.php"),
+obj.GetMainURL(INetURLObject::DecodeMechanism::NONE));
+}
+
// Change the following lines only, if you add, remove or rename
// member functions of the current class,
// because these macros are need by auto register mechanism.
@@ -326,6 +334,7 @@ namespace tools_urlobj
CPPUNIT_TEST( testSetName );
CPPUNIT_TEST( testSetExtension );
CPPUNIT_TEST( testChangeScheme );
+CPPUNIT_TEST( testTd146382 );
CPPUNIT_TEST_SUITE_END( );
}; // class createPool
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 8c3d2845eab2..7b86fe0f5261 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -2880,7 +2880,10 @@ bool INetURLObject::parseHostOrNetBiosName(
}
}
if (pCanonic)
+{
+pCanonic->setLength(nOriginalCanonicLength);
pCanonic->append(buf);
+}
}
else
{
[Libreoffice-bugs] [Bug 146393] Switch language layout crashes Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=146393 Jan-Marek Glogowski changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Jan-Marek Glogowski --- Please still copy the "About LO" information to the bug report as Mike described in comment 4; that's faster to check then the image. Then tell us what DE or window manager you are using and describe the steps to reproduce (STR) you do to "switching layout". Neither switching the direct layout nor the IM setting crashes LO master here for gen/x11 running in KDE. And actually only the Qt / kf5 or the MS Windows VCL plugin send a SalEvent::InputLanguageChange event, and - according to the screenshot - you're using neither of them. It might be a bug in the X11 IM handling. While a crash backtrace would be nice, without the STR it might be very hard / impossible to fix. Info needed: - copied "About LO" data - DE or window manager setup info - STR - a crash backtrace (optional) I've changed the report status to NEEDINFO. When you provide the missing information, please turn it back to UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug.
