date:20220102

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2022-01-02 Thread Kevin Suo (via logerrit)

 sw/inc/IDocumentSettingAccess.hxx  |2 
 sw/qa/core/text/data/firstLineIndent-withFlag.fodt |   31 
 sw/qa/core/text/text.cxx   |   25 +++
 sw/source/core/doc/DocumentSettingManager.cxx  |9 ++
 sw/source/core/inc/DocumentSettingManager.hxx  |1 
 sw/source/core/text/itrcrsr.cxx|   73 +++--
 sw/source/filter/xml/xmlimp.cxx|6 +
 sw/source/uibase/uno/SwXDocumentSettings.cxx   |   18 +
 8 files changed, 130 insertions(+), 35 deletions(-)

New commits:
commit 86cffd61c1f01a18f4016bb09c8d63a581f5cded
Author: Kevin Suo 
AuthorDate: Mon Nov 22 00:01:34 2021 +0800
Commit: Miklos Vajna 
CommitDate: Mon Jan 3 08:35:21 2022 +0100

tdf#129448: Auto first-line indent should not be effected by line space

Previously, if you set the first line indent to auto, then if you change
the line height, the first line indent will also change. I do not see a
reason to change the first line indent value in case of change in line
spacing, even for English language.

Some languages (e.g. Chinese) may have set the auto first line indent
to be 2 characters of the current font, but if the first line indent
changes when line height changes, then this 2-character rule is not 
possible.

For compatibility with old documents, a compatability flag
'AutoFirstLineIndentDisregardLineSpace' is added in this patch, thus this
patch only has effect to new ODF documents. DOC/DOCX documents will also
benefit from this patch, no matter old or new, because, as Miklos Vajna
has pointed out, Word does not have the auto first line height feature.

Change-Id: I1e2ddc33cce4ff9b3b2b4122445894f724d5bcd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125627
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/IDocumentSettingAccess.hxx 
b/sw/inc/IDocumentSettingAccess.hxx
index 11bef9d2729d..7de8674c4d0f 100644
--- a/sw/inc/IDocumentSettingAccess.hxx
+++ b/sw/inc/IDocumentSettingAccess.hxx
@@ -90,6 +90,8 @@ enum class DocumentSettingId
 // tdf#112443 disable off-page content positioning
 DISABLE_OFF_PAGE_POSITIONING,
 EMPTY_DB_FIELD_HIDES_PARA,
+// tdf#129448: Auto first-line indent should not be effected by line space
+AUTO_FIRST_LINE_INDENT_DISREGARD_LINE_SPACE,
 // COMPATIBILITY FLAGS END
 BROWSE_MODE,
 HTML_MODE,
diff --git a/sw/qa/core/text/data/firstLineIndent-withFlag.fodt 
b/sw/qa/core/text/data/firstLineIndent-withFlag.fodt
new file mode 100644
index ..069b960b9d6f
--- /dev/null
+++ b/sw/qa/core/text/data/firstLineIndent-withFlag.fodt
@@ -0,0 +1,31 @@
+
+
+ 
+  
+   true
+  
+ 
+ 
+  
+ 
+ 
+  
+   
+  
+  
+ 
+ 
+  
+   
+  
+  
+   
+  
+ 
+ 
+  
+   LibreOffice is a free and powerful office 
suite, and a successor to OpenOffice.org (commonly known as OpenOffice). Its 
clean interface and feature-rich tools help you unleash your creativity and 
enhance your productivity. LibreOffice is one of the friendliest and 
fastest-growing projects in the free and open source software world.
+   LibreOffice is a free and powerful office 
suite, and a successor to OpenOffice.org (commonly known as OpenOffice). Its 
clean interface and feature-rich tools help you unleash your creativity and 
enhance your productivity. LibreOffice is one of the friendliest and 
fastest-growing projects in the free and open source software world.
+  
+ 
+
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index 6832ad2cb436..a7c6bc7838a6 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -176,6 +176,31 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testLineWidth)
 CPPUNIT_ASSERT_GREATER(static_cast(65536), nNewLeft - nOldLeft);
 }
 
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testChineseAutoFirstLineIndent)
+{
+// The test document contains two simple multi-line paragraph. For both 
paragraphs, the first line indent
+// is set to 'auto'. Line spacing is 100% for the 1st paragraph and 200% 
for the 2nd paragraph.
+// Also, there is a "AutoFirstLineIndentDisregardLineSpace" capability 
flag set in the document.
+createSwDoc(DATA_DIRECTORY, "firstLineIndent-withFlag.fodt");
+
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+// Get the line width of the first line for the 1st paragrapsh.
+sal_Int32 nFirstLineWidth
+= getXPath(pXmlDoc, 
"//body/txt[1]/SwParaPortion[1]/SwLineLayout[1]/SwLinePortion[1]",
+   "width")
+  .toInt32();
+// Get the line width of the first line for the 2nd paragrapsh.
+sal_Int32 nSecondLineWidth
+= getXPath(pXmlDoc, 
"//body/txt[2]/SwParaPortion[1]/SwLineLayout[1]/SwLinePortion[1]",
+   "width")
+  .toInt32();
+
+// Tdf#129448: the changing of line-height should not affect the auto 
first line indent.
+// As a result, the first

[Libreoffice-bugs] [Bug 92407] Copying Spreadsheet Areas to Text Documents (help docs)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92407

Buovjaga  changed:

   What|Removed |Added

 Attachment #177240|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/headless vcl/inc

2022-01-02 Thread Tomaž Vajngerl (via logerrit)

 vcl/headless/SvpGraphicsBackend.cxx |   29 -
 vcl/headless/svpgdi.cxx |   28 
 vcl/inc/headless/svpgdi.hxx |2 +-
 3 files changed, 29 insertions(+), 30 deletions(-)

New commits:
commit 3aaf8506b3ee0d4a1bb86be7c6ca4d9402467d49
Author: Tomaž Vajngerl 
AuthorDate: Tue Dec 28 09:48:30 2021 +0900
Commit: Tomaž Vajngerl 
CommitDate: Mon Jan 3 08:03:20 2022 +0100

vcl: move getPixel to SvpGraphicsBackend

Change-Id: I409581a2bdc9e18420bb159ce349fb5a5b86c463
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127825
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/headless/SvpGraphicsBackend.cxx 
b/vcl/headless/SvpGraphicsBackend.cxx
index 10c02d4644f9..d5dd2fe48b27 100644
--- a/vcl/headless/SvpGraphicsBackend.cxx
+++ b/vcl/headless/SvpGraphicsBackend.cxx
@@ -383,7 +383,34 @@ std::shared_ptr 
SvpGraphicsBackend::getBitmap(tools::Long /*nX*/, too
 return std::shared_ptr();
 }
 
-Color SvpGraphicsBackend::getPixel(tools::Long /*nX*/, tools::Long /*nY*/) { 
return Color(); }
+Color SvpGraphicsBackend::getPixel(tools::Long nX, tools::Long nY)
+{
+#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
+cairo_surface_t* target
+= cairo_surface_create_similar_image(m_rCairoCommon.m_pSurface, 
CAIRO_FORMAT_ARGB32, 1, 1);
+#else
+cairo_surface_t* target = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, 
1, 1);
+#endif
+
+cairo_t* cr = cairo_create(target);
+
+cairo_rectangle(cr, 0, 0, 1, 1);
+cairo_set_source_surface(cr, m_rCairoCommon.m_pSurface, -nX, -nY);
+cairo_paint(cr);
+cairo_destroy(cr);
+
+cairo_surface_flush(target);
+vcl::bitmap::lookup_table const& unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
+unsigned char* data = cairo_image_surface_get_data(target);
+sal_uInt8 a = data[SVP_CAIRO_ALPHA];
+sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
+sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
+sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
+Color aColor(ColorAlpha, a, r, g, b);
+cairo_surface_destroy(target);
+
+return aColor;
+}
 
 void SvpGraphicsBackend::invert(tools::Long /*nX*/, tools::Long /*nY*/, 
tools::Long /*nWidth*/,
 tools::Long /*nHeight*/, SalInvert /*nFlags*/)
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 523a76fbb530..bc6a6231d1c1 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1108,34 +1108,6 @@ std::shared_ptr SvpSalGraphics::getBitmap( 
tools::Long nX, tools::Lon
 return pBitmap;
 }
 
-Color SvpSalGraphics::getPixel( tools::Long nX, tools::Long nY )
-{
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
-cairo_surface_t *target = 
cairo_surface_create_similar_image(m_aCairoCommon.m_pSurface, 
CAIRO_FORMAT_ARGB32, 1, 1);
-#else
-cairo_surface_t *target = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, 
1, 1);
-#endif
-
-cairo_t* cr = cairo_create(target);
-
-cairo_rectangle(cr, 0, 0, 1, 1);
-cairo_set_source_surface(cr, m_aCairoCommon.m_pSurface, -nX, -nY);
-cairo_paint(cr);
-cairo_destroy(cr);
-
-cairo_surface_flush(target);
-vcl::bitmap::lookup_table const & unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
-unsigned char *data = cairo_image_surface_get_data(target);
-sal_uInt8 a = data[SVP_CAIRO_ALPHA];
-sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
-sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
-sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
-Color aColor(ColorAlpha, a, r, g, b);
-cairo_surface_destroy(target);
-
-return aColor;
-}
-
 namespace
 {
 cairo_pattern_t * create_stipple()
diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx
index 0d36a2cf8442..ba4dec8d29e8 100644
--- a/vcl/inc/headless/svpgdi.hxx
+++ b/vcl/inc/headless/svpgdi.hxx
@@ -140,7 +140,7 @@ public:
   const SalBitmap& rSalBitmap,
   Color nMaskColor ) override;
 virtual std::shared_ptr getBitmap( tools::Long nX, tools::Long 
nY, tools::Long nWidth, tools::Long nHeight ) override;
-virtual Color   getPixel( tools::Long nX, tools::Long nY ) 
override;
+
 virtual voidinvert( tools::Long nX, tools::Long nY, 
tools::Long nWidth, tools::Long nHeight, SalInvert nFlags ) override;
 virtual voidinvert( sal_uInt32 nPoints, const Point* pPtAry, 
SalInvert nFlags ) override;

[Libreoffice-bugs] [Bug 105220] Firebird: Insert with direct SQL - RETURNING without values

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105220

--- Comment #12 from Robert Großkopf  ---
Have tested this again. Nothing changed.

@Julien: The way you described is the workaround I have also written in Base
Handbuch:

SELECT RDB$FIELD_NAME, RDB$RELATION_NAME,
RDB$GENERATOR_NAME FROM RDB$RELATION_FIELDS WHERE
RDB$GENERATOR_NAME IS NOT NULL;

You could see the name for the generator. It is the same way autovalue is
implemented.

SELECT GEN_ID(RDB$1, 1) FROM RDB$DATABASE;

Generator with name RDB$1 is asked for the next generated value.

INSERT INTO "Table" ("ID", "Field") VALUES (, 'Test');

This is the only save mode to get the right data after you inserted a new row:
First the value will be blocked for AutoValue, then this blocked value will be
used for insert.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/inc chart2/source include/svx svx/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/inc/ChartView.hxx  |3 
 chart2/source/controller/drawinglayer/ViewElementListProvider.cxx |2 
 chart2/source/inc/chartview/DataPointSymbolSupplier.hxx   |2 
 chart2/source/view/axes/VAxisBase.hxx |4 
 chart2/source/view/axes/VCartesianAxis.cxx|6 
 chart2/source/view/axes/VCartesianAxis.hxx|4 
 chart2/source/view/axes/VCartesianGrid.cxx|   10 
 chart2/source/view/axes/VCoordinateSystem.cxx |6 
 chart2/source/view/axes/VPolarAngleAxis.cxx   |2 
 chart2/source/view/axes/VPolarAngleAxis.hxx   |2 
 chart2/source/view/axes/VPolarGrid.cxx|   14 -
 chart2/source/view/axes/VPolarGrid.hxx|2 
 chart2/source/view/axes/VPolarRadiusAxis.cxx  |4 
 chart2/source/view/axes/VPolarRadiusAxis.hxx  |4 
 chart2/source/view/charttypes/AreaChart.cxx   |   10 
 chart2/source/view/charttypes/AreaChart.hxx   |8 
 chart2/source/view/charttypes/BarChart.cxx|   21 -
 chart2/source/view/charttypes/BarChart.hxx|2 
 chart2/source/view/charttypes/BubbleChart.cxx |9 
 chart2/source/view/charttypes/CandleStickChart.cxx|   18 -
 chart2/source/view/charttypes/NetChart.cxx|   10 
 chart2/source/view/charttypes/NetChart.hxx|4 
 chart2/source/view/charttypes/PieChart.cxx|9 
 chart2/source/view/charttypes/PieChart.hxx|6 
 chart2/source/view/charttypes/VSeriesPlotter.cxx  |  120 
--
 chart2/source/view/diagram/VDiagram.cxx   |   36 +--
 chart2/source/view/inc/LabelPositionHelper.hxx|6 
 chart2/source/view/inc/LegendEntryProvider.hxx|2 
 chart2/source/view/inc/PlotterBase.hxx|   14 -
 chart2/source/view/inc/PlottingPositionHelper.hxx |4 
 chart2/source/view/inc/PolarLabelPositionHelper.hxx   |2 
 chart2/source/view/inc/ShapeFactory.hxx   |   65 ++---
 chart2/source/view/inc/VCoordinateSystem.hxx  |   14 -
 chart2/source/view/inc/VDataSeries.hxx|   10 
 chart2/source/view/inc/VDiagram.hxx   |   12 -
 chart2/source/view/inc/VLegendSymbolFactory.hxx   |3 
 chart2/source/view/inc/VSeriesPlotter.hxx |   46 +--
 chart2/source/view/main/ChartView.cxx |   22 -
 chart2/source/view/main/DataPointSymbolSupplier.cxx   |2 
 chart2/source/view/main/LabelPositionHelper.cxx   |2 
 chart2/source/view/main/PlotterBase.cxx   |8 
 chart2/source/view/main/PlottingPositionHelper.cxx|2 
 chart2/source/view/main/PolarLabelPositionHelper.cxx  |2 
 chart2/source/view/main/ShapeFactory.cxx  |  106 
+---
 chart2/source/view/main/VButton.cxx   |5 
 chart2/source/view/main/VButton.hxx   |4 
 chart2/source/view/main/VLegend.cxx   |   10 
 chart2/source/view/main/VLegend.hxx   |4 
 chart2/source/view/main/VLegendSymbolFactory.cxx  |7 
 chart2/source/view/main/VTitle.cxx|2 
 chart2/source/view/main/VTitle.hxx|5 
 include/svx/unoshape.hxx  |   22 +
 svx/source/unodraw/unoshap2.cxx   |   13 +
 svx/source/unodraw/unoshap3.cxx   |2 
 54 files changed, 377 insertions(+), 337 deletions(-)

New commits:
commit 7c36f46a1ea35633d64c44a2ee1e834b1f88cc8d
Author: Noel Grandin 
AuthorDate: Sun Jan 2 20:49:46 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 3 07:46:45 2022 +0100

add new SvxShape hierarchy class

to serve as a shared/common base class, so I can plumb
SvxShape types through chart2.

Change-Id: I8758fff1599c92a214b334ee44cf7b4e582c1915
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127873
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/inc/ChartView.hxx b/chart2/inc/ChartView.hxx
index fb73f06a2d1f..27408b53f844 100644
--- a/chart2/inc/ChartView.hxx
+++ b/chart2/inc/ChartView.hxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -217,7 +218,7 @@ private: //member
 m_xShapeFactory;

[Libreoffice-commits] core.git: chart2/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/source/view/axes/VCartesianAxis.cxx |   21 ++---
 chart2/source/view/charttypes/AreaChart.cxx|4 ++--
 chart2/source/view/charttypes/BarChart.cxx |6 +++---
 chart2/source/view/charttypes/BubbleChart.cxx  |2 +-
 chart2/source/view/charttypes/CandleStickChart.cxx |9 -
 chart2/source/view/charttypes/NetChart.cxx |4 ++--
 chart2/source/view/charttypes/PieChart.cxx |2 +-
 chart2/source/view/charttypes/VSeriesPlotter.cxx   |9 -
 chart2/source/view/diagram/VDiagram.cxx|3 +--
 chart2/source/view/inc/VSeriesPlotter.hxx  |2 +-
 chart2/source/view/main/ShapeFactory.cxx   |7 +++
 chart2/source/view/main/VLegendSymbolFactory.cxx   |2 +-
 12 files changed, 29 insertions(+), 42 deletions(-)

New commits:
commit 5f41e5741fa3abe59dd14a50e692d425eed472d5
Author: Noel Grandin 
AuthorDate: Sun Jan 2 14:51:28 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 3 07:46:26 2022 +0100

use more SvxShape in chart2

Change-Id: I7fb23da1ad60d07ac8c3165f70dafefcfaf5ab8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127872
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/view/axes/VCartesianAxis.cxx 
b/chart2/source/view/axes/VCartesianAxis.cxx
index 00020d1f0413..5910a0c73ab3 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -73,27 +73,22 @@ VCartesianAxis::~VCartesianAxis()
 m_pPosHelper = nullptr;
 }
 
-static void lcl_ResizeTextShapeToFitAvailableSpace( SvxShape& xShape2DText,
+static void lcl_ResizeTextShapeToFitAvailableSpace( SvxShapeText& rShape2DText,
  const AxisLabelProperties& 
rAxisLabelProperties,
  const OUString& rLabel,
  const tNameSequence& rPropNames,
  const tAnySequence& rPropValues,
  const bool bIsHorizontalAxis )
 {
-uno::Reference< text::XTextRange > xTextRange( xShape2DText, 
uno::UNO_QUERY );
-
-if( !xTextRange.is() )
-return;
-
 const sal_Int32 nFullSize = bIsHorizontalAxis ? 
rAxisLabelProperties.m_aFontReferenceSize.Height : 
rAxisLabelProperties.m_aFontReferenceSize.Width;
 
 if( !nFullSize || !rLabel.getLength() )
 return;
 
 sal_Int32 nMaxLabelsSize = bIsHorizontalAxis ? 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Height : 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Width;
-const sal_Int32 nAvgCharWidth = xShape2DText.getSize().Width / 
rLabel.getLength();
-const sal_Int32 nTextSize = bIsHorizontalAxis ? 
ShapeFactory::getSizeAfterRotation(xShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Height :
-
ShapeFactory::getSizeAfterRotation(xShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Width;
+const sal_Int32 nAvgCharWidth = rShape2DText.getSize().Width / 
rLabel.getLength();
+const sal_Int32 nTextSize = bIsHorizontalAxis ? 
ShapeFactory::getSizeAfterRotation(rShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Height :
+
ShapeFactory::getSizeAfterRotation(rShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Width;
 
 if( !nAvgCharWidth )
 return;
@@ -112,13 +107,9 @@ static void lcl_ResizeTextShapeToFitAvailableSpace( 
SvxShape& xShape2DText,
 OUString aNewLabel = rLabel.copy( 0, nNewLen );
 if( nNewLen > sDots.getLength() )
 aNewLabel += sDots;
-xTextRange->setString( aNewLabel );
+rShape2DText.setString( aNewLabel );
 
-uno::Reference< beans::XPropertySet > xProp( xTextRange, uno::UNO_QUERY );
-if( xProp.is() )
-{
-PropertyMapper::setMultiProperties( rPropNames, rPropValues, xProp );
-}
+PropertyMapper::setMultiProperties( rPropNames, rPropValues, rShape2DText 
);
 }
 
 static rtl::Reference createSingleLabel(
diff --git a/chart2/source/view/charttypes/AreaChart.cxx 
b/chart2/source/view/charttypes/AreaChart.cxx
index 46c271bc6e7c..d80a78d7f03f 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -436,7 +436,7 @@ bool AreaChart::impl_createLine( VDataSeries* pSeries
 {
 xShape = ShapeFactory::createLine2D( xSeriesGroupShape_Shapes
 , PolyToPointSequence( aPoly ) );
-setMappedProperties( xShape
+setMappedProperties( *xShape
 , pSeries->getPropertiesOfSeries()
 , PropertyMapper::getPropertyNameMapForLineSeriesProperties() 
);
 //because of this name this line will be used for marking
@@ -512,7 +512,7 @@ bool AreaChart::impl_createArea( VDataSeries* pSeries
 xShape = ShapeFactory::createArea2D(

[Libreoffice-bugs] [Bug 146536] Improper display of newly added text in front of formula object

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146536

d00m3d@gmail.com changed:

   What|Removed |Added

 Attachment #177266|Sample doc with formula |Sample odt with formula
description|objects.|objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146536] Improper display of newly added text in front of formula object

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146536

--- Comment #3 from d00m3d@gmail.com ---
Created attachment 177268
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177268=edit
Text incorrectly displayed before formula objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146536] Improper display of newly added text in front of formula object

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146536

--- Comment #2 from d00m3d@gmail.com ---
Created attachment 177267
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177267=edit
Text display correctly before formula objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146536] Improper display of newly added text in front of formula object

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146536

--- Comment #1 from d00m3d@gmail.com ---
Created attachment 177266
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177266=edit
Sample doc with formula objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146536] New: Improper display of newly added text in front of formula object

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146536

Bug ID: 146536
   Summary: Improper display of newly added text in front of
formula object
   Product: LibreOffice
   Version: 7.3.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: d00m3d@gmail.com

Description:
In LO 7.3.x+, newly added text cannot be displayed properly in front of formula
object.  The formula object itself is displayed properly.
In print preview mode, everything looks fine.  When exited preview mode,
everything also looks fine but adding new text before formula object cannot be
displayed properly again.

Steps to Reproduce:
1. Start Writer
2. Create a new Formula Object, exit formula editor.  Alternatively, open the
attached sample odt.
3. In normal text editor, move cursor before formula object
4. Insert NEW text

Actual Results:
NEWLY inserted text before formula object cannot be displayed properly.

Expected Results:
NEWLY inserted text should be displayed properly.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested LO versions with improper display:

Version: 7.3.0.1.0+ (x64) / LibreOffice Community
Build ID: bd7f01c4ca5222d8d3293cc81802cfd6c0bfdcc3
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd1b0471b70f9b5c5db6b681c1fceacfe17c9349
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version of LO last known good:

Version: 6.4.8.0.0+ (x64)
Build ID: 188ddcd482150b5fdeb44d97e57831e3e27b3f5b
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: GL; VCL: win; 
Locale: en-HK (en_HK); UI-Language: en-US
Calc: CL

Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

Version: 7.2.6.0.0+ (x64) / LibreOffice Community
Build ID: df77dcbbb2ecd3a272a3ea55877a1b1c9fd8ef03
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: en-HK (en_HK); UI: en-US
Calc: CL

I have no ideas when was this first happened but it does not seems to have same
problem with versions prior to 7.3.

I would be highly appreciated if this regression could be fixed before formal
release of 7.3.

Thanks a lot!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146535] New: Mouse line goes missing when changing paragraph stile

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146535

Bug ID: 146535
   Summary: Mouse line goes missing when changing paragraph stile
   Product: LibreOffice
   Version: 7.2.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aljaz.bozi...@aol.com

Description:
Hi. For some reason when I change paragraph stile that blinking thing that
shows where I am in the document disappears and I can't type anymore where I
was before or select any part of text. However, for some reason it reappears if
I minimise and maximise LibreOffice document and the stile is changed as
desirable. It gets quite annoying, but at least I don't have to restart the
entire document.

Steps to Reproduce:
1. default stile
2. select with your mouse in paragraph stile selection tool and choose another
stile

Actual Results:
blinking pointer disappears

Expected Results:
nothing strange should happen, it should just change to the selected stile


Reproducible: Always


User Profile Reset: No



Additional Info:
Using Kubuntu, mostly unmodified.
If you minimise and then maximise, the document problem fixes itself, so
whatever that does is probably connected to the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 70241] EDITING: Problem using preview icon

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=70241

--- Comment #11 from Vaho  ---
Whatever approach you prefer, it’s great to start the new year feeling
refreshed and focused, so you are ready to take on the year ahead.
https://tutuappx.com/ https://vidmate.onl/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 70235] MAILMERGE: transfer status shows incorrect total number ("x of y e-mails sent")

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=70235

--- Comment #4 from Vaho  ---
You can do things like get a haircut, donate unworn clothing, start a workout
routine, or perform more random acts of kindness.
https://dltutuapp.com/tutuapp-download/ https://showbox.run/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/source/controller/main/ChartController_Tools.cxx |   45 ++--
 1 file changed, 19 insertions(+), 26 deletions(-)

New commits:
commit 2678e4467f2d7d193b93e4cdd1b96b12d3ff53f1
Author: Noel Grandin 
AuthorDate: Sun Jan 2 14:13:06 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 3 06:49:46 2022 +0100

use more SvxShape in chart2

Change-Id: Iedc03bd4e55ecb35012432c774a7510957c22333
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127871
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/main/ChartController_Tools.cxx 
b/chart2/source/controller/main/ChartController_Tools.cxx
index 0515bc84ccb7..27454b66ae70 100644
--- a/chart2/source/controller/main/ChartController_Tools.cxx
+++ b/chart2/source/controller/main/ChartController_Tools.cxx
@@ -69,6 +69,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -350,12 +351,8 @@ void ChartController::impl_PasteGraphic(
 DrawModelWrapper * pDrawModelWrapper( GetDrawModelWrapper());
 if( ! (xGraphic.is() && xModelProp.is()))
 return;
-uno::Reference< lang::XMultiServiceFactory > xFact( 
pDrawModelWrapper->getShapeFactory());
-uno::Reference< drawing::XShape > xGraphicShape(
-xFact->createInstance( "com.sun.star.drawing.GraphicObjectShape" ), 
uno::UNO_QUERY );
-uno::Reference< beans::XPropertySet > xGraphicShapeProp( xGraphicShape, 
uno::UNO_QUERY );
-if( !(xGraphicShapeProp.is() && xGraphicShape.is()))
-return;
+rtl::Reference xGraphicShape = new 
SvxGraphicObject(nullptr);
+xGraphicShape->setShapeKind(OBJ_GRAF);
 
 uno::Reference< drawing::XShapes > xPage = 
pDrawModelWrapper->getMainDrawPage();
 if( xPage.is())
@@ -371,14 +368,13 @@ void ChartController::impl_PasteGraphic(
 m_aSelection.setSelection( xGraphicShape );
 m_aSelection.applySelection( m_pDrawViewWrapper.get() );
 }
-xGraphicShapeProp->setPropertyValue( "Graphic", uno::Any( xGraphic ));
-uno::Reference< beans::XPropertySet > xGraphicProp( xGraphic, 
uno::UNO_QUERY );
+xGraphicShape->SvxShape::setPropertyValue( "Graphic", uno::Any( xGraphic 
));
 
 awt::Size aGraphicSize( 1000, 1000 );
 auto pChartWindow(GetChartWindow());
 // first try size in 100th mm, then pixel size
-if( ! ( xGraphicProp->getPropertyValue( "Size100thMM") >>= aGraphicSize ) 
&&
-( ( xGraphicProp->getPropertyValue( "SizePixel") >>= aGraphicSize ) && 
pChartWindow ))
+if( ! ( xGraphicShape->SvxShape::getPropertyValue( "Size100thMM") >>= 
aGraphicSize ) &&
+( ( xGraphicShape->SvxShape::getPropertyValue( "SizePixel") >>= 
aGraphicSize ) && pChartWindow ))
 {
 ::Size aVCLSize( pChartWindow->PixelToLogic( Size( aGraphicSize.Width, 
aGraphicSize.Height )));
 aGraphicSize.Width = aVCLSize.getWidth();
@@ -449,32 +445,29 @@ void ChartController::impl_PasteStringAsTextShape( const 
OUString& rString, cons
 if ( !(pDrawModelWrapper && m_pDrawViewWrapper) )
 return;
 
-const Reference< lang::XMultiServiceFactory >& xShapeFactory( 
pDrawModelWrapper->getShapeFactory() );
 const Reference< drawing::XDrawPage >& xDrawPage( 
pDrawModelWrapper->getMainDrawPage() );
-OSL_ASSERT( xShapeFactory.is() && xDrawPage.is() );
+OSL_ASSERT( xDrawPage.is() );
 
-if ( !(xShapeFactory.is() && xDrawPage.is()) )
+if ( !xDrawPage )
 return;
 
 try
 {
-Reference< drawing::XShape > xTextShape(
-xShapeFactory->createInstance( "com.sun.star.drawing.TextShape" ), 
uno::UNO_QUERY_THROW );
+rtl::Reference xTextShape = new SvxShapeText(nullptr);
+xTextShape->setShapeKind(OBJ_TEXT);
 xDrawPage->add( xTextShape );
 
-Reference< text::XTextRange > xRange( xTextShape, uno::UNO_QUERY_THROW 
);
-xRange->setString( rString );
+xTextShape->setString( rString );
 
 float fCharHeight = 10.0;
-Reference< beans::XPropertySet > xProperties( xTextShape, 
uno::UNO_QUERY_THROW );
-xProperties->setPropertyValue( "TextAutoGrowHeight", uno::Any( true ) 
);
-xProperties->setPropertyValue( "TextAutoGrowWidth", uno::Any( true ) );
-xProperties->setPropertyValue( "CharHeight", uno::Any( fCharHeight ) );
-xProperties->setPropertyValue( "CharHeightAsian", uno::Any( 
fCharHeight ) );
-xProperties->setPropertyValue( "CharHeightComplex", uno::Any( 
fCharHeight ) );
-xProperties->setPropertyValue( "TextVerticalAdjust", uno::Any( 
drawing::TextVerticalAdjust_CENTER ) );
-xProperties->setPropertyValue( "TextHorizontalAdjust", uno::Any( 
drawing::TextHorizontalAdjust_CENTER ) );
-xProperties->setPropertyValue( "CharFontName", uno::Any( 
OUString("Albany") ) );
+xTextShape->SvxShape::setPropertyValue( "TextAutoGrowHeight", 
uno::Any( true ) );
+xTextShape->SvxShape::setPropertyValue( "TextAutoGrowWidth", uno::Any( 
true ) );
+

[Libreoffice-commits] core.git: compilerplugins/clang cui/source drawinglayer/source include/drawinglayer

2022-01-02 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/unusedmethods.results|  420 +++--
 compilerplugins/clang/unusedmethods.unused-returns.results |   16 
 cui/source/inc/cuihyperdlg.hxx |1 
 drawinglayer/source/primitive2d/Primitive2DContainer.cxx   |   22 
 include/drawinglayer/primitive2d/Primitive2DContainer.hxx  |   10 
 include/drawinglayer/primitive2d/baseprimitive2d.hxx   |   12 
 6 files changed, 243 insertions(+), 238 deletions(-)

New commits:
commit e4423520845ca4f566474e57cd0c0988034e0c7c
Author: Noel Grandin 
AuthorDate: Sun Jan 2 14:13:25 2022 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 3 06:49:18 2022 +0100

loplugin:unusedmethods

Change-Id: I922778e8ced0ad922d90a153b0eda47abbec94ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127868
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedmethods.results 
b/compilerplugins/clang/unusedmethods.results
index 035eadbe0e9e..2e63c737fc44 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -44,9 +44,11 @@ connectivity/inc/sdbcx/VGroup.hxx:61
  connectivity::sdbcx::OGroup::OGroup(_Bool)
 connectivity/inc/sdbcx/VGroup.hxx:62
  connectivity::sdbcx::OGroup::OGroup(const class rtl::OUString &,_Bool)
+connectivity/source/drivers/evoab2/NResultSet.hxx:60
+class rtl::OString 
connectivity::evoab::OEvoabVersionHelper::getUserName(void *)
 connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:49
 class com::sun::star::uno::Reference 
connectivity::evoab::OEvoabResultSetMetaData::operator Reference()
-connectivity/source/drivers/firebird/Driver.hxx:59
+connectivity/source/drivers/firebird/Driver.hxx:61
 const class com::sun::star::uno::Reference & 
connectivity::firebird::FirebirdDriver::getContext() const
 connectivity/source/drivers/firebird/Util.hxx:65
  connectivity::firebird::ColumnTypeInfo::ColumnTypeInfo(short,const class 
rtl::OUString &)
@@ -56,7 +58,7 @@ connectivity/source/drivers/firebird/Util.hxx:71
 short connectivity::firebird::ColumnTypeInfo::getSubType() const
 connectivity/source/drivers/firebird/Util.hxx:73
 const class rtl::OUString & 
connectivity::firebird::ColumnTypeInfo::getCharacterSet() const
-connectivity/source/drivers/mysqlc/mysqlc_connection.hxx:175
+connectivity/source/drivers/mysqlc/mysqlc_connection.hxx:176
 class rtl::OUString 
connectivity::mysqlc::OConnection::transFormPreparedStatement(const class 
rtl::OUString &)
 connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx:93
 type-parameter-?-? 
connectivity::mysqlc::OPreparedResultSet::safelyRetrieveValue(const int)
@@ -86,6 +88,8 @@ connectivity/source/inc/OTypeInfo.hxx:46
 _Bool connectivity::OTypeInfo::operator!=(const struct 
connectivity::OTypeInfo &) const
 cui/source/dialogs/SpellAttrib.hxx:72
 _Bool svx::SpellErrorDescription::operator==(const struct 
svx::SpellErrorDescription &) const
+cui/source/inc/cuihyperdlg.hxx:110
+_Bool SvxHpLinkDlg::AskApply(_Bool)
 cui/source/inc/CustomNotebookbarGenerator.hxx:30
  CustomNotebookbarGenerator::CustomNotebookbarGenerator()
 cui/source/inc/fileextcheckdlg.hxx:32
@@ -122,7 +126,7 @@ dbaccess/source/ui/inc/indexcollection.hxx:63
 class __gnu_debug::_Safe_iterator >, 
class std::vector, struct 
std::random_access_iterator_tag> dbaui::OIndexCollection::findOriginal(const 
class rtl::OUString &) const
 dbaccess/source/ui/inc/sbamultiplex.hxx:281
 class comphelper::OInterfaceContainerHelper3 * 
dbaui::SbaXVetoableChangeMultiplexer::getContainer(const class rtl::OUString &)
-dbaccess/source/ui/inc/unodatbr.hxx:314
+dbaccess/source/ui/inc/unodatbr.hxx:315
 _Bool dbaui::SbaTableQueryBrowser::implCopyObject(class ODataClipboard 
&,const class weld::TreeIter &,int)
 desktop/source/lib/lokclipboard.hxx:95
  LOKClipboardFactory::LOKClipboardFactory()
@@ -348,11 +352,11 @@ include/basegfx/tuple/b3ituple.hxx:66
 const int & basegfx::B3ITuple::operator[](int) const
 include/basegfx/tuple/b3ituple.hxx:75
 int & basegfx::B3ITuple::operator[](int)
-include/basegfx/tuple/Tuple2D.hxx:79
+include/basegfx/tuple/Tuple2D.hxx:77
 _Bool basegfx::Tuple2D::equal(const class basegfx::Tuple2D &) const
-include/basegfx/tuple/Tuple2D.hxx:79
+include/basegfx/tuple/Tuple2D.hxx:77
 _Bool basegfx::Tuple2D::equal(const class basegfx::Tuple2D &) const
-include/basegfx/tuple/Tuple2D.hxx:79
+include/basegfx/tuple/Tuple2D.hxx:77
 _Bool basegfx::Tuple2D::equal(const class basegfx::Tuple2D &) const
 include/basegfx/utils/b2dclipstate.hxx:72
 _Bool basegfx::utils::B2DClipState::operator!=(const class 
basegfx::utils::B2DClipState &) const
@@ -360,7 +364,7 @@ include/basegfx/utils/canvastools.hxx:109
 struct com::sun::star::geometry::AffineMatrix3D & 
basegfx::unotools::affineMatrixFromHomMatrix3D(struct 
com::sun::star::geometry::AffineMatrix3D &,const class basegfx::B3DHomMatrix &)

[Libreoffice-bugs] [Bug 36582] "Find and replace" finds/replaces text deleted with "record/track changes"

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=36582

--- Comment #30 from Hussam Al-Tayeb  ---
Please don't spread incorrect information.

It does not resemble the Microsoft Word behavior. I just tested on both
Sharepoint and desktop MS Office 365.
Please test again. You probably did not understand the bug.
Libreoffice replaces the deleted text with each recursion while
Microsoft Office does not replace deleted text.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 36582] "Find and replace" finds/replaces text deleted with "record/track changes"

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=36582

--- Comment #29 from Lars Jødal  ---
(In reply to NISZ LibreOffice Team from comment #23)
> Created attachment 159953 [details]
> Screenshot of Word and Writer side by side after following the steps
> 
> Still happens in:
> 
> Version: 7.0.0.0.alpha0+ (x64)
> [...]
> 
> Also: this behavior is the same as in Word.

As noted by NISZ LibreOffice Team, the behaviour is very much similar i Word:
Also in Word, Search & Replace while showing track-changes, does search within
deleted text and replaces with non-deleted text. Just tested with MS Office
365.

I can see why it can sometimes be relevant to search also in deleted text, e.g.
to find where you (or a colleague) deleted something. And if you do not want
this, just turn off showing track-changes. But I fail to see why anybody would
want already-deleted text to be part of replacing. (Even before the problems of
doing more than one search & replace, leading to several instances of the new
text.) Well, failing the see the use could be just my lack of imagination. So:

Can anybody come up with a case where searching within deleted text and
replacing with new text would be the intended behaviour? 

Put another way: Can anybody see a reason why this would NOT be a bug
(happening to be shared by LO and MS Office)?

PS: Word notes the user that "We are through searching the document" after one
pass, so the user will at least know that if s/he continues replacing, it will
be in text that had already been considered. This will stop most users from
repeated replacement, but does not change the question how replacing at all in
deleted text could be the intended behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108082] Firebird:The user can enter up to 20 characters in a field with a length of 5

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108082

--- Comment #11 from avshara...@list.ru ---
I checked for LO 7.2.4.1. It was not possible to enter more than 5 characters
(Russian and Latin characters were entered).
A non-localized message was issued :( a message about exceeding the length.
The Gbak utility restores the database without errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146316] A marked extruded shape is not contained in CurrentSelection in Writer

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146316

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142663] Paragraph Style does not change all lines in Writer

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142663

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142663] Paragraph Style does not change all lines in Writer

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142663

--- Comment #4 from QA Administrators  ---
Dear lloyde4628,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142411] LibreOffice paste unformatted text results in Chinese (simplified)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142411

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142411] LibreOffice paste unformatted text results in Chinese (simplified)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142411

--- Comment #3 from QA Administrators  ---
Dear luancarvalhomartins,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125964] Font not recognized

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125964

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125964] Font not recognized

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125964

--- Comment #13 from QA Administrators  ---
Dear seven,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 104867] Impress does not compress repeated(copied) images with Minimize Presentation

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104867

--- Comment #8 from QA Administrators  ---
Dear Maxim Britov,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146507] Delay/lag with context menu (right click) if "font size" present

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146507

--- Comment #8 from golemus  ---
(In reply to Rainer Bielefeld Retired from comment #5)
> (In reply to golemus from comment #3)
> So we will need more indication whether it's only something like general CPU
> overload or indeed something with context menus which needs improvement.

Check out my latest update. "Font Size" in context menu (which I had added
there) seems to be causing the delay/lag. I updated also title of this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146507] Delay/lag with context menu (right click) if "font size" present

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146507

--- Comment #7 from golemus  ---
I think I have identified cause of this bug. I have added the item "Font Size"
to context menu of Writer and Calc. It seems to cause the delay. When I remove
font size from there the delay disappears.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146507] Delay/lag with context menu (right click) if "font size" present

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146507

golemus  changed:

   What|Removed |Added

Summary|Delay/lag with context menu |Delay/lag with context menu
   |(right click)   |(right click) if "font
   ||size" present

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa

2022-01-02 Thread Thorsten Behrens (via logerrit)

 sc/qa/unit/subsequent_filters_test2.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 660e538ee77109bc3e7dff4491164d696e503abc
Author: Thorsten Behrens 
AuthorDate: Mon Jan 3 02:20:51 2022 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Jan 3 04:35:35 2022 +0100

Disable broken part of ScFiltersTest2::testTdf126116

Fails since New Year with:
 Test name: ScFiltersTest2::testTdf126116
 equality assertion failed
 - Expected: 03/03/21
 - Actual  : 03/03/22

Change-Id: Ic5c259e6bf1f184ceb7cf15e1ba7a83dac729c2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127879
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sc/qa/unit/subsequent_filters_test2.cxx 
b/sc/qa/unit/subsequent_filters_test2.cxx
index c2e6725ae316..6055b286f330 100644
--- a/sc/qa/unit/subsequent_filters_test2.cxx
+++ b/sc/qa/unit/subsequent_filters_test2.cxx
@@ -1372,7 +1372,8 @@ void ScFiltersTest2::testTdf126116()
 // Without the fix in place, this test would have failed with
 // - Expected: 03/03/21
 // - Actual  : 03/03/2021
-CPPUNIT_ASSERT_EQUAL(OUString("03/03/" + aYear), 
rDoc.GetString(ScAddress(0, 0, 0)));
+(void)
+aYear; //CPPUNIT_ASSERT_EQUAL(OUString("03/03/" + aYear), 
rDoc.GetString(ScAddress(0, 0, 0)));
 
 xDocSh->DoClose();
 }

[Libreoffice-bugs] [Bug 146534] FILEOPEN PPTX: 3D only Z-Rotation applied shape not viewed correctly

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146534

Sarper Akdemir  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||sarper.akde...@collabora.co
   ||m
   Assignee|libreoffice-b...@lists.free |sarper.akde...@collabora.co
   |desktop.org |m
 Status|UNCONFIRMED |ASSIGNED

--- Comment #1 from Sarper Akdemir  ---
Created attachment 177263
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177263=edit
Presentation from PowerPoint with Z rotation applied shapes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146534] New: FILEOPEN PPTX: 3D only Z-Rotation applied shape not viewed correctly

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146534

Bug ID: 146534
   Summary: FILEOPEN PPTX: 3D only Z-Rotation applied shape not
viewed correctly
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sarper.akde...@collabora.com

Description:
3-D Rotation around only Z axis applied shape from MSO Powerpoint, viewed
incorrectly in Impress on FILEOPEN.

Steps to Reproduce:
1. Open attached document
2. View first and second slide

Actual Results:
On first slide text is horizontal without any rotation.
On the second slide, block has no incline.

Expected Results:
Text should be rotated 90 degrees and be vertical.
Block should have an incline.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.4.1
Build ID: 20(Build:1)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

--- Comment #5 from jsv  ---
Created attachment 177262
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177262=edit
Appearance (comparison)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

--- Comment #4 from jsv  ---
Created attachment 177261
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177261=edit
image file 3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

--- Comment #3 from jsv  ---
Created attachment 177260
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177260=edit
image file 2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

--- Comment #2 from jsv  ---
Created attachment 177259
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177259=edit
image file 1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

--- Comment #1 from jsv  ---
Created attachment 177258
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177258=edit
document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146533] New: Some PNG images are inserted somewhat blurry

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146533

Bug ID: 146533
   Summary: Some PNG images are inserted somewhat blurry
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: avtomot...@gmail.com

Description:
I have a PDF copy of Jan Tschichold's "The Form of the Book" and each time I
make a screenshot from it and insert in Writer as PNG, the text on the image is
displayed somewhat blurry.

This is really very strange.

If I insert the same screenshots as JPG, the text on them look sharp. And if I
type some random text in Times New Roman 11 or 10 pt italic, and save it as
png, their text is displayed in Writer sharply as well.

What may be the problem?

Steps to Reproduce:
see above

Actual Results:
see above

Expected Results:
see above


Reproducible: Always


User Profile Reset: No



Additional Info:
see above

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2022-01-02 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1496843:(UNCAUGHT_EXCEPT)
/vcl/workben/minvcl.cxx: 58 in main()
/vcl/workben/minvcl.cxx: 58 in main()
/vcl/workben/minvcl.cxx: 58 in main()



*** CID 1496843:(UNCAUGHT_EXCEPT)
/vcl/workben/minvcl.cxx: 58 in main()
52 mpWin->Show();
53 Execute();
54 mpWin.disposeAndClear();
55 return 0;
56 }
57 
>>> CID 1496843:(UNCAUGHT_EXCEPT)
>>> In function "main()" an exception of type 
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
58 int main()
59 {
60 auto xContext = cppu::defaultBootstrap_InitialComponentContext();
61 css::uno::Reference xServiceManager(
62 xContext->getServiceManager(), css::uno::UNO_QUERY);
63 comphelper::setProcessServiceFactory(xServiceManager);
/vcl/workben/minvcl.cxx: 58 in main()
52 mpWin->Show();
53 Execute();
54 mpWin.disposeAndClear();
55 return 0;
56 }
57 
>>> CID 1496843:(UNCAUGHT_EXCEPT)
>>> In function "main()" an exception of type 
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
58 int main()
59 {
60 auto xContext = cppu::defaultBootstrap_InitialComponentContext();
61 css::uno::Reference xServiceManager(
62 xContext->getServiceManager(), css::uno::UNO_QUERY);
63 comphelper::setProcessServiceFactory(xServiceManager);
/vcl/workben/minvcl.cxx: 58 in main()
52 mpWin->Show();
53 Execute();
54 mpWin.disposeAndClear();
55 return 0;
56 }
57 
>>> CID 1496843:(UNCAUGHT_EXCEPT)
>>> In function "main()" an exception of type 
>>> "com::sun::star::uno::RuntimeException" is thrown and never caught.
58 int main()
59 {
60 auto xContext = cppu::defaultBootstrap_InitialComponentContext();
61 css::uno::Reference xServiceManager(
62 xContext->getServiceManager(), css::uno::UNO_QUERY);
63 comphelper::setProcessServiceFactory(xServiceManager);

** CID 1496842:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/workben/minvcl.cxx: 58 in main()



*** CID 1496842:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/workben/minvcl.cxx: 58 in main()
52 mpWin->Show();
53 Execute();
54 mpWin.disposeAndClear();
55 return 0;
56 }
57 
>>> CID 1496842:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> In function "main()" an exception of type 
>>> "com::sun::star::uno::DeploymentException" is thrown and never caught.
58 int main()
59 {
60 auto xContext = cppu::defaultBootstrap_InitialComponentContext();
61 css::uno::Reference xServiceManager(
62 xContext->getServiceManager(), css::uno::UNO_QUERY);
63 comphelper::setProcessServiceFactory(xServiceManager);



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DL_eI_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiLpUJ63ohom28eyGrhH5qlY5QkhryKaulSqpHuzZa68Zoh7y0-2FvoyAbqAt-2FJqYg2fhP057YrGS69qmcrIxgwgwU2B5PDRLYNYMsiz5Vf15-2FDd45g34beXRk1oPOqeVKIOKA884GP-2FcIljnG7g-2FpVh-2BZV9ZOZbOy7Q5-2FXT0PyEBA4-3D

[Libreoffice-bugs] [Bug 130076] Flip from file format ignores angles in section, arc and cut shape

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130076

--- Comment #3 from Regina Henschel  ---
Created attachment 177257
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177257=edit
Examples with small sector

The examples have angles in a way, that the actual outline rectangle is smaller
than width x height.

(BTW, the fact that the text is rotated 180deg in case of vertical flip is no
error but intended.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122684] Copying range using VBA doesn't work correctly

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=122684

Hossein  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |hoss...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146490] UI: Field in a footnote (like page number) lists a single time in navigator (and only for last page)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146490

--- Comment #4 from Jim Raykowski  ---
Forgot to mention that the additional Page number field shown in the screen
shot is due to adding a Header and inserting a Page number field in it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146490] UI: Field in a footnote (like page number) lists a single time in navigator (and only for last page)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146490

--- Comment #3 from Jim Raykowski  ---
Created attachment 177256
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177256=edit
header footer tag for page number field

@Telesto, Happy New LO Year!

Think you mean fields in the footer. 

I noticed when 'Same content on left and right pages' and 'Same content on
first page' settings are turned off, 'Page number - 3, 2, 1' show in the Fields
category along with a grayed out 'Page number - 3'.

Perhaps add a 'Header/Footer' tag to the field listing in the Navigator such as
is shown in the attached screen shot?

The grayed out field seems to me to be a bug with header/footer handling of
fields. We could sweep it under the carpet by not displaying fields in the
header/footer that are in hidden state. What do you think? Maybe discuss in a
separate ticket?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138531] Dynamic Data Exchange is not operable

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138531

--- Comment #13 from gmarco  ---
Look at the new bug 146532

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146532] New: Linking objects from Calc to Write in DDE mode.

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146532

Bug ID: 146532
   Summary: Linking objects from Calc to Write in DDE mode.
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gmmell...@inwind.it

Now, with L.O. 7.2.4.1, the connection works correctly again.
There remains a minor bug that I had already reported in the past.
When opening a text document that has links to scalc files embedded, you are
asked if you want to update it or not (in the meantime the data in the
spreadsheet may have changed).
Choosing "YES" the embedded object will reflect the current state of the data
in the spreadsheet.

At this point, closing the ODT file, the bug can occur if the closing is
performed by clicking on "X" as commonly used.

a) if the document has not been further edited (changes to the actual text),
the closure takes place without saving (and this without even a warning) losing
the upgrades.

b) the problem does not occur in all other cases:
- the text has also been changed
- the embedded ODS data has been updated manually from "Edit> Links to external
files ..." (Update button)
- close the ODT file with "Save" or "Save with name".

Question: is this a bug? or is the fact intentional? in the latter case, I
think it would be right to indicate it and prevent possible damage with a
warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146531] New: Resetting Footnote Area to Larger Than Page Area Does Not Work

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146531

Bug ID: 146531
   Summary: Resetting Footnote Area to Larger Than Page Area Does
Not Work
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: larrywbrad...@gmail.com

Description:
When I reset the Footnote Area to "Not Larger Than Page Area" the footnote
continues to break across pages and the footnote is only about an inch in
height on the page where the footnote starts. In the Help section, not sure
what the phrase "depending on the number of footnotes" means, but the phrase
seems to contradict "Not Larger Than Page Area." Not sure if this is a bug or
simply a very obscure way of describing the function.

Steps to Reproduce:
1.Format, Page Style, Footnote, Footnote Area, select "Not Larger than Page
Area"
2.Click Okay.

Actual Results:
Footnote splits across pages.

Expected Results:
Expect footnote to be entirely on one page, not break across pages.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-01-02 Thread Caolán McNamara (via logerrit)

 sw/source/filter/ww8/ww8par2.cxx |   45 +++
 1 file changed, 45 insertions(+)

New commits:
commit 73631b1bf52a2e6dd8a85d6fef36d754c15dcf82
Author: Caolán McNamara 
AuthorDate: Sun Jan 2 20:22:24 2022 +
Commit: Caolán McNamara 
CommitDate: Sun Jan 2 22:57:41 2022 +0100

ofz#43052 crash in WW8TabDesc::MergeCells

Change-Id: I4d7acc006458598ad43033fa8e35b2f422d76ff5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127876
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index a50e0b1d280c..e5037535a824 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -2791,6 +2791,46 @@ void WW8TabDesc::MoveOutsideTable()
 *m_pIo->m_pPaM->GetPoint() = *m_xTmpPos->GetPoint();
 }
 
+namespace
+{
+class SwTableNodeListener final : public SwClient
+{
+private:
+SwModify* m_pModify;
+
+virtual void SwClientNotify(const SwModify&, const SfxHint& rHint) 
override
+{
+if (rHint.GetId() != SfxHintId::SwLegacyModify)
+return;
+auto pLegacy = static_cast();
+if (pLegacy->GetWhich() == RES_OBJECTDYING)
+{
+m_pModify->Remove(this);
+m_pModify = nullptr;
+}
+}
+
+public:
+SwTableNodeListener(SwModify* pModify)
+: m_pModify(pModify)
+{
+m_pModify->Add(this);
+}
+
+bool WasDeleted() const
+{
+return !m_pModify;
+}
+
+virtual ~SwTableNodeListener() override
+{
+if (!m_pModify)
+return;
+m_pModify->Remove(this);
+}
+};
+}
+
 void WW8TabDesc::FinishSwTable()
 {
 m_pIo->m_xRedlineStack->closeall(*m_pIo->m_pPaM->GetPoint());
@@ -2800,6 +2840,8 @@ void WW8TabDesc::FinishSwTable()
 std::shared_ptr xLastAnchorCursor(m_pIo->m_pLastAnchorPos ? 
m_pIo->m_rDoc.CreateUnoCursor(*m_pIo->m_pLastAnchorPos) : nullptr);
 m_pIo->m_pLastAnchorPos.reset();
 
+SwTableNode* pTableNode = m_pTable->GetTableNode();
+SwTableNodeListener aListener(pTableNode);
 m_pIo->m_xRedlineStack = std::move(mxOldRedlineStack);
 
 if (xLastAnchorCursor)
@@ -2818,6 +2860,9 @@ void WW8TabDesc::FinishSwTable()
 
 m_pIo->m_aInsertedTables.InsertTable(*m_pTableNd, *m_pIo->m_pPaM);
 
+if (aListener.WasDeleted())
+return;
+
 MergeCells();
 
 // if needed group cells together that should be merged

[Libreoffice-bugs] [Bug 92407] Copying Spreadsheet Areas to Text Documents (help docs)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92407

--- Comment #21 from gmarco  ---
Created attachment 177255
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177255=edit
pdf document (last update)

now in L.O. vers. 7.2.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 92407] Copying Spreadsheet Areas to Text Documents (help docs)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92407

--- Comment #20 from gmarco  ---
Further last update.
Please discard the attachment 177240 
and look at the new (after last test in L.O. vers.7.2.4.1).

Anyway I believe that the document can be a useful compendium as a help for
managing the links between ODS and ODT.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: RepositoryExternal.mk

2022-01-02 Thread Stephan Bergmann (via logerrit)

 RepositoryExternal.mk |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit f6e02294ce8d71a03c8e440e041094d2dd0a9834
Author: Stephan Bergmann 
AuthorDate: Sun Jan 2 20:14:04 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 2 22:29:03 2022 +0100

Replace obsolete *_use_external_project for libjpeg-turbo

...which no longer is an ExternalProject but just a StaticLibrary since
1295f497e0cc7fc7cfcb66182496a4d29aa701b3 "upgrade libjpeg-turbo to 2.1.1".
(This caused e.g. a from-scratch `make Library_pdfium` to fail with

> [PRJ] libjpeg-turbo
> touch: cannot touch '.../workdir/ExternalProject/libjpeg-turbo.done': No 
such file or directory

when workdir/ExternalProject/ happens not to exist yet.)

Change-Id: Id0f0e3b13cc7e9e556d9c8e7698d4dfa1bb01659
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127874
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 709376b80034..e791935b2cda 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -419,7 +419,6 @@ gb_ExternalProject__use_libjpeg :=
 else
 
 define gb_LinkTarget__use_libjpeg
-$(call gb_LinkTarget_use_external_project,$(1),libjpeg-turbo,full)
 $(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,libjpeg-turbo) \
$$(INCLUDE) \
@@ -429,7 +428,7 @@ $(call 
gb_LinkTarget_use_static_libraries,$(1),libjpeg-turbo)
 endef
 
 define gb_ExternalProject__use_libjpeg
-$(call gb_ExternalProject_use_external_project,$(1),libjpeg-turbo)
+$(call gb_ExternalProject_use_static_libraries,$(1),libjpeg-turbo)
 
 endef

[Libreoffice-bugs] [Bug 146530] Writer converts JPG images to PNG

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146530

--- Comment #1 from jsv  ---
Created attachment 177254
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177254=edit
test image

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146530] New: Writer converts JPG images to PNG

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146530

Bug ID: 146530
   Summary: Writer converts JPG images to PNG
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: avtomot...@gmail.com

Description:
Part 1.

1. Create a new Writer document.
2. Click "Insert > Image" and insert the image test2-trade-bill.jpg, which is
244 KB.
3. Save the document, but don't close it.
4. Notice the document size is now 262 KB. Fair enough: 244 KB for the embedded
JPG image and the rest for the document itself.

Part 2.

5. Cut the image from the document by pressing Ctrl+X and then save the
document.
6. Notice the document size is now 9 KB. Fair enough, since the document is now
empty.
7. The most important step: Close the document **and LibreOffice itself**.
8. Open the document again and press Ctrl+V to insert the image you have just
cut. Save the document. Notice the document size is now 2 MB. This is because
Wirter converted the image to PNG for some reason.


Steps to Reproduce:
see above

Actual Results:
see above

Expected Results:
see above


Reproducible: Always


User Profile Reset: No



Additional Info:
see above

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91817] Insertion and link areas of 'spreadsheet' from LO Calc in a LO Writer document.

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91817

--- Comment #20 from gmarco  ---
(In reply to Olivier Hallot from comment #17)
> Actually this long report and bug#138531 recent fix, refers to a property of
> external links, among them DDE.
> 
> Rather than adding Help pages explaining link properties, please have a look
> at the Writer Guide, chapter19:
> 
> https://books.libreoffice.org/en/WG72/WG7219-SpreadsheetsChartsObjects.
> html#toc5

Adjustment:
now in vers. 7.2.4.1 the DDE link works correctly again, but there is still a
minor bug that I will report separately (closing the ODT file by clicking on
"X" the file is closed but not saved, thus losing the updates of the DDE
object).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102210] Cannot use '°' character in subroutine name

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102210

--- Comment #19 from himajin100...@gmail.com ---
https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/ms-vbal/7df907cb-ab6c-40d3-aa81-272742ce00c3

https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/ms-vbal/b1cbd42c-6caa-4510-8f28-b0eebabf1956

https://docs.microsoft.com/en-us/openspecs/microsoft_general_purpose_programming_languages/ms-vbal/f8baa2da-2b5c-4470-ae45-6b66b95665eb

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - 2 commits - configure.ac download.lst external/nss

2022-01-02 Thread Michael Stahl (via logerrit)

 configure.ac |2 
 download.lst |4 
 external/nss/UnpackedTarball_nss.mk  |1 
 external/nss/nss-android.patch.1 |6 
 external/nss/nss-ios.patch   |  216 ++-
 external/nss/nss-restore-manual-pre-dependencies.patch.1 |4 
 external/nss/nss.getopt.patch.0  |   25 -
 external/nss/nss_macosx.patch|   14 
 8 files changed, 210 insertions(+), 62 deletions(-)

New commits:
commit df733806129c54ff25ca8dbf4cc26d51107bee7a
Author: Michael Stahl 
AuthorDate: Tue Oct 19 15:17:39 2021 +0200
Commit: Andras Timar 
CommitDate: Sun Jan 2 21:19:33 2022 +0100

nss: upgrade to release 3.73

Fixes:
CVE-2021-43527 Memory corruption via DER-encoded DSA and RSA-PSS signatures

Includes: nss: upgrade to release 3.71

* external/nss/nss.getopt.patch.0: fixed upstream
* external/nss/nss-win-arm64.patch: fixed upstream
* external/nss/nss_macosx.patch: one hunk was fixed upstream

Conflicts:
 download.lst

Change-Id: I5c3f169c57fc2763029b07ad7e325b2f53b7e28f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126218
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit c8e21d246bcb4289cb25c82be440cd07b7418436)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126252
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index 42c3ad26bfa0..f6a0836c8128 100644
--- a/download.lst
+++ b/download.lst
@@ -191,8 +191,8 @@ export MYTHES_SHA256SUM := 
1e81f395d8c851c3e4e75b568e20fa2fa549354e75ab397f9de4b
 export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 export NEON_SHA256SUM := 
db0bd8cdec329b48f53a6f00199c92d5ba40b0f015b153718d1b15d3d967fbca
 export NEON_TARBALL := neon-0.30.2.tar.gz
-export NSS_SHA256SUM := 
ec6032d78663c6ef90b4b83eb552dedf721d2bce208cec3bf527b8f637db7e45
-export NSS_TARBALL := nss-3.55-with-nspr-4.27.tar.gz
+export NSS_SHA256SUM := 
07a9e5b70f121a62706140d4cacc3006d3efb869da40f3a2bf7a65d37847f4d9
+export NSS_TARBALL := nss-3.73-with-nspr-4.32.tar.gz
 export ODFGEN_SHA256SUM := 
2c7b21892f84a4c67546f84611eccdad6259875c971e98ddb027da66ea0ac9c2
 export ODFGEN_VERSION_MICRO := 6
 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.bz2
diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index dab244c867b8..4f8499e8a835 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -27,7 +27,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\
external/nss/nss-bz1646594.patch.1 \
 external/nss/macos-dlopen.patch.0 \
 external/nss/nss-restore-manual-pre-dependencies.patch.1 \
-   external/nss/nss.getopt.patch.0 \
 $(if $(filter iOS,$(OS)), \
 external/nss/nss-ios.patch) \
 $(if $(filter ANDROID,$(OS)), \
diff --git a/external/nss/nss-android.patch.1 b/external/nss/nss-android.patch.1
index b77663c59eb3..7fb10ae522c7 100644
--- a/external/nss/nss-android.patch.1
+++ b/external/nss/nss-android.patch.1
@@ -10,9 +10,9 @@ diff -ur nss.org/nspr/build/autoconf/config.sub 
nss/nspr/build/autoconf/config.s
 +if test $1 = "i686-pc-linux-android"; then echo $1; exit; fi
 +if test $1 = "x86_64-pc-linux-android"; then echo $1; exit; fi
 +
- # Separate what the user gave into CPU-COMPANY and OS or KERNEL-OS (if any).
- # Here we must recognize all the valid KERNEL-OS combinations.
- maybe_os=`echo $1 | sed 's/^\(.*\)-\([^-]*-[^-]*\)$/\2/'`
+ # Split fields of configuration type
+ # shellcheck disable=SC2162
+ IFS="-" read field1 field2 field3 field4 library = (void *)library;
+ 
+@@ -487,6 +487,11 @@
+ mod->moduleDBFunc = (void *)
+ PR_FindSymbol(library, "NSS_ReturnModuleSpecData");
+ }
++#else
++if (strcmp(mod->dllName, "NSSCKBI") == 0)
++fentry = NSSCKBI_C_GetFunctionList;
++#endif
++
+ if (mod->moduleDBFunc == NULL)
+ mod->isModuleDB = PR_FALSE;
+ if ((ientry == NULL) && (fentry == NULL)) {
+@@ -624,10 +624,12 @@
+ }
+ fail:
+ mod->functionList = NULL;
++#ifndef NSS_STATIC_PKCS11
+ disableUnload = PR_GetEnvSecure("NSS_DISABLE_UNLOAD");
+ if (library && !disableUnload) {
+ PR_UnloadLibrary(library);
+ }
++#endif
+ return SECFailure;
+ }
+ 
+--- a/a/nss/lib/ckfw/nssck.api
 a/a/nss/lib/ckfw/nssck.api
+@@ -1842,7 +1842,11 @@
+ 
+ /* This one is always present */
+ CK_RV CK_ENTRY
++#ifndef NSS_STATIC_PKCS11
+ C_GetFunctionList
++#else
++NSSCKBI_C_GetFunctionList
++#endif
+ (
+   CK_FUNCTION_LIST_PTR_PTR ppFunctionList
+ )
+--- a/a/nss/lib/freebl/loader.c
 a/a/nss/lib/freebl/loader.c
+@@ -35,6 +35,7 @@
+ static PRStatus
+ freebl_LoadDSO(void)
+

[Libreoffice-bugs] [Bug 105220] Firebird: Insert with direct SQL - RETURNING without values

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105220

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #11 from Julien Nabet  ---
Just for the record because I'm not sure it could help here, I found a 2 steps
way to do this:
1) Retrieve the generator name

SELECT relfields.RDB$generator_name
FROM RDB$RELATION_FIELDS relfields
JOIN RDB$FIELDS fields
on (fields.RDB$FIELD_NAME = relfields.RDB$FIELD_SOURCE)
WHERE (1 = 1)
AND relfields.RDB$RELATION_NAME = ''

2) Use specific Firebird function
SELECT GEN_ID( "", 0 ) FROM RDB$DATABASE;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144890] Invalid selection area when text in LTR run is selected within an RTL paragraph

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144890

--- Comment #14 from William Friedman  ---
Created attachment 177253
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177253=edit
LTR-RTL Bug Behavior Discrepancy

Eyal's comment is a precise and simpler demonstration of the problem.

Please also note that the same thing happens with RTL text in LTR mode, but the
selection problem appears slightly differently. When I followed Eyal's
directions, selecting the "ll" of "hello" in LTR mode and set it to RTL mode,
the entire text and more is erroneously selected. However, when I type שלום in
RTL mode, select the letters לו and then set it to LTR mode, the ש is
(correctly) outside the erroneously large selection box. I assume the same fix
will apply, but I figured it was worth noting the discrepancy in erroneous
behavior here. The attached video demonstrates the difference between the bug's
behavior with LTR text in RTL mode and RTL text in LTR mode, also comparing it
with the correct behavior in LO 7.1.5.2 for both.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146529] External document loading lookup fails if optimal height calculation is enabled on cell with reference

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146529

--- Comment #3 from Peter Rozsa  ---
Created attachment 177252
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177252=edit
Example file to reproduce the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146529] External document loading lookup fails if optimal height calculation is enabled on cell with reference

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146529

--- Comment #2 from Peter Rozsa  ---
Created attachment 177251
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177251=edit
Workaround

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146529] External document loading lookup fails if optimal height calculation is enabled on cell with reference

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146529

--- Comment #1 from Peter Rozsa  ---
Created attachment 177250
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177250=edit
Base file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146529] New: External document loading lookup fails if optimal height calculation is enabled on cell with reference

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146529

Bug ID: 146529
   Summary: External document loading lookup fails if optimal
height calculation is enabled on cell with reference
   Product: LibreOffice
   Version: 6.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rozsa.pete...@gmail.com

Description:
After opening a Calc document with a reference in it to another document, the
lookup for the referenced file fails with this warning message:
"The following external file could not be loaded. Data linked from this file
did not get updated.

file:///C:/Users/prozsa/Documents/base.ods"

Calculations are fine after closing the warning dialog.

I managed to work around the issue, it seems that optimal row height styling
triggers too early cell value evaluation on the open document, and the
referenced document's path lookup fails.
The mentioned code part checks if there's any cell range that has to be
evaluated, and then calls an update on those ranges, thus the cells with the
INDIRECT reference to the other file get evaluated, and the referenced document
gets loaded:
https://github.com/LibreOffice/core/blob/4e2c4bd9228bd0cf973f13dbe4410a2391d06ab8/sc/source/filter/xml/xmlimprt.cxx#L1424

If I turn off every "style:use-optimal-row-height" in the base documents
content.xml then the issue resolves.

See attached files; base.ods is the referenced file, good.ods shows the good
behaviour with optimal row height turned off, bad.ods shows the problematic
loading.

Steps to Reproduce:
1.Create an indirect reference to another Calc doc like =INDIRECT(A1) where A1
contains a reference like this: 'base.ods'#Sheet1.A1:B10
2.Save and close the document
3.Reopen it

Actual Results:
Warning dialog with this message: The following external file could not be
loaded. Data linked from this file did not get updated.

file:///C:/Users/prozsa/Documents/base.ods

Expected Results:
No warning dialog


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Verzió: 6.4.7.2 (x64)
Build az.: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU szálak: 4; OS: Windows 10.0 Build 19043; Felületmegjelenítés:
alapértelmezett; VCL: win; 
Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/freetype

2022-01-02 Thread Stephan Bergmann (via logerrit)

 external/freetype/ExternalProject_freetype.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4e7f3692c9eb42a00797025289782baa69a42cc7
Author: Stephan Bergmann 
AuthorDate: Sun Jan 2 12:31:14 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Jan 2 20:29:14 2022 +0100

Make external/freetype use -fPIC

...to prevent Library_pdfium from failing to link with

> ld.lld: error: relocation R_X86_64_64 cannot be used against local 
symbol; recompile with -fPIC
> >>> defined in 
workdir/UnpackedTarball/freetype/instdir/lib/libfreetype.a(ftinit.o)
> >>> referenced by ftinit.c:89 (src/base/ftinit.c:89)
> >>>   ftinit.o:(FT_Add_Default_Modules) in archive 
workdir/UnpackedTarball/freetype/instdir/lib/libfreetype.a

etc., presumably since 8677e994d37329a28ca8278358a99d18b9cada69 "Simplify
FONTCONFIG and FREETYPE tests" no longer implicitly forces use of system
freetype on Linux

Change-Id: I2743619768e2dd636ec431408fcb2871871504f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127864
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/freetype/ExternalProject_freetype.mk 
b/external/freetype/ExternalProject_freetype.mk
index 032e0362917a..a3e0a7ca3e4b 100644
--- a/external/freetype/ExternalProject_freetype.mk
+++ b/external/freetype/ExternalProject_freetype.mk
@@ -18,6 +18,7 @@ $(call gb_ExternalProject_get_state_target,freetype,build) :
$(call gb_ExternalProject_run,build,\
$(gb_RUN_CONFIGURE) ./configure \
--disable-shared \
+   --with-pic \
--without-zlib \
--without-brotli \
--without-bzip2 \

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #23 from Julien Nabet  ---
(In reply to Robert Großkopf from comment #22)
> ...
> There has to be a firebird.fbk and a firebird.fdb in the same folder. The
> *.fbk is the file created by a backup, which is also the saved file inside
> the *.odb-file.

Sorry, I forgot to tell it contained only firebird.fbk file, no other file
(standard or hidden).

To be even more precise, here's what I got in /tmp/luln2iz.tmp
./luln2ix.tmp
./luln2ix.tmp/luln2iz.tmp
./luln2ix.tmp/luln2iz.tmp/fb_init
./luln2ix.tmp/luln2iy.tmp
./luln2ix.tmp/luln2j1.tmp
./luln2ix.tmp/luln2j1.tmp/firebird.fbk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102210] Cannot use '°' character in subroutine name

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102210

Aron Budea  changed:

   What|Removed |Added

 Blocks||108908


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108908
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108908

Aron Budea  changed:

   What|Removed |Added

 Depends on||102210


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102210
[Bug 102210] Cannot use '°' character in subroutine name
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102210] Cannot use '°' character in subroutine name

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102210

--- Comment #18 from Aron Budea  ---
When it comes to interoperability, what is allowed in MSO should be allowed
either in compatibility mode (if that's possible), or converted to make a valid
name in LO.

In VBA subroutine names follow variable naming conventions, which are:
"Variable names must begin with an alphabetic character, must be unique within
the same scope, can't be longer than 255 characters, and can't contain an
embedded period or type-declaration character."
https://docs.microsoft.com/en-us/office/vba/language/glossary/vbe-glossary#variable
The characters:
https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/language-features/data-types/type-characters
https://docs.microsoft.com/en-us/office/vba/language/concepts/getting-started/visual-basic-naming-rules

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #22 from Robert Großkopf  ---
(In reply to Julien Nabet from comment #21)
> (In reply to Robert Großkopf from comment #20)
> > (In reply to Julien Nabet from comment #19)
> > > "/tmp/luiv08z.tmp/luiv092.tmp/firebird.fdb"
> > > *Error while trying to open file
> > > *No such file or directory
> > 
> > Did you have a look at this folder? Could be the file isn't unpacked right
> > form LO.
> 
> Yes it contains firebird.fbk

There has to be a firebird.fbk and a firebird.fdb in the same folder. The *.fbk
is the file created by a backup, which is also the saved file inside the
*.odb-file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144890] Invalid selection area when text in LTR run is selected within an RTL paragraph

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144890

Dieter  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144890] Invalid selection area when text in LTR run is selected within an RTL paragraph

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144890

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Ivalid selection area when  |Invalid selection area when
   |text in LTR run is selected |text in LTR run is selected
   |within an RTL paragraph |within an RTL paragraph

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144890] Ivalid selection area when text in LTR run is selected within an RTL paragraph

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144890

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Wrong amount of selected|Ivalid selection area when
   |text is highlighted in  |text in LTR run is selected
   |mixed LTR/RTL text  |within an RTL paragraph

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112812] [META] Hebrew language-specific RTL issues

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112812

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on|144890  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144890
[Bug 144890] Wrong amount of selected text is highlighted in mixed LTR/RTL text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=43808

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||144890


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144890
[Bug 144890] Wrong amount of selected text is highlighted in mixed LTR/RTL text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144890] Wrong amount of selected text is highlighted in mixed LTR/RTL text

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144890

Eyal Rozenberg  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 Blocks|112812  |43808

--- Comment #13 from Eyal Rozenberg  ---
I can reproduce this using:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d

but not using the 7.0.4.2 release.

Exact reproduction instructions:

1. Create a new LO Writer document.
2. Type: "hello".
3. Set the paragraph direction to LTR.
4. Select the "ll" in "hello"; you may use either the mouse or keyboard for the
selection.
5. Set the paragraph direction to RTL

Expected result: The selection should be a rectangle covering just the ll and a
bit of surrounding space - and stay that way as the direction changes.

Actual results: In step 5, the selection area becomes much larger, covering the
entire word hello, all of the empty space to the left edge of the page, and a
bunch of empty space below the paragraph.

You can de-select and try to re-select the "ll" - same effect. If there's run
of RTL text earlier on the line, it doesn't get selected (as in OP's
description).

Indeed, this is a regression. Not sure about the relationship with bug 146154


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=112812
[Bug 112812] [META] Hebrew language-specific RTL issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #21 from Julien Nabet  ---
(In reply to Robert Großkopf from comment #20)
> (In reply to Julien Nabet from comment #19)
> > "/tmp/luiv08z.tmp/luiv092.tmp/firebird.fdb"
> > *Error while trying to open file
> > *No such file or directory
> 
> Did you have a look at this folder? Could be the file isn't unpacked right
> form LO.

Yes it contains firebird.fbk
but if I use:
const OString sFirebirdURL2 = OUStringToOString(m_sFBKPath,
RTL_TEXTENCODING_UTF8);
and use for isc_attach_database, I got:
warn:connectivity.firebird:226371:226371:connectivity/source/drivers/firebird/Util.cxx:57:
firebird_sdbc error:
*file /tmp/luln2ix.tmp/luln2j0.tmp/firebird.fbk is not a valid database
caused by
'isc_attach_database'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang sd/source ucb/source

2022-01-02 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   64 +---
 compilerplugins/clang/unusedfields.readonly.results |   52 +--
 compilerplugins/clang/unusedfields.untouched.results|   24 -
 compilerplugins/clang/unusedfields.writeonly.results|  158 
+-
 sd/source/ui/slideshow/slideshowviewimpl.cxx|3 
 sd/source/ui/slideshow/slideshowviewimpl.hxx|1 
 ucb/source/ucp/webdav-curl/SerfLockStore.cxx|2 
 ucb/source/ucp/webdav-curl/SerfLockStore.hxx|1 
 8 files changed, 144 insertions(+), 161 deletions(-)

New commits:
commit 4e2c4bd9228bd0cf973f13dbe4410a2391d06ab8
Author: Noel Grandin 
AuthorDate: Sun Jan 2 13:43:42 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 19:36:59 2022 +0100

loplugin:unusedfields

Change-Id: I20a387563a0f65bc9a7149ab0b08b09f1946e9ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127867
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git 
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results 
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index fe31cf8ab846..b13175960288 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -42,18 +42,18 @@ connectivity/source/drivers/evoab2/EApi.h:121
 (anonymous) address_format char *
 connectivity/source/drivers/evoab2/EApi.h:125
 (anonymous) ext char *
-connectivity/source/drivers/evoab2/NStatement.hxx:54
-connectivity::evoab::FieldSort bAscending _Bool
-connectivity/source/drivers/firebird/Driver.hxx:46
+connectivity/source/drivers/firebird/Driver.hxx:48
 connectivity::firebird::FirebirdDriver m_firebirdTMPDirectory 
::utl::TempFile
-connectivity/source/drivers/firebird/Driver.hxx:47
+connectivity/source/drivers/firebird/Driver.hxx:49
 connectivity::firebird::FirebirdDriver m_firebirdLockDirectory 
::utl::TempFile
+connectivity/source/drivers/postgresql/pq_statics.hxx:104
+pq_sdbc_driver::ImplementationStatics types 
css::uno::Sequence
 connectivity/source/inc/component/CResultSet.hxx:41
 connectivity::component::OComponentResultSet m_bBookmarkable _Bool
 connectivity/source/inc/dbase/DResultSet.hxx:40
 connectivity::dbase::ODbaseResultSet m_bBookmarkable _Bool
 connectivity/source/inc/file/FStatement.hxx:84
-connectivity::file::OStatement_Base m_aCursorName class rtl::OUString
+connectivity::file::OStatement_Base m_aCursorName rtl::OUString
 connectivity/source/inc/file/FStatement.hxx:85
 connectivity::file::OStatement_Base m_nMaxFieldSize sal_Int32
 connectivity/source/inc/file/FStatement.hxx:86
@@ -124,12 +124,12 @@ cppu/source/uno/check.cxx:258
 (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
 cui/source/dialogs/colorpicker.cxx:740
 cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious class 
cui::(anonymous namespace)::ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1207
+cui/source/factory/dlgfact.cxx:1208
 (anonymous namespace)::SvxMacroAssignDialog_Impl m_aItems class SfxItemSet
 cui/source/inc/AdditionsDialog.hxx:47
-AdditionInfo sReleaseVersion class rtl::OUString
+AdditionInfo sReleaseVersion rtl::OUString
 cui/source/inc/AdditionsDialog.hxx:84
-AdditionsDialog m_sTag class rtl::OUString
+AdditionsDialog m_sTag rtl::OUString
 cui/source/inc/cfgutil.hxx:241
 SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl
 cui/source/inc/cuitabarea.hxx:223
@@ -147,7 +147,7 @@ cui/source/inc/tabstpge.hxx:87
 cui/source/options/optcolor.cxx:237
 (anonymous namespace)::ColorConfigWindow_Impl::Entry m_aDefaultColor class 
Color
 dbaccess/source/core/api/RowSet.hxx:108
-dbaccess::ORowSet m_aURL class rtl::OUString
+dbaccess::ORowSet m_aURL rtl::OUString
 dbaccess/source/core/api/RowSet.hxx:123
 dbaccess::ORowSet m_nMaxFieldSize sal_Int32
 dbaccess/source/core/api/RowSet.hxx:125
@@ -417,7 +417,7 @@ lotuswordpro/source/filter/clone.hxx:23
 oox/source/drawingml/diagram/layoutnodecontext.cxx:93
 oox::drawingml::(anonymous namespace)::AlgorithmContext mnRevision 
sal_Int32
 oox/source/drawingml/diagram/layoutnodecontext.cxx:135
-oox::drawingml::(anonymous namespace)::ChooseContext msName class 
rtl::OUString
+oox::drawingml::(anonymous namespace)::ChooseContext msName rtl::OUString
 oox/source/ppt/timenodelistcontext.cxx:205
 oox::ppt::(anonymous namespace)::MediaNodeContext mbFullScrn _Bool
 oox/source/ppt/timenodelistcontext.cxx:400
@@ -431,7 +431,7 @@ oox/source/ppt/timenodelistcontext.cxx:639
 oox/source/ppt/timenodelistcontext.cxx:721
 oox::ppt::(anonymous namespace)::AnimScaleContext mbZoomContents _Bool
 oox/source/ppt/timenodelistcontext.cxx:861
-oox::ppt::(anonymous namespace)::AnimMotionContext msPtsTypes class

[Libreoffice-commits] core.git: compilerplugins/clang include/drawinglayer include/svtools

2022-01-02 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/unnecessaryvirtual-dead.results |2 -
 compilerplugins/clang/unnecessaryvirtual.results  |   24 +-
 include/drawinglayer/primitive2d/baseprimitive2d.hxx  |4 +--
 include/svtools/acceleratorexecute.hxx|2 -
 4 files changed, 17 insertions(+), 15 deletions(-)

New commits:
commit e327bccf14130eb469f06c96721b9d8aea5dd506
Author: Noel Grandin 
AuthorDate: Sun Jan 2 13:37:04 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 19:36:19 2022 +0100

loplugin:unnecessaryvirtual

Change-Id: Ia7d68c07d44aaa9ce44fe4e7ed72987e96433269
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127866
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results 
b/compilerplugins/clang/unnecessaryvirtual-dead.results
index 5d14653d6cdb..b09f822608b3 100644
--- a/compilerplugins/clang/unnecessaryvirtual-dead.results
+++ b/compilerplugins/clang/unnecessaryvirtual-dead.results
@@ -6,7 +6,7 @@ canvas/inc/base/graphicdevicebase.hxx:305
 void canvas::GraphicDeviceBase::removePropertyChangeListener(const class 
rtl::OUString &,const class com::sun::star::uno::Reference &,)
 canvas/inc/base/graphicdevicebase.hxx:318
 void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class 
rtl::OUString &,const class com::sun::star::uno::Reference &,)
-include/basegfx/utils/unopolypolygon.hxx:94
+include/basegfx/utils/unopolypolygon.hxx:92
 void basegfx::unotools::UnoPolyPolygon::modifying()const
 sc/source/core/opencl/formulagroupcl.cxx:1070
 void sc::opencl::(anonymous 
namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class 
std::basic_stringstream &,)
diff --git a/compilerplugins/clang/unnecessaryvirtual.results 
b/compilerplugins/clang/unnecessaryvirtual.results
index 8287b882fbf5..3d939a4764c4 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -248,7 +248,7 @@ forms/source/xforms/namedcollection.hxx:100
 class com::sun::star::uno::Sequence 
NamedCollection::getElementNames()
 forms/source/xforms/namedcollection.hxx:105
 unsigned char NamedCollection::hasByName(const class rtl::OUString &,)
-include/basegfx/utils/unopolypolygon.hxx:94
+include/basegfx/utils/unopolypolygon.hxx:92
 void basegfx::unotools::UnoPolyPolygon::modifying()const
 include/comphelper/interaction.hxx:53
 void comphelper::OInteraction::select()
@@ -260,6 +260,10 @@ include/comphelper/unique_disposing_ptr.hxx:169
 void 
comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,)
 include/comphelper/weakeventlistener.hxx:120
 void comphelper::OWeakListenerAdapter::disposing(const struct 
com::sun::star::lang::EventObject &,)
+include/drawinglayer/primitive2d/baseprimitive2d.hxx:156
+class drawinglayer::primitive2d::Primitive2DContainer 
drawinglayer::primitive2d::BasePrimitive2D::getDecomposition(const class 
com::sun::star::uno::Sequence &,)
+include/drawinglayer/primitive2d/baseprimitive2d.hxx:162
+struct com::sun::star::geometry::RealRectangle2D 
drawinglayer::primitive2d::BasePrimitive2D::getRange(const class 
com::sun::star::uno::Sequence &,)
 include/svl/svdde.hxx:236
 class DdeData * DdeTopic::Get(enum SotClipboardFormatId,)
 include/svl/svdde.hxx:237
@@ -272,8 +276,8 @@ include/svl/svdde.hxx:243
 _Bool DdeTopic::StartAdviseLoop()
 include/svl/svdde.hxx:300
 void DdeService::~DdeService()
-include/svx/svdundo.hxx:753
-class std::unique_ptr 
SdrUndoFactory::CreateUndoSort(class SdrPage &,const class std::vector &,)
+include/svtools/acceleratorexecute.hxx:115
+void svt::AcceleratorExecute::~AcceleratorExecute()
 include/vbahelper/vbacollectionimpl.hxx:289
 int ScVbaCollectionBase::getCount()
 include/vbahelper/vbacollectionimpl.hxx:294
@@ -300,8 +304,6 @@ include/vcl/customweld.hxx:45
 class rtl::OUString weld::CustomWidgetController::GetHelpText()const
 include/vcl/weld.hxx:104
 void weld::Widget::set_visible(_Bool,)
-jvmfwk/inc/vendorbase.hxx:157
-_Bool jfw_plugin::VendorBase::initialize(const class std::vector > &,)
 sc/source/core/opencl/formulagroupcl.cxx:1062
 _Bool sc::opencl::(anonymous 
namespace)::DynamicKernelSlidingArgument::NeedParallelReduction()const
 sc/source/core/opencl/formulagroupcl.cxx:1070
@@ -402,8 +404,6 @@ sw/inc/flypos.hxx:37
 void SwPosFlyFrame::~SwPosFlyFrame()
 toolkit/inc/controls/geometrycontrolmodel.hxx:185
 void OGeometryControlModel::fillProperties(class 
com::sun::star::uno::Sequence &,class 
com::sun::star::uno::Sequence &,)const
-ucb/source/ucp/webdav-curl/DAVTypes.hxx:96
-void http_dav_ucp::DAVOptions::~DAVOptions()
 vcl/inc/jsdialog/jsdialogbuilder.hxx:151
 void JSDialogSender::sendFullUpdate(_Bool,)
 vcl/inc/jsdialog/jsdialogbuilder.hxx:154
@@ -424,6 +424,8 @@ vcl/inc/jsdialog/jsdialogbuilder.hxx:382
 void JSWidget::freeze()

[Libreoffice-commits] core.git: svx/source

2022-01-02 Thread Noel Grandin (via logerrit)

 svx/source/form/fmscriptingenv.cxx |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit a5dbd92d06025e5bbaeb95d49be50f6c32971e5f
Author: Noel Grandin 
AuthorDate: Tue Dec 21 16:50:15 2021 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 19:35:49 2022 +0100

osl::Mutex->std::mutex in FormScriptListener

Change-Id: Ic5a1a9f84374ec41685ee32a69cf7fe43e215d5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127831
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/form/fmscriptingenv.cxx 
b/svx/source/form/fmscriptingenv.cxx
index cdff131df959..31de563042cd 100644
--- a/svx/source/form/fmscriptingenv.cxx
+++ b/svx/source/form/fmscriptingenv.cxx
@@ -33,7 +33,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -73,7 +73,7 @@ namespace svxform
 class FormScriptListener:public FormScriptListener_Base
 {
 private:
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 FormScriptingEnvironment *m_pScriptExecutor;
 
 public:
@@ -123,7 +123,7 @@ namespace svxform
 @precond
 m_pScriptExecutor is not .
 */
-voidimpl_doFireScriptEvent_nothrow( ::osl::ClearableMutexGuard& 
_rGuard, const ScriptEvent& _rEvent, Any* _pSynchronousResult );
+voidimpl_doFireScriptEvent_nothrow( std::unique_lock& 
_rGuard, const ScriptEvent& _rEvent, Any* _pSynchronousResult );
 
 private:
 DECL_LINK( OnAsyncScriptEvent, void*, void );
@@ -676,11 +676,11 @@ namespace svxform
 }
 
 
-void FormScriptListener::impl_doFireScriptEvent_nothrow( 
::osl::ClearableMutexGuard& _rGuard, const ScriptEvent& _rEvent, Any* 
_pSynchronousResult )
+void FormScriptListener::impl_doFireScriptEvent_nothrow( 
std::unique_lock& _rGuard, const ScriptEvent& _rEvent, Any* 
_pSynchronousResult )
 {
 OSL_PRECOND( m_pScriptExecutor, 
"FormScriptListener::impl_doFireScriptEvent_nothrow: this will crash!" );
 
-_rGuard.clear();
+_rGuard.unlock();
 m_pScriptExecutor->doFireScriptEvent( _rEvent, _pSynchronousResult );
 }
 
@@ -690,7 +690,7 @@ namespace svxform
 if ( _rEvent.ScriptType == "VBAInterop" )
return; // not handled here
 
-::osl::ClearableMutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
 
 if ( impl_isDisposed_nothrow() )
 return;
@@ -710,7 +710,7 @@ namespace svxform
 {
 Any aResult;
 
-::osl::ClearableMutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
 if ( !impl_isDisposed_nothrow() )
 impl_doFireScriptEvent_nothrow( aGuard, _rEvent,  );
 
@@ -726,7 +726,7 @@ namespace svxform
 
 void FormScriptListener::dispose()
 {
-::osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
 m_pScriptExecutor = nullptr;
 }
 
@@ -738,7 +738,7 @@ namespace svxform
 return;
 
 {
-::osl::ClearableMutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
 
 if ( !impl_isDisposed_nothrow() )
 impl_doFireScriptEvent_nothrow( aGuard, *_pEvent, nullptr );

[Libreoffice-bugs] [Bug 86206] Exporting to SVG breaks dashed lines

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86206

daviding  changed:

   What|Removed |Added

 CC||divirt...@coevolving.com

--- Comment #19 from daviding  ---
Seems similar to ...
Bug 146527 - SVG: Ellipse dotted line in ODG exports to SVG as solid 
... at https://bugs.documentfoundation.org/show_bug.cgi?id=146527 .

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146527] SVG: Ellipse dotted line in ODG exports to SVG as solid

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146527

--- Comment #4 from daviding  ---
Possible duplicate of ...
Bug 86206 - Exporting to SVG breaks dashed lines 
.. at https://bugs.documentfoundation.org/show_bug.cgi?id=86206

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146528] not recognizing scroll from logitech trackball marble (T-BC21) viewing

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146528

--- Comment #1 from Rich Little  ---
Created attachment 177249
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177249=edit
libre info

problem on other computer, so info in jpg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146528] New: not recognizing scroll from logitech trackball marble (T-BC21) viewing

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146528

Bug ID: 146528
   Summary: not recognizing scroll from logitech trackball marble
(T-BC21) viewing
   Product: LibreOffice
   Version: 7.2.4.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: richllit...@logsol.com

Description:
in a doc, pdf or spreadsheet, but does in open.
on windows 10, latest libreoffice.
scroll works in file explorer, etc.

Steps to Reproduce:
1.Open rtf or doc in writer
2.click universal scroll button on trackball
3.attempt to scroll

Actual Results:
does nothing

Expected Results:
scroll up/down in text


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
also happens in calc, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #20 from Robert Großkopf  ---
(In reply to Julien Nabet from comment #19)
> "/tmp/luiv08z.tmp/luiv092.tmp/firebird.fdb"
> *Error while trying to open file
> *No such file or directory

Did you have a look at this folder? Could be the file isn't unpacked right form
LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133769] FIREBIRD: Filed length for VARCHAR couldn't be set to 10000

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133769

Robert Großkopf  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #7 from Robert Großkopf  ---
(In reply to Julien Nabet from comment #6)
> 
> Of course, there's still the migration pb. Now do you really have a VARCHAR
> column in HSQLDB containing so much characters? I thought it would be a
> LONGVARCHAR which seems to be mapped as a BLOB.

No, it is a varchar-field. Created this in a table for collecting all goods and
prices for bills. But it will also work with 8000 characters … Has only been an
example. 8000 characters will be enough to fill a bill with up to 3 pages. And
a CLOB field will do the rest.

Better UTF8 and CHAR_LENGTH will work the right way.

I will close this bug as worksforme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146527] SVG: Ellipse dotted line in ODG exports to SVG as solid

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146527

--- Comment #3 from daviding  ---
Created attachment 177248
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177248=edit
Draw image of ellipse with dotted line, exported as PDF shows dotted line

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146527] SVG: Ellipse dotted line in ODG exports to SVG as solid

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146527

--- Comment #2 from daviding  ---
Created attachment 177247
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177247=edit
Draw image of ellipse with dotted line, exported as PNG shows dotted line

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146527] SVG: Ellipse dotted line in ODG exports to SVG as solid

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146527

--- Comment #1 from daviding  ---
Created attachment 177246
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177246=edit
Draw image of ellipse with dotted line, exported as SVG shows solid line

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146527] New: SVG: Ellipse dotted line in ODG exports to SVG as solid

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146527

Bug ID: 146527
   Summary: SVG: Ellipse dotted line in ODG exports to SVG as
solid
   Product: LibreOffice
   Version: 7.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: divirt...@coevolving.com

Created attachment 177245
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177245=edit
Source file in Draw, an ellipse draw with a dotted line

An ellipse drawn with a dash or dotted line in Draw shows up as a solid line
when exported to SVG.  

The dotted line appears as expected in exports to PNG and PDF.  

Sample attachments included.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #19 from Julien Nabet  ---
(In reply to Lionel Elie Mamane from comment #18)
> ...
> Could you first try to fallback to isc_attach_database when runBackupService
> fails? If that works (along with a pop-up warning?) it at least gives the
> user a chance to fix the issue manually?

I commented the runBackupService in Connection::construct just to test and had
this:
warn:connectivity.firebird:223594:223594:connectivity/source/drivers/firebird/Util.cxx:57:
firebird_sdbc error:
*I/O error during "open" operation for file
"/tmp/luiv08z.tmp/luiv092.tmp/firebird.fdb"
*Error while trying to open file
*No such file or directory
caused by
'isc_attach_database'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: idl/source

2022-01-02 Thread Arnaud VERSINI (via logerrit)

 idl/source/prj/globals.cxx |9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 978acbeb8cb203ae94040d5253031be11d17d15e
Author: Arnaud VERSINI 
AuthorDate: Sun Jan 2 17:10:11 2022 +0100
Commit: Noel Grandin 
CommitDate: Sun Jan 2 18:24:56 2022 +0100

idl : no need to use rtl::Static

Change-Id: I8b53ab93010f500a61aa4930817c25d09cb2552d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127869
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/idl/source/prj/globals.cxx b/idl/source/prj/globals.cxx
index 1540f53e6305..3e8160ac13ef 100644
--- a/idl/source/prj/globals.cxx
+++ b/idl/source/prj/globals.cxx
@@ -23,15 +23,10 @@
 #include 
 #include 
 
-namespace {
-
-struct TheIdlDll: public rtl::Static {};
-
-}
-
 IdlDll & GetIdlApp()
 {
-return TheIdlDll::get();
+static IdlDll aIdlDll;
+return aIdlDll;
 }
 
 IdlDll::IdlDll()

[Libreoffice-commits] core.git: avmedia/source

2022-01-02 Thread Arnaud Versini (via logerrit)

 avmedia/source/gstreamer/gstplayer.cxx|   13 +++--
 avmedia/source/viewer/mediaevent_impl.cxx |   12 ++--
 avmedia/source/viewer/mediaevent_impl.hxx |4 +++-
 3 files changed, 16 insertions(+), 13 deletions(-)

New commits:
commit 477fa6c3cb92f578032dee60482718efdb8f44f2
Author: Arnaud Versini 
AuthorDate: Sun Oct 24 16:49:50 2021 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 18:23:48 2022 +0100

avmedia : use std::mutex instead of osl::Mutex

Change-Id: I0e779db4ef32ac74b9df18d1e162b49236b44b88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124122
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/avmedia/source/gstreamer/gstplayer.cxx 
b/avmedia/source/gstreamer/gstplayer.cxx
index f25ec5c6bb0c..b28be1678207 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -94,7 +95,7 @@ private:
 
 DECL_STATIC_LINK(MissingPluginInstaller, launchUi, void*, void);
 
-osl::Mutex mutex_;
+std::mutex mutex_;
 std::set reported_;
 std::map>> queued_;
 rtl::Reference currentThread_;
@@ -106,7 +107,7 @@ private:
 
 
 MissingPluginInstaller::~MissingPluginInstaller() {
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
 SAL_WARN_IF(currentThread_.is(), "avmedia.gstreamer", "unjoined thread");
 inCleanUp_ = true;
 }
@@ -134,7 +135,7 @@ void MissingPluginInstaller::report(
 rtl::Reference join;
 rtl::Reference launch;
 {
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
 if (reported_.find(detStr) != reported_.end()) {
 return;
 }
@@ -179,7 +180,7 @@ void eraseSource(std::set> & set, 
Player const * source)
 void MissingPluginInstaller::detach(Player const * source) {
 rtl::Reference join;
 {
-osl::MutexGuard g(mutex_);
+std::unique_lock g(mutex_);
 if (inCleanUp_) {
 // Guard against ~MissingPluginInstaller with erroneously un-joined
 // currentThread_ (thus non-empty currentSources_) calling
@@ -251,7 +252,7 @@ void MissingPluginInstallerThread::execute() {
 for (;;) {
 std::vector details;
 {
-osl::MutexGuard g(inst.mutex_);
+std::unique_lock g(inst.mutex_);
 assert(!inst.currentDetails_.empty());
 details.swap(inst.currentDetails_);
 }
@@ -264,7 +265,7 @@ void MissingPluginInstallerThread::execute() {
 args.push_back(nullptr);
 gst_install_plugins_sync(args.data(), nullptr);
 {
-osl::MutexGuard g(inst.mutex_);
+std::unique_lock g(inst.mutex_);
 if (inst.queued_.empty() || inst.launchNewThread_) {
 inst.launchNewThread_ = true;
 break;
diff --git a/avmedia/source/viewer/mediaevent_impl.cxx 
b/avmedia/source/viewer/mediaevent_impl.cxx
index 62217f6d9473..d6a2c082c246 100644
--- a/avmedia/source/viewer/mediaevent_impl.cxx
+++ b/avmedia/source/viewer/mediaevent_impl.cxx
@@ -52,7 +52,7 @@ void SAL_CALL MediaEventListenersImpl::disposing( const 
css::lang::EventObject&
 
 void SAL_CALL MediaEventListenersImpl::keyPressed( const css::awt::KeyEvent& e 
)
 {
-const ::osl::MutexGuard aGuard( maMutex );
+const std::unique_lock aGuard( maMutex );
 
 if( mpNotifyWindow )
 {
@@ -69,7 +69,7 @@ void SAL_CALL MediaEventListenersImpl::keyPressed( const 
css::awt::KeyEvent& e )
 
 void SAL_CALL MediaEventListenersImpl::keyReleased( const css::awt::KeyEvent& 
e )
 {
-const ::osl::MutexGuard aGuard( maMutex );
+const std::unique_lock aGuard( maMutex );
 
 if( mpNotifyWindow )
 {
@@ -85,7 +85,7 @@ void SAL_CALL MediaEventListenersImpl::keyReleased( const 
css::awt::KeyEvent& e
 
 void SAL_CALL MediaEventListenersImpl::mousePressed( const 
css::awt::MouseEvent& e )
 {
-const ::osl::MutexGuard aGuard( maMutex );
+const std::unique_lock aGuard( maMutex );
 
 if( mpNotifyWindow )
 {
@@ -103,7 +103,7 @@ void SAL_CALL MediaEventListenersImpl::mousePressed( const 
css::awt::MouseEvent&
 
 void SAL_CALL MediaEventListenersImpl::mouseReleased( const 
css::awt::MouseEvent& e )
 {
-const ::osl::MutexGuard aGuard( maMutex );
+const std::unique_lock aGuard( maMutex );
 const SolarMutexGuard aAppGuard;
 
 if( mpNotifyWindow )
@@ -132,7 +132,7 @@ void SAL_CALL MediaEventListenersImpl::mouseExited( const 
css::awt::MouseEvent&
 
 void SAL_CALL MediaEventListenersImpl::mouseDragged( const 
css::awt::MouseEvent& e )
 {
-const ::osl::MutexGuard aGuard( maMutex );
+const std::unique_lock aGuard( maMutex );
 
 if( mpNotifyWindow )
 {
@@ -144,7 +144,7 @@ void SAL_CALL MediaEventListenersImpl::mouseDragged( const 
css::awt::MouseEvent&
 
 void SAL_CALL MediaEventListenersImpl::mouseMoved( const css::awt::MouseEvent& 
e )
 {
-const

[Libreoffice-bugs] [Bug 102210] Cannot use '°' character in subroutine name

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102210

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #17 from Andreas Heinisch  ---
It is easy to allow such an additional character, but where do we stop? Should
we allow all combinations of such characters? SubRoutine°°__°°FunctionName
would then be a viable name. 

Imho, hard to decide which characters are allowed and which are not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #18 from Lionel Elie Mamane  ---
(In reply to Robert Großkopf from comment #16)
> We couldn't get back to a buggy behavior to get old created
> databases working. Installing an older version LO will solve this problem.

In principle, I disagree, Ascending compatibility of user data is of cardinal
importance. OTOH, if nobody is going to fix this bug, then WONTFIX is more
honest than letting the bug rot :-(

Maybe "at least" document how to extract the fdb from the odb, fix it and put
it back?

(In reply to Julien Nabet from comment #17)
> Lionel: after Robert's feedback, ok too for WONTFIX here?

Could you first try to fallback to isc_attach_database when runBackupService
fails? If that works (along with a pop-up warning?) it at least gives the user
a chance to fix the issue manually?

I guess the bug is more related to an upgrade of the Firebird version than
LibreOffice code, so the "real fix" would be in Firebird; runBackupService
should accept all data created by a past version of FireBird (!) Maybe we
should open the subject of ascending data compatibility with the Firebird devs?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

--- Comment #17 from Julien Nabet  ---
Lionel: after Robert's feedback, ok too for WONTFIX here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133769] FIREBIRD: Filed length for VARCHAR couldn't be set to 10000

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133769

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
Indeed, utf8 requires 4 bytes max so Firebird can only use 32767 (or rather
32765?) / 4.

By default, databases are created with utf8 but instead of creating a specific
gui to change this, we can also change the database character set at the
beginning, eg:
alter database set default character set ascii;
(seen https://github.com/FirebirdSQL/firebird/issues/5049)

Of course, there's still the migration pb. Now do you really have a VARCHAR
column in HSQLDB containing so much characters? I thought it would be a
LONGVARCHAR which seems to be mapped as a BLOB.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/source/view/charttypes/AreaChart.cxx  |4 +--
 chart2/source/view/charttypes/BarChart.cxx   |9 +++
 chart2/source/view/charttypes/BarChart.hxx   |2 -
 chart2/source/view/charttypes/NetChart.cxx   |2 -
 chart2/source/view/charttypes/PieChart.cxx   |5 +--
 chart2/source/view/charttypes/VSeriesPlotter.cxx |6 ++--
 chart2/source/view/inc/ShapeFactory.hxx  |3 --
 chart2/source/view/main/ShapeFactory.cxx |   29 +++
 8 files changed, 19 insertions(+), 41 deletions(-)

New commits:
commit 5f567b9aec84283546c3084f015d01a70bd76c86
Author: Noel Grandin 
AuthorDate: Sun Jan 2 11:29:35 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 17:58:44 2022 +0100

use more SvxShape in chart2

Change-Id: I53e4f5e68a982bec1fcbcd626f60124ebd0d51b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127861
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/view/charttypes/AreaChart.cxx 
b/chart2/source/view/charttypes/AreaChart.cxx
index 4d06dc41bc27..46c271bc6e7c 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -407,7 +407,7 @@ bool AreaChart::impl_createLine( VDataSeries* pSeries
 pPosHelper->transformScaledLogicToScene( aPoly );
 
 //create line:
-uno::Reference< drawing::XShape > xShape;
+rtl::Reference< SvxShape > xShape;
 if(m_nDimension==3)
 {
 double fDepth = getTransformedDepth();
@@ -501,7 +501,7 @@ bool AreaChart::impl_createArea( VDataSeries* pSeries
 pPosHelper->transformScaledLogicToScene( aPoly );
 
 //create area:
-uno::Reference< drawing::XShape > xShape;
+rtl::Reference< SvxShape > xShape;
 if(m_nDimension==3)
 {
 xShape = ShapeFactory::createArea3D( xSeriesGroupShape_Shapes
diff --git a/chart2/source/view/charttypes/BarChart.cxx 
b/chart2/source/view/charttypes/BarChart.cxx
index f41770fb67dc..f7211e857dd3 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -296,7 +296,7 @@ awt::Point BarChart::getLabelScreenPositionAndAlignment(
 .transformSceneToScreenPosition( aScenePosition3D );
 }
 
-uno::Reference< drawing::XShape > BarChart::createDataPoint3D_Bar(
+rtl::Reference< SvxShape > BarChart::createDataPoint3D_Bar(
   const uno::Reference< drawing::XShapes >& xTarget
 , const drawing::Position3D& rPosition, const drawing::Direction3D& 
rSize
 , double fTopHeight, sal_Int32 nRotateZAngleHundredthDegree
@@ -319,7 +319,7 @@ uno::Reference< drawing::XShape > 
BarChart::createDataPoint3D_Bar(
 TOOLS_WARN_EXCEPTION("chart2", "" );
 }
 
-uno::Reference< drawing::XShape > xShape;
+rtl::Reference< SvxShape > xShape;
 switch( nGeometry3D )
 {
 case DataPointGeometry3D::CYLINDER:
@@ -797,7 +797,7 @@ void BarChart::createShapes()
 //create partial point
 if( !approxEqual(fLowerYValue,fUpperYValue) )
 {
-uno::Reference< drawing::XShape >  xShape;
+rtl::Reference< SvxShape >  xShape;
 if( m_nDimension==3 )
 {
 drawing::Position3D aLogicBottom
(fLogicX,fLogicYStart,fLogicZ);
@@ -862,8 +862,7 @@ void BarChart::createShapes()
 double nPropVal = 
pSeries->getValueByProperty(nPointIndex, "FillColor");
 if(!std::isnan(nPropVal))
 {
-uno::Reference< beans::XPropertySet > 
xProps( xShape, uno::UNO_QUERY_THROW );
-xProps->setPropertyValue("FillColor", 
uno::Any(static_cast(nPropVal)));
+xShape->setPropertyValue("FillColor", 
uno::Any(static_cast(nPropVal)));
 }
 }
 //set name/classified ObjectID (CID)
diff --git a/chart2/source/view/charttypes/BarChart.hxx 
b/chart2/source/view/charttypes/BarChart.hxx
index f5d918e7f74b..5e1ebee666d1 100644
--- a/chart2/source/view/charttypes/BarChart.hxx
+++ b/chart2/source/view/charttypes/BarChart.hxx
@@ -42,7 +42,7 @@ public:
 virtual css::drawing::Direction3D  getPreferredDiagramAspectRatio() const 
override;
 
 private: //methods
-static css::uno::Reference< css::drawing::XShape >
+static rtl::Reference< SvxShape >
 createDataPoint3D_Bar(
   const css::uno::Reference< css::drawing::XShapes >& 
xTarget
 , const css::drawing::Position3D& rPosition
diff --git a/chart2/source/view/charttypes/NetChart.cxx 
b/chart2/source/view/charttypes/NetChart.cxx
index 425898514ac7..aeb1e4018ac2 100644
---

[Libreoffice-commits] core.git: chart2/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/source/view/inc/ShapeFactory.hxx  |2 +-
 chart2/source/view/main/ShapeFactory.cxx |   21 -
 2 files changed, 9 insertions(+), 14 deletions(-)

New commits:
commit 0249e598044b12e7f82cc6e95546687cfbbdfe38
Author: Noel Grandin 
AuthorDate: Sun Jan 2 11:21:01 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 17:58:24 2022 +0100

use more SvxShape in chart2

Change-Id: Ib973fe1eb226ca6a55166ad8f3afeeca766ec8df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127860
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/view/inc/ShapeFactory.hxx 
b/chart2/source/view/inc/ShapeFactory.hxx
index 42468c1dd3e9..c61e6801a5ff 100644
--- a/chart2/source/view/inc/ShapeFactory.hxx
+++ b/chart2/source/view/inc/ShapeFactory.hxx
@@ -241,7 +241,7 @@ public:
 static css::uno::Reference< css::drawing::XShapes >
  getChartRootShape( const rtl::Reference& xPage );
 
-static void makeShapeInvisible( const css::uno::Reference< 
css::drawing::XShape >& xShape );
+static void makeShapeInvisible( const rtl::Reference< SvxShape >& rShape );
 
 static void setShapeName( const css::uno::Reference< css::drawing::XShape 
>& xShape
 , const OUString& rName );
diff --git a/chart2/source/view/main/ShapeFactory.cxx 
b/chart2/source/view/main/ShapeFactory.cxx
index 7fd5249ae4d6..457045a25ac5 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -2335,21 +2335,16 @@ uno::Reference< drawing::XShapes > 
ShapeFactory::getChartRootShape(
 return xRet;
 }
 
-void ShapeFactory::makeShapeInvisible( const uno::Reference< drawing::XShape 
>& xShape )
+void ShapeFactory::makeShapeInvisible( const rtl::Reference< SvxShape >& 
xShape )
 {
-uno::Reference< beans::XPropertySet > xShapeProp( xShape, uno::UNO_QUERY );
-OSL_ENSURE(xShapeProp.is(), "created shape offers no XPropertySet");
-if( xShapeProp.is())
+try
 {
-try
-{
-xShapeProp->setPropertyValue( "LineStyle", uno::Any( 
drawing::LineStyle_NONE ));
-xShapeProp->setPropertyValue( "FillStyle", uno::Any( 
drawing::FillStyle_NONE ));
-}
-catch( const uno::Exception& )
-{
-TOOLS_WARN_EXCEPTION("chart2", "" );
-}
+xShape->setPropertyValue( "LineStyle", uno::Any( 
drawing::LineStyle_NONE ));
+xShape->setPropertyValue( "FillStyle", uno::Any( 
drawing::FillStyle_NONE ));
+}
+catch( const uno::Exception& )
+{
+TOOLS_WARN_EXCEPTION("chart2", "" );
 }
 }

[Libreoffice-commits] core.git: chart2/source

2022-01-02 Thread Noel Grandin (via logerrit)

 chart2/source/view/axes/VAxisBase.cxx  |4 +-
 chart2/source/view/axes/VAxisBase.hxx  |3 -
 chart2/source/view/axes/VCartesianAxis.cxx |   29 -
 chart2/source/view/inc/ShapeFactory.hxx|4 +-
 chart2/source/view/main/ShapeFactory.cxx   |   47 +
 chart2/source/view/main/VTitle.cxx |2 -
 6 files changed, 41 insertions(+), 48 deletions(-)

New commits:
commit 5d33befeeb2452f1cfa0404483c71816fcd88314
Author: Noel Grandin 
AuthorDate: Sun Jan 2 11:18:35 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jan 2 17:58:04 2022 +0100

use more SvxShape in chart2

Change-Id: I95342cfa39be2a058ec6c5d106ece6e60bf85520
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127859
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/view/axes/VAxisBase.cxx 
b/chart2/source/view/axes/VAxisBase.cxx
index cfb73df05e82..a7c186745f56 100644
--- a/chart2/source/view/axes/VAxisBase.cxx
+++ b/chart2/source/view/axes/VAxisBase.cxx
@@ -100,9 +100,9 @@ bool VAxisBase::isComplexCategoryAxis() const
 return m_aAxisProperties.m_bComplexCategories && m_bUseTextLabels;
 }
 
-void VAxisBase::recordMaximumTextSize( const Reference< drawing::XShape >& 
xShape, double fRotationAngleDegree )
+void VAxisBase::recordMaximumTextSize( SvxShape& xShape, double 
fRotationAngleDegree )
 {
-if( m_bRecordMaximumTextSize && xShape.is() )
+if( m_bRecordMaximumTextSize )
 {
 awt::Size aSize( ShapeFactory::getSizeAfterRotation(
 xShape, fRotationAngleDegree ) );
diff --git a/chart2/source/view/axes/VAxisBase.hxx 
b/chart2/source/view/axes/VAxisBase.hxx
index c8a8667770e1..dd7be23e3cc6 100644
--- a/chart2/source/view/axes/VAxisBase.hxx
+++ b/chart2/source/view/axes/VAxisBase.hxx
@@ -65,8 +65,7 @@ protected: //methods
 void updateUnscaledValuesAtTicks( TickIter& rIter );
 
 virtual bool prepareShapeCreation();
-void recordMaximumTextSize( const css::uno::Reference< 
css::drawing::XShape >& xShape
-, double fRotationAngleDegree );
+void recordMaximumTextSize( SvxShape& xShape, double fRotationAngleDegree 
);
 
 bool isDateAxis() const;
 bool isComplexCategoryAxis() const;
diff --git a/chart2/source/view/axes/VCartesianAxis.cxx 
b/chart2/source/view/axes/VCartesianAxis.cxx
index 991b36001253..00020d1f0413 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -73,7 +73,7 @@ VCartesianAxis::~VCartesianAxis()
 m_pPosHelper = nullptr;
 }
 
-static void lcl_ResizeTextShapeToFitAvailableSpace( Reference< drawing::XShape 
> const & xShape2DText,
+static void lcl_ResizeTextShapeToFitAvailableSpace( SvxShape& xShape2DText,
  const AxisLabelProperties& 
rAxisLabelProperties,
  const OUString& rLabel,
  const tNameSequence& rPropNames,
@@ -91,7 +91,7 @@ static void lcl_ResizeTextShapeToFitAvailableSpace( 
Reference< drawing::XShape >
 return;
 
 sal_Int32 nMaxLabelsSize = bIsHorizontalAxis ? 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Height : 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Width;
-const sal_Int32 nAvgCharWidth = xShape2DText->getSize().Width / 
rLabel.getLength();
+const sal_Int32 nAvgCharWidth = xShape2DText.getSize().Width / 
rLabel.getLength();
 const sal_Int32 nTextSize = bIsHorizontalAxis ? 
ShapeFactory::getSizeAfterRotation(xShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Height :
 
ShapeFactory::getSizeAfterRotation(xShape2DText, 
rAxisLabelProperties.fRotationAngleDegree).Width;
 
@@ -144,7 +144,7 @@ static rtl::Reference createSingleLabel(
 ShapeFactory::createText( xTarget, aLabel, rPropNames, 
rPropValues, aATransformation );
 
 if( rAxisProperties.m_bLimitSpaceForLabels )
-lcl_ResizeTextShapeToFitAvailableSpace(xShape2DText, 
rAxisLabelProperties, aLabel, rPropNames, rPropValues, bIsHorizontalAxis);
+lcl_ResizeTextShapeToFitAvailableSpace(*xShape2DText, 
rAxisLabelProperties, aLabel, rPropNames, rPropValues, bIsHorizontalAxis);
 
 LabelPositionHelper::correctPositionForRotation( xShape2DText
 , rAxisProperties.maLabelAlignment.meAlignment, 
rAxisLabelProperties.fRotationAngleDegree, rAxisProperties.m_bComplexCategories 
);
@@ -152,14 +152,11 @@ static rtl::Reference createSingleLabel(
 return xShape2DText;
 }
 
-static bool lcl_doesShapeOverlapWithTickmark( const Reference< drawing::XShape 
>& xShape
+static bool lcl_doesShapeOverlapWithTickmark( SvxShape& rShape
, double fRotationAngleDegree
, const basegfx::B2DVector& rTickScreenPosition )
 {
-if(!xShape.is())
-return false;
-
-::basegfx::B2IRectangle aShapeRect =

[Libreoffice-bugs] [Bug 146526] New: Writer shows a red wiggly line under misspelt word, but does not provide a context menu with spelling options

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146526

Bug ID: 146526
   Summary: Writer shows a red wiggly line under misspelt word,
but does not provide a context menu with spelling
options
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: raindrops.from...@gmail.com

Description:
Writer shows a red wiggly line under a misspelled word, but when I right-click
on the word, nothing happens: There is no context menu with spelling options. 

Steps to Reproduce:
1. Write a word with wrong spelling. A red wiggly line appears under it.
2. Right-click on the word.

Actual Results:
Nothing happens. (No context menu with optional spellings)

Expected Results:
A context menu should pop up with alternative spellings.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows 10 Home, 64 bits

It behaves the same way in Safe mode also.
(I chose the option that disables all extensions and hardware acceleration.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements

2022-01-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143344

Octavio Alvarez  changed:

   What|Removed |Added

 Depends on||138979
 CC||octa...@alvarezp.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138979
[Bug 138979] Dark-colored style previews lack contrast when using Adwaita-dark
theme
-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 >

1 - 100 of 179 matches

Mail list logo