[Libreoffice-bugs] [Bug 147082] Copying Sheet should also copy Range
https://bugs.documentfoundation.org/show_bug.cgi?id=147082 --- Comment #1 from Samuel Mehrbrodt (allotropia) --- PS: After the fix for bug 145054, the range is already copied when copying the sheet. What is missing, is that the formulas are updated to reference the new range. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147082] Copying Sheet should also copy Range
https://bugs.documentfoundation.org/show_bug.cgi?id=147082 Samuel Mehrbrodt (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5054 CC||samuel.mehrbrodt@allotropia ||.de -- You are receiving this mail because: You are the assignee for the bug.
Unable to compile LibreOffice 7.3. Stuck at harfbuzz error messages
Hello all! I have been able to compile LibreOffice for 32-bit since two and a half years ago, so I believe I have a suitable development environment to do that in all these years. However, with LibreOffice version 7.3, compilation halts with this error: [ECH] CustomTarget/instsetoo_native/setup/setuprc fatal: not a git repository (or any of the parent directories): .git [ECH] CustomTarget/instsetoo_native/setup/versionrc fatal: not a git repository (or any of the parent directories): .git [LOC] top level modules: libreoffice /home/linux/Downloads/libreoffice-7.3.0.3/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-graphite2.o): In function `_hb_graphite2_shaper_face_data_create': /home/linux/Downloads/libreoffice-7.3.0.3/workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:132: undefined reference to `gr_make_face_with_ops' /home/linux/Downloads/libreoffice-7.3.0.3/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-graphite2.o): In function `_hb_graphite2_shaper_face_data_destroy': And a lot more error messages related to harfbuzz. Does anybody know what’s going on and how to solve this issue?(Yes, libharfbuzz-dev is installed, as always). Thanks in advance!
[Libreoffice-bugs] [Bug 147082] New: Copying Sheet should also copy Range
https://bugs.documentfoundation.org/show_bug.cgi?id=147082 Bug ID: 147082 Summary: Copying Sheet should also copy Range Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: samuel.mehrbr...@allotropia.de Created attachment 177927 --> https://bugs.documentfoundation.org/attachment.cgi?id=177927=edit bugdoc 1. Open attached spreadsheet. sheet1 has a sum formula which references the "aaa" range. sheet2 has the same sum formula. 2. Copy sheet1 to a new sheet "sheet1_2". Expected: The sum formula on sheet1_2 would copy the "aaa" range so that it references the cells on sheet3. When you change something on sheet1, only the sum formulas on sheet1 and sheet2 are updated. Actual: sheet1_2 still references the "aaa" range. Updating the values on sheet1_2 does not change the sum on sheet1_2. Instead, updating the values on sheet1 updates the sum on all three sheets. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146711] Writer pastes incorrectly when copying from HTML with the tag.
https://bugs.documentfoundation.org/show_bug.cgi?id=146711 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #2 from Dieter --- Would be nice, if you could add links to a webpage I can copy. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - .gitmodules
.gitmodules |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 06d0650d2d9aa101f7907d8e330706640599a162 Author: Christian Lohmaier AuthorDate: Wed Oct 21 21:51:54 2020 +0200 Commit: Michael Weghorn CommitDate: Mon Jan 31 07:56:51 2022 +0100 gitmodules: use relative paths as using https://git.libreoffice.org breaks the submodule subsription (automatic update in core when something is pushed to the submodules), since gerrit compares the URL with gerrit.canonicalWebUrl, the URL where gerrit itself is found, not what is used as default repository URL (cherry picked from commit f7d892aa0b44772ccd70786375d3b6a4515af180) Conflicts: .gitmodules Change-Id: I2e4566e69c7e70c463f0aab393d622a6f4d61808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129194 Tested-by: Juergen Funk Reviewed-by: Juergen Funk Reviewed-by: Michael Weghorn diff --git a/.gitmodules b/.gitmodules index fe2fb7a8117d..c441234d6030 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,12 +1,12 @@ [submodule "dictionaries"] path = dictionaries - url = https://gerrit.libreoffice.org/dictionaries + url = ../dictionaries branch = . [submodule "helpcontent2"] path = helpcontent2 - url = https://gerrit.libreoffice.org/help + url = ../help branch = . [submodule "translations"] path = translations - url = https://gerrit.libreoffice.org/translations + url = ../translations branch = .
[Libreoffice-commits] core.git: sc/source
sc/source/ui/cctrl/checklistmenu.cxx | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
New commits:
commit 709111b40441294a0b48cb71feb7d6cf8b299656
Author: Dennis Francis
AuthorDate: Wed Nov 24 17:44:30 2021 +0530
Commit: Dennis Francis
CommitDate: Mon Jan 31 06:52:43 2022 +0100
lokCalcRTL: fix autofilter popup position
Change-Id: Iecf41c286e28f849f77da47a0c5f73cbbc02986a
(cherry picked from commit be329f241ee4953a039ab4bb22f46a5ac0ad5859)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128904
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 52f53a34838e..290a6468d1d2 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1414,8 +1414,17 @@ void ScCheckListMenuControl::launch(weld::Widget*
pWidget, const tools::Rectangl
if (maConfig.mbRTL)
{
// In RTL mode, the logical "left" is visual "right".
-tools::Long nLeft = aRect.Left() - aRect.GetWidth();
-aRect.SetLeft( nLeft );
+if (!comphelper::LibreOfficeKit::isActive())
+{
+tools::Long nLeft = aRect.Left() - aRect.GetWidth();
+aRect.SetLeft( nLeft );
+}
+else
+{
+// in LOK mode, rRect is in document pixel coordinates, so width
has to be added
+// to place the popup next to the (visual) left aligned button.
+aRect.Move(aRect.GetWidth(), 0);
+}
}
else if (mnWndWidth < aRect.GetWidth())
{
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin2.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit f7b439f5d510a021f5c7cce965d9fb09f9929a44 Author: Dennis Francis AuthorDate: Wed Nov 24 16:59:47 2021 +0530 Commit: Dennis Francis CommitDate: Mon Jan 31 06:52:02 2022 +0100 lokCalcRTL: fix autofilter button hit detection No mirroring needed when not in tile painting mode. All positions are in document coordinates. Conflicts: sc/source/ui/view/gridwin2.cxx Change-Id: I45425e2ddce7f5ddc5086dcdce31bb6d081edc41 (cherry picked from commit 2eb5f597c3b1c5a680d6e0f9d0719f9f6977e1a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128903 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx index a7cd96a649ba..7071bd384f4b 100644 --- a/sc/source/ui/view/gridwin2.cxx +++ b/sc/source/ui/view/gridwin2.cxx @@ -109,8 +109,9 @@ bool ScGridWindow::DoAutoFilterButton( SCCOL nCol, SCROW nRow, const MouseEvent& Point aDiffPix = rMEvt.GetPosPixel(); aDiffPix -= aScrPos; +bool bLOKActive = comphelper::LibreOfficeKit::isActive(); bool bLayoutRTL = rDoc.IsLayoutRTL( nTab ); -if ( bLayoutRTL ) +if ( bLayoutRTL && !bLOKActive ) aDiffPix.setX( -aDiffPix.X() ); tools::Long nSizeX, nSizeY; @@ -121,8 +122,8 @@ bool ScGridWindow::DoAutoFilterButton( SCCOL nCol, SCROW nRow, const MouseEvent& // Check if the mouse cursor is clicking on the popup arrow box. mpFilterButton.reset(new ScDPFieldButton(GetOutDev(), ().GetStyleSettings(), (), )); -mpFilterButton->setBoundingBox(aScrPos, aScrSize, bLayoutRTL); -mpFilterButton->setPopupLeft(bLayoutRTL); // #i114944# AutoFilter button is left-aligned in RTL +mpFilterButton->setBoundingBox(aScrPos, aScrSize, bLayoutRTL && !bLOKActive); +mpFilterButton->setPopupLeft(bLayoutRTL && bLOKActive ? false : bLayoutRTL); // #i114944# AutoFilter button is left-aligned in RTL Point aPopupPos; Size aPopupSize; mpFilterButton->getPopupBoundingBox(aPopupPos, aPopupSize);
[Libreoffice-commits] core.git: sc/source
sc/source/ui/cctrl/dpcontrol.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit ce76f9245d678f4894e2d4148204b994f0032626 Author: Dennis Francis AuthorDate: Wed Nov 24 16:12:32 2021 +0530 Commit: Dennis Francis CommitDate: Mon Jan 31 05:56:48 2022 +0100 lokCalcRTL: Workaround to avoid DrawPoly ghost drawings Conflicts: sc/source/ui/cctrl/dpcontrol.cxx Change-Id: Ib6c794766fe68305566a293892c9123d64a2fc47 (cherry picked from commit 85a986f25956518978381df097b1f7d88477fd3d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128902 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/sc/source/ui/cctrl/dpcontrol.cxx b/sc/source/ui/cctrl/dpcontrol.cxx index f504b6c75089..4c9fbbc6abb3 100644 --- a/sc/source/ui/cctrl/dpcontrol.cxx +++ b/sc/source/ui/cctrl/dpcontrol.cxx @@ -21,6 +21,7 @@ #include #include +#include #include #include #include @@ -190,7 +191,11 @@ void ScDPFieldButton::drawPopupButton() // the arrowhead Color aArrowColor = mbHasHiddenMember ? mpStyle->GetHighlightTextColor() : mpStyle->GetButtonTextColor(); -mpOutDev->SetLineColor(aArrowColor); +// FIXME: HACK: The following DrawPolygon draws twice in lok rtl mode for some reason. +// => one at the correct location with fill (possibly no outline) +// => and the other at an x offset with outline and without fill +// eg. Replacing this with a DrawRect() does not have any such problems. +comphelper::LibreOfficeKit::isActive() ? mpOutDev->SetLineColor() : mpOutDev->SetLineColor(aArrowColor); mpOutDev->SetFillColor(aArrowColor); Point aCenter(aPos.X() + (aSize.Width() / 2), aPos.Y() + (aSize.Height() / 2));
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/gridwin.hxx |4 ++
sc/source/ui/view/gridwin4.cxx | 57 +
2 files changed, 44 insertions(+), 17 deletions(-)
New commits:
commit 324b76a3f76acd2bd00c2023a3fe990d4eefd12d
Author: Dennis Francis
AuthorDate: Wed Nov 24 16:09:29 2021 +0530
Commit: Dennis Francis
CommitDate: Mon Jan 31 05:55:54 2022 +0100
lokCalcRTL: draw autofilter buttons at correct coordinates
Factor out the transformation from document coordinates to tile device
coordinates in ScLokRTLContext.
Conflicts:
sc/source/ui/view/gridwin4.cxx
Change-Id: I426a179bff253233f6d45b67ddfde8b3bb1344a1
(cherry picked from commit 0145c2c0e4c69d486693488fa24490ee4458349a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128901
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index e1ab39eb2446..0aa1d55272c9 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -52,6 +52,7 @@ class ScNoteMarker;
class SdrHdlList;
class ScTransferObj;
struct SpellCallbackInfo;
+class ScLokRTLContext;
// mouse status (nMouseStatus)
@@ -416,7 +417,8 @@ public:
void DPLaunchFieldPopupMenu(const Point& rScrPos, const Size& rScrSize,
tools::Long nDimIndex, ScDPObject* pDPObj);
-void DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo,
OutputDevice* pContentDev);
+void DrawButtons(SCCOL nX1, SCCOL nX2, const ScTableInfo& rTabInfo,
OutputDevice* pContentDev,
+ ScLokRTLContext* pLokRTLContext);
using Window::Draw;
voidDraw( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2,
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 4f1f1cc49130..c48b206ef891 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -627,6 +627,34 @@ private:
}
+/**
+ * Used to store the necessary information about the (combined-)tile
+ * area relevant to coordinate transformations in RTL mode.
+ */
+class ScLokRTLContext
+{
+public:
+ScLokRTLContext(const ScOutputData& rOutputData, const tools::Long
nTileDeviceOriginPixelX):
+mrOutputData(rOutputData),
+mnTileDevOriginX(nTileDeviceOriginPixelX)
+{}
+
+/**
+ * Converts from document x pixel position to the
+ * corresponding pixel position w.r.t the tile device origin.
+ */
+tools::Long docToTilePos(tools::Long nPosX) const
+{
+tools::Long nMirrorX = (-2 * mnTileDevOriginX) +
mrOutputData.GetScrW();
+return nMirrorX - 1 - nPosX;
+}
+
+
+private:
+const ScOutputData& mrOutputData;
+const tools::Long mnTileDevOriginX;
+};
+
void ScGridWindow::DrawContent(OutputDevice , const ScTableInfo&
rTableInfo, ScOutputData& aOutputData,
bool bLogicText)
{
@@ -708,6 +736,10 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
}
tools::Rectangle aDrawingRectLogic;
bool bLayoutRTL = rDoc.IsLayoutRTL( nTab );
+std::unique_ptr pLokRTLCtxt(
+bIsTiledRendering && bLayoutRTL ?
+new ScLokRTLContext(aOutputData,
o3tl::convert(aOriginalMode.GetOrigin().X(), o3tl::Length::twip,
o3tl::Length::px)) :
+nullptr);
{
// get drawing pixel rect
@@ -899,9 +931,8 @@ void ScGridWindow::DrawContent(OutputDevice , const
ScTableInfo& rTableI
else
pContentDev->SetMapMode(MapMode(MapUnit::MapPixel));
-// Autofilter- and Pivot-Buttons
-
-DrawButtons(nX1, nX2, rTableInfo, pContentDev); // Pixel
+// Autofilter- and Pivot-Buttons
+DrawButtons(nX1, nX2, rTableInfo, pContentDev, pLokRTLCtxt.get());
// Pixel
pContentDev->SetMapMode(MapMode(MapUnit::MapPixel));
@@ -1067,12 +1098,8 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
{
// Transform the cell range X coordinates such
that the edit cell area is
// horizontally mirrored w.r.t the
(combined-)tile.
-tools::Long nStartTileX =
-o3tl::convert(aOriginalMode.GetOrigin().X(), o3tl::Length::twip,
o3tl::Length::px);
-// Note: nStartTileX is scaled by 2 only to
offset for the addition of
-// the -ve of the same qty (and nScrX) few
lines below.
-tools::Long nMirrorX = 2 * nStartTileX +
aOutputData.GetScrW();
-aStart.setX(nMirrorX - 1 - aStart.X());
-aEnd.setX(nMirrorX - 1 - aEnd.X());
+
aStart.setX(pLokRTLCtxt->docToTilePos(aStart.X()));
+aEnd.setX(pLokRTLCtxt->docToTilePos(aEnd.X()));
}
[Libreoffice-bugs] [Bug 147081] New: No Small capitals feature in LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=147081 Bug ID: 147081 Summary: No Small capitals feature in LibreOffice Calc Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: emetiernetw...@pm.me Description: There is no feature to make "small capitals" in Calc and when I copy and paste small capital text into "Calc". It converts the small capital text to regular text. Small text is in "Writer". Why it's not included in all programs is beyond me. My request is the have "small capitals" included in "Calc" and all other software in the LibreOffice suite. Make no sense to have the feature in one program and then go to another and it's not available. It's a waste of time and will cause people to publicly document the nuisance which could potentially have a negative effect (cause people to not want to use) the software. Steps to Reproduce: 1.No option to select "small capitals" in Calc 2.If you paste small capital text into the program, it converts it to regular text. 3. Actual Results: "Same" mentioned above. Expected Results: I explained as above. Reproducible: Always User Profile Reset: No Additional Info: The small capitals feature should have been in and worded properly in the software when selected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147080] New: Wrong Architecture offered on Mac from Upgrade Dialogue in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=147080 Bug ID: 147080 Summary: Wrong Architecture offered on Mac from Upgrade Dialogue in LibreOffice Product: LibreOffice Version: 7.2.4.1 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@blundell.net.nz Description: In Mac OS 12.1, while using the Apple Silicon version 7.2.4.1, LibreOffice offers an update. In the Dialogue box that pops up, you click on a button to take you to the website. You are taken here: https://www.libreoffice.org/download/download/?lang=en-US=7.2.5_campaign=update rather than here: https://www.libreoffice.org/download/download/?type=mac-aarch64=7.2.5=en-US Steps to Reproduce: 1.goto: LibreOffice/Help/Check for updates 2.click on [Download] button 3.you will be taken to an Intel Architecture version to download, not Arm/Apple-Silicon Actual Results: Download link takes you here: https://www.libreoffice.org/download/download/?lang=en-US=7.2.5_campaign=update Expected Results: Download link should take here instead: https://www.libreoffice.org/download/download/?type=mac-aarch64=7.2.5=en-US Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.4.1 / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 8; OS: Mac OS X 12.1; UI render: default; VCL: osx Locale: en-NZ (en_NZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146798] Math stops responding to keyboard after inserting from sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=146798 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146797] Fullscreen Mode (Ctrl+Shift+J) Has Visible Gaps Around Edges
https://bugs.documentfoundation.org/show_bug.cgi?id=146797 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146793] Inconsistency when deleting first paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=146793 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146792] Installation - / Updating :: Old Entries not completely removed
https://bugs.documentfoundation.org/show_bug.cgi?id=146792 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146711] Writer pastes incorrectly when copying from HTML with the tag.
https://bugs.documentfoundation.org/show_bug.cgi?id=146711 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146599] XIRR produces incorrect value
https://bugs.documentfoundation.org/show_bug.cgi?id=146599 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146940] Libreoffice became increadibly slow on using emoticons
https://bugs.documentfoundation.org/show_bug.cgi?id=146940 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146940] Libreoffice became increadibly slow on using emoticons
https://bugs.documentfoundation.org/show_bug.cgi?id=146940 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138985] When writing Arabic text and it has a date inside, the date is not compatible with the Arabic format from right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=138985 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138985] When writing Arabic text and it has a date inside, the date is not compatible with the Arabic format from right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=138985 --- Comment #3 from QA Administrators --- Dear a0555170767, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143698] LibreOffice Thesaurus Greyed Out
https://bugs.documentfoundation.org/show_bug.cgi?id=143698 --- Comment #2 from QA Administrators --- Dear Lyle, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=147014 --- Comment #9 from Aron Budea --- Created attachment 177926 --> https://bugs.documentfoundation.org/attachment.cgi?id=177926=edit XLSX created from scratch Note that this issue isn't directly caused by the referenced commit. The problem is an overflow in when getting the Size property of a cell range spanning more than a million rows, height is negative here: https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=75036ee9#1361 The overflow itself happens here, when sizes of type __int64 are converted into long, because the components of awt::Size are long: https://opengrok.libreoffice.org/xref/core/sc/source/ui/unoobj/cellsuno.cxx?r=c3d5c9a0#5710 awt::Size: https://api.libreoffice.org/docs/idl/ref/structcom_1_1sun_1_1star_1_1awt_1_1Size.html It's fairly simple to create a bugdoc from scratch: - Increase height to ~5x the normal size (select all cells, and resize one of the rows), - Insert an image, - Save as XLSX, then reload. Eike, is the type of the Size property not being able to hold the size of a large cell range (eg. largest sheet size) a fundamental problem, and if so, what do you think could be done about it? Clamping the values would be a simple fix, but I'm worried about other potential issues with the insufficiently sized type. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/uibase/utlui/content.cxx |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
New commits:
commit c6c343db72a97bb027ccb493cef6fa7f1025f119
Author: Jim Raykowski
AuthorDate: Fri Jan 28 17:34:48 2022 -0900
Commit: Adolfo Jayme Barrientos
CommitDate: Mon Jan 31 03:47:35 2022 +0100
tdf#147041 Always show navigated heading at top of visible view area
Revert to pre commit 1df2581cfffc87386c6de7614793b2d664244e5a behavior
Change-Id: I06fe630bf0c0e611351e0e9a56361a3028f207d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129129
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
(cherry picked from commit b0434f62c17b69e10caf05ad85a60f1bffdb5238)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129080
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 01c0b005f8ff..d3c2bc2b2b81 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5286,9 +5286,11 @@ void SwContentTree::GotoContent(const SwContent* pCnt)
rView.GetPostItMgr()->SetActiveSidebarWin(nullptr);
rView.GetEditWin().GrabFocus();
-// assure visible view area is at cursor position
-if (!m_pActiveShell->IsCursorVisible() &&
!m_pActiveShell->IsFrameSelected() &&
-!m_pActiveShell->IsObjSelected())
+// Assure cursor is in visible view area.
+// (tdf#147041) Always show the navigated outline at the top of the
visible view area.
+if (pCnt->GetParent()->GetType() == ContentTypeId::OUTLINE ||
+(!m_pActiveShell->IsCursorVisible() &&
!m_pActiveShell->IsFrameSelected() &&
+!m_pActiveShell->IsObjSelected()))
{
Point rPoint = m_pActiveShell->GetCursorDocPos();
rPoint.setX(0);
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - 2 commits - oovbaapi/ooo sc/qa sc/source
oovbaapi/ooo/vba/excel/XApplication.idl |1
sc/qa/extras/testdocuments/VariousTestMacros.xlsm |binary
sc/qa/extras/vba-macro-test.cxx | 189 ++
sc/source/ui/vba/vbaapplication.cxx | 10 +
sc/source/ui/vba/vbaapplication.hxx |2
5 files changed, 202 insertions(+)
New commits:
commit 58d74724631425b083c4bd3d316a0a4bc1af4eb3
Author: Tomaž Vajngerl
AuthorDate: Wed Jan 26 16:54:12 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Mon Jan 31 03:45:43 2022 +0100
vba: add tests for scrolling, range selecting, print area
This adds various tests involving scrolling to a particular cell
in the document, selecting whole ranges or ranges o filled cells
and setting the print area.
VBA functions:
ActiveWindow.ScrollColumn
ActiveWindow.ScrollRow
Selection
Selection.End(xlToRight)
ActiveSheet.PageSetup.PrintArea
Change-Id: Iacde9c513b41571e98234c12cc3b42a16de4b833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129014
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 9a46a203515779ae40b7cfac36dbc22990e23290)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129020
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Luboš Luňák
diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 174e2e7229b6..b256eb373036 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -21,6 +21,8 @@
#include
#include
+#include
+#include
using namespace css;
@@ -48,13 +50,21 @@ public:
void testSimpleCopyAndPaste();
void testMultiDocumentCopyAndPaste();
void testSheetAndColumnSelectAndHide();
+void testPrintArea();
+void testSelectAllChaged();
+void testRangeSelect();
void testWindowState();
+void testScroll();
CPPUNIT_TEST_SUITE(VBAMacroTest);
CPPUNIT_TEST(testSimpleCopyAndPaste);
CPPUNIT_TEST(testMultiDocumentCopyAndPaste);
CPPUNIT_TEST(testSheetAndColumnSelectAndHide);
+CPPUNIT_TEST(testPrintArea);
+CPPUNIT_TEST(testSelectAllChaged);
+CPPUNIT_TEST(testRangeSelect);
CPPUNIT_TEST(testWindowState);
+CPPUNIT_TEST(testScroll);
CPPUNIT_TEST_SUITE_END();
};
@@ -221,6 +231,126 @@ void VBAMacroTest::testSheetAndColumnSelectAndHide()
CPPUNIT_ASSERT_EQUAL(SCTAB(0), rViewData.GetTabNo());
}
+void VBAMacroTest::testPrintArea()
+{
+// Sets the print area to A1:B5
+// ActiveSheet.PageSetup.PrintArea = "$A$1:$B$5"
+
+OUString aFileName;
+createFileURL(u"VariousTestMacros.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+uno::Reference xDoc(mxComponent,
uno::UNO_QUERY_THROW);
+uno::Reference xIndex(xDoc->getSheets(),
uno::UNO_QUERY_THROW);
+uno::Reference xSheet(xIndex->getByIndex(0),
uno::UNO_QUERY_THROW);
+uno::Reference xPrintAreas(xSheet,
uno::UNO_QUERY_THROW);
+
+{
+const uno::Sequence aSequence =
xPrintAreas->getPrintAreas();
+CPPUNIT_ASSERT_EQUAL(false, aSequence.hasElements());
+}
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testPrintArea?"
+"language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+{
+const uno::Sequence aSequence =
xPrintAreas->getPrintAreas();
+CPPUNIT_ASSERT_EQUAL(true, aSequence.hasElements());
+}
+}
+
+void VBAMacroTest::testSelectAllChaged()
+{
+// Columns("A:A").Select
+// Range(Selection, Selection.End(xlToRight)).Select
+
+OUString aFileName;
+createFileURL(u"VariousTestMacros.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+ScDocShell* pDocSh = static_cast(pFoundShell);
+ScTabViewShell* pView = pDocSh->GetBestViewShell(false);
+CPPUNIT_ASSERT(pView != nullptr);
+auto const& pViewData = pView->GetViewData();
+
+{
+ScRange aRange;
+pViewData.GetMarkData().GetMarkArea(aRange);
+CPPUNIT_ASSERT_EQUAL(ScRange(), aRange);
+}
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testSelectAll?"
+
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa
sc/qa/extras/testdocuments/SheetAndColumnSelectAndHide.xlsm |binary
sc/qa/extras/vba-macro-test.cxx | 76
2 files changed, 76 insertions(+)
New commits:
commit ba4365fb28597294c20d8f3581cbfcafa761d3aa
Author: Tomaž Vajngerl
AuthorDate: Tue Jan 25 16:14:32 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Mon Jan 31 03:45:12 2022 +0100
vba: test for selcting and hiding columns from a VBA Macro
Change-Id: Ib954a98e3cf91253c416f358a114bf6b6eb549b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129012
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit cfa4867b0b66b0d4fb3aee52ca40d380e50de9ef)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129018
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Luboš Luňák
diff --git a/sc/qa/extras/testdocuments/SheetAndColumnSelectAndHide.xlsm
b/sc/qa/extras/testdocuments/SheetAndColumnSelectAndHide.xlsm
new file mode 100644
index ..684480c3ff04
Binary files /dev/null and
b/sc/qa/extras/testdocuments/SheetAndColumnSelectAndHide.xlsm differ
diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 36aa84badd2d..532e47d14ad5 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -12,6 +12,8 @@
#include
#include
#include
+#include
+#include
#include
#include
@@ -45,10 +47,12 @@ public:
void testSimpleCopyAndPaste();
void testMultiDocumentCopyAndPaste();
+void testSheetAndColumnSelectAndHide();
CPPUNIT_TEST_SUITE(VBAMacroTest);
CPPUNIT_TEST(testSimpleCopyAndPaste);
CPPUNIT_TEST(testMultiDocumentCopyAndPaste);
+CPPUNIT_TEST(testSheetAndColumnSelectAndHide);
CPPUNIT_TEST_SUITE_END();
};
@@ -143,6 +147,78 @@ void VBAMacroTest::testMultiDocumentCopyAndPaste()
CPPUNIT_ASSERT_EQUAL(0.0, rDoc.GetValue(ScAddress(1, 3, 0)));
}
+void VBAMacroTest::testSheetAndColumnSelectAndHide()
+{
+OUString aFileName;
+createFileURL(u"SheetAndColumnSelectAndHide.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName,
"com.sun.star.sheet.SpreadsheetDocument");
+
+SfxObjectShell* pFoundShell =
SfxObjectShell::GetShellFromComponent(mxComponent);
+
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+ScDocShell* pDocSh = static_cast(pFoundShell);
+ScDocument& rDoc = pDocSh->GetDocument();
+
+ScTabViewShell* pView = pDocSh->GetBestViewShell(false);
+CPPUNIT_ASSERT(pView != nullptr);
+auto const& rViewData = pView->GetViewData();
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(1, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(2, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(3, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(4, 1));
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(1, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(2, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(3, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(4, 2));
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(
+mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testHide?language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 1));
+CPPUNIT_ASSERT(rDoc.ColHidden(1, 1));
+CPPUNIT_ASSERT(rDoc.ColHidden(2, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(3, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(4, 1));
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(1, 2));
+CPPUNIT_ASSERT(rDoc.ColHidden(2, 2));
+CPPUNIT_ASSERT(rDoc.ColHidden(3, 2));
+CPPUNIT_ASSERT(rDoc.ColHidden(4, 2));
+
+CPPUNIT_ASSERT_EQUAL(SCTAB(0), rViewData.GetTabNo());
+
+SfxObjectShell::CallXScript(
+mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testUnhide?language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(1, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(2, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(3, 1));
+CPPUNIT_ASSERT(!rDoc.ColHidden(4, 1));
+
+CPPUNIT_ASSERT(!rDoc.ColHidden(0, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(1, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(2, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(3, 2));
+CPPUNIT_ASSERT(!rDoc.ColHidden(4, 2));
+
+CPPUNIT_ASSERT_EQUAL(SCTAB(0), rViewData.GetTabNo());
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(VBAMacroTest);
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - 2 commits - oovbaapi/ooo sc/CppunitTest_sc_macros_test.mk sc/qa sc/source
oovbaapi/ooo/vba/excel/XApplication.idl| 10 +
oovbaapi/ooo/vba/excel/XFileDialog.idl |2
sc/CppunitTest_sc_macros_test.mk |1
sc/qa/extras/testdocuments/MultiDocumentCopyPaste.xlsm |binary
sc/qa/extras/testdocuments/SimpleCopyPaste.xlsm|binary
sc/qa/extras/vba-macro-test.cxx| 148 +
sc/source/ui/vba/excelvbahelper.cxx| 25 +-
sc/source/ui/vba/vbaapplication.cxx| 39
sc/source/ui/vba/vbaapplication.hxx|2
sc/source/ui/vba/vbafiledialog.cxx | 11 +
sc/source/ui/vba/vbafiledialog.hxx |4
sc/source/ui/vba/vbafiledialogitems.hxx|5
sc/source/ui/vba/vbarange.cxx |7
sc/source/ui/vba/vbaworkbooks.cxx | 11 -
14 files changed, 248 insertions(+), 17 deletions(-)
New commits:
commit 6482694c3d23f94a8d7fec4edbbe1fb3b1055df8
Author: Tomaž Vajngerl
AuthorDate: Thu Jan 20 21:13:26 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Mon Jan 31 03:45:03 2022 +0100
tdf#118246 add support for Application.GetOpenFilename func.
Opens the file dialog and returns the selected filename.
Change-Id: I4eccd34a7fbb892c0950b2f7c34977cf2aad6f89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128721
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 571438a34ad9aba0d496a89e8345851331740fbd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129017
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Luboš Luňák
diff --git a/oovbaapi/ooo/vba/excel/XApplication.idl
b/oovbaapi/ooo/vba/excel/XApplication.idl
index 89a19197116f..b1bcf46336be 100644
--- a/oovbaapi/ooo/vba/excel/XApplication.idl
+++ b/oovbaapi/ooo/vba/excel/XApplication.idl
@@ -65,6 +65,16 @@ interface XApplication
string getDefaultFilePath()
raises(com::sun::star::script::BasicErrorException);
+// Opens the file dialog and returns the selected file
+// Parameters:
+// Title: title of the file dialog
+// MultiSelect: true if multi selection is allowed (false by default)
+// returns:
+// false - if file dialog was canceled
+// filename - if "MultiSelect" is false
+// array of filename - if "MultiSelect" is true
+any GetOpenFilename([in] any FileFilter, [in] any FilterIndex, [in] any
Title, [in] any ButtonText, [in] any MultiSelect);
+
any International( [in] long Index );
any Workbooks( [in] any Index );
any Worksheets( [in] any Index );
diff --git a/oovbaapi/ooo/vba/excel/XFileDialog.idl
b/oovbaapi/ooo/vba/excel/XFileDialog.idl
index e73813e53807..bf9ff2391ee8 100644
--- a/oovbaapi/ooo/vba/excel/XFileDialog.idl
+++ b/oovbaapi/ooo/vba/excel/XFileDialog.idl
@@ -34,6 +34,8 @@ interface XFileDialog
[attribute] any InitialFileName;
[attribute] any Title;
+[attribute] any AllowMultiSelect;
+
[attribute, readonly] XFileDialogSelectedItems SelectedItems;
long Show();
diff --git a/sc/source/ui/vba/vbaapplication.cxx
b/sc/source/ui/vba/vbaapplication.cxx
index ced6d0c70eb3..0fd425c15cf6 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -34,6 +34,7 @@
#include
#include
#include
+#include
#include "vbaapplication.hxx"
#include "vbaworkbooks.hxx"
@@ -55,6 +56,7 @@
#include
#include
#include "vbafiledialog.hxx"
+#include "vbafiledialogitems.hxx"
#include
#include
@@ -71,13 +73,13 @@
#include
#include
#include
+#include
#include
#include
#include
#include
#include "excelvbahelper.hxx"
-
#include
#include
@@ -347,6 +349,41 @@ ScVbaApplication::getActiveCell()
return new ScVbaRange( excel::getUnoSheetModuleObj( xRange ), mxContext,
xRange->getCellRangeByPosition( nCursorX, nCursorY, nCursorX, nCursorY ) );
}
+uno::Any SAL_CALL
+ScVbaApplication::GetOpenFilename(const uno::Any& /*aFileFilter*/, const
uno::Any& /*aFilterIndex*/, const uno::Any& aTitle, const uno::Any&
/*aButtonText*/, const uno::Any& aMultiSelect)
+{
+// TODO - take all parameters into account
+auto xDialog = uno::Reference (new ScVbaFileDialog(
this, mxContext, office::MsoFileDialogType::msoFileDialogFilePicker));
+xDialog->setTitle(aTitle);
+xDialog->setAllowMultiSelect(aMultiSelect);
+
+bool bMultiSelect = false;
+aMultiSelect >>= bMultiSelect;
+
+if (xDialog->Show() == 0)
+{
+// return FALSE when canceled
+return uno::makeAny(false);
+}
+
+uno::Reference xItems =
xDialog->getSelectedItems();
+auto* pItems = dynamic_cast(xItems.get());
+auto const & rItemVector = pItems->getItems();
+
+if (!bMultiSelect) // only 1 selection allowed - return path
+{
+OUString aPath;
+if (!rItemVector.empty())
+aPath = rItemVector.at(0);
+
[Libreoffice-bugs] [Bug 107727] FILESAVE RTF: border-less text frame gets a border line
https://bugs.documentfoundation.org/show_bug.cgi?id=107727 --- Comment #10 from Regina Henschel --- Created attachment 177925 --> https://bugs.documentfoundation.org/attachment.cgi?id=177925=edit Proposed solution The attached patch solves the problem for me. But RTF filter is not my area, so someone else should have a look. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147079] [FILEOPEN] NUMBERS iwa files deemed corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=147079 --- Comment #1 from SheetJS --- Created attachment 177924 --> https://bugs.documentfoundation.org/attachment.cgi?id=177924=edit specimen -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147079] New: [FILEOPEN] NUMBERS iwa files deemed corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=147079 Bug ID: 147079 Summary: [FILEOPEN] NUMBERS iwa files deemed corrupt Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@sheetjs.com Description: Attached file opens in Numbers but not in LibreOffice Steps to Reproduce: Open attached file Actual Results: Popup "The file ... is corrupt and therefore cannot be opened." Expected Results: File should open Reproducible: Always User Profile Reset: Yes Additional Info: plists are blanked and unnecessary subfiles were removed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107727] FILESAVE RTF: border-less text frame gets a border line
https://bugs.documentfoundation.org/show_bug.cgi?id=107727
Regina Henschel changed:
What|Removed |Added
CC||rb.hensc...@t-online.de
--- Comment #9 from Regina Henschel ---
In the RTF file the attribute {\sp{\sn fLine}{\sv 0}} is missing. It has the
default value TRUE, so in case of no border it needs to be written out.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137186] FILESAVE RTF Table breaks to second page too early
https://bugs.documentfoundation.org/show_bug.cgi?id=137186 --- Comment #4 from Gabor Kelemen (allotropia) --- Created attachment 177923 --> https://bugs.documentfoundation.org/attachment.cgi?id=177923=edit The example file saved to RTF with current Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137186] FILESAVE RTF Table breaks to second page too early
https://bugs.documentfoundation.org/show_bug.cgi?id=137186 --- Comment #3 from Gabor Kelemen (allotropia) --- Created attachment 177922 --> https://bugs.documentfoundation.org/attachment.cgi?id=177922=edit The original DOCX file and its Writer-saved RTF version in Word 2013 The Writer-saved RTF looks quite bad in Word, several settings are exported on the list items that were not present in the DOCX. Let's refocus this report. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146876] FILEOPEN PPTX: various graphical elements misplaced at position (0, 0)
https://bugs.documentfoundation.org/show_bug.cgi?id=146876 Gerald Pfeifer changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Gerald Pfeifer --- Happy to verify this as fixed, both with the sample document attached to this report and others that showed the issue: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 7055ad90927d0d2e0dc5eab3774322e386fe2b15 CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded And thank you, Xisco, for adding the regression test! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137186] FILESAVE RTF Table breaks to second page too early
https://bugs.documentfoundation.org/show_bug.cgi?id=137186 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #2 from Gabor Kelemen (allotropia) --- Created attachment 177921 --> https://bugs.documentfoundation.org/attachment.cgi?id=177921=edit The original DOCX file and its Writer-saved RTF version in current Writer This looks correct in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded since: https://git.libreoffice.org/core/+/0a32371cc2f93fad7954e0fe9c48976aae6c5b9f author Justin Luth Wed Mar 10 14:41:57 2021 +0200 committer Justin LuthThu Mar 18 16:40:02 2021 +0100 tdf#108518 partial revert tdf#64222 sw: better DOCX im/export -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5c138ac6a8334825ef171ac6291b66b277eb4288 Author: Stanislav Horacek AuthorDate: Mon Jan 31 00:54:29 2022 +0100 Commit: Gerrit Code Review CommitDate: Mon Jan 31 00:54:29 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 7dea7021f47a85d16260bbcd775897f36ffa9ee6 - make title of method list localizable Change-Id: I8a1a8c1657c6390b8bcd7a42a6f6824293bf43f2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129177 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 05845e7cdac8..7dea7021f47a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 05845e7cdac8b52eef41070a2f05445396058b92 +Subproject commit 7dea7021f47a85d16260bbcd775897f36ffa9ee6
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03/sf_string.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7dea7021f47a85d16260bbcd775897f36ffa9ee6 Author: Stanislav Horacek AuthorDate: Sun Jan 30 19:30:19 2022 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Mon Jan 31 00:54:28 2022 +0100 make title of method list localizable Change-Id: I8a1a8c1657c6390b8bcd7a42a6f6824293bf43f2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129177 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/sbasic/shared/03/sf_string.xhp b/source/text/sbasic/shared/03/sf_string.xhp index c95ba322c..2ca692c21 100644 --- a/source/text/sbasic/shared/03/sf_string.xhp +++ b/source/text/sbasic/shared/03/sf_string.xhp @@ -270,7 +270,7 @@ - List of Methods in the String Service + List of Methods in the String Service
[Libreoffice-bugs] [Bug 147053] Add Aranese {oc-ES} locale data
https://bugs.documentfoundation.org/show_bug.cgi?id=147053 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |javierd...@hotmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/document.hxx |2 ++ sc/source/core/tool/compiler.cxx | 16 2 files changed, 14 insertions(+), 4 deletions(-) New commits: commit 61cb699e88b3680becf78dc7b8bd514b2b7318a4 Author: Eike Rathke AuthorDate: Sun Jan 30 23:36:53 2022 +0100 Commit: Eike Rathke CommitDate: Mon Jan 31 00:30:50 2022 +0100 Resolves: tdf#146722 Force row label for single text with numeric to the right Note this *might* break other uses of the non-deterministic automatic labels where exactly this constellation previously lead to a column label. For which expecting a column label though makes less sense.. Change-Id: Id85df7485f9b71620d8cbc404a981852d1567a54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129187 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 87fb59e8980d..33e529d0b426 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -2610,7 +2610,9 @@ private: boolHasPartOfMerged( const ScRange& rRange ); +public: ScRefCellValue GetRefCellValue( const ScAddress& rPos ); +private: ScRefCellValue GetRefCellValue( const ScAddress& rPos, sc::ColumnBlockPosition& rBlockPos ); std::map< SCTAB, ScSortParam > mSheetSortParams; diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx index 0858487b2836..aa65019434ea 100644 --- a/sc/source/core/tool/compiler.cxx +++ b/sc/source/core/tool/compiler.cxx @@ -3889,10 +3889,18 @@ bool ScCompiler::IsColRowName( const OUString& rName ) else aAdr = aOne; aRef.InitAddress( aAdr ); -if ( (aAdr.Row() != rDoc.MaxRow() && rDoc.HasStringData( -aAdr.Col(), aAdr.Row() + 1, aAdr.Tab())) - || (aAdr.Row() != 0 && rDoc.HasStringData( -aAdr.Col(), aAdr.Row() - 1, aAdr.Tab( +// Prioritize on column label; row label only if the next cell +// above/below the found label cell is text, or if both are not and +// the cell below is empty and the next cell to the right is +// numeric. +if ((aAdr.Row() < rDoc.MaxRow() && rDoc.HasStringData( +aAdr.Col(), aAdr.Row() + 1, aAdr.Tab())) +|| (aAdr.Row() > 0 && rDoc.HasStringData( +aAdr.Col(), aAdr.Row() - 1, aAdr.Tab())) +|| (aAdr.Row() < rDoc.MaxRow() && rDoc.GetRefCellValue( +ScAddress( aAdr.Col(), aAdr.Row() + 1, aAdr.Tab())).isEmpty() +&& aAdr.Col() < rDoc.MaxCol() && rDoc.GetRefCellValue( +ScAddress( aAdr.Col() + 1, aAdr.Row(), aAdr.Tab())).hasNumeric())) aRef.SetRowRel( true ); // RowName else aRef.SetColRel( true ); // ColName
[Libreoffice-bugs] [Bug 147077] FILEOPEN RTF Table horizontal position incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147077 Gabor Kelemen (allotropia) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #3 from Gabor Kelemen (allotropia) --- oops, this was already noticed *** This bug has been marked as a duplicate of bug 108093 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Bug 112765 depends on bug 147077, which changed state. Bug 147077 Summary: FILEOPEN RTF Table horizontal position incorrect https://bugs.documentfoundation.org/show_bug.cgi?id=147077 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108093] FILEOPEN: RTF table horizontal position wrong because frame not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=108093 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #14 from Gabor Kelemen (allotropia) --- *** Bug 147077 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107727] FILESAVE RTF: border-less text frame gets a border line
https://bugs.documentfoundation.org/show_bug.cgi?id=107727 --- Comment #8 from Gabor Kelemen (allotropia) --- Created attachment 177920 --> https://bugs.documentfoundation.org/attachment.cgi?id=177920=edit The example file and its RTF version in Writer master Still a problem in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113083] [META] New RTF import filter regressions in LO 3.5+
https://bugs.documentfoundation.org/show_bug.cgi?id=113083 Bug 113083 depends on bug 107413, which changed state. Bug 107413 Summary: FILEOPEN: RTF: Footer not imported https://bugs.documentfoundation.org/show_bug.cgi?id=107413 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107413] FILEOPEN: RTF: Footer not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=107413 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||libreoff...@nisz.hu, ||nem...@numbertext.org, ||szucs.atti...@nisz.hu Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #10 from Gabor Kelemen (allotropia) --- Thanks Attila for fixing this one too! *** This bug has been marked as a duplicate of bug 143384 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107413] FILEOPEN: RTF: Footer not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=107413 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #9 from Gabor Kelemen (allotropia) --- Created attachment 177919 --> https://bugs.documentfoundation.org/attachment.cgi?id=177919=edit The example file in Word and Writer master Looks good since: https://git.libreoffice.org/core/+/c1ad429d925855c1baacbdeca1ef42f4486eb9c2 author Attila Szűcs Tue Jul 27 11:45:58 2021 +0200 committer László NémethWed Aug 25 13:45:23 2021 +0200 tdf#143384 DOCX import: fix SAXException at header with table This is another example of negative page margin, which was worked around with a frame. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146722] Calc using labels shows errors or wrong results
https://bugs.documentfoundation.org/show_bug.cgi?id=146722 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Eike Rathke --- (In reply to TorrAB from comment #4) > (In reply to Eike Rathke from comment #3) > > Automatic labels are fragile > > … but VERY convenient! But not necessarily deterministic and persistent. > > and should be deprecated in the UI option settings > Why? Because their detection depends on data content and arrangement. If later a cell content is added with the same string that is nearer to the formula cell then a recompilation of the formula will yield a different result. > The bug (as explained above) should be easy to fix I love it when people who do not know the code and implications say "should be easy".. > > Best use defined label ranges, > > Sheet -> Named Ranges and Expressions -> Labels... > Yes, but they are clumsy No, they are the correct way to use labels. Anyway, I'll come up with a fix for this situation (no text content above/below and empty cell below and numeric cell to the right leads to a row label), which of course *might* break other uses of the non-deterministic automatic labels where exactly this constellation previously lead to a column label. -- You are receiving this mail because: You are the assignee for the bug.
Value range of c3DSpecularAmt
Hi all, hi Miklos, MS Office uses value 8/65536 ≈ 1.22 for attribute c3DSpecularAmt. The specification reads, "c3DSpecularAmt (4 bytes): A value of type FixedPoint, as specified in [MS-OSHARED] section 2.2.1.6, that specifies the ratio of incident to specular light that is reflected on a shape." The corresponding ODF attribute is draw:extrusion-specularity. That has a data type zeroToHundredPercent. So we cannot write the imported 122% to ODF. But currently LibreOffice writes 122% to file and so produces invalid files. When the shape is rendered, the product of light intensity and specularity is converted to a gray color for the 3D-Scene attribute D3DMaterialSpecularIntensity. Because the light intensity is often smaller than 100% a value for c3DSpecularAmt larger than 100% can be used meaningful. The range to [0%,100] has been introduced with [Office-2509] for ODF 1.2. In ODF 1.1 the data type was "percent". What to do? My suggestion is: Allow larger values than 100% in LibreOffice. Clamp the value to 100% in case of writing ODF 1.2 and 1.3 strict and use loext in case of ODF 1.2 and 1.3 extended. And write to ODF TC to re-enable values larger than 100% for ODF 1.4. What do you think? [1] https://issues.oasis-open.org/browse/OFFICE-2509 Kind regards, Regina
Material preset "Metal" for extruded custom shapes
Hi all, hi Miklos, the UI of Microsoft Office provides a material preset "Metal". Our UI provides that too. Both ODF and MSO standards have a Boolean attribute whether "Metal" has to be used or not. But the way "Metal" is actually rendered in MSO [3] is different from how ODF specifies it [1] and how MSO specifies it [2]. I want to make rendering similar to actual rendering in MSO in case we have an import from MSO. MSO uses for the attribute c3DDiffuseAmt the special value 43712/65536 in case of "Metal", otherwise 65536/65536. Currently I use this special value in my ongoing work [4] to detect, that the shape 'wants' a Metal-rendering like MSO. The attribute c3DDiffuseAmt has the corresponding attribute draw:extrusion-diffusion in ODF. So a document imported from MSO binary format and then saved to ODF looks still as MSO-kind, when reopening the document. But it is somehow a misuse of that ODF attribute. Do you think, that I should stay with that approach? Alternative would be to use a marker in an interoperability bag. But that would loose the information when writing to ODF. Opinions? [1] ODF specifies, "true: the specular color for the shading of an extruded shape is gray (red green and blue values of 200) instead of white and 15% is added to the specularity." [2] MSO specifies, "A bit that specifies whether the 3-D shape lighting algorithm will treat the specular color as the diffuse color." [3] Actual the rendering in MSO looks as if the first light is evaluated for specularity same as in material preset "Plastic" but the specular color is not gray but it is the same as the object color. [4] https://gerrit.libreoffice.org/c/core/+/128449 Kind regards, Regina
[Libreoffice-bugs] [Bug 133606] Format as Currency toolbar button and dropdown does not follow the default currency and sets fixed locale
https://bugs.documentfoundation.org/show_bug.cgi?id=133606 Eike Rathke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Eike Rathke --- This was fixed with https://gerrit.libreoffice.org/c/core/+/124025 for 7-2 and https://gerrit.libreoffice.org/c/core/+/124152 for 7-3 and later. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146845] Crash in: SwContentTree::ContentDoubleClickHdl(weld::TreeView &)
https://bugs.documentfoundation.org/show_bug.cgi?id=146845 --- Comment #5 from Telesto --- (In reply to Albrecht Müller from comment #0) > - On restart after a crash a document recovery screen should appear, not a > infinite loop of splash screens The loop sounds like the process soffice.bin not being terminated after the crash. It likely a process maxing out a single core.. should be visible in the process manager LibreOffice 7.0.4.2 is also rather old. So maybe check 7.2.x.x first? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146101] Notebookbar is displayed regardless of the context
https://bugs.documentfoundation.org/show_bug.cgi?id=146101 --- Comment #16 from Alex Thurgood --- Is this linked to bug 103170 in any way? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146101] Notebookbar is displayed regardless of the context
https://bugs.documentfoundation.org/show_bug.cgi?id=146101 --- Comment #15 from Alex Thurgood --- @Didier: do all Writer-specific extensions suffer from this problem? If not, then there must be something different in their respective Addon.xcu files, so that they are only displayed in Notebookbar in the correct module. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/source
sc/source/ui/cctrl/checklistmenu.cxx | 17 +
sc/source/ui/inc/checklistmenu.hxx |2 ++
sc/source/ui/view/gridwin.cxx|1 +
3 files changed, 16 insertions(+), 4 deletions(-)
New commits:
commit 10600d1988665bd950166891fa9df314bb847ac3
Author: Caolán McNamara
AuthorDate: Fri Jan 28 09:58:05 2022 +
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Jan 30 22:01:20 2022 +0100
Resolves: tdf#147016 ensure focus returns to document after popup closes
Change-Id: I67e59afc08bc5983d473cb9dceb4fcefedeec117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129095
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index f62b2369da27..88366b2ff0ac 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -283,6 +283,8 @@ void ScCheckListMenuControl::queueCloseSubMenu()
maCloseTimer.mpSubMenu = maOpenTimer.mpSubMenu;
maCloseTimer.mnMenuPos = maOpenTimer.mnMenuPos;
+maOpenTimer.mpSubMenu = nullptr;
+maOpenTimer.mnMenuPos = MENU_NOT_SELECTED;
maCloseTimer.maTimer.Start();
}
@@ -570,11 +572,8 @@ void ScCheckListMenuControl::GrabFocus()
}
}
-ScCheckListMenuControl::~ScCheckListMenuControl()
+void ScCheckListMenuControl::DropPendingEvents()
{
-EndPopupMode();
-for (auto& rMenuItem : maMenuItems)
-rMenuItem.mxSubMenuWin.reset();
if (mnAsyncPostPopdownId)
{
Application::RemoveUserEvent(mnAsyncPostPopdownId);
@@ -587,6 +586,14 @@ ScCheckListMenuControl::~ScCheckListMenuControl()
}
}
+ScCheckListMenuControl::~ScCheckListMenuControl()
+{
+EndPopupMode();
+for (auto& rMenuItem : maMenuItems)
+rMenuItem.mxSubMenuWin.reset();
+DropPendingEvents();
+}
+
void ScCheckListMenuControl::prepWindow()
{
mxMenu->set_size_request(-1, mxMenu->get_preferred_size().Height() + 2);
@@ -1427,6 +1434,8 @@ IMPL_LINK_NOARG(ScCheckListMenuControl, PopupModeEndHdl,
weld::Popover&, void)
if (mxPopupEndAction)
mxPopupEndAction->execute();
+DropPendingEvents();
+
if (comphelper::LibreOfficeKit::isActive())
NotifyCloseLOK();
}
diff --git a/sc/source/ui/inc/checklistmenu.hxx
b/sc/source/ui/inc/checklistmenu.hxx
index 961fddceac58..8d135870d871 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -254,6 +254,8 @@ private:
DECL_LINK(SetDropdownPosHdl, void*, void);
+void DropPendingEvents();
+
private:
std::unique_ptr mxBuilder;
std::unique_ptr mxPopover;
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 42b02d4b9743..2e4fcf0bc38d 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -524,6 +524,7 @@ public:
virtual bool execute() override
{
mpWindow->RefreshAutoFilterButton(maPos);
+mpWindow->GrabFocus();
return false; // this is called after the popup has been closed
}
};
[Libreoffice-bugs] [Bug 146101] Notebookbar is displayed regardless of the context
https://bugs.documentfoundation.org/show_bug.cgi?id=146101 Alex Thurgood changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|RESOLVED|NEW --- Comment #14 from Alex Thurgood --- The issue is not one relating to the epub extension per se, but rather why the Addon.xcu properties, which should limit display of an extensions icons to a particular module, e.g. Writer, are being ignored by the Notebookbar. For those that don't know him, Didier is the developer of the Dmath extension, and is not a complete newb when it comes to developing extensions. The question should be : Why are the props being set in the XCU ignored by the Notebookbar? As the behaviour was confirmed in comment 5, setting as new. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120580] [META] Concordance file bugs and enhancements of alphabetical indexes
https://bugs.documentfoundation.org/show_bug.cgi?id=120580 Bug 120580 depends on bug 108910, which changed state. Bug 108910 Summary: Concordance file for indexes breaks UTF-8 and turns the characters into ASCII https://bugs.documentfoundation.org/show_bug.cgi?id=108910 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 12c6bff0e43b81b9017050f644bd87e865bbbf9e Author: Stanislav Horacek AuthorDate: Sun Jan 30 21:39:23 2022 +0100 Commit: Gerrit Code Review CommitDate: Sun Jan 30 21:39:23 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 05845e7cdac8b52eef41070a2f05445396058b92 - fix format of UnoProperties method syntax Change-Id: I50ee4de218b1236283e3aaf76137edb8b79fb062 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129123 Tested-by: Jenkins Reviewed-by: Rafael Lima diff --git a/helpcontent2 b/helpcontent2 index 9de15af08924..05845e7cdac8 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9de15af089243bac07ce6ea9b7d505163c1b3f78 +Subproject commit 05845e7cdac8b52eef41070a2f05445396058b92
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03/sf_session.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 05845e7cdac8b52eef41070a2f05445396058b92 Author: Stanislav Horacek AuthorDate: Fri Jan 28 20:35:24 2022 +0100 Commit: Rafael Lima CommitDate: Sun Jan 30 21:39:21 2022 +0100 fix format of UnoProperties method syntax Change-Id: I50ee4de218b1236283e3aaf76137edb8b79fb062 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129123 Tested-by: Jenkins Reviewed-by: Rafael Lima diff --git a/source/text/sbasic/shared/03/sf_session.xhp b/source/text/sbasic/shared/03/sf_session.xhp index b80740b8e..1ce31f8f6 100644 --- a/source/text/sbasic/shared/03/sf_session.xhp +++ b/source/text/sbasic/shared/03/sf_session.xhp @@ -596,7 +596,7 @@ UnoProperties Returns a list of the properties of an UNO object. The list is a zero-based array of strings and may be empty. - + session.UnoProperties(unoobject: uno): str[0..*]
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/iodetect.hxx |2 +-
sw/source/ui/index/cnttab.cxx | 16 +++-
2 files changed, 12 insertions(+), 6 deletions(-)
New commits:
commit 7e6e0fd63eac57de0f76ab1efdb1283c22ad6e6c
Author: Andreas Heinisch
AuthorDate: Fri Jan 21 21:01:41 2022 +0100
Commit: Andreas Heinisch
CommitDate: Sun Jan 30 21:35:02 2022 +0100
tdf#108910, tdf#125496 - read/write index entries using utf8
Always write an index concordance file using the utf8 encoding and read
the index entries using the appropriate character set which is either
utf8 or the os thread encoding.
Change-Id: I5b30f4749f635bd51d8f0933ce5029d5303aef3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128745
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch
diff --git a/sw/inc/iodetect.hxx b/sw/inc/iodetect.hxx
index 1733bde20701..7deb65fcdd91 100644
--- a/sw/inc/iodetect.hxx
+++ b/sw/inc/iodetect.hxx
@@ -108,7 +108,7 @@ public:
static bool IsValidStgFilter( const css::uno::Reference <
css::embed::XStorage >& rStg, const SfxFilter& rFilter);
// tdf#106899 - wrapper around IsDetectableText to retrieve the text
encoding for a given stream
-static rtl_TextEncoding GetTextEncoding(SvStream&);
+SW_DLLPUBLIC static rtl_TextEncoding GetTextEncoding(SvStream&);
static bool IsDetectableText( const char* pBuf, sal_uLong ,
rtl_TextEncoding *pCharSet, bool *pSwap, LineEnd *pLineEnd, bool
*pBom);
diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index e2a334ebda26..1f7393fe3fa8 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -54,6 +54,7 @@
#include
#include
#include
+#include
#include
#include
@@ -3773,7 +3774,10 @@ void SwEntryBrowseBox::InitController(
void SwEntryBrowseBox::ReadEntries(SvStream& rInStr)
{
AutoMarkEntry* pToInsert = nullptr;
-rtl_TextEncoding eTEnc = osl_getThreadTextEncoding();
+// tdf#108910, tdf#125496 - read index entries using the appropriate
character set
+rtl_TextEncoding eTEnc = SwIoSystem::GetTextEncoding(rInStr);
+if (eTEnc == RTL_TEXTENCODING_DONTKNOW)
+eTEnc = osl_getThreadTextEncoding();
while (rInStr.good())
{
OUString sLine;
@@ -3833,13 +3837,13 @@ void SwEntryBrowseBox::WriteEntries(SvStream& rOutStr)
if (pController->IsValueChangedFromSaved())
GoToColumnId(nCol + (nCol < ITEM_CASE ? 1 : -1 ));
-rtl_TextEncoding eTEnc = osl_getThreadTextEncoding();
for(const std::unique_ptr & rpEntry : m_Entries)
{
AutoMarkEntry* pEntry = rpEntry.get();
if(!pEntry->sComment.isEmpty())
{
-rOutStr.WriteByteStringLine( OUStringConcatenation("#" +
pEntry->sComment), eTEnc );
+// tdf#108910, tdf#125496 - write index entries using the utf8
text encoding
+rOutStr.WriteByteStringLine( OUStringConcatenation("#" +
pEntry->sComment), RTL_TEXTENCODING_UTF8 );
}
OUString sWrite( pEntry->sSearch + ";" +
@@ -3851,7 +3855,8 @@ void SwEntryBrowseBox::WriteEntries(SvStream& rOutStr)
(pEntry->bWord ? std::u16string_view(u"1") :
std::u16string_view(u"0")) );
if( sWrite.getLength() > 5 )
-rOutStr.WriteByteStringLine( sWrite, eTEnc );
+// tdf#108910, tdf#125496 - write index entries using the utf8
text encoding
+rOutStr.WriteByteStringLine( sWrite, RTL_TEXTENCODING_UTF8 );
}
}
@@ -3919,7 +3924,8 @@ IMPL_LINK_NOARG(SwAutoMarkDlg_Impl, OkHdl, weld::Button&,
void)
bCreateMode ? StreamMode::WRITE
: StreamMode::WRITE| StreamMode::TRUNC );
SvStream* pStrm = aMed.GetOutStream();
-pStrm->SetStreamCharSet( RTL_TEXTENCODING_MS_1253 );
+// tdf#108910, tdf#125496 - write index entries using the utf8 text
encoding
+pStrm->SetStreamCharSet( RTL_TEXTENCODING_UTF8 );
if( !pStrm->GetError() )
{
m_xEntriesBB->WriteEntries( *pStrm );
[Libreoffice-bugs] [Bug 104527] [META] DOC (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Bug 104527 depends on bug 98199, which changed state. Bug 98199 Summary: FILEOPEN: DOC checkbox size *little* too big https://bugs.documentfoundation.org/show_bug.cgi?id=98199 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Bug 81234 depends on bug 98199, which changed state. Bug 98199 Summary: FILEOPEN: DOC checkbox size *little* too big https://bugs.documentfoundation.org/show_bug.cgi?id=98199 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98199] FILEOPEN: DOC checkbox size *little* too big
https://bugs.documentfoundation.org/show_bug.cgi?id=98199 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #22 from Gabor Kelemen (allotropia) --- (In reply to Timur from comment #21) > I don't see a difference so I think this should be closed. There was some difference in the layout of doc before 7.0. But that was because the cell holding "FIFen minimimitat näyttelyhäkeille 50x50x50 cm" has a small inner border set, which was not imported correctly. Since 7.0 it is correct. So I think this part was a wrong diagnose. The tables horizontal positioning also looks correct since 7.0 Also the document does not fall apart when saved to doc/docx in Writer and reopened in Writer or even Word \o/. The interesting part comes after converting attachment 123001 to RTF in Word, then opened in Writer: table positions are still incorrect, and saving the RTF in Writer causes more layout issues due to paragraph style/direct formatting save problems. I opened bug 147077 and bug 147078 about these still remaining issues. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146944] Crash in: lcl_Regist
https://bugs.documentfoundation.org/show_bug.cgi?id=146944 Albrecht Müller changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #5 from Albrecht Müller --- *** This bug has been marked as a duplicate of bug 146845 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146845] Crash in: SwContentTree::ContentDoubleClickHdl(weld::TreeView &)
https://bugs.documentfoundation.org/show_bug.cgi?id=146845 --- Comment #4 from Albrecht Müller --- *** Bug 146944 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113340] [META] RTF (text) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113340 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||147078 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147078 [Bug 147078] FILESAVE RTF Paragraph direct formatting of tab position not saved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147077] FILEOPEN RTF Table horizontal position incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147077 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7078 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147078] New: FILESAVE RTF Paragraph direct formatting of tab position not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=147078 Bug ID: 147078 Summary: FILESAVE RTF Paragraph direct formatting of tab position not saved Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 113340 Created attachment 177918 --> https://bugs.documentfoundation.org/attachment.cgi?id=177918=edit The example file in Word and its Writer-saved version reopened in Writer This is a continuation of bug 147077 and bug 98199 The attachment 177915 has some text formatted with "Body Text 3" paragraph style in the table starting with "Näyttelyluokat / utställningsklasser:" This style has a tab stop defined at 4.5 cm. This setting is overridden with direct formatting in the paragraphs numbered 7-17 to not have this tab stop. Writer opens this setting correctly, but does not save the direct formatting removal of the tab stop setting to RTF, so upon reopening the document the paragraphs have an extra tab stop in use. 1, Open attachment 177915 2, Save as RTF, reopen. The paragraphs 7-17 in table "Näyttelyluokat / utställningsklasser:" will have a 4.5 cm tab, making the documents content flow to two pages. Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113340 [Bug 113340] [META] RTF (text) paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146845] Crash in: SwContentTree::ContentDoubleClickHdl(weld::TreeView &)
https://bugs.documentfoundation.org/show_bug.cgi?id=146845 --- Comment #3 from Albrecht Müller --- *** Bug 146943 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146943] Crash in: vcl::Window::GetParentWithLOKNotifier()
https://bugs.documentfoundation.org/show_bug.cgi?id=146943 Albrecht Müller changed: What|Removed |Added CC||albrecht.muel...@astrail.de Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Albrecht Müller --- *** This bug has been marked as a duplicate of bug 146845 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147077] FILEOPEN RTF Table horizontal position incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147077 --- Comment #2 from Gabor Kelemen (allotropia) --- Created attachment 177917 --> https://bugs.documentfoundation.org/attachment.cgi?id=177917=edit The example file in Word and Writer master with the second tables settings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147077] FILEOPEN RTF Table horizontal position incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147077 --- Comment #1 from Gabor Kelemen (allotropia) --- Created attachment 177916 --> https://bugs.documentfoundation.org/attachment.cgi?id=177916=edit The example file in Word and Writer master with the first tables settings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98199] FILEOPEN: DOC checkbox size *little* too big
https://bugs.documentfoundation.org/show_bug.cgi?id=98199 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7077 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112765] [META] RTF (text) table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112765 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||147077 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147077 [Bug 147077] FILEOPEN RTF Table horizontal position incorrect -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147077] New: FILEOPEN RTF Table horizontal position incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=147077 Bug ID: 147077 Summary: FILEOPEN RTF Table horizontal position incorrect Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 112765 Created attachment 177915 --> https://bugs.documentfoundation.org/attachment.cgi?id=177915=edit attachment 123001 converted to RTF in Word 2013 This is split from bug 98199 When the example file attachment 123001 is converted to RTF in Word and opened in Writer, the tables at the bottom of the document have incorrect horizontal position. 1, Open attached file The table starting with "Valmistuminen luokissa 3-6:" is positioned a bit to the left compared to Word. This is because in Word the table has a 0.3 cm left indent, which is read incorrectly from RTF. This does not happen if the original .doc file is opened. The other table starting with "Näyttelyluokat / utställningsklasser:" is a floating one, also horizontally more to the left than in Word. This has a 0.25 cm left and right spacing which can - as seen in the doc original - mapped to the left-right spacing in Writer. Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112765 [Bug 112765] [META] RTF (text) table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146845] Crash in: SwContentTree::ContentDoubleClickHdl(weld::TreeView &)
https://bugs.documentfoundation.org/show_bug.cgi?id=146845 Albrecht Müller changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED CC||albrecht.muel...@astrail.de --- Comment #2 from Albrecht Müller --- Finding repro steps may be the hard part of this bug. That's why I uploaded three crash reports together with bug reports (this one, bug 146943 and bug 146944 ) to demonstrate that the bug is there and it happens way to often. Nevertheless I gave it a try: The crash reported in bug 146944 occurred in a simple setting and it was easy to create a broken document that makes Writer report macros that do not exist. But using this document I was not able to reproduce any crash. See https://bugs.documentfoundation.org/show_bug.cgi?id=146944#c4 and attachment 177914 I think I better spend my time updating the document I mentioned in bug https://bugs.documentfoundation.org/show_bug.cgi?id=146958#c2 by information that helps me to get along with the problem. For example this way: (1) The user profile should be under version control. (2) If you happen to see repeating splash screens: (2a) Trying to abort the process using the task manager may not work. You can abort it using the resource monitor. Maybe you need several tries to hit the confirmation button of the resource monitor: Try to hit it in the split second pause between the splash screens. This makes it unnecessary to restart the current session to abort the LO Process. You probably will be asked to send a crash report but this is useless (see Timurs comment https://bugs.documentfoundation.org/show_bug.cgi?id=146943#c1). Time spent on trying to find steps to reproduce is wasted as the crash seem to occur at random for no obvious reason. (2b) Check if the installed extensions still work. If not (that's usually the case), try to reinstall them or restore the damaged parts of the user profile from version control. This is faster than reinstalling the extensions individually. That's one of the reasons for point (1). (2c) Starting the recovery process one more time in general works as usual. You only have to find out what part of your work got lost and to redo it. That's the same as after any common crash which does not ask you to send a crash report. There are other options I did not try yet: (ad 2b) My Windows installation keeps some previous versions of all directories and files. I think this is a Windows default. This feature helped me sometimes to restore contents destroyed by misbehaving applications. Problems of this approach: At the time you notice the problem it may be too late to use this mechanism as the version you need may be gone. Comparing the current version with some previous version by hand is time consuming and error prone. I had not need to use this backup mechanism as I have the user profile under version control as proposed in (1). (ad 2) The cause of the repeating splash screen phenomenon may be some problem in the user profile. Therefore it might help to figure out what options (including keyboard shortcuts, toolbars etc.) had been changed with respect to the defaults, store necessary data and code at some safe place, store some backup of the user profile, deinstall LibreOffice, delete the user profile, reinstall LibreOffice, reinstall all extensions, restore the saved data and code and change all options to the values they had before. Did not try as this is a lot of work, might cause unexpected side effect and it is not clear if it will stop the repeating splash screen phenomenon. As I cannot provide additional useful information I set the bug back to state 'UNCONFIRMED' as you proposed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source solenv/clang-format
chart2/source/inc/ChartType.hxx | 13 ++
chart2/source/inc/DataSeries.hxx | 22 ++--
chart2/source/inc/DataSeriesHelper.hxx |4
chart2/source/model/template/ChartType.cxx | 39 ++-
chart2/source/tools/DataSeriesHelper.cxx | 31 ++
chart2/source/view/charttypes/VSeriesPlotter.cxx | 114 ++-
chart2/source/view/inc/VDataSeries.hxx |7 -
chart2/source/view/main/ChartView.cxx|9 -
chart2/source/view/main/VDataSeries.cxx | 19 +--
solenv/clang-format/excludelist |2
10 files changed, 161 insertions(+), 99 deletions(-)
New commits:
commit c496412631c950f081d7696867db907fa313653a
Author: Noel Grandin
AuthorDate: Sun Jan 30 12:27:56 2022 +0200
Commit: Noel Grandin
CommitDate: Sun Jan 30 20:48:02 2022 +0100
use more concrete types in chart2, DataSeries
Change-Id: Ida984d1701e2426958127845418365f6645a9043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129161
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/ChartType.hxx b/chart2/source/inc/ChartType.hxx
index 833fa9783993..4c95fac5a704 100644
--- a/chart2/source/inc/ChartType.hxx
+++ b/chart2/source/inc/ChartType.hxx
@@ -35,6 +35,7 @@
namespace chart
{
+class DataSeries;
class ModifyEventForwarder;
namespace impl
@@ -93,6 +94,14 @@ public:
virtual rtl::Reference cloneChartType() const = 0;
+void addDataSeries(
+const rtl::Reference< ::chart::DataSeries >& aDataSeries );
+void removeDataSeries(
+const rtl::Reference< ::chart::DataSeries >& aDataSeries );
+void setDataSeries(
+const std::vector< rtl::Reference< ::chart::DataSeries > >&
aDataSeries );
+const std::vector< rtl::Reference< ::chart::DataSeries > > &
getDataSeries2() const { return m_aDataSeries; }
+
protected:
// XModifyListener
@@ -124,11 +133,11 @@ protected:
private:
void impl_addDataSeriesWithoutNotification(
-const css::uno::Reference< css::chart2::XDataSeries >& aDataSeries );
+const rtl::Reference< ::chart::DataSeries >& aDataSeries );
private:
typedef
-std::vector< css::uno::Reference< css::chart2::XDataSeries > >
tDataSeriesContainerType;
+std::vector< rtl::Reference< ::chart::DataSeries > >
tDataSeriesContainerType;
// --- mutable members: the following members need mutex guard ---
diff --git a/chart2/source/model/inc/DataSeries.hxx
b/chart2/source/inc/DataSeries.hxx
similarity index 97%
rename from chart2/source/model/inc/DataSeries.hxx
rename to chart2/source/inc/DataSeries.hxx
index a7a91325a605..64aab7ff8822 100644
--- a/chart2/source/model/inc/DataSeries.hxx
+++ b/chart2/source/inc/DataSeries.hxx
@@ -30,13 +30,13 @@
#include
#include
#include
-#include
+#include "ModifyListenerHelper.hxx"
// STL
#include
#include
-#include
+#include "OPropertySet.hxx"
namespace com::sun::star::beans { class XPropertySet; }
@@ -77,12 +77,8 @@ public:
/// merge XTypeProvider implementations
DECLARE_XTYPEPROVIDER()
-private:
explicit DataSeries( const DataSeries & rOther );
-// late initialization to call after copy-constructing
-void Init( const DataSeries & rOther );
-
// XDataSeries
/// @see css::chart2::XDataSeries
virtual css::uno::Reference< css::beans::XPropertySet >
@@ -134,6 +130,17 @@ private:
virtual void SAL_CALL removeModifyListener(
const css::uno::Reference< css::util::XModifyListener >& aListener )
override;
+typedef
+std::vector< rtl::Reference< ::chart::RegressionCurveModel > >
+tRegressionCurveContainerType;
+
+const tRegressionCurveContainerType & getRegressionCurves2() const {
return m_aRegressionCurves; }
+
+private:
+
+// late initialization to call after copy-constructing
+void Init( const DataSeries & rOther );
+
// XModifyListener
virtual void SAL_CALL modified(
const css::lang::EventObject& aEvent ) override;
@@ -155,9 +162,6 @@ private:
css::uno::Reference< css::beans::XPropertySet > >
tDataPointAttributeContainer;
tDataPointAttributeContainer m_aAttributedDataPoints;
-typedef
-std::vector< rtl::Reference< ::chart::RegressionCurveModel > >
-tRegressionCurveContainerType;
tRegressionCurveContainerType m_aRegressionCurves;
rtl::Reference m_xModifyEventForwarder;
diff --git a/chart2/source/inc/DataSeriesHelper.hxx
b/chart2/source/inc/DataSeriesHelper.hxx
index 8d2e7e3d5672..72d759afe008 100644
--- a/chart2/source/inc/DataSeriesHelper.hxx
+++ b/chart2/source/inc/DataSeriesHelper.hxx
@@ -39,6 +39,7 @@ namespace com::sun::star::uno { template class
Sequence; }
namespace chart { class BaseCoordinateSystem; }
namespace chart { class ChartType; }
namespace chart { class Diagram; }
+namespace chart { class
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/source
vcl/source/outdev/map.cxx | 55 ++
1 file changed, 55 insertions(+)
New commits:
commit b5b115ecc87c09146eb76d891496175218ed45c2
Author: Caolán McNamara
AuthorDate: Sat Jan 29 20:49:47 2022 +
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Jan 30 20:38:50 2022 +0100
Resolves: tdf#147013 transform the control point positions too
Change-Id: Ia73317a79de66778d4b2d0face07ee4c41e328d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129078
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/vcl/source/outdev/map.cxx b/vcl/source/outdev/map.cxx
index 112fd5322557..227905f075a8 100644
--- a/vcl/source/outdev/map.cxx
+++ b/vcl/source/outdev/map.cxx
@@ -475,6 +475,9 @@ basegfx::B2DPolygon
OutputDevice::ImplLogicToDevicePixel(const basegfx::B2DPolyg
sal_uInt32 nPoints = rLogicPoly.count();
basegfx::B2DPolygon aPoly(rLogicPoly);
+basegfx::B2DPoint aC1;
+basegfx::B2DPoint aC2;
+
if (mbMap)
{
for (sal_uInt32 i = 0; i < nPoints; ++i)
@@ -484,7 +487,36 @@ basegfx::B2DPolygon
OutputDevice::ImplLogicToDevicePixel(const basegfx::B2DPolyg
maMapRes.mnMapScNumX,
maMapRes.mnMapScDenomX )+mnOutOffX+mnOutOffOrigX,
ImplLogicToPixel(
rPt.getY()+maMapRes.mnMapOfsY, mnDPIY,
maMapRes.mnMapScNumY,
maMapRes.mnMapScDenomY )+mnOutOffY+mnOutOffOrigY);
+
+const bool bC1 = aPoly.isPrevControlPointUsed(i);
+if (bC1)
+{
+const basegfx::B2DPoint aB2DC1(aPoly.getPrevControlPoint(i));
+
+aC1 = basegfx::B2DPoint(ImplLogicToPixel(
aB2DC1.getX()+maMapRes.mnMapOfsX, mnDPIX,
+maMapRes.mnMapScNumX,
maMapRes.mnMapScDenomX )+mnOutOffX+mnOutOffOrigX,
+ImplLogicToPixel(
aB2DC1.getY()+maMapRes.mnMapOfsY, mnDPIY,
+maMapRes.mnMapScNumY,
maMapRes.mnMapScDenomY )+mnOutOffY+mnOutOffOrigY);
+}
+
+const bool bC2 = aPoly.isNextControlPointUsed(i);
+if (bC2)
+{
+const basegfx::B2DPoint aB2DC2(aPoly.getNextControlPoint(i));
+
+aC2 = basegfx::B2DPoint(ImplLogicToPixel(
aB2DC2.getX()+maMapRes.mnMapOfsX, mnDPIX,
+maMapRes.mnMapScNumX,
maMapRes.mnMapScDenomX )+mnOutOffX+mnOutOffOrigX,
+ImplLogicToPixel(
aB2DC2.getY()+maMapRes.mnMapOfsY, mnDPIY,
+maMapRes.mnMapScNumY,
maMapRes.mnMapScDenomY )+mnOutOffY+mnOutOffOrigY);
+}
+
aPoly.setB2DPoint(i, aPt);
+
+if (bC1)
+aPoly.setPrevControlPoint(i, aC1);
+
+if (bC2)
+aPoly.setNextControlPoint(i, aC2);
}
}
else
@@ -493,7 +525,30 @@ basegfx::B2DPolygon
OutputDevice::ImplLogicToDevicePixel(const basegfx::B2DPolyg
{
const basegfx::B2DPoint& rPt = aPoly.getB2DPoint(i);
basegfx::B2DPoint aPt(rPt.getX() + mnOutOffX, rPt.getY() +
mnOutOffY);
+
+const bool bC1 = aPoly.isPrevControlPointUsed(i);
+if (bC1)
+{
+const basegfx::B2DPoint aB2DC1(aPoly.getPrevControlPoint(i));
+
+aC1 = basegfx::B2DPoint(aB2DC1.getX() + mnOutOffX,
aB2DC1.getY() + mnOutOffY);
+}
+
+const bool bC2 = aPoly.isNextControlPointUsed(i);
+if (bC2)
+{
+const basegfx::B2DPoint aB2DC2(aPoly.getNextControlPoint(i));
+
+aC1 = basegfx::B2DPoint(aB2DC2.getX() + mnOutOffX,
aB2DC2.getY() + mnOutOffY);
+}
+
aPoly.setB2DPoint(i, aPt);
+
+if (bC1)
+aPoly.setPrevControlPoint(i, aC1);
+
+if (bC2)
+aPoly.setNextControlPoint(i, aC2);
}
}
[Libreoffice-bugs] [Bug 141778] Icon style selection widget not displayed in some language versions (such as Czech and Greek)
https://bugs.documentfoundation.org/show_bug.cgi?id=141778 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #12 from Julien Nabet --- Could you give a try to 7.2.5 + apply https://wiki.documentfoundation.org/QA/FirstSteps, specifically https://wiki.documentfoundation.org/QA/FirstSteps#Graphics-related_issues_.28_Skia_.29, including this part: "However, there are known cases when using Skia/Raster still crashes LibreOffice when starting, and in those cases (when you will not be even able to look at Help ▸ About LibreOffice) you would need to try these manual steps..." -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146990] LibreOfficeDev_7.3.1.0.0_Linux_x86-64_rpm 25.01.2022 CALC crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=146990 --- Comment #3 from Peter --- @m.a.riosv I've downloaded LO today, erased the profiele (directory in -user-) and there is no difference to my first post/test. --- Now i try install LO 7.2, downloaded today from devbuilds, because Version LibreOffice_7.2.6.0.0_Linux_x86-64_rpm from 08.01.2022 ist working fine. Please excuse my english, my work with english speakin persons is long time ago. THX for your help -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/viewdata.cxx |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
New commits:
commit c5ab758bc3e1227e9ab3013d2fba4c2cd387e296
Author: Caolán McNamara
AuthorDate: Sun Jan 30 14:47:21 2022 +
Commit: Caolán McNamara
CommitDate: Sun Jan 30 20:18:19 2022 +0100
cid#1497923 Logically dead code
and
cid#1497924 Logically dead code
Change-Id: I548c09b2394e263d88a48fe97490f5b63d7d693a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129171
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 6f51cd24037d..539013b79372 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -1933,8 +1933,8 @@ void ScViewData::EditGrowX()
aArea.AdjustRight((bLayoutRTL && !bLOKActive) ? nLogicLeft :
nLogicRight );
if (bLOKPrintTwips)
{
-aAreaPTwips.AdjustLeft( -((bLayoutRTL && !bLOKActive) ?
nLogicRightPTwips : nLogicLeftPTwips) );
-aAreaPTwips.AdjustRight((bLayoutRTL && !bLOKActive) ?
nLogicLeftPTwips : nLogicRightPTwips );
+aAreaPTwips.AdjustLeft(-nLogicLeftPTwips);
+aAreaPTwips.AdjustRight(nLogicRightPTwips);
}
if ( aArea.Right() > aArea.Left() + aSize.Width() - 1 )
@@ -2012,8 +2012,6 @@ void ScViewData::EditGrowX()
if ( bLayoutRTL && !bLOKActive )
{
aArea.AdjustLeft( -nLogicWidth );
-if (bLOKPrintTwips)
-aAreaPTwips.AdjustLeft( -nLogicWidthPTwips );
}
else
{
@@ -2027,8 +2025,6 @@ void ScViewData::EditGrowX()
if ( bLayoutRTL && !bLOKActive )
{
aArea.SetLeft( aArea.Right() - aSize.Width() + 1 );
-if (bLOKPrintTwips)
-aAreaPTwips.SetLeft( aAreaPTwips.Right() -
aSizePTwips.Width() + 1 );
}
else
{
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8par.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 152752ad8552024209ca36b0eb13fea2893c5f96
Author: Caolán McNamara
AuthorDate: Sun Jan 30 15:04:53 2022 +
Commit: Caolán McNamara
CommitDate: Sun Jan 30 20:17:54 2022 +0100
ofz#44207 Integer-overflow
Change-Id: Ia3cace5df71ec9dbf17d06f3c21b65a87025bfd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129172
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 97b0a4752d17..f3b5b6e4e958 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -3020,7 +3020,15 @@ bool SwWW8ImplReader::ReadPlainChars(WW8_CP& rPos,
sal_Int32 nEnd, sal_Int32 nCp
if (nRequestedStrLen <= 0)
return true;
-sal_Int32 nRequestedPos = m_xSBase->WW8Cp2Fc(nCpOfs+rPos, _bIsUnicode);
+WW8_CP nCp;
+const bool bFail = o3tl::checked_add(nCpOfs, rPos, nCp);
+if (bFail)
+{
+rPos+=nRequestedStrLen;
+return true;
+}
+
+sal_Int32 nRequestedPos = m_xSBase->WW8Cp2Fc(nCp, _bIsUnicode);
bool bValidPos = checkSeek(*m_pStrm, nRequestedPos);
OSL_ENSURE(bValidPos, "Document claimed to have more text than available");
if (!bValidPos)
[Libreoffice-bugs] [Bug 147076] New: AutoFilter does not show special characters
https://bugs.documentfoundation.org/show_bug.cgi?id=147076
Bug ID: 147076
Summary: AutoFilter does not show special characters
Product: LibreOffice
Version: 7.2.5.2 release
Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: iea...@ielogical.com
Description:
A column of special characters, e.g. Wingdings, shows as all blank in the pick
list.
Steps to Reproduce:
1. Enter special characters in a column
2. Enable auto filter on the column
3. Activate pick list
Actual Results:
Selections are all blank
Expected Results:
Items should be shown
Reproducible: Always
User Profile Reset: No
OpenGL enabled: Yes
Additional Info:
Version: 7.2.5.2 (x64) / LibreOffice Community
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
{{Ya otts to update the Open GL checking page as the graphic don't match the
current Open GL exe}}
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146958] Inconsistent page count in properties dialogue and status line
https://bugs.documentfoundation.org/show_bug.cgi?id=146958 Albrecht Müller changed: What|Removed |Added Ever confirmed|1 |0 CC||albrecht.muel...@astrail.de Status|NEEDINFO|UNCONFIRMED --- Comment #2 from Albrecht Müller --- (In reply to Timur from comment #1) > Did you forget to include the document, or a link to existing attachment 123? In short: No. Long version: The tip of an iceberg may look minor but the whole thing was able to sink the Titanic. I uploaded the screenshot as I suspect that the innocent looking discrepancy in the page count may point to a deeper problem: Writer seems to use at least two different ways to calculate the total number of pages which sometimes produce different results. This may be the cause of a couple of strange effects related to pagination, including but not limited to Bug 98698. Interestingly this report contains attachment 169503 (erratic page count) which shows essentially the same effect I observe. My screenshot is based on a document containing my collection of notes that helps me to get along with LibreOffice problems I encountered. I don't intend to upload it for the following reasons: 1) I would have to check more than 1000 pages for personal information I do not want to disclose. 2) Same for content that might infringe copyrights. 3) Last but not least: I don't want to give away the result of hundreds of working hours for free. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - i18npool/inc
i18npool/inc/bullet.h | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
New commits:
commit 3db1a060a033a2f84bdf798bed3c7e2515a498ce
Author: Kevin Suo
AuthorDate: Thu Jan 27 10:28:10 2022 +0800
Commit: Adolfo Jayme Barrientos
CommitDate: Sun Jan 30 19:38:01 2022 +0100
Add CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY to numbring list
Previously we only supported CIRCLED NUMBER ONE through CIRCLED NUMBER
TWENTY.
Unicode already has CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY.
This improves Circled Numbering, especially for CJK.
E.g. ➀, ➁, ➂, ... ㉑, ㉒, ㉓, ... ㊽, ㊾, ㊿.
Change-Id: I7c4c851f03522fef9d44163da7450cf69aab3889
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129015
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 7e380a76e1f0faa90fdf8f0575053d4a1ca6e1de)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129069
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/i18npool/inc/bullet.h b/i18npool/inc/bullet.h
index 67ea0f7d2600..403d197d2c88 100644
--- a/i18npool/inc/bullet.h
+++ b/i18npool/inc/bullet.h
@@ -239,7 +239,37 @@ const sal_Unicode table_CircledNumber[] = {
0x2470, // CIRCLED NUMBER SEVENTEEN
0x2471, // CIRCLED NUMBER EIGHTEEN
0x2472, // CIRCLED NUMBER NINETEEN
-0x2473 // CIRCLED NUMBER TWENTY
+0x2473, // CIRCLED NUMBER TWENTY
+0x3251, // CIRCLED NUMBER TWENTY ONE
+0x3252, // CIRCLED NUMBER TWENTY TWO
+0x3253, // CIRCLED NUMBER TWENTY THREE
+0x3254, // CIRCLED NUMBER TWENTY FOUR
+0x3255, // CIRCLED NUMBER TWENTY FIVE
+0x3256, // CIRCLED NUMBER TWENTY SIX
+0x3257, // CIRCLED NUMBER TWENTY SEVEN
+0x3258, // CIRCLED NUMBER TWENTY EIGHT
+0x3259, // CIRCLED NUMBER TWENTY NINE
+0x325A, // CIRCLED NUMBER THIRTY
+0x325B, // CIRCLED NUMBER THIRTY ONE
+0x325C, // CIRCLED NUMBER THIRTY TWO
+0x325D, // CIRCLED NUMBER THIRTY THREE
+0x325E, // CIRCLED NUMBER THIRTY FOUR
+0x325F, // CIRCLED NUMBER THIRTY FIVE
+0x32B1, // CIRCLED NUMBER THIRTY SIX
+0x32B2, // CIRCLED NUMBER THIRTY SEVEN
+0x32B3, // CIRCLED NUMBER THIRTY EIGHT
+0x32B4, // CIRCLED NUMBER THIRTY NINE
+0x32B5, // CIRCLED NUMBER FORTY
+0x32B6, // CIRCLED NUMBER FORTY ONE
+0x32B7, // CIRCLED NUMBER FORTY TWO
+0x32B8, // CIRCLED NUMBER FORTY THREE
+0x32B9, // CIRCLED NUMBER FORTY FOUR
+0x32BA, // CIRCLED NUMBER FORTY FIVE
+0x32BB, // CIRCLED NUMBER FORTY SIX
+0x32BC, // CIRCLED NUMBER FORTY SEVEN
+0x32BD, // CIRCLED NUMBER FORTY EIGHT
+0x32BE, // CIRCLED NUMBER FORTY NINE
+0x32BF // CIRCLED NUMBER FIFTY
};
const sal_Unicode table_HangulJamo_ko[] = {
[Libreoffice-bugs] [Bug 146944] Crash in: lcl_Regist
https://bugs.documentfoundation.org/show_bug.cgi?id=146944 --- Comment #4 from Albrecht Müller --- I uploaded attachment 177914 that shows the "strange effect". But I was not able to use this document to create any crash. I did expect that as I assume that the crash reported here is independent from this particular document and occurs at random for reasons I don't know. That's why I let LibreOffice upload three crash reports. For the other two see bug 146845 and bug 146943. The crashes occurred in pretty different situations but showed a similar behaviour. First there is a "common" crash which does not produce a crash report. If you start LibreOffice after this kind of crashes it usually launches a recovery process. This process is intended to restore all open documents to in state they were when last saved automatically. According to the settings of my autosave option the last 10 minutes of work may get lost. What is different here is that the recovery process crashes or runs into an endless loop. LibreOffice proposes to send a crash report when the recovery process crashes or when you abort the process that shows the endless loop. Common symptoms are: At start LibreOffice usually shows a splash screen before it opens the first window. This splash screen appears and disappears in varying rates ranging from more than one cycle per second to one cycle every few seconds. This process may finish either by crashing or because you abort it. If you start LibreOffice again then the recovery process usually seems to work but you have to repair the user profile. I have couple of extensions that cease to work until the user profile is fixed. This said – here are the steps to reproduce the strange effect as I think it is interesting by itself: Open the attached document in some environment that does not allow to execute macros. Writer will report that the document contains macros, that it will not execute them and that therefore the document may not work as expected. There are no macros in the document and it seems to be empty. Copy the complete content of this document into the clipboard, e.g. by using Ctrl+A to select the content and Ctrl+C to copy it in the clipboard. Create some new, empty document and paste the content there. Save it. Reopen it: LibreOffice will warn you about macros in the document. How come? My explanation: This warning seems to be triggered by a field that executes a macro when clicked. This macro does not exist and the field is not visible as it does not contain any description. Once you know what's going on you can make the field visible by telling Writer to show field names (Ctrl+F9) and/or to show fields on a grey background (Ctrl+F8, shortcuts valid for German UI, don't know if they are the same in other languages). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146944] Crash in: lcl_Regist
https://bugs.documentfoundation.org/show_bug.cgi?id=146944 --- Comment #3 from Albrecht Müller --- Created attachment 177914 --> https://bugs.documentfoundation.org/attachment.cgi?id=177914=edit File that seems to be empty but lets Writer produce a macro warning -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/mysqlc/mysqlc_connection.cxx | 10 +-
connectivity/source/drivers/mysqlc/mysqlc_connection.hxx |9 -
2 files changed, 1 insertion(+), 18 deletions(-)
New commits:
commit e5c72fcf22e479871bc5a47f660bc56878db5626
Author: Julien Nabet
AuthorDate: Sun Jan 30 16:28:32 2022 +0100
Commit: Julien Nabet
CommitDate: Sun Jan 30 19:21:12 2022 +0100
Mysql/MariaDB: remove useless include+using + unused vars in
mysqlc_connection
+ replace one time used define MYSQLC_URI_PREFIX
Change-Id: Ia2ad5b2883f5f417bdbdcc7b39055bd5454c10f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129174
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx
b/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx
index 1c654c3e24ed..22e5c0ad0c41 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx
@@ -29,25 +29,17 @@
#include
-#include
#include
-#include
-
-#include
-#include
using namespace connectivity::mysqlc;
using namespace com::sun::star::uno;
using namespace com::sun::star::container;
-using namespace com::sun::star::lang;
using namespace com::sun::star::beans;
using namespace com::sun::star::sdbc;
using namespace com::sun::star::sdbcx;
using ::osl::MutexGuard;
-#define MYSQLC_URI_PREFIX "sdbc:mysqlc:"
-
namespace
{
void lcl_executeUpdate(MYSQL* pMySql, const OString& sql)
@@ -95,7 +87,7 @@ void OConnection::construct(const OUString& url, const
Sequence&
// parse url. Url has the following format:
// external server: sdbc:mysqlc:[hostname]:[port]/[dbname]
-if (url.startsWith(MYSQLC_URI_PREFIX))
+if (url.startsWith("sdbc:mysqlc:"))
{
nIndex = 12;
}
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx
b/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx
index 5280ecde78f1..d6040ec65b7f 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx
@@ -24,12 +24,9 @@
#include "mysqlc_types.hxx"
#include
-#include
#include
#include
-#include
#include
-#include
#include
#include
#include
@@ -39,8 +36,6 @@
#include
#include
-#include
-#include
#include
#include
@@ -59,10 +54,6 @@ class ODatabaseMetaData;
namespace mysqlc
{
-using ::com::sun::star::sdbc::SQLException;
-using ::com::sun::star::sdbc::SQLWarning;
-using ::com::sun::star::uno::RuntimeException;
-
typedef ::cppu::WeakComponentImplHelper
OMetaConnection_BASE;
[Libreoffice-bugs] [Bug 147072] Selecting new dictionary - try to add czech language via search online cause crush
https://bugs.documentfoundation.org/show_bug.cgi?id=147072 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- On pc Windows 10 with LO 7.2.4, I don't reproduce this. Could you give a try to 7.1.8 or even more recent 7.2.5 ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 94929] Selection stays current location even after selecting or modifying a cell outside selection
https://bugs.documentfoundation.org/show_bug.cgi?id=94929 --- Comment #15 from B.J. Herbison --- Thank you for your help, I now have an updated version. This bug is still present in: Version: 7.2.5.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.2.5-0ubuntu0.21.10.1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: wizards/source
wizards/source/scriptforge/SF_Dictionary.xba |2
wizards/source/scriptforge/SF_FileSystem.xba |2
wizards/source/scriptforge/SF_PythonHelper.xba| 37 +
wizards/source/scriptforge/SF_Services.xba|2
wizards/source/scriptforge/SF_Session.xba | 60 ++
wizards/source/scriptforge/SF_Utils.xba |2
wizards/source/scriptforge/_CodingConventions.xba |2
wizards/source/scriptforge/python/scriptforge.py | 22 +++-
wizards/source/sfdocuments/SF_Base.xba|6 +-
wizards/source/sfdocuments/SF_Calc.xba|6 +-
wizards/source/sfdocuments/SF_Document.xba| 43 ---
wizards/source/sfdocuments/SF_Form.xba|2
wizards/source/sfdocuments/SF_FormControl.xba |2
wizards/source/sfdocuments/SF_Writer.xba |6 +-
14 files changed, 170 insertions(+), 24 deletions(-)
New commits:
commit 9688e4970eed2b4bb4265df2a5781452a8ef5c52
Author: Jean-Pierre Ledure
AuthorDate: Sun Jan 30 17:19:31 2022 +0100
Commit: Jean-Pierre Ledure
CommitDate: Sun Jan 30 18:26:36 2022 +0100
ScriptForge - (SF_Session, SF_Document) add arguments to RunCommand()
Next wiki page
https://wiki.documentfoundation.org/Development/DispatchCommands
facilitates the use of commands with the
DispatchHelper service, including with arguments
This commit
- adds the RunCommand() method in the Session service
- extends the scope of existing RunCommand() methods
for the Document, Base, Calc and Writer services
with the addition of command arguments
Syntax by examples:
(Basic)
session.RunCommand("BasicIDEAppear", _
"Document", "LibreOffice Macros & Dialogs", _
"LibName", "ScriptForge", _
"Name", "SF_Session", _
"Line", 100)
(Python) (1)
session.RunCommand("BasicIDEAppear",
"Document", "LibreOffice Macros & Dialogs",
"LibName", "ScriptForge",
"Name", "SF_Session",
"Line", 100)
(Python) (2)
session.RunCommand("BasicIDEAppear",
Document = "LibreOffice Macros & Dialogs",
LibName = "ScriptForge",
Name = "SF_Session",
Line = 100)
Change-Id: I60cd5eb1ed0a057420215ce7aebe92b2aafabd53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129175
Tested-by: Jean-Pierre Ledure
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure
diff --git a/wizards/source/scriptforge/SF_Dictionary.xba
b/wizards/source/scriptforge/SF_Dictionary.xba
index fc92e24dd2ad..367fc47553d8 100644
--- a/wizards/source/scriptforge/SF_Dictionary.xba
+++ b/wizards/source/scriptforge/SF_Dictionary.xba
@@ -952,4 +952,4 @@ Const cstSeparator = ,
End Function ScriptForge.SF_Dictionary._Repr
REM END OF
SCRIPTFORGE.SF_DICTIONARY
-
+
\ No newline at end of file
diff --git a/wizards/source/scriptforge/SF_FileSystem.xba
b/wizards/source/scriptforge/SF_FileSystem.xba
index 3f38d141e5fd..d71937d6e64a 100644
--- a/wizards/source/scriptforge/SF_FileSystem.xba
+++ b/wizards/source/scriptforge/SF_FileSystem.xba
@@ -2085,4 +2085,4 @@ Dim sFolder As String Folder
End Function ScriptForge.SF_FileSystem._SFInstallFolder
REM END OF
SCRIPTFORGE.SF_FileSystem
-
+
\ No newline at end of file
diff --git a/wizards/source/scriptforge/SF_PythonHelper.xba
b/wizards/source/scriptforge/SF_PythonHelper.xba
index 5b919ba5abe1..442a4bd1b856 100644
--- a/wizards/source/scriptforge/SF_PythonHelper.xba
+++ b/wizards/source/scriptforge/SF_PythonHelper.xba
@@ -795,6 +795,10 @@ Try:
Methods in class modules are invoked with
CallByName
ElseIf bBasicClass And ((CallType And vbMethod) =
vbMethod) Then
Select Case UBound(vArgs)
+ Dirty alternatives to process
usual and ParamArray cases
+ But, up to ... how many ?
+ - The
OFFSETADDRESSERROR has 12 arguments
+ - The
.uno:DataSort command may have 14 property name-value pairs
Case -1 : vReturn =
CallByName(vBasicObject, Script, vbMethod)
Case 0 : vReturn =
CallByName(vBasicObject, Script, vbMethod, vArgs(0))
Case 1 : vReturn =
CallByName(vBasicObject, Script, vbMethod, vArgs(0), vArgs(1))
@@ -804,6 +808,37 @@ Try:
Case 5 : vReturn =
CallByName(vBasicObject, Script, vbMethod, vArgs(0), vArgs(1), vArgs(2),
vArgs(3), vArgs(4), vArgs(5))
Case 6 : vReturn =
CallByName(vBasicObject, Script,
[Libreoffice-bugs] [Bug 146830] Vertical shift of a single line after making edit, scrolling down & back making an edit
https://bugs.documentfoundation.org/show_bug.cgi?id=146830 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Severity|normal |trivial --- Comment #4 from Dieter --- I could only reproduce it once. Perhaps it depends on zoom-level? Tried different ones, but couldn't reproduce. Can't remember zoom-level of successful test. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147075] New: Window goes to 1x2 pixel size when moving
https://bugs.documentfoundation.org/show_bug.cgi?id=147075 Bug ID: 147075 Summary: Window goes to 1x2 pixel size when moving Product: LibreOffice Version: 7.3.0.0.alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: michael.vanderf...@gmail.com Description: After opening a csv file. The calc Window goes to 1x2 pixel size when moved. Steps to Reproduce: 1. Open csv file maximized. 2. Move window 3. Try to find it Actual Results: 1. Open csv file maximized. 2. Move window 3. Try to find it Expected Results: Window goes to a default size that does not disappear Reproducible: Always User Profile Reset: Yes Additional Info: Window goes to a default size -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: o3tl/IwyuFilter_o3tl.yaml o3tl/qa oox/inc oox/IwyuFilter_oox.yaml oox/source opencl/inc opencl/source package/inc package/IwyuFilter_package.yaml package/source pyuno/I
o3tl/IwyuFilter_o3tl.yaml |2 + o3tl/qa/cow_wrapper_clients.hxx |2 - o3tl/qa/test-enumarray.cxx |2 - o3tl/qa/test-lru_map.cxx|1 o3tl/qa/test-string_view.cxx|2 - o3tl/qa/test-vector_pool.cxx|1 oox/IwyuFilter_oox.yaml |9 oox/inc/drawingml/chart/datasourcecontext.hxx |1 oox/inc/drawingml/textliststyle.hxx |1 oox/source/core/fragmenthandler2.cxx|1 oox/source/docprop/ooxmldocpropimport.cxx |1 oox/source/drawingml/chart/seriesconverter.cxx |1 oox/source/drawingml/chart/titleconverter.cxx |1 oox/source/drawingml/chart/typegroupconverter.cxx |1 oox/source/drawingml/drawingmltypes.cxx |1 oox/source/drawingml/lineproperties.cxx |1 oox/source/drawingml/shape.cxx |7 +-- oox/source/drawingml/table/tableproperties.cxx |2 - oox/source/drawingml/textcharacterpropertiescontext.cxx |1 oox/source/drawingml/textparagraphpropertiescontext.cxx |2 - oox/source/export/chartexport.cxx |1 oox/source/export/drawingml.cxx |2 - oox/source/export/shapes.cxx|2 - oox/source/helper/binarystreambase.cxx |1 oox/source/helper/graphichelper.cxx |5 -- oox/source/ppt/pptshape.cxx |1 oox/source/ppt/presPropsfragmenthandler.cxx |1 oox/source/ppt/slidetransition.cxx |1 oox/source/shape/ShapeContextHandler.cxx|2 - oox/source/vml/vmlformatting.cxx|1 oox/source/vml/vmlshape.cxx |2 - opencl/inc/opencl_device.hxx|2 - opencl/source/openclconfig.cxx |2 - package/IwyuFilter_package.yaml | 24 package/inc/ByteChucker.hxx |5 -- package/inc/ByteGrabber.hxx |5 -- package/inc/CRC32.hxx |2 - package/inc/PackageConstants.hxx|1 package/inc/ThreadedDeflater.hxx|2 - package/inc/ZipFile.hxx |6 --- package/inc/ZipPackage.hxx |3 - package/inc/ZipPackageEntry.hxx |1 package/inc/ZipPackageStream.hxx|1 package/inc/zipfileaccess.hxx |4 -- package/source/manifest/ManifestDefines.hxx |2 - package/source/manifest/ManifestExport.cxx |3 - package/source/manifest/ManifestExport.hxx |1 package/source/manifest/ManifestImport.cxx |2 - package/source/manifest/ManifestImport.hxx |3 - package/source/manifest/ManifestReader.cxx |4 -- package/source/manifest/ManifestReader.hxx |1 package/source/manifest/ManifestWriter.cxx |5 -- package/source/manifest/ManifestWriter.hxx |1 package/source/xstor/ocompinstream.cxx |1 package/source/xstor/ocompinstream.hxx |2 - package/source/xstor/owriteablestream.cxx |3 - package/source/xstor/owriteablestream.hxx |3 - package/source/xstor/selfterminatefilestream.hxx|1 package/source/xstor/switchpersistencestream.hxx|5 -- package/source/xstor/xfactory.cxx |2 - package/source/xstor/xfactory.hxx |1 package/source/xstor/xstorage.cxx |3 - package/source/xstor/xstorage.hxx |5 -- package/source/zipapi/ByteChucker.cxx |2 - package/source/zipapi/ByteGrabber.cxx |2 + package/source/zipapi/MemoryByteGrabber.hxx |4 -- package/source/zipapi/XBufferedThreadedStream.cxx |3 - package/source/zipapi/XBufferedThreadedStream.hxx |7 ++- package/source/zipapi/XUnbufferedStream.cxx |2 - package/source/zipapi/XUnbufferedStream.hxx |2 - package/source/zipapi/ZipFile.cxx | 13 +++---
[Libreoffice-commits] core.git: chart2/source solenv/clang-format
chart2/source/inc/CloneHelper.hxx | 11 +-
chart2/source/inc/ModifyListenerHelper.hxx| 22 +
chart2/source/inc/RegressionCurveModel.hxx|6 +++--
chart2/source/model/inc/DataSeries.hxx|3 +-
chart2/source/model/main/DataSeries.cxx | 27 ++
chart2/source/tools/RegressionCurveHelper.cxx |2 -
chart2/source/tools/RegressionCurveModel.cxx |2 -
solenv/clang-format/excludelist |2 -
8 files changed, 60 insertions(+), 15 deletions(-)
New commits:
commit 026e2f437e969d75209ed05211e7f02349035b98
Author: Noel Grandin
AuthorDate: Sun Jan 30 08:34:22 2022 +0200
Commit: Noel Grandin
CommitDate: Sun Jan 30 16:02:18 2022 +0100
use more concrete types in chart2, RegressionCurveModel
Change-Id: Ib4a5198f425577307ba437c73c61408b88d83dc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129160
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/CloneHelper.hxx
b/chart2/source/inc/CloneHelper.hxx
index d9771a2681f2..c0896efb5c7b 100644
--- a/chart2/source/inc/CloneHelper.hxx
+++ b/chart2/source/inc/CloneHelper.hxx
@@ -19,7 +19,7 @@
#pragma once
#include
-
+#include
#include
#include
#include
@@ -54,6 +54,15 @@ template< class Interface >
CreateRefClone< Interface >());
}
+template< class T >
+void CloneRefVector(
+const std::vector< rtl::Reference< T > > & rSource,
+std::vector< rtl::Reference< T > > & rDestination )
+{
+for (const auto & rSourceItem : rSource)
+
rDestination.push_back(static_cast(rSourceItem->createClone().get()));
+}
+
/// clones a UNO-sequence of UNO-References
template< class Interface >
void CloneRefSequence(
diff --git a/chart2/source/inc/ModifyListenerHelper.hxx
b/chart2/source/inc/ModifyListenerHelper.hxx
index abee24032bae..de407f2ba137 100644
--- a/chart2/source/inc/ModifyListenerHelper.hxx
+++ b/chart2/source/inc/ModifyListenerHelper.hxx
@@ -176,6 +176,17 @@ void addListenerToAllElements(
impl::addListenerFunctor< typename
Container::value_type >( xListener ));
}
+template< class T >
+void addListenerToAllElements(
+const std::vector> & rContainer,
+const css::uno::Reference< css::util::XModifyListener > & xListener )
+{
+if( !xListener )
+return;
+for (auto const & i : rContainer)
+i->addModifyListener(xListener);
+}
+
template< class Container >
void addListenerToAllMapElements(
const Container & rContainer,
@@ -227,6 +238,17 @@ void removeListenerFromAllElements(
impl::removeListenerFunctor< typename
Container::value_type >( xListener ));
}
+template< class T >
+void removeListenerFromAllElements(
+const std::vector> & rContainer,
+const css::uno::Reference< css::util::XModifyListener > & xListener )
+{
+if( !xListener )
+return;
+for (auto const & i : rContainer)
+i->removeModifyListener(xListener);
+}
+
template< class Container >
void removeListenerFromAllMapElements(
const Container & rContainer,
diff --git a/chart2/source/tools/RegressionCurveModel.hxx
b/chart2/source/inc/RegressionCurveModel.hxx
similarity index 99%
rename from chart2/source/tools/RegressionCurveModel.hxx
rename to chart2/source/inc/RegressionCurveModel.hxx
index 73c2439f01e7..5c32ae5e6215 100644
--- a/chart2/source/tools/RegressionCurveModel.hxx
+++ b/chart2/source/inc/RegressionCurveModel.hxx
@@ -18,7 +18,7 @@
*/
#pragma once
-#include
+#include "OPropertySet.hxx"
#include
#include
@@ -29,7 +29,7 @@
#include
#include
#include
-#include
+#include "ModifyListenerHelper.hxx"
namespace chart
{
@@ -83,6 +83,7 @@ protected:
virtual css::uno::Reference< css::beans::XPropertySetInfo > SAL_CALL
getPropertySetInfo() override;
+public:
// XRegressionCurve
virtual css::uno::Reference< css::chart2::XRegressionCurveCalculator >
SAL_CALL getCalculator() override;
virtual css::uno::Reference< css::beans::XPropertySet > SAL_CALL
getEquationProperties() override;
@@ -98,6 +99,7 @@ protected:
virtual void SAL_CALL removeModifyListener(
const css::uno::Reference< css::util::XModifyListener >& aListener )
override;
+protected:
// XModifyListener
virtual void SAL_CALL modified(
const css::lang::EventObject& aEvent ) override;
diff --git a/chart2/source/model/inc/DataSeries.hxx
b/chart2/source/model/inc/DataSeries.hxx
index eae00d7da153..a7a91325a605 100644
--- a/chart2/source/model/inc/DataSeries.hxx
+++ b/chart2/source/model/inc/DataSeries.hxx
@@ -42,6 +42,7 @@ namespace com::sun::star::beans { class XPropertySet; }
namespace chart
{
+class RegressionCurveModel;
namespace impl
{
@@ -155,7 +156,7 @@ private:
tDataPointAttributeContainer m_aAttributedDataPoints;
typedef
-std::vector<
[Libreoffice-bugs] [Bug 131023] Preinstalled 3000px theme graphics not extending full width of UI elements, affects 2K, 4K, 5K and multi-head systems
https://bugs.documentfoundation.org/show_bug.cgi?id=131023 V Stuart Foote changed: What|Removed |Added CC||noh.spam.j...@gmail.com --- Comment #16 from V Stuart Foote --- *** Bug 147060 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147060] Toolbar background colour on a 4k screen
https://bugs.documentfoundation.org/show_bug.cgi?id=147060 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #2 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 131023 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147074] Calc crashes on sorting filtered column or saving as xls or xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=147074 tmjw2...@gmail.com changed: What|Removed |Added CC||tmjw2...@gmail.com --- Comment #1 from tmjw2...@gmail.com --- Created attachment 177913 --> https://bugs.documentfoundation.org/attachment.cgi?id=177913=edit Issue with this file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147074] New: Calc crashes on sorting filtered column or saving as xls or xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=147074 Bug ID: 147074 Summary: Calc crashes on sorting filtered column or saving as xls or xlsx Product: LibreOffice Version: 7.2.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tmjw2...@gmail.com Description: When I open the attached file and try to sort the column N, it crashes. Also when I try to save the file as xls or xlsx. Steps to Reproduce: 1.Open the ods file 2.Try to sort the N column (using the arrow on autofilter) 3.Save the file as xlsx Actual Results: Crach Expected Results: Sorting the column and saving the file Reproducible: Always User Profile Reset: No Additional Info: I also tried in failsafe mode, same result. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147071] Please automatically insert the Right Single Quote character when a word has a missing first syllable
https://bugs.documentfoundation.org/show_bug.cgi?id=147071 V Stuart Foote changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #4 from V Stuart Foote --- A specialized use case that does not belong in autocorrection where the AutoCorrect dialog's Localized Options Single Quotes replacement logic is suitable to vast majority of use cases. IMHO -1, and => WF -- You are receiving this mail because: You are the assignee for the bug.
