[Libreoffice-bugs] [Bug 147759] New: When sizing a caption frame from the right, the left moves instead

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147759

Bug ID: 147759
   Summary: When sizing a caption frame from the right, the left
moves instead
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

I have an image inside a caption I added for it. I've set both of them to not
be auto-sized. There image's left edge is about flush with the caption frame's,
but on the right there's same empty space. I'm trying to resize the caption
frame, from the right, to fit the image.

After resizing the caption some of the way, with a mouse drag - when I release
the mouse, the frame has been resized from the left rather than the right, with
its right edge keeping the same position.

The frame is at the left edge of an RTL paragraph which wraps beside it.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: fb9270b238cba4f36e595c5d7f4d85f6f3f18e1c
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147758] New: LIBRE OFFICE UPDATE TO 7.2.5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147758

Bug ID: 147758
   Summary: LIBRE OFFICE UPDATE TO 7.2.5
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tinus...@gmail.com

Description:
If I select the option to update the web goes to .../donate/...
Unaible to update.


Steps to Reproduce:
1.On this link:
https://www.libreoffice.org/download/download/?lang=en-GB=7.2.5_campaign=update,
I click on LIBRE OFFICE 7.2.5 DOWNLOAD
2.The next screen is this:
https://www.libreoffice.org/donate/dl/win-x86_64/7.2.5/en-GB/LibreOffice_7.2.5_Win_x64.msi
3.There is no option to UPDATE!!!

Actual Results:
NO OPTION TO UPDATE


Expected Results:
IF I CLICK ON UPDATE THERE SHOULD BE MESSAGE ""DOWNLOADING""


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Check for Updates
Checks for available updates to your version of LibreOffice. If a newer version
is available, you can choose to download the update. After downloading, if you
have write permissions for the installation directory, you can install the
update.

Once the download starts, you see a progress bar and three buttons on the
dialogue box. You can pause and resume the download by clicking the Pause and
Resume buttons. Click Cancel to abort the download and delete the partly
downloaded file.

By default, downloads will be stored to your desktop. You can change the folder
where the downloaded file will be stored in Tools - Options - LibreOffice -
Online Update.

After the download is complete, you can click Install to start the installation
of the update. You will see a confirmation dialogue box, where you can choose
to close LibreOffice.

Note Icon 
Under some operating systems, it may be required to manually go to the download
folder, unzip the download file, and start the setup script.


After installation of the update you can delete the download file to save
space.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103370

Dieter  changed:

   What|Removed |Added

 Depends on||147472


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147472
[Bug 147472] CHAPTER NUMBERING: Unintentional dot added as before separator
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147472] CHAPTER NUMBERING: Unintentional dot added as before separator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147472

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|[Feature request/Suggestion |CHAPTER NUMBERING:
   |to change behavior] |Unintentional dot added as
   |Possibility to remove   |before separator
   |unintentional dot added |
   |into chapter numbering -->  |
   |.2.1.   |
 Blocks||103370
 Whiteboard| QA:needsComment|
   Keywords||bibisectRequest, regression
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW

--- Comment #10 from Dieter  ---
i confirm it with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c856f9bec12d98ed49f01578ded79f16ae7be051
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps to reproduce
1. open an new document and write a paragraph
2. Assign chapter level 2 to that paragraph with seperator after number (make
sure, that level 1 is empty)

Actual result:
Separator before and after number

Expected result:
Separator only after number

Additional informations
Always a dot before number 8although different charakter is behind number)

Also in
Version: 7.3.1.3 (x64) / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Doesn't happen in

Version: 7.0.6.2 (x64)
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103370
[Bug 103370] [META] Outline/Chapter numbering bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147757] Inserting a caption creates a frame not corresponding to image dimensions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147757

--- Comment #2 from Eyal Rozenberg  ---
Created attachment 178649
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178649=edit
Screenshot of invalid result of adding the caption

Screenshot of the state of the document after following the reproduction
instructions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147757] Inserting a caption creates a frame not corresponding to image dimensions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147757

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 178648
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178648=edit
Document for reproducing the bug

To reproduce:

1. Open the attached document, 147757.odt
2. Select the image.
3. On the menus, choose Insert | Caption .
4. Don't change any settings, just press Ok.

Expected: Frame/rectangle covers entire image and a bit more.
Actual: Frame/rectangle fails to cover the top of the image, text now flows
under the image where it didn't use to.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147757] New: Inserting a caption creates a frame not corresponding to image dimensions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147757

Bug ID: 147757
   Summary: Inserting a caption creates a frame not corresponding
to image dimensions
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

If I have a floating image at the side of a paragraph of text, and I add a
(no-category) caption - instead of the caption extending the area from which
the image excludes the surrounding text, it extends it horizontally, and
vertically at the bottom, but detracts from it at the top somehow, causing text
to flow under the new frame/rectangle created by adding the caption.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: fb9270b238cba4f36e595c5d7f4d85f6f3f18e1c
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmlsecurity/source

[Caolán McNamara (via logerrit)]

 xmlsecurity/source/component/documentdigitalsignatures.cxx |   14 ++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 65442205b5b274ad309308162f150f8d41648f72
Author: Caolán McNamara 
AuthorDate: Thu Mar 3 14:22:37 2022 +
Commit: Miklos Vajna 
CommitDate: Fri Mar 4 08:31:12 2022 +0100

compare authors using Thumbprint

Change-Id: I338f58eb07cbf0a3d13a7dafdaddac09252a8546
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130929
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/xmlsecurity/source/component/documentdigitalsignatures.cxx 
b/xmlsecurity/source/component/documentdigitalsignatures.cxx
index 9f20a58fd23f..0dbf0877ad1e 100644
--- a/xmlsecurity/source/component/documentdigitalsignatures.cxx
+++ b/xmlsecurity/source/component/documentdigitalsignatures.cxx
@@ -673,9 +673,17 @@ sal_Bool DocumentDigitalSignatures::isAuthorTrusted(
 std::vector< SvtSecurityOptions::Certificate > aTrustedAuthors = 
SvtSecurityOptions::GetTrustedAuthors();
 
 return std::any_of(aTrustedAuthors.begin(), aTrustedAuthors.end(),
-[, ](const SvtSecurityOptions::Certificate& 
rAuthor) {
-return xmlsecurity::EqualDistinguishedNames(rAuthor.SubjectName, 
xAuthor->getIssuerName(), xmlsecurity::NOCOMPAT)
-&& ( rAuthor.SerialNumber == sSerialNum );
+[this, , ](const SvtSecurityOptions::Certificate& 
rAuthor) {
+if (!xmlsecurity::EqualDistinguishedNames(rAuthor.SubjectName, 
xAuthor->getIssuerName(), xmlsecurity::NOCOMPAT))
+return false;
+if (rAuthor.SerialNumber != sSerialNum)
+return false;
+
+DocumentSignatureManager aSignatureManager(mxCtx, {});
+if (!aSignatureManager.init())
+return false;
+uno::Reference xCert = 
aSignatureManager.getSecurityEnvironment()->createCertificateFromAscii(rAuthor.RawData);
+return xCert->getSHA1Thumbprint() == xAuthor->getSHA1Thumbprint();
 });
 }
 

[Libreoffice-bugs] [Bug 146208] FILEEDIT DOCX Crash at Redo of accepting table row deletions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146208

--- Comment #6 from MichaelWilliams  ---
Pretty helpful information to all and we were able to grab the bugs solutions.
I hope after getting the bugs solution and discussion we can improve our
knowledge. Really admire the discussion and that would be helpful for someone.
Continue to share more on
https://www.resumehelpservices.com/brooklyn-resume-studio-review/ such related
material must visit other pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144585] button popups don't open with KF5 VCL on Wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144585

Michael Weghorn  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #20 from Michael Weghorn  ---
(In reply to GeneC from comment #16)
> Xcb is a not great workaround;  at least for me on 4k monitor, it looks
> pretty icky. Fonts render quite poorly.

Another option is to use the more mature gtk3 VCL plugin by setting environment
variable SAL_USE_VCLPLUGIN=gtk3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - oox/inc oox/source sd/qa

[Gülşah Köse (via logerrit)]

 oox/inc/drawingml/table/tablecell.hxx  |2 
 oox/source/drawingml/table/tablecell.cxx   |  112 +++--
 oox/source/drawingml/table/tableproperties.cxx |   16 ++-
 sd/qa/unit/data/pptx/bnc480256-2.pptx  |binary
 sd/qa/unit/data/pptx/tdf135843_insideH.pptx|binary
 sd/qa/unit/import-tests.cxx|2 
 sd/qa/unit/layout-tests.cxx|   38 
 7 files changed, 158 insertions(+), 12 deletions(-)

New commits:
commit 90f19b66d81b0a4958cacc40d2be0516f281d702
Author: Gülşah Köse 
AuthorDate: Tue Feb 1 16:03:14 2022 +0300
Commit: Gülşah Köse 
CommitDate: Fri Mar 4 08:28:14 2022 +0100

tdf#135843 Implement inside horizontal vertical borders.

wholeTbl as TableStylePart should be handled in different way. Before
left border of the whole table was handling like all cells left
border but it should be left border of the first column.

insideV and and insideH properties are imported but never handled. I
added the inside vertical and horizontal borders handling.

Change-Id: I5aea5cbefc746db637eac6c1438fa70a7d741bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128971
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit 3faf005a367cbd28077403bf93810bbaf4805851)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130860

diff --git a/oox/inc/drawingml/table/tablecell.hxx 
b/oox/inc/drawingml/table/tablecell.hxx
index d6e91da042f7..988b0d057a13 100644
--- a/oox/inc/drawingml/table/tablecell.hxx
+++ b/oox/inc/drawingml/table/tablecell.hxx
@@ -82,6 +82,8 @@ private:
 oox::drawingml::LineProperties  maLinePropertiesRight;
 oox::drawingml::LineProperties  maLinePropertiesTop;
 oox::drawingml::LineProperties  maLinePropertiesBottom;
+oox::drawingml::LineProperties  maLinePropertiesInsideH;
+oox::drawingml::LineProperties  maLinePropertiesInsideV;
 oox::drawingml::LineProperties  maLinePropertiesTopLeftToBottomRight;
 oox::drawingml::LineProperties  maLinePropertiesBottomLeftToTopRight;
 
diff --git a/oox/source/drawingml/table/tablecell.cxx 
b/oox/source/drawingml/table/tablecell.cxx
index e5ab3372d42e..15ab06303e3b 100644
--- a/oox/source/drawingml/table/tablecell.cxx
+++ b/oox/source/drawingml/table/tablecell.cxx
@@ -81,6 +81,14 @@ static void applyLineAttributes( const 
::oox::core::XmlFilterBase& rFilterBase,
 aBorderLine.LineWidth = static_cast< sal_Int16 >( GetCoordinate( 
rLineProperties.moLineWidth.get( 0 ) ) / 2 );
 aBorderLine.LineDistance = 0;
 }
+else
+{
+aBorderLine.Color = sal_Int32( COL_AUTO );
+aBorderLine.OuterLineWidth = static_cast< sal_Int16 >( GetCoordinate( 
rLineProperties.moLineWidth.get( 0 ) ) / 4 );
+aBorderLine.InnerLineWidth = static_cast< sal_Int16 >( GetCoordinate( 
rLineProperties.moLineWidth.get( 0 ) ) / 4 );
+aBorderLine.LineWidth = 12700;
+aBorderLine.LineDistance = 0;
+}
 
 if ( rLineProperties.moPresetDash.has() )
 {
@@ -150,9 +158,16 @@ static void applyTableStylePart( const 
::oox::core::XmlFilterBase& rFilterBase,
   oox::drawingml::LineProperties& rRightBorder,
   oox::drawingml::LineProperties& rTopBorder,
   oox::drawingml::LineProperties& rBottomBorder,
+  oox::drawingml::LineProperties& rInsideHBorder,
+  oox::drawingml::LineProperties& rInsideVBorder,
   oox::drawingml::LineProperties& 
rTopLeftToBottomRightBorder,
   oox::drawingml::LineProperties& 
rBottomLeftToTopRightBorder,
-  TableStylePart& rTableStylePart )
+  TableStylePart& rTableStylePart,
+  bool bIsWholeTable = false,
+  sal_Int32 nCol = 0,
+  sal_Int32 nMaxCol = 0,
+  sal_Int32 nRow = 0,
+  sal_Int32 nMaxRow = 0)
 {
 ::oox::drawingml::FillPropertiesPtr& rPartFillPropertiesPtr( 
rTableStylePart.getFillProperties() );
 if ( rPartFillPropertiesPtr )
@@ -169,12 +184,35 @@ static void applyTableStylePart( const 
::oox::core::XmlFilterBase& rFilterBase,
 }
 }
 
-applyBorder( rFilterBase, rTableStylePart, XML_left, rLeftBorder );
-applyBorder( rFilterBase, rTableStylePart, XML_right, rRightBorder );
-applyBorder( rFilterBase, rTableStylePart, XML_top, rTopBorder );
-applyBorder( rFilterBase, rTableStylePart, XML_bottom, rBottomBorder );
-applyBorder( rFilterBase, rTableStylePart, XML_tl2br, 
rTopLeftToBottomRightBorder );
-applyBorder( rFilterBase, rTableStylePart, XML_tr2bl, 
rBottomLeftToTopRightBorder );
+// Left, right, top and bottom side of the whole table should be mean 
outer frame of the whole table.
+// Without this check it means left top right and 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - oox/source

[Gülşah Köse (via logerrit)]

 oox/source/drawingml/table/predefined-table-styles.cxx |  378 +++--
 1 file changed, 176 insertions(+), 202 deletions(-)

New commits:
commit 96694528f3f4212070c90e8d61366bbbe35e991a
Author: Gülşah Köse 
AuthorDate: Mon Jan 31 18:34:30 2022 +0300
Commit: Gülşah Köse 
CommitDate: Fri Mar 4 08:27:39 2022 +0100

tdf#135843 Do not export unused border lines.

Setting as XML_solidFill all borders caused wrong exported borders.
All table parts aren't used for all table styles. We should set borderline
if only they had used.

Change-Id: I35b247f520c7d7862599ade2c6fdfb0d7efcd5c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129227
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit 48575b3eb856406d9de406cb1d2de23866b0178f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130859

diff --git a/oox/source/drawingml/table/predefined-table-styles.cxx 
b/oox/source/drawingml/table/predefined-table-styles.cxx
index 75435eb40303..273cf7d68a5a 100644
--- a/oox/source/drawingml/table/predefined-table-styles.cxx
+++ b/oox/source/drawingml/table/predefined-table-styles.cxx
@@ -202,6 +202,21 @@ static std::map tokens = { { "", 
XML_dk1 },
 { "Accent5", XML_accent5 },
 { "Accent6", XML_accent6 } };
 
+void setBorderLineType(oox::drawingml::LinePropertiesPtr& pLineProp, sal_Int32 
nToken)
+{
+pLineProp->maLineFill.moFillType.set(nToken);
+}
+
+void insertBorderLine(TableStylePart& aTableStylePart, sal_Int32 nToken,
+  oox::drawingml::LinePropertiesPtr pLineProp)
+{
+if (pLineProp->maLineFill.moFillType.has())
+{
+aTableStylePart.getLineBorders().insert(
+std::pair(nToken, 
pLineProp));
+}
+}
+
 std::unique_ptr CreateTableStyle(const OUString& styleId)
 {
 createStyleIdMap();
@@ -377,69 +392,6 @@ std::unique_ptr CreateTableStyle(const 
OUString& styleId)
 pBand2HFillProperties->moFillType.set(XML_solidFill);
 pBand2VFillProperties->moFillType.set(XML_solidFill);
 
-pWholeTblLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pWholeTblRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pWholeTblTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pWholeTblBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pWholeTblInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pWholeTblInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pFirstRowLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstRowRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstRowTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstRowBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstRowInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstRowInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pFirstColLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstColRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstColTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstColBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstColInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pFirstColInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pLastRowLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastRowRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastRowTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastRowBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastRowInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastRowInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pLastColLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastColRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastColTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastColBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastColInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pLastColInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pBand1HLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1HRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1HTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1HBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1HInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1HInsideVBorder->maLineFill.moFillType.set(XML_solidFill);
-
-pBand1VLeftBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1VRightBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1VTopBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1VBottomBorder->maLineFill.moFillType.set(XML_solidFill);
-pBand1VInsideHBorder->maLineFill.moFillType.set(XML_solidFill);
-

[Libreoffice-commits] core.git: hwpfilter/source

[Mike Kaganski (via logerrit)]

 hwpfilter/source/hcode.cxx |   58 +++--
 hwpfilter/source/hcode.h   |6 +++-
 hwpfilter/source/hwpreader.cxx |   12 ++--
 3 files changed, 20 insertions(+), 56 deletions(-)

New commits:
commit 176a9dfcce7c10d1c5fd3e091f10a1d57d309b24
Author: Mike Kaganski 
AuthorDate: Fri Mar 4 09:29:04 2022 +0300
Commit: Mike Kaganski 
CommitDate: Fri Mar 4 08:23:41 2022 +0100

Use comphelper::Base64 in hwpfilter

Change-Id: Id5c0a3d33ccda517473c8cbf96cb6e7b86ade57d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130945
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/hwpfilter/source/hcode.cxx b/hwpfilter/source/hcode.cxx
index e901fbbb3a58..c8c31a14085d 100644
--- a/hwpfilter/source/hcode.cxx
+++ b/hwpfilter/source/hcode.cxx
@@ -23,10 +23,17 @@
  * Hanja johap code => ks code => unicode
  * Special johap code => ks code => unicode
  */
+
+#include 
+
 #include "precompile.h"
+#include 
+#include 
 #include 
+#include 
 #include 
 #include 
+
 #include 
 #include 
 #include 
@@ -1385,54 +1392,11 @@ char *hcolor2str(uchar color, uchar shade, char *buf, 
bool bIsChar)
 }
 #endif
 
-char* base64_encode_string( const uchar *buf, unsigned int len )
+OUString base64_encode_string( const uchar *buf, unsigned int len )
 {
-char basis_64[] =
-"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
-char * out;
-int inPos  = 0;
-int outPos = 0;
-int c1, c2;
-unsigned int i;
-
-out=static_cast(malloc( (len*4/3)+8 ));
-
-/* Get three characters at a time and encode them. */
-for (i=0; i < len/3; ++i)
-{
-c1 = buf[inPos++] & 0xFF;
-c2 = buf[inPos++] & 0xFF;
-int c3 = buf[inPos++] & 0xFF;
-out[outPos++] = basis_64[(c1 & 0xFC) >> 2];
-out[outPos++] = basis_64[((c1 & 0x03) << 4) | ((c2 & 0xF0) >> 4)];
-out[outPos++] = basis_64[((c2 & 0x0F) << 2) | ((c3 & 0xC0) >> 6)];
-out[outPos++] = basis_64[c3 & 0x3F];
-}
-
-/* Encode the remaining one or two characters. */
-
-switch (len % 3)
-{
-case 0:
-break;
-case 1:
-c1 = buf[inPos] & 0xFF;
-out[outPos++] = basis_64[(c1 & 0xFC) >> 2];
-out[outPos++] = basis_64[((c1 & 0x03) << 4)];
-out[outPos++] = '=';
-out[outPos++] = '=';
-break;
-case 2:
-c1 = buf[inPos++] & 0xFF;
-c2 = buf[inPos] & 0xFF;
-out[outPos++] = basis_64[(c1 & 0xFC) >> 2];
-out[outPos++] = basis_64[((c1 & 0x03) << 4) | ((c2 & 0xF0) >> 4)];
-out[outPos++] = basis_64[((c2 & 0x0F) << 2)];
-out[outPos++] = '=';
-break;
-}
-out[outPos] = 0;
-return out;
+OStringBuffer aBuf;
+comphelper::Base64::encode(aBuf, 
comphelper::arrayToSequence(buf, len));
+return OUString::createFromAscii(aBuf);
 }
 
 double calcAngle(int x1, int y1, int x2, int y2)
diff --git a/hwpfilter/source/hcode.h b/hwpfilter/source/hcode.h
index 3fb2da528ef7..e560911b74c6 100644
--- a/hwpfilter/source/hcode.h
+++ b/hwpfilter/source/hcode.h
@@ -19,6 +19,10 @@
 
 #pragma once
 
+#include 
+
+#include 
+
 #include "hwplib.h"
 
 /**
@@ -66,7 +70,7 @@ DLLEXPORT char* Int2Str(int value, const char *format, char 
*buf);
  */
 DLLEXPORT char *hcolor2str(uchar color, uchar shade, char *buf, bool bIsChar = 
false);
 
-DLLEXPORT char *base64_encode_string( const uchar *buf, unsigned int len );
+DLLEXPORT OUString base64_encode_string( const uchar *buf, unsigned int len );
 DLLEXPORT double calcAngle(int x1, int y1, int x2, int y2);
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index a8272d82746e..205edf757c12 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -542,8 +542,7 @@ void HwpReader::makeDrawMiscStyle( HWPDrawingObject *hdo )
 if (emp)
 {
 rstartEl("office:binary-data", mxList);
-std::shared_ptr 
pStr(base64_encode_string(emp->data.get(), emp->size), Free());
-rchars(ascii(pStr.get()));
+rchars(base64_encode_string(emp->data.get(), emp->size));
 rendEl("office:binary-data");
 }
 rendEl( "draw:fill-image");
@@ -1723,8 +1722,7 @@ void HwpReader::makePageStyle()
  if( hwpinfo.back_info.type == 2 ){
  rstartEl("office:binary-data", mxList);
  mxList->clear();
- std::shared_ptr 
pStr(base64_encode_string(reinterpret_cast(hwpinfo.back_info.data.data()), hwpinfo.back_info.size ), Free());
- rchars(ascii(pStr.get()));
+ rchars(base64_encode_string(reinterpret_cast(hwpinfo.back_info.data.data()), hwpinfo.back_info.size));
  rendEl("office:binary-data");

[Libreoffice-commits] core.git: sc/inc sc/qa

[Luboš Luňák (via logerrit)]

 sc/inc/address.hxx   |5 +
 sc/inc/document.hxx  |2 ++
 sc/inc/sheetlimits.hxx   |   10 ++
 sc/qa/unit/ucalc_formula.cxx |4 +---
 4 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit fbb0b0a203f19d7a4dc64c47abd6d4b1d8c17340
Author: Luboš Luňák 
AuthorDate: Thu Mar 3 17:45:52 2022 +0100
Commit: Luboš Luňák 
CommitDate: Fri Mar 4 08:08:42 2022 +0100

provide MAXCOL/MAXROW also as strings

Primarily for use in tests.

Change-Id: Icb962cbdfa63a3b50115314e9afd46f3fa1a928a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130939
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/address.hxx b/sc/inc/address.hxx
index ce910f42cf49..18bd11049e92 100644
--- a/sc/inc/address.hxx
+++ b/sc/inc/address.hxx
@@ -81,6 +81,11 @@ const SCROW   MAXTILEDROW= 50;
 const SCTAB   MAXINITTAB = 1024;
 const SCTAB   MININITTAB = 1;
 
+inline constexpr OUStringLiteral MAXROW_STRING(u"1048575");
+inline constexpr OUStringLiteral MAXCOL_STRING(u"AMJ");
+inline constexpr OUStringLiteral MAXROW_JUMBO_STRING(u"16777215");
+inline constexpr OUStringLiteral MAXCOL_JUMBO_STRING(u"XFD");
+
 // Special values
 const SCTAB SC_TAB_APPEND = SCTAB_MAX;
 const SCTAB TABLEID_DOC   = SCTAB_MAX;  // entire document, e.g. protect
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 344e99e130f8..4e8eab09ed5d 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -879,6 +879,8 @@ public:
 SC_DLLPUBLIC SCROW MaxRow() const { return mxSheetLimits->mnMaxRow; }
 SC_DLLPUBLIC SCCOL GetMaxColCount() const { return 
mxSheetLimits->GetMaxColCount(); }
 SC_DLLPUBLIC SCROW GetMaxRowCount() const { return 
mxSheetLimits->GetMaxRowCount(); }
+SC_DLLPUBLIC OUString MaxRowAsString() const { return 
mxSheetLimits->MaxRowAsString(); }
+SC_DLLPUBLIC OUString MaxColAsString() const { return 
mxSheetLimits->MaxColAsString(); }
 ScSheetLimits& GetSheetLimits() const { return *mxSheetLimits; }
 [[nodiscard]] bool ValidCol(SCCOL nCol) const { return ::ValidCol(nCol, 
mxSheetLimits->mnMaxCol); }
 [[nodiscard]] bool ValidRow(SCROW nRow) const { return ::ValidRow(nRow, 
mxSheetLimits->mnMaxRow); }
diff --git a/sc/inc/sheetlimits.hxx b/sc/inc/sheetlimits.hxx
index c8dbc1165216..cbc017c9d10e 100644
--- a/sc/inc/sheetlimits.hxx
+++ b/sc/inc/sheetlimits.hxx
@@ -65,6 +65,16 @@ struct ScSheetLimits final : public 
salhelper::SimpleReferenceObject
 SCROW GetMaxRowCount() const { return mnMaxRow + 1; }
 // equivalent of MAXCOLCOUNT in address.hxx
 SCCOL GetMaxColCount() const { return mnMaxCol + 1; }
+// max row number as string
+OUString MaxRowAsString() const
+{
+return mnMaxRow == MAXROW ? OUString(MAXROW_STRING) : 
OUString(MAXROW_JUMBO_STRING);
+}
+// mac col as string ("AMJ" or "XFD")
+OUString MaxColAsString() const
+{
+return mnMaxCol == MAXCOL ? OUString(MAXCOL_STRING) : 
OUString(MAXCOL_JUMBO_STRING);
+}
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 4d31fbf9ea0f..a1790bb930c9 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -2501,9 +2501,7 @@ void TestFormula::testFormulaRefUpdateRange()
 // C3 with sticky reference including last column.
 m_pDoc->SetString( 2,2,1, "=SUM(23:23)");
 // C4 with reference to last column.
-CPPUNIT_ASSERT_MESSAGE("m_pDoc->MaxCol() changed, adapt unit test.",
-m_pDoc->MaxCol() == 1023 || m_pDoc->MaxCol() == 16383);
-m_pDoc->SetString( 2,3,1, m_pDoc->MaxCol() == 1023 ? "=SUM(AMJ22:AMJ23)" : 
"=SUM(XFD22:XFD23)");
+m_pDoc->SetString( 2,3,1, "=SUM(" + m_pDoc->MaxColAsString() + "22:" + 
m_pDoc->MaxColAsString() + "23)");
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong result in C3.", 3.0, 
m_pDoc->GetValue(2,2,1));
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong result in C4.", 2.0, 
m_pDoc->GetValue(2,3,1));
 // Delete last column.

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/core/text/text.cxx|   18 ++
 sw/source/core/text/porlay.cxx  |   12 +---
 sw/source/core/text/xmldump.cxx |   18 +-
 3 files changed, 28 insertions(+), 20 deletions(-)

New commits:
commit 556689c485c2df35abd6a0cdff76329178af17bf
Author: Miklos Vajna 
AuthorDate: Thu Mar 3 20:13:48 2022 +0100
Commit: Miklos Vajna 
CommitDate: Fri Mar 4 08:08:02 2022 +0100

sw layout xml dump: improve handling of number portions at the start

It's quite tricky to visit each portion exactly once. The "table" of
portions is an SwParaPortion, a row is an SwLineLayout, which contains
SwLinePortion instances. But SwLineLayout inherits from SwTextPortion
(which is a LinePortion), so depending on if e.g. the paragraph starts
with a numbering portion (not a text portion) or with plain text (is a
text portion), the first portion in a line is the line layout itself or
not.

The old behavior was to explicitly dump the first portion of the line as
an SwLinePortion, but this way e.g. the expand string of leading number
portions were not visible.

Change this to moving all the loops to SwFrame::dumpAsXml(), and then
not recursing in para portions / line layouts, this allows reaching e.g.
SwFieldPortion::dumpAsXml() for leading number portions.

Change-Id: I813fdece0e4d6b7116112e15ec866046862beeeb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130941
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index caeb70e4a89d..5741fe656a81 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -186,15 +186,17 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, 
testChineseAutoFirstLineIndent)
 xmlDocUniquePtr pXmlDoc = parseLayoutDump();
 
 // Get the line width of the first line for the 1st paragraph.
-sal_Int32 nFirstLineWidth
-= getXPath(pXmlDoc, 
"//body/txt[1]/SwParaPortion[1]/SwLineLayout[1]/SwLinePortion[1]",
-   "width")
-  .toInt32();
+sal_Int32 nFirstLineWidth = getXPath(pXmlDoc,
+ 
"//body/txt[1]/SwParaPortion/SwLineLayout[1]/"
+ 
"SwParaPortion/SwLineLayout/SwLinePortion",
+ "width")
+.toInt32();
 // Get the line width of the first line for the 2nd paragraph.
-sal_Int32 nSecondLineWidth
-= getXPath(pXmlDoc, 
"//body/txt[2]/SwParaPortion[1]/SwLineLayout[1]/SwLinePortion[1]",
-   "width")
-  .toInt32();
+sal_Int32 nSecondLineWidth = getXPath(pXmlDoc,
+  
"//body/txt[2]/SwParaPortion/SwLineLayout[1]/"
+  
"SwParaPortion/SwLineLayout/SwLinePortion",
+  "width")
+ .toInt32();
 
 // Tdf#129448: the changing of line-height should not affect the auto 
first line indent.
 // As a result, the first line width of the two paragraphs should be the 
same.
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 8212fca02f6a..1be31ad972bd 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -751,13 +751,7 @@ void SwLineLayout::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 (void)xmlTextWriterStartElement(pWriter, BAD_CAST("SwLineLayout"));
 (void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p", 
this);
 
-const SwLinePortion* pFirstPor = GetFirstPortion();
-pFirstPor->SwLinePortion::dumpAsXml(pWriter);
-for (const SwLinePortion* pPor = pFirstPor->GetNextPortion(); pPor;
- pPor = pPor->GetNextPortion())
-{
-pPor->dumpAsXml(pWriter);
-}
+SwTextPortion::dumpAsXml(pWriter);
 
 (void)xmlTextWriterEndElement(pWriter);
 }
@@ -2550,10 +2544,6 @@ void SwParaPortion::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 (void)xmlTextWriterWriteFormatAttribute(pWriter, BAD_CAST("ptr"), "%p", 
this);
 
 SwLineLayout::dumpAsXml(pWriter);
-for (const SwLineLayout* pLine = GetNext(); pLine; pLine = 
pLine->GetNext())
-{
-pLine->dumpAsXml(pWriter);
-}
 
 (void)xmlTextWriterEndElement(pWriter);
 }
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 1e52e8fdbb68..b7c05e716a5e 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -485,7 +485,23 @@ void SwFrame::dumpAsXml( xmlTextWriterPtr writer ) const
 pTextFrame->VisitPortions( pdumper );
 if (const SwParaPortion* pPara = pTextFrame->GetPara())
 {
-pPara->dumpAsXml(writer);
+(void)xmlTextWriterStartElement(writer, 
BAD_CAST("SwParaPortion"));
+(void)xmlTextWriterWriteFormatAttribute(writer, 

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 147742, which changed state.

Bug 147742 Summary: Assert hit when using UnoControlGrid with screen reader
https://bugs.documentfoundation.org/show_bug.cgi?id=147742

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

Michael Weghorn  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

--- Comment #6 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fbe4d77d961975bafe8ea3e419651df4d418f92b

tdf#147742 a11y: AccessibleGridControlBase: get accessible desc on demand

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

--- Comment #5 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83419f869c33d550a61d260b1b3aef6a00cefc45

tdf#147742 a11y: AccessibleGridControl...: get accessible name on demand

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

--- Comment #4 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a9c57e6ac6bc46ad78b66409a964f5b717878931

tdf#147742 a11y: AccessibleGridControlTable needs SolarMutex

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: accessibility/inc accessibility/source

[Michael Weghorn (via logerrit)]

 accessibility/inc/extended/AccessibleGridControlBase.hxx|2 --
 accessibility/source/extended/AccessibleGridControlBase.cxx |3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

New commits:
commit fbe4d77d961975bafe8ea3e419651df4d418f92b
Author: Michael Weghorn 
AuthorDate: Thu Mar 3 15:34:06 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Mar 4 08:05:33 2022 +0100

tdf#147742 a11y: AccessibleGridControlBase: get accessible desc on demand

Previously, the accessible description was retrieved
in the `AccessibleGridControlBase` ctor and stored
in a class member. Change that to fetch the
description on demand.

`TableControl::GetAccessibleObjectDescription` is used
to get the description, which currently uses the row and
column index of the currently active cell.

When using the macro from the sample document in tdf#147742
with the Orca screen reader active, no cell was active
at the point that the ctor was called, so
`ROW_INVALID`/`COL_INVALID` were used, resulting
in a crash later (s. backtrace in tdf#147742).

If necessary, `TableControl::GetAccessibleObjectDescription`
could be extended to allow passing an explicit row/column index,
as is the case for `TableControl::GetAccessibleName`, then
override `AccessibleGridControlBase::getAccessibleDescription`
in `AccessibleGridControlCell`, similar to how it is done
for the accessible name in
Change-Id I87eabb2ce3c99d4a622d919ab0fb8d7fb3beed6b
("tdf#147742 a11y: AccessibleGridControl...: get accessible name on
demand").

Change-Id: I58f3a2b0c83e2cdbae103811505d7d0a4f8bfc52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130934
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/accessibility/inc/extended/AccessibleGridControlBase.hxx 
b/accessibility/inc/extended/AccessibleGridControlBase.hxx
index 4075b7f7964f..7da777d8dac2 100644
--- a/accessibility/inc/extended/AccessibleGridControlBase.hxx
+++ b/accessibility/inc/extended/AccessibleGridControlBase.hxx
@@ -253,8 +253,6 @@ protected:
 ::vcl::table::AccessibleTableControlObjType m_eObjType;
 
 private:
-/** Localized description text. */
-OUString m_aDescription;
 ::comphelper::AccessibleEventNotifier::TClientIdm_aClientId;
 };
 
diff --git a/accessibility/source/extended/AccessibleGridControlBase.cxx 
b/accessibility/source/extended/AccessibleGridControlBase.cxx
index c02d921fa1a1..915aeb7e373e 100644
--- a/accessibility/source/extended/AccessibleGridControlBase.cxx
+++ b/accessibility/source/extended/AccessibleGridControlBase.cxx
@@ -54,7 +54,6 @@ AccessibleGridControlBase::AccessibleGridControlBase(
 m_xParent( rxParent ),
 m_aTable( rTable),
 m_eObjType( eObjType ),
-m_aDescription( rTable.GetAccessibleObjectDescription( eObjType ) ),
 m_aClientId(0)
 {
 }
@@ -134,7 +133,7 @@ OUString SAL_CALL 
AccessibleGridControlBase::getAccessibleDescription()
 SolarMutexGuard g;
 
 ensureIsAlive();
-return m_aDescription;
+return m_aTable.GetAccessibleObjectDescription(m_eObjType);
 }
 
 OUString SAL_CALL AccessibleGridControlBase::getAccessibleName()

[Libreoffice-commits] core.git: accessibility/inc accessibility/source

[Michael Weghorn (via logerrit)]

 accessibility/inc/extended/AccessibleGridControlBase.hxx |   14 -
 accessibility/inc/extended/AccessibleGridControlTableCell.hxx|4 +
 accessibility/source/extended/AccessibleGridControlBase.cxx  |3 -
 accessibility/source/extended/AccessibleGridControlTableCell.cxx |   28 
++
 4 files changed, 24 insertions(+), 25 deletions(-)

New commits:
commit 83419f869c33d550a61d260b1b3aef6a00cefc45
Author: Michael Weghorn 
AuthorDate: Thu Mar 3 14:49:57 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Mar 4 08:05:16 2022 +0100

tdf#147742 a11y: AccessibleGridControl...: get accessible name on demand

Base class `AccessibleGridControlBase` was retrieving
an accessible name and storing it in class member 'm_aName'.

For the classes representing cells, derived from
`AccessibleGridControlCell`, the index is needed
to get a meaningful name, so the name retrieved in
the `AccessibleGridControlBase` ctor with hard-coded
row/column indices of 0 was replaced again in
the `AccessibleGridControlCell` ctor.

Replace that logic to just retrieve the name
on demand, and override
'getAccessibleName' in `AccessibleGridControlCell`
using the logic used in its ctor previously.

(No functional change intended here, but a
somewhat similar handling for the accessible
description was causing a crash when the Orca screen
reader was active. This will be handled in a following
commit.)

Change-Id: I87eabb2ce3c99d4a622d919ab0fb8d7fb3beed6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130933
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/accessibility/inc/extended/AccessibleGridControlBase.hxx 
b/accessibility/inc/extended/AccessibleGridControlBase.hxx
index 361c8d4d59f6..4075b7f7964f 100644
--- a/accessibility/inc/extended/AccessibleGridControlBase.hxx
+++ b/accessibility/inc/extended/AccessibleGridControlBase.hxx
@@ -61,7 +61,7 @@ class AccessibleGridControlBase :
 public AccessibleGridControlImplHelper
 {
 public:
-/** Constructor sets specified name and description.
+/** Constructor.
 @param rxParent  XAccessible interface of the parent object.
 @param rTableThe Table control.
 @param eObjType  Type of accessible table control. */
@@ -227,10 +227,6 @@ protected:
 /** @throws DisposedException  If the object is not alive. */
 void ensureIsAlive() const;
 
-/** Changes the name of the object (flat assignment, no notify).
-@attention  This method requires a locked mutex. */
-inline void implSetName( const OUString& rName );
-
 /** Locks all mutex's and calculates the bounding box relative to the
 parent window.
 @return  The bounding box (VCL rect.) relative to the parent object.
@@ -257,8 +253,6 @@ protected:
 ::vcl::table::AccessibleTableControlObjType m_eObjType;
 
 private:
-/** Localized name. */
-OUString m_aName;
 /** Localized description text. */
 OUString m_aDescription;
 ::comphelper::AccessibleEventNotifier::TClientIdm_aClientId;
@@ -315,12 +309,6 @@ inline ::vcl::table::AccessibleTableControlObjType 
AccessibleGridControlBase::ge
 return m_eObjType;
 }
 
-inline void AccessibleGridControlBase::implSetName(
-const OUString& rName )
-{
-m_aName = rName;
-}
-
 
 } // namespace accessibility
 
diff --git a/accessibility/inc/extended/AccessibleGridControlTableCell.hxx 
b/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
index 77077183b54b..6e3ee3367ae8 100644
--- a/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
+++ b/accessibility/inc/extended/AccessibleGridControlTableCell.hxx
@@ -40,6 +40,10 @@ namespace accessibility
 // XAccessibleComponent
 virtual void SAL_CALL grabFocus() override;
 
+public:
+// XAccessibleContext
+virtual OUString SAL_CALL getAccessibleName() override;
+
 protected:
 AccessibleGridControlCell(
 const css::uno::Reference< css::accessibility::XAccessible >& 
_rxParent,
diff --git a/accessibility/source/extended/AccessibleGridControlBase.cxx 
b/accessibility/source/extended/AccessibleGridControlBase.cxx
index c118c70f7a32..c02d921fa1a1 100644
--- a/accessibility/source/extended/AccessibleGridControlBase.cxx
+++ b/accessibility/source/extended/AccessibleGridControlBase.cxx
@@ -54,7 +54,6 @@ AccessibleGridControlBase::AccessibleGridControlBase(
 m_xParent( rxParent ),
 m_aTable( rTable),
 m_eObjType( eObjType ),
-m_aName( rTable.GetAccessibleObjectName( eObjType, 0, 0 ) ),
 m_aDescription( rTable.GetAccessibleObjectDescription( eObjType ) ),
 m_aClientId(0)
 {
@@ -143,7 +142,7 @@ OUString SAL_CALL 
AccessibleGridControlBase::getAccessibleName()
 SolarMutexGuard g;
 
 ensureIsAlive();
-return m_aName;
+return m_aTable.GetAccessibleObjectName(m_eObjType, 0, 0);
 }
 
 css::uno::Reference< 

[Libreoffice-commits] core.git: 2 commits - accessibility/source

[Michael Weghorn (via logerrit)]

 accessibility/source/extended/AccessibleGridControlHeader.cxx |2 ++
 accessibility/source/extended/AccessibleGridControlTable.cxx  |2 ++
 2 files changed, 4 insertions(+)

New commits:
commit a9c57e6ac6bc46ad78b66409a964f5b717878931
Author: Michael Weghorn 
AuthorDate: Thu Mar 3 11:49:01 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Mar 4 08:05:01 2022 +0100

tdf#147742 a11y: AccessibleGridControlTable needs SolarMutex

... in `AccessibleGridControlTable::getAccessibleIndexInParent`,
just like in the implementation of the other a11y UNO API methods.

Change-Id: I4ab7a2626db09398c79fe53d85c9802136decbf7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130925
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/accessibility/source/extended/AccessibleGridControlTable.cxx 
b/accessibility/source/extended/AccessibleGridControlTable.cxx
index da634269b049..75a17f0bcb00 100644
--- a/accessibility/source/extended/AccessibleGridControlTable.cxx
+++ b/accessibility/source/extended/AccessibleGridControlTable.cxx
@@ -69,6 +69,8 @@ AccessibleGridControlTable::getAccessibleChild( sal_Int32 
nChildIndex )
 
 sal_Int32 SAL_CALL AccessibleGridControlTable::getAccessibleIndexInParent()
 {
+SolarMutexGuard aSolarGuard;
+
 ensureIsAlive();
 if(m_aTable.HasRowHeader() && m_aTable.HasColHeader())
 return 0;
commit 1ccb6dc5bd2aa67f151d590b1aad20cecefaa28c
Author: Michael Weghorn 
AuthorDate: Thu Mar 3 11:43:06 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Mar 4 08:04:48 2022 +0100

tdf#147742 a11y: AccessibleGridControlHeader needs SolarMutex

... in `AccessibleGridControlHeader::getAccessibleIndexInParent`,
just like in the implementation of the other a11y UNO API methods.

Change-Id: Ib3bd44e73ae54bb1df05dc2714ce1f793f7222db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130924
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/accessibility/source/extended/AccessibleGridControlHeader.cxx 
b/accessibility/source/extended/AccessibleGridControlHeader.cxx
index 122e6ab50575..d88b3421812d 100644
--- a/accessibility/source/extended/AccessibleGridControlHeader.cxx
+++ b/accessibility/source/extended/AccessibleGridControlHeader.cxx
@@ -74,6 +74,8 @@ AccessibleGridControlHeader::getAccessibleChild( sal_Int32 
nChildIndex )
 
 sal_Int32 SAL_CALL AccessibleGridControlHeader::getAccessibleIndexInParent()
 {
+SolarMutexGuard aSolarGuard;
+
 ensureIsAlive();
 if(m_eObjType == vcl::table::TCTYPE_ROWHEADERBAR && 
m_aTable.HasColHeader())
 return 1;

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

--- Comment #3 from Commit Notification 
 ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1ccb6dc5bd2aa67f151d590b1aad20cecefaa28c

tdf#147742 a11y: AccessibleGridControlHeader needs SolarMutex

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147742] Assert hit when using UnoControlGrid with screen reader

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147742

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: accessibility/source

[Michael Weghorn (via logerrit)]

 accessibility/source/extended/AccessibleGridControlHeader.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 5189fd943a522b8158002d6c34a897a9034b8819
Author: Michael Weghorn 
AuthorDate: Thu Mar 3 16:30:18 2022 +0100
Commit: Michael Weghorn 
CommitDate: Fri Mar 4 08:04:31 2022 +0100

a11y: Use more conventional indentation of 4 spaces

I hadn't even noticed that 5 spaces were used
until the Jenkins CI build for my change adding
a single line only indented by 4 spaces failed [1] due
to our clang indentation plugin...

[1] 
https://gerrit.libreoffice.org/c/core/+/130924/1#message-7a5209670085f69e53fd592ba41c2bd4b74a360a

Change-Id: I859e8de4c02ff33c6a9fee957d868cf6e4ddd907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130932
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/accessibility/source/extended/AccessibleGridControlHeader.cxx 
b/accessibility/source/extended/AccessibleGridControlHeader.cxx
index 7c6c2df5925d..122e6ab50575 100644
--- a/accessibility/source/extended/AccessibleGridControlHeader.cxx
+++ b/accessibility/source/extended/AccessibleGridControlHeader.cxx
@@ -74,11 +74,11 @@ AccessibleGridControlHeader::getAccessibleChild( sal_Int32 
nChildIndex )
 
 sal_Int32 SAL_CALL AccessibleGridControlHeader::getAccessibleIndexInParent()
 {
- ensureIsAlive();
- if(m_eObjType == vcl::table::TCTYPE_ROWHEADERBAR && 
m_aTable.HasColHeader())
- return 1;
- else
- return 0;
+ensureIsAlive();
+if(m_eObjType == vcl::table::TCTYPE_ROWHEADERBAR && 
m_aTable.HasColHeader())
+return 1;
+else
+return 0;
 }
 
 // XAccessibleComponent ---

[Libreoffice-commits] core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/filter/ascii/wrtasc.cxx|5 -
 sw/source/filter/basflt/fltini.cxx   |   13 +-
 sw/source/filter/html/css1atr.cxx|   61 
 sw/source/filter/html/htmlatr.cxx|   49 +++---
 sw/source/filter/html/htmlcss1.cxx   |  149 +--
 sw/source/filter/html/htmldrawreader.cxx |7 -
 sw/source/filter/html/htmlflywriter.cxx  |   99 
 sw/source/filter/html/htmlform.cxx   |   64 -
 sw/source/filter/html/htmlgrin.cxx   |   13 +-
 sw/source/filter/html/htmlplug.cxx   |7 -
 sw/source/filter/html/htmlsect.cxx   |   34 ++-
 sw/source/filter/html/htmltab.cxx|   52 --
 sw/source/filter/html/htmltabw.cxx   |   15 +--
 sw/source/filter/html/svxcss1.cxx|   60 
 sw/source/filter/html/swhtml.cxx |   10 --
 sw/source/filter/html/wrthtml.cxx|   58 
 sw/source/filter/writer/wrtswtbl.cxx |   29 ++
 17 files changed, 287 insertions(+), 438 deletions(-)

New commits:
commit 04e325131f3aeec0910257b261c9624de2b59542
Author: Noel Grandin 
AuthorDate: Thu Mar 3 09:55:14 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Mar 4 07:51:18 2022 +0100

use SfxItemSet::GetItemIfSet in sw/source/filter

Change-Id: I8712a42236310a268fcbd7c47c01899333f4731c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130904
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ascii/wrtasc.cxx 
b/sw/source/filter/ascii/wrtasc.cxx
index e13b4efc9414..db256e667663 100644
--- a/sw/source/filter/ascii/wrtasc.cxx
+++ b/sw/source/filter/ascii/wrtasc.cxx
@@ -210,12 +210,11 @@ void SwASCWriter::SetupFilterOptions(SfxMedium& rMedium)
 const SfxItemSet* pSet = rMedium.GetItemSet();
 if( nullptr != pSet )
 {
-const SfxPoolItem* pItem;
-if( SfxItemState::SET == pSet->GetItemState( SID_FILE_FILTEROPTIONS, 
true,  ) )
+if( const SfxStringItem* pItem = pSet->GetItemIfSet( 
SID_FILE_FILTEROPTIONS ) )
 {
 SwAsciiOptions aOpt;
 OUString sItemOpt;
-sItemOpt = static_cast(pItem)->GetValue();
+sItemOpt = pItem->GetValue();
 aOpt.ReadUserData(sItemOpt);
 SetAsciiOptions(aOpt);
 }
diff --git a/sw/source/filter/basflt/fltini.cxx 
b/sw/source/filter/basflt/fltini.cxx
index 8e421a3610b4..7948fa0782c6 100644
--- a/sw/source/filter/basflt/fltini.cxx
+++ b/sw/source/filter/basflt/fltini.cxx
@@ -271,13 +271,12 @@ void StgReader::SetFltName( const OUString& rFltNm )
 void CalculateFlySize(SfxItemSet& rFlySet, const SwNodeIndex& rAnchor,
 SwTwips nPageWidth)
 {
-const SfxPoolItem* pItem = nullptr;
-if( SfxItemState::SET != rFlySet.GetItemState( RES_FRM_SIZE, true,  
) ||
-MINFLY > static_cast(pItem)->GetWidth() )
+const SwFormatFrameSize* pFrameSizeItem = rFlySet.GetItemIfSet( 
RES_FRM_SIZE );
+if( !pFrameSizeItem || MINFLY > pFrameSizeItem->GetWidth() )
 {
 std::unique_ptr 
aSz(rFlySet.Get(RES_FRM_SIZE).Clone());
-if (pItem)
-aSz.reset(static_cast(pItem->Clone()));
+if (pFrameSizeItem)
+aSz.reset(pFrameSizeItem->Clone());
 
 SwTwips nWidth;
 // determine the width; if there is a table use the width of the table;
@@ -369,9 +368,9 @@ void CalculateFlySize(SfxItemSet& rFlySet, const 
SwNodeIndex& rAnchor,
 aSz->SetHeight( MINFLY );
 rFlySet.Put( *aSz );
 }
-else if( MINFLY > static_cast(pItem)->GetHeight() )
+else if( MINFLY > pFrameSizeItem->GetHeight() )
 {
-std::unique_ptr 
aSz(static_cast(pItem->Clone()));
+std::unique_ptr aSz(pFrameSizeItem->Clone());
 aSz->SetHeight( MINFLY );
 rFlySet.Put( std::move(aSz) );
 }
diff --git a/sw/source/filter/html/css1atr.cxx 
b/sw/source/filter/html/css1atr.cxx
index 882d7678ef55..ef3274ac6faf 100644
--- a/sw/source/filter/html/css1atr.cxx
+++ b/sw/source/filter/html/css1atr.cxx
@@ -1192,12 +1192,10 @@ bool SwHTMLWriter::HasScriptDependentItems( const 
SfxItemSet& rItemSet,
 }
 }
 
-const SfxPoolItem *pItem;
+const SwFormatDrop *pDrop;
 if( bCheckDropCap &&
-SfxItemState::SET == rItemSet.GetItemState( RES_PARATR_DROP, true,
- ) )
+(pDrop = rItemSet.GetItemIfSet( RES_PARATR_DROP )) )
 {
-const SwFormatDrop *pDrop = static_cast(pItem);
 const SwCharFormat *pDCCharFormat = pDrop->GetCharFormat();
 if( pDCCharFormat )
 {
@@ -1580,12 +1578,10 @@ static Writer& OutCSS1_SwFormat( Writer& rWrt, const 
SwFormat& rFormat,
 }
 
 // export Drop-Caps
-const SfxPoolItem *pItem;
-if( SfxItemState::SET==aItemSet.GetItemState( RES_PARATR_DROP, false, 
 ))
+if( const SwFormatDrop *pDrop = aItemSet.GetItemIfSet( RES_PARATR_DROP, 
false ) )
 {
 OUString sOut = aSelector +
 ":" + 

[Libreoffice-bugs] [Bug 128747] FILEOPEN DOCX Chart has different legend entry text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128747

Justin L  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #10 from Justin L  ---
proposed fix at https://gerrit.libreoffice.org/c/core/+/130946

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147756] New: Save docx as html: tags are not terminated, superfluous used for formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147756

Bug ID: 147756
   Summary: Save docx as html:  tags are not terminated,
superfluous  used for formatting
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libre.grisw...@xoxy.net

After importing a docx file that had both ordered and unordered list (nested) I
saved as html. The result was ugly (as expected) but two issues were large:

Both  and  lists contained unterminated 

In both lists, the  were nested in ... tags. This caused Firefox at
least to show the items spaced far apart, which was not the appearance in the
docx format.

My intuition is that this has nothing to do with docx...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sal/CppunitTest_sal_rtl.mk sal/qa

[Mike Kaganski (via logerrit)]

 sal/CppunitTest_sal_rtl.mk |1 
 sal/qa/rtl/ostring/rtl_str.cxx |  382 +
 2 files changed, 160 insertions(+), 223 deletions(-)

New commits:
commit eccbe009fd28f5b468267af853931b121b5601fd
Author: Mike Kaganski 
AuthorDate: Thu Mar 3 14:59:59 2022 +0300
Commit: Mike Kaganski 
CommitDate: Fri Mar 4 06:20:08 2022 +0100

Enable tests in rtl_str.cxx

And disable the tests that try to use nullptr where it's not accepted.

Change-Id: I1cd031e371485fdd57e7691565376253a01049c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130938
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/CppunitTest_sal_rtl.mk b/sal/CppunitTest_sal_rtl.mk
index 02b6c94e3d1b..f35586b180c2 100644
--- a/sal/CppunitTest_sal_rtl.mk
+++ b/sal/CppunitTest_sal_rtl.mk
@@ -20,6 +20,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sal_rtl,\
sal/qa/rtl/doublelock/rtl_doublelocking \
sal/qa/rtl/locale/rtl_locale \
sal/qa/rtl/math/test-rtl-math \
+   sal/qa/rtl/ostring/rtl_str \
sal/qa/rtl/oustringbuffer/test_oustringbuffer_appendchar \
sal/qa/rtl/oustringbuffer/test_oustringbuffer_appenduninitialized \
sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign \
diff --git a/sal/qa/rtl/ostring/rtl_str.cxx b/sal/qa/rtl/ostring/rtl_str.cxx
index 7cfabcab79be..b214b0ee41b4 100644
--- a/sal/qa/rtl/ostring/rtl_str.cxx
+++ b/sal/qa/rtl/ostring/rtl_str.cxx
@@ -30,25 +30,23 @@ namespace rtl_str
 
 class compare : public CppUnit::TestFixture
 {
-public:
-
-void compare_000()
-{
-rtl_str_compare( NULL, NULL);
-}
-
-void compare_000_1()
-{
-OString aStr1 = "Line must be equal.";
-rtl_str_compare( aStr1.getStr(), NULL);
-}
+//void compare_000()
+//{
+//rtl_str_compare( nullptr, nullptr);
+//}
+
+//void compare_000_1()
+//{
+//OString aStr1 = "Line must be equal.";
+//rtl_str_compare( aStr1.getStr(), nullptr);
+//}
 void compare_001()
 {
 OString aStr1 = "";
 OString aStr2 = "";
 
 sal_Int32 nValue = rtl_str_compare( aStr1.getStr(), 
aStr2.getStr());
-CPPUNIT_ASSERT_MESSAGE("compare failed, strings are equal.", 
nValue == 0);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("compare failed, strings are 
equal.", sal_Int32(0), nValue);
 }
 
 void compare_002()
@@ -57,7 +55,7 @@ namespace rtl_str
 OString aStr2 = "Line must be equal.";
 
 sal_Int32 nValue = rtl_str_compare( aStr1.getStr(), 
aStr2.getStr());
-CPPUNIT_ASSERT_MESSAGE("compare failed, strings are equal.", 
nValue == 0);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("compare failed, strings are 
equal.", sal_Int32(0), nValue);
 }
 
 void compare_003()
@@ -74,35 +72,33 @@ namespace rtl_str
 // because these macros are need by auto register mechanism.
 
 CPPUNIT_TEST_SUITE(compare);
-CPPUNIT_TEST(compare_000);
-CPPUNIT_TEST(compare_000_1);
+//CPPUNIT_TEST(compare_000); // Commented out: null-terminated arguments 
cannot be null
+//CPPUNIT_TEST(compare_000_1); // Commented out: null-terminated arguments 
cannot be null
 CPPUNIT_TEST(compare_001);
 CPPUNIT_TEST(compare_002);
 CPPUNIT_TEST(compare_003);
 CPPUNIT_TEST_SUITE_END();
-}; // class compare
+}; // class compare
 
 class compareIgnoreAsciiCase : public CppUnit::TestFixture
 {
-public:
-
-void compare_000()
-{
-rtl_str_compareIgnoreAsciiCase( NULL, NULL);
-}
-
-void compare_000_1()
-{
-OString aStr1 = "Line must be equal.";
-rtl_str_compareIgnoreAsciiCase( aStr1.getStr(), NULL);
-}
+//void compare_000()
+//{
+//rtl_str_compareIgnoreAsciiCase( nullptr, nullptr);
+//}
+
+//void compare_000_1()
+//{
+//OString aStr1 = "Line must be equal.";
+//rtl_str_compareIgnoreAsciiCase( aStr1.getStr(), nullptr);
+//}
 void compare_001()
 {
 OString aStr1 = "";
 OString aStr2 = "";
 
 sal_Int32 nValue = rtl_str_compareIgnoreAsciiCase( 
aStr1.getStr(), aStr2.getStr());
-CPPUNIT_ASSERT_MESSAGE("compare failed, strings are equal.", 
nValue == 0);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("compare failed, strings are 
equal.", sal_Int32(0), nValue);
 }
 
 void compare_002()
@@ -111,7 +107,7 @@ namespace rtl_str
 OString aStr2 = "Line must be equal.";
 
 sal_Int32 nValue = rtl_str_compareIgnoreAsciiCase( 

[Libreoffice-bugs] [Bug 144092] FILEOPEN PPTX: Empty table rows appear with lower height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144092

Justin L  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144092] FILEOPEN PPTX: Empty table rows appear with lower height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144092

--- Comment #6 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c1b2ed31cbde0a81853ba4fe59841cded6c52105

related tdf#144092 svx: warn about wrong "empty cell" idea

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144092] FILEOPEN PPTX: Empty table rows appear with lower height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144092

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/source

[Justin Luth (via logerrit)]

 svx/source/table/tablelayouter.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit c1b2ed31cbde0a81853ba4fe59841cded6c52105
Author: Justin Luth 
AuthorDate: Tue Feb 8 09:04:47 2022 +0200
Commit: Justin Luth 
CommitDate: Fri Mar 4 06:16:05 2022 +0100

related tdf#144092 svx: warn about wrong "empty cell" idea

An empty cell is not irrelevant in making height decisions,
at least in MS file formats, and yet all of this code that
is being based on that wrong assumption is being done to
import ppt(x) files, and causing one regression after another.
[Worst of all, this isn't even a filter import codebase.]

Unfortunately the regressions have been dealt with
or discovered slowly, so some of this has been in place
for years. Otherwise I would revert this in a heartbeat.

At least throw in a warning, so that this seemingly
logical conclusion will at least be challenged by
the next bug-fixer - instead of building another
layer on this house of cards.

Change-Id: I0e984a7ecce5061224a4165c0ee61818348a9659
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129659
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 0c517707f4f8..87bd4436e7f3 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -766,6 +766,11 @@ void TableLayouter::LayoutTableHeight( tools::Rectangle& 
rArea, bool bFit )
 }
 else
 {
+// WARNING: tdf#144092 / tdf#139511 suggest this entire 
section is invalid.
+// Empty cells should not be ignored in regards to row 
height,
+// especially MS formats, despite this code being added to 
import MS files...
+// The problem is getMinimumHeight can give wrong values 
for empty cells.
+
 bool bCellHasText = xCell->hasText();
 bool bCellInEditMode = xCell->IsTextEditActive();
 

[Libreoffice-bugs] [Bug 147173] Impress Presentation Crash when I increase the font size too fast in a >10mb document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147173

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147497] PostgreSQL direct connection: AutoValue wont be shown in table when created with "generated by default…"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147497

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147493] Take in consideration the extension of a file in the last used files list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147493

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147485] Docx having pure VML group inside converted to DrawingML on save and Writer unable to open it.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147485

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147484] Group shape content cannot be exported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147484

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147472] [Feature request/Suggestion to change behavior] Possibility to remove unintentional dot added into chapter numbering --> .2.1.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147472

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147482] Suboptimal Text Highlighting in Menubar in Windows 11

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147482

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147479] Pivot table display (empty) when data source is null

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147479

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141747

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141747

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141747

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141747] CROSS-REFERENCE: Give warning, if you delete a target of a cross-reference

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141747

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 132098] Custom InteractionHandler

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132098

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132098] Custom InteractionHandler

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132098

--- Comment #3 from QA Administrators  ---
Dear prrvchr,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144293] [UI] improve Android UI for tablet (in landscape mode), not the same phone UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144293

--- Comment #3 from QA Administrators  ---
Dear Patrik,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144291] compatibility MS office / libreoffice formulas: 'bar' converts to 'acute'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144291

--- Comment #2 from QA Administrators  ---
Dear KDL,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131379] a11y: Style selector not available (Orca screen reader)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131379

--- Comment #6 from QA Administrators  ---
Dear zywek,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147170] Entire UI shows at the wrong size on second monitor (DPI issue?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147170

--- Comment #5 from David Green  ---
Seems to be fixed with 7.3.1.3.   Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski (via logerrit)]

 sw/source/uibase/utlui/content.cxx |   45 ++---
 1 file changed, 23 insertions(+), 22 deletions(-)

New commits:
commit 2b924f0d83ce63882e7d14a2b51cc645c2532920
Author: Jim Raykowski 
AuthorDate: Fri Feb 18 21:13:50 2022 -0900
Commit: Jim Raykowski 
CommitDate: Fri Mar 4 01:42:40 2022 +0100

SwNavigator: speed up footnote endnote content fill

Reduces the time to fill the footnote endnote content array by avoiding
SwFormatFootnote::GetFootnoteText which calls the somewhat time
consuming SwTextNode::GetExpandText. Just calling SwTextNode::GetText
to get the footnote endnote first paragraph text should be good enough
here.

Testing with debug and optimized builds on a test document with 6243
footnotes and endnotes shows a relative average differene of 1 μs
between use of lcl_GetFootnoteText, introduced by this patch, versus
the current use of SwFormatFootnote::GetFootnoteText.

Change-Id: I6a870c0700a3e64348e5550a0fc129eabf1b1d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130182
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 7fa9c9fa5fb2..e0b3fbd16d69 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -178,6 +178,15 @@ namespace
 {
 return IDocumentMarkAccess::GetType(*pMark) == 
IDocumentMarkAccess::MarkType::BOOKMARK;
 }
+
+OUString lcl_GetFootnoteText(const SwTextFootnote& rTextFootnote)
+{
+SwNodeIndex aIdx(*rTextFootnote.GetStartNode(), 1);
+SwContentNode* pCNd = aIdx.GetNode().GetTextNode();
+if(!pCNd)
+pCNd = aIdx.GetNodes().GoNext();
+return pCNd->IsTextNode() ? static_cast(pCNd)->GetText() 
: OUString();
+}
 }
 
 // Content, contains names and reference at the content type.
@@ -620,34 +629,26 @@ void SwContentType::FillMemberList(bool* pbContentChanged)
 case ContentTypeId::FOOTNOTE:
 {
 const SwFootnoteIdxs& rFootnoteIdxs = 
m_pWrtShell->GetDoc()->GetFootnoteIdxs();
+if (rFootnoteIdxs.size() == 0)
+break;
 size_t nFootnoteCount = 0;
-for (SwTextFootnote* pTextFootnote : rFootnoteIdxs)
+for (const SwTextFootnote* pTextFootnote : rFootnoteIdxs)
 if (!pTextFootnote->GetFootnote().IsEndNote())
 ++nFootnoteCount;
 // insert a separator bar between footnote and endnote entries
-if (rFootnoteIdxs.size())
-{
-std::unique_ptr pCnt(new 
SwTextFootnoteContent(
-this, 
"---",
-nullptr, 
nFootnoteCount + 1));
-pCnt->SetInvisible();
-m_pMember->insert(std::move(pCnt));
-}
-tools::Long nPos = 0, nInsertPos = 0;
-for (SwTextFootnote* pTextFootnote : rFootnoteIdxs)
+auto pSeparatorBar(make_unique(this,
+"---", nullptr, nFootnoteCount + 
1));
+pSeparatorBar->SetInvisible();
+m_pMember->insert(std::move(pSeparatorBar));
+// insert footnotes and endnotes
+tools::Long nPos = 0;
+for (const SwTextFootnote* pTextFootnote : rFootnoteIdxs)
 {
 const SwFormatFootnote& rFormatFootnote = 
pTextFootnote->GetFootnote();
-const OUString& sText =
-rFormatFootnote.GetViewNumStr(*m_pWrtShell->GetDoc(),
-  
m_pWrtShell->GetLayout(), true) + " " +
-
rFormatFootnote.GetFootnoteText(*m_pWrtShell->GetLayout());
-if (rFormatFootnote.IsEndNote())
-nInsertPos = nPos + nFootnoteCount + 2;
-else
-nInsertPos = ++nPos;
-std::unique_ptr pCnt(new 
SwTextFootnoteContent(
-this, sText, 
pTextFootnote,
-nInsertPos));
+const OUString& sText = 
rFormatFootnote.GetViewNumStr(*m_pWrtShell->GetDoc(),
+m_pWrtShell->GetLayout(), true) + " " + 
lcl_GetFootnoteText(*pTextFootnote);
+auto pCnt(make_unique(this, sText, 
pTextFootnote,
+rFormatFootnote.IsEndNote() ? nPos + nFootnoteCount + 2 : 
++nPos));
 if 
(!pTextFootnote->GetTextNode().getLayoutFrame(m_pWrtShell->GetLayout()))
 pCnt->SetInvisible();
 m_pMember->insert(std::move(pCnt));

[Libreoffice-bugs] [Bug 147755] New: Can't insert symbols with math editor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147755

Bug ID: 147755
   Summary: Can't insert symbols with math editor
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pierre.choffar...@free.fr

Just create a new math equation

Try to insert a symbol using icon Omega

None of the symbols are inserted

Tested LO 7.4 dev and 7.3.1.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147753] Crashes when doing various things in both writer and calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147753

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Please copy the info in Menu/Help/About, with the button in it, and past it
here.
I'm also having crash without message with 7.3 and 7.4

Version: 7.3.1.3 (x64) / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 04f9a8957c04b8c5abaa58140328d2c83381f4ff
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147751] ZOOM related: Cell Cursor vertical position does not match with cell position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147751

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Reproducible, and disabling Skia doesn't solve the issue.
Version: 7.2.6.1 (x64) / LibreOffice Community
Build ID: ce99d6a58f9368279ff1495b5b367eb64343b26c
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 04f9a8957c04b8c5abaa58140328d2c83381f4ff
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147740] Lower icons disappear in groupedbar compact user interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147740

stragu  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|7.0 all versions|7.1.8.1 release

--- Comment #5 from stragu  ---
Also confirmed in:

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Changing earliest version affected accordingly. Requesting a bibisect for this
regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147752] entering numbers in some columns....after going to the next column the previous column changes to a date

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147752

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Eike Rathke  ---
Detailed example of input? In which locale?
Please copy the output of Help -> About here (version, UI language,
locale).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147754] Floating image repainted incorrectly as surrounding text changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147754

Eyal Rozenberg  changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147754] Floating image repainted incorrectly as surrounding text changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147754

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 178647
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178647=edit
Document exhibiting the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147754] New: Floating image repainted incorrectly as surrounding text changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147754

Bug ID: 147754
   Summary: Floating image repainted incorrectly as surrounding
text changes
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

In an LO writer document, when I have a floating, scaled image, and am
manipulating the text next to it so that the image may need to move (but not be
scaled), it often gets painted incorrectly: As though it has been re-scaled,
cropped, or moved with some corner or side of it left as white background.

Seen with:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 250e4886d85a7e131da76f181b3fa7be02d1a76d
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147753] New: Crashes when doing various things in both writer and calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147753

Bug ID: 147753
   Summary: Crashes when doing various things in both writer and
calc
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ginnikip...@me.com

Created attachment 178646
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178646=edit
Spontanious Crashing

I have never filed a bug report, so I hope I did this the right way.I have
attached the report that the crash generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135413] CRASH: importing document (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135413

--- Comment #7 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/58f2c1e6ab3052e0746dabb36e6061125779b034

tdf#135413: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135413] CRASH: importing document (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135413

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/data/tdf135413.docx|binary
 sw/qa/uitest/writer_tests7/tdf135413.py |   25 +
 2 files changed, 25 insertions(+)

New commits:
commit 58f2c1e6ab3052e0746dabb36e6061125779b034
Author: Xisco Fauli 
AuthorDate: Thu Mar 3 19:43:12 2022 +0100
Commit: Xisco Fauli 
CommitDate: Thu Mar 3 23:06:31 2022 +0100

tdf#135413: sw: Add UItest

Change-Id: Ic22042b604ac7228ac0368c7c0a3324c1863679b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130940
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/data/tdf135413.docx b/sw/qa/uitest/data/tdf135413.docx
new file mode 100644
index ..89a56ad34699
Binary files /dev/null and b/sw/qa/uitest/data/tdf135413.docx differ
diff --git a/sw/qa/uitest/writer_tests7/tdf135413.py 
b/sw/qa/uitest/writer_tests7/tdf135413.py
new file mode 100644
index ..22c088eb2d01
--- /dev/null
+++ b/sw/qa/uitest/writer_tests7/tdf135413.py
@@ -0,0 +1,25 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+
+class tdf135413(UITestCase):
+
+def test_tdf135413(self):
+
+# Without the fix in place, this test would have crashed opening the 
document
+# It seems the issue is only reproducible when the UI is displayed,
+# thus, test it with a UItest
+with self.ui_test.load_file(get_url_for_data_file("tdf135413.docx")):
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+self.assertEqual("16", get_state_as_dict(xWriterEdit)["Pages"])
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-commits] core.git: hwpfilter/source

[Mike Kaganski (via logerrit)]

 hwpfilter/source/hwpreader.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 4cbaaf21fe1c22b36dd72798cecfa59e73d0f8c3
Author: Mike Kaganski 
AuthorDate: Thu Mar 3 23:02:41 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Mar 3 22:59:04 2022 +0100

Use 's std::hypot

Change-Id: I2f9db19dca795b6318cd88ca645020077520f5da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130943
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 6c285c664e23..a8272d82746e 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3943,8 +3943,6 @@ void HwpReader::makePicture(Picture * hbox)
 }
 }
 
-namespace { double DBL(int x) { return x * x; } }
-
 void HwpReader::makePictureDRAW(HWPDrawingObject *drawobj, Picture * hbox)
 {
 int x = hbox->pgx;
@@ -4047,8 +4045,8 @@ void HwpReader::makePictureDRAW(HWPDrawingObject 
*drawobj, Picture * hbox)
 bIsRotate = true;
 }
 if( bIsRotate ){
-drawobj->extent.w = 
static_cast(sqrt(DBL(pt[1].x-pt[0].x) + DBL(pt[1].y-pt[0].y)));
-drawobj->extent.h = 
static_cast(sqrt(DBL(pt[2].x-pt[1].x) + DBL(pt[2].y-pt[1].y)));
+drawobj->extent.w = 
static_cast(std::hypot(pt[1].x-pt[0].x, pt[1].y-pt[0].y));
+drawobj->extent.h = 
static_cast(std::hypot(pt[2].x-pt[1].x, pt[2].y-pt[1].y));
 padd("draw:transform", sXML_CDATA, trans);
 }
 }

[Libreoffice-commits] core.git: hwpfilter/source

[Mike Kaganski (via logerrit)]

 hwpfilter/source/hwpreader.cxx |   55 +++--
 1 file changed, 15 insertions(+), 40 deletions(-)

New commits:
commit be1076297b9b1191030cb4fc8c94cfae354630da
Author: Mike Kaganski 
AuthorDate: Thu Mar 3 22:52:23 2022 +0300
Commit: Mike Kaganski 
CommitDate: Thu Mar 3 22:46:12 2022 +0100

Drop some strcpy

Change-Id: I304f69147e570f08c743183c54cc5b759143550a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130942
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 6095360c1ec9..6c285c664e23 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -86,6 +86,10 @@ struct Free
 }
 };
 
+constexpr OUStringLiteral sBeginOfDoc(u"[\uBB38\uC11C\uC758 \uCC98\uC74C]");
+// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
+// U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
+// U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
 }
 
 struct HwpReaderPrivate
@@ -1406,32 +1410,28 @@ void HwpReader::parseParaShape(ParaShape const * pshape)
 padd("fo:line-height", sXML_CDATA,
 ascii(Int2Str (pshape->lspacing, "%d%%", buf)));
 
-unsigned char set_align = 0;
+const char* align = nullptr;
 
 switch (static_cast(pshape->arrange_type))
 {
 case 1:
-strcpy(buf, "start");
-set_align = 1;
+align = "start";
 break;
 case 2:
-strcpy(buf, "end");
-set_align = 1;
+align = "end";
 break;
 case 3:
-strcpy(buf, "center");
-set_align = 1;
+align = "center";
 break;
 case 4:
 case 5:
 case 6:
-strcpy(buf, "justify");
-set_align = 1;
+align = "justify";
 break;
 }
 
-if (set_align)
-padd("fo:text-align", sXML_CDATA, ascii(buf));
+if (align)
+padd("fo:text-align", sXML_CDATA, ascii(align));
 
 if (pshape->outline)
 padd("fo:border", sXML_CDATA, "0.002cm solid #00");
@@ -2705,13 +2705,7 @@ void HwpReader::make_text_p0(HWPPara * para, bool 
bParaStart)
 }
 if( d->bFirstPara && d->bInBody )
 {
-strcpy(
-buf,
-"[\xEB\xAC\xB8\xEC\x84\x9C\xEC\x9D\x98 \xEC\xB2\x98\xEC\x9D\x8C]");
-// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
-// U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
-// U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
-padd("text:name", sXML_CDATA, OUString(buf, strlen(buf), 
RTL_TEXTENCODING_UTF8));
+padd("text:name", sXML_CDATA, sBeginOfDoc);
 rstartEl("text:bookmark", mxList);
 mxList->clear();
 rendEl("text:bookmark");
@@ -2781,13 +2775,7 @@ void HwpReader::make_text_p1(HWPPara * para,bool 
bParaStart)
 if( d->bFirstPara && d->bInBody )
 {
 /* for HWP's Bookmark */
-strcpy(
-buf,
-"[\xEB\xAC\xB8\xEC\x84\x9C\xEC\x9D\x98 \xEC\xB2\x98\xEC\x9D\x8C]");
-// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
-// U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
-// U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
-padd("text:name", sXML_CDATA, OUString(buf, strlen(buf), 
RTL_TEXTENCODING_UTF8));
+padd("text:name", sXML_CDATA, sBeginOfDoc);
 rstartEl("text:bookmark", mxList);
 mxList->clear();
 rendEl("text:bookmark");
@@ -2865,13 +2853,7 @@ void HwpReader::make_text_p3(HWPPara * para,bool 
bParaStart)
 if ( !pstart ) {
 STARTP;
 }
-strcpy(
-buf,
-"[\xEB\xAC\xB8\xEC\x84\x9C\xEC\x9D\x98 \xEC\xB2\x98\xEC\x9D\x8C]");
-// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
-// U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
-// U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
-padd("text:name", sXML_CDATA, OUString(buf, strlen(buf), 
RTL_TEXTENCODING_UTF8));
+padd("text:name", sXML_CDATA, sBeginOfDoc);
 rstartEl("text:bookmark", mxList);
 mxList->clear();
 rendEl("text:bookmark");
@@ -4730,14 +4712,7 @@ void HwpReader::parsePara(HWPPara * para)
 if( d->bFirstPara && d->bInBody )
 {
 /* for HWP's Bookmark */
-strcpy(
-buf,
-"[\xEB\xAC\xB8\xEC\x84\x9C\xEC\x9D\x98"
-" \xEC\xB2\x98\xEC\x9D\x8C]");
-// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
-// U+C758 HANGUL SYLLABLE YI, U+CC98 HANGUL SYLLABLE CEO,
-// U+C74C HANGUL SYLLABLE EUM: "Begin of Document"
-padd("text:name", sXML_CDATA, OUString(buf, strlen(buf), 
RTL_TEXTENCODING_UTF8));
+   

[Libreoffice-commits] core.git: sc/qa sc/source

[Luboš Luňák (via logerrit)]

 sc/qa/unit/mark_test.cxx |   32 +++
 sc/source/core/data/markdata.cxx |   13 +--
 sc/source/ui/Accessibility/AccessibleDocument.cxx|1 
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |1 
 sc/source/ui/unoobj/cellsuno.cxx |4 --
 5 files changed, 42 insertions(+), 9 deletions(-)

New commits:
commit 19e3644eaf8f3f09c22c94e4ad8352f844fc4955
Author: Luboš Luňák 
AuthorDate: Thu Mar 3 12:21:27 2022 +0100
Commit: Luboš Luňák 
CommitDate: Thu Mar 3 22:37:49 2022 +0100

make ScMarkData::IsAllMarked() work also for simple marks

Change-Id: I41009c83827619605b4cfc4909f1d9922cde68a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130923
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/qa/unit/mark_test.cxx b/sc/qa/unit/mark_test.cxx
index 309a62143aff..55a13cb0da57 100644
--- a/sc/qa/unit/mark_test.cxx
+++ b/sc/qa/unit/mark_test.cxx
@@ -112,6 +112,8 @@ public:
 
 void testScMarkArraySearch();
 
+void testIsAllMarked();
+
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testSimpleMark_Simple);
 CPPUNIT_TEST(testSimpleMark_Column);
@@ -123,6 +125,7 @@ public:
 CPPUNIT_TEST(testDeleteTabBeforeSelected);
 CPPUNIT_TEST(testDeleteTabAfterSelected);
 CPPUNIT_TEST(testScMarkArraySearch);
+CPPUNIT_TEST(testIsAllMarked);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -970,6 +973,35 @@ void Test::testScMarkArraySearch()
 }
 }
 
+void Test::testIsAllMarked()
+{
+ScSheetLimits aSheetLimits(MAXCOL, MAXROW);
+ScMarkData mark(aSheetLimits);
+ScRange range1( ScAddress( 5, 10, 0 ), ScAddress( 15, 20, 0 ));
+ScRange range2( ScAddress( 2, 2, 0 ), ScAddress( 25, 30, 0 ));
+CPPUNIT_ASSERT( !mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( !mark.IsAllMarked( range2 ));
+mark.MarkToMulti();
+CPPUNIT_ASSERT( !mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( !mark.IsAllMarked( range2 ));
+
+mark.ResetMark();
+mark.SetMarkArea( range1 );
+CPPUNIT_ASSERT( mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( !mark.IsAllMarked( range2 ));
+mark.MarkToMulti();
+CPPUNIT_ASSERT( mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( !mark.IsAllMarked( range2 ));
+
+mark.ResetMark();
+mark.SetMarkArea( range2 );
+CPPUNIT_ASSERT( mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( mark.IsAllMarked( range2 ));
+mark.MarkToMulti();
+CPPUNIT_ASSERT( mark.IsAllMarked( range1 ));
+CPPUNIT_ASSERT( mark.IsAllMarked( range2 ));
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/core/data/markdata.cxx b/sc/source/core/data/markdata.cxx
index 2b3f948d8803..596937e24346 100644
--- a/sc/source/core/data/markdata.cxx
+++ b/sc/source/core/data/markdata.cxx
@@ -564,13 +564,20 @@ std::vector 
ScMarkData::GetMarkedColSpans() const
 
 bool ScMarkData::IsAllMarked( const ScRange& rRange ) const
 {
-if ( !bMultiMarked )
-return false;
-
 SCCOL nStartCol = rRange.aStart.Col();
 SCROW nStartRow = rRange.aStart.Row();
 SCCOL nEndCol = rRange.aEnd.Col();
 SCROW nEndRow = rRange.aEnd.Row();
+
+if ( !bMultiMarked )
+{
+if ( bMarked && !bMarkIsNeg &&
+ aMarkRange.aStart.Col() <= nStartCol && aMarkRange.aEnd.Col() >= 
nEndCol &&
+ aMarkRange.aStart.Row() <= nStartRow && aMarkRange.aEnd.Row() >= 
nEndRow )
+return true;
+return false;
+}
+
 bool bOk = true;
 
 if ( nStartCol == 0 && nEndCol == mrSheetLimits.mnMaxCol )
diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx 
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index 21e3d1813a77..251bba490f87 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -2114,7 +2114,6 @@ bool ScAccessibleDocument::IsTableSelected() const
 SCTAB nTab(getVisibleTable());
 //#103800#; use a copy of MarkData
 ScMarkData aMarkData(mpViewShell->GetViewData().GetMarkData());
-aMarkData.MarkToMulti();
 ScDocument* pDoc = GetDocument();
 if (aMarkData.IsAllMarked( ScRange( 0, 0, nTab, pDoc->MaxCol(), 
pDoc->MaxRow(), nTab)))
 bResult = true;
diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx 
b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
index f8399b68918a..8abbe1f7b967 100644
--- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
+++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
@@ -1357,7 +1357,6 @@ bool ScAccessibleSpreadsheet::IsCompleteSheetSelected()
 {
 //#103800#; use a copy of MarkData
 ScMarkData aMarkData(mpViewShell->GetViewData().GetMarkData());
-aMarkData.MarkToMulti();
 if (aMarkData.IsAllMarked(maRange))
 bResult = true;
 }
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Luboš Luňák (via logerrit)]

 sc/inc/markarr.hxx   |2 
 sc/inc/markdata.hxx  |   17 +++
 sc/inc/markmulti.hxx |4 -
 sc/qa/extras/vba-macro-test.cxx  |   30 ++--
 sc/qa/unit/mark_test.cxx |4 -
 sc/source/core/data/column.cxx   |3 -
 sc/source/core/data/documen3.cxx |3 -
 sc/source/core/data/document.cxx |   24 +++---
 sc/source/core/data/drwlayer.cxx |3 -
 sc/source/core/data/markarr.cxx  |8 ---
 sc/source/core/data/markdata.cxx |   45 ---
 sc/source/core/data/markmulti.cxx|   13 -
 sc/source/core/data/table1.cxx   |4 -
 sc/source/core/data/table3.cxx   |4 -
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |3 -
 sc/source/ui/app/seltrans.cxx|3 -
 sc/source/ui/docshell/docfunc.cxx|   21 +++-
 sc/source/ui/docshell/docsh5.cxx |3 -
 sc/source/ui/navipi/navipi.cxx   |9 +--
 sc/source/ui/undo/undoblk.cxx|5 --
 sc/source/ui/unoobj/docuno.cxx   |   10 +---
 sc/source/ui/view/cellsh.cxx |3 -
 sc/source/ui/view/cellsh1.cxx|8 +--
 sc/source/ui/view/cellsh2.cxx|2 
 sc/source/ui/view/dbfunc3.cxx|2 
 sc/source/ui/view/formatsh.cxx   |4 -
 sc/source/ui/view/gridwin.cxx|3 -
 sc/source/ui/view/gridwin4.cxx   |6 --
 sc/source/ui/view/gridwin_dbgutil.cxx|4 -
 sc/source/ui/view/pfuncache.cxx  |4 -
 sc/source/ui/view/tabview2.cxx   |   13 ++---
 sc/source/ui/view/tabview3.cxx   |   13 +
 sc/source/ui/view/tabvwsh3.cxx   |3 -
 sc/source/ui/view/viewdata.cxx   |2 
 sc/source/ui/view/viewfun2.cxx   |   15 ++
 sc/source/ui/view/viewfun3.cxx   |3 -
 sc/source/ui/view/viewfun4.cxx   |4 -
 sc/source/ui/view/viewfunc.cxx   |   14 ++---
 sc/source/ui/view/viewutil.cxx   |3 -
 39 files changed, 90 insertions(+), 234 deletions(-)

New commits:
commit f92e15bc09def64a718b52812a9cb39e43fb8b5b
Author: Luboš Luňák 
AuthorDate: Thu Mar 3 10:57:21 2022 +0100
Commit: Luboš Luňák 
CommitDate: Thu Mar 3 22:37:35 2022 +0100

improve ScMark* classes a bit

Bin pointless empty destructors, make trivial functions inline,
return value by simply returning it.

Change-Id: Ia71e73262802bbe6b022ca4bafb2b958ffdf39f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130915
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/markarr.hxx b/sc/inc/markarr.hxx
index de0b3361cfab..03e94b7d302b 100644
--- a/sc/inc/markarr.hxx
+++ b/sc/inc/markarr.hxx
@@ -52,7 +52,6 @@ public:
 ScMarkArray( const ScSheetLimits& rLimits );
 ScMarkArray( ScMarkArray&& rArray ) noexcept;
 ScMarkArray( const ScMarkArray& rArray );
-~ScMarkArray();
 voidReset( bool bMarked = false, SCSIZE nNeeded = 1 );
 boolGetMark( SCROW nRow ) const;
 voidSetMarkArea( SCROW nStartRow, SCROW nEndRow, bool bMarked );
@@ -82,7 +81,6 @@ class SC_DLLPUBLIC ScMarkArrayIter // iterate over selected 
range
 SCSIZE  nPos;
 public:
 ScMarkArrayIter( const ScMarkArray* pNewArray );
-~ScMarkArrayIter();
 
 boolNext( SCROW& rTop, SCROW& rBottom );
 voidreset( const ScMarkArray* pNewArray );
diff --git a/sc/inc/markdata.hxx b/sc/inc/markdata.hxx
index 69a7acfde8ab..6c2969e6e50a 100644
--- a/sc/inc/markdata.hxx
+++ b/sc/inc/markdata.hxx
@@ -67,7 +67,6 @@ public:
 ScMarkData(ScMarkData&& rData) = default;
 ScMarkData& operator=(const ScMarkData& rData);
 ScMarkData& operator=(ScMarkData&& rData);
-~ScMarkData();
 
 voidResetMark();
 voidSetMarkArea( const ScRange& rRange );
@@ -81,8 +80,8 @@ public:
 boolIsMarked() const{ return bMarked; }
 boolIsMultiMarked() const   { return bMultiMarked; }
 
-voidGetMarkArea( ScRange& rRange ) const;
-voidGetMultiMarkArea( ScRange& rRange ) const;
+const ScRange& GetMarkArea() const { return aMarkRange; }
+const ScRange& GetMultiMarkArea() const { return aMultiRange; }
 
 voidSetAreaTab( SCTAB nTab );
 
@@ -104,7 +103,7 @@ public:
 
 //  for FillInfo / Document etc.
 const ScMultiSel& 

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/fontsubset/sft.cxx |   29 ++---
 1 file changed, 22 insertions(+), 7 deletions(-)

New commits:
commit dd6ff950cbc570a11100a7cce69d51577a26bbd7
Author: Caolán McNamara 
AuthorDate: Thu Mar 3 20:28:28 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 3 22:16:50 2022 +0100

ofz: Use-of-uninitialized-value

Change-Id: If10e8d2465ef6de62583f6547e3f68e92002f3f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130944
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 9ce05ebe0e30..794cdd59d7f8 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -1521,31 +1521,46 @@ int GetTTGlyphComponents(AbstractTrueTypeFont *ttf, 
sal_uInt32 glyphID, std::vec
 
 glyphlist.push_back( glyphID );
 
-const sal_uInt32 nMaxGlyphSize = glyflength - nOffset;
+sal_uInt32 nRemainingData = glyflength - nOffset;
 
-if (nMaxGlyphSize >= 10 && GetInt16(ptr, 0) == -1) {
+if (nRemainingData >= 10 && GetInt16(ptr, 0) == -1) {
 sal_uInt16 flags, index;
 ptr += 10;
+nRemainingData -= 10;
 do {
+if (nRemainingData < 4)
+{
+SAL_WARN("vcl.fonts", "short read");
+break;
+}
 flags = GetUInt16(ptr, 0);
 index = GetUInt16(ptr, 2);
 
 ptr += 4;
+nRemainingData -= 4;
 n += GetTTGlyphComponents(ttf, index, glyphlist);
 
+sal_uInt32 nAdvance;
 if (flags & ARG_1_AND_2_ARE_WORDS) {
-ptr += 4;
+nAdvance = 4;
 } else {
-ptr += 2;
+nAdvance = 2;
 }
 
 if (flags & WE_HAVE_A_SCALE) {
-ptr += 2;
+nAdvance += 2;
 } else if (flags & WE_HAVE_AN_X_AND_Y_SCALE) {
-ptr += 4;
+nAdvance += 4;
 } else if (flags & WE_HAVE_A_TWO_BY_TWO) {
-ptr += 8;
+nAdvance += 8;
+}
+if (nRemainingData < nAdvance)
+{
+SAL_WARN("vcl.fonts", "short read");
+break;
 }
+ptr += nAdvance;
+nRemainingData -= nAdvance;
 } while (flags & MORE_COMPONENTS);
 }
 

[Libreoffice-bugs] [Bug 147739] for opentype fonts font weight "Medium" is not displayed if weight "Regular" is also installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147739

--- Comment #3 from Julien Nabet  ---
The fonts have the same name with otf, I suppose it's the source of the pb.
No pb with ttf which have distinct names "Profile Pro" and "Profile Pro
Medium".

Please respond on the bugtracker (except attaching fonts since they're not
free) in order to share info.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147752] entering numbers in some columns....after going to the next column the previous column changes to a date

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147752

magician...@live.com changed:

   What|Removed |Added

Summary|entering numbers in some|entering numbers in some
   |columnsafter going to   |columnsafter going to
   |the next column the |the next column the
   |previous column changes to  |previous column changes to
   |a dategoes to dates |a date

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147752] New: entering numbers in some columns....after going to the next column the previous column changes to a dategoes to dates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147752

Bug ID: 147752
   Summary: entering numbers in some columnsafter going to the
next column the previous column changes to a dategoes
to dates
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: magician...@live.com

entering numbers into a column and then going to the next column, the numbers
change to a date.then you have to go into format to change back to numbers


NOT VERY Good

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147751] ZOOM related: Cell Cursor vertical position does not match with cell position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147751

--- Comment #2 from Rainer Bielefeld Retired  
---

c) Was not a problem with
Version: 6.4.7.2 (x86) Build-ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
Version: 6.0.7.3 (x64)
Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89)
(some with different Theme)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147751] ZOOM related: Cell Cursor vertical position does not match with cell position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147751

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #1 from Rainer Bielefeld Retired  
---
c) Query

does not show an obvious DUP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147751] New: ZOOM related: Cell Cursor vertical position does not match with cell position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147751

Bug ID: 147751
   Summary: ZOOM related: Cell Cursor vertical position does not
match with cell position
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@bielefeldundbuss.de

Created attachment 178645
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178645=edit
Sample document

Steps how to reproduce with  Installation of Version: 7.3.0.3 (x64) 
Build ID 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
| Locale: de-DE (de_DE); UI: de-DE | Calc: threaded | ElementaryTheme | My
normal User Profile

1. Open attached Sample document 
2. Click into B13
   » Expected: Cell Cursor borders match with borders around cell B13
 Actual: cell cursor around an area including bottom of B12 and top of B13
 vertical position of cell cursor is between 2 cells

Additional Info

a) Reason seem to be the rows with very small height 
b) For me a switch to Zoom = 200% heals the problem for that document and for 
   the moment.
b1) go back to zoom  80% will bring back the wrong view.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147420] IMAGEs ANCHORed TO a CELL and selected with AUTOFILTER are not displaying or PRINTING correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147420

--- Comment #7 from Graham Tapper  ---
I have just realised that we are getting mixed up over the use of "All".  My
apologies.  I didn't mean the "All" criteria; I meant the "All" box right at
the top of the list, that selects All criteria.  Realising the confusion, I
have changed the criteria name to "*Headings" on my copy of the spreadsheet,
just so as to differentiate the usage of the term "All"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/fontsubset/sft.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit dd7f4acfccee6fd845050ecdc5544c1c9c78afaf
Author: Caolán McNamara 
AuthorDate: Thu Mar 3 09:26:18 2022 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 3 20:57:41 2022 +0100

ofz: Use-of-uninitialized-value

Change-Id: I358d826a1dafe345f610d26d0d517a7357c838d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130909
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index a413c73e7bd0..9ce05ebe0e30 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -379,7 +379,11 @@ static int GetSimpleTTOutline(AbstractTrueTypeFont const 
*ttf, sal_uInt32 glyphI
 lastPoint = t;
 }
 
-sal_uInt16 instLen = GetUInt16(ptr, 10 + numberOfContours*2);
+sal_uInt32 nInstLenOffset = 10 + numberOfContours * 2;
+if (nInstLenOffset + 2 > nMaxGlyphSize)
+return 0;
+sal_uInt16 instLen = GetUInt16(ptr, nInstLenOffset);
+
 sal_uInt32 nOffset = 10 + 2 * numberOfContours + 2 + instLen;
 if (nOffset > nMaxGlyphSize)
 return 0;

[Libreoffice-bugs] [Bug 145378] [META] Issues related to weld annotation window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145378
Bug 145378 depends on bug 145580, which changed state.

Bug 145580 Summary: Comment balloon doesn't allow Latin characters
https://bugs.documentfoundation.org/show_bug.cgi?id=145580

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146705] bug (spam)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146705

--- Comment #2 from ramisthand76  ---
i got same problem, but i don't know how to solve this

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147739] for opentype fonts font weight "Medium" is not displayed if weight "Regular" is also installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147739

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today and the otf files you
provided, I could reproduce this.

I don't know the license of these fonts but do you think it's possible to
attach them on the bugtracker?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147716] Error dialog instead of WebDAV authentication - WebDAV completely broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147716

--- Comment #6 from Michael Stahl (allotropia)  ---
so the problem is apparently that in 7.2 an URL with https:// is handled not by
webdav UCP but by gio UCP - that is indeed quite surprising.

if you have basic git skills and can download a ~10gb repo, possibly this
potential regression could be tracked down via bibisect, in the linux 7.2 repo:

https://wiki.documentfoundation.org/QA/Bibisect/Linux

https://bibisect.libreoffice.org/linux-64-7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147740] Lower icons disappear in groupedbar compact user interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147740

--- Comment #4 from joe.broes...@gmx.de ---
Here my detailed version info:

Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 24; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147740] Lower icons disappear in groupedbar compact user interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147740

--- Comment #3 from joe.broes...@gmx.de ---
I am sorry, I thought to remember that the bug came in with version 7.0.
Meanwhile I have checked these versions:

7.0.0.3: OK (no bug)
7.1.0.3: OK (no bug)
7.2.0.4: bug
7.3.0.3: bug
7.3.1.3: bug

So the bug appeared between version 7.1.0.3 and 7.2.0.4.

Another hint: The error disappears when the Paragraph Style icon is removed by
customization (see attached screenshot).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147740] Lower icons disappear in groupedbar compact user interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147740

--- Comment #2 from joe.broes...@gmx.de ---
Created attachment 178644
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178644=edit
The error disappears when the Paragraph Style icon is removed by customization

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147656] Presenter console default disable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147656

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Artem, if I understood you in our channel right the problem that have your
hundreds users is they all have TWO presenter consoles instead only one: one on
first display and the second on a second display, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 41007] EDITING: Insert image dialog should allow to select multiple images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41007

Dieter  changed:

   What|Removed |Added

 CC||dbs...@gmail.com

--- Comment #18 from Dieter  ---
*** Bug 147494 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147494] Enhancement: Add photo album function to Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147494

Dieter  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Dieter  ---
I think, that bug 41007 covers your idea. So I mark it as duplicate. Feel free
to change it back to UNCONFIRMED wih a short reasoning, if you disagree.

*** This bug has been marked as a duplicate of bug 41007 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147481] Writer Mail Merge does not use CR/LF as paragraph separator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147481

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
Thank you for reporting the bug. It seems you're using an old version of
LibreOffice. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I
have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED'
if the bug is still present in the latest version. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147480] CR/LF disappear when copy/paste a cell that have multiple lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147480

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Dieter  ---
Thank you for reporting the bug. It seems you're using an old version of
LibreOffice. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I
have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED'
if the bug is still present in the latest version. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103610] [META] Slide show (presentation mode) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103610

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||147714


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147714
[Bug 147714] Gradient background not shown in slide show if Skia enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||147714


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147714
[Bug 147714] Gradient background not shown in slide show if Skia enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147714] Gradient background not shown in slide show if Skia enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147714

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||129062, 103610

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm the problem in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc99d27f04b47c173de934a19b6d6a3cc572c20a
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default;
VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

and I see the problem in 7.1 and 7.2 too but it looks some different than in
7.4


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103610
[Bug 103610] [META] Slide show (presentation mode) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147750] New: Font changes format in tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147750

Bug ID: 147750
   Summary: Font changes format in tables
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ad.martinez.ma...@gmail.com

Description:
when writing text in a table, it resets format when the tab key is actiones.
For example, in a cell you write in bold letters and when you press tab to go
to the next cell it removes that given format.

Actual Results:
no format in text

Expected Results:
rich text maintained


Reproducible: Always


User Profile Reset: No



Additional Info:
.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147719] Calc freezes when resizing Properties pane (Win 11 only?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147719

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

Summary|Calc freezes when resizing  |Calc freezes when resizing
   |Properties pane |Properties pane (Win 11
   ||only?)
 CC||79045_79...@mail.ru

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
No repro in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dc99d27f04b47c173de934a19b6d6a3cc572c20a
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

Win 11 only?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/uibase/app/apphdl.cxx |8 -
 sw/source/uibase/app/appopt.cxx |   44 +++---
 sw/source/uibase/app/docsh.cxx  |   38 -
 sw/source/uibase/app/docsh2.cxx |   26 +++---
 sw/source/uibase/app/docst.cxx  |   34 +++-
 sw/source/uibase/app/docstyle.cxx   |   17 +---
 sw/source/uibase/dialog/regionsw.cxx|   37 -
 sw/source/uibase/docvw/HeaderFooterWin.cxx  |5 -
 sw/source/uibase/frmdlg/colex.cxx   |5 -
 sw/source/uibase/frmdlg/frmmgr.cxx  |   15 +--
 sw/source/uibase/shells/annotsh.cxx |   28 ++
 sw/source/uibase/shells/basesh.cxx  |5 -
 sw/source/uibase/shells/drawdlg.cxx |   16 +--
 sw/source/uibase/shells/drwbassh.cxx|   64 +++
 sw/source/uibase/shells/drwtxtex.cxx|   23 ++---
 sw/source/uibase/shells/drwtxtsh.cxx|   10 --
 sw/source/uibase/shells/frmsh.cxx   |  115 +---
 sw/source/uibase/shells/grfsh.cxx   |   55 ++---
 sw/source/uibase/shells/tabsh.cxx   |   78 +-
 sw/source/uibase/shells/textfld.cxx |   45 +-
 sw/source/uibase/shells/textsh.cxx  |   27 ++
 sw/source/uibase/shells/textsh1.cxx |   42 --
 sw/source/uibase/shells/textsh2.cxx |   53 +---
 sw/source/uibase/shells/txtattr.cxx |7 -
 sw/source/uibase/shells/txtcrsr.cxx |9 --
 sw/source/uibase/shells/txtnum.cxx  |   14 +--
 sw/source/uibase/uiview/formatclipboard.cxx |   51 +---
 sw/source/uibase/uiview/pview.cxx   |   20 ++--
 sw/source/uibase/uiview/view.cxx|8 -
 sw/source/uibase/uiview/view2.cxx   |   71 +
 sw/source/uibase/uiview/viewprt.cxx |6 -
 sw/source/uibase/uiview/viewtab.cxx |   46 ---
 sw/source/uibase/utlui/numfmtlb.cxx |   19 ++--
 sw/source/uibase/utlui/uitool.cxx   |   81 +--
 34 files changed, 519 insertions(+), 603 deletions(-)

New commits:
commit 0a1031a9ecd1502b1841bde26dde7ad51358c638
Author: Noel Grandin 
AuthorDate: Thu Mar 3 09:56:09 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Mar 3 19:19:39 2022 +0100

use SfxItemSet::GetItemIfSet in sw/source/uibase

Change-Id: Ic82df8d321ba2eb94957236264c71c5eb9a940a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130905
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/uibase/app/apphdl.cxx b/sw/source/uibase/app/apphdl.cxx
index 8042ed313605..e0934b78ce94 100644
--- a/sw/source/uibase/app/apphdl.cxx
+++ b/sw/source/uibase/app/apphdl.cxx
@@ -244,13 +244,13 @@ std::shared_ptr 
SwView::EnsureMailMergeConfigItem(const S
 xMMConfig->SetSourceView(this);
 
 //set the first used database as default source on the config item
-const SfxPoolItem* pItem = nullptr;
-if (pArgs && SfxItemState::SET == pArgs->GetItemState(
-   FN_PARAM_DATABASE_PROPERTIES, false, ))
+const SfxUnoAnyItem* pItem = nullptr;
+if (pArgs && (pItem = pArgs->GetItemIfSet(
+   FN_PARAM_DATABASE_PROPERTIES, false)))
 {
 //mailmerge has been called from the database beamer
 uno::Sequence< beans::PropertyValue> aDBValues;
-if (static_cast(pItem)->GetValue() >>= 
aDBValues)
+if (pItem->GetValue() >>= aDBValues)
 {
 SwDBData aDBData;
 svx::ODataAccessDescriptor aDescriptor(aDBValues);
diff --git a/sw/source/uibase/app/appopt.cxx b/sw/source/uibase/app/appopt.cxx
index c4fe62e2ffa9..77033c4940f0 100644
--- a/sw/source/uibase/app/appopt.cxx
+++ b/sw/source/uibase/app/appopt.cxx
@@ -228,15 +228,12 @@ void SwModule::ApplyItemSet( sal_uInt16 nId, const 
SfxItemSet& rSet )
 SwViewOption aViewOpt = *GetUsrPref(!bTextDialog);
 SwMasterUsrPref* pPref = bTextDialog ? m_pUsrPref.get() : 
m_pWebUsrPref.get();
 
-const SfxPoolItem* pItem;
 SfxBindings *pBindings = pAppView ? 
>GetViewFrame()->GetBindings()
  : nullptr;
 
 // Interpret the page Documentview
-if( SfxItemState::SET == rSet.GetItemState( FN_PARAM_DOCDISP, false, 
 ))
+if( const SwDocDisplayItem* pDocDispItem = rSet.GetItemIfSet( 
FN_PARAM_DOCDISP, false ))
 {
-const SwDocDisplayItem* pDocDispItem = static_cast(pItem);
-
 if(!aViewOpt.IsViewMetaChars())
 {
 if( (!aViewOpt.IsTab( true ) &&  pDocDispItem->m_bTab) ||
@@ -261,9 +258,8 @@ void SwModule::ApplyItemSet( sal_uInt16 nId, const 
SfxItemSet& rSet )
 
 // Elements - interpret Item
 bool bFlag = true;
-if( SfxItemState::SET == rSet.GetItemState( FN_PARAM_ELEM, false,  ) 
)
+if( const SwElemItem* pElemItem = rSet.GetItemIfSet( FN_PARAM_ELEM, false 
) )
 {
-const SwElemItem* pElemItem = 

[Libreoffice-commits] core.git: shell/source

[Stephan Bergmann (via logerrit)]

 shell/source/unix/exec/shellexec.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c1ac79906bde5c902be5cb0ae6b530da96e52169
Author: Stephan Bergmann 
AuthorDate: Thu Mar 3 16:13:42 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Mar 3 18:59:16 2022 +0100

Handle symlinks

LIBREOFFICE-PQ967WYM

Change-Id: I5e4df92401e009fe6b7238565d1223cfb77d10ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130930
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/shell/source/unix/exec/shellexec.cxx 
b/shell/source/unix/exec/shellexec.cxx
index d33553022471..240113ae8271 100644
--- a/shell/source/unix/exec/shellexec.cxx
+++ b/shell/source/unix/exec/shellexec.cxx
@@ -131,12 +131,12 @@ void SAL_CALL ShellExec::execute( const OUString& 
aCommand, const OUString& aPar
 0);
 }
 struct stat st;
-auto const e2 = stat(pathname8.getStr(), );
+auto const e2 = lstat(pathname8.getStr(), );
 if (e2 != 0) {
 auto const e3 = errno;
-SAL_INFO("shell", "stat(" << pathname8 << ") failed with errno 
" << e3);
+SAL_INFO("shell", "lstat(" << pathname8 << ") failed with 
errno " << e3);
 }
-if (e2 == 0 && S_ISDIR(st.st_mode)) {
+if (e2 == 0 && (S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode))) {
 dir = true;
 } else if (e2 != 0 || !S_ISREG(st.st_mode)
|| (st.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH)) != 0)

[Libreoffice-bugs] [Bug 127586] Part of legend is overlapping with the chart (comment 9)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127586

Justin L  changed:

   What|Removed |Added

   Keywords|regression  |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147747] FILESAVE PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147747

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
It is already possible, I don't understand what you mean. Please explain.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147747] FILESAVE PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147747

--- Comment #1 from Buovjaga  ---
*** Bug 147748 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.