[Libreoffice-bugs] [Bug 51779] support for SQL datatype INTERVAL
https://bugs.documentfoundation.org/show_bug.cgi?id=51779 Buovjaga changed: What|Removed |Added CC|ilmari.lauhakangas@libreoff |pragat.pan...@gmail.com |ice.org | --- Comment #15 from Buovjaga --- (In reply to Libreoffice user SSO from comment #14) > I would like to work on this easyhack! Feel free to assign to yourself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 51779] support for SQL datatype INTERVAL
https://bugs.documentfoundation.org/show_bug.cgi?id=51779 --- Comment #14 from Libreoffice user SSO --- I would like to work on this easyhack! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147755] Can't use "Tools > Symbols" dialog in math formula editor (StR in comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=147755 Ming Hua changed: What|Removed |Added Keywords||bibisectRequest, regression Summary|Can't insert symbols with |Can't use "Tools > Symbols" |math editor |dialog in math formula ||editor (StR in comment 3) --- Comment #3 from Ming Hua --- More detailed steps to reproduce: 1. In Writer start the formula editor via "Insert > Object > Formula Object..." menu; 2. The UI changed to Math formula editor, open the Symbols dialog with "Tools > Symbols..." menu; 3. Choose a Greek letter, press "Insert" button. Actual Result: Nothing happens. Expected Result: Math code like "%alpha" inserted into the formula code pane at the bottom, Greek letter like "α" inserted into the formula object in the display pane at the middle. Directly typing code like "%alpha" in the code pane works fine and can be used as a workaround. The same problem occurs if one opens Math directly instead of inserting formula in Writer in step 1, or uses button on toolbar (I assume this is what the reporter means by "using icon Omega" in comment 0) instead of menu to invoke the dialog in step 2. Can not reproduce the "can't insert `(small space) or ^ in a formula by pressing the correct key" claim in comment 1. Reproduced with 7.3.1 RC2 on Windows 10: Version: 7.3.1.2 (x64) / LibreOffice Community Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded But can not reproduce (symbols inserted as expected) with 7.1.7: Version: 7.1.7.2 (x64) / LibreOffice Community Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f CPU threads: 2; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded Tagged as regression and bibisection requested. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130924] replace debugging printf calls with SAL_INFO/SAL_WARN
https://bugs.documentfoundation.org/show_bug.cgi?id=130924 --- Comment #17 from Commit Notification --- pragat-pandya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f121860d0537060084278da11842732a748d6b7 tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130924] replace debugging printf calls with SAL_INFO/SAL_WARN
https://bugs.documentfoundation.org/show_bug.cgi?id=130924 Commit Notification changed: What|Removed |Added Whiteboard|target:7.0.0 target:7.3.0 |target:7.0.0 target:7.3.0 ||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bridges/source include/sal
bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx |7 ++-
include/sal/log-areas.dox|1 +
2 files changed, 3 insertions(+), 5 deletions(-)
New commits:
commit 6f121860d0537060084278da11842732a748d6b7
Author: pragat-pandya
AuthorDate: Tue Mar 1 16:56:06 2022 +0530
Commit: Luboš Luňák
CommitDate: Sat Mar 5 08:35:23 2022 +0100
tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN
Change-Id: Iaef5eec6508d031ab711a71c0d8ecebb18112ef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130764
Tested-by: Luboš Luňák
Reviewed-by: Luboš Luňák
diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
index de393582f99a..48d8d174fb6a 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
@@ -442,11 +442,8 @@ static unsigned char * codeSnippet( unsigned char * code,
// jmpq *%r11
*reinterpret_cast( code + 20 ) = 0x00e3ff49;
-#if OSL_DEBUG_LEVEL > 1
-fprintf(stderr,
-"==> codeSnippet, functionIndex=%d%s, vtableOffset=%d\n",
-nFunctionIndex, (bHasHiddenParam ? "|0x8000":""),
nVtableOffset);
-#endif
+SAL_INFO("bridges.debug", "==> codeSnippet, functionIndex=" <<
nFunctionIndex
+<< (bHasHiddenParam ? "|0x8000":"") << ", vtableOffset=" <<
nVtableOffset);
return code + codeSnippetSize;
}
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 7d61cfd3d3cd..b0e10c48fa2d 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -47,6 +47,7 @@ certain functionality.
@li @c bridges
@li @c bridges.ios
@li @c bridges.osx
+@li @c bridges.debug
@section canvas
[Libreoffice-commits] core.git: sc/CppunitTest_sc_tablecolumnsobj.mk sc/CppunitTest_sc_tablerowsobj.mk sc/CppunitTest_sc_tablesheetobj.mk sc/inc sc/qa sc/source
sc/CppunitTest_sc_tablecolumnsobj.mk |3
sc/CppunitTest_sc_tablerowsobj.mk|3
sc/CppunitTest_sc_tablesheetobj.mk |3
sc/inc/sheetlimits.hxx |9 +-
sc/qa/extras/sctablecolumnsobj.cxx |4
sc/qa/extras/sctablerowsobj.cxx |4
sc/qa/extras/sctablesheetobj.cxx |7 +
sc/qa/unit/mark_test.cxx | 146 ++-
sc/qa/unit/rangelst_test.cxx |2
sc/qa/unit/ucalc.cxx |2
sc/qa/unit/ucalc_formula.cxx |2
sc/source/core/data/documen2.cxx | 16 ++-
12 files changed, 115 insertions(+), 86 deletions(-)
New commits:
commit 31e0ada711a008d7841a2da243ce50bc49c6c857
Author: Luboš Luňák
AuthorDate: Fri Mar 4 20:42:59 2022 +0100
Commit: Luboš Luňák
CommitDate: Sat Mar 5 08:30:59 2022 +0100
remove more hardcoded sheet sizes from Calc tests
E.g. sctablesheetobj test had the limits hardcoded, even as actual
numbers. Apparently some tests cannot easily access global
settings, but this at least makes it easy to check all tests
after modifying ScSheetLimits::CreateDefault().
Change-Id: I6cff577fb01b1ea262dcd1f9fde24e114e19abdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131040
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/CppunitTest_sc_tablecolumnsobj.mk
b/sc/CppunitTest_sc_tablecolumnsobj.mk
index 04d41985aa22..29e65d860830 100644
--- a/sc/CppunitTest_sc_tablecolumnsobj.mk
+++ b/sc/CppunitTest_sc_tablecolumnsobj.mk
@@ -22,12 +22,15 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sc_tablecolumnsobj, \
$(eval $(call gb_CppunitTest_use_libraries,sc_tablecolumnsobj, \
cppu \
sal \
+ salhelper \
+ sc \
subsequenttest \
test \
unotest \
))
$(eval $(call gb_CppunitTest_set_include,sc_tablecolumnsobj,\
+ -I$(SRCDIR)/sc/inc \
$$(INCLUDE) \
))
diff --git a/sc/CppunitTest_sc_tablerowsobj.mk
b/sc/CppunitTest_sc_tablerowsobj.mk
index 4c82243b4f1a..ffbd3850aebd 100644
--- a/sc/CppunitTest_sc_tablerowsobj.mk
+++ b/sc/CppunitTest_sc_tablerowsobj.mk
@@ -22,12 +22,15 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sc_tablerowsobj, \
$(eval $(call gb_CppunitTest_use_libraries,sc_tablerowsobj, \
cppu \
sal \
+ salhelper \
+ sc \
subsequenttest \
test \
unotest \
))
$(eval $(call gb_CppunitTest_set_include,sc_tablerowsobj,\
+ -I$(SRCDIR)/sc/inc \
$$(INCLUDE) \
))
diff --git a/sc/CppunitTest_sc_tablesheetobj.mk
b/sc/CppunitTest_sc_tablesheetobj.mk
index 44e72d112bc8..52f7f427b27a 100644
--- a/sc/CppunitTest_sc_tablesheetobj.mk
+++ b/sc/CppunitTest_sc_tablesheetobj.mk
@@ -22,12 +22,15 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sc_tablesheetobj, \
$(eval $(call gb_CppunitTest_use_libraries,sc_tablesheetobj, \
cppu \
sal \
+salhelper \
+sc \
subsequenttest \
test \
unotest \
))
$(eval $(call gb_CppunitTest_set_include,sc_tablesheetobj,\
+-I$(SRCDIR)/sc/inc \
$$(INCLUDE) \
))
diff --git a/sc/inc/sheetlimits.hxx b/sc/inc/sheetlimits.hxx
index cbc017c9d10e..1d1410b9056a 100644
--- a/sc/inc/sheetlimits.hxx
+++ b/sc/inc/sheetlimits.hxx
@@ -31,12 +31,13 @@ struct ScSheetLimits final : public
salhelper::SimpleReferenceObject
ScSheetLimits(SCCOL nMaxCol, SCROW nMaxRow)
: mnMaxCol(nMaxCol)
-, mnMaxRow(nMaxRow){}
-
- [[nodiscard]] bool ValidCol(SCCOL nCol) const
+, mnMaxRow(nMaxRow)
{
-return ::ValidCol(nCol, mnMaxCol);
}
+
+SC_DLLPUBLIC static ScSheetLimits CreateDefault();
+
+[[nodiscard]] bool ValidCol(SCCOL nCol) const { return ::ValidCol(nCol,
mnMaxCol); }
[[nodiscard]] bool ValidRow(SCROW nRow) const { return ::ValidRow(nRow,
mnMaxRow); }
[[nodiscard]] bool ValidColRow(SCCOL nCol, SCROW nRow) const
{
diff --git a/sc/qa/extras/sctablecolumnsobj.cxx
b/sc/qa/extras/sctablecolumnsobj.cxx
index 406e559489fa..ccb96f7c786d 100644
--- a/sc/qa/extras/sctablecolumnsobj.cxx
+++ b/sc/qa/extras/sctablecolumnsobj.cxx
@@ -29,6 +29,8 @@
#include
+#include
+
using namespace css;
namespace sc_apitest
@@ -90,7 +92,7 @@ private:
ScTableColumnsObj::ScTableColumnsObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
, XElementAccess(cppu::UnoType::get())
-, XIndexAccess(1024)
+, XIndexAccess(ScSheetLimits::CreateDefault().GetMaxColCount())
, XNameAccess("ABC")
, XServiceInfo("ScTableColumnsObj", "com.sun.star.table.TableColumns")
{
diff --git a/sc/qa/extras/sctablerowsobj.cxx b/sc/qa/extras/sctablerowsobj.cxx
index 5efe6bc64cac..419a326f48cd 100644
--- a/sc/qa/extras/sctablerowsobj.cxx
+++ b/sc/qa/extras/sctablerowsobj.cxx
@@ -28,6 +28,8 @@
#include
+#include
+
using namespace css;
using namespace css::uno;
@@ -79,7 +81,7 @@ private:
ScTableRowsObj::ScTableRowsObj()
:
[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source
sc/inc/attarray.hxx |6 -
sc/inc/column.hxx | 166 +++-
sc/source/core/data/column.cxx | 111 --
sc/source/core/data/column2.cxx | 68
sc/source/core/data/column4.cxx |5 -
sc/source/core/data/table1.cxx |8 -
6 files changed, 172 insertions(+), 192 deletions(-)
New commits:
commit 16b4525e8770ca457c8b33f08c5f9ef5f35ef62e
Author: Luboš Luňák
AuthorDate: Fri Mar 4 18:27:13 2022 +0100
Commit: Luboš Luňák
CommitDate: Sat Mar 5 08:30:45 2022 +0100
remove more hardcoded MAXROW
Change-Id: Ica57f18d3fd1bf9ec06f05869f4a956d7d1097b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131036
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx
index 52c2793c3f3c..f55a4ee8206e 100644
--- a/sc/inc/attarray.hxx
+++ b/sc/inc/attarray.hxx
@@ -21,6 +21,7 @@
#include "global.hxx"
#include "attrib.hxx"
+#include "document.hxx"
#include "patattr.hxx"
#include
@@ -114,6 +115,7 @@ public:
~ScAttrArray();
ScDocument& GetDoc() { return rDocument; }
+const ScDocument& GetDoc() const { return rDocument; }
voidSetTab(SCTAB nNewTab) { nTab = nNewTab; }
voidSetCol(SCCOL nNewCol) { nCol = nNewCol; }
#if DEBUG_SC_TESTATTRARRAY
@@ -266,10 +268,10 @@ inline const ScPatternAttr* ScAttrIterator::Next( SCROW&
rTop, SCROW& rBottom )
if ( !nPos )
{
++nPos;
-if ( nRow > MAXROW )
+if ( nRow > pArray->GetDoc().MaxRow())
return nullptr;
rTop = nRow;
-rBottom = std::min( nEndRow, MAXROW );
+rBottom = std::min( nEndRow, pArray->GetDoc().MaxRow());
nRow = rBottom + 1;
return pDefPattern;
}
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index de69846442ca..1ec4aac4204b 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -281,8 +281,7 @@ public:
boolGetFirstVisibleAttr( SCROW& rFirstRow ) const;
boolGetLastVisibleAttr( SCROW& rLastRow ) const;
boolHasVisibleAttrIn( SCROW nStartRow, SCROW nEndRow ) const;
-boolIsVisibleAttrEqual( const ScColumn& rCol, SCROW nStartRow = 0,
-SCROW nEndRow = MAXROW ) const;
+boolIsVisibleAttrEqual( const ScColumn& rCol, SCROW nStartRow, SCROW
nEndRow ) const;
boolIsAllAttrEqual( const ScColumn& rCol, SCROW nStartRow, SCROW
nEndRow ) const;
boolTestInsertCol( SCROW nStartRow, SCROW nEndRow) const;
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 7329b4f455b9..99c673eb5d6a 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -631,7 +631,7 @@ bool ScTable::GetPrintArea( SCCOL& rEndCol, SCROW& rEndRow,
bool bNotes, bool bC
if (nMaxX == rDocument.MaxCol())// omit attribute at
the right
{
--nMaxX;
-while ( nMaxX>0 && aCol[nMaxX].IsVisibleAttrEqual(aCol[nMaxX+1]) )
+while ( nMaxX>0 && aCol[nMaxX].IsVisibleAttrEqual(aCol[nMaxX+1], 0,
rDocument.MaxRow()) )
--nMaxX;
}
@@ -645,7 +645,7 @@ bool ScTable::GetPrintArea( SCCOL& rEndCol, SCROW& rEndRow,
bool bNotes, bool bC
while ( nAttrStartX < (aCol.size()-1) )
{
SCCOL nAttrEndX = nAttrStartX;
-while ( nAttrEndX < (aCol.size()-1) &&
aCol[nAttrStartX].IsVisibleAttrEqual(aCol[nAttrEndX+1]) )
+while ( nAttrEndX < (aCol.size()-1) &&
aCol[nAttrStartX].IsVisibleAttrEqual(aCol[nAttrEndX+1], 0, rDocument.MaxRow()) )
++nAttrEndX;
if ( nAttrEndX + 1 - nAttrStartX >= SC_COLUMNS_STOP )
{
@@ -770,10 +770,10 @@ bool ScTable::GetDataStart( SCCOL& rStartCol, SCROW&
rStartRow ) const
if (nMinX == 0) // omit attribute at
the right
{
-if ( aCol.size() > 1 && aCol[0].IsVisibleAttrEqual(aCol[1]) ) //
no single ones
+if ( aCol.size() > 1 && aCol[0].IsVisibleAttrEqual(aCol[1], 0,
rDocument.MaxRow())) // no single ones
{
++nMinX;
-while ( nMinX<(aCol.size()-1) &&
aCol[nMinX].IsVisibleAttrEqual(aCol[nMinX-1]) )
+while ( nMinX<(aCol.size()-1) &&
aCol[nMinX].IsVisibleAttrEqual(aCol[nMinX-1], 0, rDocument.MaxRow()))
++nMinX;
}
}
commit 2e2e30d7ae445509e39ba47c1b248079f28c8d95
Author: Luboš Luňák
AuthorDate: Fri Mar 4 16:40:20 2022 +0100
Commit: Luboš Luňák
CommitDate: Sat Mar 5 08:30:30 2022 +0100
remove pAttrArray nullptr checks
I don't see how it possibly could be nullptr in a correct situation,
ScColumn::Init() is called right after creating ScColumn.
Also make a bunch of trivial forwarding functions inline.
Change-Id: I710d3cd86a660a8b4dcfbb9966a685b657b93c18
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/column.hxx| 75 --
sc/inc/markdata.hxx |5 ++
sc/inc/table.hxx |2
sc/source/core/data/attarray.cxx |6 +-
sc/source/core/data/column.cxx | 62 ++---
sc/source/core/data/fillinfo.cxx |2
sc/source/core/data/markdata.cxx | 16 ++
sc/source/core/data/table1.cxx |6 +-
sc/source/core/data/table2.cxx | 95 +--
9 files changed, 180 insertions(+), 89 deletions(-)
New commits:
commit 17bcf1073bf21088b9845e36fe735622d8f88fd7
Author: Luboš Luňák
AuthorDate: Wed Feb 16 14:14:06 2022 +0100
Commit: Luboš Luňák
CommitDate: Sat Mar 5 08:30:15 2022 +0100
introduce ScColumnData for ScColumn/ScTable code sharing
Since columns are allocated dynamically on demand, up until
this commit ScTable had ScPatternAttr member for unallocated
columns that it was using in place of those unallocated columns.
But that meant either copy pieces of code from ScColumn,
or having extra slightly more cumbersome shared function
in ScColumn, or even nothing.
Improve this by creating ScColumnData, which will be used as
ScColumn base class to keep things working as before, but
ScTable now also contains one ScColumnData instance and
so it can also call its functions.
Change-Id: If1d842c4a5aec32e2a7729358006d79cd831349f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131034
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index e23eac0fdab1..7eea78900600 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -108,7 +108,54 @@ struct ScNeededSizeOptions
ScNeededSizeOptions();
};
-class ScColumn
+// A shared implementation of some column code and data.
+// This is used by ScColumn, but also by ScTable for the unallocated
+// columns (one instance that is the default for all not-yet allocated
columns).
+class ScColumnData
+{
+protected:
+std::unique_ptr pAttrArray;
+
+ScColumnData(const ScColumnData&) = delete;
+ScColumnData& operator= (const ScColumnData&) = delete;
+
+public:
+ScColumnData() = default;
+void InitAttrArray(ScAttrArray* attrArray) { pAttrArray.reset(attrArray); }
+
+ScDocument& GetDoc() const { return pAttrArray->GetDoc(); }
+
+ScAttrArray& AttrArray() { return *pAttrArray; }
+const ScAttrArray& AttrArray() const { return *pAttrArray; }
+
+const ScPatternAttr*GetPattern( SCROW nRow ) const;
+const ScPatternAttr*GetMostUsedPattern( SCROW nStartRow, SCROW nEndRow
) const;
+SCROW ApplySelectionCache( SfxItemPoolCache* pCache, const
ScMarkData& rMark, ScEditDataArray* pDataArray, bool* const pIsChanged,
+ SCCOL nCol );
+voidApplyPatternArea( SCROW nStartRow, SCROW nEndRow, const
ScPatternAttr& rPatAttr,
+ ScEditDataArray* pDataArray = nullptr,
+ bool* const pIsChanged = nullptr);
+voidMergePatternArea( ScMergePatternState& rState, SCROW nRow1,
SCROW nRow2, bool bDeep ) const;
+
+sal_uInt32 GetNumberFormat( const ScInterpreterContext& rContext, SCROW
nRow ) const;
+sal_uInt32 GetNumberFormat( SCROW nStartRow, SCROW nEndRow ) const;
+
+/// Including current, may return -1
+SCROW GetNextUnprotected( SCROW nRow, bool bUp ) const;
+
+const ScStyleSheet* GetStyle( SCROW nRow ) const;
+voidApplyStyleArea( SCROW nStartRow, SCROW nEndRow, const
ScStyleSheet& rStyle );
+
+boolHasAttrib( SCROW nRow1, SCROW nRow2, HasAttrFlags nMask )
const;
+
+voidClearSelectionItems( const sal_uInt16* pWhich, const
ScMarkData& rMark, SCCOL nCol );
+voidChangeSelectionIndent( bool bIncrement, const ScMarkData&
rMark, SCCOL nCol );
+};
+
+// Use protected inheritance to prevent publishing some internal ScColumnData
+// functions as part of ScColumn. If they should be public in ScColumn,
+// use 'using' to make them public.
+class ScColumn : protected ScColumnData
{
// Empty values correspond with empty cells. All non-empty cell positions
// must have non-empty elements. For text width, the value should be
@@ -126,8 +173,6 @@ class ScColumn
// Cell values.
sc::CellStoreType maCells;
-std::unique_ptr pAttrArray;
-
size_t mnBlkCountFormula;
SCCOL nCol;
@@ -156,9 +201,6 @@ friend class sc::CellValues;
friend class sc::TableValues;
friend class sc::CellStoreEvent;
-ScColumn(const ScColumn&) = delete;
-ScColumn& operator= (const ScColumn&) = delete;
-
bool ParseString(
ScCellValue& rCell,
SCROW nRow, SCTAB nTab, const OUString& rString,
formula::FormulaGrammar::AddressConvention eConv,
@@ -179,7 +221,7 @@ public:
voidInit(SCCOL nNewCol, SCTAB nNewTab, ScDocument& rDoc, bool
[Libreoffice-bugs] [Bug 147778] Auto Calculate is disabled after Calc is recovered from crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147778 --- Comment #2 from Kevin Suo --- I don't think is is bibisectable because I do not find other ways to make it crash. I do not reproduce this bug if I make Calc to crash by killing the soffice process. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147778] Auto Calculate is disabled after Calc is recovered from crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147778 Kevin Suo changed: What|Removed |Added Version|7.4.0.0 alpha0+ Master |7.3.1.3 release --- Comment #1 from Kevin Suo --- Also reproduced in: Version: 7.3.2.0.0+ / LibreOffice Community Build ID: 789fbf732ad6db002fd83b307385940c392cc457 CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147744] Calc crashes when pasting simple formula in a filtered column
https://bugs.documentfoundation.org/show_bug.cgi?id=147744 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7778 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147778] Auto Calculate is disabled after Calc is recovered from crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147778 Kevin Suo changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7744 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147778] New: Auto Calculate is disabled after Calc is recovered from crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147778 Bug ID: 147778 Summary: Auto Calculate is disabled after Calc is recovered from crash Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Steps to Reproduce: 1. Open attachment 178640 in bug 147744. Observe in "Data > Calculate" the option "Auto Calculate" is enabled. If not, enable it manually. 2. Follow the steps in bug 147744 to make Calc crash. 3. Click OK and finish the recovery process when you are asked whether to recover the document. 4. Now observe in "Data > Calculate", that the option "Auto Calculate" is disabled. Expected Result: After recovery Calc Auto Calculate should remain enabled. Current Result: After recovery Calc Auto Calculate is disabled. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 85a5b1d92ebb4d66c9ed683df99dc8b37c0f02a5 CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.4-CN Calc: threaded Fedora 34. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147777] New: Dropdown menus open in the middle of screen and immediately close or does not open at all
https://bugs.documentfoundation.org/show_bug.cgi?id=14 Bug ID: 14 Summary: Dropdown menus open in the middle of screen and immediately close or does not open at all Product: LibreOffice Version: 7.3.1.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ajames...@gmail.com Description: Clicking on a drapdown menu (e.g. fonts or font size) causes the menu to open in the center of the screen and close almost immediately. Often, clicking the dropdown menu to open it up does nothing at all. Steps to Reproduce: 1. Click on a dropdown menu, such as the font selector or the text style Actual Results: Either the dropdown menu fails to open (most common occurance), or the dropdown menu appears in the center of the screen and immediately closes. Expected Results: The dropdown menu should have dropped down and remained open until either dismissed or the user makes their selection. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.1.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+wayland) Locale: en-US (en_US.UTF-8); UI: en-US 7.3.1-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hwpreader.cxx | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
New commits:
commit e001a86393e363261617d2521b516287561905d4
Author: Mike Kaganski
AuthorDate: Fri Mar 4 19:55:14 2022 +0300
Commit: Mike Kaganski
CommitDate: Sat Mar 5 06:22:06 2022 +0100
Use rtl::isAsciiDigit instead of custom macro
Change-Id: Iabca31825dd47cee661b47b14f09e96459a42015
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131033
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index d6fdf29d1407..ff551174219f 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -37,6 +37,7 @@
#include
#include
#include
+#include
#include
// xmloff/xmlkyd.hxx
@@ -222,7 +223,6 @@ void HwpReader::makeTextDecls()
}
-#define ISNUMBER(x) ( (x) <= 0x39 && (x) >= 0x30 )
/**
* make office:meta
* Completed
@@ -259,8 +259,8 @@ void HwpReader::makeMeta()
unsigned short *pDate = hwpinfo.summary.date;
int year,month,day,hour,minute;
int gab = 0;
-if( ISNUMBER( pDate[0] ) && ISNUMBER( pDate[1] ) &&
-ISNUMBER( pDate[2] ) && ISNUMBER( pDate[3] ))
+if( rtl::isAsciiDigit( pDate[0] ) && rtl::isAsciiDigit( pDate[1] ) &&
+rtl::isAsciiDigit( pDate[2] ) && rtl::isAsciiDigit( pDate[3] ))
{
year = (pDate[0]-0x30) * 1000 + (pDate[1]-0x30) * 100 +
(pDate[2]-0x30) * 10 + (pDate[3]-0x30);
@@ -268,9 +268,9 @@ void HwpReader::makeMeta()
else {
year = 0;
}
-if( ISNUMBER( pDate[6] ))
+if( rtl::isAsciiDigit( pDate[6] ))
{
-if( ISNUMBER( pDate[7] ) )
+if( rtl::isAsciiDigit( pDate[7] ) )
month = (pDate[6] - 0x30) * 10 + (pDate[6+ ++gab]-0x30);
else
month = (pDate[6] - 0x30);
@@ -278,9 +278,9 @@ void HwpReader::makeMeta()
else {
month = 0;
}
-if( ISNUMBER( pDate[9 + gab] ) )
+if( rtl::isAsciiDigit( pDate[9 + gab] ) )
{
-if( ISNUMBER( pDate[10 + gab])) {
+if( rtl::isAsciiDigit( pDate[10 + gab])) {
day = ( pDate[9 + gab] - 0x30 ) * 10 + (pDate[9+ gab +
1]-0x30);
++gab;
} else
@@ -289,9 +289,9 @@ void HwpReader::makeMeta()
else {
day = 0;
}
-if( ISNUMBER( pDate[17 + gab] ) )
+if( rtl::isAsciiDigit( pDate[17 + gab] ) )
{
-if( ISNUMBER( pDate[18 + gab])) {
+if( rtl::isAsciiDigit( pDate[18 + gab])) {
hour = ( pDate[17 + gab] - 0x30 ) * 10 + (pDate[17+ gab +
1]-0x30);
++gab;
} else
@@ -300,9 +300,9 @@ void HwpReader::makeMeta()
else {
hour = 0;
}
-if( ISNUMBER( pDate[20 + gab] ) )
+if( rtl::isAsciiDigit( pDate[20 + gab] ) )
{
-if( ISNUMBER( pDate[21 + gab])) {
+if( rtl::isAsciiDigit( pDate[21 + gab])) {
minute = ( pDate[20 + gab] - 0x30 ) * 10 + (pDate[20+ gab +
1]-0x30);
++gab;
} else
[Libreoffice-bugs] [Bug 145378] [META] Issues related to weld annotation window
https://bugs.documentfoundation.org/show_bug.cgi?id=145378 Bug 145378 depends on bug 145580, which changed state. Bug 145580 Summary: Comment balloon doesn't allow Latin characters https://bugs.documentfoundation.org/show_bug.cgi?id=145580 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hwpreader.cxx | 142 +
1 file changed, 76 insertions(+), 66 deletions(-)
New commits:
commit 2c82ed241648dadd8326f0847479a4959385a6f1
Author: Mike Kaganski
AuthorDate: Fri Mar 4 16:01:17 2022 +0300
Commit: Mike Kaganski
CommitDate: Sat Mar 5 06:21:47 2022 +0100
Convert some macros to local lambdas
Change-Id: I22942588c7e7ebfb3f53cc5739d2bbd9a7ccfd41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130983
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index cb484b4fa814..d6fdf29d1407 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -42,23 +42,6 @@
// xmloff/xmlkyd.hxx
constexpr OUStringLiteral sXML_CDATA = u"CDATA";
-#define STARTP mxList->addAttribute( "text:style-name", "CDATA",
getPStyleName((para->GetParaShape()).index)); \
-startEl("text:p"); \
-mxList->clear(); \
-pstart = true
-#define STARTT \
-curr = para->GetCharShape(n > 0 ? n-1 : 0)->index; \
-mxList->addAttribute( "text:style-name", "CDATA" , getTStyleName(curr) ); \
-startEl("text:span"); \
-mxList->clear(); \
-tstart = true
-#define ENDP \
-endEl("text:p"); \
-pstart = false
-#define ENDT \
-endEl("text:span"); \
-tstart = false
-
static hchar *field = nullptr;
static char buf[1024];
@@ -2772,11 +2755,38 @@ void HwpReader::make_text_p3(HWPPara * para,bool
bParaStart)
bool pstart = bParaStart;
bool tstart = false;
bool infield = false;
-int curr;
+
+const auto STARTP = [this, para, ]()
+{
+mxList->addAttribute("text:style-name", "CDATA",
+ getPStyleName(para->GetParaShape().index));
+startEl("text:p");
+mxList->clear();
+pstart = true;
+};
+const auto STARTT = [this, para, ](int pos)
+{
+auto curr = para->GetCharShape(pos > 0 ? pos - 1 : 0)->index;
+mxList->addAttribute("text:style-name", "CDATA", getTStyleName(curr));
+startEl("text:span");
+mxList->clear();
+tstart = true;
+};
+const auto ENDP = [this, ]()
+{
+endEl("text:p");
+pstart = false;
+};
+const auto ENDT = [this, ]()
+{
+endEl("text:span");
+tstart = false;
+};
+
if( d->bFirstPara && d->bInBody )
{
if ( !pstart ) {
-STARTP;
+STARTP();
}
mxList->addAttribute("text:name", sXML_CDATA, sBeginOfDoc);
startEl("text:bookmark");
@@ -2787,7 +2797,7 @@ void HwpReader::make_text_p3(HWPPara * para,bool
bParaStart)
if( d->bInHeader )
{
if ( !pstart ) {
-STARTP;
+STARTP();
}
makeShowPageNum();
d->bInHeader = false;
@@ -2800,19 +2810,19 @@ void HwpReader::make_text_p3(HWPPara * para,bool
bParaStart)
{
if (!str.empty())
{
-if( !pstart ){ STARTP;}
-if( !tstart ){ STARTT;}
+if( !pstart ){ STARTP(); }
+if( !tstart ){ STARTT(n);}
makeChars(str);
}
-if( tstart ){ ENDT;}
-if( !pstart ){ STARTP;}
-if( pstart ){ ENDP;}
+if( tstart ){ ENDT();}
+if( !pstart ){ STARTP(); }
+if( pstart ){ ENDP(); }
break;
}
else if( para->hhstr[n]->hh == CH_SPACE && !firstspace)
{
-if( !pstart ) {STARTP;}
-if( !tstart ) {STARTT;}
+if( !pstart ) {STARTP(); }
+if( !tstart ) {STARTT(n);}
makeChars(str);
startEl("text:s");
mxList->clear();
@@ -2823,10 +2833,10 @@ void HwpReader::make_text_p3(HWPPara * para,bool
bParaStart)
if( n > 0 )
if( para->GetCharShape(n)->index !=
para->GetCharShape(n-1)->index && !infield )
{
- if( !pstart ) {STARTP;}
- if( !tstart ) {STARTT;}
+ if( !pstart ) {STARTP(); }
+ if( !tstart ) {STARTT(n);}
makeChars(str);
- ENDT;
+ ENDT();
}
if( para->hhstr[n]->hh == CH_SPACE )
firstspace = 0;
@@ -2843,8 +2853,8 @@ void HwpReader::make_text_p3(HWPPara * para,bool
bParaStart)
FieldCode *hbox = static_cast(para->hhstr[n].get());
if( hbox->location_info == 1)
{
-if( !pstart ) {STARTP;}
-if( !tstart ) {STARTT;}
+if( !pstart ) {STARTP(); }
+if( !tstart ) {STARTT(n);}
makeChars(str);
firstspace = 1;
if( hbox->type[0] == 4 && hbox->type[1] == 0 )
@@ -2873,24 +2883,24 @@ void
[Libreoffice-bugs] [Bug 105588] SVG exported from Impress or Draw cannot be correctly inserted as an image into another document
https://bugs.documentfoundation.org/show_bug.cgi?id=105588 --- Comment #15 from skierpage --- (In reply to stragu from comment #12) > I think this bug should be a WORKSFORME and possibly a different bug should > be opened about the "hidden" tags in whole-slide SVG exports. I filed bug 147776 "a slide exported as SVG from Impress should Just Work and not require JavaScript" (In reply to skierpage from comment #14) > (In reply to stragu from comment #12) > > > The resulting SVG can be seen fine when imported in Impress and Writer, and > > opened in Firefox and Inkscape, ... > When I export an Impress (version 7.3.1.3) slide as SVG and open in Inkscape > (version Inkscape 1.1.2 (0a00cf5339, 2022-02-04)), I see the slide's > contents, but not the text and background from its Master Slide [because the correct rendering requires Javascript] > > but requires switching the tags to > visibility="visible"> to work in GIMP, Sozi and gThumb. In addition to comment 4's change to visible to see the slide content: it seems the Master Slide's content is inside a tag and is not rendered. To see the Master Slide's content in the SVG, remove or comment out the outermost opening and closing tag. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147766] Table is broken in PPTX -> ODP
https://bugs.documentfoundation.org/show_bug.cgi?id=147766 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147208] In Office Libre power point information not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=147208 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147516] Setting the Tabbed Interface (Notebookbar) in Impress retains 2 toolbars in a new profile
https://bugs.documentfoundation.org/show_bug.cgi?id=147516 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147515] Dark Mode: Hidden cells in Calc are numbered in blue, which has low contrast with background
https://bugs.documentfoundation.org/show_bug.cgi?id=147515 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147776] New: a slide exported as SVG from Impress should Just Work and not require JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=147776 Bug ID: 147776 Summary: a slide exported as SVG from Impress should Just Work and not require JavaScript Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@skierpage.com Description: If you export a slide from Impress as SVG, it won't display properly in other programs unless they execute JavaScript in the SVG. a) You may not see any text from the slide, and b) You will not see any text and background from its Master Slide. a) is because the slide contents are set visibility="hidden"; b)is because the elements from the Master Slide are nested in a . The exported SVG depends on JavaScript to adjust these XML blocks to make content visible, but for a single slide with no animation this is unexpected and unnecessary complication. Steps to Reproduce: 1. Create a new presentation in LibreOffice (Impress). I chose the Vivid template. 2. Switch to View > Master Slide and add some text. (I did Insert > Text Box, drag out a text box on the master slide, enter "TEXT ON MASTER SLIDE", then select it and make it bold and red.) 3. Go to the first slide, it should be using this master, and enter some text on it. 4. File > Export, export as SVG. 5. View the SVG in a browser like Firefox or Konqueror. 6. Open the SVG in Inkscape 7. Import the SVG into LibreOffice Draw Actual Results: You see the background and the text from the master slide when you view the SVG in Firefox and Konqueror (unless you disable JavaScript, in which case you see nothing). But in Inkscape and LibreOffice Draw, the background and text from the master slide isn't visible. Expected Results: The SVG should Just Work. There's no animation, there is only a single slide, so there's no reason to require JavaScript. The behavior is counterintuitive. All the visual elements you see in Impress are in the SVG, they're just hidden and nested. Reproducible: Always User Profile Reset: No Additional Info: You can edit the SVG's XML to make it work everywhere, as discussed in bug 105588#c12. To make the SVG from the STR to display correctly everywhere I had to: * To show the slide's content with JavaScript disabled, change the object's to * To show the Master Slide's content everywhere, find the top-level tag that encloses its content (probably the tag that contains ) and remove or comment out the opening and closing - tags. * I think at this point the
[Libreoffice-bugs] [Bug 147513] PostgreSQL direct connection: string_agg will show wrong result with comma as delimiter
https://bugs.documentfoundation.org/show_bug.cgi?id=147513 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147512] program is crashed while set printer settings in calc printing
https://bugs.documentfoundation.org/show_bug.cgi?id=147512 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147506] Image anchored as Character doesn't position itself properly (overlapping text) in 7.4 & and image invisible in older versions of LibreOffice (so also a backward compat
https://bugs.documentfoundation.org/show_bug.cgi?id=147506 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147504] EDITING: Insert a point with mouse completely still
https://bugs.documentfoundation.org/show_bug.cgi?id=147504 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147761] Record macro, does not record "sort"
https://bugs.documentfoundation.org/show_bug.cgi?id=147761 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147761] Record macro, does not record "sort"
https://bugs.documentfoundation.org/show_bug.cgi?id=147761 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files
https://bugs.documentfoundation.org/show_bug.cgi?id=140759 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143739] bug insertion tableau
https://bugs.documentfoundation.org/show_bug.cgi?id=143739 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files
https://bugs.documentfoundation.org/show_bug.cgi?id=140759 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143739] bug insertion tableau
https://bugs.documentfoundation.org/show_bug.cgi?id=143739 --- Comment #3 from QA Administrators --- Dear jouault, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143735] Still no Find and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=143735 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143735] Still no Find and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=143735 --- Comment #3 from QA Administrators --- Dear Bruce Gray, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142619] LibreOffice Slow load
https://bugs.documentfoundation.org/show_bug.cgi?id=142619 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136166] CREATEDESKTOPLINK does not work in GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=136166 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142619] LibreOffice Slow load
https://bugs.documentfoundation.org/show_bug.cgi?id=142619 --- Comment #3 from QA Administrators --- Dear 2komotube, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136166] CREATEDESKTOPLINK does not work in GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=136166 --- Comment #3 from QA Administrators --- Dear guser, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135418] When started LO runs out of screen
https://bugs.documentfoundation.org/show_bug.cgi?id=135418 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135418] When started LO runs out of screen
https://bugs.documentfoundation.org/show_bug.cgi?id=135418 --- Comment #18 from QA Administrators --- Dear paps, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144314] Slowness opening documents
https://bugs.documentfoundation.org/show_bug.cgi?id=144314 --- Comment #3 from QA Administrators --- Dear moll, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144254] LibreCalc UI: The display of the drop-down box when selecting a police in the "Insert a special character"box goes crazy.
https://bugs.documentfoundation.org/show_bug.cgi?id=144254 --- Comment #3 from QA Administrators --- Dear Ramdan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140604] Some DDE Fields won't load - Multiple empty fields on large/frequently updated dde links.
https://bugs.documentfoundation.org/show_bug.cgi?id=140604 --- Comment #2 from QA Administrators --- Dear pedroh.u, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139794] Version 6.4.6 of Math works weel with STIX font (version 1), but version 6.4.7 doesn't
https://bugs.documentfoundation.org/show_bug.cgi?id=139794 --- Comment #2 from QA Administrators --- Dear aldemarcalazans, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135887] "Email Document" in Writer on Windows 10 produces an error
https://bugs.documentfoundation.org/show_bug.cgi?id=135887 --- Comment #7 from QA Administrators --- Dear smkbot, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123674] Main entry number in index loses character style after inserting new entry with 1st key
https://bugs.documentfoundation.org/show_bug.cgi?id=123674 --- Comment #10 from QA Administrators --- Dear Chris Hargrave, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147208] In Office Libre power point information not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=147208 Scott Clewell changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Component|filters and storage |Impress --- Comment #1 from Scott Clewell --- Hello Ashlee, Thank you for reporting the bug. Unfortunately, I cannot reproduce the crash. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. Especially how to "try to change font on slide". I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147769] No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 sdc.bla...@youmail.dk changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||sdc.bla...@youmail.dk -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147775] New: Unable to open spreadsheet files - error message says file does not exist
https://bugs.documentfoundation.org/show_bug.cgi?id=147775 Bug ID: 147775 Summary: Unable to open spreadsheet files - error message says file does not exist Product: LibreOffice Version: 7.3.1.3 release Hardware: Other OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mike.tam...@pm.me Description: Receiving the following messages when attempting to open spreadsheet documents: /Users/MikeTamayo/Downloads/Savings Tracking Excel.xlsx does not exist /Users/MikeTamayo/Documents/Financials/Household Financials.ods does not exist Actual Results: Clicking on file and the error messages reference above appear. This is a recent occurrence within the last couple of days...prior to this was able to open files as expected. Expected Results: Received the error messages Reproducible: Always User Profile Reset: No Additional Info: Opened the files -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147761] Record macro, does not record "sort"
https://bugs.documentfoundation.org/show_bug.cgi?id=147761 --- Comment #4 from Mark Mclean --- I only use "Run macro". I do not write them. I have recorded the same a year ago, it still works good. Thanks for your time. Not a must to fix but I thought it should be know -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147774] New: Cannot choose to drop the separator in reference text
https://bugs.documentfoundation.org/show_bug.cgi?id=147774 Bug ID: 147774 Summary: Cannot choose to drop the separator in reference text Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com In documents with numbered headings, which have separators after the number, e.g. A. My first heading B. My second heading when you want to refer to one of the headings using the "Number", the reference reads "A." rather than "A". But one does not necessarily want to include the separator in the reference! That's a stylistic choice. Now, LO should support one of the following: 1. Have a checkbox for whether to include the separator before the first number level, and another checkbox for whether to include the separator after the last level 2. Have a checkbox for whether to include both the separator before the first number level the separator after the last level 3 Split the 'Number' reference option into "Number with first prefix and last suffix" and "Number without first prefix and last suffix" (perhaps using shorter names for these options) I like option (1.) personally. Note that, in MS Word, IIANM, you can definitely refer to heading numbers using just the number without the last prefix, i.e. the default is unlike in LO. And then you can add a prefix and suffix of your own, to the field, which gives you the essentially the same effect as the LO default. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147765] Calc/Impress/Draw fail to render protected hyphen for Liberation Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=147765 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #6 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147773] New: FILEOPEN: Draw imports images with wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=147773 Bug ID: 147773 Summary: FILEOPEN: Draw imports images with wrong size Product: LibreOffice Version: 7.3.1.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sek...@posteo.se Created attachment 178662 --> https://bugs.documentfoundation.org/attachment.cgi?id=178662=edit It's a scanned quadrille paper I want to use as background, so the size has to be exact, which it isn't after importing it to Draw. Hi guys, ok so I prepared an image in GIMP at a certain size (using Image -> Print Size… in GIMP) so it has this exact size in Draw when I import it (with Import -> Image… in Draw). In GIMP the width is 189.99 mm and the height is 279.99 mm with a resolution of 299.99 pixels/inch (the .99 being a rounding error? which can be ignored). In Draw the image has a width of 18.80 mm and a height of 27.70 mm, which obviously doesn't match the values of GIMP. In order to find out which application is wrong, I imported the image in Inkscape, which shows a width of 189.992 mm and a height of 279.993 mm, which matches the values of GIMP. So to me it looks like Draw is wrong here. In practice it's no biggie, because the image can be scaled and be worked with just fine afterwards. But I still think this is a bug. I attached the image so you can confirm this on your side. p.s.: I also tested this with LibreOffice version 7.2.5.2. release, same results. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133820] Difficult to set/override footnote separator line direction
https://bugs.documentfoundation.org/show_bug.cgi?id=133820 --- Comment #11 from Eyal Rozenberg --- I am still routinely frustrated by not being able to change the footnote separator style - because I can simply not remember I need to go look for the setting in the Format | Page dialog. And that's when I've already done it in the past... it is just the opposite of intuitive. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - hwpfilter/source
hwpfilter/source/hwpreader.cxx | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit c695c60be9fb7028b3176869400be2b11c6268ec
Author: Caolán McNamara
AuthorDate: Fri Mar 4 16:47:33 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:38:37 2022 +0100
ofz: Null-dereference
Change-Id: I01be4c06c6d97430953ada8f3f5f84ef0a389267
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131032
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 91c4bdd7784b..cb484b4fa814 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -4457,7 +4457,8 @@ void HwpReader::makeFootnote(Footnote * hbox)
chars(OUString::number(hbox->number));
endEl("text:endnote-citation");
startEl("text:endnote-body");
-parsePara(hbox->plist.front().get());
+if (!hbox->plist.empty())
+parsePara(hbox->plist.front().get());
endEl("text:endnote-body");
endEl("text:endnote");
}
@@ -4472,7 +4473,8 @@ void HwpReader::makeFootnote(Footnote * hbox)
chars(OUString::number(hbox->number));
endEl("text:footnote-citation");
startEl("text:footnote-body");
-parsePara(hbox->plist.front().get());
+if (!hbox->plist.empty())
+parsePara(hbox->plist.front().get());
endEl("text:footnote-body");
endEl("text:footnote");
}
commit d3e0159a3e510f1d3202d1c7d3d652be9152a314
Author: Caolán McNamara
AuthorDate: Fri Mar 4 16:25:47 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:38:20 2022 +0100
ofz: Null-dereference
Change-Id: I7d8e30dc85df3cc5800617e5b2f232136bb72cdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131006
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 9bb15364a0c3..91c4bdd7784b 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3510,7 +3510,7 @@ void HwpReader::makeTextBox(TxtBox * hbox)
{
makeTable(hbox);
}
-else // Is TextBox
+else if (!hbox->plists[0].empty())// Is TextBox
{
parsePara(hbox->plists[0].front().get());
}
@@ -3524,7 +3524,7 @@ void HwpReader::makeTextBox(TxtBox * hbox)
if( hbox->style.cap_len > 0 && hbox->type == TXT_TYPE)
{
endEl("text:p");
-if( !(hbox->cap_pos % 2))
+if (!(hbox->cap_pos % 2) && !hbox->caption.empty())
{
parsePara(hbox->caption.front().get());
}
[Libreoffice-commits] core.git: 2 commits - codemaker/source oox/source
codemaker/source/javamaker/javatype.cxx |3 +--
oox/source/drawingml/shape.cxx |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit bc9b5c830fe4d424148f9991f416442c51e6e4fd
Author: Caolán McNamara
AuthorDate: Fri Mar 4 15:40:01 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:37:55 2022 +0100
cid#1500511 silence Resource leak
Change-Id: I37cdd52d965112598249b929fa49c759a88606c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/codemaker/source/javamaker/javatype.cxx
b/codemaker/source/javamaker/javatype.cxx
index 2bd624299a30..99a07339f821 100644
--- a/codemaker/source/javamaker/javatype.cxx
+++ b/codemaker/source/javamaker/javatype.cxx
@@ -779,8 +779,7 @@ void handleEnumType(
std::unique_ptr< ClassFile::Code > blockCode(cf->newCode());
blockCode->instrGetstatic(className, pair.second, classDescriptor);
blockCode->instrAreturn();
-blocks.emplace_back(pair.first, blockCode.get());
-blockCode.release();
+blocks.emplace_back(pair.first, blockCode.release());
}
code->instrLookupswitch(defCode.get(), blocks);
for (const std::pair< sal_Int32, ClassFile::Code * >& pair : blocks)
commit f3226c540d45deefb08b30170fc8b2511742711c
Author: Caolán McNamara
AuthorDate: Fri Mar 4 15:31:03 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:37:41 2022 +0100
cid#1500524 Dereference after null check
Change-Id: Ic76f1b4992f51bdfe10406734ce00135607db357
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131001
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index d0ab82501c71..98401179d84d 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1728,7 +1728,7 @@ Reference< XShape > const & Shape::createAndInsert(
}
// in some cases, we don't have any text body.
-if( getTextBody() && ( !bDoNotInsertEmptyTextBody ||
!mpTextBody->isEmpty() ) )
+if( mpTextBody && ( !bDoNotInsertEmptyTextBody ||
!mpTextBody->isEmpty() ) )
{
Reference < XText > xText( mxShape, UNO_QUERY );
if ( xText.is() ) // not every shape is supporting an XText
interface (e.g. GroupShape)
[Libreoffice-commits] core.git: 2 commits - sc/source svx/source
sc/source/ui/undo/undodat.cxx |2 ++ svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx |2 ++ 2 files changed, 4 insertions(+) New commits: commit 5541b7b1dd0d683a7018f7499aec4dbe6626a25a Author: Caolán McNamara AuthorDate: Fri Mar 4 15:22:45 2022 + Commit: Caolán McNamara CommitDate: Fri Mar 4 22:37:15 2022 +0100 cid#1500546 silence Explicit null dereferenced Change-Id: I44b97965548bd84adf6dc3ec1c67f028a4b31075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131000 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx b/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx index 7ec09e455d90..f7aa223f4997 100644 --- a/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx @@ -901,6 +901,8 @@ public: std::shared_ptr pFirstArg( std::move(rNodeStack.top()) ); rNodeStack.pop(); +assert(pThirdArg && pSecondArg && pFirstArg); + // create combined ExpressionNode auto pNode = std::make_shared( pFirstArg, pSecondArg, pThirdArg ); // check for constness commit b35571c348eb8816098f7c8786d8cc8ff9082f19 Author: Caolán McNamara AuthorDate: Fri Mar 4 15:20:48 2022 + Commit: Caolán McNamara CommitDate: Fri Mar 4 22:36:58 2022 +0100 cid#1500566 Uninitialized scalar field Change-Id: I63e81377227ab35a0697a1d90fb3c9302a12a2b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130999 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sc/source/ui/undo/undodat.cxx b/sc/source/ui/undo/undodat.cxx index 006527d7bacd..1ab89a8b543f 100644 --- a/sc/source/ui/undo/undodat.cxx +++ b/sc/source/ui/undo/undodat.cxx @@ -1707,6 +1707,8 @@ ScUndoChartData::ScUndoChartData( ScDocShell* pNewDocShell, const OUString& rNam bool bAdd ) : ScSimpleUndo( pNewDocShell ), aChartName( rName ), +bOldColHeaders(false), +bOldRowHeaders(false), aNewRangeListRef( rNew ), bNewColHeaders( bColHdr ), bNewRowHeaders( bRowHdr ),
[Libreoffice-commits] core.git: 2 commits - cui/source sw/source
cui/source/dialogs/cuigaldlg.cxx |5 ++---
sw/source/filter/ww8/wrtww8.cxx |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
New commits:
commit 9007ca10a3f2e11fabcd7bed74cf28da2920ce2f
Author: Caolán McNamara
AuthorDate: Fri Mar 4 15:19:01 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:36:45 2022 +0100
cid#1500569 (likely) silence Explicit null dereferenced
Change-Id: Ib44b3dcb94998ce7bf28c9dc1cd3ca7acc6e5190
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130998
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 0274944d26d6..63b27a2af334 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -3728,7 +3728,7 @@ ErrCode SwWW8Writer::WriteStorage()
xComponentContext->getServiceManager()->createInstanceWithArgumentsAndContext(
"com.sun.star.comp.oox.crypto." + sCryptoType,
aArguments, xComponentContext), uno::UNO_QUERY);
-if (xPackageEncryption.is())
+if (xPackageEncryption)
{
// We have an encryptor
// Create new temporary storage for content
commit 4ffb36265312f18e4c382fc6ff8940c5cdf268ca
Author: Caolán McNamara
AuthorDate: Fri Mar 4 15:11:38 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:36:30 2022 +0100
cid#1500632 Using a moved object
Change-Id: I5e7dd51c9f9b2b295ded161307bbe9a6a23c42de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130997
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index 559e878ce25c..fd1f4a36e10d 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -334,7 +334,8 @@ IMPL_LINK_NOARG(TakeProgress, CleanUpHdl, void*, void)
if( !aRemoveEntries[ i ] )
aRemainingVector.push_back( m_pTabPage->aFoundList[i] );
-m_pTabPage->aFoundList = std::move(aRemainingVector);
+std::swap(m_pTabPage->aFoundList, aRemainingVector);
+aRemainingVector.clear();
// refill list box
for( i = 0, nCount = aRemoveEntries.size(); i < nCount; ++i )
@@ -342,10 +343,8 @@ IMPL_LINK_NOARG(TakeProgress, CleanUpHdl, void*, void)
aRemainingVector.push_back(m_pTabPage->m_xLbxFound->get_text(i));
m_pTabPage->m_xLbxFound->clear();
-
for( i = 0, nCount = aRemainingVector.size(); i < nCount; ++i )
m_pTabPage->m_xLbxFound->append_text(aRemainingVector[i]);
-
aRemainingVector.clear();
m_pTabPage->m_xLbxFound->thaw();
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/wrtsh/wrtsh1.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 9ad752830f42dfc38f91eb2353b49650a3a48d0a
Author: Caolán McNamara
AuthorDate: Fri Mar 4 15:04:03 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:36:10 2022 +0100
cid#1500637 Explicit null dereferenced
Change-Id: I813703287faff25a48aa695ccb9c43bf469354d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130996
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index f267368c65c1..25ab28130d3b 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -2118,7 +2118,8 @@ void SwWrtShell::InsertPostIt(SwFieldMgr& rFieldMgr,
const SfxRequest& rReq)
// comment.
if (pFly)
{
-*GetCurrentShellCursor().GetPoint() = *pAnchor;
+if (pAnchor)
+*GetCurrentShellCursor().GetPoint() = *pAnchor;
SwFrameFormat* pFormat = pFly->GetFormat();
if (pFormat && pFormat->GetAnchor().GetAnchorId() ==
RndStdIds::FLY_AS_CHAR)
{
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/filter/ww8/ww8par.cxx |8 ++--
sw/source/ui/index/swuiidxmrk.cxx |5 +++--
2 files changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 80c0625995585a43f8dd4cbc7404df47f62dfae9
Author: Caolán McNamara
AuthorDate: Fri Mar 4 14:59:41 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:35:39 2022 +0100
cid#1500652 silence Explicit null dereferenced
Change-Id: Ifb96f7cf3d28b3bef70c8d920d8c926c76329fb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130995
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/ui/index/swuiidxmrk.cxx
b/sw/source/ui/index/swuiidxmrk.cxx
index fb5ae141563c..02e9f20454c0 100644
--- a/sw/source/ui/index/swuiidxmrk.cxx
+++ b/sw/source/ui/index/swuiidxmrk.cxx
@@ -1719,6 +1719,7 @@
SwCreateAuthEntryDlg_Impl::SwCreateAuthEntryDlg_Impl(weld::Window* pParent,
++nRightRow;
bLeft = !bLeft;
}
+assert(m_xTypeListBox && "this will exist after the loop");
EnableHdl(*m_xTypeListBox);
}
@@ -1726,13 +1727,13 @@ OUString
SwCreateAuthEntryDlg_Impl::GetEntryText(ToxAuthorityField eField) cons
{
if( AUTH_FIELD_AUTHORITY_TYPE == eField )
{
-OSL_ENSURE(m_xTypeListBox, "No ListBox");
+assert(m_xTypeListBox && "No ListBox");
return OUString::number(m_xTypeListBox->get_active());
}
if( AUTH_FIELD_IDENTIFIER == eField && !m_bNewEntryMode)
{
-OSL_ENSURE(m_xIdentifierBox, "No ComboBox");
+assert(m_xIdentifierBox && "No ComboBox");
return m_xIdentifierBox->get_active_text();
}
commit 6b566ed9a32c5c0eb3bde7512733c0c11a479ecd
Author: Caolán McNamara
AuthorDate: Fri Mar 4 14:55:22 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 4 22:35:25 2022 +0100
cid#1500666 Explicit null dereferenced
Change-Id: Id4283660feb95432995872b82e71c3331349f837
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130994
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 6614c5195f28..469118b61ebd 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -280,7 +280,9 @@ void SwWW8ImplReader::ReadEmbeddedData(SvStream& rStrm,
SwDocShell const * pDocS
// ANSI characters in ansiPath, including the terminating NULL
character
sal_uInt32 nUnits = 0;
rStrm.ReadUInt32(nUnits);
-if (nUnits)
+if (!nUnits)
+xShortName.reset(new OUString);
+else
{
OString sStr(read_uInt8s_ToOString(rStrm, nUnits - 1));
rStrm.SeekRel(sizeof(sal_uInt8)); // skip null-byte at end
@@ -312,7 +314,9 @@ void SwWW8ImplReader::ReadEmbeddedData(SvStream& rStrm,
SwDocShell const * pDocS
sal_uInt32 nStrLen(0);
rStrm.ReadUInt32( nStrLen );
nStrLen /= 2;
-if (nStrLen)
+if (!nStrLen)
+xLongName.reset(new OUString);
+else
{
xLongName.reset(new OUString(read_uInt16s_ToOUString(rStrm,
nStrLen - 1)));
rStrm.SeekRel(sizeof(sal_Unicode)); // skip null-byte at end
[Libreoffice-bugs] [Bug 147769] No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 Eyal Rozenberg changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Eyal Rozenberg --- (In reply to LeroyG from comment #2) > What is your LibreOffice version? Well, it doesn't matter, since it's not been implemented recently, but - Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: fb9270b238cba4f36e595c5d7f4d85f6f3f18e1c CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US > Have you tested Find & Replace, Paragraph Styles / Including Styles? I specifically mentioned this ability as something which would facilitate implementing the feature I asked for. But it is certainly no replacement for it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107614] Chinese characters are wrongly aligned if 'vpal' feature enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=107614 --- Comment #15 from Buovjaga --- (In reply to Julien Nabet from comment #13) > Volga: if it's fixed in Harfbuzz 2.1.1, it should be ok now since 2.3.1 has > been in 7.1 and 7.2 > Just for the record, 3.2.2 is present on master. > > Could you give a try to a recent LO version? (7.2.5 or 7.3.0) There was no known fix in Harfbuzz 2.1.x, but testing would be good. In https://github.com/harfbuzz/harfbuzz/issues/485 there is a comment from the reporter in 2019: "After I got HarfBuzz 2.2.0, the problem is still there. So what’s wrong with it?" Behdad closed Mark Hung's PR a bit over 2 weeks ago (!) https://github.com/harfbuzz/harfbuzz/pull/619 saying: "I don't think this is correct. Our vertical support should be correct already." -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147761] Record macro, does not record "sort"
https://bugs.documentfoundation.org/show_bug.cgi?id=147761 LeroyG changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from LeroyG --- There are only one instruction to sort and is preceded with rem: "rem dispatcher.executeDispatch(document, ".uno:DataSort", "", 0, Array())" Are you invoking the sort fuction with the mouse or with the keyboard? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107614] Chinese characters are wrongly aligned if 'vpal' feature enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=107614 --- Comment #14 from Julien Nabet --- Just for the record, I'm wondering if it's actually implemented in Harfbuzz. Indeed, first I searched vpal in Harfbuzz code, I didn't find it except these in Harfbuzz Changelog: commit 89a2bc9ba674e7e57fec1fd8ce7648a44f3aab63 Author: Behdad Esfahbod Date: Tue May 31 15:18:13 2011 -0400 [Vertical] Apply vertical features We apply all of vert, vrt2, vkrn, valt, and vpal. commit d71c0df2d17f4590d5611239577a6cb532c26528 Author: Behdad Esfahbod Date: Fri Aug 9 09:28:32 2013 -0400 Remove vrt2, vkrn, vpal, and valt from default vertical features See thread by John Dagget on the list. then I saw this: https://lists.freedesktop.org/archives/harfbuzz/2013-August/003490.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/oox include/svx oox/source sc/source sd/source sw/source
include/oox/drawingml/shape.hxx |6 -
include/svx/svdogrp.hxx |2
oox/source/drawingml/diagram/diagram.cxx| 54 +++-
oox/source/drawingml/diagram/diagram.hxx| 10 +-
oox/source/drawingml/diagram/diagramhelper.cxx | 87 +++-
oox/source/drawingml/diagram/diagramhelper.hxx |9 +-
oox/source/drawingml/diagram/diagramlayoutatoms.cxx |4
oox/source/drawingml/shape.cxx | 44 --
oox/source/ppt/pptshape.cxx | 21 ++--
sc/source/ui/drawfunc/drawsh5.cxx |2
sd/source/ui/view/drviews3.cxx |2
sw/source/uibase/shells/drwbassh.cxx|2
12 files changed, 110 insertions(+), 133 deletions(-)
New commits:
commit 9c526b557e264280cb0c9da704245494f5ec5af3
Author: Armin Le Grand (Allotropia)
AuthorDate: Fri Mar 4 16:51:07 2022 +0100
Commit: Armin Le Grand
CommitDate: Fri Mar 4 22:10:10 2022 +0100
Advanced Diagram support: Allow reLayout without keeping oox::Shape
Goal is to minimize dependencies on oox classes. For that pupose
I redesigned the Diagram class to work without remembering
an oox::Shape at all. For reLayout, a new temporary one is created
and used. That was a bit tricky, I needed to find out what
data at the oox::Shape is needed to sucessfully do that with
the not-originally-imported one.
Another necessary change was to move the DiagramFontHeights
adapting mechanism away from oox::Shape, too. It fits better
to Diagram class. That way it can also be used for reLayout
and the oox::Shape gets a little bit smaller, too.
This opens the path to move needed Mode-Data Diagam core
claasses to other libs where changing/im/exPorting them will
be possible.
Change-Id: I40bc4b190d2abc797f5c56f9e476d22155d21422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131004
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
diff --git a/include/oox/drawingml/shape.hxx b/include/oox/drawingml/shape.hxx
index 6bd875656632..d3fd710954a5 100644
--- a/include/oox/drawingml/shape.hxx
+++ b/include/oox/drawingml/shape.hxx
@@ -247,8 +247,6 @@ public:
void keepDiagramDrawing(::oox::core::XmlFilterBase& rFilterBase, const
OUString& rFragmentPath);
-oox::core::NamedShapePairs& getDiagramFontHeights() { return
maDiagramFontHeights; }
-
// Allows preparation of a local Diagram helper && propagate an eventually
// existing one to the data holder object later
void prepareDiagramHelper(const std::shared_ptr< Diagram >& rDiagramPtr,
const std::shared_ptr<::oox::drawingml::Theme>& rTheme);
@@ -290,7 +288,6 @@ protected:
const basegfx::B2DHomMatrix& aTransformation );
voidkeepDiagramCompatibilityInfo();
-void syncDiagramFontHeights();
voidconvertSmartArtToMetafile( ::oox::core::XmlFilterBase
const& rFilterBase );
css::uno::Reference< css::drawing::XShape >
@@ -397,9 +394,6 @@ private:
/// The shape fill should be set to that of the slide background surface.
bool mbUseBgFill = false;
-/// For SmartArt, this contains groups of shapes: automatic font size is
the same in each group.
-oox::core::NamedShapePairs maDiagramFontHeights;
-
// temporary space for DiagramHelper in preparation for collecting data
// Note: I tried to use a unique_ptr here, but existing constuctor func
does not allow that
IDiagramHelper* mpDiagramHelper;
diff --git a/include/svx/svdogrp.hxx b/include/svx/svdogrp.hxx
index d4ea77746019..176892fdd8ac 100644
--- a/include/svx/svdogrp.hxx
+++ b/include/svx/svdogrp.hxx
@@ -40,7 +40,7 @@ public:
virtual ~IDiagramHelper();
// re-create XShapes
-virtual void reLayout() = 0;
+virtual void reLayout(SdrObjGroup& rTarget) = 0;
// get text representation of data tree
virtual OUString getString() const = 0;
diff --git a/oox/source/drawingml/diagram/diagram.cxx
b/oox/source/drawingml/diagram/diagram.cxx
index 6c6578ae4067..481e56adec3c 100644
--- a/oox/source/drawingml/diagram/diagram.cxx
+++ b/oox/source/drawingml/diagram/diagram.cxx
@@ -137,8 +137,8 @@ void Diagram::addTo( const ShapePtr & pParentShape )
aChildren.insert(aChildren.begin(), pBackground);
}
-Diagram::Diagram(const ShapePtr& pShape)
-: mpShape(pShape)
+Diagram::Diagram()
+: maDiagramFontHeights()
{
}
@@ -168,9 +168,48 @@ uno::Sequence
Diagram::getDomsAsPropertyValues() const
return aValue;
}
-void Diagram::newTargetShape(ShapePtr& pTarget)
+using ShapePairs
+= std::map,
css::uno::Reference>;
+
+void Diagram::syncDiagramFontHeights()
{
-mpShape = pTarget;
+// Each name represents a group of shapes, for which the font height
should have the same
+// scaling.
+for (const auto& rNameAndPairs :
[Libreoffice-bugs] [Bug 147769] No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 LeroyG changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from LeroyG --- What is your LibreOffice version? Have you tested Find & Replace, Paragraph Styles / Including Styles? (https://help.libreoffice.org/latest/en-US/text/shared/01/0210.html) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hinfo.h | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
New commits:
commit 35428625b70829ba56da99fafe205b24b0018ace
Author: Mike Kaganski
AuthorDate: Fri Mar 4 19:24:34 2022 +0300
Commit: Mike Kaganski
CommitDate: Fri Mar 4 22:02:39 2022 +0100
Restore damaged comments
They were broken in commit d1af3a5fc102f9bb3464541d83ef0fa4bb2ce2a1
Author Vladimir Glazounov
Date Wed Jun 04 09:02:42 2008 +
INTEGRATION: CWS sw30bf04 (1.4.2); FILE MERGED
It changed the original EUC-KR file encoding to ASCII.
Change-Id: I423b6e7dac0a47ad7688175780f062ecaefb9101
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131027
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/hwpfilter/source/hinfo.h b/hwpfilter/source/hinfo.h
index c0381787f7d9..57067646c856 100644
--- a/hwpfilter/source/hinfo.h
+++ b/hwpfilter/source/hinfo.h
@@ -65,19 +65,19 @@ struct PaperInfo
}
};
-/* ?? ??, */
+/* 페이지 배경색, 배경그림 정보 */
struct PaperBackInfo
{
char type; // 0- background color, 1 - external image, 2- embedded image
char reserved1[8] = {};
-int luminance; /* ( -100 ~ 100 ) */
-int contrast; /* ( -100 ~ 100 ) */
-char effect; /* 0-, 1-, 2- */
+int luminance; /* 밝기 ( -100 ~ 100 ) */
+int contrast; /* 명암 ( -100 ~ 100 ) */
+char effect; /* 0-원래그림, 1-그레이스케일, 2-흑백 */
char reserved2[8] = {};
char filename[260 + 1] = {}; // filename
unsigned char color[3] = {}; //0 - red, 1 - green, 2 - blue
-unsigned short flag; /* 0 - , 1 - , 2 - ??, 3 -
*/
-int range; /* 0-, 1-, 3-??, 4-?? */
+unsigned short flag; /* 0 - 바둑판식, 1 - 가운데로, 2 - 쪽크기, 3 - 용지크기 */
+int range; /* 0-전체, 1-첫페이지, 3-짝수쪽, 4-홀수쪽 */
char reserved3[27] = {};
int size;
std::vector data;// image data
@@ -95,7 +95,7 @@ struct PaperBackInfo
}
};
-/* */
+/* 연결인쇄 정보 */
/**
* Information of printing for chained page
*/
@@ -111,7 +111,7 @@ struct DocChainInfo
}
};
-/* */
+/* 문서 요약 */
/**
* Summary of document
*/
@@ -128,13 +128,13 @@ struct HWPSummary
};
/**
- HWPInfo class?? HWPFile?? ?? ??.
- ?? (layout) ??
- , ?? . \\
+ HWPInfo class는 HWPFile에 대한 정보를 담고 있는 클래스이다.
+ 종이나 여백 등의 레이아웃(layout) 정보는 쪽매기기에서
+ 사용하며, 기타 내부 정보를 포함하고 있다. \\
- HWPInfo HWPFile?? #GetHWPInfo()# ?? ?? .
+ HWPInfo 클래스는 HWPFile의 #GetHWPInfo()# 함수를 통해 얻을 수 있다.
- @memo Hwp
+ @memo Hwp 문서 정보
*/
/**
* Contains the basic information of the hwp document:
@@ -169,12 +169,12 @@ class DLLEXPORT HWPInfo
unsigned char annotation[ANNOTATION_LEN] = {};
short encrypted;
// unsigned charreserved2[6];
-short beginpagenum; /* ?? */
+short beginpagenum; /* 시작페이지 번호 */
/**
* Information about footnote
*/
-short beginfnnum; /* */
-short countfn;/* */
+short beginfnnum; /* 각주시작번호 */
+short countfn;/* 각주 갯수 */
hunit splinetext, splinefn;
hunit spfnfn;
unsigned char fnchar;
@@ -191,7 +191,7 @@ class DLLEXPORT HWPInfo
unsigned char compressed;
unsigned char reserved3;
short info_block_len;
-/* ?? 128 ?? */
+/* 여기까지가 128 바이트이다 */
/**
* Summary of document
*/
@@ -205,7 +205,7 @@ class DLLEXPORT HWPInfo
};
-/* ?? */
+/* 글자 모양 구조체 */
/**
* @short Style of character
*/
@@ -214,14 +214,14 @@ struct CharShape
/**
* Index of character style
*/
-int index; /* . */
+int index; /* 스타일의 인덱스를 저장. */
/**
* Font size
*/
hunit size;
unsigned char font[NLanguage];
unsigned char ratio[NLanguage];
-signed char space[NLanguage]; /* */
+signed char space[NLanguage]; /* 자간 */
unsigned char color[2];
unsigned char shade;
unsigned char attr;
@@ -232,7 +232,7 @@ struct CharShape
CharShape();
};
-/* ?? ?? ?? */
+/* 탭 설정에 대한 구조체 */
#define MAXTABS 40
/**
@@ -278,7 +278,7 @@ struct ParaShape
/**
* Index of paragraph style
*/
-int index; /* */
+int index; /* 스타일의 인덱스를 저장 */
hunit left_margin;
hunit right_margin;
hunit indent;
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hwpreader.cxx | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
New commits:
commit 3dfd6657db5e4a1706004c006ebf6c40b23830f9
Author: Mike Kaganski
AuthorDate: Fri Mar 4 15:30:11 2022 +0300
Commit: Mike Kaganski
CommitDate: Fri Mar 4 22:00:42 2022 +0100
Turn conversion macros to proper functions
Change-Id: I463dff95d81e497bafacb60268288bf7526fb3d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 0f77c8df9746..9bb15364a0c3 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -39,11 +39,6 @@
#include
#include
-// To be shorten source code by realking
-#define WTI(x) (static_cast(x) / 1800.) // unit => inch
-#define WTMM(x) (static_cast(x) / 1800. * 25.4) // unit => mm
-#define WTSM(x) (static_cast((x) / 1800. * 2540)) // unit ==> 1/100
mm
-
// xmloff/xmlkyd.hxx
constexpr OUStringLiteral sXML_CDATA = u"CDATA";
@@ -69,15 +64,9 @@ static char buf[1024];
namespace
{
-
-template
-struct Free
-{
-void operator()(T* const ptr)
-{
-free(ptr);
-}
-};
+double WTI(double x) { return x / 1800.; } // unit => inch
+double WTMM(double x) { return x / 1800. * 25.4; } // unit => mm
+int WTSM(double x) { return x / 1800. * 2540; } // unit ==> 1/100 mm
constexpr OUStringLiteral sBeginOfDoc(u"[\uBB38\uC11C\uC758 \uCC98\uC74C]");
// U+BB38 HANGUL SYLLABLE MUN, U+C11C HANGUL SYLLABLE SEO,
@@ -3439,14 +3428,14 @@ void HwpReader::makeTextBox(TxtBox * hbox)
if (hbox->style.anchor_type != CHAR_ANCHOR)
{
mxList->addAttribute("svg:x", sXML_CDATA,
-OUString::number(WTMM( ( hbox->pgx + hbox->style.margin[0][0]
) )) + "mm");
+OUString::number(WTMM( hbox->pgx + hbox->style.margin[0][0] ))
+ "mm");
mxList->addAttribute("svg:y", sXML_CDATA,
-OUString::number(WTMM( ( hbox->pgy + hbox->style.margin[0][2]
) )) + "mm");
+OUString::number(WTMM( hbox->pgy + hbox->style.margin[0][2] ))
+ "mm");
}
mxList->addAttribute("svg:width", sXML_CDATA,
-OUString::number(WTMM(( hbox->box_xs + hbox->cap_xs) )) + "mm");
+OUString::number(WTMM( hbox->box_xs + hbox->cap_xs )) + "mm");
mxList->addAttribute("fo:min-height", sXML_CDATA,
-OUString::number(WTMM(( hbox->box_ys + hbox->cap_ys) )) + "mm");
+OUString::number(WTMM( hbox->box_ys + hbox->cap_ys )) + "mm");
startEl("draw:text-box");
mxList->clear();
if( hbox->cap_pos % 2 ) /* The caption is on the top
*/
[Libreoffice-bugs] [Bug 107614] Chinese characters are wrongly aligned if 'vpal' feature enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=107614 Julien Nabet changed: What|Removed |Added Status|NEW |NEEDINFO CC||serval2...@yahoo.fr --- Comment #13 from Julien Nabet --- Volga: if it's fixed in Harfbuzz 2.1.1, it should be ok now since 2.3.1 has been in 7.1 and 7.2 Just for the record, 3.2.2 is present on master. Could you give a try to a recent LO version? (7.2.5 or 7.3.0) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/hcode.cxx |8 +
hwpfilter/source/hcode.h |2 +
hwpfilter/source/hwpreader.cxx | 60 +++--
3 files changed, 27 insertions(+), 43 deletions(-)
New commits:
commit 823fe1cb509e80f36744ff948d506ec9eeffb752
Author: Mike Kaganski
AuthorDate: Fri Mar 4 18:57:46 2022 +0300
Commit: Mike Kaganski
CommitDate: Fri Mar 4 21:59:56 2022 +0100
Avoid some sprintf used with colors
Also addresses possible buffer overflow because of possible
color channel values greater than 255 (found by a fuzzer;
likely by some unexpected value of shade exceeding 100; see
https://gerrit.libreoffice.org/c/core/+/130956/3/hwpfilter/source/hcode.cxx#1292)
Change-Id: I168685c3b51cbc8c9f664282bc9378b3c6669ba0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131003
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/hwpfilter/source/hcode.cxx b/hwpfilter/source/hcode.cxx
index 3e9b08086f23..7a00271641b1 100644
--- a/hwpfilter/source/hcode.cxx
+++ b/hwpfilter/source/hcode.cxx
@@ -1288,13 +1288,21 @@ OUString hcolor2str(uchar color, uchar shade, bool
bIsChar)
blue = 0xff;
break;
}
+return rgb2str(red, green, blue);
+}
+
+OUString rgb2str(unsigned char red, unsigned char green, unsigned char blue)
+{
char buf[8];
int n = std::max(sprintf(buf, "#%02x%02x%02x", red, green, blue), 0);
return OUString::createFromAscii(std::string_view(buf, n));
}
+OUString rgb2str(int32_t rgb) { return rgb2str(rgb & 0xff, (rgb >> 8) & 0xff,
(rgb >> 16) & 0xff); }
+
+
::std::string urltounix(const char *src)
{
::std::string ret;
diff --git a/hwpfilter/source/hcode.h b/hwpfilter/source/hcode.h
index 0f8362e0128a..da7ff7345913 100644
--- a/hwpfilter/source/hcode.h
+++ b/hwpfilter/source/hcode.h
@@ -65,6 +65,8 @@ DLLEXPORT ::std::string urltowin(const char *src);
* color인덱스 값과 음영값을 조합하여 스타오피스의 color로 변환
*/
DLLEXPORT OUString hcolor2str(uchar color, uchar shade, bool bIsChar = false);
+DLLEXPORT OUString rgb2str(unsigned char red, unsigned char green, unsigned
char blue);
+DLLEXPORT OUString rgb2str(int32_t rgb);
DLLEXPORT OUString base64_encode_string( const uchar *buf, unsigned int len );
DLLEXPORT double calcAngle(int x1, int y1, int x2, int y2);
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index f971eeae8c58..0f77c8df9746 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -585,32 +585,19 @@ void HwpReader::makeDrawMiscStyle( HWPDrawingObject *hdo )
{
if( prop->center_y == 100 )
{
-sprintf( buf, "#%02x%02x%02x", prop->tocolor & 0xff,
-(prop->tocolor >> 8) & 0xff, (prop->tocolor >>16)
& 0xff );
-mxList->addAttribute( "draw:start-color", sXML_CDATA,
OUString::createFromAscii( buf ));
-sprintf( buf, "#%02x%02x%02x", prop->fromcolor & 0xff,
-(prop->fromcolor >> 8) & 0xff, (prop->fromcolor
>>16) & 0xff );
-mxList->addAttribute( "draw:end-color", sXML_CDATA,
OUString::createFromAscii( buf ));
+mxList->addAttribute( "draw:start-color", sXML_CDATA,
rgb2str( prop->tocolor ));
+mxList->addAttribute( "draw:end-color", sXML_CDATA,
rgb2str( prop->fromcolor ));
}
else
{
-sprintf( buf, "#%02x%02x%02x", prop->fromcolor & 0xff,
-(prop->fromcolor >> 8) & 0xff, (prop->fromcolor
>>16) & 0xff );
-mxList->addAttribute( "draw:start-color", sXML_CDATA,
OUString::createFromAscii( buf ));
-sprintf( buf, "#%02x%02x%02x", prop->tocolor & 0xff,
-(prop->tocolor >> 8) & 0xff, (prop->tocolor >>16)
& 0xff );
-mxList->addAttribute( "draw:end-color", sXML_CDATA,
OUString::createFromAscii( buf ));
+mxList->addAttribute( "draw:start-color", sXML_CDATA,
rgb2str( prop->fromcolor ));
+mxList->addAttribute( "draw:end-color", sXML_CDATA,
rgb2str( prop->tocolor ));
}
}
else
{
-sprintf( buf, "#%02x%02x%02x", prop->tocolor & 0xff,
-(prop->tocolor >> 8) & 0xff, (prop->tocolor >>16) &
0xff );
-mxList->addAttribute( "draw:start-color",
sXML_CDATA,OUString::createFromAscii( buf ));
-
-sprintf( buf, "#%02x%02x%02x", prop->fromcolor & 0xff,
-(prop->fromcolor >> 8) & 0xff, (prop->fromcolor >>16)
& 0xff );
-mxList->addAttribute( "draw:end-color",
sXML_CDATA,OUString::createFromAscii( buf ));
+
[Libreoffice-bugs] [Bug 147772] [wayland] Copy/paste in Basic editor pastes chinese/japanese symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=147772 --- Comment #1 from sunwe...@gmail.com --- Created attachment 178661 --> https://bugs.documentfoundation.org/attachment.cgi?id=178661=edit Video that shows how copy paste works -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147772] New: [wayland] Copy/paste in Basic editor pastes chinese/japanese symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=147772 Bug ID: 147772 Summary: [wayland] Copy/paste in Basic editor pastes chinese/japanese symbols Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sunwe...@gmail.com 1. Open Macros editor 2. Copy something 3. Paste something RESULT NOW: Pastes chinese/japanese symbols instead of what you copied. RESULT EXPECTED: Pastes exactly what was copied. If i copy from KDE's clipboard and then paste it everything pastes as it should. In X11 everything works as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147771] New: Impress. If remove all characters in any cell in the table of attach file, save and reopen then return character
https://bugs.documentfoundation.org/show_bug.cgi?id=147771 Bug ID: 147771 Summary: Impress. If remove all characters in any cell in the table of attach file, save and reopen then return character Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmoll...@us.es Created attachment 178660 --> https://bugs.documentfoundation.org/attachment.cgi?id=178660=edit Impress file with table. I have a impress document that: If I remove all characters in any cell in the table of attached file, save it and reopen it then return the remove characters, all visible other time. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147768] le kb de microsoft ne s'installe pas
https://bugs.documentfoundation.org/show_bug.cgi?id=147768 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Buovjaga --- And what is this KB? Is it perhaps this: https://wiki.documentfoundation.org/Faq/General/General_Installation_Issues_(Windows)#Enable_Windows_Update "Starting from 6.3, failure installing the update will not fail LibreOffice installation, so e.g. stopping Windows Update service while installer is waiting for the update will just show a warning and continue. In this case, it's an indication of Windows Update (system component) malfunction, and it's user's responsibility to ensure that UCRT is installed on system" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117085] [META] Compress image dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=117085 Bug 117085 depends on bug 146929, which changed state. Bug 146929 Summary: Compression settings for images should remember user's choice https://bugs.documentfoundation.org/show_bug.cgi?id=146929 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/osl
sal/osl/w32/file_dirvol.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit ef0e15aaefad8347fc4a3c71771de07e370eda2f Author: Julien Nabet AuthorDate: Fri Mar 4 17:38:21 2022 +0100 Commit: Julien Nabet CommitDate: Fri Mar 4 20:41:31 2022 +0100 Remove useless comment on a commented line since always (sal/w32/file_dirvol) git history gives: commit b76cb86eaa0aec1d02c5ff29c5a43e1e7a675b27 Author: Oliver Bolte Date: Wed Sep 9 09:38:41 2009 + CWS-TOOLING: integrate CWS mhu20 where it was already commented and from sal/osl/w32/file.cxx then digging a bit more gives: commit 73cd79644d4355de483b0d0c04fba034ac02795b Author: Rüdiger Timm Date: Mon Oct 17 13:52:03 2005 + INTEGRATION: CWS perform05 (1.5.52); FILE MERGED where it's also already commented. => No need to keep this Change-Id: I3e8892e8c8f4e76d2e05a8bd158e77418a12eb38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131030 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx index f5995f8de391..dc90f474dcfe 100644 --- a/sal/osl/w32/file_dirvol.cxx +++ b/sal/osl/w32/file_dirvol.cxx @@ -1019,9 +1019,6 @@ oslFileError SAL_CALL osl_getDirectoryItem(rtl_uString *strFilePath, oslDirector CopyMemory(>FindData, , sizeof(WIN32_FIND_DATAW)); pItemImpl->m_sFullPath = strSysFilePath; -// MT: This costs 600ms startup time on fast v60x! -// GetCaseCorrectPathName( pItemImpl->szFullPath, pItemImpl->szFullPath, sizeof(pItemImpl->szFullPath) ); - pItemImpl->uType = DIRECTORYITEM_FILE; *pItem = pItemImpl; }
[Libreoffice-bugs] [Bug 144291] compatibility MS office / libreoffice formulas: 'bar' converts to 'acute'
https://bugs.documentfoundation.org/show_bug.cgi?id=144291 Julien Nabet changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Julien Nabet --- Let's put this one to WFM since no feedback. Of course if you reproduce this with recent LO version (7.2.5 or 7.3.0), don't hesitate to reopen this tracker. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144291] compatibility MS office / libreoffice formulas: 'bar' converts to 'acute'
https://bugs.documentfoundation.org/show_bug.cgi?id=144291
--- Comment #3 from Julien Nabet ---
Created attachment 178659
--> https://bugs.documentfoundation.org/attachment.cgi?id=178659=edit
test docx
On pc Debian x86-64 with LO Debian package 7.3.1.1, I don't reproduce this.
I created a docx containing "{bar {C}} rsub {hkl}" and when reopening it, I
still have {bar {C}} rsub {hkl}
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147755] Can't insert symbols with math editor
https://bugs.documentfoundation.org/show_bug.cgi?id=147755 Arnaud Versini changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Arnaud Versini --- Confirmed on : Version: 7.3.1.1 / LibreOffice Community Build ID: 30(Build:1) CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files
https://bugs.documentfoundation.org/show_bug.cgi?id=140759 --- Comment #8 from Jan-Åke Larsson --- Acrobat reader does not, to my knowledge, display the PDF/A level. You will need a proper verifier to 1) display what PDF/A level a given PDF claims to obey and 2) verify that it obeys that level. verapdf is such a verifier. It is likely not enough to document in the referred page, I did not reach that page when trying to find information on this. Some is better than none I suppose. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108600] Paragraph format: Inconsistent display in space between paragraphs for area fill
https://bugs.documentfoundation.org/show_bug.cgi?id=108600 --- Comment #14 from Thomas Lendo --- Please don't keep the current behavior. As Mike and Regina already said, it's wrong how LO handles that. And in my point of view, it drives me crazy that i have to insert a blank line between two paragraphs (e.g. headings of different hierarchy) with same background color. This shouldn't be necessary. I doubt a new setting is a good idea that looks like the page background filling. It would make the paragraph options more complex. But it's foreseeable that someone will complain that LO has changed it's behavior if there is no way to bring the old behavior back. :-/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147770] New: Need better, more intuitive, Insert Caption behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=147770 Bug ID: 147770 Summary: Need better, more intuitive, Insert Caption behavior Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com If I have a floating image, and I "Insert Caption" on it, what I expect is absolutely no change in the wrapping below or to the sides, no right-to-left movement of the image, but only a small(ish) push-down at the bottom which may result in more wraparound of text, in which we see the footnote text. And - if this is achieved using a new frame, then that frame should inherit the image's wrapping and space around properties with the image itself losing them. Instead, I observe some or all of the following: * Resizing * Movement of the image relative to its original position, even when that's not necessary * Extra padding, or under-padding * More surrounding space than the image had before -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140569] Feature request: Collapsible objects in Normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=140569 --- Comment #18 from Dieter --- (In reply to Eyal Rozenberg from comment #17) > Dieter, with respect - have you not read my explanation why this is not > related to outline view? There was no further comment for almost one year, so my question to Heiko was, if you comment 15 changes his opinion or not. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147769] No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 Eyal Rozenberg changed: What|Removed |Added Keywords||needsUXEval --- Comment #1 from Eyal Rozenberg --- Naturally I would like to see this for character styles, list styles, table styles and page styles as well, but even just for paragraph styles this would be quite the improvement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147769] No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 Eyal Rozenberg changed: What|Removed |Added Blocks||102946 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102946 [Bug 102946] [META] Styles bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102946] [META] Styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102946 Eyal Rozenberg changed: What|Removed |Added Depends on||147769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147769 [Bug 147769] No ability to select all content with a specific style -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147769] New: No ability to select all content with a specific style
https://bugs.documentfoundation.org/show_bug.cgi?id=147769 Bug ID: 147769 Summary: No ability to select all content with a specific style Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Microsoft Word allows one to select all content (or all paragraphs? all text?) with a specific style, or even a specific combination of styles and manual formatting. LO Writer does not seem to offer this capability, even in a limited form. It should. It seems this should mostly be a matter of setting up the UI for this, since LO Writer already offers non-contiguous selection and the ability to find paragraphs with a specified style (even though the latter ability is not sufficiently articulated, see issue 141439). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b96435215a611e3a807c1fd4f365e84bd1b2ba22 Author: Julien Nabet AuthorDate: Fri Mar 4 18:56:17 2022 +0100 Commit: Gerrit Code Review CommitDate: Fri Mar 4 18:56:17 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 9e228842ec7a29bd45b295f88acd65b86a98b1b3 - Typo in accesibilitycheck Change-Id: I3653d1181c954af1224ff810201ac58329293234 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131009 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/helpcontent2 b/helpcontent2 index 01958f0b3eb4..9e228842ec7a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 01958f0b3eb4b87adbfa1f4504180182dd3d5935 +Subproject commit 9e228842ec7a29bd45b295f88acd65b86a98b1b3 commit d17b8d260f1a289140bf6fa25a7ca80a4db1b199 Author: Julien Nabet AuthorDate: Fri Mar 4 18:56:09 2022 +0100 Commit: Gerrit Code Review CommitDate: Fri Mar 4 18:56:09 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 01958f0b3eb4b87adbfa1f4504180182dd3d5935 - Fix typo acessibilitycheckheading Change-Id: Id268a158bbb1e089387cb702d42ffae04e89bfcf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131008 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/helpcontent2 b/helpcontent2 index eacc07e42321..01958f0b3eb4 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit eacc07e423211c32935013e8862d546838746c6d +Subproject commit 01958f0b3eb4b87adbfa1f4504180182dd3d5935
[Libreoffice-commits] help.git: 2 commits - source/text
source/text/swriter/01/accessibility_check.xhp |4 ++-- source/text/swriter/main0106.xhp |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 9e228842ec7a29bd45b295f88acd65b86a98b1b3 Author: Julien Nabet AuthorDate: Fri Mar 4 18:50:41 2022 +0100 Commit: Julien Nabet CommitDate: Fri Mar 4 18:56:16 2022 +0100 Typo in accesibilitycheck Change-Id: I3653d1181c954af1224ff810201ac58329293234 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131009 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/source/text/swriter/01/accessibility_check.xhp b/source/text/swriter/01/accessibility_check.xhp index 27d1244d0..923049f5f 100644 --- a/source/text/swriter/01/accessibility_check.xhp +++ b/source/text/swriter/01/accessibility_check.xhp @@ -10,7 +10,7 @@ --> - + Accessibility Check /text/swriter/01/accessibility_check.xhp commit 01958f0b3eb4b87adbfa1f4504180182dd3d5935 Author: Julien Nabet AuthorDate: Fri Mar 4 18:46:16 2022 +0100 Commit: Julien Nabet CommitDate: Fri Mar 4 18:56:07 2022 +0100 Fix typo acessibilitycheckheading Change-Id: Id268a158bbb1e089387cb702d42ffae04e89bfcf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131008 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/source/text/swriter/01/accessibility_check.xhp b/source/text/swriter/01/accessibility_check.xhp index 218c1e2c2..27d1244d0 100644 --- a/source/text/swriter/01/accessibility_check.xhp +++ b/source/text/swriter/01/accessibility_check.xhp @@ -22,7 +22,7 @@ - + Accessibility Check Review common accessibility problems in the document, and support for PDF/UA specifications in the PDF export dialog. diff --git a/source/text/swriter/main0106.xhp b/source/text/swriter/main0106.xhp index 8ae4724f4..8bd635d8e 100644 --- a/source/text/swriter/main0106.xhp +++ b/source/text/swriter/main0106.xhp @@ -38,7 +38,7 @@ - +
[Libreoffice-bugs] [Bug 140759] PDF/A-1a export not in selection dialog, but the choice PDF/A-1b sometimes exports PDF/A-1a compliant files
https://bugs.documentfoundation.org/show_bug.cgi?id=140759 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Component|Writer |Printing and PDF export CC||dgp-m...@gmx.de --- Comment #7 from Dieter --- Jan-Åke, whre can I see specification in exported PDF (I use Acrobat reader)? Is it sufficient to improve documetation: https://help.libreoffice.org/7.3/en-US/text/shared/01/ref_pdf_export_general.html => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6a858e97bf595e2535daab8f7a3d8c9c64611c2a Author: Olivier Hallot AuthorDate: Fri Mar 4 14:38:52 2022 -0300 Commit: Gerrit Code Review CommitDate: Fri Mar 4 18:38:52 2022 +0100 Update git submodules * Update helpcontent2 from branch 'master' to eacc07e423211c32935013e8862d546838746c6d - Typo in bookmark/hid Change-Id: If07b640c888cac960116c7587f81889b5b33982b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131037 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 5573c118ebe4..eacc07e42321 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 5573c118ebe4b2b5328b328170c21bf77cc9f2e8 +Subproject commit eacc07e423211c32935013e8862d546838746c6d
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/accessibility_check.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eacc07e423211c32935013e8862d546838746c6d Author: Olivier Hallot AuthorDate: Fri Mar 4 14:35:27 2022 -0300 Commit: Olivier Hallot CommitDate: Fri Mar 4 18:38:51 2022 +0100 Typo in bookmark/hid Change-Id: If07b640c888cac960116c7587f81889b5b33982b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131037 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/01/accessibility_check.xhp b/source/text/swriter/01/accessibility_check.xhp index 0decc3f4d..218c1e2c2 100644 --- a/source/text/swriter/01/accessibility_check.xhp +++ b/source/text/swriter/01/accessibility_check.xhp @@ -20,8 +20,8 @@ accessibility;check in text document PDF/UA;check - + Accessibility Check Review common accessibility problems in the document, and support for PDF/UA specifications in the PDF export dialog.
[Libreoffice-bugs] [Bug 140569] Feature request: Collapsible objects in Normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=140569 --- Comment #17 from Eyal Rozenberg --- (In reply to Dieter from comment #16) > Heiko, any further input from your side or should we close it as WONTFIX or > ...? Dieter, with respect - have you not read my explanation why this is not related to outline view? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147765] Calc/Impress/Draw fail to render protected hyphen for Liberation Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=147765 --- Comment #5 from OfficeUser --- In case Eike is right, Calc/Impress/Draw should adopt Writer's replacement scheme. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147765] Calc/Impress/Draw fail to render protected hyphen for Liberation Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=147765 --- Comment #4 from OfficeUser --- Created attachment 178658 --> https://bugs.documentfoundation.org/attachment.cgi?id=178658=edit Installed Liberation font packages. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147765] Calc/Impress/Draw fail to render protected hyphen for Liberation Sans
https://bugs.documentfoundation.org/show_bug.cgi?id=147765 --- Comment #3 from OfficeUser --- All other Applications (including Writer, but also OnlyOffice and Abiword) are not affected by this bug. Additional info: I have installed two packets of the Liberation fonts. I will attache screenshot. The older package is a dependence that OnlyOffice requires. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141110] Modify "No List" icon to show that it applies to more than just bulleted lists
https://bugs.documentfoundation.org/show_bug.cgi?id=141110 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #4 from Dieter --- Rizal, is answer in comment 2 sufficient? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140569] Feature request: Collapsible objects in Normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=140569 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #16 from Dieter --- Heiko, any further input from your side or should we close it as WONTFIX or ...? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
