[Libreoffice-bugs] [Bug 148194] slanted cells do not display correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=148194 --- Comment #1 from Elmar --- Created attachment 179114 --> https://bugs.documentfoundation.org/attachment.cgi?id=179114=edit sheet1 displays incorrectly It would be nice if there were some kind of tool that could "audit" a sheet and identify cases where the sheet metadata does not conform to the standard so that this could be corrected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148194] New: slanted cells do not display correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=148194 Bug ID: 148194 Summary: slanted cells do not display correctly Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@iafrica.com Description: I have columns where the data in the body will be a single character. The heading is 10 or more characters. To conserve space, especially as the sheet can be many pages I want to slope the heading text at 45 degree angle. Steps to Reproduce: 1. type text in cells 2.change cell slope 3. Actual Results: displays incorrectly. Expected Results: should be correctly positioned and not overlap text from different cells Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-GB Module: SpreadsheetDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes NOTE: This seems t be a problem that previously existed but has since been corrected. The original spreadsheet was created in around 2014/6, originally in Excel and then opened in Calc. See the extracted Sheet1 from that file. It had originally not had any formatting, just text. However, when I extracted sheet2 from a file created some years later, originally created in Calc, it displays correctly. If I add a new Sheet3, then copy the cells from Sheet1 to Sheet3 as unformatted text and then format them, it displays correctly. So, why raise this as a bug? Mainly to query how a person would resolve a problem like this. I have a long history of working with these kind of tools (from Visicalc in 1983). I was using a file which was already in ODS format and it was through some experimentation that I found that this might have been a bug in a former version. How does another user of Calc figure this out? My original file has 36 sheets in if many were still raw and I would have a lot of work to fix this. But maybe there are few who would experience this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146320] Base Report generator Java error
https://bugs.documentfoundation.org/show_bug.cgi?id=146320 Lucas changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #13 from Lucas --- Uninstalling previews versions and installing from https://www.libreoffice.org/download/download/ as suggested in Comment 10 solved this problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144869] Feature Request for export format Similar to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=144869 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147924] [UI] Missing icon in colibre icon set
https://bugs.documentfoundation.org/show_bug.cgi?id=147924 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147915] Mirroring of page headers not working in one case
https://bugs.documentfoundation.org/show_bug.cgi?id=147915 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147943] Allow numbering formats when sending Master Document
https://bugs.documentfoundation.org/show_bug.cgi?id=147943 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147943] Allow numbering formats when sending Master Document
https://bugs.documentfoundation.org/show_bug.cgi?id=147943 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144726] Programa Libre Office se cierra inesperadamente
https://bugs.documentfoundation.org/show_bug.cgi?id=144726 --- Comment #2 from QA Administrators --- Dear ramon6419, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146320] Base Report generator Java error
https://bugs.documentfoundation.org/show_bug.cgi?id=146320 --- Comment #12 from Lucas --- I have this problem too. I use OpenSUSE Leap 15.3, LibreOffice 7.2.5.1 and PostgreSQL. Initially I installed OpenOffice from their website but I did not know how to connect to PostgreSQL using JDBC. So I installed LibreOffice through YaST. I connected to PostgreSQL by selecting PostgreSQL option when creating the Libre Office Base database. In Libre Office Base I can open tables and views from PostgreSQL but I cannot run reports. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148170] Calc: setting print range not remember
https://bugs.documentfoundation.org/show_bug.cgi?id=148170 --- Comment #2 from pornchai_...@hotmail.com --- I found this when I'm working with my xls file. I created this file with Calc and save as xls format. And I have set filter to some column in the sheet I do print, but I show all data for that column when print. I tried set print rage to other sheet (sheet B) in same file but no filter, then I previewed to check the setting. I closed and reopened the file with sheet B and check with print preview, the setting pring range is reset. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148193] New: Reading .ods file created by LibreOffice 7.0.4.2 or newer breaks jOpenDocument
https://bugs.documentfoundation.org/show_bug.cgi?id=148193 Bug ID: 148193 Summary: Reading .ods file created by LibreOffice 7.0.4.2 or newer breaks jOpenDocument Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: l...@heess.me Could this bug be caused by LibreOffice: https://bugs.documentfoundation.org/show_bug.cgi?id=139446 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139446] using jOpenDocument-1.3.jar read ods created by LibreOffice 7.0.4.2 has error
https://bugs.documentfoundation.org/show_bug.cgi?id=139446 --- Comment #2 from l...@heess.me --- Hi, I am maintaining a huge software project built with jOpenDocument and because of this error I can't support any of the newer versions of LibreOffice. Any chance this will get fixed or do I have to migrate to a new library all together? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148192] Create a new option External Firebird file under Create new database
https://bugs.documentfoundation.org/show_bug.cgi?id=148192 --- Comment #1 from B. Antonio Fernández --- I am of the same opinion, the user should have the option to create a firebird database to use it as external database -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148192] New: Create a new option External Firebird file under Create new database
https://bugs.documentfoundation.org/show_bug.cgi?id=148192 Bug ID: 148192 Summary: Create a new option External Firebird file under Create new database Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jcs...@libreoffice.org Currently, in the first step of the database wizard, three options are available. When selecting the first option, *Create* a new database, if the experimental functionalities have been enabled, it proposes two options Firebird embedded and HSQLDB embedded (but it does not propose to create an external Firebird archive). However, if we select the third option, Connect to an *existing* database, in the next step, we can connect to an existing Firebird file (by selecting the Browse button) but in addition we have a *Create new* button, which allows us to create a new external Firebird file. This behavior can mislead the user, who does not see the way to create a new Firebird database file in the option that should correspond to it (Create a new database) while the option to create the database is in Connect to an *existing* file. So I believe that adding a new entry under Create new database that allows you to create an external Firebird database and at the same time removing the Create new button from Connect to an existing database would improve the user experience by having the options in the places where they should be expected. In addition, the user would have the two options for creating Firebird databases (embedded and external) in the same place, allowing them to decide which is best option -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148191] New: xlink:href in SVG is deprecated
https://bugs.documentfoundation.org/show_bug.cgi?id=148191 Bug ID: 148191 Summary: xlink:href in SVG is deprecated Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gessos.p...@yahoo.gr Description: According to https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href xlink:href is deprecated for SVG images. But LibreOffice Writer needs it. So, instead of: http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> ... which is deprecated, anyone must use: http://www.w3.org/2000/svg;> ... First, which is deprecated, works on LibreOffice. Second, which is current, does not work. Steps to Reproduce: 1. Follow description 2. 3. Actual Results: . Expected Results: . Reproducible: Always User Profile Reset: No Additional Info: . -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130383] Filesave ODS: Row height after Optimal Height still opens as 1 line instead of 2 in cell F5 (not with XLS/X)
https://bugs.documentfoundation.org/show_bug.cgi?id=130383 --- Comment #13 from Gessel --- I took a screengrab of your demo spreadsheet when I opened it with "enable very large spreadsheets" enabled and it looked like this: https://bug-attachments.documentfoundation.org/attachment.cgi?id=179081 It returned to normal after disabling that option with row heights correct. I suppose there might be some other configuration option that triggers the bug I do not have set and you do, happy to exchange configs for a diff check to see if something pops out. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136358] [META] ODF to OOXML shape export related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136358 Bug 136358 depends on bug 100390, which changed state. Bug 100390 Summary: FILESAVE: OOXML export of cloud shape leaves cloud partially unfilled https://bugs.documentfoundation.org/show_bug.cgi?id=100390 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Bug 108897 depends on bug 100390, which changed state. Bug 100390 Summary: FILESAVE: OOXML export of cloud shape leaves cloud partially unfilled https://bugs.documentfoundation.org/show_bug.cgi?id=100390 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Bug 108226 depends on bug 100390, which changed state. Bug 100390 Summary: FILESAVE: OOXML export of cloud shape leaves cloud partially unfilled https://bugs.documentfoundation.org/show_bug.cgi?id=100390 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 Bug 104520 depends on bug 100390, which changed state. Bug 100390 Summary: FILESAVE: OOXML export of cloud shape leaves cloud partially unfilled https://bugs.documentfoundation.org/show_bug.cgi?id=100390 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136358] [META] ODF to OOXML shape export related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=136358 Bug 136358 depends on bug 147978, which changed state. Bug 147978 Summary: FILESAVE PPTX Cloud shape loses fill after RT https://bugs.documentfoundation.org/show_bug.cgi?id=147978 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109169] [FILESAVE DOCX] Some shapes are not correctly preserved when saved as DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=109169 --- Comment #8 from Regina Henschel --- The shapes "Diamond Bevel" and "Octagon Bevel" are difficult: (A) These shapes have neither a counterpart in the OOXML preset shapes nor in shapes of the binary versions of MS Office. So they need to be exported to an element "custGeom". That export is done in method WriteCustomGeometry. This method cannot export equations or handles, but only exports the current state of the shape outline. Export of equations and handles into "custGeom" is very hard and will not be implemented in the foreseeable future. So we will loose the handles. (B) Because they have no counterpart in the OOXML preset shapes, it will not be possible to recreate them, when the pptx file will be reopened by LO. They will be of type "ooxml-non-primitive". That means the next save to pptx will use WriteCustomGeometry anyway. (C) The export in WriteCustomGeometry is in the meantime (current master!) able to export the lighten/darken commands of the enhanced-path. But the shapes "Diamond Bevel" and "Octagon Bevel" are not implement the same way as the shapes from binary MS Office. "Diamond Bevel" and "Octagon Bevel" shapes are inserted from private://gallery/hidden/imgppt. That Gallery theme is so old, that is does not know anything about the lighten/darken commands. Their lighten/darken is different from the lighten/darken in other shapes. The path does not contain commands for lighten/darken. The shapes are stored in binary format in the Gallery theme so there is no way to add the needed commands. (D) The export to binary MS Office formats does not export them to a shape but to a WMF image. That keeps lighten/darken but looses handles same as export by WriteCustomGeometry. Using WMF image drops the possibility to edit a text in the shape. We could move the two shapes from the list in lcl_IsOnDenylist in /oox/source/export/shapes.cxx to the list in lcl_IsOnAllowlist. That way they would be exported by method WriteCustomGeometry. Currently an export as preset shape is tried and because that fails the default preset shape "rect" is used. Using WriteCustomGeometry would preserve outline and editable text but looses darken/lighten. Using WMF image preserves outline and darken/lighten but you can no longer edit text. Both ways loose handles. @Gabor: What do you think we should do? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142447] Cut, copy, paste and drag operations for folded outlines: include folded content
https://bugs.documentfoundation.org/show_bug.cgi?id=142447 --- Comment #24 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b000d964fcc8849d10576bf3539bde7729db2eb1 tdf#142447 related: SwNavigator: Copy outlines It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142447] Cut, copy, paste and drag operations for folded outlines: include folded content
https://bugs.documentfoundation.org/show_bug.cgi?id=142447 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/uibase/inc/conttree.hxx |1
sw/source/uibase/utlui/content.cxx | 39 +
sw/uiconfig/swriter/ui/navigatorcontextmenu.ui |9 +
3 files changed, 49 insertions(+)
New commits:
commit b000d964fcc8849d10576bf3539bde7729db2eb1
Author: Jim Raykowski
AuthorDate: Sat Feb 5 21:27:33 2022 -0900
Commit: Jim Raykowski
CommitDate: Fri Mar 25 23:18:18 2022 +0100
tdf#142447 related: SwNavigator: Copy outlines
Change-Id: Ibfc173ab6db3d9cbb1e8c59b515c40f1846f1e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129542
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index 2de7dc54f1e2..9f595def2825 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -158,6 +158,7 @@ class SwContentTree final : public SfxListener
voidExecuteContextMenuAction(const OString&
rSelectedPopupEntry);
void DeleteOutlineSelections();
+void CopyOutlineSelections();
size_t GetEntryCount() const;
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index c793f63740bc..619424701fb6 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1426,6 +1426,7 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&,
rCEvt, bool)
bool bRemovePostItEntries = true;
bool bRemoveIndexEntries = true;
+bool bRemoveCopyEntry = true;
bool bRemoveEditEntry = true;
bool bRemoveUnprotectEntry = true;
bool bRemoveDeleteEntry = true;
@@ -1569,6 +1570,7 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&,
rCEvt, bool)
bRemoveSelectEntry = false;
bRemoveChapterEntries = false;
}
+bRemoveCopyEntry = false;
}
else if (!bReadonly && (bEditable || bDeletable))
{
@@ -1704,7 +1706,11 @@ IMPL_LINK(SwContentTree, CommandHdl, const
CommandEvent&, rCEvt, bool)
bRemoveSendOutlineEntry)
xPop->remove("separator1");
+if (bRemoveCopyEntry)
+xPop->remove("copy");
+
if (bRemoveGotoEntry &&
+bRemoveCopyEntry &&
bRemoveSelectEntry &&
bRemoveDeleteEntry &&
bRemoveChapterEntries &&
@@ -4053,6 +4059,8 @@ IMPL_LINK(SwContentTree, KeyInputHdl, const KeyEvent&,
rEvent, bool)
ExecCommand("chapterup", !aCode.IsShift());
else if (aCode.GetCode() == KEY_DOWN)
ExecCommand("chapterdown", !aCode.IsShift());
+else if (aCode.GetCode() == KEY_C)
+CopyOutlineSelections();
else
bConsumed = false;
}
@@ -4168,6 +4176,11 @@ IMPL_LINK(SwContentTree, QueryTooltipHdl, const
weld::TreeIter&, rEntry, OUStrin
void SwContentTree::ExecuteContextMenuAction(const OString&
rSelectedPopupEntry)
{
+if (rSelectedPopupEntry == "copy")
+{
+CopyOutlineSelections();
+return;
+}
if (rSelectedPopupEntry == "collapseallcategories")
{
std::unique_ptr xEntry = m_xTreeView->make_iterator();
@@ -4870,6 +4883,32 @@ static void lcl_AssureStdModeAtShell(SwWrtShell*
pWrtShell)
pWrtShell->EnterStdMode();
}
+void SwContentTree::CopyOutlineSelections()
+{
+m_pActiveShell->LockView(true);
+{
+MakeAllOutlineContentTemporarilyVisible a(m_pActiveShell->GetDoc());
+lcl_AssureStdModeAtShell(m_pActiveShell);
+m_pActiveShell->EnterAddMode();
+size_t nCount = m_xTreeView->get_selected_rows().size();
+m_xTreeView->selected_foreach([this, ](weld::TreeIter& rEntry){
+SwOutlineNodes::size_type nOutlinePos =
reinterpret_cast(
+
m_xTreeView->get_id(rEntry).toInt64())->GetOutlinePos();
+m_pActiveShell->SttSelect();
+m_pActiveShell->MakeOutlineSel(nOutlinePos, nOutlinePos,
+
!m_xTreeView->get_row_expanded(rEntry), false);
+// don't move if this is the last selected outline or the cursor
is at start of para
+if (--nCount && !m_pActiveShell->IsSttPara())
+m_pActiveShell->Right(CRSR_SKIP_CHARS, true, 1, false);
+m_pActiveShell->EndSelect();
+return false;
+});
+m_pActiveShell->LeaveAddMode();
+
m_pActiveShell->GetView().GetViewFrame()->GetBindings().Execute(SID_COPY);
+}
+m_pActiveShell->LockView(false);
+}
+
void SwContentTree::GotoContent(const SwContent* pCnt)
{
m_nLastGotoContentWasOutlinePos = SwOutlineNodes::npos;
diff --git a/sw/uiconfig/swriter/ui/navigatorcontextmenu.ui
b/sw/uiconfig/swriter/ui/navigatorcontextmenu.ui
index e39368556fed..d7619e643fd0 100644
---
[Libreoffice-bugs] [Bug 142447] Cut, copy, paste and drag operations for folded outlines: include folded content
https://bugs.documentfoundation.org/show_bug.cgi?id=142447 --- Comment #23 from Jim Raykowski --- (In reply to Gerry from comment #22) > Hi Jim and Heiko, in case you are not aware: the gerrit patch in comment 19 > seems to got stuck and hasn't yet had any reviewers looking at it. The > pootle bot started complaining "A polite ping, still working on this patch?" H Gerry, I've rebased that patch on top of master and will put it after getting the OK from Jenkins. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/inc
sw/inc/calbck.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4540d0593eea920691849f0b9fc073f6106cefc4
Author: Stephan Bergmann
AuthorDate: Sat Nov 27 16:47:16 2021 +0100
Commit: Andras Timar
CommitDate: Fri Mar 25 22:41:04 2022 +0100
Library_msword needs sw::LegacyModifyHint RTTI now in UBSan build
...since 7d3aadce8d184f72e4785827ad706d27c31a2edb "ofz#41398 drop a para
scheduled for deletion if something else deletes it", causing e.g.
CppunitTest_chart2_export to fail with
> [_RUN_] Chart2ExportTest::testStockChart
[...]
> warn:sal.osl:1981149:1981149:sal/osl/unx/module.cxx:155:
dlopen(/home/sbergman/lo/core/instdir/program/libmswordlo.so, 257):
/home/sbergman/lo/core/instdir/program/libmswordlo.so: undefined symbol:
_ZTIN2sw16LegacyModifyHintE
> warn:sfx.doc:1981149:1981149:sfx2/source/doc/sfxbasemodel.cxx:3147:
Storing has failed, no error is set!
> unknown:0:Chart2ExportTest::testStockChart
>
> An uncaught exception of type com.sun.star.io.IOException
> - SfxBaseModel::impl_store
failed: 0xc10(Error Area:Io Class:Write Code:16)
/home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:3194
/home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:1775
Change-Id: I47ce1c10b7757b27e4279f35d59e34d5312c8b07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125945
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/inc/calbck.hxx b/sw/inc/calbck.hxx
index 7f2224671813..7d185d053710 100644
--- a/sw/inc/calbck.hxx
+++ b/sw/inc/calbck.hxx
@@ -69,7 +69,7 @@ namespace sw
class ClientIteratorBase;
class ListenerEntry;
void ClientNotifyAttrChg(SwModify& rModify, const SwAttrSet& aSet,
SwAttrSet& aOld, SwAttrSet& aNew);
-struct LegacyModifyHint final: SfxHint
+struct SAL_DLLPUBLIC_RTTI LegacyModifyHint final: SfxHint
{
LegacyModifyHint(const SfxPoolItem* pOld, const SfxPoolItem* pNew) :
SfxHint(SfxHintId::SwLegacyModify), m_pOld(pOld), m_pNew(pNew) {};
sal_uInt16 GetWhich() const { return m_pOld ? m_pOld->Which() : m_pNew
? m_pNew->Which() : 0; };
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/layout/data/forcepoint90.rtf |1 + sw/qa/extras/layout/layout.cxx|6 ++ sw/source/core/layout/tabfrm.cxx | 21 +++-- 3 files changed, 26 insertions(+), 2 deletions(-) New commits: commit 8910ab087c90972ce627591fb3206a9434aeac83 Author: Caolán McNamara AuthorDate: Fri Mar 25 20:09:32 2022 + Commit: Caolán McNamara CommitDate: Fri Mar 25 22:29:06 2022 +0100 forcepoint#90 fix crash on layout of specific rtf Change-Id: I17c227ab278ed5a2cc60449d1d005212f00ded89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132128 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/qa/extras/layout/data/forcepoint90.rtf b/sw/qa/extras/layout/data/forcepoint90.rtf new file mode 100644 index ..82c26224292d --- /dev/null +++ b/sw/qa/extras/layout/data/forcepoint90.rtf @@ -0,0 +1 @@ ... etc. - the rest is truncated
[Libreoffice-bugs] [Bug 148190] Support cell-level widow/orphan control
https://bugs.documentfoundation.org/show_bug.cgi?id=148190 --- Comment #1 from Eyal Rozenberg --- The motivation: Similar to paragraph widow-orphan control, but when you have a table row with many paragraphs, so that intra-paragraph widow-orphan settings don't prevent the table from having just a small part on the first page, e.g. one line of contents and the repeating header lines. That looks kind of iffy. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Eyal Rozenberg changed: What|Removed |Added Depends on||148190 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148190 [Bug 148190] Support cell-level widow/orphan control -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148190] New: Support cell-level widow/orphan control
https://bugs.documentfoundation.org/show_bug.cgi?id=148190 Bug ID: 148190 Summary: Support cell-level widow/orphan control Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 103100 LO Writer supports paragraph-level widow/orphan control: Not letting a paragraph have just its first k lines or last k lines separate from all the rest (on a different page). I suggest having a similar feature for table rows, w.r.t. lines within them (or rather, lines within the paragraphs within them): Don't allow a row to break across pages or columns when its first or last part has no more than k lines. Paragraphs are inconsequential here, in the sense that it doesn't matter if the k lines belong to k paragraphs or less-than-k or even a single paragraph. Naturally, per-paragraph widow-orphan settings would also apply. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/layout/data/forcepoint89.html |binary
sw/qa/extras/layout/layout.cxx |6 ++
sw/source/core/layout/layact.cxx |3 ++-
3 files changed, 8 insertions(+), 1 deletion(-)
New commits:
commit 448fa0bc518e0813b26e5d6c6178444b1264
Author: Caolán McNamara
AuthorDate: Fri Mar 25 12:10:32 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 22:02:59 2022 +0100
forcepoint#89 don't remove page with footnote continuation frame
in browse/html/web mode
Change-Id: Ic821dd7f2cc1f47305b5fe2ced16d5168aedc0b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132122
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/extras/layout/data/forcepoint89.html
b/sw/qa/extras/layout/data/forcepoint89.html
new file mode 100644
index ..7998a2b0b979
Binary files /dev/null and b/sw/qa/extras/layout/data/forcepoint89.html differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index d44cceac3eff..38ce7fa2a37b 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2497,6 +2497,12 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testN4LA0OHZ)
createSwDoc(DATA_DIRECTORY, "LIBREOFFICE-N4LA0OHZ.rtf");
}
+//just care it doesn't crash/assert
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint89)
+{
+createSwWebDoc(DATA_DIRECTORY, "forcepoint89.html");
+}
+
CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf118058)
{
SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf118058.fodt");
diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index c7a00139478a..558cbdff22f8 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -296,7 +296,8 @@ bool SwLayAction::RemoveEmptyBrowserPages()
do
{
if ( (pPage->GetSortedObjs() && pPage->GetSortedObjs()->size()) ||
- pPage->ContainsContent() )
+ pPage->ContainsContent() ||
+ pPage->FindFootnoteCont() )
pPage = static_cast(pPage->GetNext());
else
{
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 11 commits - include/connectivity include/ucbhelper include/vcl officecfg/registry readlicense_oo/license sc/qa sc/source sd/qa sd/
include/connectivity/paramwrapper.hxx |2
include/connectivity/sdbcx/VCollection.hxx |2
include/ucbhelper/interactionrequest.hxx |6
include/vcl/IDialogRenderable.hxx |2
include/vcl/customweld.hxx |1
include/vcl/metaact.hxx|8
officecfg/registry/schema/org/openoffice/Office/Common.xcs |6
readlicense_oo/license/CREDITS.fodt| 3847 ++---
sc/qa/unit/data/ods/too-many-cols-rows.ods |binary
sc/qa/unit/subsequent_filters_test2.cxx| 17
sc/source/filter/xml/xmlcelli.cxx |6
sc/source/ui/view/spellcheckcontext.cxx|4
sd/qa/unit/data/pptx/deftabstop.pptx |binary
sd/qa/unit/import-tests2.cxx | 14
sd/source/ui/docshell/docshel4.cxx | 12
sfx2/source/control/charwin.cxx|3
svl/source/passwordcontainer/passwordcontainer.cxx | 41
svl/source/passwordcontainer/passwordcontainer.hxx |6
sw/qa/core/data/rtf/fail/forcepoint-82.rtf | 28
sw/qa/extras/rtfexport/data/tdf111851.rtf | 17
sw/qa/extras/rtfexport/rtfexport4.cxx | 36
sw/source/ui/config/optpage.cxx|6
uui/source/iahndl-authentication.cxx |5
writerfilter/source/dmapper/DomainMapperTableManager.cxx |2
writerfilter/source/rtftok/rtfdispatchvalue.cxx| 136
25 files changed, 2206 insertions(+), 2001 deletions(-)
New commits:
commit cac6cd38944fd6375e1f1d754afe60e02b979956
Author: Andras Timar
AuthorDate: Tue Jul 20 11:54:05 2021 +0200
Commit: Andras Timar
CommitDate: Fri Mar 25 21:54:06 2022 +0100
these classes are used from non-merged libs
I found this bug with debug / ASAN build of LOKit. During startup:
program/libsclo.so: undefined symbol: _ZTIN3vcl23ILibreOfficeKitNotifierE
program/libfilelo.so: undefined symbol:
_ZTIN12connectivity5sdbcx17IObjectCollectionE
etc.
Change-Id: I2eb80d0b3002f174deea0d8657cb0cdbdec5be8f
diff --git a/include/connectivity/paramwrapper.hxx
b/include/connectivity/paramwrapper.hxx
index bf16e0851fcb..b862a619af85 100644
--- a/include/connectivity/paramwrapper.hxx
+++ b/include/connectivity/paramwrapper.hxx
@@ -49,7 +49,7 @@ namespace dbtools::param
/** wraps a parameter column as got from an SQLQueryComposer, so that it
has an additional
property "Value", which is forwarded to an XParameters interface
*/
-class UNLESS_MERGELIBS(OOO_DLLPUBLIC_DBTOOLS) ParameterWrapper final :
public ::cppu::OWeakObject
+class OOO_DLLPUBLIC_DBTOOLS ParameterWrapper final : public
::cppu::OWeakObject
,public css::lang::XTypeProvider
,public ::comphelper::OMutexAndBroadcastHelper
,public ::cppu::OPropertySetHelper
diff --git a/include/connectivity/sdbcx/VCollection.hxx
b/include/connectivity/sdbcx/VCollection.hxx
index ab0dd3bcc828..a2f8a821fa33 100644
--- a/include/connectivity/sdbcx/VCollection.hxx
+++ b/include/connectivity/sdbcx/VCollection.hxx
@@ -58,7 +58,7 @@ namespace connectivity::sdbcx
typedef css::uno::Reference< css::beans::XPropertySet > ObjectType;
-class UNLESS_MERGELIBS(OOO_DLLPUBLIC_DBTOOLS) SAL_NO_VTABLE
IObjectCollection
+class OOO_DLLPUBLIC_DBTOOLS SAL_NO_VTABLE IObjectCollection
{
public:
virtual ~IObjectCollection();
diff --git a/include/ucbhelper/interactionrequest.hxx
b/include/ucbhelper/interactionrequest.hxx
index 78fc31f7a23b..16e9eda38b96 100644
--- a/include/ucbhelper/interactionrequest.hxx
+++ b/include/ucbhelper/interactionrequest.hxx
@@ -222,7 +222,7 @@ public:
* along with an interaction request to indicate the possibility to approve
* the request.
*/
-class UNLESS_MERGELIBS(UCBHELPER_DLLPUBLIC) InteractionApprove final : public
InteractionContinuation,
+class UCBHELPER_DLLPUBLIC InteractionApprove final : public
InteractionContinuation,
public css::lang::XTypeProvider,
public css::task::XInteractionApprove
{
@@ -255,7 +255,7 @@ public:
* along with an interaction request to indicate the possibility to disapprove
* the request.
*/
-class UNLESS_MERGELIBS(UCBHELPER_DLLPUBLIC) InteractionDisapprove final :
public InteractionContinuation,
+class UCBHELPER_DLLPUBLIC InteractionDisapprove final : public
InteractionContinuation,
public css::lang::XTypeProvider,
public css::task::XInteractionDisapprove
{
@@ -288,7 +288,7 @@ public:
* passed along with an authentication
[Libreoffice-bugs] [Bug 142447] Cut, copy, paste and drag operations for folded outlines: include folded content
https://bugs.documentfoundation.org/show_bug.cgi?id=142447 --- Comment #22 from Gerry --- Hi Jim and Heiko, in case you are not aware: the gerrit patch in comment 19 seems to got stuck and hasn't yet had any reviewers looking at it. The pootle bot started complaining "A polite ping, still working on this patch?" Btw: Is there a chance that outline folding gets out of experimental mode for LibreOffice 7.4? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114637] Autocorrect should fully support Hebrew-specific punctuation marks
https://bugs.documentfoundation.org/show_bug.cgi?id=114637 Eyal Rozenberg changed: What|Removed |Added Depends on||148189 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148189 [Bug 148189] Autocorrect hyphen/minus sign into Hebrew Maqaf when appropriate -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148189] New: Autocorrect hyphen/minus sign into Hebrew Maqaf when appropriate
https://bugs.documentfoundation.org/show_bug.cgi?id=148189 Bug ID: 148189 Summary: Autocorrect hyphen/minus sign into Hebrew Maqaf when appropriate Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eyalr...@gmx.com Blocks: 114637 The Hebrew language uses a character named Maqaf - essentially a top hyphen - instead of the latin languages' inter-word hyphen. It is not a dash (neither en nor em), and is not used as a minus sign. More about this character: https://codepoints.net/U+05BE and here's an example: אבי־סער the Maqaf separates the two words. The character does not have its own key on a Hebrew-layout keyboard; and use of hyphens in its stead is quite popular by now, so it is no longer in wide use by people typing in text... unfortunately. It can be inserted using Alt+underscore in a Hebrew-layout keyboard on Linux, and is rendered properly, but that is still not good enough. The Auto-correct mechanism, when enabled, should replace a hyphen/minus character with a Maqaf when one types in a sequence of at least two Hebrew characters, then a hyphen, then another sequence of at least 2 Hebrew characters. Typing just one character, or mixing in non-Hebrew characters, or using spaces, should not result in the replacement, to keep things on the conservative side. Note: I've split this off from bug 114637, which now becomes a meta-bug, because this capability is self-contained enough and important enough to merit its own bug. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114637 [Bug 114637] Autocorrect should fully support Hebrew-specific punctuation marks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148167] Writer does not display SVG file correctly when inserted as image
https://bugs.documentfoundation.org/show_bug.cgi?id=148167 --- Comment #5 from Gerry --- Created attachment 179112 --> https://bugs.documentfoundation.org/attachment.cgi?id=179112=edit SVG-in-Firefox-top_and_LibreOffice73_bottom.png Thanks Xisco for the Screenshots of the SVG in Firefox and Libreoffice. I assume that Xisco does not have the font Calibri installed, thus here is another screenshot from a system that has Calibri installed: The SVG in Firefox (top) & in LibreOffice 7.3.1.3 (bottom). Both screenshots, Xisco's and mine, shows the bug in the right grey box in the svg drawing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148080] UI: Dialog "Rename Slide" should name "Rename Page"
https://bugs.documentfoundation.org/show_bug.cgi?id=148080 --- Comment #9 from lol --- (In reply to Dave Barton from comment #5) > Yes it appears to be an error in the procedure/function called from the main > menu "Page -> Rename Page" option. Maybe I find the reason why you couldn't reproduce the bug at first. Did you clicked first on the page in the page pane? See the different steps. Steps: 1. Open Draw 2. Open the dialog via Page - Rename Page... 3. Dialog appears with the title "Rename Slide" Steps: 1. Open Draw 1a. Click on the page in the Page Pane 2. Open the dialog via Page - Rename Page... 3. Dialog appears with the title "Rename Page" If the focus is on the page in the page pane the dialog has a another title. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source
sw/source/ui/table/instable.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit a4e7cc2a12ca3ea90ec21de96aa038f2447b40f8 Author: Mert Tumer AuthorDate: Fri Mar 25 17:56:30 2022 +0300 Commit: Gökay ŞATIR CommitDate: Fri Mar 25 19:39:10 2022 +0100 make default selected table style to Default Table Style for only online unfortunately when the table has a style sw/qa/uitest/writer_tests4/tdf115573.py fails because tables that have pre-applied style resets the style of the elements in their cells when a new row is inserted and the ui test above relies on that. For now this is LOK only Signed-off-by: Mert Tumer Change-Id: I2f60376fc2d929498aef45259a5ef291922ccdcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132124 Tested-by: Jenkins CollaboraOffice Reviewed-by: Gökay ŞATIR diff --git a/sw/source/ui/table/instable.cxx b/sw/source/ui/table/instable.cxx index 94e29d28665d..1a3bafb14dc2 100644 --- a/sw/source/ui/table/instable.cxx +++ b/sw/source/ui/table/instable.cxx @@ -149,8 +149,13 @@ void SwInsTableDlg::InitAutoTableFormat() // Change this min variable if you add autotable manually. minTableIndexInLb = 1; maxTableIndexInLb = minTableIndexInLb + static_cast(pTableTable->size()); -m_xLbFormat->select( minTableIndexInLb ); -tbIndex = lbIndexToTableIndex( minTableIndexInLb ); +// 1 means default table style +// unfortunately when the table has a style sw/qa/uitest/writer_tests4/tdf115573.py fails +// because tables that have pre-applied style resets the style of the elements in their cells +// when a new row is inserted and the ui test above relies on that. For now this is LOK only +lbIndex = comphelper::LibreOfficeKit::isActive() ? 1 : 0; +m_xLbFormat->select( lbIndex ); +tbIndex = lbIndexToTableIndex(lbIndex); SelFormatHdl( *m_xLbFormat ); }
[Libreoffice-bugs] [Bug 108911] Cannot toggle cursor focus between formula and worksheet
https://bugs.documentfoundation.org/show_bug.cgi?id=108911 --- Comment #10 from Rick Collins --- The problem is still present. It also interferes with editing or adding a reference to a cell immediately adjacent to the cell being edited. If the formula is large enough, the editing field over the cell being edited blocks viewing the adjacent cells. This makes it impossible to click on it with the cursor. Without being able to use the arrow keys to select the cell, the only choice remaining is to type the cell reference manually. I would have expected this to not take so long to fix. I'm sure this impacts a lot of users and is rather a headache. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148186] Potentially confusing text label on Base Database Wizard when connecting to a Firebird file
https://bugs.documentfoundation.org/show_bug.cgi?id=148186 Robert Großkopf changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Robert Großkopf --- (In reply to Steve Fanning from comment #0) > 4. At Step 2 of the Database Wizard, notice the legend positioned above the > text field. It reads "Datasource URL (e.g. host=$host=$host:$port > dbname=$database)". This has been changed from LO 7.2.5 to LO 7.3.2. Now there appears: "Enter the DBMS/driver-specific connection string here". This should be better something like: "Enter or choose the URL to the Firebird file here". Used version here: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148188] Distribute Selection not working correctly when shadows are enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148188 --- Comment #1 from Rafael Lima --- Created attachment 179111 --> https://bugs.documentfoundation.org/attachment.cgi?id=179111=edit Sample ODP file This is the sample ODP file I used in the video. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148188] New: Distribute Selection not working correctly when shadows are enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=148188 Bug ID: 148188 Summary: Distribute Selection not working correctly when shadows are enabled Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 179110 --> https://bugs.documentfoundation.org/attachment.cgi?id=179110=edit Video showing the bug In Impress/Draw, if you select 3 or more objects, right-click them and go to Distribute Selection > Horizontally Spacing, the objects should be re-positioned so that the horizontal spacing between them is the same. This works nicely when objects do not have shadows. However, when shadows are enabled, the horizontal spacing is calculated incorrectly. See the attached video where I use 2 sets with three rectangles each. The first set does not have shadows and horizontal spacing works fine. Enabling shadows in the second set of rectangles breaks spacing calculations. Steps to reproduce: 1) Open the attached sample ODP file 2) Select the 3 rectangles without shadows 3) Go to Distribute Selection > Horizontally Spacing 4) Notice the three rectangles are spaced evenly (which is expected) 5) Now select the three rectangles with shadows 6) Go to Distribute Selection > Horizontally Spacing 7) Notice that the spacing between rectangles is not the same System info: Version: 7.3.1.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.1~rc3-0ubuntu0.21.10.1~lo2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105446] Copying forms not working anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105446 --- Comment #10 from Kevin Geller --- I am a tech blogger. I write tech articles that solve problems related to software and hardware. The site https://enhau.com/ has many articles that help people solve their problems. Just visit this site it might help solve th bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132106] CELL() function "format" should include more date formats to return "D1" (or a new "D0")
https://bugs.documentfoundation.org/show_bug.cgi?id=132106 --- Comment #15 from peter.hy...@gmail.com --- I'm not entirely sure if its related, but when I open a Excel document that dropped in `[$-en-US]` prefixes to the number values, especially date formats, it doesn't get read properly by Calc. Is this issue close enough? Or should I open a new issue about the problems with using the format prefixes in Calc? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148187] page numbering does not work when setting a start value
https://bugs.documentfoundation.org/show_bug.cgi?id=148187 --- Comment #2 from auch.wich...@posteo.de --- Created attachment 179109 --> https://bugs.documentfoundation.org/attachment.cgi?id=179109=edit page numbers are not ok with offset -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148187] page numbering does not work when setting a start value
https://bugs.documentfoundation.org/show_bug.cgi?id=148187 --- Comment #1 from auch.wich...@posteo.de --- Created attachment 179108 --> https://bugs.documentfoundation.org/attachment.cgi?id=179108=edit page numbers are ok without offset -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148187] New: page numbering does not work when setting a start value
https://bugs.documentfoundation.org/show_bug.cgi?id=148187 Bug ID: 148187 Summary: page numbering does not work when setting a start value Product: LibreOffice Version: 7.2.6.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: auch.wich...@posteo.de Description: In a multi-page document the page numbering in the header or footer does not work if a start value n is given. No page number is displayed for the last n pages. Steps to Reproduce: 1. Create a new multi-page document. 2. Set a page header or footer (Insert - Header and Footer - ...) and insert a page number (Insert - Page Count) 3. Change the start number (Edit - Fields, Page number - Offsets) Actual Results: If you set an offset of e.g. 3 the last 3 pages will not show any page numbers Expected Results: The last pages should show a page number Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.2.6.2 / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148186] New: Potentially confusing text label on Base Database Wizard when connecting to a Firebird file
https://bugs.documentfoundation.org/show_bug.cgi?id=148186 Bug ID: 148186 Summary: Potentially confusing text label on Base Database Wizard when connecting to a Firebird file Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stevemfanning...@gmail.com Description: When connecting to a Firebird file via the Database Wizard, there is a text field for entry of the file's location. The legend adjacent to this field is "Datasource URL (e.g. host=$host=$host:$port dbname=$database)". The text of this legend may have been copied/pasted from a similar field for creating a JDBC connection but is very likely to confuse users in this context. Consider replacing this text when connecting to a Firebird file with something simpler and more relevant, such as "File location". Steps to Reproduce: 1. In any LO component, select File > New > Database on Menu bar. 2. At Step 1 of the Database Wizard, click the "Connect to an existing database" option and select the "Firebird File" entry in the adjacent drop-down menu. 3. Click the "Next" button. 4. At Step 2 of the Database Wizard, notice the legend positioned above the text field. It reads "Datasource URL (e.g. host=$host=$host:$port dbname=$database)". Actual Results: Not applicable Expected Results: Not applicable Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2 (x64) / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 6; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_GB); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143192] 'Format' Basic function doesn't handle Null values
https://bugs.documentfoundation.org/show_bug.cgi?id=143192 --- Comment #2 from Paris Oplopoios --- I am trying to work on tdf#143193. Is Null supposed to be a correct data type? It doesn't seem to recognize it as one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 --- Comment #7 from Dieter --- (In reply to Eyal Rozenberg from comment #6) > Shall I try to run it from a terminal and see if I get > some interesting output? Don't know, sorry. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) or change Default to Point
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 --- Comment #9 from Luke --- (In reply to Heiko Tietze from comment #8) > (In reply to Heiko Tietze from comment #3) > Don't see why this needs to be an extra ticket. Only if you fix this by a overly complex workaround. Following the industry standard of using a point, like Word and Word Prefect would eliminate the need for the user to manually manage the complexity of changing units. Why shift this burden to the User? Why not use the industry standard unit here? We are doing it wrong. As a result it creates problems for the user that don't exist in other productivity suites. Change the unit to point. Don't force the user to juggle units that don't make sense for the measurement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 --- Comment #6 from Eyal Rozenberg --- (In reply to Dieter from comment #5) > Correct, so I don't understand, why "Update Selected Style" doesn't work for > you, if cursor is in second paragraph. I don't know either... it just doesn't work. Maybe it's something with the nightly I'm using? Shall I try to run it from a terminal and see if I get some interesting output? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147582] PostgreSQL JDBC: Form with Subform and SubSubform gives Parameter Error for SubSubForm
https://bugs.documentfoundation.org/show_bug.cgi?id=147582 Alex Thurgood changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Alex Thurgood --- This is the error I get on opening the JDBC connected form: Statut SQL: 42883 ERROR: operator does not exist: integer = character varying Indice : No operator matches the given name and argument type(s). You might need to add explicit type casts. Position : 79 and then indeed, there is no connection to the subsubform if no subform data is provided beforehand. Confirming. -- You are receiving this mail because: You are the assignee for the bug.
Re: 回复：回复：回复：回复：回复：libreoffice-7.3.2 compile in arm system
On 25/03/2022 12.34, gcxyw1314 wrote: Are you talking about question 2? I mean these questions: Some questions to try to narrow the issue down: Can you please try whether the same happens with the current git master branch instead of 7.3 (run "make distclean" first after switching branches), and if so, submit a more detailed error output to paste.debian.net, with the expiration date set to "never"? What does your autogen.input look like? Or if you're not using that, what options are you passing to `./autogen.sh`? This is on CentOS 7.7, aarch64 architecture, right? Can you share the file `config.log` from your build directory? But I am https://bug-attachments.documentfoundation.org/attachment.cgi?id=172646 No modification method was found above, so I compiled on 7.06 and didn't encounter this error, Where does that patch come from? Is there a related Bugzilla issue it is attached to? and: Also, did the patch you mention change anything (or was the error just the same before)? OpenPGP_signature Description: OpenPGP digital signature
[Libreoffice-commits] core.git: Branch 'feature/sparklines' - include/xmloff sc/CppunitTest_sc_sparkline_test.mk schema/libreoffice sc/inc sc/Library_sc.mk sc/qa sc/source xmloff/source
Rebased ref, commits from common ancestor:
commit 6af8a63e62cd2f0c800f8dfc364355d19b10a1db
Author: Tomaž Vajngerl
AuthorDate: Fri Mar 25 14:53:48 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Mar 26 01:41:36 2022 +0900
sc: sparkline import/export for ODF
Change-Id: I0d8293cdd35cc8c7afab98efac0a28a3613d122b
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 4f7cd7e148a4..dc7c930f0e2a 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -449,8 +449,16 @@ namespace xmloff::token {
XML_CODEBASE,
XML_COLLAPSE,
XML_COLOR,
+XML_COLOR_AXIS,
+XML_COLOR_FIRST,
+XML_COLOR_HIGH,
XML_COLOR_INVERSION,
+XML_COLOR_LAST,
+XML_COLOR_LOW,
+XML_COLOR_MARKERS,
XML_COLOR_MODE,
+XML_COLOR_NEGATIVE,
+XML_COLOR_SERIES,
XML_COLOR_SCALE,
XML_COLOR_SCALE_ENTRY,
XML_COLOR_TABLE,
@@ -593,6 +601,7 @@ namespace xmloff::token {
XML_DATA_PILOT_TABLE,
XML_DATA_PILOT_TABLES,
XML_DATA_POINT,
+XML_DATA_RANGE,
XML_DATA_STREAM_SOURCE,
XML_DATA_STYLE,
XML_DATA_STYLE_NAME,
@@ -609,6 +618,7 @@ namespace xmloff::token {
XML_DATABASE_SOURCE_TABLE,
XML_DATABASE_TABLE_NAME,
XML_DATE,
+XML_DATE_AXIS,
XML_DATE_IS,
XML_DATE_ADJUST,
XML_DATE_STYLE,
@@ -668,12 +678,15 @@ namespace xmloff::token {
XML_DISPLAY_DETAILS,
XML_DISPLAY_DUPLICATES,
XML_DISPLAY_EMPTY,
+XML_DISPLAY_EMPTY_CELLS_AS,
XML_DISPLAY_FILTER_BUTTONS,
XML_DISPLAY_FORMULA,
+XML_DISPLAY_HIDDEN,
XML_DISPLAY_LABEL,
XML_DISPLAY_LEVELS,
XML_DISPLAY_NAME,
XML_DISPLAY_OUTLINE_LEVEL,
+XML_DISPLAY_X_AXIS,
XML_DISSOLVE,
XML_DISTANCE,
XML_DISTANCE_AFTER_SEP,
@@ -1180,6 +1193,7 @@ namespace xmloff::token {
XML_LINE_SKEW,
XML_LINE_SPACING,
XML_LINE_STYLE,
+XML_LINE_WIDTH,
XML_LINEAR,
XML_LINEARGRADIENT,
XML_LINENUMBERING_CONFIGURATION,
@@ -1207,6 +1221,7 @@ namespace xmloff::token {
XML_LOGARITHMIC,
XML_LOGBASE,
XML_LONG,
+XML_LOW,
XML_LOWLIMIT,
XML_LR_TB,
XML_LT,
@@ -1220,6 +1235,8 @@ namespace xmloff::token {
XML_MALIGNGROUP,
XML_MALIGNMARK,
XML_MANUAL,
+XML_MANUAL_MIN,
+XML_MANUAL_MAX,
XML_MAP,
XML_MARGIN_BOTTOM,
XML_MARGIN_LEFT,
@@ -1227,6 +1244,7 @@ namespace xmloff::token {
XML_MARGIN_TOP,
XML_MARGINS,
XML_MARKER,
+XML_MARKERS,
XML_MARKER_END,
XML_MARKER_END_CENTER,
XML_MARKER_END_WIDTH,
@@ -1245,6 +1263,7 @@ namespace xmloff::token {
XML_MATRIX_COVERED,
XML_MATRIXROW,
XML_MAX,
+XML_MAX_AXIS_TYPE,
XML_MAX_EDGE,
XML_MAX_HEIGHT,
XML_MAX_LENGTH,
@@ -1270,6 +1289,7 @@ namespace xmloff::token {
XML_MIDDLE,
XML_MIME_TYPE,
XML_MIN,
+XML_MIN_AXIS_TYPE,
XML_MIN_DENOMINATOR_DIGITS,
XML_MIN_EDGE,
XML_MIN_EXPONENT_DIGITS,
@@ -1344,6 +1364,7 @@ namespace xmloff::token {
XML_NAMED_RANGE,
XML_NAVIGATION_MODE,
XML_NAVY,
+XML_NEGATIVE,
XML_NEGATIVE_COLOR,
XML_NEQ,
XML_NEW,
@@ -1605,6 +1626,7 @@ namespace xmloff::token {
XML_RIGHT,
XML_RIGHT_OUTSIDE,
XML_RIGHT_TEXT,
+XML_RIGHT_TO_LEFT,
XML_RIGHTARC,
XML_RIGHTCIRCLE,
XML_RING,
@@ -1759,6 +1781,10 @@ namespace xmloff::token {
XML_SOURCE_RANGE_ADDRESS,
XML_SOURCE_SERVICE,
XML_SPACE_BEFORE,
+XML_SPARKLINE_GROUPS,
+XML_SPARKLINE_GROUP,
+XML_SPARKLINES,
+XML_SPARKLINE,
XML_SPAN,
XML_SPECULAR,
XML_SPECULAR_COLOR,
diff --git a/sc/CppunitTest_sc_sparkline_test.mk
b/sc/CppunitTest_sc_sparkline_test.mk
index 499eaaf4ea38..a3e8078a9b83 100644
--- a/sc/CppunitTest_sc_sparkline_test.mk
+++ b/sc/CppunitTest_sc_sparkline_test.mk
@@ -18,6 +18,12 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sc_sparkline_test, \
sc/qa/unit/SparklineTest \
))
+$(eval $(call gb_CppunitTest_use_externals,sc_sparkline_test, \
+boost_headers \
+mdds_headers \
+libxml2 \
+))
+
$(eval $(call gb_CppunitTest_use_libraries,sc_sparkline_test, \
basegfx \
comphelper \
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 2c78147abf62..e97f6e04b4c2 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -293,6 +293,8 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/core/tool/webservicelink \
sc/source/core/tool/zforauto \
sc/source/filter/xml/datastreamimport \
+
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/uicalc/uicalc.cxx | 36
1 file changed, 36 insertions(+)
New commits:
commit 1d4c4e82f1704eb66fb130ae03ee9ad28ddb2067
Author: Xisco Fauli
AuthorDate: Fri Mar 25 12:20:40 2022 +0100
Commit: Xisco Fauli
CommitDate: Fri Mar 25 17:42:01 2022 +0100
tdf#113541: sc_uicalc: Add unittest
Change-Id: I8c2e2b531ef31b834d7431543c94acfb67ff9ae2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132113
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 90bafa91f64e..917ef6b2d9b9 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -380,6 +380,42 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf103994)
CPPUNIT_ASSERT_EQUAL(1.0, pDoc->GetValue(ScAddress(1, 0, 0)));
}
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf113541)
+{
+mxComponent = loadFromDesktop("private:factory/scalc");
+ScModelObj* pModelObj = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pModelObj);
+ScDocument* pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+insertStringToCell(*pModelObj, "A1", "50");
+
+// Save the document
+utl::TempFile aTempFile = save(mxComponent, "calc8");
+
+// Open a new document
+mxComponent = loadFromDesktop("private:factory/scalc");
+pModelObj = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pModelObj);
+pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+// Change grammar to Excel A1
+pDoc->SetGrammar(formula::FormulaGrammar::GRAM_ENGLISH_XL_A1);
+
+// Insert the reference to the external document
+OUString aFormula = "=['" + aTempFile.GetURL() + "']Sheet1!A1";
+insertStringToCell(*pModelObj, "A1", aFormula.toUtf8().getStr());
+
+// Without the fix in place, this test would have failed with
+// - Expected: 50
+// - Actual : Err:507
+CPPUNIT_ASSERT_EQUAL(OUString("50"), pDoc->GetString(ScAddress(0, 0, 0)));
+
+// Change grammar to default
+pDoc->SetGrammar(formula::FormulaGrammar::GRAM_ENGLISH);
+}
+
CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf126577)
{
mxComponent = loadFromDesktop("private:factory/scalc");
[Libreoffice-commits] core.git: Branch 'feature/sparklines' - 2 commits - include/xmloff oox/source sc/CppunitTest_sc_sparkline_test.mk schema/libreoffice sc/inc sc/Library_sc.mk sc/qa sc/source test/
include/xmloff/xmltoken.hxx | 26
oox/source/core/xmlfilterbase.cxx |2
oox/source/token/namespaces-strict.txt |1
oox/source/token/namespaces.hxx.tail|1
oox/source/token/namespaces.txt |1
oox/source/token/tokens.txt |1
sc/CppunitTest_sc_sparkline_test.mk |6
sc/Library_sc.mk|2
sc/inc/SparklineGroup.hxx | 10
sc/qa/unit/SparklineImportExportTest.cxx| 87 ++-
sc/source/filter/excel/excdoc.cxx |1
sc/source/filter/excel/export/SparklineExt.cxx |6
sc/source/filter/oox/SparklineFragment.cxx |3
sc/source/filter/xml/SparklineGroupsExport.cxx | 222
sc/source/filter/xml/SparklineGroupsExport.hxx | 48 +
sc/source/filter/xml/SparklineGroupsImportContext.cxx | 332
sc/source/filter/xml/SparklineGroupsImportContext.hxx | 61 ++
sc/source/filter/xml/xmlexprt.cxx | 15
sc/source/filter/xml/xmlexprt.hxx |1
sc/source/filter/xml/xmltabi.cxx|5
schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng | 165 +
test/source/xmltesttools.cxx|2
xmloff/source/core/xmltoken.cxx | 28 -
xmloff/source/token/tokens.txt | 26
24 files changed, 1044 insertions(+), 8 deletions(-)
New commits:
commit 88214d0f7d55e4b1ccced5f1ec0790d446da8ab6
Author: Tomaž Vajngerl
AuthorDate: Fri Mar 25 14:53:48 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Mar 26 01:37:27 2022 +0900
sc: sparkline import/export for ODF
Change-Id: I0d8293cdd35cc8c7afab98efac0a28a3613d122b
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 4f7cd7e148a4..dc7c930f0e2a 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -449,8 +449,16 @@ namespace xmloff::token {
XML_CODEBASE,
XML_COLLAPSE,
XML_COLOR,
+XML_COLOR_AXIS,
+XML_COLOR_FIRST,
+XML_COLOR_HIGH,
XML_COLOR_INVERSION,
+XML_COLOR_LAST,
+XML_COLOR_LOW,
+XML_COLOR_MARKERS,
XML_COLOR_MODE,
+XML_COLOR_NEGATIVE,
+XML_COLOR_SERIES,
XML_COLOR_SCALE,
XML_COLOR_SCALE_ENTRY,
XML_COLOR_TABLE,
@@ -593,6 +601,7 @@ namespace xmloff::token {
XML_DATA_PILOT_TABLE,
XML_DATA_PILOT_TABLES,
XML_DATA_POINT,
+XML_DATA_RANGE,
XML_DATA_STREAM_SOURCE,
XML_DATA_STYLE,
XML_DATA_STYLE_NAME,
@@ -609,6 +618,7 @@ namespace xmloff::token {
XML_DATABASE_SOURCE_TABLE,
XML_DATABASE_TABLE_NAME,
XML_DATE,
+XML_DATE_AXIS,
XML_DATE_IS,
XML_DATE_ADJUST,
XML_DATE_STYLE,
@@ -668,12 +678,15 @@ namespace xmloff::token {
XML_DISPLAY_DETAILS,
XML_DISPLAY_DUPLICATES,
XML_DISPLAY_EMPTY,
+XML_DISPLAY_EMPTY_CELLS_AS,
XML_DISPLAY_FILTER_BUTTONS,
XML_DISPLAY_FORMULA,
+XML_DISPLAY_HIDDEN,
XML_DISPLAY_LABEL,
XML_DISPLAY_LEVELS,
XML_DISPLAY_NAME,
XML_DISPLAY_OUTLINE_LEVEL,
+XML_DISPLAY_X_AXIS,
XML_DISSOLVE,
XML_DISTANCE,
XML_DISTANCE_AFTER_SEP,
@@ -1180,6 +1193,7 @@ namespace xmloff::token {
XML_LINE_SKEW,
XML_LINE_SPACING,
XML_LINE_STYLE,
+XML_LINE_WIDTH,
XML_LINEAR,
XML_LINEARGRADIENT,
XML_LINENUMBERING_CONFIGURATION,
@@ -1207,6 +1221,7 @@ namespace xmloff::token {
XML_LOGARITHMIC,
XML_LOGBASE,
XML_LONG,
+XML_LOW,
XML_LOWLIMIT,
XML_LR_TB,
XML_LT,
@@ -1220,6 +1235,8 @@ namespace xmloff::token {
XML_MALIGNGROUP,
XML_MALIGNMARK,
XML_MANUAL,
+XML_MANUAL_MIN,
+XML_MANUAL_MAX,
XML_MAP,
XML_MARGIN_BOTTOM,
XML_MARGIN_LEFT,
@@ -1227,6 +1244,7 @@ namespace xmloff::token {
XML_MARGIN_TOP,
XML_MARGINS,
XML_MARKER,
+XML_MARKERS,
XML_MARKER_END,
XML_MARKER_END_CENTER,
XML_MARKER_END_WIDTH,
@@ -1245,6 +1263,7 @@ namespace xmloff::token {
XML_MATRIX_COVERED,
XML_MATRIXROW,
XML_MAX,
+XML_MAX_AXIS_TYPE,
XML_MAX_EDGE,
XML_MAX_HEIGHT,
XML_MAX_LENGTH,
@@ -1270,6 +1289,7 @@ namespace xmloff::token {
XML_MIDDLE,
XML_MIME_TYPE,
XML_MIN,
+XML_MIN_AXIS_TYPE,
XML_MIN_DENOMINATOR_DIGITS,
XML_MIN_EDGE,
[Libreoffice-bugs] [Bug 148185] New: German translation - little issue
https://bugs.documentfoundation.org/show_bug.cgi?id=148185 Bug ID: 148185 Summary: German translation - little issue Product: LibreOffice Version: 7.3.1.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: klaus.lupp...@gmail.com Created attachment 179107 --> https://bugs.documentfoundation.org/attachment.cgi?id=179107=edit screenshot German translation for installation needs a little fix. I found it during 7.3.2.2 installation, but I couldn't select it here for this bug, since it is not listed. Anyway, I uploaded a screenshot -> the two blue and the two green marked words match, but the two red marked which is german for "Cancel" needs to be matched. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147304] UI: Find and replace dialog position to parent is off (dialog doesn't open centered to main screen)
https://bugs.documentfoundation.org/show_bug.cgi?id=147304 --- Comment #5 from Dieter --- (In reply to Dieter from comment #3) > I suppose, that there is an underlying problem: The dialog position to > parent is off (dialog doesn't open centered to main screen); same with Table > of Content dialog (see bug 146562) Looks good now in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e8c95b796626cb9db163f5d563fa67f38a5e92b0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL HTK300, could you please retest? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) or change Default to Point
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #8 from Heiko Tietze --- (In reply to Heiko Tietze from comment #3) > Smallest number that can be entered manually is 0.01cm... > ... The solution is to me to allow different units per control, as requested > at bug 72662. Don't see why this needs to be an extra ticket. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) or change Default to Point
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Heiko Tietze changed: What|Removed |Added CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org Keywords|needsUXEval | --- Comment #8 from Heiko Tietze --- (In reply to Heiko Tietze from comment #3) > Smallest number that can be entered manually is 0.01cm... > ... The solution is to me to allow different units per control, as requested > at bug 72662. Don't see why this needs to be an extra ticket. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 --- Comment #5 from Dieter --- (In reply to Eyal Rozenberg from comment #4) > After step 4, > > * Format -> Paragraph -> Outline & List while in the second paragraph - > "Bullet -" is the applied list style. > * Format -> Paragraph -> Outline & List while in the first paragraph - > "Numbering 123" is the applied list style. > * Right-click -> Outline & List on the "foo" style - "Numbering 123" is the > applied list style. Correct, so I don't understand, why "Update Selected Style" doesn't work for you, if cursor is in second paragraph. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) or change Default to Point
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Luke changed: What|Removed |Added Summary|Borders: Allow Shadow Style |Borders: Allow Shadow Style |Distance to be less than|Distance to be less than |than 0.1 cm (current|than 0.1 cm (current |default)|default) or change Default ||to Point -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) or change Default to Point
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Luke changed: What|Removed |Added Summary|Borders: Allow Shadow Style |Borders: Allow Shadow Style |Distance to be less than|Distance to be less than |than 0.1 cm (current|than 0.1 cm (current |default)|default) or change Default ||to Point -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 --- Comment #7 from Luke --- Created attachment 179106 --> https://bugs.documentfoundation.org/attachment.cgi?id=179106=edit MS Word Shadow Distance in Points This is another case of using the wrong units. Both Word and Word Perfect use the natural unit of point for Shadow Distance. In typography, the traditional unit is the point. Switching to that not only makes sense for all professional users, but also would follow the industry standard. Finally it would fix this issue of forcing a user to switch to mm as it's the only other unit (although non-standard) that makes sense in this use case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 --- Comment #7 from Luke --- Created attachment 179106 --> https://bugs.documentfoundation.org/attachment.cgi?id=179106=edit MS Word Shadow Distance in Points This is another case of using the wrong units. Both Word and Word Perfect use the natural unit of point for Shadow Distance. In typography, the traditional unit is the point. Switching to that not only makes sense for all professional users, but also would follow the industry standard. Finally it would fix this issue of forcing a user to switch to mm as it's the only other unit (although non-standard) that makes sense in this use case. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 --- Comment #4 from Eyal Rozenberg --- (In reply to Dieter from comment #3) > (In reply to Eyal Rozenberg from comment #2) > > Expected results: > > After step 1.5, the paragraphs begin with "1." and "2." respectively. > > After step 5, both paragraphs have an en-dash-like bullet. > > Yes, and this is my result. > > After step 4, please open Format -> Paragraph -> Outline & List > List St[y]le "Bullet -" is the applied list style. Do you get the same result? After step 4, * Format -> Paragraph -> Outline & List while in the second paragraph - "Bullet -" is the applied list style. * Format -> Paragraph -> Outline & List while in the first paragraph - "Numbering 123" is the applied list style. * Right-click -> Outline & List on the "foo" style - "Numbering 123" is the applied list style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/inc/swmodeltestbase.hxx | 17 -
sw/qa/unit/swmodeltestbase.cxx | 24 +---
2 files changed, 37 insertions(+), 4 deletions(-)
New commits:
commit bd769805180c9b0aadca5301e29161c2d84fbe64
Author: Caolán McNamara
AuthorDate: Fri Mar 25 14:01:47 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 16:35:55 2022 +0100
add support to explicitly test swriter/sweb layout
Change-Id: Ib47526d35428a95b081c88011d733397339f288d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132121
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/inc/swmodeltestbase.hxx b/sw/qa/inc/swmodeltestbase.hxx
index 329a9a60b4d8..15980cdfda84 100644
--- a/sw/qa/inc/swmodeltestbase.hxx
+++ b/sw/qa/inc/swmodeltestbase.hxx
@@ -308,11 +308,20 @@ protected:
void load(std::u16string_view pDir, const char* pName, const char*
pPassword = nullptr)
{
-return loadURL(m_directories.getURLFromSrc(pDir) +
OUString::createFromAscii(pName), pName, pPassword);
+return loadURLWithComponent(m_directories.getURLFromSrc(pDir) +
OUString::createFromAscii(pName),
+"com.sun.star.text.TextDocument", pName,
pPassword);
+}
+
+void load_web(std::u16string_view pDir, const char* pName, const char*
pPassword = nullptr)
+{
+return loadURLWithComponent(m_directories.getURLFromSrc(pDir) +
OUString::createFromAscii(pName),
+"com.sun.star.text.WebDocument", pName,
pPassword);
}
void setTestInteractionHandler(const char* pPassword,
std::vector& rFilterOptions);
+void loadURLWithComponent(OUString const& rURL, OUString const&
rComponent, const char* pName, const char* pPassword);
+
void loadURL(OUString const& rURL, const char* pName, const char*
pPassword = nullptr);
void reload(const char* pFilter, const char* filename, const char*
pPassword = nullptr);
@@ -367,6 +376,12 @@ protected:
*/
SwDoc* createSwDoc(
std::u16string_view rDataDirectory = std::u16string_view(), const
char* pName = nullptr);
+
+/**
+ * As createSwDoc except a Web Document in Browse Mode
+ */
+SwDoc* createSwWebDoc(
+std::u16string_view rDataDirectory = std::u16string_view(), const
char* pName = nullptr);
};
/**
diff --git a/sw/qa/unit/swmodeltestbase.cxx b/sw/qa/unit/swmodeltestbase.cxx
index e1b28153110f..ad4ff03d5479 100644
--- a/sw/qa/unit/swmodeltestbase.cxx
+++ b/sw/qa/unit/swmodeltestbase.cxx
@@ -480,7 +480,8 @@ void SwModelTestBase::setTestInteractionHandler(const char*
pPassword,
void SwModelTestBase::header() {}
-void SwModelTestBase::loadURL(OUString const& rURL, const char* pName, const
char* pPassword)
+void SwModelTestBase::loadURLWithComponent(OUString const& rURL, OUString
const& rComponent,
+ const char* pName, const char*
pPassword)
{
if (mxComponent.is())
mxComponent->dispose();
@@ -512,8 +513,8 @@ void SwModelTestBase::loadURL(OUString const& rURL, const
char* pName, const cha
if (pName)
std::cout << pName << ":\n";
mnStartTime = osl_getGlobalTimer();
-mxComponent = loadFromDesktop(rURL, "com.sun.star.text.TextDocument",
-
comphelper::containerToSequence(aFilterOptions));
+mxComponent
+= loadFromDesktop(rURL, rComponent,
comphelper::containerToSequence(aFilterOptions));
if (pPassword)
{
@@ -526,6 +527,11 @@ void SwModelTestBase::loadURL(OUString const& rURL, const
char* pName, const cha
calcLayout();
}
+void SwModelTestBase::loadURL(OUString const& rURL, const char* pName, const
char* pPassword)
+{
+loadURLWithComponent(rURL, "com.sun.star.text.TextDocument", pName,
pPassword);
+}
+
void SwModelTestBase::reload(const char* pFilter, const char* filename, const
char* pPassword)
{
uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
@@ -729,4 +735,16 @@ SwDoc* SwModelTestBase::createSwDoc(std::u16string_view
rDataDirectory, const ch
return pTextDoc->GetDocShell()->GetDoc();
}
+SwDoc* SwModelTestBase::createSwWebDoc(std::u16string_view rDataDirectory,
const char* pName)
+{
+if (rDataDirectory.empty() || !pName)
+loadURL("private:factory/swriter/web", nullptr);
+else
+load_web(rDataDirectory, pName);
+
+SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+return pTextDoc->GetDocShell()->GetDoc();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 Dieter changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from Dieter --- (In reply to Eyal Rozenberg from comment #2) > Expected results: > After step 1.5, the paragraphs begin with "1." and "2." respectively. > After step 5, both paragraphs have an en-dash-like bullet. Yes, and this is my result. After step 4, please open Format -> Paragraph -> Outline & List List Stle "Bullet -" is the applied list style. Do you get the same result? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a paragraph style's associated list style has no effect on other paragraphs with the style
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 Eyal Rozenberg changed: What|Removed |Added Summary|Updating a list style to|Updating a paragraph |reflect a change to bullets |style's associated list |has no effect |style has no effect on ||other paragraphs with the ||style -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147809] Updating a list style to reflect a change to bullets has no effect
https://bugs.documentfoundation.org/show_bug.cgi?id=147809 --- Comment #2 from Eyal Rozenberg --- Created attachment 179105 --> https://bugs.documentfoundation.org/attachment.cgi?id=179105=edit Document for reproducing the bug Here are reproduction instructions, without even using a custom list style, just a custom paragraph style: 1. 1.1 Type in two paragraphs, with text "first" and "second" respectively (and type Enter after the end of each paragraph) 1.2 Create a new style based on the default paragraph style, named foo 1.3 Apply style "foo" to the first paragraph 1.4 Apply numbering style "Numbering 123" to the first paragraph 1.5 In the Styles Sidebar, switch to paragraph styles, right-click "foo" and from the top-right menubutton choose "Updated Selected Style" 1.6 Apply style foo to the second paragraph (or alternatively: 1. Open 147809.odt ) 2. Place cursor on one of the foo paragraphs 3. On the Styles Sidebar, choose List Styles 4. Apply the "Bullet -" style 5. In the Styles Sidebar, switch to paragraph styles, right-click "foo" and from the top-right menubutton choose "Updated Selected Style" Expected results: After step 1.5, the paragraphs begin with "1." and "2." respectively. After step 5, both paragraphs have an en-dash-like bullet. Actual result: After step 1.5, the paragraphs begin with "1." and "2." respectively. After step 5, only the paragraph chosen in step (2.) now exhibits an en-dash-like bullet, the other one is still preceded by a number. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Changes to 'distro/lhm/libreoffice-7-3+backports'
New branch 'distro/lhm/libreoffice-7-3+backports' available with the following commits:
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Dieter changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Dieter --- Heiko, waht Info do you need? I've tested with master and got the same result Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 51fb84829afbc1c0957fd1a489085613ad199f1a CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL @R. Green, could you please also test? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Dieter changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Dieter --- Heiko, waht Info do you need? I've tested with master and got the same result Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 51fb84829afbc1c0957fd1a489085613ad199f1a CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL @R. Green, could you please also test? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/inc sw/qa sw/source
sw/inc/formatlinebreak.hxx |2
sw/inc/textlinebreak.hxx |5 +
sw/inc/unomap.hxx|4 +
sw/inc/unoprnms.hxx |1
sw/qa/core/unocore/unocore.cxx |3 +
sw/source/core/txtnode/attrlinebreak.cxx | 30 +-
sw/source/core/txtnode/thints.cxx|5 +
sw/source/core/unocore/unolinebreak.cxx | 85 ++-
sw/source/core/unocore/unomap.cxx|5 +
sw/source/core/unocore/unomap1.cxx | 18 ++
10 files changed, 140 insertions(+), 18 deletions(-)
New commits:
commit 5feb766541d8817cdab4af5da4c9c40b48771840
Author: Miklos Vajna
AuthorDate: Wed Mar 2 09:38:14 2022 +0100
Commit: Miklos Vajna
CommitDate: Fri Mar 25 15:46:53 2022 +0100
sw clearing breaks: add UNO API to insert this with custom clear / char
props
- if (character) properties are specified when the text content itself
is inserted, then format the anchor ("dummy") character like that
- add the ability to specify a clear type (none/left/right/all) on the
line break object itself before insertion
(cherry picked from commit 1a240807f2c051ff9a63d713625404a024d7c221)
Change-Id: I219a1031e53c2e0368ff329d45b7e3fff0934038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132107
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/sw/inc/formatlinebreak.hxx b/sw/inc/formatlinebreak.hxx
index 9e26ab11351f..c3a2b0164f86 100644
--- a/sw/inc/formatlinebreak.hxx
+++ b/sw/inc/formatlinebreak.hxx
@@ -70,7 +70,7 @@ public:
void InvalidateLineBreak();
-css::uno::Reference getAnchor(SwDoc& rDoc) const;
+css::uno::Reference GetAnchor() const;
void SetTextLineBreak(SwTextLineBreak* pTextAttr) { m_pTextAttr =
pTextAttr; }
diff --git a/sw/inc/textlinebreak.hxx b/sw/inc/textlinebreak.hxx
index c0853aa2bd56..33401972f60b 100644
--- a/sw/inc/textlinebreak.hxx
+++ b/sw/inc/textlinebreak.hxx
@@ -32,11 +32,16 @@ class SwFormatLineBreak;
*/
class SW_DLLPUBLIC SwTextLineBreak final : public SwTextAttr
{
+SwTextNode* m_pTextNode;
+
public:
SwTextLineBreak(SwFormatLineBreak& rAttr, sal_Int32 nStart);
~SwTextLineBreak() override;
+const SwTextNode& GetTextNode() const;
+void SetTextNode(SwTextNode* pNew);
+
void dumpAsXml(xmlTextWriterPtr pWriter) const override;
};
diff --git a/sw/inc/unomap.hxx b/sw/inc/unomap.hxx
index c4c166032983..413adfaf7fc3 100644
--- a/sw/inc/unomap.hxx
+++ b/sw/inc/unomap.hxx
@@ -125,7 +125,8 @@ struct SfxItemPropertyMapEntry;
#define PROPERTY_MAP_TABLE_STYLE100
#define PROPERTY_MAP_CELL_STYLE 101
#define PROPERTY_MAP_FIELDMARK 102
-#define PROPERTY_MAP_END103
+#define PROPERTY_MAP_LINEBREAK 103
+#define PROPERTY_MAP_END104
//S
#define WID_WORDS0
@@ -351,6 +352,7 @@ private:
static const SfxItemPropertyMapEntry* GetRedlinePropertyMap();
static const SfxItemPropertyMapEntry* GetRedlinePortionPropertyMap();
static SfxItemPropertyMapEntry* GetTextDefaultPropertyMap();
+static const SfxItemPropertyMapEntry* GetLineBreakPropertyMap();
};
extern SwUnoPropertyMapProvider aSwMapProvider;
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index 5d8684c47f53..c291742a1641 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -866,6 +866,7 @@
#define UNO_NAME_RESOLVED "Resolved"
#define UNO_NAME_ALLOW_OVERLAP "AllowOverlap"
+#define UNO_NAME_CLEAR "Clear"
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/core/unocore/unocore.cxx b/sw/qa/core/unocore/unocore.cxx
index ddf8d4bb5362..d8c9f9559bd9 100644
--- a/sw/qa/core/unocore/unocore.cxx
+++ b/sw/qa/core/unocore/unocore.cxx
@@ -227,6 +227,9 @@ CPPUNIT_TEST_FIXTURE(SwCoreUnocoreTest, testLineBreakInsert)
uno::Reference xTextDocument(mxComponent,
uno::UNO_QUERY);
uno::Reference xLineBreak(
xMSF->createInstance("com.sun.star.text.LineBreak"), uno::UNO_QUERY);
+uno::Reference xLineBreakProps(xLineBreak,
uno::UNO_QUERY);
+auto eClear = static_cast(SwLineBreakClear::ALL);
+xLineBreakProps->setPropertyValue("Clear", uno::makeAny(eClear));
uno::Reference xText = xTextDocument->getText();
uno::Reference xCursor = xText->createTextCursor();
xText->insertTextContent(xCursor, xLineBreak, /*bAbsorb=*/false);
diff --git a/sw/source/core/txtnode/attrlinebreak.cxx
b/sw/source/core/txtnode/attrlinebreak.cxx
index f0f583ecc2df..00d1c275e3dd 100644
--- a/sw/source/core/txtnode/attrlinebreak.cxx
+++ b/sw/source/core/txtnode/attrlinebreak.cxx
@@ -27,6 +27,8 @@
#include
#include
#include
+#include
+#include
using namespace com::sun::star;
@@ -74,17 +76,21 @@ void
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/uielement/menubarmanager.hxx|2 --
framework/source/uielement/menubarmanager.cxx | 16 +---
2 files changed, 5 insertions(+), 13 deletions(-)
New commits:
commit 47e6bf0109c686f71b48c550667af707705a777b
Author: Stephan Bergmann
AuthorDate: Fri Mar 25 12:18:05 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Mar 25 15:38:42 2022 +0100
Fold MenuBarManager::Destroy into its only call site
...mainly to demonstrate that its SolarMutexGuard was redundant and that
replacing it with DBG_TESTSOLARMUTEX() would be overkill
Change-Id: I82f00873cd99cb5da1b644c40ba25f8c210503cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132112
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/framework/inc/uielement/menubarmanager.hxx
b/framework/inc/uielement/menubarmanager.hxx
index 079d127d4d83..710c788f2dcc 100644
--- a/framework/inc/uielement/menubarmanager.hxx
+++ b/framework/inc/uielement/menubarmanager.hxx
@@ -127,8 +127,6 @@ class MenuBarManager final :
static bool MustBeHidden( PopupMenu* pPopupMenu, const
css::uno::Reference< css::util::XURLTransformer >& rTransformer );
OUString RetrieveLabelFromCommand(const OUString& rCmdURL);
-void Destroy();
-
struct MenuItemHandler
{
MenuItemHandler( sal_uInt16 aItemId,
diff --git a/framework/source/uielement/menubarmanager.cxx
b/framework/source/uielement/menubarmanager.cxx
index 49b4092f6d46..c363ccffb9b6 100644
--- a/framework/source/uielement/menubarmanager.cxx
+++ b/framework/source/uielement/menubarmanager.cxx
@@ -136,9 +136,12 @@ MenuBarManager::~MenuBarManager()
SAL_WARN_IF( OWeakObject::m_refCount != 0, "fwk.uielement", "Who wants to
delete an object with refcount > 0!" );
}
-void MenuBarManager::Destroy()
+// XComponent
+void MenuBarManager::disposing(std::unique_lock& )
{
-SolarMutexGuard aGuard;
+Reference< XComponent > xThis( this );
+
+SolarMutexGuard g;
// stop asynchronous settings timer and
// release deferred item container reference
@@ -152,15 +155,6 @@ void MenuBarManager::Destroy()
{
m_pVCLMenu.disposeAndClear();
}
-}
-
-// XComponent
-void MenuBarManager::disposing(std::unique_lock& )
-{
-Reference< XComponent > xThis( this );
-
-SolarMutexGuard g;
-Destroy();
if ( m_xDocImageManager.is() )
{
[Libreoffice-bugs] [Bug 147943] Allow numbering formats when sending Master Document
https://bugs.documentfoundation.org/show_bug.cgi?id=147943 --- Comment #4 from L Duperval --- In the attached zip file, there is: mybook.odm with mybook.odt. Those are the generated files. mybook.odt (without a number) contains a single file that can be used to run the process again (it will create about 20 subdocuments and a master document). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147943] Allow numbering formats when sending Master Document
https://bugs.documentfoundation.org/show_bug.cgi?id=147943 --- Comment #3 from L Duperval --- Created attachment 179104 --> https://bugs.documentfoundation.org/attachment.cgi?id=179104=edit Sample output from a document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147943] Allow numbering formats when sending Master Document
https://bugs.documentfoundation.org/show_bug.cgi?id=147943 --- Comment #2 from L Duperval --- No, not quite. The "Send to Master Document" process works like this: You have a document with 20 "Heading 1" paragraphs in it. Choose "File > Send > Create Master Document" A window opens, asking you to give a name to your master document. So, let's say I call it "mybook.odm" Then Writer will create files called mybook.odm mybook1.odt mybook2.odt mybook3.odt . . . mybook10.odt mybook11.odt .. . What I'm asking is for the ability to have some control over the naming of the files, without needing to do them by hand after the fact. In my case, it would be: mybook.odm mybook-01.odt mybook-02.odt . . . mybook-10.odt mybook-11.odt . . . I'm attaching a file so you can test out the process. P.S. this particular file also caused problems witht eh Master document creation process. Although all the ODT files were created, they did not appear in the structure. I had to add them by hand. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/source
vcl/source/window/mouse.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit c9ccb88b99eeda1d227ff44587c09241e74d Author: Andras Timar AuthorDate: Fri Mar 25 13:56:53 2022 +0100 Commit: Andras Timar CommitDate: Fri Mar 25 15:21:20 2022 +0100 fix error: unused variable Change-Id: I941e3abd1986bfb490acae3585e165ce42d9c71c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132119 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/vcl/source/window/mouse.cxx b/vcl/source/window/mouse.cxx index 0c77347f89f8..9b533b991a9e 100644 --- a/vcl/source/window/mouse.cxx +++ b/vcl/source/window/mouse.cxx @@ -769,6 +769,9 @@ Reference< css::datatransfer::dnd::XDragSource > Window::GetDragSource() pDragSourceAL[ 1 ] <<= pEnvData->aShellWindow; pDropTargetAL[ 0 ] <<= Application::GetDisplayConnection(); pDropTargetAL[ 1 ] <<= pEnvData->aShellWindow; +#else // LOKit +(void)pDragSourceAL; +(void)pDropTargetAL; #endif if( !aDragSourceSN.isEmpty() ) mpWindowImpl->mpFrameData->mxDragSource.set(
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/document.hxx | 14 +++---
sc/inc/table.hxx |8
sc/qa/unit/ucalc.cxx | 19 +++
sc/source/core/data/document.cxx | 12 ++--
sc/source/core/data/table2.cxx|7 +++
sc/source/filter/xml/xmlexprt.cxx |8
6 files changed, 43 insertions(+), 25 deletions(-)
New commits:
commit b8720d1e1f0842d52f1830c48ef7551b1868ae6f
Author: Luboš Luňák
AuthorDate: Fri Mar 25 12:42:58 2022 +0100
Commit: Luboš Luňák
CommitDate: Fri Mar 25 15:20:58 2022 +0100
fix ScTable::GetLastChangedCol() for unallocated columns
Column flags and widths are stored separately from ScColumn data,
and so don't depend on allocated columns count.
Also rename the functions from the misleading generic name to what
they actually do.
Change-Id: If85ae80efda1d8b382fa3b559aa65be0292e25ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132114
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index cd7138b3e945..639166319366 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -2025,17 +2025,17 @@ public:
*/
voidSyncColRowFlags();
-/// @return the index of the last row with any set flags
(auto-pagebreak is ignored).
+/// @return the index of the last row with any set flags (auto-pagebreak
is ignored).
SC_DLLPUBLIC SCROW GetLastFlaggedRow( SCTAB nTab ) const;
-/// @return the index of the last changed column (flags
and column width, auto pagebreak is ignored).
-SCCOL GetLastChangedCol( SCTAB nTab ) const;
-/// @return the index of the last changed row (flags and
row height, auto pagebreak is ignored).
-SCROW GetLastChangedRow( SCTAB nTab ) const;
+/// @return the index of the last changed column (flags and column width,
auto pagebreak is ignored).
+SCCOL GetLastChangedColFlagsWidth( SCTAB nTab ) const;
+/// @return the index of the last changed row (flags and row height, auto
pagebreak is ignored).
+SCROW GetLastChangedRowFlagsWidth( SCTAB nTab ) const;
-SCCOL GetNextDifferentChangedCol( SCTAB nTab, SCCOL nStart)
const;
+SCCOL GetNextDifferentChangedColFlagsWidth( SCTAB nTab, SCCOL
nStart) const;
-SCROW GetNextDifferentChangedRow( SCTAB nTab, SCROW nStart)
const;
+SCROW GetNextDifferentChangedRowFlagsWidth( SCTAB nTab, SCROW
nStart) const;
// returns whether to export a Default style for this col or not
// nDefault is set to one position in the current row where the Default
style is
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 58fb6c4a45ad..a885067f5649 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -870,10 +870,10 @@ public:
/// @return the index of the last row with any set flags
(auto-pagebreak is ignored).
SCROW GetLastFlaggedRow() const;
-/// @return the index of the last changed column (flags and
column width, auto pagebreak is ignored).
-SCCOL GetLastChangedCol() const;
-/// @return the index of the last changed row (flags and row
height, auto pagebreak is ignored).
-SCROW GetLastChangedRow() const;
+/// @return the index of the last changed column (flags and column width,
auto pagebreak is ignored).
+SCCOL GetLastChangedColFlagsWidth() const;
+/// @return the index of the last changed row (flags and row height, auto
pagebreak is ignored).
+SCROW GetLastChangedRowFlagsWidth() const;
bool IsDataFiltered(SCCOL nColStart, SCROW nRowStart, SCCOL nColEnd,
SCROW nRowEnd) const;
bool IsDataFiltered(const ScRange& rRange) const;
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 895d5a96bf89..020e43c6dbde 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -117,6 +117,7 @@ public:
void testValueIterator();
void testHorizontalAttrIterator();
void testIteratorsUnallocatedColumnsAttributes();
+void testLastChangedColFlagsWidth();
/**
* More direct test for cell broadcaster management, used to track formula
@@ -250,6 +251,7 @@ public:
CPPUNIT_TEST(testValueIterator);
CPPUNIT_TEST(testHorizontalAttrIterator);
CPPUNIT_TEST(testIteratorsUnallocatedColumnsAttributes);
+CPPUNIT_TEST(testLastChangedColFlagsWidth);
CPPUNIT_TEST(testCellBroadcaster);
CPPUNIT_TEST(testFuncParam);
CPPUNIT_TEST(testNamedRange);
@@ -1456,6 +1458,23 @@ void Test::testIteratorsUnallocatedColumnsAttributes()
m_pDoc->DeleteTab(0);
}
+void Test::testLastChangedColFlagsWidth()
+{
+m_pDoc->InsertTab(0, "Tab1");
+
+constexpr SCCOL firstChangedCol = 100;
+assert( firstChangedCol > INITIALCOLCOUNT );
+for( SCCOL col =
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Heiko Tietze changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 --- Comment #5 from Heiko Tietze --- Created attachment 179103 --> https://bugs.documentfoundation.org/attachment.cgi?id=179103=edit Screencast (In reply to Dieter from comment #4) > ... but shadow has always width of 0,1 cm and if you reopen dialog... Cannot confirm -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 --- Comment #5 from Heiko Tietze --- Created attachment 179103 --> https://bugs.documentfoundation.org/attachment.cgi?id=179103=edit Screencast (In reply to Dieter from comment #4) > ... but shadow has always width of 0,1 cm and if you reopen dialog... Cannot confirm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107838] [META] Character-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107838 Dieter changed: What|Removed |Added Depends on||147869 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147869 [Bug 147869] Problem with border around characters at beginning of list entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108382] [META] Borders bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108382 Dieter changed: What|Removed |Added Depends on||147869 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147869 [Bug 147869] Problem with border around characters at beginning of list entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Dieter changed: What|Removed |Added Depends on||147869 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147869 [Bug 147869] Problem with border around characters at beginning of list entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147869] Problem with border around characters at beginning of list entry
https://bugs.documentfoundation.org/show_bug.cgi?id=147869 Dieter changed: What|Removed |Added Blocks||107838, 108382, 103369 Summary|Border in character style |Problem with border around |disrupts list style |characters at beginning of ||list entry Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Dieter --- I confirm it with Version: 7.3.1.3 (x64) / LibreOffice Community Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL But it's not only in character style but also if you add boder to a characer at the beginning of a list. Additional observation: Doesn't happen with paragraph border. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103369 [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=107838 [Bug 107838] [META] Character-level bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108382 [Bug 108382] [META] Borders bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113200] [META] DOC (binary) field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113200 Bug 113200 depends on bug 147861, which changed state. Bug 147861 Summary: FILEOPEN DOC: Custom DocProperty field shows only one value, not the changed value https://bugs.documentfoundation.org/show_bug.cgi?id=147861 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 72662] Use Different Measurement Units for Line vs Page Properties (e.g. point vs inch)
https://bugs.documentfoundation.org/show_bug.cgi?id=72662 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7899 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/singlevalfields.cxx| 13 ++---
compilerplugins/clang/unnecessaryvirtual.cxx | 14 +-
compilerplugins/clang/virtualdead.cxx|2 --
3 files changed, 11 insertions(+), 18 deletions(-)
New commits:
commit ace70dae44eea914ea460cc2feb49202b61a20fc
Author: Noel Grandin
AuthorDate: Fri Mar 25 13:59:18 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Mar 25 14:35:24 2022 +0100
loplugins ignoreLocation() is unreliable with PCH
Change-Id: Ic12cacb6e058a8725ea6d722399e3afe6ea458c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132115
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/singlevalfields.cxx
b/compilerplugins/clang/singlevalfields.cxx
index 81fa76da885e..3d966c9e9be3 100644
--- a/compilerplugins/clang/singlevalfields.cxx
+++ b/compilerplugins/clang/singlevalfields.cxx
@@ -180,8 +180,7 @@ bool SingleValFields::VisitFieldDecl( const FieldDecl*
fieldDecl )
{
auto canonicalDecl = fieldDecl->getCanonicalDecl();
-if( ignoreLocation( canonicalDecl )
-|| isInUnoIncludeFile(
compiler.getSourceManager().getSpellingLoc(canonicalDecl->getLocation())) )
+if( isInUnoIncludeFile(
compiler.getSourceManager().getSpellingLoc(canonicalDecl->getLocation())) )
return true;
MyFieldInfo aInfo;
@@ -212,8 +211,7 @@ bool SingleValFields::VisitVarDecl( const VarDecl* varDecl )
if (!canonicalDecl->getLocation().isValid())
return true;
-if( ignoreLocation( canonicalDecl )
-|| isInUnoIncludeFile(
compiler.getSourceManager().getSpellingLoc(canonicalDecl->getLocation())) )
+if( isInUnoIncludeFile(
compiler.getSourceManager().getSpellingLoc(canonicalDecl->getLocation())) )
return true;
MyFieldInfo aInfo;
@@ -233,9 +231,6 @@ bool SingleValFields::VisitVarDecl( const VarDecl* varDecl )
bool SingleValFields::VisitCXXConstructorDecl( const CXXConstructorDecl* decl )
{
-if( ignoreLocation( decl ) )
-return true;
-
// doesn't count as a write to fields because it's self->self
if (decl->isCopyOrMoveConstructor())
return true;
@@ -266,8 +261,6 @@ bool SingleValFields::VisitMemberExpr( const MemberExpr*
memberExpr )
const FieldDecl* fieldDecl = dyn_cast(decl);
if (!fieldDecl)
return true;
-if (ignoreLocation(memberExpr))
-return true;
walkPotentialAssign(fieldDecl, memberExpr);
return true;
}
@@ -283,8 +276,6 @@ bool SingleValFields::VisitDeclRefExpr( const DeclRefExpr*
declRefExpr )
return true;
if (!(varDecl->isStaticLocal() || varDecl->isStaticDataMember() ||
varDecl->hasGlobalStorage()))
return true;
-if (ignoreLocation(declRefExpr))
-return true;
walkPotentialAssign(varDecl, declRefExpr);
return true;
}
diff --git a/compilerplugins/clang/unnecessaryvirtual.cxx
b/compilerplugins/clang/unnecessaryvirtual.cxx
index eb3df3b1524f..c3c73923b3ae 100644
--- a/compilerplugins/clang/unnecessaryvirtual.cxx
+++ b/compilerplugins/clang/unnecessaryvirtual.cxx
@@ -108,9 +108,6 @@ std::string niceName(const CXXMethodDecl* cxxMethodDecl)
bool UnnecessaryVirtual::VisitCXXMethodDecl( const CXXMethodDecl* methodDecl )
{
-if (ignoreLocation(methodDecl)) {
-return true;
-}
if (!methodDecl->isVirtual() || methodDecl->isDeleted()) {
return true;
}
@@ -132,6 +129,8 @@ bool UnnecessaryVirtual::VisitCXXMethodDecl( const
CXXMethodDecl* methodDecl )
return true;
methodDecl = methodDecl->getCanonicalDecl();
+if (!methodDecl)
+return true;
std::string aNiceName = niceName(methodDecl);
// for destructors, we need to check if any of the superclass' destructors
are virtual
@@ -147,8 +146,11 @@ bool UnnecessaryVirtual::VisitCXXMethodDecl( const
CXXMethodDecl* methodDecl )
if (baseSpecifier->getType()->isRecordType())
{
const CXXRecordDecl* superclassCXXRecordDecl =
baseSpecifier->getType()->getAsCXXRecordDecl();
-std::string aOverriddenNiceName =
niceName(superclassCXXRecordDecl->getDestructor());
-overridingSet.insert(aOverriddenNiceName);
+if (superclassCXXRecordDecl->getDestructor())
+{
+std::string aOverriddenNiceName =
niceName(superclassCXXRecordDecl->getDestructor());
+overridingSet.insert(aOverriddenNiceName);
+}
}
}
return true;
@@ -174,6 +176,8 @@ bool UnnecessaryVirtual::VisitCXXMethodDecl( const
CXXMethodDecl* methodDecl )
void UnnecessaryVirtual::MarkRootOverridesNonEmpty( const CXXMethodDecl*
methodDecl )
{
+if (!methodDecl)
+return;
if (methodDecl->size_overridden_methods() == 0) {
nonEmptySet.insert(niceName(methodDecl));
return;
diff --git a/compilerplugins/clang/virtualdead.cxx
[Libreoffice-ux-advise] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Dieter changed: What|Removed |Added Status|RESOLVED|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=72 ||662 Resolution|DUPLICATE |--- --- Comment #4 from Dieter --- (In reply to Heiko Tietze from comment #3) > Smallest number that can be entered manually is 0.01cm if Tools > Options > > Writer > Units is set to centimetre. That's true (Tools -> Options -> LibreOffice Writer -> General -> Settings) , but shadow has always width of 0,1 cm and if you reopen dialog it shows 0,1cm. So a value less than 0,1 cm is not accepted. => Status back to NEW -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 108014] [META] Writer character style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108014 Bug 108014 depends on bug 147899, which changed state. Bug 147899 Summary: Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default) https://bugs.documentfoundation.org/show_bug.cgi?id=147899 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147899] Borders: Allow Shadow Style Distance to be less than than 0.1 cm (current default)
https://bugs.documentfoundation.org/show_bug.cgi?id=147899 Dieter changed: What|Removed |Added Status|RESOLVED|NEW See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=72 ||662 Resolution|DUPLICATE |--- --- Comment #4 from Dieter --- (In reply to Heiko Tietze from comment #3) > Smallest number that can be entered manually is 0.01cm if Tools > Options > > Writer > Units is set to centimetre. That's true (Tools -> Options -> LibreOffice Writer -> General -> Settings) , but shadow has always width of 0,1 cm and if you reopen dialog it shows 0,1cm. So a value less than 0,1 cm is not accepted. => Status back to NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: connectivity/Library_mysqlc.mk connectivity/source vcl/inc
connectivity/Library_mysqlc.mk |1
connectivity/source/drivers/mysqlc/mysqlc_tables.cxx | 57 ---
connectivity/source/drivers/mysqlc/mysqlc_tables.hxx |4 -
connectivity/source/drivers/mysqlc/mysqlc_users.cxx | 71 ---
connectivity/source/drivers/mysqlc/mysqlc_users.hxx | 47
connectivity/source/drivers/mysqlc/mysqlc_views.cxx |7 -
connectivity/source/drivers/mysqlc/mysqlc_views.hxx |2
vcl/inc/opengl/x11/X11DeviceInfo.hxx | 25 --
8 files changed, 214 deletions(-)
New commits:
commit 793fd21a4da5a442cc7130ae04628ffe3181ea6c
Author: Noel Grandin
AuthorDate: Fri Mar 25 14:28:21 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Mar 25 14:53:29 2022 +0100
loplugin:unusedmethods
Change-Id: I42cd6d52bd6c0759fa0a8b1b91bbf1af7eb70ba8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132117
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/connectivity/Library_mysqlc.mk b/connectivity/Library_mysqlc.mk
index af46fb9ba137..afc8f19b86cf 100644
--- a/connectivity/Library_mysqlc.mk
+++ b/connectivity/Library_mysqlc.mk
@@ -68,7 +68,6 @@ $(eval $(call gb_Library_add_exception_objects,mysqlc,\
connectivity/source/drivers/mysqlc/mysqlc_tables \
connectivity/source/drivers/mysqlc/mysqlc_types \
connectivity/source/drivers/mysqlc/mysqlc_user \
- connectivity/source/drivers/mysqlc/mysqlc_users \
connectivity/source/drivers/mysqlc/mysqlc_view \
connectivity/source/drivers/mysqlc/mysqlc_views \
))
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
index ee82134086e9..06218403f3fb 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
@@ -87,63 +87,6 @@ connectivity::sdbcx::ObjectType
connectivity::mysqlc::Tables::createObject(const
return xRet;
}
-OUString connectivity::mysqlc::Tables::createStandardColumnPart(
-const css::uno::Reference& xColProp,
-const css::uno::Reference& _xConnection)
-{
-css::uno::Reference xMetaData =
_xConnection->getMetaData();
-
-::dbtools::OPropertyMap& rPropMap = OMetaConnection::getPropMap();
-
-bool bIsAutoIncrement = false;
-
xColProp->getPropertyValue(rPropMap.getNameByIndex(PROPERTY_ID_ISAUTOINCREMENT))
->>= bIsAutoIncrement;
-
-const OUString sQuoteString = xMetaData->getIdentifierQuoteString();
-OUStringBuffer aSql(
-::dbtools::quoteName(sQuoteString,
::comphelper::getString(xColProp->getPropertyValue(
-
rPropMap.getNameByIndex(PROPERTY_ID_NAME);
-
-// check if the user enter a specific string to create autoincrement values
-OUString sAutoIncrementValue;
-css::uno::Reference xPropInfo =
xColProp->getPropertySetInfo();
-
-if (xPropInfo.is()
-&&
xPropInfo->hasPropertyByName(rPropMap.getNameByIndex(PROPERTY_ID_AUTOINCREMENTCREATION)))
-
xColProp->getPropertyValue(rPropMap.getNameByIndex(PROPERTY_ID_AUTOINCREMENTCREATION))
->>= sAutoIncrementValue;
-
-aSql.append(" ");
-
-aSql.append(dbtools::createStandardTypePart(xColProp, _xConnection));
-// Add character set for (VAR)BINARY (fix) types:
-// (VAR) BINARY is distinguished from other CHAR types by its character
set.
-// Octets is a special character set for binary data.
-if (xPropInfo.is() &&
xPropInfo->hasPropertyByName(rPropMap.getNameByIndex(PROPERTY_ID_TYPE)))
-{
-sal_Int32 aType = 0;
-xColProp->getPropertyValue(rPropMap.getNameByIndex(PROPERTY_ID_TYPE))
>>= aType;
-if (aType == css::sdbc::DataType::BINARY || aType ==
css::sdbc::DataType::VARBINARY)
-{
-aSql.append(" ");
-aSql.append("CHARACTER SET OCTETS");
-}
-}
-
-if (bIsAutoIncrement && !sAutoIncrementValue.isEmpty())
-{
-aSql.append(" ");
-aSql.append(sAutoIncrementValue);
-}
-// AutoIncrement "IDENTITY" is implicitly "NOT NULL"
-else if (::comphelper::getINT32(
-
xColProp->getPropertyValue(rPropMap.getNameByIndex(PROPERTY_ID_ISNULLABLE)))
- == css::sdbc::ColumnValue::NO_NULLS)
-aSql.append(" NOT NULL");
-
-return aSql.makeStringAndClear();
-}
-
css::uno::Reference
connectivity::mysqlc::Tables::createDescriptor()
{
// There is some internal magic so that the same class can be used as
either
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_tables.hxx
b/connectivity/source/drivers/mysqlc/mysqlc_tables.hxx
index 2ee2ab9b96da..2d3c4c74533d 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_tables.hxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_tables.hxx
@@ -24,10 +24,6 @@ class Tables : public ::connectivity::sdbcx::OCollection
protected:
css::uno::Reference m_xMetaData;
-static
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/lineinfo.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 21fb34bbb48393d6e631355f1124e5baa2759fcc
Author: Caolán McNamara
AuthorDate: Fri Mar 25 10:44:00 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 14:49:07 2022 +0100
ofz: Integer-overflow
Change-Id: Ic4a3e8b6d58e19fb93614521a8e0c1ba4dfaa834
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132109
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/gdi/lineinfo.cxx b/vcl/source/gdi/lineinfo.cxx
index 1267623c0f19..490b1d920d5e 100644
--- a/vcl/source/gdi/lineinfo.cxx
+++ b/vcl/source/gdi/lineinfo.cxx
@@ -131,9 +131,9 @@ static void ReadLimitedDouble(SvStream& rIStm, double
)
{
double fTmp(0.0);
rIStm.ReadDouble(fTmp);
-if (fTmp < std::numeric_limits::min() || fTmp >
std::numeric_limits::max())
+if (!std::isfinite(fTmp) || fTmp < std::numeric_limits::min()
|| fTmp > std::numeric_limits::max())
{
-SAL_WARN("vcl", "Parsing error: double too large: " << fTmp);
+SAL_WARN("vcl", "Parsing error: out of range double: " << fTmp);
return;
}
fDest = fTmp;
[Libreoffice-commits] core.git: 2 commits - external/liborcus
external/liborcus/UnpackedTarball_liborcus.mk |2 +
external/liborcus/forcepoint-87.patch.1 | 27
external/liborcus/forcepoint-88.patch.1 | 42 ++
3 files changed, 71 insertions(+)
New commits:
commit 87259aef31a0411ccc8cb045ceb1365c23e917e5
Author: Caolán McNamara
AuthorDate: Fri Mar 25 10:14:19 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 14:48:43 2022 +0100
forcepoint#88 temp std::string assigned to std::string_view
Change-Id: I128a60b68a3af988e3a4bdb06994f43d9b18d67e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132102
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 948b92753539..562ab4e5fcd7 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -30,6 +30,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/forcepoint-83.patch.1 \
external/liborcus/forcepoint-84.patch.1 \
external/liborcus/forcepoint-87.patch.1 \
+ external/liborcus/forcepoint-88.patch.1 \
))
ifeq ($(OS),WNT)
diff --git a/external/liborcus/forcepoint-88.patch.1
b/external/liborcus/forcepoint-88.patch.1
new file mode 100644
index ..19d96f4d8315
--- /dev/null
+++ b/external/liborcus/forcepoint-88.patch.1
@@ -0,0 +1,42 @@
+From 8c9537fe46b85acde0a7a183cee9066919c6b619 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Caol=C3=A1n=20McNamara?=
+Date: Fri, 25 Mar 2022 10:10:17 +
+Subject: [PATCH] forcepoint#88 assigned temp std::string return to string_view
+
+it's out of scope when used
+
+=ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffcaf91b111 at
pc 0x00486ec4 bp 0x7ffcaf91aed0 sp 0x7ffcaf91a680
+READ of size 2 at 0x7ffcaf91b111 thread T0
+#0 0x486ec3 in __interceptor_memcpy.part.0
(instdir/program/soffice.bin+0x486ec3)
+#1 0x7fa6c4471b77 in std::basic_streambuf
>::xsputn(char const*, long) (/lib64/libstdc++.so.6+0x143b77)
+#2 0x7fa6c4463ae3 in std::basic_ostream >&
std::__ostream_insert >(std::basic_ostream >&, char const*, long) (/lib64/libstdc++.so.6+0x135ae3)
+#3 0x7fa6b4027a26 in std::basic_ostream >&
std::operator<< >(std::basic_ostream >&, std::basic_string_view
>)
/usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/string_view:669:14
+#4 0x7fa6b426792b in
orcus::xml_element_printer::print_namespace(std::ostream&, char const*) const
workdir/UnpackedTarball/liborcus/src/liborcus/xml_util.cpp:35:12
+#5 0x7fa6b4267c68 in
orcus::xml_element_printer::print_element(std::ostream&, char const*, unsigned
long) const workdir/UnpackedTarball/liborcus/src/liborcus/xml_util.cpp:46:5
+#6 0x7fa6b41c1956 in orcus::xml_context_base::print_element(std::ostream&,
std::pair const&) const
workdir/UnpackedTarball/liborcus/src/liborcus/xml_context_base.cpp:280:20
+---
+ src/liborcus/xml_util.cpp | 8
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/liborcus/xml_util.cpp b/src/liborcus/xml_util.cpp
+index 906d321d..ff270d4a 100644
+--- a/src/liborcus/xml_util.cpp
b/src/liborcus/xml_util.cpp
+@@ -29,10 +29,10 @@ void xml_element_printer::print_namespace(std::ostream&
os, xmlns_id_t ns) const
+ if (mp_ns_cxt)
+ {
+ std::string_view alias = mp_ns_cxt->get_alias(ns);
+-if (alias.empty())
+-alias = mp_ns_cxt->get_short_name(ns);
+-
+-os << alias;
++if (!alias.empty())
++os << alias;
++else
++os << mp_ns_cxt->get_short_name(ns);
+ }
+ else
+ os << ns;
+--
+2.35.1
+
commit 32019baffa19a8f79cacf93d5dd5a95c7d416657
Author: Caolán McNamara
AuthorDate: Fri Mar 25 09:12:30 2022 +
Commit: Caolán McNamara
CommitDate: Fri Mar 25 14:48:28 2022 +0100
forcepoint#87 Assertion 'mp_char <= mp_end' failed
Change-Id: I434928cb2425a2e8eb9440dff67f52cda241b2d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132097
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 8f41fdbf9173..948b92753539 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -29,6 +29,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/std-get-busted.patch.1 \
external/liborcus/forcepoint-83.patch.1 \
external/liborcus/forcepoint-84.patch.1 \
+ external/liborcus/forcepoint-87.patch.1 \
))
ifeq ($(OS),WNT)
diff --git a/external/liborcus/forcepoint-87.patch.1
b/external/liborcus/forcepoint-87.patch.1
new file mode 100644
index ..c1a58dde59c4
--- /dev/null
+++ b/external/liborcus/forcepoint-87.patch.1
@@ -0,0 +1,27 @@
+From
