[Libreoffice-bugs] [Bug 148535] Fraction formatting in Calc gives the wrong result
https://bugs.documentfoundation.org/show_bug.cgi?id=148535 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #4 from Mike Kaganski --- As noted in comment 3, the documentation explains how to use the fraction feature properly; this specific case (1/10) is even mentioned there directly. Just to reiterate: defining denominator number of digits, you define the "resolution" of the resulting number visual representation. It will never exceed that resolution (by using more digits than defined in the format); and using 1-digit denominator, you can approximate *any* value (1/9 being the best approximation for 0.1, as well as for any number greater than 1/18). OTOH, numerator would add as many digits as needed to represent that approximation - that way, "?/?" would give you "19/9" for "2.1" This behaves the same way as for decimal representation like "#.#", where the whole part would expand as needed, and fractional part would never expand. Or put in other words: you must never expect to see the *exact* representation of any fractional number on screen, only some approximation according to the number format. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/win
vcl/win/gdi/salprn.cxx | 29 +
1 file changed, 5 insertions(+), 24 deletions(-)
New commits:
commit a8383345174d91f6e722128e1d53c9a4ebc18195
Author: Mike Kaganski
AuthorDate: Thu Apr 14 14:41:33 2022 +0100
Commit: Mike Kaganski
CommitDate: Fri Apr 15 07:06:57 2022 +0200
No Win16-style WIN.INI since Windows Vista
Change-Id: I75bc8c7c61e863747cdfc65fb4ed7603c0eb1c0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133034
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/vcl/win/gdi/salprn.cxx b/vcl/win/gdi/salprn.cxx
index 835c571785a6..724c4f18e2e1 100644
--- a/vcl/win/gdi/salprn.cxx
+++ b/vcl/win/gdi/salprn.cxx
@@ -22,6 +22,7 @@
#include
#include
+#include
#include
#include
@@ -224,31 +225,11 @@ OUString WinSalInstance::GetDefaultPrinter()
GetDefaultPrinterW( nullptr, );
if( nChars )
{
-LPWSTR pStr = static_cast(std::malloc(nChars*sizeof(WCHAR)));
-OUString aDefPrt;
-if( GetDefaultPrinterW( pStr, ) )
-{
-aDefPrt = o3tl::toU(pStr);
-}
-std::free( pStr );
-if( !aDefPrt.isEmpty() )
-return aDefPrt;
-}
-
-// get default printer from win.ini
-wchar_t szBuffer[256];
-GetProfileStringW( aImplWindows, aImplDevice, L"", szBuffer,
SAL_N_ELEMENTS( szBuffer ) );
-if ( szBuffer[0] )
-{
-// search for printer name
-wchar_t* pBuf = szBuffer;
-wchar_t* pTmp = pBuf;
-while ( *pTmp && (*pTmp != ',') )
-pTmp++;
-return OUString( o3tl::toU(pBuf), static_cast(pTmp-pBuf) );
+std::vector pStr(nChars);
+if (GetDefaultPrinterW(pStr.data(), ))
+return OUString(o3tl::toU(pStr.data()));
}
-else
-return OUString();
+return OUString();
}
static DWORD ImplDeviceCaps( WinSalInfoPrinter const * pPrinter, WORD nCaps,
[Libreoffice-bugs] [Bug 148607] File menu in full-screen 4k monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=148607 --- Comment #1 from Patriot009 --- Created attachment 179575 --> https://bugs.documentfoundation.org/attachment.cgi?id=179575=edit screenshot of bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148607] New: File menu in full-screen 4k monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=148607 Bug ID: 148607 Summary: File menu in full-screen 4k monitor Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shas...@cn.ru Description: In full-screen mode on the 4K monitor, there is a color palette problem for the command menu. There is no such problem in window mode Steps to Reproduce: 1.Run any Libreoffice app in 4k monitor in full screen mode 2.Change color scheme 3.See in left part of top menu. Actual Results: Color scheme has errors Expected Results: I see this bug every time Reproducible: Always User Profile Reset: No Additional Info: apply the color scheme to the entire menu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148606] LO cannot read/write from drives
https://bugs.documentfoundation.org/show_bug.cgi?id=148606 --- Comment #1 from robgrune --- Created attachment 179574 --> https://bugs.documentfoundation.org/attachment.cgi?id=179574=edit illustration of problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148606] New: LO cannot read/write from drives
https://bugs.documentfoundation.org/show_bug.cgi?id=148606 Bug ID: 148606 Summary: LO cannot read/write from drives Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robgr...@gmx.com Description: When choosing file-open or file-save, LO shows no drives other than /home. I cannot make LO link to other drives. I can see no means to add mounted drives to the LO dialogue box "places". Steps to Reproduce: 1. LO menus: file-open, file-save 2. cannot add mounted drives to "places" 3. Actual Results: clicked the "+". tried to find the mounted drives. cannot. LO shows "/" only. Expected Results: LO should have some means to choose mounted drives. LO should display all mounted drives. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 6; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-US (en_GB.UTF-8); UI: en-GB Calc: threaded CPU; AMD Fx 6 core Grpahics: NV137 OS: Fedora 35 Gnome: 41.5 Windowing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148229] MROUND shows up as com.sun.star.sheet.addİn.analysİs.getmround after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=148229 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148301] Shortcuts Ctrl+> and Ctrl+< not working
https://bugs.documentfoundation.org/show_bug.cgi?id=148301 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148299] Master Document: File not found if filename/path has back to back spaces.
https://bugs.documentfoundation.org/show_bug.cgi?id=148299 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148298] Impress won't handle PowerPoint slide hyperlink containing an executable
https://bugs.documentfoundation.org/show_bug.cgi?id=148298 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148288] Row height is not stored
https://bugs.documentfoundation.org/show_bug.cgi?id=148288 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148274] AutoText from LO > 7.3 (or maybe > 7.0..?) incompatible with older versions
https://bugs.documentfoundation.org/show_bug.cgi?id=148274 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148271] Printing out in Landscape format
https://bugs.documentfoundation.org/show_bug.cgi?id=148271 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148575] Crash when I tried to change the contents in a formula field of a write table
https://bugs.documentfoundation.org/show_bug.cgi?id=148575 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148575] Crash when I tried to change the contents in a formula field of a write table
https://bugs.documentfoundation.org/show_bug.cgi?id=148575 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148536] I have created a presentation on Microsoft PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=148536 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148536] I have created a presentation on Microsoft PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=148536 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148468] Outline track default should be only track if in Outline subtree
https://bugs.documentfoundation.org/show_bug.cgi?id=148468 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148468] Outline track default should be only track if in Outline subtree
https://bugs.documentfoundation.org/show_bug.cgi?id=148468 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147656] Presenter console default disable
https://bugs.documentfoundation.org/show_bug.cgi?id=147656 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147656] Presenter console default disable
https://bugs.documentfoundation.org/show_bug.cgi?id=147656 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144505] Error opening Libreoffice after ppa install - Ubuntu 18.04.5
https://bugs.documentfoundation.org/show_bug.cgi?id=144505 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144505] Error opening Libreoffice after ppa install - Ubuntu 18.04.5
https://bugs.documentfoundation.org/show_bug.cgi?id=144505 --- Comment #5 from QA Administrators --- Dear Josir Gomes, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144504] Crash in: SwTextNode::CutImpl(SwTextNode*, SwIndex const&, SwIndex const&, int, bool) FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=144504 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144504] Crash in: SwTextNode::CutImpl(SwTextNode*, SwIndex const&, SwIndex const&, int, bool) FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=144504 --- Comment #3 from QA Administrators --- Dear David Johnston, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132048] CROSS-REFERENCE: Cutting a referenced title breaks the cross-reference to that title
https://bugs.documentfoundation.org/show_bug.cgi?id=132048 --- Comment #6 from QA Administrators --- Dear Roberto Cantù, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] New: Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 Bug ID: 148605 Summary: Writer no fonts shown in drop-down box Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robgr...@gmx.com Created attachment 179573 --> https://bugs.documentfoundation.org/attachment.cgi?id=179573=edit illustration of problem LO 7.3 drop-down box for font selection shows no font labels. Placing the cursor onto the box displays a blue highlighter with white text label. Basically, the problem is a reversal of colours. Instead of normal black text on white background, per LO 7.1, I have now white text on white background: so labels are not visible. This problem can be detected invoking LO to override GTKthus; SAL_USE_VCLPLUGIN=gen /opt/libreoffice7.3/program/soffice Invoking this command results in a microscopic LO GUI upon my 4K monitor. But the drop-down box is now black text on white background, so font labels are displayed. Exiting LO, I receive a message informing me java needs to be installed. Installing java-latest does not resolve the problem. imho, this is a compatibility issue, and should be considered critical. system info... Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 6; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-US (en_GB.UTF-8); UI: en-GB Calc: threaded OS: Fedora 35 GNOME; 41.5 CPU; AMD64 Graphic; NV137 Windowing: Wayland note: LO 7.3 installed from rpm files downloaded from LO website -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148604] New: LibreOffice and files want launch
https://bugs.documentfoundation.org/show_bug.cgi?id=148604 Bug ID: 148604 Summary: LibreOffice and files want launch Product: LibreOffice Version: 7.3.0.0 alpha0+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kline0...@yahoo.com Description: I am unable to launch the program or open any files after installing newer ver. 7.3. Properties states 7.3.lnk Actual Results: Program or files won't open Expected Results: To open Reproducible: Always User Profile Reset: No Additional Info: None -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148535] Fraction formatting in Calc gives the wrong result
https://bugs.documentfoundation.org/show_bug.cgi?id=148535 sdc.bla...@youmail.dk changed: What|Removed |Added CC||er...@redhat.com, ||mikekagan...@hotmail.com --- Comment #3 from sdc.bla...@youmail.dk --- @Rofo - I agree the behavior is surprising. But I believe it is by design. https://help.libreoffice.org/master/en-US/text/scalc/guide/fraction_enter.html If you use Format Cell (Numbers tab) notice that you can choose different predefined formats for fraction and immediately see the result in the preview window. Notice also the "Format Code" control in the Numbers tab. This shows the number codes used to define the format. You can also make your own custom formats. See: https://help.libreoffice.org/master/en-US/text/shared/01/05020301.html (where there is a special section on fractions) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl officecfg/registry sc/inc sc/Library_sc.mk sc/sdi sc/source sc/uiconfig sc/UIConfig_scalc.mk svx/source vcl/source
include/vcl/EnumContext.hxx|1 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu |5 officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs |2 sc/Library_sc.mk |1 sc/UIConfig_scalc.mk |1 sc/inc/document.hxx|8 sc/inc/shellids.hxx|1 sc/sdi/SparklineShell.sdi | 17 ++ sc/sdi/scslots.sdi |1 sc/source/ui/app/scdll.cxx |2 sc/source/ui/inc/SparklineShell.hxx| 40 sc/source/ui/inc/tabvwsh.hxx |6 sc/source/ui/view/SparklineShell.cxx | 54 ++ sc/source/ui/view/tabview3.cxx | 13 + sc/source/ui/view/tabvwsh4.cxx | 42 - sc/uiconfig/scalc/popupmenu/sparkline.xml | 81 ++ svx/source/sidebar/paragraph/ParaPropertyPanel.cxx |1 vcl/source/window/EnumContext.cxx |1 18 files changed, 269 insertions(+), 8 deletions(-) New commits: commit e1f3f2e00c37173e5f6f1cbb5235ab95b100bde7 Author: Tomaž Vajngerl AuthorDate: Fri Apr 15 00:55:54 2022 +0900 Commit: Tomaž Vajngerl CommitDate: Fri Apr 15 02:49:00 2022 +0200 sc: introduce SparklineShell and Sparkline context Having a separate sparkline context is very useful, so we can add a custom UI when the user has the cursor over a sparkline. This will allow a "Sparkline" tab for NotebookBar and its own deck in Sidebar, activated only when the sparkline is present. Also the pop-up menu can be customized specifically for the sparkline, but this may be less useful. For the sparkline context we need a custom shell - SparklineShell where now all the UNO commands can be implemented (not done in this commit). Change-Id: Idca2ad946af3afdd1b494744b80c9c093eec602c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/EnumContext.hxx b/include/vcl/EnumContext.hxx index 639a427a138a..dec5711b6ba5 100644 --- a/include/vcl/EnumContext.hxx +++ b/include/vcl/EnumContext.hxx @@ -96,6 +96,7 @@ public: Text, TextObject, Trendline, +Sparkline, // Default context of an application. Do we need this? Default, diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu index ad61ee9033d6..c64da92d8789 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu @@ -337,6 +337,7 @@ Calc, default,visible; Calc, EditCell, visible; Calc, Pivot, visible; +Calc, Sparkline, visible; @@ -372,6 +373,7 @@ Calc, DrawLine, hidden ; Calc, EditCell, visible; Calc, Pivot, visible, .uno:CellTextDlg ; +Calc, Sparkline, visible; DrawImpress, Draw, hidden ; DrawImpress, DrawFontwork, hidden ; DrawImpress, DrawText, visible; @@ -1205,6 +1207,7 @@ Calc, default, visible ; Calc, EditCell, visible ; Calc, Pivot,visible ; +Calc, Sparkline, visible ; @@ -1238,6 +1241,7 @@ Calc, EditCell, visible ; Calc, default, visible ; Calc, Pivot,visible ; +Calc, Sparkline, visible ; @@ -1271,6 +1275,7 @@ Calc, EditCell, visible ; Calc, default, visible ; Calc, Pivot,visible ; +Calc, Sparkline, visible ; diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs index 53ad678e3574..1eb7007d3008 100644 --- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs @@ -109,7 +109,7 @@ 2 Context
[Libreoffice-bugs] [Bug 148444] "Print Preview" and "Print Preview bar" in Writer help pages need some updating
https://bugs.documentfoundation.org/show_bug.cgi?id=148444 --- Comment #1 from sdc.bla...@youmail.dk --- https://gerrit.libreoffice.org/c/help/+/132610 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148598] FORMATTING- A fraction is converted to date in cells designated as number
https://bugs.documentfoundation.org/show_bug.cgi?id=148598 Eike Rathke changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148598] FORMATTING- A fraction is converted to date in cells designated as number
https://bugs.documentfoundation.org/show_bug.cgi?id=148598 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Eike Rathke --- Cells are not "formatted for numbers" or "formatted for dates" input. Cells may have a *display format* assigned that is not an input mask. If your locale happens to use the '/' slash date separator and you don't want a simple fraction to be recognized as abbreviated date input then remove the D/M or M/D (depending on your locale) pattern from the Date Acceptance Patterns under Tools -> Options -> Languages Settings -> Languages. Or precede the fraction with a 0 to force a fraction input, like 0 1/2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source include/svl sc/source svl/source
chart2/source/tools/DiagramHelper.cxx |2 -
include/svl/numformat.hxx | 11 +++--
sc/source/core/data/column3.cxx |4 +--
svl/source/numbers/zforlist.cxx | 40 ++
4 files changed, 34 insertions(+), 23 deletions(-)
New commits:
commit abe0080d66fe81013d92bbc3521980e049640f6d
Author: Eike Rathke
AuthorDate: Thu Apr 14 18:23:04 2022 +0200
Commit: Eike Rathke
CommitDate: Fri Apr 15 01:40:05 2022 +0200
Prepare SvNumberFormatter::GetEditFormat() to obtain for another locale
Change-Id: Iab8b9a802ebac60b52007754430352d3de925374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133026
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/chart2/source/tools/DiagramHelper.cxx
b/chart2/source/tools/DiagramHelper.cxx
index f1021442f617..51bcd4cf9f0c 100644
--- a/chart2/source/tools/DiagramHelper.cxx
+++ b/chart2/source/tools/DiagramHelper.cxx
@@ -1061,7 +1061,7 @@ sal_Int32 DiagramHelper::getDateTimeInputNumberFormat(
const Reference< util::XN
// Obtain best matching date, time or datetime format.
nRet = pNumFormatter->GuessDateTimeFormat( nType, fNumber,
LANGUAGE_SYSTEM);
// Obtain the corresponding edit format.
-nRet = pNumFormatter->GetEditFormat( fNumber, nRet, nType,
LANGUAGE_SYSTEM, nullptr);
+nRet = pNumFormatter->GetEditFormat( fNumber, nRet, nType, nullptr);
}
return nRet;
}
diff --git a/include/svl/numformat.hxx b/include/svl/numformat.hxx
index e002349b2dad..9cdb414346c5 100644
--- a/include/svl/numformat.hxx
+++ b/include/svl/numformat.hxx
@@ -306,9 +306,16 @@ public:
should not be used otherwise. */
sal_uInt32 GuessDateTimeFormat(SvNumFormatType& rType, double fNumber,
LanguageType eLnge);
-/** Return the corresponding edit format of a format. */
+/** Return the corresponding edit format of a format.
+
+nFIndex, eType and pFormat (if not nullptr) are assumed to match each
+other / be of one format. The locale to use is obtained from pFormat,
+if nullptr then LANGUAGE_SYSTEM is used. This can be overriden by
+specifying eForLocale other than LANGUAGE_DONTKNOW.
+ */
sal_uInt32 GetEditFormat(double fNumber, sal_uInt32 nFIndex,
SvNumFormatType eType,
- LanguageType eLnge, SvNumberformat const*
pFormat);
+ SvNumberformat const* pFormat,
+ LanguageType eForLocale = LANGUAGE_DONTKNOW);
/// Return the reference date
const Date& GetNullDate() const;
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 56aff45386b5..8d5a9363a02a 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2064,8 +2064,8 @@ bool ScColumn::ParseString(
bForceFormatDate = false;
else
{
-nIndex = aParam.mpNumFormatter->GetEditFormat(
aCell.getValue(), nOldIndex, eNumFormatType,
-pOldFormat->GetLanguage(), pOldFormat);
+nIndex = aParam.mpNumFormatter->GetEditFormat(
+aCell.getValue(), nOldIndex,
eNumFormatType, pOldFormat);
eEvalDateFormat =
aParam.mpNumFormatter->GetEvalDateFormat();
aParam.mpNumFormatter->SetEvalDateFormat(
NF_EVALDATEFORMAT_FORMAT_INTL);
}
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 8606a4a24226..1ea60fc81784 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -1594,10 +1594,14 @@ sal_uInt32 SvNumberFormatter::GuessDateTimeFormat(
SvNumFormatType& rType, doubl
}
sal_uInt32 SvNumberFormatter::GetEditFormat( double fNumber, sal_uInt32
nFIndex,
- SvNumFormatType eType,
LanguageType eLang,
- SvNumberformat const * pFormat )
+ SvNumFormatType eType,
+ SvNumberformat const * pFormat,
+ LanguageType eForLocale )
{
::osl::MutexGuard aGuard( GetInstanceMutex() );
+const LanguageType eLang = (pFormat ? pFormat->GetLanguage() :
LANGUAGE_SYSTEM);
+if (eForLocale == LANGUAGE_DONTKNOW)
+eForLocale = eLang;
sal_uInt32 nKey = nFIndex;
switch ( eType )
{
@@ -1615,16 +1619,16 @@ sal_uInt32 SvNumberFormatter::GetEditFormat( double
fNumber, sal_uInt32 nFIndex,
// fdo#34977 preserve time when editing even if only date was
// displayed.
if (bIsoDate)
-nKey = GetFormatIndex( NF_DATETIME_ISO_MMDD_HHMMSS,
eLang);
+nKey =
[Libreoffice-commits] core.git: 2 commits - desktop/source oox/inc oox/Library_oox.mk oox/source sfx2/source
desktop/source/lib/init.cxx | 10 +++
oox/Library_oox.mk |1
oox/inc/drawingml/chart/datatablecontext.hxx| 42 ++
oox/inc/drawingml/chart/datatablemodel.hxx | 41 ++
oox/inc/drawingml/chart/plotareacontext.hxx | 15 -
oox/inc/drawingml/chart/plotareamodel.hxx |9 ---
oox/source/drawingml/chart/datatablecontext.cxx | 68
oox/source/drawingml/chart/plotareacontext.cxx | 32 ---
oox/source/drawingml/chart/plotareamodel.cxx|7 --
sfx2/source/control/unoctitm.cxx|8 ++
10 files changed, 171 insertions(+), 62 deletions(-)
New commits:
commit 32e38ec654cfd467aad74da59366bd41142b3bdc
Author: Tomaž Vajngerl
AuthorDate: Thu Apr 14 15:57:01 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Fri Apr 15 01:35:09 2022 +0200
oox: move DataTable{Context,Model} into own file, prop. "showKeys"
Move DataTableContext and DataTableModel into its own files and
add the missing "showKeys" property of the data table (dTable).
Change-Id: I44fb436000c7f00a596fc9b12489d15ea1368e68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133021
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/oox/Library_oox.mk b/oox/Library_oox.mk
index ca88ab100039..01da0aa4374d 100644
--- a/oox/Library_oox.mk
+++ b/oox/Library_oox.mk
@@ -100,6 +100,7 @@ $(eval $(call gb_Library_add_exception_objects,oox,\
oox/source/drawingml/chart/datasourcecontext \
oox/source/drawingml/chart/datasourceconverter \
oox/source/drawingml/chart/datasourcemodel \
+oox/source/drawingml/chart/datatablecontext \
oox/source/drawingml/chart/modelbase \
oox/source/drawingml/chart/objectformatter \
oox/source/drawingml/chart/plotareacontext \
diff --git a/oox/inc/drawingml/chart/datatablecontext.hxx
b/oox/inc/drawingml/chart/datatablecontext.hxx
new file mode 100644
index ..01a75c6e634d
--- /dev/null
+++ b/oox/inc/drawingml/chart/datatablecontext.hxx
@@ -0,0 +1,42 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+
+namespace oox::drawingml::chart
+{
+struct DataTableModel;
+
+/** Handler for a data table context (c:dTable element).
+ */
+class DataTableContext final : public ContextBase
+{
+public:
+explicit DataTableContext(::oox::core::ContextHandler2Helper& rParent,
DataTableModel& rModel);
+virtual ~DataTableContext() override;
+
+virtual ::oox::core::ContextHandlerRef onCreateContext(sal_Int32 nElement,
+ const
AttributeList& rAttribs) override;
+};
+
+} // namespace oox::drawingml::chart
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/inc/drawingml/chart/datatablemodel.hxx
b/oox/inc/drawingml/chart/datatablemodel.hxx
new file mode 100644
index ..5c7fe7901200
--- /dev/null
+++ b/oox/inc/drawingml/chart/datatablemodel.hxx
@@ -0,0 +1,41 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+namespace oox::drawingml::chart
+{
+struct DataTableModel
+{
+bool mbShowHBorder : 1; /// Show Horizontal Border
+bool mbShowVBorder : 1; /// Show
[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue
https://bugs.documentfoundation.org/show_bug.cgi?id=103866 sdc.bla...@youmail.dk changed: What|Removed |Added Resolution|FIXED |INSUFFICIENTDATA --- Comment #32 from sdc.bla...@youmail.dk --- (In reply to Ben from comment #28) Ben --the bugs system here is only for identifying bugs and confirming enhancement ideas, but it requires that the bug submitter gives a clear procedure for how to produce the bug, and a specific identification of what has actually happened compared to the expected behavior of the software. > It is unclear to me if this is a bug or global property that is improperly > set. Fair enough. If you want help from others to solve your formatting problems then http://ask.libreoffice.org is the right place to go. There are knowledgeable persons there, who usually respond quickly, and often are able to identify something as a likely or potential bug (and even suggest to file a report here). (Some of the bug reports started as a ask.libreoffice.org query) In light of the situation, I propose that we Resolve this ticket as INSUFFICIENTDATA (which is the local convention for saying that the bug report was not specific enough to be addressed). How does that sound? Meanwhile, as a friendly suggestion, try https://ask.libreoffice.org. Pick just one formula that you think is particularly difficult or problematic, and ask for help there about how to format that one formula. >From understanding that one case, you are likely to gain a better general understanding of how to approach other formula, or you can continue to ask questions there. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148603] New: cannot set Wrap/Top value of Graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=148603 Bug ID: 148603 Summary: cannot set Wrap/Top value of Graphics Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Created attachment 179572 --> https://bugs.documentfoundation.org/attachment.cgi?id=179572=edit template with Graphics In txSlips.ott>Styles>Frames, edit Graphics: set Wrap/Top to 0.08, click Apply: Top returns to 0.00. Idem if you click OK with Top=0.08; when you check back, Top has returned to 0.00. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 103866, which changed state. Bug 103866 Summary: Formula Vertical Alignment issue https://bugs.documentfoundation.org/show_bug.cgi?id=103866 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue
https://bugs.documentfoundation.org/show_bug.cgi?id=103866 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #31 from sdc.bla...@youmail.dk --- (In reply to Ben from comment #28) Ben --the bugs system here is only for identifying bugs and confirming enhancement ideas, but it requires that the bug submitter gives a clear procedure for how to produce the bug, and a specific identification of what has actually happened compared to the expected behavior of the software. > It is unclear to me if this is a bug or global property that is improperly > set. Fair enough. If you want help from others to solve your formatting problems then http://ask.libreoffice.org is the right place to go. There are knowledgeable persons there, who usually respond quickly, and often are able to identify something as a likely or potential bug (and even suggest to file a report here). (Some of the bug reports started as a ask.libreoffice.org query) In light of the situation, I propose that we Resolve this ticket as INSUFFICIENTDATA (which is the local convention for saying that the bug report was not specific enough to be addressed). How does that sound? Meanwhile, as a friendly suggestion, try https://ask.libreoffice.org. Pick just one formula that you think is particularly difficult or problematic, and ask for help there about how to format that one formula. >From understanding that one case, you are likely to gain a better general understanding of how to approach other formula, or you can continue to ask questions there. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148602] New: cannot set Wrap/Top value of Graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=148602 Bug ID: 148602 Summary: cannot set Wrap/Top value of Graphics Product: LibreOffice Version: 7.3.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tor...@yahoo.com Description: In txSlips.ott>Styles>Frames, edit Graphics: set Wrap/Top to 0.08, click Apply: Top returns to 0.00. Idem if you click OK with Top=0.08; when you check back, Top has returned to 0.00. Steps to Reproduce: 1.edit Graphics: set Wrap/Top to 0.08 2.click Apply 3. Actual Results: Top returns to 0.00 Expected Results: Top should remain=0.08 Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.3 (x64) / LibreOffice Community Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-CA (en_CA); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148596] Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 Cor Nouws changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #4 from Cor Nouws --- Hi Miguel, Ah.. thanks for checking - and sorry that I missed this :) ! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148601] New: error en la interfaz desde la 7.0
https://bugs.documentfoundation.org/show_bug.cgi?id=148601 Bug ID: 148601 Summary: error en la interfaz desde la 7.0 Product: LibreOffice Version: 7.0 all versions Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: maicoleduardofigue...@gmail.com Description: hay un error que hace que las dialogos o barras se salgan de la pantalla y no se vean completas Actual Results: error de interfaz Expected Results: que se vea completo Reproducible: Always User Profile Reset: No Additional Info: hace falta una mejor opcion para reportar los errores -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148468] Outline track default should be only track if in Outline subtree
https://bugs.documentfoundation.org/show_bug.cgi?id=148468 --- Comment #2 from Eyal Rozenberg --- Created attachment 179571 --> https://bugs.documentfoundation.org/attachment.cgi?id=179571=edit Document for experiencing the issue In the attached document, ensure Outline tracking is set to Default. Comment tracking setting should not matter. Now, open the Navigator. Expand the Comments category and select one of the later comments. There are lots of comments, so the Outline/Chapters/Headings (those names are used interchangeably in LibreOffice, which is a bug in itself IMHO but which some people who shall remain nameless refuse to recognize; but nevermind) are out of view. With the mouse, click the paragraph to which the comment is referring. You will notice the Navigator has scrolled up, to one of the Headings/Outline/Chapters entries. That should not happen. If one is reviewing the comments using the navigator, one does _not_ want to be taken away to a different category, with the relevant comment entries in the Navigator tree out of view. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147948] Visual improvements in LibreOffice - Mockups - "revolutionary, good, simple" ideas
https://bugs.documentfoundation.org/show_bug.cgi?id=147948 --- Comment #23 from Yeron 50201 --- Created attachment 179570 --> https://bugs.documentfoundation.org/attachment.cgi?id=179570=edit minimal_menu new image minimal menu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147948] Visual improvements in LibreOffice - Mockups - "revolutionary, good, simple" ideas
https://bugs.documentfoundation.org/show_bug.cgi?id=147948 --- Comment #23 from Yeron 50201 --- Created attachment 179570 --> https://bugs.documentfoundation.org/attachment.cgi?id=179570=edit minimal_menu new image minimal menu -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: include/o3tl
include/o3tl/string_view.hxx | 16 1 file changed, 12 insertions(+), 4 deletions(-) New commits: commit 7582286258984d790274295aea1cd7eb6ad96602 Author: Stephan Bergmann AuthorDate: Thu Apr 14 14:17:50 2022 +0200 Commit: Stephan Bergmann CommitDate: Thu Apr 14 22:35:39 2022 +0200 Add some clarifying comments for o3lt::getToken Change-Id: I417f048cdcd74e0a06b4c08d7d1851ea3e8a7077 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133015 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/o3tl/string_view.hxx b/include/o3tl/string_view.hxx index bf72c0b2b976..903cc5ced758 100644 --- a/include/o3tl/string_view.hxx +++ b/include/o3tl/string_view.hxx @@ -48,9 +48,13 @@ inline int compareToIgnoreAsciiCase(std::u16string_view s1, std::u16string_view return rtl_ustr_compareIgnoreAsciiCase_WithLength(s1.data(), s1.size(), s2.data(), s2.size()); }; -// Similar to O[U]String::getToken, returning the first token of a std::[u16]string_view, starting -// at a given position (and if needed, it can be extended to return the n'th token instead of just -// the first, or support an initial position of npos): +// Similar to O[U]String::getToken, returning the first token of a std::[u16]string_view starting +// at a given position. +// +// Attention: There are two sets of o3tl::getToken overloads here. This first set has an interface +// based on std::size_t length parameters, and its semantics don't match those of +// O[U]String::getToken exactly (buf if needed, it can be extended to return the n'th token instead +// of just the first, and/or support an initial position of npos, to make the semantics match). template > inline std::basic_string_view getToken(std::basic_string_view sv, charT delimiter, std::size_t& position) @@ -80,7 +84,11 @@ inline std::u16string_view getToken(std::u16string_view sv, char16_t delimiter, return getToken(sv, delimiter, position); } -// Similar to OUString::getToken +// Similar to O[U]String::getToken. +// +// Attention: There are two sets of o3tl::getToken overloads here. This second set has an +// interface based on sal_Int32 length parameters, and is meant to be a drop-in replacement for +// O[U]String::getToken. template > inline std::basic_string_view getToken(std::basic_string_view pStr, sal_Int32 nToken, charT cTok,
[Libreoffice-bugs] [Bug 147948] Visual improvements in LibreOffice - Mockups - "revolutionary, good, simple" ideas
https://bugs.documentfoundation.org/show_bug.cgi?id=147948 --- Comment #22 from Yeron 50201 --- 1. Here it shows a minimal menu in textedit in mac-os - you can see in the youtube video: "Using TextEdit For Casual Word Processing (MacMost Now 379)" - https://www.youtube.com/watch?v=UNCo4Jvs5Ys 2. this video references the idea I mentioned here of having a minimal menu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 147948] Visual improvements in LibreOffice - Mockups - "revolutionary, good, simple" ideas
https://bugs.documentfoundation.org/show_bug.cgi?id=147948 --- Comment #22 from Yeron 50201 --- 1. Here it shows a minimal menu in textedit in mac-os - you can see in the youtube video: "Using TextEdit For Casual Word Processing (MacMost Now 379)" - https://www.youtube.com/watch?v=UNCo4Jvs5Ys 2. this video references the idea I mentioned here of having a minimal menu -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148229] MROUND shows up as com.sun.star.sheet.addİn.analysİs.getmround after reopening
https://bugs.documentfoundation.org/show_bug.cgi?id=148229 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- No repro Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: ab8d141967111ca81f4607db3618bb09214e42db CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo tested ODS and XLSX format. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148349] Use attention-attracting cue when pressing Ctrl+F while in the find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=148349 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #10 from Caolán McNamara --- well, https://gerrit.libreoffice.org/c/core/+/133030 for the flashing background idea (one flash). It's probably worth noting that ctrl+f has another special thing from bug 82502 to select all the text inside the findbar. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/TextLayoutCache.hxx |2 ++
vcl/inc/sallayout.hxx |1 -
vcl/source/gdi/CommonSalLayout.cxx | 20
vcl/source/gdi/impglyphitem.cxx |2 +-
vcl/source/outdev/text.cxx |3 ++-
vcl/source/text/TextLayoutCache.cxx | 25 -
6 files changed, 29 insertions(+), 24 deletions(-)
New commits:
commit 4557ea11aeda19b705b4d701bdd1b85db7f0b206
Author: Luboš Luňák
AuthorDate: Thu Apr 14 16:11:06 2022 +0200
Commit: Luboš Luňák
CommitDate: Thu Apr 14 21:48:56 2022 +0200
move vcl::text::TextLayoutCache caching to the class itself
I have no idea why I did that in GenericSalLayout.
Change-Id: I163b08045e7c1dcdbf35cf408525f8dbcc06c4f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133019
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/vcl/inc/TextLayoutCache.hxx b/vcl/inc/TextLayoutCache.hxx
index ecb85ea7043d..46e5c80dc320 100644
--- a/vcl/inc/TextLayoutCache.hxx
+++ b/vcl/inc/TextLayoutCache.hxx
@@ -49,6 +49,8 @@ class VCL_DLLPUBLIC TextLayoutCache
public:
std::vector runs;
TextLayoutCache(sal_Unicode const* pStr, sal_Int32 const nEnd);
+// Creates a cached instance.
+static std::shared_ptr Create(OUString
const&);
};
struct FirstCharsStringHash
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 894be0a3098b..75f7cb3c6ea0 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -113,7 +113,6 @@ public:
voidAdjustLayout(vcl::text::ImplLayoutArgs&) final override;
boolLayoutText(vcl::text::ImplLayoutArgs&, const
SalLayoutGlyphsImpl*) final override;
voidDrawText(SalGraphics&) const final override;
-static std::shared_ptr
CreateTextLayoutCache(OUString const&);
SalLayoutGlyphs GetGlyphs() const final override;
boolIsKashidaPosValid(int nCharPos) const final override;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index 628938c5b123..0007e3f355d1 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -21,11 +21,8 @@
#include
#include
-#include
-#include
#include
-#include
#include
#include
#include
@@ -156,23 +153,6 @@ namespace {
} // namespace
-std::shared_ptr
GenericSalLayout::CreateTextLayoutCache(OUString const& rString)
-{
-typedef o3tl::lru_map,
-vcl::text::FirstCharsStringHash, vcl::text::FastStringCompareEqual>
Cache;
-static vcl::DeleteOnDeinit< Cache > cache( 1000 );
-if( Cache* map = cache.get())
-{
-auto it = map->find(rString);
-if( it != map->end())
-return it->second;
-auto ret = std::make_shared(rString.getStr(), rString.getLength());
-map->insert( { rString, ret } );
-return ret;
-}
-return std::make_shared(rString.getStr(), rString.getLength());
-}
-
SalLayoutGlyphs GenericSalLayout::GetGlyphs() const
{
SalLayoutGlyphs glyphs;
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index d581715dc9cd..0268eb3861c0 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -256,7 +256,7 @@ SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr outputDevice, c
std::shared_ptr tmpLayoutCache;
if (layoutCache == nullptr)
{
-tmpLayoutCache = OutputDevice::CreateTextLayoutCache(text);
+tmpLayoutCache = vcl::text::TextLayoutCache::Create(text);
layoutCache = tmpLayoutCache.get();
}
std::unique_ptr layout = outputDevice->ImplLayout(
diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 522fd348c7ee..840341502beb 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -51,6 +51,7 @@
#include
#include
#include
+#include
#include
#define TEXT_DRAW_ELLIPSIS (DrawTextFlags::EndEllipsis |
DrawTextFlags::PathEllipsis | DrawTextFlags::NewsEllipsis)
@@ -1459,7 +1460,7 @@ std::unique_ptr OutputDevice::ImplLayout(const
OUString& rOrigStr,
std::shared_ptr
OutputDevice::CreateTextLayoutCache(
OUString const& rString)
{
-return GenericSalLayout::CreateTextLayoutCache(rString);
+return vcl::text::TextLayoutCache::Create(rString);
}
bool OutputDevice::GetTextIsRTL( const OUString& rString, sal_Int32 nIndex,
sal_Int32 nLen ) const
diff --git a/vcl/source/text/TextLayoutCache.cxx
b/vcl/source/text/TextLayoutCache.cxx
index 00e9f9405358..e1e4321a98d3 100644
--- a/vcl/source/text/TextLayoutCache.cxx
+++ b/vcl/source/text/TextLayoutCache.cxx
@@ -17,9 +17,14 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#include
#include
+#include
+
+#include
+#include
+#include
+
namespace vcl::text
{
TextLayoutCache::TextLayoutCache(sal_Unicode const* pStr, sal_Int32 const nEnd)
@@ -31,6 +36,24 @@ TextLayoutCache::TextLayoutCache(sal_Unicode const* pStr,
[Libreoffice-bugs] [Bug 148596] Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Created attachment 179569 --> https://bugs.documentfoundation.org/attachment.cgi?id=179569=edit Screenshot Hi Cor, acceptable for me, with:. Version: 7.2.6.2 (x64) / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL With 7.0 it has the column wide. With 7.1 the same look than with 7.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148600] New: Wrong encoding in the GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=148600 Bug ID: 148600 Summary: Wrong encoding in the GUI Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mabees...@googlemail.com Description: If there is bold text in the GUI, for example in the settings window, or only single characters, for example if you select a column in LibreOffice Calc, then these characters look like Russian characters. This is only the case for bold text. It does not change if I change the UI language. It is per default German, but the bug occur also with an English UI. Bug occurs with enabled but also disabled OpenGL. Steps to Reproduce: 1.Just start LibreOffice and go open settings for example or select a column in Calc. 2. 3. Actual Results: Characters look Cyrillic. Expected Results: Characters should look like the characters that are used in German or English. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: de Module: StartModule [Information guessed from browser] OS: Mac OS X (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104597] RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 Eyal Rozenberg changed: What|Removed |Added Summary|Text runs of RTL scripts|RTL script text runs are |(e.g. Arabic, Hebrew, |reversed on PDF import, |Persian) from imported PDF |PDFIProcessor::mirrorString |are reversed, |misbehaving |PDFIProcessor::mirrorString | |misbehaving | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa sd/source
sd/qa/unit/SVGExportTests.cxx| 10 +-
sd/qa/unit/tiledrendering/tiledrendering.cxx |4 ++--
sd/source/ui/docshell/docshel4.cxx | 21 +++--
sd/source/ui/inc/DrawDocShell.hxx|2 +-
sd/source/ui/inc/DrawViewShell.hxx |2 +-
sd/source/ui/inc/unopage.hxx |2 +-
sd/source/ui/unoidl/unopage.cxx | 10 +-
sd/source/ui/view/drviewsh.cxx |2 +-
8 files changed, 27 insertions(+), 26 deletions(-)
New commits:
commit 4475483b92da89f6ab7fa503c6db920b7b50d1b7
Author: Noel Grandin
AuthorDate: Thu Apr 14 11:48:13 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Apr 14 21:13:00 2022 +0200
use more string_view in sd
Change-Id: I301f3d8a6634df8be5fdd42649c0c265da8f9099
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133004
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/qa/unit/SVGExportTests.cxx b/sd/qa/unit/SVGExportTests.cxx
index d43815264d26..4878eca27972 100644
--- a/sd/qa/unit/SVGExportTests.cxx
+++ b/sd/qa/unit/SVGExportTests.cxx
@@ -46,13 +46,13 @@ bool isValidBitmapId(const OUString& sId)
return std::regex_match(sId.toUtf8().getStr(), aRegEx);
}
-BitmapChecksum getBitmapChecksumFromId(const OUString& sId)
+BitmapChecksum getBitmapChecksumFromId(std::u16string_view sId)
{
-sal_Int32 nStart = sId.indexOf("(") + 1;
-sal_Int32 nCount = sId.indexOf(")") - nStart;
-bool bIsValidRange = nStart > 0 && nCount > 0;
+size_t nStart = sId.find(u"(") + 1;
+size_t nCount = sId.find(u")") - nStart;
+bool bIsValidRange = nStart > 0 && nStart != std::u16string_view::npos &&
nCount > 0;
CPPUNIT_ASSERT(bIsValidRange);
-OUString sChecksum = sId.copy( nStart, nCount );
+OUString sChecksum( sId.substr( nStart, nCount ) );
return sChecksum.toUInt64();
}
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 4207f6bbce7f..9ce85a102f83 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -2676,9 +2676,9 @@ void SdTiledRenderingTest::testSlideDuplicateUndo()
namespace
{
-void lcl_extractHandleParameters(const OString& selection, sal_uInt32& id,
sal_uInt32& x, sal_uInt32& y)
+void lcl_extractHandleParameters(std::string_view selection, sal_uInt32& id,
sal_uInt32& x, sal_uInt32& y)
{
-OString extraInfo = selection.copy(selection.indexOf("{"));
+OString extraInfo( selection.substr(selection.find("{")) );
std::stringstream aStream(extraInfo.getStr());
boost::property_tree::ptree aTree;
boost::property_tree::read_json(aStream, aTree);
diff --git a/sd/source/ui/docshell/docshel4.cxx
b/sd/source/ui/docshell/docshel4.cxx
index 6150321ca33a..6fe599e44197 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -72,6 +72,7 @@
#include
#include
#include
+#include
#include
@@ -698,7 +699,7 @@ SfxStyleSheetBasePool* DrawDocShell::GetStyleSheetPool()
return mpDoc->GetStyleSheetPool();
}
-void DrawDocShell::GotoBookmark(const OUString& rBookmark)
+void DrawDocShell::GotoBookmark(std::u16string_view rBookmark)
{
auto pDrawViewShell = dynamic_cast( mpViewShell );
if (!pDrawViewShell)
@@ -710,28 +711,28 @@ void DrawDocShell::GotoBookmark(const OUString& rBookmark)
sal_uInt16 nPageNumber = SDRPAGE_NOTFOUND;
SdrObject* pObj = nullptr;
-static const OUStringLiteral sInteraction( u"action?" );
-if ( rBookmark.match( sInteraction ) )
+static constexpr std::u16string_view sInteraction( u"action?" );
+if ( o3tl::starts_with(rBookmark, sInteraction ) )
{
-static const OUStringLiteral sJump( u"jump=" );
-if ( rBookmark.match( sJump, sInteraction.getLength() ) )
+static constexpr std::u16string_view sJump( u"jump=" );
+if ( o3tl::starts_with(rBookmark.substr( sInteraction.size() ), sJump
) )
{
-OUString aDestination( rBookmark.copy( sInteraction.getLength() +
sJump.getLength() ) );
-if ( aDestination.match( "firstslide" ) )
+std::u16string_view aDestination( rBookmark.substr(
sInteraction.size() + sJump.size() ) );
+if ( o3tl::starts_with(aDestination, u"firstslide" ) )
{
nPageNumber = 1;
}
-else if ( aDestination.match( "lastslide" ) )
+else if ( o3tl::starts_with(aDestination, u"lastslide" ) )
{
nPageNumber = mpDoc->GetPageCount() - 2;
}
-else if ( aDestination.match( "previousslide" ) )
+else if ( o3tl::starts_with(aDestination, u"previousslide" ) )
{
SdPage* pPage = pDrawViewShell->GetActualPage();
nPageNumber = pPage->GetPageNum();
nPageNumber = nPageNumber > 2 ? nPageNumber - 2 :
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Jan-Marek Glogowski changed: What|Removed |Added Depends on||146297 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146297 [Bug 146297] NB TABBED: Styles Preview Widget does not implement scaling (visible in qt / kf5) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146297] NB TABBED: Styles Preview Widget does not implement scaling (visible in qt / kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=146297 Jan-Marek Glogowski changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148599] Frame style issue
https://bugs.documentfoundation.org/show_bug.cgi?id=148599 --- Comment #1 from la...@hotmail.com --- In the frame style the values seems persistent but not applied to existing frames. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148595] Opening any doc in Android Viewer or gtktiledviewer results in a crash
https://bugs.documentfoundation.org/show_bug.cgi?id=148595 --- Comment #3 from Michael Weghorn --- (In reply to Tor Lillqvist from comment #2) > What about the follow-up fix ab612633003c75dfb30664db8cc8924c086a91ee , does > that help? Unfortunately not, that was included in my builds already. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148599] New: Frame style issue
https://bugs.documentfoundation.org/show_bug.cgi?id=148599 Bug ID: 148599 Summary: Frame style issue Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: la...@hotmail.com Hi, Frame style doesn't seem to work at all. I try to change area color or relative width of a frame style and none of my frames with that style is updated in my document. Is it working differently compared to paragraph style ? Regards. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |5
+++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 003e2873e4463974e59e1f909f9250cde743851f
Author: Michael Weghorn
AuthorDate: Thu Apr 14 09:34:28 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 14 20:40:23 2022 +0200
android: Use proper Intent to open doc for API level < 19
`Intent.ACTION_OPEN_DOCUMENT` was introduced in API level 19,
therefore `Intent.ACTION_GET_CONTENT` is supposed to be used
for older Android versions.
The previous attempt at doing so didn't work, since no
`ActivityNotFoundException` is thrown when trying
to set the action to `Intent.ACTION_OPEN_DOCUMENT` on
older Android versions.
Fix that by using a proper version check instead.
Change-Id: Ie06fa3f39e3042b4b7161a3c937bf655eb658abd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133025
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index c18b784e581b..f2e366c90ed3 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -258,9 +258,10 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
private void showSystemFilePickerAndOpenFile() {
Intent intent = new Intent();
-try {
+if (Build.VERSION.SDK_INT >= 19) {
intent.setAction(Intent.ACTION_OPEN_DOCUMENT);
-} catch (ActivityNotFoundException exception) {
+}
+else {
// Intent.ACTION_OPEN_DOCUMENT added in API level 19, but
minSdkVersion is currently 16
intent.setAction(Intent.ACTION_GET_CONTENT);
}
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/FileUtilities.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f869807175f1fc49328465473aa8e90b6f1876ff
Author: Michael Weghorn
AuthorDate: Thu Apr 14 17:17:04 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 14 20:40:09 2022 +0200
android: Use "ContentResolver#query" available from API level 1
Use the `ContentResolver#query` overload that is available from
Android API level 1 on, not the one that's only available from
API level 26 on [2], which would otherwise trigger an exception
if run on devices running Android version < 8.0, as seen
on an AVD with API level 21:
> E/AndroidRuntime( 2914): FATAL EXCEPTION: main
> E/AndroidRuntime( 2914): Process: org.libreoffice, PID: 2914
> E/AndroidRuntime( 2914): java.lang.NoSuchMethodError: No virtual method
query(Landroid/net/Uri;[Ljava/lang/String;Landroid/os/Bundle;Landroid/os/CancellationSignal;)Landroid/database/Cursor;
in class Landroid/content/ContentResolver; or its super classes (declaration
of 'android.content.ContentResolver' appears in /system/framework/framework.jar)
> E/AndroidRuntime( 2914):at
org.libreoffice.ui.FileUtilities.retrieveDisplayNameForDocumentUri(FileUtilities.java:137)
> E/AndroidRuntime( 2914):at
org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:206)
> E/AndroidRuntime( 2914):at
org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147)
> E/AndroidRuntime( 2914):at
android.app.Activity.performCreate(Activity.java:5937)
> E/AndroidRuntime( 2914):at
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
> E/AndroidRuntime( 2914):at
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2251)
> E/AndroidRuntime( 2914):at
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2360)
> E/AndroidRuntime( 2914):at
android.app.ActivityThread.access$800(ActivityThread.java:144)
> E/AndroidRuntime( 2914):at
android.app.ActivityThread$H.handleMessage(ActivityThread.java:1278)
> E/AndroidRuntime( 2914):at
android.os.Handler.dispatchMessage(Handler.java:102)
> E/AndroidRuntime( 2914):at android.os.Looper.loop(Looper.java:135)
> E/AndroidRuntime( 2914):at
android.app.ActivityThread.main(ActivityThread.java:5221)
> E/AndroidRuntime( 2914):at java.lang.reflect.Method.invoke(Native
Method)
> E/AndroidRuntime( 2914):at
java.lang.reflect.Method.invoke(Method.java:372)
> E/AndroidRuntime( 2914):at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
> E/AndroidRuntime( 2914):at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
>
[1]
https://developer.android.com/reference/android/content/ContentResolver#query(android.net.Uri,%20java.lang.String[],%20java.lang.String,%20java.lang.String[],%20java.lang.String)
[2]
https://developer.android.com/reference/android/content/ContentResolver#query(android.net.Uri,%20java.lang.String[],%20android.os.Bundle,%20android.os.CancellationSignal)
Change-Id: I13ecc57d3d6b25a7eb2e5ff85a3420ef8064cb20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133024
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/android/source/src/java/org/libreoffice/ui/FileUtilities.java
b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
index 5bfb93b4c1f5..72da47b8cc3a 100644
--- a/android/source/src/java/org/libreoffice/ui/FileUtilities.java
+++ b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
@@ -134,7 +134,7 @@ public class FileUtilities {
Cursor cursor = null;
try {
String[] columns = {OpenableColumns.DISPLAY_NAME};
-cursor = resolver.query(docUri, columns, null, null);
+cursor = resolver.query(docUri, columns, null, null, null);
if (cursor != null && cursor.moveToFirst()) {
displayName =
cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME));
}
[Libreoffice-commits] core.git: 2 commits - emfio/README.md vcl/source
emfio/README.md|2 +- vcl/source/filter/imet/ios2met.cxx |1 + 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 84de0b351c959c9a1ebbbd61bf0702561afc4d82 Author: Andrea Gelmini AuthorDate: Thu Apr 14 05:14:32 2022 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Thu Apr 14 20:38:02 2022 +0200 Fix typo Change-Id: I5707dbda5468256c8d03ac35b43fb54b8b4f3c7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132991 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/emfio/README.md b/emfio/README.md index db7393d9018c..283e0c3f41c7 100644 --- a/emfio/README.md +++ b/emfio/README.md @@ -119,7 +119,7 @@ modifies several binary formats from Microsoft including WMF/EMF/EMF+, and also other companies. * [EMF+ diagnostics reporting tool](https://github.com/chrissherlock/emfplus-decoder) * [limerest](https://gitlab.com/re-lab-project/limerest): A new gui tool based -on OLEToy for working with verious binary formats +on OLEToy for working with various binary formats ## Related Software * [libemf](http://libemf.sourceforge.net/) commit 6e53140dd3d7b414e81718d55ec288c4640ed587 Author: Caolán McNamara AuthorDate: Thu Apr 14 16:43:35 2022 +0100 Commit: Caolán McNamara CommitDate: Thu Apr 14 20:37:52 2022 +0200 cid#1504075 Uninitialized scalar field Change-Id: Ib24e34cabf99876b4aba56a768a34cd0da22a8dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133020 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/source/filter/imet/ios2met.cxx b/vcl/source/filter/imet/ios2met.cxx index 9054a244d62c..fe856c1d7bb6 100644 --- a/vcl/source/filter/imet/ios2met.cxx +++ b/vcl/source/filter/imet/ios2met.cxx @@ -345,6 +345,7 @@ struct OSAttr , nArcR(0) , nArcS(0) , nChrAng(0) +, nChrCellHeight(0) , nChrSet(0) , eLinStyle(PEN_NULL) , nLinWidth(0)
[Libreoffice-bugs] [Bug 115639] Align right/center with trailing spaces aren't treated the same in PPT(X) as in DOC(X)
https://bugs.documentfoundation.org/show_bug.cgi?id=115639 --- Comment #9 from Aron Budea --- Still the same in LO 7.4.0.0.alpha0+ (53fe4a26c7c4691fcf9d07d022adfd45247d176b) / Ubuntu. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143524] Table jumps around on every click - back and forth filling empty space or starting a new page
https://bugs.documentfoundation.org/show_bug.cgi?id=143524 --- Comment #4 from Justin L --- (In reply to Buovjaga from comment #3) > Justin: can you re-check? Yes, I reproduce immediately. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2475a552255fc100f2054d18dd85d3b044481129 CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148598] New: FORMATTING- A fraction is converted to date in cells designated as number
https://bugs.documentfoundation.org/show_bug.cgi?id=148598 Bug ID: 148598 Summary: FORMATTING- A fraction is converted to date in cells designated as number Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: waltp9...@gmail.com In cells formatted for numbers, fractions are converted to dates. I feel this conversion should only be made in cells formatted for dates, not numbers in general. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140575] [META] Gutter margin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=140575 Bug 140575 depends on bug 141803, which changed state. Bug 141803 Summary: FILEOPEN ODT gutter is not subtracted from margin in "mirrored" page layout https://bugs.documentfoundation.org/show_bug.cgi?id=141803 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141803] FILEOPEN ODT gutter is not subtracted from margin in "mirrored" page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=141803 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Regina Henschel --- I can no longer reproduce it with today master. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593 --- Comment #5 from Regina Henschel --- (In reply to Heiko Tietze from comment #1) > [Left] of [Left page border] sounds good to me and while [Right] of [Left > page border] is a bit weird it works well for [Right] of [Right page > border]. This *region to* is confusing. Perhaps page margin instead of > border? But is this really needed? > > Regina, Mike, your take? The wording should neither contain "Margin" nor "Border". The region in question is "page margin area" plus "page border area" plus "page padding area". Thereby "margin", "border" and "padding" are used as defined in CSS, see https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model or https://drafts.csswg.org/css-box/#box-model. It could be named page region left of page content area But that is too long for the drop-down list. You need "page" in the item, because you have regions related to paragraphs in the same list. Perhaps a total different concept is needed, for example a large preview, which has place enough to show the regions in question and has for each region an identifier that can be used in the list. The paragraph related items have the same wording problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593 --- Comment #5 from Regina Henschel --- (In reply to Heiko Tietze from comment #1) > [Left] of [Left page border] sounds good to me and while [Right] of [Left > page border] is a bit weird it works well for [Right] of [Right page > border]. This *region to* is confusing. Perhaps page margin instead of > border? But is this really needed? > > Regina, Mike, your take? The wording should neither contain "Margin" nor "Border". The region in question is "page margin area" plus "page border area" plus "page padding area". Thereby "margin", "border" and "padding" are used as defined in CSS, see https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model or https://drafts.csswg.org/css-box/#box-model. It could be named page region left of page content area But that is too long for the drop-down list. You need "page" in the item, because you have regions related to paragraphs in the same list. Perhaps a total different concept is needed, for example a large preview, which has place enough to show the regions in question and has for each region an identifier that can be used in the list. The paragraph related items have the same wording problem. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148597] New: FORMATTING request enhancement: create formatted Table of Figures using tabs before and after index
https://bugs.documentfoundation.org/show_bug.cgi?id=148597 Bug ID: 148597 Summary: FORMATTING request enhancement: create formatted Table of Figures using tabs before and after index Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ar...@bureauvoorarcheologie.nl I would like to be able to automatically format the Table of Figures so that the numbers align and the next lines can be outlined with the tabstop after the figure number. It will make it possible to format the Table of Figures the way it can be done with the Table of Contents. See for example screenshots: https://ask.libreoffice.org/t/how-to-create-formatted-table-of-figures-using-tabs-before-and-after-index-number/76464?u=bva This would improve professional look of the document. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 148312, which changed state. Bug 148312 Summary: Navigator should not show ToC entries as hyperlinks, at all https://bugs.documentfoundation.org/show_bug.cgi?id=148312 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148312] Navigator should not show ToC entries as hyperlinks, at all
https://bugs.documentfoundation.org/show_bug.cgi?id=148312 Jim Raykowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - binaryurp/source
binaryurp/source/binaryurp.component |5 ++--
binaryurp/source/bridgefactory.cxx | 39 +--
binaryurp/source/bridgefactory.hxx | 12 --
3 files changed, 10 insertions(+), 46 deletions(-)
New commits:
commit 65fc5bd895948d73f3d1eec14a669ada3e3465f0
Author: Noel Grandin
AuthorDate: Sat Jul 4 09:12:35 2020 +0200
Commit: Thorsten Behrens
CommitDate: Thu Apr 14 19:32:18 2022 +0200
binaryurp: create instances with uno constructors
See tdf#74608 for motivation
Change-Id: Ide39715f83b0183f560e16fa69fcb3112496936d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97933
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 9be078ae0d4cc4e4c01952bb42c9bb5943bbde86)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132945
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/binaryurp/source/binaryurp.component
b/binaryurp/source/binaryurp.component
index 1eff0c2c18d6..e2581c76411e 100644
--- a/binaryurp/source/binaryurp.component
+++ b/binaryurp/source/binaryurp.component
@@ -18,8 +18,9 @@
-->
http://openoffice.org/2010/uno-components;>
-
+xmlns="http://openoffice.org/2010/uno-components;>
+
diff --git a/binaryurp/source/bridgefactory.cxx
b/binaryurp/source/bridgefactory.cxx
index 6563b101f1df..f653d40cc68c 100644
--- a/binaryurp/source/bridgefactory.cxx
+++ b/binaryurp/source/bridgefactory.cxx
@@ -43,21 +43,6 @@
namespace binaryurp {
-css::uno::Reference< css::uno::XInterface > BridgeFactory::static_create(
-css::uno::Reference< css::uno::XComponentContext > const & /*xContext*/)
-{
-return static_cast< cppu::OWeakObject * >(new BridgeFactory);
-}
-
-OUString BridgeFactory::static_getImplementationName() {
-return "com.sun.star.comp.bridge.BridgeFactory";
-}
-
-css::uno::Sequence< OUString >
-BridgeFactory::static_getSupportedServiceNames() {
-return css::uno::Sequence{ "com.sun.star.bridge.BridgeFactory" };
-}
-
void BridgeFactory::removeBridge(
css::uno::Reference< css::bridge::XBridge > const & bridge)
{
@@ -85,7 +70,7 @@ BridgeFactory::~BridgeFactory() {}
OUString BridgeFactory::getImplementationName()
{
-return static_getImplementationName();
+return "com.sun.star.comp.bridge.BridgeFactory";
}
sal_Bool BridgeFactory::supportsService(OUString const & ServiceName)
@@ -95,7 +80,7 @@ sal_Bool BridgeFactory::supportsService(OUString const &
ServiceName)
css::uno::Sequence< OUString > BridgeFactory::getSupportedServiceNames()
{
-return static_getSupportedServiceNames();
+return { "com.sun.star.bridge.BridgeFactory" };
}
css::uno::Reference< css::bridge::XBridge > BridgeFactory::createBridge(
@@ -198,23 +183,11 @@ void BridgeFactory::disposing() {
}
-namespace {
-
-static cppu::ImplementationEntry const services[] = {
-{ ::BridgeFactory::static_create,
- ::BridgeFactory::static_getImplementationName,
- ::BridgeFactory::static_getSupportedServiceNames,
- ::createOneInstanceComponentFactory, nullptr, 0 },
-{ nullptr, nullptr, nullptr, nullptr, nullptr, 0 }
-};
-
-}
-
-extern "C" SAL_DLLPUBLIC_EXPORT void * binaryurp_component_getFactory(
-char const * pImplName, void * pServiceManager, void * pRegistryKey)
+extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
+com_sun_star_comp_bridge_BridgeFactory_get_implementation(
+css::uno::XComponentContext* , css::uno::Sequence const&)
{
-return cppu::component_getFactoryHelper(
-pImplName, pServiceManager, pRegistryKey, services);
+return cppu::acquire(static_cast< cppu::OWeakObject * >(new
binaryurp::BridgeFactory));
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/binaryurp/source/bridgefactory.hxx
b/binaryurp/source/bridgefactory.hxx
index 1a83962ee6b7..bbe2e39fd46a 100644
--- a/binaryurp/source/bridgefactory.hxx
+++ b/binaryurp/source/bridgefactory.hxx
@@ -57,16 +57,6 @@ typedef
class BridgeFactory : private cppu::BaseMutex, public BridgeFactoryBase
{
public:
-static com::sun::star::uno::Reference< com::sun::star::uno::XInterface >
-SAL_CALL static_create(
-com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext
>
-const & xContext);
-
-static OUString SAL_CALL static_getImplementationName();
-
-static com::sun::star::uno::Sequence< OUString > SAL_CALL
-static_getSupportedServiceNames();
-
void removeBridge(
com::sun::star::uno::Reference< com::sun::star::bridge::XBridge >
const & bridge);
@@ -74,7 +64,6 @@ public:
using BridgeFactoryBase::acquire;
using BridgeFactoryBase::release;
-private:
BridgeFactory(const BridgeFactory&) = delete;
BridgeFactory& operator=(const BridgeFactory&) = delete;
@@ -82,6 +71,7 @@ private:
virtual ~BridgeFactory() override;
+private:
virtual OUString SAL_CALL getImplementationName() override;
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - sfx2/source
sfx2/source/doc/objmisc.cxx | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
New commits:
commit 6520d6f9b09085af9c63d3c35108fb8083abbefa
Author: Samuel Mehrbrodt
AuthorDate: Wed Apr 13 08:01:29 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Apr 14 19:31:51 2022 +0200
Prevent save interception when sharing Calc doc
Using the dispatch mechanism means that this can be caught by the dispatch
interceptor
which we don't want in this place.
Change-Id: Ie7e5f92e6043e2aff98d4887829a3573c12c6d08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132946
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 4afaf1cc5d7b..04ff6ecd5314 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -113,6 +113,7 @@
#include
#include
#include
+#include
#include
#include
#include "objstor.hxx"
@@ -521,9 +522,16 @@ bool SfxObjectShell::SwitchToShared( bool bShared, bool
bSave )
{
// TODO/LATER: currently the application guards against the
reentrance problem
SetModified(); // the modified flag has to be set to let the
document be stored with the shared flag
-const SfxPoolItem* pItem =
pViewFrame->GetBindings().ExecuteSynchron( HasName() ? SID_SAVEDOC :
SID_SAVEASDOC );
-const SfxBoolItem* pResult = dynamic_cast(
pItem );
-bResult = ( pResult && pResult->GetValue() );
+try
+{
+// Do *not* use dispatch mechanism in this place - we
don't want others (extensions etc.) to intercept this.
+pImpl->pBaseModel->store();
+bResult = true;
+}
+catch (...)
+{
+bResult = false;
+}
}
}
[Libreoffice-bugs] [Bug 148595] Opening any doc in Android Viewer or gtktiledviewer results in a crash
https://bugs.documentfoundation.org/show_bug.cgi?id=148595 --- Comment #2 from Tor Lillqvist --- What about the follow-up fix ab612633003c75dfb30664db8cc8924c086a91ee , does that help? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 143615, which changed state. Bug 143615 Summary: Impress: Crash when slide transition = 0sec ( steps in comment 10 ) https://bugs.documentfoundation.org/show_bug.cgi?id=143615 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103704 Bug 103704 depends on bug 143615, which changed state. Bug 143615 Summary: Impress: Crash when slide transition = 0sec ( steps in comment 10 ) https://bugs.documentfoundation.org/show_bug.cgi?id=143615 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103444] [META] Slide transition deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103444 Bug 103444 depends on bug 143615, which changed state. Bug 143615 Summary: Impress: Crash when slide transition = 0sec ( steps in comment 10 ) https://bugs.documentfoundation.org/show_bug.cgi?id=143615 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec ( steps in comment 10 )
https://bugs.documentfoundation.org/show_bug.cgi?id=143615 Thorsten Behrens (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |t...@libreoffice.org |desktop.org | Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: slideshow/source
slideshow/source/engine/activities/simplecontinuousactivitybase.cxx | 12 +++--- 1 file changed, 9 insertions(+), 3 deletions(-) New commits: commit e1db8c27875eac73b1e619e4a23ecdb7a9924b61 Author: Thorsten Behrens AuthorDate: Thu Apr 14 12:01:50 2022 +0200 Commit: Thorsten Behrens CommitDate: Thu Apr 14 19:29:03 2022 +0200 Resolves: tdf#143615 clamp relative times to 1.0 User input permits zero-length animations, so whenever we calculate relative position within the animation time frame, the case mnMinSimpleDuration == 0.0 means: we're already at the end of the animation, i.e. set relative time to 1.0 Change-Id: I0e8c1e29f47bd9fa16f04115cf52d3a176e13fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133005 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx index 9e23fc2c76c8..01cb3b75007b 100644 --- a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx +++ b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx @@ -63,9 +63,12 @@ namespace slideshow::internal // perform will be called at least mnMinNumberOfTurns // times. -// fraction of time elapsed +// fraction of time elapsed (clamp to 1.0 for zero-length +// animations) const double nFractionElapsedTime( -nCurrElapsedTime / mnMinSimpleDuration ); +mnMinSimpleDuration != 0.0 ? +nCurrElapsedTime / mnMinSimpleDuration : +1.0 ); // fraction of minimum calls performed const double nFractionRequiredCalls( @@ -115,7 +118,10 @@ namespace slideshow::internal // === const double nCurrElapsedTime( maTimer.getElapsedTime() ); -double nT( nCurrElapsedTime / mnMinSimpleDuration ); +// clamp to 1.0 for zero animation duration +double nT( mnMinSimpleDuration != 0.0 ? + nCurrElapsedTime / mnMinSimpleDuration : + 1.0 ); // one of the stop criteria reached?
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - sfx2/source
sfx2/source/doc/objmisc.cxx | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
New commits:
commit e0a27e60ab8e37d89b350efc0c3c7abf65f483d0
Author: Samuel Mehrbrodt
AuthorDate: Wed Apr 13 08:01:29 2022 +0200
Commit: Thorsten Behrens
CommitDate: Thu Apr 14 19:28:41 2022 +0200
Prevent save interception when sharing Calc doc
Using the dispatch mechanism means that this can be caught by the dispatch
interceptor
which we don't want in this place.
Change-Id: Ie7e5f92e6043e2aff98d4887829a3573c12c6d08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132947
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 91817a637620..5b078261910f 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -106,6 +106,7 @@
#include
#include
#include
+#include
#include
#include
#include "objstor.hxx"
@@ -496,9 +497,16 @@ bool SfxObjectShell::SwitchToShared( bool bShared, bool
bSave )
{
// TODO/LATER: currently the application guards against the
reentrance problem
SetModified(); // the modified flag has to be set to let the
document be stored with the shared flag
-const SfxPoolItem* pItem =
pViewFrame->GetBindings().ExecuteSynchron( HasName() ? SID_SAVEDOC :
SID_SAVEASDOC );
-const SfxBoolItem* pResult = dynamic_cast(
pItem );
-bResult = ( pResult && pResult->GetValue() );
+try
+{
+// Do *not* use dispatch mechanism in this place - we
don't want others (extensions etc.) to intercept this.
+pImpl->pBaseModel->store();
+bResult = true;
+}
+catch (...)
+{
+bResult = false;
+}
}
}
[Libreoffice-commits] core.git: 2 commits - include/o3tl unotools/source
include/o3tl/string_view.hxx |3 ++-
unotools/source/config/bootstrap.cxx |6 +++---
unotools/source/ucbhelper/tempfile.cxx |8
3 files changed, 9 insertions(+), 8 deletions(-)
New commits:
commit af4407649d2c8a2ea59487d5fc1f8cc742ddd0b2
Author: Noel Grandin
AuthorDate: Thu Apr 14 13:46:06 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Apr 14 19:26:04 2022 +0200
use more string_view in unotools
Change-Id: I5fc3753475c3c6a45f86910eeb49055f96a2e925
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133013
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/unotools/source/config/bootstrap.cxx
b/unotools/source/config/bootstrap.cxx
index 09c52157024b..ef7ba57000c1 100644
--- a/unotools/source/config/bootstrap.cxx
+++ b/unotools/source/config/bootstrap.cxx
@@ -413,12 +413,12 @@ char const IS_MISSING[] = "is missing";
char const IS_INVALID[] = "is corrupt";
char const PERIOD[] = ". ";
-static void addFileError(OUStringBuffer& _rBuf, OUString const& _aPath,
AsciiString _sWhat)
+static void addFileError(OUStringBuffer& _rBuf, std::u16string_view _aPath,
AsciiString _sWhat)
{
-OUString sSimpleFileName = _aPath.copy(1
+_aPath.lastIndexOf(cURLSeparator));
+std::u16string_view sSimpleFileName = _aPath.substr(1
+_aPath.rfind(cURLSeparator));
_rBuf.append("The configuration file");
-_rBuf.append(" '" + sSimpleFileName + "' ");
+_rBuf.append(OUString::Concat(" '") + sSimpleFileName + "' ");
_rBuf.appendAscii(_sWhat).append(PERIOD);
}
diff --git a/unotools/source/ucbhelper/tempfile.cxx
b/unotools/source/ucbhelper/tempfile.cxx
index 4fac0bacd782..e912c609337b 100644
--- a/unotools/source/ucbhelper/tempfile.cxx
+++ b/unotools/source/ucbhelper/tempfile.cxx
@@ -47,14 +47,14 @@ namespace
namespace utl
{
-static OUString getParentName( const OUString& aFileName )
+static OUString getParentName( std::u16string_view aFileName )
{
-sal_Int32 lastIndex = aFileName.lastIndexOf( '/' );
+size_t lastIndex = aFileName.rfind( '/' );
OUString aParent;
-if (lastIndex > -1)
+if (lastIndex != std::u16string_view::npos)
{
-aParent = aFileName.copy(0, lastIndex);
+aParent = aFileName.substr(0, lastIndex);
if (aParent.endsWith(":") && aParent.getLength() == 6)
aParent += "/";
commit 2a5b28eaaaf8ff56778fcdfb28f0a660592c7866
Author: Noel Grandin
AuthorDate: Thu Apr 14 13:16:58 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Apr 14 19:25:52 2022 +0200
address review comments
(*) fix parameter type of getToken()
Change-Id: Ib6fcfc6b217e98f57e600dc44c888366b432c19e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133011
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/o3tl/string_view.hxx b/include/o3tl/string_view.hxx
index eb98e243c8b1..bf72c0b2b976 100644
--- a/include/o3tl/string_view.hxx
+++ b/include/o3tl/string_view.hxx
@@ -74,7 +74,8 @@ inline std::string_view getToken(std::string_view sv, char
delimiter, std::size_
{
return getToken(sv, delimiter, position);
}
-inline std::u16string_view getToken(std::u16string_view sv, char delimiter,
std::size_t& position)
+inline std::u16string_view getToken(std::u16string_view sv, char16_t delimiter,
+std::size_t& position)
{
return getToken(sv, delimiter, position);
}
[Libreoffice-bugs] [Bug 148458] If Calc finds an error in a formula, and users decide *not* to autocorrect, Calc may chop out parts of the formula.
https://bugs.documentfoundation.org/show_bug.cgi?id=148458 MarjaE changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from MarjaE --- I recall times it dropped the 0.0004689, I think that involved typing the last terms, and then re-typing the first. But I only see it drop the B6 and B2 terms in Safe Mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148458] If Calc finds an error in a formula, and users decide *not* to autocorrect, Calc may chop out parts of the formula.
https://bugs.documentfoundation.org/show_bug.cgi?id=148458 --- Comment #2 from MarjaE --- Any of them. Trying again, if I reject corrections, I get Err:509. If I accept corrections, I get = 0.0004689*(B4^0.55) instead of = 0.0004689*(B4^0.55)*(B6^1.1)/(B8^0.65) So it's dropping 2 out of 4 terms. If I start re-typing the rest, it just goes to Err:509 now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148596] Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 Cor Nouws changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3160 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148596] Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 --- Comment #2 from Cor Nouws --- Created attachment 179568 --> https://bugs.documentfoundation.org/attachment.cgi?id=179568=edit test file exposing the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148596] Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 Cor Nouws changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #1 from Cor Nouws --- Created attachment 179567 --> https://bugs.documentfoundation.org/attachment.cgi?id=179567=edit screen shot shoeing the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148596] New: Selection List can appear very wide, depending on longest string in column - odd looking
https://bugs.documentfoundation.org/show_bug.cgi?id=148596 Bug ID: 148596 Summary: Selection List can appear very wide, depending on longest string in column - odd looking Product: LibreOffice Version: 7.0 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: c...@nouenoff.nl The width of a Selection List (Alt+Down) is determined by the longest string in the column. Logic as such, but if there is one cell with a (verry) long string, it looks odd. And if the user is not realizing what causes this (as happened me, since I didn't know the length of all strings of the past year+ ;) ) he calls the service desk. Quite sure that this comes from bug 133160 I'll attach an image and a test file to show & help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144075] Fonts in interface and preferences are too small.
https://bugs.documentfoundation.org/show_bug.cgi?id=144075 --- Comment #14 from MarjaE --- Also affects the dialogue when opening safe mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148312] Navigator should not show ToC entries as hyperlinks, at all
https://bugs.documentfoundation.org/show_bug.cgi?id=148312 --- Comment #3 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/78b723c3a1fad1c095de1e5c746aef513556a53b tdf#52113, tdf#148312 Don't include table of contents hyperlinks It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148312] Navigator should not show ToC entries as hyperlinks, at all
https://bugs.documentfoundation.org/show_bug.cgi?id=148312 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 52113] Navigator should show the Hyperlinks embedded in TOC separately
https://bugs.documentfoundation.org/show_bug.cgi?id=52113 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 52113] Navigator should show the Hyperlinks embedded in TOC separately
https://bugs.documentfoundation.org/show_bug.cgi?id=52113 --- Comment #2 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/78b723c3a1fad1c095de1e5c746aef513556a53b tdf#52113, tdf#148312 Don't include table of contents hyperlinks It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/editsh.hxx |2 +-
sw/source/core/edit/editsh.cxx | 14 +-
sw/source/uibase/utlui/content.cxx |2 +-
3 files changed, 15 insertions(+), 3 deletions(-)
New commits:
commit 78b723c3a1fad1c095de1e5c746aef513556a53b
Author: Jim Raykowski
AuthorDate: Wed Apr 13 18:15:11 2022 -0800
Commit: Jim Raykowski
CommitDate: Thu Apr 14 18:44:14 2022 +0200
tdf#52113, tdf#148312 Don't include table of contents hyperlinks
in the Navigator content tree Hyperlinks entries
Change-Id: I8d4499ecd6d9f617192560b31d7f87f7f26269f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132988
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 95faaf6003cd..9439d8a777e0 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -826,7 +826,7 @@ public:
bool InsertURL( const SwFormatINetFormat& rFormat, const OUString& rStr,
bool bKeepSelection = false );
-void GetINetAttrs( SwGetINetAttrs& rArr );
+void GetINetAttrs(SwGetINetAttrs& rArr , bool bIncludeInToxContent = true);
OUString GetDropText( const sal_Int32 nChars ) const;
void ReplaceDropText( const OUString , SwPaM* pPaM = nullptr );
diff --git a/sw/source/core/edit/editsh.cxx b/sw/source/core/edit/editsh.cxx
index b1d265305321..a6a27bcc5b57 100644
--- a/sw/source/core/edit/editsh.cxx
+++ b/sw/source/core/edit/editsh.cxx
@@ -685,7 +685,7 @@ bool SwEditShell::InsertURL( const SwFormatINetFormat&
rFormat, const OUString&
return true;
}
-void SwEditShell::GetINetAttrs( SwGetINetAttrs& rArr )
+void SwEditShell::GetINetAttrs(SwGetINetAttrs& rArr, bool bIncludeInToxContent)
{
rArr.clear();
@@ -705,6 +705,18 @@ void SwEditShell::GetINetAttrs( SwGetINetAttrs& rArr )
&& pFrame->MapModelToView(pTextNd, pFnd->GetStart())
!= pFrame->MapModelToView(pTextNd, *pFnd->GetEnd()))
{
+// tdf#52113, tdf#148312 Don't include table of contents
hyperlinks in the
+// Navigator content tree Hyperlinks entries
+if (!bIncludeInToxContent)
+{
+if(const SwSectionNode* pSectNd =
pTextNd->FindSectionNode())
+{
+SectionType eType = pSectNd->GetSection().GetType();
+if(SectionType::ToxContent == eType)
+continue;
+}
+}
+
SwTextINetFormat& rAttr = *pFnd;
OUString sText( pTextNd->GetExpandText(GetLayout(),
rAttr.GetStart(), *rAttr.GetEnd() - rAttr.GetStart())
);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 719b2016e1b7..c614ee4d7c7d 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -714,7 +714,7 @@ void SwContentType::FillMemberList(bool* pbContentChanged)
case ContentTypeId::URLFIELD:
{
SwGetINetAttrs aArr;
-m_pWrtShell->GetINetAttrs(aArr);
+m_pWrtShell->GetINetAttrs(aArr, false);
if (m_bAlphabeticSort)
{
[Libreoffice-bugs] [Bug 148349] Use attention-attracting cue when pressing Ctrl+F while in the find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=148349 --- Comment #9 from Eyal Rozenberg --- (In reply to Caolán McNamara from comment #8) > Created attachment 179564 [details] > a flashing widget demo > > The GtkInspector will "flash" the background of the widget 3 times like this. Sure. I would think just once is enough (since if you're Ctrl+F'ing, you'll probably notice), but 3 times is ok too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/implicitboolconversion.cxx |5 +++--
compilerplugins/clang/test/implicitboolconversion.cxx |7 ++-
2 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 36b7288a0ce9588b958e0b3a68613e9ee11cf17c
Author: Stephan Bergmann
AuthorDate: Thu Apr 14 15:49:01 2022 +0200
Commit: Stephan Bergmann
CommitDate: Thu Apr 14 18:25:49 2022 +0200
Use DeclCheck at one place in loplugin:implicitboolconversion
...and add tests for those additions to isBoolExpr done in
8e4d82cd1125502c26ddaaa85c49c4aa44f65811 "loplugin:implicitboolconversion:
warn
about conversions to unsigned char" (and which were added to avoid false
warnings like
> testtools/source/bridgetest/bridgetest.cxx:643:21: error: implicit
conversion (IntegralToBoolean) of call argument from 'unsigned char' to 'bool'
[loplugin:implicitboolconversion]
> (xLBT->transportPolyBoolean(
> ^~~~
and
> cui/source/options/optaboutconfig.cxx:359:62: error: implicit conversion
(IntegralToBoolean) of call argument from 'unsigned char' to 'bool'
[loplugin:implicitboolconversion]
> sValue.append(OUString::boolean( seq[j] ));
> ^~
)
Change-Id: I0683144e1c39d31303faf678afaafd708ef7ff79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133018
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/implicitboolconversion.cxx
b/compilerplugins/clang/implicitboolconversion.cxx
index e61f4a14cf0f..d0bdff190807 100644
--- a/compilerplugins/clang/implicitboolconversion.cxx
+++ b/compilerplugins/clang/implicitboolconversion.cxx
@@ -180,8 +180,9 @@ bool isBoolExpr(Expr const * expr) {
TemplateDecl const * d
= t->getTemplateName().getAsTemplateDecl();
if (d == nullptr
-|| (d->getQualifiedNameAsString()
-!= "com::sun::star::uno::Sequence")
+||
!loplugin::DeclCheck(d->getTemplatedDecl()).Class("Sequence")
+
.Namespace("uno").Namespace("star").Namespace("sun").Namespace("com")
+.GlobalNamespace()
|| t->getNumArgs() != 1
|| t->getArg(0).getKind() != TemplateArgument::Type)
{
diff --git a/compilerplugins/clang/test/implicitboolconversion.cxx
b/compilerplugins/clang/test/implicitboolconversion.cxx
index 47c015261fef..fa5a2b84b905 100644
--- a/compilerplugins/clang/test/implicitboolconversion.cxx
+++ b/compilerplugins/clang/test/implicitboolconversion.cxx
@@ -12,6 +12,7 @@
#include
#include
+#include
#include
template struct Sequence
@@ -35,6 +36,8 @@ template struct Wrap2
bool g();
+void h(bool);
+
void f()
{
// expected-error@+1 {{implicit conversion (IntegralCast) from 'bool' to
'int' [loplugin:implicitboolconversion]}}
@@ -63,13 +66,15 @@ void f()
Sequence> s4{ { false } };
(void)s4;
Wrap1 w1{ false };
-(void)w1;
Sequence> s5{ { false } };
(void)s5;
Wrap2 w2{ false };
(void)w2;
Sequence> s6{ { false } };
(void)s6;
+h(w1.element);
+css::uno::Sequence s7(1);
+h(s7[0]);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
[Libreoffice-bugs] [Bug 141735] Clone formatting while in text edit mode doesn't work as expected (Align to bottom becomes Align to top)
https://bugs.documentfoundation.org/show_bug.cgi?id=141735 Buovjaga changed: What|Removed |Added Version|7.1.2.2 release |6.3.0.4 release --- Comment #5 from Buovjaga --- Already seen in 6.3. In 5.0 and earlier, it is not possible to clone the formatting between text boxes in any way. In older versions, Align bottom/top, center vertically are found under Table (when customising toolbar buttons). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148591] Rename "page text area top" and "page text area bottom" to "Above (or Below) page text area
https://bugs.documentfoundation.org/show_bug.cgi?id=148591 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||148485 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148485 [Bug 148485] four options missing in "Position > Vertical > to" section for Position and Size tab for Shape -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148591] Rename "page text area top" and "page text area bottom" to "Above (or Below) page text area
https://bugs.documentfoundation.org/show_bug.cgi?id=148591 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||148485 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148485 [Bug 148485] four options missing in "Position > Vertical > to" section for Position and Size tab for Shape -- You are receiving this mail because: You are on the CC list for the bug.
