[Libreoffice-bugs] [Bug 131664] REPORT-BUILDER: Attribute "Auto Grow" will only be saved if first field of a row is set to "Auto Grow" → 'Yes'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131664

Robert Großkopf  changed:

   What|Removed |Added

 CC||lbi...@outlook.com

--- Comment #13 from Robert Großkopf  ---
*** Bug 148582 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148582] Report Text Box Parameter "Auto Grow" Automatically Changes to "No" After Saving the Document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148582

Robert Großkopf  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Robert Großkopf  ---
This bug has already been reported:
https://bugs.documentfoundation.org/show_bug.cgi?id=131664

*** This bug has been marked as a duplicate of bug 131664 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148582] Report Text Box Parameter "Auto Grow" Automatically Changes to "No" After Saving the Document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148582

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1664

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131664] REPORT-BUILDER: Attribute "Auto Grow" will only be saved if first field of a row is set to "Auto Grow" → 'Yes'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131664

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8582

--- Comment #12 from Robert Großkopf  ---
Bug still exists in LO 7.3.3.1 on OpenSUSE 15.3
See also the duplicate, which has just been reported.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148493] replacement does not work well

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148493

--- Comment #5 from masao-...@jcom.home.ne.jp ---
Created attachment 179603
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179603=edit
a sample document

I tried change word "一昨昨日" to "一昨々日" in all tabs.

And serch and change did not work well. 

I made the file to attach for the test. As you know this file is a sort of a
diary. So I tried to deleate sensitve informations, but could not remove all, I
know. Please take this fle caefully.

When I reported the bug, search and change worked as normal change and
irregular channge both. Irregular change changed not targetted word to not
requeste word.

I tested this attached file, and in this file no word seemedchanged, althoug
target word was recognised.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144782] LibreOffice_7.2.1_Win_x64.msi (323 MB) not downloading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144782

Duane Steele  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148274] AutoText from LO > 7.3 (or maybe > 7.0..?) incompatible with older versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148274

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148311] calc . REQUEST for Copy & Past configurability ......... ( 500 000 asking calc user so far )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148311

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148306] ToC column layout does not default to the page style's direction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148306

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148305] Multi-column table of contents/index is always LTR

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148305

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148487] when you try to insert a special character, Libre Office closes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148487

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148487] when you try to insert a special character, Libre Office closes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148487

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148299] Master Document: File not found if filename/path has back to back spaces.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148299

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148299] Master Document: File not found if filename/path has back to back spaces.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148299

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144507] Unable to save spreadsheets when one of them is a CSV file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144507

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144507] Unable to save spreadsheets when one of them is a CSV file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144507

--- Comment #7 from QA Administrators  ---
Dear Pete Haigh,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142572] Mendely Plugin: Word to LibreOffice citation compatibility problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142572

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142572] Mendely Plugin: Word to LibreOffice citation compatibility problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142572

--- Comment #5 from QA Administrators  ---
Dear Bittu,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145100] Applying numbered list style after bulleted increases its level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145100

--- Comment #2 from QA Administrators  ---
Dear larson,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144782] LibreOffice_7.2.1_Win_x64.msi (323 MB) not downloading

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144782

--- Comment #2 from QA Administrators  ---
Dear Duane Steele,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Justin Luth (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf148380_modifiedField.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx |   17 +
 sw/source/filter/ww8/ww8atr.cxx|4 +--
 3 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit d9b33ed6644203141fdb0776c291425c2bc9f5ac
Author: Justin Luth 
AuthorDate: Wed Apr 6 18:54:02 2022 +0200
Commit: Justin Luth 
CommitDate: Sat Apr 16 05:47:06 2022 +0200

tdf#148380 docx export: support CHANGEDATE/PRINTDATE without format

This is the same idea as the earlier patch for CREATEDATE.
However, it isn't safe to import these as fields,
so a round-trip test can only test the string itself.

The unit test here really doesn't test any of the code changes,
but is just pre-emptive to ensure that if DI_CHANGE
is imported as a field that it will have the right
output.
(P.S. Expected date output matches MS Word 2003
 even after an F9 refresh.)

Change-Id: I30a8b1fc851246898a67e6241a35e927f85dfbb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132664
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf148380_modifiedField.docx 
b/sw/qa/extras/ooxmlexport/data/tdf148380_modifiedField.docx
new file mode 100644
index ..14f6e319e298
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf148380_modifiedField.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 960bb3f16d8b..5d5bdb22471a 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -83,6 +83,23 @@ DECLARE_OOXMLEXPORT_TEST(testTdf148380_createField, 
"tdf148380_createField.docx"
 CPPUNIT_ASSERT_EQUAL(OUString("yesterday at noon"), 
xField->getPresentation(false));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf148380_modifiedField, 
"tdf148380_modifiedField.docx")
+{
+getParagraph(2, "4/5/2022 4:29:00 PM"); // default (unspecified) date 
format
+
+// Verify that these are fields, and not just plain text
+uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
+auto xFieldsAccess(xTextFieldsSupplier->getTextFields());
+uno::Reference 
xFields(xFieldsAccess->createEnumeration());
+uno::Reference xField(xFields->nextElement(), 
uno::UNO_QUERY);
+// unspecified SAVEDATE gets default US formatting because style.xml has 
w:lang w:val="en-US"
+//CPPUNIT_ASSERT_EQUAL(OUString("4/5/2022 4:29:00 PM"), 
xField->getPresentation(false));
+//xField.set(xFields->nextElement(), uno::UNO_QUERY);
+// FIXME: This was hand-modified and really should be Charlie Brown
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Did you fix me? I really should be Charlie 
Brown (or a date)",
+ OUString("Charles Brown"), 
xField->getPresentation(false));
+}
+
 CPPUNIT_TEST_FIXTURE(Test, testTdf135906)
 {
 loadAndReload("tdf135906.docx");
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index b9c71e4433ae..a5e650eb8e6c 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -2948,13 +2948,13 @@ void AttributeOutputBase::TextField( const 
SwFormatField& rField )
 case DI_CHANGE:
 if (DI_SUB_AUTHOR == (nSubType & DI_SUB_MASK))
 eField = ww::eLASTSAVEDBY;
-else if (GetExport().GetNumberFormat(*pField, sStr))
+else if (GetExport().GetNumberFormat(*pField, sStr) || 
sStr.isEmpty())
 eField = ww::eSAVEDATE;
 break;
 
 case DI_PRINT:
 if (DI_SUB_AUTHOR != (nSubType & DI_SUB_MASK) &&
-GetExport().GetNumberFormat(*pField, sStr))
+(GetExport().GetNumberFormat(*pField, sStr) || 
sStr.isEmpty()))
 eField = ww::ePRINTDATE;
 break;
 case DI_CUSTOM:

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Telesto  changed:

   What|Removed |Added

 Depends on||148620


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148620
[Bug 148620] Crash in Draw when using Format > Lists > Move Down
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148620] Crash in Draw when using Format > Lists > Move Down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

Telesto  changed:

   What|Removed |Added

 Blocks||133092


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148620] Crash in Draw when using Format > Lists > Move Down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

Telesto  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||tele...@surfxs.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148620] Crash in Draw when using Format > Lists > Move Down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

--- Comment #1 from Telesto  ---
Created attachment 179602
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179602=edit
BT with symbols

Confirm
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: fbf739198aa7f02975d531521c6525073783c7f1
CPU threads: 8; OS: Mac OS X 12.2.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148620] Crash in Draw when using Format > Lists > Move Down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Summary|Crash in Draw when using|Crash in Draw when using
   |Format > Lists > Move Up|Format > Lists > Move Down

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148620] New: Crash in Draw when using Format > Lists > Move Up

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

Bug ID: 148620
   Summary: Crash in Draw when using Format > Lists > Move Up
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk

Created attachment 179601
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179601=edit
test file for making Draw crash

First crash occurred in a textbox with a six item ordered list and using Format
> Lists > Move Up (and Move Down).

For subsequent crashes, I made a keyboard shortcuts to "Move Chapter Down" and
"Move Chapter Up" (see bug 144493 if you want to know why they have those names
in Customize).  I mention this because it makes testing easier.

STR.

1. Open attached draw document (or make your own list in a textbox).
2. Place cursor in a list item.
3. Press "down" shortcut key several times (rapidly may help).

It crashes reasonably quickly.  

STR 2

1. In attachment, select 4 lines of the list in the textbox.
2. Format > Lists > Move Down  (or use your shortcut key)

Crash.

Also reproduced using Safe Mode.

Have not tried to explore other possibilities, but Up may also produce crashes.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148619] Cell reference in formula don't update on all sheets when moving cells on multiple sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148619

--- Comment #1 from Gauthier  ---
Operating System: KDE neon 5.24
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3
Kernel Version: 5.13.0-39-generic (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-8350U CPU @ 1.70GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.20.04.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148619] New: Cell reference in formula don't update on all sheets when moving cells on multiple sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148619

Bug ID: 148619
   Summary: Cell reference in formula don't update on all sheets
when moving cells on multiple sheets
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: g.gue...@posteo.net

Created attachment 179600
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179600=edit
broken sheet

I have attached and example spreadsheet but first I am going to describe what I
am trying to do and what the problem is.

Say you have 4 sheets with exactly same content on Sheet 1, 2, 3.

On those 3 sheets the cell A1 contains the formula: =B5*C5

If I select sheet 1,2,3, cut cell C5 and past it say in E7, the content of the
cell does move in all three sheets from C5 to E7 and the formula in A1 becomes
=B5*E7 also in all three sheets and so I get the right result. This is the
expected behaviour and if you open a blank spreadsheet and try that simple case
it just works.

However in the attached spreadsheet (test_broken.ods), this does not work. If I
select the 4 Project sheets (Project 1 to 4) and cut for example the cell W13
anywhere, say in V88, the formula in cell N9 which references W13 only updates
in the Project 1 sheet but does not in the others.
Similarly if you insert a column / row on the four sheets simultaneous, formula
affected by the shift only update on one sheet and not on the others.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148449] Text style is locked into one definition that no editing can change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148449

stragu  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 Status|NEEDINFO|NEW

--- Comment #2 from stragu  ---
I have tested with the document supplied by Rory via private email and can
confirm that clearing the direct formatting of a specific paragraph (or
modifying the style) does not restore the font style or the font colour set up
in the style. For the paragraph in question, the font colour and the italics
are "sticky": they can only be changed by using the formatting toolbar.

Waiting for Rory to agree to share the document here for others to test.

Version: 7.2.6.2 / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103866

--- Comment #35 from sdc.bla...@youmail.dk ---
(In reply to Ben from comment #33)
> I do think this is a bug and not a formatting issue. 
You do not need to determine if it is a bug. But, as noted in comment 31, you
need to provide sufficient information. The evaluations here are based on the
concrete information, not on assertions or intuitions about bugs. Without that
information, it is impossible to evaluate the situation.

Cited from:  How to Report Bugs in LibreOffice
https://wiki.documentfoundation.org/QA/BugReport

All bug reports should have at minimum:
your Operating System and version of LibreOffice;
clear reproducible steps;
expected results;
observed results; and
a simple attachment where appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/workben

[Caolán McNamara (via logerrit)]

 vcl/workben/commonfuzzer.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 4659fc2f0a7223a89446edff0b77e58758b5edf5
Author: Caolán McNamara 
AuthorDate: Fri Apr 15 20:07:25 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sat Apr 16 00:14:25 2022 +0200

ofz#46632 Direct-leak

there is no DeinitVCL for fuzzing, so fill the fontoptions,etc cache
before starting

Change-Id: I14a30c3d38490d03c31b4c349674ba48dd32de15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133088
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/workben/commonfuzzer.hxx b/vcl/workben/commonfuzzer.hxx
index c9afd65552fe..e64a53dda644 100644
--- a/vcl/workben/commonfuzzer.hxx
+++ b/vcl/workben/commonfuzzer.hxx
@@ -129,6 +129,8 @@ void CommonInitialize(int *argc, char ***argv)
 psp::PrintFontManager::get();
 //get the printer info
 Printer::GetPrinterQueues();
+//Draw some text to fill CairoTextRender fontoptions cache
+Application::GetDefaultDevice()->DrawText(Point(0, 0), "hello world");
 
 //https://github.com/google/oss-fuzz/issues/1449
 //https://github.com/google/oss-fuzz/issues/5441

[Libreoffice-bugs] [Bug 148608] Slide has background with 'hairlines' in powerpoint but not in LibO (and get lost on round trip)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148608

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
   Severity|normal  |enhancement
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Regina Henschel  ---
That is the special fill "Slide background fill" of an object. The object is
not transparent but copies the underlying slide background. So it looks as if
the object makes a hole in the shapes between itself and the slide background.
It depends on the position of the shape, which part of the background of the
slide is shown.

It can neither be solved by setting the shape background the same as the slide
background nor by setting the shape background transparent.

LibreOffice is not able to render this special fill and it cannot be expressed
in current ODF. It is the attribute "useBgFill" in OOXML.

I'm quite sure there are already reports about this problem. It might be bug
128150 or bug 147852. It is a missing OOXML feature, so set to enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147732] font effect "small caps" does not work in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147732

--- Comment #10 from sdc.bla...@youmail.dk ---
(In reply to Xisco Faulí from comment #9)
> For me, 'Small capitals' is greyed out in the menu in Impress, so the option
> can't be used
Repro that Format > Text > Small capitals is greyed out.

@Xisco -- did you try:

1. Place cursor in text to be small cap'ed.
2. Right-click, choose Character
3. Choose "Font Effects" tab.
4. In "Case" dropdown box in Effects section, choose "Small capitals".

Does that not work for you?  (aside from the fact that it gives the result of
UPPERCASE letters, which is the OP).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148513] Poor nomenclature for Manual Break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148513

--- Comment #20 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #19)
> Keep localization in mind.
Proposal in comment 14 seems translation-friendly in terms of understanding
(i.e., familiar nouns and adjectives, simple prepositions, no special
grammatical demands).

> And the UI scales according to the largest content.
The Spanish translation might be pretty long.

In that connectionto gain some more room in the "to" field ...

Could the Vertical and Horizontal control widths be reduced?
At present, there is a least a cm of white space in the drop down menu.   

Also the "by" field could probably be reduced a little.

And there is already bug 148512 to address the "to" field.

(and ftr, such UI adjustments are beyond my possibilities. Presumably it is
preferred that these changes are achieved before July string freeze.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148513] Poor nomenclature for Manual Break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148513

--- Comment #20 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #19)
> Keep localization in mind.
Proposal in comment 14 seems translation-friendly in terms of understanding
(i.e., familiar nouns and adjectives, simple prepositions, no special
grammatical demands).

> And the UI scales according to the largest content.
The Spanish translation might be pretty long.

In that connectionto gain some more room in the "to" field ...

Could the Vertical and Horizontal control widths be reduced?
At present, there is a least a cm of white space in the drop down menu.   

Also the "by" field could probably be reduced a little.

And there is already bug 148512 to address the "to" field.

(and ftr, such UI adjustments are beyond my possibilities. Presumably it is
preferred that these changes are achieved before July string freeze.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148299] Master Document: File not found if filename/path has back to back spaces.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148299

--- Comment #2 from John  ---
Hi Dieter, appreciate you looking into this!

For context I was writing specifications, with file names following a standard
format "## ## ## - Title".  Occasionally I'd double-tap the space bar, or an
extra space would sneak in there while renaming.  

The extra space is nearly invisible, so it just appeared to me like the file
was randomly corrupted.  It wasn't until I was looking at the files in windows
explorer that my OCD compelled me to figure out why some of the file names
weren't kerning properly, that I found the root cause.  Multiple spaces in the
filename is not at all a requirement, just a nearly-invisible accident.

Long story short:  a more descriptive error would be a fine solution.

Cheers!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/writer_tests/tdf148551.py |   44 +
 1 file changed, 44 insertions(+)

New commits:
commit cb21bbc1210dc270a125613d571521701e379ff9
Author: Xisco Fauli 
AuthorDate: Fri Apr 15 18:27:41 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 23:22:01 2022 +0200

tdf#148551: sw: Add UItest

Change-Id: I118c0c91f0ba90f57761512e8e9984186ab4ac19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133080
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests/tdf148551.py 
b/sw/qa/uitest/writer_tests/tdf148551.py
new file mode 100644
index ..2d0de314b65a
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/tdf148551.py
@@ -0,0 +1,44 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, type_text
+from uitest.uihelper.common import select_pos
+
+class Tdf148551(UITestCase):
+
+def test_tdf148551(self):
+
+with self.ui_test.create_doc_in_start_center("writer") as document:
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+with 
self.ui_test.execute_modeless_dialog_through_command(".uno:InsertField", 
close_button="cancel") as xDialog:
+xTab = xDialog.getChild("tabcontrol")
+select_pos(xTab, "0")
+
+xDoc = xDialog.getChild("type-doc")
+xDoc.getChild('7').executeAction("SELECT", tuple())
+self.assertEqual("Statistics", 
get_state_as_dict(xDoc)['SelectEntryText'])
+
+xSelect = xDialog.getChild("select-doc")
+self.assertEqual("Pages", 
get_state_as_dict(xSelect)['SelectEntryText'])
+
+xFormat = xDialog.getChild("format-doc")
+self.assertEqual("As Page Style", 
get_state_as_dict(xFormat)['SelectEntryText'])
+
+xOk = xDialog.getChild("ok")
+xOk.executeAction("CLICK", tuple())
+
+# Without the fix in place, this test would have failed with
+# AssertionError: '1' != 'A'
+self.assertEqual("1", 
document.Text.createEnumeration().nextElement().String)
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-bugs] [Bug 148559] FILESAVE: RTF: Border lost after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148559

--- Comment #4 from Regina Henschel  ---
Created attachment 179599
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179599=edit
Reduced version of attachment 50625

I have reduced attachment 50625 to the affected object.

The patch will force the object to a default line. But I think, there is a
principle problem:

The object is not a text box (as I thought first) but it is a frame. When Word
exports docx to RFT, it sets the borders as paragraph borders. For such
RTF-document made by Word, LibreOffice renders the borders same as Word. LO
converts the paragraph group to a Frame.

But when LO converts the docx document to RTF it generates a shape and enables
default "stroke" of the shape. It does not consider border color and border
width. So there is a principle shortcoming in exporting such object from docx
to rtf.

Should we nevertheless use the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/writer_tests/tdf135377.py |   46 +
 1 file changed, 46 insertions(+)

New commits:
commit b4b3398736d42bf1e3de4b397510576fdc5c3338
Author: Xisco Fauli 
AuthorDate: Fri Apr 15 19:57:30 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 22:35:48 2022 +0200

tdf#135377: sw: Add UItest

Change-Id: I6e00601e1e8a6971e2668a744a3faac06344403f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133084
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests/tdf135377.py 
b/sw/qa/uitest/writer_tests/tdf135377.py
new file mode 100644
index ..b5751bedf8ab
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/tdf135377.py
@@ -0,0 +1,46 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+
+class Tdf135377(UITestCase):
+
+def test_tdf135377(self):
+
+with self.ui_test.create_doc_in_start_center("writer") as writer_doc:
+
+with 
self.ui_test.execute_modeless_dialog_through_command(".uno:InsertField", 
close_button="cancel") as xDialog:
+xTab = xDialog.getChild("tabcontrol")
+select_pos(xTab, "4")
+
+xType = xDialog.getChild("type-var")
+xType.getChild('8').executeAction("SELECT", tuple())
+self.assertEqual("User Field", 
get_state_as_dict(xType)['SelectEntryText'])
+
+xName = xDialog.getChild("name-var")
+xName.executeAction("TYPE", mkPropertyValues({"TEXT": "AA"}))
+
+xValue = xDialog.getChild("value-var")
+xValue.executeAction("TYPE", mkPropertyValues({"TEXT": "BB"}))
+
+xNumFormat = xDialog.getChild("numformat-var")
+
+# Without the fix in place, this test would have failed with
+# AssertionError: 'General' != ''
+self.assertEqual("General", 
get_state_as_dict(xNumFormat)['SelectEntryText'])
+
+xApplyBtn = xDialog.getChild("apply")
+xApplyBtn.executeAction("CLICK", ())
+
+self.assertEqual("AA", 
get_state_as_dict(xDialog.getChild("select-var"))["SelectEntryText"])
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-bugs] [Bug 123381] FILEOPEN DOCX INT table formula is not working in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123381

--- Comment #8 from Xisco Faulí  ---
Proposed patch in https://gerrit.libreoffice.org/c/core/+/133091

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148618] Font size in fields is incorrect depending on the zoom level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148618

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||l.lu...@collabora.com
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

author  Luboš Luňák  2022-04-07 12:06:27 +0200
committer   Luboš Luňák  2022-04-08 21:29:19
+0200
commit  3e5863605881c6de6ad130fe06883c176ca1c69f (patch)
tree9e7863107a162eba8952710af00c281b91a12633
parent  53fe4a26c7c4691fcf9d07d022adfd45247d176b (diff)
use just one shared global SalLayoutGlyphsCache

Bisected with: bibisect-linux64-7.4

Adding Cc: to Luboš Luňák

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148618] Font size in fields is incorrect depending on the zoom level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148618

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Created attachment 179598
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179598=edit
wrong vs right

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148618] New: Font size in fields is incorrect depending on the zoom level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148618

Bug ID: 148618
   Summary: Font size in fields is incorrect depending on the zoom
level
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 179597
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179597=edit
sample file

Steps to reproduce:
1. Open attached document
2. Zoom in and out

-> Font size is incorrect

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ab8d141967111ca81f4607db3618bb09214e42db
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

and GEN

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109169] [FILESAVE DOCX] Some shapes are not correctly preserved when saved as DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109169

--- Comment #10 from Regina Henschel  ---
This is a first step. Now the geometry is correct. Still missing are shading
and handle.

Shading cannot be exported identical to LO, because OOXML has only four grades
of shading, whereas shapes of type "col-..." can have up to 14 grades of
shading. But before finding a suitable emulation the rendering in LO needs to
be fixed, see bug 148501.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103866

--- Comment #34 from Ben  ---
Created attachment 179596
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179596=edit
Formula alignment in odt file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103866] Formula Vertical Alignment issue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103866

--- Comment #33 from Ben  ---
This issue can be further investigated by inspecting the attached .odt file.
After trying various changes once again, similar to what people have reported,
I do think this is a bug and not a formatting issue. Please check this in both
Windows and other environments. Unfortunately, this has literally taken me many
days of investigations on the Internet and trying all kinds of workarounds.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109169] [FILESAVE DOCX] Some shapes are not correctly preserved when saved as DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109169

--- Comment #9 from Commit Notification 
 ---
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b195cf4db4c21da3cf754689fb22f0b6a904a03e

tdf#109169 use custGeom for Octagon Bevel shape

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109169] [FILESAVE DOCX] Some shapes are not correctly preserved when saved as DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109169

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sd/qa

[Regina Henschel (via logerrit)]

 oox/source/export/shapes.cxx  |6 +--
 sd/qa/unit/data/odp/tdf109169_Diamond.odp |binary
 sd/qa/unit/data/odp/tdf109169_Octagon.odp |binary
 sd/qa/unit/export-tests-ooxml3.cxx|   46 ++
 4 files changed, 49 insertions(+), 3 deletions(-)

New commits:
commit b195cf4db4c21da3cf754689fb22f0b6a904a03e
Author: Regina Henschel 
AuthorDate: Fri Apr 15 15:04:16 2022 +0200
Commit: Regina Henschel 
CommitDate: Fri Apr 15 22:16:40 2022 +0200

tdf#109169 use custGeom for Octagon Bevel shape

The shapes 'Octagon Bevel', type col_60da8460, and 'Diamond Bevel',
type col-502ad400, are LO specific preset shapes. They have neither a
counterpart in MS binary nor in OOXML. So they need to be exported
with custGeom. To force custGeom these shape types are moved from
vDenylist to vAllowlist.
These shapes were exported as prst='rect' before.

Change-Id: I9619345812b6dba8f14ec2cc6a92ae808a56b595
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133069
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index e4d378bd6111..3308d5ab4492 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -551,8 +551,6 @@ static bool lcl_IsOnDenylist(OUString const & rShapeType)
 u"flower",
 u"bracket-pair",
 u"brace-pair",
-u"col-60da8460",
-u"col-502ad400",
 u"quad-bevel",
 u"round-rectangular-callout",
 u"rectangular-callout",
@@ -605,7 +603,9 @@ static bool lcl_IsOnAllowlist(OUString const & rShapeType)
 {
 static const std::initializer_list vAllowlist = {
 u"heart",
-u"puzzle"
+u"puzzle",
+u"col-60da8460",
+u"col-502ad400"
 };
 
 return std::find(vAllowlist.begin(), vAllowlist.end(), rShapeType) != 
vAllowlist.end();
diff --git a/sd/qa/unit/data/odp/tdf109169_Diamond.odp 
b/sd/qa/unit/data/odp/tdf109169_Diamond.odp
new file mode 100644
index ..cd6a18d1b318
Binary files /dev/null and b/sd/qa/unit/data/odp/tdf109169_Diamond.odp differ
diff --git a/sd/qa/unit/data/odp/tdf109169_Octagon.odp 
b/sd/qa/unit/data/odp/tdf109169_Octagon.odp
new file mode 100644
index ..f35e746f3b28
Binary files /dev/null and b/sd/qa/unit/data/odp/tdf109169_Octagon.odp differ
diff --git a/sd/qa/unit/export-tests-ooxml3.cxx 
b/sd/qa/unit/export-tests-ooxml3.cxx
index 3f4bec336ef1..23486c66f254 100644
--- a/sd/qa/unit/export-tests-ooxml3.cxx
+++ b/sd/qa/unit/export-tests-ooxml3.cxx
@@ -11,6 +11,7 @@
 #include 
 #include "sdmodeltestbase.hxx"
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -21,6 +22,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -107,6 +109,8 @@ public:
 void testTdf140912_PicturePlaceholder();
 void testEnhancedPathViewBox();
 void testTdf74670();
+void testTdf109169_OctagonBevel();
+void testTdf109169_DiamondBevel();
 
 CPPUNIT_TEST_SUITE(SdOOXMLExportTest3);
 
@@ -184,6 +188,8 @@ public:
 CPPUNIT_TEST(testTdf140912_PicturePlaceholder);
 CPPUNIT_TEST(testEnhancedPathViewBox);
 CPPUNIT_TEST(testTdf74670);
+CPPUNIT_TEST(testTdf109169_OctagonBevel);
+CPPUNIT_TEST(testTdf109169_DiamondBevel);
 CPPUNIT_TEST_SUITE_END();
 
 virtual void registerNamespaces(xmlXPathContextPtr& pXmlXPathCtx) override
@@ -1919,6 +1925,46 @@ void SdOOXMLExportTest3::testTdf74670()
 CPPUNIT_ASSERT_EQUAL(1, nImageFiles);
 }
 
+void SdOOXMLExportTest3::testTdf109169_OctagonBevel()
+{
+// The document has a shape 'Octagon Bevel'. It consists of an octagon 
with 8 points and eight
+// facets with 4 points each, total 8+8*4=40 points. Without the patch it 
was exported as
+// rectangle and thus had 4 points.
+::sd::DrawDocShellRef xDocShRef
+= 
loadURL(m_directories.getURLFromSrc(u"sd/qa/unit/data/odp/tdf109169_Octagon.odp"),
 ODP);
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX);
+
+auto xPropSet(getShapeFromPage(0, 0, xDocShRef));
+auto aGeomPropSeq = xPropSet->getPropertyValue("CustomShapeGeometry")
+.get>();
+comphelper::SequenceAsHashMap aCustomShapeGeometry(aGeomPropSeq);
+auto 
aPathSeq((aCustomShapeGeometry["Path"]).get>());
+comphelper::SequenceAsHashMap aPath(aPathSeq);
+auto aCoordinates(
+
(aPath["Coordinates"]).get>());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(40), aCoordinates.getLength());
+}
+
+void SdOOXMLExportTest3::testTdf109169_DiamondBevel()
+{
+// The document has a shape 'Diamond Bevel'. It consists of a diamond with 
4 points and four
+// facets with 4 points each, total 4+4*4=20 points. Without the patch it 
was exported as
+// rectangle and thus had 4 points.
+::sd::DrawDocShellRef xDocShRef
+= 
loadURL(m_directories.getURLFromSrc(u"sd/qa/unit/data/odp/tdf109169_Diamond.odp"),
 ODP);
+xDocShRef = 

[Libreoffice-bugs] [Bug 148274] AutoText from LO > 7.3 (or maybe > 7.0..?) incompatible with older versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148274

--- Comment #3 from Cor Nouws  ---
Hi Dieter,

(In reply to Dieter from comment #2)
> I'm not familiar with AutoText, so I couldn't reproduce it without more
> detailed steps,

- Text document with some content
- select
- Ctrl+F3 or Tools>AutoText (dialog AutoText)
- Chose  category to create a category - it will be stored in your user profile
under /user/autotext/
- Choose Autotext > New to create an AutoText, select your category and give a
name
- Close LO
- Copy the /bau to the user profile of an older LO version


> ...  but i would like to ask, why somebody should create AutoText
> in LO 7 and use it in LO 6? So where is the use case for the described
> problem in real life?

Not something you expect indeed. Unless you have a .bau that you share with
someone else who turns out to have that older version :)

HTH & thanks for looking at this,
Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148617] New: LO Calc - Grouped bar compact (GBC) - dropdown menu blocks menu next to it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148617

Bug ID: 148617
   Summary: LO Calc - Grouped bar compact (GBC) - dropdown menu
blocks menu next to it
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dajo...@gmail.com

Description:
in the GBC layout I hit the "Review" drop down menu, and the menu appearance
follows the mouse click location. This means that if I click on the click on
the top edge of this menu button, the menu goes over "view" so that I have to
click it away before I can choose "view". If I click on the lower edge of the
"review" button, the menu appears a bit lower down so that "view" button is
available. I think that the menu appearance should not follow the mouse and the
menu buttons should always be available.

Steps to Reproduce:
1.Use Grouped bar compact
2.Click on "review" menu
3.

Actual Results:
See description

Expected Results:
See description


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148301] Shortcuts Ctrl+> and Ctrl+< not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148301

jr...@hotmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from jr...@hotmail.com ---
Didn't work with and without profile reset. (Also customised Ctrl+Shift+[ to
check if it was something Ctrl+Shift related, but it worked normally)

Profile reset done as:
1. Start LibreOffice and select Help ▸ Restart in Safe Mode
2. Select Continue in Safe Mode (after restart is done and a modal dialog
appears)

[New version info]
OS: Fedora 35 (5.16.19-200.fc35.x86_64)
GNOME Shell 41.4
Windowing system: Wayland
Version: 7.3.2.2 / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: gtk3
Locale: pt-BR (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: jvmfwk/inc jvmfwk/plugins jvmfwk/source

[Noel Grandin (via logerrit)]

 jvmfwk/inc/fwkutil.hxx |2 +-
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx |6 +++---
 jvmfwk/plugins/sunmajor/pluginlib/util.hxx |2 +-
 jvmfwk/source/fwkutil.cxx  |6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 65e846d73c023cb8ed8a8393a91032d4a816f2a0
Author: Noel Grandin 
AuthorDate: Fri Apr 15 16:47:26 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Apr 15 21:33:17 2022 +0200

use more string_view in jvmfwk

Change-Id: I05f3b171578b8fef5b15dcbbf10ae9b7cf2d1b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133075
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/jvmfwk/inc/fwkutil.hxx b/jvmfwk/inc/fwkutil.hxx
index 825355f42a47..76d437ae76b9 100644
--- a/jvmfwk/inc/fwkutil.hxx
+++ b/jvmfwk/inc/fwkutil.hxx
@@ -46,7 +46,7 @@ osl::Mutex& FwkMutex();
 rtl::ByteSequence encodeBase16(const rtl::ByteSequence& rawData);
 rtl::ByteSequence decodeBase16(const rtl::ByteSequence& data);
 
-OUString getDirFromFile(const OUString& usFilePath);
+OUString getDirFromFile(std::u16string_view usFilePath);
 
 enum FileStatus
 {
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index f7d786007544..b596e18cf480 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -1023,10 +1023,10 @@ Reference 
createInstance(createInstance_func pFunc,
 return aBase;
 }
 
-inline OUString getDirFromFile(const OUString& usFilePath)
+inline OUString getDirFromFile(std::u16string_view usFilePath)
 {
-sal_Int32 index = usFilePath.lastIndexOf('/');
-return usFilePath.copy(0, index);
+size_t index = usFilePath.rfind('/');
+return OUString(usFilePath.substr(0, index));
 }
 
 void addJavaInfosFromPath(
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
index 78df074f9de3..9ba0055832ed 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.hxx
@@ -37,7 +37,7 @@ void addJREInfoFromBinPath(
 const OUString& path,
 std::vector> & allInfos,
 std::vector> & addedInfos);
-inline OUString getDirFromFile(const OUString& usFilePath);
+inline OUString getDirFromFile(std::u16string_view usFilePath);
 void addJavaInfosFromPath(
 std::vector> & allInfos,
 std::vector> & addedInfos);
diff --git a/jvmfwk/source/fwkutil.cxx b/jvmfwk/source/fwkutil.cxx
index ee083f064926..89cb2e5415cb 100644
--- a/jvmfwk/source/fwkutil.cxx
+++ b/jvmfwk/source/fwkutil.cxx
@@ -136,10 +136,10 @@ rtl::ByteSequence decodeBase16(const rtl::ByteSequence& 
data)
 return ret;
 }
 
-OUString getDirFromFile(const OUString& usFilePath)
+OUString getDirFromFile(std::u16string_view usFilePath)
 {
-sal_Int32 index = usFilePath.lastIndexOf('/');
-return usFilePath.copy(0, index);
+size_t index = usFilePath.rfind('/');
+return OUString(usFilePath.substr(0, index));
 }
 
 OUString getLibraryLocation()

[Libreoffice-commits] core.git: cui/source

[Noel Grandin (via logerrit)]

 cui/source/customize/cfgutil.cxx |   22 --
 cui/source/customize/macropg.cxx |   22 +++---
 cui/source/dialogs/scriptdlg.cxx |2 +-
 cui/source/inc/cfgutil.hxx   |2 +-
 4 files changed, 25 insertions(+), 23 deletions(-)

New commits:
commit 15d8762dd07289447e782a3812dfd4425fe9a82b
Author: Noel Grandin 
AuthorDate: Fri Apr 15 16:46:52 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Apr 15 21:32:59 2022 +0200

use more string_view in cui

Change-Id: I377d95ec2d80cef611c6fce274f1e17504132564
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133074
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index aab25aa9bb8d..6b39170e18f7 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -54,6 +54,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -1027,22 +1028,23 @@ void CuiConfigGroupListBox::SelectMacro( const 
SfxMacroInfoItem *pItem )
 }
 
 void CuiConfigGroupListBox::SelectMacro( std::u16string_view rBasic,
- const OUString& rMacro )
+ std::u16string_view rMacro )
 {
 const OUString aBasicName(OUString::Concat(rBasic) + " " + 
xImp->m_sMacros);
-sal_Int32 nIdx {rMacro.lastIndexOf('.')};
-const OUString aMethod( rMacro.copy(nIdx+1) );
-OUString aLib;
-OUString aModule;
-if ( nIdx>0 )
+size_t nIdx {rMacro.rfind('.')};
+const std::u16string_view aMethod( rMacro.substr(nIdx == 
std::u16string_view::npos ? 0 : nIdx + 1) );
+std::u16string_view aLib;
+std::u16string_view aModule;
+if ( nIdx>0 && nIdx != std::u16string_view::npos )
 {
 // string contains at least 2 tokens
-nIdx = rMacro.lastIndexOf('.', nIdx);
-if (nIdx>=0)
+nIdx = rMacro.rfind('.', nIdx);
+if (nIdx != std::u16string_view::npos)
 {
 // string contains at least 3 tokens
-aLib = rMacro.getToken( 0, '.' );
-aModule = rMacro.getToken( 0, '.', ++nIdx );
+aLib = o3tl::getToken(rMacro, 0, '.' );
+sal_Int32 nIdx2 = nIdx + 1;
+aModule = o3tl::getToken(rMacro, 0, '.', nIdx2 );
 }
 }
 
diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index b1df3957de8b..ed9e4f6c0c4d 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
@@ -269,21 +270,20 @@ bool SvxMacroTabPage_::IsReadOnly() const
 
 namespace
 {
-OUString GetEventDisplayText(const OUString )
+std::u16string_view GetEventDisplayText(std::u16string_view rURL)
 {
-if (rURL.isEmpty())
-return OUString();
-sal_Int32 nIndex = rURL.indexOf(aVndSunStarUNO);
-bool bUNO = nIndex == 0;
-OUString aPureMethod;
+if (rURL.empty())
+return std::u16string_view();
+bool bUNO = o3tl::starts_with(rURL, aVndSunStarUNO);
+std::u16string_view aPureMethod;
 if (bUNO)
 {
-aPureMethod = rURL.copy(aVndSunStarUNO.getLength());
+aPureMethod = rURL.substr(aVndSunStarUNO.getLength());
 }
 else
 {
-aPureMethod = rURL.copy(strlen("vnd.sun.star.script:"));
-aPureMethod = aPureMethod.copy( 0, aPureMethod.indexOf( '?' ) );
+aPureMethod = rURL.substr(strlen("vnd.sun.star.script:"));
+aPureMethod = aPureMethod.substr( 0, aPureMethod.find( '?' ) );
 }
 return aPureMethod;
 }
@@ -344,7 +344,7 @@ void SvxMacroTabPage_::DisplayAppEvents( bool appEvents)
 int nRow = mpImpl->xEventLB->n_children();
 mpImpl->xEventLB->append(sEventName, displayName);
 mpImpl->xEventLB->set_image(nRow, GetEventDisplayImage(eventURL), 1);
-mpImpl->xEventLB->set_text(nRow, GetEventDisplayText(eventURL), 2);
+mpImpl->xEventLB->set_text(nRow, 
OUString(GetEventDisplayText(eventURL)), 2);
 }
 
 mpImpl->xEventLB->thaw();
@@ -478,7 +478,7 @@ void 
SvxMacroTabPage_::GenericHandler_Impl(SvxMacroTabPage_* pThis, const weld::
 }
 
 rListBox.set_image(nEntry, GetEventDisplayImage(sEventURL), 1);
-rListBox.set_text(nEntry, GetEventDisplayText(sEventURL), 2);
+rListBox.set_text(nEntry, OUString(GetEventDisplayText(sEventURL)), 2);
 
 rListBox.select(nEntry );
 rListBox.scroll_to_row(nEntry);
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 4294e56ebac0..0c349367b44d 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -1113,7 +1113,7 @@ OUString FormatErrorString(
 std::u16string_view type,
 std::u16string_view message )
 {
-OUString result = unformatted.copy( 0 );
+OUString result = unformatted;
 

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/data/tdf143483.odt|binary
 sw/qa/uitest/writer_tests/tdf143483.py |   57 +
 2 files changed, 57 insertions(+)

New commits:
commit 267a0e94920dbaf3f9db316c9cbfe6fa72be8818
Author: Xisco Fauli 
AuthorDate: Fri Apr 15 19:09:56 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 21:22:44 2022 +0200

tdf#143483: sw: Add UItest

Change-Id: I10d05ea3f2866523e5adaac9ba768073b03c15a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133081
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/data/tdf143483.odt b/sw/qa/uitest/data/tdf143483.odt
new file mode 100644
index ..0b80ab196d57
Binary files /dev/null and b/sw/qa/uitest/data/tdf143483.odt differ
diff --git a/sw/qa/uitest/writer_tests/tdf143483.py 
b/sw/qa/uitest/writer_tests/tdf143483.py
new file mode 100644
index ..346fe60743db
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/tdf143483.py
@@ -0,0 +1,57 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+
+class Tdf143483(UITestCase):
+
+def test_tdf143483(self):
+
+with self.ui_test.load_file(get_url_for_data_file("tdf143483.odt")) as 
document:
+
+self.xUITest.executeCommand(".uno:JumpToNextBookmark")
+
+with 
self.ui_test.execute_dialog_through_command(".uno:FieldDialog") as xDialog:
+
+xDoc = xDialog.getChild("type-doc")
+self.assertEqual("Chapter", 
get_state_as_dict(xDoc)['SelectEntryText'])
+
+xFormat = xDialog.getChild("format-doc")
+self.assertEqual("Chapter name", 
get_state_as_dict(xFormat)['SelectEntryText'])
+
+xNext = xDialog.getChild("next")
+xNext.executeAction("CLICK", tuple())
+
+self.assertEqual("Chapter", 
get_state_as_dict(xDoc)['SelectEntryText'])
+self.assertEqual("Chapter number", 
get_state_as_dict(xFormat)['SelectEntryText'])
+
+xNext.executeAction("CLICK", tuple())
+
+self.assertEqual("Chapter", 
get_state_as_dict(xDoc)['SelectEntryText'])
+self.assertEqual("Chapter number and name", 
get_state_as_dict(xFormat)['SelectEntryText'])
+
+xNext.executeAction("CLICK", tuple())
+
+self.assertEqual("Chapter", 
get_state_as_dict(xDoc)['SelectEntryText'])
+self.assertEqual("Chapter number without separator", 
get_state_as_dict(xFormat)['SelectEntryText'])
+
+xEnumeration = document.Text.createEnumeration()
+self.assertEqual("Another title", 
xEnumeration.nextElement().String)
+self.assertEqual("", xEnumeration.nextElement().String)
+self.assertEqual("1. Another title", 
xEnumeration.nextElement().String)
+
+# Without the fix in place, this test would have failed with
+# AssertionError: '2. Chapter 1 -' != '2. Another title'
+self.assertEqual("2. Chapter 1 -", 
xEnumeration.nextElement().String)
+self.assertEqual("3. Chapter 1 - Another title", 
xEnumeration.nextElement().String)
+self.assertEqual("4. 1", xEnumeration.nextElement().String)
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/includeform.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 4cc5ceb9e3349fccc8ba08fdacb444ae70c597eb
Author: Stephan Bergmann 
AuthorDate: Fri Apr 15 20:10:37 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 15 21:05:03 2022 +0200

Adapt to clang::PPCallbacks::InclusionDirective change in Clang 15 trunk



"[clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()"

Change-Id: Ib2ea325cca3be03d3b5dfb9dfc3d870be659b129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/includeform.cxx 
b/compilerplugins/clang/includeform.cxx
index d9e603351783..7b2c0feb07ea 100644
--- a/compilerplugins/clang/includeform.cxx
+++ b/compilerplugins/clang/includeform.cxx
@@ -28,13 +28,18 @@ private:
 
 void InclusionDirective(
 SourceLocation HashLoc, Token const & IncludeTok, StringRef,
-bool IsAngled, CharSourceRange FilenameRange, FileEntry const * File,
+bool IsAngled, CharSourceRange FilenameRange,
+#if CLANG_VERSION >= 15
+Optional File,
+#else
+FileEntry const * File,
+#endif
 StringRef SearchPath, StringRef, clang::Module const *, 
SrcMgr::CharacteristicKind) override
 {
 if (ignoreLocation(HashLoc)) {
 return;
 }
-if (File == nullptr) { // in case of "fatal error: '...' file not 
found"
+if (!File) { // in case of "fatal error: '...' file not found"
 return;
 }
 if (IncludeTok.getIdentifierInfo()->getPPKeywordID() != 
tok::pp_include)

[Libreoffice-bugs] [Bug 108743] [META] Find toolbar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108743
Bug 108743 depends on bug 148349, which changed state.

Bug 148349 Summary: Use attention-attracting cue when pressing Ctrl+F while in 
the find bar
https://bugs.documentfoundation.org/show_bug.cgi?id=148349

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144072] LibreofficeBase crashed when 2 fields selected in report builder from different sections and width is adjusted 2nd time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144072

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #17 from Aron Budea  ---
I'm able to reproduce it in LO 7.4.0.0.alpha0+
(ab612633003c75dfb30664db8cc8924c086a91ee) / Ubuntu.

I have to say, the UX of resizing those widgets is terrible, you try to drag
from the right edge, and it resizes from the left, or from the corner. That's
one of the reasons why the crash is hard to reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl svx/source vcl/inc vcl/source vcl/unx

[Caolán McNamara (via logerrit)]

 include/vcl/weld.hxx   |3 
 svx/source/tbxctrls/tbunosearchcontrollers.cxx |   29 ---
 vcl/inc/salvtables.hxx |7 +
 vcl/source/app/salvtables.cxx  |   81 ++
 vcl/unx/gtk3/gtkinst.cxx   |   92 +
 5 files changed, 201 insertions(+), 11 deletions(-)

New commits:
commit d1da1c59d196b7f6037b7e0820b81fc527d56a4c
Author: Caolán McNamara 
AuthorDate: Thu Apr 14 20:13:17 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 15 20:44:49 2022 +0200

tdf#148349 add a way to call the user's attention to a widget

Change-Id: I2846155a44f3e51ddd8cc1acd81e84a38b4d3934
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133030
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index bdef5b22b9ca..226e2cb6c21a 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -320,6 +320,9 @@ public:
 
 virtual VclPtr create_virtual_device() const = 0;
 
+//do something transient to attract the attention of the user to the widget
+virtual void call_attention_to() = 0;
+
 //make this widget look like a page in a notebook
 virtual void set_stack_background() = 0;
 //make this widget look like it has a highlighted background
diff --git a/svx/source/tbxctrls/tbunosearchcontrollers.cxx 
b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
index 6deb930c18f2..b168462baf2d 100644
--- a/svx/source/tbxctrls/tbunosearchcontrollers.cxx
+++ b/svx/source/tbxctrls/tbunosearchcontrollers.cxx
@@ -295,22 +295,29 @@ IMPL_LINK(FindTextFieldControl, KeyInputHdl, const 
KeyEvent&, rKeyEvent, bool)
 }
 }
 }
-// Select text in the search box when Ctrl-F pressed
-else if ( bMod1 && nCode == KEY_F )
-m_xWidget->select_entry_region(0, -1);
-
-// Execute the search when Ctrl-G, F3 and Shift-RETURN pressed (in 
addition to ActivateHdl condition which handles bare RETURN)
-else if ( (bMod1 && KEY_G == nCode) || (bShift && KEY_RETURN == nCode) || 
(KEY_F3 == nCode) )
-{
-ActivateFind(bShift);
-bRet = true;
-}
 else
 {
 auto awtKey = 
svt::AcceleratorExecute::st_VCLKey2AWTKey(rKeyEvent.GetKeyCode());
 const OUString aCommand(m_pAcc->findCommand(awtKey));
-if (aCommand == ".uno:SearchDialog")
+
+// Select text in the search box when Ctrl-F pressed
+if ( bMod1 && nCode == KEY_F )
+m_xWidget->select_entry_region(0, -1);
+// Execute the search when Ctrl-G, F3 and Shift-RETURN pressed (in 
addition to ActivateHdl condition which handles bare RETURN)
+else if ( (bMod1 && KEY_G == nCode) || (bShift && KEY_RETURN == nCode) 
|| (KEY_F3 == nCode) )
+{
+ActivateFind(bShift);
+bRet = true;
+}
+else if (aCommand == ".uno:SearchDialog")
 bRet = m_pAcc->execute(awtKey);
+
+// find-shortcut called with focus already in find
+if (aCommand == "vnd.sun.star.findbar:FocusToFindbar")
+{
+m_xWidget->call_attention_to();
+bRet = true;
+}
 }
 
 return bRet || ChildKeyInput(rKeyEvent);
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index 5f8ceb6b9ae3..3f574237444b 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -167,10 +167,13 @@ public:
 virtual ~SalInstanceMenu() override;
 };
 
+class SalFlashAttention;
+
 class SalInstanceWidget : public virtual weld::Widget
 {
 protected:
 VclPtr m_xWidget;
+std::unique_ptr m_xFlashAttention;
 SalInstanceBuilder* m_pBuilder;
 
 private:
@@ -367,6 +370,8 @@ public:
 
 virtual void get_property_tree(tools::JsonWriter& rJsonWriter) override;
 
+virtual void call_attention_to() override;
+
 virtual void set_stack_background() override;
 
 virtual void set_title_background() override;
@@ -1000,6 +1005,8 @@ public:
 
 virtual void HandleEventListener(VclWindowEvent& rEvent) override;
 
+virtual void call_attention_to() override;
+
 virtual ~SalInstanceComboBoxWithEdit() override;
 };
 
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 263c29ff5eea..a8fdaf2a7978 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -559,6 +559,79 @@ VclPtr 
SalInstanceWidget::create_virtual_device() const
  DeviceFormat::DEFAULT);
 }
 
+class SalFlashAttention
+{
+private:
+VclPtr m_xWidget;
+Timer m_aFlashTimer;
+Color m_aOrigControlBackground;
+Wallpaper m_aOrigBackground;
+bool m_bOrigControlBackground;
+int m_nFlashCount;
+
+void SetFlash()
+{
+Color 
aColor(Application::GetSettings().GetStyleSettings().GetHighlightColor());
+m_xWidget->SetControlBackground(aColor);
+}
+
+void ClearFlash()
+{
+if 

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit fbfda267e8f4b55dff30a3827bff760565f36fdb
Author: Caolán McNamara 
AuthorDate: Fri Apr 15 17:19:05 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 15 20:43:47 2022 +0200

gtk[3|4] add the css "warning" "error" to GtkEntry when those states fit

Change-Id: I4063155d25b80f6b5912f0b63dc3c8fa21c7263b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133079
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 53f9e3bb644f..50e3b7949877 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -12586,30 +12586,42 @@ public:
 
 namespace
 {
-#if GTK_CHECK_VERSION(4, 0, 0)
 // CSS nodes: entry[.flat][.warning][.error]
 void set_widget_css_message_type(GtkWidget* pWidget, 
weld::EntryMessageType eType)
 {
+#if GTK_CHECK_VERSION(4, 0, 0)
+gtk_widget_remove_css_class(pWidget, "error");
+gtk_widget_remove_css_class(pWidget, "warning");
+#else
+GtkStyleContext *pWidgetContext = 
gtk_widget_get_style_context(pWidget);
+gtk_style_context_remove_class(pWidgetContext, "error");
+gtk_style_context_remove_class(pWidgetContext, "warning");
+#endif
+
 switch (eType)
 {
 case weld::EntryMessageType::Normal:
-gtk_widget_remove_css_class(pWidget, "error");
-gtk_widget_remove_css_class(pWidget, "warning");
 break;
 case weld::EntryMessageType::Warning:
-gtk_widget_remove_css_class(pWidget, "error");
+#if GTK_CHECK_VERSION(4, 0, 0)
 gtk_widget_add_css_class(pWidget, "warning");
+#else
+gtk_style_context_add_class(pWidgetContext, "warning");
+#endif
 break;
 case weld::EntryMessageType::Error:
-gtk_widget_remove_css_class(pWidget, "warning");
+#if GTK_CHECK_VERSION(4, 0, 0)
 gtk_widget_add_css_class(pWidget, "error");
+#else
+gtk_style_context_add_class(pWidgetContext, "error");
+#endif
 break;
 }
 }
-#endif
 
 void set_entry_message_type(GtkEntry* pEntry, weld::EntryMessageType eType)
 {
+set_widget_css_message_type(GTK_WIDGET(pEntry), eType);
 switch (eType)
 {
 case weld::EntryMessageType::Normal:

[Libreoffice-bugs] [Bug 147237] Dynamic theme gtk switching only partially switches colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147237

--- Comment #12 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/37fb1cbf7bceac8421741dc55b89146a42a77a22

Related: tdf#147237 change the SalObject background when the settings change

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147237] Dynamic theme gtk switching only partially switches colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147237

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 211fb753067f315597ac79f13c1bc553407fbf2f
Author: Caolán McNamara 
AuthorDate: Fri Apr 15 17:02:09 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 15 20:43:31 2022 +0200

gtk4: warning and error are explicitly mentioned in the documentation

Change-Id: If61b40e6d104ba54e71c4473bf1214a6df999089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 42e5b6971b8c..53f9e3bb644f 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -12587,7 +12587,7 @@ public:
 namespace
 {
 #if GTK_CHECK_VERSION(4, 0, 0)
-// speculative, "error" seems to be a thing but "warning" probably isn't
+// CSS nodes: entry[.flat][.warning][.error]
 void set_widget_css_message_type(GtkWidget* pWidget, 
weld::EntryMessageType eType)
 {
 switch (eType)

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/inc/unx/gtk/gtkobject.hxx |7 +
 vcl/unx/gtk3/gtkobject.cxx|   53 ++
 2 files changed, 46 insertions(+), 14 deletions(-)

New commits:
commit 37fb1cbf7bceac8421741dc55b89146a42a77a22
Author: Caolán McNamara 
AuthorDate: Fri Apr 15 16:27:37 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 15 20:43:16 2022 +0200

Related: tdf#147237 change the SalObject background when the settings change

which solves the problem of parts of the gtk ui remaining in the old
theme when switching dark<->light

Change-Id: I59060dfdf3937ca13cd706eefc9e67c133478992
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133076
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkobject.hxx b/vcl/inc/unx/gtk/gtkobject.hxx
index 113868a4616c..b43f09e0bd30 100644
--- a/vcl/inc/unx/gtk/gtkobject.hxx
+++ b/vcl/inc/unx/gtk/gtkobject.hxx
@@ -82,6 +82,8 @@ class GtkSalObjectWidgetClip final : public GtkSalObjectBase
 tools::Rectangle m_aRect;
 tools::Rectangle m_aClipRect;
 GtkWidget* m_pScrolledWindow;
+GtkWidget* m_pViewPort;
+GtkCssProvider* m_pBgCssProvider;
 
 // signals
 #if !GTK_CHECK_VERSION(4, 0, 0)
@@ -98,6 +100,11 @@ class GtkSalObjectWidgetClip final : public GtkSalObjectBase
 #endif
 
 void ApplyClipRegion();
+
+void SetViewPortBackground();
+
+DECL_LINK(SettingsChangedHdl, VclWindowEvent&, void);
+
 public:
 GtkSalObjectWidgetClip(GtkSalFrame* pParent, bool bShow);
 virtual ~GtkSalObjectWidgetClip() override;
diff --git a/vcl/unx/gtk3/gtkobject.cxx b/vcl/unx/gtk3/gtkobject.cxx
index e5adb887cbeb..ca01e7795ab4 100644
--- a/vcl/unx/gtk3/gtkobject.cxx
+++ b/vcl/unx/gtk3/gtkobject.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 
 GtkSalObjectBase::GtkSalObjectBase(GtkSalFrame* pParent)
 : m_pSocket(nullptr)
@@ -296,6 +297,8 @@ void GtkSalObjectBase::SetForwardKey( bool bEnable )
 GtkSalObjectWidgetClip::GtkSalObjectWidgetClip(GtkSalFrame* pParent, bool 
bShow)
 : GtkSalObjectBase(pParent)
 , m_pScrolledWindow(nullptr)
+, m_pViewPort(nullptr)
+, m_pBgCssProvider(nullptr)
 {
 if( !pParent )
 return;
@@ -318,31 +321,26 @@ 
GtkSalObjectWidgetClip::GtkSalObjectWidgetClip(GtkSalFrame* pParent, bool bShow)
0, 0 );
 
 // deliberately without adjustments to avoid gtk's auto adjustment on 
changing focus
-GtkWidget* pViewPort = gtk_viewport_new(nullptr, nullptr);
+m_pViewPort = gtk_viewport_new(nullptr, nullptr);
 
 // force in a fake background of a suitable color
-GtkStyleContext *pWidgetContext = gtk_widget_get_style_context(pViewPort);
-GtkCssProvider* pBgCssProvider = gtk_css_provider_new();
-OUString sColor = 
Application::GetSettings().GetStyleSettings().GetDialogColor().AsRGBHexString();
-OUString aBuffer = "* { background-color: #" + sColor + "; }";
-OString aResult = OUStringToOString(aBuffer, RTL_TEXTENCODING_UTF8);
-css_provider_load_from_data(pBgCssProvider, aResult.getStr(), 
aResult.getLength());
-gtk_style_context_add_provider(pWidgetContext, 
GTK_STYLE_PROVIDER(pBgCssProvider),
-   GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+SetViewPortBackground();
+
+ImplGetDefaultWindow()->AddEventListener(LINK(this, 
GtkSalObjectWidgetClip, SettingsChangedHdl));
 
 #if !GTK_CHECK_VERSION(4, 0, 0)
-gtk_container_add(GTK_CONTAINER(m_pScrolledWindow), pViewPort);
+gtk_container_add(GTK_CONTAINER(m_pScrolledWindow), m_pViewPort);
 #else
-gtk_scrolled_window_set_child(GTK_SCROLLED_WINDOW(m_pScrolledWindow), 
pViewPort);
+gtk_scrolled_window_set_child(GTK_SCROLLED_WINDOW(m_pScrolledWindow), 
m_pViewPort);
 #endif
-gtk_widget_show(pViewPort);
+gtk_widget_show(m_pViewPort);
 
 // our plug window
 m_pSocket = gtk_grid_new();
 #if !GTK_CHECK_VERSION(4, 0, 0)
-gtk_container_add(GTK_CONTAINER(pViewPort), m_pSocket);
+gtk_container_add(GTK_CONTAINER(m_pViewPort), m_pSocket);
 #else
-gtk_viewport_set_child(GTK_VIEWPORT(pViewPort), m_pSocket);
+gtk_viewport_set_child(GTK_VIEWPORT(m_pViewPort), m_pSocket);
 #endif
 gtk_widget_show(m_pSocket);
 
@@ -353,8 +351,35 @@ 
GtkSalObjectWidgetClip::GtkSalObjectWidgetClip(GtkSalFrame* pParent, bool bShow)
 g_signal_connect( G_OBJECT(m_pSocket), "destroy", 
G_CALLBACK(signalDestroy), this );
 }
 
+// force in a fake background of a suitable color
+void GtkSalObjectWidgetClip::SetViewPortBackground()
+{
+GtkStyleContext *pWidgetContext = 
gtk_widget_get_style_context(m_pViewPort);
+if (m_pBgCssProvider)
+gtk_style_context_remove_provider(pWidgetContext, 
GTK_STYLE_PROVIDER(m_pBgCssProvider));
+m_pBgCssProvider = gtk_css_provider_new();
+OUString sColor = 
Application::GetSettings().GetStyleSettings().GetDialogColor().AsRGBHexString();
+OUString aBuffer = "* { background-color: #" + sColor + "; 

[Libreoffice-bugs] [Bug 148616] FILEOPEN PPTX A certain POTX template is slow to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148616

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Severity|normal  |minor
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148616] FILEOPEN PPTX A certain POTX template is slow to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148616

--- Comment #1 from Buovjaga  ---
Created attachment 179595
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179595=edit
Perf flamegraph

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148616] New: FILEOPEN PPTX A certain POTX template is slow to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148616

Bug ID: 148616
   Summary: FILEOPEN PPTX A certain POTX template is slow to open
   Product: LibreOffice
   Version: 6.3.0.4 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: haveBacktrace, perf
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ilmari.lauhakan...@libreoffice.org
Blocks: 108226

Created attachment 179594
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179594=edit
Slow template

Originally reported by Dedoimedo:
https://www.dedoimedo.com/computers/libreoffice-7-2-review.html

Template from MS
https://templates.office.com/en-US/Organic-presentation-TM78453729

Takes about 25 secs to open.

Oldest tested version 6.3.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b2b821715a3745718a941fa99dda92137c0f0c86
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Buovjaga  changed:

   What|Removed |Added

 Depends on||148616


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148616
[Bug 148616] FILEOPEN PPTX A certain POTX template is slow to open
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: i18npool/qa

[Rene Engelhard (via logerrit)]

 i18npool/qa/cppunit/test_breakiterator.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 67c577c692faaa0382d26c3c3f47b5ffa9deaa77
Author: Rene Engelhard 
AuthorDate: Fri Apr 15 08:38:52 2022 +0200
Commit: Eike Rathke 
CommitDate: Fri Apr 15 20:23:13 2022 +0200

apply ICU test workaround to < 70 to "fix" test with ICU 71

See also 263961306ede0656ebb7904034a2172615ce81d0

Change-Id: Ib64ec43dba59ffddb34fe7f1a0f0d2e589c3455c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133063
Tested-by: René Engelhard 
Reviewed-by: Eike Rathke 

diff --git a/i18npool/qa/cppunit/test_breakiterator.cxx 
b/i18npool/qa/cppunit/test_breakiterator.cxx
index b74ff4222be4..cdcbff9be535 100644
--- a/i18npool/qa/cppunit/test_breakiterator.cxx
+++ b/i18npool/qa/cppunit/test_breakiterator.cxx
@@ -856,11 +856,11 @@ void TestBreakIterator::testLao()
 i18n::WordType::DICTIONARY_WORD, true);
 
 CPPUNIT_ASSERT_EQUAL(sal_Int32(5), aBounds.startPos);
-#if (U_ICU_VERSION_MAJOR_NUM != 70)
+#if (U_ICU_VERSION_MAJOR_NUM < 70)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(9), aBounds.endPos);
 #else
 // FIXME:
-// In ICU 70 for yet unknown reason the word boundary 9 is not detected and
+// In ICU 70/71 for yet unknown reason the word boundary 9 is not detected 
and
 // instead the length 12 is returned as endpos.
 // Deep in
 // icu_70::RuleBasedBreakIterator::BreakCache::next()

[Libreoffice-commits] core.git: connectivity/source

[Noel Grandin (via logerrit)]

 connectivity/source/drivers/hsqldb/HStorageMap.cxx |4 ++--
 connectivity/source/drivers/mysql_jdbc/YDriver.cxx |6 +++---
 connectivity/source/inc/hsqldb/HStorageMap.hxx |2 +-
 connectivity/source/inc/mysql/YDriver.hxx  |2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit f9a15395dc1d71a9597296e0e29e266cf9441a7e
Author: Noel Grandin 
AuthorDate: Fri Apr 15 16:45:39 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Apr 15 20:12:11 2022 +0200

use more string_view in connectivity

Change-Id: I916db7599e600ba795e02b7afd29b54d1dc7187e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133073
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/connectivity/source/drivers/hsqldb/HStorageMap.cxx 
b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
index 63b5e0481c5c..aba88f192801 100644
--- a/connectivity/source/drivers/hsqldb/HStorageMap.cxx
+++ b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
@@ -132,9 +132,9 @@ namespace connectivity::hsqldb
 return OUString::number(s_nCount++);
 }
 
-OUString StorageContainer::removeURLPrefix(const OUString& _sURL,const 
OUString& _sFileURL)
+OUString StorageContainer::removeURLPrefix(std::u16string_view 
_sURL,const OUString& _sFileURL)
 {
-return _sURL.copy(_sFileURL.getLength()+1);
+return OUString(_sURL.substr(_sFileURL.getLength()+1));
 }
 
 OUString StorageContainer::removeOldURLPrefix(const OUString& _sURL)
diff --git a/connectivity/source/drivers/mysql_jdbc/YDriver.cxx 
b/connectivity/source/drivers/mysql_jdbc/YDriver.cxx
index 7ee501d42e81..69d2386990ae 100644
--- a/connectivity/source/drivers/mysql_jdbc/YDriver.cxx
+++ b/connectivity/source/drivers/mysql_jdbc/YDriver.cxx
@@ -115,9 +115,9 @@ T_DRIVERTYPE lcl_getDriverType(std::u16string_view _sUrl)
 return eRet;
 }
 
-OUString transformUrl(const OUString& _sUrl)
+OUString transformUrl(std::u16string_view _sUrl)
 {
-OUString sNewUrl = _sUrl.copy(11);
+OUString sNewUrl(_sUrl.substr(11));
 if (isOdbcUrl(_sUrl))
 sNewUrl = "sdbc:" + sNewUrl;
 else if (isNativeUrl(_sUrl))
@@ -187,7 +187,7 @@ Sequence lcl_convertProperties(T_DRIVERTYPE 
_eType,
 }
 }
 
-Reference ODriverDelegator::loadDriver(const OUString& url,
+Reference ODriverDelegator::loadDriver(std::u16string_view url,
 const Sequence& 
info)
 {
 Reference xDriver;
diff --git a/connectivity/source/inc/hsqldb/HStorageMap.hxx 
b/connectivity/source/inc/hsqldb/HStorageMap.hxx
index ee4590864016..06f31e6df326 100644
--- a/connectivity/source/inc/hsqldb/HStorageMap.hxx
+++ b/connectivity/source/inc/hsqldb/HStorageMap.hxx
@@ -86,7 +86,7 @@ namespace connectivity::hsqldb
 static TStreamMap::mapped_type getRegisteredStream( JNIEnv * env, 
jstring name, jstring key);
 
 static OUString jstring2ustring(JNIEnv * env, jstring jstr);
-static OUString removeURLPrefix(const OUString& _sURL,const 
OUString& _sFileURL);
+static OUString removeURLPrefix(std::u16string_view _sURL,const 
OUString& _sFileURL);
 static OUString removeOldURLPrefix(const OUString& _sURL);
 static void throwJavaException(const css::uno::Exception& 
_aException,JNIEnv * env);
 };
diff --git a/connectivity/source/inc/mysql/YDriver.hxx 
b/connectivity/source/inc/mysql/YDriver.hxx
index 7bdb499718fd..84fad1af1c99 100644
--- a/connectivity/source/inc/mysql/YDriver.hxx
+++ b/connectivity/source/inc/mysql/YDriver.hxx
@@ -72,7 +72,7 @@ namespace connectivity
 @return
 The driver which was currently selected.
 */
-css::uno::Reference< css::sdbc::XDriver > loadDriver( const 
OUString& url, const css::uno::Sequence< css::beans::PropertyValue >& info );
+css::uno::Reference< css::sdbc::XDriver > loadDriver( 
std::u16string_view url, const css::uno::Sequence< css::beans::PropertyValue >& 
info );
 
 public:
 /** creates a new delegator for a mysql driver

[Libreoffice-commits] core.git: xmlhelp/source xmlsecurity/inc xmlsecurity/source

[Noel Grandin (via logerrit)]

 xmlhelp/source/cxxhelp/provider/databases.cxx  |   47 -
 xmlhelp/source/cxxhelp/provider/databases.hxx  |8 +-
 xmlsecurity/inc/documentsignaturemanager.hxx   |2 
 xmlsecurity/source/helper/documentsignaturemanager.cxx |   11 ++-
 4 files changed, 35 insertions(+), 33 deletions(-)

New commits:
commit 558aaa9ed222e7142fe87c9bab9a8293a5e2a159
Author: Noel Grandin 
AuthorDate: Fri Apr 15 16:43:40 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Apr 15 20:11:48 2022 +0200

use more string_view in xml*

Change-Id: Ie219cb3feb98660463858d00f82f882881946ad0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133072
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmlhelp/source/cxxhelp/provider/databases.cxx 
b/xmlhelp/source/cxxhelp/provider/databases.cxx
index 48e6788b0639..7d70fde659ce 100644
--- a/xmlhelp/source/cxxhelp/provider/databases.cxx
+++ b/xmlhelp/source/cxxhelp/provider/databases.cxx
@@ -567,35 +567,36 @@ namespace chelp {
 KeywordInfo::KeywordElement::KeywordElement( Databases const *pDatabases,
  helpdatafileproxy::Hdf* pHdf,
  OUString const & ky,
- OUString const & data )
+ std::u16string_view data )
 : key( ky )
 {
 pDatabases->replaceName( key );
 init( pDatabases,pHdf,data );
 }
 
-void KeywordInfo::KeywordElement::init( Databases const 
*pDatabases,helpdatafileproxy::Hdf* pHdf,const OUString& ids )
+void KeywordInfo::KeywordElement::init( Databases const 
*pDatabases,helpdatafileproxy::Hdf* pHdf, std::u16string_view ids )
 {
 std::vector< OUString > id,anchor;
-int idx = -1,k;
+size_t idx = std::u16string_view::npos;
+size_t k = 0;
 for (;;)
 {
-k = ++idx;
-idx = ids.indexOf( ';', k );
-if( idx == -1 )
+idx = ids.find( ';', k );
+if( idx == std::u16string_view::npos )
 break;
-int h = ids.indexOf( '#', k );
-if( h < idx )
+size_t h = ids.find( '#', k );
+if( h == std::u16string_view::npos || h < idx )
 {
 // found an anchor
-id.push_back( ids.copy( k, h-k ) );
-anchor.push_back( ids.copy( h+1, idx-h-1 ) );
+id.push_back( OUString(ids.substr( k, h-k )) );
+anchor.push_back( OUString(ids.substr( h+1, idx-h-1 )) );
 }
 else
 {
-id.push_back( ids.copy( k, idx-k ) );
+id.push_back( OUString(ids.substr( k, idx-k )) );
 anchor.emplace_back( );
 }
+k = ++idx;
 }
 
 listId.realloc( id.size() );
@@ -775,10 +776,10 @@ KeywordInfo* Databases::getKeyword( const OUString& 
Database,
 return it->second.get();
 }
 
-Reference< XHierarchicalNameAccess > Databases::jarFile( const OUString& jar,
+Reference< XHierarchicalNameAccess > Databases::jarFile( std::u16string_view 
jar,
  const OUString& 
Language )
 {
-if( jar.isEmpty() || Language.isEmpty() )
+if( jar.empty() || Language.isEmpty() )
 {
 return Reference< XHierarchicalNameAccess >( nullptr );
 }
@@ -795,14 +796,14 @@ Reference< XHierarchicalNameAccess > Databases::jarFile( 
const OUString& jar,
 {
 OUString zipFile;
 // Extension jar file? Search for ?
-sal_Int32 nQuestionMark1 = jar.indexOf( '?' );
-sal_Int32 nQuestionMark2 = jar.lastIndexOf( '?' );
-if( nQuestionMark1 != -1 && nQuestionMark2 != -1 && nQuestionMark1 
!= nQuestionMark2 )
+size_t nQuestionMark1 = jar.find( '?' );
+size_t nQuestionMark2 = jar.rfind( '?' );
+if( nQuestionMark1 != std::u16string_view::npos && nQuestionMark2 
!= std::u16string_view::npos && nQuestionMark1 != nQuestionMark2 )
 {
-OUString aExtensionPath = jar.copy( nQuestionMark1 + 1, 
nQuestionMark2 - nQuestionMark1 - 1 );
-OUString aPureJar = jar.copy( nQuestionMark2 + 1 );
+std::u16string_view aExtensionPath = jar.substr( 
nQuestionMark1 + 1, nQuestionMark2 - nQuestionMark1 - 1 );
+std::u16string_view aPureJar = jar.substr( nQuestionMark2 + 1 
);
 
-zipFile = expandURL( aExtensionPath + "/" + aPureJar );
+zipFile = expandURL( OUString::Concat(aExtensionPath) + "/" + 
aPureJar );
 }
 else
 {
@@ -1795,12 +1796,12 @@ OUString 
IndexFolderIterator::implGetIndexFolderFromPackage( bool& o_rbTemporary
 return aIndexFolder;
 }
 
-void IndexFolderIterator::deleteTempIndexFolder( const OUString& aIndexFolder )
+void IndexFolderIterator::deleteTempIndexFolder( std::u16string_view 
aIndexFolder )
 {
-sal_Int32 nLastSlash = aIndexFolder.lastIndexOf( '/' );
-if( 

[Libreoffice-commits] core.git: fpicker/source

[Noel Grandin (via logerrit)]

 fpicker/source/office/contentenumeration.cxx |4 ++--
 fpicker/source/office/contentenumeration.hxx |2 +-
 fpicker/source/office/iodlg.cxx  |   10 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit ba74c925a5ef872c291613d4be589e1ab4b4e9e1
Author: Noel Grandin 
AuthorDate: Fri Apr 15 16:39:27 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Apr 15 20:11:29 2022 +0200

use more string_view in fpicker

Change-Id: I2568dfa05082bbd2d3a433c54b47039455d91153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133071
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/fpicker/source/office/contentenumeration.cxx 
b/fpicker/source/office/contentenumeration.cxx
index 737808e10b62..5b74719a3f6e 100644
--- a/fpicker/source/office/contentenumeration.cxx
+++ b/fpicker/source/office/contentenumeration.cxx
@@ -306,9 +306,9 @@ namespace svt
 }
 
 
-bool FileViewContentEnumerator::URLOnDenyList ( const OUString& sRealURL )
+bool FileViewContentEnumerator::URLOnDenyList ( std::u16string_view 
sRealURL )
 {
-OUString entryName = sRealURL.copy( sRealURL.lastIndexOf( '/' ) + 1 );
+std::u16string_view entryName = sRealURL.substr( sRealURL.rfind( '/' ) 
+ 1 );
 
 return comphelper::findValue(m_rDenyList, entryName) != -1;
 }
diff --git a/fpicker/source/office/contentenumeration.hxx 
b/fpicker/source/office/contentenumeration.hxx
index bc2180c53c47..68277e6a4830 100644
--- a/fpicker/source/office/contentenumeration.hxx
+++ b/fpicker/source/office/contentenumeration.hxx
@@ -172,7 +172,7 @@ namespace svt
 
 css::uno::Sequence< OUString > m_rDenyList;
 
-bool URLOnDenyList ( const OUString& sRealURL );
+bool URLOnDenyList ( std::u16string_view sRealURL );
 
 public:
 /** constructs an enumerator instance
diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 4090189a3cf6..d41bbab8b252 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -127,18 +127,18 @@ namespace
 }
 
 
-OUString GetFsysExtension_Impl( const OUString& rFile, const OUString& 
rLastFilterExt )
+OUString GetFsysExtension_Impl( std::u16string_view rFile, const OUString& 
rLastFilterExt )
 {
-sal_Int32 nDotPos = rFile.lastIndexOf( '.' );
-if ( nDotPos != -1 )
+size_t nDotPos = rFile.rfind( '.' );
+if ( nDotPos != std::u16string_view::npos )
 {
 if ( !rLastFilterExt.isEmpty() )
 {
-if ( o3tl::equalsIgnoreAsciiCase(rFile.subView( nDotPos + 1 ), 
rLastFilterExt ) )
+if ( o3tl::equalsIgnoreAsciiCase(rFile.substr( nDotPos + 1 ), 
rLastFilterExt ) )
 return rLastFilterExt;
 }
 else
-return rFile.copy( nDotPos );
+return OUString(rFile.substr( nDotPos ));
 }
 return OUString();
 }

[Libreoffice-bugs] [Bug 126087] Hang/processing loop pasting a large table after undo in multipage view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126087

Buovjaga  changed:

   What|Removed |Added

 Attachment #179590|0   |1
is obsolete||

--- Comment #7 from Buovjaga  ---
Created attachment 179593
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179593=edit
Perf flamegraph

I might have absentmindedly used some incorrect version for testing, so
uploading a trace taken with an --enable-symbols build

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b2b821715a3745718a941fa99dda92137c0f0c86
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135703] EDITING Inserting paragraph before multi page table causes CPU spike

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135703

Buovjaga  changed:

   What|Removed |Added

 Attachment #179538|0   |1
is obsolete||

--- Comment #4 from Buovjaga  ---
Created attachment 179592
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179592=edit
Perf flamegraph

I might have absentmindedly used some incorrect version for testing, so
uploading a trace taken with an --enable-symbols build

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b2b821715a3745718a941fa99dda92137c0f0c86
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143441] FILEOPEN TABLE: Writer process stops responding when opening MS Office doc with vertical text center aligned on merged table cells that cross pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143441

--- Comment #5 from Buovjaga  ---
Created attachment 179591
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179591=edit
Perf flamegraph

I might have absentmindedly used some incorrect version for testing, so
uploading a trace taken with an --enable-symbols build

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b2b821715a3745718a941fa99dda92137c0f0c86
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126087] Hang/processing loop pasting a large table after undo in multipage view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126087

Buovjaga  changed:

   What|Removed |Added

 Attachment #179537|0   |1
is obsolete||

--- Comment #6 from Buovjaga  ---
Created attachment 179590
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179590=edit
Perf flamegraph

I might have absentmindedly used some incorrect version for testing, so
uploading a trace taken with an --enable-symbols build

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b2b821715a3745718a941fa99dda92137c0f0c86
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/inc

[Justin Luth (via logerrit)]

 sw/inc/docufld.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad76fa39f3a43822103141dbbaea3b057e5d3a15
Author: Justin Luth 
AuthorDate: Wed Apr 6 09:28:49 2022 +0200
Commit: Andras Timar 
CommitDate: Fri Apr 15 20:00:22 2022 +0200

tdf#147861 sw ms export: DI_SUB_MASK must exclude FIXED now

This is a follow-up to
7.4 commit daef39352b008fc1f903fd8c09288ff5e772fa42

There is only one place in which DI_SUB_MASK is used,
so I'm just changing it to what it could have always been,
since it never was actually used to mask out DI_SUB_FIXED.
Otherwise, I might have made this a MASK2 or whatever.

The issue here is that AUTHOR was not being recognized
when it was paired with FIXED, so every FIXEDFLD was
ended up being considered as a date/time.

In practice, this didn't really change anything
because bWriteExpand already ignored any of
these areas of the code. It is only when I turn off
bWriteExpand as I implement fixes that I am seeing
the wrong field type being created.

And regardless, since the field is FIXED, the visible
content remains the same anyway (until someone in MS Word
refreshes the field with F9).

Both Author and date have the same field name ":Created"
so I couldn't super easily test this.

Change-Id: Icd2d0be2d3fbe24dc4763e0e25801569bcca471b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132660
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 
(cherry picked from commit e61eed211766f26a3896c1d912dc7349abbe823d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132698
Tested-by: Jenkins CollaboraOffice 
(cherry picked from commit 2e6acddd815bca6261634b69b015c6deead74b58)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132702
Reviewed-by: Andras Timar 

diff --git a/sw/inc/docufld.hxx b/sw/inc/docufld.hxx
index 62363f01bbd1..b4fe720970b6 100644
--- a/sw/inc/docufld.hxx
+++ b/sw/inc/docufld.hxx
@@ -79,7 +79,7 @@ namespace nsSwDocInfoSubType
 const SwDocInfoSubType DI_SUB_TIME  = 0x0200;
 const SwDocInfoSubType DI_SUB_DATE  = 0x0300;
 const SwDocInfoSubType DI_SUB_FIXED = 0x1000;
-const SwDocInfoSubType DI_SUB_MASK  = 0xff00;
+const SwDocInfoSubType DI_SUB_MASK  = 0x0f00;
 }
 
 enum SwPageNumSubType

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa

[Dennis Francis (via logerrit)]

 sc/qa/unit/tiledrendering/tiledrendering.cxx |   30 +++
 1 file changed, 26 insertions(+), 4 deletions(-)

New commits:
commit e7710ecab5da8ba734a0270e87bba269041ae391
Author: Dennis Francis 
AuthorDate: Tue Apr 12 10:43:00 2022 +0530
Commit: Andras Timar 
CommitDate: Fri Apr 15 19:58:58 2022 +0200

unit test: use temp copy in testInvalidEntrySave()

Use a temporary copy of the source file to run this test otherwise it
will execute a .uno:Save on the original document in the git tree!

Change-Id: I673aad64453e72a9140efcad2b0ff9c0ceabc038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132851
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 9894da18e018..053b8d842019 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -42,6 +42,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -187,10 +189,11 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-ScModelObj* createDoc(const char* pName);
+ScModelObj* createDoc(const char* pName, bool bMakeTempCopy = false);
 void setupLibreOfficeKitViewCallback(SfxViewShell* pViewShell);
 static void callback(int nType, const char* pPayload, void* pData);
 void callbackImpl(int nType, const char* pPayload);
+void makeTempCopy(const OUString& rOrigURL);
 
 /// document size changed callback.
 osl::Condition m_aDocSizeCondition;
@@ -198,6 +201,7 @@ private:
 
 uno::Reference mxComponent;
 TestLokCallbackWrapper m_callbackWrapper;
+std::unique_ptr mpTempFile;
 };
 
 ScTiledRenderingTest::ScTiledRenderingTest()
@@ -236,11 +240,29 @@ void ScTiledRenderingTest::tearDown()
 test::BootstrapFixture::tearDown();
 }
 
-ScModelObj* ScTiledRenderingTest::createDoc(const char* pName)
+void ScTiledRenderingTest::makeTempCopy(const OUString& rOrigURL)
+{
+mpTempFile.reset(new utl::TempFile());
+mpTempFile->EnableKillingFile();
+auto const aError = osl::File::copy(rOrigURL, mpTempFile->GetURL());
+CPPUNIT_ASSERT_EQUAL_MESSAGE(
+OUString("<" + rOrigURL + "> -> <" + mpTempFile->GetURL() + 
">").toUtf8().getStr(),
+osl::FileBase::E_None, aError);
+}
+
+ScModelObj* ScTiledRenderingTest::createDoc(const char* pName, bool 
bMakeTempCopy)
 {
 if (mxComponent.is())
 mxComponent->dispose();
-mxComponent = loadFromDesktop(m_directories.getURLFromSrc(DATA_DIRECTORY) 
+ OUString::createFromAscii(pName), "com.sun.star.sheet.SpreadsheetDocument");
+
+OUString aOriginalSrc = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
OUString::createFromAscii(pName);
+if (bMakeTempCopy)
+makeTempCopy(aOriginalSrc);
+
+mxComponent = loadFromDesktop(
+bMakeTempCopy ? mpTempFile->GetURL() : aOriginalSrc,
+"com.sun.star.sheet.SpreadsheetDocument");
+
 ScModelObj* pModelObj = dynamic_cast(mxComponent.get());
 CPPUNIT_ASSERT(pModelObj);
 
pModelObj->initializeForTiledRendering(uno::Sequence());
@@ -3033,7 +3055,7 @@ void ScTiledRenderingTest::testInvalidEntrySave()
 // Load a document
 comphelper::LibreOfficeKit::setActive();
 
-ScModelObj* pModelObj = createDoc("validity.xlsx");
+ScModelObj* pModelObj = createDoc("validity.xlsx", true /* bMakeTempCopy 
*/);
 const ScDocument* pDoc = pModelObj->GetDocument();
 ViewCallback aView;
 int nView = SfxLokHelper::getView();

[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112969
Bug 112969 depends on bug 148494, which changed state.

Bug 148494 Summary: FILESAVE DOCX Field MacroButton saved incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=148494

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Xisco Fauli (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf148494.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx   |   12 
 sw/source/filter/ww8/ww8atr.cxx  |4 ++--
 3 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit c5d5c7e8c385f8a7e6ab824095e61aeeca4ab8c7
Author: Xisco Fauli 
AuthorDate: Fri Apr 15 17:55:21 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 19:17:54 2022 +0200

tdf#148494: export: Always add space separator

Otherwise, the macro is saved as MACROBUTTONAllCaps
instead of MACROBUTTON AllCaps

Change-Id: Id1288e23f21ce72884bc1197f171e255ea7458f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133077
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf148494.docx 
b/sw/qa/extras/ooxmlexport/data/tdf148494.docx
new file mode 100644
index ..c60c73a206fb
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf148494.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 75b483e7d239..960bb3f16d8b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -158,6 +158,18 @@ CPPUNIT_TEST_FIXTURE(Test, testContentControlExport)
 assertXPath(pXmlDoc, "//w:sdt/w:sdtContent", 1);
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf148494)
+{
+loadAndSave("tdf148494.docx");
+
+xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
+
+// Without the fix in place, this test would have failed with
+// - Expected:  MACROBUTTON AllCaps Hello World
+// - Actual  :  MACROBUTTONAllCaps Hello World
+assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[3]/w:instrText", " 
MACROBUTTON AllCaps Hello World ");
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf137466, "tdf137466.docx")
 {
 xmlDocUniquePtr pXmlDoc = parseExport("word/document.xml");
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 72bdc213f4b3..b9c71e4433ae 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -3300,8 +3300,8 @@ void AttributeOutputBase::TextField( const SwFormatField& 
rField )
 break;
 case SwFieldIds::Macro:
 {
-const OUString sStr = " MACROBUTTON"
-+ 
pField->GetPar1().replaceFirst("StarOffice.Standard.Modul1.", " ")
+const OUString sStr = " MACROBUTTON "
++ 
pField->GetPar1().replaceFirst("StarOffice.Standard.Modul1.", "")
 + " "
 + lcl_GetExpandedField(*pField);
 GetExport().OutputField( pField, ww::eMACROBUTTON, sStr );

[Libreoffice-bugs] [Bug 131751] Character emphasis is not rendered correctly in print and export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131751

--- Comment #9 from Kenneth Hanson  ---
Bug still present in v7.2.6.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148599] Frame style issue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148599

--- Comment #2 from la...@hotmail.com ---
Hi,
  It seems that when a frame property is changed on a frame instance, style are
not influencing that property anymore.
  Is it the correct behavior ?
  Then, how do we reset the override ?

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - slideshow/source

[Thorsten Behrens (via logerrit)]

 slideshow/source/engine/activities/simplecontinuousactivitybase.cxx |   12 
+++---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 18ac22f8a24cb4b691d8c0269206355d0f484625
Author: Thorsten Behrens 
AuthorDate: Thu Apr 14 12:01:50 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 18:28:24 2022 +0200

Resolves: tdf#143615 clamp relative times to 1.0

User input permits zero-length animations, so whenever we calculate
relative position within the animation time frame, the case
mnMinSimpleDuration == 0.0 means: we're already at the end of the
animation, i.e. set relative time to 1.0

Change-Id: I0e8c1e29f47bd9fa16f04115cf52d3a176e13fb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133005
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit e1db8c27875eac73b1e619e4a23ecdb7a9924b61)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133039
Reviewed-by: Xisco Fauli 

diff --git 
a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx 
b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
index 9e23fc2c76c8..01cb3b75007b 100644
--- a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
+++ b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
@@ -63,9 +63,12 @@ namespace slideshow::internal
 // perform will be called at least mnMinNumberOfTurns
 // times.
 
-// fraction of time elapsed
+// fraction of time elapsed (clamp to 1.0 for zero-length
+// animations)
 const double nFractionElapsedTime(
-nCurrElapsedTime / mnMinSimpleDuration );
+mnMinSimpleDuration != 0.0 ?
+nCurrElapsedTime / mnMinSimpleDuration :
+1.0 );
 
 // fraction of minimum calls performed
 const double nFractionRequiredCalls(
@@ -115,7 +118,10 @@ namespace slideshow::internal
 // ===
 
 const double nCurrElapsedTime( maTimer.getElapsedTime() );
-double nT( nCurrElapsedTime / mnMinSimpleDuration );
+// clamp to 1.0 for zero animation duration
+double nT( mnMinSimpleDuration != 0.0 ?
+   nCurrElapsedTime / mnMinSimpleDuration :
+   1.0 );
 
 
 // one of the stop criteria reached?

[Libreoffice-bugs] [Bug 148615] Grid settings in Draw not properly set upon loading file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148615

Scott  changed:

   What|Removed |Added

 CC||salex...@gmail.com

--- Comment #1 from Scott  ---
Created attachment 179589
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179589=edit
Draw file with specific grid settings

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #1)
> Likely not possible without changing the ODF spec.

Oh, yes, certainly. I should have mentioned that. Definitely asking for this to
be directly representable in ODF files and part of the spec.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148479] Support category indicators

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148479

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #1)
> Likely not possible without changing the ODF spec.

Oh, yes, certainly. I should have mentioned that. Definitely asking for this to
be directly representable in ODF files and part of the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148615] New: Grid settings in Draw not properly set upon loading file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148615

Bug ID: 148615
   Summary: Grid settings in Draw not properly set upon loading
file
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: salex...@gmail.com

Description:
I have various Drawings generated with Draw with different grid settings. I
noticed when I load a Drawing to work on it items would be off grid and a mess.
Figured out it was because the Grid settings are not properly set for each
drawing when the drawing is loaded.

Steps to Reproduce:
1. Open Draw
2. Set Tools | Options | General | UOM : Inch
3. Set Tools | Options | Grid : Snap to Grid:on + Visible Grid:on + H/V= 1.00"
+ H/V Spaces=5
4. Apply
5. Close Draw
6. Open Draw
7. Verify the previous settings
8. Open grid1.odg
9. Check the Options to see if they agree with file settings



Actual Results:
When I perform these steps and check the grid settings I find the Grid H/V
settings are 2.54 cm.

Expected Results:
The Grid H/V settings should be 1.00 cm.


Reproducible: Always


User Profile Reset: No



Additional Info:
I can reproduce this on two different windows 11 computers.
I can reproduce many variations of this problem opening and closing files with
different grid settings.
OpenGL doesn't seem to make a difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - slideshow/source

[Thorsten Behrens (via logerrit)]

 slideshow/source/engine/activities/simplecontinuousactivitybase.cxx |   12 
+++---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 01c5006db900e3911e6bf8cb7abc2935e8215ded
Author: Thorsten Behrens 
AuthorDate: Thu Apr 14 12:01:50 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 15 18:05:46 2022 +0200

Resolves: tdf#143615 clamp relative times to 1.0

User input permits zero-length animations, so whenever we calculate
relative position within the animation time frame, the case
mnMinSimpleDuration == 0.0 means: we're already at the end of the
animation, i.e. set relative time to 1.0

Change-Id: I0e8c1e29f47bd9fa16f04115cf52d3a176e13fb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133005
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit e1db8c27875eac73b1e619e4a23ecdb7a9924b61)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133038
Reviewed-by: Xisco Fauli 

diff --git 
a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx 
b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
index 9e23fc2c76c8..01cb3b75007b 100644
--- a/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
+++ b/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
@@ -63,9 +63,12 @@ namespace slideshow::internal
 // perform will be called at least mnMinNumberOfTurns
 // times.
 
-// fraction of time elapsed
+// fraction of time elapsed (clamp to 1.0 for zero-length
+// animations)
 const double nFractionElapsedTime(
-nCurrElapsedTime / mnMinSimpleDuration );
+mnMinSimpleDuration != 0.0 ?
+nCurrElapsedTime / mnMinSimpleDuration :
+1.0 );
 
 // fraction of minimum calls performed
 const double nFractionRequiredCalls(
@@ -115,7 +118,10 @@ namespace slideshow::internal
 // ===
 
 const double nCurrElapsedTime( maTimer.getElapsedTime() );
-double nT( nCurrElapsedTime / mnMinSimpleDuration );
+// clamp to 1.0 for zero animation duration
+double nT( mnMinSimpleDuration != 0.0 ?
+   nCurrElapsedTime / mnMinSimpleDuration :
+   1.0 );
 
 
 // one of the stop criteria reached?

[Libreoffice-commits] core.git: sw/source

[Vasily Melenchuk (via logerrit)]

 sw/source/ui/fldui/flddok.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit b2b821715a3745718a941fa99dda92137c0f0c86
Author: Vasily Melenchuk 
AuthorDate: Wed Apr 13 20:19:35 2022 +0300
Commit: Thorsten Behrens 
CommitDate: Fri Apr 15 18:02:00 2022 +0200

tdf#148551: sw ui: set default format value for Insert Field dlg

My previous implementation was changing current format selection
only for field edit dialog. However it should be initialized also
for insert field dlg. It is not always first element. Instead of
older confusing approach right now there is a switch to set
defaults: it is less confusing IMO.

Change-Id: I189339ba66effc49267004a42345a28892cb693c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132980
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx
index 2e7c1c67dbc2..4e65a7c3fb26 100644
--- a/sw/source/ui/fldui/flddok.cxx
+++ b/sw/source/ui/fldui/flddok.cxx
@@ -479,6 +479,19 @@ sal_Int32 SwFieldDokPage::FillFormatLB(SwFieldTypesEnum 
nTypeId)
 {
 m_xFormatLB->select_id(OUString::number(GetCurField()->GetFormat() & 
~AF_FIXED));
 }
+else
+{
+// Select default selected value for "Insert" dialog
+switch (nTypeId)
+{
+case SwFieldTypesEnum::PageNumber:
+case SwFieldTypesEnum::DocumentStatistics:
+m_xFormatLB->select_text(SwResId(FMT_NUM_PAGEDESC));
+break;
+default:
+m_xFormatLB->select(0);
+}
+}
 
 FormatHdl(*m_xFormatLB);
 

[Libreoffice-bugs] [Bug 148494] FILESAVE DOCX Field MacroButton saved incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148494

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

--- Comment #4 from Xisco Faulí  ---
Proposed fixed in https://gerrit.libreoffice.org/c/core/+/133077

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/app/salvtables.cxx |   43 --
 1 file changed, 21 insertions(+), 22 deletions(-)

New commits:
commit 9efab24f38bb5e4b150c842cda51cfd76d694022
Author: Caolán McNamara 
AuthorDate: Fri Apr 15 14:44:54 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 15 17:57:30 2022 +0200

use the same colors for warning/error for gen ComboBox as Entry does

Change-Id: I0fb24c0d60c66348052334c9a86e6a5425dccb46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index fad841f45787..263c29ff5eea 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -3316,31 +3316,39 @@ void SalInstanceEntry::set_overwrite_mode(bool bOn) { 
m_xEntry->SetInsertMode(!b
 
 bool SalInstanceEntry::get_overwrite_mode() const { return 
!m_xEntry->IsInsertMode(); }
 
-void SalInstanceEntry::set_message_type(weld::EntryMessageType eType)
+namespace
+{
+void set_message_type(Edit* pEntry, weld::EntryMessageType eType)
 {
 switch (eType)
 {
 case weld::EntryMessageType::Normal:
-m_xEntry->SetForceControlBackground(false);
-m_xEntry->SetControlForeground();
-m_xEntry->SetControlBackground();
+pEntry->SetForceControlBackground(false);
+pEntry->SetControlForeground();
+pEntry->SetControlBackground();
 break;
 case weld::EntryMessageType::Warning:
 // tdf#114603: enable setting the background to a different color;
 // relevant for GTK; see also #i75179#
-m_xEntry->SetForceControlBackground(true);
-m_xEntry->SetControlForeground(COL_BLACK);
-m_xEntry->SetControlBackground(COL_YELLOW);
+pEntry->SetForceControlBackground(true);
+pEntry->SetControlForeground(COL_BLACK);
+pEntry->SetControlBackground(COL_YELLOW);
 break;
 case weld::EntryMessageType::Error:
 // tdf#114603: enable setting the background to a different color;
 // relevant for GTK; see also #i75179#
-m_xEntry->SetForceControlBackground(true);
-m_xEntry->SetControlForeground(COL_WHITE);
-m_xEntry->SetControlBackground(0xff6563);
+pEntry->SetForceControlBackground(true);
+pEntry->SetControlForeground(COL_WHITE);
+pEntry->SetControlBackground(0xff6563);
 break;
 }
 }
+}
+
+void SalInstanceEntry::set_message_type(weld::EntryMessageType eType)
+{
+::set_message_type(m_xEntry, eType);
+}
 
 void SalInstanceEntry::set_font(const vcl::Font& rFont)
 {
@@ -6355,18 +6363,9 @@ bool 
SalInstanceComboBoxWithEdit::changed_by_direct_pick() const
 
 void 
SalInstanceComboBoxWithEdit::set_entry_message_type(weld::EntryMessageType 
eType)
 {
-switch (eType)
-{
-case weld::EntryMessageType::Normal:
-m_xComboBox->SetControlForeground();
-break;
-case weld::EntryMessageType::Warning:
-m_xComboBox->SetControlForeground(COL_YELLOW);
-break;
-case weld::EntryMessageType::Error:
-m_xComboBox->SetControlForeground(Color(0xf0, 0, 0));
-break;
-}
+Edit* pEdit = m_xComboBox->GetSubEdit();
+assert(pEdit);
+::set_message_type(pEdit, eType);
 }
 
 OUString SalInstanceComboBoxWithEdit::get_active_text() const { return 
m_xComboBox->GetText(); }

[Libreoffice-bugs] [Bug 147237] Dynamic theme gtk switching only partially switches colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147237

--- Comment #11 from Caolán McNamara  ---
https://gerrit.libreoffice.org/c/core/+/133076 should at least fix comment #10
and the "speckles" that can be seen at the corner of the comboboxes in that
image.

Comment #9 however I can't reproduce and I'm not sure I'm looking at the right
thing. "Default Paragraph Style" and "Clear formatting" looks a bit like the
top of the style dropdown from the standard toolbar, but in 7.3 those entries
are the other way around and don't have that wide bevel around them

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147237] Dynamic theme gtk switching only partially switches colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147237

Caolán McNamara  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148612] Bug in a macro that cannot read cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148612

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148612] Bug in a macro that cannot read cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148612

--- Comment #2 from Mike Kaganski  ---
Created attachment 179588
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179588=edit
Minimal bugdoc

Repro using Version: 7.3.3.1 (x64) / LibreOffice Community
Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: 

The attachment has minimal macro needed to reproduce the bug. Looks like having
something named "cells" referenced from a sub, affects use of an object's
member having the same name in another function. Renaming "cells" to anything
else in "test3" makes "test_bug" function properly copy data from A1 to A2.

-- 
You are receiving this mail because:
You are the assignee for the bug.