[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/document.hxx|2 ++
sc/inc/table.hxx |1 +
sc/source/core/data/document.cxx |7 +++
sc/source/core/data/table1.cxx |9 +
sc/source/filter/html/htmlexp2.cxx |4 +---
5 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit 79ea331bbd91def54bb8a31ba2acd671fbf4422d
Author: Luboš Luňák
AuthorDate: Thu Apr 21 21:56:32 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 22 07:44:07 2022 +0200
fix checking whether a block of cells is empty
The GetEmptyLinesInBlock() call has unclear semantics and it appears
that it has an off-by-one error. Use a simple clear function
for the check.
Change-Id: I45d9b73428aedababc1ad93c202daa1de945b5bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133303
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index d24f4f170239..5e5af3a31fa6 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1532,6 +1532,8 @@ public:
voidExtendPrintArea( OutputDevice* pDev, SCTAB
nTab,
SCCOL nStartCol, SCROW
nStartRow,
SCCOL& rEndCol, SCROW nEndRow
) const;
+SC_DLLPUBLIC bool IsEmptyBlock(SCCOL nStartCol, SCROW nStartRow,
+ SCCOL nEndCol, SCROW nEndRow,
SCTAB nTab) const;
SC_DLLPUBLIC SCSIZE GetEmptyLinesInBlock( SCCOL nStartCol, SCROW
nStartRow, SCTAB nStartTab,
SCCOL nEndCol, SCROW
nEndRow, SCTAB nEndTab,
ScDirection eDir );
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index ba8ed9e328d8..ec78bfa598c5 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -619,6 +619,7 @@ public:
SCROW GetLastDataRow( SCCOL nCol1, SCCOL nCol2, SCROW nLastRow,
ScDataAreaExtras* pDataAreaExtras = nullptr )
const;
+boolIsEmptyBlock(SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol,
SCROW nEndRow) const;
SCSIZE GetEmptyLinesInBlock( SCCOL nStartCol, SCROW nStartRow,
SCCOL nEndCol, SCROW nEndRow,
ScDirection eDir ) const;
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index b0b9242a1a63..c8e951e7b909 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -6142,6 +6142,13 @@ ScStyleSheetPool* ScDocument::GetStyleSheetPool() const
return mxPoolHelper->GetStylePool();
}
+bool ScDocument::IsEmptyBlock(SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol,
SCROW nEndRow, SCTAB nTab) const
+{
+if (ValidTab(nTab) && nTab < static_cast(maTabs.size()) &&
maTabs[nTab])
+return maTabs[nTab]->IsEmptyBlock(nStartCol, nStartRow, nEndCol,
nEndRow);
+return true;
+}
+
SCSIZE ScDocument::GetEmptyLinesInBlock( SCCOL nStartCol, SCROW nStartRow,
SCTAB nStartTab,
SCCOL nEndCol, SCROW nEndRow, SCTAB nEndTab,
ScDirection eDir )
{
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index e864bd23974f..16b90b3b7c62 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1175,6 +1175,15 @@ SCROW ScTable::GetLastDataRow( SCCOL nCol1, SCCOL nCol2,
SCROW nLastRow, ScDataA
return nNewLastRow;
}
+bool ScTable::IsEmptyBlock( SCCOL nStartCol, SCROW nStartRow,
+SCCOL nEndCol, SCROW nEndRow ) const
+{
+for( SCCOL col : GetAllocatedColumnsRange( nStartCol, nEndCol ))
+if( !aCol[col].IsEmptyBlock( nStartRow, nEndRow ))
+return false;
+return true;
+}
+
SCSIZE ScTable::GetEmptyLinesInBlock( SCCOL nStartCol, SCROW nStartRow,
SCCOL nEndCol, SCROW nEndRow,
ScDirection eDir ) const
{
diff --git a/sc/source/filter/html/htmlexp2.cxx
b/sc/source/filter/html/htmlexp2.cxx
index 7d3c7f75b213..bc969f89fc80 100644
--- a/sc/source/filter/html/htmlexp2.cxx
+++ b/sc/source/filter/html/htmlexp2.cxx
@@ -89,9 +89,7 @@ void ScHTMLExport::FillGraphList( const SdrPage* pPage, SCTAB
nTab,
SCCOL nCol2 = aR.aEnd.Col();
SCROW nRow2 = aR.aEnd.Row();
// All cells empty under object?
-bool bInCell = (pDoc->GetEmptyLinesInBlock(
-nCol1, nRow1, nTab, nCol2, nRow2, nTab, DIR_TOP )
-== static_cast< SCSIZE >( nRow2 - nRow1 ));// rows-1 !
+bool bInCell = pDoc->IsEmptyBlock( nCol1, nRow1, nCol2, nRow2,
nTab );
if ( bInCell )
{ // Spacing in spanning cell
tools::Rectangle aCellRect = pDoc->GetMMRect(
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table4.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 8b5fdf155817d516ce40c203ccbade0c64a5d6e6
Author: Luboš Luňák
AuthorDate: Thu Apr 21 22:33:26 2022 +0200
Commit: Luboš Luňák
CommitDate: Fri Apr 22 07:43:49 2022 +0200
use range-checked GetCellValue()
Change-Id: Ie02b6be79d1be7481ebcfbc6862295a34e38f7db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133304
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 5105d9c36654..bad81a83dd9a 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1887,7 +1887,7 @@ void ScTable::FillAutoSimple(
{
if (bVertical) // rInner&:=nRow, rOuter&:=nCol
{
-aSrcCell = aCol[rCol].GetCellValue(nSource);
+aSrcCell = GetCellValue(rCol, nSource);
if (nISrcStart == nISrcEnd && aSrcCell.meType ==
CELLTYPE_FORMULA)
{
FillFormulaVertical(*aSrcCell.mpFormula, rInner, rCol,
nIStart, nIEnd, pProgress, rProgress);
@@ -1901,7 +1901,7 @@ void ScTable::FillAutoSimple(
}
else// rInner&:=nCol, rOuter&:=nRow
{
-aSrcCell = aCol[nSource].GetCellValue(rRow);
+aSrcCell = GetCellValue(nSource, rRow);
const SvNumFormatType nFormatType =
rDocument.GetFormatTable()->GetType(
aCol[nSource].GetNumberFormat(
rDocument.GetNonThreadedContext(), rRow));
bBooleanCell = (nFormatType == SvNumFormatType::LOGICAL);
@@ -2226,9 +2226,9 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, SCCOL
nCol2, SCROW nRow2,
// it is still a good upper estimation.
ScCellValue aSrcCell;
if (bVertical)
-aSrcCell =
aCol[static_cast(nOStart)].GetCellValue(static_cast(nISource));
+aSrcCell = GetCellValue(static_cast(nOStart),
static_cast(nISource));
else
-aSrcCell =
aCol[static_cast(nISource)].GetCellValue(static_cast(nOStart));
+aSrcCell = GetCellValue(static_cast(nISource),
static_cast(nOStart));
// Same logic as for the actual series.
if (!aSrcCell.isEmpty() && (aSrcCell.meType == CELLTYPE_VALUE ||
aSrcCell.meType == CELLTYPE_FORMULA))
{
@@ -2281,7 +2281,7 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, SCCOL
nCol2, SCROW nRow2,
CreateColumnIfNotExists(nCol);
// Source cell value. We need to clone the value since it may be
inserted repeatedly.
-ScCellValue aSrcCell =
aCol[nCol].GetCellValue(static_cast(nRow));
+ScCellValue aSrcCell = GetCellValue(nCol, static_cast(nRow));
// Maybe another source cell need to be searched, if the fill is going
through merged cells,
// where overlapped parts does not contain any information, so they
can be skipped.
@@ -2306,9 +2306,9 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, SCCOL
nCol2, SCROW nRow2,
//Set the real source cell
if (bVertical)
-aSrcCell =
aCol[nOStart].GetCellValue(static_cast(nFirstValueIdx));
+aSrcCell = GetCellValue(nOStart,
static_cast(nFirstValueIdx));
else
-aSrcCell =
aCol[nFirstValueIdx].GetCellValue(static_cast(nOStart));
+aSrcCell = GetCellValue(nFirstValueIdx,
static_cast(nOStart));
}
const ScPatternAttr* pSrcPattern =
aCol[nCol].GetPattern(static_cast(nRow));
[Libreoffice-bugs] [Bug 148708] ordered letter list wrongs then save as docx
https://bugs.documentfoundation.org/show_bug.cgi?id=148708 Timur changed: What|Removed |Added Keywords||bisected, filter:docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 --- Comment #6 from Timur --- (In reply to robgrune from comment #4) > But the problem of no help function remains. What you you mean? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-7-3+backports' - 15 commits - android/Bootstrap android/default-document android/source cppuhelper/source sw/source ucb/source vcl/inc vc
android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java |1
android/default-document/example.odt |binary
android/source/res/layout/activity_document_browser.xml |4
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java | 88
--
cppuhelper/source/exc_thrower.cxx | 19 +-
sw/source/core/doc/docbm.cxx |5
sw/source/core/inc/layfrm.hxx |1
sw/source/core/layout/findfrm.cxx | 21 ++
sw/source/core/layout/pagechg.cxx |2
ucb/source/ucp/webdav-curl/CurlSession.cxx|7
vcl/inc/qt5/QtInstance.hxx|6
vcl/inc/qt5/QtWidget.hxx |8
vcl/qt5/QtInstance.cxx|7
vcl/qt5/QtWidget.cxx | 55
+-
14 files changed, 159 insertions(+), 65 deletions(-)
New commits:
commit 8d1304d602d67c695f3de6f2aea74a1ca2419fcf
Author: Jan-Marek Glogowski
AuthorDate: Wed Nov 17 01:24:22 2021 +0100
Commit: Michael Weghorn
CommitDate: Fri Apr 22 07:14:24 2022 +0200
Convert example document from cz to en-us
Change-Id: Ia757491ce8802ec9deec9e75c65c6ae1c8ff2c79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126460
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 7a4a13517dc464ed409be0b9c36b2a32a4027c98)
diff --git a/android/default-document/example.odt
b/android/default-document/example.odt
index 2da7ce6e84d1..3aa6bb5119e9 100644
Binary files a/android/default-document/example.odt and
b/android/default-document/example.odt differ
commit 5c2b5e77da29edfcbdb0b3f534bbed077842b327
Author: Michael Weghorn
AuthorDate: Thu Apr 21 17:01:55 2022 +0200
Commit: Michael Weghorn
CommitDate: Fri Apr 22 07:13:48 2022 +0200
android: Show file chooser despite package visibility filtering in API 30
While it was working just fine in my x86_64 AVD with API level 31,
opening the the file chooser on a real HW aarch64 device running
Android 12 no longer worked by tapping on the TextView in
`LibreOfficeUIActivity` after updating target API from 28
to 31 in
commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
Date: Tue Apr 19 10:33:27 2022 +0200
android: Update compileSdkVersion/targetSdkVersion to 31
The
intent.resolveActivity(getPackageManager()) != null
check was failing there, so the Activity with
`Intent.ACTION_OPEN_DOCUMENT` wasn't started there.
This looks like an issue due to package visibility filtering
introduced in target API level 30. Quoting from [1]:
> When an app targets Android 11 (API level 30) or higher and queries for
> information about the other apps that are installed on a device, the
> system filters this information by default. The limited package
> visibility reduces the number of apps that appear to be installed on a
> device, from your app's perspective.
>
> [...]
>
> The limited app visibility affects the return results of methods that
> give information about other apps, such as queryIntentActivities(),
> getPackageInfo(), and getInstalledApplications(). The limited
> visibility also affects explicit interactions with other apps, such
> as starting another app's service.
From how I understand it, the check is used to make sure that
there is an app that can handle the Intent, as e.g. the
"Android fundamentals 02.3: Implicit intents" tutorial [2]
mentions it for the example using an `Intent.ACTION_VIEW`:
> Use the resolveActivity() method and the Android package manager to find
> an Activity that can handle your implicit Intent. Make sure that the
> request resolved successfully.
>
> if (intent.resolveActivity(getPackageManager()) != null) {
> }
>
> This request matches your Intent action and data with the Intent filters
> for installed apps on the device. You use it to make sure there is at
> least one Activity that can handle your requests.
While that sounds reasonable to make sure there is an app that can
view specific data passed *from* the app (and [3] describes how to add
a corresponding `` element to make this use case work),
it seems to be unnecessary for `Intent.ACTION_OPEN_DOCUMENT`,
since that causes the system to "display the various DocumentsProvider
instances installed on the device, letting the user navigate through
them" and Android presumably at least provides a provider for
handling local files by itself in any case.
The
[Libreoffice-bugs] [Bug 148454] Crash when I change font size in KDE Plasma 5.22.5
https://bugs.documentfoundation.org/show_bug.cgi?id=148454 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148447] Replace All in Writer comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148447 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148439] Business card alignment and spacing problem
https://bugs.documentfoundation.org/show_bug.cgi?id=148439 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change
https://bugs.documentfoundation.org/show_bug.cgi?id=148414 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148316] I would like an option to disable font margins.
https://bugs.documentfoundation.org/show_bug.cgi?id=148316 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143167] Calc "Freeze Rows and Columns" randomly forgets row and column settings even though feature still checked on
https://bugs.documentfoundation.org/show_bug.cgi?id=143167 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143167] Calc "Freeze Rows and Columns" randomly forgets row and column settings even though feature still checked on
https://bugs.documentfoundation.org/show_bug.cgi?id=143167 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144960] "operations" are incorrectly applied to "formats only" in edit paste special
https://bugs.documentfoundation.org/show_bug.cgi?id=144960 --- Comment #2 from QA Administrators --- Dear Jack Danel, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144893] Image frame & content split when dragging frame outside table & partly off page
https://bugs.documentfoundation.org/show_bug.cgi?id=144893 --- Comment #3 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
New commits:
commit e4243a140345a4bcd800217115b42667e277c6a3
Author: Justin Luth
AuthorDate: Thu Apr 21 14:49:33 2022 +0200
Commit: Justin Luth
CommitDate: Fri Apr 22 05:55:38 2022 +0200
cleanup writerfilter lcl_ParseFormat
If there is no \@, then we will never match what
util::findQuotedText is looking for, so don't bother.
Change-Id: I0a6709046673d98d00d74e921d7f502c9df54b46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133265
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 2ce7081d286d..2aff26ad5ad4 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4219,18 +4219,17 @@ style::NumberingType::
static OUString lcl_ParseFormat( const OUString& rCommand )
{
// The command looks like: " DATE \@"dd " or "09/02/2014"
-// Remove whitespace permitted by standard between \@ and "
OUString command;
sal_Int32 delimPos = rCommand.indexOf("\\@");
if (delimPos != -1)
{
+// Remove whitespace permitted by standard between \@ and "
sal_Int32 wsChars = rCommand.indexOf('\"') - delimPos - 2;
command = rCommand.replaceAt(delimPos+2, wsChars, u"");
+return OUString(msfilter::util::findQuotedText(command, "\\@\"",
'\"'));
}
-else
-command = rCommand;
-return OUString(msfilter::util::findQuotedText(command, "\\@\"", '\"'));
+return OUString();
}
/*-
extract a parameter (with or without quotes) between the command and the
following backslash
[Libreoffice-bugs] [Bug 135026] Large arrow images on file save rtf (and missing text)
https://bugs.documentfoundation.org/show_bug.cgi?id=135026 Aron Budea changed: What|Removed |Added Keywords|bibisectRequest, regression |bibisected, bisected CC||aron.bu...@gmail.com --- Comment #3 from Aron Budea --- (In reply to Telesto from comment #0) > Expected Results: > Regular sized Not sure why any arrows would be expected there. The empty pages have already been there since 3.3.0, while they aren't in the original. Nevertheless, the oversized arrow images started appearing with the following commit. https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c91f8f839d36c8b5af272b1d3c835d2f4af6b65 author Miklos Vajna 2018-07-16 22:04:02 +0200 committer Miklos Vajna 2018-07-17 09:03:42 +0200 "tdf#81943 sw RTF import: fix missing wrap in background for in-table shape" This claims to fix a regression, so I checked the state before the regressing commit, and there are no large arrows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141623] Qt5 refresh problem when starting LO start center and cairo (text) rendering ennabled
https://bugs.documentfoundation.org/show_bug.cgi?id=141623 --- Comment #8 from margot --- I have read the file Refresh bug of the start center with the default 640x480 cairo surface you attached but still not working. Or did I do something wrong. https://dinosaur-game.io -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148716] New: LibreOffice dark mode displays inverted previews
https://bugs.documentfoundation.org/show_bug.cgi?id=148716 Bug ID: 148716 Summary: LibreOffice dark mode displays inverted previews Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: barrett...@owageskuo.com I am using the flatpak. When I launch LibreOffice the main app, not a specific one like Writer or Draw it will show a bunch of previews for recent files. The issue is that I am using dark mode and all of my documents are dark themed but the previews seem to be inverted and show white mode. This does not match what the documents actually look like when opened. Preferably the document previews would show what the document would actually look like if using dark mode. I have stopped using the main LibreOffice app and go directly into Write, Draw, Calc etc instead because I don't like being visually blasted by most of my screens showing white documents. I really did like having the main LibreOffice pinned and then I could launch my recent document or pick the app so I am looking forward if this can be fixed so I can go back to using it how I used too Thank you for all the work your team does, loving LibreOffice besides this one issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 --- Comment #4 from robgrune --- Problem obviated by upgrading to Ubuntu 22.04, Gnome 42, and LO 7.3.2.2 installed from repositories (not snap). But the problem of no help function remains. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148605] Writer no fonts shown in drop-down box
https://bugs.documentfoundation.org/show_bug.cgi?id=148605 --- Comment #3 from robgrune --- (In reply to Timur from comment #2) > May be a Wayland problem and a duplicate of bug 147249. Problem occurs for both wayland and x11. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148426] Inserting image via clipboard or drag and drop inserts only placeholder
https://bugs.documentfoundation.org/show_bug.cgi?id=148426 Aron Budea changed: What|Removed |Added Blocks||108843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108843 [Bug 108843] [META] Clipboard bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Aron Budea changed: What|Removed |Added Depends on||148426 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148426 [Bug 148426] Inserting image via clipboard or drag and drop inserts only placeholder -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148526] LibreOffice Draw | PDF file displayed incorrectly | Visual elements missing
https://bugs.documentfoundation.org/show_bug.cgi?id=148526 Hossein changed: What|Removed |Added Version|7.3.2.2 release |3.5.0 release Hardware|x86-64 (AMD64) |All OS|Linux (All) |All --- Comment #4 from Hossein --- The bug is reproducible in LibreOffice 6.4: Version: 6.4.0.1 Build ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded In LibreOffice 3.5, the obstructing circle is there, but it is black. The PDF is load very slowly and make the application unresponsive: LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 I'm setting the first affected version to LibreOffice 3.5. The same problem is visible in Windows. Version: 7.2.4.1 (x64) / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 32; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148601] error en la interfaz desde la 7.0
https://bugs.documentfoundation.org/show_bug.cgi?id=148601 Michael FA changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148526] LibreOffice Draw | PDF file displayed incorrectly | Visual elements missing
https://bugs.documentfoundation.org/show_bug.cgi?id=148526 Hossein changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Hossein --- (In reply to flywire from comment #2) > Confirmed > > Version: 7.3.2.2 (x64) / LibreOffice Community > Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 > CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: > win > Locale: en-AU (en_AU); UI: en-GB > Calc: threaded @flywire: Please also set the bug status to: NEW Also confirmed in the latest LibreOffice 7.4 master: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: b0f24ca516e13c86d410960788ed6df3efe367b2 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148420] imported scans went white after calling export to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=148420 Rikkit changed: What|Removed |Added Whiteboard| QA:needsComment| QA:needsComment Rikkit: ||Do you need additional ||informations from me? If ||yes please specify what you ||need from me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148715] undo error
https://bugs.documentfoundation.org/show_bug.cgi?id=148715 --- Comment #2 from mustafa --- Created attachment 179717 --> https://bugs.documentfoundation.org/attachment.cgi?id=179717=edit test file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148715] undo error
https://bugs.documentfoundation.org/show_bug.cgi?id=148715 --- Comment #1 from mustafa --- Created attachment 179716 --> https://bugs.documentfoundation.org/attachment.cgi?id=179716=edit video -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148715] New: undo error
https://bugs.documentfoundation.org/show_bug.cgi?id=148715 Bug ID: 148715 Summary: undo error Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bkel...@gmail.com Description: Description: Every now and then I see an error in undoing the drawing. This error does not always occur. Undo doesn't work when I draw. so it doesn't get old. I could hardly identify when the error came. rarely occurs. The version I use: Version: 7.3.2.2 LibreOffice Writer Actual Results: it doesn't get old. Expected Results: erorr Reproducible: Always User Profile Reset: Yes Additional Info: sorry i get this error from time to time. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table1.cxx |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) New commits: commit 1768d5705dc72328ae2369fac7fc82437fef4ae1 Author: Luboš Luňák AuthorDate: Thu Apr 21 21:03:59 2022 +0200 Commit: Luboš Luňák CommitDate: Thu Apr 21 22:08:35 2022 +0200 simply return from a loop Change-Id: I4e10945f32dfb535663ea7392f19532e45ca9ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133301 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx index e82fdf9d4cfd..e864bd23974f 100644 --- a/sc/source/core/data/table1.cxx +++ b/sc/source/core/data/table1.cxx @@ -1234,11 +1234,10 @@ bool ScTable::IsEmptyLine( SCROW nRow, SCCOL nStartCol, SCCOL nEndCol ) const nEndCol = std::min( nEndCol, aCol.size()-1 ); -bool bFound = false; -for (SCCOL i=nStartCol; i<=nEndCol && !bFound; i++) +for (SCCOL i=nStartCol; i<=nEndCol; i++) if (aCol[i].HasDataAt(nRow)) -bFound = true; -return !bFound; +return false; +return true; } void ScTable::LimitChartArea( SCCOL& rStartCol, SCROW& rStartRow, SCCOL& rEndCol, SCROW& rEndRow ) const
[Libreoffice-bugs] [Bug 148707] Multiple V or B commands are not rendered ODF conform
https://bugs.documentfoundation.org/show_bug.cgi?id=148707 Regina Henschel changed: What|Removed |Added Depends on||148714 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148714 [Bug 148714] shapes of type "curved*Arrow" use wrong commands it is segments definition -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148714] New: shapes of type "curved*Arrow" use wrong commands it is segments definition
https://bugs.documentfoundation.org/show_bug.cgi?id=148714 Bug ID: 148714 Summary: shapes of type "curved*Arrow" use wrong commands it is segments definition Product: LibreOffice Version: Inherited From OOo Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Blocks: 148707 Created attachment 179715 --> https://bugs.documentfoundation.org/attachment.cgi?id=179715=edit Problematic shapes and a description of the problem The attached document contains on the first slide the shapes "curvedDownArrow", "curvedUpArrow", "curvedRightArrow" and "CurvedLeftArrow". These shapes are available in binary MS Office and here import from a ppt file. Open the document in PowerPoint or Scribus, for example. They show, what LO is actually writing to file. The rendering in LO does not reflect this because of bug 148707. The geometry for these shapes need to be repaired, before bug 148707 can be fixed. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148707 [Bug 148707] Multiple V or B commands are not rendered ODF conform -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 74331] 16bit "Photometric Interpretation: min-is-black" tiff not loaded correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=74331 Julien Nabet changed: What|Removed |Added Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free ||desktop.org Status|ASSIGNED|NEW CC||serval2...@yahoo.fr --- Comment #15 from Julien Nabet --- I abandoned my patch since there was a regression on tdf#115863 (black and white are reversed) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source
desktop/source/lib/init.cxx | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
New commits:
commit 92db31fa44040706d627fb5cafe6b0e2641b0bec
Author: Tor Lillqvist
AuthorDate: Tue Apr 19 16:40:11 2022 +0300
Commit: Tor Lillqvist
CommitDate: Thu Apr 21 21:19:41 2022 +0200
Fix regression in the iOS app (and possibly the Android and GTK apps)
The problem was caused by my remote font downloading changes. We need
to be more careful in lo_initialize() and libreofficekit_hook_2() to
distinguish whether the code is called from "normal" Online (with
"pre-initialisation" through lok_preinit_2()) or otherwise, for
instance the iOS app (where pre-initialisation is not done).
Sadly, this fix makes state handling in init.cxx even more complex
with one more static Boolean flag.
Change-Id: I2a8fa96740eb79725aa162cf7adc86d49a8ba603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133181
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Tor Lillqvist
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 6ab245c55d35..df5f67ad3c2b 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -200,6 +200,7 @@ using namespace desktop;
using namespace utl;
static LibLibreOffice_Impl *gImpl = nullptr;
+static bool lok_preinit_2_called = false;
static std::weak_ptr< LibreOfficeKitClass > gOfficeClass;
static std::weak_ptr< LibreOfficeKitDocumentClass > gDocumentClass;
@@ -6500,8 +6501,11 @@ static int lo_initialize(LibreOfficeKit* pThis, const
char* pAppPath, const char
if (pThis == nullptr)
{
eStage = PRE_INIT;
-SAL_INFO("lok", "Create libreoffice object");
-gImpl = new LibLibreOffice_Impl();
+if (lok_preinit_2_called)
+{
+SAL_INFO("lok", "Create libreoffice object");
+gImpl = new LibLibreOffice_Impl();
+}
}
else if (bPreInited)
eStage = SECOND_INIT;
@@ -6788,10 +6792,16 @@ LibreOfficeKit *libreofficekit_hook_2(const char*
install_path, const char* user
{
static bool alreadyCalled = false;
-if (!alreadyCalled)
+if ((!lok_preinit_2_called && !gImpl) || (lok_preinit_2_called &&
!alreadyCalled))
{
alreadyCalled = true;
+if (!lok_preinit_2_called)
+{
+SAL_INFO("lok", "Create libreoffice object");
+gImpl = new LibLibreOffice_Impl();
+}
+
if (!lo_initialize(gImpl, install_path, user_profile_url))
{
lo_destroy(gImpl);
@@ -6815,6 +6825,7 @@ int lok_preinit(const char* install_path, const char*
user_profile_url)
SAL_JNI_EXPORT
int lok_preinit_2(const char* install_path, const char* user_profile_url,
LibLibreOffice_Impl** kit)
{
+lok_preinit_2_called = true;
int result = lo_initialize(nullptr, install_path, user_profile_url);
if (kit != nullptr)
*kit = gImpl;
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table1.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9ec0395a0666ce07871b945dcb9a741d2237103b
Author: Luboš Luňák
AuthorDate: Thu Apr 21 19:54:53 2022 +0200
Commit: Luboš Luňák
CommitDate: Thu Apr 21 21:07:50 2022 +0200
fix off-by-one error
Change-Id: Ic58a896a7a2edf5ba602ab9cfc5a4578fd5d0a56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133296
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 1d8a072a0635..e82fdf9d4cfd 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -318,7 +318,7 @@ ScTable::~ScTable() COVERITY_NOEXCEPT_FALSE
{
if (!rDocument.IsInDtorClear())
{
-for (SCCOL nCol = 0; nCol < (aCol.size() - 1); ++nCol)
+for (SCCOL nCol = 0; nCol < aCol.size(); ++nCol)
{
aCol[nCol].FreeNotes();
}
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/document.hxx |6 +
sc/inc/table.hxx | 17 --
sc/source/core/data/documen4.cxx |2 -
sc/source/core/data/document.cxx | 24 +++-
sc/source/core/data/table1.cxx | 45 ---
sc/source/core/data/table2.cxx |2 -
sc/source/core/data/table3.cxx |4 +--
sc/source/core/data/table7.cxx |2 -
sc/source/filter/dif/difimp.cxx |2 -
sc/source/ui/unoobj/docuno.cxx |2 -
10 files changed, 65 insertions(+), 41 deletions(-)
New commits:
commit 4dfdb5a3c9b9ce1eb61c28d8f570398c04fb0d01
Author: Luboš Luňák
AuthorDate: Thu Apr 21 19:11:38 2022 +0200
Commit: Luboš Luňák
CommitDate: Thu Apr 21 21:07:25 2022 +0200
rework GetColumnsRange() and ScColumnsRange
The problem with GetColumnsRange() was that it was clamping the range
to the number of allocated columns, but that's not always wanted,
e.g. ScDocument::InsertMatrixFormula() needs to iterate over the whole
range and allocate columns if necessary instead of ignoring them.
From an API point of view it's also not very obvious that something
called GetColumnsRange() actually does something more than just
returning the given range.
Handle this by making GetColumnsRange() return the actual given range,
and add GetWriteableColumnsRange() and GetAllocatedColumnsRange()
for the specific cases. This also required changing ScColumnsRange
to work simply on SCCOL value instead of using std::vector iterator
(since the vector may not have all the elements in the range).
Change-Id: I9b645459461efe6b282e8ac5d7a29549830f46c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133295
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 26e43c046164..d24f4f170239 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -2607,6 +2607,12 @@ public:
voidfinalizeOutlineImport();
boolTableExists( SCTAB nTab ) const;
+// Returns the given column range, first allocating all the columns if
necessary.
+SC_DLLPUBLIC ScColumnsRange GetWritableColumnsRange(SCTAB nTab, SCCOL
nColBegin, SCCOL nColEnd);
+// Returns a column range, clamped to the allocated columns.
+SC_DLLPUBLIC ScColumnsRange GetAllocatedColumnsRange(SCTAB nTab, SCCOL
nColBegin, SCCOL nColEnd) const;
+// Returns the given range, without any adjustments. One of the variants
above may return
+// a smaller range (better performance) if the use case is known.
SC_DLLPUBLIC ScColumnsRange GetColumnsRange(SCTAB nTab, SCCOL nColBegin,
SCCOL nColEnd) const;
bool IsInDocShellRecalc() const { return mbDocShellRecalc; }
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 36ff984ed8fa..ba8ed9e328d8 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -123,7 +123,7 @@ class ScColumnsRange final
public:
class Iterator final
{
-std::vector>>::const_iterator maColIter;
+SCCOL mCol;
public:
typedef std::bidirectional_iterator_tag iterator_category;
typedef SCCOL value_type;
@@ -131,17 +131,18 @@ class ScColumnsRange final
typedef const SCCOL* pointer;
typedef SCCOL reference;
-explicit Iterator(const std::vector>>::const_iterator& colIter) : maColIter(colIter)
{}
+explicit Iterator(SCCOL nCol) : mCol(nCol) {}
-Iterator& operator++() { ++maColIter; return *this;}
-Iterator& operator--() { --maColIter; return *this;}
+Iterator& operator++() { ++mCol; return *this;}
+Iterator& operator--() { --mCol; return *this;}
-bool operator==(const Iterator & rOther) const {return maColIter ==
rOther.maColIter;}
+// Comparing iterators from different containers is undefined, so
comparing mCol is enough.
+bool operator==(const Iterator & rOther) const {return mCol ==
rOther.mCol;}
bool operator!=(const Iterator & rOther) const {return !(*this ==
rOther);}
-SCCOL operator*() const {return (*maColIter)->GetCol();}
+SCCOL operator*() const {return mCol;}
};
-ScColumnsRange(const Iterator & rBegin, const Iterator & rEnd) :
maBegin(rBegin), maEnd(rEnd) {}
+ScColumnsRange(SCCOL nBegin, SCCOL nEnd) : maBegin(nBegin), maEnd(nEnd) {}
const Iterator & begin() { return maBegin; }
const Iterator & end() { return maEnd; }
std::reverse_iterator rbegin() { return
std::reverse_iterator(maEnd); }
@@ -1114,6 +1115,8 @@ public:
*/
static void UpdateSearchItemAddressForReplace( const SvxSearchItem&
rSearchItem, SCCOL& rCol, SCROW& rRow );
+ScColumnsRange GetWritableColumnsRange(SCCOL begin, SCCOL end);
+ScColumnsRange GetAllocatedColumnsRange(SCCOL begin, SCCOL end) const;
ScColumnsRange GetColumnsRange(SCCOL begin, SCCOL end) const;
SCCOL ClampToAllocatedColumns(SCCOL
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |5
-
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit b68821acc77c774c09ebca8be157a768ea417e04
Author: Michael Weghorn
AuthorDate: Thu Apr 21 17:01:55 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 21:01:37 2022 +0200
android: Show file chooser despite package visibility filtering in API 30
While it was working just fine in my x86_64 AVD with API level 31,
opening the the file chooser on a real HW aarch64 device running
Android 12 no longer worked by tapping on the TextView in
`LibreOfficeUIActivity` after updating target API from 28
to 31 in
commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
Date: Tue Apr 19 10:33:27 2022 +0200
android: Update compileSdkVersion/targetSdkVersion to 31
The
intent.resolveActivity(getPackageManager()) != null
check was failing there, so the Activity with
`Intent.ACTION_OPEN_DOCUMENT` wasn't started there.
This looks like an issue due to package visibility filtering
introduced in target API level 30. Quoting from [1]:
> When an app targets Android 11 (API level 30) or higher and queries for
> information about the other apps that are installed on a device, the
> system filters this information by default. The limited package
> visibility reduces the number of apps that appear to be installed on a
> device, from your app's perspective.
>
> [...]
>
> The limited app visibility affects the return results of methods that
> give information about other apps, such as queryIntentActivities(),
> getPackageInfo(), and getInstalledApplications(). The limited
> visibility also affects explicit interactions with other apps, such
> as starting another app's service.
From how I understand it, the check is used to make sure that
there is an app that can handle the Intent, as e.g. the
"Android fundamentals 02.3: Implicit intents" tutorial [2]
mentions it for the example using an `Intent.ACTION_VIEW`:
> Use the resolveActivity() method and the Android package manager to find
> an Activity that can handle your implicit Intent. Make sure that the
> request resolved successfully.
>
> if (intent.resolveActivity(getPackageManager()) != null) {
> }
>
> This request matches your Intent action and data with the Intent filters
> for installed apps on the device. You use it to make sure there is at
> least one Activity that can handle your requests.
While that sounds reasonable to make sure there is an app that can
view specific data passed *from* the app (and [3] describes how to add
a corresponding `` element to make this use case work),
it seems to be unnecessary for `Intent.ACTION_OPEN_DOCUMENT`,
since that causes the system to "display the various DocumentsProvider
instances installed on the device, letting the user navigate through
them" and Android presumably at least provides a provider for
handling local files by itself in any case.
The `Intent.ACTION_GET_CONTENT` case used instead of
`Intent.ACTION_OPEN_DOCUMENT` for API level < 19 should
presumably be similar.
Anyway, in case there should still be any case where the
Intent cannot be handled:
`startActivityForResult` "throws ActivityNotFoundException if there was
no Activity found to run the given Intent." [4], so add
a try-catch block handling that exception instead of the previous
check.
[1] https://developer.android.com/training/package-visibility
[2]
https://developer.android.com/codelabs/android-training-activity-with-implicit-intent?index=..%2F..android-training#3
[3]
https://developer.android.com/training/package-visibility/use-cases#open-a-file
[4]
https://developer.android.com/reference/android/app/Activity#startActivityForResult(android.content.Intent,%20int)
Change-Id: I7702b100d71333be2d78df1bc81ef2e5a7e016bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133272
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 16e0fe8af2cd..965639e6e2ba 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -10,6 +10,7 @@
package org.libreoffice.ui;
import android.Manifest;
+import android.content.ActivityNotFoundException;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
@@ -268,8 +269,10 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
intent.setType("*/*");
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit b68362b178f732f90fdc99073aaa5940bee409bb
Author: Michael Weghorn
AuthorDate: Thu Apr 21 16:34:03 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 21:01:05 2022 +0200
android: Slightly improve style in use of arrays
Addresses these warnings shown in Android Studio
for class `LibreOfficeUIActivity`:
* "Unnecessary 'Arrays.asList()' call"
* "Raw use of parameterized class 'ArrayList'"
* "Explicit type argument ShortcutInfo can be replaced with <>"
Change-Id: I083e5fcf804209fae704b19643ce80bc92126ca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133271
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 1f7292b2a538..16e0fe8af2cd 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -197,9 +197,9 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
SharedPreferences prefs = getSharedPreferences(EXPLORER_PREFS_KEY,
MODE_PRIVATE);
String recentPref = prefs.getString(RECENT_DOCUMENTS_KEY, "");
-List recentFileStrings =
Arrays.asList(recentPref.split(RECENT_DOCUMENTS_DELIMITER));
+String[] recentFileStrings =
recentPref.split(RECENT_DOCUMENTS_DELIMITER);
-final List recentFiles = new ArrayList();
+final List recentFiles = new ArrayList<>();
for (String recentFileString : recentFileStrings) {
Uri uri = Uri.parse(recentFileString);
String filename =
FileUtilities.retrieveDisplayNameForDocumentUri(getContentResolver(), uri);
@@ -364,7 +364,7 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
getContentResolver().takePersistableUriPermission(fileUri,
Intent.FLAG_GRANT_READ_URI_PERMISSION | Intent.FLAG_GRANT_WRITE_URI_PERMISSION);
String newRecent = fileUri.toString();
-List recentsList = new
ArrayList(Arrays.asList(prefs.getString(RECENT_DOCUMENTS_KEY,
"").split(RECENT_DOCUMENTS_DELIMITER)));
+List recentsList = new
ArrayList<>(Arrays.asList(prefs.getString(RECENT_DOCUMENTS_KEY,
"").split(RECENT_DOCUMENTS_DELIMITER)));
// remove string if present, so that it doesn't appear multiple times
recentsList.remove(newRecent);
@@ -393,7 +393,7 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
//Remove all shortcuts, and apply new ones.
shortcutManager.removeAllDynamicShortcuts();
-ArrayList shortcuts = new ArrayList();
+ArrayList shortcuts = new ArrayList<>();
for (String recentDoc : recentsList) {
Uri docUri = Uri.parse(recentDoc);
String filename =
FileUtilities.retrieveDisplayNameForDocumentUri(getContentResolver(), docUri);
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |3
+--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 6515633aad867dd9e2d59378f3254e292dbdacb0
Author: Michael Weghorn
AuthorDate: Thu Apr 21 15:54:55 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 21:00:29 2022 +0200
android: Drop unused import and extra semicolon
Change-Id: I19557b0b1d63698a31dac61ce9fde3ce07f86451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133267
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 3b7b401804b8..1f7292b2a538 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -10,7 +10,6 @@
package org.libreoffice.ui;
import android.Manifest;
-import android.content.ActivityNotFoundException;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
@@ -267,7 +266,7 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
}
intent.setType("*/*");
-intent.putExtra(Intent.EXTRA_MIME_TYPES, SUPPORTED_MIME_TYPES);;
+intent.putExtra(Intent.EXTRA_MIME_TYPES, SUPPORTED_MIME_TYPES);
if (intent.resolveActivity(getPackageManager()) != null) {
startActivityForResult(intent, REQUEST_CODE_OPEN_FILECHOOSER);
[Libreoffice-commits] core.git: android/source
android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java | 74
--
1 file changed, 33 insertions(+), 41 deletions(-)
New commits:
commit 62524dcf152b274b855005402d082debaa3fc84a
Author: Michael Weghorn
AuthorDate: Thu Apr 21 15:52:54 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 20:59:56 2022 +0200
android: Avoid using resource ID in switch-case
Adresses this warning shown in Android Studio:
> Resource IDs will be non-final by default in Android Gradle Plugin
> version 8.0, avoid using them in switch case statements
Change-Id: I8cead0ceb3b71e263b29d4283a8cfac522ed4204
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133266
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index f2e366c90ed3..3b7b401804b8 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -318,19 +318,18 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
@Override
public boolean onOptionsItemSelected(MenuItem item) {
-switch (item.getItemId()) {
-case R.id.action_about: {
-AboutDialogFragment aboutDialogFragment = new
AboutDialogFragment();
-aboutDialogFragment.show(getSupportFragmentManager(),
"AboutDialogFragment");
-}
-return true;
-case R.id.action_settings:
-startActivity(new Intent(getApplicationContext(),
SettingsActivity.class));
-return true;
-
-default:
-return super.onOptionsItemSelected(item);
+final int itemId = item.getItemId();
+if (itemId == R.id.action_about) {
+AboutDialogFragment aboutDialogFragment = new
AboutDialogFragment();
+aboutDialogFragment.show(getSupportFragmentManager(),
"AboutDialogFragment");
+return true;
}
+if (itemId == R.id.action_settings) {
+startActivity(new Intent(getApplicationContext(),
SettingsActivity.class));
+return true;
+}
+
+return super.onOptionsItemSelected(item);
}
public void readPreferences(){
@@ -441,35 +440,28 @@ public class LibreOfficeUIActivity extends
AppCompatActivity implements Settings
@Override
public void onClick(View v) {
int id = v.getId();
-switch (id){
-case R.id.editFAB:
-// Intent.ACTION_CREATE_DOCUMENT, used in
'createNewFileDialog' requires SDK version 19
-if (Build.VERSION.SDK_INT < 19) {
-Toast.makeText(this,
-getString(R.string.creating_new_files_not_supported),
Toast.LENGTH_SHORT).show();
-return;
-}
-if (isFabMenuOpen) {
-collapseFabMenu();
-} else {
-expandFabMenu();
-}
-break;
-case R.id.open_file_view:
-showSystemFilePickerAndOpenFile();
-break;
-case R.id.newWriterFAB:
-loadNewDocument(DocumentType.WRITER);
-break;
-case R.id.newImpressFAB:
-loadNewDocument(DocumentType.IMPRESS);
-break;
-case R.id.newCalcFAB:
-loadNewDocument(DocumentType.CALC);
-break;
-case R.id.newDrawFAB:
-loadNewDocument(DocumentType.DRAW);
-break;
+if (id == R.id.editFAB) {
+// Intent.ACTION_CREATE_DOCUMENT, used in 'createNewFileDialog'
requires SDK version 19
+if (Build.VERSION.SDK_INT < 19) {
+Toast.makeText(this,
+getString(R.string.creating_new_files_not_supported),
Toast.LENGTH_SHORT).show();
+return;
+}
+if (isFabMenuOpen) {
+collapseFabMenu();
+} else {
+expandFabMenu();
+}
+} else if (id == R.id.open_file_view) {
+showSystemFilePickerAndOpenFile();
+} else if (id == R.id.newWriterFAB) {
+loadNewDocument(DocumentType.WRITER);
+} else if (id == R.id.newImpressFAB) {
+loadNewDocument(DocumentType.IMPRESS);
+} else if (id == R.id.newCalcFAB) {
+loadNewDocument(DocumentType.CALC);
+} else if (id == R.id.newDrawFAB) {
+loadNewDocument(DocumentType.DRAW);
}
}
}
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/exc_thrower.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit a03d7b1871673473b6201a8a15be175d7b65d71d Author: Michael Weghorn AuthorDate: Thu Apr 21 14:26:18 2022 +0200 Commit: Michael Weghorn CommitDate: Thu Apr 21 20:59:05 2022 +0200 android: Use fake exceptions on all architectures This was previously only used for aarch64, and the workaround does not seem to be necessary in current Android versions on other architectures. However, while it's e.g. not needed on an x86 AVD with API level 21 (Android 5), at least my x86 AVD with API level 16 (Android 4.1), which is currently our `minSdkVersion`, fails otherwise when trying to open any document with the below in the ADB log. With this (and all the previous fixes for low API/SDK levels) in place, opening a document in Android Viewer finally succeeds there. > F/libc( 3288): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 3310 (Thread-122) > I/stderr ( 3288): terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException > I/stderr ( 3288): assertion "terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException" failed: file "/usr/local/google/buildbot/src/android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp", line 73, function "abort_message" > I/DEBUG ( 1173): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** > I/DEBUG ( 1173): Build fingerprint: 'generic_x86/sdk_x86/generic_x86:4.1.2/MASTER/eng.wdu.20191218.182616:eng/test-keys' > I/DEBUG ( 1173): pid: 3288, tid: 3310, name: Thread-122 >>> org.libreoffice <<< > I/DEBUG ( 1173): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr deadbaad > I/DEBUG ( 1173): eax ebx b76c9f4c ecx edx b76cbfd4 > I/DEBUG ( 1173): esi b65ed000 edi 788c7d6c > I/DEBUG ( 1173): xcs 0073 xds 007b xes 007b xfs xss 007b > I/DEBUG ( 1173): eip b7661c03 ebp 788c7d88 esp 788c7d40 flags 00210246 > I/DEBUG ( 1173): > I/DEBUG ( 1173): backtrace: > I/DEBUG ( 1173): #00 pc 00021c03 /system/lib/libc.so (abort+131) > I/DEBUG ( 1173): #01 pc 00030ff1 /system/lib/libc.so > I/DEBUG ( 1173): #02 pc 0e137175 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #03 pc 0e1372f5 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #04 pc 0e133d0a /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #05 pc 0e13323f /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #06 pc 0e133194 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #07 pc 0d369737 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #08 pc 0d3673b0 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #09 pc 0d366a7b /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #10 pc 0d377a25 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #11 pc 09a2b944 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #12 pc 098826da /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #13 pc 098cc47c /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #14 pc 098ded29 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #15 pc 098bb839 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #16 pc 098b7e23 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #17 pc 098bb8cf /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #18 pc 0987a677 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #19 pc 0987b7c7 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #20 pc 0987ab4b /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #21 pc 0987a9a7 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #22 pc 0987f90b /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #23 pc 0986d4ff /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #24 pc 09872298 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #25 pc 035625cf /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #26 pc 0355dff2 /data/data/org.libreoffice/lib/liblo-native-code.so > I/DEBUG ( 1173): #27 pc 035713f9
[Libreoffice-commits] core.git: android/Bootstrap
android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java |1 +
1 file changed, 1 insertion(+)
New commits:
commit 7084da45dd322c253626c3576aef53ae021fdcdf
Author: Michael Weghorn
AuthorDate: Thu Apr 21 14:16:30 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 20:57:55 2022 +0200
android: Explicitly load libc++_shared
While it works just fine without that in newer
Android versions, trying to open any doc in an
x86 AVD with API level 16 failed like this:
> E/AndroidRuntime( 2999): java.lang.ExceptionInInitializerError
> E/AndroidRuntime( 2999):at
org.libreoffice.TileProviderFactory.initialize(TileProviderFactory.java:23)
> E/AndroidRuntime( 2999):at
org.libreoffice.LOKitThread.(LOKitThread.java:39)
> E/AndroidRuntime( 2999):at
org.libreoffice.LibreOfficeMainActivity.onCreate(LibreOfficeMainActivity.java:149)
> E/AndroidRuntime( 2999):at
android.app.Activity.performCreate(Activity.java:5008)
> E/AndroidRuntime( 2999):at
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
> E/AndroidRuntime( 2999):at
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
> E/AndroidRuntime( 2999):at
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
> E/AndroidRuntime( 2999):at
android.app.ActivityThread.access$600(ActivityThread.java:130)
> E/AndroidRuntime( 2999):at
android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
> E/AndroidRuntime( 2999):at
android.os.Handler.dispatchMessage(Handler.java:99)
> E/AndroidRuntime( 2999):at android.os.Looper.loop(Looper.java:137)
> E/AndroidRuntime( 2999):at
android.app.ActivityThread.main(ActivityThread.java:4745)
> E/AndroidRuntime( 2999):at
java.lang.reflect.Method.invokeNative(Native Method)
> E/AndroidRuntime( 2999):at
java.lang.reflect.Method.invoke(Method.java:511)
> E/AndroidRuntime( 2999):at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
> E/AndroidRuntime( 2999):at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
> E/AndroidRuntime( 2999):at dalvik.system.NativeStart.main(Native
Method)
> E/AndroidRuntime( 2999): Caused by: java.lang.UnsatisfiedLinkError:
Cannot load library: link_image[1891]: 1176 could not load needed library
'libc++_shared.so' for 'liblo-native-code.so' (load_library[1093]: Library
'libc++_shared.so' not found)
> E/AndroidRuntime( 2999):at
java.lang.Runtime.loadLibrary(Runtime.java:370)
> E/AndroidRuntime( 2999):at
java.lang.System.loadLibrary(System.java:535)
> E/AndroidRuntime( 2999):at
org.libreoffice.kit.NativeLibLoader.load(LibreOfficeKit.java:105)
> E/AndroidRuntime( 2999):at
org.libreoffice.kit.LibreOfficeKit.(LibreOfficeKit.java:82)
> E/AndroidRuntime( 2999):... 17 more
> W/ActivityManager( 1421): Force finishing activity
org.libreoffice/.LibreOfficeMainActivity
> W/ActivityManager( 1421): Force finishing activity
org.libreoffice/.ui.LibreOfficeUIActivity
Change-Id: I6e383e624b9e66c0daa9ecfda4a3b176c8fa0d94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133263
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java
b/android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java
index f6658d64806a..f7597c29a86c 100644
--- a/android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java
+++ b/android/Bootstrap/src/org/libreoffice/kit/LibreOfficeKit.java
@@ -102,6 +102,7 @@ class NativeLibLoader {
System.loadLibrary("smime3");
System.loadLibrary("ssl3");
+System.loadLibrary("c++_shared");
System.loadLibrary("lo-native-code");
done = true;
}
[Libreoffice-commits] core.git: android/source
android/source/res/layout/activity_document_browser.xml |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 730add0ca619985b99e133dd586e063f0f12538b
Author: Michael Weghorn
AuthorDate: Thu Apr 21 13:48:53 2022 +0200
Commit: Michael Weghorn
CommitDate: Thu Apr 21 20:57:21 2022 +0200
android: Use drawable tag already supported with API level 16
Use the `app:drawableLeftCompat` tag instead of
`android:drawableLeft` to set the icon to show
in the TextView.
With the latter, trying to start Android Viewer
in an x86 AVD with API level 16 resulted in this
crash:
> E/AndroidRuntime( 2510): java.lang.RuntimeException: Unable to start
activity
ComponentInfo{org.libreoffice/org.libreoffice.ui.LibreOfficeUIActivity}:
android.view.InflateException: Binary XML file line #80: Error inflating class
TextView
> E/AndroidRuntime( 2510):at
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2059)
> E/AndroidRuntime( 2510):at
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
> E/AndroidRuntime( 2510):at
android.app.ActivityThread.access$600(ActivityThread.java:130)
> E/AndroidRuntime( 2510):at
android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
> E/AndroidRuntime( 2510):at
android.os.Handler.dispatchMessage(Handler.java:99)
> E/AndroidRuntime( 2510):at android.os.Looper.loop(Looper.java:137)
> E/AndroidRuntime( 2510):at
android.app.ActivityThread.main(ActivityThread.java:4745)
> E/AndroidRuntime( 2510):at
java.lang.reflect.Method.invokeNative(Native Method)
> E/AndroidRuntime( 2510):at
java.lang.reflect.Method.invoke(Method.java:511)
> E/AndroidRuntime( 2510):at
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
> E/AndroidRuntime( 2510):at
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
> E/AndroidRuntime( 2510):at dalvik.system.NativeStart.main(Native
Method)
> E/AndroidRuntime( 2510): Caused by: android.view.InflateException: Binary
XML file line #80: Error inflating class TextView
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:704)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.rInflate(LayoutInflater.java:746)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.inflate(LayoutInflater.java:489)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.inflate(LayoutInflater.java:396)
> E/AndroidRuntime( 2510):at
android.view.LayoutInflater.inflate(LayoutInflater.java:352)
> E/AndroidRuntime( 2510):at
androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:696)
> E/AndroidRuntime( 2510):at
androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:170)
> E/AndroidRuntime( 2510):at
org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:169)
> E/AndroidRuntime( 2510):at
org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147)
> E/AndroidRuntime( 2510):at
android.app.Activity.performCreate(Activity.java:5008)
> E/AndroidRuntime( 2510):at
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
> E/AndroidRuntime( 2510):at
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
> E/AndroidRuntime( 2510):... 11 more
> E/AndroidRuntime( 2510): Caused by:
android.content.res.Resources$NotFoundException: File
res/drawable-hdpi-v4/ic_folder_grey_48dp.xml from drawable resource ID
#0x7f080083
> E/AndroidRuntime( 2510):at
android.content.res.Resources.loadDrawable(Resources.java:1923)
> E/AndroidRuntime( 2510):at
android.content.res.TypedArray.getDrawable(TypedArray.java:601)
> E/AndroidRuntime( 2510):at
android.widget.TextView.(TextView.java:614)
> E/AndroidRuntime( 2510):at
androidx.appcompat.widget.AppCompatTextView.(AppCompatTextView.java:100)
> E/AndroidRuntime( 2510):at
androidx.appcompat.widget.AppCompatTextView.(AppCompatTextView.java:95)
> E/AndroidRuntime( 2510):at
androidx.appcompat.app.AppCompatViewInflater.createTextView(AppCompatViewInflater.java:194)
> E/AndroidRuntime( 2510):at
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/redundantfcast.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 427188600ffe31d142ca6d0e1d549e3c1c4246b8
Author: Andrea Gelmini
AuthorDate: Thu Apr 21 20:19:03 2022 +0200
Commit: Julien Nabet
CommitDate: Thu Apr 21 20:55:53 2022 +0200
Fix typo
Change-Id: I0444ed42636e464b59758545155e11e9c13a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133298
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/compilerplugins/clang/redundantfcast.cxx
b/compilerplugins/clang/redundantfcast.cxx
index 1378d9eaf435..aed71e8783f9 100644
--- a/compilerplugins/clang/redundantfcast.cxx
+++ b/compilerplugins/clang/redundantfcast.cxx
@@ -335,7 +335,7 @@ public:
// tdf#145203: FIREBIRD cannot create a table
if (fn == SRCDIR
"/connectivity/source/drivers/firebird/DatabaseMetaData.cxx")
return false;
-// false positive during using contructor
drawinglayer::attribute::StrokeAttribute({ 3 * pw, pw })
+// false positive during using constructor
drawinglayer::attribute::StrokeAttribute({ 3 * pw, pw })
if (fn == SRCDIR "/drawinglayer/source/tools/emfppen.cxx")
return false;
return true;
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/source
sw/source/core/inc/layfrm.hxx |1 +
sw/source/core/layout/findfrm.cxx | 21 +
sw/source/core/layout/pagechg.cxx |2 ++
3 files changed, 24 insertions(+)
New commits:
commit 116b246e42a1c807e4e693bd020231a22f05abcd
Author: Michael Stahl
AuthorDate: Wed Apr 20 18:48:30 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Apr 21 20:49:26 2022 +0200
sw: layout: fix crash when deleting page with section being formatted
This crashes only when calling storeToURL() with writer_pdf_Export?
There is a text frame 112, followed by section frame 126, which contains
table frame 127.
The section frame 126 is being formatted, which in
SwFrame::PrepareMake() formats its prev, text frame 112.
This does MoveBwd() and in SwContentFrame::MakeAll() formats its next,
tab frame 127.
This also does MoveBwd() and then there is this really odd condition in
SwTabFrame::Paste() where it calls SwFrame::CheckPageDescs() if it
*doesn't* have a RES_PAGEDESC item and the page has a non-default page
style - this condition remains inexplicable since initial CVS import.
Then CheckPageDesc() sees the (next) page is empty and deletes it.
So check in sw::IsPageFrameEmpty() that there aren't any sections with
IsDeleteForbidden() set.
(regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
Change-Id: I3c64fe40fabffc255c4146a35c678ce6a1cc09c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133222
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 85aa57359befd7a21b3fdf36f2b362f50495f77c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133151
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/inc/layfrm.hxx b/sw/source/core/inc/layfrm.hxx
index 3f73602e6bfa..b0f981477499 100644
--- a/sw/source/core/inc/layfrm.hxx
+++ b/sw/source/core/inc/layfrm.hxx
@@ -100,6 +100,7 @@ public:
SwPrintData const*const pPrintData = nullptr ) const
override;
const SwFrame *Lower() const { return m_pLower; }
SwFrame *Lower() { return m_pLower; }
+bool ContainsDeleteForbiddenLayFrame() const;
const SwContentFrame *ContainsContent() const;
inline SwContentFrame *ContainsContent();
const SwCellFrame *FirstCell() const;
diff --git a/sw/source/core/layout/findfrm.cxx
b/sw/source/core/layout/findfrm.cxx
index 3696e2a02e0c..ea3f48982a72 100644
--- a/sw/source/core/layout/findfrm.cxx
+++ b/sw/source/core/layout/findfrm.cxx
@@ -162,6 +162,27 @@ const SwFrame *SwLayoutFrame::ContainsAny( const bool
_bInvestigateFootnoteForSe
return nullptr;
}
+bool SwLayoutFrame::ContainsDeleteForbiddenLayFrame() const
+{
+if (IsDeleteForbidden())
+{
+return true;
+}
+for (SwFrame const* pFrame = Lower(); pFrame; pFrame = pFrame->GetNext())
+{
+if (!pFrame->IsLayoutFrame())
+{
+continue;
+}
+SwLayoutFrame const*const pLay(static_cast(pFrame));
+if (pLay->ContainsDeleteForbiddenLayFrame())
+{
+return true;
+}
+}
+return false;
+}
+
const SwFrame* SwFrame::GetLower() const
{
return IsLayoutFrame() ? static_cast(this)->Lower()
: nullptr;
diff --git a/sw/source/core/layout/pagechg.cxx
b/sw/source/core/layout/pagechg.cxx
index e60e9440367b..1fe6d47b97c5 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1024,6 +1024,8 @@ bool IsPageFrameEmpty(SwPageFrame const& rPage)
rPage.FindFootnoteCont() ||
(nullptr != (pBody = rPage.FindBodyCont()) &&
( pBody->ContainsContent() ||
+ // check for section frames that are being formatted on the stack
+ rPage.ContainsDeleteForbiddenLayFrame() ||
// #i47580#
// Do not delete page if there's an empty tabframe
// left. I think it might be correct to use ContainsAny()
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/core/inc/layfrm.hxx |1 +
sw/source/core/layout/findfrm.cxx | 21 +
sw/source/core/layout/pagechg.cxx |2 ++
3 files changed, 24 insertions(+)
New commits:
commit af0955d600cd3d54d26a87b9ff30e3c402a226dd
Author: Michael Stahl
AuthorDate: Wed Apr 20 18:48:30 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Apr 21 20:48:52 2022 +0200
sw: layout: fix crash when deleting page with section being formatted
This crashes only when calling storeToURL() with writer_pdf_Export?
There is a text frame 112, followed by section frame 126, which contains
table frame 127.
The section frame 126 is being formatted, which in
SwFrame::PrepareMake() formats its prev, text frame 112.
This does MoveBwd() and in SwContentFrame::MakeAll() formats its next,
tab frame 127.
This also does MoveBwd() and then there is this really odd condition in
SwTabFrame::Paste() where it calls SwFrame::CheckPageDescs() if it
*doesn't* have a RES_PAGEDESC item and the page has a non-default page
style - this condition remains inexplicable since initial CVS import.
Then CheckPageDesc() sees the (next) page is empty and deletes it.
So check in sw::IsPageFrameEmpty() that there aren't any sections with
IsDeleteForbidden() set.
(regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
Change-Id: I3c64fe40fabffc255c4146a35c678ce6a1cc09c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133222
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 85aa57359befd7a21b3fdf36f2b362f50495f77c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133150
Reviewed-by: Xisco Fauli
diff --git a/sw/source/core/inc/layfrm.hxx b/sw/source/core/inc/layfrm.hxx
index 3f73602e6bfa..b0f981477499 100644
--- a/sw/source/core/inc/layfrm.hxx
+++ b/sw/source/core/inc/layfrm.hxx
@@ -100,6 +100,7 @@ public:
SwPrintData const*const pPrintData = nullptr ) const
override;
const SwFrame *Lower() const { return m_pLower; }
SwFrame *Lower() { return m_pLower; }
+bool ContainsDeleteForbiddenLayFrame() const;
const SwContentFrame *ContainsContent() const;
inline SwContentFrame *ContainsContent();
const SwCellFrame *FirstCell() const;
diff --git a/sw/source/core/layout/findfrm.cxx
b/sw/source/core/layout/findfrm.cxx
index d100e24526a4..3d92f2a9ce0e 100644
--- a/sw/source/core/layout/findfrm.cxx
+++ b/sw/source/core/layout/findfrm.cxx
@@ -165,6 +165,27 @@ const SwFrame *SwLayoutFrame::ContainsAny( const bool
_bInvestigateFootnoteForSe
return nullptr;
}
+bool SwLayoutFrame::ContainsDeleteForbiddenLayFrame() const
+{
+if (IsDeleteForbidden())
+{
+return true;
+}
+for (SwFrame const* pFrame = Lower(); pFrame; pFrame = pFrame->GetNext())
+{
+if (!pFrame->IsLayoutFrame())
+{
+continue;
+}
+SwLayoutFrame const*const pLay(static_cast(pFrame));
+if (pLay->ContainsDeleteForbiddenLayFrame())
+{
+return true;
+}
+}
+return false;
+}
+
const SwFrame* SwFrame::GetLower() const
{
return IsLayoutFrame() ? static_cast(this)->Lower()
: nullptr;
diff --git a/sw/source/core/layout/pagechg.cxx
b/sw/source/core/layout/pagechg.cxx
index fe84f956a35c..e7a458737d30 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1024,6 +1024,8 @@ bool IsPageFrameEmpty(SwPageFrame const& rPage)
rPage.FindFootnoteCont() ||
(nullptr != (pBody = rPage.FindBodyCont()) &&
( pBody->ContainsContent() ||
+ // check for section frames that are being formatted on the stack
+ rPage.ContainsDeleteForbiddenLayFrame() ||
// #i47580#
// Do not delete page if there's an empty tabframe
// left. I think it might be correct to use ContainsAny()
[Libreoffice-bugs] [Bug 148713] New: Unexpected table visible after redo table delete (and freezes when pressing delete column (track changes involved)
https://bugs.documentfoundation.org/show_bug.cgi?id=148713 Bug ID: 148713 Summary: Unexpected table visible after redo table delete (and freezes when pressing delete column (track changes involved) Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Unexpected table visible after redo table delete (and freezes when pressing delete column (track changes involved) Steps to Reproduce: 1. Open attachment 178724 2. Place cursor in the bottom row of the table 3. Press delete row until table is deleted 4. Press hold Undo 6. Press and hold redo until everything is deleted 7. Delete a table column of the spurious table row Related bug 148386 Actual Results: Freeze Expected Results: No table visible Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 85aa57359befd7a21b3fdf36f2b362f50495f77c CPU threads: 8; OS: Mac OS X 12.2.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basic/qa
basic/qa/cppunit/test_vba.cxx |1 +
basic/qa/vba_tests/formatpercent.vb | 31 +++
2 files changed, 32 insertions(+)
New commits:
commit 07bf0ce4e7f04a79910cbe1340264863451f1926
Author: Xisco Fauli
AuthorDate: Thu Apr 21 13:50:01 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Apr 21 19:52:16 2022 +0200
tdf#148651: basic_macros: Add unittest
Change-Id: Iadbe470de5a33dc633fe8f53083520988e497df0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133255
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/basic/qa/cppunit/test_vba.cxx b/basic/qa/cppunit/test_vba.cxx
index a420568f8b7c..68d9bbaf2570 100644
--- a/basic/qa/cppunit/test_vba.cxx
+++ b/basic/qa/cppunit/test_vba.cxx
@@ -94,6 +94,7 @@ void VBATest::testMiscVBAFunctions()
"hex.vb",
"hour.vb",
"formatnumber.vb",
+"formatpercent.vb",
"iif.vb",
"instr.vb",
"instrrev.vb",
diff --git a/basic/qa/vba_tests/formatpercent.vb
b/basic/qa/vba_tests/formatpercent.vb
new file mode 100644
index ..0a8c551c27f1
--- /dev/null
+++ b/basic/qa/vba_tests/formatpercent.vb
@@ -0,0 +1,31 @@
+'
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Option VBASupport 1
+Option Explicit
+
+Function doUnitTest() As String
+TestUtil.TestInit
+verify_testFormatPercent
+doUnitTest = TestUtil.GetResult()
+End Function
+
+Sub verify_testFormatPercent()
+On Error GoTo errorHandler
+
+TestUtil.AssertEqual(FormatPercent("12.2", 2, vbFalse, vbFalse, vbFalse),
"1220.00%","FormatPercent(""12.2"", 2, vbFalse,
vbFalse, vbFalse)")
+TestUtil.AssertEqual(FormatPercent("-.2", 2, vbTrue, vbFalse, vbFalse),
"-20.00%", "FormatPercent(""-.2"", 20, vbTrue,
vbFalse, vbFalse)")
+TestUtil.AssertEqual(FormatPercent("-0.2", 2, vbFalse, vbFalse, vbFalse),
"-20.00%", "FormatPercent(""-0.2"", 20, vbFalse,
vbFalse, vbFalse)")
+TestUtil.AssertEqual(FormatPercent("-0.2", -1, vbFalse, vbTrue, vbFalse),
"(20.00)%","FormatPercent(""-0.2"", -1, vbFalse,
vbTrue, vbFalse)")
+TestUtil.AssertEqual(FormatPercent("-0.2", -1, vbUseDefault, vbTrue,
vbFalse), "(20.00)%","FormatPercent(""-0.2"", -1,
vbUseDefault, vbTrue, vbFalse)")
+TestUtil.AssertEqual(FormatPercent("-12345678", -1, vbUseDefault,
vbUseDefault, vbTrue), "-1,234,567,800.00%", "FormatPercent(""-12345678"", -1,
vbUseDefault, vbUseDefault, vbTrue)")
+
+Exit Sub
+errorHandler:
+TestUtil.ReportErrorHandler("verify_testFormatPercent", Err, Error$, Erl)
+End Sub
[Libreoffice-bugs] [Bug 96474] It would be helpful to be able to search *only* within comments
https://bugs.documentfoundation.org/show_bug.cgi?id=96474 --- Comment #9 from Eyal Rozenberg --- @Heiko, it looks like you're arguing with yourself here... should we continue the discussion on this bug page? @Luke , sorry about not noticing your bug before filing mine. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148199] Table paragraph styles not fully applied
https://bugs.documentfoundation.org/show_bug.cgi?id=148199 --- Comment #5 from Eyal Rozenberg --- (In reply to Timur from comment #4) > Eyal, there are many bugs on same, I don't know if you search before > reporting. Actually, it would be easier if the meta bugs were more accessible, e.g. in a searchable list of just the meta-bug names -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 83671] Fileopen XLSX: SmartArt is not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=83671 --- Comment #14 from Jason Adams --- Even though Android devices usually have certain security measures, such as Play Store Protect, having an antivirus for your Android device is in your best interest. Google is not on the same level as, for example, Android when it comes to security updates. In addition, if your Android device is put into developer mode, the built-in security features are further reduced. So check out the best android antivirus app free: https://celltrackingapps.com/free-android-antivirus/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/inc vcl/qt5
vcl/inc/qt5/QtInstance.hxx |6 ++
vcl/inc/qt5/QtWidget.hxx |1 +
vcl/qt5/QtInstance.cxx |7 +++
vcl/qt5/QtWidget.cxx | 20
4 files changed, 30 insertions(+), 4 deletions(-)
New commits:
commit 06c51d61e4a16057f945effe85b1ff9457f8cffb
Author: Jan-Marek Glogowski
AuthorDate: Thu Apr 21 10:56:42 2022 +0200
Commit: Jan-Marek Glogowski
CommitDate: Thu Apr 21 18:57:05 2022 +0200
tdf#148699 Qt track the active / shown popup
I have no idea, if there can be multiple active popups in LO in
some way. There can be multiple FloatingWindow and gtk does count
them in m_nFloats... There is a whole lot going on in gtk3 related
to isFloatGrabWindow(), with "funny" comments like:
// FIXME: find out who the hell steals the focus from our frame
So this goes with some "optimistic" approach: there is just one
active popup, so we can track it in QtInstance. It WFM...
Change-Id: I9778587696e1ad9e641dba4f102e2e921266eee6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133249
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
(cherry picked from commit 347622a98f512dae709f938a85498dcdcf9f225a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133260
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/qt5/QtInstance.hxx b/vcl/inc/qt5/QtInstance.hxx
index 9a9853a7a2ce..fd111bb22abe 100644
--- a/vcl/inc/qt5/QtInstance.hxx
+++ b/vcl/inc/qt5/QtInstance.hxx
@@ -35,6 +35,7 @@
#include "QtFilePicker.hxx"
+class QtFrame;
class QtTimer;
class QApplication;
@@ -67,6 +68,8 @@ class VCLPLUG_QT_PUBLIC QtInstance : public QObject,
Timer m_aUpdateStyleTimer;
bool m_bUpdateFonts;
+QtFrame* m_pActivePopup;
+
DECL_DLLPRIVATE_LINK(updateStyleHdl, Timer*, void);
void AfterAppInit() override;
@@ -172,6 +175,9 @@ public:
void UpdateStyle(bool bFontsChanged);
void* CreateGStreamerSink(const SystemChildWindow*) override;
+
+QtFrame* activePopup() const { return m_pActivePopup; }
+void setActivePopup(QtFrame*);
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/qt5/QtWidget.hxx b/vcl/inc/qt5/QtWidget.hxx
index 4a40589b16ba..8f7f6cc319e1 100644
--- a/vcl/inc/qt5/QtWidget.hxx
+++ b/vcl/inc/qt5/QtWidget.hxx
@@ -73,6 +73,7 @@ class QtWidget : public QWidget
virtual void paintEvent(QPaintEvent*) override;
virtual void resizeEvent(QResizeEvent*) override;
virtual void showEvent(QShowEvent*) override;
+virtual void hideEvent(QHideEvent*) override;
virtual void wheelEvent(QWheelEvent*) override;
virtual void closeEvent(QCloseEvent*) override;
virtual void changeEvent(QEvent*) override;
diff --git a/vcl/qt5/QtInstance.cxx b/vcl/qt5/QtInstance.cxx
index d252109e122a..247001443020 100644
--- a/vcl/qt5/QtInstance.cxx
+++ b/vcl/qt5/QtInstance.cxx
@@ -223,6 +223,7 @@ QtInstance::QtInstance(std::unique_ptr&
pQApp, bool bUseCairo)
, m_pQApplication(std::move(pQApp))
, m_aUpdateStyleTimer("vcl::qt5 m_aUpdateStyleTimer")
, m_bUpdateFonts(false)
+, m_pActivePopup(nullptr)
{
ImplSVData* pSVData = ImplGetSVData();
const OUString sToolkit = "qt" + OUString::number(QT_VERSION_MAJOR);
@@ -722,6 +723,12 @@ std::unique_ptr
QtInstance::CreateQApplication(int& nArgc, char**
return pQApp;
}
+void QtInstance::setActivePopup(QtFrame* pFrame)
+{
+assert(!pFrame || pFrame->isPopup());
+m_pActivePopup = pFrame;
+}
+
extern "C" {
VCLPLUG_QT_PUBLIC SalInstance* create_SalInstance()
{
diff --git a/vcl/qt5/QtWidget.cxx b/vcl/qt5/QtWidget.cxx
index 5f07974600e8..8c545fd13377 100644
--- a/vcl/qt5/QtWidget.cxx
+++ b/vcl/qt5/QtWidget.cxx
@@ -317,9 +317,21 @@ void QtWidget::showEvent(QShowEvent*)
// sequence from QtFrame::SetModal, if the frame was already set visible,
// resulting in a hidden / unmapped window
SalPaintEvent aPaintEvt(0, 0, aSize.width(), aSize.height());
+if (m_rFrame.isPopup())
+{
+auto* pQtInst(static_cast(GetSalData()->m_pInstance));
+pQtInst->setActivePopup(_rFrame);
+}
m_rFrame.CallCallback(SalEvent::Paint, );
}
+void QtWidget::hideEvent(QHideEvent*)
+{
+auto* pQtInst(static_cast(GetSalData()->m_pInstance));
+if (m_rFrame.isPopup() && pQtInst->activePopup() == _rFrame)
+pQtInst->setActivePopup(nullptr);
+}
+
void QtWidget::closeEvent(QCloseEvent* /*pEvent*/)
{
m_rFrame.CallCallback(SalEvent::Close, nullptr);
@@ -627,11 +639,11 @@ bool QtWidget::handleEvent(QtFrame& rFrame, QWidget&
rWidget, QEvent* pEvent)
}
else if (pEvent->type() == QEvent::ToolTip)
{
-// Qt's POV on focus is wrong for our fake popup windows, so check
LO's state.
+// Qt's POV on the active popup is wrong due to our fake popup, so
check LO's state.
// Otherwise Qt will continue handling ToolTip events from the
"parent" window.
-const vcl::Window* pFocusWin =
[Libreoffice-bugs] [Bug 148699] kf5: No tooltips for shapes in Impress's "Basic Shapes" toolbar item (and others)
https://bugs.documentfoundation.org/show_bug.cgi?id=148699 --- Comment #4 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/06c51d61e4a16057f945effe85b1ff9457f8cffb tdf#148699 Qt track the active / shown popup It will be available in 7.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148699] kf5: No tooltips for shapes in Impress's "Basic Shapes" toolbar item (and others)
https://bugs.documentfoundation.org/show_bug.cgi?id=148699 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/IconThemeInfo.cxx | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
New commits:
commit 02b740a7a047052e60274b8649f3624267eb079f
Author: Zain Iftikhar
AuthorDate: Sat Apr 16 04:31:02 2022 +0500
Commit: Ilmari Lauhakangas
CommitDate: Thu Apr 21 18:52:37 2022 +0200
tdf#141000 replacing underscores with spaces of multi words icon pack name
patch will replace underscores with spaces of multi words icon pack name.
Change-Id: If37f6617b7c90eb912ab2f58fff0f1df225efa66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133094
Tested-by: Heiko Tietze
Reviewed-by: Heiko Tietze
diff --git a/vcl/source/app/IconThemeInfo.cxx b/vcl/source/app/IconThemeInfo.cxx
index 4a5ff157cfa9..4166ae0845dd 100644
--- a/vcl/source/app/IconThemeInfo.cxx
+++ b/vcl/source/app/IconThemeInfo.cxx
@@ -18,8 +18,6 @@
namespace {
-constexpr OUStringLiteral KARASA_JAGA_ID(u"karasa_jaga");
-constexpr OUStringLiteral KARASA_JAGA_DISPLAY_NAME(u"Karasa Jaga");
constexpr OUStringLiteral HELPIMG_FAKE_THEME(u"helpimg");
OUString
@@ -124,20 +122,16 @@ IconThemeInfo::ThemeIdToDisplayName(const OUString&
themeId)
if (!bIsSvg && bIsDark)
bIsSvg = aDisplayName.endsWith("_svg", );
-// special cases
-if (aDisplayName.equalsIgnoreAsciiCase(KARASA_JAGA_ID)) {
-aDisplayName = KARASA_JAGA_DISPLAY_NAME;
-}
-else
+// make the first letter uppercase
+sal_Unicode firstLetter = aDisplayName[0];
+if (rtl::isAsciiLowerCase(firstLetter))
{
-// make the first letter uppercase
-sal_Unicode firstLetter = aDisplayName[0];
-if (rtl::isAsciiLowerCase(firstLetter))
-{
-aDisplayName =
OUStringChar(sal_Unicode(rtl::toAsciiUpperCase(firstLetter))) +
aDisplayName.subView(1);
-}
+aDisplayName =
OUStringChar(sal_Unicode(rtl::toAsciiUpperCase(firstLetter))) +
aDisplayName.subView(1);
}
+// replacing underscores with spaces of multi words pack name.
+aDisplayName = aDisplayName.replace('_', ' ');
+
if (bIsSvg && bIsDark)
aDisplayName += " (SVG + dark)";
else if (bIsSvg)
Re: [Libreoffice-qa] ESC meeting minutes: 2022-04-21
Hi *, Miklos Vajna wrote: > * ucb: webdav-curl: put user name from config into LOCK request (Michael S) > + https://gerrit.libreoffice.org/c/core/+/133143 > + benefit: if some other user edits a file on a webdav share, then publish > the name of the editing user > + but this sends user data, might disturb some > + idea: respect the setting that decides if user data is written to > documents > + currently controls ODF's meta.xml > + reuse this > Sorry, had quite a bad jitsi connection today, so as said comment via email - I agree with the rationale that putting the name into the lock file is good UX. There's a small corner case where there would be additional information disclosure, compared to document meta data: if the document is encrypted. Cheers, -- Thorsten signature.asc Description: PGP signature
Re: [Libreoffice-qa] ESC meeting minutes: 2022-04-21
Hi *, Miklos Vajna wrote: > * ucb: webdav-curl: put user name from config into LOCK request (Michael S) > + https://gerrit.libreoffice.org/c/core/+/133143 > + benefit: if some other user edits a file on a webdav share, then publish > the name of the editing user > + but this sends user data, might disturb some > + idea: respect the setting that decides if user data is written to > documents > + currently controls ODF's meta.xml > + reuse this > Sorry, had quite a bad jitsi connection today, so as said comment via email - I agree with the rationale that putting the name into the lock file is good UX. There's a small corner case where there would be additional information disclosure, compared to document meta data: if the document is encrypted. Cheers, -- Thorsten signature.asc Description: PGP signature
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/ui/attrdlg/scdlgfact.cxx |7 ++
sc/source/ui/attrdlg/scdlgfact.hxx |5 +
sc/source/ui/view/cellsh3.cxx | 96 +
3 files changed, 65 insertions(+), 43 deletions(-)
New commits:
commit 7f7e81f70304d672b85fe457c126285a5abac103
Author: rash419
AuthorDate: Tue Apr 12 20:00:13 2022 +0530
Commit: Gökay ŞATIR
CommitDate: Thu Apr 21 18:28:28 2022 +0200
sc: convert optimal width/height and normal width/height dialog to async
Signed-off-by: rash419
Change-Id: I96f6d90692d7767bdc276f753897bdc392c90411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132919
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133127
Reviewed-by: Gökay ŞATIR
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx
b/sc/source/ui/attrdlg/scdlgfact.cxx
index 9fbfccaa4d38..ab8741a9e8d8 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -194,6 +194,11 @@ short AbstractScMetricInputDlg_Impl::Execute()
return m_xDlg->run();
}
+bool AbstractScMetricInputDlg_Impl::StartExecuteAsync(AsyncContext& rCtx)
+{
+return ScMetricInputDlg::runAsync(m_xDlg, rCtx.maEndDialogFn);
+}
+
short AbstractScMoveTableDlg_Impl::Execute()
{
return m_xDlg->run();
@@ -1112,7 +1117,7 @@ VclPtr
ScAbstractDialogFactory_Impl::CreateScMetricInp
tools::Long
nMaximum ,
tools::Long
nMinimum )
{
-return
VclPtr::Create(std::make_unique(pParent,
sDialogName, nCurrent ,nDefault, eFUnit,
+return
VclPtr::Create(std::make_shared(pParent,
sDialogName, nCurrent ,nDefault, eFUnit,
nDecimals, nMaximum , nMinimum));
}
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx
b/sc/source/ui/attrdlg/scdlgfact.hxx
index fef206002dea..b3756bb075af 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -390,13 +390,14 @@ public:
class AbstractScMetricInputDlg_Impl : public AbstractScMetricInputDlg
{
-std::unique_ptr m_xDlg;
+std::shared_ptr m_xDlg;
public:
-explicit AbstractScMetricInputDlg_Impl(std::unique_ptr p)
+explicit AbstractScMetricInputDlg_Impl(std::shared_ptr p)
: m_xDlg(std::move(p))
{
}
virtual short Execute() override;
+virtual bool StartExecuteAsync(AsyncContext& rCtx) override;
virtual int GetInputValue() const override;
};
diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx
index f24c06e9a0d2..f5c1155ec218 100644
--- a/sc/source/ui/view/cellsh3.cxx
+++ b/sc/source/ui/view/cellsh3.cxx
@@ -687,21 +687,24 @@ void ScCellShell::Execute( SfxRequest& rReq )
GetRowHeight( rData.GetCurY(),
rData.GetTabNo()
);
ScAbstractDialogFactory* pFact =
ScAbstractDialogFactory::Create();
-ScopedVclPtr
pDlg(pFact->CreateScMetricInputDlg(
+VclPtr
pDlg(pFact->CreateScMetricInputDlg(
pTabViewShell->GetFrameWeld(), "RowHeightDialog",
nCurHeight, ScGlobal::nStdRowHeight,
eMetric, 2, MAX_ROW_HEIGHT));
-if ( pDlg->Execute() == RET_OK )
-{
-tools::Long nVal = pDlg->GetInputValue();
-pTabViewShell->SetMarkedWidthOrHeight( false,
SC_SIZE_DIRECT, static_cast(nVal) );
-
-// #101390#; the value of the macro should be in HMM
so use TwipsToEvenHMM to convert
-rReq.AppendItem( SfxUInt16Item( FID_ROW_HEIGHT,
static_cast(TwipsToEvenHMM(nVal)) ) );
-rReq.Done();
+pDlg->StartExecuteAsync([pDlg, pTabViewShell](sal_Int32
nResult){
+if (nResult == RET_OK)
+{
+SfxRequest pRequest(pTabViewShell->GetViewFrame(),
FID_ROW_HEIGHT);
+tools::Long nVal = pDlg->GetInputValue();
+pTabViewShell->SetMarkedWidthOrHeight( false,
SC_SIZE_DIRECT, static_cast(nVal) );
-}
+// #101390#; the value of the macro should be in
HMM so use TwipsToEvenHMM to convert
+pRequest.AppendItem( SfxUInt16Item(
FID_ROW_HEIGHT, static_cast(TwipsToEvenHMM(nVal)) ) );
+pRequest.Done();
+}
+pDlg->disposeOnce();
+});
}
}
break;
@@ -725,20 +728,24 @@ void ScCellShell::Execute( SfxRequest& rReq )
FieldUnit eMetric =
SC_MOD()->GetAppOptions().GetAppMetric();
[Libreoffice-bugs] [Bug 148709] Spurious crash report screen on start up of Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=148709 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Could you update to 7.3.2 and give a try at https://wiki.documentfoundation.org/QA/FirstSteps ? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148693] "Write Error" due to "Curves and Polygons"
https://bugs.documentfoundation.org/show_bug.cgi?id=148693 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #7 from Julien Nabet --- (In reply to Regina Henschel from comment #6) > (In reply to Julien Nabet from comment #4) > > Regina: thought you might be interested in this one. > > Sorry, I cannot reproduce the problem. That prevents properly fixing. Tested > ... did you try to freeform line AND very short line? Indeed, if the draw is not enough short and can be considered just as a line, you can't reproduce the pb. > But from reading your changes, I think it does the correct thing. ok => https://gerrit.libreoffice.org/c/core/+/133273 thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?
https://bugs.documentfoundation.org/show_bug.cgi?id=148673 --- Comment #4 from Mike Kaganski --- (In reply to sdc.blanco from comment #3) > Neutral about name change (was not in OP) Please note that name change is *essential* for the OP: if you have "Bullet and Numbering" toolbar, then it *must not* appear when no bullets or numbering is involved. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?
https://bugs.documentfoundation.org/show_bug.cgi?id=148673 --- Comment #4 from Mike Kaganski --- (In reply to sdc.blanco from comment #3) > Neutral about name change (was not in OP) Please note that name change is *essential* for the OP: if you have "Bullet and Numbering" toolbar, then it *must not* appear when no bullets or numbering is involved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?
https://bugs.documentfoundation.org/show_bug.cgi?id=148673 --- Comment #3 from sdc.bla...@youmail.dk --- Neutral about name change (was not in OP) – though agree that "Outline and List" bar would better signal the toolbar’s functionality, and better match the relevant Para and PS dialogs tabs. Note implication with name change: at least 36 help pages would need updating (plus triggering need for retranslations). Assume that Format > Bullets and Numbering (.uno:OutlineBullet) would remain with ”Bullets and Numbering”(which is another advantage with a toolbar name change, because it would disambiguate the Bullets and Numbering DF dialog (which chooses list formats) from the (mostly) "level" and "order" functions of the "Outline and List" bar). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?
https://bugs.documentfoundation.org/show_bug.cgi?id=148673 --- Comment #3 from sdc.bla...@youmail.dk --- Neutral about name change (was not in OP) – though agree that "Outline and List" bar would better signal the toolbar’s functionality, and better match the relevant Para and PS dialogs tabs. Note implication with name change: at least 36 help pages would need updating (plus triggering need for retranslations). Assume that Format > Bullets and Numbering (.uno:OutlineBullet) would remain with ”Bullets and Numbering”(which is another advantage with a toolbar name change, because it would disambiguate the Bullets and Numbering DF dialog (which chooses list formats) from the (mostly) "level" and "order" functions of the "Outline and List" bar). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: desktop/source include/sfx2 officecfg/registry sfx2/source
desktop/source/lib/init.cxx | 11 --
include/sfx2/sidebar/SidebarController.hxx |1
officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu | 46 +++
sfx2/source/sidebar/Context.cxx |9 --
sfx2/source/sidebar/SidebarController.cxx|4
5 files changed, 19 insertions(+), 52 deletions(-)
New commits:
commit c09f59eb6173a4a53a2d40ed80aebed18e3882ac
Author: Mike Kaganski
AuthorDate: Thu Apr 21 15:14:49 2022 +0300
Commit: Mike Kaganski
CommitDate: Thu Apr 21 18:03:43 2022 +0200
Drop special-casing for Chart's sidebar property deck
Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a
Author Markus Mohrhard
Date Thu Jul 09 20:39:06 2015 +0200
big step towards real chart sidebar
later in commit da57c32c5cb27eee38e32d10232b31d459c399df
Author Tor Lillqvist
Date Fri Feb 28 17:02:30 2020 +0200
tdf#130348: Add special case for ChartDeck, too
and then in commit ff23d87cb00388095a94b90e061564fc179e1823
Author Mert Tumer
Date Fri May 08 17:23:12 2020 +0300
mobile: fix calc chart wizard properties is not shown
The normal PropertyDeck can host all the chart-specific panels,
and the other decks that had "all" application context, but are
not needed for charts, have their context fixed.
This cleanup is needed for a following introduction of sidebar
in Math.
Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 9a4ec4881805..462e2e5d25af 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -873,22 +873,13 @@ void setupSidebar(std::u16string_view sidebarDeckId = u"")
if (!pDockingWin)
return;
-OUString currentDeckId =
pDockingWin->GetSidebarController()->GetCurrentDeckId();
-
-// check if it is the chart deck id, if it is, don't switch to default
deck
-bool switchToDefault = true;
-
-if (currentDeckId == "ChartDeck")
-switchToDefault = false;
-
if (!sidebarDeckId.empty())
{
pDockingWin->GetSidebarController()->SwitchToDeck(sidebarDeckId);
}
else
{
-if (switchToDefault)
-pDockingWin->GetSidebarController()->SwitchToDefaultDeck();
+pDockingWin->GetSidebarController()->SwitchToDefaultDeck();
}
pDockingWin->SyncUpdate();
diff --git a/include/sfx2/sidebar/SidebarController.hxx
b/include/sfx2/sidebar/SidebarController.hxx
index baedec092484..8d8dcf215527 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -133,7 +133,6 @@ public:
FocusManager& GetFocusManager() { return maFocusManager;}
ResourceManager* GetResourceManager() { return mpResourceManager.get();}
-auto& GetCurrentDeckId() const { return msCurrentDeckId; }
// std::unique_ptr GetResourceManager() { return
mpResourceManager;}
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index c64da92d8789..9290ef9dcc70 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -114,7 +114,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -194,7 +196,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -214,7 +218,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -289,26 +295,6 @@
-
-
- Properties
-
-
- ChartDeck
-
-
-
private:graphicrepository/sfx2/res/symphony/sidebar-property-large.png
-
-
-
-Chart, any, visible ;
-
-
-
- 10
-
-
-
@@ -1646,7 +1632,7 @@
ChartElementsPanel
- ChartDeck
+ PropertyDeck
@@ -1672,7 +1658,7 @@
ChartSeriesPanel
- ChartDeck
+ PropertyDeck
[Libreoffice-bugs] [Bug 148693] "Write Error" due to "Curves and Polygons"
https://bugs.documentfoundation.org/show_bug.cgi?id=148693 --- Comment #6 from Regina Henschel --- (In reply to Julien Nabet from comment #4) > Regina: thought you might be interested in this one. Sorry, I cannot reproduce the problem. That prevents properly fixing. Tested with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 347622a98f512dae709f938a85498dcdcf9f225a CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: threaded But from reading your changes, I think it does the correct thing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148690] Ordered lists created with list styles lose their numbering when Untitled document saved as .docx, while direct formatted ordered lists do not
https://bugs.documentfoundation.org/show_bug.cgi?id=148690 --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to Timur from comment #3) > Maybe there's some detail. For the list style, use: Numbering a b c List Style. No repro with Numbering 1 2 3 List Style. And still need to save a new Untitled document as Word 2007-365 (.docx) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148712] Show the count of hidden sheets in the Calc spreadsheets statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=148712 Jeff Fortin Tam changed: What|Removed |Added Keywords||easyHack -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148712] New: Show the count of hidden sheets in the Calc spreadsheets statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=148712 Bug ID: 148712 Summary: Show the count of hidden sheets in the Calc spreadsheets statusbar Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nekoh...@gmail.com Below the tab bar representing the visible sheets in a spreadsheet, Calc has a statusbar with various pieces of information, starting with "Sheet 4 of 10". As there is no visual indication of hidden sheets otherwise, I would like Calc to clearly indicate that there are hidden sheets, without the user needing to manually count sheets (especially since that's not really easy to do when sheet tabs scroll, so you often can't see them all at once anyway). This could be done with a string like this in the statusbar, when there are hidden sheets (i.e. their number is not zero): Sheet %d of %d (%d hidden) For example: Sheet 4 of 10 (4 hidden) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148708] ordered letter list wrongs then save as docx
https://bugs.documentfoundation.org/show_bug.cgi?id=148708 Timur changed: What|Removed |Added CC||gti...@gmail.com, ||mark...@gmail.com Keywords||bibisected --- Comment #2 from Timur --- LO 4.4max 999662c1344871699dbf487554379a9d8ab8437a is the first bad commit source-hash-d30a8ec448bcd08c6a52a37d6ae41a4b71c235da prev source-hash-ba59fc533b6ac393969b456e72223d7d839b46c1 2 commits here, I guess it's the 1st one: author Mark Hung Correct number format mapping for CJK numbered lists in rtf/doc/docx filters. author Miklos Vajna indentation fixes Adding Mark to CC, please see. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139469] [LOCALHELP] fontwork help page needs review
https://bugs.documentfoundation.org/show_bug.cgi?id=139469 --- Comment #8 from lach...@gmail.com --- Hello, all! After one year since this bug was reported, I noticed those changes were gone "for good" :) What happened? I can't find the text-along-the-curve feature. Besides, the Help system for this topic is outdated. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148301] Shortcuts Ctrl+> and Ctrl+< not working
https://bugs.documentfoundation.org/show_bug.cgi?id=148301 --- Comment #4 from jr...@hotmail.com --- Tested again with profile reset (safe mode) on Version: 7.3.3.1 / LibreOffice Community Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928 CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Still didn't work. Maybe it's an OS/GNOME specific error? -- You are receiving this mail because: You are the assignee for the bug.
Re: How to export 'Octagon Bevel' and 'Diamond Bevel' to OOXML
Hi Miklos, Hi Miklos, Miklos Vajna schrieb am 21.04.2022 um 16:31: Hi Regina, On Tue, Apr 19, 2022 at 01:32:23AM +0200, Regina Henschel wrote: The appearance we currently get (without any patch) cannot be exported to OOXML, if we want, that it remains to be a shape. And when reopening the file the shape will have different shading than before saving, if we not change 'Octagon Bevel' and 'Diamond Bevel' to an OOXML-compatible shape at the same time. The alternative would be to export the shape not as a shape but as an image. For what purpose are these bevel-shapes used? Likely for giving a frame to a text. And then text and background should be still editable after roundtrip. That is my opinion. So for me export as image would be the worse solution. I agree that exporting it as an image sounds quite poor. I have added export of its shading in https://cgit.freedesktop.org/libreoffice/core/commit/?id=5168d06b1302c43a305d0f670ee65079f21063b5 I think, that is a good compromise. Only handles are missing. But that is a general problem. Kind regards, Regina
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/data/tdf147723.docx |binary
sw/qa/extras/uiwriter/uiwriter5.cxx | 21 +
2 files changed, 21 insertions(+)
New commits:
commit e31cf19e5f5bcdc9e96d1ecd896a611ea035a934
Author: Xisco Fauli
AuthorDate: Thu Apr 21 14:12:48 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Apr 21 17:03:09 2022 +0200
tdf#147723: sw_uiwriter5: Add unittest
Change-Id: Ief6afaee548e58a31580b66d55b9b193ba23d153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133259
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/data/tdf147723.docx
b/sw/qa/extras/uiwriter/data/tdf147723.docx
new file mode 100644
index ..4cdfb264bd4d
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf147723.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter5.cxx
b/sw/qa/extras/uiwriter/uiwriter5.cxx
index 1ba4f86cc8b9..dbd804164671 100644
--- a/sw/qa/extras/uiwriter/uiwriter5.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter5.cxx
@@ -887,6 +887,27 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest5,
testMixedFormFieldInsertion)
CPPUNIT_ASSERT_EQUAL(sal_Int32(3), pMarkAccess->getAllMarksCount());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest5, testTdf147723)
+{
+SwDoc* const pDoc = createSwDoc(DATA_DIRECTORY, "tdf147723.docx");
+
+IDocumentMarkAccess& rIDMA(*pDoc->getIDocumentMarkAccess());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rIDMA.getAllMarksCount());
+
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+dispatchCommand(mxComponent, ".uno:Copy", {});
+
+// Without the fix in place, this test would have crashed here
+dispatchCommand(mxComponent, ".uno:Paste", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rIDMA.getAllMarksCount());
+dispatchCommand(mxComponent, ".uno:Paste", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(6), rIDMA.getAllMarksCount());
+dispatchCommand(mxComponent, ".uno:Undo", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rIDMA.getAllMarksCount());
+dispatchCommand(mxComponent, ".uno:Undo", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), rIDMA.getAllMarksCount());
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest5, testTdf147006)
{
SwDoc* const pDoc = createSwDoc(DATA_DIRECTORY, "tdf147006.rtf");
[Libreoffice-bugs] [Bug 148711] Selected options in context menu show in black text on dark blue background in Windows 11
https://bugs.documentfoundation.org/show_bug.cgi?id=148711 --- Comment #1 from Ariel Torres --- Created attachment 179714 --> https://bugs.documentfoundation.org/attachment.cgi?id=179714=edit Screenshot of a pop-up menu in Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148711] New: Selected options in context menu show in black text on dark blue background in Windows 11
https://bugs.documentfoundation.org/show_bug.cgi?id=148711 Bug ID: 148711 Summary: Selected options in context menu show in black text on dark blue background in Windows 11 Product: LibreOffice Version: 7.2.6.2 release Hardware: x86-64 (AMD64) OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: arieltor...@gmail.com Description: After upgrading to Windows 11, Writer pop-up menus and even normal menus (also in Calc) show the selected option in black text on a dark blue (instead a pale blue, like in Windows 10) background. In the case of Autocorrection, where you have to choose between several unpredictable options, it's almost unreadable. Doesn't happen in Linux. Doesn't happen in other versions of Windows. Tested changing values in MenuText and MenuHilight in \HKEY_CURRENT_USER\Control Panel\Colors but I only changes MenuText showed in the GUI, not MenuHilight changes Steps to Reproduce: 1. Open a menu or right clic on any part of a document, mispelled word or such 2. Select an option in the menu 3. (BTW, I have only one computer with Windows 11 to test this; not 100% sure it will happen in ANY computer with Windows 11) Actual Results: The option selected have a black text on a dark blue backround Expected Results: Have a paler backround or a white text for the selected option Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.2.6.2 (x64) / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 20; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win Locale: es-AR (es_AR); UI: es-ES Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148690] Ordered lists created with list styles lose their numbering when Untitled document saved as .docx, while direct formatted ordered lists do not
https://bugs.documentfoundation.org/show_bug.cgi?id=148690 --- Comment #3 from Timur --- No repro. Maybe there's some detail. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148708] ordered letter list wrongs then save as docx
https://bugs.documentfoundation.org/show_bug.cgi?id=148708 Timur changed: What|Removed |Added Version|7.3.1.3 release |4.4.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140956] Recording macros is not convenient - fully rewrite Macro recorder for proper code
https://bugs.documentfoundation.org/show_bug.cgi?id=140956 educm...@yahoo.com changed: What|Removed |Added CC||educm...@yahoo.com --- Comment #2 from educm...@yahoo.com --- LO 7.2.6.2 continues the difficulty (on my Win 11 install). Recognizing that this would be a massive undertaking, to move MACRO RECORDING from command execution (dispatches) to functional, executable commands in basic ((akin to what happens in MSOffice and VBA)), I would vote for a communal focus in this area. Sadly, my programming skills aren't up. My hope is that (by trivial example, only!), I could turn on a macro recording, change the border color on a shape, and turn off recording. Look in at the recorded macro, and see the exact code that executed that, and then use/manipulate it as needed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148708] ordered letter list wrongs then save as docx
https://bugs.documentfoundation.org/show_bug.cgi?id=148708 Timur changed: What|Removed |Added Ever confirmed|0 |1 OS|Linux (All) |All Status|UNCONFIRMED |NEW Keywords||regression Hardware|x86-64 (AMD64) |All --- Comment #1 from Timur --- No repro 4.1. Repro 5.4 and 7.4+ when saved DOCX reopened in LO and MSO. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96474] It would be helpful to be able to search *only* within comments
https://bugs.documentfoundation.org/show_bug.cgi?id=96474 --- Comment #8 from Heiko Tietze --- *** Bug 148463 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 148463, which changed state. Bug 148463 Summary: Need ability to search only comments https://bugs.documentfoundation.org/show_bug.cgi?id=148463 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Bug 113136 depends on bug 148463, which changed state. Bug 148463 Summary: Need ability to search only comments https://bugs.documentfoundation.org/show_bug.cgi?id=148463 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Heiko Tietze --- *** This bug has been marked as a duplicate of bug 96474 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 Bug 102847 depends on bug 96474, which changed state. Bug 96474 Summary: It would be helpful to be able to search *only* within comments https://bugs.documentfoundation.org/show_bug.cgi?id=96474 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Heiko Tietze --- *** This bug has been marked as a duplicate of bug 96474 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 96474, which changed state. Bug 96474 Summary: It would be helpful to be able to search *only* within comments https://bugs.documentfoundation.org/show_bug.cgi?id=96474 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96474] It would be helpful to be able to search *only* within comments
https://bugs.documentfoundation.org/show_bug.cgi?id=96474 Heiko Tietze changed: What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- --- Comment #7 from Heiko Tietze --- (In reply to Heiko Tietze from comment #5) > Let's do it the other way around, not much discussion here and a broader > more flexible approach on the other ticket. Nonsense, the other ticket has no more input. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148710] Layout of an image in docx file is different from the layout in odt file, even when the anchorings used are docx-compatible ones (i.e., "as char" and "to char" anchorin
https://bugs.documentfoundation.org/show_bug.cgi?id=148710 Jambunathan K changed: What|Removed |Added Summary|Layout of an image in docx |Layout of an image in docx |file is different from the |file is different from the |layout in odt file |layout in odt file, even ||when the anchorings used ||are docx-compatible ones ||(i.e., "as char" and "to ||char" anchorings) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added CC||luke.kend...@gmail.com --- Comment #2 from Heiko Tietze --- *** Bug 96474 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added CC||luke.kend...@gmail.com --- Comment #2 from Heiko Tietze --- *** Bug 96474 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96474] It would be helpful to be able to search *only* within comments
https://bugs.documentfoundation.org/show_bug.cgi?id=96474 Heiko Tietze changed: What|Removed |Added Resolution|FIXED |DUPLICATE --- Comment #6 from Heiko Tietze --- *** This bug has been marked as a duplicate of bug 148463 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Bug 113136 depends on bug 148463, which changed state. Bug 148463 Summary: Need ability to search only comments https://bugs.documentfoundation.org/show_bug.cgi?id=148463 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 148463, which changed state. Bug 148463 Summary: Need ability to search only comments https://bugs.documentfoundation.org/show_bug.cgi?id=148463 What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added Status|RESOLVED|NEW Ever confirmed|0 |1 Resolution|DUPLICATE |--- -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148463] Need ability to search only comments
https://bugs.documentfoundation.org/show_bug.cgi?id=148463 Heiko Tietze changed: What|Removed |Added Status|RESOLVED|NEW Ever confirmed|0 |1 Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Bug 106179 depends on bug 96474, which changed state. Bug 96474 Summary: It would be helpful to be able to search *only* within comments https://bugs.documentfoundation.org/show_bug.cgi?id=96474 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
