[Libreoffice-bugs] [Bug 148739] Writer - Windows 7.1.4.2 (x64) FAILS to save "Export Directly ePUB" with file extension.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148739

David  Ring Jr  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from David  Ring Jr  ---
Bug resolved as of Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148454] Crash when I change font size in KDE Plasma 5.22.5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148454

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
(In reply to Samantha from comment #0)
> It appears to be present on the current version of LibreOffice that was
> launched with 21.04 and 21.10.

Please paste informations from Help -> About LibreOffice
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148447] Replace All in Writer comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148447

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Dieter  ---
I support this enhancement request, but I'm not a member of design-team

cc: Design-Team

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148447] Replace All in Writer comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148447

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Dieter  ---
I support this enhancement request, but I'm not a member of design-team

cc: Design-Team

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148698] Page Format Margin settings incorrect for Letter Size in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148698

--- Comment #2 from Eek! A Bug. Kill it!  ---
(In reply to Telesto from comment #1)
> Where do I find: 1. Select Letter with Normal (0.75") Margins"
> 
> Note: If I change the locale of LibreOffice to English USA I do get 0,79
> inch margin (with letter Page) But unsure if the 2.00 cm margin being
> inherited from my previous setting or if the 2.00 cm / 0,79 being hardcoded
> margin.


On the sidebar, 

1. Select the Page icon
2. under the Format section
3. first select the Size as Letter
4. then select a Margins setting of Normal (0.75")

The wrong margins do not seem to be inherited from previous settings but appear
to be mis-coded -- and have been this way for the past couple years that I have
used LO Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148739] New: Writer - Windows 7.1.4.2 (x64) FAILS to save "Export Directly ePUB" with file extension.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148739

Bug ID: 148739
   Summary: Writer - Windows 7.1.4.2 (x64) FAILS to save "Export
Directly ePUB" with file extension.
   Product: LibreOffice
   Version: 7.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: n...@arrl.net

Description:
Writer - Windows 7.1.4.2 (x64) FAILS to save "Export Directly ePUB" with file
extension.

Version: 7.1.4.2 (x64) / LibreOffice Community
Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Steps to Reproduce:
1.Save any file as "Directly EXPORT as EPub"


Actual Results:
File seems to save, but the file in File Explorer shows a file named without
the epub extension.

Expected Results:
Writer should export as epub normally without this error.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148432

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de,
   ||heiko.tietze@documentfounda
   ||tion.org, rayk...@gmail.com

--- Comment #1 from Dieter  ---
Eyal, thank you for the report. Looks like an enhancement request to me. Sounds
reasonable to me. Heiko, Jim, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148414

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|minor   |normal
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1
 Blocks||146315, 108576
 Whiteboard| QA:needsComment|

--- Comment #5 from Dieter  ---
I confirm it with

Version: 7.3.3.1 (x64) / LibreOffice Community
Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps to reproduce
1. Toggle "Show Whitespace" off
2. Open attachment 179337 from comment 0. Document has three pages and page
format is "Letter"
3. Change page format to A6. Document has still three pages although page
height is reduced. (Nit Expected)
4. Toggle "Show Whitespace" on. Document now has four pages. (Expected)
5. Toggle "Sow Whitespace" off => four pages (Expected)

Actual result: 
Change of page format doesn't change number of pages

Expected result:
Same result as with "Show Whitespace" on


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108576
[Bug 108576] [META] Writer page style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=146315
[Bug 146315] [META] Show/Hide Whitespace bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108576] [META] Writer page style bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108576

Dieter  changed:

   What|Removed |Added

 Depends on||148414


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148414
[Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146315] [META] Show/Hide Whitespace bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146315

Dieter  changed:

   What|Removed |Added

 Depends on||148414


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148414
[Bug 148414] "View > Show Whitespace" Does Not Update With Page Size Change
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148472] Render of Bold Italic Strikeout font differs with MS Word for specific docx file (with null values)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148472

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148473] Use field type for subtreeing in Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148473

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148446] LO Writer randomly restarts automatic numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148446

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148421] Assertion failed: (nOrdNum < GetReferencedObj().GetOrdNum()), function AddToDrawingPage, file dcontact.cxx, line 2323

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148421

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141804] extremely slow libreoffice version 7.1.1 and 7.1.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141804

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148231] First Check For Updates creates dummy form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148231

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141804] extremely slow libreoffice version 7.1.1 and 7.1.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141804

--- Comment #7 from QA Administrators  ---
Dear Serge Mimouni,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145293] Crash when clicking "data sources"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145293

--- Comment #2 from QA Administrators  ---
Dear Per Schoerner,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145228] Cannot open .odt files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145228

--- Comment #8 from QA Administrators  ---
Dear surfbird,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148738] New: Selected all object does not resize to the same size.[CALC]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148738

Bug ID: 148738
   Summary: Selected all object does not resize to the same
size.[CALC]
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m5382607...@gomen-da.com

Description:
I needed to convert a list PDF with images in a table (image it made of HTML)
to Excel and then import it into Google Sheets, which I found in the process.

At the time of loading imported ,xlsx imported by Calc, there is no abnormality
in appearance.

==NEEDS==
I want to align the vertical width of the image size with the height of the
cell and the horizontal width to any size.
*Aligning objects is not a position relative to the height of the cell.
*Anchors are different to maintain the aspect ratio of the image.

Steps to Reproduce:
1.You have a lot of image objects on your calc sheet. Their size is not
constant.
2.Click one of image.
3.Push Ctrl+A. then all images object are selected.
4.Right click, select "Position and size"
5.Input width or height size. click "OK"

Actual Results:
Only part of the selected image will be the specified size.

Expected Results:
All selected image objects are risized the same size.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
HTMLのテーブルにIMGタグで画像を収めた一覧表のPDFをエクセルに変換（Calcへの変換ツールがないだけ）。それをGoogleスプレッドにインポートした時にセルと画像の位置が一致しなくなるため、Calc上で画像のサイズを統一しておきたい。
なぜこのようにしたいかというと、画像のサイズが一定でないせいでセルから画像が大きくはみ出すのだろうと考えたから。（統一できている内はズレていないのです）

そしてこれが発見した問題です。

○画像をクリックし、Ctrl＋Aをして画像を全て選択し「位置とサイズ」でサイズを指定しても一部の画像しかサイズが同じにならない。

画像1枚づつ右クリックした場合はこのメニューでできるが、4000枚あるからやりたくない。「セルとともにサイズ変更」もセルにピッタリではなく縦横の比率を維持するので期待した動作ではない。

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148710] Layout of an image in docx file is different from the layout in odt file, even when the anchorings used are docx-compatible ones (i.e., "as char" and "to char" anchorin

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148710

--- Comment #7 from Jambunathan K  ---
ATTENTION ADMINISTRATORS

ATTENTION ADMINISTRATORS


Someone is spamming the bug reports. Note the URL field of this bug report.

I wonder if you have any bots to capture edits that are not in good faith. 


ATTENTION ADMINISTRATORS

ATTENTION ADMINISTRATORS

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126242] PDF-EXPORT: do not produce correct glyph outlines of OTF-CFF fonts subset to Type1 fonts, during subset some outline paths get shifted (at the end points, not the joins

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126242

--- Comment #12 from medmedin2014  ---
Repro on:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: e4243a140345a4bcd800217115b42667e277c6a3
CPU threads: 2; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148705] [FILEOPEN] SpreadsheetML 2003 parser missing text wrap setting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148705

--- Comment #2 from SheetJS  ---
https://i.imgur.com/0wmcEHT.png

Top: LibreOffice about screen.  Version 7.3.2.2 just downloaded from the
website

Bottom-Left: Excel for Mac Version 16.55 (2400)

Bottom-Right: LibreOffice

Curiously both B1 and B2 are incorrect: Excel has text wrap enabled on B1 but
not B2.  LO has neither cell set to wrap, but in practice it displays B2 as if
it were wrapped.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148705] [FILEOPEN] SpreadsheetML 2003 parser missing text wrap setting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148705

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Created attachment 179737
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179737=edit
Screenshot excel vs calc

How it looks excel vs calc.
Excel doesn't apply the split, calc only doesn't recalculate the row height.

Microsoft® Excel® for Microsoft 365 MSO (Version 2203 Build 16.0.15028.20178)
64-bit
Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139414] Calc exports CSV dates as 11/10/09 Millennium Bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139414

--- Comment #11 from Jonny Grant  ---
Hi Buovjaga
If I type "Untitled 1.csv" in the box, I expect it to save as CSV... As is
customary in all software. Feels like a bug. It should say "Error cannot Export
as CSV" right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148641] inconsistent unicode ellipsis vs three dots handling in pivot table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148641

--- Comment #1 from himajin100...@gmail.com ---
https://opengrok.libreoffice.org/xref/core/sc/source/core/data/dpsave.cxx?r=f477b54e#1243

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] FILEOPEN PPTX: crash upon opening (possibly SmartArt-related?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

--- Comment #3 from Hossein  ---
Backtrace, copied from Qt Creator:

1   __GI_raise  raise.c   50   0x779ec03b 
2   __GI_abort  abort.c   79   0x779cb859 
3   ??   0x77846109 
4   std::vector>::front  vector  443 
0x7fffd23d1fa6 
5   oox::drawingml::TextBody::toString  textbody.cxx  92   0x7fffd23d0f85 
6   oox::drawingml::DiagramData::secureDataFromShapeToModelAfterDiagramImport
datamodel.cxx   295  0x7fffd22d3047 
7   oox::drawingml::AdvancedDiagramHelper::doAnchor   diagramhelper.cxx   213 
0x7fffd22fb92d 
8   oox::drawingml::Shape::propagateDiagramHelper   shape.cxx   229 
0x7fffd2372a27 
9   oox::ppt::PPTShape::addShape  pptshape.cxx  574  0x7fffd25b2bd4 
10  oox::ppt::SlidePersist::createXShapes   slidepersist.cxx  150 
0x7fffd25d81ea 
11  oox::ppt::PresentationFragmentHandler::importSlide 
presentationfragmenthandler.cxx 404  0x7fffd25c1a78 
12  oox::ppt::PresentationFragmentHandler::finalizeImport  
presentationfragmenthandler.cxx 550  0x7fffd25c3331 
13  oox::core::FragmentHandler2::endDocument  fragmenthandler2.cxx  53  
0x7fffd22364ab 
14  sax_fastparser::FastSaxParserImpl::parseStream  fastparser.cxx  907 
0x7fffe18b2d2b 
15  sax_fastparser::FastSaxParser::parseStream  fastparser.cxx  1480
0x7fffe18b71d2 
16  oox::core::FastParser::parseStream  fastparser.cxx  121  0x7fffd221d85b 
17  oox::core::FastParser::parseStream  fastparser.cxx  129  0x7fffd221d930 
18  oox::core::XmlFilterBase::importFragment  xmlfilterbase.cxx   413 
0x7fffd2248ba5 
19  oox::core::XmlFilterBase::importFragment  xmlfilterbase.cxx   343 
0x7fffd2248687 
20  oox::ppt::PowerPointImport::importDocument  pptimport.cxx   109 
0x7fffd25a89e2 
... 

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148736

--- Comment #1 from sdc.bla...@youmail.dk ---
https://gerrit.libreoffice.org/c/core/+/133287

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148731] Calc crashes (closes) when scrolling through line items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148731

--- Comment #3 from WAM  ---
I believe I found the fix.
In Libre Calc go to tools tab then select options, pick view and within
graphics output place check mark in the "force skia" box.
The computer I have that Calc worked perfectly had that box checked.  The
machine having the problem had the box unchecked.
All seems to be fine now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148737] Improve label and tooltip for Arrow Styles icon in Drawing Objects Properties bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148737

--- Comment #1 from sdc.bla...@youmail.dk ---
https://gerrit.libreoffice.org/c/core/+/133286

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/libassuan

[Stephan Bergmann (via logerrit)]

 external/libassuan/UnpackedTarball_libassuan.mk |1 
 external/libassuan/w32-stdc.patch   |   74 
 2 files changed, 75 insertions(+)

New commits:
commit 8279d89d6e037def78f50c72fab2116ca56bef52
Author: Stephan Bergmann 
AuthorDate: Fri Apr 22 21:52:50 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 22 23:38:33 2022 +0200

external/libassuan: Fix fallout of defining __STDC__ on Windows

...since 1bb0e177124d5d6661b72df6c7d848fb23639652 "Fix autoconf>=2.70
gcc-wrapper breakage", which had the side effect of preventing various
deprecated function declarations in system headers (e.g., isascii in 
addition to
__isascii).  This went unnoticed so far due to the traditionally lax 
handling of
missing function declarations in C, and only now started to cause

> conversion.c(94,9): error: call to undeclared function 'isascii'; ISO C99 
and later do not support implicit function declarations 
[-Wimplicit-function-declaration]
>   if ((isascii (*istr) && isprint (*istr)) || (*istr >= 0x80))
>^

etc. with clang-cl 15 trunk after


"[C11/C2x] Change the behavior of the implicit function declaration 
warning".

Where undeclared functions have been used in Windows-only code, they have 
been
replaced with their __STDC__-declared counterparts, and for occurrences in
shared code Windows-only macro definitions have been introduced (as would 
have
done in the system headers too, if __STDC__ was not defined) to not clutter 
the
shared code with #ifdefs.

Also, for getpid (resp. _getpid), the #include  was apparently
missing from the upstream code, even without our __STDC__ hack in
external/libassuan/ExternalProject_libassuan.mk (but never caused errors 
until
now, either).

Change-Id: I7442394d0c6e633bca1f6c7331d7ee51651179a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/19
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/libassuan/UnpackedTarball_libassuan.mk 
b/external/libassuan/UnpackedTarball_libassuan.mk
index 295b87d49677..3604fa36a395 100644
--- a/external/libassuan/UnpackedTarball_libassuan.mk
+++ b/external/libassuan/UnpackedTarball_libassuan.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,libassuan, \
 $(if $(filter MSC,$(COM)),external/libassuan/w32-build-fixes.patch.1) \
 external/libassuan/w32-build-fixes-2.patch \
 $(if $(filter LINUX,$(OS)),external/libassuan/rpath.patch) \
+external/libassuan/w32-stdc.patch \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/libassuan/w32-stdc.patch 
b/external/libassuan/w32-stdc.patch
new file mode 100644
index ..def3dea833af
--- /dev/null
+++ b/external/libassuan/w32-stdc.patch
@@ -0,0 +1,74 @@
+--- src/assuan-handler.c
 src/assuan-handler.c
+@@ -938,7 +938,7 @@
+ #if defined(HAVE_W32CE_SYSTEM)
+ fdarray[n++] = (void*)fileno (ctx->outbound.data.fp);
+ #elif defined(HAVE_W32_SYSTEM)
+-fdarray[n++] = (void*)_get_osfhandle (fileno (ctx->outbound.data.fp));
++fdarray[n++] = (void*)_get_osfhandle (_fileno 
(ctx->outbound.data.fp));
+ #else
+ fdarray[n++] = fileno (ctx->outbound.data.fp);
+ #endif
+--- src/assuan-logging.c
 src/assuan-logging.c
+@@ -30,10 +30,15 @@
+ # ifdef HAVE_WINSOCK2_H
+ #  include 
+ # endif
++# include 
++# define getpid _getpid
+ # include 
+ #endif /*HAVE_W32_SYSTEM*/
+ #include 
+ #include 
++#if defined HAVE_W32_SYSTEM
++#define isascii __isascii
++#endif
+ 
+ #include "assuan-defs.h"
+ 
+--- src/assuan-pipe-connect.c
 src/assuan-pipe-connect.c
+@@ -47,6 +47,8 @@
+ # ifdef HAVE_WINSOCK2_H
+ #  include 
+ # endif
++# include 
++# define getpid _getpid
+ # include 
+ #endif
+ 
+--- src/assuan-socket.c
 src/assuan-socket.c
+@@ -27,6 +27,8 @@
+ #include 
+ #ifdef HAVE_W32_SYSTEM
+ # define WIN32_LEAN_AND_MEAN
++# include 
++# define getpid _getpid
+ # include 
+ # include 
+ #ifndef HAVE_W32CE_SYSTEM
+--- src/conversion.c
 src/conversion.c
+@@ -27,6 +27,9 @@
+ #include 
+ #include 
+ #include 
++#if defined HAVE_W32_SYSTEM
++#define isascii __isascii
++#endif
+ 
+ #include "assuan-defs.h"
+ #include "debug.h"
+--- src/system-w32.c
 src/system-w32.c
+@@ -453,7 +453,7 @@
+ 
+   /* Dup stderr to /dev/null unless it is in the list of FDs to be
+  passed to the child. */
+-  fd = assuan_fd_from_posix_fd (fileno (stderr));
++  fd = assuan_fd_from_posix_fd (_fileno (stderr));
+   fdp = fd_child_list;
+   if (fdp)
+ {

[Libreoffice-commits] core.git: external/gpgmepp

[Stephan Bergmann (via logerrit)]

 external/gpgmepp/UnpackedTarball_gpgmepp.mk |1 +
 external/gpgmepp/w32-include.patch  |   22 ++
 2 files changed, 23 insertions(+)

New commits:
commit b212163587524f723c737d698919cb4fe4e547e6
Author: Stephan Bergmann 
AuthorDate: Fri Apr 22 22:07:25 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 22 23:20:09 2022 +0200

external/gpgmepp: Missing includes (Windows)

> gpgme-w32spawn.c(288,8): error: call to undeclared function 'open'; ISO 
C99 and later do not support implicit function declarations 
[-Wimplicit-function-declaration]
>   fd = open (trans_file, O_RDONLY);
>^

etc. with clang-cl 15 trunk after


"[C11/C2x] Change the behavior of the implicit function declaration 
warning",
which went unnoticed so far due to the traditionally lax handling of missing
function declarations in C.

Change-Id: I805ab10d2b0aae3f8b1f46ffeda57aff2bbcef2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133340
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/gpgmepp/UnpackedTarball_gpgmepp.mk 
b/external/gpgmepp/UnpackedTarball_gpgmepp.mk
index 05bfc9f07bf1..f3de8d2c24ff 100644
--- a/external/gpgmepp/UnpackedTarball_gpgmepp.mk
+++ b/external/gpgmepp/UnpackedTarball_gpgmepp.mk
@@ -33,5 +33,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,gpgmepp, \
 external/gpgmepp/clang-cl.patch \
 external/gpgmepp/configure.patch \
 
external/gpgmepp/gpgme.git-4b64774b6d13ffa4f59dddf947a97d61bcfa2f2e.patch.1 \
+external/gpgmepp/w32-include.patch \
 ))
 # vim: set noet sw=4 ts=4:
diff --git a/external/gpgmepp/w32-include.patch 
b/external/gpgmepp/w32-include.patch
new file mode 100644
index ..30fdba5f8f26
--- /dev/null
+++ b/external/gpgmepp/w32-include.patch
@@ -0,0 +1,22 @@
+--- src/data-fd.c
 src/data-fd.c
+@@ -28,6 +28,9 @@
+ #ifdef HAVE_SYS_TYPES_H
+ # include 
+ #endif
++#if defined HAVE_W32_SYSTEM
++#include 
++#endif
+ 
+ #include "debug.h"
+ #include "data.h"
+--- src/gpgme-w32spawn.c
 src/gpgme-w32spawn.c
+@@ -36,6 +36,7 @@
+ # include 
+ #endif
+ #include 
++#include 
+ #include 
+ 
+ #include "priv-io.h"

[Libreoffice-commits] core.git: external/libgpg-error

[Stephan Bergmann (via logerrit)]

 external/libgpg-error/w32-build-fixes-5.patch |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 350c733a033c3ca233a445b5dda38e1fa64f0c9e
Author: Stephan Bergmann 
AuthorDate: Fri Apr 22 21:42:19 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 22 23:19:34 2022 +0200

external/libgpg-error: Missing include (getpid, Windows)

This was apparently missing from d49e7c74d13f01fda923d7399eac11b83b66
"gpg4libre: update gpgme, libassuan and libgpg-error" but went unnoticed so 
far
due to the traditionally lax handling of missing function declarations in 
C, and
only now started to cause

> logging.c(845,57): error: call to undeclared function 'getpid'; ISO C99 
and later do not support implicit function declarations 
[-Wimplicit-function-declaration]
>   (unsigned int)getpid (), 
pidsuf);
> ^

with clang-cl 15 trunk after


"[C11/C2x] Change the behavior of the implicit function declaration 
warning".

Change-Id: I66dc409f629d9bda807bc9cca21a8a5ecdda79be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/18
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/libgpg-error/w32-build-fixes-5.patch 
b/external/libgpg-error/w32-build-fixes-5.patch
index 8a65cedea2da..4e04e47a31d8 100644
--- a/external/libgpg-error/w32-build-fixes-5.patch
+++ b/external/libgpg-error/w32-build-fixes-5.patch
@@ -43,12 +43,13 @@
 
 --- src/logging.c  2020-06-05 18:58:59.254413200 +0200
 +++ src/logging.c~ 2019-12-12 15:23:37.0 +0100
-@@ -44,7 +44,11 @@
+@@ -44,7 +44,12 @@
  # include 
  # include 
  #endif /*!HAVE_W32_SYSTEM*/
 +#ifdef _WIN32
 +# include 
++# include 
 +#else
 +# include 
 +#endif

[Libreoffice-bugs] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #79 from sdc.bla...@youmail.dk ---
Proposal for a new ToD:

Never use certain arrow styles?  Remove them with the Delete button on the
Format > Text Box and Shape > Line > Arrow Styles tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 127294] Add more tips of the day (and make it module-specific eventually)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127294

--- Comment #79 from sdc.bla...@youmail.dk ---
Proposal for a new ToD:

Never use certain arrow styles?  Remove them with the Delete button on the
Format > Text Box and Shape > Line > Arrow Styles tab.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148620] Crash in Draw and Impress when using Format > Lists > Move Down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148620

--- Comment #11 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/5a55e11df328634547cd091933f8228b834a6f25

tdf#148620: sd: add UItest

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sd/qa

[Xisco Fauli (via logerrit)]

 sd/qa/uitest/impress_tests/tdf148620.py |   77 
 1 file changed, 77 insertions(+)

New commits:
commit 5a55e11df328634547cd091933f8228b834a6f25
Author: Xisco Fauli 
AuthorDate: Tue Apr 19 16:25:14 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 22 22:43:38 2022 +0200

tdf#148620: sd: add UItest

I tried to implement this test as a CppUnittest but
'.uno:OutlineUp' and '.uno:OutlineDown' do nothing there

Change-Id: Ie0d35abcc423999891d6a5dac07ec55d4ca8ee71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133176
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit e9dbbf0f184e4f742d5f0e1a6bc9adcd9d765739)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133283

diff --git a/sd/qa/uitest/impress_tests/tdf148620.py 
b/sd/qa/uitest/impress_tests/tdf148620.py
new file mode 100644
index ..a703d722d8dd
--- /dev/null
+++ b/sd/qa/uitest/impress_tests/tdf148620.py
@@ -0,0 +1,77 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.uihelper.common import get_state_as_dict
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.framework import UITestCase
+
+class Tdf148620(UITestCase):
+
+def test_Tdf148620(self):
+with self.ui_test.create_doc_in_start_center("impress") as document:
+
+xTemplateDlg = self.xUITest.getTopFocusWindow()
+xCancelBtn = xTemplateDlg.getChild("close")
+self.ui_test.close_dialog_through_button(xCancelBtn)
+
+xDoc = self.xUITest.getTopFocusWindow()
+xEditWin = xDoc.getChild("impress_win")
+
+xEditWin.executeAction("SELECT", 
mkPropertyValues({"OBJECT":"Unnamed Drawinglayer object 1"}))
+self.assertEqual("com.sun.star.drawing.SvxShapeCollection", 
document.CurrentSelection.getImplementationName())
+
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"one"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"two"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"three"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"four"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"five"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+xEditWin.executeAction("TYPE", mkPropertyValues({"TEXT":"six"}))
+
+self.assertEqual("One\nTwo\nThree\nFour\nFive\nsix", 
document.DrawPages[0].getByIndex(1).String)
+
+xArgs = mkPropertyValues({"KeyModifier": 0})
+self.xUITest.executeCommandWithParameters(".uno:OutlineUp", xArgs)
+self.assertEqual("One\nTwo\nThree\nFour\nsix\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineUp", xArgs)
+self.assertEqual("One\nTwo\nThree\nsix\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineUp", xArgs)
+self.assertEqual("One\nTwo\nsix\nThree\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineUp", xArgs)
+self.assertEqual("One\nsix\nTwo\nThree\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineUp", xArgs)
+self.assertEqual("six\nOne\nTwo\nThree\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineDown", 
xArgs)
+
+# Without the fix in place, this test would have failed with
+# AssertionError: 'One\nsix\nTwo\nThree\nFour\nFive' != 
'One\nTwo\nsix\nThree\nFour\nFive'
+self.assertEqual("One\nsix\nTwo\nThree\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineDown", 
xArgs)
+self.assertEqual("One\nTwo\nsix\nThree\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+self.xUITest.executeCommandWithParameters(".uno:OutlineDown", 
xArgs)
+self.assertEqual("One\nTwo\nThree\nsix\nFour\nFive", 
document.DrawPages[0].getByIndex(1).String)
+
+

[Libreoffice-bugs] [Bug 148737] Improve label and tooltip for Arrow Styles icon in Drawing Objects Properties bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148737

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||148534


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148534
[Bug 148534] [META] Arrow Style
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148534] [META] Arrow Style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148534

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||148737


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148737
[Bug 148737] Improve label and tooltip for Arrow Styles icon in Drawing Objects
Properties bar
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148737] New: Improve label and tooltip for Arrow Styles icon in Drawing Objects Properties bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148737

Bug ID: 148737
   Summary: Improve label and tooltip for Arrow Styles icon in
Drawing Objects Properties bar
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk

1. Select a shape.
2. Look at the Arrow Style icon on the Drawing Objects Properties bar.
3. Click on dropdown box.

Actual: Shows "Arrowheads"
Expected:  "Arrow Styles"  (to be consistent with Arrow Styles tab).

Also, the tooltip from this icon could be improved.

For example:  "Select start and end arrow styles for lines."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148736

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Blocks||148534


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148534
[Bug 148534] [META] Arrow Style
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148534] [META] Arrow Style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148534

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||148736


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148736
[Bug 148736] Popup dialog boxes for Arrow Style tab should use consistent
terminology with the main Arrow style tab
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148736] New: Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148736

Bug ID: 148736
   Summary: Popup dialog boxes for Arrow Style tab should use
consistent terminology with the main Arrow style tab
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk

General issue: popup boxes associated with Arrow Style tab in Line dialog
should refer to "arrow styles" -- for the sake of UI consistency.

Select a textbox or shape, then right-click, choose Line > Arrow Styles tab.

A. Click "Modify"

Actual result:
Popup box with: ”Please enter a name for the new arrowhead”  

Change:  "arrowhead"   –>  ”arrow style” 

B. Click the Delete button with an existing arrow style. (don’t worry, you will
get a confirmation popup)

Actual result:  Popup box with:  Do you really want to delete the arrowhead?

Change:  "arrowhead"   –>  ”arrow style”

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148665] CRASH: importing document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148665

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134387] "LibreOffice Document Recovery" dialog appears even when there is no document to recover

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134387

--- Comment #8 from Gerald Pfeifer  ---
"Thanks" to bug #148735 I can confirm this is still an issue. 

The dialog in this case does not appear on the next startup, rather
LibreOffice is shown in the same invocation, after the crash.


Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: e4243a140345a4bcd800217115b42667e277c6a3
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148665] CRASH: importing document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148665

Xisco Faulí  changed:

   What|Removed |Added

 CC||ger...@pfeifer.com

--- Comment #3 from Xisco Faulí  ---
*** Bug 148735 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] FILEOPEN PPTX: crash upon opening (possibly SmartArt-related?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||xiscofa...@libreoffice.org
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #2 from Xisco Faulí  ---
Issue introduced by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c79fa460fe6220051bbda2d3c0cb67fbf765e2ac
Closing as duplicated of bug 148665

*** This bug has been marked as a duplicate of bug 148665 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] FILEOPEN PPTX: crash upon opening (possibly SmartArt-related?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
   Keywords||filter:pptx
 CC||79045_79...@mail.ru

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: f8e11c6480ff0005715b989a6d4e2e10a3816cf6
CPU threads: 4; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded Jumbo

and no crash in

Version: 7.3.2.2 / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: CL

it's really the regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] FILEOPEN PPTX: crash upon opening (possibly SmartArt-related?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

Gerald Pfeifer  changed:

   What|Removed |Added

Summary|FILEOPEN PPTX: crash|FILEOPEN PPTX: crash upon
   ||opening (possibly
   ||SmartArt-related?)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] FILEOPEN PPTX: crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

Gerald Pfeifer  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148735] New: FILEOPEN PPTX: crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148735

Bug ID: 148735
   Summary: FILEOPEN PPTX: crash
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 179734
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179734=edit
Sample slide (PPTX) that crashes Impress upon opening

Impress recently started crashing open a specific PPTX document;
I am attaching a drastically reduced test case.


Seen with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: e4243a140345a4bcd800217115b42667e277c6a3
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US


Okay with

  Version: 7.3.1.0.0+ / LibreOffice Community
  Build ID: 33d70d68aa67d567e9b18fa5947b86df6e378f32
  CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

down to the following (and older even):

  Version: 7.0.7.0.0+
  Build ID: 54e9dd41dc9dd45af12c9346199f601ea4a5994d
  CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-0, Time:
2021-05-07_08:22:18

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148593

--- Comment #11 from Eyal Rozenberg  ---
(In reply to Regina Henschel from comment #10)

So, do you believe the way forward is to arrange the UI more logically, and
translate back and forth from/to the ODF standard, or to change the two
together?

Also, even keeping in synch with what ODF offers, rearranging boxes and
rewording labels (and possibly listbox items) would still improve readability.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148731] Calc crashes (closes) when scrolling through line items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148731

Julien Nabet  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Julien Nabet  ---
Email received in private:
"
Julien,
I believe I found the fix.
In Libre Calc go to tools tab then select options, pick view and within
graphics output place check mark in the "force skia" box.
The computer I have that Calc worked perfectly had that box checked.  The
machine having the problem had the box unchecked.
All seems to be fine now.
Thanks for your help (forcing me to do more homework). 
"
Please next time, just comment the bugtracker by using this link:
https://bugs.documentfoundation.org/show_bug.cgi?id=148731#

Thank you for the feedback anyway and let's put this one to WFM then.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: librelogo/source

[László Németh (via logerrit)]

 librelogo/source/LibreLogo/LibreLogo.py |   71 +++-
 1 file changed, 70 insertions(+), 1 deletion(-)

New commits:
commit 89c34706331984d12af8ce99444d53f19b40b496
Author: László Németh 
AuthorDate: Sun Apr 10 19:53:56 2022 +0200
Commit: László Németh 
CommitDate: Fri Apr 22 20:46:35 2022 +0200

LibreLogo: add basic HTML formatting support to LABEL

It's possible to format character spans in text
of LABEL, as bold, italic and underline text
using HTML tags ,  and  and their
lowercase equivalents. For example,

LABEL 'Italic, also bold and underline.'

Use HTML "" to avoid of the replacement. For example,

LABEL 'some i>text/i>'

prints "some text" instead of "some text"
with italic "text" in it.

Change-Id: I70fd97763c6c488eba23c168a541b84cff0c90e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132786
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/librelogo/source/LibreLogo/LibreLogo.py 
b/librelogo/source/LibreLogo/LibreLogo.py
index 804057a9689d..7aa71cac7be0 100644
--- a/librelogo/source/LibreLogo/LibreLogo.py
+++ b/librelogo/source/LibreLogo/LibreLogo.py
@@ -203,6 +203,7 @@ from com.sun.star.drawing.CircleKind import CUT as __CUT__
 from com.sun.star.drawing.CircleKind import ARC as __ARC__
 from com.sun.star.awt.FontSlant import NONE as __Slant_NONE__
 from com.sun.star.awt.FontSlant import ITALIC as __Slant_ITALIC__
+from com.sun.star.awt.FontUnderline import SINGLE as __Underline_SINGLE__
 from com.sun.star.awt import Size as __Size__
 from com.sun.star.awt import WindowDescriptor as __WinDesc__
 from com.sun.star.awt.WindowClass import MODALTOP as __MODALTOP__
@@ -1270,8 +1271,55 @@ def label(st):
 _.shapecache[__ACTUAL__] = actual
 return z
 
-def text(shape, st):
+def __get_HTML_format__(orig_st):
+  "Process HTML-like tags, and return with text and formatting vector"
+  st = orig_st.replace('', '\uE000')
+  if not ('<' in st and '>' in st):
+  return st.replace('\uE000', '<'), None
+  tex = "" # characters without HTML tags
+  pat = [] # bit vectors of the previous characters
+  # 1st bit: bold
+  # 2nd bit: italic
+  # 3rd bit: underline
+  f = 0
+  tags = ['', '', '', '', '', '']
+  # store embedding level of the same element to disable it
+  # only at the most outer closing tag, e.g. a double italic here, 
too
+  bit_level = {0: 0, 1: 0, 2: 0}
+  i = 0
+  while i < len(st):
+  is_tag = False
+  for j in range(len(tags)):
+  if st[i:i + 4].lower().startswith(tags[j]):
+  bit = j // 2
+  # opening tag
+  if j % 2 == 0:
+  f |= (1 << bit)
+  bit_level[bit] += 1
+  else:
+  if bit_level[bit] > 0:
+  bit_level[bit] -= 1
+  if bit_level[bit] == 0:
+  f &= ~(1 << bit)
+  i += len(tags[j]) - 1
+  is_tag = True
+  break
+
+  if not is_tag:
+  tex = tex + st[i]
+  pat.append(f)
+  i += 1
+
+  # no tags
+  if len(st) == len(tex):
+  pat = None
+
+  return tex.replace('\uE000', '<'), pat
+
+def text(shape, orig_st):
 if shape:
+# analyse HTML
+st, formatting = __get_HTML_format__(orig_st)
 shape.setString(__string__(st, _.decimal))
 c = shape.createTextCursor()
 c.gotoStart(False)
@@ -1281,6 +1329,27 @@ def text(shape, st):
 c.CharWeight = __fontweight__(_.fontweight)
 c.CharPosture = __fontstyle__(_.fontstyle)
 c.CharFontName = _.fontfamily
+# has HTML-like formatting
+if formatting != None:
+prev_format = 0
+c.collapseToStart()
+n = 0 # length of the previous text span
+formatting.append(0) # add terminating 0 to process last span
+for i in formatting:
+if i != prev_format:
+do_formatting = prev_format != 0
+c.goRight(n, do_formatting) # move cursor with optional 
selection
+if do_formatting:
+if prev_format & (1 << 0):
+c.CharWeight = 150
+if prev_format & (1 << 1):
+c.CharPosture = __Slant_ITALIC__
+if prev_format & (1 << 2):
+c.CharUnderline = __Underline_SINGLE__
+c.collapseToEnd()
+n = 0
+n += 1
+prev_format = i
 
 def sleep(t):
 _.time = _.time + t

[Libreoffice-bugs] [Bug 148734] New: In LibreOffice Draw, grouped objects become inactive, faded, and cannot be selected or edited.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148734

Bug ID: 148734
   Summary: In LibreOffice Draw, grouped objects become inactive,
faded, and cannot be selected or edited.
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: daisukeda...@gmail.com

This happens when I am working with at least two sets of grouped objects
(shapes) in a Draw document. If I edit an object in one group, the other
grouped objects become inactive, cannot be clicked on or edited. They appear
faded or greyed out although the dimmed colors are still there. So far the only
way to work around this state is to ctrl-z back to the point when they were not
faded.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148733] New: The active font isn't filtered in the Character dialog on open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148733

Bug ID: 148733
   Summary: The active font isn't filtered in the Character dialog
on open
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
The active font isn't filtered in the Character dialog on open

Steps to Reproduce:
1. Open Writer
2. type Hello World
3. Select hello world
4. Format (menu item) -> Character -> Font tab
5. In the font input field states: Calibri (in my case) but isn't filtered in
the list 
6. Press reset button (now it's working as expected)

Actual Results:
The input field is a filter field. However it doesn't filter

Expected Results:
It should filter the font


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148732] UI: Default Character in Format Styles is called No Character Style in character styles deck of the sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148732

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148732] UI: Default Character in Format Styles is called No Character Style in character styles deck of the sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148732

Telesto  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148732] New: UI: Default Character in Format Styles is called No Character Style in character styles deck of the sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148732

Bug ID: 148732
   Summary: UI: Default Character in Format Styles is called No
Character Style in character styles deck of the
sidebar
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Default Character in Format Styles is called No Character Style in character
styles deck of the sidebar

Steps to Reproduce:
1. Open Writer
2. Type some text: Hello World
3. Select Hello World
4. Styles (menu bar) -> Emphasis and back to Default Character Style
5. Sidebar -> Styles Deck -> Character Styles -> Calls it No Character Style

Actual Results:
Styles in Menubar calles it 'Default Character Style"

Expected Results:
It should be No Character Style I guess


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138327

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Depends on|148422  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148422
[Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved ||
(rSData[0].m_nRedlineCount ==
rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function
SetSaveData, file undobj.cxx, line 1487.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved || (rSData[0].m_nRedlineCount == rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function Se

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148422

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Blocks|138327  |

--- Comment #6 from Michael Stahl (allotropia)  ---
this doesn't look like redlinehide-regression


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138327
[Bug 138327] [META] sw_redlinehide regressions (track changes)
-- 
You are receiving this mail because:
You are the assignee for the bug.

Łukasz Leszko license statement

[Łukasz Leszko]

All of my past & future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.

[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138327

Telesto  changed:

   What|Removed |Added

 Depends on||148461


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148461
[Bug 148461] Assertion failed: (pMerged->pFirstNode->GetIndex() <= i), function
DelFrames, file node.cxx, line 1444.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148461] Assertion failed: (pMerged->pFirstNode->GetIndex() <= i), function DelFrames, file node.cxx, line 1444.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148461

Telesto  changed:

   What|Removed |Added

 Blocks||138327


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138327
[Bug 138327] [META] sw_redlinehide regressions (track changes)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138327] [META] sw_redlinehide regressions (track changes)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138327

Telesto  changed:

   What|Removed |Added

 Depends on||148422


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148422
[Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved ||
(rSData[0].m_nRedlineCount ==
rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function
SetSaveData, file undobj.cxx, line 1487.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved || (rSData[0].m_nRedlineCount == rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function Se

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148422

Telesto  changed:

   What|Removed |Added

 Blocks||138327


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138327
[Bug 138327] [META] sw_redlinehide regressions (track changes)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148282] Make sure thumbnails in start center are readable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148282

--- Comment #12 from barrett...@owageskuo.com ---
I didn't realize a ticket for this existed. I'll post my description here in
case it helps describe the issue:

"When I launch LibreOffice the main app, not a specific one like Writer or Draw
it will show a bunch of previews for recent files. The issue is that I am using
dark mode and all of my documents are dark themed but the previews seem to be
inverted and show white mode. This does not match what the documents actually
look like when opened.

Preferably the document previews would show what the document would actually
look like if using dark mode. I have stopped using the main LibreOffice app and
go directly into Write, Draw, Calc etc instead because I don't like being
visually blasted by most of my screens showing white documents."

Thanks for all of your hard work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - ucb/CppunitTest_ucb_webdav_core.mk ucb/Library_ucpdav1.mk ucb/source

[Michael Stahl (via logerrit)]

 ucb/CppunitTest_ucb_webdav_core.mk   |1 +
 ucb/Library_ucpdav1.mk   |1 +
 ucb/source/ucp/webdav-curl/webdavcontent.cxx |8 ++--
 3 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit aa6c8686b74cf0f87fbaf99dc113649ffaacdb5c
Author: Michael Stahl 
AuthorDate: Tue Apr 19 18:01:37 2022 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Apr 22 19:49:20 2022 +0200

ucb: webdav-curl: put user name from config into LOCK request

... so that the dialog in SfxMedium::LockOrigFileOnDemand() can show
something more useful than hard-coded URL, which has been used since
commit 99bdd887a6141883878978bad9beb35e7b326cd1 in 2009 when locking
was added.

This is half of the user info that is put into LO's own lock files
(see svt::LockFileCommon::GenerateOwnEntry()).

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133186
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 70bea73ffbe815c2d5b7067f20d3eebbb98df61f)

ucb: webdav-curl: check UseUserData before sending user name

Hope this should be acceptable.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133188
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 6d7c3848560883034a4ff12ac1ef52d2d1d28606)

Change-Id: Iefac724644a536fc37c3c79ce862e25bd9be38af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133143
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/ucb/CppunitTest_ucb_webdav_core.mk 
b/ucb/CppunitTest_ucb_webdav_core.mk
index fbd3f59f55f6..0df1feefff21 100644
--- a/ucb/CppunitTest_ucb_webdav_core.mk
+++ b/ucb/CppunitTest_ucb_webdav_core.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_CppunitTest_use_libraries,ucb_webdav_core, \
cppuhelper \
sal \
salhelper \
+   svl \
test \
ucbhelper \
tl \
diff --git a/ucb/Library_ucpdav1.mk b/ucb/Library_ucpdav1.mk
index b8cbb2be48e1..8574c6ff47a4 100644
--- a/ucb/Library_ucpdav1.mk
+++ b/ucb/Library_ucpdav1.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Library_use_libraries,ucpdav1,\
cppuhelper \
sal \
salhelper \
+   svl \
ucbhelper \
tl \
 ))
diff --git a/ucb/source/ucp/webdav-curl/webdavcontent.cxx 
b/ucb/source/ucp/webdav-curl/webdavcontent.cxx
index 1eb069a3480e..513626b8d73b 100644
--- a/ucb/source/ucp/webdav-curl/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-curl/webdavcontent.cxx
@@ -22,12 +22,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -3236,8 +3238,10 @@ void Content::lock(
 }
 
 uno::Any aOwnerAny;
-aOwnerAny
-<<= OUString("LibreOffice - http://www.libreoffice.org/;);
+OUString const 
user(officecfg::Office::Common::Save::Document::UseUserData::get()
+? " - " + ::svt::LockFileCommon::GetOOOUserName()
+: OUString());
+aOwnerAny <<= OUString("LibreOffice" + user);
 
 ucb::Lock aLock(
 ucb::LockScope_EXCLUSIVE,

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - 2 commits - sfx2/source ucb/source

[Michael Stahl (via logerrit)]

 sfx2/source/view/viewfrm.cxx|3 +-
 ucb/source/ucp/webdav-curl/webdavresponseparser.cxx |   22 ++--
 2 files changed, 22 insertions(+), 3 deletions(-)

New commits:
commit 1d5293dc8c010d0b81827682f30699fc597b7729
Author: Michael Stahl 
AuthorDate: Tue Apr 19 17:34:52 2022 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Apr 22 19:49:08 2022 +0200

ucb: webdav-curl: fix getting DAV:lockdiscovery property

commit b4576f3da4d90139fc5140962d13cb91dab98797 "tdf#82744: fix WebDAV
lock/unlock behaviour - part 3" added a call to get the
DAV:lockdiscovery property.

But WebDAVResponseParser puts lock related properties into a separate
return value maResult_Lock that is only returned for LOCK requests.

Just add it as a normal property too, then PROPFIND can get it, and
the dialog in SfxMedium::LockOrigFileOnDemand() no longer displays
"Unknown user".

Change-Id: Icee920588ea40b6e203b18287d75484528cfdebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133185
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 68f41f4e2dcec65e8885cdfa658c0568a26182a9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133142
Reviewed-by: Thorsten Behrens 

diff --git a/ucb/source/ucp/webdav-curl/webdavresponseparser.cxx 
b/ucb/source/ucp/webdav-curl/webdavresponseparser.cxx
index a236957c096e..8b7d0473585c 100644
--- a/ucb/source/ucp/webdav-curl/webdavresponseparser.cxx
+++ b/ucb/source/ucp/webdav-curl/webdavresponseparser.cxx
@@ -22,11 +22,13 @@
 #include "DAVProperties.hxx"
 #include "UCBDeadPropertyValue.hxx"
 
-#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -75,6 +77,7 @@ namespace
 {
 WebDAVName_unknown = 0,
 WebDAVName_activelock,
+WebDAVName_lockdiscovery,
 WebDAVName_multistatus,
 WebDAVName_response,
 WebDAVName_href,
@@ -114,6 +117,7 @@ namespace
 if(aWebDAVNameMapperList.empty())
 {
 
aWebDAVNameMapperList.insert(WebDAVNameValueType(OUString("activelock"), 
WebDAVName_activelock));
+
aWebDAVNameMapperList.insert(WebDAVNameValueType(OUString("lockdiscovery"), 
WebDAVName_lockdiscovery));
 
aWebDAVNameMapperList.insert(WebDAVNameValueType(OUString("multistatus"), 
WebDAVName_multistatus));
 
aWebDAVNameMapperList.insert(WebDAVNameValueType(OUString("response"), 
WebDAVName_response));
 aWebDAVNameMapperList.insert(WebDAVNameValueType(OUString("href"), 
WebDAVName_href));
@@ -751,6 +755,20 @@ namespace
 maResult_Lock.push_back(maLock);
 break;
 }
+case WebDAVName_lockdiscovery:
+{
+// lockdiscovery may be requested via PROPFIND,
+// in addition to LOCK! so return it 2 ways
+if (isCollectingProperties())
+{
+http_dav_ucp::DAVPropertyValue 
aDAVPropertyValue;
+
+aDAVPropertyValue.Name = 
"DAV:lockdiscovery";
+aDAVPropertyValue.Value <<= 
::comphelper::containerToSequence(maResult_Lock);
+
maPropStatProperties.push_back(aDAVPropertyValue);
+}
+break;
+}
 case WebDAVName_propstat:
 {
 // propstat end, check status
commit 5b5fb5e9c0580ecb70cf65882865bdaf16498fa5
Author: Michael Stahl 
AuthorDate: Tue Apr 19 14:09:08 2022 +0200
Commit: Thorsten Behrens 
CommitDate: Fri Apr 22 19:48:55 2022 +0200

sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()

commit b505ca5b9c31b3d9c639406d03a25bea4e914242 "Switch to read-only
mode: do not force reload document if possible" replaced "true" with
"bNeedsReload" here - but this is a problem when switching from
read-only to editable.

1. Start LO and load a document from WebDAV editable
2. Start other LO and load the same document from WebDAV read-only
3. In first LO, edit document, store it and close it
4. In second LO, click "Edit Document" button
5. LO doesn't reload the document and shows stale content

It's not clear what problem that commit was trying to solve, but let's
assume that it intended to change only what happens when switching from
editable to read-only.

Change-Id: I69c779c5c0c5c2ccda677ea8cb353c8716916861
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133171
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry 

[Libreoffice-bugs] [Bug 148731] Calc crashes (closes) when scrolling through line items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148731

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Does it happen on any files (for example a brand new files containing just 0s)
or  is it specific to a file?

Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source sd/qa

[Xisco Fauli (via logerrit)]

 oox/source/drawingml/textcharacterproperties.cxx |6 +++
 sd/qa/unit/data/pptx/tdf148685.pptx  |binary
 sd/qa/unit/import-tests2.cxx |   43 +++
 3 files changed, 49 insertions(+)

New commits:
commit 1c924efe1f80207a5e104d755615b1eb9a91d418
Author: Xisco Fauli 
AuthorDate: Wed Apr 20 17:58:15 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 22 19:37:36 2022 +0200

tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties

Change-Id: Iebf482434cd393f55ae3e4690580b573624d78b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133219
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/oox/source/drawingml/textcharacterproperties.cxx 
b/oox/source/drawingml/textcharacterproperties.cxx
index 9d568cd5cabb..fc8214db42fe 100644
--- a/oox/source/drawingml/textcharacterproperties.cxx
+++ b/oox/source/drawingml/textcharacterproperties.cxx
@@ -201,6 +201,12 @@ void TextCharacterProperties::pushToPropMap( PropertyMap& 
rPropMap, const XmlFil
 rPropMap.setProperty( PROP_CharUnderlineHasColor, true);
 rPropMap.setProperty( PROP_CharUnderlineColor, 
maUnderlineColor.getColor( rFilter.getGraphicHelper() ));
 }
+else
+{
+rPropMap.setProperty( PROP_CharUnderlineHasColor, false);
+rPropMap.setProperty( PROP_CharUnderlineColor, sal_Int32(-1));
+}
+
 // TODO If bUnderlineFillFollowText uFillTx 
(CT_TextUnderlineFillFollowText) is set, fill color of the underline should be 
the same color as the text
 
 if (maHighlightColor.isUsed() && maHighlightColor.getTransparency() != 100)
diff --git a/sd/qa/unit/data/pptx/tdf148685.pptx 
b/sd/qa/unit/data/pptx/tdf148685.pptx
new file mode 100644
index ..80af5a9bbf46
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf148685.pptx differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 0bb99100b9dd..b06a699b04bd 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -72,6 +72,7 @@ public:
 void testAoo124143();
 void testTdf103567();
 void testTdf103792();
+void testTdf148685();
 void testTdf103876();
 void testTdf79007();
 void testTdf119649();
@@ -142,6 +143,7 @@ public:
 CPPUNIT_TEST(testAoo124143);
 CPPUNIT_TEST(testTdf103567);
 CPPUNIT_TEST(testTdf103792);
+CPPUNIT_TEST(testTdf148685);
 CPPUNIT_TEST(testTdf103876);
 CPPUNIT_TEST(testTdf79007);
 CPPUNIT_TEST(testTdf119649);
@@ -436,6 +438,47 @@ void SdImportTest2::testTdf103792()
 xDocShRef->DoClose();
 }
 
+void SdImportTest2::testTdf148685()
+{
+sd::DrawDocShellRef xDocShRef
+= 
loadURL(m_directories.getURLFromSrc(u"/sd/qa/unit/data/pptx/tdf148685.pptx"), 
PPTX);
+uno::Reference xShape(getShapeFromPage(1, 0, 
xDocShRef));
+
+uno::Reference const xParagraph(getParagraphFromShape(0, 
xShape));
+
+uno::Reference xRun(getRunFromParagraph(0, xParagraph));
+CPPUNIT_ASSERT_EQUAL(OUString("TEXT "), xRun->getString());
+
+uno::Reference xPropSet(xRun, uno::UNO_QUERY_THROW);
+
+Color nCharUnderlineColor;
+xPropSet->getPropertyValue("CharUnderlineColor") >>= nCharUnderlineColor;
+CPPUNIT_ASSERT_EQUAL(Color(0xA1467E), nCharUnderlineColor);
+
+xRun.set(getRunFromParagraph(1, xParagraph));
+
+CPPUNIT_ASSERT_EQUAL(OUString("TE"), xRun->getString());
+
+xPropSet.set(xRun, uno::UNO_QUERY_THROW);
+
+xPropSet->getPropertyValue("CharUnderlineColor") >>= nCharUnderlineColor;
+
+// Without the fix in place, this test would have failed with
+// - Expected: Color: R:255 G:255 B:255 A:255
+// - Actual  : Color: R:161 G:70 B:126 A:0
+CPPUNIT_ASSERT_EQUAL(COL_AUTO, nCharUnderlineColor);
+
+xRun.set(getRunFromParagraph(2, xParagraph));
+CPPUNIT_ASSERT_EQUAL(OUString("XT"), xRun->getString());
+
+xPropSet.set(xRun, uno::UNO_QUERY_THROW);
+
+xPropSet->getPropertyValue("CharUnderlineColor") >>= nCharUnderlineColor;
+CPPUNIT_ASSERT_EQUAL(COL_AUTO, nCharUnderlineColor);
+
+xDocShRef->DoClose();
+}
+
 void SdImportTest2::testTdf103876()
 {
 // Title text shape's placeholder text did not inherit the corresponding 
text properties

[Libreoffice-bugs] [Bug 147453] EDITING: Disable "Delete Selected Table/Rows" on already deleted rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147453

--- Comment #3 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0204c00f241313e1d292b4c3ea117d42af7dec69

tdf#147453 sw: disable Delete Table functions on tracked deletions

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147453] EDITING: Disable "Delete Selected Table/Rows" on already deleted rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147453

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143002
Bug 143002 depends on bug 147453, which changed state.

Bug 147453 Summary: EDITING: Disable "Delete Selected Table/Rows" on already 
deleted rows
https://bugs.documentfoundation.org/show_bug.cgi?id=147453

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147453] EDITING: Disable "Delete Selected Table/Rows" on already deleted rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147453

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[László Németh (via logerrit)]

 sw/source/uibase/shells/tabsh.cxx |   46 --
 1 file changed, 44 insertions(+), 2 deletions(-)

New commits:
commit 0204c00f241313e1d292b4c3ea117d42af7dec69
Author: László Németh 
AuthorDate: Fri Apr 22 13:23:55 2022 +0200
Commit: László Németh 
CommitDate: Fri Apr 22 19:24:17 2022 +0200

tdf#147453 sw: disable Delete Table functions on tracked deletions

In Show Changes mode, disable "Delete Selected Rows" icons
and the same menu options in the following cases:

- no table selection, but the text cursor in a deleted table row;

- with table selection, all selected cells in deleted table rows.

Disable also "Deleted Selected Columns" and "Delete Table"
icons and the same menu options, when the cursor is there
in a deleted table.

Follow-up to commit c4f6fee3bea0d8618b5815e60304ff9359ccd21c
"tdf#147435 sw: enable Accept Change for table selection".

Change-Id: Ic6781ccee794c7458e6979f2e981840339cd3883
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133320
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/source/uibase/shells/tabsh.cxx 
b/sw/source/uibase/shells/tabsh.cxx
index a7136e38ba17..9dbb1b689e8e 100644
--- a/sw/source/uibase/shells/tabsh.cxx
+++ b/sw/source/uibase/shells/tabsh.cxx
@@ -55,6 +55,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -443,6 +444,43 @@ static void lcl_TabGetMaxLineWidth(const SvxBorderLine* 
pBorderLine, SvxBorderLi
 rBorderLine.SetColor(pBorderLine->GetColor());
 }
 
+static bool lcl_BoxesInDeletedRows(SwWrtShell , const SwSelBoxes& rBoxes)
+{
+// cursor and selection are there only in deleted rows in Show Changes mode
+if ( rSh.GetLayout()->IsHideRedlines() )
+return false;
+
+// not selected or all selected rows are deleted
+bool bRet = true;
+SwRedlineTable::size_type nRedlinePos = 0;
+if ( rBoxes.empty() )
+bRet = 
rSh.GetCursor()->GetNode().GetTableBox()->GetUpper()->IsDeleted(nRedlinePos);
+else
+{
+tools::Long nBoxes = rBoxes.size();
+SwTableLine* pPrevLine = nullptr;
+for ( tools::Long i = 0; i < nBoxes; i++ )
+{
+SwTableLine* pLine = rBoxes[i]->GetUpper();
+if ( pLine != pPrevLine )
+bRet &= pLine->IsDeleted(nRedlinePos);
+pPrevLine = pLine;
+}
+}
+
+return bRet;
+}
+
+static bool lcl_CursorInDeletedTable(SwWrtShell )
+{
+// cursor and selection are there only in deleted table in Show Changes 
mode
+if ( rSh.GetLayout()->IsHideRedlines() )
+return false;
+
+SwTableNode* pTableNd = 
rSh.GetCursor()->GetPoint()->nNode.GetNode().FindTableNode();
+return pTableNd && pTableNd->GetTable().IsDeleted();
+}
+
 void SwTableShell::Execute(SfxRequest )
 {
 const SfxItemSet* pArgs = rReq.GetArgs();
@@ -1380,7 +1418,7 @@ void SwTableShell::GetState(SfxItemSet )
 {
 SwSelBoxes aBoxes;
 ::GetTableSel( rSh, aBoxes, SwTableSearchType::Row );
-if( ::HasProtectedCells( aBoxes ))
+if( ::HasProtectedCells( aBoxes ) || 
lcl_BoxesInDeletedRows( rSh, aBoxes ) )
 rSet.DisableItem( nSlot );
 }
 break;
@@ -1388,10 +1426,14 @@ void SwTableShell::GetState(SfxItemSet )
 {
 SwSelBoxes aBoxes;
 ::GetTableSel( rSh, aBoxes, SwTableSearchType::Col );
-if( ::HasProtectedCells( aBoxes ))
+if( ::HasProtectedCells( aBoxes ) || 
lcl_CursorInDeletedTable( rSh ) )
 rSet.DisableItem( nSlot );
 }
 break;
+case FN_TABLE_DELETE_TABLE:
+if( lcl_CursorInDeletedTable( rSh ) )
+rSet.DisableItem( nSlot );
+break;
 
 case FN_TABLE_UNSET_READ_ONLY_CELLS:
 // disable in readonly sections, but enable in protected cells

[Libreoffice-bugs] [Bug 148731] New: Calc crashes (closes) when scrolling through line items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148731

Bug ID: 148731
   Summary: Calc crashes (closes) when scrolling through line
items
   Product: LibreOffice
   Version: 7.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mar...@mailfence.com

Description:
Every update of Libre Office past 7.2.5.2 causes Calc to crash when scrolling
through line items.  This only happens on computer: MSI B450 Max II
motherboard, AMD Ryzen 5 5600G with GEForce 1030 graphics, running Win 10 64
bit 21H2 version 19044.1645.  When using the AMD Radeon graphics, the same
thing happens.

Steps to Reproduce:
1.Open calc
2.scroll up or down through data fields
3.scrolling freezes and calc closes

Actual Results:
See above

Expected Results:
Calc closes unexpectedly


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Continue scrolling without crashing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148673

--- Comment #9 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #8)
> No strong opinion on this ... 
Aww..that is disappointing.  I was sure that at least you would like the idea
of removing the offer to apply DF numbering to Heading N paragraphs in an
outline bar.

> except one: please stop using "headings" here.
No problem. See comment 3  ("neutral about name change"). 
I appreciate that there is much confusion/debate about this terminology -- and
I am not trying to participate in that discussion -- or to promote particular
terminology.

But I needed to use some words to communicate about the functionality. Sorry if
my "lay" terms were a source of distress. But today you have given some
technical definitions, which are fine with me -- so from bug 141452 comment
#24:
>* Heading is a paragraph having an outline level other than "Text Body".
That was also my understanding. And that was also my intended meaning of
"heading" here. Concretely, whenever the cursor is in a paragraph with outline
level other than Text Body, then a special toolbar (not Bullets and Numbering)
should appear.

But after some experiments and reflection, I now see/believe that it only makes
sense for a context-sensitive toolbar to appear when the cursor is placed in a
Heading N PS paragraph – for the primary reason that it is not possible to
change the outline level of Heading paragraphs that are non-Heading N (using
toolbar/menu commands). (which by luck was also the OP).

With that additional condition (only show context-sensitive toolbar for Heading
N PS), then it makes a lot of sense to call a context-sensitive toolbar for
“Outline” (which is also the name that the Organizer uses to show “List Style”
for Heading N PS).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148673] Should the Bullet and Numbering toolbar also appear with unnumbered (chapter) headings?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148673

--- Comment #9 from sdc.bla...@youmail.dk ---
(In reply to Mike Kaganski from comment #8)
> No strong opinion on this ... 
Aww..that is disappointing.  I was sure that at least you would like the idea
of removing the offer to apply DF numbering to Heading N paragraphs in an
outline bar.

> except one: please stop using "headings" here.
No problem. See comment 3  ("neutral about name change"). 
I appreciate that there is much confusion/debate about this terminology -- and
I am not trying to participate in that discussion -- or to promote particular
terminology.

But I needed to use some words to communicate about the functionality. Sorry if
my "lay" terms were a source of distress. But today you have given some
technical definitions, which are fine with me -- so from bug 141452 comment
#24:
>* Heading is a paragraph having an outline level other than "Text Body".
That was also my understanding. And that was also my intended meaning of
"heading" here. Concretely, whenever the cursor is in a paragraph with outline
level other than Text Body, then a special toolbar (not Bullets and Numbering)
should appear.

But after some experiments and reflection, I now see/believe that it only makes
sense for a context-sensitive toolbar to appear when the cursor is placed in a
Heading N PS paragraph – for the primary reason that it is not possible to
change the outline level of Heading paragraphs that are non-Heading N (using
toolbar/menu commands). (which by luck was also the OP).

With that additional condition (only show context-sensitive toolbar for Heading
N PS), then it makes a lot of sense to call a context-sensitive toolbar for
“Outline” (which is also the name that the Organizer uses to show “List Style”
for Heading N PS).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148723] Request improvement :Create a REFLECT text effect in Font attributes like italic, bold...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148723

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Well this is not is ODF spec. We can do it manually after a fashion, with a
conversion of the text string to curve, a copy paste, an invert and some
fiddling with the resulting SVG.  ODF supports that, but not very
convenient--and this is a convenience feature.  Do wonder what happens on LO
import of OOXML text with that "attribute" in use.

Doing it seamlessly as a font attribute seems out of scope to project, with no
need to extend ODF to accomodate. But there could be valid interoperability
issues to address.

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148723] Request improvement :Create a REFLECT text effect in Font attributes like italic, bold...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148723

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Well this is not is ODF spec. We can do it manually after a fashion, with a
conversion of the text string to curve, a copy paste, an invert and some
fiddling with the resulting SVG.  ODF supports that, but not very
convenient--and this is a convenience feature.  Do wonder what happens on LO
import of OOXML text with that "attribute" in use.

Doing it seamlessly as a font attribute seems out of scope to project, with no
need to extend ODF to accomodate. But there could be valid interoperability
issues to address.

IMHO => WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basic/source

[Julien Nabet (via logerrit)]

 basic/source/inc/rtlproto.hxx|1 +
 basic/source/runtime/methods.cxx |   19 +--
 basic/source/runtime/stdobj.cxx  |7 +++
 3 files changed, 25 insertions(+), 2 deletions(-)

New commits:
commit 975bc84af3b3b3d251e68bcb86b0d0e619e0987c
Author: Julien Nabet 
AuthorDate: Mon Apr 18 19:37:10 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 22 18:46:41 2022 +0200

tdf#148651: implement VBA.FormatPercent

I started from a copy/paste of FormatNumber.
Then I deduplicated the code (it saved about 99% of it).

Change-Id: Ibcb9ffbf8cebf45d5ffac4713e3d220b8499ba11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133133
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133246
Reviewed-by: Xisco Fauli 

diff --git a/basic/source/inc/rtlproto.hxx b/basic/source/inc/rtlproto.hxx
index 7347ead45dc1..ff089d6b0dbd 100644
--- a/basic/source/inc/rtlproto.hxx
+++ b/basic/source/inc/rtlproto.hxx
@@ -233,6 +233,7 @@ extern void SbRtl_IsUnoStruct(StarBASIC * pBasic, SbxArray 
& rPar, bool bWrite);
 extern void SbRtl_FileDateTime(StarBASIC * pBasic, SbxArray & rPar, bool 
bWrite);
 extern void SbRtl_Format(StarBASIC * pBasic, SbxArray & rPar, bool bWrite);
 extern void SbRtl_FormatNumber(StarBASIC* pBasic, SbxArray& rPar, bool bWrite);
+extern void SbRtl_FormatPercent(StarBASIC* pBasic, SbxArray& rPar, bool 
bWrite);
 extern void SbRtl_GetAttr(StarBASIC * pBasic, SbxArray & rPar, bool bWrite);
 extern void SbRtl_Randomize(StarBASIC * pBasic, SbxArray & rPar, bool bWrite); 
// JSM
 extern void SbRtl_Round(StarBASIC * pBasic, SbxArray & rPar, bool bWrite);
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index e678b8852838..851584b6db79 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -3337,8 +3337,7 @@ void SbRtl_Format(StarBASIC *, SbxArray & rPar, bool)
 }
 }
 
-// 
https://msdn.microsoft.com/en-us/vba/language-reference-vba/articles/formatnumber-function
-void SbRtl_FormatNumber(StarBASIC*, SbxArray& rPar, bool)
+static void lcl_FormatNumberPercent(SbxArray& rPar, bool isPercent)
 {
 const sal_uInt32 nArgCount = rPar.Count();
 if (nArgCount < 2 || nArgCount > 6)
@@ -3421,6 +3420,8 @@ void SbRtl_FormatNumber(StarBASIC*, SbxArray& rPar, bool)
 }
 
 double fVal = rPar.Get(1)->GetDouble();
+if (isPercent)
+fVal *= 100;
 const bool bNegative = fVal < 0;
 if (bNegative)
 fVal = fabs(fVal); // Always work with non-negatives, to easily handle 
leading zero
@@ -3462,6 +3463,20 @@ void SbRtl_FormatNumber(StarBASIC*, SbxArray& rPar, bool)
 }
 
 rPar.Get(0)->PutString(aResult);
+if (isPercent)
+aResult += "%";
+}
+
+// 
https://docs.microsoft.com/en-us/office/vba/Language/Reference/User-Interface-Help/formatnumber-function
+void SbRtl_FormatNumber(StarBASIC*, SbxArray& rPar, bool)
+{
+return lcl_FormatNumberPercent(rPar, false);
+}
+
+// 
https://docs.microsoft.com/en-us/office/vba/Language/Reference/User-Interface-Help/formatpercent-function
+void SbRtl_FormatPercent(StarBASIC*, SbxArray& rPar, bool)
+{
+return lcl_FormatNumberPercent(rPar, true);
 }
 
 namespace {
diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx
index dcbc0ec05983..810f53ad4912 100644
--- a/basic/source/runtime/stdobj.cxx
+++ b/basic/source/runtime/stdobj.cxx
@@ -401,6 +401,13 @@ constexpr Method aMethods[] = {
 arg(u"useParensForNegativeNumbers", SbxINTEGER, OPT_), // vbTriState
 arg(u"groupDigits", SbxINTEGER, OPT_), // vbTriState
 
+{ u"FormatPercent",  SbxSTRING,   5 | FUNCTION_ | COMPATONLY_, 
SbRtl_FormatPercent  },
+arg(u"expression",  SbxDOUBLE),
+arg(u"numDigitsAfterDecimal",   SbxINTEGER, OPT_),
+arg(u"includeLeadingDigit", SbxINTEGER, OPT_), // vbTriState
+arg(u"useParensForNegativeNumbers", SbxINTEGER, OPT_), // vbTriState
+arg(u"groupDigits", SbxINTEGER, OPT_), // vbTriState
+
 { u"Frac",  SbxDOUBLE,   1 | FUNCTION_,
SbRtl_Frac },
 arg(u"number", SbxDOUBLE),
 

[Libreoffice-bugs] [Bug 148685] FILEOPEN PPTX: Underlining color wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148685

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

--- Comment #5 from Xisco Faulí  ---
Ok, I know how to fix it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: officecfg/registry

[Mike Kaganski (via logerrit)]

 officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs |   10 
++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 9c8029866146b43014ecc7b08f7cd9b73045844f
Author: Mike Kaganski 
AuthorDate: Fri Apr 22 12:49:46 2022 +0100
Commit: Mike Kaganski 
CommitDate: Fri Apr 22 18:29:16 2022 +0200

Update context names to match EnumContext::ProvideContextContainers

Change-Id: Id9bb806ba526a7557cda91ebdeb649578e64517c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133281
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
index 1eb7007d3008..10e57ac4fb64 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
@@ -107,13 +107,15 @@
  none
 
   2  Context name
-  Know context names are 3DObject, Annotation, Auditing, Axis, 
Cell, Chart, Draw, DrawPage, DrawText,
-  EditCell, ErrorBar, Form, Frame, Graphic, HandoutPage, 
MasterPage, Media, Multiobj, OLE, OutlineText,
-  Pivot, Series, SlidesorterPage, Table, Text, TextObject, 
Trendline, Sparkline
-  default
+  Know context names are 3DObject, Annotation, Auditing, Axis, 
Cell, Chart, ChartElements, Draw,
+  DrawFontwork, DrawLine, DrawPage, DrawText, EditCell, ErrorBar, 
Form, Frame, Graphic, Grid,
+  HandoutPage, MasterPage, Media, MultiObject, NotesPage, OLE, 
OutlineText, Pivot, Printpreview,
+  Series, SlidesorterPage, Table, Text, TextObject, Trendline, 
Sparkline
 
  Special values:
  any
+ default
+ empty
 
   3  Panel state.  One of
  visible  Panel is initially visible and expanded

[Libreoffice-bugs] [Bug 148282] Make sure thumbnails in start center are readable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148282

V Stuart Foote  changed:

   What|Removed |Added

 CC||barrett...@owageskuo.com

--- Comment #11 from V Stuart Foote  ---
*** Bug 148716 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148716] LibreOffice dark mode displays inverted previews

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148716

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 148282 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 55058] EMF+ List of EMF import bugs with examples

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #67 from Commit Notification 
 ---
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/abe3a06c45c0803a5c8bcf16e0e586fd72781c93

tdf#55058 tdf#143875 EMF+ Don't change line weight while rotating

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: drawinglayer/source emfio/qa

[Bartosz Kosiorek (via logerrit)]

 drawinglayer/source/tools/emfphelperdata.cxx  |   10 ++-
 drawinglayer/source/tools/emfphelperdata.hxx  |5 +
 drawinglayer/source/tools/primitive2dxmldump.cxx  |2 
 emfio/qa/cppunit/emf/EmfImportTest.cxx|   46 --
 emfio/qa/cppunit/emf/data/TestEmfPlusDrawLineWithDash.emf |binary
 5 files changed, 40 insertions(+), 23 deletions(-)

New commits:
commit abe3a06c45c0803a5c8bcf16e0e586fd72781c93
Author: Bartosz Kosiorek 
AuthorDate: Fri Apr 22 16:46:39 2022 +0200
Commit: Bartosz Kosiorek 
CommitDate: Fri Apr 22 18:23:21 2022 +0200

tdf#55058 tdf#143875 EMF+ Don't change line weight while rotating

Previously when TranfromationMatrix was used with rotation,
the line weight and dashed line shapes were changed.
In worst case if angle was larger than 90 degrees,
the lines just disappear.

This patch fixes that. The line looks exactly after rotation
(with TranfromationMatrix).

The tests were updated (added some additional rotation),
to prove that now it is working correctly.

Change-Id: Ic2382fa8d1b711a6bf06c94b2d0b9da9e7d396f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133329
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 84d848ed2c1a..a7f809373e09 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -442,6 +442,10 @@ namespace emfplushelper
 maMapTransform *= 
basegfx::utils::createScaleTranslateB2DHomMatrix(100.0 * mnMmX / mnPixX, 100.0 
* mnMmY / mnPixY,

double(-mnFrameLeft), double(-mnFrameTop));
 maMapTransform *= maBaseTransform;
+
+// Used only for performance optimization, to do not calculate it 
every line draw
+mdExtractedXScale = std::hypot(maMapTransform.a(), maMapTransform.b());
+mdExtractedYScale = std::hypot(maMapTransform.c(), maMapTransform.d());
 }
 
 ::basegfx::B2DPoint EmfPlusHelperData::Map(double ix, double iy) const
@@ -531,7 +535,7 @@ namespace emfplushelper
 SAL_WARN_IF(pen->startCap != pen->endCap, "drawinglayer.emf", 
"emf+ pen uses different start and end cap");
 }
 
-const double transformedPenWidth = maMapTransform.get(0, 0) * 
pen->penWidth;
+const double transformedPenWidth = mdExtractedYScale * pen->penWidth;
 drawinglayer::attribute::LineAttribute 
lineAttribute(pen->GetColor().getBColor(),
  
transformedPenWidth,
  
pen->GetLineJoinType(),
@@ -543,7 +547,7 @@ namespace emfplushelper
 new drawinglayer::primitive2d::PolyPolygonStrokePrimitive2D(
 polygon,
 lineAttribute,
-pen->GetStrokeAttribute(maMapTransform.get(1, 1;
+pen->GetStrokeAttribute(mdExtractedXScale)));
 }
 else
 {
@@ -551,7 +555,7 @@ namespace emfplushelper
 new 
drawinglayer::primitive2d::PolyPolygonStrokePrimitive2D(
 polygon,
 lineAttribute,
-pen->GetStrokeAttribute(maMapTransform.get(1, 
1;
+pen->GetStrokeAttribute(mdExtractedXScale)));
 
 mrTargetHolders.Current().append(
 new 
drawinglayer::primitive2d::UnifiedTransparencePrimitive2D(
diff --git a/drawinglayer/source/tools/emfphelperdata.hxx 
b/drawinglayer/source/tools/emfphelperdata.hxx
index 563f7773c3ba..600f666145af 100644
--- a/drawinglayer/source/tools/emfphelperdata.hxx
+++ b/drawinglayer/source/tools/emfphelperdata.hxx
@@ -210,6 +210,11 @@ namespace emfplushelper
 GraphicStateMap mGSStack;
 GraphicStateMap mGSContainerStack;
 
+/* Performance optimizators */
+/* Extracted Scale values from Transformation Matrix */
+double mdExtractedXScale;
+double mdExtractedYScale;
+
 /// data holders
 wmfemfhelper::TargetHolders&mrTargetHolders;
 wmfemfhelper::PropertyHolders&  mrPropertyHolders;
diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx 
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index 61264496ff98..3074ad30690a 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -143,7 +143,7 @@ void writeStrokeAttribute(::tools::XmlWriter& rWriter,
 OUString sDotDash;
 for (double fDotDash : rStrokeAttribute.getDotDashArray())
 {
-sDotDash += OUString::number(round(100.0 * fDotDash)) + " ";
+sDotDash += 

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure (via logerrit)]

 wizards/source/access2base/access2base.py |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 49dfec0a061ca4595a3c5122e92e6a5524cb768b
Author: Jean-Pierre Ledure 
AuthorDate: Fri Apr 22 16:28:12 2022 +0200
Commit: Jean-Pierre Ledure 
CommitDate: Fri Apr 22 18:18:46 2022 +0200

Access2Base - (access2base.py) Don't use bare except: statement

The exception hierarchy described on page
  https://docs.python.org/3.5/library/exceptions.html#exception-hierarchy
indicates that the default exception in bare
  except:
statements is BaseException. This induces that the SystemExit,
KeyboardInterrupt and GeneratorExit are also handled by the
user script.

This is a not recommended practice.

Better is to use the explicit Exception built-in exception
  except Exception:

Bug reported by Paul M on Telegram

Change-Id: Ie1ae1f732ebc60a881e7d40ba8141aa704e9cd5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133328
Tested-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 

diff --git a/wizards/source/access2base/access2base.py 
b/wizards/source/access2base/access2base.py
index 00b9c894488d..ce88057247e1 100644
--- a/wizards/source/access2base/access2base.py
+++ b/wizards/source/access2base/access2base.py
@@ -43,7 +43,7 @@ from platform import system as _opsys
 import datetime, os, sys, traceback
 
 _LIBRARY = ''   # Should be 'Access2Base' or 'Access2BaseDev'
-_VERSION = '7.1'# Actual version number
+_VERSION = '7.4'# Actual version number
 _WRAPPERMODULE = 'Python'   # Module name in the Access2Base library 
containing Python interfaces
 
 # CallByName types
@@ -608,7 +608,7 @@ class _A2B(object, metaclass = _Singleton):
 Script = cls.xScript(script, module)
 try:
 Returned = Script.invoke((args), (), ())[0]
-except:
+except Exception:
 raise TypeError("Access2Base error: method '" + script + "' in 
Basic module '" + module + "' call error. Check its arguments.")
 else:
 if Returned == None:
@@ -643,7 +643,7 @@ class _A2B(object, metaclass = _Singleton):
 args = (action,) + (basic,) + (script,) + args
 try:
 Returned = Script.invoke((args), (), ())
-except:
+except Exception:
 raise TypeError("Access2Base error: method '" + script + "' 
call error. Check its arguments.")
 
 if isinstance(Returned[0], tuple):

[Libreoffice-commits] core.git: sc/inc sc/source

[Luboš Luňák (via logerrit)]

 sc/inc/column.hxx |3 
 sc/inc/document.hxx   |3 
 sc/inc/queryiter.hxx  |  105 -
 sc/inc/table.hxx  |3 
 sc/inc/types.hxx  |6 
 sc/source/core/data/queryiter.cxx |  290 ++
 sc/source/core/tool/interpr1.cxx  |2 
 7 files changed, 190 insertions(+), 222 deletions(-)

New commits:
commit d5986d1c5f639f21204412ebe4a2a9487088b2f3
Author: Luboš Luňák 
AuthorDate: Fri Apr 22 13:33:05 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Apr 22 18:16:48 2022 +0200

do not duplicate code for ScCountIfCellIterator

d468958331f36310d11265ba55d7c27366ab58ab improved COUNTIF performance
by copy the generic query iterator and then basically removing
what was not necessary. Which is in general a good way to improve
the performance, except for the copy part, as the code has
already started to diverge (e.g. fc3b904b671a71266db2e8b30cbeeef4f79).

So instead make the shared code into a template and reuse that from
specific code. This has exactly the same performance as the copy
way.

Change-Id: I168319a1f4273bafc8c0742a114dafbf433968bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133324
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 812a2e6b5abc..ed9ce2e0c77c 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -208,8 +208,9 @@ friend class ScTable;
 friend class ScValueIterator;
 friend class ScHorizontalValueIterator;
 friend class ScDBQueryDataIterator;
+template< ScQueryCellIteratorType >
+friend class ScQueryCellIteratorBase;
 friend class ScQueryCellIterator;
-friend class ScCountIfCellIterator;
 friend class ScFormulaGroupIterator;
 friend class ScCellIterator;
 friend class ScHorizontalCellIterator;
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 3a19ffa02ffb..5fb616b0076b 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -323,8 +323,9 @@ friend class ScHorizontalValueIterator;
 friend class ScDBQueryDataIterator;
 friend class ScFormulaGroupIterator;
 friend class ScCellIterator;
+template< ScQueryCellIteratorType >
+friend class ScQueryCellIteratorBase;
 friend class ScQueryCellIterator;
-friend class ScCountIfCellIterator;
 friend class ScHorizontalCellIterator;
 friend class ScHorizontalAttrIterator;
 friend class ScDocAttrIterator;
diff --git a/sc/inc/queryiter.hxx b/sc/inc/queryiter.hxx
index 70b8daaf4153..ae7b8066c57b 100644
--- a/sc/inc/queryiter.hxx
+++ b/sc/inc/queryiter.hxx
@@ -24,9 +24,24 @@
 #include "scdllapi.h"
 #include "queryparam.hxx"
 #include "mtvelements.hxx"
+#include "types.hxx"
 
-class ScQueryCellIterator   // walk through all non-empty cells in an 
area
+// Query-related iterators. There is one template class ScQueryCellIteratorBase
+// that implements most of the shared functionality, specific parts are done
+// by specializing the templates and then subclassing as the actual class to 
use.
+
+// Specific data should be in ScQueryCellIteratorSpecific (otherwise adding 
data
+// members here would mean specializing the entire ScQueryCellIteratorBase).
+template< ScQueryCellIteratorType iteratorType >
+class ScQueryCellIteratorSpecific
+{
+};
+
+// Shared code for query-based iterators.
+template< ScQueryCellIteratorType iteratorType >
+class ScQueryCellIteratorBase : public ScQueryCellIteratorSpecific< 
iteratorType >
 {
+protected:
 enum StopOnMismatchBits
 {
 nStopOnMismatchDisabled = 0x00,
@@ -61,28 +76,20 @@ class ScQueryCellIterator   // walk through all 
non-empty cells in an ar
 void InitPos();
 void IncPos();
 void IncBlock();
-bool GetThis();
 
-/* Only works if no regular expression is involved, only
-   searches for rows in one column, and only the first
-   query entry is considered with simple conditions
-   SC_LESS_EQUAL (sorted ascending) or SC_GREATER_EQUAL
-   (sorted descending). Check these things before
-   invocation! Delivers a starting point, continue with
-   GetThis() and GetNext() afterwards. Introduced for
-   FindEqualOrSortedLastInRange()
- */
-bool BinarySearch();
+// The actual query function. It will call HandleItemFound() for any 
matching type
+// and return if HandleItemFound() returns true.
+void PerformQuery();
+bool HandleItemFound(); // not implemented, needs specialization
+
+SCCOL   GetCol() const { return nCol; }
+SCROW   GetRow() const { return nRow; }
 
 public:
-ScQueryCellIterator(ScDocument& rDocument, const 
ScInterpreterContext& rContext, SCTAB nTable,
-const ScQueryParam& aParam, bool bMod);
+

[Libreoffice-commits] core.git: sc/inc sc/Library_sc.mk sc/source solenv/clang-format

[Luboš Luňák (via logerrit)]

 sc/Library_sc.mk  |1 
 sc/inc/dociter.hxx|  143 
 sc/inc/queryiter.hxx  |  171 +
 sc/source/core/data/dociter.cxx   | 1036 
 sc/source/core/data/queryiter.cxx | 1090 ++
 sc/source/core/tool/interpr1.cxx  |1 
 solenv/clang-format/excludelist   |2 
 7 files changed, 1265 insertions(+), 1179 deletions(-)

New commits:
commit 4af9403cf718207620376b63242f6d0dd047406a
Author: Luboš Luňák 
AuthorDate: Fri Apr 22 12:08:57 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Apr 22 18:16:05 2022 +0200

move query-related iterators to a new separate file

dociter.cxx/hxx are already quite big as it is, and the query
iterators are more about queries than about iterating the document.

Change-Id: I49e3a5636e4f366efb8b4968f54567d2716ade35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133323
Tested-by: Luboš Luňák 
Reviewed-by: Luboš Luňák 

diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 0ba02c9449ac..c6f65d4ec495 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -179,6 +179,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
 sc/source/core/data/poolhelp \
 sc/source/core/data/postit \
 sc/source/core/data/queryevaluator \
+sc/source/core/data/queryiter \
 sc/source/core/data/refupdatecontext \
 sc/source/core/data/rowheightcontext \
 sc/source/core/data/segmenttree \
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 99ceb1e99972..90fbd614b8bd 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -248,149 +248,6 @@ public:
 bool next();
 };
 
-class ScQueryCellIterator   // walk through all non-empty cells in an 
area
-{
-enum StopOnMismatchBits
-{
-nStopOnMismatchDisabled = 0x00,
-nStopOnMismatchEnabled  = 0x01,
-nStopOnMismatchOccurred  = 0x02,
-nStopOnMismatchExecuted = nStopOnMismatchEnabled | 
nStopOnMismatchOccurred
-};
-
-enum TestEqualConditionBits
-{
-nTestEqualConditionDisabled = 0x00,
-nTestEqualConditionEnabled  = 0x01,
-nTestEqualConditionMatched  = 0x02,
-nTestEqualConditionFulfilled = nTestEqualConditionEnabled | 
nTestEqualConditionMatched
-};
-
-typedef sc::CellStoreType::const_position_type PositionType;
-PositionType maCurPos;
-
-ScQueryParammaParam;
-ScDocument& rDoc;
-const ScInterpreterContext& mrContext;
-SCTAB   nTab;
-SCCOL   nCol;
-SCROW   nRow;
-sal_uInt8nStopOnMismatch;
-sal_uInt8nTestEqualCondition;
-boolbAdvanceQuery;
-boolbIgnoreMismatchOnLeadingStrings;
-
-/** Initialize position for new column. */
-void InitPos();
-void IncPos();
-void IncBlock();
-bool GetThis();
-
-/* Only works if no regular expression is involved, only
-   searches for rows in one column, and only the first
-   query entry is considered with simple conditions
-   SC_LESS_EQUAL (sorted ascending) or SC_GREATER_EQUAL
-   (sorted descending). Check these things before
-   invocation! Delivers a starting point, continue with
-   GetThis() and GetNext() afterwards. Introduced for
-   FindEqualOrSortedLastInRange()
- */
-bool BinarySearch();
-
-public:
-ScQueryCellIterator(ScDocument& rDocument, const 
ScInterpreterContext& rContext, SCTAB nTable,
-const ScQueryParam& aParam, bool bMod);
-// when !bMod, the QueryParam has to 
be filled
-// (bIsString)
-bool GetFirst();
-bool GetNext();
-SCCOL   GetCol() const { return nCol; }
-SCROW   GetRow() const { return nRow; }
-
-// increments all Entry.nField, if column
-// changes, for ScInterpreter ScHLookup()
-voidSetAdvanceQueryParamEntryField( bool bVal )
-{ bAdvanceQuery = bVal; }
-voidAdvanceQueryParamEntryField();
-
-/** If set, iterator stops on first non-matching cell
-content. May be used in SC_LESS_EQUAL queries where a
-cell range is assumed to be sorted; stops on first
-value being greater than the queried value and
-GetFirst()/GetNext() return NULL. StoppedOnMismatch()
-returns true then.
-However, the iterator's conditions are not set to end
-all queries, GetCol() and GetRow() return values for
-the non-matching cell, further 

[Libreoffice-bugs] [Bug 148727] Help text is incomplete for cell range examples, e.g. for SUM, PRODUCT etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148727

László Németh  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from László Németh  ---
@Xisco: thanks for the report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142253] Writer cursor can't be stopped from blinking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142253

--- Comment #7 from Buovjaga  ---
(In reply to Jon from comment #6)
> Thanks, but no luck I'm afraid.  I got the following terminal text
> 
> jon@jon-Z590-AORUS-ELITE-AX:~$ sudo apt-get install libreoffice-gtk3~
> [sudo] password for jon: 
> Reading package lists... Done
> Building dependency tree... Done
> Reading state information... Done
> E: Unable to locate package libreoffice-gtk3~
> jon@jon-Z590-AORUS-ELITE-AX:~$

Notice you have a little worm at the end of your command.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139414] Calc exports CSV dates as 11/10/09 Millennium Bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139414

--- Comment #10 from Buovjaga  ---
(In reply to Jonny Grant from comment #9)
> That seems to work, some of the time
> 
> If I do 'File'->'Export' it doesn't have that option.
> 
> Another time I ended up with "Untitled 1.csv.html"
> 
> I'm using 6.4.7.2

That's because you picked XHTML from File - Export. CSV files are saved from
Save As.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142253] Writer cursor can't be stopped from blinking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142253

--- Comment #6 from Jon  ---
Thanks, but no luck I'm afraid.  I got the following terminal text

jon@jon-Z590-AORUS-ELITE-AX:~$ sudo apt-get install libreoffice-gtk3~
[sudo] password for jon: 
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package libreoffice-gtk3~
jon@jon-Z590-AORUS-ELITE-AX:~$

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139414] Calc exports CSV dates as 11/10/09 Millennium Bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139414

--- Comment #9 from Jonny Grant  ---
That seems to work, some of the time

If I do 'File'->'Export' it doesn't have that option.

Another time I ended up with "Untitled 1.csv.html"

I'm using 6.4.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148728] Should Format -> Character/ Paragraph entry's not be called Paragraph/Character Direct Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148728

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148728] Should Format -> Character/ Paragraph entry's not be called Paragraph/Character Direct Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148728

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 126886] Calc window contents are not visible when opening a CSV in Compiz from Calc 6.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126886

--- Comment #19 from Thomas Mayer  ---
I can confirm this issue for 

Ubuntu 18.04 up-to-date
Kernel: Linux lat61 5.4.0-109-generic #123~18.04.1-Ubuntu SMP Fri Apr 8
09:48:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

LO Build-ID: 1:6.0.7-0ubuntu0.18.04.11
LibreOffice Version: 6.0.7.3

With 

metacity 1:3.28.0-1ubuntu0.1
compiz 1:0.9.13.1+18.04.20180302-0ubuntu1


Please have a look at:
https://bugs.launchpad.net/unity-linux/+source/libreoffice/+bug/1854183

The bug is confirmed by multiple users and e.g. calc not showing up (while
writer does work) occurs sporadically, when
~/.config/libreoffice/4/user/registrymodifications.xcu has values which lead to
the problem.

To work around this problem, I had to edit this file for calc to work again. In
my case, I copied the resolution value from the TextDocument entry to the
SpreadsheetDocument entry.

before:

1920,40,717,27;5;1920,40,1920,1040;
1184,40,735,83;5;1920,40,1920,1040;

after:

1184,40,735,83;5;1920,40,1920,1040;
1184,40,735,83;5;1920,40,1920,1040;

The bug seems to be that resolution values are stored in
~/.config/libreoffice/4/user/registrymodifications.xcu which then lead to the
"infinite surface size not supported" warning (and calc not showing up).

In my case, an (up to) three monitor setup with multiple resulutions (or usable
resolutions because of the bars for one main screen) might have triggered this
whole issue from one day to the other and for no apparent reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144258] Left Area Header is not editable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144258

--- Comment #7 from Manfred  ---
Just want to mention that I have the same behaviour with ver. 7.3.3.1 at Linux
distro Sidcution, wich is based on Debian unstable.

-- 
You are receiving this mail because:
You are the assignee for the bug.