[Libreoffice-ux-advise] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" an
https://bugs.documentfoundation.org/show_bug.cgi?id=148782 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||148519 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148519 [Bug 148519] Change "Margin" to "Entire Frame" in "to" field for Vertical Position when anchoring "To frame" in Position and Shape tab -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-ux-advise] [Bug 148519] Change "Margin" to "Entire Frame" in "to" field for Vertical Position when anchoring "To frame" in Position and Shape tab
https://bugs.documentfoundation.org/show_bug.cgi?id=148519 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||148782 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148782 [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Right of frame text area" -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148519] Change "Margin" to "Entire Frame" in "to" field for Vertical Position when anchoring "To frame" in Position and Shape tab
https://bugs.documentfoundation.org/show_bug.cgi?id=148519 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||148782 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148782 [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Right of frame text area" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Ri
https://bugs.documentfoundation.org/show_bug.cgi?id=148782 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||148519 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148519 [Bug 148519] Change "Margin" to "Entire Frame" in "to" field for Vertical Position when anchoring "To frame" in Position and Shape tab -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593 --- Comment #13 from sdc.bla...@youmail.dk --- https://gerrit.libreoffice.org/c/core/+/133403 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: solenv/vs
solenv/vs/LibreOffice.natvis | 16
1 file changed, 16 insertions(+)
New commits:
commit 8b646cf931543093ba27e7aed7c8206d4b647a6d
Author: Vasily Melenchuk
AuthorDate: Mon Apr 25 15:54:19 2022 +0300
Commit: Vasily Melenchuk
CommitDate: Tue Apr 26 07:47:37 2022 +0200
natvis: some extra patterns for SvRefs<...> and writerfilter
Change-Id: I077232d641fee38da0f50cb838091c0fd0787189
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133416
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk
diff --git a/solenv/vs/LibreOffice.natvis b/solenv/vs/LibreOffice.natvis
index 0962c1c441fb..6dcfea5818b5 100644
--- a/solenv/vs/LibreOffice.natvis
+++ b/solenv/vs/LibreOffice.natvis
@@ -410,6 +410,22 @@
maType
+
+{{Params: {m_pSprms.pObj->size()}}}
+
+
+m_pSprms.pObj->size()
+m_pSprms.pObj->_Mypair._Myval2._Myfirst
+
+
+
+
+{*pObj}
+nullptr
+
+ *pObj
+
+
{mnFrameType,en} of
{mpUpper->mnFrameType,en} {(void*)mpUpper}
{{{mnFrameType,en}}}
[Libreoffice-bugs] [Bug 148540] FILEOPEN RTF Paragraph style extends to more table cells in a row
https://bugs.documentfoundation.org/show_bug.cgi?id=148540 Dieter changed: What|Removed |Added Ever confirmed|0 |1 CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW --- Comment #3 from Dieter --- I confirm it with Version: 7.3.3.1 (x64) / LibreOffice Community Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL in comparison with Word 2016 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148525] FILESAVE RTF Field gets bold direct formatting after saving in Writer and opening in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=148525 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 Summary|FILESAVE RTF Field gets |FILESAVE RTF Field gets |bold direct formatting |bold direct formatting ||after saving in Writer and ||opening in MS Word Status|UNCONFIRMED |NEW CC||dgp-m...@gmx.de --- Comment #3 from Dieter --- I confirm it with MS Word 2016 Saved as RTF with Version: 7.3.3.1 (x64) / LibreOffice Community Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL I've changed bug summary to make clear, that it only happens in Word. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148517] FILESAVE RTF Paragraph with before-after spacing set with DF gets its spacing reset to Auto
https://bugs.documentfoundation.org/show_bug.cgi?id=148517 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Dieter --- I confirm it with Version: 7.3.3.1 (x64) / LibreOffice Community Build ID: 1688991ca59a3ca1c74bc2176b274fba1b034928 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148788] New: LibreOffice Calc with slow "Opening " taskbar message
https://bugs.documentfoundation.org/show_bug.cgi?id=148788 Bug ID: 148788 Summary: LibreOffice Calc with slow "Opening " taskbar message Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kiewoon...@gmail.com Description: I’m using LibreOffice version 7.3.2.2 in Ubuntu MATE 22.04. I noticed that after I open the 1st file (.ods, .xls, .xlsx) with LibreOffice Calc, subsequent file opening in LibreOffice Calc always come with a “Opening ” taskbar message. Although the file is already opened, but the “Opening ” taskbar message stays for >10 seconds. Note that the “Opening ” taskbar message appear when I open the 1st file, but the message disappear relatively quickly when the 1st file is opened. I tried it on Ubuntu 22.04. Such "Opening " taskbar message doesn't appear at all. I'm not sure whether it is due to the differences in desktop environment GNOME2 (Ubuntu MATE 22.04) and GNOME42 (Ubuntu 22.04). I'm not sure whether it is safe to start editing the opened file, with the "Opening " taskbar message still there? Can I do something to make the "Opening " taskbar message don't appear at all or disappear faster? Steps to Reproduce: 1.Open the first file in LibreOffice Calc. 2.Open the 2nd file in LibreOffice Calc 3.na Actual Results: The "Opening " taskbar message for the 2nd file stays in the taskbar for >10 seconds even after the 2nd file is open. Expected Results: The taskbar message should disappear after the file is opened. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.2.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 2; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.3.2-0ubuntu2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148522] Undo line color changes aligns text centered (and doesn't undo the line color)
https://bugs.documentfoundation.org/show_bug.cgi?id=148522 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148525] FILESAVE RTF Field gets bold direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=148525 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148514] Filternavigator in Base is always minimized
https://bugs.documentfoundation.org/show_bug.cgi?id=148514 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148517] FILESAVE RTF Paragraph with before-after spacing set with DF gets its spacing reset to Auto
https://bugs.documentfoundation.org/show_bug.cgi?id=148517 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148520] Impress, table templates (character formatting wrong after load)
https://bugs.documentfoundation.org/show_bug.cgi?id=148520 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148511] Dragging top handle of the table border to increase the size of table refuses
https://bugs.documentfoundation.org/show_bug.cgi?id=148511 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148507] The right column showing the row number keeps constantly expanding in size (even if still in the range of say 4 or 5 digits)
https://bugs.documentfoundation.org/show_bug.cgi?id=148507 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148509] UI:Delete row button is often disabled when being in table (Impress)
https://bugs.documentfoundation.org/show_bug.cgi?id=148509 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148504] Voice control makes Calc and Writer freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=148504 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144726] Programa Libre Office se cierra inesperadamente
https://bugs.documentfoundation.org/show_bug.cgi?id=144726 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144726] Programa Libre Office se cierra inesperadamente
https://bugs.documentfoundation.org/show_bug.cgi?id=144726 --- Comment #3 from QA Administrators --- Dear ramon6419, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145247] Cannot save documents macOS Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=145247 --- Comment #2 from QA Administrators --- Dear Keith Johnson, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145238] bug in vertical Text orientation in cell
https://bugs.documentfoundation.org/show_bug.cgi?id=145238 --- Comment #3 from QA Administrators --- Dear HM, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1504268: Concurrent data access violations (MISSING_LOCK)
/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx: 695 in
dp_gui::ExtensionCmdQueue::Thread::execute()()
*** CID 1504268: Concurrent data access violations (MISSING_LOCK)
/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx: 695 in
dp_gui::ExtensionCmdQueue::Thread::execute()()
689 while (m_eInput == NONE) {
690 m_wakeup.wait(aGuard);
691 }
692 eInput = m_eInput;
693 m_eInput = NONE;
694 nSize = m_queue.size();
>>> CID 1504268: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "this->m_bWorking" without holding lock
>>> "dp_gui::ExtensionCmdQueue::Thread.m_mutex". Elsewhere,
>>> "_ZN6dp_gui17ExtensionCmdQueue6ThreadE.m_bWorking" is accessed with
>>> "dp_gui::ExtensionCmdQueue::Thread.m_mutex" held 3 out of 4 times (3 of
>>> these accesses strongly imply that it is necessary).
695 m_bWorking = false;
696 }
697
698 if ( eInput == STOP )
699 break;
700
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DXlJF_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiQYDOobQ-2BGVFghOJb-2F-2Fz6XMQpmvBxmyrTpT1cEUWA2LHLtkmlylzZ8MA2-2BOp5fQwRcMefHeIIpvAJ4WZxmPJioq2XZQ1W0LYZ1gCCgUeHkf3vGkBDhNIoAvazP0-2BwxPOqVnop9al2aCGH-2Bw2SKEJyDm3n8mZGOiHSmuRfL7bbTOg-3D
[Libreoffice-bugs] [Bug 148787] New: Backspace wipes out bullet beyond recovery.
https://bugs.documentfoundation.org/show_bug.cgi?id=148787 Bug ID: 148787 Summary: Backspace wipes out bullet beyond recovery. Product: LibreOffice Version: 7.2.5.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cdan...@betasoft.org Created attachment 179771 --> https://bugs.documentfoundation.org/attachment.cgi?id=179771=edit Impress slide with bullet points: First one vanished, after backspacing. Steps to Duplicate: 1. Create an Impress slide with several bullet points, as shown in Attachment. 2. Position the cursor inside the text box, before the first word of text. 3. Accidentally press Backspace. 4. The first bullet disappears. Unless you immediately Undo, it is gone beyond recovery, down a black hole. Issue: This is a huge annoyance, in comparison with the very trivial benefit of being able to un-bullet one line in a bulleted list. I found no way to recover the missing bullet -- even after several attempts playing with the Bullets and Numbering dialog in various ways. In the end, the user has to completely delete the text box, and start all the tedious text entry over again, from scratch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148786] New: Unable to undock Edit Points toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=148786 Bug ID: 148786 Summary: Unable to undock Edit Points toolbar Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cdan...@betasoft.org Created attachment 179770 --> https://bugs.documentfoundation.org/attachment.cgi?id=179770=edit Draw window with Edit Points toolbar docked. Steps to Duplicate: 1. Open Draw or Impress in Windows 10. 2. Select a plain line or a bezier curve. 3. The Edit Points toolbar appears, but it is docked -- or stuck -- at the bottom of the window, just above the Status Bar. 4. There is no . icon on the toolbar, enabling users to undock it. Issue: This defeats the convenience of a floating toolbar, close to the drawing, when the user has many points to edit -- as in the State Machine diagram shown in the attachment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148785] New: Cursor position in file is lost when the file is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=148785 Bug ID: 148785 Summary: Cursor position in file is lost when the file is closed Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mrzen...@gmail.com I have files where I have filled in all the optional information needed for LO Writer to remember where the cursor last was when the fle is closed. In LO 7.2, this works perfectly - the file is set up so the cursor is in the last position it was when I previously edited the file. In 7.3, this not only does not work, but in 7.3.3, the page that shows is the right page, but the cursor is actually somewhere else, nowhere near the last edit position. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148784] Stretch point is missing in export to custGeom in OOXML
https://bugs.documentfoundation.org/show_bug.cgi?id=148784 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Version|Inherited From OOo |7.4.0.0 alpha0+ Master Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | Ever confirmed|0 |1 --- Comment #1 from Regina Henschel --- I will fix it. The solution is to use parameter value "true" in calling EnhancedCustomShape2d::GetParameter(). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148784] New: Stretch point is missing in export to custGeom in OOXML
https://bugs.documentfoundation.org/show_bug.cgi?id=148784 Bug ID: 148784 Summary: Stretch point is missing in export to custGeom in OOXML Product: LibreOffice Version: Inherited From OOo Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 179769 --> https://bugs.documentfoundation.org/attachment.cgi?id=179769=edit example with ActionButton Open attached document. It has a not square action button. The markup uses the attributes draw:path-stretchpoint-x and draw:path-stretchpoint-y. The purpose of these attributes is, that the width of the bevel area does not change, when you make the shape much wider. The width of the bevel area is only determined by the handle. Save the document to pptx-format. Open in PowerPoint or reopen in LO. Notice, that the geometry is broken. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148732] UI: Default Character in Format Styles is called No Character Style in character styles deck of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=148732 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | --- Comment #2 from sdc.bla...@youmail.dk --- https://gerrit.libreoffice.org/c/core/+/133401 Seeking feedback on tooltip, which would appear (a) in the customize dialog and (b) over the "A" icon in the Formatting (Styles) bar. Hard to formulate because it sometimes describes a state (no CS) and sometimes a process (removing CS). I chose to emphasize the process, rather than try to express the dual nature. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593 --- Comment #12 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #9) Sorry for this off-topic comment, but... > And we do have a nice preview that clearly shows where the object is > positioned Are you sure about that? Have you tested the preview lately? It is a mistake to believe that the current preview is always showing clearly where an object will be positioned. As Regina noted in comment 5, a ”large preview” may be a good way to reduce or eliminate uncertainty about the meanings of these options, but at present the current preview is not functioning adequately in (too) many cases. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148783] New: PGP signatures hard to find
https://bugs.documentfoundation.org/show_bug.cgi?id=148783 Bug ID: 148783 Summary: PGP signatures hard to find Product: LibreOffice Version: unspecified Hardware: All URL: https://www.libreoffice.org/download/download/ OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: manc...@zoho.com LibreOffice binaries/installers are PGP-signed (good) but detached signatures aren't found on download page (not that good). One must do some detective work to find them. Suggestion: please include link to corresponding .asc file on download page. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123370] [META] "Expression is faulty" regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=123370 Bug 123370 depends on bug 123381, which changed state. Bug 123381 Summary: FILEOPEN DOCX INT table formula is not working in LO https://bugs.documentfoundation.org/show_bug.cgi?id=123381 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112969] [META] DOCX (OOXML) field-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112969 Bug 112969 depends on bug 123381, which changed state. Bug 123381 Summary: FILEOPEN DOCX INT table formula is not working in LO https://bugs.documentfoundation.org/show_bug.cgi?id=123381 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 123381] FILEOPEN DOCX INT table formula is not working in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=123381 Xisco Faulí changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #10 from Xisco Faulí --- I guess we can close this issue as RESOLVED FIXED @laszlo, Thanks for reviewing the patch -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||148782 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148782 [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Right of frame text area" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||148782 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148782 [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Right of frame text area" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Ri
https://bugs.documentfoundation.org/show_bug.cgi?id=148782 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||103270, 108741 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rb.hensc...@t-online.de Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" an
https://bugs.documentfoundation.org/show_bug.cgi?id=148782 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||103270, 108741 CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||rb.hensc...@t-online.de Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148782] New: "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" an
https://bugs.documentfoundation.org/show_bug.cgi?id=148782 Bug ID: 148782 Summary: "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Right of frame text area" Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Make a frame. 2. Make a shape, and anchor the shape "to frame" 3. Right-click shape and choose "Position and Size" - Position and Size tab. 4. In Position section, look at options for "to" control. Left frame border -> Left of frame text area Right frame border -> Right of frame text area Please note: Left/Right is a geometric issue -- positions in space. Nothing to do with directions of writing. Reasons: 1. Accuracy 2. Would be parallel/similar to "Left of page text area" and "Right of page text area" (see bug 148593) (i.e., facilitating understanding/consistency) 3. Enables possibility to use "Frame border" for both Horizontal and Vertical "to" options instead of "Margin" and "Entire Frame" (see bug 148519) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - oox/qa oox/source
oox/qa/unit/data/FaultyPathStart.odp |binary
oox/qa/unit/export.cxx | 20
oox/source/export/drawingml.cxx | 25 +++--
3 files changed, 39 insertions(+), 6 deletions(-)
New commits:
commit 7ae899e1e2f28e9be4bcd4fb6786bc6999f3ba8d
Author: Regina Henschel
AuthorDate: Sat Apr 23 21:52:29 2022 +0200
Commit: Xisco Fauli
CommitDate: Tue Apr 26 00:01:49 2022 +0200
Do not start a:path with lnTo in export to OOXML
This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2
The commands A, W, T or L of a draw:enhanced-path draw a line from
current point to start of the arc or end of line, respectivly. If
there is no current point the path is faulty and behavior is not
defined in ODF.
LibreOffice is tolerant and makes a move to the start point of the
arc or to the end point of the line. With this patch we do the same
now in export to OOXML, so the user gets the same shape geometry as in
LO. If a path starts with lnTo, MS Office will show nothing.
I wouldn't care about user-created faulty paths, but LO produces such
faulty path when an EllipseRibbon shape from binary MS Office is
imported. Even when that will be fixed, we need the fix here, because
the faulty path had been written to document markup and will be used
when such document is opened.
Change-Id: Ic52ec3bc78231b26efb592ddadee2e3042fdc065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133349
Tested-by: Jenkins
Reviewed-by: Regina Henschel
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133370
diff --git a/oox/qa/unit/data/FaultyPathStart.odp
b/oox/qa/unit/data/FaultyPathStart.odp
new file mode 100644
index ..219795ffa58b
Binary files /dev/null and b/oox/qa/unit/data/FaultyPathStart.odp differ
diff --git a/oox/qa/unit/export.cxx b/oox/qa/unit/export.cxx
index e104b4effdd7..26d1a0e973bb 100644
--- a/oox/qa/unit/export.cxx
+++ b/oox/qa/unit/export.cxx
@@ -529,6 +529,26 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf147978_subpath)
assertXPath(pXmlDoc, "//a:pathLst/a:path[4]", "w", "80");
assertXPath(pXmlDoc, "//a:pathLst/a:path[4]", "h", "80");
}
+
+CPPUNIT_TEST_FIXTURE(Test, testFaultyPathCommandsAWT)
+{
+// The odp file contains shapes whose path starts with command A, W, T or
L. That is a faulty
+// path. LO is tolerant and renders it so that is makes a moveTo to the
start point of the arc or
+// the end of the line respectively. Export to OOXML does the same now and
writes a moveTo
+// instead of the normally used lnTo. If a lnTo is written, MS Office
shows nothing of the shape.
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) +
"FaultyPathStart.odp";
+
+loadAndSave(aURL, "Impress Office Open XML");
+
+// Verify the markup:
+std::unique_ptr pStream = parseExportStream(getTempFile(),
"ppt/slides/slide1.xml");
+xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
+// First child of a:path should be a moveTo in all four shapes.
+assertXPath(pXmlDoc,
"//p:spTree/p:sp[1]/p:spPr/a:custGeom/a:pathLst/a:path/a:moveTo");
+assertXPath(pXmlDoc,
"//p:spTree/p:sp[2]/p:spPr/a:custGeom/a:pathLst/a:path/a:moveTo");
+assertXPath(pXmlDoc,
"//p:spTree/p:sp[3]/p:spPr/a:custGeom/a:pathLst/a:path/a:moveTo");
+assertXPath(pXmlDoc,
"//p:spTree/p:sp[4]/p:spPr/a:custGeom/a:pathLst/a:path/a:moveTo");
+}
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 311669bd5cbe..c2bdf39042a4 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3997,10 +3997,21 @@ bool DrawingML::WriteCustomGeometrySegment(
{
if (rnPairIndex >= rPairs.getLength())
return false;
-
-mpFS->startElementNS(XML_a, XML_lnTo);
-WriteCustomGeometryPoint(rPairs[rnPairIndex], rCustomShape2d);
-mpFS->endElementNS(XML_a, XML_lnTo);
+// LINETO without valid current point is a faulty path. LO is
tolerant and makes a
+// moveTo instead. Do the same on export. MS OFFICE requires a
current point for lnTo,
+// otherwise it shows nothing of the shape.
+if (rbCurrentValid)
+{
+mpFS->startElementNS(XML_a, XML_lnTo);
+WriteCustomGeometryPoint(rPairs[rnPairIndex], rCustomShape2d);
+mpFS->endElementNS(XML_a, XML_lnTo);
+}
+else
+{
+mpFS->startElementNS(XML_a, XML_moveTo);
+WriteCustomGeometryPoint(rPairs[rnPairIndex], rCustomShape2d);
+mpFS->endElementNS(XML_a, XML_moveTo);
+}
rCustomShape2d.GetParameter(rfCurrentX, rPairs[rnPairIndex].First,
false, false);
rCustomShape2d.GetParameter(rfCurrentY,
[Libreoffice-commits] core.git: bridges/source
bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 67d8c245daf7c6ee33e908255f2bbd0ea8d08206
Author: Stephan Bergmann
AuthorDate: Mon Apr 25 17:01:04 2022 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 25 23:58:46 2022 +0200
loplugin:stringview
Change-Id: I4bd3efe67217a4c4418cf308cc8e7a55cf4a604a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133390
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
index 8db8c37140e5..ff50e62dd026 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
@@ -29,6 +29,7 @@
#include
#include
+#include
#include
#include
#include
@@ -99,7 +100,7 @@ std::type_info * Rtti::getRtti(typelib_TypeDescription const
& type) {
for (sal_Int32 j = 0; j != -1;) {
OString t(
OUStringToOString(
-unoName.getToken(0, '.', j), RTL_TEXTENCODING_ASCII_US));
+o3tl::getToken(unoName, 0, '.', j),
RTL_TEXTENCODING_ASCII_US));
b.append(t.getLength());
b.append(t);
}
[Libreoffice-bugs] [Bug 60205] Multi-column 1-page RTF(not doc) with text box (absolute position to margin with "Layout in table cell") opens with wrong frame position
https://bugs.documentfoundation.org/show_bug.cgi?id=60205 --- Comment #18 from rj_libreoff...@objectmail.com --- Created attachment 179768 --> https://bugs.documentfoundation.org/attachment.cgi?id=179768=edit Essentially the same problem seen with LO v7.3.2.2 (x64), Win 10 Home -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 60205] Multi-column 1-page RTF(not doc) with text box (absolute position to margin with "Layout in table cell") opens with wrong frame position
https://bugs.documentfoundation.org/show_bug.cgi?id=60205 --- Comment #17 from rj_libreoff...@objectmail.com --- I see essentially the same problem with the current LibreOffice Fresh, v7.3.2.2. (x64), using Windows 10 Home. See new screenshot. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148781] New: I have tried to open LibreOffice and it will not run. I cannot open any of my documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=148781 Bug ID: 148781 Summary: I have tried to open LibreOffice and it will not run. I cannot open any of my documents. Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: richardson.jaso...@gmail.com Description: I tried to click on the short cut on my desktop and nothing happens. I try to open my spreadsheets and documents, and nothing happens. I have version 7.3.2. Actual Results: I can not open LibreOffice. to reproduce the problem just try to open it. Expected Results: Nothing is happening, that is why im reaching out to you. Reproducible: Always User Profile Reset: No Additional Info: Software should open as normal -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148637] Unusably tiny window size after 'restore' is used on KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=148637 --- Comment #3 from BDF --- Bug report on the KDE bug tracker got closed by Nate Graham: "It really sounds like a LibreOffice bug" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 38850] Show "Bullets and Numbering" toolbar for all paragraphs not being Text Body
https://bugs.documentfoundation.org/show_bug.cgi?id=38850 --- Comment #14 from sdc.bla...@youmail.dk --- (In reply to Heiko Tietze from comment #13) > As discussed on bug 148673 we should show the toolbar for any paragraph > which outline level is not Text Body. iiuc the OP here is about allowing the user to manually override the context-sensitive nature of the B toolbar. STR. 1. Insert a non-list paragraph. 2. View > Toolbars > Bullets and Numbering. 3. Insert a new paragraph, formatted as a list paragraph 4. Place cursor in (initial) non-list paragraph. Actual:Toolbar appears after step 2, but disappears after step 4 Expected: Toolbar remains visible (because I have manually chosen to "View" it) until I manually choose to "hide" it. Tested with: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: f8e11c6480ff0005715b989a6d4e2e10a3816cf6 (I have not tested other context-sensitive toolbars, but I could imagine that the request can be generalized to "always show toolbars that I manually "activate" with View > Toolbars.) That request seems worthy of consideration, but the issue discussed in bug 148673 would not "resolve" the OP here -- because the B bar would disappear on non-list paragraphs with "Text Body" outline level. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/aqua/FilterHelper.hxx |3 ++-
fpicker/source/aqua/FilterHelper.mm | 33 +
2 files changed, 19 insertions(+), 17 deletions(-)
New commits:
commit 8e77be57024fa9422db2dddce7c0c7ef4302a3c2
Author: Stephan Bergmann
AuthorDate: Mon Apr 25 17:02:42 2022 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 25 23:24:04 2022 +0200
loplugin:stringviewparam
...and loplugin:stringview(param) follow-ups
Change-Id: I5ccb5c7b246a35aefb43c8f608d781b753f9830c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133392
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/fpicker/source/aqua/FilterHelper.hxx
b/fpicker/source/aqua/FilterHelper.hxx
index 6cf4aec5996e..21cb9c4b4464 100644
--- a/fpicker/source/aqua/FilterHelper.hxx
+++ b/fpicker/source/aqua/FilterHelper.hxx
@@ -27,6 +27,7 @@
#include
#include
+#include
#include
#include
@@ -82,7 +83,7 @@ public:
//XFilterManager delegates
/// @throws css::lang::IllegalArgumentException
/// @throws css::uno::RuntimeException
-void appendFilter( const OUString& aTitle, const OUString& aFilter );
+void appendFilter( const OUString& aTitle, std::u16string_view aFilter );
/// @throws css::lang::IllegalArgumentException
/// @throws css::uno::RuntimeException
diff --git a/fpicker/source/aqua/FilterHelper.mm
b/fpicker/source/aqua/FilterHelper.mm
index fc6bca998755..f11d8447d91a 100644
--- a/fpicker/source/aqua/FilterHelper.mm
+++ b/fpicker/source/aqua/FilterHelper.mm
@@ -21,6 +21,9 @@
#include
#include
+#include
+#include
+#include
#include
#include
@@ -31,12 +34,12 @@
namespace {
-void fillSuffixList(OUStringList& aSuffixList, const OUString& suffixString) {
-sal_Int32 nIndex = 0;
+void fillSuffixList(OUStringList& aSuffixList, std::u16string_view
suffixString) {
+std::size_t nIndex = 0;
do {
-OUString aToken = suffixString.getToken( 0, ';', nIndex );
-aSuffixList.push_back(aToken.copy(1));
-} while ( nIndex >= 0 );
+std::u16string_view aToken = o3tl::getToken( suffixString, u';',
nIndex );
+aSuffixList.push_back(OUString(aToken.substr(1)));
+} while ( nIndex != std::u16string_view::npos );
}
}
@@ -70,24 +73,22 @@ sal_Int32 FilterEntry::getSubFilters( UnoFilterList&
_rSubFilterList )
#pragma mark statics
static bool
-isFilterString( const OUString& rFilterString, const char *pMatch )
+isFilterString( std::u16string_view rFilterString, std::u16string_view pMatch )
{
-sal_Int32 nIndex = 0;
-OUString aToken;
+std::size_t nIndex = 0;
+std::u16string_view aToken;
bool bIsFilter = true;
-OUString aMatch(OUString::createFromAscii(pMatch));
-
do
{
-aToken = rFilterString.getToken( 0, ';', nIndex );
-if( !aToken.match( aMatch ) )
+aToken = o3tl::getToken( rFilterString, u';', nIndex );
+if( !o3tl::starts_with( aToken, pMatch ) )
{
bIsFilter = false;
break;
}
}
-while( nIndex >= 0 );
+while( nIndex != std::u16string_view::npos );
return bIsFilter;
}
@@ -109,11 +110,11 @@ shrinkFilterName( const OUString& aFilterName, bool
bAllowNoStar = false )
sal_Int32 nBracketLen = nBracketEnd - i;
if( nBracketEnd <= 0 )
continue;
-if( isFilterString( aFilterName.copy( i + 1, nBracketLen - 1 ),
"*." ) )
+if( isFilterString( aFilterName.subView( i + 1, nBracketLen - 1 ),
u"*." ) )
aRealName = aRealName.replaceAt( i, nBracketLen + 1, u"" );
else if (bAllowNoStar)
{
-if( isFilterString( aFilterName.copy( i + 1, nBracketLen - 1
), ".") )
+if( isFilterString( aFilterName.subView( i + 1, nBracketLen -
1 ), u".") )
aRealName = aRealName.replaceAt( i, nBracketLen + 1, u"" );
}
}
@@ -259,7 +260,7 @@ void FilterHelper::SetFilters()
}
}
-void FilterHelper::appendFilter(const OUString& aTitle, const OUString&
aFilterString)
+void FilterHelper::appendFilter(const OUString& aTitle, std::u16string_view
aFilterString)
{
SolarMutexGuard aGuard;
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/printaccessoryview.mm |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit f12448ce5f6fdccdaccfeed76b1ec22cccdcddec
Author: Stephan Bergmann
AuthorDate: Mon Apr 25 17:01:54 2022 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 25 23:23:12 2022 +0200
loplugin:stringview
Change-Id: I60b37ab39662c485855894642484b6d093070519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133391
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm
index 92c09f7dd47f..95ace78d2816 100644
--- a/vcl/osx/printaccessoryview.mm
+++ b/vcl/osx/printaccessoryview.mm
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
#include
@@ -330,7 +331,7 @@ static OUString filterAccelerator( OUString const & rText )
{
OUStringBuffer aBuf( rText.getLength() );
for( sal_Int32 nIndex = 0; nIndex != -1; )
-aBuf.append( rText.getToken( 0, '~', nIndex ) );
+aBuf.append( o3tl::getToken( rText, 0, '~', nIndex ) );
return aBuf.makeStringAndClear();
}
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/textcharacterproperties.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 34c1c57dc38b62036e8d68b0adec442c11f2cc5d Author: Xisco Fauli AuthorDate: Mon Apr 25 14:01:53 2022 +0200 Commit: Xisco Fauli CommitDate: Mon Apr 25 23:17:55 2022 +0200 oox: Remove obsolete TODO This can go after 1c924efe1f80207a5e104d755615b1eb9a91d418 < tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties > Change-Id: I9b9540cf0cdcd9ecbb39b92fe24b83a1810df7da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133382 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/oox/source/drawingml/textcharacterproperties.cxx b/oox/source/drawingml/textcharacterproperties.cxx index fc8214db42fe..583ccf7b6d77 100644 --- a/oox/source/drawingml/textcharacterproperties.cxx +++ b/oox/source/drawingml/textcharacterproperties.cxx @@ -207,8 +207,6 @@ void TextCharacterProperties::pushToPropMap( PropertyMap& rPropMap, const XmlFil rPropMap.setProperty( PROP_CharUnderlineColor, sal_Int32(-1)); } -// TODO If bUnderlineFillFollowText uFillTx (CT_TextUnderlineFillFollowText) is set, fill color of the underline should be the same color as the text - if (maHighlightColor.isUsed() && maHighlightColor.getTransparency() != 100) rPropMap.setProperty( PROP_CharBackColor, maHighlightColor.getColor( rFilter.getGraphicHelper() )); else
[Libreoffice-bugs] [Bug 148780] UNWANTED SPACES on Entering Next Line in Writer Document
https://bugs.documentfoundation.org/show_bug.cgi?id=148780 --- Comment #1 from Digi Abros --- Created attachment 179767 --> https://bugs.documentfoundation.org/attachment.cgi?id=179767=edit Writer-Empty-Space-Characters-on-Click-Anywhere-in-Document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148780] New: UNWANTED SPACES on Entering Next Line in Writer Document
https://bugs.documentfoundation.org/show_bug.cgi?id=148780 Bug ID: 148780 Summary: UNWANTED SPACES on Entering Next Line in Writer Document Product: LibreOffice Version: 7.3.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: digitalab...@gmail.com Description: see Steps and expected results. Steps to Reproduce: 1. Open Writer > New Document. (somename.odt) 2. Type text on a line. Press Enter / Return key. 3. Type some more text. 4. Press Enter / Return key. 2-3 times. 5. Type some more text. 6. Press Enter / Return key. 7. Click anywhere on blank space on above lines. You see all blank lines and cursor where you clicked is converted to Space characters. Actual Results: BLANK LINES are converted to SPACE characters. Space after Text on any given line is converted to SPACE characters. Expected Results: No Spaces allowed after written text, no matter how many blank lines in Writer Text document are present at the moment. It is extremely frustrating to have to delete is every time, for official work documents. No one likes it during presentation or sharing. Kindly get rid of the empty space characters, that are generated automatically. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Bug 108908 depends on bug 75263, which changed state. Bug 75263 Summary: FILESAVE XLS Cyrillic (Russian) characters inserted by macro appear as question marks https://bugs.documentfoundation.org/show_bug.cgi?id=75263 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=146928 Eyal Rozenberg changed: What|Removed |Added Blocks||43808 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Eyal Rozenberg changed: What|Removed |Added Depends on||146928 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146928 [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Eyal Rozenberg changed: What|Removed |Added Depends on|146928 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146928 [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues
https://bugs.documentfoundation.org/show_bug.cgi?id=129661 Eyal Rozenberg changed: What|Removed |Added Depends on||146928 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146928 [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=146928 Eyal Rozenberg changed: What|Removed |Added Blocks|43808 |129661 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL) https://bugs.documentfoundation.org/show_bug.cgi?id=129661 [Bug 129661] [META] Right-To-Left (RTL) user interface issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146928] Open the corresponding text font tab for Asian/CTL fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=146928 --- Comment #12 from Eyal Rozenberg --- > That makes Asian and CTL users confused before clicking 'Asian' or 'Complex' > tab because a user will usually believe what dialog shows first reflects > present state. As far as I can speak for RTL language users (which is to be debated...) I semi-disagree. The tab heading clearly states "Western". And - RTL language users are used to there being "two fonts" - the English/LTR/European languages font and the RTL languages font. (You could argue that "Western" is a questionable choice of name, but that's a different story.) I agree that in its previous state, the dialog was kind of repetitive; and that readability is somewhat improved now. What I suggest as an alternative solution is that, when the Character properties dialog is opened, the focused tab will be the one corresponding to the language group in whose context the dialog was opened. That seems like Heiko's second suggested option; and it should suffice to avoid the element of surprise described by Kiyotaka-san (Or is it Nishibori-san? Sorry, I couldn't figure out which one is the family name). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 --- Comment #8 from Eyal Rozenberg --- (In reply to Caolán McNamara from comment #7) > but its a big amount of UI to attempt to try and tackle that widget by > widget But almost no LO UI needs this. I currently know of two places. Maybe you can find another example or two. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/charnamepage.ui | 908 +--- 1 file changed, 489 insertions(+), 419 deletions(-) New commits: commit 2bb3587f5e7b1ee1fcb7163419c21144258ebf00 Author: Caolán McNamara AuthorDate: Mon Apr 25 15:31:31 2022 +0100 Commit: Caolán McNamara CommitDate: Mon Apr 25 21:37:54 2022 +0200 character dialog contents jumping around a little when label contents change Change-Id: Icc49b7b6a9163c769e80eb04dd4b725aaa725a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133387 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/charnamepage.ui b/cui/uiconfig/ui/charnamepage.ui index ac37e704c6ca..aad4efeb4a74 100644 --- a/cui/uiconfig/ui/charnamepage.ui +++ b/cui/uiconfig/ui/charnamepage.ui @@ -482,175 +482,199 @@ 6 6 - + True False -start start 12 12 12 12 6 -6 - - -True -False -Family: -True -westfontnamelb-cjk -0 - - -0 -0 - - - + + True False -Language: -True -westlanglb-cjk -0 - - -0 -3 - - - - -True -False -liststore5 -True -0 -1 +True +6 +6 - - -2 - + +True +False +Family: +True +westfontnamelb-cjk +0 + + +0 +0 + - - -Sets the language that the spellchecker uses for the selected text or the text that you type. Available language modules have a check mark in front of them. + + +True +False +Language: +True +westlanglb-cjk +0 + +0 +3 + - - -1 -3 -2 - - - - -True -False -True - - -1 -0 -2 - - - - -True -False -Style: -True -weststylelb-cjk -0 - - -0 -1 - - - - -True -False -True - - -Select the formatting that you want to apply. + + +True +False +liststore5 +True +0 +1 + + + +2 + + + + +Sets the language that the spellchecker uses for the selected text or the text that you type. Available language modules have a check mark in front of them. + + + +1 +3 +2 +
[Libreoffice-bugs] [Bug 148779] Crash when editing "Structure and Formatting" of Bibliography
https://bugs.documentfoundation.org/show_bug.cgi?id=148779 --- Comment #1 from leana.ji...@icloud.com --- Created attachment 179766 --> https://bugs.documentfoundation.org/attachment.cgi?id=179766=edit logfile of macOS after the crash of LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148779] New: Crash when editing "Structure and Formatting" of Bibliography
https://bugs.documentfoundation.org/show_bug.cgi?id=148779 Bug ID: 148779 Summary: Crash when editing "Structure and Formatting" of Bibliography Product: LibreOffice Version: 7.3.2.2 release Hardware: ARM OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leana.ji...@icloud.com Description: Right-click a generated Bibliography index > "Edit Index" > "Entries" tab > "Structure and Formatting", removing text to the text field of text separator crashes LibreOffice Steps to Reproduce: 1. Create bibliography: "Insert" > "Table of Contents and Index" > "Table of Contents, index and Bibliography". 2. "Entries" tab > "Structure and Formatting". I should be able to add/remove text in the text boxes. 3. Remove text to the text field of text separator crashes LibreOffice (even where there are still text to delete) Actual Results: Crashes LibreOffice completely Expected Results: Be able to add/delete text to the text field Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 8; OS: Mac OS X 12.3.1; UI render: default; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded Crash log from macOS https://controlc.com/64e66b9f -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148433] Extreme keyboard input delays on linux in paragraphs which contain both rtl and ltr characters
https://bugs.documentfoundation.org/show_bug.cgi?id=148433 --- Comment #19 from Yotam Benshalom --- Thank you. Will you let me know how to install libreoffice from daily? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148433] Extreme keyboard input delays on linux in paragraphs which contain both rtl and ltr characters
https://bugs.documentfoundation.org/show_bug.cgi?id=148433 --- Comment #18 from Caolán McNamara --- the remaining leading contender for investigation is then that CAIRO_OPERATOR_DIFFERENCE call, there was difficulties with it in the past on nvidia. I will push a commit which will allow experimenting with the next daily that contains it to see if that has a bearing on this problem or not. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/charnamepage.ui | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) New commits: commit 0b674bda2564b10e65c12b26f1e610a1b4ef5bdc Author: Caolán McNamara AuthorDate: Mon Apr 25 12:48:34 2022 +0100 Commit: Caolán McNamara CommitDate: Mon Apr 25 20:54:19 2022 +0200 repair mangled sizegroups Change-Id: I51b52fa160bca38f158e5e7aec5386ffdb286fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133383 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/charnamepage.ui b/cui/uiconfig/ui/charnamepage.ui index 6f865e3122aa..ac37e704c6ca 100644 --- a/cui/uiconfig/ui/charnamepage.ui +++ b/cui/uiconfig/ui/charnamepage.ui @@ -1108,6 +1108,14 @@ + +True + + + + + + True @@ -1116,13 +1124,20 @@ - -True - True + + + + + True + + + + +
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 --- Comment #7 from Caolán McNamara --- I'm not sure there is a general solution when using the LTR UI to get good outcomes in the dialogs with such lists of RTL text. It is possible to override the direction of individual widgets but in the general case the text that will appear in the list is arbitrary. One could try and bubble the "document language" around the place and override default direction based on that, but its a big amount of UI to attempt to try and tackle that widget by widget -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148771] Decreasing font sizes is often inconvenient
https://bugs.documentfoundation.org/show_bug.cgi?id=148771 Telesto changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148771] Decreasing font sizes is often inconvenient
https://bugs.documentfoundation.org/show_bug.cgi?id=148771 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl Version|7.2.6.2 release |7.0.0.3 release Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest, regression --- Comment #1 from Telesto --- 1. Open Writer 2. Set font size to 10.5 3. click on the drop down again (should be 4 entry's with smaller font 7, 8, 9 and 10 visible) Confirm (no entry's) Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL also in Version: 7.0.0.0.beta1+ (x64) Build ID: 2891e91a513520d68ea2b8c59c14335861a15253 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL fine with Version: 6.4.0.0.beta1+ (x64) (4 entry's before) Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148778] Librecalc memory likage - it cannot empty memory
https://bugs.documentfoundation.org/show_bug.cgi?id=148778 --- Comment #2 from elias estatistics --- In my machine, i can reproduce, freeze, very well. I think that it has to do with "adapt-row" topic. Cause, when i am copying some tables over formula sheet, it may need 1 minute (!!) in order to copy them -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147586] FILEOPEN PPTX: bullet points in list appear black instead of blue (style issue?)
https://bugs.documentfoundation.org/show_bug.cgi?id=147586 Xisco Faulí changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | Status|NEW |ASSIGNED --- Comment #5 from Xisco Faulí --- i think I know how to fix it -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107765] CALC: Switching language during spell-check doesn't change the text's language property
https://bugs.documentfoundation.org/show_bug.cgi?id=107765 --- Comment #6 from Justin L --- My guess is that it is from 5f62f8e19d07c795b98ca85350b00b5d1edef3e2 Auto spell-check is no longer done in ScDocument. where we now call pViewSh->ContinueOnlineSpelling() instead of doing something at the document level - which did have some language code in it. Another good place to check is sc/source/ui/view/spelldialog.cxx's ApplyChangedSentence() -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/oox oox/source
include/oox/export/drawingml.hxx |5
oox/source/export/drawingml.cxx | 650 ++-
2 files changed, 309 insertions(+), 346 deletions(-)
New commits:
commit f2458bab5d67a988feb9ba72d70e0649a979fcb1
Author: Regina Henschel
AuthorDate: Mon Apr 25 11:09:07 2022 +0200
Commit: Xisco Fauli
CommitDate: Mon Apr 25 20:29:04 2022 +0200
Extract 'switch' block out of WriteCustomGeometry
This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2.
That commit has increased the line count of WriteCustomGeometry to more
than 500. This patch splits it to a main part of about 230 lines and
a new method for the previous 'switch' block of about 300 lines. That
makes the loops in the main part better readable.
Change-Id: Ied4378f54e7c8dc7965a5b1db15baf0b35f63f59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132274
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133369
diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index 7fbb015b4ce4..dc01e20f9199 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -201,6 +201,11 @@ protected:
void WriteSoftEdgeEffect(const
css::uno::Reference& rXPropSet);
void WriteCustomGeometryPoint(const
css::drawing::EnhancedCustomShapeParameterPair& rParamPair,
const EnhancedCustomShape2d& rCustomShape2d);
+bool WriteCustomGeometrySegment(
+const sal_Int16 eCommand, const sal_Int32 nCount,
+const
css::uno::Sequence& rPairs,
+sal_Int32& rnPairIndex, double& rfCurrentX, double& rfCurrentY, bool&
rbCurrentValid,
+const EnhancedCustomShape2d& rCustomShape2d);
public:
DrawingML( ::sax_fastparser::FSHelperPtr pFS, ::oox::core::XmlFilterBase*
pFB, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport =
nullptr )
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index d4dbef899b96..311669bd5cbe 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3951,352 +3951,9 @@ bool DrawingML::WriteCustomGeometry(
}
for (sal_Int32 k = 0; k < rSegment.Count && bOK; ++k)
{
-switch (rSegment.Command)
-{
-case MOVETO:
-{
-if (nPairIndex >= aPairs.getLength())
-bOK = false;
-else
-{
-mpFS->startElementNS(XML_a, XML_moveTo);
-WriteCustomGeometryPoint(aPairs[nPairIndex],
aCustomShape2d);
-mpFS->endElementNS(XML_a, XML_moveTo);
-aCustomShape2d.GetParameter(fCurrentX,
aPairs[nPairIndex].First, false,
-false);
-aCustomShape2d.GetParameter(fCurrentY,
aPairs[nPairIndex].Second, false,
-false);
-bCurrentValid = true;
-nPairIndex++;
-}
-break;
-}
-case LINETO:
-{
-if (nPairIndex >= aPairs.getLength())
-bOK = false;
-else
-{
-mpFS->startElementNS(XML_a, XML_lnTo);
-WriteCustomGeometryPoint(aPairs[nPairIndex],
aCustomShape2d);
-mpFS->endElementNS(XML_a, XML_lnTo);
-aCustomShape2d.GetParameter(fCurrentX,
aPairs[nPairIndex].First, false,
-false);
-aCustomShape2d.GetParameter(fCurrentY,
aPairs[nPairIndex].Second, false,
-false);
-bCurrentValid = true;
-nPairIndex++;
-}
-break;
-}
-case CURVETO:
-{
-if (nPairIndex + 2 >= aPairs.getLength())
-bOK = false;
-else
-{
-mpFS->startElementNS(XML_a, XML_cubicBezTo);
-for (sal_uInt8 l = 0; l <= 2; ++l)
-{
-WriteCustomGeometryPoint(aPairs[nPairIndex +
l], aCustomShape2d);
-}
-mpFS->endElementNS(XML_a, XML_cubicBezTo);
-
[Libreoffice-bugs] [Bug 148778] Librecalc memory likage - it cannot empty memory
https://bugs.documentfoundation.org/show_bug.cgi?id=148778 --- Comment #1 from elias estatistics --- Created attachment 179765 --> https://bugs.documentfoundation.org/attachment.cgi?id=179765=edit workbench with simple tables. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148778] New: Librecalc memory likage - it cannot empty memory
https://bugs.documentfoundation.org/show_bug.cgi?id=148778 Bug ID: 148778 Summary: Librecalc memory likage - it cannot empty memory Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: elias__0...@yahoo.com Created attachment 179764 --> https://bugs.documentfoundation.org/attachment.cgi?id=179764=edit image showing >5gb consumed by a simple workbook. Librecalc memory likage - it cannot empty memory I have done a lot resets working only two calc workbooks. My computer almost freezes. When i close all other workbooks except one which contains simple tables (no formulas), memory is almost >5GBs while when shutting down libreoffice, and opening only that workbook, then total memory is about ~1GB. (total ~8GBs mem) Reproduce 0) restrict memory to libre about 8GBs a) open many sheets with formula in order to memory goes almost full (~7GBs in total) b) close all "complicated sheets". c) except the simplest one without formulas. d) computer cannot empty memory after 1 to 5 minutes... e) freezes... Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 566ee17c2709f9939145ddc7fbb1d61c35049321 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb) Locale: el-GR (el_GR.UTF-8); UI: en-US Calc: threaded Jumbo Architecture:x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 39 bits physical, 48 bits virtual CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 NUMA node(s):1 Vendor ID: GenuineIntel CPU family: 6 Model: 60 Model name: Intel(R) Core(TM) i5-4570S CPU @ 2.90GHz Stepping:3 CPU MHz: 2178.963 CPU max MHz: 3600. CPU min MHz: 800. BogoMIPS:5786.55 Virtualization: VT-x L1d cache: 128 KiB L1i cache: 128 KiB L2 cache:1 MiB L3 cache:6 MiB NUMA node0 CPU(s): 0-3 Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cach e flushes, SMT disabled Vulnerability Mds: Mitigation; Clear CPU buffers; SMT disabled Vulnerability Meltdown: Mitigation; PTI Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled v ia prctl and seccomp Vulnerability Spectre v1:Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2:Mitigation; Full generic retpoline, IBPB condit ional, IBRS_FW, STIBP disabled, RSB filling Vulnerability Srbds: Mitigation; Microcode Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtr r pge mca cmov pat pse36 clflush dts acpi mmx f xsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rd tscp lm constant_tsc arch_perfmon pebs bts rep_ good nopl xtopology nonstop_tsc cpuid aperfmper f pni pclmulqdq dtes64 monitor ds_cpl vmx smx e st tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_ 1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm cpuid_fa ult invpcid_single pti ssbd ibrs ibpb stibp tpr _shadow vnmi flexpriority ept vpid ept_ad fsgsb ase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts md_clear flus h_l1d $$P. ,g$$P" """Y$$.".OS: Debian GNU/Linux 11 (bullseye) x86_64 ,$$P' `$$$. Host: B85M-HD3 R4 ',$$P ,ggs. `$$b: Kernel: 5.11.0-18-generic `d$$' ,$P"' .$$$Uptime: 1 hour, 28 mins $$P d$' ,$$PPackages: 6371 (dpkg), 4 (flatpak) $$: $$. -,d$$'Shell: bash 5.1.4 Y$$.`.`"YP"'Resolution: 1920x1080 `$$b.
[Libreoffice-bugs] [Bug 130715] copy cell range from one sheet to another does not work (openSUSE-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=130715 --- Comment #22 from Buovjaga --- (In reply to Eric from comment #21) > Can you explain? This was not installed by Yast, but as a direct download > from libroffice and using the install script from the tarball to install > locally in my home directory I can't except that there seems to be something in the openSUSE KDE distro that brings this about. As I said in an earlier comment, Arch Linux with KDE does not exhibit this even with Klipper active. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148464] Ability to pick-and-choose where to search
https://bugs.documentfoundation.org/show_bug.cgi?id=148464 --- Comment #4 from Eyal Rozenberg --- (In reply to Heiko Tietze from bug #96474 comment #10) > The topic was on the agenda of the design meeting. > > Solution a) is to list all entities similar to attributes and check it by > default. The idea in comment 3 is not flexible, hard to understand and takes > a lot of space. > Solution b) would be to know where the search was started from and allow to > "[ ] Search only in %1". > Solution c) is to start the search command with a parameter like > .uno:Search?where="comment" and allow to restrict the search to this entity > only > > Solutions b) and c) clutter less, a) is more flexible (but requires a check > all/none option). I'll rephrase, since the minutes mis-capture my opinion as it evolved over the course of the meeting.. (a) (b) and (c) are for me all parts of the same solution: * A sub-dialog of the F dialog will list all _kinds_ of entities, just like we currently have for Attributes. The entries could be something like: Body, footnotes, endnotes, comments, footers, headers, headings etc. etc. * The initial selection on this dialog will depend on how or from where you got into the F dialog. For example, if the comment context menu had an item called "search comments", it would bring up F with only comments checked; but the main menu item would not do that. One can bike-shed what the default selection should be, and whether using the same menu item from different places should affect the default. * The initial selection can be overriden by a parameter of the UNO command, which would be a list of checked/selected items. So, the way a "search comments" would be implemented is the F dialog command, with a setting of the initial selection parameter to only have comments. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148464] Ability to pick-and-choose where to search
https://bugs.documentfoundation.org/show_bug.cgi?id=148464 --- Comment #4 from Eyal Rozenberg --- (In reply to Heiko Tietze from bug #96474 comment #10) > The topic was on the agenda of the design meeting. > > Solution a) is to list all entities similar to attributes and check it by > default. The idea in comment 3 is not flexible, hard to understand and takes > a lot of space. > Solution b) would be to know where the search was started from and allow to > "[ ] Search only in %1". > Solution c) is to start the search command with a parameter like > .uno:Search?where="comment" and allow to restrict the search to this entity > only > > Solutions b) and c) clutter less, a) is more flexible (but requires a check > all/none option). I'll rephrase, since the minutes mis-capture my opinion as it evolved over the course of the meeting.. (a) (b) and (c) are for me all parts of the same solution: * A sub-dialog of the F dialog will list all _kinds_ of entities, just like we currently have for Attributes. The entries could be something like: Body, footnotes, endnotes, comments, footers, headers, headings etc. etc. * The initial selection on this dialog will depend on how or from where you got into the F dialog. For example, if the comment context menu had an item called "search comments", it would bring up F with only comments checked; but the main menu item would not do that. One can bike-shed what the default selection should be, and whether using the same menu item from different places should affect the default. * The initial selection can be overriden by a parameter of the UNO command, which would be a list of checked/selected items. So, the way a "search comments" would be implemented is the F dialog command, with a setting of the initial selection parameter to only have comments. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130715] copy cell range from one sheet to another does not work (openSUSE-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=130715 --- Comment #21 from Eric --- Can you explain? This was not installed by Yast, but as a direct download from libroffice and using the install script from the tarball to install locally in my home directory -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119010] Page area hatch doesn't work correctly in a Writer document with mirrored pages.
https://bugs.documentfoundation.org/show_bug.cgi?id=119010 --- Comment #9 from Robin Henderson --- I’ve re-tested this using LibreOffice 7.3.2.2 on Mac OS X 10.16 and confirm that there is still a bug present and that Gradient, Image, Pattern and Hash aren’t presented correctly on the LH page. This is slightly different to the way that the bug originally presented itself when first reported. Before testing on 7.3.2.3, I tested the bug on LibreOffice v6.x and although there was still a bug present it didn’t show show up quite so obviously (ie., it nearly worked). It wasn’t evident for Gradient but for Image, Pattern and Hash the page area wasn’t always filled consistently. I would therefore conclude that there appears to be some regression between v6.x and v7.3.2.2. The page diagram on Format >> Page Style… >> Page, the area filled in doesn’t include the margins. When the problem was originally reported, only the page text area was filled in and not the margins (see attachment provided). This is a change and not an improvement. Comments about v3.3 have already been made. This feature wasn't present in v3.3. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130715] copy cell range from one sheet to another does not work (openSUSE-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=130715 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Summary|copy cell range from one|copy cell range from one |sheet to another does not |sheet to another does not |work|work (openSUSE-only) --- Comment #20 from Buovjaga --- I think your best bet is to get openSUSE developers involved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130715] copy cell range from one sheet to another does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=130715 Eric changed: What|Removed |Added CC||erben...@comcast.net --- Comment #19 from Eric --- I just downloaded LO: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded And installed it i my home directory separate from the distro install I tried to copy a column of data from one sheet to a new sheet in the same document and nothing happens. Nothing at all is pasted. This has bugged me a lot in prev versions so I was hoping a direct install would fix it but it doesn't openSUSE Leap 15.3 / (x86_64) Installed Memory 8G KDE 5.76.0 Plasma 5.18.6 Qt: 5.12.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148432 --- Comment #6 from Eyal Rozenberg --- (In reply to Caolán McNamara from comment #5) > My understanding is that all those UI things follow the UI Language rather > than the document language Yes. But - this becomes a problem when you fill up the UI with document content - which is what happens in Navigator. It also happens in the xref dialog (bug 131725). The worst part of it is how you get the ends of labels rather than the beginning of labels. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148433] Extreme keyboard input delays on linux in paragraphs which contain both rtl and ltr characters
https://bugs.documentfoundation.org/show_bug.cgi?id=148433 --- Comment #17 from Yotam Benshalom --- Holding shift does not make any difference. No input method is defined in settings->area and language->manage installed languages. I think they are not relevant to rtl languages. Changing the keyboard input language has no effect. Changing font (using fonts from various sources) makes no difference. Please note that on further investigation I found that this happens whenever rtl and ltr (e.g., latin) characters are mixed together. This is not exclusive to the case of rtl and numeric characters in the same paragraph. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148648] Need to make Insert cross-ref more accessible
https://bugs.documentfoundation.org/show_bug.cgi?id=148648 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > Shortcuts are precious and hard if not impossible to remove later. Fair enough... > What key combination do you have in mind? Anything would be better than no shortcut, I guess... how about Alt+Shift+R, or Alt+Shift+C? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148648] Need to make Insert cross-ref more accessible
https://bugs.documentfoundation.org/show_bug.cgi?id=148648 --- Comment #2 from Eyal Rozenberg --- (In reply to Heiko Tietze from comment #1) > Shortcuts are precious and hard if not impossible to remove later. Fair enough... > What key combination do you have in mind? Anything would be better than no shortcut, I guess... how about Alt+Shift+R, or Alt+Shift+C? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148777] The tip of the day 106/223
https://bugs.documentfoundation.org/show_bug.cgi?id=148777 --- Comment #1 from Mehrad Mahmoudian --- Created attachment 179763 --> https://bugs.documentfoundation.org/attachment.cgi?id=179763=edit TipOfTheDay106 This is what I see for this TipOfTheDay -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148777] New: The tip of the day 106/223
https://bugs.documentfoundation.org/show_bug.cgi?id=148777 Bug ID: 148777 Summary: The tip of the day 106/223 Product: LibreOffice Version: 7.2.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m.mahmoud...@gmail.com Description: The tip of the day number 106 (I wish there was a universal permanent way to point at them) is very vague and is practically useless. It reads: > Citation management? Use a 3rd party extension. Not that it grammatically is wrong, it is lacking the most important information: "what?" I propose adding at least one 3rd-party Citation manager to the text to clarify to user what you mean. For instance the text can be altered to: > Need to do citation? You can use 3rd-party citation managers such as Zotero The reasons I wrote Zotero are: - it is Free and Libre Opensource Software - user own the data and until Mendeley it is not stored in some sort of cryptic database Steps to Reproduce: 1. open LibreOffice 2. press Next Tip button enough times to get to tip number 106/223 Actual Results: > Citation management? Use a 3rd party extension. Expected Results: > Need to do citation? You can use 3rd-party citation managers such as Zotero Reproducible: Always User Profile Reset: No Additional Info: NOT APPLICABLE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility
https://bugs.documentfoundation.org/show_bug.cgi?id=139007 Olivier Hallot changed: What|Removed |Added Depends on||148776 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148776 [Bug 148776] PDF Accessibility: checker windows scroll steps too small -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148776] New: PDF Accessibility: checker windows scroll steps too small
https://bugs.documentfoundation.org/show_bug.cgi?id=148776 Bug ID: 148776 Summary: PDF Accessibility: checker windows scroll steps too small Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org Blocks: 139007 On using the Accessibility checker (Tools - Accessibility check) in a Writer document, the dialog list the issues found. However on scrolling the list, the scroll is too slow, as when the scroll minimal step is too small. It forces to use the mouse roller too much. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139007 [Bug 139007] [META] PDF accessibility -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf148380_printField.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport17.cxx | 17
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 64 +++-
writerfilter/source/dmapper/DomainMapper_Impl.hxx |1
4 files changed, 61 insertions(+), 21 deletions(-)
New commits:
commit 115599cc3478e37879cd2fa0b6c6c9dabde7dfd1
Author: Justin Luth
AuthorDate: Sat Apr 9 18:06:24 2022 +0200
Commit: Justin Luth
CommitDate: Mon Apr 25 18:57:45 2022 +0200
tdf#132475 writerfilter: use proper date-field defaults
When a field doesn't specify the format for a date,
the system is free to implement it as it chooses.
However, the user tends to disagree with that,
so lets try to create a MS-similar default for
these dates - since LO defaults to only displaying
a date without any time component.
For example: PRINTDATE \* MERGEFORMAT
doesn't tell us how to display the date.
MS Word uses different defaults depending on
the language of the document. And that only make sense.
For example, I noticed that of course en-GB's format
is dd/MM/ instead of en-US's M/d/.
As a documentation example: 17.16.5.47 PRINTDATE
Syntax: PRINTDATE [ switches ]
Description: Retrieves the date and time on which the
document was last printed, as recorded in the
LastPrinted element of the Core File Properties part.
Switches: Zero or one date-and-time-formatting-switch
and zero or one of the following field-specific-switches.
PRINTDATE (without any formatting switches)
the results are:
1/6/2006 2:58:00 PM
Change-Id: I41f3bdc155bd8cdc74177e4626b31ece9b47e16b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133208
Tested-by: Justin Luth
Tested-by: Jenkins
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ooxmlexport/data/tdf148380_printField.docx
b/sw/qa/extras/ooxmlexport/data/tdf148380_printField.docx
new file mode 100644
index ..44145748c6ed
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf148380_printField.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index 9347a8abfb54..464c0b22d6c4 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -100,6 +100,23 @@ DECLARE_OOXMLEXPORT_TEST(testTdf148380_modifiedField,
"tdf148380_modifiedField.d
OUString("Charles Brown"),
xField->getPresentation(false));
}
+DECLARE_OOXMLEXPORT_TEST(testTdf148380_printField, "tdf148380_printField.docx")
+{
+// Verify that these are fields, and not just plain text
+uno::Reference xTextFieldsSupplier(mxComponent,
uno::UNO_QUERY);
+auto xFieldsAccess(xTextFieldsSupplier->getTextFields());
+uno::Reference
xFields(xFieldsAccess->createEnumeration());
+uno::Reference xField(xFields->nextElement(),
uno::UNO_QUERY);
+// unspecified SAVEDATE gets default GB formatting because stylele.xml has
w:lang w:val="en-GB"
+//CPPUNIT_ASSERT_EQUAL(OUString("08/04/2022 07:10:00 AM"),
xField->getPresentation(false));
+//CPPUNIT_ASSERT_EQUAL(OUString("DocInformation:Modified"),
xField->getPresentation(true));
+//xField.set(xFields->nextElement(), uno::UNO_QUERY);
+// MS Word actually shows "8 o'clock-ish" until the document is reprinted,
+// but it seems best to actually show the real last-printed date since it
can't be FIXEDFLD
+CPPUNIT_ASSERT_EQUAL(OUString("08/04/2022 06:47:00 AM"),
xField->getPresentation(false));
+CPPUNIT_ASSERT_EQUAL(OUString("DocInformation:Last printed"),
xField->getPresentation(true));
+}
+
DECLARE_OOXMLEXPORT_TEST(testTdf132475_printField, "tdf132475_printField.docx")
{
// The last printed date field: formatted two different ways
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 6206a9386edb..d8327fa8d248 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -35,6 +35,8 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
@@ -1187,6 +1189,15 @@ uno::Any DomainMapper_Impl::GetAnyProperty(PropertyIds
eId, const PropertyMapPtr
return aProperty->second;
}
+// then look whether it was directly applied as a paragraph property
+PropertyMapPtr pParaContext = GetTopContextOfType(CONTEXT_PARAGRAPH);
+if (pParaContext && rContext != pParaContext)
+{
+std::optional aProperty =
pParaContext->getProperty(eId);
+if (aProperty)
+return aProperty->second;
+}
+
// then look whether it was inherited from a directly applied character
style
if ( eId != PROP_CHAR_STYLE_NAME && isCharacterProperty(eId) )
{
@@ -4429,23 +4440,6 @@ static OUString
[Libreoffice-bugs] [Bug 142253] Writer cursor can't be stopped from blinking
https://bugs.documentfoundation.org/show_bug.cgi?id=142253 Buovjaga changed: What|Removed |Added Resolution|--- |INVALID Status|NEEDINFO|RESOLVED --- Comment #9 from Buovjaga --- Great to hear :) I am closing this as invalid for lack of a better status. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142253] Writer cursor can't be stopped from blinking
https://bugs.documentfoundation.org/show_bug.cgi?id=142253 --- Comment #8 from Jon --- Many Thanks! Problem solved. The blinking cursor might seem a small problem but as I have one or two slightly autistic traits the blinking was driving me KNUTZ! Thanks again. (It seems the worm was added by my copy & paste operation.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 139395] Writer Paragraph Style dialog is too tall: OK/Cancel buttons are not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=139395 --- Comment #26 from Mike Kaganski --- Personally I'd prefer the sections made collapsible, remember their collapsed state, and make all dialogs have scrollbars. [/rant off] -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/draw/shapeexport.cxx | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit fd4410aa5fd079e4277297f1fb70ad8c728e7a17
Author: Julien Nabet
AuthorDate: Thu Apr 21 18:06:57 2022 +0200
Commit: Julien Nabet
CommitDate: Mon Apr 25 18:30:26 2022 +0200
tdf#145240: Can't save drawing if I'm adding a short freeform line with no
fill
Here are the steps of the dup tdf#148693:
1. Open a new sheet in LibreOffice Draw
2. Select the tool Shape/Insert/Curves and Polygons
3. Draw a short line (I mean very short)
4. Click "File" > "Save" and select a random place to save
=>
1 0x7fcd3c774fcb in
o3tl::doAccess(com::sun::star::uno::Any
const&) (any=
uno::Any("[][]com.sun.star.awt.Point": uno::Sequence of length 1 =
{uno::Sequence of length 2 = {{X = 0, Y = 0}, {X = 252, Y = 0}}})) at
include/o3tl/any.hxx:284
2 0x7fcd3c74f759 in
XMLShapeExport::ImpExportPolygonShape(com::sun::star::uno::Reference
const&, XmlShapeType, XMLShapeExportFlags, com::sun::star::awt::Point*)
(this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *)
0x7bcb3a8, eShapeType=XmlShapeTypeDrawOpenBezierShape, nFeatures=15,
pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:2342
3 0x7fcd3c74d952 in
XMLShapeExport::exportShape(com::sun::star::uno::Reference
const&, XMLShapeExportFlags, com::sun::star::awt::Point*, SvXMLAttributeList*)
(this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *)
0x7bcb3a8, nFeatures=15, pRefPoint=0x0, pAttrList=0x0) at
xmloff/source/draw/shapeexport.cxx:811
4 0x7fcd3c75cca1 in
XMLShapeExport::exportShapes(com::sun::star::uno::Reference
const&, XMLShapeExportFlags, com::sun::star::awt::Point*)
(this=0x8770560, xShapes=uno::Reference to (SdDrawPage *) 0x2d6b258,
nFeatures=15, pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:1006
Change-Id: Ie6d626999bf606f951f4f79a7c314559a9a886f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133273
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/xmloff/source/draw/shapeexport.cxx
b/xmloff/source/draw/shapeexport.cxx
index 55de243f07aa..9b069a07eb2c 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -2338,11 +2338,13 @@ void XMLShapeExport::ImpExportPolygonShape(
{
// get PolygonBezier
uno::Any aAny( xPropSet->getPropertyValue("Geometry") );
-const basegfx::B2DPolyPolygon aPolyPolygon(
-
basegfx::utils::UnoPolyPolygonBezierCoordsToB2DPolyPolygon(*o3tl::doAccess(aAny)));
-
-if(aPolyPolygon.count())
+auto pSourcePolyPolygon =
o3tl::tryAccess(aAny);
+if(pSourcePolyPolygon && pSourcePolyPolygon->Coordinates.getLength())
{
+const basegfx::B2DPolyPolygon aPolyPolygon(
+basegfx::utils::UnoPolyPolygonBezierCoordsToB2DPolyPolygon(
+*pSourcePolyPolygon));
+
// complex polygon shape, write as svg:d
const OUString aPolygonString(
basegfx::utils::exportToSvgD(
[Libreoffice-bugs] [Bug 148075] LibreOffice crashes when opening certain large files (which worked with other versions)
https://bugs.documentfoundation.org/show_bug.cgi?id=148075 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #19 from Julien Nabet --- (In reply to Adalbert Hanßen from comment #18) > ... > I am happily surprised that this version did not show the crash on all files > the one before uploaded (and some more where the previous ones all failed). > > I'll keep an open eye in the next time (and I'll use the development version > more often than in the last weeks now). Good news then! :-) However since it's a dev version, do think even more than usual about making backups regularly and let's put this one to WFM. Of course, don't hesitate to reopen if you still reproduce the crash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131828] Font size feedback is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=131828 Julien Nabet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #5 from Julien Nabet --- Thank you Heiko for the feedback, let's put this one to Not A Bug then. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang connectivity/source drawinglayer/source sc/source
compilerplugins/clang/plugin.cxx | 177 ++
compilerplugins/clang/plugin.hxx |4
compilerplugins/clang/redundantfcast.cxx | 30 --
connectivity/source/drivers/firebird/DatabaseMetaData.cxx |1
drawinglayer/source/tools/emfppen.cxx |4
sc/source/core/data/table2.cxx|2
6 files changed, 200 insertions(+), 18 deletions(-)
New commits:
commit e63e769bd30800b72f4a1cdfc7222c0b64f3c770
Author: Stephan Bergmann
AuthorDate: Mon Apr 25 10:10:55 2022 +0200
Commit: Stephan Bergmann
CommitDate: Mon Apr 25 18:21:24 2022 +0200
Introduce a better mechanism to suppress false loplugin warnings
...by annotating occurrences of false warnings with [-loplugin:]
comments
in source files and letting individual plugins opt-in to watch out for such
suppression annotations, rather than maintaining lists of excluded source
files
in the individual plugins. (See the new
loplugin::Plugin::suppressWarningsAt.)
Instead of making all calls to loplugin::Plugin::report check for
suppression
annotations, the intent is that this check will only be added opt-in to
those
places in the plugins that are prone to emitting false warnings. In
general it
is better to have plugins that don't produce false warnings in the first
place,
or at least let those warnings be addressed with trivial and harmless source
code modifications, avoiding the need for any suppression mechanism.
As a proof of concept, I have removed the exclude list from
loplugin:redundantfcast and instead annotated the relevant source code.
(And
thereby found that three of the six originally excluded files didn't need
to be
excluded any more at all?)
For now, this mechanism looks for comments (both //... and /*...*/, even
documentation-style /**...*/) that overlap the current and/or the preceding
line, because at least for code controlled by clang-format it is often
easier to
move comments to a line of their own, preceding the commented code. Looking
also at the current line (and not only at the preceding one) opens the door
for
erroneous over-eager annotation, where an annotation that was meant to
address a
false warning on the current line would also silence a potentially true
warning
on the following line. This probably doesn't cause much trouble in
practice,
but is up for potential change.
Change-Id: I91ce7a0e5248886a60b471b1a153867f16bb5cea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133365
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 8bf5b4333bdc..727eda589548 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -128,6 +128,183 @@ DiagnosticBuilder Plugin::report(
DiagnosticsEngine::Level level, StringRef mess
return handler.report( level, name, message, compiler, loc );
}
+bool Plugin::suppressWarningAt(SourceLocation location) const {
+auto const start = compiler.getSourceManager().getSpellingLoc(location);
+auto const startInfo = compiler.getSourceManager().getDecomposedLoc(start);
+auto invalid = false;
+auto const buf =
compiler.getSourceManager().getBufferData(startInfo.first, );
+if (invalid) {
+if (isDebugMode()) {
+report(DiagnosticsEngine::Fatal, "failed to getBufferData", start);
+}
+return false;
+}
+auto const label = std::string("[-loplugin:").append(name).append("]");
+// Look back to the beginning of the previous line:
+auto loc = start;
+auto locInfo = startInfo;
+auto cur = loc;
+enum class State { Normal, Slash, Comment };
+auto state = State::Normal;
+auto newlines = 0;
+for (auto prev = cur;;) {
+auto prevInfo = compiler.getSourceManager().getDecomposedLoc(prev);
+if (prev ==
compiler.getSourceManager().getLocForStartOfFile(prevInfo.first)) {
+if (state == State::Comment && isDebugMode()) {
+report(
+DiagnosticsEngine::Fatal,
+"beginning of file while looking for beginning of
comment", prev);
+}
+break;
+}
+Token tok;
+if (Lexer::getRawToken(
+Lexer::GetBeginningOfToken(
+prev.getLocWithOffset(-1), compiler.getSourceManager(),
compiler.getLangOpts()),
+tok, compiler.getSourceManager(), compiler.getLangOpts(),
true))
+{
+if (isDebugMode()) {
+report(
+DiagnosticsEngine::Fatal, "failed to getRawToken",
+prev.getLocWithOffset(-1));
+}
+break;
+}
+if (tok.getLocation() == cur) {
+// Keep walking back,
