Re: SalAbort:Unspecified application error

2022-04-29 Thread Michael Weghorn

On 30/04/2022 06.14, di liu wrote:
I am so sorry,I made a mistake (I made some local changes but did not 
restore the code completely which interferes the test result.)

After my initial test(on the same devices) the crash disappeared.
I will continue to test this issue on different devices and scenarios to 
make sure it be fixed completely


Great, thanks for the update.


  Yeah,thank you so much for all you do.


Thank you for your valuable input. :-)


OpenPGP_signature
Description: OpenPGP digital signature


[Libreoffice-bugs] [Bug 111443] [META] Unsupported formats in LibreOffice Viewer

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111443
Bug 111443 depends on bug 111427, which changed state.

Bug 111427 Summary: Add support for .ppsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=111427

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: android/source

2022-04-29 Thread Michael Weghorn (via logerrit)
 android/source/src/java/org/libreoffice/ui/FileUtilities.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c50afd45d2f6a7c70bb3a7591747b162a2675311
Author: Michael Weghorn 
AuthorDate: Fri Apr 29 22:01:07 2022 +0200
Commit: Michael Weghorn 
CommitDate: Sat Apr 30 07:11:04 2022 +0200

android: Show Impress icon for .pps files

For some reason, that was commented out.
Opening such a PowerPoint file worked just
fine, and with this commit in place, the
Impress icon is shown in the "Recent Files"
view as well.

Change-Id: I69bce54074c084928d9aa7b95f37145a9692b847
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133649
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/android/source/src/java/org/libreoffice/ui/FileUtilities.java 
b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
index 4675ca1d0709..52b92534947f 100644
--- a/android/source/src/java/org/libreoffice/ui/FileUtilities.java
+++ b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
@@ -63,7 +63,7 @@ public class FileUtilities {
 mExtnMap.put(".vsdx", DRAWING);
 mExtnMap.put(".pub", DRAWING);
 mExtnMap.put(".ppt",  IMPRESS);
-// mExtnMap.put(".pps",  IMPRESS);
+mExtnMap.put(".pps",  IMPRESS);
 mExtnMap.put(".xls",  CALC);
 
 // MS templates


[Libreoffice-commits] core.git: android/source

2022-04-29 Thread Michael Weghorn (via logerrit)
 android/source/AndroidManifest.xml|2 +-
 android/source/src/java/org/libreoffice/ui/FileUtilities.java |2 +-
 android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java |1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 965205931162b7fcdc175672354103b40985c6ed
Author: Michael Weghorn 
AuthorDate: Fri Apr 29 21:55:54 2022 +0200
Commit: Michael Weghorn 
CommitDate: Sat Apr 30 07:10:35 2022 +0200

tdf#111427 android: Enable support for .ppsx

Opening the sample file of MIME type
"application/vnd.openxmlformats-officedocument.presentationml.slideshow"
attached to tdf#111427 worked fine now when testing in an x86_64 AVD
with API level 31, so declare support for it.

Change-Id: I67ace0fb6ee82c0a43624dc32671ba2d453e473c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133648
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/android/source/AndroidManifest.xml 
b/android/source/AndroidManifest.xml
index 0af368c8460b..c50ad77ae71d 100644
--- a/android/source/AndroidManifest.xml
+++ b/android/source/AndroidManifest.xml
@@ -70,7 +70,7 @@
 
 
 
-
+
 
 
 
diff --git a/android/source/src/java/org/libreoffice/ui/FileUtilities.java 
b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
index 72da47b8cc3a..4675ca1d0709 100644
--- a/android/source/src/java/org/libreoffice/ui/FileUtilities.java
+++ b/android/source/src/java/org/libreoffice/ui/FileUtilities.java
@@ -74,7 +74,7 @@ public class FileUtilities {
 // OOXML
 mExtnMap.put(".docx", DOC);
 mExtnMap.put(".pptx", IMPRESS);
-// mExtnMap.put(".ppsx", IMPRESS);
+mExtnMap.put(".ppsx", IMPRESS);
 mExtnMap.put(".xlsx", CALC);
 
 // OOXML templates
diff --git 
a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java 
b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 965639e6e2ba..e7b38b4cac86 100644
--- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -103,6 +103,7 @@ public class LibreOfficeUIActivity extends 
AppCompatActivity implements Settings
 "application/x-mspublisher",
 
"application/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
 
"application/vnd.openxmlformats-officedocument.presentationml.presentation",
+
"application/vnd.openxmlformats-officedocument.presentationml.slideshow",
 
"application/vnd.openxmlformats-officedocument.wordprocessingml.document",
 
"application/vnd.openxmlformats-officedocument.wordprocessingml.template",
 
"application/vnd.openxmlformats-officedocument.spreadsheetml.template",


[Libreoffice-bugs] [Bug 49099] Locking elements in master slides should keep them locked in later use.

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49099

--- Comment #2 from Panos Stokas  ---
Locking flags are also lost on slide reload.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: SalAbort:Unspecified application error

2022-04-29 Thread di liu
>
> I have created a separate ticket in Bugzilla for that one and added some
> more information, also mentioning a potential workaround:
> https://bugs.documentfoundation.org/show_bug.cgi?id=148854
>
> I suggest to continue discussion about that particular issue in Bugzilla
> (e.g. I'd be interested whether your crash also disappears when you do
> that change locally).
>

Ok,I will post the follow-up questions here

Michael Weghorn  于2022年4月29日周五 23:39写道:

>
> On 29/04/2022 12.54, Michael Weghorn wrote:
> >> Is that file confidential or can it be shared publicly (attached to
> a
> >> Bugzilla ticket)? (I can't read most of the text in it. :-))
> >>
> >>
> >>  The file is not confidential and can be shared publicly (haha,The
> >> text in it is chiness)
> >
> > Great, thanks.
>
> I've now created a Bugzilla ticket for the initial issue that I could
> reproduce and have a pending fix for that in Gerrit:
> https://bugs.documentfoundation.org/show_bug.cgi?id=148851
> https://gerrit.libreoffice.org/c/core/+/133581
>
> With that in place, I didn't see any more crashes or unexpected memory
> usage increase when testing more with your sample doc and experimental
> mode *disabled*.
>
> I can still reproduce a crash due to running out of memory with
> experimental mode *enabled*, though.
>
> I have created a separate ticket in Bugzilla for that one and added some
> more information, also mentioning a potential workaround:
> https://bugs.documentfoundation.org/show_bug.cgi?id=148854
>
> I suggest to continue discussion about that particular issue in Bugzilla
> (e.g. I'd be interested whether your crash also disappears when you do
> that change locally).
>
> >  My compile machine only has 4GB RAM so that i must restrict the symbols
> but even so the memory is also not enough(because of that link error
> "clang++ error:unable to execute command Killed")
>
> 4 GB are actually not much. I have no further ideas what you could
> do/try to do a build with debug symbols in that setup, other than having
> lots of swap, which will probably be very slow.
>


Re: SalAbort:Unspecified application error

2022-04-29 Thread di liu
>
> Does "more times" here mean that it takes longer now than previously
> until the problem shows up? Or is it pretty much unchanged for you?
>
> Is that with experimental mode enabled or disabled in the app settings?
>

I am so sorry,I made a mistake (I made some local changes but did not
restore the code completely which interferes the test result.)
After my initial test(on the same devices) the crash disappeared.
I will continue to test this issue on different devices and scenarios to
make sure it be fixed completely

Yes, that's most likely.
> The one from https://gerrit.libreoffice.org/c/core/+/133581 is also
> called further down in the stack from there and was clearly showing up
> in the memory profile.
>
> The app was working fine with the sample file in non-editing mode  for
> me with that hack in place in a quick test.
> But it's well possible that there are more leaks elsewhere.
>


 Yeah,thank you so much for all you do.

Michael Weghorn  于2022年4月29日周五 18:54写道:

> > Is that file confidential or can it be shared publicly (attached to a
> > Bugzilla ticket)? (I can't read most of the text in it. :-))
> >
> >
> >  The file is not confidential and can be shared publicly (haha,The text
> in it is chiness)
>
> Great, thanks.
>
>
> On 29/04/2022 12.07, di liu wrote:
> > Ok, I will make a try (recompile the source code will spend me
> > hours... )
> >
> >
> > Unfortunately it's also crash with same error when i swipe up and down
> > more times.
>
> Does "more times" here mean that it takes longer now than previously
> until the problem shows up? Or is it pretty much unchanged for you?
>
> Is that with experimental mode enabled or disabled in the app settings?
>
> > I suppose the memory leak maybe exit in this method
> > "desktop/source/lib/init.cxx -> doc_paintTile".Because every time i
> > swipe the screen the java code will call this method to paint tile where
> > crash was happened
>
> Yes, that's most likely.
> The one from https://gerrit.libreoffice.org/c/core/+/133581 is also
> called further down in the stack from there and was clearly showing up
> in the memory profile.
>
> The app was working fine with the sample file in non-editing mode  for
> me with that hack in place in a quick test.
> But it's well possible that there are more leaks elsewhere.
>


[Libreoffice-bugs] [Bug 148012] Deleting sheets multiple sheet slow (6 seconds with 7.4, compared to 1 second with 7.0)

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148012

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144653] The command ".uno:ExportToPDF" ignore all given options in FilterData argument.

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144653

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148619] Cell reference in formula don't update on all sheets when moving cells on multiple sheets

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148619

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148617] LO Calc - Grouped bar compact (GBC) - dropdown menu blocks menu next to it

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148617

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148614] Date fields not printed

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148614

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148613] Setting hotkey via macro only works after a restart.

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148613

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148611] Help Page "Connection Pooling" not found

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148611

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148610] UI Better detection of URL parts in Remote Files dialog

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148610

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148607] File menu in full-screen 4k monitor

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148607

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148606] LO cannot read/write from drives

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148606

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148599] Frame style issue

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148599

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148444] "Print Preview" and "Print Preview bar" in Writer help pages need some updating

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148444

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144802] Libre office ne fonctionne plus après mise à jour

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144802

--- Comment #5 from QA Administrators  ---
Dear Lauflarra,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144802] Libre office ne fonctionne plus après mise à jour

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144802

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144406] Crash when copying/pasting objects in Base report edit

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144406

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144406] Crash when copying/pasting objects in Base report edit

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144406

--- Comment #3 from QA Administrators  ---
Dear Colin Murdoch,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140145] Calc stops responding to keyboard

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140145

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140145] Calc stops responding to keyboard

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140145

--- Comment #14 from QA Administrators  ---
Dear clearstar,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145466] Application crashes when running multiple writer instances

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145466

--- Comment #3 from QA Administrators  ---
Dear seven,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134788] Inserting a table with 4000-6000 takes a long time to process since 5.1

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134788

--- Comment #9 from QA Administrators  ---
Dear Telesto,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120200] [META] Update or correct help for features

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120200

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||148861


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148861
[Bug 148861] Help page for Outline toolbar in Impress needs updating
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148861] Help page for Outline toolbar in Impress needs updating

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148861

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||120200


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120200
[Bug 120200] [META] Update or correct help for features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148861] New: Help page for Outline toolbar in Impress needs updating

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148861

Bug ID: 148861
   Summary: Help page for Outline toolbar in Impress needs
updating
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk
CC: olivier.hal...@libreoffice.org

Outline toolbar help page needs updating

https://help.libreoffice.org/7.4/en-US/text/simpress/main0211.html?=IMPRESS

On Help page, but not on Outline (Impress) toolbar

  Zoom
  Slide Show

On toolbar, but not on Help page

  Demote  (shared/02/0605.xhp)
  Promote (shared/02/0606.xhp)
  Move Up (shared/02/0610.xhp) 
  Move Down shared/02/0611.xhp)

On Help page, but needs command name change

   "First Level" -> "Shown Only First Level"
   "All Levels" -> "Show All Levels"
   "Formatting On/Off" -> "Show Formatting"

And would be good if order of controls corresponded to order on toolbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148860] Calc: "Tools" -> "Macros" -> "Edit Macros" crashes

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148860

--- Comment #1 from Matt K  ---
Created attachment 179853
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179853=edit
Example file with a macro that crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148860] New: Calc: "Tools" -> "Macros" -> "Edit Macros" crashes

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148860

Bug ID: 148860
   Summary: Calc: "Tools" -> "Macros" -> "Edit Macros" crashes
   Product: LibreOffice
   Version: 7.1.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: matt...@gmail.com

Description:
Calc crashes when attempting to edit a macro from an opened file

Steps to Reproduce:
1. Open Calc
2. Open the attached file with a macro in it
3. Go to "Tools" -> "Macros" -> "Edit Macros..."
4. Observe crash after BASIC IDE loads

Actual Results:
crash

Expected Results:
no crash, able to edit macro


Reproducible: Always


User Profile Reset: No



Additional Info:
Note that I changed my macro security settings to Medium and clicked "Enable
Macros" when opening the attached file.

Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120201

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||148859


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148859
[Bug 148859] (F1) on Outline bar in Impress gives not found
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148859] (F1) on Outline bar in Impress gives not found

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148859

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Blocks||120201


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120201
[Bug 120201] [META] Update or add link to help page
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148859] New: (F1) on Outline bar in Impress gives not found

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148859

Bug ID: 148859
   Summary: (F1) on Outline bar in Impress gives not found
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk
CC: olivier.hal...@libreoffice.org

Impress document
View > Toolbars > Outline
Set focus on Outline bar
Press F1

Actual result:  Not found
   .HelpId:outlinetoolbar

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030
Bug 103030 depends on bug 143569, which changed state.

Bug 143569 Summary: Headings outside the main body are out of order in 
Navigator and PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=143569

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148543] Excess character format code embedded in Writer documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148543

--- Comment #6 from Ernest Bywater  ---
I just attached 4 files. 

My system recently updated to Libre Office 7.3.2.2 and that's what was used to
create the new .odt file

The four files are in two groups of an ODT file with that file saved as a HTML
file. The files with 'original' in the title are the original version of the
file which was first created years ago in Libre Office 4 or 5 or maybe earlier
and edited a lot over the years. The files with 'new' in the title were
recently created by taking the original file, saving it as a plain text file
then saving again as an ODT file and creating the various paragraph styles and
applying them.

The file 'z_layout-new.html' is what I would expect to see with every ODT that
is saved as a HTML. However, what I get is what you see in
'z_layout-original.html' in every case of a file being saved as HTML, other
than this one example.

Since I saw the comment by Dieter I wondered if the issue is related to a
change of Libre Office version. I can't rule this out as my most recent story
was started in LO 7.3.1.3 and the edits show the problem.

The text in the 'z_layout-original' from lines 118 to 121 have (with spaces
added to stop the code running:

< blockquote class = "western" >< b >Note:< / b > Due to the main character
and the narrator being Australians UK English is used < font color = "#ff"
>< i >< span style="font-weight: normal" >in< / span >< / i >< / font >
this story, except for dialogue by a US character where US English is
used in the dialogue and some nouns.< / blockquote >

The first iteration of that paragraph had the word 'for' which was later edited
into 'in' and the extra format code appeared with the edit. the extra format
code is NOT in the 'z_layout-new' file as going via the plain text change
removed it. However, that's a hell of a thing to do to a few hundred files
adding up to over ten million words.

While Dieter's comment makes me hope the issue may vanish when I can upgrade to
the latest version of Libre Office, which is an issue I'll cover below, I'm NOT
holding my breath on it. I am waiting to see how things go as I complete and
edit the stories I'm working on.



Libre Office upgrades - comment only as not an issue. Until about a year ago I
was using either a version of Windows or a version of Linux based on Debian, so
the standard downloads and upgrade routes of the latest versions from your
website worked. However, due to an issue with a new graphics card and most
Debian versions of Linux at that time I switch to using Manjaro Linux, which is
an Arch Linux based operating system, as it came with the latest AMD graphics
drivers built-in. I soon found the instructions for the RPM and DEB packages of
LO do NOT natively work on Manjaro. I have been told there is a complex work
around to get them to load, but I've not been able to do make that work for me.
Thus I now wait until the latest version of LO upgrade is made available via
the Manjaro Repository. That means I'm not always with the very latest version
of LO but am often one or two behind. Since the only issue I have with LO is
the one in this bug, I can easily live with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-04-29 Thread Seth Chaiklin (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bd950c4bfd2753589bb4b4b89aab6b05eaa1e346
Author: Seth Chaiklin 
AuthorDate: Sat Apr 30 02:03:52 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Sat Apr 30 03:03:52 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to b218d6ebe0f497748414b3a7fd173cff363b76ae
  - refactor some switchinlines to avoid translation problems

   shared/02/0610.xhp  (Move Up)
   shared/02/0611.xhp  (Move Down)

Change-Id: Ib67c383db0ee8690a9fcedb4850455319e34f7b8
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133603
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/helpcontent2 b/helpcontent2
index d7890e971698..b218d6ebe0f4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d7890e97169844d9a2f46703b893c1123dd8ebce
+Subproject commit b218d6ebe0f497748414b3a7fd173cff363b76ae


[Libreoffice-commits] help.git: source/text

2022-04-29 Thread Seth Chaiklin (via logerrit)
 source/text/shared/02/0610.xhp |   10 +++---
 source/text/shared/02/0611.xhp |   10 +++---
 2 files changed, 14 insertions(+), 6 deletions(-)

New commits:
commit b218d6ebe0f497748414b3a7fd173cff363b76ae
Author: Seth Chaiklin 
AuthorDate: Sat Apr 30 00:58:33 2022 +0100
Commit: Seth Chaiklin 
CommitDate: Sat Apr 30 03:03:45 2022 +0200

refactor some switchinlines to avoid translation problems

   shared/02/0610.xhp  (Move Up)
   shared/02/0611.xhp  (Move Down)

Change-Id: Ib67c383db0ee8690a9fcedb4850455319e34f7b8
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133603
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/source/text/shared/02/0610.xhp 
b/source/text/shared/02/0610.xhp
index 9232fd1de..ec2ad6835 100644
--- a/source/text/shared/02/0610.xhp
+++ b/source/text/shared/02/0610.xhp
@@ -31,19 +31,23 @@
 
 
 
-Move Item 
Up
+Move Item 
UpMove Up
 Moves the paragraph where the cursor is located, or selected 
paragraphs, to before the previous paragraph.
 
-If you have 
numbered paragraphs and use the Move Item 
Up command, then 
the numbers are adjusted automatically to the current order. 
 
 
+If you have 
numbered paragraphs and use the Move Item Up command, then 
the numbers are adjusted automatically to the current order.
 The Move Item 
Up icon appears on the Bullets and Numbering 
bar.
 The 
Move Item Up command is always active. This function can 
also be called by pressing CommandCtrl+Alt+Up
 Arrow.
 
 
+ If you 
have numbered paragraphs and use the Move Up command, then 
the numbers are adjusted automatically to the current order.
 The Move 
Up icon appears on the Outline bar.
 The Move 
Up command is always active. This function can also be called by 
pressing Alt+Shift+Up Arrow.
 
+
+If you have 
numbered paragraphs and use Move Down, then the numbers 
are adjusted automatically to the current order.
+
 
 No shortcut keys or toolbars for CALC and DRAW
 
@@ -55,7 +59,7 @@
   Icon Move Up
 
 
-  Move 
Item Up
+  Move 
Item UpMove 
Up
 
   
 
diff --git a/source/text/shared/02/0611.xhp 
b/source/text/shared/02/0611.xhp
index 533c841c6..3d99053de 100644
--- a/source/text/shared/02/0611.xhp
+++ b/source/text/shared/02/0611.xhp
@@ -31,19 +31,23 @@
 
 
 
-Move 
Item Down
+Move Item 
DownMove 
Down
 Moves the paragraph where the cursor is located, or selected 
paragraphs, to after the next paragraph.
 
-If you have 
numbered paragraphs and use Move 
Item 
Down, then the numbers are adjusted automatically to the 
current order.
 
 
+If you have 
numbered paragraphs and use Move Item Down, then the 
numbers are adjusted automatically to the current order.
 The Move Item 
Down icon appears on the Bullets and Numbering 
bar.
 The 
Move Item Down command is always active. This function can 
also be called by pressing CommandCtrl+Alt+Down
 Arrow.
 
 
+If you 
have numbered paragraphs and use Move Down, then the 
numbers are adjusted automatically to the current order.
 The Move 
Down icon appears on the Outline 
bar.
 The Move 
Down command is always active. This function can also be called by 
pressing Alt+Shift+Down Arrow.
 
+
+If you have 
numbered paragraphs and use Move Down, then the numbers 
are adjusted automatically to the current order.
+
 
 No shortcut keys or toolbars for CALC and DRAW.
 
@@ -55,7 +59,7 @@
   Icon Move Down
 
 
-  Move 
Item Down
+  Move 
Item DownMove 
Down
 
   
 


[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115709

Aron Budea  changed:

   What|Removed |Added

 Depends on||101378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101378
[Bug 101378] DOC(X): Writer doesn't handle tracked changes in formula
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946

Aron Budea  changed:

   What|Removed |Added

 Depends on|101378  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101378
[Bug 101378] DOC(X): Writer doesn't handle tracked changes in formula
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101378] DOC(X): Writer doesn't handle tracked changes in formula

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101378

Aron Budea  changed:

   What|Removed |Added

 Blocks|83946   |115709


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=115709
[Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148543] Excess character format code embedded in Writer documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148543

--- Comment #5 from Ernest Bywater  ---
Created attachment 179852
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179852=edit
new version of .odt file as html file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148543] Excess character format code embedded in Writer documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148543

--- Comment #4 from Ernest Bywater  ---
Created attachment 179851
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179851=edit
new version of .odt file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148543] Excess character format code embedded in Writer documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148543

--- Comment #3 from Ernest Bywater  ---
Created attachment 179850
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179850=edit
original with edits saved as html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148543] Excess character format code embedded in Writer documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148543

--- Comment #2 from Ernest Bywater  ---
Created attachment 179849
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179849=edit
original .odt file with edits in it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143484] FILEOPEN DOCX contour wrap on diagram (SmartArt) is different from Word

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143484

Hossein  changed:

   What|Removed |Added

 Attachment #173867|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143484] FILEOPEN DOCX contour wrap on diagram (SmartArt) is different from Word

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143484

--- Comment #7 from Hossein  ---
Still reproducible with the latest 7.4 master:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: baa6531bf272265a31aed4ce54ffc6ef00e3a514
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148828] FILEOPEN PPTX text box padding is too large in SmartArt

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148828

Hossein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Version|7.4.0.0 alpha0+ Master  |6.4 all versions
 Status|UNCONFIRMED |NEW

--- Comment #1 from Hossein  ---
This is an important compatibility issues. I think this issue is quite old. I
am setting the version to LO 6.4. As far as I remember, I had similar issues
also with the custom shapes, and not only SmartArt objects.

Reproducible in 7.4 master for Windows and Linux:

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 83d0f2eebae41d431d9a5bfd1a918523977752d0
CPU threads: 32; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_DE); UI: en-US
Calc: threaded

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: baa6531bf272265a31aed4ce54ffc6ef00e3a514
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Also reproducible in 7.2

Version: 7.2.4.1 (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 32; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_DE); UI: en-US
Calc: threaded

Also reproducible in 6.4:

Version: 6.4.0.1
Build ID: 1b6477b31f0334bd8620a96f0aeeb449b587be9f
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83671] Fileopen XLSX: SmartArt is not displayed

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83671

--- Comment #15 from Hossein  ---
Still reproducible in the latest 7.4 master:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: baa6531bf272265a31aed4ce54ffc6ef00e3a514
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131760] Commands related to styles miscategorized in customization dialog

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131760

--- Comment #20 from sdc.bla...@youmail.dk ---
(In reply to Kenneth Hanson from comment #19)
Thanks for giving your thoughts Kenneth. Good to have the motivating POV for
the OP.

> The current customization menus are extremely confusing 
> excessively difficult ….
> usability problem for *ALL* users.
Ack.  Command names issue goes far beyond categorization, but understand that
sensible categorization in existing Customize dialog can be an improvement. 

> difficult to fix the command names.
The problem arises because some commands (e.g., the one labelled “Edit”) are
used in different applications, so in Writer, the command that appears as
“Edit” edits Paragraph Style, but in Impress the same command “Edit” will edit
Graphic Styles, hence the neutral (and hard to interpret) "Edit". 

However, there is a technical solution, designed exactly for this purpose,
where it is possible to make an alias just for Writer, and another for Impress
(and a third for Calc...), each with its own (more meaningful)  “name”, 
appropriate tooltip, label, etc. But then it becomes necessary to find and
change the right toolbars and menus (across the different applications) so that
the right alias is appearing on all the right toolbars and menus, and not
appearing where it shouldn’t (where there can easily be dozens of menus and
toolbars to check). In short, a tedious task, that must be done with high
(about 100%) accuracy. Not difficult technically, but not the sort of thing to
attract voluntary efforts. 

(Same issue with changing "Edit" to "Edit Style". Maybe it would work, but
would require a lot of checking/testing to see the consequences because the
command is used in many places).

> names of commands *must* be fixed to disambiguate. 
> can't just have "New", "Edit", and so on in a mixed category.
> This is exactly the problem with searching by name in all categories.
Agreed. In some individual cases, it may be possible (i.e., relatively easy) to
make name improvements. (e.g., bug 134432). In other cases, such as Edit (and
probably several others), then the just-mentioned complications arise. To
evaluate and revise command names requires knowing what the command does,
discover where it used, and decide what aliases are needed, as well as get
acceptance about possible changes. Not exciting work.

The point of these explanations is to give a hypothesis for why your sensible
suggestions have not been tackled systematically.

> (In reply to sdc.blanco from comment #10)
> > not all commands are categorized (e.g., Character 
My mistake. It was categorized.  I believe now all commands are categorized.

>never saw an answer as to whether the current "Styles" category can be used.
No definitive answer, but my best guess (from looking at the source code) is it
cannot be done in a simple, nontrivial way, so then it becomes a question of
whether it will be accepted to make a special change in the source code to
allow this. 


Not to sweep the general issue away, but perhaps this ticket should be closed –
because it has too many issues running here. 

My friendly recommendation:
 - file a new ticket requesting large-scale, systematic evaluation and revision
of the existing Customize dialog  (if it does not already exist – I have not
searched). Then that “big idea” is available (and Heiko can add his link to an
alternative vision).

 - meanwhile – as a completely different strategy – file bug reports in
relation to specific difficulties with specific command names or categories,
etc. when using the existing interface (such as you did here). 

That strategy does not immediately address the global problems that you have
raised here, but if you think that small, incremental changes to the existing
dialog are also worthwhile (or better than nothing), then it may slowly start
to reduce some of the “noise”.

If you follow that strategy, then there is an advantage to have each report
focus on one specific limited issue. If you file 10 different tickets for 10
different, specific problems, so be it. If each one is clear, limited, focused,
then there is a much better chance that someone actually might address it. (see
bug 129549 as example). 

So – to repeat myself:
> cannot see that much more can be done for now, so I pass the baton to others.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148858] Draw png extension

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148858

Pete  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Standalone Excel to csv conversion?

2022-04-29 Thread sa212+lo

Thanks for the responses - if I can reply to everyone at once:

Joao - thanks, rows looks good, but I'm trying to move away from Python 
- I currently only need it for Excel handling


Kohei - yes, pretty much what I was expecting, thanks. Unfortunately, I 
do need xls, for at least another year or so. The C libs I've looked 
(briefly) at are:


xlnt (https://github.com/tfussell/xlnt) - looks good, but doesn't handle 
xls, and it's not obvious that it can yet export csv files


OpenXLSX (https://github.com/troldal/OpenXLSX) - doesn't seem as mature 
as xlnt; again, xlsx only, not obvious that it can export csv


Michael - good idea, at least in the short term. Both LibreOffice and 
ssconvert (gnumeric) can handle my test spreadsheets and generate csv 
output. I'm sticking with ssconvert at the moment, as I suspect that a 
gnumeric headless install is (much?) less resource intensive than a 
LibreOffice install and then running it headless (I need to run headless 
on a server). I've covered this on SO at 
https://serverfault.com/a/1099802/221197.


There are also other potential solutions - there are at least 3 program 
called xlsx2csv, for example. All 3 are minimally documented and 
probably don't work. I've tried the Python version, but can't persuade 
it to produce anything other than floating-point output for times.




[Libreoffice-bugs] [Bug 141610] Libreoffice crashes, if a shape with textbox inside is anchored to a frame

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141610

Martin Srdoš  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||srd...@email.cz

--- Comment #12 from Martin Srdoš  ---
There is two different behaviour of the crashing. First is that program crash
exactly in the time if I create the text box. Second is that after create the
textbox is everything ok, but the program crash after close.

I have bisected that like bug is both behaviours.

e7f029b7ca96f76183c6cf05a09ecca046d996f9 is the first bad commit
commit e7f029b7ca96f76183c6cf05a09ecca046d996f9
Author: Norbert Thiebaud 
Date:   Thu Jun 11 07:08:11 2020 -0700

I have forgotten how to search the person, who made the commit. Someone can
help?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148527] Mouse scrolling inconsistent in Calc

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148527

--- Comment #8 from Pierre Fortin  ---
Opened a PDF file in oowriter and the missing mouse events occur in both
directions when slow-scrolling. Fast scrolling works; but it is more important
to be able to hone in with slow scroll.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148858] Draw png extension

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148858

--- Comment #2 from Pete  ---
Yes, you are correct, the "Export" has the png option, I was looking at "Export
As" which does not have that option!
Which brings up a point, why have a "Export As" in the first place, if you are
going to Export a document, just have Export and all the formats (pdf included)
in the drop down, makes no sense to me.

Now to the main topic.
Under Tools->Options->Save/Load->General and select the App as Draw, there
currently is no option to select png only options are odg/otg and fodg

I believe that png should be there also so that I can save all my drawings in
that format without constantly using "Export"

Im using version 7.3.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-04-29 Thread Jim Raykowski (via logerrit)
 sw/source/uibase/inc/content.hxx   |2 +-
 sw/source/uibase/inc/swcont.hxx|4 ++--
 sw/source/uibase/utlui/content.cxx |   29 ++---
 3 files changed, 21 insertions(+), 14 deletions(-)

New commits:
commit c81f4a4ecbfa7dc97d8c28b5ec5f00d1d561b6bb
Author: Jim Raykowski 
AuthorDate: Sun Apr 24 12:07:35 2022 -0800
Commit: Jim Raykowski 
CommitDate: Fri Apr 29 22:43:38 2022 +0200

tdf#143569 SwNavigator: Make Headings entries from headings in frames

be in document layout order, not alphabetical order

Change-Id: I75328311a7ddbda1eb050135709da20fed5d054a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133359
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/inc/content.hxx b/sw/source/uibase/inc/content.hxx
index 2d6ac1a7d925..0acc45197e76 100644
--- a/sw/source/uibase/inc/content.hxx
+++ b/sw/source/uibase/inc/content.hxx
@@ -46,7 +46,7 @@ class SwOutlineContent final : public SwContent
 SwOutlineNodes::size_type nArrPos,
 sal_uInt8 nLevel,
 bool bMove,
-tools::Long nYPos) :
+double nYPos) :
 SwContent(pCnt, rName, nYPos),
 m_nOutlinePos(nArrPos), m_nOutlineLevel(nLevel), 
m_bIsMoveable(bMove) {}
 
diff --git a/sw/source/uibase/inc/swcont.hxx b/sw/source/uibase/inc/swcont.hxx
index a965b0fadbc6..77b9d5656030 100644
--- a/sw/source/uibase/inc/swcont.hxx
+++ b/sw/source/uibase/inc/swcont.hxx
@@ -75,13 +75,13 @@ class SwContent : public SwTypeNumber
 {
 const SwContentType*m_pParent;
 OUStringm_sContentName;
-tools::Longm_nYPosition;
+double m_nYPosition;
 // some subclasses appear to use this for a tools/gen.hxx-style
 // geometric Y position, while e.g. SwOutlineContent wants to store
 // the index in its subtree
 boolm_bInvisible;
 public:
-SwContent(const SwContentType* pCnt, const OUString& rName, 
tools::Long nYPos );
+SwContent(const SwContentType* pCnt, const OUString& rName, double 
nYPos);
 
 virtual boolIsProtect() const;
 const SwContentType*GetParent() const {return m_pParent;}
diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index e9d4468d1df7..3cb1fd4aede2 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -183,7 +183,7 @@ namespace
 
 // Content, contains names and reference at the content type.
 
-SwContent::SwContent(const SwContentType* pCnt, const OUString& rName, 
tools::Long nYPos) :
+SwContent::SwContent(const SwContentType* pCnt, const OUString& rName, double 
nYPos) :
 SwTypeNumber(CTYPE_CNT),
 m_pParent(pCnt),
 m_sContentName(rName),
@@ -424,23 +424,30 @@ void SwContentType::FillMemberList(bool* pbContentChanged)
 {
 case ContentTypeId::OUTLINE   :
 {
-const size_t nOutlineCount =
-
m_pWrtShell->getIDocumentOutlineNodesAccess()->getOutlineNodesCount();
+const SwNodeOffset nEndOfExtrasIndex = 
m_pWrtShell->GetNodes().GetEndOfExtras().GetIndex();
+// provide for up to 9 outline nodes in frames to be sorted in 
document layout order
+double nOutlinesInFramesIndexAdjustment = 0.1;
+const SwOutlineNodes& 
rOutlineNodes(m_pWrtShell->GetNodes().GetOutLineNds());
+const size_t nOutlineCount = rOutlineNodes.size();
 
 for (size_t i = 0; i < nOutlineCount; ++i)
 {
-const sal_uInt8 nLevel = 
m_pWrtShell->getIDocumentOutlineNodesAccess()->getOutlineLevel(i);
-if (nLevel >= m_nOutlineLevel || 
!m_pWrtShell->getIDocumentOutlineNodesAccess()->
-isOutlineInLayout(i, *m_pWrtShell->GetLayout()))
+SwTextNode* pNode = rOutlineNodes[i]->GetTextNode();
+const sal_uInt8 nLevel = pNode->GetAttrOutlineLevel() - 1;
+if (nLevel >= m_nOutlineLevel || 
!pNode->getLayoutFrame(m_pWrtShell->GetLayout()))
 continue;
-tools::Long nYPos = m_bAlphabeticSort ? 0 : getYPos(
-
*m_pWrtShell->getIDocumentOutlineNodesAccess()->getOutlineNode(i));
+double nYPos = m_bAlphabeticSort ? 0 : 
static_cast(getYPos(*pNode));
+if (nEndOfExtrasIndex >= pNode->GetIndex() && 
pNode->GetFlyFormat())
+{
+nYPos += nOutlinesInFramesIndexAdjustment;
+nOutlinesInFramesIndexAdjustment += 0.1;
+}
 OUString aEntry(comphelper::string::stripStart(
-
m_pWrtShell->getIDocumentOutlineNodesAccess()->getOutlineText(
-i, m_pWrtShell->GetLayout(), true, 
false, 

[Libreoffice-bugs] [Bug 148226] Add Edit style buttons in Footnotes dialog

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148226

--- Comment #4 from Jim Raykowski  ---
Created attachment 179848
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179848=edit
Organizer tab page edit style image buttons

Another place image buttons could be used instead of 'Edit Style' text labeled
buttons is the styles organizer tab page. This only requires removing the text
for the existing buttons and adding an image, perhaps 'cmd/sc_editstyle.png',
in the sfx2/uiconfig/ui/managestylepage.ui file. Similar can be done to add
edit style image buttons to sw/uiconfig/swriter/ui/endnotepage.ui and
sw/uiconfig/swriter/ui/footnotepage.ui and then hook up functionality of these
in sw/source/ui/misc/impfnote.hxx and sw/source/ui/misc/docfnote.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148843] Function AGGREGATE bug

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148843

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
It returns the correct value 8, if the cell reference is given as range D2:D8.
Excel returns 8.

Because this function is a COM.MICROSOFT.AGGREGATE LibreOffice should give the
same results as Excel.

I have tested it in Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141893] CALC DATA EDITING Advanced Filter No Duplicates -- strange effects v.difficult to Summarise

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141893

--- Comment #7 from Colin  ---
(In reply to Buovjaga from comment #6)
> (In reply to Colin from comment #0)
> > Steps to Reproduce:

> Using your attachment 171403 [details], I removed the AutoFilter from B3 and
> created it again. At this step 9, when I click OK, I get this warning and
> nothing happens:

This was superceded by comments 3 & 4 with new procedures for the new
attachment 173326 but I'm also not certain why you have removed and recreated
the AutoFilter for which you appear to have experienced a different error from
that which I reported.

> Arch Linux 64-bit
> Version: 7.4.0.0.alpha0+ / LibreOffice Community
> Build ID: 3a4a12b3801b0b88d119c6e7aaca1e183f7e470f
> CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
> Locale: fi-FI (fi_FI.UTF-8); UI: en-US
> Calc: threaded Jumbo
> Built on 29 April 2022

I'm using Windows 10 and now on LO 7.2.6.2. I'm unsure what would happen to
either attachment under Linux but I will conduct further testing of your
modified procedure for a comparison of both attachments. I can't do it
immediately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111427] Add support for .ppsx format

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111427

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
   Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #2 from Michael Weghorn  ---
Opening the sample file works fine by now, so this pending Gerrit change
enables support for it:
https://gerrit.libreoffice.org/c/core/+/133648

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148858] Draw png extension

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148858

Regina Henschel  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
The export as png image is in File > Export. The dialog has a drop-down list
'Save as type' where you can select PNG. Do not forget to decide whether you
want an image from a selection or from the page. Enter the desired file name.
Click 'Save'. Now you get the dialog 'PNG Options'. Make you settings and Click
OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146007

--- Comment #6 from Matt K  ---
(In reply to Andreas Heinisch from comment #5)
> Adding Cc: to Matt K and Mike Kaganski; Could you possibly take a look at
> this one? Thank you!

I took a quick look and it seems like the main thread is blocked waiting for
something to happen.  I'm not familiar with how macros use (or don't) the main
thread, but if the main thread is blocked before the file picker opens it could
just be an endless wait situation/deadlock.  Haven't debugged enough to say
more or suggest a solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148805] The SEARCH function is not working since after version 5.3.7.2

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148805

--- Comment #6 from Mike Kaganski  ---
(In reply to Cubic Consult from comment #4)
> Though it work in version 5.

Sure: since commit  07157107a3b7fd3d1b55db9ce1aeb9f6d4e204ab
  Author Winfried Donkers 
  Sate   Wed Feb 08 16:48:58 2017 +0100
tdf#105772 apply all ODFF constraints with function SEARCH.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148854] Android Viewer runs out of memory when scrolling up and down in Calc doc in experimental editing mode

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148854

Michael Weghorn  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8851

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: i18npool/inc i18npool/source

2022-04-29 Thread Michael Weghorn (via logerrit)
 i18npool/inc/xdictionary.hxx  |6 
 i18npool/source/breakiterator/xdictionary.cxx |   34 --
 2 files changed, 28 insertions(+), 12 deletions(-)

New commits:
commit d4370761421508522a29c5206aea6e538d71b342
Author: Michael Weghorn 
AuthorDate: Fri Apr 29 15:23:41 2022 +0200
Commit: Michael Weghorn 
CommitDate: Fri Apr 29 21:10:25 2022 +0200

tdf#148851 Unmap + close file again in xdictionary dtor

The file opened and mapped to memory in
the `xdictionary` ctor was never unmapped
and closed again, resulting in a memory leak.

For Android Viewer, this resulted in the app
running out of memory after a while when
scrolling up and down in the Chinese sample
doc from tdf#148851.

On Android, closing the file is actually the relevant part,
because the content of files from `/assets` is automatically
loaded into memory when the files are opened (s. the call to
`openMemoryAsFile` in `openFilePath` in `sal/osl/unx/file.cxx`)
and that memory is only freed when the file is closed
again (s. `osl_closeFile`).

When using the sample doc, the file in question
was "file:///assets/share/dict_zh.data", which
has a size of 2.2 MB and is therefore actually
loaded into memory anew every time, since only
files below 50 KiB are handled by the file cache
introduced in

commit 26a46c1143e34e361d76d6459535c2056c59de77
Date:   Fri Dec 20 14:46:36 2019 +

android: file-cache to improve performance.

Fix the memory leak by unmapping and closing
the file again in the dtor.

Change-Id: I3388964877080d1f2b3cf2682a41549e0bfb850c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133581
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/i18npool/inc/xdictionary.hxx b/i18npool/inc/xdictionary.hxx
index cc7364bd14fc..f0861408bbd6 100644
--- a/i18npool/inc/xdictionary.hxx
+++ b/i18npool/inc/xdictionary.hxx
@@ -18,6 +18,7 @@
  */
 #pragma once
 
+#include 
 #include 
 
 #include 
@@ -63,6 +64,11 @@ private:
 
 css::i18n::Boundary boundary;
 bool japaneseWordBreak;
+#ifdef DICT_JA_ZH_IN_DATAFILE
+oslFileHandle m_aFileHandle;
+sal_uInt64 m_nFileSize;
+char* m_pMapping;
+#endif
 
 public:
 xdictionary(const char *lang);
diff --git a/i18npool/source/breakiterator/xdictionary.cxx 
b/i18npool/source/breakiterator/xdictionary.cxx
index dd1f83f8baa7..6c326f69e48f 100644
--- a/i18npool/source/breakiterator/xdictionary.cxx
+++ b/i18npool/source/breakiterator/xdictionary.cxx
@@ -62,6 +62,11 @@ sal_Unicode* getDataArea_zh();
 
 xdictionary::xdictionary(const char *lang) :
 japaneseWordBreak( false )
+#ifdef DICT_JA_ZH_IN_DATAFILE
+, m_aFileHandle(nullptr),
+m_nFileSize(-1),
+m_pMapping(nullptr)
+#endif
 {
 
 #ifdef DICT_JA_ZH_IN_DATAFILE
@@ -76,21 +81,18 @@ xdictionary::xdictionary(const char *lang) :
 else if( strcmp( lang, "zh" ) == 0 )
 sUrl += "zh.data";
 
-oslFileHandle aFileHandle;
-sal_uInt64 nFileSize;
-char *pMapping;
-if( osl_openFile( sUrl.pData, , osl_File_OpenFlag_Read ) 
== osl_File_E_None &&
-osl_getFileSize( aFileHandle, ) == osl_File_E_None &&
-osl_mapFile( aFileHandle, (void **) , nFileSize, 0, 
osl_File_MapFlag_RandomAccess ) == osl_File_E_None )
+if( osl_openFile( sUrl.pData, _aFileHandle, osl_File_OpenFlag_Read ) 
== osl_File_E_None &&
+osl_getFileSize( m_aFileHandle, _nFileSize) == osl_File_E_None &&
+osl_mapFile( m_aFileHandle, (void **) _pMapping, m_nFileSize, 0, 
osl_File_MapFlag_RandomAccess ) == osl_File_E_None )
 {
 // We have the offsets to the parts of the file at its end, see 
gendict.cxx
-sal_Int64 *pEOF = (sal_Int64*)(pMapping + nFileSize);
+sal_Int64 *pEOF = (sal_Int64*)(m_pMapping + m_nFileSize);
 
-data.existMark = (sal_uInt8*) (pMapping + pEOF[-1]);
-data.index2 = (sal_Int32*) (pMapping + pEOF[-2]);
-data.index1 = (sal_Int16*) (pMapping + pEOF[-3]);
-data.lenArray = (sal_Int32*) (pMapping + pEOF[-4]);
-data.dataArea = (sal_Unicode*) (pMapping + pEOF[-5]);
+data.existMark = (sal_uInt8*) (m_pMapping + pEOF[-1]);
+data.index2 = (sal_Int32*) (m_pMapping + pEOF[-2]);
+data.index1 = (sal_Int16*) (m_pMapping + pEOF[-3]);
+data.lenArray = (sal_Int32*) (m_pMapping + pEOF[-4]);
+data.dataArea = (sal_Unicode*) (m_pMapping + pEOF[-5]);
 }
 }
 
@@ -131,6 +133,14 @@ xdictionary::~xdictionary()
 delete [] i.wordboundary;
 }
 }
+#ifdef DICT_JA_ZH_IN_DATAFILE
+if (m_aFileHandle) {
+if (m_pMapping) {
+osl_unmapMappedFile(m_aFileHandle, m_pMapping, m_nFileSize);
+}
+osl_closeFile(m_aFileHandle);
+}
+#endif
 }
 
 namespace 

[Libreoffice-commits] core.git: sw/CppunitTest_sw_core_text.mk sw/qa sw/source

2022-04-29 Thread Miklos Vajna (via logerrit)
 sw/CppunitTest_sw_core_text.mk  |1 
 sw/qa/core/text/text.cxx|   44 +++-
 sw/source/core/text/frmform.cxx |   18 
 3 files changed, 62 insertions(+), 1 deletion(-)

New commits:
commit 515bf5d4afa3a8ed413fd6f17f66fa98b6dbf29e
Author: Miklos Vajna 
AuthorDate: Fri Apr 29 12:10:13 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Apr 29 20:59:50 2022 +0200

tdf#148683 sw: fix crash on deleting text with redlining enabled, but hidden

Regression from commit 32902f66e7749b2d06d13f50416be5323a0c0ea9
(sw_redlinehide: make layout based Show/Hide mode the default,
2018-11-30), deleting some text in the middle of the paragraph with the
bugdoc results in an assertion failure in the SwDrawTextInfo ctor.

Normally this doesn't happen on text deletion as we already have a
mechanism for truncating no longer needed lines in
SwTextFrame::Format_(), though that only checks the length of the
current line.

Fix the problem by extending this mechanism to also check the remaining
lines: if change tracking is on and the total of all line lengths is
more than the string length of the text frame, then time to
re-calculate.

It seems this is not needed in practice when redlining is disabled,
though we might want to enable this for the non-redline case as well in
the future.

Change-Id: Iede03e11daceb3c2b614a301e21560b075a60c01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133620
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/CppunitTest_sw_core_text.mk b/sw/CppunitTest_sw_core_text.mk
index 19d8cd422edc..c3025f007a9a 100644
--- a/sw/CppunitTest_sw_core_text.mk
+++ b/sw/CppunitTest_sw_core_text.mk
@@ -21,6 +21,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_core_text, \
 comphelper \
 cppu \
 cppuhelper \
+editeng \
 sal \
 sfx \
 svl \
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index f847df9c5e56..f6c4023af944 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -24,13 +24,14 @@
 #include 
 #include 
 #include 
-
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
+#include 
 
 constexpr OUStringLiteral DATA_DIRECTORY = u"/sw/qa/core/text/data/";
 
@@ -428,6 +429,47 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, 
testAsCharImageDocModelFromViewPoint)
 CPPUNIT_ASSERT_EQUAL(aGraphicNode, pShellCursor->GetMark()->nNode);
 }
 
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testRedlineDelete)
+{
+// Given a document with A4 paper size, some text, redlining on, but 
hidden:
+SwDoc* pDoc = createSwDoc();
+SwDocShell* pDocShell = pDoc->GetDocShell();
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+{
+// Set page size to A4.
+size_t nCurIdx = pWrtShell->GetCurPageDesc();
+SwPageDesc aPageDesc(pWrtShell->GetPageDesc(nCurIdx));
+SwFrameFormat& rMaster = aPageDesc.GetMaster();
+SwFormatFrameSize aSize(SwFrameSize::Fixed);
+aSize.SetSize(Size(11906, 16838));
+rMaster.SetFormatAttr(aSize);
+pWrtShell->ChgPageDesc(nCurIdx, aPageDesc);
+}
+OUString aBefore("a aa aa aa aa ");
+OUString aDelete("delete eee ee eee ee ee");
+pWrtShell->Insert(aBefore + " " + aDelete
+  + " zz zzz z zzz   z zz zzz 
zzz zzz");
+// Enable redlining.
+pDocShell->SetChangeRecording(/*bActivate=*/true);
+// Hide redlining.
+pWrtShell->StartAllAction();
+pWrtShell->GetLayout()->SetHideRedlines(true);
+pWrtShell->EndAllAction();
+
+// When deleting content in the middle of the paragraph:
+pWrtShell->SttEndDoc(/*bStt=*/true);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/false, 
/*nCount=*/aBefore.getLength(),
+ /*bBasicCall=*/false);
+pWrtShell->Right(CRSR_SKIP_CHARS, /*bSelect=*/true, 
/*nCount=*/aDelete.getLength(),
+ /*bBasicCall=*/false);
+// Without the accompanying fix in place, this test would have crashed:
+pWrtShell->Delete();
+
+// Then make sure that the redline is created:
+CPPUNIT_ASSERT_EQUAL(static_cast(1),
+ 
pDoc->getIDocumentRedlineAccess().GetRedlineTable().size());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/frmform.cxx b/sw/source/core/text/frmform.cxx
index 861d143dc96a..e2bff47bd305 100644
--- a/sw/source/core/text/frmform.cxx
+++ b/sw/source/core/text/frmform.cxx
@@ -1620,8 +1620,26 @@ void SwTextFrame::Format_( SwTextFormatter , 
SwTextFormatInfo ,
 // If we're finished formatting the text and we still
 // have other line objects left, these are superfluous
 // now because the text has gotten shorter.
+bool bTruncLines = false;
 if( 

[Libreoffice-commits] core.git: bin/check-elf-dynamic-objects configure.ac m4/libo_externals.m4

2022-04-29 Thread Michael Stahl (via logerrit)
 bin/check-elf-dynamic-objects |2 +-
 configure.ac  |2 +-
 m4/libo_externals.m4  |   17 ++---
 3 files changed, 16 insertions(+), 5 deletions(-)

New commits:
commit 0028266e34a683b1650410cee65dac502e304c9f
Author: Michael Stahl 
AuthorDate: Thu Aug 12 13:04:54 2021 +0200
Commit: Michael Stahl 
CommitDate: Fri Apr 29 20:24:58 2022 +0200

configure: default to --with-system-nss on Linux

NSS is very ABI compatible and part of current LSB 5.0 and so it should
just work to use the one from the system, i'm not aware of a Linux that
doesn't ship it.

There used to be some feature patch in external/nss but this was removed
years ago, now it just contains build fixes.

Problems can occur if a mixture of system and bundled NSS libraries is
loaded, if first an old version .so is loaded and then newer version .so
depends on it but can't find some required symbol.

See for example:

https://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg287043.html

Another issue is that e.g. Fedora ships libnsspem.so in the nss-pem
package, which may cause trouble in ASAN builds, where the internal NSS
is built to call __asan_poison_memory_region but the system
libnss-pem.so doesn't call __asan_unpoison_memory_region so we get:

  ==2568944==ERROR: AddressSanitizer: use-after-poison on address 
0x61d0019afab0
  WRITE of size 192 at 0x61d0019afab0 thread T28 (utl::Moderator)
0 in __interceptor_memset.part.0 (instdir/program/soffice.bin+0x466460)
1  (/lib64/libnsspem.so+0x15f3d)
2  (/lib64/libnsspem.so+0x16185)
3  (/lib64/libnsspem.so+0x8a9b)
4  (/lib64/libnsspem.so+0xe13b)
5 in secmod_ModuleInit 
workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
..
21 in curl_easy_perform workdir/UnpackedTarball/curl/lib/easy.c:715:10

Also, with system NSS, things like p11-kit integration become
responsibility of the OS.

Change-Id: I50caedd46914dd5d6905c5d32d44a599cd78119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120388
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/bin/check-elf-dynamic-objects b/bin/check-elf-dynamic-objects
index 7d4011597f8f..133f58d34dda 100755
--- a/bin/check-elf-dynamic-objects
+++ b/bin/check-elf-dynamic-objects
@@ -88,7 +88,7 @@ programfiles=$(echo ${files} | grep -o '/program/[^/]* ' | 
xargs -n 1 basename)
 # of maintaining ABI stability
 # allow extending the allowlist using the environment variable to be able to 
work
 # on the installer stuff without the need for a baseline setup
-globalallowlist="ld-linux-x86-64.so.2 ld-linux.so.2 libc.so.6 libm.so.6 
libdl.so.2 libpthread.so.0 librt.so.1 libutil.so.1 libnsl.so.1 libcrypt.so.1 
libgcc_s.so.1 libstdc++.so.6 libz.so.1 libfontconfig.so.1 libfreetype.so.6 
libxml2.so.2 libxslt.so.1 libexslt.so.0 ${LO_ELFCHECK_ALLOWLIST-}"
+globalallowlist="ld-linux-x86-64.so.2 ld-linux.so.2 libc.so.6 libm.so.6 
libdl.so.2 libpthread.so.0 librt.so.1 libutil.so.1 libnsl.so.1 libcrypt.so.1 
libgcc_s.so.1 libstdc++.so.6 libz.so.1 libfontconfig.so.1 libfreetype.so.6 
libxml2.so.2 libxslt.so.1 libexslt.so.0 libnspr4.so libnss3.so libnssutil3.so 
libplc4.so libplds4.so libsmime3.so libssl3.so ${LO_ELFCHECK_ALLOWLIST-}"
 x11allowlist="libX11.so.6 libX11-xcb.so.1 libXext.so.6 libSM.so.6 libICE.so.6 
libXinerama.so.1 libXrender.so.1 libXrandr.so.2 libcairo.so.2"
 openglallowlist="libGL.so.1"
 gobjectallowlist="libgobject-2.0.so.0 libglib-2.0.so.0"
diff --git a/configure.ac b/configure.ac
index b40d16003d44..cdef1a6507e5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10591,7 +10591,7 @@ dnl 
===
 dnl Check for system NSS
 dnl ===
 if test "$enable_fuzzers" != "yes" -a "$enable_nss" = "yes"; then
-libo_CHECK_SYSTEM_MODULE([nss],[NSS],[nss >= 3.9.3 nspr >= 4.8])
+libo_CHECK_SYSTEM_MODULE([nss],[NSS],[nss >= 3.9.3 nspr >= 
4.8],,system-if-linux)
 AC_DEFINE(HAVE_FEATURE_NSS)
 ENABLE_NSS=TRUE
 elif test $_os != iOS ; then
diff --git a/m4/libo_externals.m4 b/m4/libo_externals.m4
index 07df27f874ca..7f2b04305c47 100644
--- a/m4/libo_externals.m4
+++ b/m4/libo_externals.m4
@@ -10,11 +10,11 @@ dnl -*- Mode: Autoconf; tab-width: 4; indent-tabs-mode: 
nil; fill-column: 102 -*
 # <$2 uppercase variable part - used for configure.ac and make variables>
 # <$3 pkg-config query string>
 # [$4 if optional, default to: enabled, disabled or fixed (default: fixed)]
-# [$5 which is preferred: (fixed-|test-)system or (fixed-)internal (default: 
internal)]
+# [$5 which is preferred: (fixed-|test-)system or (fixed-)internal or 
system-if-linux (default: internal)]
 # [$6 ignore $with_system_libs: TRUE or blank (default: blank/false)]
 #
 # $4 fixed: fixed-enabled, as fixed-disabled makes no 

[Libreoffice-commits] core.git: unotest/source

2022-04-29 Thread Michael Stahl (via logerrit)
 unotest/source/cpp/macros_test.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 55b9b3c9d4a71de1f4e4c79bfce2766d3ef73e28
Author: Michael Stahl 
AuthorDate: Fri Apr 29 11:58:51 2022 +0200
Commit: Michael Stahl 
CommitDate: Fri Apr 29 20:23:02 2022 +0200

unotest: fix NSS initialization for CentOS7 system NSS

When given an unprefixed path, CentOS7 system NSS 3.67 apparently
ignores the nice unit test database and creates a legacy "dbm:" one in
the same directory, which is of course empty.

This causes:


xmlsecurity/qa/unit/signing/signing.cxx:570:aaa_testODFX509CertificateChain::TestBody
equality assertion failed
- Expected: 0
- Actual  : 1

The intermediate/root CA certificates are read from the signature and
added with CERT_NewTempCertificate(), which then does a lookup in the
database to find the trust flags of the certificate:

 0  nssTrust_GetCERTCertTrustForCert () at pki3hack.c:610
 1  fill_CERTCertificateFields () at pki3hack.c:819
 2  stan_GetCERTCertificate () at pki3hack.c:926
 3  STAN_GetCERTCertificate () at pki3hack.c:973
 4  add_cert_to_cache () at tdcache.c:721
 5  nssTrustDomain_AddCertsToCache () at tdcache.c:849
 6  cert_createObject () at pkibase.c:1023
 7  nssPKIObjectCollection_GetObjects () at pkibase.c:853
 8  nssPKIObjectCollection_GetCertificates () at pkibase.c:1077
 9  nssTrustDomain_FindCertificateByIssuerAndSerialNumber () at 
trustdomain.c:796
 10 nssTrustDomain_FindCertificateByEncodedCertificate () at 
trustdomain.c:839
 11 NSSTrustDomain_FindCertificateByEncodedCertificate () at 
trustdomain.c:852
 12 CERT_NewTempCertificate () at stanpcertdb.c:366
 13 __CERT_NewTempCertificate () at stanpcertdb.c:474
 14 SecurityEnvironment_NssImpl::verifyCertificate() () at 
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:524

Change-Id: If334d056a9e13ad806e3ea1a03d395d606fd3d84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133622
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/unotest/source/cpp/macros_test.cxx 
b/unotest/source/cpp/macros_test.cxx
index f30cbcdac3ea..6e8a26cceeb4 100644
--- a/unotest/source/cpp/macros_test.cxx
+++ b/unotest/source/cpp/macros_test.cxx
@@ -131,7 +131,8 @@ void MacrosTest::setUpNssGpg(const test::Directories& 
rDirectories, const OUStri
 osl_setEnvironment(caVar.pData, aTargetPath.pData);
 #else
 OUString mozCertVar("MOZILLA_CERTIFICATE_FOLDER");
-osl_setEnvironment(mozCertVar.pData, aTargetPath.pData);
+// explicit prefix with "sql:" needed for CentOS7 system NSS 3.67
+osl_setEnvironment(mozCertVar.pData, OUString("sql:" + aTargetPath).pData);
 #endif
 OUString gpgHomeVar("GNUPGHOME");
 osl_setEnvironment(gpgHomeVar.pData, aTargetPath.pData);


[Libreoffice-bugs] [Bug 33201] UI: Highlight (not select) current row and column in spreadsheet

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=33201

--- Comment #50 from Bayram Çiçek  ---
(In reply to Phil from comment #49)
> Any progress?
> For LO 7.4 beta1?

no progress so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148858] New: Draw png extension

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148858

Bug ID: 148858
   Summary: Draw png extension
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: petesm...@gmail.com

I see that for the application "Draw" there is not option to Save/Load as a png
extension


Not only that but there is no png extension for Save As pr Export!

So, can the .png extension be added to the "Save/Load" selection menu?

>From my understanding png is a standard that is not owned by Microsoft.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137157] CENTER ALIGNMENT not working in paragraphs containing line breaks: RESET mysteriously corrects it

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137157

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Buovjaga  ---
Ok, let's close and be happy

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148805] The SEARCH function is not working since after version 5.3.7.2

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148805

--- Comment #5 from Cubic Consult  ---
(In reply to m.a.riosv from comment #1)
> I guess, your formula separator, it's the comma.
> 
> You have a zero after quotes at the end of the formula, before the last
> parenthesis. Deleting it, the formula don't result in error.

You are right about the last 0 parameter being the cause. 1 should have been
used. Thanks.

NB:
The comma works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148805] The SEARCH function is not working since after version 5.3.7.2

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148805

--- Comment #4 from Cubic Consult  ---
Confirmed. Though it work in version 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126152] [META] Images-TIFF

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126152
Bug 126152 depends on bug 74331, which changed state.

Bug 74331 Summary: 16bit "Photometric Interpretation: min-is-black" tiff not 
loaded correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=74331

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

2022-04-29 Thread Laurent BP (via logerrit)
 sc/qa/uitest/calc_tests6/moveCopySheet.py |   17 +
 sc/source/ui/inc/mvtabdlg.hxx |1 +
 sc/source/ui/miscdlgs/mvtabdlg.cxx|   11 +++
 3 files changed, 29 insertions(+)

New commits:
commit 170cdf5e335f8803b6d851a9d16020d277e73288
Author: Laurent BP 
AuthorDate: Mon Apr 25 09:30:38 2022 +0200
Commit: Andreas Heinisch 
CommitDate: Fri Apr 29 19:04:10 2022 +0200

tdf#139464 Change label of OK button

In Move/copy sheet UI, change label
according to selected action
 update: with UI test

Change-Id: I8244b1635f56574c7641191be7e15ee4a098dce9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133364
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/sc/qa/uitest/calc_tests6/moveCopySheet.py 
b/sc/qa/uitest/calc_tests6/moveCopySheet.py
index 9436364dd053..41019b371a83 100644
--- a/sc/qa/uitest/calc_tests6/moveCopySheet.py
+++ b/sc/qa/uitest/calc_tests6/moveCopySheet.py
@@ -65,5 +65,22 @@ class moveCopySheet(UITestCase):
 self.assertEqual(document.Sheets[1].Name, "Sheet1")
 self.assertEqual(document.Sheets[2].Name, "moveName")
 
+#tdf#139464 Set OK button label to selected action: Move or Copy
+def test_tdf139464_move_sheet(self):
+with self.ui_test.create_doc_in_start_center("calc") as document:
+with self.ui_test.execute_dialog_through_command(".uno:Move") as 
xDialog:
+xOkButton = xDialog.getChild("ok")
+xCopyButton = xDialog.getChild("copy")
+self.assertEqual(get_state_as_dict(xCopyButton)['Text'], 
get_state_as_dict(xOkButton)['Text'])
+with self.ui_test.execute_dialog_through_command(".uno:Move") as 
xDialog:
+xOkButton = xDialog.getChild("ok")
+xCopyButton = xDialog.getChild("copy")
+xMoveButton = xDialog.getChild("move")
+self.assertEqual(get_state_as_dict(xMoveButton)['Text'], 
get_state_as_dict(xOkButton)['Text'])
+xCopyButton.executeAction("CLICK", tuple())
+self.assertEqual(get_state_as_dict(xCopyButton)['Text'], 
get_state_as_dict(xOkButton)['Text'])
+xMoveButton.executeAction("CLICK", tuple())
+self.assertEqual(get_state_as_dict(xMoveButton)['Text'], 
get_state_as_dict(xOkButton)['Text'])
+
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/source/ui/inc/mvtabdlg.hxx b/sc/source/ui/inc/mvtabdlg.hxx
index 2f11fd3868b4..9d121a928fa6 100644
--- a/sc/source/ui/inc/mvtabdlg.hxx
+++ b/sc/source/ui/inc/mvtabdlg.hxx
@@ -37,6 +37,7 @@ public:
 voidGetTabNameString( OUString& rString ) const;
 voidSetForceCopyTable   ();
 voidEnableRenameTable   (bool bFlag);
+voidSetOkBtnLabel   ();
 
 private:
 void ResetRenameInput();
diff --git a/sc/source/ui/miscdlgs/mvtabdlg.cxx 
b/sc/source/ui/miscdlgs/mvtabdlg.cxx
index 6ec7712f87ea..80eeaeadecfa 100644
--- a/sc/source/ui/miscdlgs/mvtabdlg.cxx
+++ b/sc/source/ui/miscdlgs/mvtabdlg.cxx
@@ -74,6 +74,7 @@ void ScMoveTableDlg::SetForceCopyTable()
 m_xBtnCopy->set_active(true);
 m_xBtnMove->set_sensitive(false);
 m_xBtnCopy->set_sensitive(false);
+SetOkBtnLabel();
 }
 
 void ScMoveTableDlg::EnableRenameTable(bool bFlag)
@@ -185,6 +186,7 @@ void ScMoveTableDlg::Init()
 m_xBtnOk->connect_clicked(LINK(this, ScMoveTableDlg, OkHdl));
 m_xLbDoc->connect_changed(LINK(this, ScMoveTableDlg, SelHdl));
 m_xBtnCopy->connect_toggled(LINK(this, ScMoveTableDlg, CheckBtnHdl));
+m_xBtnMove->connect_toggled(LINK(this, ScMoveTableDlg, CheckBtnHdl));
 m_xEdTabName->connect_changed(LINK(this, ScMoveTableDlg, CheckNameHdl));
 m_xBtnMove->set_active(true);
 m_xBtnCopy->set_active(false);
@@ -197,6 +199,7 @@ void ScMoveTableDlg::Init()
 m_xFtDoc->hide();
 m_xLbDoc->hide();
 }
+SetOkBtnLabel();
 }
 
 void ScMoveTableDlg::InitDocListBox()
@@ -236,12 +239,20 @@ void ScMoveTableDlg::InitDocListBox()
 m_xLbDoc->set_active(nSelPos);
 }
 
+void ScMoveTableDlg::SetOkBtnLabel()
+{
+// tdf#139464 Write "Copy" or "Move" on OK button
+m_xBtnOk->set_label(m_xBtnCopy->get_active() ? m_xBtnCopy->get_label()
+ : m_xBtnMove->get_label());
+}
+
 // Handler:
 
 IMPL_LINK(ScMoveTableDlg, CheckBtnHdl, weld::Toggleable&, rBtn, void)
 {
 if ( == m_xBtnCopy.get())
 ResetRenameInput();
+SetOkBtnLabel();
 }
 
 IMPL_LINK_NOARG(ScMoveTableDlg, OkHdl, weld::Button&, void)


[Libreoffice-bugs] [Bug 146007] FilePicker dialog execute method hangs LibreOffice

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146007

Andreas Heinisch  changed:

   What|Removed |Added

 CC||matt...@gmail.com,
   ||mikekagan...@hotmail.com
   Keywords|bibisectRequest |bibisected, bisected,
   ||regression

--- Comment #5 from Andreas Heinisch  ---
This seems to have begun at the below commit.
Adding Cc: to Matt K and Mike Kaganski; Could you possibly take a look at this
one? Thank you!

commit  1c1226709c6be39c5462f5e6e1262ca630b30b34
author  Matt K   Wed Apr 21 17:34:16 2021 -0500
committer   Mike Kaganski  Thu Apr 22
22:20:55 2021 +0200
tree14dc0f683da5bc6c8e08ea7db516da174960679f
parent  04bd21d483c33c5011e31ac12d02c9e00dc410ce
tdf#106282 Change Windows File Dialog to run on the main thread |
https://gerrit.libreoffice.org/c/core/+/114482

c2e223873620c4d44247c835aff279053f574dc6 is the first bad commit
commit c2e223873620c4d44247c835aff279053f574dc6
Author: Norbert Thiebaud 
Date:   Thu Apr 22 13:29:23 2021 -0700

source sha:1c1226709c6be39c5462f5e6e1262ca630b30b34

source sha:1c1226709c6be39c5462f5e6e1262ca630b30b34

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148432

--- Comment #18 from Eyal Rozenberg  ---
(In reply to Caolán McNamara from comment #16)
> Maybe table of contents dialog? 

Nope, you don't get actual document content in there.

> some bookmark/index selecting dialogs,

Bookmark - that's the XRef dialog, isn't it? And index is the ToC dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64070] Handle is not initialized exception

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64070

--- Comment #8 from Michele Locati  ---
Thanks for the quick reply, Jean-Baptiste!

I've just submitted https://bugs.documentfoundation.org/show_bug.cgi?id=148857

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148857] New: Handle is not initialized exception when bootstrapping with .Net (but not in .Net Framework)

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148857

Bug ID: 148857
   Summary: Handle is not initialized exception when bootstrapping
with .Net (but not in .Net Framework)
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: sdk
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mloc...@gmail.com

Description:
Bootstrapping in .Net (tested with .Net 6) fails, whereas bootstrapping in .Net
Framework (tested with .Net Framework 4.8) succeeds.


Consider this C# code:


static int Main()
{
string programPath = GetProgramPath();

System.Environment.SetEnvironmentVariable(
"UNO_PATH",
programPath,
System.EnvironmentVariableTarget.Process
);
System.Environment.SetEnvironmentVariable(
"URE_BOOTSTRAP",
$"vnd.sun.star.pathname:{System.IO.Path.Combine(programPath,
"fundamental.ini")}",
System.EnvironmentVariableTarget.Process
);
System.Environment.SetEnvironmentVariable(
"PATH",
   
$"{programPath}{System.IO.Path.PathSeparator}{System.Environment.GetEnvironmentVariable("PATH")}",
System.EnvironmentVariableTarget.Process
);
try
{
uno.util.Bootstrap.defaultBootstrap_InitialComponentContext();
System.Console.Out.WriteLine("OK!");
return 0;
}
catch (System.Exception x)
{
System.Console.Error.WriteLine(x.GetType().FullName);
System.Console.Error.WriteLine(x.Message);
System.Console.Error.WriteLine(x.StackTrace);
return 1;
}
}
static string GetProgramPath()
{
var programPath = Microsoft.Win32.Registry.GetValue(
Microsoft.Win32.Registry.LocalMachine.Name +
@"\SOFTWARE\LibreOffice\UNO\InstallPath",
"",
null
) as string;
if (string.IsNullOrEmpty(programPath))
{
throw new System.Exception("Failed to detect the program path");
}
return programPath;
}


When executed with .Net Framework 4.8 everything works just fine.

When executed with .Net 6 we have:

System.InvalidOperationException
Handle is not initialized.
   at System.Runtime.InteropServices.GCHandle.FromIntPtr(IntPtr value)
   at uno.util.to_cli(Reference*
x)
   at uno.util.Bootstrap.defaultBootstrap_InitialComponentContext(String
ini_file, IDictionaryEnumerator bootstrap_parameters)
   at uno.util.Bootstrap.defaultBootstrap_InitialComponentContext()
   at ConsoleDotNetFramework.Program.Main() in Program.cs:line 26


I tested it with LibreOffice 7.3.1.3 and with a fresh built of master (as of
2022-03-28): same results.
I also tested it in a Windows Sandbox: same results.



Steps to Reproduce:
1. Create a .Net (not .Net Framework) project
2. Add references to the DLLs that come with the SDK
3. Call uno.util.Bootstrap.defaultBootstrap_InitialComponentContext();

Actual Results:
defaultBootstrap_InitialComponentContext throws a
System.InvalidOperationException exception:

Message: Handle is not initialized.
Stack trace:
   at System.Runtime.InteropServices.GCHandle.FromIntPtr(IntPtr value)
   at uno.util.to_cli(Reference*
x)
   at uno.util.Bootstrap.defaultBootstrap_InitialComponentContext(String
ini_file, IDictionaryEnumerator bootstrap_parameters)
   at uno.util.Bootstrap.defaultBootstrap_InitialComponentContext()


Expected Results:
defaultBootstrap_InitialComponentContext should return a
unoidl.com.sun.star.uno.XComponentContext instance without throwing an
exception.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I published a simple Visual Studio solution to showcase this: see
https://github.com/mlocati/libreoffice-uno-dotnet

The .Net project fails, the .NetFramework project succeeds (with exactly the
same code)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

2022-04-29 Thread Caolán McNamara (via logerrit)
 sw/qa/extras/layout/data/tdf138465min.docx |binary
 1 file changed

New commits:
commit c16128bba6da5f2c51e970631c6cccf3b561ff7c
Author: Caolán McNamara 
AuthorDate: Fri Apr 29 12:52:38 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 29 18:12:45 2022 +0200

use "Rubik" from more_fonts instead of "System" for consistent layout

using Rubik with trailing 0 because need to overwrite the binary
fontname in the embedded wmf in this docx

Change-Id: I0338d4876345b0ab13e13cc4609081b3299b981e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133627
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/tdf138465min.docx 
b/sw/qa/extras/layout/data/tdf138465min.docx
index d576a54f281f..7136d27b35c3 100644
Binary files a/sw/qa/extras/layout/data/tdf138465min.docx and 
b/sw/qa/extras/layout/data/tdf138465min.docx differ


[Libreoffice-commits] core.git: sw/qa

2022-04-29 Thread Caolán McNamara (via logerrit)
 sw/qa/extras/layout/data/tdf124601b.doc |binary
 1 file changed

New commits:
commit 9550760e7fff134a1a84e21f88f6d48f0db19a75
Author: Caolán McNamara 
AuthorDate: Fri Apr 29 10:06:25 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 29 18:11:41 2022 +0200

binary patch fontname from Open Sans to Carlito for repeatable layout test

Change-Id: I3b09bb193a0f507fe0a61b28458423be342101e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133615
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/tdf124601b.doc 
b/sw/qa/extras/layout/data/tdf124601b.doc
index 4428a7daf7b3..a580e81d3d7e 100644
Binary files a/sw/qa/extras/layout/data/tdf124601b.doc and 
b/sw/qa/extras/layout/data/tdf124601b.doc differ


[Libreoffice-bugs] [Bug 147163] System hangs when trying to resize properties window in LibreOffice on hidpi

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147163

--- Comment #3 from opendr...@gmail.com ---
(In reply to Gerald Pfeifer from comment #2)
> I cannot reproduce this with current head

> on a 4k screen with 200% scaling (and I even tried 300% scaling).
> 
> I am wondering whether this somehow related to your use of KDE versus
> GNOME on my end? I.e., whether the issue might be the KDE integration?
You can reproduce this for example on openSUSE Tumbleweed Live with KDE Plasma.

> Any chance you can give it a try with the gtk3 VCL?
I tried openSUSE Tumbleweed Live with Gnome 42 and LibreOffice 7.3.3.3, the
system doesn't freeze, but I can't scale the first properties tab correctly, it
takes up 2/3 of the screen.
But I have no problem with LibreOffice Flatpak.


> (In reply to Victor Prudniy from comment #1)
> > Can confirm this bug.
> 
> Victor, can you please share the version and desktop environment you are
> using? You can copy that from the "About" menu item in LibreOffice.

If I'm not mistaken, he uses Arch Linux with KDE Plasma.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148856] New: conditional formatting cannot reference cells from other sheets

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148856

Bug ID: 148856
   Summary: conditional formatting cannot reference cells from
other sheets
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cales...@scientia.org

Description:
Hey.

When setting up conditional formatting, e.g. trying to look for duplicate
values, referencing cell-ranges from other sheets doesn't seem to work.

I can e.g. enter "A1:A10,sheet1.B1:B10" in the respective field and it does
seem to recognise whether sheet1 is actually a sheet or not, but after I
clicked ok, the "sheet1." part is simply dropped and it uses "A1:A10,B1:B10"
instead.

Thanks,
Chris.

PS: This is actually on 7.3.3~rc2

Steps to Reproduce:
see above

Actual Results:
uses the wrong cell range

Expected Results:
use the cell range from the referenced sheet


Reproducible: Always


User Profile Reset: No



Additional Info:
.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137157] CENTER ALIGNMENT not working in paragraphs containing line breaks: RESET mysteriously corrects it

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137157

R. Green  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from R. Green  ---
Version: 7.3.1.3 / LibreOffice Community
Build ID: a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

I can't duplicate this problem from scratch in a new file; it only seems to
affect the specimen file. So, AFAIK, it's fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Buovjaga  changed:

   What|Removed |Added

 Depends on||143180


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143180
[Bug 143180] In a chart, Format > Title > All Titles messes up title text
orientation
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143180] In a chart, Format > Title > All Titles messes up title text orientation

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143180

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|UNCONFIRMED |NEW
  Component|Calc|Chart
Version|7.0.6.2 release |4.2.0.4 release
 Blocks||90486
Summary|In calc, Format > Title >   |In a chart, Format > Title
   |All Titles messes up title  |> All Titles messes up
   |text orientation|title text orientation
   Keywords||implementationError
 OS|Linux (All) |All

--- Comment #6 from Buovjaga  ---
The title is not visible in the oldest of Linux 42max repo, but is seen in the
latest and the problem is already in this.

The dialog resets the Text Orientation in the Alignment tab to 0.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 83d0f2eebae41d431d9a5bfd1a918523977752d0
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 3a4a12b3801b0b88d119c6e7aaca1e183f7e470f
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded Jumbo
Built on 29 April 2022


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148853] "Before Submitting" event of a Base form does not fire

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148853

--- Comment #4 from Aaron Gerber  ---
Comment on attachment 179847
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179847
Test Database that actually has contents

Note: I did not include the macro in this file.  Instead, I parked it in a
trusted place on my machine.  To use the file, you'll have to create the macro
per the instructions and put it in a trusted place on your machine, and then
point the "Before submitting" event to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147967] Libreoffice Writer crashes after trying to insert a formula via the formula editor (macOS)

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147967

--- Comment #19 from Oliver  ---
any updates on this topic?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64070] Handle is not initialized exception

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64070

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|REOPENED|RESOLVED

--- Comment #7 from Jean-Baptiste Faure  ---
Hi Michele,

There is no clear link between your comment and the original bug report, which
is very, very old.
Please open a new bug report with all needed information: step by step
procedure to reproduce the problem, expected behavior and current behavior,
LibreOffice version, etc.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 139210, which changed state.

Bug 139210 Summary: Diacritical mark handling in Writer (may apply to other 
components)
https://bugs.documentfoundation.org/show_bug.cgi?id=139210

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139210] Diacritical mark handling in Writer (may apply to other components)

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139210

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141893] CALC DATA EDITING Advanced Filter No Duplicates -- strange effects v.difficult to Summarise

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141893

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Whiteboard| QA:needsComment|

--- Comment #6 from Buovjaga  ---
(In reply to Colin from comment #0)
> Steps to Reproduce:
> 1 Create a list of 8 unique events at B:4 and then replicate them 5 times.
> 2 At B:3, create a label "Events" and an AutoFilter from the toolbar using
> the "Events" label
> 3 Mouse select the label and all events
> 4 Data>More Filters>Advanced Filter
> 
> Observation - the process fails if the selected column of data - step 3 -
> doesn't include the label "Events" or has NOT previously been
> selected/focused prior to 4&5
> 
> 5 From within the little Advanced filter pane AGAIN select the entire data
> column - NOT the column in its entirety
> 6 Expand >options
> 7 Select >No duplicates
> 8 Select >Copy results to
> 9 Mouse select E:3 which is conveniently adjacent to the Filtered List
> commencing B3

Using your attachment 171403, I removed the AutoFilter from B3 and created it
again. At this step 9, when I click OK, I get this warning and nothing happens:

This range does not contain a valid query.

It focuses me to the Read Filter Criteria From field, where I have
$Sheet1.$B$4:$B$46

Please advise.

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 3a4a12b3801b0b88d119c6e7aaca1e183f7e470f
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded Jumbo
Built on 29 April 2022

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148778] Librecalc memory likage - it cannot empty memory

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148778

--- Comment #9 from elias estatistics  ---
I like open source programs.
and i thank you for your time for creating a such wonderful product.

However, i think this problem is very serious (low mem systems almost will hung
as it happened previously to me often).

You must have a very big RED sign when someone is downloading and using this
program cause this may cause computer problems. And he/she must be aware of
that problem in order to watch his/her memory when is reaching full... in order
to shutting down librecalc 

(note: why when i terminate libre calc also libre writer and all the other
libre apps terminate too? this is bug too?) 

I ate many hours to find out what was causing my system to hung up. 

Until now, the 2 most serious bugs of Libre calc are not solved:
a) memory problem 
b) adapt height row

Both causing a lot of work hours lost for me and possibly for many other people
that are formula-calc oriented with large tables. 

Hopefully, by upgrading memory solved in part the mem problem for now. 
For (b) problem, no solution 

i know that you offer your free time, and this is suburb. however, If it is
hard to fix this bug, put a warning sign please... (or tell them to have mem
>12GB otherwise hungs may occur)

sincerely,
Elias the vegan, for animals

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148855] New: When click to open font list, it isn't open and I had to click many times to open it.

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148855

Bug ID: 148855
   Summary: When click to open font list, it isn't open and I had
to click many times to open it.
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: leonardon...@hotmail.com

Description:
Font list, fonts sizes or another lists, from inputs, don't open on first
click. I have to clicking in the same item many times, open a list in a
direction out of correctly and, immediatly closes it.

Steps to Reproduce:
1.click in arrow down to open font family (or font size) list.
2.repeat step 1, but many times.
Only it.

Actual Results:
shows the list, but, in 1sec, immediatly closes.

Expected Results:
Show the list with all font family installed on PC or some fonts sizes
suggested.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
no one

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148853] "Before Submitting" event of a Base form does not fire

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148853

--- Comment #3 from Aaron Gerber  ---
Created attachment 179847
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179847=edit
Test Database that actually has contents

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143133] LibreOffice leaks embedded Fonts between documents

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143133

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords||implementationError
Version|7.0.6.2 release |4.1.0.4 release
 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
I reproduce. You don't have to export as PDF. It is enough to first open the
one with embedded and then the one without. You can immediately see from the
non-embedded file that the font is not substituted, the font name is not shown
in italics in the font toolbar.

I tested with old bibisect repos and noticed that it has been like this since
the feature of embedding fonts was introduced in 4.1:
https://wiki.documentfoundation.org/ReleaseNotes/4.1#Writer

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 3a4a12b3801b0b88d119c6e7aaca1e183f7e470f
CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded Jumbo
Built on 29 April 2022

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: SalAbort:Unspecified application error

2022-04-29 Thread Michael Weghorn



On 29/04/2022 12.54, Michael Weghorn wrote:

    Is that file confidential or can it be shared publicly (attached to a
    Bugzilla ticket)? (I can't read most of the text in it. :-))


 The file is not confidential and can be shared publicly (haha,The 
text in it is chiness)


Great, thanks.


I've now created a Bugzilla ticket for the initial issue that I could 
reproduce and have a pending fix for that in Gerrit:

https://bugs.documentfoundation.org/show_bug.cgi?id=148851
https://gerrit.libreoffice.org/c/core/+/133581

With that in place, I didn't see any more crashes or unexpected memory 
usage increase when testing more with your sample doc and experimental 
mode *disabled*.


I can still reproduce a crash due to running out of memory with 
experimental mode *enabled*, though.


I have created a separate ticket in Bugzilla for that one and added some 
more information, also mentioning a potential workaround:

https://bugs.documentfoundation.org/show_bug.cgi?id=148854

I suggest to continue discussion about that particular issue in Bugzilla 
(e.g. I'd be interested whether your crash also disappears when you do 
that change locally).



 My compile machine only has 4GB RAM so that i must restrict the symbols but even so the 
memory is also not enough(because of that link error "clang++ error:unable to 
execute command Killed")


4 GB are actually not much. I have no further ideas what you could 
do/try to do a build with debug symbols in that setup, other than having 
lots of swap, which will probably be very slow.


[Libreoffice-bugs] [Bug 131760] Commands related to styles miscategorized in customization dialog

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131760

--- Comment #19 from Kenneth Hanson  ---
(In reply to sdc.blanco from comment #18)
> Would still be interesting to hear from @Kenneth about thoughts or 
> experiences that motivated this ticket.

Sorry for the delay. Thank you for looking into this.

The current customization menus are extremely confusing due to a combination of
(1) inconsistent naming conventions, (2) duplicate names, (3) names that don't
match the application menus, (4) miscategorized commands. Currently, it is
excessively difficicult find the command you are looking for, whether by
searching for the name, browsing by category, or sometimes both. When you've
found something, you don't actually know what it does.

It seems quite obvious to me that this is a usability problem for *ALL* users.

When I investigated and first reported these bugs, I got the impression that
there were implementation issues that made it difficult to fix the command
names. I don't know whether the situation has changed. In the meantime, at
least fixing the categories would help a lot.

(In reply to sdc.blanco from comment #10)
> I can see now that not all commands are categorized (e.g., Character 
> .uno:FontDialog).

Yet another problem!

(In reply to sdc.blanco from comment #10)
> Do you know if it is possible to use the Styles category for commands? I 
> could not determine if it was possible (or see how to do it).

(In reply to Heiko Tietze from comment #13)
> The topic was on the agenda of the design meeting and we appreciate your
> work. If the category Styles cannot be used a similar name like "Style
> Functions" works as well.

I never saw an answer as to whether the current "Styles" category can be used.
If so, this seems like the the obvious thing to do. If not, Heiko's solution
seems sensible to me. The result might not be ideal, but it would be an
improvement.

(In reply to sdc.blanco from comment #14)
> In this concrete case, how about:
> Templates --> Styles and Templates
> a Styles Functions would not have many entries either (and Templates would 
> have even fewer if split up).

I don't understand the problem with having categories with few entries. As
Heiko mentioned somewhere, they don't have anything to do with each other (or
any other category).

A combined Styles and Templates category could be workable if others insist on
it, but note that the names of the commands *must* be fixed to disambiguate.
You can't just have "New", "Edit", and so on in a mixed category. This is
exactly the problem with searching by name in all categories.

(In reply to Heiko Tietze from comment #15)
> Do we need a category at all? My take is to get rid of the tab and all
> categories and have it at the commands list, see
> https://design.blog.documentfoundation.org/2015/01/22/how-to-make-
> libreoffice-customization-usable/

This is a terrible idea. There is a huge benefit to being able to filter a
monstrous list, or to browse by category. This would be true even if not for
the problems I reiterate here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148854] Android Viewer runs out of memory when scrolling up and down in Calc doc in experimental editing mode

2022-04-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148854

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #1 from Michael Weghorn  ---
Result of a first analysis:

This is caused by the way that Calc row and column headers (the "A", "B", "C",
... labels for columns and "1", "2", "3", ... for rows) are currently handled.

Android Viewer currently gets the headers for the whole current "document
size", s. `LOKitTileProvider#getCalcHeaders`. However, this has the side effect
of increasing the document size, triggered by this in 
`ScTabView::getRowColumnHeaders`:

>
> // 2) if we are approaching current max tiled row, signal a size changed 
> event
> // and invalidate the involved area
> lcl_ExtendTiledDimension(/* bColumn */ false, nEndRow, nVisibleRows, 
> *this, aViewData);

Properly fixing this would probably include reworking the way that Calc headers
are handled in Android Viewer more fundamentally.

With this workaround/hack to no longer retrieve headers for the whole doc size,
I no longer see that problem (but Calc headers are missing):

diff --git a/android/source/src/java/org/libreoffice/LOKitTileProvider.java
b/android/source/src/java/org/libreoffice/LOKitTileProvider.java
index 0c7931763571..03e6f1a7abb7 100644
--- a/android/source/src/java/org/libreoffice/LOKitTileProvider.java
+++ b/android/source/src/java/org/libreoffice/LOKitTileProvider.java
@@ -396,7 +396,7 @@ class LOKitTileProvider implements TileProvider {
 long nWidth = mDocument.getDocumentWidth();
 long nHeight = mDocument.getDocumentHeight();
 return mDocument.getCommandValues(".uno:ViewRowColumnHeaders?x=" + nX
+ "=" + nY
-+ "=" + nWidth + "=" + nHeight);
++ "=" + 10 + "=" + 10);
 }

 /**

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >