[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - starmath/inc starmath/Library_sm.mk starmath/source starmath/uiconfig uitest/math_tests
starmath/Library_sm.mk |3
starmath/inc/AccessibleSmElement.hxx | 101 --
starmath/inc/AccessibleSmElementsControl.hxx | 106 --
starmath/inc/ElementsDockingWindow.hxx | 106 --
starmath/source/AccessibleSmElement.cxx| 281 ---
starmath/source/AccessibleSmElementsControl.cxx| 369 -
starmath/source/ElementsDockingWindow.cxx | 841 ++---
starmath/source/SmElementsPanel.cxx| 14
starmath/source/SmElementsPanel.hxx|3
starmath/source/uiobject.cxx | 106 --
starmath/source/uiobject.hxx | 57 -
starmath/uiconfig/smath/ui/dockingelements.ui | 40
starmath/uiconfig/smath/ui/sidebarelements_math.ui | 42 -
uitest/math_tests/start.py |5
14 files changed, 167 insertions(+), 1907 deletions(-)
New commits:
commit 26628a8b554367d55ebeb2a9cf466780f738aed0
Author: Mike Kaganski
AuthorDate: Wed Jun 1 11:20:12 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:55:27 2022 +0200
Use IconView in SmElementsControl
Allows to send individual images over the wire in lok case,
instead of sending full canvas at every scroll operation.
The control's horizontal and vertical modes (when it's docked to a
vertical or a horizontal parent window side) are now identical.
Some TODOs:
* Re-implement a11y - that needs to be implemented on IconView level;
* Make sure that sub-pixel positioning is not used when creating the
elements icons (makes elements look a bit slim on Windows);
* Maybe restore mouse hover indication; in non-GTK case, a call to
m_xIconView->SetHoverSelection would suffice in SalInstanceIconView.
Change-Id: Idbc35f4e38e2b49fd0848a96da557fa2c1a1f6e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134761
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135421
Tested-by: Jenkins CollaboraOffice
diff --git a/starmath/Library_sm.mk b/starmath/Library_sm.mk
index 3eac10c29e85..047f7aea4697 100644
--- a/starmath/Library_sm.mk
+++ b/starmath/Library_sm.mk
@@ -64,8 +64,6 @@ $(eval $(call gb_Library_use_libraries,sm,\
))
$(eval $(call gb_Library_add_exception_objects,sm,\
-starmath/source/AccessibleSmElement \
-starmath/source/AccessibleSmElementsControl \
starmath/source/ElementsDockingWindow \
starmath/source/SmElementsPanel \
starmath/source/SmPanelFactory \
@@ -94,7 +92,6 @@ $(eval $(call gb_Library_add_exception_objects,sm,\
starmath/source/symbol \
starmath/source/tmpdevice \
starmath/source/typemap \
-starmath/source/uiobject \
starmath/source/unodoc \
starmath/source/unofilter \
starmath/source/unomodel \
diff --git a/starmath/inc/AccessibleSmElement.hxx
b/starmath/inc/AccessibleSmElement.hxx
deleted file mode 100644
index c1e7e6526872..
--- a/starmath/inc/AccessibleSmElement.hxx
+++ /dev/null
@@ -1,101 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#pragma once
-
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-
-class SmElementsControl;
-
-typedef ::cppu::ImplHelper3
-AccessibleSmElement_BASE;
-
-class AccessibleSmElement final : public
comphelper::OAccessibleComponentHelper,
- public AccessibleSmElement_BASE
-{
-SmElementsControl* m_pSmElementsControl;
-const sal_Int32 m_nIndexInParent; ///< index in the parent XAccessible
-const sal_uInt16 m_nItemId; ///< index in the SmElementsControl
-bool m_bHasFocus;
-sal_Int16 m_nRole;
-
-~AccessibleSmElement() override;
-void SAL_CALL disposing() override;
-css::awt::Rectangle implGetBounds() override;
-
-void testAction(sal_Int32) const;
-
-public:
-explicit AccessibleSmElement(SmElementsControl* pSmElementsControl,
sal_uInt16 nItemId,
-
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - uitest/math_tests
uitest/math_tests/start.py | 55 ++---
1 file changed, 13 insertions(+), 42 deletions(-)
New commits:
commit addd7c3d63f8d6c6c45c91436170f37a3e3b2609
Author: Xisco Fauli
AuthorDate: Thu Mar 10 11:41:25 2022 +0100
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:55:10 2022 +0200
uitest: math: at least execute the test on linux
besides, fix it and remove duplicated tests
Change-Id: I15c6696c6cdd1c7e03647e105d8caf268555018a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131310
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135420
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Mike Kaganski
diff --git a/uitest/math_tests/start.py b/uitest/math_tests/start.py
index 4645dff920da..215d97b68bdb 100644
--- a/uitest/math_tests/start.py
+++ b/uitest/math_tests/start.py
@@ -13,52 +13,23 @@ from uitest.framework import UITestCase
from uitest.uihelper.common import type_text, select_pos
import unittest
+import platform
class SimpleMathTest(UITestCase):
-def test_start_math(self):
-
-with self.ui_test.create_doc_in_start_center("math"):
-
-xMathDoc = self.xUITest.getTopFocusWindow()
-
-
-def test_docking_window_listbox(self):
-
-with self.ui_test.create_doc_in_start_center("math"):
-
-xMathDoc = self.xUITest.getTopFocusWindow()
-
-xList = xMathDoc.getChild("listbox")
-state = get_state_as_dict(xList)
-self.assertEqual(state["SelectEntryText"], "Unary/Binary
Operators")
-select_pos(xList, "1")
-state = get_state_as_dict(xList)
-self.assertEqual(state["SelectEntryText"], "Relations")
-
-
def test_math_edit(self):
with self.ui_test.create_doc_in_start_center("math"):
xMathDoc = self.xUITest.getTopFocusWindow()
-xMathEdit = xMathDoc.getChild("math_edit")
-
-type_text(xMathEdit, "E=mc^2")
-
-
-def test_math_selector(self):
-with self.ui_test.create_doc_in_start_center("math"):
-
-xMathDoc = self.xUITest.getTopFocusWindow()
-
-xMathSelector = xMathDoc.getChild("element_selector")
+xEditView = xMathDoc.getChild("editview")
-xElement = xMathSelector.getChild("1")
-xElement.executeAction("SELECT", tuple())
+type_text(xEditView, "E=mc^2")
+xMathEdit = xMathDoc.getChild("editview")
+self.assertEqual("E=mc^2", get_state_as_dict(xEditView)["Text"])
-@unittest.skip("on windows the f4 does not always work")
+@unittest.skipIf(platform.system() == "Windows", "on windows the f4 does
not always work")
def test_complete_math(self):
with self.ui_test.create_doc_in_start_center("math"):
@@ -68,19 +39,19 @@ class SimpleMathTest(UITestCase):
state = get_state_as_dict(xList)
self.assertEqual(state["SelectEntryText"], "Unary/Binary
Operators")
select_pos(xList, "1")
+state = get_state_as_dict(xList)
+self.assertEqual(state["SelectEntryText"], "Relations")
xMathSelector = xMathDoc.getChild("element_selector")
xElement = xMathSelector.getChild("1")
xElement.executeAction("SELECT", tuple())
-xMathEdit = xMathDoc.getChild("math_edit")
-type_text(xMathEdit, "1")
-xMathEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":"F4"}))
-type_text(xMathEdit, "2")
-
-edit_state = get_state_as_dict(xMathEdit)
-self.assertEqual("1 <> 2 ", edit_state["Text"])
+xEditView = xMathDoc.getChild("editview")
+type_text(xEditView, "1")
+xEditView.executeAction("TYPE", mkPropertyValues({"KEYCODE":"F4"}))
+type_text(xEditView, "2")
+self.assertEqual("1 <> 2 ", get_state_as_dict(xEditView)["Text"])
# vim: set shiftwidth=4 softtabstop=4 expandtab:
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - include/vcl vcl/inc vcl/jsdialog vcl/source vcl/unx
include/vcl/toolkit/treelistbox.hxx |2
include/vcl/weld.hxx |4
vcl/inc/iconview.hxx |7
vcl/inc/jsdialog/jsdialogbuilder.hxx |3
vcl/inc/salvtables.hxx |2
vcl/inc/svimpbox.hxx |2
vcl/jsdialog/jsdialogbuilder.cxx |6
vcl/source/app/salvtables.cxx| 23 +
vcl/source/treelist/iconview.cxx | 75 ++---
vcl/source/treelist/iconviewimpl.cxx | 523 +--
vcl/source/treelist/iconviewimpl.hxx | 28 +
vcl/source/treelist/svimpbox.cxx |4
vcl/source/treelist/treelistbox.cxx |8
vcl/unx/gtk3/gtkinst.cxx |6
14 files changed, 442 insertions(+), 251 deletions(-)
New commits:
commit 829425fc82fc257e5b9b098457964b3bac6e37bd
Author: Mike Kaganski
AuthorDate: Mon May 30 10:37:53 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:54:52 2022 +0200
Introduce weld::IconView::insert_separator
Needed to eventual re-implementation of starmath's SmElementsControl
using IconView.
This required re-implementation of IconViewImpl, to layout entries
by iteration, because now it's impossible to find an entry position
just based on its index.
This coincidentally fixed some visual glitches in non-gtk IconView
implementation from commit 5813660e7bfe128ac076e592fe31de64a6863780
Author Szymon Kłos
Date Tue Feb 16 16:03:30 2016 +0100
icon view for RemoteFilesDialog
where any selected element could become first in row when scrolling.
SvTreeListBox::SetEntryHeight taking a SvTreeListEntry const* had to
be renamed to CalcEntryHeight, to avoid both virtual and non-virtual
overloads, additionally having different accessibility.
A TODO is implement separators in GtkInstanceIconView. I couldn't
find a GTK API for separators in IconView, so possibly a workaround
would be needed with some non-selectable narrow elements.
Change-Id: Ie8dc35d94049a1c48e4eb49697681ffbe93c17f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135112
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135419
Tested-by: Jenkins CollaboraOffice
diff --git a/include/vcl/toolkit/treelistbox.hxx
b/include/vcl/toolkit/treelistbox.hxx
index ff1cc54216e8..aef486d1ef37 100644
--- a/include/vcl/toolkit/treelistbox.hxx
+++ b/include/vcl/toolkit/treelistbox.hxx
@@ -472,7 +472,7 @@ public:
protected:
-VCL_DLLPRIVATE void SetEntryHeight( SvTreeListEntry const * pEntry
);
+virtual voidCalcEntryHeight(SvTreeListEntry const* pEntry);
void AdjustEntryHeight( const Image& rBmp );
VCL_DLLPRIVATE void AdjustEntryHeight();
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 9fe575fe50ec..8bef158cd19a 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1342,6 +1342,8 @@ public:
const VirtualDevice* pIcon, TreeIter* pRet)
= 0;
+virtual void insert_separator(int pos, const OUString* pId) = 0;
+
void append(const OUString& rId, const OUString& rStr, const OUString&
rImage)
{
insert(-1, , , , nullptr);
@@ -1352,6 +1354,8 @@ public:
insert(-1, , , pImage, nullptr);
}
+void append_separator(const OUString& rId) { insert_separator(-1, ); }
+
void connect_selection_changed(const Link& rLink)
{
m_aSelectionChangeHdl = rLink;
diff --git a/vcl/inc/iconview.hxx b/vcl/inc/iconview.hxx
index c1e62bc2ec65..971a638cc6ef 100644
--- a/vcl/inc/iconview.hxx
+++ b/vcl/inc/iconview.hxx
@@ -27,15 +27,20 @@ class IconView final : public SvTreeListBox
public:
IconView(vcl::Window* pParent, WinBits nBits);
+Size GetEntrySize(const SvTreeListEntry&) const;
+
virtual void Resize() override;
-virtual tools::Rectangle GetFocusRect(const SvTreeListEntry*, tools::Long
nEntryPos) override;
+virtual tools::Rectangle GetFocusRect(const SvTreeListEntry*, tools::Long)
override;
void PaintEntry(SvTreeListEntry&, tools::Long nX, tools::Long nY,
vcl::RenderContext& rRenderContext);
virtual FactoryFunction GetUITestFactory() const override;
virtual void DumpAsPropertyTree(tools::JsonWriter& rJsonWriter) override;
+
+protected:
+virtual void CalcEntryHeight(SvTreeListEntry const* pEntry) override;
};
#endif
diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index 44747b8d3418..098e8279039b 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -671,6 +671,9 @@ public:
virtual void insert(int pos, const OUString* pStr, const OUString* pId,
const VirtualDevice* pIcon, weld::TreeIter* pRet)
override;
+
+virtual void insert_separator(int pos, const OUString*
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - include/vcl vcl/inc vcl/source vcl/unx
include/vcl/weld.hxx | 10 +
vcl/inc/salvtables.hxx|6 +
vcl/source/app/salvtables.cxx | 29 ++
vcl/unx/gtk3/gtkinst.cxx | 46 ++
4 files changed, 91 insertions(+)
New commits:
commit 49148b925f296c22378088c8f1c01164e5599c89
Author: Mike Kaganski
AuthorDate: Tue May 24 18:43:45 2022 +0200
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:54:19 2022 +0200
Implement weld::IconView::[gs]et_item_width
Change-Id: I211e3c21b4e0148c4ff6fc9931838e37ccd0cc41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134897
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135417
Tested-by: Jenkins CollaboraOffice
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index f9684606d644..9fe575fe50ec 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1331,6 +1331,9 @@ protected:
OUString signal_query_tooltip(const TreeIter& rIter) { return
m_aQueryTooltipHdl.Call(rIter); }
public:
+virtual int get_item_width() const = 0;
+virtual void set_item_width(int width) = 0;
+
virtual void insert(int pos, const OUString* pStr, const OUString* pId,
const OUString* pIconName, TreeIter* pRet)
= 0;
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index e302e59a3318..036e769d1a37 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -1754,6 +1754,9 @@ private:
public:
SalInstanceIconView(::IconView* pIconView, SalInstanceBuilder* pBuilder,
bool bTakeOwnership);
+virtual int get_item_width() const override;
+virtual void set_item_width(int width) override;
+
virtual void freeze() override;
virtual void thaw() override;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 830047f3a079..925bfa324a68 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -5195,6 +5195,9 @@ SalInstanceIconView::SalInstanceIconView(::IconView*
pIconView, SalInstanceBuild
m_xIconView->SetPopupMenuHdl(LINK(this, SalInstanceIconView, CommandHdl));
}
+int SalInstanceIconView::get_item_width() const { return
m_xIconView->GetEntryWidth(); }
+void SalInstanceIconView::set_item_width(int width) {
m_xIconView->SetEntryWidth(width); }
+
void SalInstanceIconView::freeze()
{
bool bIsFirstFreeze = IsFirstFreeze();
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 7cb845d92a32..80e07031bdac 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -16066,6 +16066,16 @@ public:
m_nIdCol = m_nTextCol + 1;
}
+virtual int get_item_width() const override
+{
+return gtk_icon_view_get_item_width(m_pIconView);
+}
+
+virtual void set_item_width(int width) override
+{
+gtk_icon_view_set_item_width(m_pIconView, width);
+}
+
virtual void insert(int pos, const OUString* pText, const OUString* pId,
const OUString* pIconName, weld::TreeIter* pRet) override
{
disable_notify_events();
commit aa56360855a372fcc3329b04d8ab045b8ef09cab
Author: Mike Kaganski
AuthorDate: Mon May 23 12:48:15 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:54:04 2022 +0200
Implement weld::IconView::connect_query_tooltip
Change-Id: I8a8540e240d6a7046f564404c7c3b6bff8c2f04d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134806
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135416
Tested-by: Jenkins CollaboraOffice
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 5fab9b459a8b..f9684606d644 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1324,9 +1324,11 @@ protected:
Link m_aSelectionChangeHdl;
Link m_aItemActivatedHdl;
Link m_aCommandHdl;
+Link m_aQueryTooltipHdl;
void signal_selection_changed() { m_aSelectionChangeHdl.Call(*this); }
bool signal_item_activated() { return m_aItemActivatedHdl.Call(*this); }
+OUString signal_query_tooltip(const TreeIter& rIter) { return
m_aQueryTooltipHdl.Call(rIter); }
public:
virtual void insert(int pos, const OUString* pStr, const OUString* pId,
@@ -1362,6 +1364,11 @@ public:
void connect_command(const Link& rLink) {
m_aCommandHdl = rLink; }
+virtual void connect_query_tooltip(const Link&
rLink)
+{
+m_aQueryTooltipHdl = rLink;
+}
+
virtual OUString get_selected_id() const = 0;
virtual void clear() = 0;
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index c44fa1f96234..e302e59a3318 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -1749,6 +1749,7 @@ private:
DECL_LINK(DeSelectHdl, SvTreeListBox*, void);
DECL_LINK(DoubleClickHdl, SvTreeListBox*, bool);
DECL_LINK(CommandHdl, const CommandEvent&, bool);
+
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - starmath/uiconfig
starmath/uiconfig/smath/ui/sidebarelements_math.ui |2 +- starmath/uiconfig/smath/ui/sidebarproperties_math.ui |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 1875cd8c5a6db2720dea732a89c5a9df0b0d3505 Author: Xisco Fauli AuthorDate: Mon May 30 10:28:35 2022 +0200 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:53:49 2022 +0200 fix another domain Change-Id: I3a0c5aab62a7b6723df5820abb3f56e3f110d8b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135113 Tested-by: Jenkins Reviewed-by: Xisco Fauli Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135415 Tested-by: Jenkins CollaboraOffice Reviewed-by: Mike Kaganski diff --git a/starmath/uiconfig/smath/ui/sidebarproperties_math.ui b/starmath/uiconfig/smath/ui/sidebarproperties_math.ui index b2d8b05eddf0..1eb123534f95 100644 --- a/starmath/uiconfig/smath/ui/sidebarproperties_math.ui +++ b/starmath/uiconfig/smath/ui/sidebarproperties_math.ui @@ -1,6 +1,6 @@ - + commit 409e4b12600b6ed6c628d8fa8340821cfef255a1 Author: Mike Kaganski AuthorDate: Sat May 28 07:20:59 2022 +0200 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:53:32 2022 +0200 Fix domain Change-Id: I0391fb3d4b913967ed4f8459d6b30f7f39bf4b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135055 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135414 Tested-by: Jenkins CollaboraOffice diff --git a/starmath/uiconfig/smath/ui/sidebarelements_math.ui b/starmath/uiconfig/smath/ui/sidebarelements_math.ui index 3b18a2a9e301..9d915ca24e43 100644 --- a/starmath/uiconfig/smath/ui/sidebarelements_math.ui +++ b/starmath/uiconfig/smath/ui/sidebarelements_math.ui @@ -1,6 +1,6 @@ - +
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - svx/source vcl/source
svx/source/accessibility/AccessibleTextHelper.cxx | 20 +++- vcl/source/treelist/treelistbox.cxx |6 +++--- 2 files changed, 14 insertions(+), 12 deletions(-) New commits: commit a9ee71097a246edea9581a4f997d13467b7189ee Author: Mike Kaganski AuthorDate: Sat May 28 20:04:40 2022 +0200 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:53:18 2022 +0200 Fix failing assert on shutdown with NVDA active The stack trace at the moment of calling implLookupClient with nClient == -1 was: > ucrtbased.dll!abort() Line 61 C++ > ucrtbased.dll!common_assert_to_stderr(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187C++ > ucrtbased.dll!common_assert(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420 C++ > ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444 C++ > comphelper.dll!`anonymous namespace'::implLookupClient(const unsigned long nClient, std::_Tree_iterator * & rPos) Line 139 C++ > comphelper.dll!comphelper::AccessibleEventNotifier::addEvent(const unsigned long _nClient, const com::sun::star::accessibility::AccessibleEventObject & _rEvent) Line 249 C++ > svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const com::sun::star::accessibility::AccessibleEventObject & rEvent) Line 1416 C++ > svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const short nEventId, const com::sun::star::uno::Any & rNewValue, const com::sun::star::uno::Any & rOldValue) Line 1408 C++ > svxlo.dll!accessibility::AccessibleTextHelper_Impl::ShutdownEditSource() Line 700 C++ > svxlo.dll!accessibility::AccessibleTextHelper_Impl::SetEditSource(std::unique_ptr> && pEditSource) Line 717 C++ > svxlo.dll!accessibility::AccessibleTextHelper::SetEditSource(std::unique_ptr> && pEditSource) Line 1548 C++ > svxlo.dll!WeldEditAccessible::ClearWin() Line 552 C++ > svxlo.dll!WeldEditView::~WeldEditView() Line 864 C++ > smlo.dll!SmEditTextWindow::~SmEditTextWindow() Line 85C++ > smlo.dll!SmEditTextWindow::`scalar deleting destructor'(unsigned int) C++ > smlo.dll!std::default_delete::operator()(SmEditTextWindow * _Ptr) Line 3129 C++ > smlo.dll!std::unique_ptr>::reset(SmEditTextWindow * _Ptr) Line 3276C++ > smlo.dll!SmEditWindow::DeleteEditView() Line 853 C++ > smlo.dll!SmEditWindow::~SmEditWindow() Line 139 C++ > smlo.dll!SmEditWindow::`scalar deleting destructor'(unsigned int) C++ > smlo.dll!o3tl::default_delete::operator()(SmEditWindow * p) Line 46 C++ > smlo.dll!std::unique_ptr>::reset(SmEditWindow * _Ptr) Line 3276 C++ > smlo.dll!SmCmdBoxWindow::dispose() Line 931 C++ > vcllo.dll!VclReferenceBase::disposeOnce() Line 39 C++ > sfxlo.dll!VclPtr::disposeAndClear() Line 206 C++ > sfxlo.dll!SfxChildWindow::~SfxChildWindow() Line 198 C++ > smlo.dll!SmCmdBoxWrapper::~SmCmdBoxWrapper() C++ > smlo.dll!SmCmdBoxWrapper::`scalar deleting destructor'(unsigned int) C++ > sfxlo.dll!SfxChildWindow::Destroy() Line 176 C++ > sfxlo.dll!SfxWorkWindow::DeleteControllers_Impl() Line 599C++ > sfxlo.dll!SfxFrame::DoClose_Impl() Line 133 C++ > sfxlo.dll!SfxBaseController::dispose() Line 981 C++ > fwklo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun::star::uno::Reference & xComponentWindow, const com::sun::star::uno::Reference & xController) Line 1485C++ > fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1696 C++ > fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1702 C++ > fwklo.dll!framework::Desktop::terminate() Line 214C++ > fwklo.dll!framework::CloseDispatcher::implts_terminateApplication() Line 543 C++ > fwklo.dll!framework::CloseDispatcher::impl_asyncCallback(LinkParamNone * __formal) Line 397 C++ > fwklo.dll!framework::CloseDispatcher::LinkStubimpl_asyncCallback(void * instance, LinkParamNone * data) Line 245 C++ > vcllo.dll!Link::Call(LinkParamNone * data) Line 111 C++ > vcllo.dll!vcl::EventPoster::DoEvent_Impl(void * __formal) Line 53 C++ > vcllo.dll!vcl::EventPoster::LinkStubDoEvent_Impl(void * instance, void * data) Line 48C++ > vcllo.dll!Link::Call(void * data) Line 111 C++ > vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 2232 C++ > vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2800 C++ > vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 308 C++ > vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4214C++
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - include/unotools starmath/inc starmath/source vcl/source
include/unotools/resmgr.hxx |4
starmath/inc/ElementsDockingWindow.hxx| 25 -
starmath/source/ElementsDockingWindow.cxx | 739 --
starmath/source/SmElementsPanel.cxx |7
vcl/source/app/salvtables.cxx |2
5 files changed, 412 insertions(+), 365 deletions(-)
New commits:
commit 7f64d5fbcf79c3665ac913272a1d57db71bc5f0b
Author: Mike Kaganski
AuthorDate: Thu May 19 16:38:56 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:52:49 2022 +0200
Simplify SmElementsControl
Change-Id: Idcb075a474b440447b8566cc92a8f65bbc77127c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134643
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135411
Tested-by: Jenkins CollaboraOffice
diff --git a/include/unotools/resmgr.hxx b/include/unotools/resmgr.hxx
index 80e3a23eb57d..142ec2de5b1f 100644
--- a/include/unotools/resmgr.hxx
+++ b/include/unotools/resmgr.hxx
@@ -33,9 +33,9 @@ struct UNOTOOLS_DLLPUBLIC TranslateId
const char* mpContext;
const char* mpId;
-inline TranslateId()
+inline constexpr TranslateId()
: mpContext(nullptr), mpId(nullptr) {}
-inline TranslateId(const char* pContext, const char* pId)
+inline constexpr TranslateId(const char* pContext, const char* pId)
: mpContext(pContext), mpId(pId) {}
inline operator bool() const { return mpId != nullptr; }
diff --git a/starmath/inc/ElementsDockingWindow.hxx
b/starmath/inc/ElementsDockingWindow.hxx
index 9f8849da4b82..7c188133dace 100644
--- a/starmath/inc/ElementsDockingWindow.hxx
+++ b/starmath/inc/ElementsDockingWindow.hxx
@@ -57,32 +57,11 @@ public:
bool isSeparator() const override { return true; }
};
-typedef std::pair SmElementDescr;
-
class SmElementsControl : public weld::CustomWidgetController
{
friend class ElementSelectorUIObject;
friend class ElementUIObject;
-// SmParser 5 elements
-static const SmElementDescr m_a5UnaryBinaryOperatorsList[];
-static const SmElementDescr m_a5RelationsList[];
-static const SmElementDescr m_a5SetOperationsList[];
-static const SmElementDescr m_a5FunctionsList[];
-static const SmElementDescr m_a5OperatorsList[];
-static const SmElementDescr m_a5AttributesList[];
-static const SmElementDescr m_a5BracketsList[];
-static const SmElementDescr m_a5FormatsList[];
-static const SmElementDescr m_a5OthersList[];
-static const SmElementDescr m_a5ExamplesList[];
-static const std::tuple
m_a5Categories[];
-static const size_t m_a5CategoriesSize;
-
-// SmParser 6 elements
-static const std::tuple
m_a6Categories[0];
-static const size_t m_a6CategoriesSize = 0;
-
-// Parser for them
std::unique_ptr maParser;
virtual void Paint(vcl::RenderContext& rRenderContext, const
tools::Rectangle&) override;
@@ -112,7 +91,6 @@ class SmElementsControl : public weld::CustomWidgetController
rtl::Reference m_xAccessible;
void addElement(const OUString& aElementVisual, const OUString&
aElementSource, const OUString& aHelpText);
-void addElements(const SmElementDescr aElementsArray[], sal_uInt16 size);
SmElement* current() const;
void setCurrentElement(sal_uInt16);
bool hasRollover() const { return m_nCurrentRolloverElement !=
SAL_MAX_UINT16; }
@@ -132,8 +110,7 @@ public:
explicit SmElementsControl(std::unique_ptr
xScrolledWindow);
virtual ~SmElementsControl() override;
-static const auto& categories() { return m_a5Categories; }
-static size_t categoriesSize() { return m_a5CategoriesSize; }
+static const std::vector& categories();
const TranslateId& elementSetId() const { return msCurrentSetId; }
void setElementSetId(TranslateId pSetId);
diff --git a/starmath/source/ElementsDockingWindow.cxx
b/starmath/source/ElementsDockingWindow.cxx
index 2f4bc80de14f..de1782f5f67a 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -37,6 +37,8 @@
#include
#include
+#include
+
SmElement::SmElement(std::unique_ptr&& pNode, const OUString& aText,
const OUString& aHelpText) :
mpNode(std::move(pNode)),
maText(aText),
@@ -52,234 +54,416 @@ SmElementSeparator::SmElementSeparator() :
SmElement(std::unique_ptr(), OUString(), OUString())
{}
-const SmElementDescr SmElementsControl::m_a5UnaryBinaryOperatorsList[] =
+namespace
{
-{RID_PLUSX, RID_PLUSX_HELP}, {RID_MINUSX, RID_MINUSX_HELP},
-{RID_PLUSMINUSX, RID_PLUSMINUSX_HELP}, {RID_MINUSPLUSX,
RID_MINUSPLUSX_HELP},
-{nullptr, {}},
-{RID_XPLUSY, RID_XPLUSY_HELP}, {RID_XMINUSY, RID_XMINUSY_HELP},
-{RID_XCDOTY, RID_XCDOTY_HELP}, {RID_XTIMESY, RID_XTIMESY_HELP},
-{RID_XSYMTIMESY, RID_XSYMTIMESY_HELP}, {RID_XOVERY, RID_XOVERY_HELP},
-{RID_FRACXY, RID_FRACXY_HELP},
-{RID_XDIVY, RID_XDIVY_HELP}, {RID_XSYMDIVIDEY,
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - starmath/source starmath/uiconfig
starmath/source/ElementsDockingWindow.cxx |8 - starmath/uiconfig/smath/ui/sidebarelements_math.ui | 144 ++--- 2 files changed, 46 insertions(+), 106 deletions(-) New commits: commit f208a4bcbbadc40d92a32bef9afba487bb539fe3 Author: Mike Kaganski AuthorDate: Tue May 17 11:55:11 2022 +0300 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:52:20 2022 +0200 Simplify the UI Remove the intermediary containers, keeping those that are really needed to create the necessary structure. I'm curious, how much CPU could be wasted by the unused container layers when calculating the layout. Change-Id: I56bf13c52b4e14dcef6595d00223cd36f48793d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134463 Tested-by: Jenkins Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135409 Tested-by: Jenkins CollaboraOffice Reviewed-by: Mike Kaganski diff --git a/starmath/uiconfig/smath/ui/sidebarelements_math.ui b/starmath/uiconfig/smath/ui/sidebarelements_math.ui index c645e7f8d349..3b18a2a9e301 100644 --- a/starmath/uiconfig/smath/ui/sidebarelements_math.ui +++ b/starmath/uiconfig/smath/ui/sidebarelements_math.ui @@ -8,146 +8,86 @@ - - + True False +vertical True True 6 +True - - + True -False +True True True -3 -6 +in - + True True True True -vertical -True +liststore1 +False +0 +False + + + - - -True -False -True -True + - -True -True -True -True -in - - -True -True -True -True -liststore1 -False -0 -False - - - - - - - - -1 - - - - - - - - -0 -0 - + + +1 + - -False -True - + + + + + + +True +True +True +True +in + + +True +False - - + True False +vertical True True -6 - - + True -False +True +GDK_BUTTON_MOTION_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_ENTER_NOTIFY_MASK | GDK_LEAVE_NOTIFY_MASK | GDK_STRUCTURE_MASK | GDK_SCROLL_MASK | GDK_SMOOTH_SCROLL_MASK True True - - -True -True -True -True -in - - -True -False - - -True -True -GDK_BUTTON_MOTION_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_ENTER_NOTIFY_MASK | GDK_LEAVE_NOTIFY_MASK | GDK_STRUCTURE_MASK | GDK_SCROLL_MASK | GDK_SMOOTH_SCROLL_MASK -True -True - - - - - - -0 -0 -
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - comphelper/source include/vcl svx/source vcl/source
comphelper/source/misc/accessibletexthelper.cxx |5 ++---
include/vcl/toolkit/treelistbox.hxx |2 ++
svx/source/tbxctrls/fontworkgallery.cxx |2 +-
vcl/source/treelist/treelistbox.cxx |7 +++
vcl/source/treelist/uiobject.cxx|4 +++-
5 files changed, 15 insertions(+), 5 deletions(-)
New commits:
commit 5adc90960a84c738e04a8508e5d9b179e757dd0e
Author: Mike Kaganski
AuthorDate: Fri May 6 15:01:59 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:51:47 2022 +0200
Only dereference iterators after checking them
Was this way since commit edf11d28fafac50b6380c9372d0e6cf07a355616
Author Vladimir Glazounov
Date Thu Apr 24 16:27:52 2003 +
INTEGRATION: CWS uaa02 (1.3.44); FILE MERGED
Surfaced after commit b1148c31ed2786396f0b018a988fce8288f1797d
Author Noel Grandin
Date Wed Apr 27 16:47:53 2022 +0200
use more string_view in comphelper
where the pointers were changed to iterators, which are checked in
debug builds, failing an assertion.
Change-Id: I87fce562aef8f50b94fb52ad6c2a79d2e84d6424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133934
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135407
Tested-by: Jenkins CollaboraOffice
diff --git a/comphelper/source/misc/accessibletexthelper.cxx
b/comphelper/source/misc/accessibletexthelper.cxx
index 35fe769c1700..6bb244dd5b1a 100644
--- a/comphelper/source/misc/accessibletexthelper.cxx
+++ b/comphelper/source/misc/accessibletexthelper.cxx
@@ -682,9 +682,8 @@ namespace comphelper
const sal_Unicode* pLastDiffNew = rNewString.getStr() + nLenNew;
// find first difference
-while ((*pFirstDiffOld == *pFirstDiffNew) &&
- (pFirstDiffOld < pLastDiffOld) &&
- (pFirstDiffNew < pLastDiffNew))
+while ((pFirstDiffOld < pLastDiffOld) && (pFirstDiffNew < pLastDiffNew)
+ && (*pFirstDiffOld == *pFirstDiffNew))
{
pFirstDiffOld++;
pFirstDiffNew++;
commit 273eb41f28eded48ff27561ae28882658b5099ad
Author: Mike Kaganski
AuthorDate: Tue May 3 09:49:07 2022 +0100
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:51:32 2022 +0200
Don't add empty labels to fontwork's icon view
This allows to center the icon in the respective entry,
not having whitespace in the bottom
Change-Id: Ib148df6911f020f8d4efca4f6a80a65b7f95945f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133720
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135406
Tested-by: Jenkins CollaboraOffice
diff --git a/include/vcl/toolkit/treelistbox.hxx
b/include/vcl/toolkit/treelistbox.hxx
index 999f3a52c6b6..ff1cc54216e8 100644
--- a/include/vcl/toolkit/treelistbox.hxx
+++ b/include/vcl/toolkit/treelistbox.hxx
@@ -565,6 +565,8 @@ public:
voidSetCheckButtonState( SvTreeListEntry*, SvButtonState );
SvButtonState GetCheckButtonState( SvTreeListEntry* ) const;
+static bool HasEntryText(const SvTreeListEntry* pEntry);
+
voidSetEntryText(SvTreeListEntry*, const OUString& );
voidSetExpandedEntryBmp( SvTreeListEntry* _pEntry, const
Image& _rImage );
voidSetCollapsedEntryBmp( SvTreeListEntry* _pEntry, const
Image& _rImage );
diff --git a/svx/source/tbxctrls/fontworkgallery.cxx
b/svx/source/tbxctrls/fontworkgallery.cxx
index de42c5f639c4..3cc8e5ac381a 100644
--- a/svx/source/tbxctrls/fontworkgallery.cxx
+++ b/svx/source/tbxctrls/fontworkgallery.cxx
@@ -131,7 +131,7 @@ void FontWorkGalleryDialog::fillFavorites(sal_uInt16
nThemeId)
for( size_t nFavorite = 1; nFavorite <= nFavCount; nFavorite++ )
{
OUString sId = OUString::number(static_cast(nFavorite));
-maCtlFavorites->append(sId, "", maFavoritesHorizontal[nFavorite-1]);
+maCtlFavorites->insert(-1, nullptr, ,
maFavoritesHorizontal[nFavorite - 1], nullptr);
}
if (maCtlFavorites->n_children())
diff --git a/vcl/source/treelist/treelistbox.cxx
b/vcl/source/treelist/treelistbox.cxx
index f8cfaaf6a311..f2ec419891be 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -1572,6 +1572,13 @@ SvTreeListEntry* SvTreeListBox::InsertEntry(
return pEntry;
}
+// static
+bool SvTreeListBox::HasEntryText(const SvTreeListEntry* pEntry)
+{
+assert(pEntry);
+return pEntry->GetFirstItem(SvLBoxItemType::String) != nullptr;
+}
+
void SvTreeListBox::SetEntryText(SvTreeListEntry* pEntry, const OUString& rStr)
{
SvLBoxString* pItem =
static_cast(pEntry->GetFirstItem(SvLBoxItemType::String));
diff --git a/vcl/source/treelist/uiobject.cxx b/vcl/source/treelist/uiobject.cxx
index 0caea7163f76..846cc2066f46 100644
---
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - officecfg/registry vcl/source
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu | 11
vcl/source/treelist/iconview.cxx | 153
--
2 files changed, 73 insertions(+), 91 deletions(-)
New commits:
commit d90f701221207977e4a0417caedc841b6adca2e3
Author: Mike Kaganski
AuthorDate: Wed Apr 27 11:10:59 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:51:17 2022 +0200
Drop unused .uno:EditChart
This reverts commit fb5e0581f922dba93f3689786201ee067cb01a73
Author Muhammet Kara
Date Fri Nov 22 13:16:25 2019 +0300
Add command .uno:EditChart
Obviously this command has never been used. It was named "EditChart",
but in fact it executes the default verb for any selected object, so
could be named like "edit object".
Since it's unused, let's just drop it instead of renaming.
Change-Id: I20aa8a17c54a0bf0030c3187340690846bfbc729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133473
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135405
Tested-by: Jenkins CollaboraOffice
diff --git
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 15924fc1f06e..0b1212292b13 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -7265,17 +7265,6 @@ bit 3 (0x8): #define
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
1
-
-
- ~Edit Chart
-
-
- .uno:ObjectMenue?VerbID:short=-1
-
-
- 1
-
-
~Distribution
commit 20c7f3d0047f5de5c0951a0091c0d03ed522d67f
Author: Mike Kaganski
AuthorDate: Mon May 2 09:46:52 2022 +0100
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:50:57 2022 +0200
Reimplement IconView::PaintEntry
Use spacing between top, bottom, icon and text (the case of sum
of items heights greater than element height is not yet handled).
Draw the background even when there's no text: that allows to
center the icon in the item, and still have proper highlight of
selected item.
Change-Id: I5d5dd14060efd15beb0e69df859ecf1efe8a0287
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133612
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135404
Tested-by: Jenkins CollaboraOffice
diff --git a/vcl/source/treelist/iconview.cxx b/vcl/source/treelist/iconview.cxx
index c46862434120..c1ed4b028726 100644
--- a/vcl/source/treelist/iconview.cxx
+++ b/vcl/source/treelist/iconview.cxx
@@ -82,59 +82,45 @@ tools::Rectangle IconView::GetFocusRect(const
SvTreeListEntry*, tools::Long nEnt
void IconView::PaintEntry(SvTreeListEntry& rEntry, tools::Long nX, tools::Long
nY,
vcl::RenderContext& rRenderContext)
{
-tools::Rectangle aRect; // multi purpose
+const int nSpacing = 5; // 5 pixels from top, from bottom, between icon
and label
pImpl->UpdateContextBmpWidthMax();
short nTempEntryHeight = GetEntryHeight();
short nTempEntryWidth = GetEntryWidth();
-Point aEntryPos;
+Point aEntryPos(nX, nY);
-Color aBackupTextColor(rRenderContext.GetTextColor());
-vcl::Font aBackupFont(rRenderContext.GetFont());
-Color aBackupColor = rRenderContext.GetFillColor();
+const Color aBackupTextColor(rRenderContext.GetTextColor());
+const vcl::Font aBackupFont(rRenderContext.GetFont());
+const Color aBackupColor = rRenderContext.GetFillColor();
-bool bCurFontIsSel = false;
-const WinBits nWindowStyle = GetStyle();
-const bool bHideSelection = (nWindowStyle & WB_HIDESELECTION) != 0 &&
!HasFocus();
const StyleSettings& rSettings =
rRenderContext.GetSettings().GetStyleSettings();
-vcl::Font aHighlightFont(rRenderContext.GetFont());
-const Color aHighlightTextColor(rSettings.GetHighlightTextColor());
-aHighlightFont.SetColor(aHighlightTextColor);
-
-Size aOutputSize = GetOutputSizePixel();
+const Size aOutputSize = GetOutputSizePixel();
if (aOutputSize.getHeight() < nTempEntryHeight)
nTempEntryHeight = aOutputSize.getHeight();
-Size aRectSize(nTempEntryWidth, nTempEntryHeight);
-
-SvViewDataEntry* pViewDataEntry = GetViewDataEntry();
+const SvViewDataEntry* pViewDataEntry = GetViewDataEntry();
-sal_uInt16 nItemCount = rEntry.ItemCount();
-sal_uInt16 nCurItem = 0;
-sal_uInt16 nIconItem = nItemCount;
-
-while (nCurItem < nItemCount)
+bool bCurFontIsSel = false;
+if (pViewDataEntry->IsHighlighted())
{
-SvLBoxItem* pItem = nCurItem < nItemCount ? (nCurItem)
: nullptr;
-SvLBoxItemType nItemType = pItem->GetType();
-
-
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - starmath/source
starmath/source/ElementsDockingWindow.cxx |2 ++ starmath/source/SmElementsPanel.hxx |2 -- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit e15109935a0afa8d7b073a75e256eeed760d8691 Author: Mike Kaganski AuthorDate: Wed Apr 27 17:40:20 2022 +0300 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:50:40 2022 +0200 tdf#148819: let the scroller know the custom widget's line size Change-Id: Ie30cd1db182aad5fbbf7e89498bd0ae9ce98c0f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133518 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135403 Tested-by: Jenkins CollaboraOffice diff --git a/starmath/source/ElementsDockingWindow.cxx b/starmath/source/ElementsDockingWindow.cxx index 23888cf95311..1ba5c0d991ec 100644 --- a/starmath/source/ElementsDockingWindow.cxx +++ b/starmath/source/ElementsDockingWindow.cxx @@ -499,6 +499,7 @@ void SmElementsControl::LayoutOrPaintContents(vcl::RenderContext& rContext, bool mxScroll->hadjustment_set_upper(nTotalControlWidth); mxScroll->hadjustment_set_page_size(nControlWidth); mxScroll->hadjustment_set_page_increment(nControlWidth); +mxScroll->hadjustment_set_step_increment(boxX); mxScroll->set_hpolicy(VclPolicyType::ALWAYS); } else @@ -515,6 +516,7 @@ void SmElementsControl::LayoutOrPaintContents(vcl::RenderContext& rContext, bool mxScroll->vadjustment_set_upper(nTotalControlHeight); mxScroll->vadjustment_set_page_size(nControlHeight); mxScroll->vadjustment_set_page_increment(nControlHeight); +mxScroll->vadjustment_set_step_increment(boxY); mxScroll->set_vpolicy(VclPolicyType::ALWAYS); } else commit 5376d162dc28d014d3a7fad99bcfba95b9adde25 Author: Mike Kaganski AuthorDate: Wed Apr 27 15:53:09 2022 +0300 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:50:26 2022 +0200 Clean up includes Change-Id: Ied9a75953875e809e4284fdff03aab6add6800ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133511 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135402 Tested-by: Jenkins CollaboraOffice diff --git a/starmath/source/SmElementsPanel.hxx b/starmath/source/SmElementsPanel.hxx index 4629b33af409..72de4c227a87 100644 --- a/starmath/source/SmElementsPanel.hxx +++ b/starmath/source/SmElementsPanel.hxx @@ -22,8 +22,6 @@ #include #include -#include -#include #include #include #include
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - officecfg/registry starmath/Library_sm.mk starmath/source starmath/uiconfig starmath/UIConfig_smath.mk
officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu | 29 +++
starmath/Library_sm.mk |1
starmath/UIConfig_smath.mk |1
starmath/source/SmPanelFactory.cxx |7
starmath/source/SmPropertiesPanel.cxx| 88 +++
starmath/source/SmPropertiesPanel.hxx| 51 ++
starmath/uiconfig/smath/ui/sidebarproperties_math.ui | 81 ++
7 files changed, 257 insertions(+), 1 deletion(-)
New commits:
commit 8672f95ab410a42667fc8655bfc42f583d62e492
Author: Mike Kaganski
AuthorDate: Wed Apr 27 15:06:03 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:41:14 2022 +0200
tdf#125931: add Properties panel to Math's Properties deck
For now, it only contains buttons opening the dialogs accessible
from Format menu. This is enough for the initial implementation,
and should later be changed to individual controls allowing to
set the formula properties directly.
Change-Id: Ia0e52915198ddb2648d13d577d55b367f178b1ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133508
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135401
Tested-by: Jenkins CollaboraOffice
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index a6e268628941..7192e9d10a84 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -762,6 +762,35 @@
+
+
+ Properties
+
+
+ true
+
+
+ MathPropertiesPanel
+
+
+ PropertyDeck
+
+
+
+Math, any, visible;
+
+
+
+
private:resource/toolpanel/SmPanelFactory/MathPropertiesPanel
+
+
+ 100
+
+
+ false
+
+
+
Elements
diff --git a/starmath/Library_sm.mk b/starmath/Library_sm.mk
index 91d62caed114..3eac10c29e85 100644
--- a/starmath/Library_sm.mk
+++ b/starmath/Library_sm.mk
@@ -69,6 +69,7 @@ $(eval $(call gb_Library_add_exception_objects,sm,\
starmath/source/ElementsDockingWindow \
starmath/source/SmElementsPanel \
starmath/source/SmPanelFactory \
+starmath/source/SmPropertiesPanel \
starmath/source/accessibility \
starmath/source/action \
starmath/source/caret \
diff --git a/starmath/UIConfig_smath.mk b/starmath/UIConfig_smath.mk
index 45b12819731a..a54f2e4553c4 100644
--- a/starmath/UIConfig_smath.mk
+++ b/starmath/UIConfig_smath.mk
@@ -40,6 +40,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/smath,\
starmath/uiconfig/smath/ui/printeroptions \
starmath/uiconfig/smath/ui/savedefaultsdialog \
starmath/uiconfig/smath/ui/sidebarelements_math \
+ starmath/uiconfig/smath/ui/sidebarproperties_math \
starmath/uiconfig/smath/ui/smathsettings \
starmath/uiconfig/smath/ui/spacingdialog \
starmath/uiconfig/smath/ui/symdefinedialog \
diff --git a/starmath/source/SmPanelFactory.cxx
b/starmath/source/SmPanelFactory.cxx
index 243c3d05a5f2..664adbcb3bcb 100644
--- a/starmath/source/SmPanelFactory.cxx
+++ b/starmath/source/SmPanelFactory.cxx
@@ -32,6 +32,7 @@
#include
#include "SmElementsPanel.hxx"
+#include "SmPropertiesPanel.hxx"
namespace
{
@@ -85,7 +86,11 @@ css::uno::Reference SAL_CALL
SmPanelFactory::createUIElemen
std::unique_ptr pPanel;
css::ui::LayoutSize aLayoutSize{ -1, -1, -1 };
-if (ResourceURL.endsWith("/MathElementsPanel"))
+if (ResourceURL.endsWith("/MathPropertiesPanel"))
+{
+pPanel = sm::sidebar::SmPropertiesPanel::Create(*pParent);
+}
+else if (ResourceURL.endsWith("/MathElementsPanel"))
{
pPanel = sm::sidebar::SmElementsPanel::Create(*pParent,
*pBindings);
aLayoutSize = { 300, -1, -1 };
diff --git a/starmath/source/SmPropertiesPanel.cxx
b/starmath/source/SmPropertiesPanel.cxx
new file mode 100644
index ..3ffd25c40e79
--- /dev/null
+++ b/starmath/source/SmPropertiesPanel.cxx
@@ -0,0 +1,88 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #49 from Jambunathan K --- Apropos `moon phases.odt` & co. report, I am using Version: 7.3.4.1 / LibreOffice Community Build ID: 30(Build:1) CPU threads: 4; OS: Linux 5.17; UI render: default; VCL: x11 Locale: en-IN (en_IN); UI: en-US Debian package version: 1:7.3.4~rc1-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - svx/source svx/uiconfig
svx/source/sidebar/possize/PosSizePropertyPanel.cxx | 18 +-
svx/source/sidebar/possize/PosSizePropertyPanel.hxx |6 +++---
svx/uiconfig/ui/sidebarpossize.ui |4 ++--
3 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit d5690e308acb1e2e194e6e96dfcb76d35fabca22
Author: Mike Kaganski
AuthorDate: Tue Apr 26 09:21:24 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:40:59 2022 +0200
[ Edit Chart ] -> [ Edit Object ]
This button was introduced in commit
376cd2ceaeedd12a8050c5acd142cd9b9d5e731a
Author Muhammet Kara
Date Wed Nov 20 15:30:01 2019 +0300
Add Edit Chart button for online's mobile view
It is shown for any kind of OLE object, including Math. So make its text
more neutral.
Possibly it could make sense to construct the name from the OLE object's
proper name in a follow-up.
Change-Id: Ied2e9b10db3bcbfab4328a1f65f812cd52f85004
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133426
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135400
Tested-by: Jenkins CollaboraOffice
diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
index cb309821b824..f172c042ba3e 100644
--- a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
+++ b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
@@ -85,7 +85,7 @@ PosSizePropertyPanel::PosSizePropertyPanel(
mxAlignDispatch(new ToolbarUnoDispatcher(*mxAlignTbx, *m_xBuilder,
rxFrame)),
mxAlignTbx2(m_xBuilder->weld_toolbar("aligntoolbar2")),
mxAlignDispatch2(new ToolbarUnoDispatcher(*mxAlignTbx2, *m_xBuilder,
rxFrame)),
-mxBtnEditChart(m_xBuilder->weld_button("btnEditChart")),
+mxBtnEditOLEObject(m_xBuilder->weld_button("btnEditObject")),
mpView(nullptr),
mlOldWidth(1),
mlOldHeight(1),
@@ -157,7 +157,7 @@ PosSizePropertyPanel::~PosSizePropertyPanel()
mxArrangeDispatch2.reset();
mxArrangeTbx.reset();
mxArrangeTbx2.reset();
-mxBtnEditChart.reset();
+mxBtnEditOLEObject.reset();
maTransfPosXControl.dispose();
maTransfPosYControl.dispose();
@@ -226,7 +226,7 @@ void PosSizePropertyPanel::Initialize()
pDrawingArea->set_size_request(aSize.Width(), aSize.Height());
mxCtrlDial->Init(aSize);
-mxBtnEditChart->connect_clicked( LINK( this, PosSizePropertyPanel,
ClickChartEditHdl ) );
+mxBtnEditOLEObject->connect_clicked( LINK( this, PosSizePropertyPanel,
ClickObjectEditHdl ) );
SfxViewShell* pCurSh = SfxViewShell::Current();
if ( pCurSh )
@@ -273,7 +273,7 @@ void PosSizePropertyPanel::HandleContextChange(
bool bShowPosition = false;
bool bShowAngle = false;
bool bShowFlip = false;
-bool bShowEditChart = false;
+bool bShowEditObject = false;
bool bShowArrangeTbx2 = false;
switch (maContext.GetCombinedContext_DI())
@@ -302,13 +302,13 @@ void PosSizePropertyPanel::HandleContextChange(
break;
case CombinedEnumContext(Application::WriterVariants, Context::OLE):
-bShowEditChart = true;
+bShowEditObject = true;
break;
case CombinedEnumContext(Application::Calc, Context::OLE):
case CombinedEnumContext(Application::DrawImpress, Context::OLE):
bShowPosition = true;
-bShowEditChart = true;
+bShowEditObject = true;
break;
case CombinedEnumContext(Application::Calc, Context::Chart):
@@ -338,8 +338,8 @@ void PosSizePropertyPanel::HandleContextChange(
mxFtFlip->set_visible(bShowFlip);
mxFlipTbx->set_visible(bShowFlip);
-// Edit Chart
-mxBtnEditChart->set_visible(bShowEditChart);
+// Edit Object
+mxBtnEditOLEObject->set_visible(bShowEditObject);
// Arrange tool bar 2
mxArrangeTbx2->set_visible(bShowArrangeTbx2);
@@ -452,7 +452,7 @@ IMPL_LINK_NOARG( PosSizePropertyPanel, RotationHdl,
DialControl&, void )
SfxCallMode::RECORD, { , , });
}
-IMPL_STATIC_LINK_NOARG( PosSizePropertyPanel, ClickChartEditHdl,
weld::Button&, void )
+IMPL_STATIC_LINK_NOARG( PosSizePropertyPanel, ClickObjectEditHdl,
weld::Button&, void )
{
SfxViewShell* pCurSh = SfxViewShell::Current();
if ( pCurSh)
diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
index 088290557d9a..ede3d3e44315 100644
--- a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
+++ b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
@@ -114,8 +114,8 @@ private:
std::unique_ptr mxAlignTbx2;
std::unique_ptr mxAlignDispatch2;
-//edit charts button for online's mobile view
-std::unique_ptr mxBtnEditChart;
+//edit objects button for online's mobile view
+std::unique_ptr mxBtnEditOLEObject;
// Internal variables
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #48 from Jambunathan K --- Created attachment 180577 --> https://bugs.documentfoundation.org/attachment.cgi?id=180577=edit moon-phases.pdf: `moon-phases.odt` exported to `PDF` with `Noto Color Emoji` font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - officecfg/registry starmath/Library_sm.mk starmath/source starmath/uiconfig starmath/UIConfig_smath.mk starmath/util
officecfg/registry/data/org/openoffice/Office/UI/Factories.xcu | 14 officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu | 49 +++ starmath/Library_sm.mk |2 starmath/UIConfig_smath.mk |1 starmath/source/SmElementsPanel.cxx| 105 ++ starmath/source/SmElementsPanel.hxx| 59 +++ starmath/source/SmPanelFactory.cxx | 136 starmath/uiconfig/smath/ui/sidebarelements_math.ui | 154 ++ starmath/util/sm.component |4 9 files changed, 524 insertions(+) New commits: commit e5b1edebd722d724322d9cde90f4319c82571f16 Author: Mike Kaganski AuthorDate: Mon Apr 25 18:24:43 2022 +0300 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:35:28 2022 +0200 tdf#125931: Add Elements deck and Elements panel to Math's sidebar Change-Id: Ie04a5dc48de38f318f0ddb42efc42cea022dc62c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133393 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135399 Tested-by: Jenkins CollaboraOffice diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Factories.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Factories.xcu index c26b96ec287b..20cb7d0b52ac 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Factories.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Factories.xcu @@ -146,6 +146,20 @@ org.libreoffice.comp.chart2.sidebar.ChartPanelFactory + + + toolpanel + + + SmPanelFactory + + + + + + org.libreoffice.comp.Math.sidebar.SmPanelFactory + + diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu index 086c745c9d82..a6e268628941 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu @@ -298,6 +298,26 @@ + + + Elements + + + ElementsDeck + + + private:graphicrepository/sfx2/res/symphony/sidebar-gallery-large.png + + + +Math, any, visible; + + + + 300 + + + @@ -742,6 +762,35 @@ + + + Elements + + + true + + + MathElementsPanel + + + ElementsDeck + + + +Math, any, visible; + + + + private:resource/toolpanel/SmPanelFactory/MathElementsPanel + + + 100 + + + false + + + Position and Size diff --git a/starmath/Library_sm.mk b/starmath/Library_sm.mk index 613a8cbdb7cd..91d62caed114 100644 --- a/starmath/Library_sm.mk +++ b/starmath/Library_sm.mk @@ -67,6 +67,8 @@ $(eval $(call gb_Library_add_exception_objects,sm,\ starmath/source/AccessibleSmElement \ starmath/source/AccessibleSmElementsControl \ starmath/source/ElementsDockingWindow \ +starmath/source/SmElementsPanel \ +starmath/source/SmPanelFactory \ starmath/source/accessibility \ starmath/source/action \ starmath/source/caret \ diff --git a/starmath/UIConfig_smath.mk b/starmath/UIConfig_smath.mk index 2a39af9e4a6d..45b12819731a 100644 --- a/starmath/UIConfig_smath.mk +++ b/starmath/UIConfig_smath.mk @@ -39,6 +39,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/smath,\ starmath/uiconfig/smath/ui/mathwindow \ starmath/uiconfig/smath/ui/printeroptions \ starmath/uiconfig/smath/ui/savedefaultsdialog \ + starmath/uiconfig/smath/ui/sidebarelements_math \ starmath/uiconfig/smath/ui/smathsettings \ starmath/uiconfig/smath/ui/spacingdialog \ starmath/uiconfig/smath/ui/symdefinedialog \ diff --git a/starmath/source/SmElementsPanel.cxx b/starmath/source/SmElementsPanel.cxx new file mode 100644 index ..a4c8d7c6d883 --- /dev/null +++ b/starmath/source/SmElementsPanel.cxx @@ -0,0 +1,105 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - include/vcl officecfg/registry sfx2/source starmath/source starmath/uiconfig vcl/source
include/vcl/EnumContext.hxx|1
officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs |4 -
sfx2/source/sidebar/ResourceManager.cxx|2
starmath/source/smdll.cxx |3
starmath/source/view.cxx | 36
++
starmath/uiconfig/smath/menubar/menubar.xml|1
vcl/source/window/EnumContext.cxx |1
7 files changed, 47 insertions(+), 1 deletion(-)
New commits:
commit 5ebb6747ad577618cb1f9f3632474eaa0d27a7fe
Author: Mike Kaganski
AuthorDate: Fri Apr 22 20:25:43 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:34:41 2022 +0200
tdf#125931: Enable sidebar in Math
No panels yet, only one default deck (PropertyDeck). It is needed
to have the uniform default deck like in all other modules (see
commit c09f59eb6173a4a53a2d40ed80aebed18e3882ac); the panels for
formula properties might appear later.
Change-Id: If1785dc780111fe496638418f43e7b90a250ffce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/14
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135398
Tested-by: Jenkins CollaboraOffice
diff --git a/include/vcl/EnumContext.hxx b/include/vcl/EnumContext.hxx
index dec5711b6ba5..9d82e72adc9d 100644
--- a/include/vcl/EnumContext.hxx
+++ b/include/vcl/EnumContext.hxx
@@ -83,6 +83,7 @@ public:
Grid,
HandoutPage,
MasterPage,
+Math,
Media,
MultiObject,
NotesPage,
diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
index 10e57ac4fb64..4b5d13b63c5f 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
@@ -87,6 +87,7 @@
com.sun.star.presentation.PresentationDocument
com.sun.star.drawing.DrawingDocument
com.sun.star.chart2.ChartDocument
+ com.sun.star.formula.FormulaProperties
Recognized shortcuts:
Writer
@@ -94,6 +95,7 @@
Impress
Draw
Chart
+ Math
Shortcuts for multiple applications:
DrawImpress
@@ -109,7 +111,7 @@
2 Context name
Know context names are 3DObject, Annotation, Auditing, Axis,
Cell, Chart, ChartElements, Draw,
DrawFontwork, DrawLine, DrawPage, DrawText, EditCell, ErrorBar,
Form, Frame, Graphic, Grid,
- HandoutPage, MasterPage, Media, MultiObject, NotesPage, OLE,
OutlineText, Pivot, Printpreview,
+ HandoutPage, MasterPage, Math, Media, MultiObject, NotesPage,
OLE, OutlineText, Pivot, Printpreview,
Series, SlidesorterPage, Table, Text, TextObject, Trendline,
Sparkline
Special values:
diff --git a/sfx2/source/sidebar/ResourceManager.cxx
b/sfx2/source/sidebar/ResourceManager.cxx
index 664d6c42b479..7bdae537b088 100644
--- a/sfx2/source/sidebar/ResourceManager.cxx
+++ b/sfx2/source/sidebar/ResourceManager.cxx
@@ -556,6 +556,8 @@ void ResourceManager::ReadContextList (
aApplications.push_back(vcl::EnumContext::Application::Impress);
else if (sApplicationName == "Chart")
aApplications.push_back(vcl::EnumContext::Application::Chart);
+else if (sApplicationName == "Math")
+
aApplications.push_back(vcl::EnumContext::Application::Formula);
else if (sApplicationName == "DrawImpress")
{
// A special case among the special names: it is
diff --git a/starmath/source/smdll.cxx b/starmath/source/smdll.cxx
index 7ef93bfa0f3c..f10e9d9db3f0 100644
--- a/starmath/source/smdll.cxx
+++ b/starmath/source/smdll.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
@@ -69,6 +70,8 @@ namespace
SvxModifyControl::RegisterControl(SID_TEXTSTATUS, pModule);
XmlSecStatusBarControl::RegisterControl(SID_SIGNATURE, pModule);
+sfx2::sidebar::SidebarChildWindow::RegisterChildWindow(false, pModule);
+
SmCmdBoxWrapper::RegisterChildWindow(true);
SmElementsDockingWindowWrapper::RegisterChildWindow(true);
}
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 62e8b01d5348..002a2321c1d1 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -41,6 +41,8 @@
#include
#include
#include
+#include
+#include
#include
#include
#include
@@ -49,6 +51,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1024,6 +1027,8 @@ void SmViewShell::InitInterface_Impl()
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - officecfg/registry
officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit 7cb4ca195baff69be13154ef042498ab7f51d2cb Author: Mike Kaganski AuthorDate: Fri Apr 22 12:49:46 2022 +0100 Commit: Mike Kaganski CommitDate: Sun Jun 5 07:34:23 2022 +0200 Update context names to match EnumContext::ProvideContextContainers Change-Id: Id9bb806ba526a7557cda91ebdeb649578e64517c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133281 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135397 Tested-by: Jenkins CollaboraOffice diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs index 1eb7007d3008..10e57ac4fb64 100644 --- a/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs @@ -107,13 +107,15 @@ none 2 Context name - Know context names are 3DObject, Annotation, Auditing, Axis, Cell, Chart, Draw, DrawPage, DrawText, - EditCell, ErrorBar, Form, Frame, Graphic, HandoutPage, MasterPage, Media, Multiobj, OLE, OutlineText, - Pivot, Series, SlidesorterPage, Table, Text, TextObject, Trendline, Sparkline - default + Know context names are 3DObject, Annotation, Auditing, Axis, Cell, Chart, ChartElements, Draw, + DrawFontwork, DrawLine, DrawPage, DrawText, EditCell, ErrorBar, Form, Frame, Graphic, Grid, + HandoutPage, MasterPage, Media, MultiObject, NotesPage, OLE, OutlineText, Pivot, Printpreview, + Series, SlidesorterPage, Table, Text, TextObject, Trendline, Sparkline Special values: any + default + empty 3 Panel state. One of visible Panel is initially visible and expanded
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - chart2/source framework/source
chart2/source/controller/main/ChartController.cxx | 21 ++--
framework/source/services/ContextChangeEventMultiplexer.cxx | 17 -
2 files changed, 11 insertions(+), 27 deletions(-)
New commits:
commit f66b5c4bdf7d285d8eae6231b9dc906eca065072
Author: Mike Kaganski
AuthorDate: Fri Apr 22 16:17:09 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:34:07 2022 +0200
Drop a bit more special-casing for Chart's sidebar property deck
Introduced in commit 2d01ed9e8be543460e41e009fa992103a7c8d4c0
Author Muhammet Kara
Date Mon Nov 25 21:55:31 2019 +0300
tdf#94288: Show chart props sidebar on activation
The problem was that ChartController::attachFrame, that called
SelectionChangeHandler::selectionChanged notification, did that
*prior* to setting its m_xFrame - and the notification failed
in ContextChangeEventMultiplexer::NotifyContextChange, that
checks the frame first. That prevented the proper context (with
correct application and context names) to arrive to listeners,
and the sidebar didn't update properly.
Changing the order of the calls should fix the original problem.
Change-Id: I9da8465af2ee4ed1f8eabed1c65d1c318f81a3f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133326
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135396
Tested-by: Jenkins CollaboraOffice
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index 19c314da2635..f50fab660acf 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -385,6 +385,17 @@ void SAL_CALL ChartController::attachFrame(
if( impl_isDisposedOrSuspended() ) //@todo? allow attaching the frame
while suspended?
return; //behave passive if already disposed or suspended
+if(m_xFrame.is()) //what happens, if we do have a Frame already??
+{
+//@todo? throw exception?
+OSL_FAIL( "there is already a frame attached to the controller" );
+return;
+}
+
+//--attach frame
+m_xFrame = xFrame; //the frameloader is responsible to call
xFrame->setComponent
+
+// Only notify after setting the frame, otherwise notification will fail
mpSelectionChangeHandler->Connect();
uno::Reference xSidebar = getSidebarFromModel(getModel());
@@ -398,16 +409,6 @@ void SAL_CALL ChartController::attachFrame(
mpSelectionChangeHandler->selectionChanged(aEvent);
}
-if(m_xFrame.is()) //what happens, if we do have a Frame already??
-{
-//@todo? throw exception?
-OSL_FAIL( "there is already a frame attached to the controller" );
-return;
-}
-
-//--attach frame
-m_xFrame = xFrame; //the frameloader is responsible to call
xFrame->setComponent
-
//add as disposelistener to the frame (due to persistent reference) ??...:
//the frame is considered to be owner of this controller and will live
longer than we do
diff --git a/framework/source/services/ContextChangeEventMultiplexer.cxx
b/framework/source/services/ContextChangeEventMultiplexer.cxx
index 0dea0823c52b..887fa946856a 100644
--- a/framework/source/services/ContextChangeEventMultiplexer.cxx
+++ b/framework/source/services/ContextChangeEventMultiplexer.cxx
@@ -162,23 +162,6 @@ void SAL_CALL
ContextChangeEventMultiplexer::addContextChangeEventListener (
if (!(rxEventFocus.is() && pFocusDescriptor!=nullptr))
return;
-if (pFocusDescriptor->msCurrentApplicationName.isEmpty() &&
pFocusDescriptor->msCurrentContextName.isEmpty()
-&& rxEventFocus.is())
-{
-Reference< lang::XServiceInfo > xServInfo( rxEventFocus,
uno::UNO_QUERY );
-if( xServInfo.is() && xServInfo->getImplementationName() ==
"com.sun.star.comp.chart2.ChartController")
-{
-css::ui::ContextChangeEventObject aEvent (
-rxEventFocus,
-"com.sun.star.chart2.ChartDocument",
-"Chart");
-rxListener->notifyContextChangeEvent(aEvent);
-
-return;
-}
-
-}
-
css::ui::ContextChangeEventObject aEvent (
nullptr,
pFocusDescriptor->msCurrentApplicationName,
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - desktop/source include/sfx2 officecfg/registry sfx2/source
desktop/source/lib/init.cxx | 11 --
include/sfx2/sidebar/SidebarController.hxx |1
officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu | 46 +++
sfx2/source/sidebar/Context.cxx |9 --
sfx2/source/sidebar/SidebarController.cxx|4
5 files changed, 19 insertions(+), 52 deletions(-)
New commits:
commit 2493e90ef3b955a06c80ecb5e5f6b4173b5b71ef
Author: Mike Kaganski
AuthorDate: Thu Apr 21 15:14:49 2022 +0300
Commit: Mike Kaganski
CommitDate: Sun Jun 5 07:33:48 2022 +0200
Drop special-casing for Chart's sidebar property deck
Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a
Author Markus Mohrhard
Date Thu Jul 09 20:39:06 2015 +0200
big step towards real chart sidebar
later in commit da57c32c5cb27eee38e32d10232b31d459c399df
Author Tor Lillqvist
Date Fri Feb 28 17:02:30 2020 +0200
tdf#130348: Add special case for ChartDeck, too
and then in commit ff23d87cb00388095a94b90e061564fc179e1823
Author Mert Tumer
Date Fri May 08 17:23:12 2020 +0300
mobile: fix calc chart wizard properties is not shown
The normal PropertyDeck can host all the chart-specific panels,
and the other decks that had "all" application context, but are
not needed for charts, have their context fixed.
This cleanup is needed for a following introduction of sidebar
in Math.
Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135395
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index db0fc5145fe9..3a72be64a139 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -877,22 +877,13 @@ void setupSidebar(std::u16string_view sidebarDeckId = u"")
if (!pDockingWin)
return;
-OUString currentDeckId =
pDockingWin->GetSidebarController()->GetCurrentDeckId();
-
-// check if it is the chart deck id, if it is, don't switch to default
deck
-bool switchToDefault = true;
-
-if (currentDeckId == "ChartDeck")
-switchToDefault = false;
-
if (!sidebarDeckId.empty())
{
pDockingWin->GetSidebarController()->SwitchToDeck(sidebarDeckId);
}
else
{
-if (switchToDefault)
-pDockingWin->GetSidebarController()->SwitchToDefaultDeck();
+pDockingWin->GetSidebarController()->SwitchToDefaultDeck();
}
pDockingWin->SyncUpdate();
diff --git a/include/sfx2/sidebar/SidebarController.hxx
b/include/sfx2/sidebar/SidebarController.hxx
index 0a09f993dbad..9aea16754399 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -135,7 +135,6 @@ public:
FocusManager& GetFocusManager() { return maFocusManager;}
ResourceManager* GetResourceManager() { return mpResourceManager.get();}
-auto& GetCurrentDeckId() const { return msCurrentDeckId; }
// std::unique_ptr GetResourceManager() { return
mpResourceManager;}
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
index 69ade7054af8..086c745c9d82 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Sidebar.xcu
@@ -114,7 +114,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -194,7 +196,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -214,7 +218,9 @@
-any, any, visible ;
+Calc, any, visible;
+DrawImpress,any, visible;
+WriterVariants, any, visible;
@@ -292,26 +298,6 @@
-
-
- Properties
-
-
- ChartDeck
-
-
-
private:graphicrepository/sfx2/res/symphony/sidebar-property-large.png
-
-
-
-Chart, any, visible ;
-
-
-
- 10
-
-
-
@@ -1649,7 +1635,7 @@
ChartElementsPanel
- ChartDeck
+ PropertyDeck
@@ -1675,7 +1661,7 @@
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #47 from Jambunathan K --- Created attachment 180576 --> https://bugs.documentfoundation.org/attachment.cgi?id=180576=edit moon-phases.odt: With `Noto Color Emoji` font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #46 from Jambunathan K --- Created attachment 180575 --> https://bugs.documentfoundation.org/attachment.cgi?id=180575=edit Moon symbols: `fc-list` on my Debian Unstabe (as recent as June 1, 2022) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #45 from Jambunathan K --- Created attachment 180574 --> https://bugs.documentfoundation.org/attachment.cgi?id=180574=edit Moon Symbols renders well with `Symbola` -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #44 from Jambunathan K --- Created attachment 180573 --> https://bugs.documentfoundation.org/attachment.cgi?id=180573=edit Moon Symbols: Translate `Noto Color Emoji` to `Symbola` -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #43 from Jambunathan K --- Created attachment 180572 --> https://bugs.documentfoundation.org/attachment.cgi?id=180572=edit Moon symbols + Noto Color Emoji doesn't render at all on PDF side -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129523] FILESAVE Emojis not exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=129523 --- Comment #42 from Jambunathan K --- One more upvote from my side ... I had trouble with the moon symbols. ``` |---+-+-| | *Phase* | *UCS Codepoint* | *Glyph* | |---+-+-| | New moon | =U+1F311= | | | First quarter | =U+1F313= | | | Full moon | =U+1F315= | | | Last quarter | =U+1F317= | | |---+-+-| | | | | ``` LibreOffice was picking up `Noto Color Emoji` on my machine. Even though the UI was picking up the Colored Emojis, the PDF export part wasn't. I had to remap `Noto Color Emoji` to `Symbola` font. (I am on Debian Unstable, and I couldn't find the `Emoji One Color` on the package repos) See https://emacs.stackexchange.com/a/72035/31220. I am also attaching the screenshots. -- I don't know much about fonts or if they expose their "capabilities" in useful ways. If fonts do advertise their capabilities, and LibreOffice's PDF printer doesn't handle those capabilities it should automatically switch to a different "functional" font. That is, LibreOffice should do a "functional deprecation" instead of a "dysfunctional" export. In my case, I would have appreciated if LibreOffice PDF export deprecated itself to a "works for me" black and white `Symbola` font instead of the "dysfunctional / not-all-acceptable" `Noto Color Emoji` font. -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
5 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 1504667: Resource leaks (CTOR_DTOR_LEAK)
*** CID 1504667: Resource leaks (CTOR_DTOR_LEAK)
/usr/include/c++/10/bits/hashtable.h: 534 in std::_Hashtable>, TranslateId,
std::basic_string_view>, TranslateId> *,
unsigned long>>, std::allocator>, TranslateId,
std::basic_string_view>, TranslateId> *,
unsigned long>>>, std::__detail::_Select1st, std::equal_to,
::TranslateId_hash, std::__detail::_Mod_range_hashing,
std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy,
std::__detail::_Hashtable_traits<(bool)1, (bool)0,
(bool)1>>::_Hashtable(std::initializer_list>, TranslateId, std::basic_string_view>, TranslateId> *, unsigned long>>>, unsigned long,
const ::TranslateId_hash &, const std::equal_to &, const
std::allocator>, TranslateId,
std::basic_string_view>, TranslateId> *,
unsigned long>>>&)()
528
529 _Hashtable(initializer_list __l,
530 size_type __bkt_count_hint = 0,
531 const _H1& __hf = _H1(),
532 const key_equal& __eql = key_equal(),
533 const allocator_type& __a = allocator_type())
>>> CID 1504667: Resource leaks (CTOR_DTOR_LEAK)
>>> Calling allocation function "_Hashtable".
534 : _Hashtable(__l.begin(), __l.end(), __bkt_count_hint,
535__hf, _H2(), _Hash(), __eql,
536__key_extract(), __a)
537 { }
538
539 _Hashtable&
** CID 1504666: Null pointer dereferences (NULL_RETURNS)
/dbaccess/source/ui/dlg/dbwizsetup.cxx: 120 in
dbaui::ODbTypeWizDialogSetup::ODbTypeWizDialogSetup(weld::Window *, const
SfxItemSet *, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Any &)()
*** CID 1504666: Null pointer dereferences (NULL_RETURNS)
/dbaccess/source/ui/dlg/dbwizsetup.cxx: 120 in
dbaui::ODbTypeWizDialogSetup::ODbTypeWizDialogSetup(weld::Window *, const
SfxItemSet *, const
com::sun::star::uno::Reference &, const
com::sun::star::uno::Any &)()
114 , m_pGeneralPage( nullptr )
115 , m_pMySQLIntroPage( nullptr )
116 , m_pFinalPage( nullptr )
117 {
118 // no local resources needed anymore
119 // extract the datasource type collection from the item set
>>> CID 1504666: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing "_pItems->GetItem(5, true)", which is known to be
>>> "nullptr".
120 const DbuTypeCollectionItem& rCollectionItem = dynamic_cast(*_pItems->GetItem(DSID_TYPECOLLECTION));
121 m_pCollection = rCollectionItem.getCollection();
122
123 assert(m_pCollection &&
"ODbTypeWizDialogSetup::ODbTypeWizDialogSetup : really need a DSN type
collection !");
124
125 m_pImpl.reset(new ODbDataSourceAdministrationHelper(_rxORB,
m_xAssistant.get(), _pParent, this));
** CID 1504665: Performance inefficiencies (PASS_BY_VALUE)
/cppcanvas/source/mtfrenderer/polypolyaction.cxx: 258 in
cppcanvas::internalTexturedPolyPolyAction::TexturedPolyPolyAction(const
basegfx::B2DPolyPolygon &, const std::shared_ptr &, const
cppcanvas::internal::OutDevState &, com::sun::star::rendering::Texture)()
*** CID 1504665: Performance inefficiencies (PASS_BY_VALUE)
/cppcanvas/source/mtfrenderer/polypolyaction.cxx: 258 in
cppcanvas::internalTexturedPolyPolyAction::TexturedPolyPolyAction(const
basegfx::B2DPolyPolygon &, const std::shared_ptr &, const
cppcanvas::internal::OutDevState &, com::sun::star::rendering::Texture)()
252 const rendering::Texture
maTexture;
253 };
254
255 TexturedPolyPolyAction::TexturedPolyPolyAction( const
::basegfx::B2DPolyPolygon& rPolyPoly,
256 const
CanvasSharedPtr& rCanvas,
257 const
OutDevState& rState,
>>> CID 1504665: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aTexture of type "com::sun::star::rendering::Texture"
>>> (size 136 bytes) by value.
258
rendering::Texture aTexture ) :
259 CachedPrimitiveBase( rCanvas, true ),
[Libreoffice-bugs] [Bug 149111] Crash when attempting to add MP4 file to Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149111 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149224] [LOCALHELP] Bad Help page for database properties wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=149224 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149223] [LOCALHELP] Missing Help page for database connection properties page
https://bugs.documentfoundation.org/show_bug.cgi?id=149223 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149222] [LOCALHELP] Missing Help page for database Relationship dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=149222 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149221] [LOCALHELP] Bad Help page for database connection wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=149221 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149218] [LOCALHELP] Add pivot table formatting Help page
https://bugs.documentfoundation.org/show_bug.cgi?id=149218 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149214] Unicode IVS occupies more space if textgrid is on
https://bugs.documentfoundation.org/show_bug.cgi?id=149214 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149211] Entry for "Object" in General Glossary needs review/clarification
https://bugs.documentfoundation.org/show_bug.cgi?id=149211 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145481] To set font size of a character style in percentage relative to current paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=145481 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145481] To set font size of a character style in percentage relative to current paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=145481 --- Comment #3 from QA Administrators --- Dear John, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146071] Problem in Pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=146071 --- Comment #2 from QA Administrators --- Dear Scott, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143436] Exported PDF doesn't contain table header tags
https://bugs.documentfoundation.org/show_bug.cgi?id=143436 --- Comment #7 from QA Administrators --- Dear Martin Josefik, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143207] Every time I open a .doc file it says it needs to be recovered
https://bugs.documentfoundation.org/show_bug.cgi?id=143207 --- Comment #5 from QA Administrators --- Dear Chas B, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143191] Cannot open hyperlink to another sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=143191 --- Comment #8 from QA Administrators --- Dear Chuyen Nguyen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142804] General I/O error when attempting to export soft edge rectangles to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=142804 --- Comment #7 from QA Administrators --- Dear Bogdan Stăncescu, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142626] Infinity save
https://bugs.documentfoundation.org/show_bug.cgi?id=142626 --- Comment #5 from QA Administrators --- Dear Marat Nagayev, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 32484] Allow anchor settings in frame styles
https://bugs.documentfoundation.org/show_bug.cgi?id=32484 --- Comment #40 from John Kaufmann --- (In reply to Olivier Hallot from comment #39) > ... > As (advanced) user, I'll create another anchoring option to "Inherit from > applied frame style" on the frame properties dialog. Does that make sense? I don't know. Aren't 'all' properties inherited from the applied style, except as modified by direct formatting? [Am I understanding your point correctly?] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149456] No le permite al usuario la modificación de sus datos personales
https://bugs.documentfoundation.org/show_bug.cgi?id=149456 LeroyG changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from LeroyG --- Por favor, presenta tu problema en el sitio de preguntas de LibreOffice —https://ask.libreoffice.org/c/spanish/10—, para que puedan orientarte. Gracias. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149460 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149460 [Bug 149460] Lines and Shadows in Shapes are positioned outside their selected region (to Entire Paragraph area or Paragraph Text area) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149460] Lines and Shadows in Shapes are positioned outside their selected region (to Entire Paragraph area or Paragraph Text area)
https://bugs.documentfoundation.org/show_bug.cgi?id=149460 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||108741 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149460] Lines and Shadows in Shapes are positioned outside their selected region (to Entire Paragraph area or Paragraph Text area)
https://bugs.documentfoundation.org/show_bug.cgi?id=149460 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Blocks||108741 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149460] New: Lines and Shadows in Shapes are positioned outside their selected region (to Entire Paragraph area or Paragraph Text area)
https://bugs.documentfoundation.org/show_bug.cgi?id=149460 Bug ID: 149460 Summary: Lines and Shadows in Shapes are positioned outside their selected region (to Entire Paragraph area or Paragraph Text area) Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Created attachment 180571 --> https://bugs.documentfoundation.org/attachment.cgi?id=180571=edit Examples of lines and shadows going past positioning region The attachment demonstrates the problem. Basic issue. For shapes, it is possible to add a "line" or a "shadow" For images, it is possible to add a "border" or a "shadow" Actual: When positioning shapes and images, which are anchored "to paragraph" and positioned horizontally with Horizontal: Left to: Entire Paragraph Area (or Paragraph Text Area), then line and shadow for shape are positioned outside of the Entire Paragraph Area/Paragraph Text Area while for images, they are "inside". Expected: Images and Shapes behave the same. Expected: Shapes would follow the behavior of Images. Question: Is this difference in behavior by design, in which case this ticket is a documentation report, or is this an implementation bug? Additional information: The attachment only looked at "Left" and "Entire Paragraph Area" and "Paragraph Text Area". There are many other variations that could be checked, but there are enough examples in the attachment to show that there is an issue. Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134498] SHAPES: Line disappears if deleting text in the anchored paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134498 --- Comment #13 from sdc.bla...@youmail.dk --- (In reply to Pasi from comment #8) > And another bug from the same example file. CTRL+A behaves erratically, in > my opinion. Please file another ticket for this issue. The tradition with Bugzilla is to file one problem per ticket, where the original report here was about "moving lines", which I believe is NOTABUG. (similarly the problem in example 1 reflects another ticket which was resolved as WONTFIX). Before filing a new ticket, you might want to search a little in Bugzilla, because it is possible that there is already a report about Ctrl+A with a mixture of shapes, tables, and text not copying everything. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134498] SHAPES: Line disappears if deleting text in the anchored paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134498 --- Comment #12 from sdc.bla...@youmail.dk --- (In reply to Dieter from comment #10) > Shapes are anchored to paragraph in highlighted table cell. If you remove > all characters of the paragraph, shapes are removed. Isn't this case bug 146445? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134498] SHAPES: Line disappears if deleting text in the anchored paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134498 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #11 from sdc.bla...@youmail.dk --- (In reply to Pasi from comment #6) > Example 2: Not a bug. In this example, the horizontal line is anchored to a paragraph in the table. When you add text to a row, the position of the anchor in the table is moved down, and the horizontal correctly moves with the anchor. If you, for example, anchor that horizontal line "to page", then adding text to the table will not move the line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149111] Crash when attempting to add MP4 file to Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=149111 Scott Clewell changed: What|Removed |Added Ever confirmed|0 |1 CC||sclew...@protonmail.com Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Scott Clewell --- Hello Applejack01, Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149459] [FORMATTING] Tab key do not select shapes by turn if they are copy-pasted
https://bugs.documentfoundation.org/show_bug.cgi?id=149459 --- Comment #1 from LeroyG --- Created attachment 180570 --> https://bugs.documentfoundation.org/attachment.cgi?id=180570=edit Second test file. If in step 2, do you move the lines with mouse, tab key jumps to some lines but skip some others. Tested with four and six lines. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149459] New: [FORMATTING] Tab key do not select shapes by turn if they are copy-pasted
https://bugs.documentfoundation.org/show_bug.cgi?id=149459 Bug ID: 149459 Summary: [FORMATTING] Tab key do not select shapes by turn if they are copy-pasted Product: LibreOffice Version: 7.2.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: iavs.le...@gmail.com Created attachment 180569 --> https://bugs.documentfoundation.org/attachment.cgi?id=180569=edit File to test. 1. Created a line in a new Writer document. 2. Copy, paste, and move to the right with arrow key. 3. Select one line. 4. Press tab key. 5. Move the first line to the right, 6. Press tab key. 7. Select the (now) middle line. 8. Press tab key. Actual behavior: After 4: Selection jumps from whichever shape to the original (leftmost) line. After 6: Selection jumps and stay in the leftmost line. After 8: Selection will not jump. Expected behavior: Selection jumps from one shape to other, in insert order. Additional info: If do you create three lines (without copy), tab key will select all of them by turn. Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: es-MX (es_ES); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149458] New: Adding Caption to image change image anchoring
https://bugs.documentfoundation.org/show_bug.cgi?id=149458 Bug ID: 149458 Summary: Adding Caption to image change image anchoring Product: LibreOffice Version: 7.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org When adding a caption to a inserted image, the image anchor changes from "As Character" to "To Paragraph". Step to reproduce: 1) On a blank document, insert an image (Insert - Image). Image is inserted anchored "as character" per default setting. 2) select image, right-click, select Insert caption. Fill caption data. Click OK. Actual results: Caption frame is added around the image and caption text. Image anchor changes "to paragraph". Expected results: Caption frame is added around the image and caption text. Image anchor is kept "as character". In other words, anchoring should not change. Version: 7.3.3.2 / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (pt_BR.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148287] Scrolling not possible when mouse pointer over row/column index
https://bugs.documentfoundation.org/show_bug.cgi?id=148287 --- Comment #6 from rot_...@yahoo.de --- I created an annotated screenshot (see attachments) to try to clarify the problem. This issue is about the orange areas. It might be that the behavior to not support scrolling in those areas is intentional. However, as originally stated, the current behavior seems counter-intuitive as the index moves together with the rest of the sheet when scrolling is performed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148287] Scrolling not possible when mouse pointer over row/column index
https://bugs.documentfoundation.org/show_bug.cgi?id=148287 --- Comment #5 from rot_...@yahoo.de --- Created attachment 180568 --> https://bugs.documentfoundation.org/attachment.cgi?id=180568=edit Annotated Screenshot to clarify issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124006] EDITING: copy & paste from AOO to LO or between two LO instances fails for formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=124006 Aron Budea changed: What|Removed |Added Summary|EDITING: copy & paste from |EDITING: copy & paste from |AOO to LO fails for |AOO to LO or between two LO |formula's |instances fails for ||formulas CC||aron.bu...@gmail.com --- Comment #7 from Aron Budea --- (In reply to raal from comment #1) > Works for me - copy from 6.3 to 6.0.7.3 and vice versa Seems Windows-specific. (In reply to Xisco Faulí from comment #4) > I don't think there are many users having different instances of LibreOffice > installed at the same time. Let's change the summary to a more realistic > scenario... Maybe have both? It's important detail that not only AOO -> LO copy-pasting is affacted, but LO -> LO as well, if for no one else, then to the person who picks up this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 124006] EDITING: copy & paste from AOO to LO fails for formula's
https://bugs.documentfoundation.org/show_bug.cgi?id=124006 Aron Budea changed: What|Removed |Added CC||saywel...@gmail.com --- Comment #6 from Aron Budea --- *** Bug 148590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148590] Editing: Formulas pasted as numbers between different versions of Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=148590 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||aron.bu...@gmail.com --- Comment #2 from Aron Budea --- I'd say this is a duplicate of bug 124006. *** This bug has been marked as a duplicate of bug 124006 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149252] "Margin" -> "Entire Paragraph Area" in "to" for Vertical Positioning and "Paragraph Area" -> "Entire Paragraph Area" in "to" for Horizontal positioning
https://bugs.documentfoundation.org/show_bug.cgi?id=149252 --- Comment #13 from sdc.bla...@youmail.dk --- Created attachment 180567 --> https://bugs.documentfoundation.org/attachment.cgi?id=180567=edit Entire paragraph area table, with proposed explanation Some points: 1. Ok to keep ”Entire” with ”Entire Paragraph Area” for both Horizontal and Vertical - primarily to keep a parallel with: Entire page Page text Area Entire frameFrame text area Entire paragraph area Paragraph text area (alternative is to drop ”Entire” for all, but ”page” and ”frame” alone seem more indefinite). 2. Also ok to keep ”Entire Paragraph Area” label for both Horizontal and Vertical controls – even though they are applied independently, and may have slight differences because they focus separately on horizontal and vertical. Primary reasons: to (a) indicate that the same ”region” (”container”) is being used and (b) avoid introducing even more variation across the entire set of positioning options. 3. Do not need to ”explain” the meaning of ”Entire Paragraph Area” in general. The work flow in the positioning dialog is to position Horizontal to Entire Paragraph Area and position Vertical to Entire Paragraph. These options can be used independently. No requirement that both options must be used at the same time in positioning an object. => sufficient to describe positioning for Entire Paragraph Area for Horizontal alone. Attachment provides a table of different contexts for Entire Paragraph Area for Horizontal. Proposal is to use a table like this to describe Entire Paragraph Area. Rather than trying to find a generic description (and forcing the reader to guess how the description applies in different contexts). It seems better – for documentation – to give an exhaustive list of the contexts. - I do not know if the table is exhaustive, but I tried. - Maybe the three multicolumn contexts (text, section, frame) can/should be collapsed into one entry. - a comparable table would be made for the Vertical option of Entire paragraph area. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149457] Arabic Text Scrambled and Unreadable in PDF Files Opened by LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=149457 Khaldoun changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149457] Arabic Text Scrambled and Unreadable in PDF Files Opened by LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=149457 Khaldoun changed: What|Removed |Added Summary|Arabic Text Scrambled and |Arabic Text Scrambled and |Unreadable in LibreOffice |Unreadable in PDF Files |Draw|Opened by LibreOffice Draw -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149457] Arabic Text Scrambled and Unreadable in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=149457 --- Comment #1 from Khaldoun --- Created attachment 180566 --> https://bugs.documentfoundation.org/attachment.cgi?id=180566=edit PDF Sample File with Arabic text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149457] New: Arabic Text Scrambled and Unreadable in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=149457 Bug ID: 149457 Summary: Arabic Text Scrambled and Unreadable in LibreOffice Draw Product: LibreOffice Version: 7.3.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kni...@gmail.com Description: PDF Documents when opened with LO Draw show the Arabic text scrambled and completely unreadable. The file attached is an example of what shows up in a document with Arabic text content. I tried to open the same document with Adobe Acrobat and it opened perfectly fine. I love LO and I want it to maintain its position as the best office suite out there. The details of my system: Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-AE (en_AE.UTF-8); UI: en-US 7.3.3-3 Calc: threaded The issue is there for V 7.3.3.2 as well. Steps to Reproduce: 1. Save the document attached to this bug report 2. Open the document with LO Draw Actual Results: The Arabic text is scrambled and not readable at all. Expected Results: Arabic text to look normal and be readable. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: - I checked fonts, I have the font used. I tried also to change the font, but still the same issue. - LO Office on Windows and Linus were tried with the same issue. - Even documents created with LO and saved as PDF will have the same issue as well. - It is not only shows the text scrambled and unreadbale, but also if I save the document, it is then scrambled and not readable using any other PDF reader including Adobe Acrobat Reader. - IMPORTANT: The attached document was created by another office suite, then opened as scrambled as described, then it was modified for privacy reasons and saved by LO Draw - like described in previous point. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Aron Budea changed: What|Removed |Added Depends on|148572 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148572 [Bug 148572] UI: Color picker tooltip flickering (macOS) Skia Raster and without Skia (not seen with Vulkan) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148572] UI: Color picker tooltip flickering (macOS) Skia Raster and without Skia (not seen with Vulkan)
https://bugs.documentfoundation.org/show_bug.cgi?id=148572 Aron Budea changed: What|Removed |Added Blocks|42082 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148569] Character highlighting: custom color color picker doesn't look properly with skia raster on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=148569 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||aron.bu...@gmail.com Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #2 from Aron Budea --- Confirmed using LO 7.4 daily build from 06-04 on macOS, with Skia/Raster. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Aron Budea changed: What|Removed |Added Depends on||148572 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148572 [Bug 148572] UI: Color picker tooltip flickering (macOS) Skia Raster and without Skia (not seen with Vulkan) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148572] UI: Color picker tooltip flickering (macOS) Skia Raster and without Skia (not seen with Vulkan)
https://bugs.documentfoundation.org/show_bug.cgi?id=148572 Aron Budea changed: What|Removed |Added Status|UNCONFIRMED |NEW Blocks||42082 Whiteboard| QA:needsComment| Ever confirmed|0 |1 CC||aron.bu...@gmail.com --- Comment #1 from Aron Budea --- Confirmed using LO 7.4 daily build from 06-04 on macOS, with Skia/Raster. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113108] [META] Dialog UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113108 Bug 113108 depends on bug 149242, which changed state. Bug 149242 Summary: "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area" https://bugs.documentfoundation.org/show_bug.cgi?id=149242 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Bug 108741 depends on bug 149242, which changed state. Bug 149242 Summary: "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area" https://bugs.documentfoundation.org/show_bug.cgi?id=149242 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103305] [META] Frame dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103305 Bug 103305 depends on bug 149242, which changed state. Bug 149242 Summary: "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area" https://bugs.documentfoundation.org/show_bug.cgi?id=149242 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 Bug 103270 depends on bug 149242, which changed state. Bug 149242 Summary: "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area" https://bugs.documentfoundation.org/show_bug.cgi?id=149242 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149242] "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area"
https://bugs.documentfoundation.org/show_bug.cgi?id=149242 sdc.bla...@youmail.dk changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #18 from sdc.bla...@youmail.dk --- Note: In relation to 'Left of Paragraph Text Area', if there is no Before Text Indent or no Paragraph left padding in the anchoring paragraph, then this control option will APPEAR like positioning is being made to Left Paragraph Border. (same story for 'Right of Paragraph Text Area' but with non-zero After Text Indent or Paragraph right padding). (maybe that explains the origin of the label, but could not find anything relevant in BZ) Closing as FIXED. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148566] UI: Translation error - Norwegian Bomål in all dialogs with a Close button
https://bugs.documentfoundation.org/show_bug.cgi?id=148566 Aron Budea changed: What|Removed |Added Whiteboard| QA:needsComment| CC||aron.bu...@gmail.com, ||karl.m.ramb...@gmail.com --- Comment #1 from Aron Budea --- Karl, I see you're contributing to Norwegian Bokmål translations, can you please comment on this? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Bug 101912 depends on bug 148941, which changed state. Bug 148941 Summary: Make label of the field for an image's text alternative consistent https://bugs.documentfoundation.org/show_bug.cgi?id=148941 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/frmaddpage.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c1898a4d1b38e0077416a104e2b47573ce207ffa Author: Caolán McNamara AuthorDate: Sat Jun 4 19:30:04 2022 +0100 Commit: Caolán McNamara CommitDate: Sat Jun 4 22:22:29 2022 +0200 Duplicate object ID 'altname-atkobject' Change-Id: I47c488ef5c192d464ef2661c4ff5473e98bb2208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135430 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/frmaddpage.ui b/sw/uiconfig/swriter/ui/frmaddpage.ui index 83b34667aea2..f306f7d1c223 100644 --- a/sw/uiconfig/swriter/ui/frmaddpage.ui +++ b/sw/uiconfig/swriter/ui/frmaddpage.ui @@ -202,7 +202,7 @@ word textbuffer1 - + Enter a longer description of the object, especially if the object is too complex or contains too much detail to be described adequately with the short “Text Alternative.” This text is available for use by assistive technologies. For images, this text is exported with an appropriate tag to HTML and PDF format.
[Libreoffice-bugs] [Bug 49893] FILEOPEN: RTF: Image in header not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=49893 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8558 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148558] FILEOPEN: RTF: graphic is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=148558 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||893 CC||aron.bu...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148549] Calc doesn't show sparklines in XLSX example from bug 91476
https://bugs.documentfoundation.org/show_bug.cgi?id=148549 Aron Budea changed: What|Removed |Added Blocks||108897 CC||aron.bu...@gmail.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108897 [Bug 108897] [META] XLSX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Aron Budea changed: What|Removed |Added Depends on||148549 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148549 [Bug 148549] Calc doesn't show sparklines in XLSX example from bug 91476 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103427 Bug 103427 depends on bug 149304, which changed state. Bug 149304 Summary: Stylist does not show upper/lower case font effects https://bugs.documentfoundation.org/show_bug.cgi?id=149304 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149304] Stylist does not show upper/lower case font effects
https://bugs.documentfoundation.org/show_bug.cgi?id=149304 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149304] Stylist does not show upper/lower case font effects
https://bugs.documentfoundation.org/show_bug.cgi?id=149304 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6aaa3e617523783b98bc68e260a3a7b4912d11b8 tdf#149304 Stylist does not show upper/lower case font effects It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149304] Stylist does not show upper/lower case font effects
https://bugs.documentfoundation.org/show_bug.cgi?id=149304 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/styles/CommonStylePreviewRenderer.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 6aaa3e617523783b98bc68e260a3a7b4912d11b8
Author: Noel Grandin
AuthorDate: Sat Jun 4 18:42:53 2022 +0200
Commit: Noel Grandin
CommitDate: Sat Jun 4 20:33:18 2022 +0200
tdf#149304 Stylist does not show upper/lower case font effects
SvxFont has code to handle these extra features, we just need
to call that
Change-Id: I45691efeeead3ea60ab838eeb081fa5f19a76b90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135428
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index 79f8376b0ae8..7ad9c8697dd1 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -218,7 +218,10 @@ bool CommonStylePreviewRenderer::render(const
tools::Rectangle& aRectangle, Rend
aFontDrawPosition.AdjustY((aRectangle.GetHeight() -
aPixelSize.Height()) / 2 );
}
-mrOutputDev.DrawText(aFontDrawPosition, rText);
+if (m_pFont)
+m_pFont->QuickDrawText( , aFontDrawPosition, rText, 0,
rText.getLength(), {} );
+else
+mrOutputDev.DrawText(aFontDrawPosition, rText);
mrOutputDev.Pop();
[Libreoffice-commits] core.git: vcl/win
vcl/win/window/salframe.cxx | 47
1 file changed, 18 insertions(+), 29 deletions(-)
New commits:
commit 428cc8da98ddb73f8abeaa3bddb555f3bd896a29
Author: Jan-Marek Glogowski
AuthorDate: Fri Jun 3 00:24:24 2022 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 4 20:25:54 2022 +0200
WIN refactor geometry updating
Change-Id: I34e710c022e6362dc2381327eb896610c35bcbf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135425
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 6f3b3ca507e5..2ae47ec57630 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -131,6 +131,22 @@ bool WinSalFrame::mbInReparent = false;
static void UpdateFrameGeometry( HWND hWnd, WinSalFrame* pFrame );
static void SetMaximizedFrameGeometry( HWND hWnd, WinSalFrame* pFrame, RECT*
pParentRect = nullptr );
+static void UpdateGeometry(WinSalFrame* pFrame, RECT& aRect)
+{
+RECT aRect2 = aRect;
+AdjustWindowRectEx(, GetWindowStyle(pFrame->mhWnd),
+ FALSE, GetWindowExStyle(pFrame->mhWnd));
+tools::Long nTopDeco = abs(aRect.top - aRect2.top);
+tools::Long nLeftDeco = abs(aRect.left - aRect2.left);
+tools::Long nBottomDeco = abs(aRect.bottom - aRect2.bottom);
+tools::Long nRightDeco = abs(aRect.right - aRect2.right);
+
+pFrame->maState.mnX = aRect.left + nLeftDeco;
+pFrame->maState.mnY = aRect.top + nTopDeco;
+pFrame->maState.mnWidth = aRect.right - aRect.left - nLeftDeco -
nRightDeco;
+pFrame->maState.mnHeight = aRect.bottom - aRect.top - nTopDeco -
nBottomDeco;
+}
+
static void ImplSaveFrameState( WinSalFrame* pFrame )
{
// save position, size and state for GetWindowState()
@@ -154,42 +170,15 @@ static void ImplSaveFrameState( WinSalFrame* pFrame )
WINDOWPLACEMENT aPlacement;
aPlacement.length = sizeof(aPlacement);
if( GetWindowPlacement( pFrame->mhWnd, ) )
-{
-RECT aRect = aPlacement.rcNormalPosition;
-RECT aRect2 = aRect;
-AdjustWindowRectEx( , GetWindowStyle( pFrame->mhWnd ),
-FALSE, GetWindowExStyle( pFrame->mhWnd )
);
-tools::Long nTopDeco = abs( aRect.top - aRect2.top );
-tools::Long nLeftDeco = abs( aRect.left - aRect2.left );
-tools::Long nBottomDeco = abs( aRect.bottom - aRect2.bottom );
-tools::Long nRightDeco = abs( aRect.right - aRect2.right );
-
-pFrame->maState.mnX = aRect.left + nLeftDeco;
-pFrame->maState.mnY = aRect.top + nTopDeco;
-pFrame->maState.mnWidth = aRect.right - aRect.left -
nLeftDeco - nRightDeco;
-pFrame->maState.mnHeight = aRect.bottom - aRect.top - nTopDeco
- nBottomDeco;
-}
+UpdateGeometry(pFrame, aPlacement.rcNormalPosition);
}
else
{
RECT aRect;
GetWindowRect( pFrame->mhWnd, );
-
-// to be consistent with Unix, the frame state is without(!)
decoration
-RECT aRect2 = aRect;
-AdjustWindowRectEx( , GetWindowStyle( pFrame->mhWnd ),
-FALSE, GetWindowExStyle( pFrame->mhWnd ) );
-tools::Long nTopDeco = abs( aRect.top - aRect2.top );
-tools::Long nLeftDeco = abs( aRect.left - aRect2.left );
-tools::Long nBottomDeco = abs( aRect.bottom - aRect2.bottom );
-tools::Long nRightDeco = abs( aRect.right - aRect2.right );
+UpdateGeometry(pFrame, aRect);
pFrame->maState.mnState &=
~WindowStateState(WindowStateState::Minimized | WindowStateState::Maximized);
-// subtract decoration
-pFrame->maState.mnX = aRect.left+nLeftDeco;
-pFrame->maState.mnY = aRect.top+nTopDeco;
-pFrame->maState.mnWidth =
aRect.right-aRect.left-nLeftDeco-nRightDeco;
-pFrame->maState.mnHeight =
aRect.bottom-aRect.top-nTopDeco-nBottomDeco;
if ( bVisible )
pFrame->mnShowState = SW_SHOWNORMAL;
pFrame->mbRestoreMaximize = false;
[Libreoffice-bugs] [Bug 103460] [META] Master pages deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103460 Bug 103460 depends on bug 114980, which changed state. Bug 114980 Summary: "Preparing preview" for master slides "Recently used" or "Used in this presentation" only updates after switching to another Sidebar deck and back https://bugs.documentfoundation.org/show_bug.cgi?id=114980 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 Bug 91488 depends on bug 114980, which changed state. Bug 114980 Summary: "Preparing preview" for master slides "Recently used" or "Used in this presentation" only updates after switching to another Sidebar deck and back https://bugs.documentfoundation.org/show_bug.cgi?id=114980 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114980] "Preparing preview" for master slides "Recently used" or "Used in this presentation" only updates after switching to another Sidebar deck and back
https://bugs.documentfoundation.org/show_bug.cgi?id=114980 Buovjaga changed: What|Removed |Added Summary|"Preparing preview" for |"Preparing preview" for |master slides "Recently |master slides "Recently |used" or "Used in this |used" or "Used in this |presentation" takes a long |presentation" only updates |time sometimes |after switching to another ||Sidebar deck and back Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #13 from Buovjaga --- Still the same issue, now I noticed it updates immediately after switching between Sidebar decks. Updated summary. Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779 CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/tools
include/tools/gen.hxx | 68 ++
1 file changed, 36 insertions(+), 32 deletions(-)
New commits:
commit 434d471e9b8e54626af332974268ffd8fce4a78e
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 2 22:35:15 2022 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 4 19:30:10 2022 +0200
Rectangle: move inline definition into functions
... and add GetPos() as TopLeft() alias.
Change-Id: Ia2c169d40ed121e829802835011648281f48f585
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135424
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx
index 6d4548065495..20da07cb99af 100644
--- a/include/tools/gen.hxx
+++ b/include/tools/gen.hxx
@@ -495,7 +495,7 @@ public:
constexpr Rectangle( tools::Long nLeft, tools::Long nTop );
constexpr Rectangle( const Point& rLT, const Size& rSize );
-inline constexpr static Rectangle Justify(const Point& rLT, const Point&
rRB);
+constexpr inline static Rectangle Justify(const Point& rLT, const Point&
rRB);
constexpr tools::Long Left() const { return nLeft; }
constexpr tools::Long Right() const { return IsWidthEmpty() ? nLeft :
nRight; }
@@ -531,41 +531,13 @@ public:
inline void SetPos( const Point& rPoint );
voidSetSize( const Size& rSize );
+constexpr Point GetPos() const { return TopLeft(); }
constexpr Size GetSize() const { return { GetWidth(), GetHeight() }; }
/// Returns the difference between right and left, assuming the range is
inclusive.
-constexpr tools::Long GetWidth() const
-{
-tools::Long n = 0;
-
-if (!IsWidthEmpty())
-{
-n = nRight - nLeft;
-if (n < 0)
-n--;
-else
-n++;
-}
-
-return n;
-}
-
+constexpr inline tools::Long GetWidth() const;
/// Returns the difference between bottom and top, assuming the range is
inclusive.
-constexpr tools::Long GetHeight() const
-{
-tools::Long n = 0;
-
-if (!IsHeightEmpty())
-{
-n = nBottom - nTop;
-if (n < 0)
-n--;
-else
-n++;
-}
-
-return n;
-}
+constexpr inline tools::Long GetHeight() const;
tools::Rectangle& Union( const tools::Rectangle& rRect );
tools::Rectangle& Intersection( const tools::Rectangle& rRect );
@@ -691,6 +663,38 @@ inline void tools::Rectangle::SetPos( const Point& rPoint )
SetPosY(rPoint.Y());
}
+constexpr inline tools::Long tools::Rectangle::GetWidth() const
+{
+tools::Long n = 0;
+
+if (!IsWidthEmpty())
+{
+n = nRight - nLeft;
+if (n < 0)
+n--;
+else
+n++;
+}
+
+return n;
+}
+
+constexpr inline tools::Long tools::Rectangle::GetHeight() const
+{
+tools::Long n = 0;
+
+if (!IsHeightEmpty())
+{
+n = nBottom - nTop;
+if (n < 0)
+n--;
+else
+n++;
+}
+
+return n;
+}
+
inline tools::Rectangle tools::Rectangle::GetUnion( const tools::Rectangle&
rRect ) const
{
tools::Rectangle aTmpRect( *this );
[Libreoffice-bugs] [Bug 120883] [META] Hyphenation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120883 László Németh changed: What|Removed |Added Depends on||149420 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149420 [Bug 149420] Add hyphenation zone to layout, UI and ODF export/import -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149420] Add hyphenation zone to layout, UI and ODF export/import
https://bugs.documentfoundation.org/show_bug.cgi?id=149420 László Németh changed: What|Removed |Added Blocks||120883 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120883 [Bug 120883] [META] Hyphenation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149420] Add hyphenation zone to layout, UI and ODF export/import
https://bugs.documentfoundation.org/show_bug.cgi?id=149420 László Németh changed: What|Removed |Added Blocks||149421 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149421 [Bug 149421] import/export DOCX hyphenation zone -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 László Németh changed: What|Removed |Added Depends on||149421 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149421 [Bug 149421] import/export DOCX hyphenation zone -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120883] [META] Hyphenation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120883 László Németh changed: What|Removed |Added Depends on||149421 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149421 [Bug 149421] import/export DOCX hyphenation zone -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149434] MySQL/MariaDB: Database name with dot will be split at first dot, rest will added to table names
https://bugs.documentfoundation.org/show_bug.cgi?id=149434 --- Comment #20 from Robert Großkopf --- Think this isn't a specific MySQL driver problem, because it will appear in ODBC, JDBC and with direct connection. It doesn't appear, for example, in Firebird, because Firebird will only connect to one database and won't show other databases in pane "Tables". It doesn't appear in PostgreSQL, because there is a schema name like "public", which will separate database name and table name. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67573] VIEWING: font replacement causes several fonts shown in one cell
https://bugs.documentfoundation.org/show_bug.cgi?id=67573 Buovjaga changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
