[Libreoffice-bugs] [Bug 149728] LibreOffice 7.3.3 and above: Locally Integrated Menu (LIM) disappears with kf5 and material-decoration theme
https://bugs.documentfoundation.org/show_bug.cgi?id=149728 Michael Weghorn changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #8 from Michael Weghorn --- (In reply to Max from comment #6) > So, it works, but if LO installed from community compiled deb packages in > main system environment, not AppImg That's interesting... If it works with deb packages but not the AppImg, I tend to suggest to close this bug here as WORKSFORME and open a GitHub issue for the script that generates the AppImg instead: https://github.com/antoniofaccioli/libreoffice-appimage What do you think? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 149680, which changed state. Bug 149680 Summary: Hamburger menu in Tabbed Interface does not open in the correct position in kf5 https://bugs.documentfoundation.org/show_bug.cgi?id=149680 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/QtMenu.cxx | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
New commits:
commit ee3976f2c613f9015477ab327996c074e8516f9d
Author: Michael Weghorn
AuthorDate: Fri Jun 24 10:27:04 2022 +0200
Commit: Michael Weghorn
CommitDate: Fri Jul 1 07:28:01 2022 +0200
tdf#149680 qt: Open native popup menu at given position
Calculate the position at which to open the popup
menu from the passed window and rectangle, rather
than always opening the native popup menu at the
cursor position.
The commit message in
commit 1e0b16f8695498e4eea7c2208aabf7e7664ce749
Date: Wed Feb 12 08:07:42 2020 +0100
tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenus
which had implemented native poup menus, already said:
> For now, this always shows the popup menu at cursor position, which
> can be changed by taking the Rectangle passed to
> 'Qt5Menu::ShowNativePopupMenu' into account if there should be any
> need.
Change-Id: If1a44b6d53f3dcd6fa7ceec0738219f11cfc22c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136356
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/qt5/QtMenu.cxx b/vcl/qt5/QtMenu.cxx
index 5a4d3e859e9d..c1e4cb0e1a29 100644
--- a/vcl/qt5/QtMenu.cxx
+++ b/vcl/qt5/QtMenu.cxx
@@ -828,15 +828,19 @@ void QtMenu::ShowCloseButton(bool bShow)
lcl_force_menubar_layout_update(*mpQMenuBar);
}
-bool QtMenu::ShowNativePopupMenu(FloatingWindow*, const tools::Rectangle&,
+bool QtMenu::ShowNativePopupMenu(FloatingWindow* pWin, const tools::Rectangle&
rRect,
FloatWinPopupFlags nFlags)
{
assert(mpQMenu);
DoFullMenuUpdate(mpVCLMenu);
mpQMenu->setTearOffEnabled(bool(nFlags &
FloatWinPopupFlags::AllowTearOff));
-const QPoint aPos = QCursor::pos();
-mpQMenu->exec(aPos);
+const VclPtr xParent =
pWin->ImplGetWindowImpl()->mpRealParent;
+const QtFrame* pFrame = static_cast(xParent->ImplGetFrame());
+assert(pFrame);
+const tools::Rectangle aFloatRect =
FloatingWindow::ImplConvertToAbsPos(xParent, rRect);
+const QRect aRect = toQRect(aFloatRect, 1 / pFrame->devicePixelRatioF());
+mpQMenu->exec(aRect.topLeft());
return true;
}
[Libreoffice-bugs] [Bug 149796] New: styles / document: "autoupdate" -- misleading meaning
https://bugs.documentfoundation.org/show_bug.cgi?id=149796 Bug ID: 149796 Summary: styles / document: "autoupdate" -- misleading meaning Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu hi, I'm sure that one can argue the opposite, but look at styles and the process of writing a document... if you have a document (this is your "scope", the context within which you think), and see the checkbox and its title: "autoupdate", what would that mean? What meaning would you rad from this? it will mean: "if I check this, my page will automatically update once the style is modified, ah, cool, that's what I want" How wrong! :) It will mean, in reality, that once you modify a paragraph's "look" (by applying direct formatting), your style will be modified, I mean, your style in your template! And then all your documents, whenever you click "OK" to the popup: "your style has changed, do you want to update your document?", the template will me modded... This shouldn't work like this. "autoupdate" is ANYWAY a superfluous category in terms of styles, cause the point in the using styles is to get pages "automatically updated"... so, a different name should be invented to preserve / achieve integrity... and that title / name should reflect what will happen... for example: "reverse update" (something analogous to "feedback" would be better), or "doc-to-template update" (from this, the real-time is what's missing) or "real time template update" you name it :) - - - - - AND there is something faulty in it systemically, too: cause this checkbox you can "tick" (check) in the template... which will cause a LOOP... cause if it is checked in the template... (the person using the program will think in the template's scope, thinking that the template's style will do what a template's style has to do anyway: autoupdate) whilst in reality, she or he will give all future documents based on that template a "write-back" editing access to the template's styles I hope I'm not completely wrong :) or rather, I hope I am! :) Peter - - - thank you for developing Writer - - - -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147967] Libreoffice Writer crashes after trying to insert a formula via the formula editor (macOS)
https://bugs.documentfoundation.org/show_bug.cgi?id=147967 --- Comment #25 from Aron Budea --- I'm still not able to reproduce with a Macmini8,1. If someone who can would be interested in bibisecting it, that would be helpful. For those unfamiliar with the procedure, this involves doing a git bisect on a repository full of binary builds, for each source commit. It involves downloading a git repository ~8-10 GB in size. The general instructions are at [1], the Mac repos (one per version are at [2]. Based on the information so far, bibisect-mac64-7.2 should have the change responsible for this bug. The start script in [3] might be useful. [1] https://wiki.documentfoundation.org/QA/Bibisect [2] https://wiki.documentfoundation.org/QA/Bibisect/macOS#Versions [3] https://wiki.documentfoundation.org/Installing_in_parallel/macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148611] Help Page "Connection Pooling" not found
https://bugs.documentfoundation.org/show_bug.cgi?id=148611 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147631] The Chinese IME in Windows 10 doesn't work correctly in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=147631 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149590] LibreOffice Writer 7.2.4.1 or later hangs under macOS 10.13.6 (High Sierra)
https://bugs.documentfoundation.org/show_bug.cgi?id=149590 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149583] Crash if I open the Printer properties dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=149583 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146509] Navigator Demote Level bug
https://bugs.documentfoundation.org/show_bug.cgi?id=146509 --- Comment #2 from QA Administrators --- Dear golemus, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #12 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 54933] EDITING Report builder: mouse-move control: gap between mouse position
https://bugs.documentfoundation.org/show_bug.cgi?id=54933 --- Comment #44 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133838] Image in front of text with wrap to left enabled and anchor to character
https://bugs.documentfoundation.org/show_bug.cgi?id=133838 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137308] import newer / zstandard as zip-format
https://bugs.documentfoundation.org/show_bug.cgi?id=137308 --- Comment #9 from paulyste...@web.de --- zstandard (actual Version 1.5.2) is perhaps also a possibility in next future for the installation files of LO for less size and faster installation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131611] global document odm is not in the context menu in windows like odt, odg, odp and ods
https://bugs.documentfoundation.org/show_bug.cgi?id=131611 --- Comment #7 from paulyste...@web.de --- also in Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139247] CHART: Legends are lost after saving to XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=139247 --- Comment #10 from paulyste...@web.de --- Created attachment 181048 --> https://bugs.documentfoundation.org/attachment.cgi?id=181048=edit extended example paris tokyo budapest with budapest 2 xlsx xlsx export with Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: de-DE Calc: CL for me are Budapest and Budapest2 not ok. see attachment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139247] CHART: Legends are lost after saving to XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=139247 --- Comment #9 from paulyste...@web.de --- Created attachment 181047 --> https://bugs.documentfoundation.org/attachment.cgi?id=181047=edit extended example paris tokyo budapest with budapest 2 Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (de_DE); UI: de-DE Calc: CL for me are Budapest and Budapest2 not ok. see attachment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142529] Minimal row height not working for tables in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142529 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5204 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145204] Optimize Row Height / Minimal Row Height not working in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=145204 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2529 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142529] Minimal row height not working for tables in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=142529 --- Comment #3 from Rafael Lima --- Still repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145204] Optimize Row Height / Minimal Row Height not working in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=145204 --- Comment #3 from Rafael Lima --- Still repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source xmloff/source
sc/source/filter/oox/revisionfragment.cxx| 14 +-
xmloff/source/chart/SchXMLCalculationSettingsContext.cxx |6 --
xmloff/source/core/DocumentSettingsContext.cxx |6 --
3 files changed, 17 insertions(+), 9 deletions(-)
New commits:
commit 9c4cfb6a95e851f5651e024e798699d71e16d968
Author: Eike Rathke
AuthorDate: Thu Jun 30 23:49:03 2022 +0200
Commit: Eike Rathke
CommitDate: Fri Jul 1 02:02:04 2022 +0200
Check sax::Converter::parseDateTime() success return value
Change-Id: Ia843a1437a8c97e2dafc3f22d43a3dc61873269b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136686
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit bc5380b751d2c062575afb19db28545b7512be17)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136702
diff --git a/sc/source/filter/oox/revisionfragment.cxx
b/sc/source/filter/oox/revisionfragment.cxx
index f6fee91c4051..350adbea90e3 100644
--- a/sc/source/filter/oox/revisionfragment.cxx
+++ b/sc/source/filter/oox/revisionfragment.cxx
@@ -286,11 +286,15 @@ void RevisionHeadersFragment::importHeader( const
AttributeList& rAttribs )
if (!aDateTimeStr.isEmpty())
{
util::DateTime aDateTime;
-sax::Converter::parseDateTime(aDateTime, aDateTimeStr);
-Date aDate(aDateTime);
-tools::Time aTime(aDateTime);
-aMetadata.maDateTime.SetDate(aDate.GetDate());
-aMetadata.maDateTime.SetTime(aTime.GetTime());
+if (sax::Converter::parseDateTime(aDateTime, aDateTimeStr))
+{
+Date aDate(aDateTime);
+tools::Time aTime(aDateTime);
+aMetadata.maDateTime.SetDate(aDate.GetDate());
+aMetadata.maDateTime.SetTime(aTime.GetTime());
+}
+else
+SAL_WARN("sc.filter", "RevisionHeadersFragment: broken DateTime '"
<< aDateTimeStr << "'");
}
aMetadata.maUserName = rAttribs.getString(XML_userName, OUString());
diff --git a/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
b/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
index 9365a791c901..fbe54c96d0f8 100644
--- a/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
+++ b/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
@@ -44,8 +44,10 @@
SchXMLCalculationSettingsContext::SchXMLCalculationSettingsContext( SvXMLImport&
if ( aIter.getToken() == XML_ELEMENT(TABLE, XML_DATE_VALUE) )
{
util::DateTime aNullDate;
-::sax::Converter::parseDateTime(aNullDate, aIter.toView());
-m_aNullDate <<= aNullDate;
+if (::sax::Converter::parseDateTime(aNullDate, aIter.toView()))
+m_aNullDate <<= aNullDate;
+else
+SAL_WARN("xmloff", "SchXMLCalculationSettingsContext: broken
DateTime '" << aIter.toView() << "'");
}
else
XMLOFF_WARN_UNKNOWN("xmloff", aIter);
diff --git a/xmloff/source/core/DocumentSettingsContext.cxx
b/xmloff/source/core/DocumentSettingsContext.cxx
index b21010b07c81..9052a8dbaa81 100644
--- a/xmloff/source/core/DocumentSettingsContext.cxx
+++ b/xmloff/source/core/DocumentSettingsContext.cxx
@@ -462,8 +462,10 @@ void XMLConfigItemContext::endFastElement(sal_Int32 )
else if (IsXMLToken(msType, XML_DATETIME))
{
util::DateTime aDateTime;
-::sax::Converter::parseDateTime(aDateTime, sValue);
-mrAny <<= aDateTime;
+if (::sax::Converter::parseDateTime(aDateTime, sValue))
+mrAny <<= aDateTime;
+else
+SAL_WARN("xmloff.core", "XMLConfigItemContext: broken DateTime
'" << sValue << "'");
}
else if (IsXMLToken(msType, XML_BASE64BINARY))
{
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zforscan.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit db00c13579a94dd256a01e76ef230cde342f30db
Author: Eike Rathke
AuthorDate: Fri Jul 1 00:03:10 2022 +0200
Commit: Eike Rathke
CommitDate: Fri Jul 1 02:01:34 2022 +0200
ChangeNullDate: assert valid date after normalization if it wasn't before
... and abort if not. Also take over only valid values.
This might pop up more crashtest import failures that would need
fixes similar to commit 7ca3eca66888a1fa1b7bd59d79bb8f4c96bd7460.
Change-Id: I217204378374a1a598b5a3ff3c9c6728f112af70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136688
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/svl/source/numbers/zforscan.cxx b/svl/source/numbers/zforscan.cxx
index a5f25637678a..10ff6a591b35 100644
--- a/svl/source/numbers/zforscan.cxx
+++ b/svl/source/numbers/zforscan.cxx
@@ -519,14 +519,18 @@ void ImpSvNumberformatScan::SetDependentKeywords()
void ImpSvNumberformatScan::ChangeNullDate(sal_uInt16 nDay, sal_uInt16 nMonth,
sal_Int16 nYear)
{
-maNullDate = Date(nDay, nMonth, nYear);
-if (!maNullDate.IsValidDate())
+Date aDate(nDay, nMonth, nYear);
+if (!aDate.IsValidDate())
{
-maNullDate.Normalize();
+aDate.Normalize();
SAL_WARN("svl.numbers","ImpSvNumberformatScan::ChangeNullDate - not
valid"
" d: " << nDay << " m: " << nMonth << " y: " << nYear << "
normalized to"
-" d: " << maNullDate.GetDay() << " m: " <<
maNullDate.GetMonth() << " y: " << maNullDate.GetYear());
+" d: " << aDate.GetDay() << " m: " << aDate.GetMonth() << " y:
" << aDate.GetYear());
+// Slap the caller if really bad, like year 0.
+assert(aDate.IsValidDate());
}
+if (aDate.IsValidDate())
+maNullDate = aDate;
}
void ImpSvNumberformatScan::ChangeStandardPrec(sal_uInt16 nPrec)
[Libreoffice-bugs] [Bug 113363] [META] DOCX (OOXML) content control-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113363 Bug 113363 depends on bug 146334, which changed state. Bug 146334 Summary: Rich text content control not imported after checkbox content control https://bugs.documentfoundation.org/show_bug.cgi?id=146334 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146334] Rich text content control not imported after checkbox content control
https://bugs.documentfoundation.org/show_bug.cgi?id=146334 Gabor Kelemen (allotropia) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||vmik...@collabora.com --- Comment #3 from Gabor Kelemen (allotropia) --- This one is imported correctly since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c53d3a1f4b8430507d54f5fac336870df7a700af author Miklos Vajna 2022-04-29 08:12:25 +0200 committer Miklos Vajna 2022-04-29 09:03:01 +0200 commit c53d3a1f4b8430507d54f5fac336870df7a700af (patch) sw content controls, checkbox: add DOCX import Thanks Miklos! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114734] Comment direction lost on saving-then-reloading a .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=114734 Justin L changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |jl...@mail.com |desktop.org | Version|6.0.0.0.beta2 |Inherited From OOo --- Comment #9 from Justin L --- Import exception writerfilter/source/dmapper/DomainMapper_Impl.cxx:2550: finishParagraph() com.sun.star.beans.UnknownPropertyException message: "Unknown property: ParaStyleName at /persistent/git/libreoffice2/editeng/source/uno/unotext.cxx:1980" Also - watch out that you aren't bitten by Left/Right justify changes... For export, we currently don't export any paragraph properties in WriteOutliner (aka draw stuff) in any of DOC/RTF/DOCX. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/revisionfragment.cxx |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
New commits:
commit 216b33b8eaf144f438f87b7a35e35d04baf943bd
Author: Eike Rathke
AuthorDate: Thu Jun 30 23:58:49 2022 +0200
Commit: Eike Rathke
CommitDate: Fri Jul 1 00:51:49 2022 +0200
Use DateTime::operator=(const css::util::DateTime&)
... instead of separated Date and Time constructions.
Change-Id: I712187e41a18fe9ccbe467e9f2da3ac41693cbbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136687
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/filter/oox/revisionfragment.cxx
b/sc/source/filter/oox/revisionfragment.cxx
index 405e45f8e26b..9075ff56a897 100644
--- a/sc/source/filter/oox/revisionfragment.cxx
+++ b/sc/source/filter/oox/revisionfragment.cxx
@@ -287,12 +287,7 @@ void RevisionHeadersFragment::importHeader( const
AttributeList& rAttribs )
{
util::DateTime aDateTime;
if (sax::Converter::parseDateTime(aDateTime, aDateTimeStr))
-{
-Date aDate(aDateTime);
-tools::Time aTime(aDateTime);
-aMetadata.maDateTime.SetDate(aDate.GetDate());
-aMetadata.maDateTime.SetTime(aTime.GetTime());
-}
+aMetadata.maDateTime = aDateTime;
else
SAL_WARN("sc.filter", "RevisionHeadersFragment: broken DateTime '"
<< aDateTimeStr << "'");
}
[Libreoffice-commits] core.git: sc/source xmloff/source
sc/source/filter/oox/revisionfragment.cxx| 14 +-
xmloff/source/chart/SchXMLCalculationSettingsContext.cxx |6 --
xmloff/source/core/DocumentSettingsContext.cxx |6 --
3 files changed, 17 insertions(+), 9 deletions(-)
New commits:
commit d031accf712cde8f664828ec4547bf6a4661860f
Author: Eike Rathke
AuthorDate: Thu Jun 30 23:49:03 2022 +0200
Commit: Eike Rathke
CommitDate: Fri Jul 1 00:48:15 2022 +0200
Check sax::Converter::parseDateTime() success return value
Change-Id: Ia843a1437a8c97e2dafc3f22d43a3dc61873269b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136686
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/filter/oox/revisionfragment.cxx
b/sc/source/filter/oox/revisionfragment.cxx
index 4a0fa785e6df..405e45f8e26b 100644
--- a/sc/source/filter/oox/revisionfragment.cxx
+++ b/sc/source/filter/oox/revisionfragment.cxx
@@ -286,11 +286,15 @@ void RevisionHeadersFragment::importHeader( const
AttributeList& rAttribs )
if (!aDateTimeStr.isEmpty())
{
util::DateTime aDateTime;
-sax::Converter::parseDateTime(aDateTime, aDateTimeStr);
-Date aDate(aDateTime);
-tools::Time aTime(aDateTime);
-aMetadata.maDateTime.SetDate(aDate.GetDate());
-aMetadata.maDateTime.SetTime(aTime.GetTime());
+if (sax::Converter::parseDateTime(aDateTime, aDateTimeStr))
+{
+Date aDate(aDateTime);
+tools::Time aTime(aDateTime);
+aMetadata.maDateTime.SetDate(aDate.GetDate());
+aMetadata.maDateTime.SetTime(aTime.GetTime());
+}
+else
+SAL_WARN("sc.filter", "RevisionHeadersFragment: broken DateTime '"
<< aDateTimeStr << "'");
}
aMetadata.maUserName = rAttribs.getString(XML_userName, OUString());
diff --git a/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
b/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
index 9365a791c901..fbe54c96d0f8 100644
--- a/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
+++ b/xmloff/source/chart/SchXMLCalculationSettingsContext.cxx
@@ -44,8 +44,10 @@
SchXMLCalculationSettingsContext::SchXMLCalculationSettingsContext( SvXMLImport&
if ( aIter.getToken() == XML_ELEMENT(TABLE, XML_DATE_VALUE) )
{
util::DateTime aNullDate;
-::sax::Converter::parseDateTime(aNullDate, aIter.toView());
-m_aNullDate <<= aNullDate;
+if (::sax::Converter::parseDateTime(aNullDate, aIter.toView()))
+m_aNullDate <<= aNullDate;
+else
+SAL_WARN("xmloff", "SchXMLCalculationSettingsContext: broken
DateTime '" << aIter.toView() << "'");
}
else
XMLOFF_WARN_UNKNOWN("xmloff", aIter);
diff --git a/xmloff/source/core/DocumentSettingsContext.cxx
b/xmloff/source/core/DocumentSettingsContext.cxx
index b21010b07c81..9052a8dbaa81 100644
--- a/xmloff/source/core/DocumentSettingsContext.cxx
+++ b/xmloff/source/core/DocumentSettingsContext.cxx
@@ -462,8 +462,10 @@ void XMLConfigItemContext::endFastElement(sal_Int32 )
else if (IsXMLToken(msType, XML_DATETIME))
{
util::DateTime aDateTime;
-::sax::Converter::parseDateTime(aDateTime, sValue);
-mrAny <<= aDateTime;
+if (::sax::Converter::parseDateTime(aDateTime, sValue))
+mrAny <<= aDateTime;
+else
+SAL_WARN("xmloff.core", "XMLConfigItemContext: broken DateTime
'" << sValue << "'");
}
else if (IsXMLToken(msType, XML_BASE64BINARY))
{
[Libreoffice-bugs] [Bug 113363] [META] DOCX (OOXML) content control-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113363 Bug 113363 depends on bug 99571, which changed state. Bug 99571 Summary: FILEOPEN: Cannot click on docx checkbox (content control) https://bugs.documentfoundation.org/show_bug.cgi?id=99571 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99571] FILEOPEN: Cannot click on docx checkbox (content control)
https://bugs.documentfoundation.org/show_bug.cgi?id=99571 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||vmik...@collabora.com Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #21 from Gabor Kelemen (allotropia) --- These are clickable since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c53d3a1f4b8430507d54f5fac336870df7a700af author Miklos Vajna 2022-04-29 08:12:25 +0200 committer Miklos Vajna 2022-04-29 09:03:01 +0200 commit c53d3a1f4b8430507d54f5fac336870df7a700af (patch) sw content controls, checkbox: add DOCX import Thanks Miklos! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149795] Image in frame moving to the bottom of the page after CTRL+A/CTRL+X/CTRL+V
https://bugs.documentfoundation.org/show_bug.cgi?id=149795 Rafael Lima changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Rafael Lima --- Repro in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL Selecting everything (Ctrl+A), then immediately cutting (Ctrl+X) and pasting (Ctrl+V) should restore the initial state, but the arrow image is moved to a different position. Setting this to NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138093] FILEOPEN DOCX Date selector control resets to year 1900 if placed inside table
https://bugs.documentfoundation.org/show_bug.cgi?id=138093 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #4 from Gabor Kelemen (allotropia) --- Still a problem in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 9c796266470183f673eb58a8637dfe621eefa8b3 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131722] FILEOPEN DOCX Date picker control placeholder texts first character goes out of the control
https://bugs.documentfoundation.org/show_bug.cgi?id=131722 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #4 from Gabor Kelemen (allotropia) --- Still a problem in: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 9c796266470183f673eb58a8637dfe621eefa8b3 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104260] FILEOPEN DOCX: Images in table appear only once
https://bugs.documentfoundation.org/show_bug.cgi?id=104260 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9632 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104468 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||149632 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149632 [Bug 149632] fileopen missing image on docx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149632] fileopen missing image on docx
https://bugs.documentfoundation.org/show_bug.cgi?id=149632 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||4260 Blocks||104468 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104468 [Bug 104468] [META] DOCX (OOXML) image-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 19 commits - chart2/inc chart2/Library_chartcontroller.mk chart2/Library_chartcore.mk chart2/source chart2/uiconfig chart2/UIConfig_ch
Rebased ref, commits from common ancestor:
commit f39ac2b1acadd07e14b1cb3e10be3c8ebc100a2b
Author: Tomaž Vajngerl
AuthorDate: Thu Jun 30 23:43:52 2022 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jun 30 23:43:52 2022 +0200
chart2: add some data table default properties
Change-Id: I4fac46ac2a119275bcdaa6ebc8b7382ad6fb5684
diff --git a/chart2/source/model/main/DataTable.cxx
b/chart2/source/model/main/DataTable.cxx
index 0620ce5ccaba..c67fab5c1740 100644
--- a/chart2/source/model/main/DataTable.cxx
+++ b/chart2/source/model/main/DataTable.cxx
@@ -70,6 +70,14 @@ private:
true);
::chart::PropertyHelper::setPropertyValueDefault(aMap,
DataTableProperty_Outilne, true);
::chart::PropertyHelper::setPropertyValueDefault(aMap,
DataTableProperty_Keys, false);
+
+float fDefaultCharHeight = 10.0;
+::chart::PropertyHelper::setPropertyValue(
+aMap, ::chart::CharacterProperties::PROP_CHAR_CHAR_HEIGHT,
fDefaultCharHeight);
+::chart::PropertyHelper::setPropertyValue(
+aMap, ::chart::CharacterProperties::PROP_CHAR_ASIAN_CHAR_HEIGHT,
fDefaultCharHeight);
+::chart::PropertyHelper::setPropertyValue(
+aMap, ::chart::CharacterProperties::PROP_CHAR_COMPLEX_CHAR_HEIGHT,
fDefaultCharHeight);
}
};
commit 0bf157a9c90546416e27aead961e02d46c413ec3
Author: Tomaž Vajngerl
AuthorDate: Thu Jun 30 23:34:19 2022 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jun 30 23:41:54 2022 +0200
chart2: add "InsertDataTable" action to menu
Change-Id: Ib60a2b061966eb61834480b63dc0653410a43a14
diff --git a/chart2/source/controller/inc/ChartController.hxx
b/chart2/source/controller/inc/ChartController.hxx
index 505b109fdcc7..e8b78a309e12 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -440,6 +440,7 @@ private:
void executeDispatch_OpenLegendDialog();
void executeDispatch_InsertAxes();
void executeDispatch_InsertGrid();
+void executeDispatch_InsertDataTable();
void executeDispatch_InsertMenu_DataLabels();
void executeDispatch_InsertMenu_Trendlines();
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index a4bd7a3972cc..79e05b77e885 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -1169,6 +1169,8 @@ void SAL_CALL ChartController::dispatch(
this->executeDispatch_InsertErrorBars(false);
else if( aCommand == "InsertMenuYErrorBars" )
this->executeDispatch_InsertErrorBars(true);
+else if( aCommand == "InsertDataTable" )
+this->executeDispatch_InsertDataTable();
else if( aCommand == "InsertSymbol" )
this->executeDispatch_InsertSpecialCharacter();
else if( aCommand == "InsertTrendline" )
@@ -1631,6 +1633,7 @@ const o3tl::sorted_vector< OUString >&
ChartController::impl_getAvailableCommand
"DeleteTrendline","DeleteMeanValue",
"DeleteTrendlineEquation",
"DeleteXErrorBars", "DeleteYErrorBars",
"DeleteDataLabels", "DeleteDataLabel",
+"InsertDataTable",
//format objects
"FormatSelection", "TransformDialog",
"DiagramType","View3D",
diff --git a/chart2/source/controller/main/ChartController_Insert.cxx
b/chart2/source/controller/main/ChartController_Insert.cxx
index 4f39f1068cdb..7c660af86f81 100644
--- a/chart2/source/controller/main/ChartController_Insert.cxx
+++ b/chart2/source/controller/main/ChartController_Insert.cxx
@@ -52,6 +52,7 @@
#include
#include
#include
+#include
#include
#include
@@ -155,6 +156,24 @@ void ChartController::executeDispatch_InsertGrid()
}
}
+void ChartController::executeDispatch_InsertDataTable()
+{
+rtl::Reference xDiagram = getFirstDiagram();
+SolarMutexGuard aGuard;
+if (xDiagram->getDataTable().is())
+{
+xDiagram->setDataTable(uno::Reference());
+}
+else
+{
+uno::Reference xDataTable(new DataTable);
+if (xDataTable.is())
+{
+xDiagram->setDataTable(xDataTable);
+}
+}
+}
+
void ChartController::executeDispatch_InsertTitles()
{
UndoGuard aUndoGuard(
diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index e5035b4f053c..b7872b93e708 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -584,6 +584,7 @@ void ControllerCommandDispatch::updateCommandAvailability()
m_aCommandAvailability[ ".uno:InsertMenuXErrorBars" ] = bIsWritable &&
m_apModelState->bSupportsStatistics;
m_aCommandAvailability[ ".uno:InsertMenuYErrorBars" ] = bIsWritable &&
[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/XMLCalculationSettingsContext.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 8480e15f854cfc0a6b99a6b28f794465d0fb8253
Author: Eike Rathke
AuthorDate: Thu Jun 30 02:06:06 2022 +0200
Commit: Eike Rathke
CommitDate: Thu Jun 30 23:44:23 2022 +0200
Ignoring invalid NullDate is worth a warning
Change-Id: Ie29151ab17b947561c96512e5128edbfdeaa226b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136662
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
b/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
index 43da1437eb5c..d5e214b7c20d 100644
--- a/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
+++ b/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
@@ -158,6 +158,10 @@ ScXMLNullDateContext::ScXMLNullDateContext( ScXMLImport&
rImport,
aDate.Year = aDateTime.Year;
pCalcSet->SetNullDate(aDate);
}
+else
+{
+SAL_WARN("sc.filter","ignoring invalid NullDate '" <<
aIter.toView() << "'");
+}
}
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source
sc/source/filter/xml/XMLCalculationSettingsContext.cxx | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
New commits:
commit a60e3c28dbf561b0d1eb190baf32f06151bf32a0
Author: Eike Rathke
AuthorDate: Thu Jun 30 01:38:43 2022 +0200
Commit: Eike Rathke
CommitDate: Thu Jun 30 23:44:05 2022 +0200
crashtesting: assert on reexport to ods of forum-it-7248.ods
source document available from:
https://forum.openoffice.org/it/forum/download/file.php?id=7248
The actual cause is already a bad
imported unchecked. For this, sax::Converter::parseDateTime()
returns a success value, just use it..
If bad keep the default NullDate.
Change-Id: If4caa57e302cfe8304e6cb49bf9d330245a97660
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136611
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 626458eaec9a1c6ef2c29fd25dc5612d3dd1555c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136646
diff --git a/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
b/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
index 1989b337faf2..43da1437eb5c 100644
--- a/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
+++ b/sc/source/filter/xml/XMLCalculationSettingsContext.cxx
@@ -150,12 +150,14 @@ ScXMLNullDateContext::ScXMLNullDateContext( ScXMLImport&
rImport,
if (aIter != rAttrList->end())
{
util::DateTime aDateTime;
-::sax::Converter::parseDateTime(aDateTime, aIter.toView());
-util::Date aDate;
-aDate.Day = aDateTime.Day;
-aDate.Month = aDateTime.Month;
-aDate.Year = aDateTime.Year;
-pCalcSet->SetNullDate(aDate);
+if (::sax::Converter::parseDateTime(aDateTime, aIter.toView()))
+{
+util::Date aDate;
+aDate.Day = aDateTime.Day;
+aDate.Month = aDateTime.Month;
+aDate.Year = aDateTime.Year;
+pCalcSet->SetNullDate(aDate);
+}
}
}
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/frame.hxx |2
sfx2/source/view/frame.cxx | 110 ++--
sfx2/source/view/frame2.cxx | 26 +-
3 files changed, 69 insertions(+), 69 deletions(-)
New commits:
commit 965cb44506c3ff182203d49d06b96beb6194f707
Author: Henry Castro
AuthorDate: Thu Jun 30 15:45:06 2022 -0400
Commit: Henry Castro
CommitDate: Thu Jun 30 23:38:52 2022 +0200
sfx2: replace pImpl -> m_pImpl
Class SfxFrame
Signed-off-by: Henry Castro
Change-Id: Iad58908e76f3d9891816a9c8dad3d37aa6630722
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136684
Tested-by: Jenkins
diff --git a/include/sfx2/frame.hxx b/include/sfx2/frame.hxx
index 86b5baaa756c..7956fdd36d57 100644
--- a/include/sfx2/frame.hxx
+++ b/include/sfx2/frame.hxx
@@ -69,7 +69,7 @@ class SFX2_DLLPUBLIC SfxFrame final : public
SvCompatWeakBase
friend class SfxFrameWindow_Impl;
private:
-std::unique_ptr< SfxFrame_Impl > pImpl;
+std::unique_ptr< SfxFrame_Impl > m_pImpl;
VclPtr pWindow;
virtual ~SfxFrame();
diff --git a/sfx2/source/view/frame.cxx b/sfx2/source/view/frame.cxx
index 8e577221c58f..0abc76bc3271 100644
--- a/sfx2/source/view/frame.cxx
+++ b/sfx2/source/view/frame.cxx
@@ -65,7 +65,7 @@ SfxPoolItem* SfxUnoFrameItem::CreateDefault()
}
void SfxFrame::Construct_Impl()
{
-pImpl.reset(new SfxFrame_Impl);
+m_pImpl.reset(new SfxFrame_Impl);
gaFramesArr_Impl.push_back( this );
}
@@ -79,28 +79,28 @@ SfxFrame::~SfxFrame()
if ( it != gaFramesArr_Impl.end() )
gaFramesArr_Impl.erase( it );
-delete pImpl->pDescr;
+delete m_pImpl->pDescr;
}
bool SfxFrame::DoClose()
{
// Actually, one more PrepareClose is still needed!
bool bRet = false;
-if ( !pImpl->bClosing )
+if ( !m_pImpl->bClosing )
{
-pImpl->bClosing = true;
+m_pImpl->bClosing = true;
CancelTransfers();
// now close frame; it will be deleted if this call is successful, so
don't use any members after that!
bRet = true;
try
{
-Reference< XCloseable > xCloseable ( pImpl->xFrame, UNO_QUERY );
+Reference< XCloseable > xCloseable ( m_pImpl->xFrame, UNO_QUERY );
if (xCloseable.is())
xCloseable->close(true);
-else if ( pImpl->xFrame.is() )
+else if ( m_pImpl->xFrame.is() )
{
-Reference < XFrame > xFrame = pImpl->xFrame;
+Reference < XFrame > xFrame = m_pImpl->xFrame;
xFrame->setComponent( Reference < css::awt::XWindow >(),
Reference < XController >() );
xFrame->dispose();
}
@@ -109,7 +109,7 @@ bool SfxFrame::DoClose()
}
catch( css::util::CloseVetoException& )
{
-pImpl->bClosing = false;
+m_pImpl->bClosing = false;
bRet = false;
}
catch( css::lang::DisposedException& )
@@ -123,17 +123,17 @@ bool SfxFrame::DoClose()
void SfxFrame::DoClose_Impl()
{
SfxBindings* pBindings = nullptr;
-if ( pImpl->pCurrentViewFrame )
-pBindings = >pCurrentViewFrame->GetBindings();
+if ( m_pImpl->pCurrentViewFrame )
+pBindings = _pImpl->pCurrentViewFrame->GetBindings();
// For internal tasks Controllers and Tools must be cleared
-if ( pImpl->pWorkWin )
-pImpl->pWorkWin->DeleteControllers_Impl();
+if ( m_pImpl->pWorkWin )
+m_pImpl->pWorkWin->DeleteControllers_Impl();
-if ( pImpl->pCurrentViewFrame )
-pImpl->pCurrentViewFrame->Close();
+if ( m_pImpl->pCurrentViewFrame )
+m_pImpl->pCurrentViewFrame->Close();
-if ( pImpl->bOwnsBindings )
+if ( m_pImpl->bOwnsBindings )
{
delete pBindings;
pBindings = nullptr;
@@ -144,8 +144,8 @@ void SfxFrame::DoClose_Impl()
bool SfxFrame::DocIsModified_Impl()
{
-return pImpl->pCurrentViewFrame &&
pImpl->pCurrentViewFrame->GetObjectShell() &&
-pImpl->pCurrentViewFrame->GetObjectShell()->IsModified();
+return m_pImpl->pCurrentViewFrame &&
m_pImpl->pCurrentViewFrame->GetObjectShell() &&
+m_pImpl->pCurrentViewFrame->GetObjectShell()->IsModified();
}
bool SfxFrame::PrepareClose_Impl( bool bUI )
@@ -153,9 +153,9 @@ bool SfxFrame::PrepareClose_Impl( bool bUI )
bool bRet = true;
// prevent recursive calls
-if( !pImpl->bPrepClosing )
+if( !m_pImpl->bPrepClosing )
{
-pImpl->bPrepClosing = true;
+m_pImpl->bPrepClosing = true;
SfxObjectShell* pCur = GetCurrentDocument() ;
if( pCur )
@@ -179,12 +179,12 @@ bool SfxFrame::PrepareClose_Impl( bool bUI )
bRet = pCur->PrepareClose( bUI );
}
-pImpl->bPrepClosing = false;
+m_pImpl->bPrepClosing = false;
}
-if ( bRet && pImpl->pWorkWin )
+if ( bRet && m_pImpl->pWorkWin )
[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - chart2/source chart2/uiconfig officecfg/registry
chart2/source/controller/inc/ChartController.hxx |1
chart2/source/controller/main/ChartController.cxx |3 +
chart2/source/controller/main/ChartController_Insert.cxx | 19
++
chart2/source/controller/main/ControllerCommandDispatch.cxx|1
chart2/uiconfig/menubar/menubar.xml|1
officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu |5 ++
6 files changed, 30 insertions(+)
New commits:
commit ad19d370708d9c4efabee1cb88eeb63452ec9f68
Author: Tomaž Vajngerl
AuthorDate: Thu Jun 30 23:34:19 2022 +0200
Commit: Tomaž Vajngerl
CommitDate: Thu Jun 30 23:34:19 2022 +0200
chart2: add "InsertDataTable" action to menu
Change-Id: Ib60a2b061966eb61834480b63dc0653410a43a14
diff --git a/chart2/source/controller/inc/ChartController.hxx
b/chart2/source/controller/inc/ChartController.hxx
index 505b109fdcc7..e8b78a309e12 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -440,6 +440,7 @@ private:
void executeDispatch_OpenLegendDialog();
void executeDispatch_InsertAxes();
void executeDispatch_InsertGrid();
+void executeDispatch_InsertDataTable();
void executeDispatch_InsertMenu_DataLabels();
void executeDispatch_InsertMenu_Trendlines();
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index a4bd7a3972cc..79e05b77e885 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -1169,6 +1169,8 @@ void SAL_CALL ChartController::dispatch(
this->executeDispatch_InsertErrorBars(false);
else if( aCommand == "InsertMenuYErrorBars" )
this->executeDispatch_InsertErrorBars(true);
+else if( aCommand == "InsertDataTable" )
+this->executeDispatch_InsertDataTable();
else if( aCommand == "InsertSymbol" )
this->executeDispatch_InsertSpecialCharacter();
else if( aCommand == "InsertTrendline" )
@@ -1631,6 +1633,7 @@ const o3tl::sorted_vector< OUString >&
ChartController::impl_getAvailableCommand
"DeleteTrendline","DeleteMeanValue",
"DeleteTrendlineEquation",
"DeleteXErrorBars", "DeleteYErrorBars",
"DeleteDataLabels", "DeleteDataLabel",
+"InsertDataTable",
//format objects
"FormatSelection", "TransformDialog",
"DiagramType","View3D",
diff --git a/chart2/source/controller/main/ChartController_Insert.cxx
b/chart2/source/controller/main/ChartController_Insert.cxx
index 4f39f1068cdb..7c660af86f81 100644
--- a/chart2/source/controller/main/ChartController_Insert.cxx
+++ b/chart2/source/controller/main/ChartController_Insert.cxx
@@ -52,6 +52,7 @@
#include
#include
#include
+#include
#include
#include
@@ -155,6 +156,24 @@ void ChartController::executeDispatch_InsertGrid()
}
}
+void ChartController::executeDispatch_InsertDataTable()
+{
+rtl::Reference xDiagram = getFirstDiagram();
+SolarMutexGuard aGuard;
+if (xDiagram->getDataTable().is())
+{
+xDiagram->setDataTable(uno::Reference());
+}
+else
+{
+uno::Reference xDataTable(new DataTable);
+if (xDataTable.is())
+{
+xDiagram->setDataTable(xDataTable);
+}
+}
+}
+
void ChartController::executeDispatch_InsertTitles()
{
UndoGuard aUndoGuard(
diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index e5035b4f053c..b7872b93e708 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -584,6 +584,7 @@ void ControllerCommandDispatch::updateCommandAvailability()
m_aCommandAvailability[ ".uno:InsertMenuXErrorBars" ] = bIsWritable &&
m_apModelState->bSupportsStatistics;
m_aCommandAvailability[ ".uno:InsertMenuYErrorBars" ] = bIsWritable &&
m_apModelState->bSupportsStatistics;
m_aCommandAvailability[ ".uno:InsertSymbol" ] = bIsWritable &&
bControllerStateIsValid && m_apControllerState->bIsTextObject;
+m_aCommandAvailability[ ".uno:InsertDataTable" ] = bIsWritable;
// format objects
bool bFormatObjectAvailable = bIsWritable && bControllerStateIsValid &&
m_apControllerState->bIsFormateableObjectSelected;
diff --git a/chart2/uiconfig/menubar/menubar.xml
b/chart2/uiconfig/menubar/menubar.xml
index 354ebbc1903a..581aff37153b 100644
--- a/chart2/uiconfig/menubar/menubar.xml
+++ b/chart2/uiconfig/menubar/menubar.xml
@@ -56,6 +56,7 @@
+
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu
index d3a54a052c8e..7739522a866e 100644
---
[Libreoffice-bugs] [Bug 149785] Read Error importing document
https://bugs.documentfoundation.org/show_bug.cgi?id=149785 --- Comment #3 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/59cf9a433e1ea74ccdb1abe080511353a6c0af08 tdf#149785: sd_import_tests2: Add unittest It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/data/pptx/tdf149785.pptx |binary
sd/qa/unit/import-tests2.cxx| 16
2 files changed, 16 insertions(+)
New commits:
commit 59cf9a433e1ea74ccdb1abe080511353a6c0af08
Author: Xisco Fauli
AuthorDate: Thu Jun 30 14:41:51 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 30 23:33:32 2022 +0200
tdf#149785: sd_import_tests2: Add unittest
Change-Id: I8d11508adc999381a119da26a5cf438072c8aff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136672
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sd/qa/unit/data/pptx/tdf149785.pptx
b/sd/qa/unit/data/pptx/tdf149785.pptx
new file mode 100644
index ..9b969af171c1
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf149785.pptx differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 33bbcca615b7..d7273967be67 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -119,6 +119,7 @@ public:
void testPatternImport();
void testPptCrop();
void testTdf149206();
+void testTdf149785();
void testTdf120028();
void testDescriptionImport();
void testTdf83247();
@@ -183,6 +184,7 @@ public:
CPPUNIT_TEST(testTdf116266);
CPPUNIT_TEST(testPptCrop);
CPPUNIT_TEST(testTdf149206);
+CPPUNIT_TEST(testTdf149785);
CPPUNIT_TEST(testTdf120028);
CPPUNIT_TEST(testDescriptionImport);
CPPUNIT_TEST(testTdf83247);
@@ -1567,6 +1569,20 @@ void SdImportTest2::testTdf149206()
CPPUNIT_ASSERT_EQUAL(static_cast(0), aCrop.Right);
}
+void SdImportTest2::testTdf149785()
+{
+// Without the fix in place, this test would have failed to load the file
+::sd::DrawDocShellRef xDocShRef
+=
loadURL(m_directories.getURLFromSrc(u"/sd/qa/unit/data/pptx/tdf149785.pptx"),
PPTX);
+uno::Reference
xDoc(xDocShRef->GetDoc()->getUnoModel(),
+ uno::UNO_QUERY);
+
+const SdrPage* pPage = GetPage(1, xDocShRef);
+CPPUNIT_ASSERT_EQUAL(size_t(1), pPage->GetObjCount());
+
+xDocShRef->DoClose();
+}
+
void SdImportTest2::testTdf120028()
{
// Check that the text shape has 4 columns.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - config_host.mk.in configure.ac lo.xcent.in Makefile.in
Makefile.in |4 +++-
config_host.mk.in |1 +
configure.ac | 19 +++
lo.xcent.in |1 +
4 files changed, 24 insertions(+), 1 deletion(-)
New commits:
commit 4019eab1be7ecba19996acbd31cce97d5a3c4406
Author: Christian Lohmaier
AuthorDate: Wed Jun 29 13:35:01 2022 +0200
Commit: Caolán McNamara
CommitDate: Thu Jun 30 22:35:19 2022 +0200
allow to specify a macOS provisioning profile
having one is one of the prerequisites of using TestFlight
Change-Id: I9e20eb99905071fade4179dfbe2da5b7e5dd1c24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136618
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier
(cherry picked from commit b43f0b0295953c8d5d16c5b9eccaddb5ec214bab)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136696
Reviewed-by: Caolán McNamara
diff --git a/Makefile.in b/Makefile.in
index 29208d2765cc..beae106e3ede 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -387,7 +387,9 @@ ifneq ($(ENABLE_MACOSX_SANDBOX),)
rm
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/MacOS/unopkg
rm
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/MacOS/unoinfo
endif
-#
+ifneq ($(MACOSX_PROVISIONING_PROFILE),)
+ cp "$(MACOSX_PROVISIONING_PROFILE)"
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/embedded.provisionprofile
+endif
ifneq ($(MACOSX_CODESIGNING_IDENTITY),)
# Then use the macosx-codesign-app-bundle script
@$(SRCDIR)/solenv/bin/macosx-codesign-app-bundle
$(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app
diff --git a/config_host.mk.in b/config_host.mk.in
index 019e1a65561b..595e386bae43 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -450,6 +450,7 @@ export MACOSX_BUNDLE_IDENTIFIER=@MACOSX_BUNDLE_IDENTIFIER@
export MACOSX_CODESIGNING_IDENTITY=@MACOSX_CODESIGNING_IDENTITY@
export MACOSX_DEPLOYMENT_TARGET=@MACOSX_DEPLOYMENT_TARGET@
export MACOSX_PACKAGE_SIGNING_IDENTITY=@MACOSX_PACKAGE_SIGNING_IDENTITY@
+export MACOSX_PROVISIONING_PROFILE=@MACOSX_PROVISIONING_PROFILE@
export MACOSX_SDK_PATH=@MACOSX_SDK_PATH@
export MAC_OS_X_VERSION_MIN_REQUIRED=@MAC_OS_X_VERSION_MIN_REQUIRED@
export MANDIR=@MANDIR@
diff --git a/configure.ac b/configure.ac
index 426e99cea2dd..6134678b9c54 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1899,6 +1899,11 @@ AC_ARG_WITH(macosx-bundle-identifier,
org.libreoffice.script ("script", huh?).]),
,with_macosx_bundle_identifier=org.libreoffice.script)
+AC_ARG_WITH(macosx-provisioning-profile,
+
AS_HELP_STRING([--with-macosx-provisioning-profile=/path/to/mac.provisionprofile],
+[Specify the path to a provisioning profile to use]),
+,)
+
AC_ARG_WITH(product-name,
AS_HELP_STRING([--with-product-name='My Own Office Suite'],
[Define the product name. Default is AC_PACKAGE_NAME.]),
@@ -3628,6 +3633,18 @@ if test $_os = Darwin; then
AC_MSG_CHECKING([what macOS app bundle identifier to use])
MACOSX_BUNDLE_IDENTIFIER=$with_macosx_bundle_identifier
AC_MSG_RESULT([$MACOSX_BUNDLE_IDENTIFIER])
+
+if test -n "$with_macosx_provisioning_profile" ; then
+if test ! -f "$with_macosx_provisioning_profile"; then
+AC_MSG_ERROR([provisioning profile not found at
$with_macosx_provisioning_profile])
+else
+MACOSX_PROVISIONING_PROFILE=$with_macosx_provisioning_profile
+MACOSX_PROVISIONING_INFO=$([security cms -D -i
"$MACOSX_PROVISIONING_PROFILE" | \
+xmllint --xpath "//key[.='com.apple.application-identifier' or
.='com.apple.developer.team-identifier'] \
+| //key[.='com.apple.application-identifier' or
.='com.apple.developer.team-identifier']/following-sibling::string[1]" - | \
+sed -e 's#><#>\n\t<#g' -e 's#^#\t#'])
+fi
+fi
fi
AC_SUBST(MACOSX_SDK_PATH)
AC_SUBST(MACOSX_DEPLOYMENT_TARGET)
@@ -3638,6 +3655,8 @@ AC_SUBST(MACOSX_CODESIGNING_IDENTITY)
AC_SUBST(MACOSX_PACKAGE_SIGNING_IDENTITY)
AC_SUBST(ENABLE_MACOSX_SANDBOX)
AC_SUBST(MACOSX_BUNDLE_IDENTIFIER)
+AC_SUBST(MACOSX_PROVISIONING_INFO)
+AC_SUBST(MACOSX_PROVISIONING_PROFILE)
dnl ===
dnl Check iOS SDK and compiler
diff --git a/lo.xcent.in b/lo.xcent.in
index 9a0838fbc388..4b7303876e6b 100644
--- a/lo.xcent.in
+++ b/lo.xcent.in
@@ -22,5 +22,6 @@
com.apple.security.personal-information.addressbook
@SDREMOTE_ENTITLEMENT@
+@MACOSX_PROVISIONING_INFO@
[Libreoffice-bugs] [Bug 149179] The filter dialog in LibreOffice Calc behaves strangely using Graphite GTK Theme
https://bugs.documentfoundation.org/show_bug.cgi?id=149179 --- Comment #10 from Caolán McNamara --- oh cool, this got fixed on the theme side. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137544] Opening complex electric PDF drawing is very slow with high CPU in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=137544 --- Comment #10 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c6f1659fa2be14f830fb4a8264b70420df22f7e0 tdf#137544 elide some UNO_QUERY It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/ChildrenManager.hxx |3 +-
svx/source/accessibility/ChildrenManager.cxx |2 -
svx/source/accessibility/ChildrenManagerImpl.cxx | 29 +--
svx/source/accessibility/ChildrenManagerImpl.hxx | 10 +++
4 files changed, 20 insertions(+), 24 deletions(-)
New commits:
commit c6f1659fa2be14f830fb4a8264b70420df22f7e0
Author: Noel Grandin
AuthorDate: Wed Jun 29 20:49:03 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 30 22:14:14 2022 +0200
tdf#137544 elide some UNO_QUERY
Change-Id: I58b5a800d2f24168c9d1c109769344a00dea8e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136658
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/ChildrenManager.hxx b/include/svx/ChildrenManager.hxx
index 0498b43fdff0..c14ae6c1c476 100644
--- a/include/svx/ChildrenManager.hxx
+++ b/include/svx/ChildrenManager.hxx
@@ -46,6 +46,7 @@ class XShapes;
namespace accessibility
{
class AccessibleContextBase;
+class AccessibleShape;
class AccessibleShapeTreeInfo;
class ChildrenManagerImpl;
@@ -164,7 +165,7 @@ public:
@param shape must be non-null
*/
-void
AddAccessibleShape(css::uno::Reference const&
shape);
+void AddAccessibleShape(rtl::Reference const& shape);
/** Clear the list of accessible shapes which have been added by
previous calls to AddAccessibleShape.
diff --git a/svx/source/accessibility/ChildrenManager.cxx
b/svx/source/accessibility/ChildrenManager.cxx
index 71983f46e98c..d0e681b550f1 100644
--- a/svx/source/accessibility/ChildrenManager.cxx
+++ b/svx/source/accessibility/ChildrenManager.cxx
@@ -74,7 +74,7 @@ void ChildrenManager::SetShapeList (const
css::uno::ReferenceSetShapeList (xShapeList);
}
-void ChildrenManager::AddAccessibleShape
(css::uno::Reference const & shape)
+void ChildrenManager::AddAccessibleShape (rtl::Reference
const & shape)
{
mpImpl->AddAccessibleShape (shape);
}
diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx
b/svx/source/accessibility/ChildrenManagerImpl.cxx
index d22f81e76684..27647f70c097 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.cxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.cxx
@@ -24,6 +24,7 @@
#include "ChildrenManagerImpl.hxx"
#include
#include
+#include
#include
#include
#include
@@ -424,7 +425,7 @@ void ChildrenManagerImpl::CreateAccessibilityObjects (
rChild.mbCreateEventPending = false;
mrContext.CommitChange (
AccessibleEventId::CHILD,
-uno::Any(rChild.mxAccessibleShape),
+
uno::Any(uno::Reference(rChild.mxAccessibleShape)),
uno::Any());
}
++nPos;
@@ -472,7 +473,7 @@ void ChildrenManagerImpl::AddShape (const
Reference& rxShape)
// Inform listeners about new child.
uno::Any aNewShape;
-aNewShape <<= rDescriptor.mxAccessibleShape;
+aNewShape <<= uno::Reference(rDescriptor.mxAccessibleShape);
aGuard.clear();
mrContext.CommitChange (
AccessibleEventId::CHILD,
@@ -517,7 +518,7 @@ void ChildrenManagerImpl::SetShapeList (const
css::uno::Reference const & shape)
+void ChildrenManagerImpl::AddAccessibleShape (rtl::Reference
const & shape)
{
assert(shape.is());
maAccessibleShapes.push_back (shape);
@@ -547,7 +548,7 @@ void ChildrenManagerImpl::ClearAccessibleShapeList()
for (auto& rChild : aLocalVisibleChildren)
if ( rChild.mxAccessibleShape.is() && rChild.mxShape.is() )
{
-::comphelper::disposeComponent(rChild.mxAccessibleShape);
+rChild.mxAccessibleShape->dispose();
rChild.mxAccessibleShape = nullptr;
}
@@ -556,7 +557,7 @@ void ChildrenManagerImpl::ClearAccessibleShapeList()
if (rpShape.is())
{
// Dispose the object.
-::comphelper::disposeComponent(rpShape);
+rpShape->dispose();
rpShape = nullptr;
}
}
@@ -748,7 +749,7 @@ bool ChildrenManagerImpl::ReplaceChild (
mrContext.CommitChange (
AccessibleEventId::CHILD,
uno::Any(),
-uno::Any (I->mxAccessibleShape));
+uno::Any (uno::Reference(I->mxAccessibleShape)));
// Replace with replacement and send an event about existence
// of the new child.
@@ -764,7 +765,7 @@ bool ChildrenManagerImpl::ReplaceChild (
I->mxAccessibleShape = pNewChild.get();
mrContext.CommitChange (
AccessibleEventId::CHILD,
-uno::Any (I->mxAccessibleShape),
+uno::Any (uno::Reference(I->mxAccessibleShape)),
uno::Any());
return true;
@@ -1026,7 +1027,7 @@ ChildDescriptor::ChildDescriptor (const
Reference& xShape)
}
-ChildDescriptor::ChildDescriptor (const Reference&
rxAccessibleShape)
+ChildDescriptor::ChildDescriptor (const rtl::Reference&
rxAccessibleShape)
:
[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/fuarea.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 27ad7de6a9a8a019a0138179685268fc52e010d0
Author: Caolán McNamara
AuthorDate: Thu Jun 30 16:28:47 2022 +0100
Commit: Caolán McNamara
CommitDate: Thu Jun 30 21:54:25 2022 +0200
tdf#149787 capture a copy of mpViewShell and mpView
so the callback can outlive the FuArea
Change-Id: I392ffa46b6f13795faef7284c1cae74428655b5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136679
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/ui/func/fuarea.cxx b/sd/source/ui/func/fuarea.cxx
index 2e35cac7b687..8dd7543e3ba0 100644
--- a/sd/source/ui/func/fuarea.cxx
+++ b/sd/source/ui/func/fuarea.cxx
@@ -59,10 +59,10 @@ void FuArea::DoExecute( SfxRequest& rReq )
VclPtr pDlg(
pFact->CreateSvxAreaTabDialog(mpViewShell->GetFrameWeld(), ,
mpDoc, true, bHasSlideBackground));
-pDlg->StartExecuteAsync([pDlg, this](sal_Int32 nResult){
+pDlg->StartExecuteAsync([pDlg, pView = this->mpView, pViewShell =
this->mpViewShell](sal_Int32 nResult){
if (nResult == RET_OK)
{
-mpView->SetAttributes (*(pDlg->GetOutputItemSet ()));
+pView->SetAttributes (*(pDlg->GetOutputItemSet ()));
// attributes changed, update Listboxes in Objectbars
static const sal_uInt16 SidArray[] = {
@@ -76,11 +76,11 @@ void FuArea::DoExecute( SfxRequest& rReq )
SID_ATTR_FILL_USE_SLIDE_BACKGROUND,
0 };
-mpViewShell->GetViewFrame()->GetBindings().Invalidate( SidArray );
+pViewShell->GetViewFrame()->GetBindings().Invalidate( SidArray );
}
// deferred until the dialog ends
-mpViewShell->Cancel();
+pViewShell->Cancel();
pDlg->disposeOnce();
});
[Libreoffice-bugs] [Bug 149795] New: Image in frame moving to the bottom of the page after CTRL+A/CTRL+X/CTRL+V
https://bugs.documentfoundation.org/show_bug.cgi?id=149795 Bug ID: 149795 Summary: Image in frame moving to the bottom of the page after CTRL+A/CTRL+X/CTRL+V Product: LibreOffice Version: 7.4.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Image in frame moving to the bottom of the page after CTRL+A/CTRL+X/CTRL+V Steps to Reproduce: 1. Open attachment 151496 (Bug 125352 2. CTRL+A 3. CTRL+X 4. CTRL+V Actual Results: Arrow image at the bottom of the page Expected Results: At the same spot, as on file open Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 089c91b1ad16232f130cb50266732509f83c52eb CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: threaded and in 7.0.7 (but differently) CTRL+A selection didn't include frames with Version: 6.2.9.0.0+ (x86) Build ID: 5f01fe15eb2661f1f9ce12d1d99dc2a705b462ee CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #11 from makisushi...@proton.me --- Created attachment 181046 --> https://bugs.documentfoundation.org/attachment.cgi?id=181046=edit Step 9 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #10 from makisushi...@proton.me --- Created attachment 181045 --> https://bugs.documentfoundation.org/attachment.cgi?id=181045=edit Step 8 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #9 from makisushi...@proton.me --- Created attachment 181044 --> https://bugs.documentfoundation.org/attachment.cgi?id=181044=edit Step 7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #8 from makisushi...@proton.me --- Created attachment 181043 --> https://bugs.documentfoundation.org/attachment.cgi?id=181043=edit Step 6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #7 from makisushi...@proton.me --- Created attachment 181042 --> https://bugs.documentfoundation.org/attachment.cgi?id=181042=edit Step 5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147199] CRASH: pasting twice and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=147199 --- Comment #20 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1d84ac1cd25022be13bd0c3f831f24b8edfee75d tdf#147199: sw_uiwriter3: Add unittest It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147199] CRASH: pasting twice and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=147199 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/data/tdf147199.docx |binary
sw/qa/extras/uiwriter/uiwriter3.cxx | 41 ++
2 files changed, 41 insertions(+)
New commits:
commit 1d84ac1cd25022be13bd0c3f831f24b8edfee75d
Author: Xisco Fauli
AuthorDate: Thu Jun 30 17:45:35 2022 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 30 21:31:50 2022 +0200
tdf#147199: sw_uiwriter3: Add unittest
Change-Id: I86fa740fd69e14afcb2effaa091db2b22477a7cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136680
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/uiwriter/data/tdf147199.docx
b/sw/qa/extras/uiwriter/data/tdf147199.docx
new file mode 100644
index ..f28894cadc90
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf147199.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 619e5c032549..e3127c2e3d1f 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -78,6 +78,47 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf145731)
CPPUNIT_ASSERT_EQUAL(1, getPages());
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf147199)
+{
+createSwDoc(DATA_DIRECTORY, "tdf147199.docx");
+
+CPPUNIT_ASSERT_EQUAL(7, getShapes());
+
+dispatchCommand(mxComponent, ".uno:SelectAll", {});
+Scheduler::ProcessEventsToIdle();
+
+dispatchCommand(mxComponent, ".uno:Cut", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(0, getShapes());
+
+dispatchCommand(mxComponent, ".uno:Paste", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(7, getShapes());
+
+dispatchCommand(mxComponent, ".uno:Paste", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(14, getShapes());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(7, getShapes());
+
+// Without the fix in place, this test would have crashed here
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(0, getShapes());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(7, getShapes());
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf139843)
{
createSwDoc(DATA_DIRECTORY, "tdf139843.odt");
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #6 from makisushi...@proton.me --- Created attachment 181041 --> https://bugs.documentfoundation.org/attachment.cgi?id=181041=edit Step 4 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #5 from makisushi...@proton.me --- Created attachment 181040 --> https://bugs.documentfoundation.org/attachment.cgi?id=181040=edit Step 3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #4 from makisushi...@proton.me --- Created attachment 181039 --> https://bugs.documentfoundation.org/attachment.cgi?id=181039=edit Step 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #3 from makisushi...@proton.me --- Created attachment 181038 --> https://bugs.documentfoundation.org/attachment.cgi?id=181038=edit Step 1 Attaching screenshots of the process for you (steps 1 to 9). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125619] 'performance problem with plenty comments' still in 6.3 alpha1, *only after save of file/autosave*
https://bugs.documentfoundation.org/show_bug.cgi?id=125619 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com --- Comment #25 from Gabor Kelemen (allotropia) --- I can reproduce the issue with the first attachment 154800 (about 10k cells filled with text+comment). Upon opening the file my system monitor reports about 280Mb memory use for soffice.bin, then saving the file as another name makes this go to about 900Mb, and even closing the file does not free this memory. Randomly pointing to cells and waiting for their comment box to show up also shows quite a bit of waves in CPU use. Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 9c796266470183f673eb58a8637dfe621eefa8b3 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149730] Wrong text about "external data" when opening a label document
https://bugs.documentfoundation.org/show_bug.cgi?id=149730 --- Comment #2 from makisushi...@proton.me --- Created attachment 181037 --> https://bugs.documentfoundation.org/attachment.cgi?id=181037=edit Sample Label Writer Document Thanks for your answer. Sample document attached. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148808] Redo doesn't restore the numbered list
https://bugs.documentfoundation.org/show_bug.cgi?id=148808 --- Comment #5 from Telesto --- (In reply to H.K. from comment #4) > @Telesto can you please be more specific on what you see as actual result > and does not meet expectations? > Would be useful to understand what is not working on redo, because I am > seeing everything being restored to it's initial state. The numbering is not restored on redo, so it looks like as the state on file-open. It did work once today, no clue why Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 089c91b1ad16232f130cb50266732509f83c52eb CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 125352, which changed state. Bug 125352 Summary: File with linked frames and inserted image in the second frame crashes on close (see comment 2) https://bugs.documentfoundation.org/show_bug.cgi?id=125352 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107656] [META] Frame bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107656 Bug 107656 depends on bug 125352, which changed state. Bug 125352 Summary: File with linked frames and inserted image in the second frame crashes on close (see comment 2) https://bugs.documentfoundation.org/show_bug.cgi?id=125352 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125352] File with linked frames and inserted image in the second frame crashes on close (see comment 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=125352 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||caol...@redhat.com, ||kelem...@ubuntu.com Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #7 from Gabor Kelemen (allotropia) --- I can't reproduce the crash (opening and closing attachment 151496) in 7.1 since: https://git.libreoffice.org/core/+/aeeea34074ebaeead66b81d78237361e096852ac author Caolán McNamara Wed Jun 03 20:01:52 2020 +0100 committer Caolán McNamara Fri Jun 05 11:08:30 2020 +0200 crashtesting: null deref Thanks Caolán! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149717] Systematic crash on resize of database table creation window
https://bugs.documentfoundation.org/show_bug.cgi?id=149717 --- Comment #6 from Noel Grandin --- This crash looks very much like what is mentioned here: https://www.mikeash.com/pyblog/friday-qa-2014-01-10-lets-break-cocoa.html where a NSView is added to itself. Noting that I cannot reproduce this on my Macbook. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148288] Row height changed by "Optimal height" is not stored in the file
https://bugs.documentfoundation.org/show_bug.cgi?id=148288 Rafael Lima changed: What|Removed |Added Summary|Row height is not stored|Row height changed by ||"Optimal height" is not ||stored in the file Blocks||125077 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125077 [Bug 125077] [META] regressions introduced by row height recalculation on document load -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125077] [META] regressions introduced by row height recalculation on document load
https://bugs.documentfoundation.org/show_bug.cgi?id=125077 Rafael Lima changed: What|Removed |Added Depends on||148288 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148288 [Bug 148288] Row height changed by "Optimal height" is not stored in the file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148139] Row height when text is wrapped is being lost after saving document
https://bugs.documentfoundation.org/show_bug.cgi?id=148139 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8288 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148288] Row height is not stored
https://bugs.documentfoundation.org/show_bug.cgi?id=148288 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8139 --- Comment #2 from Rafael Lima --- Repro with Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1 Calc: threaded And with Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded Row height is adjusted, but after saving, closing and reopening the file, row height returns to what it was before. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149792] Feature request: Preselect type of files in open dialog depending on the component in use
https://bugs.documentfoundation.org/show_bug.cgi?id=149792 Rafael Lima changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Rafael Lima --- Sounds an interest topic for discussion. Indeed, currently clicking "Open" will open a file picker with "All files" being shown. Maybe this could be improved. I'm CCing the UX team. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 149792] Feature request: Preselect type of files in open dialog depending on the component in use
https://bugs.documentfoundation.org/show_bug.cgi?id=149792 Rafael Lima changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Rafael Lima --- Sounds an interest topic for discussion. Indeed, currently clicking "Open" will open a file picker with "All files" being shown. Maybe this could be improved. I'm CCing the UX team. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149793] Undo search & replaced regex $ fails and causes major subsequent undo/redo problems
https://bugs.documentfoundation.org/show_bug.cgi?id=149793 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 140007 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Rafael Lima changed: What|Removed |Added Depends on||149778 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149778 [Bug 149778] Hyperlinks in comments need to flow as they do in Writer paragraphs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149778] Hyperlinks in comments need to flow as they do in Writer paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=149778 Rafael Lima changed: What|Removed |Added Blocks||106179 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Rafael Lima changed: What|Removed |Added Depends on||149778 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149778 [Bug 149778] Hyperlinks in comments need to flow as they do in Writer paragraphs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149778] Hyperlinks in comments need to flow as they do in Writer paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=149778 Rafael Lima changed: What|Removed |Added Blocks||107733 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107733 [Bug 107733] [META] Hyperlink bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149794] Double-clicking a word no longer selects it
https://bugs.documentfoundation.org/show_bug.cgi?id=149794 Rafael Lima changed: What|Removed |Added Version|7.4.0.0 beta1+ |7.5.0.0 alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149794] New: Double-clicking a word no longer selects it
https://bugs.documentfoundation.org/show_bug.cgi?id=149794 Bug ID: 149794 Summary: Double-clicking a word no longer selects it Product: LibreOffice Version: 7.4.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Since today, when you double-click a word in LO Writer 7.5 alpha, the word no longer is selected. Double-clicking a word and having it selected is a pretty standard behavior that stopped working with today's daily build. Was there a change about this? Now I have to triple-click a word to select it. Can anyone else confirm? System info Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 61f5c991a97de8990badfed6ef840941b5aa8c7f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: threaded The problem does not happen in Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149785] Read Error importing document
https://bugs.documentfoundation.org/show_bug.cgi?id=149785 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/accessibility/ChildrenManagerImpl.cxx | 35 +++
1 file changed, 30 insertions(+), 5 deletions(-)
New commits:
commit 8f9fd6806ccfbf381a383efe5d143ead86ee49de
Author: Noel Grandin
AuthorDate: Wed Jun 29 19:47:20 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 30 19:13:16 2022 +0200
tdf#137544 reduce cost of ChildrenManagerImpl::Update
there are 2 O(n^2) algorithms here, reduce them to O(n log n) by
pre-sorting
Change-Id: Ib3912155cda62cac95b5037528e23ef3c686a7e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136655
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx
b/svx/source/accessibility/ChildrenManagerImpl.cxx
index 56b47c74b710..d22f81e76684 100644
--- a/svx/source/accessibility/ChildrenManagerImpl.cxx
+++ b/svx/source/accessibility/ChildrenManagerImpl.cxx
@@ -316,6 +316,21 @@ void ChildrenManagerImpl::CreateListOfVisibleShapes (
}
}
+namespace
+{
+struct ChildDescriptorLess
+{
+bool operator()(const ChildDescriptor& lhs, const ChildDescriptor& rhs)
const
+{
+auto pLhsShape = lhs.mxShape.get();
+auto pRhsShape = rhs.mxShape.get();
+if (pLhsShape || pRhsShape)
+return pLhsShape < pRhsShape;
+return lhs.mxAccessibleShape.get() < rhs.mxAccessibleShape.get();
+}
+};
+}
+
void ChildrenManagerImpl::RemoveNonVisibleChildren (
const ChildDescriptorListType& rNewChildList,
ChildDescriptorListType& rOldChildList)
@@ -323,9 +338,16 @@ void ChildrenManagerImpl::RemoveNonVisibleChildren (
// Iterate over list of formerly visible children and remove those that
// are not visible anymore, i.e. member of the new list of visible
// children.
+
+// the lists have already been sorted in MergeAccessibilityInformation
+auto newIt = rNewChildList.begin();
+auto newEnd = rNewChildList.end();
+
for (auto& rChild : rOldChildList)
{
-if (::std::find(rNewChildList.begin(), rNewChildList.end(), rChild) ==
rNewChildList.end())
+while (newIt != newEnd && ChildDescriptorLess()(*newIt, rChild))
+newIt++;
+if (newIt == newEnd || !(*newIt == rChild) )
{
// The child is disposed when there is a UNO shape from which
// the accessible shape can be created when the shape becomes
@@ -349,16 +371,19 @@ void ChildrenManagerImpl::RemoveNonVisibleChildren (
void ChildrenManagerImpl::MergeAccessibilityInformation (
ChildDescriptorListType& raNewChildList)
{
-ChildDescriptorListType::const_iterator aStartVisibleChildren =
maVisibleChildren.begin();
+// sort the lists by mxShape, and then walk them in parallel, which avoids
an O(n^2) loop
+std::sort(maVisibleChildren.begin(), maVisibleChildren.end(),
ChildDescriptorLess());
+std::sort(raNewChildList.begin(), raNewChildList.end(),
ChildDescriptorLess());
+ChildDescriptorListType::const_iterator aOldChildDescriptor =
maVisibleChildren.begin();
ChildDescriptorListType::const_iterator aEndVisibleChildren =
maVisibleChildren.end();
for (auto& rChild : raNewChildList)
{
-ChildDescriptorListType::const_iterator aOldChildDescriptor =
-std::find(aStartVisibleChildren, aEndVisibleChildren, rChild);
+while (aOldChildDescriptor != aEndVisibleChildren &&
ChildDescriptorLess()(*aOldChildDescriptor, rChild))
+aOldChildDescriptor++;
// Copy accessible shape if that exists in the old descriptor.
-if (aOldChildDescriptor != aEndVisibleChildren &&
+if (aOldChildDescriptor != aEndVisibleChildren && *aOldChildDescriptor
== rChild &&
aOldChildDescriptor->mxAccessibleShape.is())
{
rChild.mxAccessibleShape = aOldChildDescriptor->mxAccessibleShape;
[Libreoffice-bugs] [Bug 137544] Opening complex electric PDF drawing is very slow with high CPU in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=137544 --- Comment #9 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8f9fd6806ccfbf381a383efe5d143ead86ee49de tdf#137544 reduce cost of ChildrenManagerImpl::Update It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149785] Read Error importing document
https://bugs.documentfoundation.org/show_bug.cgi?id=149785 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149785] Read Error importing document
https://bugs.documentfoundation.org/show_bug.cgi?id=149785 --- Comment #2 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e64e4e373e43e9490dda4b778424dbef6d6f1299 tdf#149785 Read Error importing document It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/source sfx2/source
oox/source/drawingml/table/tablecell.cxx |3 ++-
sfx2/source/doc/objstor.cxx |1 +
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit e64e4e373e43e9490dda4b778424dbef6d6f1299
Author: Noel Grandin
AuthorDate: Thu Jun 30 11:45:11 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 30 19:12:52 2022 +0200
tdf#149785 Read Error importing document
after
commit 04073c5fedd33654f242fecb7e39afb07cf0e273
Author: Noel Grandin
Date: Tue Jun 21 13:17:09 2022 +0200
replace oox::OptValue with std::optional
and add a SAL_WARN to make this easier to diagnose in the future
Change-Id: Ia5be0b82e3a5df34f50bc8a2decb1de98e0c5556
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136665
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/oox/source/drawingml/table/tablecell.cxx
b/oox/source/drawingml/table/tablecell.cxx
index 8cff610763fc..d979fb54e63f 100644
--- a/oox/source/drawingml/table/tablecell.cxx
+++ b/oox/source/drawingml/table/tablecell.cxx
@@ -502,7 +502,8 @@ void TableCell::pushToXCell( const
::oox::core::XmlFilterBase& rFilterBase, cons
applyLineAttributes( rFilterBase, xPropSet, aLinePropertiesInsideV,
PROP_RightBorder );
}
-if (rProperties.getBgColor().isUsed() &&
!maFillProperties.maFillColor.isUsed() && maFillProperties.moFillType.value()
== XML_noFill)
+if (rProperties.getBgColor().isUsed() &&
!maFillProperties.maFillColor.isUsed() &&
+maFillProperties.moFillType.value_or(0) == XML_noFill)
{
maFillProperties.moFillType = XML_solidFill;
maFillProperties.maFillColor = rProperties.getBgColor();
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 288b6a7ae6a9..6e406d332f9a 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2333,6 +2333,7 @@ bool SfxObjectShell::ImportFrom(SfxMedium& rMedium,
{
const char *msg = e.what();
const OUString sError(msg, strlen(msg), RTL_TEXTENCODING_ASCII_US);
+SAL_WARN("sfx.doc", "exception importing " << sError);
SetError(*new StringErrorInfo(ERRCODE_SFX_DOLOADFAILED,
sError, DialogMask::ButtonsOk | DialogMask::MessageError));
}
[Libreoffice-bugs] [Bug 149781] Spanish translation is missing in some strings in the Language Configuration Options
https://bugs.documentfoundation.org/show_bug.cgi?id=149781 --- Comment #6 from Albert Acer --- I agree that "Lightproof" should not be translated because it refers to the proper name of a dictionary. However, I also completely agree with Adolfo's opinion when he indicates that the last two words of the string "Lightproof grammar checker" must be translated, that is "Grammar Checker" whose translation in Spanish is "Revisor gramatical". This is important for common Spanish LO users, those who don't know any English. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 149781] Spanish translation is missing in some strings in the Language Configuration Options
https://bugs.documentfoundation.org/show_bug.cgi?id=149781 --- Comment #6 from Albert Acer --- I agree that "Lightproof" should not be translated because it refers to the proper name of a dictionary. However, I also completely agree with Adolfo's opinion when he indicates that the last two words of the string "Lightproof grammar checker" must be translated, that is "Grammar Checker" whose translation in Spanish is "Revisor gramatical". This is important for common Spanish LO users, those who don't know any English. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148808] Redo doesn't restore the numbered list
https://bugs.documentfoundation.org/show_bug.cgi?id=148808 H.K. changed: What|Removed |Added CC||holaszk...@ymail.com --- Comment #4 from H.K. --- System info OS Name: Microsoft Windows 10 Pro OS Version: 10.0.19044 N/A Build 19044 System Type: x64-based PC Input Locale: en-us; English (United States) LibreOffice Writer Version: 7.3.4.2 I have tried reproducing this issue with latest stable version on the specified system configuration above and I am not able to see anything not working on the Redo option while using numbered lists. System info OS Name: MacOS Monterey OS version: 12.1 Input Locale: en-us; English (United States) LibreOffice Writer Version: 7.4.0.0.alpha1 I have also tried in MacOS, using 7.4.alpha version, but I am not seeing anything working unexpectedly in the Redo button, neither using Ctrl+Y to redo the changes. @Telesto can you please be more specific on what you see as actual result and does not meet expectations? Would be useful to understand what is not working on redo, because I am seeing everything being restored to it's initial state. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1a021823f3c49f936e5e9d740294fd77c91e0fc1 Author: Martin Srebotnjak AuthorDate: Thu Jun 30 18:41:22 2022 +0200 Commit: Gerrit Code Review CommitDate: Thu Jun 30 18:41:22 2022 +0200 Update git submodules * Update translations from branch 'libreoffice-7-4' to 984bc1116845bd13606b8d0956120f10a6e19eaa - Updated Slovenian translation Change-Id: I5d1a444818c3febfb906010a127fb402d7931291 diff --git a/translations b/translations index e67b3be07b65..984bc1116845 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit e67b3be07b65b2ce12d17d948e428d408652e587 +Subproject commit 984bc1116845bd13606b8d0956120f10a6e19eaa
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-4' - source/sl
source/sl/cui/messages.po | 14 source/sl/filter/messages.po |4 source/sl/helpcontent2/source/text/sbasic/guide.po | 14 source/sl/helpcontent2/source/text/sbasic/shared.po| 12 source/sl/helpcontent2/source/text/sbasic/shared/03.po | 14 source/sl/helpcontent2/source/text/scalc/01.po | 222 +++-- source/sl/helpcontent2/source/text/scalc/guide.po | 126 +++ source/sl/helpcontent2/source/text/sdatabase.po|6 source/sl/helpcontent2/source/text/shared/00.po| 16 source/sl/helpcontent2/source/text/shared/01.po| 16 source/sl/helpcontent2/source/text/shared/guide.po | 26 - source/sl/helpcontent2/source/text/shared/optionen.po |4 source/sl/helpcontent2/source/text/simpress.po |4 source/sl/helpcontent2/source/text/smath/guide.po |4 source/sl/helpcontent2/source/text/swriter/00.po |4 source/sl/helpcontent2/source/text/swriter/01.po | 108 +- source/sl/helpcontent2/source/text/swriter/04.po | 12 source/sl/helpcontent2/source/text/swriter/guide.po|4 source/sl/helpcontent2/source/text/swriter/librelogo.po| 16 source/sl/officecfg/registry/data/org/openoffice/Office.po |4 source/sl/oox/messages.po |7 source/sl/sd/messages.po |4 source/sl/svtools/messages.po |4 source/sl/svx/messages.po |4 source/sl/sw/messages.po |6 25 files changed, 446 insertions(+), 209 deletions(-) New commits: commit 984bc1116845bd13606b8d0956120f10a6e19eaa Author: Martin Srebotnjak AuthorDate: Thu Jun 30 18:41:07 2022 +0200 Commit: Andras Timar CommitDate: Thu Jun 30 18:41:07 2022 +0200 Updated Slovenian translation Change-Id: I5d1a444818c3febfb906010a127fb402d7931291 diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index 386a996f1af..c847bb4b069 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,8 +3,8 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.4\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-06-24 13:03+0200\n" -"PO-Revision-Date: 2022-06-24 22:10+0200\n" +"POT-Creation-Date: 2022-06-30 10:48+0200\n" +"PO-Revision-Date: 2022-06-30 15:57+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" "Language: sl\n" @@ -9979,12 +9979,12 @@ msgstr "Uporabite osnovni URL, t.j. brez »/check« na koncu." #: cui/uiconfig/ui/langtoolconfigpage.ui:174 msgctxt "langtoolconfigpage|usernamedesc" msgid "Your LanguageTool account’s username for premium usage." -msgstr "Uporabniško ime vašega računa LanguageTool za premijsko rabo." +msgstr "Uporabniško ime vašega računa LanguageTool za rabo naprednih storitev." #: cui/uiconfig/ui/langtoolconfigpage.ui:189 msgctxt "langtoolconfigpage|apikeydesc" msgid "Your LanguageTool account’s API key for premium usage." -msgstr "Ključ API vašega računa LanguageTool za premijsko rabo." +msgstr "Ključ API vašega računa LanguageTool za rabo naprednih storitev." #: cui/uiconfig/ui/langtoolconfigpage.ui:215 msgctxt "langtoolconfigpage|apisettingsheader" @@ -16754,8 +16754,8 @@ msgstr "_Vstavi" #: cui/uiconfig/ui/specialcharacters.ui:109 msgctxt "specialcharacters|subsetft" -msgid "Subset:" -msgstr "Podmnožica:" +msgid "Character block:" +msgstr "Znakovni blok:" #: cui/uiconfig/ui/specialcharacters.ui:123 msgctxt "specialcharacters|fontft" @@ -16807,7 +16807,7 @@ msgctxt "specialcharacters|favbtn|symboltext2" msgid "Favorite Characters:" msgstr "Priljubljeni znaki:" -#: cui/uiconfig/ui/specialcharacters.ui:906 +#: cui/uiconfig/ui/specialcharacters.ui:903 msgctxt "specialcharacters|extended_tip|SpecialCharactersDialog" msgid "Allows a user to insert characters from the range of symbols found in the installed fonts." msgstr "Omogoča uporabniku vstavljanje posebnih znakov iz nabora simbolov v nameščenih pisavah." diff --git a/source/sl/filter/messages.po b/source/sl/filter/messages.po index d1c0be17e05..fb834f6f2c5 100644 --- a/source/sl/filter/messages.po +++ b/source/sl/filter/messages.po @@ -3,14 +3,14 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 7.4\n" "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n; -"POT-Creation-Date: 2022-06-24 13:03+0200\n" +"POT-Creation-Date: 2022-06-30 10:49+0200\n" "PO-Revision-Date: 2022-06-24 22:19+0200\n" "Last-Translator: Martin Srebotnjak \n" "Language-Team: sl.libreoffice.org\n" -"Language: sl\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n"
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Bug 85811 depends on bug 149643, which changed state. Bug 149643 Summary: Shape group or ungroup located in wrong menu https://bugs.documentfoundation.org/show_bug.cgi?id=149643 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WONTFIX |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149643] Shape group or ungroup located in wrong menu
https://bugs.documentfoundation.org/show_bug.cgi?id=149643 Eyal Rozenberg changed: What|Removed |Added Resolution|WONTFIX |--- Ever confirmed|1 |0 Status|RESOLVED|UNCONFIRMED Summary|Add Shape main menu in to |Shape group or ungroup |Impress |located in wrong menu --- Comment #10 from Eyal Rozenberg --- Wait a minute. This won't do. The issue title was changed only because there seemed to be consensus about the solution. Nobody objected before, and now this is set to WF? No way. Whoever wants to not-adopt the proposed solution should suggest their own. Reverting title to the original. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149793] New: Undo search & replaced regex $ fails and causes major subsequent undo/redo problems
https://bugs.documentfoundation.org/show_bug.cgi?id=149793 Bug ID: 149793 Summary: Undo search & replaced regex $ fails and causes major subsequent undo/redo problems Product: LibreOffice Version: 7.3.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: will.fried...@gmail.com Description: If one searches for the regex $ and replaces it, undo only undoes the replacement but does not replace the end-of-paragraph marker, resulting in further broken undo/redo behavior that ultimately causes !!br0ken!! to appear multiples times. Steps to Reproduce: 1. Open a new document. Turn on View | Formatting Marks just to make sure you can see what's happening clearly. (This doesn't affect the bug, it happens with this option on or off.) 2. Type the letter A followed by a hard return, the letter B followed by a hard return, and C. If you turned on formatting marks, you should see A, B, and C followed by an end-of-paragraph (EOP) mark. 3. Open Find and Replace. Put $ in the search box. Put a space (or anything) in the replace box. Make sure "Regular Expressions" is checked under "other options." Hit Replace All. ABC should now appear on one line, followed by a single EOP mark. 4. Now hit undo. Whatever you replaced $ with is gone, but ABC is still on one line, followed by an EOP mark, and two EOP marks have returned below that line. The cursor is after the A. 5. Now hit undo again. Cursor goes to the beginning of the third line, as if the letter C had been erased. 6. Now hit undo again. Cursor jumps up as if B had just been erased. The EOP mark on the third line is gone. EOP mark on the second line is still there. 7. Now hit undo again. Nothing happens. 8. Now hit undo again. EOP mark on the second line disappears, cursor jumps after the A. 9. Now hit undo again. A disappears. BC and EOP mark still on first line. 10. Undo is unavailable. Now hit redo. A returns. 11. Hit redo. EOP mark appears after A, BC followed by EOP mark goes to next line. 12. Hit redo. !!br0ken!! appears before BC followed by EOP mark. 13. Hit redo. An EOP mark is inserted, moving "!br0ken!!BC" to the next line. 14. Hit redo. !!br0ken!! appears. 15. Hit redo again. The EOP markers are removed and replaced by whatever you replaced the EOP markers with in your first search-and-replace. 16. This sequence can be repeated ad infinitum. Actual Results: As described above. Expected Results: The actual results of the replace of the EOP makers should be undone. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147631] The Chinese IME in Windows 10 doesn't work correctly in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=147631 peterho0...@yahoo.com.hk changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #3 from peterho0...@yahoo.com.hk --- I've tried version 7.3.4.2 too. It seems that the problem has gone. Thank you so much. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149787] CRASH: closing area dialog after closing Add color palette via extension dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=149787 Caolán McNamara changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | Status|NEW |ASSIGNED --- Comment #3 from Caolán McNamara --- I feel that commit is innocent for why it crashes, maybe just adds more "stuff" so a use after free is more likely to crash. https://gerrit.libreoffice.org/c/core/+/136679 seems to work for me to avoid the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89623] SVG images used for Headers and Footers in Calc are being converted to a raster preview and are not rendered as vector for print or export
https://bugs.documentfoundation.org/show_bug.cgi?id=89623 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=51 ||510 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=51510 Gabor Kelemen (allotropia) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||623 -- You are receiving this mail because: You are the assignee for the bug.
