[Libreoffice-bugs] [Bug 150111] LibreOffice crashes on launch with a KERNELBASE.dll error unless Hardware Acceleration is off

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150111

--- Comment #11 from Melvin Hausmann  ---
Thank you. I set all [...]Common/VCL props to false, LO works fine.
Even my skia.log has info in it. Funny enough, seems to be the same as vkview.
Ain't consistent Data wonderful?
"RenderMethod: vulkan
Vendor: 0x10de
Device: 0x2489
API: 1.3.205
Driver: 516.236.0
DeviceType: discrete
DeviceName: NVIDIA GeForce RTX 3060 Ti
Denylisted: no"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142628] Wrong Icons for "Field", "Field by type" and "Recency" in Navigator's Navigate By Drop Down Menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142628

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |5817|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115817] Correct implementation or remove the Navigation toolbar (a GSOC 2009 contribution see bug 32869) (comment 3 for history and functional intent)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2628

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142628] Wrong Icons for "Field", "Field by type" and "Recency" in Navigator's Navigate By Drop Down Menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142628

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5817

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115817] Correct implementation or remove the Navigation toolbar (a GSOC 2009 contribution see bug 32869) (comment 3 for history and functional intent)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |2628|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146270] Empty image frames after scrolling down a document. Disabling show changes & scrolling up

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146270

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   Keywords|bibisectRequest, regression |
 Resolution|--- |WORKSFORME

--- Comment #6 from Telesto  ---
No issue
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bb4314aa21baec08268e0f02b816a8cf05096ceb
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115817] Correct implementation or remove the Navigation toolbar (a GSOC 2009 contribution see bug 32869) (comment 3 for history and functional intent)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2628

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142628] Wrong Icons for "Field", "Field by type" and "Recency" in Navigator's Navigate By Drop Down Menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142628

Rizal Muttaqin  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5817

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145226] MSWord 2019 doesn't open odt files with tables created by LibreOffice

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145226

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145226] MSWord 2019 doesn't open odt files with tables created by LibreOffice

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145226

--- Comment #9 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a9fe1d80ea977c439dd10ee2056abe6b0cb4d07

tdf#145226 sw: ODF export: fix table-row/table-cell styles

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

2022-07-31 Thread Michael Stahl (via logerrit)
 sw/source/filter/xml/xmlexp.hxx   |4 
 sw/source/filter/xml/xmlfmte.cxx  |6 -
 sw/source/filter/xml/xmliteme.cxx |2 
 sw/source/filter/xml/xmltble.cxx  |  157 --
 sw/source/filter/xml/xmltexte.hxx |   12 ++
 5 files changed, 103 insertions(+), 78 deletions(-)

New commits:
commit 5a9fe1d80ea977c439dd10ee2056abe6b0cb4d07
Author: Michael Stahl 
AuthorDate: Fri Jul 29 17:00:14 2022 +0200
Commit: Michael Stahl 
CommitDate: Sun Jul 31 14:22:56 2022 +0200

tdf#145226 sw: ODF export: fix table-row/table-cell styles

The SwFrameFormat for table lines and table boxes gets an auto-generated
name in SwDoc::MakeTableBoxFormat()/MakeTableLineFormat().

The problem is that xmltble.cxx assumes that these SwFrameFormats never
have a name, and sets names on them temporarily during
exportTextAutoStyles(), then later reads them when exporting the
table-rows and table-cells, then eventually resets them all to an empty
name.

One issue is that it assumes that a non-empty SwFrameFormat name
indicates a style has been exported, but that isn't always the case, and
the name may still be an auto-generated one.

Another issue is that overwriting the names interferes with the use of
the names in Undo operations.

So store the name for the ODF styles in members of the filter classes
instead of the core model.

(regression from commit 083fe09958658de8c3da87a28e0f8ff7b3b8a5e9)

Change-Id: I9b17962decbf9f8ecd2a91551230cf0f012e7a9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127548
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/filter/xml/xmlexp.hxx b/sw/source/filter/xml/xmlexp.hxx
index 53ab4431c645..86b919ac95a7 100644
--- a/sw/source/filter/xml/xmlexp.hxx
+++ b/sw/source/filter/xml/xmlexp.hxx
@@ -24,6 +24,7 @@
 #include "xmlitmap.hxx"
 #include 
 
+#include 
 #include 
 #include 
 
@@ -75,7 +76,8 @@ class SwXMLExport : public SvXMLExport
  SwXMLTableInfo_Impl& rTableInfo,
  bool bTop=false );
 
-void ExportFormat( const SwFormat& rFormat,  enum 
::xmloff::token::XMLTokenEnum eClass );
+void ExportFormat(const SwFormat& rFormat, enum 
::xmloff::token::XMLTokenEnum eClass,
+::std::optional const oStyleName);
 void ExportTableFormat( const SwFrameFormat& rFormat, sal_uInt32 nAbsWidth 
);
 
 void ExportTableColumnStyle( const SwXMLTableColumn_Impl& rCol );
diff --git a/sw/source/filter/xml/xmlfmte.cxx b/sw/source/filter/xml/xmlfmte.cxx
index 60e650e48e72..f0a6aab224d3 100644
--- a/sw/source/filter/xml/xmlfmte.cxx
+++ b/sw/source/filter/xml/xmlfmte.cxx
@@ -46,7 +46,8 @@ using namespace ::com::sun::star::drawing;
 using namespace ::com::sun::star::lang;
 using namespace ::xmloff::token;
 
-void SwXMLExport::ExportFormat( const SwFormat& rFormat, enum XMLTokenEnum 
eFamily )
+void SwXMLExport::ExportFormat(const SwFormat& rFormat, enum XMLTokenEnum 
eFamily,
+::std::optional const oStyleName)
 {
 // 
 CheckAttrList();
@@ -57,9 +58,10 @@ void SwXMLExport::ExportFormat( const SwFormat& rFormat, 
enum XMLTokenEnum eFami
 return;
 OSL_ENSURE( eFamily != XML_TOKEN_INVALID, "family must be specified" );
 // style:name="..."
+assert(oStyleName || (eFamily != XML_TABLE_ROW && eFamily != 
XML_TABLE_CELL));
 bool bEncoded = false;
 AddAttribute( XML_NAMESPACE_STYLE, XML_NAME, EncodeStyleName(
-rFormat.GetName(),  ) );
+oStyleName ? *oStyleName : rFormat.GetName(), ) );
 if( bEncoded )
 AddAttribute( XML_NAMESPACE_STYLE, XML_DISPLAY_NAME, rFormat.GetName() 
);
 
diff --git a/sw/source/filter/xml/xmliteme.cxx 
b/sw/source/filter/xml/xmliteme.cxx
index 3989fb59b7cd..a8fbc712ac90 100644
--- a/sw/source/filter/xml/xmliteme.cxx
+++ b/sw/source/filter/xml/xmliteme.cxx
@@ -240,7 +240,7 @@ void SwXMLExport::ExportTableFormat( const SwFrameFormat& 
rFormat, sal_uInt32 nA
 {
 static_cast(m_pTableItemMapper.get())
 ->SetAbsWidth( nAbsWidth );
-ExportFormat( rFormat, XML_TABLE );
+ExportFormat(rFormat, XML_TABLE, {});
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/xml/xmltble.cxx b/sw/source/filter/xml/xmltble.cxx
index 0da423d4e450..81528e5b8c2f 100644
--- a/sw/source/filter/xml/xmltble.cxx
+++ b/sw/source/filter/xml/xmltble.cxx
@@ -185,13 +185,18 @@ class SwXMLTableFrameFormatsSort_Impl
 {
 private:
 SwXMLFrameFormats_Impl m_aFormatList;
+SwXMLTextParagraphExport::FormatMap & m_rFormatMap;
+
 public:
-bool AddRow( SwFrameFormat& rFrameFormat, std::u16string_view rNamePrefix, 
sal_uInt32 nLine );
-bool AddCell( SwFrameFormat& rFrameFormat, std::u16string_view rNamePrefix,
+SwXMLTableFrameFormatsSort_Impl(SwXMLTextParagraphExport::FormatMap & 
rFormatMap)
+: m_rFormatMap(rFormatMap)
+{}
+

[Libreoffice-bugs] [Bug 150012] Line numbering should go in Formatting menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150012

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Line numbering isn't formatting. It's more a view option. But I agree with
Dieter

So, here is my -1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150012] Line numbering should go in Formatting menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150012

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Line numbering isn't formatting. It's more a view option. But I agree with
Dieter

So, here is my -1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

GSoC status report - Week 10

2022-07-31 Thread Paris Oplopoios
Started work on combining GraphicDescriptor and GraphicFormatDetector
graphic detection (patch )

Next:
Continue combining work


[Libreoffice-bugs] [Bug 144506] LO Base PUBLIC schema table data window shows no records

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144506

--- Comment #11 from Andrew Richardson  ---
Created attachment 181509
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181509=edit
Demo BASE file demonstrating bad behaviour

Created a Demo BASE file with an embedded database demonstrating bad behaviour.
 The tree of tables is NOT displayed with the different schemas shown as parent
nodes.  All tables can be opened EXCEPT for "TEMP_CAMP_DETAIL", which is owned
by a non-PUBLIC schema.  Suspect fixing the root cause of bug will allow all
tables to be opened.

Expected behaviour is the tree view will show every schema name, then all table
names within that schema as children nodes.  For the Demo case, the schemas are
"PUBLIC" and "BOARS_USER1".  Under "BOARS_USER1", only "TEMP_CAMP_DETAIL"
should be listed.  All other tables would appear under "PUBLIC" schema.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144506] LO Base PUBLIC schema table data window shows no records

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144506

--- Comment #10 from Andrew Richardson  ---
Created attachment 181508
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181508=edit
Screen capture showing table tree in working version

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150201] Opening certain wmf files fail

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150201

--- Comment #8 from Hossein  ---
Created attachment 181507
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181507=edit
WMF file with placeable header: tdf88163-wrong-font-size.wmf

The is the example file from core repository:

emfio/qa/cppunit/wmf/data/tdf88163-wrong-font-size.wmf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150206] New: FILESAVE as RTF in Writer is given wrong fcharset in the standard font

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150206

Bug ID: 150206
   Summary: FILESAVE as RTF in Writer is given wrong fcharset in
the standard font
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bernard.more...@gmx.co.uk

Description:
When a simple file is saved AS RTF, the (Roman-style) font in use is saved in
the fonttbl with \fcharset128 (= Shift Jis).  If a character is then changed in
the RTF to an accented form, this then displays as a fr-eastern character
instead of a (European) unicode.
The normal setting should be \fcharset1 (= Default).

Steps to Reproduce:
1.Create a new document in Writer
2.Save as RTF
3.

Actual Results:
\fcharset128 set for the font in use (Book Antiqua)

Expected Results:
\fcharset1 should have been set for the font in use


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 7.3.5.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Ubuntu package version: 1:7.3.5~rc2-0ubuntu0.20.04.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85811

Dieter  changed:

   What|Removed |Added

 Depends on||150012


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150012
[Bug 150012] Line numbering should go in Formatting menu
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150012] Line numbering should go in Formatting menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150012

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Blocks||85811

--- Comment #1 from Dieter  ---
Peter, thank you for suggestion. Let's ask design team for their input and
decision. Personally I won't support that idea. On the one hand I agree, that
"Tools" ist more like a container for severla featurees, but on the otherhand:
- We would have to change Lo Help and Writer Guide (a lot of work)
- List of entries in "Format" menu is already very long (we should avoid
scolling in a menu)
- You can customize menu structure

cc: Design-Team


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150012] Line numbering should go in Formatting menu

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150012

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Blocks||85811

--- Comment #1 from Dieter  ---
Peter, thank you for suggestion. Let's ask design team for their input and
decision. Personally I won't support that idea. On the one hand I agree, that
"Tools" ist more like a container for severla featurees, but on the otherhand:
- We would have to change Lo Help and Writer Guide (a lot of work)
- List of entries in "Format" menu is already very long (we should avoid
scolling in a menu)
- You can customize menu structure

cc: Design-Team


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 150154] Axis Format in Libre Office Calc Does Not Change

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150154

--- Comment #5 from raal  ---
Created attachment 181506
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181506=edit
added second chart

I think because you have not added date axe. Try to edit chart and LO will make
visual borders of source data. Column with date is not as a source. Look at my
attachment, I've added new chart. btw you have mistakes in date column, check
the dates.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/qa sc/source

2022-07-31 Thread Noel Grandin (via logerrit)
 sc/qa/unit/tiledrendering/tiledrendering.cxx |   80 +++
 sc/source/ui/inc/undomanager.hxx |2 
 sc/source/ui/undo/undobase.cxx   |   44 +++---
 3 files changed, 116 insertions(+), 10 deletions(-)

New commits:
commit 80cdfe4512a66ab58e0ae27c9fafad601c2f84b2
Author: Noel Grandin 
AuthorDate: Sat Jul 30 09:02:31 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jul 31 09:27:23 2022 +0200

sc, out of order undo: allow a subset of a non-empty redo list

This is the calc analogue of
commit 60665dc4a2af238939b1a5056ae4a4ce2c083159
sw, out of order undo: allow a subset of a non-empty redo list

Specifically, we used to not allow out of order undo at all if the redo
list was non-empty. This relaxes that condition a bit. Out of order undo
is OK with a non-empty redo list, in case all undo actions in the redo
list are either

1) owned by the current view or

2) independent from the undo action to be executed

I.e. if view1 has lots of type undo actions and an view2 adds a
single type undo action on top of it, then allow view 1 to execute
multiple of its typing undo actions, not just a single one.

Change-Id: Ib7ab88e9ebbefce267d3c7d567debd1cd98d7d6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137628
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index f8498fae1b95..9ed5cf471269 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -129,6 +129,7 @@ public:
 void testCommentCellCopyPaste();
 void testInvalidEntrySave();
 void testUndoReordering();
+void testUndoReorderingRedo();
 
 CPPUNIT_TEST_SUITE(ScTiledRenderingTest);
 CPPUNIT_TEST(testRowColumnHeaders);
@@ -187,6 +188,7 @@ public:
 CPPUNIT_TEST(testCommentCellCopyPaste);
 CPPUNIT_TEST(testInvalidEntrySave);
 CPPUNIT_TEST(testUndoReordering);
+CPPUNIT_TEST(testUndoReorderingRedo);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -3047,6 +3049,84 @@ void ScTiledRenderingTest::testUndoReordering()
 CPPUNIT_ASSERT_EQUAL(std::size_t(0), pUndoManager->GetUndoActionCount());
 }
 
+void ScTiledRenderingTest::testUndoReorderingRedo()
+{
+ScModelObj* pModelObj = createDoc("empty.ods");
+CPPUNIT_ASSERT(pModelObj);
+ScDocument* pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+ScUndoManager* pUndoManager = pDoc->GetUndoManager();
+CPPUNIT_ASSERT(pUndoManager);
+CPPUNIT_ASSERT_EQUAL(std::size_t(0), pUndoManager->GetUndoActionCount());
+
+// view #1
+int nView1 = SfxLokHelper::getView();
+ViewCallback aView1;
+
+// view #2
+SfxLokHelper::createView();
+int nView2 = SfxLokHelper::getView();
+
pModelObj->initializeForTiledRendering(uno::Sequence());
+ViewCallback aView2;
+
+// text edit a cell in view #1
+SfxLokHelper::setView(nView1);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN);
+Scheduler::ProcessEventsToIdle();
+CPPUNIT_ASSERT_EQUAL(std::size_t(1), pUndoManager->GetUndoActionCount());
+
+// text edit another cell in view #1
+SfxLokHelper::setView(nView1);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'y', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'y', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'y', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'y', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN);
+Scheduler::ProcessEventsToIdle();
+CPPUNIT_ASSERT_EQUAL(std::size_t(2), pUndoManager->GetUndoActionCount());
+CPPUNIT_ASSERT_EQUAL(OUString("xx"), pDoc->GetString(ScAddress(0, 0, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("yy"), pDoc->GetString(ScAddress(0, 1, 0)));
+
+// text edit a different cell in view #2
+SfxLokHelper::setView(nView2);
+ScTabViewShell* pView2 = 
dynamic_cast(SfxViewShell::Current());
+pView2->SetCursor(0, 2);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'C', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'C', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'C', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'C', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN);
+Scheduler::ProcessEventsToIdle();
+CPPUNIT_ASSERT_EQUAL(std::size_t(3), pUndoManager->GetUndoActionCount());
+

[Libreoffice-bugs] [Bug 150205] De-emphasize freetext search

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150205

--- Comment #1 from ajlittoz  ---
Off topic: is this freetext search Windows-specific? I never met it under my
Linux configuration (Fedora).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142108] Calc chart loses data number formatting in new source Data Table when copied to non calc LibO document (Writer, Draw)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142108

Rainer Bielefeld Retired  changed:

   What|Removed |Added

Version|7.1.2.2 release |Inherited From OOo

--- Comment #7 from Rainer Bielefeld Retired  
---
a) OS = All due to Bug 150198 
b) I already see this in oOO 3.2.0. so probably this never worked 
c)Bug or RfE, that is the question here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150198] Diagrams copied from Calc loose formatting (percentage) in data series and axis

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150198

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Rainer Bielefeld Retired  
---
c) Bug 68942 is limited to pasting in particular format.
   So this one is a DUP of Bug 142108

*** This bug has been marked as a duplicate of bug 142108 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142108] Calc chart loses data number formatting in new source Data Table when copied to non calc LibO document (Writer, Draw)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142108

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||a...@madspunky.net

--- Comment #6 from Rainer Bielefeld Retired  
---
*** Bug 150198 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142108] Calc chart loses data number formatting in new source Data Table when copied to non calc LibO document (Writer, Draw)

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142108

Rainer Bielefeld Retired  changed:

   What|Removed |Added

Summary|Calc chart loses number |Calc chart loses data
   |formatting on bars when |number formatting in new
   |pasted in Writer doc wher   |source Data Table when
   |shows all decimal parts |copied to non calc LibO
   |instead of using original   |document (Writer, Draw)
   |format setting  |
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #5 from Rainer Bielefeld Retired  
---
I updated Summary to root of the problem
Please also see comment and screenshot in Bug 150198 Comment 9

Still REPRODUCIBLE with Server Installation of Version: 7.5.0.0.alpha0+  Build
ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU-Threads: 4; BS: Windows 6.1 Service Pack 1 Build 7601; UI-Render:
Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL |  Auto Colibre Theme  |  Special devUserProfile  (based on my normal
one)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150205] De-emphasize freetext search

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150205

Mike Kaganski  changed:

   What|Removed |Added

URL||https://ask.libreoffice.org
   ||/t/how-to-show-hide-hidden-
   ||text-in-writer/80051/10

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150205] New: De-emphasize freetext search

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150205

Bug ID: 150205
   Summary: De-emphasize freetext search
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com
CC: olivier.hal...@libreoffice.org

In our help, the topmost bar (with product name, module and language selectors)
has also a freetext search box (using "Omega Search" engine).

Personally I never found it useful (also before the engine switch, when it used
Google search IIRC); the relevance of results was always awful. On the other
side, Index search gives *much* better results in my experience.

I realize that my use might not be the most typical; but e.g.
https://ask.libreoffice.org/t/how-to-show-hide-hidden-text-in-writer/80051/10
shows that others may be hit by that, too.

So the proposal is to de-emphasize somehow the freetext search, to be secondary
to Index search.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: writerfilter/source writerperfect/inc writerperfect/source

2022-07-31 Thread Noel Grandin (via logerrit)
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |5 +-
 writerfilter/source/dmapper/DomainMapperTableHandler.hxx |2 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx|9 ++-
 writerfilter/source/dmapper/DomainMapper_Impl.hxx|   37 +++
 writerfilter/source/dmapper/FontTable.cxx|5 +-
 writerfilter/source/dmapper/FontTable.hxx|2 
 writerfilter/source/dmapper/FormControlHelper.cxx|5 +-
 writerfilter/source/dmapper/FormControlHelper.hxx|2 
 writerfilter/source/dmapper/GraphicImport.cxx|9 ++-
 writerfilter/source/dmapper/GraphicImport.hxx|4 -
 writerfilter/source/dmapper/LoggedResources.cxx  |5 +-
 writerfilter/source/dmapper/LoggedResources.hxx  |2 
 writerfilter/source/dmapper/NumberingManager.cxx |5 +-
 writerfilter/source/dmapper/NumberingManager.hxx |2 
 writerfilter/source/dmapper/PropertyMap.cxx  |5 +-
 writerfilter/source/dmapper/PropertyMap.hxx  |9 ++-
 writerfilter/source/dmapper/SdtHelper.cxx|5 +-
 writerfilter/source/dmapper/SdtHelper.hxx|2 
 writerfilter/source/dmapper/StyleSheetTable.cxx  |   11 ++--
 writerfilter/source/dmapper/TableData.hxx|3 -
 writerfilter/source/ooxml/OOXMLBinaryObjectReference.cxx |6 +-
 writerfilter/source/ooxml/OOXMLBinaryObjectReference.hxx |2 
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx  |   11 ++--
 writerfilter/source/ooxml/OOXMLDocumentImpl.hxx  |2 
 writerfilter/source/ooxml/OOXMLFastDocumentHandler.cxx   |5 +-
 writerfilter/source/ooxml/OOXMLFastDocumentHandler.hxx   |2 
 writerfilter/source/ooxml/OOXMLPropertySet.cxx   |   30 ++--
 writerfilter/source/ooxml/OOXMLPropertySet.hxx   |   14 ++---
 writerfilter/source/ooxml/OOXMLStreamImpl.cxx|9 ++-
 writerfilter/source/ooxml/OOXMLStreamImpl.hxx|4 -
 writerperfect/inc/ImportFilter.hxx   |5 +-
 writerperfect/source/calc/MSWorksCalcImportFilter.cxx|5 +-
 writerperfect/source/common/DirectoryStream.cxx  |7 +-
 writerperfect/source/common/WPXSvInputStream.cxx |   15 +++---
 writerperfect/source/writer/WordPerfectImportFilter.hxx  |6 +-
 35 files changed, 137 insertions(+), 115 deletions(-)

New commits:
commit 93bea3531cff7f1e35a4c982836afbabfa587a6f
Author: Noel Grandin 
AuthorDate: Fri Jul 29 09:50:52 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Jul 31 08:33:13 2022 +0200

clang-tidy modernize-pass-by-value in writer*

Change-Id: Ib08c971eb3e859e7b04cdd408af7966d83c2955b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137585
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index 774cba78c3a1..bd23785b6ef2 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -55,6 +55,7 @@
 #ifdef DBG_UTIL
 #include "PropertyMapHelper.hxx"
 #include 
+#include 
 #endif
 
 namespace writerfilter::dmapper {
@@ -81,9 +82,9 @@ using namespace ::std;
 #define MAXTABLECELLS 63
 
 DomainMapperTableHandler::DomainMapperTableHandler(
-css::uno::Reference const& xText,
+css::uno::Reference xText,
 DomainMapper_Impl& rDMapper_Impl)
-: m_xText(xText),
+: m_xText(std::move(xText)),
 m_rDMapper_Impl( rDMapper_Impl ),
 m_bHadFootOrEndnote(false)
 {
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
index 4e396b6b23fc..f05fc1e474f1 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
@@ -79,7 +79,7 @@ class DomainMapperTableHandler final : public virtual 
SvRefBase
 public:
 typedef tools::SvRef Pointer_t;
 
-
DomainMapperTableHandler(css::uno::Reference 
const& xText,
+
DomainMapperTableHandler(css::uno::Reference 
xText,
  DomainMapper_Impl& rDMapper_Impl);
 ~DomainMapperTableHandler() override;
 
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index ba66d5c340f7..f5ca32d6f6f6 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -87,6 +87,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -312,7 +313,7 @@ uno::Any 
FloatingTableInfo::getPropertyValue(std::u16string_view propertyName)
 
 DomainMapper_Impl::DomainMapper_Impl(
 DomainMapper& rDMapper,
-uno::Reference const& xContext,
+uno::Reference xContext,
  

[Libreoffice-bugs] [Bug 150198] Diagrams copied from Calc loose formatting (percentage) in data series and axis

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150198

--- Comment #10 from Rainer Bielefeld Retired  
---
c) This one might be DUP of or related to 
   "Bug 68942 - Copy from Calc to Writer should burn in the source 
format of number"
   "Bug 142108 - Calc chart loses number formatting on bars when pasted in
Writer
doc where shows all decimal parts instead of using original format setting"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150198] Diagrams copied from Calc loose formatting (percentage) in data series and axis

2022-07-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150198

--- Comment #9 from Rainer Bielefeld Retired  
---
Created attachment 181505
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181505=edit
Screenshot of new data table

The screenshot shows the core of the problem. For copy paste of a chart to a
not Calc document a new data source table with the numeric data for the chart
will be created. And as the screenshot shows data formatting of original source
will become lost

-- 
You are receiving this mail because:
You are the assignee for the bug.