[Libreoffice-commits] core.git: chart2/Library_chartcontroller.mk chart2/source chart2/uiconfig chart2/UIConfig_chart2.mk
chart2/Library_chartcontroller.mk|2
chart2/UIConfig_chart2.mk|3
chart2/source/controller/dialogs/dlg_InsertDataTable.cxx | 61 +++
chart2/source/controller/dialogs/res_DataTableProperties.cxx | 111 +
chart2/source/controller/dialogs/tp_DataTable.cxx| 78 ---
chart2/source/controller/dialogs/tp_DataTable.hxx| 11
chart2/source/controller/inc/dlg_InsertDataTable.hxx | 47 ++
chart2/source/controller/inc/res_DataTableProperties.hxx | 47 ++
chart2/source/controller/main/ChartController_Insert.cxx | 64 ++-
chart2/uiconfig/ui/dlg_InsertDataTable.ui| 215 +++
10 files changed, 548 insertions(+), 91 deletions(-)
New commits:
commit 6c00d75738bb182b5c02848b1720e6623baed4b9
Author: Tomaž Vajngerl
AuthorDate: Fri Jul 1 22:00:38 2022 +0200
Commit: Tomaž Vajngerl
CommitDate: Mon Aug 15 07:42:32 2022 +0200
chart2: InsertDataTableDialog for inserting/removing the data table
Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138257
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/chart2/Library_chartcontroller.mk
b/chart2/Library_chartcontroller.mk
index 4bc8c7497915..cc25cdd907ae 100644
--- a/chart2/Library_chartcontroller.mk
+++ b/chart2/Library_chartcontroller.mk
@@ -109,6 +109,7 @@ $(eval $(call
gb_Library_add_exception_objects,chartcontroller,\
chart2/source/controller/dialogs/dlg_DataSource \
chart2/source/controller/dialogs/dlg_InsertAxis_Grid \
chart2/source/controller/dialogs/dlg_InsertDataLabel \
+chart2/source/controller/dialogs/dlg_InsertDataTable \
chart2/source/controller/dialogs/dlg_InsertErrorBars \
chart2/source/controller/dialogs/dlg_InsertLegend \
chart2/source/controller/dialogs/dlg_InsertTitle \
@@ -122,6 +123,7 @@ $(eval $(call
gb_Library_add_exception_objects,chartcontroller,\
chart2/source/controller/dialogs/RangeSelectionListener \
chart2/source/controller/dialogs/res_BarGeometry \
chart2/source/controller/dialogs/res_DataLabel \
+chart2/source/controller/dialogs/res_DataTableProperties \
chart2/source/controller/dialogs/res_ErrorBar \
chart2/source/controller/dialogs/res_LegendPosition \
chart2/source/controller/dialogs/res_Titles \
diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk
index 59af510c5845..274efd02638f 100644
--- a/chart2/UIConfig_chart2.mk
+++ b/chart2/UIConfig_chart2.mk
@@ -44,7 +44,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/combobox \
chart2/uiconfig/ui/datarangedialog \
chart2/uiconfig/ui/dlg_DataLabel \
+ chart2/uiconfig/ui/dlg_InsertDataTable \
chart2/uiconfig/ui/dlg_InsertErrorBars \
+ chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/imagefragment \
chart2/uiconfig/ui/insertaxisdlg \
chart2/uiconfig/ui/insertgriddlg \
@@ -58,7 +60,6 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\
chart2/uiconfig/ui/smoothlinesdlg \
chart2/uiconfig/ui/steppedlinesdlg \
chart2/uiconfig/ui/titlerotationtabpage \
- chart2/uiconfig/ui/dlg_InsertLegend \
chart2/uiconfig/ui/tp_3D_SceneAppearance \
chart2/uiconfig/ui/tp_3D_SceneGeometry \
chart2/uiconfig/ui/tp_3D_SceneIllumination \
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
new file mode 100644
index ..4b5e928db057
--- /dev/null
+++ b/chart2/source/controller/dialogs/dlg_InsertDataTable.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+namespace chart
+{
+InsertDataTableDialog::InsertDataTableDialog(weld::Window* pWindow)
+: GenericDialogController(pWindow,
"modules/schart/ui/dlg_InsertDataTable.ui",
+ "InsertDataTableDialog")
+, m_aDataTablePropertiesResources(*m_xBuilder)
+, m_xCbShowDataTable(m_xBuilder->weld_check_button("showDataTable"))
+{
+m_xCbShowDataTable->connect_toggled(LINK(this, InsertDataTableDialog,
ShowDataTableToggle));
+init(m_aData);
+}
+
+IMPL_LINK_NOARG(InsertDataTableDialog, ShowDataTableToggle, weld::Toggleable&,
void)
+{
+changeEnabled();
+}
+
+void InsertDataTableDialog::changeEnabled()
+{
+bool bEnable = m_xCbShowDataTable->get_active();
+m_aDataTablePropertiesResources.setChecksSensitive(bEnable);
+m_aData.mbShow = bEnable;
+}
+
+void InsertDataTableDialog::init(DataTableDialogData const& rData)
+{
+
[Libreoffice-bugs] [Bug 82321] row add/lock bug when deleting field from row to be added
https://bugs.documentfoundation.org/show_bug.cgi?id=82321 Robert Großkopf changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Robert Großkopf --- Tried it with LO 7.4.0.2, LO 7.3.5.2 and LO 7.1.5.2. Gives an error when trying to switch to previous row: Error inserting the new record at /home/buildslave/source/libo-core/connectivity/source/commontools/dbtools.cxx:746 SQL Status: HY010 Function sequence error. at /home/buildslave/source/libo-core/connectivity/source/commontools/dbexception.cxx:358 Bug couldn't be reproduced any more. I will set this one as WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108441] [META] Database table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108441 Bug 108441 depends on bug 82321, which changed state. Bug 82321 Summary: row add/lock bug when deleting field from row to be added https://bugs.documentfoundation.org/show_bug.cgi?id=82321 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86066] [META] Bugs and improvements to the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=86066 Bug 86066 depends on bug 127856, which changed state. Bug 127856 Summary: Pushing More... in language selection in Calc Status bar leads to Language settings instead of cell properties https://bugs.documentfoundation.org/show_bug.cgi?id=127856 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127856] Pushing More... in language selection in Calc Status bar leads to Language settings instead of cell properties
https://bugs.documentfoundation.org/show_bug.cgi?id=127856 andis.lazd...@gmail.com changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #12 from andis.lazd...@gmail.com --- Works as supposed, in the same way in Calc and Writer. Version: 7.4.0.3 / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: lv-LV (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135459] There is no a Build ID in About dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=135459 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=13 | |5460| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135460] BORDERS TAB IN PARAGRAPH DIALOG: Make selection of borders in User-defined preview more visible (see comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=135460 Dieter changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=13 |tion.org/show_bug.cgi?id=13 |5459|5359 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135359] BORDERS "Line arrangement" display shows "Set no borders" when dialog is reopened, irrespective of actual border setting
https://bugs.documentfoundation.org/show_bug.cgi?id=135359 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||5460 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103729] [META] HarfBuzz-based common text layout regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=103729 Khaled Hosny changed: What|Removed |Added Assignee|kha...@aliftype.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 started giving a warning when clicking link to HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 started giving a warning when clicking link to HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148311] calc . REQUEST for Copy & Past configurability
https://bugs.documentfoundation.org/show_bug.cgi?id=148311 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148311] calc . REQUEST for Copy & Past configurability
https://bugs.documentfoundation.org/show_bug.cgi?id=148311 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146770] tarda en abrir archivos y rutina de párrafo tarda 8 segundos en abrir
https://bugs.documentfoundation.org/show_bug.cgi?id=146770 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138391] duplex printing does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=138391 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146770] tarda en abrir archivos y rutina de párrafo tarda 8 segundos en abrir
https://bugs.documentfoundation.org/show_bug.cgi?id=146770 --- Comment #4 from QA Administrators --- Dear elvialh55, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138391] duplex printing does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=138391 --- Comment #4 from QA Administrators --- Dear billfrew90, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147120] Repairs document to old version and no clue about new document.
https://bugs.documentfoundation.org/show_bug.cgi?id=147120 --- Comment #2 from QA Administrators --- Dear rackaitis, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91111] Importing Docbook ignores lists
https://bugs.documentfoundation.org/show_bug.cgi?id=9 --- Comment #14 from QA Administrators --- Dear Stéphane Bortzmeyer, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135932] Open File option in front screen does nothing
https://bugs.documentfoundation.org/show_bug.cgi?id=135932 --- Comment #5 from QA Administrators --- Dear Dan Essin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80931] VIEWING: Size of caption depending on amount of description text & above/below object
https://bugs.documentfoundation.org/show_bug.cgi?id=80931 --- Comment #8 from QA Administrators --- Dear Dominik, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106038] Selected range of text disappears when going to Print Preview and back
https://bugs.documentfoundation.org/show_bug.cgi?id=106038 --- Comment #7 from QA Administrators --- Dear Thomas Lendo, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150102] LibreOffice Impress has white line on bottom and right edge of projection monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=150102 NoWorries changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from NoWorries --- I now have LO Impress Version 7.4.0.3 and on Wayland Kubuntu 22.10 it is working correctly with no white lines on the screen edges showing. I have the Format set to On-screen Show (16:9) and I make sure that no packages such as libreofice-kf5, libreofice-kde5, libreoffice-kde4, and libreoffice-kde are NOT installed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150408] "Legal numbering style" is not applied to list levels with tag
https://bugs.documentfoundation.org/show_bug.cgi?id=150408 Tex2002ans changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Blocks||108770 OS|Linux (All) |All Version|unspecified |6.0.7.3 release Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108770 [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108770] [META] DOCX (OOXML) bullet and numbering list-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108770 Tex2002ans changed: What|Removed |Added Depends on||150408 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150408 [Bug 150408] "Legal numbering style" is not applied to list levels with tag -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150408] "Legal numbering style" is not applied to list levels with tag
https://bugs.documentfoundation.org/show_bug.cgi?id=150408 --- Comment #2 from Tex2002ans --- Created attachment 181777 --> https://bugs.documentfoundation.org/attachment.cgi?id=181777=edit LO 7.3.5 vs. Word 2016 Comparison I confirm the bug: Version: 7.3.5.2 (x64) / LibreOffice Community Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded - - - Attached is an image showing the difference in list numbering between LO + Microsoft Word. Word 2016: - 1. -- 1.1. --- 1.1.1 - 2. -- 2.1. --- 2.1.1. LO 7.3.5: - 1. -- 1.a.<--- Here --- 1.a.i. <--- Here - 2. -- 2.a.<--- Here --- 2.a.i. <--- Here - - - Other discussion originally happened in this Reddit post: https://www.reddit.com/r/libreoffice/comments/wmwlf1/does_libreoffices_cli_support_islgl_legal/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149055] Embedded chart no longer works properly
https://bugs.documentfoundation.org/show_bug.cgi?id=149055 --- Comment #3 from John --- Created attachment 181776 --> https://bugs.documentfoundation.org/attachment.cgi?id=181776=edit Requested sample file I've enclosed a copy of the file. If you open it in the current version of LibreOffice the vertical lines in the chart will be elongated. The original the lines were within the colored part of the chart. On opening you will see they are elongated past that area. Make a minor change to a cell and save, close and reopen the spreadsheet. You will observe the lines have lengthened again. Each iteration will cause the lines to grow longer. The lines originally marked the boundary between months. As they lengthen they become skewed. There are no instructions about where to upload the file so I'm enclosing it with this email. I'll also try to upload it to the bug report. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/xls/pass/ofz49713-1.xls |binary
sc/source/core/data/table2.cxx | 20
2 files changed, 16 insertions(+), 4 deletions(-)
New commits:
commit 6c81a09e3ef239a2d7a991d00fe3620a67298b99
Author: Caolán McNamara
AuthorDate: Sun Aug 14 20:46:49 2022 +0100
Commit: Caolán McNamara
CommitDate: Mon Aug 15 00:50:46 2022 +0200
ofz#49713 Heap-use-after-free
the dtor of ScAttrArray where the std::vector ends up
will call ScDocumentPool::Remove on each entries pPattern, assuming
that a matching ScDocumentPool::Put was called on each, something
that is elided if we just do a simply copy here.
probably a problem since:
commit dddee125cc32f1ad5228e598a7de04e9654e65c1
Date: Thu Mar 10 15:03:25 2022 +0100
load ods/xlsx with full row attributes without allocating all columns
Change-Id: I3a5e2e3fa4d40343f30f9eefbabd1579d8a97e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/qa/unit/data/xls/pass/ofz49713-1.xls
b/sc/qa/unit/data/xls/pass/ofz49713-1.xls
new file mode 100644
index ..b32574013e95
Binary files /dev/null and b/sc/qa/unit/data/xls/pass/ofz49713-1.xls differ
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index c7c8a92b03dc..4eb5671f0dc7 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -2897,6 +2897,20 @@ void ScTable::ApplyPatternArea( SCCOL nStartCol, SCROW
nStartRow, SCCOL nEndCol,
CreateColumnIfNotExists(i).ApplyPatternArea(nStartRow, nEndRow, rAttr,
pDataArray, pIsChanged);
}
+namespace
+{
+std::vector duplicateScAttrEntries(ScDocument& rDocument,
const std::vector& rOrigData)
+{
+std::vector aData(rOrigData);
+for (size_t nIdx = 0; nIdx < aData.size(); ++nIdx)
+{
+ScPatternAttr aNewPattern(*aData[nIdx].pPattern);
+aData[nIdx].pPattern = ()->Put(aNewPattern);
+}
+return aData;
+}
+}
+
void ScTable::SetAttrEntries( SCCOL nStartCol, SCCOL nEndCol,
std::vector && vNewData)
{
if (!ValidCol(nStartCol) || !ValidCol(nEndCol))
@@ -2908,8 +2922,7 @@ void ScTable::SetAttrEntries( SCCOL nStartCol, SCCOL
nEndCol, std::vector(vNewData));
+aCol[i].SetAttrEntries(duplicateScAttrEntries(rDocument,
vNewData));
aDefaultColData.SetAttrEntries(std::move(vNewData));
}
else
@@ -2922,8 +2935,7 @@ void ScTable::SetAttrEntries( SCCOL nStartCol, SCCOL
nEndCol, std::vector(vNewData));
+aCol[i].SetAttrEntries(duplicateScAttrEntries(rDocument,
vNewData));
aCol[nEndCol].SetAttrEntries( std::move(vNewData));
}
}
[Libreoffice-bugs] [Bug 113298] RTL: Automatic language detection based on keyboard layout
https://bugs.documentfoundation.org/show_bug.cgi?id=113298 --- Comment #7 from Eyal Rozenberg --- Still the same behavior with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 5c68399e6bea3aa18477487400f8bb143d6ed84e CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3 Locale: en-IL (en_IL); UI: en-US -- You are receiving this mail because: You are the assignee for the bug.
Infra call on Tue, Aug 16 at 16:30 UTC
Hi there, The next infra call will take place at `date -d "Tue, 16 Aug 2022 16:30 UTC"` (18:30 Berlin time). We'll meet at https://jitsi.documentfoundation.org/infra and write the minutes to https://pad.documentfoundation.org/p/infra . Agenda TBA. See you there! Cheers, -- Guilhem. signature.asc Description: PGP signature
[Libreoffice-bugs] [Bug 133184] Arabic Tatweel disconnected from following letter when surrounded with Japanese quotation marks
https://bugs.documentfoundation.org/show_bug.cgi?id=133184 --- Comment #14 from Khaled Hosny --- Created attachment 181775 --> https://bugs.documentfoundation.org/attachment.cgi?id=181775=edit Screenshot showing rendering as expected Looks fine here, can’t reproduce with various fonts. If this is still an issue, please attach LibreOffice document to reproduce it. -- You are receiving this mail because: You are the assignee for the bug.
segfault in unopkg.bin
Hi, I managed to provoke unopkg.bin to segfault while I was doing `make` in instdir/sdk/examples/cpp/complextoolbarcontrols/. Is this a candidate for a bug report? Or, is it a case of: I deserve whatever I do to myself? FWIW, my mistake was to define envvar URE_BOOTSTRAP with an embedded equal sign where it should have had a colon. Thank you for your attention and guidance. Terry.
Re: IMPORTANT UPDATE LibreOffice Conference
I have added the hotel list to the conference website. You can also use Booking.Com as an alternative. On 8/5/22 09:06, Stephan Bergmann wrote: On 7/1/22 18:00, Italo Vignoli wrote: [...] We will share all logistic details before July 15. Together with the logistic details, we will share infos about places to see, and food & drinks to enjoy. [...]> As soon as we share logistic details, we also suggest people to look for hotel rooms based on the list of affordable hotels close to the metro we are putting together. Most of the hotels will be rather small, as large hotels are usually quite expensive. [...] Hi Italo, Is there an update on such a hotel list? Might be helpful when one is looking for an appropriate hotel to book. -- Italo Vignoli - LibreOffice Marketing & PR mobile/signal +39.348.5653829 - emailit...@libreoffice.org GPG Key ID - 0xAAB8D5C0 DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 133184, which changed state. Bug 133184 Summary: Arabic Tatweel disconnected from following letter when surrounded with Japanese quotation marks https://bugs.documentfoundation.org/show_bug.cgi?id=133184 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 133184, which changed state. Bug 133184 Summary: Arabic Tatweel disconnected from following letter when surrounded with Japanese quotation marks https://bugs.documentfoundation.org/show_bug.cgi?id=133184 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133184] Arabic Tatweel disconnected from following letter when surrounded with Japanese quotation marks
https://bugs.documentfoundation.org/show_bug.cgi?id=133184 Khaled Hosny changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED CC||kha...@aliftype.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||135765 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135765 [Bug 135765] bullets in table not restored after undo cell merging -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||135765 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135765 [Bug 135765] bullets in table not restored after undo cell merging -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135765] bullets in table not restored after undo cell merging
https://bugs.documentfoundation.org/show_bug.cgi?id=135765 Gabor Kelemen (allotropia) changed: What|Removed |Added CC||kelem...@ubuntu.com Blocks||105948, 103100 --- Comment #5 from Gabor Kelemen (allotropia) --- Still in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: cdf5b6a2a6f0ba2838323ce4398948c3d3a56f8e CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150389] loose centering with new entry in a table in writer
https://bugs.documentfoundation.org/show_bug.cgi?id=150389 --- Comment #1 from seth_...@yahoo.com --- New detail: The problem only occurs when new rows are added to an existing table.Only then will the previously centered text suddenly become left justified. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Eyal Rozenberg changed: What|Removed |Added Depends on||87731 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87731 [Bug 87731] Tag appearing in Arabic characters when change size of fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Eyal Rozenberg changed: What|Removed |Added Depends on|87731 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87731 [Bug 87731] Tag appearing in Arabic characters when change size of fonts -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144998] Impress Ubuntu at save us the last modifications disappear from both last versions
https://bugs.documentfoundation.org/show_bug.cgi?id=144998 BogdanB changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from BogdanB --- Based on your last comment and the fact that noone will install an unsupported version I will close the bug as Worksforme. Please be free to reopen as unconfirmed if you want. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150411] Table scrambled at undo. Track Changes involved
https://bugs.documentfoundation.org/show_bug.cgi?id=150411 Telesto changed: What|Removed |Added Keywords||bibisectRequest Version|7.5.0.0 alpha0+ Master |7.4.0.0 alpha1+ --- Comment #3 from Telesto --- Also in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 0c17712465b07e8a7ebe078b00123965b112f0ac CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL not in Version: 7.1.8.0.0+ (x64) / LibreOffice Community Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Note: in 7.1.8 track Changes Record didn't register table deletion -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150411] Table scrambled at undo. Track Changes involved
https://bugs.documentfoundation.org/show_bug.cgi?id=150411 Telesto changed: What|Removed |Added Summary|Table scrambled at undo |Table scrambled at undo. ||Track Changes involved -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150411] Table scrambled at undo
https://bugs.documentfoundation.org/show_bug.cgi?id=150411 --- Comment #1 from Telesto --- Created attachment 181773 --> https://bugs.documentfoundation.org/attachment.cgi?id=181773=edit Example file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150411] New: Table scrambled at undo
https://bugs.documentfoundation.org/show_bug.cgi?id=150411 Bug ID: 150411 Summary: Table scrambled at undo Product: LibreOffice Version: 7.5.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Table scrambled at undo Steps to Reproduce: 1. Open the attached file 2. Place the cursor in the table on page 2 3. Menu Table -> Delete -> Table 4. CTRL+Z 5. Edit -> Track Changes -> Record -> Toggle record on & show ON 6. Delete the table again 7. Press undo Actual Results: See screenshot Expected Results: Same table as before on file open Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 86b2bfd34a4f07c54f03c8c8dfe48e0810834628 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103538] Use OpenType Sanitiser to sanitize embedded fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=103538 Khaled Hosny changed: What|Removed |Added CC||kha...@aliftype.com Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Khaled Hosny --- No security issue about embedded fonts in 5 years, probably not worth it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144998] Impress Ubuntu at save us the last modifications disappear from both last versions
https://bugs.documentfoundation.org/show_bug.cgi?id=144998 szelev71 changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #7 from szelev71 --- I mark it as unconfirmed, but nobody else tried it on the same version of Ubuntu with the same version of LO. By the way, on the newer Ubuntu and LO it works without this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 137530, which changed state. Bug 137530 Summary: FORMATTING: Arabic Letters are sometimes disjoined in justified alignment in LibreOffice Impress https://bugs.documentfoundation.org/show_bug.cgi?id=137530 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 137530, which changed state. Bug 137530 Summary: FORMATTING: Arabic Letters are sometimes disjoined in justified alignment in LibreOffice Impress https://bugs.documentfoundation.org/show_bug.cgi?id=137530 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 103492, which changed state. Bug 103492 Summary: Arabic words not formed well in textboxes when sentence begins with English word https://bugs.documentfoundation.org/show_bug.cgi?id=103492 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113064] [META] RTL/CTL textbox related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113064 Bug 113064 depends on bug 103492, which changed state. Bug 103492 Summary: Arabic words not formed well in textboxes when sentence begins with English word https://bugs.documentfoundation.org/show_bug.cgi?id=103492 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/svm/SvmReader.cxx | 21 +
vcl/source/filter/svm/SvmWriter.cxx |8 +++-
2 files changed, 28 insertions(+), 1 deletion(-)
New commits:
commit 62ff1053eeba26cecd7264db08e73da154835816
Author: Khaled Hosny
AuthorDate: Sat Aug 13 23:06:27 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 22:01:19 2022 +0200
svm: serialize MetaTextArrayAction’s Kashida array
Otherwise reading SVM files would lose the Kashida but not the DX
adjustments and would leave blanks in their place.
Change-Id: Id37e09fed12da5e256d65e2c45c91869364c8d06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index f02451ea36ff..a7b990c3ddba 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -707,6 +707,27 @@ rtl::Reference
SvmReader::TextArrayHandler(const ImplMetaReadData* p
if (!aArray.empty())
pAction->SetDXArray(std::move(aArray));
+if (aCompat.GetVersion() >= 3) // Version 3
+{
+sal_Int32 nKashidaAryLen(0);
+mrStream.ReadInt32(nKashidaAryLen);
+nTmpLen = std::min(nKashidaAryLen, sal_Int32(aArray.size()));
+if (nTmpLen)
+{
+// aKashidaArray, if not empty, must be the same size as aArray
+std::vector aKashidaArray(aArray.size(), 0);
+
+// [-loplugin:fakebool] false positive:
+sal_Bool val(sal_False);
+for (sal_Int32 i = 0; i < nTmpLen; i++)
+{
+mrStream.ReadUChar(val);
+aKashidaArray[i] = val;
+}
+pAction->SetKashidaArray(std::move(aKashidaArray));
+}
+}
+
return pAction;
}
diff --git a/vcl/source/filter/svm/SvmWriter.cxx
b/vcl/source/filter/svm/SvmWriter.cxx
index 118db1325d71..6dec8279c151 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -988,7 +988,7 @@ void SvmWriter::TextArrayHandler(const MetaTextArrayAction*
pAction, const ImplM
const sal_Int32 nAryLen = !rDXArray.empty() ? pAction->GetLen() : 0;
-VersionCompatWrite aCompat(mrStream, 2);
+VersionCompatWrite aCompat(mrStream, 3);
TypeSerializer aSerializer(mrStream);
aSerializer.writePoint(pAction->GetPoint());
mrStream.WriteUniOrByteString(pAction->GetText(), pData->meActualCharSet);
@@ -1000,6 +1000,12 @@ void SvmWriter::TextArrayHandler(const
MetaTextArrayAction* pAction, const ImplM
mrStream.WriteInt32(rDXArray[i]);
write_uInt16_lenPrefixed_uInt16s_FromOUString(mrStream,
pAction->GetText()); // version 2
+
+// Version 3
+const auto& rKashidaArray = pAction->GetKashidaArray();
+mrStream.WriteInt32(sal_Int32(rKashidaArray.size()));
+for (const auto& val : rKashidaArray)
+mrStream.WriteUChar(val);
}
void SvmWriter::StretchTextHandler(const MetaStretchTextAction* pAction,
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 106653, which changed state. Bug 106653 Summary: RTL Arabic text has some gaps between characters https://bugs.documentfoundation.org/show_bug.cgi?id=106653 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 106653, which changed state. Bug 106653 Summary: RTL Arabic text has some gaps between characters https://bugs.documentfoundation.org/show_bug.cgi?id=106653 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 139627, which changed state. Bug 139627 Summary: Justified paragraph rendering defect when inserting Arabic diacritics https://bugs.documentfoundation.org/show_bug.cgi?id=139627 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 139627, which changed state. Bug 139627 Summary: Justified paragraph rendering defect when inserting Arabic diacritics https://bugs.documentfoundation.org/show_bug.cgi?id=139627 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 started giving a warning when clicking link to HTML file
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 Timur changed: What|Removed |Added Summary|LibreOffice 7.3.5.2 dropped |LibreOffice 7.3.5.2 started |a feature I use a lot when |giving a warning when |editing.|clicking link to HTML file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 137528, which changed state. Bug 137528 Summary: Arabic Letters are sometimes disjoined and the vowel marks are misplaced in justified paragraph in Text Box https://bugs.documentfoundation.org/show_bug.cgi?id=137528 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113046] renaming a style
https://bugs.documentfoundation.org/show_bug.cgi?id=113046 Bug 113046 depends on bug 137528, which changed state. Bug 137528 Summary: Arabic Letters are sometimes disjoined and the vowel marks are misplaced in justified paragraph in Text Box https://bugs.documentfoundation.org/show_bug.cgi?id=137528 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145962] [META] Bugs related to kerning/font spacing (cramped/to width/wiggling)
https://bugs.documentfoundation.org/show_bug.cgi?id=145962 Bug 145962 depends on bug 137528, which changed state. Bug 137528 Summary: Arabic Letters are sometimes disjoined and the vowel marks are misplaced in justified paragraph in Text Box https://bugs.documentfoundation.org/show_bug.cgi?id=137528 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 146199, which changed state. Bug 146199 Summary: Farsi character overlapped with underscore/dash in an Impress presentation https://bugs.documentfoundation.org/show_bug.cgi?id=146199 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 146199, which changed state. Bug 146199 Summary: Farsi character overlapped with underscore/dash in an Impress presentation https://bugs.documentfoundation.org/show_bug.cgi?id=146199 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 145647, which changed state. Bug 145647 Summary: Arabic tatweel rendered as whitespace with preceding English text https://bugs.documentfoundation.org/show_bug.cgi?id=145647 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 145647, which changed state. Bug 145647 Summary: Arabic tatweel rendered as whitespace with preceding English text https://bugs.documentfoundation.org/show_bug.cgi?id=145647 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||146575 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146575 [Bug 146575] Writer won't export hyperlinks to pdf -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146575] Writer won't export hyperlinks to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=146575 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks||103378 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 127176, which changed state. Bug 127176 Summary: 'Noto Nastaliq Urdu' font does not render correctly when justified. https://bugs.documentfoundation.org/show_bug.cgi?id=127176 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 127176, which changed state. Bug 127176 Summary: 'Noto Nastaliq Urdu' font does not render correctly when justified. https://bugs.documentfoundation.org/show_bug.cgi?id=127176 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 112849, which changed state. Bug 112849 Summary: Kashida characters appears at particular zoom levels (310%) https://bugs.documentfoundation.org/show_bug.cgi?id=112849 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 112849, which changed state. Bug 112849 Summary: Kashida characters appears at particular zoom levels (310%) https://bugs.documentfoundation.org/show_bug.cgi?id=112849 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 112849, which changed state. Bug 112849 Summary: Kashida characters appears at particular zoom levels (310%) https://bugs.documentfoundation.org/show_bug.cgi?id=112849 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 108604, which changed state. Bug 108604 Summary: wrong kashida placement when exporting to PDF https://bugs.documentfoundation.org/show_bug.cgi?id=108604 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 108604, which changed state. Bug 108604 Summary: wrong kashida placement when exporting to PDF https://bugs.documentfoundation.org/show_bug.cgi?id=108604 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 106309, which changed state. Bug 106309 Summary: Wrong placement of kashida causes defect in Arabic/Persian text rendering https://bugs.documentfoundation.org/show_bug.cgi?id=106309 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112810 Bug 112810 depends on bug 106309, which changed state. Bug 106309 Summary: Wrong placement of kashida causes defect in Arabic/Persian text rendering https://bugs.documentfoundation.org/show_bug.cgi?id=106309 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 106309, which changed state. Bug 106309 Summary: Wrong placement of kashida causes defect in Arabic/Persian text rendering https://bugs.documentfoundation.org/show_bug.cgi?id=106309 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150406] Style Inspector shows with Default Paragraph Style with Times of New Roman, but actual font is David (without DF accordantly to Style Inspector)
https://bugs.documentfoundation.org/show_bug.cgi?id=150406 --- Comment #8 from Telesto --- Created attachment 181772 --> https://bugs.documentfoundation.org/attachment.cgi?id=181772=edit Example file B Before I start spamming the bug tracker.. another attempt to illustrate the issue 1. Open Writer 2. Tools -> Options -> Language settings -> Languages -> Make sure complex text layout being enabled set for Hebrew [not sure if it matters, but well) 3. Open the attached file 4. Open Sidebar -> Style Inspector 5. Walk through the file with arrows.. Nothing about Liberation Serif (OK) 6. Save the file to DOC 7. File -> Reload 8. Walk through the file with arrows.. Notice Character Direct Formatting appearing regularly in the area between words -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 87731, which changed state. Bug 87731 Summary: Tag appearing in Arabic characters when change size of fonts https://bugs.documentfoundation.org/show_bug.cgi?id=87731 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text
https://bugs.documentfoundation.org/show_bug.cgi?id=150285 Bug 150285 depends on bug 104921, which changed state. Bug 104921 Summary: Make Arabic text justification more robust https://bugs.documentfoundation.org/show_bug.cgi?id=104921 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116969] Justification by alternative methods
https://bugs.documentfoundation.org/show_bug.cgi?id=116969 Bug 116969 depends on bug 104921, which changed state. Bug 104921 Summary: Make Arabic text justification more robust https://bugs.documentfoundation.org/show_bug.cgi?id=104921 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145962] [META] Bugs related to kerning/font spacing (cramped/to width/wiggling)
https://bugs.documentfoundation.org/show_bug.cgi?id=145962 Bug 145962 depends on bug 104921, which changed state. Bug 104921 Summary: Make Arabic text justification more robust https://bugs.documentfoundation.org/show_bug.cgi?id=104921 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150400] File menu is missing some items
https://bugs.documentfoundation.org/show_bug.cgi?id=150400 Timur changed: What|Removed |Added Summary|Embeded Fonts |File menu is missing some ||items -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150400] Embeded Fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=150400 Timur changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- --- Comment #6 from Timur --- This is not reproducible by someone else hence cannot be confirmed. Did you really reset, delete, rename LO user profile? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/unocrsrhelper.hxx|4 +--
sw/source/core/crsr/crsrsh.cxx |4 +--
sw/source/core/crsr/swcrsr.cxx |2 -
sw/source/core/doc/DocumentContentOperationsManager.cxx |2 -
sw/source/core/doc/DocumentRedlineManager.cxx | 10
sw/source/core/doc/doccomp.cxx |8 +++---
sw/source/core/doc/docredln.cxx |2 -
sw/source/core/frmedt/fetab.cxx |2 -
sw/source/core/layout/frmtool.cxx |2 -
sw/source/core/layout/trvlfrm.cxx |2 -
sw/source/core/text/itratr.cxx |2 -
sw/source/core/text/redlnitr.cxx|2 -
sw/source/core/undo/undel.cxx |4 +--
sw/source/core/undo/undobj.cxx | 20
sw/source/core/undo/unins.cxx |8 +++---
sw/source/core/unocore/unoobj.cxx | 10
sw/source/core/unocore/unoparagraph.cxx |6 ++--
sw/source/uibase/docvw/edtwin.cxx |7 ++---
sw/source/uibase/uiview/formatclipboard.cxx |2 -
sw/source/uibase/uiview/viewstat.cxx|2 -
20 files changed, 50 insertions(+), 51 deletions(-)
New commits:
commit d0c07ec1cad386a0ec3bf34c6aa6e7b50859ef09
Author: Noel Grandin
AuthorDate: Sun Aug 14 18:02:27 2022 +0200
Commit: Noel Grandin
CommitDate: Sun Aug 14 21:28:37 2022 +0200
use more GetContentIndex
Change-Id: I48e36a95872b5c2bdb6b92c66403d4c08eedd38c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138255
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/unocrsrhelper.hxx b/sw/inc/unocrsrhelper.hxx
index 014421371ba0..af3c779f2288 100644
--- a/sw/inc/unocrsrhelper.hxx
+++ b/sw/inc/unocrsrhelper.hxx
@@ -86,10 +86,10 @@ namespace SwUnoCursorHelper
voidGetCurPageStyle(SwPaM const & rPaM, OUString
);
inline bool IsStartOfPara(SwPaM& rUnoCursor)
-{ return
rUnoCursor.GetPoint()->nContent == 0;}
+{ return
rUnoCursor.GetPoint()->GetContentIndex() == 0;}
inline bool IsEndOfPara(SwPaM& rUnoCursor)
{ return
rUnoCursor.GetPointContentNode() &&
-rUnoCursor.GetPoint()->nContent ==
rUnoCursor.GetPointContentNode()->Len();}
+
rUnoCursor.GetPoint()->GetContentIndex() ==
rUnoCursor.GetPointContentNode()->Len();}
voidresetCursorPropertyValue(const
SfxItemPropertyMapEntry& rEntry, SwPaM& rPam);
/// @throws css::lang::IllegalArgumentException
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 013f65bf6e5b..d9a040adfad4 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -1107,7 +1107,7 @@ bool SwCursorShell::IsSttPara() const
}
}
}
-return m_pCurrentCursor->GetPoint()->nContent == 0;
+return m_pCurrentCursor->GetPoint()->GetContentIndex() == 0;
}
bool SwCursorShell::IsEndPara() const
@@ -1126,7 +1126,7 @@ bool SwCursorShell::IsEndPara() const
}
}
}
-return m_pCurrentCursor->GetPoint()->nContent ==
m_pCurrentCursor->GetPointContentNode()->Len();
+return m_pCurrentCursor->GetPoint()->GetContentIndex() ==
m_pCurrentCursor->GetPointContentNode()->Len();
}
bool SwCursorShell::IsEndOfTable() const
diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx
index 9cd4a326a533..5a47e9bdb965 100644
--- a/sw/source/core/crsr/swcrsr.cxx
+++ b/sw/source/core/crsr/swcrsr.cxx
@@ -1280,7 +1280,7 @@ bool SwCursor::IsInWordWT(sal_Int16 nWordType,
SwRootFrame const*const pLayout)
bool SwCursor::IsStartEndSentence(bool bEnd, SwRootFrame const*const pLayout)
const
{
bool bRet = bEnd ?
-GetPointContentNode() && GetPoint()->nContent ==
GetPointContentNode()->Len() :
+GetPointContentNode() && GetPoint()->GetContentIndex() ==
GetPointContentNode()->Len() :
GetPoint()->GetContentIndex() == 0;
if ((pLayout != nullptr && pLayout->HasMergedParas()) || !bRet)
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index bd8b154b1323..1972be388df2 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2452,7 +2452,7 @@ bool DocumentContentOperationsManager::MoveRange( SwPaM&
rPaM, SwPosition& rPos,
// tdf#99692 don't Move() back if that would end up in another node
// because moving
[Libreoffice-bugs] [Bug 149957] Screen Size Does Not Carry to Next Session with LO 7.4
https://bugs.documentfoundation.org/show_bug.cgi?id=149957 Timur changed: What|Removed |Added Keywords||possibleRegression -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149424] Layout loop in doc files
https://bugs.documentfoundation.org/show_bug.cgi?id=149424 --- Comment #16 from Gabor Kelemen (allotropia) --- A fresh debug build spews this on the console every second or two: warn:legacy.osl:23929:23929:sw/source/core/layout/layact.cxx:755: LoopControl_3 in Interrupt formatting in SwLayAction::InternalAction -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132261] [META] Table layouting: PrepareMake, MakeAll loops and crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=132261 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||149424 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149424 [Bug 149424] Layout loop in doc files -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149424] Layout loop in doc files
https://bugs.documentfoundation.org/show_bug.cgi?id=149424 Gabor Kelemen (allotropia) changed: What|Removed |Added Blocks||132261 CC||kelem...@ubuntu.com Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132261 [Bug 132261] [META] Table layouting: PrepareMake, MakeAll loops and crashes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150381] LibreOffice 7.3.5.2 dropped a feature I use a lot when editing.
https://bugs.documentfoundation.org/show_bug.cgi?id=150381 --- Comment #6 from JIM7 --- Created attachment 181771 --> https://bugs.documentfoundation.org/attachment.cgi?id=181771=edit Edited sample Help/About is at the bottom of the Sample. Hyperlink is not present in .odt. This happens when I am directly editing html files. I tested this file. Hyperlink no longer works. I'm also attaching the file that the hyperlink is supposed to access. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit3.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 895843ad466954b63f6f99a1b6319b7813d0dbe1 Author: Khaled Hosny AuthorDate: Sat Aug 13 00:00:27 2022 +0200 Commit: Caolán McNamara CommitDate: Sun Aug 14 21:13:04 2022 +0200 tdf#103492: Messed Arabic letter spacing in text starting with LTR character(s) This partially reverts the still relevant parts of commit commit 41007842ed9bb5d6165792a197769f72dae55a2c Author: Martin Hosken Date: Thu Sep 10 10:14:18 2015 +0700 Refactor graphite integration and update graphite Change-Id: I09db7262c2a6180a078620ba086dd7a4c132bd82 Reviewed-on: https://gerrit.libreoffice.org/18459 Tested-by: Jenkins Reviewed-by: László Németh Reviewed-by: Martin Hosken No mention of the commit about this change or its relevance to Graphite integration. But the separate Graphite layout engine is long gone and Graphite handling goes through HarfBuzz now, so whatever the change was for is probably no longer relevant. I reverted only one the two changes in impedit3.cxx, as the other one does not seem to make any difference for this issue. Change-Id: Id70a711d6231cce52c9a32dbc3604860b1da9f4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138217 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx index 6195b0e8e606..5ff196f02040 100644 --- a/editeng/source/editeng/impedit3.cxx +++ b/editeng/source/editeng/impedit3.cxx @@ -838,8 +838,6 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, sal_uInt32 nStartPosY ) EditLine aSaveLine( *pLine ); SvxFont aTmpFont( pNode->GetCharAttribs().GetDefFont() ); -ImplInitLayoutMode(*GetRefDevice(), nPara, nIndex); - std::vector aBuf( pNode->Len() ); bool bSameLineAgain = false;// For TextRanger, if the height changes.
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/CommonSalLayout.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 3836b99f335ac9e6890545607d07124e455eb531
Author: Khaled Hosny
AuthorDate: Fri Aug 12 14:00:25 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 21:12:37 2022 +0200
Use doubles when calculating the number of Kashidas to insert
Makes it a bit more stable across zoom levels and avoids excessive
overlaps due to calculating one copy too many because of rounding
errors.
Change-Id: I6a21a89c1dfda085b1f7fa9570c9875a0d39f671
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138192
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index 0bea121896b4..eff9dab9acbb 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -754,7 +754,7 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
return;
// Find Kashida glyph width and index.
-DeviceCoordinate nKashidaWidth = 0;
+double nKashidaWidth = 0;
hb_codepoint_t nKashidaIndex = 0;
if (hb_font_get_glyph(GetFont().GetHbFont(), 0x0640, 0, ))
nKashidaWidth = GetFont().GetKashidaWidth();
@@ -771,7 +771,7 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
auto pGlyphIter = m_GlyphItems.begin() + nInserted + pKashida.first;
// The total Kashida width.
-DeviceCoordinate nTotalWidth = pKashida.second;
+double nTotalWidth = pKashida.second;
// Number of times to repeat each Kashida.
int nCopies = 1;
@@ -780,12 +780,12 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
// See if we can improve the fit by adding an extra Kashidas and
// squeezing them together a bit.
-DeviceCoordinate nOverlap = 0;
-DeviceCoordinate nShortfall = nTotalWidth - nKashidaWidth * nCopies;
+double nOverlap = 0;
+double nShortfall = nTotalWidth - nKashidaWidth * nCopies;
if (nShortfall > 0)
{
++nCopies;
-DeviceCoordinate nExcess = nCopies * nKashidaWidth - nTotalWidth;
+double nExcess = nCopies * nKashidaWidth - nTotalWidth;
if (nExcess > 0)
nOverlap = nExcess / (nCopies - 1);
}
[Libreoffice-commits] core.git: vcl/source
vcl/source/font/fontinstance.cxx |2 +-
vcl/source/gdi/CommonSalLayout.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 3d0e482df81a28e6d0eb86cda71ac49d3363ae50
Author: Khaled Hosny
AuthorDate: Fri Aug 12 02:51:50 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 21:12:21 2022 +0200
tdf#106653: Try harder not to return 0 for Kashida width
The font in the bug document has a very small Kashida advance width and
this gets rounded to zero at smaller zoom level. Try to round up the
value to avoid returning zero too eagerly.
Change-Id: I78c309d66a9e94812827c7c6724c67c4d09bcff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138169
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/font/fontinstance.cxx b/vcl/source/font/fontinstance.cxx
index 0907d657ad02..44c2c8cc757d 100644
--- a/vcl/source/font/fontinstance.cxx
+++ b/vcl/source/font/fontinstance.cxx
@@ -73,7 +73,7 @@ int LogicalFontInstance::GetKashidaWidth() const
{
double nXScale = 0;
GetScale(, nullptr);
-nWidth = hb_font_get_glyph_h_advance(pHbFont, nIndex) * nXScale;
+nWidth = std::ceil(hb_font_get_glyph_h_advance(pHbFont, nIndex) *
nXScale);
}
return nWidth;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index b3d63dac30a0..0bea121896b4 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -761,7 +761,7 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
if (nKashidaWidth <= 0)
{
-SAL_WARN("vcl.gdi", "Asked to insert Kashidas in a font with
zero-width Kashida");
+SAL_WARN("vcl.gdi", "Asked to insert Kashidas in a font with bogus
Kashida width");
return;
}
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/vcllayout.hxx |2
vcl/inc/sallayout.hxx |4 -
vcl/source/gdi/CommonSalLayout.cxx | 82 +++--
vcl/source/gdi/sallayout.cxx |9 ++--
vcl/source/outdev/font.cxx | 26 +--
5 files changed, 54 insertions(+), 69 deletions(-)
New commits:
commit 5e2b7a656024b621bdeeb6efd977331191b66d9d
Author: Khaled Hosny
AuthorDate: Fri Aug 12 02:12:04 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 21:11:52 2022 +0200
Streamline Kashida validation logic
We are asked to validate the position *after* which Kashida will be
inserted, but HarfBuzz will tell us which glyph we can insert Kashida
*before*. So align both by passing down the position before and after
and make the loop iterating over glyph items a lot simpler.
As a bonus, the new code allow Kashida insertion across layout change in
both sides, old code allowed it only at the start of the layout.
Change-Id: I9f632610b92c0f4c512e50456bf7d207175f17ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138168
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/vcl/vcllayout.hxx b/include/vcl/vcllayout.hxx
index 87d9345f4b9b..cbadb47ee0ba 100644
--- a/include/vcl/vcllayout.hxx
+++ b/include/vcl/vcllayout.hxx
@@ -92,7 +92,7 @@ public:
virtual DeviceCoordinate FillDXArray( std::vector*
pDXArray ) const = 0;
virtual DeviceCoordinate GetTextWidth() const { return FillDXArray(
nullptr ); }
virtual voidGetCaretPositions( int nArraySize, sal_Int32* pCaretXArray
) const = 0;
-virtual boolIsKashidaPosValid ( int /*nCharPos*/ ) const { return
true; } // i60594
+virtual boolIsKashidaPosValid ( int /*nCharPos*/, int /*nNextCharPos*/
) const = 0; // i60594
// methods using glyph indexing
virtual boolGetNextGlyph(const GlyphItem** pGlyph, DevicePoint& rPos,
int& nStart,
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 885de2446db7..b49c1c663ee4 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -68,7 +68,7 @@ public:
const LogicalFontInstance** ppGlyphFont =
nullptr,
const vcl::font::PhysicalFontFace**
pFallbackFont = nullptr) const override;
boolGetOutline(basegfx::B2DPolyPolygonVector&) const override;
-boolIsKashidaPosValid(int nCharPos) const override;
+boolIsKashidaPosValid(int nCharPos, int nNextCharPos) const
override;
SalLayoutGlyphs GetGlyphs() const final override;
// used only by OutputDevice::ImplLayout, TODO: make friend
@@ -115,7 +115,7 @@ public:
voidDrawText(SalGraphics&) const final override;
SalLayoutGlyphs GetGlyphs() const final override;
-boolIsKashidaPosValid(int nCharPos) const final override;
+boolIsKashidaPosValid(int nCharPos, int nNextCharPos) const
final override;
// used by upper layers
DeviceCoordinate GetTextWidth() const final override;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx
b/vcl/source/gdi/CommonSalLayout.cxx
index da7334352858..b3d63dac30a0 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -719,22 +719,19 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
m_GlyphItems[i].addNewWidth(nDiff);
m_GlyphItems[i].adjustLinearPosX(nDelta + nDiff);
-// Adjust the X position of the rest of the glyphs in the cluster.
size_t j = i;
while (j > 0)
{
--j;
-if (!m_GlyphItems[j].IsInCluster())
+if (!(m_GlyphItems[j].IsDiacritic() ||
m_GlyphItems[j].IsInCluster()))
break;
-m_GlyphItems[j].adjustLinearPosX(nDelta + nDiff);
-}
-// Move any non-spacing marks to keep attached to this cluster.
-while (j > 0)
-{
-if (!m_GlyphItems[j].IsDiacritic())
-break;
-m_GlyphItems[j--].adjustLinearPosX(nDiff);
+if (m_GlyphItems[j].IsInCluster())
+// Adjust X position of the remainder of the cluster.
+m_GlyphItems[j].adjustLinearPosX(nDelta + nDiff);
+else
+// Move non-spacing marks to keep attached to this cluster.
+m_GlyphItems[j].adjustLinearPosX(nDiff);
}
// This is a Kashida insertion position, mark it. Kashida glyphs
@@ -807,56 +804,27 @@ void GenericSalLayout::ApplyDXArray(const DC* pDXArray,
const sal_Bool* pKashida
}
}
-bool GenericSalLayout::IsKashidaPosValid(int nCharPos) const
+// Kashida will be inserted between nCharPos and nNextCharPos.
+bool GenericSalLayout::IsKashidaPosValid(int nCharPos, int
[Libreoffice-commits] core.git: editeng/source sw/source
editeng/source/editeng/impedit3.cxx | 18 ++
sw/source/core/text/porlay.cxx | 18 ++
2 files changed, 20 insertions(+), 16 deletions(-)
New commits:
commit 72e56537d4bb9411229346da977d1d669ccfca9a
Author: Khaled Hosny
AuthorDate: Thu Aug 11 18:52:17 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 21:11:15 2022 +0200
tdf#139627: Don’t set Kashida insertion position after combining marks
We were skipping the marks when checking for previous char, but not when
setting the index to previous char.
Fixes also the second part of tdf#106653.
Change-Id: I73436ba9df6ccf104ea6d4dfbd76a59c86040a44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138154
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index d712dfa5..6195b0e8e606 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -2339,10 +2339,9 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// restore selection for proper iteration at the end of the function
aWordSel.Max().SetIndex( nSavPos );
-sal_Int32 nIdx = 0;
+sal_Int32 nIdx = 0, nPrevIdx = 0;
sal_Int32 nKashidaPos = -1;
-sal_Unicode cCh;
-sal_Unicode cPrevCh = 0;
+sal_Unicode cCh, cPrevCh = 0;
int nPriorityLevel = 7;// 0..6 = level found
// 7 not found
@@ -2390,7 +2389,7 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// check if character is connectable to previous character,
if ( lcl_ConnectToPrev( cCh, cPrevCh ) )
{
-nKashidaPos = aWordSel.Min().GetIndex() + nIdx - 1;
+nKashidaPos = aWordSel.Min().GetIndex() + nPrevIdx;
nPriorityLevel = 2;
}
}
@@ -2411,7 +2410,7 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// check if character is connectable to previous character,
if ( lcl_ConnectToPrev( cCh, cPrevCh ) )
{
-nKashidaPos = aWordSel.Min().GetIndex() + nIdx - 1;
+nKashidaPos = aWordSel.Min().GetIndex() + nPrevIdx;
nPriorityLevel = 3;
}
}
@@ -2431,7 +2430,7 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// check if character is connectable to previous
character,
if ( lcl_ConnectToPrev( cCh, cPrevCh ) )
{
-nKashidaPos = aWordSel.Min().GetIndex() + nIdx - 1;
+nKashidaPos = aWordSel.Min().GetIndex() + nPrevIdx;
nPriorityLevel = 4;
}
}
@@ -2453,7 +2452,7 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// check if character is connectable to previous character,
if ( lcl_ConnectToPrev( cCh, cPrevCh ) )
{
-nKashidaPos = aWordSel.Min().GetIndex() + nIdx - 1;
+nKashidaPos = aWordSel.Min().GetIndex() + nPrevIdx;
nPriorityLevel = 5;
}
}
@@ -2469,7 +2468,7 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// check if character is connectable to previous character,
if ( lcl_ConnectToPrev( cCh, cPrevCh ) )
{
-nKashidaPos = aWordSel.Min().GetIndex() + nIdx - 1;
+nKashidaPos = aWordSel.Min().GetIndex() + nPrevIdx;
nPriorityLevel = 6;
}
}
@@ -2478,7 +2477,10 @@ void ImpEditEngine::ImpFindKashidas( ContentNode* pNode,
sal_Int32 nStart, sal_I
// Do not consider vowel marks when checking if a character
// can be connected to previous character.
if ( !isTransparentChar ( cCh) )
+{
cPrevCh = cCh;
+nPrevIdx = nIdx;
+}
++nIdx;
} // end of current word
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 3db6a07600e9..d1e4b967f235 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -1509,10 +1509,9 @@ void SwScriptInfo::InitScriptInfo(const SwTextNode&
rNode,
{
const OUString& rWord = aScanner.GetWord();
-sal_Int32 nIdx = 0;
+
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit3.cxx | 248
1 file changed, 199 insertions(+), 49 deletions(-)
New commits:
commit 640a2bc1cd093875b701bb958b6156d5752c0fac
Author: Khaled Hosny
AuthorDate: Thu Aug 11 14:53:19 2022 +0200
Commit: Caolán McNamara
CommitDate: Sun Aug 14 21:10:43 2022 +0200
tdf#137528: Sync Kashida algorithm in editeng with sw
It seems that editeng is using an old copy of the code in sw and it was
never updated.
With this change, the text in the test document from tdf#137528 looks
essentially identical in both cases.
Fixes also tdf#146199.
Change-Id: I38541bfb35eae36681af84e73a7965d36152448f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138145
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index 9d71560c108b..d712dfa5 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -75,6 +75,8 @@
#include
+#include
+
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::beans;
@@ -254,19 +256,93 @@ static Point lcl_ImplCalcRotatedPos( Point rPos, Point
rOrigin, double nSin, dou
return aTranslatedPos;
}
-static bool lcl_IsLigature( sal_Unicode cCh, sal_Unicode cNextCh ) // For
Kashidas from sw/source/core/text/porlay.txt
+// For Kashidas from sw/source/core/text/porlay.cxx
+
+#define IS_JOINING_GROUP(c, g) ( u_getIntPropertyValue( (c),
UCHAR_JOINING_GROUP ) == U_JG_##g )
+#define isAinChar(c)IS_JOINING_GROUP((c), AIN)
+#define isAlefChar(c) IS_JOINING_GROUP((c), ALEF)
+#define isDalChar(c)IS_JOINING_GROUP((c), DAL)
+#if U_ICU_VERSION_MAJOR_NUM >= 58
+#define isFehChar(c) (IS_JOINING_GROUP((c), FEH) ||
IS_JOINING_GROUP((c), AFRICAN_FEH))
+#else
+#define isFehChar(c)IS_JOINING_GROUP((c), FEH)
+#endif
+#define isGafChar(c)IS_JOINING_GROUP((c), GAF)
+#define isHehChar(c)IS_JOINING_GROUP((c), HEH)
+#define isKafChar(c)IS_JOINING_GROUP((c), KAF)
+#define isLamChar(c)IS_JOINING_GROUP((c), LAM)
+#if U_ICU_VERSION_MAJOR_NUM >= 58
+#define isQafChar(c) (IS_JOINING_GROUP((c), QAF) ||
IS_JOINING_GROUP((c), AFRICAN_QAF))
+#else
+#define isQafChar(c)IS_JOINING_GROUP((c), QAF)
+#endif
+#define isRehChar(c)IS_JOINING_GROUP((c), REH)
+#define isTahChar(c)IS_JOINING_GROUP((c), TAH)
+#define isTehMarbutaChar(c) IS_JOINING_GROUP((c), TEH_MARBUTA)
+#define isWawChar(c)IS_JOINING_GROUP((c), WAW)
+#define isSeenOrSadChar(c) (IS_JOINING_GROUP((c), SAD) ||
IS_JOINING_GROUP((c), SEEN))
+
+// Beh and characters that behave like Beh in medial form.
+static bool isBehChar(sal_Unicode cCh)
+{
+bool bRet = false;
+switch (u_getIntPropertyValue(cCh, UCHAR_JOINING_GROUP))
+{
+case U_JG_BEH:
+case U_JG_NOON:
+#if U_ICU_VERSION_MAJOR_NUM >= 58
+case U_JG_AFRICAN_NOON:
+#endif
+case U_JG_NYA:
+case U_JG_YEH:
+case U_JG_FARSI_YEH:
+case U_JG_BURUSHASKI_YEH_BARREE:
+bRet = true;
+break;
+default:
+bRet = false;
+break;
+}
+
+return bRet;
+}
+
+// Yeh and characters that behave like Yeh in final form.
+static bool isYehChar(sal_Unicode cCh)
+{
+bool bRet = false;
+switch (u_getIntPropertyValue(cCh, UCHAR_JOINING_GROUP))
+{
+case U_JG_YEH:
+case U_JG_FARSI_YEH:
+case U_JG_YEH_BARREE:
+case U_JG_BURUSHASKI_YEH_BARREE:
+case U_JG_YEH_WITH_TAIL:
+bRet = true;
+break;
+default:
+bRet = false;
+break;
+}
+
+return bRet;
+}
+
+static bool isTransparentChar ( sal_Unicode cCh )
+{
+return u_getIntPropertyValue( cCh, UCHAR_JOINING_TYPE ) ==
U_JT_TRANSPARENT;
+}
+
+static bool lcl_IsLigature( sal_Unicode cCh, sal_Unicode cNextCh )
{
// Lam + Alef
-return ( 0x644 == cCh && 0x627 == cNextCh ) ||
-// Beh + Reh
- ( 0x628 == cCh && 0x631 == cNextCh );
+return ( isLamChar ( cCh ) && isAlefChar ( cNextCh ));
}
-static bool lcl_ConnectToPrev( sal_Unicode cCh, sal_Unicode cPrevCh ) // For
Kashidas from sw/source/core/text/porlay.txt
+static bool lcl_ConnectToPrev( sal_Unicode cCh, sal_Unicode cPrevCh )
{
-// Alef, Dal, Thal, Reh, Zain, and Waw do not connect to the left
-bool bRet = 0x627 != cPrevCh && 0x62F != cPrevCh && 0x630 != cPrevCh &&
-0x631 != cPrevCh && 0x632 != cPrevCh && 0x648 != cPrevCh;
+const int32_t nJoiningType = u_getIntPropertyValue( cPrevCh,
UCHAR_JOINING_TYPE );
+bool bRet = nJoiningType != U_JT_RIGHT_JOINING && nJoiningType !=
U_JT_NON_JOINING;
// check for ligatures cPrevChar + cChar
if ( bRet )
@@ -2236,8 +2312,15 @@ void ImpEditEngine::ImpAdjustBlocks( ParaPortion*
pParaPortion, EditLine* pLine,
pLine->SetTextWidth( pLine->GetTextWidth() +
[Libreoffice-commits] core.git: canvas/source drawinglayer/source editeng/inc editeng/source emfio/source include/drawinglayer include/editeng include/vcl sc/source sd/source sfx2/source svgio/source
canvas/source/cairo/cairo_textlayout.cxx |2 canvas/source/directx/dx_textlayout_drawhelper.cxx|1 canvas/source/vcl/textlayout.cxx |1 drawinglayer/source/primitive2d/textbreakuphelper.cxx | 10 + drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx |7 drawinglayer/source/primitive2d/textlayoutdevice.cxx |6 drawinglayer/source/primitive2d/textprimitive2d.cxx | 13 - drawinglayer/source/primitive2d/textstrikeoutprimitive2d.cxx |1 drawinglayer/source/processor2d/vclprocessor2d.cxx|3 drawinglayer/source/tools/emfphelperdata.cxx |4 drawinglayer/source/tools/wmfemfhelper.cxx|7 editeng/inc/editdoc.hxx |4 editeng/source/editeng/editeng.cxx|3 editeng/source/editeng/impedit3.cxx | 33 ++- editeng/source/items/svxfont.cxx | 13 - editeng/source/outliner/outleeng.cxx |5 editeng/source/outliner/outleeng.hxx |3 editeng/source/outliner/outliner.cxx |9 emfio/source/reader/mtftools.cxx |4 include/drawinglayer/primitive2d/textdecoratedprimitive2d.hxx |2 include/drawinglayer/primitive2d/textlayoutdevice.hxx |3 include/drawinglayer/primitive2d/textprimitive2d.hxx |8 include/editeng/editeng.hxx |4 include/editeng/outliner.hxx |7 include/editeng/svxfont.hxx |3 include/vcl/metaact.hxx | 11 - include/vcl/outdev.hxx| 12 - include/vcl/pdfwriter.hxx |1 include/vcl/rendercontext/SalLayoutFlags.hxx |3 sc/source/ui/view/hintwin.cxx |4 sd/source/ui/view/sdview.cxx |1 sfx2/source/control/thumbnailviewitem.cxx |1 svgio/source/svgreader/svgcharacternode.cxx |2 svtools/source/control/ruler.cxx |4 svx/source/diagram/IDiagramHelper.cxx |3 svx/source/svdraw/svdotextdecomposition.cxx | 14 + svx/source/svdraw/svdotextpathdecomposition.cxx |5 svx/source/tbxctrls/StylesPreviewWindow.cxx |3 sw/source/core/inc/scriptinfo.hxx |2 sw/source/core/layout/paintfrm.cxx|1 sw/source/core/text/itradj.cxx|6 sw/source/core/text/porlay.cxx|6 sw/source/core/text/portxt.cxx|2 sw/source/core/txtnode/fntcache.cxx | 32 ++- sw/source/uibase/docvw/HeaderFooterWin.cxx|2 sw/source/uibase/docvw/UnfloatTableButton.cxx |2 vcl/inc/ImplLayoutArgs.hxx|2 vcl/inc/impglyphitem.hxx |4 vcl/inc/pdf/pdfwriter_impl.hxx|2 vcl/inc/sallayout.hxx |2 vcl/qa/cppunit/complextext.cxx| 37 --- vcl/qa/cppunit/svm/svmtest.cxx|2 vcl/qa/cppunit/text.cxx |2 vcl/source/control/imp_listbox.cxx|2 vcl/source/filter/eps/eps.cxx | 12 - vcl/source/filter/svm/SvmConverter.cxx|2 vcl/source/gdi/CommonSalLayout.cxx| 98 +++--- vcl/source/gdi/gdimtf.cxx |4 vcl/source/gdi/impglyphitem.cxx | 25 -- vcl/source/gdi/metaact.cxx| 12 + vcl/source/gdi/pdfwriter.cxx |3 vcl/source/gdi/pdfwriter_impl.cxx |8 vcl/source/gdi/pdfwriter_impl2.cxx|2 vcl/source/gdi/textlayout.cxx |2 vcl/source/outdev/text.cxx| 42 ++-- vcl/source/outdev/transparent.cxx |2 vcl/source/text/ImplLayoutArgs.cxx| 32 +++ vcl/source/window/menuitemlist.cxx|2 vcl/source/window/status.cxx |2 69 files changed, 346 insertions(+), 228 deletions(-) New
